--- Log opened Tue Nov 15 00:00:07 2016
20161115 00:01:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161115 00:04:50-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20161115 00:10:21< gfgtdf> vultraz: online?
20161115 00:12:05< gfgtdf> vultraz: i think https://github.com/wesnoth/wesnoth/commit/41c3e028f1823f5106a55cd6b8082a11e0557363 casues serius perofrmance issues, to reproduce run a 100x100 map from the rnadom map generator, activate shroud in the map settings and try to move a unit in the scenario (ideally one with myna movepoints)
20161115 00:20:11< gfgtdf> also i couldn't realyl see the in increase in detail (tested on 21x21 map compareing 1.13.6 to 1.12.5)
20161115 00:26:09< gfgtdf> s/myna/many
20161115 00:30:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 00:46:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161115 00:53:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Remote host closed the connection]
20161115 01:02:39< celticminstrel> I guess this should be almost ready to push...
20161115 01:29:54< vultraz> gfgtdf: the detail is most apparently for small maps
20161115 01:30:00< vultraz> gfgtdf: and in MP create
20161115 01:31:34< vultraz> gfgtdf: basically, for larger maps, the low quality wasn't noticeable. on small maps, it made the minimaps look like shit.
20161115 01:32:01< vultraz> [07:32:10]	Aginor	hey vultraz, are you going to fix up/revert that commit where you moved the strip-alpha code to something unrelated?
20161115 01:32:03< vultraz> Aginor: ?
20161115 01:32:20< vultraz> Aginor: are you referring to the get_transparent_potion crap?
20161115 01:32:33< celticminstrel> Yes, because it has nothing to do with rectangles.
20161115 01:32:41< celticminstrel> Heh, potion.
20161115 01:32:43 * vultraz mutters darkly
20161115 01:33:27< celticminstrel> Wait, why am I writing po errors to WRN_G.
20161115 01:35:42< vultraz> fine, I'll revert the damn change 
20161115 01:35:44-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161115 01:36:25< vultraz> at some point we should move all the surface stuff to a surface.*pp file or something
20161115 01:36:52< vultraz> because how in hell a general utils file became the domain of a million custom surface manipulation functions is beyond me
20161115 01:37:04< celticminstrel> The utils file could probably be split up, yeah.
20161115 01:37:18< vultraz> i was going to split the color stuff, at least
20161115 01:37:28< vultraz> (at least, I have the change locally)
20161115 01:37:34< vultraz> but i suppose i need to check with Aginor 
20161115 01:38:05< vultraz> Aginor: can i split the SDL_Color stuff out of utils.*pp?
20161115 01:38:07 * celticminstrel wonders whether [[]] goes before or after static.
20161115 01:38:21< celticminstrel> I suppose I'll find out.
20161115 01:38:39< celticminstrel> BTW vultraz, did you get the memo on investigating appveyor so we can have continuous integration for Windows too?
20161115 01:38:50-!- irker217 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161115 01:38:50< irker217> wesnoth: Charles Dang wesnoth:master aa67217f1c9f / src/ (display.cpp sdl/rect.cpp sdl/rect.hpp sdl/utils.cpp sdl/utils.hpp): Revert "Moved get_non_transparent_portion to the more appropriate file" https://github.com/wesnoth/wesnoth/commit/aa67217f1c9fb4659dc6be04229478868423aa99
20161115 01:38:52< vultraz> .......what?
20161115 01:39:00< celticminstrel> It's like Travis, but for Windows.
20161115 01:39:14< vultraz> I heard nothing about this
20161115 01:39:16< vultraz> Go ask someone else
20161115 01:39:19< celticminstrel> So basically it'd fail if you push something that breaks the MSVC build.
20161115 01:39:26< vultraz> I'm too busy as it is.
20161115 01:39:34< celticminstrel> tad_carlucci brought it up and I think Jyrki also approved.
20161115 01:39:44< celticminstrel> I think tad_carlucci said he'd investigate eventually, too.
20161115 01:39:48< vultraz> then ask one of them to do it!
20161115 01:39:59< tad_carlucci> huh?
20161115 01:40:10< celticminstrel> So I assume that means you don't mind.
20161115 01:40:46< vultraz> well I think I already broke the msvc 2013 build a while back
20161115 01:40:54< celticminstrel> Huh?
20161115 01:41:38< vultraz> https://github.com/wesnoth/wesnoth/commit/b70200c8f5ce2c73d445fcaea269d198f6af834b
20161115 01:42:05< vultraz> no one complained, so I assumed no one built with 2013 since then 
20161115 01:42:30< celticminstrel> Not sure, but CONSTEXPR might expand to "const" on MSVC 2013...
20161115 01:43:03< celticminstrel> But anyway, why do you think that broke the MSVC 2013 build?
20161115 01:43:16< vultraz> jyrki said it might
20161115 01:43:20< celticminstrel> Oh.
20161115 01:43:26< vultraz> ODO violation or something 
20161115 01:43:33< celticminstrel> ODR
20161115 01:43:40< celticminstrel> Well, I'm building it now since you mentioned it.
20161115 01:43:45< celticminstrel> (That's One Definition Rule.)
20161115 01:44:03< celticminstrel> Yeah, now that you mention it, that would be a ODR violation without constexpr.
20161115 01:44:08< celticminstrel> Probably fixable by adding static.
20161115 01:45:15< tad_carlucci> I was thinking what I'd do is check I can do a Makefile build on my VS 2015 system then set up an account and try using the CI system. Once I got a good build I'd then do a PR with instructions for someone with access to finish up with the notifications to IRC, etc.
20161115 01:45:33< celticminstrel> Sounds good to me.
20161115 01:45:59< celticminstrel> I assume that means MS's make, not GNU make.
20161115 01:46:08< celticminstrel> (Might be called nmake.)
20161115 01:48:23< tad_carlucci> yes I mean MS's sorta-posix suprise-not-posix make system
20161115 01:48:40< celticminstrel> Is it sorta-POSIX?
20161115 01:49:01< celticminstrel> I just thought of it as an unrelated program that happens to use similar syntax.
20161115 01:49:10< tad_carlucci> when last I looked it was able to do simple posix-y builds. haven't looked in a long time
20161115 01:50:28< tad_carlucci> anyway it lurks beneath "Rebuild project" on the GUI and it's what that CI system needs. Docs indicate is should "just work" but I'm thinking that's for pretty plain MS builds and not using SDL, Boost, etc.
20161115 01:50:48< tad_carlucci> But it should be do-able. Just need to figure it out.
20161115 01:51:38< celticminstrel> Assuming you have the dependencies installed in the location where the project expects them to be (ie "../external"), I think it should be as simple as calling "msbuild projectfiles/VC12/Wesnoth.sln".
20161115 01:52:11< Aginor> vultraz: I'd suggest making a colour class that we use, which can translate itself into sdl and pango colours. Instead of passing uint32_ts around that may or may not be RGB888 or ARGB8888 or RGBA8888
20161115 01:52:15< celticminstrel> The question then is whether you can easily install the dependencies in that location.
20161115 01:52:18< tad_carlucci> That's about the size of it. The question is the stuff one doesn't expect like can I checkout TWO git repos
20161115 01:52:35< Aginor> that class can then contain the colour functionality we need
20161115 01:52:35< celticminstrel> Aginor: Yeah, I really think we should try to drop the use of unit32_t as a colour too.
20161115 01:52:55< Aginor> it's a mess and gives me a headache to try to figure out which part of the code uses what colour format
20161115 01:53:12< tad_carlucci> Aginor, and a size typo which isn't size_t would be good too. there's a lot of that lurking in the codebase.
20161115 01:53:33< celticminstrel> I don't really think that's necessary.
20161115 01:53:35< tad_carlucci> s/typo/type/ or maybe not
20161115 01:53:42< Aginor> I'd expend more on it, but I don't have time now
20161115 01:53:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has joined #wesnoth-dev
20161115 01:53:47< Aginor> expand even
20161115 01:53:55< Aginor> but I don't think we should do those changes before 1.14
20161115 01:54:03 * tad_carlucci nods.
20161115 01:54:17< celticminstrel> Oh right.
20161115 01:54:26< vultraz> oh, of course..
20161115 01:54:30< celticminstrel> We need to vastly cut down on refactors now.
20161115 01:54:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 01:55:02< tad_carlucci> I'd propose that 1.15 or whatever we call the next big dev cycle come not-to-far-off and refactoring cleaning be a major concept for it.
20161115 01:57:57< tad_carlucci> I've been looking at smart_list and keep hittting the wall of someone else looking at something or other's internal state and having to remind myself to stay focused on just cleaning the reach-arounds for smart_list. Everywhere I look I see implementation details made public so someone can whack something which should have been a method or separate class or anything other than just reaching in an whacking a valie
20161115 01:58:16< gfgtdf> vultraz: you hvae a plan about what to do n the minimap issue ?
20161115 01:58:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Ping timeout: 245 seconds]
20161115 01:58:38< vultraz> gfgtdf: no
20161115 01:59:05< celticminstrel> I thought this was almost ready, but it still won't work for some reason...
20161115 01:59:08< gfgtdf> vultraz: i think we shoudl make scale depndnt on the map size, for bug map the current map size is just too slow.
20161115 01:59:25< vultraz> why does everyone get these issues except me..
20161115 01:59:35< gfgtdf> vultraz: actuall for very lage maps even the epreivousl of 8 was too slow
20161115 01:59:55< gfgtdf> vultraz: a better solution woudl ofc be to improve the peroformance of scale_surface_sharp
20161115 02:00:12< vultraz> look, we can't do that until we get hw acceleration
20161115 02:00:29< celticminstrel> That's not a given.
20161115 02:00:37< gfgtdf> vultraz: do you know the implementation of scale_surface_sharp in detail?
20161115 02:00:46< vultraz> no i do not
20161115 02:00:50< celticminstrel> It might be possible to improve performance without hardware acceleration.
20161115 02:02:12-!- horrowind [~Icedove@ip5f5ad79b.dynamic.kabel-deutschland.de] has quit [Quit: horrowind]
20161115 02:10:50-!- gfgtdf_ [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 02:13:40-!- gfgtdf [~chatzilla@x4e363b31.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161115 02:13:44-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161115 02:13:44-!- gfgtdf_ is now known as gfgtdf
20161115 02:16:02-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161115 02:20:11-!- Bonobo [~Bonobo@2001:44b8:254:3200:c5a7:736:307:9c2] has quit [Quit: Leaving]
20161115 02:23:50-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161115 02:24:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20161115 02:24:25-!- wedge010 is now known as wedge009
20161115 02:34:29< celticminstrel> vultraz: I didn't get any errors in MSVC 2013.
20161115 02:34:53< celticminstrel> Maybe because const globals are implicitly static, if I recall correctly.
20161115 02:44:42< tad_carlucci> celticminstrel, appveyor uses msbuild. I'm looking into that now.
20161115 02:50:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:4f1:b91d:4356:723d] has joined #wesnoth-dev
20161115 02:55:45< celticminstrel> I wonder whether the French translation is France or Quebec.
20161115 02:59:15-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161115 02:59:15-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161115 02:59:15-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 02:59:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 244 seconds]
20161115 02:59:35-!- noy_ is now known as noy
20161115 03:05:05< vultraz> france, I assume
20161115 03:06:45< celticminstrel> I keep hearing that most French translations are fr_CA, but I have no idea how true that is. (And that wouldn't apply to something like Wesnoth anyway, probably.)
20161115 03:07:18< vultraz> i wonder if some of our minimap problems come from the fact that they are literal mini maps
20161115 03:07:43< vultraz> ie, transitionless base hexes rendered and scaled down before being composited into the map.
20161115 03:08:00< vultraz> (well, maybe not rendered first)
20161115 03:08:35< celticminstrel> I have no idea what you're saying.
20161115 03:10:47< vultraz> in order to construct the minimap, the terrain icon of every hex is loaded, scaled down to a size (right now 24x24), before being combined on a single surface which is then scaled to fit the minimap viewer size.
20161115 03:11:34< celticminstrel> That seems reasonable.
20161115 03:12:04< vultraz> it seems inefficient in my mind
20161115 03:13:05< celticminstrel> I don't see how you could get it much better.
20161115 03:17:06< celticminstrel> Oh hey. I switch to GDB and suddenly all my breakpoints work.
20161115 03:17:36< celticminstrel> Oh, apparently my locale is en_CA. Interesting.
20161115 03:18:20< celticminstrel> Seems like the locale is being regenerated a lot during startup.
20161115 03:19:19< celticminstrel> Switching language to French apparently chooses fr_FR. I have no idea whether that means anything though.
20161115 03:22:27< tad_carlucci> What is the status having Travis-CI checking OS/x?
20161115 03:33:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161115 03:45:16-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161115 03:55:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has joined #wesnoth-dev
20161115 03:57:59< celticminstrel> tad_carlucci: It's working so far.
20161115 03:58:14< celticminstrel> But I had to make it not run the tests to get there.
20161115 03:58:23< celticminstrel> And exclude vorbis from dependencies just for Travis.
20161115 03:58:23< vultraz> tad_carlucci: i have something else for your TODO List Of Stuff To Eventually But Probably In 1.15 Refactor Out: https://github.com/wesnoth/wesnoth/blob/master/src/utils/iterator.hpp
20161115 03:59:18< vultraz> (for some reason JaMiT seems to have liked to create these weird custom util classes)
20161115 03:59:32< celticminstrel> Sounds a lot like boost::iterator_adaptor (if I recall the name correctly)
20161115 03:59:51< vultraz> oh?
20161115 04:00:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Ping timeout: 258 seconds]
20161115 04:00:08< vultraz> well if it exists in boost all the better
20161115 04:01:15< tad_carlucci> I'd have to look at where it's used. I have a feeling it's another case of something was not well done elsewhere and rather than fix the real issue someone slapped in a workaround.
20161115 04:01:37< vultraz> it's something else used only in 1 place
20161115 04:01:49< vultraz> the menu items manager 
20161115 04:01:50< tad_carlucci> Which tends to the idea its a workaround.
20161115 04:02:01< vultraz> which is thankfully less intrusive
20161115 04:02:15< celticminstrel> For the record, iterator_extend is only used by wmi_container.
20161115 04:02:26< vultraz> that's what I just said
20161115 04:02:30< vultraz> :|
20161115 04:02:36< celticminstrel> I don't know if it's the same as iterator_adaptor; just noting that, at a glance, it seems to be similar in concept.
20161115 04:02:52< tad_carlucci> celticminstrel, I'm looking at Travis running on one of my PRs and wondering what changed that the "allowed failure" build is passing
20161115 04:02:56< vultraz> anyway, file is src/game_events/wmi_container.hpp
20161115 04:03:12< celticminstrel> Yeah sorry, I commented before finishing reading everything.
20161115 04:03:14< tad_carlucci> Oh .. there.
20161115 04:03:23< celticminstrel> tad_carlucci: I think vultraz had a theory on that, but I really have no idea.
20161115 04:03:50< vultraz> tad_carlucci: it magically started passing when celticminstrel changed the dependency fetch flow
20161115 04:03:52< vultraz> or something
20161115 04:03:58< vultraz> he did some moving of stuff around
20161115 04:04:16< vultraz> either that, or their repos updated to boost >= 1.58 or something
20161115 04:04:16< celticminstrel> Oh right, he thinks that somehow I fixed it by moving the installation of dependencies into a separate shell-script.
20161115 04:04:20< celticminstrel> Which doesn't really make sense to me.
20161115 04:04:27< celticminstrel> Yeah, that was what I was wondering too.
20161115 04:04:34< tad_carlucci> wmi_container .. that's one of the places where I run into when I'm tracking down the end-runs making smart_list necessary. Betcha its the same end-run.
20161115 04:05:09< tad_carlucci> There is so much of that. Some implementation detail is made public so something else can whack it instead of asking nicely.
20161115 04:05:51< vultraz> blame JaMiT
20161115 04:05:57< vultraz> both of these are his work
20161115 04:06:05< celticminstrel> Please don't blame people.
20161115 04:06:35< vultraz> I don't understand why he felt it necessary to write whole utility classes and custom containers just to get around some issue :/
20161115 04:06:57< tad_carlucci> We have .. I think .. at least 4, maybe 5 or even 6, ways to access a game event handler. All boil down to, somehow, getting a reference to the config tree enclosed by [event].
20161115 04:07:10< celticminstrel> Huh, wow.
20161115 04:07:20< vultraz> :|
20161115 04:07:23< vultraz> jesus 
20161115 04:07:26< pydsigner> Need moar!
20161115 04:07:29< celticminstrel> Urgh, GDB won't show me my strings.
20161115 04:07:43< tad_carlucci> we got lists, vectors, pointers, pointers to shared pointers, pointers to weak pointers ...
20161115 04:08:09< tad_carlucci> Oh and I forgot just remembering the original reference.
20161115 04:08:19< celticminstrel> And now I broke GDB and it refuses to continue. :|
20161115 04:08:30< vultraz> #JustWesnothCodeThings
20161115 04:08:35< celticminstrel> Better than crashing XCode though as lldb occasionally does.
20161115 04:11:55< gfgtdf> tad_carlucci: if you are currnelt wokring on it, know  that there is a known bug in 1.13 related to wml handlers of menu items: https://gna.org/bugs/?23545
20161115 04:12:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161115 04:12:09< tad_carlucci> I'm having to rerun my test of msbuild. I forgot and told it to use VC12 when I have the 'extern' for VC14 checked out. So, it failed linking. Anyway, looks good for building on Appveyor so I'm hitting the books seeing if I can checkout 'extern' (probably can) and put it in the expected place so msbuild 'just works'
20161115 04:13:07-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161115 04:13:20< tad_carlucci> gfgtdf, I'll look at it but so far all I'm finding is stuff which is too major this close to 1.14 and am recommending waiting until we re-open 'dev' when we're happy with 'stable'
20161115 04:13:38< celticminstrel> Maybe I should just gdb this from the command-line... :|
20161115 04:13:47< vultraz> again, I'm not sure we're exactly at that point yet
20161115 04:13:54< celticminstrel> Because XCode's UI is being useless.
20161115 04:14:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 04:14:52< celticminstrel> Or maybe I should just sprinkly DBG_G lines through the code.
20161115 04:15:02< tad_carlucci> gfgtdf, And, yes, that sure sounds like it's in the same area as these special collections and custom iterators
20161115 04:15:06< vultraz> as was said on facebook, better to push back a release than rush it broken for a due date
20161115 04:15:15< vultraz> so im thinking, we might push back 1.14 furtehr
20161115 04:15:20< vultraz> further
20161115 04:15:44< tad_carlucci> celticminstrel, I gave up on my UIs using gdb long ago and stick to command-line now, too.
20161115 04:15:58< vultraz> so we still have *some* time for large changes
20161115 04:15:59< celticminstrel> MSVC is actually pretty good at it though.
20161115 04:16:25< celticminstrel> It even manages to notify me when I step through part of a line in code compiled with clang.
20161115 04:16:30< vultraz> but ill leave it to tad_carlucci to decide how intrusive of a change he wants to do
20161115 04:18:16< tad_carlucci> I prefer non-intrusive as much as possible. But do we REALLY want to run the risk of subtly breaking [event]?
20161115 04:18:48< vultraz> unit tests, we need!
20161115 04:18:52< celticminstrel> So if I do "run --data-dir=." in GDB it should take the CWD for the data dir, right?
20161115 04:19:58< tad_carlucci> I believe so. But isnt' that the default?
20161115 04:20:22< tad_carlucci> Or --data-dir=data maybe
20161115 04:20:36< celticminstrel> No, the default is to auto-detect relative to the executable path.
20161115 04:20:51< celticminstrel> Which is buried under ~/Library/Application Support/Developer/XCode
20161115 04:24:33< tad_carlucci> Wow. Closing VS and running msbuild seems like an order of magnitude faster than using the UI "Build All" even if I include the abominable wait to restart VS
20161115 04:24:43< celticminstrel> I accidentally set a breakpoint. How do I make sure it's gone.
20161115 04:24:54< celticminstrel> I did "delete 1" but there was no output so I have no idea if it did anything.
20161115 04:25:18< tad_carlucci> And Ouch. Note to self: Self, when running msbuild it runs tests automagically .. be sure to set the path BEFORE you start!
20161115 04:25:29< celticminstrel> I don't see a "list breakpoints" command in the help output.
20161115 04:25:35< tad_carlucci> 160 clicks on OK to get past 160 failed attempts to find SDL2.dll
20161115 04:27:37< shadowm> tad_carlucci: Why do PR #871 and #874 have both the exact same description and title?
20161115 04:28:12< tad_carlucci> shadowm, Dunno. I had a problem with one a few hours ago. Probably messed somethign up
20161115 04:29:46< tad_carlucci> shadowm, Oh. I closed 871 and put up something else. Changed my mind and closed that and put it back up as 874.
20161115 04:30:15< shadowm> You didn't have the option to reopen #871?
20161115 04:30:57< tad_carlucci> shadowm, didn't know that was possible.
20161115 04:32:36 * celticminstrel gives up.
20161115 04:32:43< celticminstrel> Sprinkling logging lines it is, then.
20161115 04:33:02< tad_carlucci> Ah yes. Often far easier than using a debugger, anyway.
20161115 04:40:31-!- irker217 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161115 04:42:05-!- Aginor [~andreas@unaffiliated/aginor] has left #wesnoth-dev []
20161115 04:49:25-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 04:51:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20161115 04:51:37-!- noy_ is now known as noy
20161115 04:56:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has joined #wesnoth-dev
20161115 05:00:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20161115 05:00:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Ping timeout: 258 seconds]
20161115 05:01:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 05:03:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161115 05:04:10-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has quit [Remote host closed the connection]
20161115 05:22:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 05:26:54-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161115 05:26:54-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161115 05:26:54-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 05:28:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 252 seconds]
20161115 05:28:44-!- noy_ is now known as noy
20161115 05:31:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161115 05:41:08< celticminstrel> .........
20161115 05:42:22< celticminstrel> Okay, so I have no idea what is going on with this thing...
20161115 05:42:40< celticminstrel> Though I think passing --data-dir in the first place might be part of the problem.
20161115 05:44:42< celticminstrel> That doesn't explain why the translations fail to work when the mo files are not in the package, but... it might explain why the po files are not found in the package.
20161115 05:45:48< celticminstrel> And I still have no idea why the breakpoints refuse to function in XCode.
20161115 05:46:20< celticminstrel> lldb on command-line is taking forever to set a breakpoint...
20161115 05:47:11< celticminstrel> Hopefully just swap issues...
20161115 05:49:14< celticminstrel> Yeah, looks like it worked.
20161115 05:57:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has joined #wesnoth-dev
20161115 06:01:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Ping timeout: 258 seconds]
20161115 06:04:59-!- Appleman1234_ [~Appleman1@KD106161202162.au-net.ne.jp] has joined #wesnoth-dev
20161115 06:06:31-!- Appleman1234 [~Appleman1@KD106161211153.au-net.ne.jp] has quit [Disconnected by services]
20161115 06:06:35-!- Appleman1234_ is now known as Appleman1234
20161115 06:08:32< celticminstrel> Okay, so stream.bad() and stream.fail() both return true.
20161115 06:09:05< celticminstrel> ...
20161115 06:09:08< vultraz> ah, spiritpo
20161115 06:09:48< celticminstrel> The error is "No such file or directory".
20161115 06:10:26< celticminstrel> Even though the file's existence was tested beforehand, and the error occurred sometime after open().
20161115 06:10:35< celticminstrel> How does that even work.
20161115 06:14:46< celticminstrel> Still, this is progress. At least I now know that it's correctly resolving the path to the po files.
20161115 06:18:44 * celticminstrel isn't sure if this one line will compile on MSVC.
20161115 06:19:14< celticminstrel> I suppose the chance it doesn't is slim...
20161115 06:26:28< celticminstrel> vultraz: I think perhaps "team index refactor" should also be left for later.
20161115 06:26:43< celticminstrel> It'll probably need to be redone entirely by then, as well.
20161115 06:26:58< celticminstrel> So we could delete that branch from github for the time being.
20161115 06:28:10< celticminstrel> As for the menu refactoring, it might turn out to be quite a bit easier if it's done as part moving the game UI to GUI2, so I think I'd prefer to drop that one as well.
20161115 06:28:46< celticminstrel> vultraz: On another note, do you think I should add bitmath operators to WFL?
20161115 06:28:58< vultraz> i see no reason to
20161115 06:29:05< vultraz> but if you want, sure
20161115 06:29:18< celticminstrel> No strong reason, but since we upgraded to Lua 5.3 which added them. *shrug*
20161115 06:29:32< celticminstrel> Though I'm not sure what I'll do for XOR.
20161115 06:29:50< celticminstrel> Since I already used ~ for ranges, and ^ is exponentiation (as in Lua).
20161115 06:31:55< tad_carlucci> Oh, nice. I can have it check VC14 using the VS12 project files.
20161115 06:32:09< celticminstrel> Nice indeed.
20161115 06:32:53< tad_carlucci> I _think_ I have it set up. It would go faster if it didn't take so bloomin' long to clone master
20161115 06:33:09< celticminstrel> --depth=50?
20161115 06:33:17< celticminstrel> I think that's what Travis does by default.
20161115 06:33:38< celticminstrel> Restarting XCode seems to have fixed the breakpoint woes.
20161115 06:34:07< tad_carlucci> Ah. Of course.
20161115 06:34:32< celticminstrel> To the depth or the restart.
20161115 06:38:11< celticminstrel> Ah. Hm. Maybe I shouldn't request exceptions on failbit. Looks like it may be set at eof as well, sometimes.
20161115 06:39:35 * celticminstrel wonders why the __cxa_begin_catch code appears to contain a conditional call to std::terminate.
20161115 06:40:49-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161115 06:56:49< celticminstrel> It works!
20161115 06:57:03< celticminstrel> Okay, I'm going to push it.
20161115 06:57:07< celticminstrel> Then comment on the PR.
20161115 06:57:15< celticminstrel> And touch it up tomorrow.
20161115 06:57:35< celticminstrel> The loading screen messages are untranslated for some reason...
20161115 06:57:40< celticminstrel> ...
20161115 06:57:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has joined #wesnoth-dev
20161115 06:58:22< celticminstrel> Sudden segfault... while outputting log message... :|
20161115 06:58:29< celticminstrel> Hope it's a fluke...
20161115 06:59:34< celticminstrel> Well, I'll push anyway.
20161115 06:59:48< celticminstrel> Hopefully it won't happen when the log messages are disabled.
20161115 07:01:24-!- irker465 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161115 07:01:24< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po 7bdcc425b1d2 / src/ (10 files in 2 dirs): Add new translation library https://github.com/wesnoth/wesnoth/commit/7bdcc425b1d2b955c0b9da9cdcde13786673ab8a
20161115 07:01:24< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po da876af4ee16 / CMakeLists.txt SConstruct src/CMakeLists.txt src/gettext.cpp: Remove option to link libintl instead of Boost.Locale https://github.com/wesnoth/wesnoth/commit/da876af4ee1612ba5bd5eeb92637e762853f07d4
20161115 07:01:24< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po 015fc96d890c / src/gettext_boost.cpp: This namespace alias is defined, so might as well use it https://github.com/wesnoth/wesnoth/commit/015fc96d890c8cc72d5a0205eab45294b7dc153f
20161115 07:01:25< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po d007803b9870 / / (5 files in 4 dirs): fixup! Remove option to link libintl instead of Boost.Locale https://github.com/wesnoth/wesnoth/commit/d007803b987056cda753ade30e04e18c2510a70c
20161115 07:01:26< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po 9c8759dca8ec / src/ (filesystem_boost.cpp wesnoth.cpp): Normalize data and userdata paths https://github.com/wesnoth/wesnoth/commit/9c8759dca8ec5ee30138e66c7a8cc5d72a0f6374
20161115 07:01:27< irker465> wesnoth: Celtic Minstrel wesnoth:spirit_po c64935f94be4 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj src/gettext_boost.cpp: Enable loading of po files in addons https://github.com/wesnoth/wesnoth/commit/c64935f94be4057b5ab75781a0f3c662cb6246a9
20161115 07:02:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:883d:5856:51cf:b942] has quit [Ping timeout: 258 seconds]
20161115 07:09:27< tad_carlucci> did you remember to rm gettext.cpp?
20161115 07:27:48< celticminstrel> Well, it doesn't exist in my copy, so I assume so.
20161115 07:29:13-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Quit: WeeChat 1.4]
20161115 07:35:16< tad_carlucci> I see src/gettext.cpp on master but not on your spirit_po branch so I guess you did that a while ago.
20161115 07:37:13< tad_carlucci> BTW I'm up to getting the windows 'external' stuff put into the proper place. Once I get that I should be building on AppVeyor. So I'll then do some work to see about checking both Visual Studio 2013 and 2015, tracking branches and pull requests and other nice stuff.
20161115 07:37:40-!- atarocch [~atarocch@31.157.55.121] has joined #wesnoth-dev
20161115 07:41:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161115 07:44:31-!- Bonobo [~Bonobo@2001:44b8:254:3200:4f1:b91d:4356:723d] has quit [Quit: Leaving]
20161115 07:44:55-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20161115 07:48:47< tad_carlucci> YEAH!
20161115 07:55:58< vultraz> ?
20161115 07:57:43-!- travis-ci [~travis-ci@ec2-54-146-4-139.compute-1.amazonaws.com] has joined #wesnoth-dev
20161115 07:57:44< travis-ci> wesnoth/wesnoth#12068 (spirit_po - c64935f : Celtic Minstrel): The build has errored.
20161115 07:57:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175963783
20161115 07:57:44-!- travis-ci [~travis-ci@ec2-54-146-4-139.compute-1.amazonaws.com] has left #wesnoth-dev []
20161115 07:57:47< tad_carlucci> AppVeyor is compiling away. 400 files in and no errors, no warnings. It will probably link. "Release" target runs unit tests. I forgot (sheesh, again) to set PATH so those will probably file.
20161115 07:57:53< tad_carlucci> fail
20161115 08:00:34< tad_carlucci> I wonder if I should take it all the way to building a windows installer package. Probably should. We could do that only when a tag appears and I could ship the artifact off someplace ... something to think about
20161115 08:09:18< tad_carlucci> Good. Yes, I forgot to set the path. But it compiles and links with no issues. So I'm for bed. I'll work on it more tomorrow.
20161115 08:09:27-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161115 08:13:17-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161115 08:28:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161115 08:43:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161115 08:50:13-!- boucman_work [~boucman@230.204.154.77.rev.sfr.net] has joined #wesnoth-dev
20161115 09:10:53-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 256 seconds]
20161115 09:11:57-!- irker465 [~irker@uruz.ai0867.net] has quit [Ping timeout: 246 seconds]
20161115 09:21:21-!- boucman_work1 [~boucman@177.16.90.92.rev.sfr.net] has joined #wesnoth-dev
20161115 09:22:04-!- boucman_work [~boucman@230.204.154.77.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20161115 09:29:55-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161115 09:36:55-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20161115 09:45:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161115 09:46:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161115 09:48:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 09:54:09-!- atarocch [~atarocch@31.157.55.121] has quit [Ping timeout: 260 seconds]
20161115 10:04:18-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161115 10:08:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161115 10:09:04-!- atarocch [~atarocch@2.43.49.12] has joined #wesnoth-dev
20161115 10:49:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161115 11:11:26-!- boucman_work1 [~boucman@177.16.90.92.rev.sfr.net] has quit [Ping timeout: 244 seconds]
20161115 11:12:02-!- boucman_work [~boucman@177.16.90.92.rev.sfr.net] has joined #wesnoth-dev
20161115 11:23:41-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161115 11:42:03-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161115 11:50:52< zookeeper> vultraz, gfgtdf, why is there even a static scaling factor there instead of it dynamically adjusting to the minimap dimensions and map size?
20161115 11:51:31-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161115 11:54:31-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 11:55:04< zookeeper> i presume the number denotes the max pixel dimensions of the surface used to draw a particular terrain? so scale=8 means that if you have a really tiny map, then a terrain image is its icon scaled down to 8x8 and then scaled to fit however many pixels a hex takes on the minimap?
20161115 11:55:27< gfgtdf> vultraz: are the improvements of th eminimap commit also visible if you us the 'tactical terrain' minimap mode? ('toggle minimap terrain drawing')
20161115 11:56:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit []
20161115 11:57:47-!- irker467 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161115 11:57:47< irker467> wesnoth: gfgtdf wesnoth:master 5e0d39c3b6b6 / src/minimap.cpp: improve minimap performance for alterntive terrain drawing https://github.com/wesnoth/wesnoth/commit/5e0d39c3b6b6ec6830396c6b0b3d4f58d2cb9c02
20161115 12:03:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5d56:e6f5:dc6e:d65] has joined #wesnoth-dev
20161115 12:06:16< irker467> wesnoth: gfgtdf wesnoth:master 08418761273b / src/minimap.cpp: fixup 5e0d39c3b6b https://github.com/wesnoth/wesnoth/commit/08418761273b0b87186465f56b22178131b26f2f
20161115 12:08:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5d56:e6f5:dc6e:d65] has quit [Ping timeout: 258 seconds]
20161115 12:36:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161115 12:47:20-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has joined #wesnoth-dev
20161115 12:48:31-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has quit [Client Quit]
20161115 12:52:55-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has joined #wesnoth-dev
20161115 12:53:10-!- travis-ci [~travis-ci@ec2-54-92-163-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20161115 12:53:11< travis-ci> wesnoth/wesnoth#12071 (master - 5e0d39c : gfgtdf): The build was broken.
20161115 12:53:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/176027630
20161115 12:53:11-!- travis-ci [~travis-ci@ec2-54-92-163-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20161115 12:53:36-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has quit [Client Quit]
20161115 12:58:32-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161115 12:59:43< zookeeper> good grief, why does my perfectly normal cerr output from preprocessor code suddenly _only_ output stuff about GUI macros...
20161115 13:14:51-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161115 13:22:47-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161115 13:23:23< zookeeper> it was some weird kind of cache issue apparently? as soon as i entered a syntax error in a .cfg file, the output went back to normal and included all kinds of macros and not just GUI macros.
20161115 13:23:27 * zookeeper shrugs
20161115 13:23:32< zookeeper> black magic as usual
20161115 13:29:31< Soliton> perhaps GUI WML is not cached.
20161115 13:37:43< zookeeper> right, that's a thought
20161115 13:54:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 268 seconds]
20161115 13:59:21< vultraz> zookeeper: progress on this? https://github.com/wesnoth/wesnoth/pull/743
20161115 14:02:43-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161115 14:20:41< zookeeper> vultraz, nope
20161115 14:21:59< vultraz>  did someone change the tree view node size calculation..
20161115 14:22:32< vultraz> ah, I see the problem
20161115 14:22:41< vultraz> it was *my* change that's the issue :|
20161115 14:22:43< vultraz> fuck
20161115 14:23:48-!- Appleman1234 [~Appleman1@KD106161202162.au-net.ne.jp] has quit [Ping timeout: 245 seconds]
20161115 14:25:40< vultraz> not... sure what to do about this
20161115 14:26:13< vultraz> (issue is that if the unfolded node size is greater than the visible area due to nodes created in pre show there's no scollbar)
20161115 14:36:28-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161115 14:40:35-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161115 14:48:58-!- Appleman1234 [~Appleman1@KD106161202162.au-net.ne.jp] has joined #wesnoth-dev
20161115 14:49:21-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161115 14:50:06-!- JyrkiVesterinen_ [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161115 14:50:22-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Ping timeout: 265 seconds]
20161115 14:50:31-!- JyrkiVesterinen_ is now known as JyrkiVesterinen
20161115 14:52:54-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161115 14:54:18< irker467> wesnoth: Charles Dang wesnoth:master ab1244e7c5ed / src/gui/dialogs/multiplayer/faction_select.cpp: Faction Select: disable Random gender if option not available https://github.com/wesnoth/wesnoth/commit/ab1244e7c5ede6856497f950f5ee4a0ffc02e4cb
20161115 15:04:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20161115 15:06:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161115 15:16:43-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 15:27:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:30e5:3cbd:6dcd:dda] has joined #wesnoth-dev
20161115 15:31:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:30e5:3cbd:6dcd:dda] has quit [Ping timeout: 245 seconds]
20161115 15:34:15-!- boucman_work [~boucman@177.16.90.92.rev.sfr.net] has quit [Ping timeout: 258 seconds]
20161115 15:35:06-!- boucman_work [~boucman@177.16.90.92.rev.sfr.net] has joined #wesnoth-dev
20161115 16:01:44-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161115 16:04:06< Shiki> ^ sth is strange about that commit vultraz 
20161115 16:07:01< Shiki> let's say I choose an elf witch as leader and klick on female... change then the leader to a red mage ... to an elf fighter - then male is selected, because there's no female....if i choose then a red mage, still male is selected.. But if i choose another unit with more genders afterwards, it's everytime female.
20161115 16:07:29< Shiki> why does this change AFTER the red mage was selected as male ?
20161115 16:07:40< Shiki> ^*automatically selected
20161115 16:08:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161115 16:26:40-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161115 16:27:31-!- atarocch [~atarocch@2.43.49.12] has quit [Ping timeout: 265 seconds]
20161115 16:28:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161115 16:28:24-!- wedge010 is now known as wedge009
20161115 16:41:57-!- atarocch [~atarocch@2.43.49.12] has joined #wesnoth-dev
20161115 16:42:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 245 seconds]
20161115 16:43:46-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161115 16:47:06 * celticminstrel thinks it doesn't make much sense to make an "improve performance of xyz" commit on github. How do you even know it's true.
20161115 16:47:20-!- atarocch [~atarocch@2.43.49.12] has quit [Ping timeout: 260 seconds]
20161115 17:06:01< shadowm> vultraz, zookeeper: Why has https://github.com/wesnoth/wesnoth/pull/743 been frozen for over 3 months?
20161115 17:07:06< celticminstrel> Funny, I was just wondering what was up with that PR too.
20161115 17:08:05< vultraz> Shiki: there's still a known bug with the gender selection in the faction dialog
20161115 17:08:10< vultraz> Shiki: i'll get to it
20161115 17:10:54 * celticminstrel wonders what happened to Elvish_Hunter 
20161115 17:13:23< Shiki> vultraz, okay, thought it was a new one
20161115 17:13:27< celticminstrel> vultraz: Would you object to the test button if it was based on an advanced pref instead of --debug?
20161115 17:14:09< vultraz> celticminstrel: no, that would be acceptable.
20161115 17:14:20-!- boucman_work [~boucman@177.16.90.92.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20161115 17:15:40< vultraz> though i have been reconsidering my stance on debug
20161115 17:17:25-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 17:17:28< celticminstrel> Oh?
20161115 17:17:54< vultraz> perhaps it would be acceptable in debug mode if the button were not with the main ones in the right-side panel
20161115 17:17:58< zookeeper> shadowm, because i haven't taken the time off to finish it
20161115 17:18:07< zookeeper> mostly because it's not urgent in any way
20161115 17:18:13< vultraz> but down to the left with the info button/version string
20161115 17:19:39< vultraz> since that was one of my main objections
20161115 17:19:48< vultraz> that the button would be too intrusive too easily
20161115 17:20:10< vultraz> but if it were not in the right panel, then it'd be... more acceptable.
20161115 17:20:44< vultraz> i still think a proper debug console is the proper way to launch the tests, but barring that, a less-intrusive button in debug mode would be acceptable.
20161115 17:20:48< celticminstrel> vultraz: So where else would it be then?
20161115 17:20:56< vultraz> [04:18:12]	vultraz	but down to the left with the info button/version string
20161115 17:21:06< celticminstrel> Hm, I suppose that's a possibility...
20161115 17:28:02< shadowm> zookeeper: The thing is, the easiest way to drive new contributors away is to ignore their contributions.
20161115 17:28:29< shadowm> zookeeper: Three months for a PR that doesn't involve any programming whatsoever.
20161115 17:28:53< shadowm> Would you be okay to be on the submitter end of an exchange like that?
20161115 17:29:16< shadowm> (I'm guessing 'yes', but only because you're extremely prone to procrastinating yourself.)
20161115 17:30:56< shadowm> I strongly advise that you tackle that PR once you're done with whatever it is that you're doing with the preprocessor right now.
20161115 17:31:10< shadowm> Either merge it or request changes or reject it.
20161115 17:33:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 17:34:05< irker467> wesnoth: Lari Nieminen wesnoth:master 929093b4e719 / data/core/units/ (13 files in 5 dirs): Gyra_Solune's unit description updates (#743) https://github.com/wesnoth/wesnoth/commit/929093b4e7199b97b31e9fd842e7d41472abb2a4
20161115 17:34:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 260 seconds]
20161115 17:36:22< zookeeper> the next PR can be someone else's headache
20161115 17:40:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:30e5:3cbd:6dcd:dda] has joined #wesnoth-dev
20161115 17:40:07-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161115 17:44:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161115 17:45:22-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Ping timeout: 252 seconds]
20161115 17:46:47< tad_carlucci> My presence may be spotty for a while dealing with RL issues here. Where I am: AppVeyor is able to run CI builds for MSVC but needs a bit more work on the tests; and I want to test it with branches and PRs. I will continue to look at smart_list<> but expect slow progress. I will check as I can until things calm down.
20161115 17:47:35-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161115 18:03:20-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161115 18:09:28-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20161115 18:10:50-!- JyrkiVesterinen [~JyrkiVest@87-100-252-117.bb.dnainternet.fi] has joined #wesnoth-dev
20161115 18:18:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161115 18:18:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161115 18:19:44-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161115 18:19:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161115 18:26:17-!- noy_ [~Noy@184.69.143.198] has joined #wesnoth-dev
20161115 18:26:17-!- noy_ [~Noy@184.69.143.198] has quit [Changing host]
20161115 18:26:17-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 18:26:40-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161115 18:28:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 250 seconds]
20161115 18:28:09-!- noy_ is now known as noy
20161115 18:28:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161115 18:28:48-!- wedge010 is now known as wedge009
20161115 18:43:14-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161115 18:57:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 19:03:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 19:05:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:30e5:3cbd:6dcd:dda] has quit [Remote host closed the connection]
20161115 19:12:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 19:15:26-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161115 19:19:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161115 19:27:21-!- celticminstrel is now known as celmin|away
20161115 19:31:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 19:33:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:30e5:3cbd:6dcd:dda] has joined #wesnoth-dev
20161115 19:36:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161115 19:37:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161115 19:43:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161115 19:48:59-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 19:54:21< JyrkiVesterinen> Huh. Testing shows that the rewritten size lock widget (without generator_base) works correctly. I got it right blindly. :O
20161115 19:54:37< JyrkiVesterinen> Now I just need to get the WML unit tests to pass...
20161115 19:57:41-!- travis-ci [~travis-ci@ec2-54-92-163-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20161115 19:57:42< travis-ci> wesnoth/wesnoth#12074 (master - 929093b : Lari Nieminen): The build was broken.
20161115 19:57:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/176118153
20161115 19:57:42-!- travis-ci [~travis-ci@ec2-54-92-163-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20161115 19:58:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 19:59:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 20:01:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161115 20:04:47-!- gfgtdf_ [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 20:05:22-!- gfgtdf_ [~chatzilla@x4e369486.dyn.telefonica.de] has quit [Client Quit]
20161115 20:06:14-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20161115 20:09:33-!- Bonobo [~Bonobo@2001:44b8:254:3200:7dc6:f9fa:fa06:d8b3] has joined #wesnoth-dev
20161115 20:12:44< JyrkiVesterinen> The WML tests pass here. :S
20161115 20:13:00-!- JyrkiVesterinen [~JyrkiVest@87-100-252-117.bb.dnainternet.fi] has quit [Quit: Rebooting to GNU/Linux. Maybe the problem is OS specific...]
20161115 20:13:19< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox e926503346a7 / / (7 files in 3 dirs): Size lock widget, the C++ part https://github.com/wesnoth/wesnoth/commit/e926503346a775c7ad6a3d325f3bb58ef4bb7ae3
20161115 20:13:20< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox b276c4c01a62 / data/gui/ (macros/_initial.cfg schema.cfg widget/size_lock_default.cfg): Size lock widget, the WML part https://github.com/wesnoth/wesnoth/commit/b276c4c01a6235d1b0047c59fc9beebaee1052a4
20161115 20:13:23< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 2d92f357e031 / data/gui/window/ (lobby_main.cfg mp_join_game.cfg mp_staging.cfg): Lock sizes of all chat boxes https://github.com/wesnoth/wesnoth/commit/2d92f357e031c00576b974e8cbb3b0d294bb97fe
20161115 20:17:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161115 20:19:14-!- JyrkiVesterinen [~jyrki@87-100-252-117.bb.dnainternet.fi] has joined #wesnoth-dev
20161115 20:24:32-!- travis-ci [~travis-ci@ec2-54-146-4-139.compute-1.amazonaws.com] has joined #wesnoth-dev
20161115 20:24:33< travis-ci> wesnoth/wesnoth#12075 (test_button - 9a267d0 : Celtic Minstrel): The build is still failing.
20161115 20:24:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/176120145
20161115 20:24:33-!- travis-ci [~travis-ci@ec2-54-146-4-139.compute-1.amazonaws.com] has left #wesnoth-dev []
20161115 20:31:57< vultraz> JyrkiVesterinen: i disabled the mp tests
20161115 20:33:17< JyrkiVesterinen> But not the WML tests.
20161115 20:33:18-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161115 20:41:10< JyrkiVesterinen> I committed this to master: https://github.com/wesnoth/wesnoth/commit/a71e2c7cd02980f8455cb372dd8aa49aa78f651b
20161115 20:41:18< JyrkiVesterinen> Irker is being quiet again...
20161115 20:47:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 20:47:39-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161115 20:53:33< zookeeper> yarr, getting there. now i can have one optional single-line macro argument.
20161115 20:55:52< tad_carlucci> Visual Studio 2013 continue integration is being tested on https://github.com/GregoryLundberg/wesnoth scroll to the bottom and click the badges on the README to see the results so far. The control file in my master is appveyor.yml so far looks good
20161115 20:57:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161115 21:00:01-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 21:00:42-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161115 21:00:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161115 21:22:51< JyrkiVesterinen> I can't reproduce the WML test failures on GNU/Linux either.
20161115 21:23:21< JyrkiVesterinen> I wonder if master just happened to be broken when I rebased the fixed-size-chatbox branch on Friday.
20161115 21:23:55< JyrkiVesterinen> I'll just push my latest rebase and go to bed. I can think more about this if the tests continue to fail in Travis.
20161115 21:24:42< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 889e5a8fd64a / / (7 files in 3 dirs): Size lock widget, the C++ part https://github.com/wesnoth/wesnoth/commit/889e5a8fd64ab8c88de52480182eaca18b3f44b2
20161115 21:24:44< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 8f404621160c / data/gui/ (macros/_initial.cfg schema.cfg widget/size_lock_default.cfg): Size lock widget, the WML part https://github.com/wesnoth/wesnoth/commit/8f404621160ca00db8e10e74325af867d8b4f6ec
20161115 21:24:46< irker467> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 4ed014625158 / data/gui/window/ (lobby_main.cfg mp_join_game.cfg mp_staging.cfg): Lock sizes of all chat boxes https://github.com/wesnoth/wesnoth/commit/4ed014625158e39749603d6fd4c34f1f55ab1fa3
20161115 21:25:02-!- JyrkiVesterinen [~jyrki@87-100-252-117.bb.dnainternet.fi] has quit [Quit: Sleep]
20161115 21:31:03-!- celmin|away is now known as celticminstrel
20161115 21:32:05-!- mjs-de [~mjs-de@x5ce49112.dyn.telefonica.de] has joined #wesnoth-dev
20161115 21:42:43< celticminstrel> Maybe a new attribute in [hotkey], or some magic value for the key attribute, could be used to provide layout-independent defaults.
20161115 21:42:57< celticminstrel> Basically, a way to say "use the key that maps to this character".
20161115 21:43:19< celticminstrel> Probably would only be safe to use with letters and digits, though.
20161115 21:43:41< celticminstrel> And no idea what to do with non-Roman scripts.
20161115 22:28:18-!- mjs-de [~mjs-de@x5ce49112.dyn.telefonica.de] has quit [Remote host closed the connection]
20161115 22:41:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161115 22:56:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161115 23:44:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20161115 23:46:56-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161115 23:47:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has left #wesnoth-dev []
20161115 23:49:38-!- gfgtdf [~chatzilla@x4e369486.dyn.telefonica.de] has joined #wesnoth-dev
20161115 23:51:35< gfgtdf> vultraz: i noticed that the mp staging dialog adds a 'random' leader option, even if the factions has only one possible  leader avaiable.
20161115 23:51:50< gfgtdf> vultraz: i'd be better not to show the 'random' option in this case
20161115 23:55:51< gfgtdf> vultraz: also i wonder whether/how its possible not to show a gender symbol for the leader in the mp staging dialog? There are unittypes that have no genders and itlooks just wrong to have a male symbol have on things like ships. I am not 100 sure whether its my wml that is wrong or the not.
20161115 23:59:10< celticminstrel> Why would you have a ship as your leader...
20161115 23:59:42< celticminstrel> You probably don't really need a gender symbol though since the unit image generally reflects it.
20161115 23:59:46< celticminstrel> (Except nagas.)
20161115 23:59:50< celticminstrel> (And saurians maybe?)
--- Log closed Wed Nov 16 00:00:05 2016