--- Log opened Sat Nov 19 00:00:24 2016
20161119 00:04:38-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has quit [Remote host closed the connection]
20161119 00:07:57< wedge009> Ugh, I thought it was compiling properly, but it still isn't.
20161119 00:09:39< irker405> wesnoth: Wedge009 wesnoth:master 69b070afb402 / src/spirit_po/default_plural_forms_expressions.hpp: Specifiy which uint type to use (VC compilation fails otherwise). https://github.com/wesnoth/wesnoth/commit/69b070afb40277962e2245378e0362c96d75437e
20161119 00:09:44< wedge009> That should do it.
20161119 00:16:35< celticminstrel> I'm kinda surprised there is another uint...
20161119 00:21:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161119 00:22:42< tad_carlucci> I'm not just surprised, I'm worried. What if they're not the same? Is there anywhere which would break?
20161119 00:23:32< celticminstrel> I don't think we use a uint anywhere.
20161119 00:23:38< celticminstrel> spirit_po defines and uses one.
20161119 00:23:50< celticminstrel> So, his change is definitely the correct one for this situation.
20161119 00:26:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Permission denied]
20161119 00:26:36< wedge009> Don't know why, but uint is defined in lots of spirit_po headers.
20161119 00:26:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161119 00:29:15-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161119 00:34:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161119 00:49:18-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161119 00:53:14-!- gfgtdf [~chatzilla@x4e36840a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161119 01:12:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161119 01:16:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 01:18:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161119 01:18:07-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161119 01:18:07-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161119 01:18:07-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 01:22:14-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161119 01:28:33-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161119 01:29:32-!- travis-ci [~travis-ci@ec2-54-166-228-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20161119 01:29:33< travis-ci> wesnoth/wesnoth#12108 (master - 5ab0c22 : Wedge009): The build has errored.
20161119 01:29:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177178875
20161119 01:29:34-!- travis-ci [~travis-ci@ec2-54-166-228-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20161119 01:33:24-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161119 01:35:21-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 01:48:43-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161119 01:51:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161119 01:51:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161119 02:09:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161119 02:09:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161119 02:22:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 02:25:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 02:27:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 256 seconds]
20161119 03:10:14-!- irker405 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161119 03:14:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161119 03:23:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 03:29:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 03:48:58-!- Appleman1234 [~Appleman1@KD106161198040.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20161119 03:53:48-!- Appleman1234 [~Appleman1@KD106161198040.au-net.ne.jp] has joined #wesnoth-dev
20161119 04:08:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161119 04:09:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161119 04:57:21-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20161119 05:03:25< vultraz> a simple do_reselect = !w.get_value_bool() && !res; seems to *almost* be enough
20161119 05:09:37< Aginor> hey everyone
20161119 05:09:50< vultraz> hey
20161119 05:11:12< Aginor> I don't think I'll submit any changes to the canvas, that's just been snowballing a lot
20161119 05:11:32< vultraz> snowballing?
20161119 05:12:01< Aginor> in size and scope, I keep finding more stuff to fix, that causes more and more things to need to be fixed
20161119 05:12:27< Aginor> at which point I'm finding myself to try to move it all to a hardware rendering approach, because at that point I might as well
20161119 05:12:49< Aginor> but that's going to be big and require lots more changes to do properly
20161119 05:13:21< Aginor> so I think it would be more useful for me to spend time fixing the flickering when closing a gui2 message on the main screen
20161119 05:13:32< vultraz> what flicker?
20161119 05:13:39< Aginor> of buttons
20161119 05:13:41< vultraz> I've seen no flicker
20161119 05:13:50< vultraz> unless you mean the gui1 ones?
20161119 05:13:57< Aginor> I mean gui1 ones
20161119 05:14:27< vultraz> i don't consider that a blocker
20161119 05:14:33< Aginor> ok
20161119 05:16:40< vultraz> I'd say the buttons in the editor disappearing entirely when a gui2 dialog is open more important
20161119 05:16:58< Aginor> it's probably the same cause
20161119 05:17:45< Aginor> actually, probably not
20161119 05:18:08< Aginor> that's got everything to do with event scoping, and that gui1 and 2 doesn't *ever* receive the same events
20161119 05:18:48< Aginor> which is fine until something is fired that triggers a redraw, of some things but not others
20161119 05:19:52-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161119 05:26:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161119 05:31:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 250 seconds]
20161119 05:34:35< vultraz> Aginor: the editor has a function dedicated to the preferences dialog that calls redraw_everything
20161119 05:34:43< vultraz> in that case, the buttons display fine
20161119 05:35:18< vultraz> Aginor: anyway, if you're not going to complete the canvas pr, can you at least cherry pick the color masks?
20161119 05:37:20< Aginor> I'll see, I might have baked them in with a bunch of other stuff
20161119 05:38:07< Aginor> and to be honest, I think we need a better approach than just defining those masks, we need to differentiate between pango and gui2 and the rest of the game colours
20161119 05:38:16< vultraz> yes
20161119 05:38:25< vultraz> that can wait, though
20161119 05:38:35< vultraz> if you want to look into the flickering buttons, go ahead
20161119 05:38:55< vultraz> however, I'm considering pushing back 1.14 and working on converting the main game screen to gui2
20161119 05:39:04< vultraz> in which case, your canvas work might be most useful
20161119 05:40:56< Aginor> not terribly, I think we're ill served by the canvas both in terms of complexity and performance implications. it mostly seems to just add another layer that's used once
20161119 05:41:20< Aginor> what I was looking at was at the end to render it directly to the screen
20161119 05:41:39< vultraz> well, the canvas thing was to allow 'layers'
20161119 05:41:41< vultraz> I think
20161119 05:41:52< vultraz> but if you can get rid of it I won't object
20161119 05:42:06< Aginor> and then I got carried away with increasing performance because the dirty-checks are only about resizes, not about if something's rendered on top of it
20161119 05:42:58< Aginor> so it all comes back to how drawing of components is structured and how rendering in general is done
20161119 05:44:54< Aginor> but I'm not keen on looking at that now because I expect that I'll spend most of my time simply keeping up with other changes and resolving conflicts since there's a lot of work in that area
20161119 05:46:04< celticminstrel> In which area?
20161119 05:46:12< Aginor> gui2
20161119 05:46:31< Aginor> which I'd expect to have to make extensive modifications to to make it decent
20161119 05:46:43< Aginor> with all the regressions that'd mean
20161119 05:48:14< celticminstrel> I think most of the work on GUI2 is new dialogs, but it's true there's a fair amount of other stuff too...
20161119 05:49:12< Aginor> yeah, I'd rather wait for it to settle down
20161119 05:58:13< vultraz> that will never happen 
20161119 05:58:23< vultraz> until the conversion is done
20161119 05:59:39< vultraz> the problem is you do all of these changes in secret locally
20161119 05:59:45< vultraz> instead of coordinating with the rest of the team
20161119 06:00:42< Aginor> I could flip that argument around as well, I start doing my changes, then people come and change everything while I'm working on it without talking to me about it ahead of time
20161119 06:00:53< Aginor> but that's alright
20161119 06:01:03< Aginor> it's just coming down to who has more time to spend
20161119 06:03:44< vultraz> not.. exactly. Take this case. I was under the impression your changes were canvas-only, but now you reveal they would be a lot more far-reaching.
20161119 06:03:48< Aginor> I've been doing some soul searching while I was away on my trip, and I don't actually think I have terribly much useful to contribute at this time
20161119 06:04:03< vultraz> No-one was going to touch the canvas, but if you don't notify us if you changes go further we can't avoid conflicts.
20161119 06:04:21< Aginor> vultraz: no, they were canvas only, then I realised I couldn't contain them to the canvas
20161119 06:04:24< Aginor> and here I am
20161119 06:04:28< vultraz> I see
20161119 06:06:29-!- Appleman1234 [~Appleman1@KD106161198040.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20161119 06:08:23< vultraz> I won't insist you work on anything, but I would appreciate it if you kept us updated as to your active status. If you feel you currently don't have anything much to contribute, we won't look to you for changes.
20161119 06:08:35< vultraz> If you do intend to work on something
20161119 06:08:41< vultraz> such as button flickering
20161119 06:08:45< vultraz> also do let us know.
20161119 06:09:20< vultraz> I need to know what I can expect the team to be working on in the months ahead.
20161119 06:10:19< Aginor> well, if you're planning to remove it, there's no point in putting work into it, is there?
20161119 06:11:02< vultraz> Obviously the goal is to eventually remove it. The question is whether we can do it within, say, 6 months.
20161119 06:12:03< celticminstrel> If it's just a minor aesthetic thing though...
20161119 06:12:20 * Aginor shrugs
20161119 06:12:40< Aginor> I thought it was useful because those gui elements were still going to be present for the next stable release
20161119 06:13:04< Aginor> if that's not the point there's not much point in me spending a few days debugging to figure out where exactly it's going wrong
20161119 06:13:43< celticminstrel> I thought they were still going to be present in 1.14 too.
20161119 06:13:56< celticminstrel> I know vultraz said he'd work on porting the main game UI to GUI2, but...
20161119 06:14:08< celticminstrel> I'm not sure if that can be completed for 1.14.
20161119 06:14:12< vultraz> Hey, it can't just be me
20161119 06:14:18< vultraz> We need to *all* work on it, jointly
20161119 06:14:45< celticminstrel> I can probably help, sure.
20161119 06:14:54< celticminstrel> But even so, I'm not sure it can be completed for 1.14.
20161119 06:18:50< Aginor> anyway, please let me know if you think it's worth spending time trying to fix it or not
20161119 06:19:21< Aginor> otherwise I might to and look at something else from the roadmap, I think removing SDL_ttf was on there
20161119 06:20:24< celticminstrel> Would it be fine if we decided in eg a month's time that it would be worth spending time trying to fix it? Or is that too late for this decision?
20161119 06:20:41< Aginor> not at all
20161119 06:21:03< Aginor> I might be on my summer holidays though
20161119 06:21:08< celticminstrel> I need to learn not to phrase questions so that a simple "no" or "yes" is always ambiguous.
20161119 06:21:17< celticminstrel> I guess that's "no" to the second question then.
20161119 06:21:44< Aginor> no, I'd look at it when I was back
20161119 06:21:55< Aginor> there's no guarantee I'm going anywhere at this point either
20161119 06:23:21-!- Appleman1234 [~Appleman1@KD106161213031.au-net.ne.jp] has joined #wesnoth-dev
20161119 06:23:30< Aginor> I'm also thinking about spending some time fuzzing our network code
20161119 06:23:44< Aginor> just to make sure that the rewrite hasn't introduced anything too nasty
20161119 06:24:18< Aginor> as we should expect a lot of renewed attention in that area once the game is on steam
20161119 06:25:31-!- irker541 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161119 06:25:31< irker541> wesnoth: Andreas Löf wesnoth:master 40f1ebc899d4 / src/sdl/ (utils.cpp utils.hpp): Define a bitmask for and bitshift for SDL colors https://github.com/wesnoth/wesnoth/commit/40f1ebc899d4ff087ff08518be029d6322fe838f
20161119 06:26:37 * celticminstrel would've preferred const ints, but whatever.
20161119 06:26:49< celticminstrel> Still a good idea.
20161119 06:27:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 06:27:46< Aginor> the fun bit will be to apply them to more places and figure out which colour format that the uint32_t is in
20161119 06:27:56< celticminstrel> What's SDL_ALPHA_OPAQUE?
20161119 06:28:18< celticminstrel> Yeah, that doesn't sound very fun at all. >_>
20161119 06:28:39< Aginor> a constant defined by SDL to be an opaque alpha value
20161119 06:28:51< celticminstrel> Right, but I mean, is it 0 or 255?
20161119 06:28:59< Aginor> I followed the common SDL conventions there
20161119 06:29:12< vultraz> why would it be 0 
20161119 06:29:14< vultraz> :/
20161119 06:29:20< Aginor> #define SDL_ALPHA_OPAQUE 255
20161119 06:29:21< Aginor> #define SDL_ALPHA_TRANSPARENT 0
20161119 06:29:25< celticminstrel> Hmm.
20161119 06:29:44< celticminstrel> I think your int_to_color is going to be transparent when it shouldn't be, then.
20161119 06:30:26< Aginor> hmmm
20161119 06:30:32< celticminstrel> vultraz: I dunno, I'm pretty sure 255=transparent has been a thing somewhere.
20161119 06:30:51 * Aginor swears profusely
20161119 06:31:02< Aginor> if that's the case, it'd explain a lot
20161119 06:31:12< celticminstrel> Eh?
20161119 06:31:24< vultraz> actually
20161119 06:31:33< vultraz> i think 255 = transparent was something in old sdl 1.2
20161119 06:31:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 240 seconds]
20161119 06:31:40< celticminstrel> Possibly.
20161119 06:31:52< vultraz> bc there was some code to assert that transparent or opaque was the right value
20161119 06:31:53< Aginor> they changed it at some point, yes
20161119 06:35:11< irker541> wesnoth: Andreas Löf wesnoth:master a27895afd93d / src/sdl/utils.cpp: Ensure that callers of int_to_color get an opaque colour instead of a fully tran https://github.com/wesnoth/wesnoth/commit/a27895afd93daac686684556c0c2c68486172878
20161119 06:37:45< celticminstrel> Huh?
20161119 06:39:00< Aginor> that code is most likely not alpha aware
20161119 06:39:16< Aginor> so it'll define rgb values with a zero alpha component
20161119 06:39:31< celticminstrel> Now the alpha is always set to 0, because SDL_ALPHA_OPAQUE==SDL_BLUE_MASK.
20161119 06:39:57< celticminstrel> Unless I'm confused.
20161119 06:40:02< Aginor> 	result.a = static_cast<Uint8>((SDL_ALPHA_OPAQUE & rgb) >> SDL_ALPHA_BITSHIFT);
20161119 06:40:22< Aginor> yeah, I managed to not delete the &
20161119 06:40:45-!- JyrkiVesterinen [~JyrkiVest@87-100-214-92.bb.dnainternet.fi] has joined #wesnoth-dev
20161119 06:40:46< Aginor> thank you for spotting that
20161119 06:40:51< celticminstrel> I don't really get what you're aiming for here...
20161119 06:41:09< celticminstrel> SDL_ALPHA_OPAQUE>>SDL_ALPHA_BITSHIFT is 0.
20161119 06:42:17< Aginor> esult.a = static_cast<Uint8>(SDL_ALPHA_OPAQUE); is what I'm aiming for
20161119 06:42:21< celticminstrel> Oh.
20161119 06:42:41< Aginor> I guess the cast might be superflous though
20161119 06:43:01< celticminstrel> I was going to say that an easy general solution (if you want to allow alpha here) would be to invert the alpha so that 255 is transparent and 0 is opaque, so basically "1 - the expression from the previous commit".
20161119 06:43:06< celticminstrel> ^255 not 1
20161119 06:43:15 * celticminstrel mixing up float vs int components here.
20161119 06:43:35< celticminstrel> But it's likely that we just don't need to care about alpha here, I guess.
20161119 06:43:43< Aginor> I really don't want to change the semantics of that function
20161119 06:43:54< celticminstrel> Fair enough.
20161119 06:44:14< Aginor> bool string2rgb(const std::string& s, std::vector<uint32_t>& result) {
20161119 06:44:20< Aginor> is a good consumer of it
20161119 06:44:31< Aginor> and that function doesn't know or care about alpha in the slightest
20161119 06:45:07< celticminstrel> It's actually a little strange to consider alpha as part of the colour anyway.
20161119 06:45:29< Aginor> it wasn't for a long time
20161119 06:46:11< Aginor> that function is from 2006
20161119 06:46:25< Aginor> although it's been touched by 2 people this year
20161119 06:46:49< Aginor> actually, it's probably older than 2006, but that's when it got it's last major prod
20161119 06:48:06< vultraz> gui1 crap
20161119 06:48:44< Aginor> vultraz: all the colour handling is equally bad
20161119 06:49:13< vultraz> indeed
20161119 06:49:29< Aginor> in fact, the gui1 stuff is easy to change because it hasn't had alpha stuff manually hacked in, and uses the same colour format as all images
20161119 06:49:38< Aginor> which is sadly more than can be said for gui2
20161119 06:49:48< Aginor> so all in all it makes it harder
20161119 06:59:00-!- oldlaptop [~quassel@162.247.150.37] has quit [Ping timeout: 256 seconds]
20161119 07:03:16-!- oldlaptop [~quassel@162.247.150.37] has joined #wesnoth-dev
20161119 07:05:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161119 07:11:54< irker541> wesnoth: Andreas Löf wesnoth:master 3ad8ed267bf2 / src/sdl/utils.cpp: Really ensure that the requested color is opaque. https://github.com/wesnoth/wesnoth/commit/3ad8ed267bf2f785540076eea0ac8e6aa3a4b4cd
20161119 07:18:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161119 07:19:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161119 07:33:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161119 07:35:39< Aginor> who's looking after our server at the moment?
20161119 07:39:14< loonycyborg> what about it?
20161119 07:41:21< loonycyborg> It seems to be running fine atm
20161119 07:41:34< loonycyborg> at least master wesnothd :P
20161119 07:41:48< Aginor> who's looking after stable?
20161119 07:44:42< loonycyborg> shadowm is looking for them mostly atm
20161119 07:44:45< loonycyborg> but he seems off
20161119 07:47:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161119 07:50:38< loonycyborg> hmm he's like totally off, so won't even read logs from nonpublic channel
20161119 08:00:00-!- boucman_work [~boucman@2a02-8428-034f-f800-b10c-58cf-54c4-c67c.rev.sfr.net] has joined #wesnoth-dev
20161119 08:00:07-!- boucman_work [~boucman@2a02-8428-034f-f800-b10c-58cf-54c4-c67c.rev.sfr.net] has left #wesnoth-dev []
20161119 08:10:43< Aginor> ok
20161119 08:20:45-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20161119 08:20:46< travis-ci> wesnoth/wesnoth#12111 (master - a27895a : Andreas Löf): The build has errored.
20161119 08:20:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177220235
20161119 08:20:46-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20161119 08:34:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 08:35:42< Aginor> the invalid username/password screen is really eating all cpu
20161119 08:36:12< Aginor> and it doesn't have the length limitation on username unlike the multiplayer dialog
20161119 08:36:46< Aginor> by "eats all cpu" I really mean "is completely unusable insofar that wesnoth hangs and has to be forcibly terminated"
20161119 08:39:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 08:45:04-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161119 08:52:55< vultraz> Aginor: I'll add the max length
20161119 08:53:31< vultraz> Aginor: i haven't been able to repro that lag thing, though
20161119 08:53:53< vultraz> but if it's that "draw events flooding the queue" thing that would be a very good bug to fix
20161119 08:59:12-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has joined #wesnoth-dev
20161119 09:03:37< Aginor> oh, I thought you had pulled those changes
20161119 09:06:06-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has quit [Read error: No route to host]
20161119 09:06:31-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has joined #wesnoth-dev
20161119 09:24:52 * Aginor makes unhappy face
20161119 09:25:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161119 09:25:13< Aginor> https://wiki.libsdl.org/SDL_AddTimer <-- Use this function to set up a callback function to be run on a separate thread after the specified number of milliseconds has elapsed. 
20161119 09:25:32< Aginor> gui2 uses that to push/pop events from the SDL event system which is not threadsafe
20161119 09:26:51< Aginor> I'm not going to do anything about that now, but this is a potentially big issue
20161119 09:28:25< Aginor> static Uint32 timer_sdl_draw_event(Uint32, void*)
20161119 09:28:31< Aginor> static Uint32 timer_sdl_poll_events(Uint32, void*)
20161119 09:29:11< Aginor> static Uint32 delay_event_callback(const Uint32, void* event)
20161119 09:30:03< Aginor> I made the same mistake in my renderpath_redo thread
20161119 09:30:33< Aginor> s/thread/branch/
20161119 09:35:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 09:39:35-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161119 09:40:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 10:09:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161119 10:17:21< zookeeper> Aginor, vultraz, so is there any hope of having the "map labels disappear whenever a menu/dialog is on-screen" thing fixed for 1.14?
20161119 10:22:00< vultraz> peerrrrhaps
20161119 10:36:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 10:41:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 10:49:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161119 10:58:08-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20161119 11:03:35< irker541> wesnoth: Charles Dang wesnoth:master f1686d769bdd / src/units/types.hpp: Made has_gender_variation take a const reference https://github.com/wesnoth/wesnoth/commit/f1686d769bddd8f8a177879a304564be6a5f98bf
20161119 11:03:38< irker541> wesnoth: Charles Dang wesnoth:master bd258cdcab93 / src/gui/ (3 files in 3 dirs): GUI2/Group: bunch of refactoring to fix issues when enabling/disabling members https://github.com/wesnoth/wesnoth/commit/bd258cdcab93480951124248e2a47f4342af564f
20161119 11:03:41< irker541> wesnoth: Charles Dang wesnoth:master 9d0520d816ba / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/9d0520d816ba15fa9c7bc964e2a91002e558b9dc
20161119 11:03:44< irker541> wesnoth: Charles Dang wesnoth:master 65dacf6bc76a / src/spirit_po/exceptions.hpp: Spirit Po: add a missing include for spirit_po::uint https://github.com/wesnoth/wesnoth/commit/65dacf6bc76a51527e72c7284faca77bac472f1c
20161119 11:03:47< irker541> wesnoth: Charles Dang wesnoth:master e6329da6f452 / data/gui/window/mp_login.cfg: MP Login: specify same max username length as in MP Method Selection https://github.com/wesnoth/wesnoth/commit/e6329da6f45289e0b86d8b55b1dc5fa3a829bff5
20161119 11:23:42< irker541> wesnoth: Charles Dang wesnoth:master 910a81b6cc64 / src/units/types.hpp: I am being told that f1686d769bdd was in error https://github.com/wesnoth/wesnoth/commit/910a81b6cc6407b34808bb2393ed7adc030ca22e
20161119 11:27:23< JyrkiVesterinen> Well, "error" is a strong word. The code works either way.
20161119 11:29:19< vultraz> true, true
20161119 11:29:27< vultraz> do you have any suggestions on simplifying the do_reselect  logic?
20161119 11:30:21< JyrkiVesterinen> I already suggested moving dynamic_cast out of there. Hold on, I may be able to simplify the logic.
20161119 11:30:56< vultraz> well, I'd still need a dynamic cast anyway
20161119 11:31:11< vultraz> for get/set value bool
20161119 11:33:40-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161119 11:33:50< vultraz> oh wait
20161119 11:33:54< vultraz> wrong code
20161119 11:34:09< JyrkiVesterinen> https://gist.github.com/jyrkive/400f74ea8c08c815d442c5e1b179931a
20161119 11:34:19< JyrkiVesterinen> The above is logically identical to existing code.
20161119 11:35:52< vultraz> couldn't one just do do_reselect = !res?
20161119 11:35:55< vultraz> in this case
20161119 11:36:22< JyrkiVesterinen> Yes, that would also work.
20161119 11:37:11< JyrkiVesterinen> I edited the gist.
20161119 11:37:53< vultraz> ty ty
20161119 11:45:20-!- JyrkiVesterinen [~JyrkiVest@87-100-214-92.bb.dnainternet.fi] has quit [Quit: Going somewhere]
20161119 11:46:28< irker541> wesnoth: Charles Dang wesnoth:master 5630efdac3c4 / src/gui/widgets/group.hpp: Improvements to bd258cdcab93 as suggested https://github.com/wesnoth/wesnoth/commit/5630efdac3c4a7eb88e16280f2ac3c39c36a8d85
20161119 11:47:40-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161119 11:50:30-!- gfgtdf [~chatzilla@x4e368879.dyn.telefonica.de] has joined #wesnoth-dev
20161119 11:50:46< gfgtdf> 20161119 09:25:32< Aginor> gui2 uses that to push/pop events from the SDL event system which is not threadsafe
20161119 11:51:05< gfgtdf> Aginor: https://wiki.libsdl.org/SDL_PushEvent explicitly says that "This function is thread-safe, and can be called from other threads safely. "
20161119 11:54:03< irker541> wesnoth: Charles Dang wesnoth:master 3f5d952d3b62 / src/gui/widgets/group.hpp: GUI2/Group: added error if attempting to add member with an already-taken value https://github.com/wesnoth/wesnoth/commit/3f5d952d3b622cf4931b89f1928e9966507bd13b
20161119 11:56:23< vultraz> huh, just realized i never gave this class a constructor
20161119 11:56:26< vultraz> oh well, it's not needed
20161119 11:57:13< gfgtdf> vultraz: you saw my quetion about unit preview panels ?
20161119 11:57:20< vultraz> gfgtdf: yes
20161119 11:57:30< vultraz> gfgtdf: talk to celmin about a lua interface. i don't know that code at all
20161119 11:57:51< gfgtdf> vultraz: hmm ok
20161119 11:58:12< irker541> wesnoth: Nils Kneuper wesnoth:master c7646bbcdf59 / changelog players_changelog po/wesnoth-ei/pt_BR.po: updated Portuguese (Brazil) translation https://github.com/wesnoth/wesnoth/commit/c7646bbcdf59745d6149aa3e1fd85d552ec5fc3e
20161119 12:04:15-!- gfgtdf [~chatzilla@x4e368879.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161119 12:33:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161119 12:37:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 12:39:48-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161119 12:42:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 13:05:41-!- JyrkiVesterinen [~JyrkiVest@78-27-117-223.bb.dnainternet.fi] has joined #wesnoth-dev
20161119 13:07:45-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has quit [Remote host closed the connection]
20161119 13:12:54< vultraz> JyrkiVesterinen: i implemented your suggestions
20161119 13:38:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 13:43:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 13:51:00< irker541> wesnoth: Charles Dang wesnoth:master 32d69b9c2cde / / (6 files in 4 dirs): MP Game Set Password: removed unused dialog https://github.com/wesnoth/wesnoth/commit/32d69b9c2cde4169db350e70af12e7ebb0d82d41
20161119 13:53:00< irker541> wesnoth: Charles Dang wesnoth:master 5dcf1213b0c4 / data/gui/window/mp_create_game_set_password.cfg: Removed WML for MP Game Set Password (32d69b9c2cde) https://github.com/wesnoth/wesnoth/commit/5dcf1213b0c414e2a3f015f373b4ef4ebbd0717b
20161119 14:01:07-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161119 14:16:59-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161119 14:39:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 14:44:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Ping timeout: 260 seconds]
20161119 14:44:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20161119 14:46:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161119 14:46:20< vultraz> wedge009: msvc projectfile update, you need to do
20161119 14:49:21< irker541> wesnoth: Wedge009 wesnoth:master 524f23db583f / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project. https://github.com/wesnoth/wesnoth/commit/524f23db583f16520c9c02eeb537ecf744087692
20161119 15:21:32-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20161119 15:21:34< travis-ci> wesnoth/wesnoth#12118 (master - 32d69b9 : Charles Dang): The build has errored.
20161119 15:21:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177261905
20161119 15:21:34-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20161119 15:30:15-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161119 15:36:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has joined #wesnoth-dev
20161119 15:52:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:556f:f0da:4513:51b2] has quit [Remote host closed the connection]
20161119 15:56:51-!- JyrkiVesterinen [~JyrkiVest@78-27-117-223.bb.dnainternet.fi] has quit [Quit: .]
20161119 15:57:27-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20161119 15:57:28< travis-ci> wesnoth/wesnoth#12119 (master - 5dcf121 : Charles Dang): The build has errored.
20161119 15:57:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177262075
20161119 15:57:28-!- travis-ci [~travis-ci@ec2-54-161-90-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20161119 16:01:38 * vultraz is converting the Statistics dialog to GUI2
20161119 16:03:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 16:07:13-!- gfgtdf [~chatzilla@x4e368879.dyn.telefonica.de] has joined #wesnoth-dev
20161119 16:07:32< gfgtdf> celim: any opinon on the lua interface for unit preview panel widget https://gna.org/bugs/index.php?25317 ?
20161119 16:12:34-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has joined #wesnoth-dev
20161119 16:45:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161119 16:54:48< vultraz> ... ok, wtf is this...
20161119 16:56:06< vultraz> im getting a value displaying twice in a listbox
20161119 16:56:10< vultraz> for no apparently reason :|
20161119 16:56:34< celticminstrel> So, it was added twice?
20161119 16:56:43< vultraz> no
20161119 16:56:48< celticminstrel> You sure?
20161119 16:56:51< vultraz> yes
20161119 16:57:02< celticminstrel> Really.
20161119 16:57:11 * celticminstrel skeptical
20161119 16:57:22< vultraz> im printing out the value to console and it's there *once*
20161119 16:57:32< vultraz> but it displays twice
20161119 16:57:33< vultraz> :|
20161119 16:58:13< celticminstrel> What're you working on. anyway?
20161119 16:58:29< vultraz> [03:01:34]	vultraz	is converting the Statistics dialog to GUI2
20161119 16:58:35< celticminstrel> Oh fun.
20161119 16:59:00< vultraz> mostly involves pulling code from the gui1 dialog
20161119 16:59:06< vultraz> but now im running into this
20161119 16:59:08< vultraz> *weird* but :|
20161119 16:59:24< celticminstrel> Sounds like it's being added twice.
20161119 16:59:45< vultraz> celticminstrel: http://pastebin.com/ZXR2i7MJ
20161119 16:59:53< vultraz> the "damage_overall" label
20161119 17:00:00< vultraz> where am I adding it twive
20161119 17:00:03< vultraz> twice*
20161119 17:01:21< celticminstrel> Okay, so there's the code.
20161119 17:01:26< celticminstrel> Now what are you actually seeing?
20161119 17:02:23< celticminstrel> I think add_damage_row and add_stat_row should really be member functions, not lambdas.
20161119 17:02:40< vultraz> https://drive.google.com/file/d/0B-mR9s8FduLLX1E3R2kzY3J3NzQ/view?usp=sharing
20161119 17:04:00< celticminstrel> Oh, I know what's happening.
20161119 17:04:06< vultraz> what is happening?
20161119 17:04:07< celticminstrel> clear() doesn't do what you think it does.
20161119 17:04:11< celticminstrel> It doesn't clear the stream.
20161119 17:04:16< celticminstrel> It clear's the stream's error flags.
20161119 17:04:25< celticminstrel> To clear the stream you call str("").
20161119 17:04:28< celticminstrel> ^clears
20161119 17:04:57< celticminstrel> So basically the value added for damage_this_turn consists of damage_overall with the extra damage_this_turn data appended.
20161119 17:05:10< vultraz> I see
20161119 17:05:32< vultraz> that is...highly unintuitive 
20161119 17:05:37< celticminstrel> Kinda, yeah.
20161119 17:05:42< celticminstrel> But that's how it is.
20161119 17:06:35< vultraz> ahhhh that works
20161119 17:06:36< vultraz> ty ty :D
20161119 17:10:24< vultraz> alright, that makes the dialog basically functional for a single view
20161119 17:10:32< vultraz> now i just need the rest of the functionality
20161119 17:17:07-!- horrowind [~Icedove@ip5f5ad759.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161119 17:19:24-!- louis94 [~~louis94@91.178.240.155] has joined #wesnoth-dev
20161119 17:21:55-!- JyrkiVesterinen [~JyrkiVest@78-27-124-250.bb.dnainternet.fi] has joined #wesnoth-dev
20161119 17:37:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161119 17:49:38-!- irker541 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161119 17:50:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161119 17:52:11-!- midzer_ [~quassel@p5B296948.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161119 17:52:41-!- midzer [~quassel@p57B454D1.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20161119 18:04:39-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161119 18:05:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161119 18:07:27< celticminstrel> Wait, why is the username limited to 20 characters?
20161119 18:07:27-!- mjs-de [~mjs-de@x4db541d1.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161119 18:07:44-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has joined #wesnoth-dev
20161119 18:07:45< celticminstrel> I guess it doesn't matter that much, just... it seems pointless.
20161119 18:10:12< celticminstrel> Though when I saw that commit I momentarily thought it was the password being limited, which is bad.
20161119 18:10:45-!- horrowind [~Icedove@ip5f5ad759.dynamic.kabel-deutschland.de] has quit [Quit: horrowind]
20161119 18:12:37< vultraz> no idea
20161119 18:13:14< celticminstrel> Create game set password was unused?
20161119 18:13:21< vultraz> yes
20161119 18:13:27< celticminstrel> Where do you set a game password? Right in MP Create?
20161119 18:13:30< vultraz> yes
20161119 18:15:17< celticminstrel> I notice it's set with a [text_box], not a [password_box]... intentional?
20161119 18:15:24< celticminstrel> (I could see arguments for it.)
20161119 18:33:19< celticminstrel> vultraz: Objections to doing that GUI2 file reshuffling today?
20161119 18:33:30< vultraz> i thought you had done it already locally
20161119 18:33:46< celticminstrel> I hadn't, but it wouldn't be too much work probably.
20161119 18:33:54< celticminstrel> Nowhere near the effort of the class renaming.
20161119 18:34:07< celticminstrel> Just rename a few files and update all the includes.
20161119 18:36:12< vultraz> are you asking me to do it?
20161119 18:36:12< celticminstrel> What the heck does "namespace ng" actually mean anyway...
20161119 18:36:22< celticminstrel> No, I'm asking if you object to me doing it.
20161119 18:36:24< celticminstrel> Today.
20161119 18:36:29< celticminstrel> And pushing the result.
20161119 18:36:31< celticminstrel> Today.
20161119 18:36:41< celticminstrel> Sorry if that was unclear.
20161119 18:36:51< celticminstrel> I can totally see how you might've taken it the wrong way.
20161119 18:38:39< celticminstrel> My plan was to just do the file renames and move the highly questionable files.
20161119 18:39:27< celticminstrel> There were also some slightly questionable ones whose best placement is less clear.
20161119 18:39:56< celticminstrel> I think they can wait, unless you really want it done now (in which case we'd need to discuss how it's to be done now).
20161119 18:42:35 * celticminstrel poke vultraz 
20161119 18:42:45< vultraz> ng = engine
20161119 18:43:04< vultraz> anyway, go ahead
20161119 18:52:13-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20161119 18:56:45< vultraz> note to self:
20161119 18:56:49< vultraz> use team::color more
20161119 18:57:25< vultraz> for RC..
20161119 18:57:32< vultraz> instead of magenta>num...
20161119 18:57:35< vultraz> if possible
20161119 18:57:41< vultraz> though id have to look at every case :/
20161119 18:57:43< vultraz> blagh
20161119 18:57:49< vultraz> so many dialogs color units
20161119 18:58:27< celticminstrel> So basically what you're trying to say is, remove the numeric colours.
20161119 18:58:35-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161119 18:59:07 * celticminstrel thought that magenta>num did not use the team colour from team num but rather a fixed colour that would've been the default for that team in an MP game.
20161119 18:59:19< vultraz> yes, true..
20161119 18:59:20< vultraz> ugh...
20161119 18:59:50< celticminstrel> Well, a good start then would be to make ~RC() produce an error when the target colour doesn't exist (unless it does already?).
20161119 19:00:09< celticminstrel> Maybe a more noticeable error than just a log message.
20161119 19:01:27< vultraz> this is more of that color handling stuff that will need to be dealt with
20161119 19:03:22< vultraz> random: I wonder whether I should change my practice of recreating the data/item objects for every iteration in list generation
20161119 19:03:26< vultraz> and instead just use clear
20161119 19:04:22< celticminstrel> It probably doesn't matter that much.
20161119 19:05:11< vultraz> i find myself using the latter method for this dialog
20161119 19:05:37 * celticminstrel shrugs.
20161119 19:05:40< JyrkiVesterinen> I prefer recreating objects instead of reusing and clearing them.
20161119 19:05:42-!- shadowm [~ignacio@wesnoth/developer/shadowm] has left #wesnoth-dev []
20161119 19:06:17< vultraz> celticminstrel: design thoughts? https://drive.google.com/file/d/0B-mR9s8FduLLOXlFSEE4a2J1NjA/view?usp=sharing
20161119 19:07:02< celticminstrel> I'll tell you once I'm finished this.
20161119 19:10:34-!- louis94 [~~louis94@91.178.240.155] has quit [Ping timeout: 256 seconds]
20161119 19:15:48< vultraz> updated shot
20161119 19:25:09-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161119 19:29:42-!- DeFender1031 [~DeFender1@46-116-88-23.bb.netvision.net.il] has joined #wesnoth-dev
20161119 19:31:00-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 250 seconds]
20161119 19:39:16< pydsigner> Looks fine to me other than maybe a bit more right pad on the unit list?
20161119 19:40:06< vultraz> after the count?
20161119 19:42:09< pydsigner> Yeah
20161119 19:48:53< vultraz> ok
20161119 19:48:59< vultraz> well, general implementation all done
20161119 19:49:02< vultraz> now for cleanup, etc
20161119 19:53:02< celticminstrel> vultraz: What were the files that needed ../ to work again.
20161119 19:53:30< celticminstrel> I think image.hpp was one?
20161119 19:53:34< celticminstrel> Maybe I can grep it.
20161119 19:56:58< vultraz> minimap
20161119 20:03:46< vultraz> hmmmmmmm
20161119 20:03:53< vultraz> ok, I'm not sure how to do this..
20161119 20:06:24-!- JyrkiVesterinen [~JyrkiVest@78-27-124-250.bb.dnainternet.fi] has quit [Quit: .]
20161119 20:07:00< vultraz> perhaps...uh...
20161119 20:07:54< vultraz> er wait, maybe this isn't the problem
20161119 20:11:33< vultraz> ahhh
20161119 20:11:34< vultraz> got it
20161119 20:16:00-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20161119 20:18:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161119 20:28:45< vultraz> dialog ready barring WML layout issues
20161119 20:32:01< vultraz> eh, ya know what
20161119 20:32:16< celticminstrel> You were waiting on my comments, I thought.
20161119 20:32:17< vultraz> ill finagle the wml later 
20161119 20:32:37< vultraz> oh right
20161119 20:32:44< vultraz> do you have comments?
20161119 20:32:48< celticminstrel> I mean, if you really want to push, I can't exactly stop you.
20161119 20:32:55< celticminstrel> I don't know. I closed Firefox so I could XCode.
20161119 20:33:25< celticminstrel> I suppose I could swap to the other computer and retrieve the link from the logs, if you're impatient.
20161119 20:33:35< vultraz> nah, ill just push
20161119 20:33:40< vultraz> pydsigner said the design was fine
20161119 20:33:46< celticminstrel> 'kay, whatever3
20161119 20:33:46< vultraz> can always tweak later
20161119 20:33:56< celticminstrel> I guess I'll bundle that into the "Update XCode" commit too then.
20161119 20:33:58< pydsigner> vultraz: You did ask him specifically
20161119 20:34:10-!- irker462 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161119 20:34:10< irker462> wesnoth: Charles Dang wesnoth:master 049f06707355 / / (10 files in 5 dirs): Converted Statistics dialog to GUI2 https://github.com/wesnoth/wesnoth/commit/049f06707355fa68e8ee1096c34967864b4186a9
20161119 20:34:15< vultraz> pydsigner: true, but any feedback was good
20161119 20:34:23< pydsigner> celticminstrel: https://drive.google.com/file/d/0B-mR9s8FduLLOXlFSEE4a2J1NjA/view
20161119 20:34:36< celticminstrel> Huh? Reposting the link that's in my logs?
20161119 20:34:42< celticminstrel> s/logs/scrollback/
20161119 20:35:01< pydsigner> You said it was on your other machine
20161119 20:35:09< celticminstrel> Which isn't connected to IRC.
20161119 20:35:31< pydsigner> I guess I don't know what you're trying to say then
20161119 20:35:54< celticminstrel> I can't copy-paste from here to there, but I could switch to there, load the logs website, and click the link from there.
20161119 20:36:04< celticminstrel> Or, I could wait until I get around to launching Firefox again here.
20161119 20:37:41< vultraz> god dammit
20161119 20:37:48< vultraz> i've found a hidden gui1 dialog :|
20161119 20:38:13< celticminstrel> Oh? What is it?
20161119 20:38:16< vultraz> Layers
20161119 20:38:19< celticminstrel> ?
20161119 20:38:34< vultraz> go into a game, open console, and type "layers" while hovering over a hex
20161119 20:38:41< vultraz> it's like, debug terrain graphics info
20161119 20:38:45< celticminstrel> Huh.
20161119 20:38:57< celticminstrel> Works with ;nodebug
20161119 20:38:58< celticminstrel> ?
20161119 20:39:22< vultraz> no
20161119 20:39:28< celticminstrel> Good, good.
20161119 20:39:42< celticminstrel> Is it at least a simple dialog?
20161119 20:39:46< vultraz> kinda
20161119 20:39:47< vultraz> yes
20161119 20:40:19< vultraz> remind me at some point to get you or maybe myself to look at making listbox headers better
20161119 20:40:37< vultraz> because it shouldn't be such a PITA to get headers to align with the body colums
20161119 20:40:39< vultraz> :|
20161119 20:40:51< celticminstrel> Linked groups don't work?
20161119 20:40:58< vultraz> not really, no
20161119 20:41:12< vultraz> not very well
20161119 20:41:28< celticminstrel> Hmm, maybe header and content has different padding or something which messes it up.
20161119 20:41:46< vultraz> sometimes
20161119 20:41:54< vultraz> but sometimes it just downright refuses to line up
20161119 20:43:10< vultraz> anyway
20161119 20:43:24< vultraz> - and + 1 gui1 dialogs, it seems :|
20161119 20:47:42< celticminstrel> I just noticed there are a lot of "for tmulti_page" etc comments.
20161119 20:48:38-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161119 20:54:54-!- zookeeper_ is now known as zookeeper
20161119 20:54:56-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20161119 20:54:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161119 20:57:31-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161119 21:00:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161119 21:12:19< vultraz> zookeeper: do you know about the Layers dialog?
20161119 21:12:55< vultraz> seems to be it'd be something useful in the editor
20161119 21:14:15< celticminstrel> But it's not in the editor.
20161119 21:14:18< celticminstrel> Right?
20161119 21:14:26< celticminstrel> Presumably, since commands aren't in the editor.
20161119 21:14:39< zookeeper> vultraz, the what?
20161119 21:15:24< vultraz> zookeeper: this https://drive.google.com/file/d/0B-mR9s8FduLLWWtGRnQ5b2JoVnc/view?usp=sharing
20161119 21:15:28< celticminstrel> Apparently it shows up if you enter the command ;layers in debug mode.
20161119 21:15:41-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161119 21:16:27< zookeeper> ohh yes i've seen that
20161119 21:17:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161119 21:17:34< zookeeper> well, yes that'd be useful in the editor
20161119 21:22:57-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has quit [Remote host closed the connection]
20161119 21:22:58-!- Bonobo [~Bonobo@2001:44b8:254:3200:4d63:d3da:ba09:24ff] has joined #wesnoth-dev
20161119 21:28:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161119 21:29:08< zookeeper> dunno how though; there's no right-click menu, and an entry in the map menu might be confusing since it'd require you to always use the hotkey.
20161119 21:29:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161119 21:30:55< celticminstrel> vultraz: Just to be sure, the new dialog is game_stats.?pp right?
20161119 21:31:09< celticminstrel> The editor does actually have a right-click menu in some modes.
20161119 21:32:27< celticminstrel> For example, when placing units.
20161119 21:32:40< celticminstrel> Not sure if it has one in any non-scenario modes.
20161119 21:32:56< celticminstrel> (Speaking of placing units, isn't that still causing a crash?)
20161119 21:33:43< celticminstrel> Oh, I guess it's actually statistics_dialog.?pp
20161119 21:36:51-!- Bonobo [~Bonobo@2001:44b8:254:3200:4d63:d3da:ba09:24ff] has quit [Ping timeout: 258 seconds]
20161119 21:37:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:9c88:26a4:5207:c87d] has joined #wesnoth-dev
20161119 21:44:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161119 21:44:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161119 21:46:46< Shiki> already compiling 15 minutes - seems like you worked quite a bit
20161119 21:47:34< celticminstrel> ?
20161119 21:50:22< Shiki> I'm just looking what happened the last days ;)
20161119 21:54:34< celticminstrel> I wonder if libdbus works on OSX.
20161119 21:55:17< celticminstrel> scons appears to detect its presence, at least.
20161119 21:57:03< celticminstrel> But I dunno if that means it'd actually work.
20161119 22:16:41< loonycyborg> there's no reason why dbus wouldn't work on mac
20161119 22:16:59< loonycyborg> but probably it won';t work towards purpse wesnoth is using it
20161119 22:17:33< loonycyborg> unless there are some compatibility layers to emulate desktop linux protocols :P
20161119 22:21:14< celticminstrel> I guess I should be able to push this now.
20161119 22:21:25< celticminstrel> Though probably best to at least wait for the build to complete.
20161119 22:25:30-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161119 22:25:50< tad_carlucci> C:\projects\wesnoth\src\spirit_po/default_plural_forms_expressions.hpp(25): fatal error C1083: Cannot open include file: 'boost/spirit/include/qi.hpp': No such file or directory (..\..\src\gettext_boost.cpp) [C:\projects\wesnoth\projectfiles\VC12\wesnoth
20161119 22:27:09< celticminstrel> Boost version?
20161119 22:28:22< tad_carlucci> It's AppVeyor and uses a fresh download for 'external' tools. Don't know the boost version but I think 1.62
20161119 22:28:48< celticminstrel> Hmm, pretty sure that's newer than I'm building with..
20161119 22:30:01< tad_carlucci> the ../../src is where I'd start. And its from spirit_po so neither side is boost
20161119 22:31:32< celticminstrel> But the include file that can't be opened is boost.
20161119 22:32:03< tad_carlucci> wesnoth src/gettext_boost.cpp
20161119 22:32:32< tad_carlucci> oh soory ok
20161119 22:32:42< tad_carlucci> I'm too tired to think straight.
20161119 22:35:14< celticminstrel> Maybe get some sleep. >_>
20161119 22:37:56< tad_carlucci> Walked in the door a couple hours ago and passed out in the chair. Woke and checked the CI for MSVC and saw the error.
20161119 22:42:19< EliDupree> Hmmm… I'm trying to stop wesnoth from redrawing in the middle of the script when I don't want it to. Does wesnoth automatically redraw when you use the word to change a unit's facing? I can't find the part of the code responsible for that
20161119 22:42:34< EliDupree> *use lua to
20161119 22:44:43< tad_carlucci> Anyway. Details on the AppVeyor setup are in my fork master appveyor.yml and link to build log from the badge on my version of README.md
20161119 22:44:48< gfgtdf> EliDupree: you mena liek wesnoth.get_unit(1,1).facing = "north" ? I don't think that causes a redrat.
20161119 22:44:51< gfgtdf> redraw
20161119 22:44:56-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161119 22:44:56< EliDupree> yeah
20161119 22:45:23< celticminstrel> Is "north" the right value? I'd expect "n".
20161119 22:46:02< gfgtdf> celticminstrel: yes maybe my code was wrong
20161119 22:54:18 * celticminstrel pokes wedge009 for VC update
20161119 22:54:27< irker462> wesnoth: Celtic Minstrel wesnoth:master 17d32e3083da / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/17d32e3083da8a1c77e7af8d28769c40efe5c69e
20161119 22:54:29< irker462> wesnoth: Celtic Minstrel wesnoth:master 9eb1efadc720 / / (22 files in 6 dirs): Move lobby data/info to game_initialization, in mp namespace https://github.com/wesnoth/wesnoth/commit/9eb1efadc7202ceee5997b74d3f1de99de01b62c
20161119 22:54:31< irker462> wesnoth: Celtic Minstrel wesnoth:master 01d23b5b1558 / / (9 files in 6 dirs): Move tip of the day code from GUI2 core to auxiliary https://github.com/wesnoth/wesnoth/commit/01d23b5b1558508e56c7fcd98f3c9bd03a18f1e6
20161119 22:54:33< irker462> wesnoth: Celtic Minstrel wesnoth:master 67ea79d86f84 / / (184 files in 18 dirs): Rename some GUI2 files to match the contained class https://github.com/wesnoth/wesnoth/commit/67ea79d86f84674249ebbf4a49d846f791a8cd73
20161119 22:57:20< EliDupree> The frustrating thing is that I have a large section of my code, which isn't easy to split up, and all I know is that a redraw is occurring SOMEWHERE in there
20161119 22:57:36< EliDupree> But it definitely doesn't redraw explicitly, nor use synchronize_choice
20161119 23:03:09-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20161119 23:06:59< irker462> wesnoth: Wedge009 wesnoth:master 63106d1c6205 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update VC project for statistics dialogue conversion to gui2. https://github.com/wesnoth/wesnoth/commit/63106d1c6205ba05f32c6bbe810a6d48d5f38bba
20161119 23:07:16< wedge009> I have to go, I'll do the rest when I get back.
20161119 23:07:42< celticminstrel> Sure...
20161119 23:15:04< irker462> wesnoth: Celtic Minstrel wesnoth:osx_notifications_info c18ca562a81d / src/ (4 files in 2 dirs): Attempt to fix Cocoa notifications availability not being shown https://github.com/wesnoth/wesnoth/commit/c18ca562a81d8e9aa7aef45f248b29fdac303fd5
20161119 23:15:25< celticminstrel> ^ something for ancestral to try out when he has the time
20161119 23:16:07< celticminstrel> Not entirely sure if it's complete or if everything in that commit is actually needed.
20161119 23:19:48< celticminstrel> Actually, the way it's set up, 99% of users will never see Growl notifications even if they have Growl, because the Cocoa notifications take priority...
20161119 23:20:25< celticminstrel> If it wasn't for 10.7 I'd suggest dropping Growl.
20161119 23:51:56-!- travis-ci [~travis-ci@ec2-54-166-228-134.compute-1.amazonaws.com] has joined #wesnoth-dev
20161119 23:51:56< travis-ci> wesnoth/wesnoth#12122 (master - 67ea79d : Celtic Minstrel): The build was broken.
20161119 23:51:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177340508
20161119 23:51:57-!- travis-ci [~travis-ci@ec2-54-166-228-134.compute-1.amazonaws.com] has left #wesnoth-dev []
20161119 23:52:06< celticminstrel> Well.
20161119 23:52:18< celticminstrel> I can't say I'm super-surprised, but...
20161119 23:53:03< celticminstrel> Oh huh, a stupid mistake.
20161119 23:53:08< celticminstrel> How did I miss that one.
20161119 23:53:18< celticminstrel> Oh right, because I don't build the campaign server.
20161119 23:55:10< irker462> wesnoth: Celtic Minstrel wesnoth:master b1f6983ebfd6 / src/campaign_server/campaign_server.cpp: Fix erroneous include change https://github.com/wesnoth/wesnoth/commit/b1f6983ebfd60e94873c519e156afa1bb0ea354d
--- Log closed Sun Nov 20 00:00:30 2016