--- Log opened Sun Nov 20 00:00:30 2016
20161120 00:28:46-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 00:28:47< travis-ci> wesnoth/wesnoth#12123 (master - 63106d1 : Wedge009): The build was broken.
20161120 00:28:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177342429
20161120 00:28:47-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 00:30:27< gfgtdf> EliDupree: you coudl inject a debugtrace in wesnoth.redraw, like << local old_redraw = wesnoth.redraw; wesnoth.redraw = function(cfg) print(debug.traceback()); old_redraw(cfg) end>>
20161120 00:31:11< celticminstrel> gfgtdf: That'll only work if the redraw is being triggered through Lua though.
20161120 00:31:23< celticminstrel> If some other API call implicitly redraws, that won't produce results.
20161120 00:31:28< EliDupree> That's assuming that a wesnoth.redraw is being invoked by some lua script, rather than a redraw being invoked by something in the C++
20161120 00:31:35< EliDupree> Yeah, that
20161120 00:31:36< celticminstrel> Yeah, that ^
20161120 00:32:07< gfgtdf> celticminstrel: hmm yes but some other lua-impleted wml tags for exaample also call wensoth.redraw, so it might work
20161120 00:32:21< EliDupree> Would that include wesnoth.fire ("redraw")?
20161120 00:32:40< celticminstrel> I think so.
20161120 00:32:41< gfgtdf> yes it implex wesnoth.fire redraw
20161120 00:32:47< EliDupree> I suppose it's worth testing for…
20161120 00:32:48< gfgtdf> (but why woudl one call redraw that way?)
20161120 00:32:57< gfgtdf> printing the debug trace from the theme items clalbck migth ab another option
20161120 00:33:03< celticminstrel> Wait, isn't that the only way to call redraw?
20161120 00:33:19< gfgtdf> sicne thoew afaik alog get called when redraw is called by the c++ code
20161120 00:33:20< celticminstrel> Through the WML action I mean.
20161120 00:33:51-!- Shiki2 [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 00:34:44< EliDupree> Interesting you should mention that. I recently encountered an unrelated(?), non-reproducible issue where I got a stack overflow inside a theme item
20161120 00:35:03< gfgtdf> celticminstrel: [redraw] is afaik implented in lua as calling wenoth.redraw() 
20161120 00:36:24< gfgtdf> s/alog/that also
20161120 00:38:30< celticminstrel> vultraz: This might be the same as pydsigner brought up, but it looks really odd how eg "1x" is right up against the edge. I'm not entirely convinced a multiplication symbol looks good there, actually.
20161120 00:38:42< celticminstrel> Still, overall the dialog looks good.
20161120 00:42:15< EliDupree> I have discovered my problem. My code was actually invoking synchronize_choice in a way I didn't realize.
20161120 00:42:29< EliDupree> Now I just have to figure out how to avoid doing that.
20161120 00:43:08< EliDupree> I did it by sticking a trace back in theme item, like you suggested – thanks :-)
20161120 00:47:45< EliDupree> However, the results also reveal some strange and possibly bad things. One of the theme item calls was inside a wesnoth.fire ("set_variable", {rand =...})
20161120 00:48:15< EliDupree> I suppose that makes sense because it might require network
20161120 00:48:59< gfgtdf> EliDupree: yes when the rand migth rquire a rnadom variable form the server which uses teh same mechanics as sync_choice, but i agree thats its quite unexpected
20161120 00:49:49< EliDupree> I might want to use my own pseudorandom number generator to avoid various issues like that…
20161120 00:50:43< gfgtdf> EliDupree: you can add a dummy rand= call at the start of the event to make sure that the random is inited when you use it in the midle of the event, this woudl move the redraw to the start of the event.
20161120 00:51:29< EliDupree> Oh, it's only once per event? Then it probably isn't a problem for me. Assuming it's once per event stack, not once per manually fired event in the stack
20161120 00:52:10< EliDupree> I guess I should throw a random call in at the beginning of all my events, just to protect from unexpected redraws
20161120 00:52:15< gfgtdf> EliDupree: its once per 'user action' like move/attack/recuit/menu_item_lick etc.
20161120 00:52:25< EliDupree> neat
20161120 00:53:04< gfgtdf> EliDupree: note that adding a random call iek this will prevent undoing on all these events, so you shoudl onyl do the dumym rand call after you know its nonundoable.
20161120 00:53:25< gfgtdf> s/lick/click
20161120 00:53:30< EliDupree> This isn't a problem because the events in question are already not possible to undo
20161120 00:54:01< EliDupree> Is it even possible to undo events in multiplayer now?
20161120 00:54:59< gfgtdf> EliDupree: well yes you can add [allow_undo] so moveto events that doesnt change the gamestate like in sp
20161120 00:58:42< gfgtdf> EliDupree: are you wokring on 1.12 or 1.13 ?
20161120 00:58:59< EliDupree> 1.12
20161120 00:59:01-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161120 01:09:54-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 01:09:55< travis-ci> wesnoth/wesnoth#12124 (osx_notifications_info - c18ca56 : Celtic Minstrel): The build failed.
20161120 01:09:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177343341
20161120 01:09:55-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 01:10:32< celticminstrel> Probably for the same reason as master, so not gonna bother checking.
20161120 01:20:40< EliDupree> gfgtdf: As far as I can tell, I've now fixed the problem, and likely reduced a lot of the frustrating network delays in EoHS as a whole. Thanks again for the help.
20161120 01:52:43-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 01:52:44< travis-ci> wesnoth/wesnoth#12125 (master - b1f6983 : Celtic Minstrel): The build is still failing.
20161120 01:52:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177348616
20161120 01:52:44-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 01:55:29-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161120 01:55:56< tad_carlucci> src/gui/widgets/size_lock.hpp:63:7: error: 'set_size' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
20161120 01:55:59-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161120 01:56:57< irker462> wesnoth: Celtic Minstrel wesnoth:master 18248c7a7aa3 / src/tests/gui/test_gui2.cpp: Fix includes in unit tests https://github.com/wesnoth/wesnoth/commit/18248c7a7aa3465451415ae161474c53ec241e65
20161120 01:59:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161120 02:13:21< Shiki2> I'm compiling master on debian rigth now. I got three warings like:
20161120 02:13:27< Shiki2> src/actions/attack.cpp:593:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
20161120 02:14:35< celticminstrel> At a glance that seems erroneous, but...
20161120 02:14:36< Shiki2> the last time I compiled from zero on Archlinux recently were no warnings
20161120 02:14:58< celticminstrel> If defender.attacks() is a Boost iterator range, it could have a signed size(), depending on your Boost version.
20161120 02:16:38< Shiki2> so it's due to the old boost version
20161120 02:16:47< celticminstrel> Likely.
20161120 02:17:24< Shiki2> So everything is fine :)
20161120 02:17:30< celticminstrel> Probably!
20161120 02:20:28-!- gfgtdf_ [~chatzilla@x4e369dd7.dyn.telefonica.de] has joined #wesnoth-dev
20161120 02:22:19-!- gfgtdf [~chatzilla@x4e368879.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161120 02:22:22-!- gfgtdf_ is now known as gfgtdf
20161120 02:22:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20161120 02:32:08-!- gfgtdf [~chatzilla@x4e369dd7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161120 02:52:00-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 02:52:01< travis-ci> wesnoth/wesnoth#12126 (master - 18248c7 : Celtic Minstrel): The build is still failing.
20161120 02:52:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177362768
20161120 02:52:01-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 02:57:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161120 03:02:38< irker462> wesnoth: Celtic Minstrel wesnoth:master f31079d099a1 / src/tests/gui/test_gui2.cpp: Fix another include in unit tests https://github.com/wesnoth/wesnoth/commit/f31079d099a136cb09e6195f3df5ad0612b0e6d6
20161120 03:12:34-!- Shiki2 [~Shiki@141.39.226.226] has quit [Ping timeout: 268 seconds]
20161120 03:12:37-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 248 seconds]
20161120 03:13:00-!- Shiki2 [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 03:13:01-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 03:17:46< vultraz> [11:38:27]	celticminstrel	vultraz: This might be the same as pydsigner brought up, but it looks really odd how eg "1x" is right up against the edge. I'm not entirely convinced a multiplication symbol looks good there, actually.
20161120 03:17:51< vultraz> celticminstrel: yeah i fixed that  
20161120 03:18:48< celticminstrel> 'kay
20161120 03:29:24< vultraz> for the record, I think widgets/text.*pp isn't just supposed to be a text box base
20161120 03:29:35< vultraz> so not sure why you named it so
20161120 03:30:23< vultraz> i would call it text_base
20161120 03:37:05< vultraz> or text_item
20161120 03:40:23< irker462> wesnoth: Charles Dang wesnoth:master 733040d1a293 / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/733040d1a2936e0dec3329a954168258d6107a82
20161120 03:53:29< celticminstrel> Oh?
20161120 03:53:37< celticminstrel> Is it the base of something else?
20161120 03:56:07-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 03:56:08< travis-ci> wesnoth/wesnoth#12127 (master - f31079d : Celtic Minstrel): The build has errored.
20161120 03:56:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177369080
20161120 03:56:08-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 03:56:31< celticminstrel> Now what...
20161120 03:59:48< vultraz> no,but it's supposed to be the base of text-based widgets
20161120 03:59:55< celticminstrel> Like?
20161120 04:05:05< vultraz>  there's none yet
20161120 04:06:20< vultraz> anyway
20161120 04:06:27< vultraz> looks like more bad includes in the tests
20161120 04:38:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161120 04:38:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161120 04:39:44-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 04:39:45< travis-ci> wesnoth/wesnoth#12128 (master - 733040d : Charles Dang): The build is still failing.
20161120 04:39:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177373141
20161120 04:39:45-!- travis-ci [~travis-ci@ec2-54-227-82-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 04:45:36-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161120 04:47:42-!- Shiki2 [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161120 05:34:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f147:1b08:2704:6c43] has joined #wesnoth-dev
20161120 05:45:38< irker462> wesnoth: Wedge009 wesnoth:master d10cbb8f445d / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project. https://github.com/wesnoth/wesnoth/commit/d10cbb8f445d7743a066e1c3d44c7adf7e306a6b
20161120 05:45:38< celticminstrel> Thanks.
20161120 05:46:32< celticminstrel> (Maybe I should've included most of that in the big rename PR, but oh well.)
20161120 05:50:26< celticminstrel> Anyway, vultraz, based on the methods it defines, "text_box_base" is clearly intended for text boxes that can be edited, have a selection, etc. It wouldn't make sense to derive label from it, for example. The only other class I can think of might be derived from it would be a multiline textbox.
20161120 06:06:28-!- Appleman1234 [~Appleman1@KD106161213031.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20161120 06:10:29< irker462> wesnoth: Charles Dang wesnoth:master 27b48683b171 / data/gui/window/statistics_dialog.cfg: Statistics Dialog: some WML layout tweaks https://github.com/wesnoth/wesnoth/commit/27b48683b1716805c9bb1ff3f41c385aed5d253f
20161120 06:11:46< vultraz> seems shadowm was the one to figure out the correct method for laying out header cells
20161120 06:11:58< vultraz> i was wrong - border = "all" is correct
20161120 06:12:08< vultraz> celticminstrel: are you fixing the tests?
20161120 06:12:22< celticminstrel> I haven't looked at the latest failuer yet.
20161120 06:13:06< celticminstrel> ^failure
20161120 06:13:20< celticminstrel> If you know how to fix it, please do. If it's still broken tomorrow, I'll look at it.
20161120 06:13:29< celticminstrel> I'll probably go to bed fairly soon.
20161120 06:14:49< irker462> wesnoth: Charles Dang wesnoth:master 6781b498c83e / src/tests/gui/test_gui2.cpp: Fixup includes in tests https://github.com/wesnoth/wesnoth/commit/6781b498c83e840faa8ad02854013b08e161f556
20161120 06:15:07< vultraz> ^ might fix it
20161120 06:29:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f147:1b08:2704:6c43] has quit [Remote host closed the connection]
20161120 06:29:52-!- JyrkiVesterinen [~JyrkiVest@87-100-177-177.bb.dnainternet.fi] has joined #wesnoth-dev
20161120 06:41:10-!- travis-ci [~travis-ci@ec2-54-159-183-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 06:41:11< travis-ci> wesnoth/wesnoth#12129 (master - d10cbb8 : Wedge009): The build is still failing.
20161120 06:41:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177382767
20161120 06:41:11-!- travis-ci [~travis-ci@ec2-54-159-183-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 07:02:47-!- Appleman1234 [~Appleman1@KD106161200068.au-net.ne.jp] has joined #wesnoth-dev
20161120 07:04:13< vultraz> why does travis even run a build on something so obviously NOT something to run a build on :|
20161120 07:06:52< celticminstrel> There's no way for it to know whether it needs to run a build, unless people explicitly tell it by including "[ci skip]" in the commit message.
20161120 07:07:09< celticminstrel> (So, vultraz, wedge009, maybe consider doing that for future project file updates. :) )
20161120 07:07:25< celticminstrel> (Preferably on a line by itself, and not the first line.)
20161120 07:07:46< celticminstrel> (I should too, but I keep forgetting due to using commit -m <_< )
20161120 07:08:36< celticminstrel> ...actually, come to think of it, I could do -m 'Update XCode project' -m '[ci skip]' to get the desired result.
20161120 07:09:10< celticminstrel> (Obviously cmd.exe users need double quotes instead.)
20161120 07:12:43< vultraz> ...huh
20161120 07:12:45< vultraz> ok then
20161120 07:14:49-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 07:14:50< travis-ci> wesnoth/wesnoth#12130 (master - 27b4868 : Charles Dang): The build is still failing.
20161120 07:14:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177384703
20161120 07:14:50-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 07:28:49-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161120 07:43:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161120 08:02:57-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 08:02:58< travis-ci> wesnoth/wesnoth#12131 (master - 6781b49 : Charles Dang): The build is still failing.
20161120 08:02:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177384982
20161120 08:02:59-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 08:14:21< irker462> wesnoth: Charles Dang wesnoth:master 75ffbc46c549 / src/tests/gui/test_gui2.cpp: More test fixup https://github.com/wesnoth/wesnoth/commit/75ffbc46c549295908ef63a42b100d046d0d90b2
20161120 08:50:10-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161120 09:11:40-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has joined #wesnoth-dev
20161120 09:11:41< travis-ci> wesnoth/wesnoth#12132 (master - 75ffbc4 : Charles Dang): The build was fixed.
20161120 09:11:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/177392505
20161120 09:11:41-!- travis-ci [~travis-ci@ec2-54-80-97-140.compute-1.amazonaws.com] has left #wesnoth-dev []
20161120 09:11:46< vultraz> ermeghard
20161120 09:23:18< JyrkiVesterinen> celticminstrel: Please add Boost.Spirit to https://github.com/aquileia/external
20161120 09:23:46< JyrkiVesterinen> MSVC builds using it are broken because Boost.Spirit isn't present there.
20161120 09:24:29< JyrkiVesterinen> Same problem that tad_carlucci reported in this channel last night (from my perspective).
20161120 09:28:15< irker462> wesnoth: Jyrki Vesterinen wesnoth:master f50d234774ac / src/gui/widgets/ (size_lock.cpp size_lock.hpp): Fix: size_lock accidentally overrides widget::set_size() https://github.com/wesnoth/wesnoth/commit/f50d234774ac911ea1d406a503ac8fe61e3ed0f4
20161120 09:29:33-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161120 09:29:33-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161120 10:16:44-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has joined #wesnoth-dev
20161120 10:37:25-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has quit [Remote host closed the connection]
20161120 10:52:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161120 11:03:05-!- DeFender1031 [~DeFender1@46-116-88-23.bb.netvision.net.il] has quit [Read error: Connection reset by peer]
20161120 11:15:03-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161120 11:38:47-!- JyrkiVesterinen [~JyrkiVest@87-100-177-177.bb.dnainternet.fi] has quit [Quit: .]
20161120 12:02:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161120 12:06:13-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has joined #wesnoth-dev
20161120 12:22:39-!- DeFender1031 [~DeFender1@46-116-58-100.bb.netvision.net.il] has joined #wesnoth-dev
20161120 12:33:46-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has joined #wesnoth-dev
20161120 12:33:47-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has quit [Changing host]
20161120 12:33:47-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20161120 12:34:00< mordante> servus
20161120 12:35:13-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161120 12:43:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161120 13:25:43-!- bslsk [~Kitteh@162.243.251.6] has joined #wesnoth-dev
20161120 13:29:25-!- bslsk [~Kitteh@162.243.251.6] has quit [Remote host closed the connection]
20161120 13:34:41-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161120 13:34:48-!- irker462 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161120 13:37:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20161120 13:37:09-!- wedge010 is now known as wedge009
20161120 13:41:44-!- JyrkiVesterinen [~JyrkiVest@87-92-29-27.bb.dnainternet.fi] has joined #wesnoth-dev
20161120 13:44:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161120 13:49:18< vultraz> mordante: hey, had any chance to look at that credits issue?
20161120 13:50:26-!- DeFender1031 [~DeFender1@46-116-58-100.bb.netvision.net.il] has quit [Ping timeout: 264 seconds]
20161120 14:03:30-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161120 14:06:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20161120 14:06:15-!- wedge010 is now known as wedge009
20161120 14:06:47-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161120 14:26:36-!- Bonobo [~Bonobo@2001:44b8:254:3200:9c88:26a4:5207:c87d] has quit [Ping timeout: 260 seconds]
20161120 15:11:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161120 15:36:05-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161120 15:36:23-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161120 15:50:25-!- irker165 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161120 15:50:26< irker165> wesnoth: Charles Dang wesnoth:master 325aef0a1bc2 / src/game_initialization/multiplayer.cpp: Removed a call to set_resolution https://github.com/wesnoth/wesnoth/commit/325aef0a1bc29bdd857a88cbba8dc3eccd502616
20161120 15:52:13-!- midzer_ is now known as midzer
20161120 15:57:19-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161120 15:58:36-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161120 15:59:30-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161120 15:59:30-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161120 16:00:03-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161120 16:32:01-!- gfgtdf [~chatzilla@x4e369dd7.dyn.telefonica.de] has joined #wesnoth-dev
20161120 17:54:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161120 18:03:21-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 18:07:53-!- markus__ [~mjs-de@x4db6b311.dyn.telefonica.de] has joined #wesnoth-dev
20161120 18:11:30-!- mjs-de [~mjs-de@x4db6dcf0.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20161120 18:17:27-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 246 seconds]
20161120 18:18:58-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 18:25:15-!- gfgtdf [~chatzilla@x4e369dd7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161120 18:26:16-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161120 18:27:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f147:1b08:2704:6c43] has joined #wesnoth-dev
20161120 18:29:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f147:1b08:2704:6c43] has quit [Remote host closed the connection]
20161120 18:31:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161120 18:45:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161120 18:48:24< celticminstrel> "border" is really "margin" in GUI2, right?
20161120 18:50:32-!- irker165 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161120 19:02:57-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20161120 19:03:22-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 19:08:20< celticminstrel> Hmm, I wonder, does placement=location_name find a free space or overwrite?
20161120 19:16:32< zookeeper> Jetrel_bot, you've seen a lot of palette rotation animations, so what do you think, how difficult would it be to paint the bright blue water on top of the towers and walls so that it would animate nicely with palette rotation? https://dl.dropboxusercontent.com/u/63964618/wesnoth/merfolk_keep_water.png
20161120 19:16:54< zookeeper> because i think that might actually be a good approach in this particular case.
20161120 19:17:41< zookeeper> (i _think_ it could technically be done, or else i wouldn't asking... but i'm not yet completely sure)
20161120 19:33:14-!- gfgtdf [~chatzilla@x4e369dd7.dyn.telefonica.de] has joined #wesnoth-dev
20161120 19:47:52-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161120 20:14:33-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has joined #wesnoth-dev
20161120 20:26:44-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161120 21:03:12-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 260 seconds]
20161120 21:06:51-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161120 21:34:13< mordante> vultraz, no haven't found time for it yet
20161120 21:34:41< mordante> I'm off bye
20161120 21:34:45-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20161120 21:34:54 * celticminstrel wants to know what he was talking about now.
20161120 21:40:59-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161120 21:57:35-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161120 21:58:44-!- JyrkiVesterinen [~JyrkiVest@87-92-29-27.bb.dnainternet.fi] has quit [Quit: .]
20161120 21:59:09< tad_carlucci> Do we have an alternative to https://github.com/aquileia/external for prebuilts for MSVC supporting libraries? The issue building for Windows is that unless you by-hand upgrade to add the missing Boost components, you cannot build Wesnoth.
20161120 22:00:03-!- markus__ [~mjs-de@x4db6b311.dyn.telefonica.de] has quit [Remote host closed the connection]
20161120 22:15:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161120 22:16:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161120 22:23:08-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161120 22:40:46< gfgtdf> tad_carlucci: afaik thse xtrnal pckages use alredy boost 1.62
20161120 22:41:20< gfgtdf> tad_carlucci: so not sure what you mena by by-hand-upgrading
20161120 22:41:50< tad_carlucci> gfgtdf, I just checked and they're missing pieces and aprts.
20161120 22:42:15< gfgtdf> tad_carlucci: hmm u suppose you could add them if you want
20161120 22:42:25< celticminstrel> gfgtdf: The external packages omit Boost headers that Wesnoth doesn't actually used.
20161120 22:42:35< tad_carlucci> Not an option. It's not my computer.
20161120 22:42:48< celticminstrel> Which means that if someone starts using a new header, anyone using that repo will be unable to build.
20161120 22:42:58< tad_carlucci> The computer has Boost 1.62.0 (full) install but not where out project can find it. 
20161120 22:43:08< gfgtdf> tad_carlucci: you mean you currently wokr on a differnt computer? thne you can do that as soon as you get to your won computer.
20161120 22:43:17< tad_carlucci> So I'm looking into how to override our project files from the environment or commandline
20161120 22:43:33< celticminstrel> tad_carlucci: Couldn't you move or copy the files to where our project can find it?
20161120 22:44:01< celticminstrel> gfgtdf: Presumably he's talking about the appveyor build.
20161120 22:44:26< gfgtdf> tad_carlucci: maybe you can add the boost path to the msvc global include paths.
20161120 22:44:29< tad_carlucci> gfgtdf, This is a service computer for continuous intergration. I can build the boost but it exceeds the time quota. I suppose I could copy several thousand files in case any others are missing.
20161120 22:45:07< celticminstrel> tad_carlucci: Well, this isn't something that needs to be built. It's header-only libraries.
20161120 22:45:19< gfgtdf> wedge009: maybhe you coudl update the msvc extrnal package in https://github.com/aquileia/external ?
20161120 22:45:41< gfgtdf> celticminstrel: boost isn't all header-onyl
20161120 22:46:04< celticminstrel> gfgtdf: I know.
20161120 22:46:18< celticminstrel> gfgtdf: The specific issue here is a header-only library, though.
20161120 22:46:18< tad_carlucci> At some point the 'external' package will need upgrading because it's the recommended build process and our project file assumes it's at ../external
20161120 22:46:39< celticminstrel> gfgtdf: And Boost libraries that aren't header-only probably won't suddenly start being used without discussion.
20161120 22:47:05< tad_carlucci> I should be able to override that for the boost stuff .. just working on it now .. but that's a machine-dependent fix and only for my yml config not a general solution
20161120 22:47:54 * celticminstrel personally just dumps all headers into Program Files\...\VC12\{bin,lib,include}... not sure if that's the recommended approach for working with MSVC, but it makes more sense to me than the ..\external approach.
20161120 22:47:57< tad_carlucci> celticminstrel, BTW gettext_boost.cpp now takes a huge amount of memory and time to compile.
20161120 22:48:11< celticminstrel> tad_carlucci: Well, that's kinda expected.
20161120 22:48:26< vultraz> [08:34:50]	celticminstrel	wants to know what he was talking about now.
20161120 22:48:30< vultraz> celticminstrel: the credits issue
20161120 22:48:40< celticminstrel> Oh, that.
20161120 22:48:53< celticminstrel> I still think breaking it up into multiple widgets is the solution though.
20161120 22:49:14< tad_carlucci> celticminstrel, The "official" boost installer puts them in c:\local .. which I hate and use c:\Program Files... too but for this test it is close enough to what the yml config needs so I'm using it
20161120 22:49:59< vultraz> building boost is rather easy
20161120 22:50:16< celticminstrel> Unless you have to coax it into using clang.
20161120 22:50:25< tad_carlucci> vultraz, And it's possible to do it on the CI machine. But it takes too long when added to our build.
20161120 22:50:29< celticminstrel> And libc++
20161120 22:50:40< celticminstrel> But it takes a long time.
20161120 22:50:46< celticminstrel> Easy but time-consuming.
20161120 22:51:07< vultraz> true
20161120 22:51:14< vultraz> don't want to add 10 minutes to every build
20161120 22:51:17< tad_carlucci> Besides, the official Boost binaries are there. I just need to override the library and include settings in our VC12 project file without actually changing our project file.
20161120 22:51:26< celticminstrel> vultraz: Probably a lot more than 10 minutes.
20161120 22:52:03< tad_carlucci> I get a 1-hour quote. We presently use 49 to 51 minutes of that.
20161120 22:52:38< vultraz> the actual build time for boost for me is pretty short
20161120 22:52:41< celticminstrel> Whoa.
20161120 22:53:11< celticminstrel> That's not even including tests, right? Since the C++ ones aren't in the MSVC project and the WML ones can't be batch-run on Windows right now.
20161120 22:54:09< tad_carlucci> celticminstrel, No, that's including the tests. Our VC12 project file builds both wesnoth and test and runs 161 tests automatically when I use MSBUILD. 
20161120 22:54:27< celticminstrel> Oh. Okay, I misremembered then, I guess.
20161120 22:54:55< tad_carlucci> The Boost Test tests take about 30 to 50 seconds each and there's 160 of them. 
20161120 22:55:00< celticminstrel> Is that Boost unit tests only, or also the WML tests?
20161120 22:55:12< celticminstrel> Okay.
20161120 22:55:20< tad_carlucci> just thge boost test test run using the 'test.exe
20161120 22:55:24< celticminstrel> What's the last test then?
20161120 22:55:45< celticminstrel> You said 161 and then 160.
20161120 22:55:49< tad_carlucci> Dunno. When it succeeds all is sayss is 161 of 161 p-assed
20161120 22:56:06< celticminstrel> Okay then.
20161120 22:57:01< tad_carlucci> anyway .. gtg .. after asking the original question I dug into the CI machine and found boost so it's just a matter of overriding to get spirit/po to compile
20161120 22:57:08-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161120 23:21:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161120 23:22:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161120 23:25:50-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161120 23:27:32-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
--- Log closed Mon Nov 21 00:00:08 2016