--- Log opened Tue Nov 22 00:00:12 2016
20161122 00:06:43< gfgtdf> celticminstrel: now that gettext.cpp is gonce, i think its best to rename gettext_boost.cpp to just gettext.cpp, same for filesystem_boost.cpp
20161122 00:17:26-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20161122 00:24:52< celticminstrel> Makes sense.
20161122 00:25:11< celticminstrel> Though for filesystem we have filesystem_boost, filesystem_common, and filesystem_sdl.
20161122 00:36:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161122 00:36:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161122 00:41:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161122 00:58:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 00:58:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 00:59:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161122 00:59:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 00:59:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161122 01:08:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 01:22:27< gfgtdf> celticminstrel: i wonder whether filesystem_sdl is still needed now that we use SDL2
20161122 01:22:44< celticminstrel> I think it is.
20161122 01:22:50< gfgtdf> celticminstrel: iirc we onyl needed it to work around bug in SDL_mixer on windows.
20161122 01:23:04< celticminstrel> Really? I assumed it was used for loading images with SDL_image.
20161122 01:23:15< celticminstrel> But I never really looked, so I could be wrong.
20161122 01:24:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161122 01:25:50< gfgtdf> celticminstrel: see my last comment here  https://github.com/wesnoth/wesnoth/pull/155
20161122 01:35:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 01:36:34< gfgtdf> celticminstrel: and for the filesystem_common.cpp: that was afaik oynl split of to not have that code twice while there were 2 filesystem implementations
20161122 01:42:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161122 01:57:35< EliDupree> Today was a good day. I released a new version of EoHS and had more brilliant ideas about how to make real-time games in wesnoth (like my Tetris)
20161122 01:57:49< EliDupree> The main obstacle is having smooth graphics.
20161122 02:17:04-!- gfgtdf_ [~chatzilla@x4e36890a.dyn.telefonica.de] has joined #wesnoth-dev
20161122 02:19:56-!- gfgtdf [~chatzilla@x4e32b2ee.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161122 02:19:58-!- gfgtdf_ is now known as gfgtdf
20161122 03:08:07-!- gfgtdf [~chatzilla@x4e36890a.dyn.telefonica.de] has quit [Remote host closed the connection]
20161122 03:22:45-!- Appleman1234 [~Appleman1@KD106161205095.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20161122 04:14:28-!- JyrkiVesterinen [~JyrkiVest@87-100-205-149.bb.dnainternet.fi] has joined #wesnoth-dev
20161122 04:39:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 04:39:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 05:01:03-!- stikonas_ is now known as stikonas
20161122 05:01:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161122 05:10:56-!- irker825 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161122 05:15:29-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: I'll Be Back!]
20161122 05:16:30-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20161122 05:37:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161122 06:00:16< wedge009> JyrkiVesterinen: I added the spirit/home headers just before I left for work. Don't know if you had a chance to try again.
20161122 06:00:48< JyrkiVesterinen> I didn't know that you had added them. I'll try again right now.
20161122 06:06:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 06:08:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 06:08:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161122 06:09:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 06:09:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161122 06:09:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 06:10:00-!- Appleman1234 [~Appleman1@KD106161210210.au-net.ne.jp] has joined #wesnoth-dev
20161122 06:11:14-!- Appleman1234 [~Appleman1@KD106161210210.au-net.ne.jp] has quit [Remote host closed the connection]
20161122 06:11:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20161122 06:14:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161122 06:15:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 06:22:35-!- Appleman1234 [~Appleman1@KD106161210210.au-net.ne.jp] has joined #wesnoth-dev
20161122 06:23:29< JyrkiVesterinen> 1>i:\battle for wesnoth\external\include\boost\spirit\home\support\attributes.hpp(23): fatal error C1083: Cannot open include file: 'boost/fusion/include/filter_if.hpp': No such file or directory
20161122 06:23:38< JyrkiVesterinen> So, we need Boost.Fusion as well-
20161122 06:23:41< JyrkiVesterinen> .
20161122 06:24:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161122 06:30:54-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161122 06:39:58-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161122 06:56:40< wedge009> Crikey, this could take a while.
20161122 06:57:24< JyrkiVesterinen> This would be so much faster if I had push access. I could just fix the problem myself in that case. :/
20161122 06:57:27< wedge009> I didn't have to recompile boost when spirit_po was merged, so hopefully there's nothing on the library side that's needed.
20161122 06:57:36< wedge009> Maybe ask aquileia.
20161122 06:57:49< wedge009> Or you could just use your own boost? ;)
20161122 06:58:38< JyrkiVesterinen> I have thought about just rebuilding Boost locally as a stopgap.
20161122 06:59:24< JyrkiVesterinen> The repository has instructions on "updating Boost" in its README. I can just follow them (with the necessary changes to add missing libraries).
20161122 07:01:18< vultraz> aren't fusion and spirit header libs?
20161122 07:02:26< wedge009> Probably. I didn't need to do anything specific when spirit_po was added.
20161122 07:02:44< vultraz> neither did i
20161122 07:03:37< vultraz> then again, im using the full boost sources because following those instructions give me missing file errors at wesnoth build time.
20161122 07:04:11< vultraz> just building the listed libraries and then copying all the source files works fine for me.
20161122 07:06:19< wedge009> I think I'm the same. I only build the libraries in aquileia's instructions (doing all takes a lot longer) but also point VC to all the headers included from the distribution.
20161122 07:06:38< wedge009> JyrkiVesterinen: I've added the rest of the boost fusion headers in VC12 and VC14.
20161122 07:10:00< JyrkiVesterinen> 1>i:\battle for wesnoth\external\include\boost\spirit\include\phoenix_function.hpp(11): fatal error C1083: Cannot open include file: 'boost/phoenix/function.hpp': No such file or directory
20161122 07:10:13< JyrkiVesterinen> Boost.Phoenix?
20161122 07:10:23< wedge009> Okay, may as well add the rest of spirit as well. ):
20161122 07:13:57< wedge009> Oh wait.
20161122 07:13:59< wedge009> Misread. x.x
20161122 07:14:07< wedge009> Yeah, okay, boost phoenix it is.
20161122 07:15:16 * JyrkiVesterinen wonders what Boost.Phoenix even is... or how the Boost authors come up with these names, for that matter. 
20161122 07:17:31-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 07:17:31< wedge010> JyrkiVesterinen: Done.
20161122 07:17:36< wedge010> And yes, I was thinking something similar.
20161122 07:17:41< vultraz> "Phoenix enables Functional Programming (FP) in C++. The design and implementation of Phoenix is highly influenced by FC++ by Yannis Smaragdakis and Brian McNamara and the BLL (Boost Lambda Library) by Jaakko Jaarvi and Gary Powell. Phoenix is a blend of FC++ and BLL using the implementation techniques used in the Spirit inline parser."
20161122 07:17:52< wedge010> Ooh, FP.
20161122 07:19:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161122 07:19:53-!- wedge010 is now known as Wedge009
20161122 07:20:28< JyrkiVesterinen> Okay, that hopefully did it. I am now getting compiler errors because of missing constexpr support.
20161122 07:20:29< JyrkiVesterinen> 1>i:\battle for wesnoth\wesnoth\src\spirit_po\catalog_metadata.hpp(85): error C2065: 'constexpr' : undeclared identifier
20161122 07:21:26< vultraz> also, this is at the bottom of the manual page, so might explain the name: "...To Joel's dear daughter, Phoenix"
20161122 07:21:34< JyrkiVesterinen> I can't know for sure until those problems are fixed. If any of those Boost libraries is not header-only, the problem will show up as linking errors (which I can't get until compile errors are fixed).
20161122 07:21:51< vultraz> blagh
20161122 07:22:00< vultraz> vc13?
20161122 07:22:08< Wedge009> No such thing.
20161122 07:22:12< Wedge009> They skipped the number for some reason.
20161122 07:22:18< vultraz> msvc2013
20161122 07:22:25< vultraz> vs
20161122 07:22:27< vultraz> or somethinng
20161122 07:22:32< vultraz> vc 12 i guess it is?
20161122 07:22:35< JyrkiVesterinen> Yes. I use MSVC2013, also known as VC12.
20161122 07:22:43< vultraz> well that explains it
20161122 07:23:01< Wedge009> VC12 is... yeah, what Jyrki said.
20161122 07:23:17< vultraz> i wonder if we should drop 2013
20161122 07:23:30< JyrkiVesterinen> I'll try to fix the compile errors in the evening. Now I need to go to work.
20161122 07:23:31< vultraz> zookeeper: are you still using 2013?
20161122 07:23:34-!- JyrkiVesterinen [~JyrkiVest@87-100-205-149.bb.dnainternet.fi] has quit [Quit: .]
20161122 07:23:39< zookeeper> yes
20161122 07:24:08< vultraz> can you upgrade to 2015 if necessary?
20161122 07:24:10< Wedge009> constexpr isn't even done properly in VC14/2015 either is it?
20161122 07:24:46< vultraz> it's in 14
20161122 07:25:17< vultraz> only thing 14 doesn't have is Expression SFINAE
20161122 07:25:48< vultraz> (for c++11)
20161122 07:25:52< zookeeper> vultraz, i don't know
20161122 07:25:58< vultraz> it does *not* have "Extended constexpr" from c++14
20161122 07:26:01< vultraz> whatever that is
20161122 07:27:28< vultraz> aw, 14 doesn't have Variable templates
20161122 07:27:30< vultraz> :(
20161122 07:27:37< vultraz> dammit, microsoft, pick up your game.
20161122 07:54:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 07:59:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161122 08:11:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161122 08:13:27-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161122 08:15:50< JyrkiVesterinen> 20161122 07:25:58< vultraz> it does *not* have "Extended constexpr" from c++14
20161122 08:15:50< JyrkiVesterinen> 20161122 07:26:01< vultraz> whatever that is
20161122 08:16:21< JyrkiVesterinen> Extended constexpr significantly extends the amount of constructs allowed in constexpr functions.
20161122 08:16:53< JyrkiVesterinen> In C++14, constexpr functions can contain variables, if statements and even loops.
20161122 08:17:58< JyrkiVesterinen> IMO, extended constexpr is way more useful than the restricted C++11 constexpr. In many cases, it can be used to avoid template magic (such as the kind used all over the place in GUI2 core).
20161122 08:18:40< vultraz> if statements?
20161122 08:18:54< vultraz> like, if constexpr()? I though that was c++17
20161122 08:19:03< JyrkiVesterinen> https://en.wikipedia.org/wiki/C%2B%2B14#Relaxed_constexpr_restrictions
20161122 08:20:25< JyrkiVesterinen> It means stuff like this: https://gist.github.com/jyrkive/0f5dd6fabe1a05271ef9b2f59f5ee99c
20161122 08:22:27< vultraz> oh, so not if constexpr.
20161122 08:36:02< iceiceice> i think the best thing in C++14 is probably generic lambdas
20161122 08:36:06< iceiceice> idk, my opinion
20161122 08:36:12< iceiceice> the constexpr is good too
20161122 08:37:23< iceiceice> JyrkiVesterinen, boost::phoenix is sort of like, lambda type things for C++03
20161122 08:37:33< JyrkiVesterinen> I find extended constexpr the biggest improvement in C++14.
20161122 08:37:36< iceiceice> spirit and phoenix are all both pretty old
20161122 08:38:12< iceiceice> i didnt play around with "spirit x3" yet
20161122 08:38:15< iceiceice> it is on my todo list
20161122 08:38:26< iceiceice> supposed to be a C++14-enabled rewrite of spirit
20161122 08:50:45-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has joined #wesnoth-dev
20161122 08:59:36-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has quit [Ping timeout: 252 seconds]
20161122 09:03:56-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161122 09:27:05< zookeeper> ohh, haha. my macro arguments feature has an interesting side-effect: you can use it to re-define any macro used inside that macro call.
20161122 09:27:08< zookeeper> like, if HIGHLIGHT_IMAGE used the DELAY macro internally, then you could do {HIGHLIGHT_IMAGE foo bar (DELAY="[sound] sound=heal.wav [/sound]")} to turn those delays into sounds :>
20161122 09:29:25< zookeeper> or, rather {HIGHLIGHT_IMAGE foo bar (DELAY=[sound] sound=heal.wav [/sound])} to be precise
20161122 09:31:44< DeFender1031> zookeeper, isn't that true of regular arguments as well?
20161122 09:32:22< zookeeper> sure?
20161122 09:32:57< zookeeper> but no one can modify the internals of your macro in weird ways when calling it, unless you've allowed it
20161122 09:34:13< DeFender1031> how is that any different here though?
20161122 09:34:36< zookeeper> in the way i described. i don't see what you're asking.
20161122 09:34:45< DeFender1031> http://paste.nachsoftware.com/DeFender1031/DxpjXh5f0ffab19f799c5cbdd5834113194b0bkW
20161122 09:35:29< DeFender1031> if you create a parameter called "A", the A macro is overridden with the A parameter. This is true whether it has a default or not.
20161122 09:35:50< DeFender1031> So I'm not sure what's special about your case that didn't already exist.
20161122 09:36:27< zookeeper> well all i can do is keep repeating myself
20161122 09:36:55< DeFender1031> oh
20161122 09:36:58< DeFender1031> ohhhh
20161122 09:37:01< zookeeper> yes :P
20161122 09:37:29< DeFender1031> meaning, you can pass stuff that ISN'T actually specifically set as a parameter internally to the macro and it will STILL override it
20161122 09:37:35< zookeeper> yes
20161122 09:39:02< DeFender1031> well, there's two things you can do, you can either check that stuff being passed is actually defined as an argument inside the macro, which would avoid that, or you could leave it and call it a feature, as there's no harm in it, since it can't be encountered accidentally and there's no ambiguity
20161122 09:39:21< DeFender1031> personally, i lean toward the latter, because that could be a pretty interesting feature.
20161122 09:39:27< zookeeper> yeah i kind of like it
20161122 09:40:15< zookeeper> i bet it would be useful in some rare situations, and hitting it accidentally seems very unlikely indeed
20161122 09:40:31< DeFender1031> btw, about "no one can modify the internals of your macro in weird ways when calling it, unless you've allowed it" that's not entirely true, you can always undef and redef a macro that the macro you're calling uses. This is basically just on-the-fly redeffing in a localized scope.
20161122 09:40:36< DeFender1031> (Which is pretty cool.)
20161122 09:42:09< zookeeper> sure... although you can't then revert the macro back to the original anymore, you're stuck with your redef'd versions
20161122 09:42:45< zookeeper> (except by including the file containing the original definition, of course... but then you're in practise gonna get a bunch of redef without undef warnings)
20161122 09:42:54< DeFender1031> well, you could always redef it back to whatever the original code was, but that's what i meant by "on-the-fly with a localized scope"
20161122 09:43:11< DeFender1031> hmmmmmmm
20161122 09:43:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 09:43:16< DeFender1031> just realized something else
20161122 09:45:34< DeFender1031> {HIGHLIGHT_IMAGE foo bar (DELAY=[sound] sound=heal.wav [/sound]{DELAY 300)}
20161122 09:46:06< DeFender1031> erm... missing a }
20161122 09:46:43< DeFender1031> but the point is, based on what you're telling me, this should work, and you should be able to USE existing macros as part of the redefinition
20161122 09:47:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20161122 09:47:19< DeFender1031> though... now that you've realized this, perhaps there ought to be a way to add parameters to arguments...
20161122 09:47:43< DeFender1031> though that could get very crazy
20161122 09:47:56< zookeeper> i did want this to be simple, so i don't think so... :p
20161122 09:59:42-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 10:01:18-!- Wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161122 10:02:06-!- wedge010 is now known as wedge009
20161122 10:06:10-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has joined #wesnoth-dev
20161122 10:35:39-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has quit [Ping timeout: 252 seconds]
20161122 11:11:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161122 11:31:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 11:35:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161122 12:09:29-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161122 12:17:58-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has joined #wesnoth-dev
20161122 12:22:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161122 12:38:51-!- RatArmy [~RatArmy@om126204196053.6.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20161122 12:43:21< zookeeper> ehh... "std::vector< std::string > const &foo" is not equal to "const std::vector< std::string > &foo", right?
20161122 12:43:39< vultraz> it is
20161122 12:44:19< zookeeper> mmkay
20161122 12:44:44< vultraz> use const std::vector<std::string>& foo, though
20161122 12:48:16-!- Kwandulin [~Miranda@93.221.43.143] has joined #wesnoth-dev
20161122 12:49:49< zookeeper> yeah, i figured
20161122 12:50:08< zookeeper> i ought to get a PR for the macro arguments thing up sometime today
20161122 12:56:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161122 13:12:31< DeFender1031> came up with a new word today: "Hacro". A macro whose sole purpose is to hack around some code deficiency.
20161122 13:12:44< DeFender1031> or "Hackro" even/
20161122 13:12:48< DeFender1031> .*
20161122 13:14:06< vultraz> :D
20161122 13:19:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 13:26:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161122 13:38:57-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Read error: Connection timed out]
20161122 13:40:37-!- iceiceice [~chris@2601:8b:c303:2c50:a980:e645:31a0:6259] has joined #wesnoth-dev
20161122 13:40:38-!- iceiceice [~chris@2601:8b:c303:2c50:a980:e645:31a0:6259] has quit [Changing host]
20161122 13:40:38-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161122 13:46:23< vultraz> zookeeper: could you look into updating to msvc 2015, if possible? No hurry, but if you can get 2015 it means we can drop 2013 and adopt c++14. and proper constexpr.
20161122 13:46:59< zookeeper> didn't we just recently adopt the previous c++something
20161122 13:47:40< JyrkiVesterinen> MSVC2015 alone isn't enough to get C++14.
20161122 13:48:02< JyrkiVesterinen> GCC 4.8 (that we still support) has quite poor C++14 support.
20161122 13:48:33< vultraz> Yes.
20161122 13:48:47< vultraz> However, I've already gone into length as to why we could bump to 4.9.
20161122 13:49:04< JyrkiVesterinen> 4.9 is not that much better.
20161122 13:49:50< vultraz> true. However, dropping 2013 would at least mean we have almost complete c++11 support.
20161122 13:50:10< JyrkiVesterinen> Yes, that's correct.
20161122 13:58:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 268 seconds]
20161122 14:09:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161122 14:17:20-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161122 14:17:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161122 14:17:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20161122 14:24:01< tad_carlucci> I take it we no longer support Visual Studio 2013 as a build environment?
20161122 14:24:19< JyrkiVesterinen> We do support it.
20161122 14:24:59< tad_carlucci> Isn't "constexptr" only on VS 2015? Perhaps I'm remembering wrong or we need to change an option for 2013?
20161122 14:25:17< JyrkiVesterinen> Yes, constexpr isn't available in MSVC2013.
20161122 14:25:39< tad_carlucci> OK. So we don't support 2013.
20161122 14:26:12< JyrkiVesterinen> I would have done something about constexpr being used in spirit_po code, but my builds were failing because the aquileia/external repository hadn't been updated.
20161122 14:26:33< tad_carlucci> Mine started working today and it's complaining about constextr not being defined.
20161122 14:26:40< JyrkiVesterinen> Now that repository has been updated to the point that I get the constexpr error.
20161122 14:26:43< tad_carlucci> Plus some minor stuff like ;
20161122 14:27:11< JyrkiVesterinen> I plan to fix the constexpr problem in the evening, about three hours from now.
20161122 14:28:01< tad_carlucci> Ah. OK.  The rest of the errors I'm seeing are here: https://github.com/GregoryLundberg/wesnoth  around line 140
20161122 14:28:29< tad_carlucci> WHY does my copy and paste always randomly chboose the wrong thing
20161122 14:28:38< tad_carlucci> https://ci.appveyor.com/project/GregoryLundberg/wesnoth/branch/master
20161122 14:28:47< tad_carlucci> That's the link to the build report
20161122 14:29:24< JyrkiVesterinen> The error messages I get are identical. I only glanced them quickly earlier.
20161122 14:30:11< JyrkiVesterinen> "Missing ';' before 'const'" and "'default_charset' : undeclared identifier" are both caused by the use of constexpr.
20161122 14:30:31< JyrkiVesterinen> The warning looks like a real problem.
20161122 14:31:04-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20161122 14:31:05< JyrkiVesterinen> I don't know what is going on with the "missing type specifier". I'll take a look in the evening.
20161122 14:32:07< JyrkiVesterinen> Also, I'm not sure if the external repository is good enough to build Wesnoth yet. It will compile once I fix those errors, but it may not link.
20161122 14:32:34< tad_carlucci> Well, my mind isn't into real work this week I was sorta surprised to see it getting even this far. I was going to try using xcopy to overwrite 'extrnal' boost with official and was just checking the build report before starting.
20161122 14:32:52< tad_carlucci> I guess I'll just let it lie for a few more days while y'all work on it.
20161122 14:33:25< JyrkiVesterinen> Broken builds with any toolset are obviously considered high-priority problems.
20161122 14:33:59< vultraz> tad_carlucci: we use the CONSTEXPR macro, which expands to 'const' or something on msvc2013
20161122 14:34:07< vultraz> constexpr everywhere else
20161122 14:35:36< JyrkiVesterinen> But there is a lowercase constexpr here: https://github.com/wesnoth/wesnoth/blob/cbf1c50bb52bde706b7f730c2a9d1a4abe4742bd/src/spirit_po/catalog_metadata.hpp#L85
20161122 14:35:48< vultraz> yes
20161122 14:35:55< JyrkiVesterinen> Just an oversight, but it breaks MSVC2013 builds.
20161122 14:35:56< vultraz> spiritpo was not written with 2013 support
20161122 14:37:00< tad_carlucci> Considering how long it takes and the memory used, I'm just hoping Wesnoth still fits inside the quotas for AppVeyor.
20161122 14:38:03< vultraz> zoo keeper is the only reason we kept 2013 support
20161122 14:39:05< tad_carlucci> For me, it's jsut a config option.
20161122 14:44:45< tad_carlucci> For a check, I'm switching the MSVC CI to VS2015
20161122 15:02:32-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161122 15:04:45-!- Kwandulin [~Miranda@93.221.43.143] has quit [Read error: Connection reset by peer]
20161122 15:52:07-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161122 16:42:45-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161122 16:43:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161122 16:59:03-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161122 17:09:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161122 17:09:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 17:11:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20161122 17:11:13-!- wedge010 is now known as wedge009
20161122 17:11:48-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161122 17:22:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 17:23:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 17:23:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161122 17:24:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 17:24:52< vultraz> celticminstrel: you're in charge for the next few days
20161122 17:24:57< vultraz> i'm sick
20161122 17:26:09< vultraz> or, ya know what
20161122 17:26:18< vultraz> any time im absent for a period of time, celticminstrel is in charge
20161122 17:28:00 * celticminstrel pokes loonycyborg about PR 847 and possibly also 616.
20161122 17:28:17< celticminstrel> Also, I forget, did Aginor have any strong objections to 874?
20161122 17:28:28< celticminstrel> Or were his main objections already addressed?
20161122 17:30:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 17:39:17-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20161122 17:39:30< mordante> servus
20161122 17:43:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161122 17:43:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161122 17:45:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 17:54:50< loonycyborg> celticminstrel: I'm planning to get to them when less busy with other stuff :P
20161122 18:07:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161122 18:11:50< zookeeper> [label]s don't seem to show up if they have a team_name=, at least not in SP
20161122 18:16:10-!- JyrkiVesterinen [~JyrkiVest@87-100-190-159.bb.dnainternet.fi] has joined #wesnoth-dev
20161122 18:18:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 18:18:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 18:23:41-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161122 18:28:19< zookeeper> there it is: https://github.com/wesnoth/wesnoth/pull/876
20161122 18:41:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161122 18:46:52< Soliton> seems fine on a quick look.
20161122 18:48:48< celticminstrel> Does it complain if it sees #arg outside of a macro definition?
20161122 18:49:14< zookeeper> it ought to complain in the same way as without the feature, so... yes :P
20161122 18:50:20< celticminstrel> Eh? It assumed a # meant enddef?
20161122 18:50:48< zookeeper> no, it's just the only one it was specifically checking
20161122 18:51:01< zookeeper> hence when it was a # it assumed it might be the beginning of an #enddef
20161122 18:51:07< zookeeper> s/was/saw
20161122 18:52:41< celticminstrel> So once it found # it just skipped characters assuming it was an enddef...
20161122 18:53:00< celticminstrel> Oh hey, there is an error about nested #define.
20161122 18:53:51< celticminstrel> I'm just wondering, what if the # was an ifdef instead?
20161122 18:53:58< celticminstrel> Or had it already checked for that?
20161122 18:54:22< celticminstrel> Or wait, does it resolve those at definition time or at substitution time?
20161122 18:54:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161122 18:55:00-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20161122 18:55:05< celticminstrel> Sorry, these aren't comments on the actual code but rather on the existing preprocessor behaviour.
20161122 19:25:26-!- gfgtdf [~chatzilla@x4e36890a.dyn.telefonica.de] has joined #wesnoth-dev
20161122 19:26:34< gfgtdf> celticminstrel: i think on substutution time, im particular i have seen codes like #define A \n{B} +#endef \n #define B .. \n {A} quite a few times
20161122 19:27:01< gfgtdf> celticminstrel: "#define A \n{B} +#endef \n #define B .. \n#endef\n {A}" i meant
20161122 19:30:26-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161122 19:50:21-!- irker031 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161122 19:50:21< irker031> wesnoth: Jyrki Vesterinen wesnoth:master ae60ff80e666 / src/spirit_po/ (catalog.hpp catalog_metadata.hpp wesnoth_fix_vc12_build.patch): Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/ae60ff80e666e0fffde36fca699dae150eef8ab3
20161122 19:50:43< JyrkiVesterinen> Building the game with MSVC2013 and aquileia/external works now. :)
20161122 19:59:18-!- JyrkiVesterinen [~JyrkiVest@87-100-190-159.bb.dnainternet.fi] has quit [Quit: Going to bed]
20161122 20:01:24< celticminstrel> \o/
20161122 20:20:13-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 20:20:27-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161122 20:20:34-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 20:23:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20161122 20:48:26-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161122 20:50:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 20:55:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161122 20:58:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 21:51:02-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161122 21:59:34-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161122 22:14:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161122 22:15:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161122 22:19:22-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161122 22:19:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161122 22:35:46-!- travis-ci [~travis-ci@ec2-54-205-230-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20161122 22:35:47< travis-ci> wesnoth/wesnoth#12141 (master - ae60ff8 : Jyrki Vesterinen): The build has errored.
20161122 22:35:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178084401
20161122 22:35:47-!- travis-ci [~travis-ci@ec2-54-205-230-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20161122 22:50:25-!- irker031 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161122 23:23:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161122 23:24:38< matthiaskrgr> D: 
20161122 23:25:55< matthiaskrgr> ok, just normal travis hang  ._.
--- Log closed Wed Nov 23 00:00:16 2016