--- Log opened Thu Nov 24 00:00:45 2016
20161124 00:12:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 00:15:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20161124 00:16:40-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20161124 00:21:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 00:52:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161124 01:07:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161124 01:10:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161124 01:34:48-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20161124 01:43:22< Aginor> "a while" turned quite a bit longer
20161124 01:43:33< Aginor> sneaky mertings
20161124 01:50:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:95cc:435c:5708:71e1] has joined #wesnoth-dev
20161124 01:55:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:95cc:435c:5708:71e1] has quit [Ping timeout: 258 seconds]
20161124 01:59:19-!- Bonobo [~Bonobo@2001:44b8:254:3200:21f6:5588:2125:c4d4] has joined #wesnoth-dev
20161124 02:08:15-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 02:13:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161124 02:13:50-!- gfgtdf_ [~chatzilla@x4e36363f.dyn.telefonica.de] has joined #wesnoth-dev
20161124 02:14:35-!- gfgtdf [~chatzilla@x4e3697d0.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161124 02:14:45-!- gfgtdf_ is now known as gfgtdf
20161124 02:52:00-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has quit [Ping timeout: 252 seconds]
20161124 02:57:38-!- louis94 [~~louis94@91.178.240.137] has quit [Ping timeout: 250 seconds]
20161124 03:11:54-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161124 03:14:09-!- gfgtdf [~chatzilla@x4e36363f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161124 03:54:28-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 03:59:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161124 04:00:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 04:06:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161124 04:07:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 04:08:38-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161124 04:30:21-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20161124 04:35:12-!- irker215 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161124 04:53:17-!- JyrkiVesterinen [~JyrkiVest@87-100-147-172.bb.dnainternet.fi] has joined #wesnoth-dev
20161124 06:10:44-!- Appleman1234 [~Appleman1@KD106161201080.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20161124 06:13:42-!- Appleman1234 [~Appleman1@KD106161198200.au-net.ne.jp] has joined #wesnoth-dev
20161124 06:36:57-!- JyrkiVesterinen [~JyrkiVest@87-100-147-172.bb.dnainternet.fi] has quit [Quit: .]
20161124 07:06:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161124 07:13:30-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 07:16:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161124 07:47:12-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161124 07:56:00-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20161124 08:05:13-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20161124 09:36:34< zookeeper> gfgtdf, celticminstrel, $unit.x and $unit.y seem to work correctly with delayed_variable_substitution=yes
20161124 09:37:44< zookeeper> x1,y1,x2,y2 too
20161124 10:03:56< zookeeper> eh, surely a weapon special [filter_self] [filter_weapon] should filter the weapon picked, and not match if _another_ attack that the unit has matches that filter?
20161124 10:04:16< zookeeper> because what i seem to see is the latter
20161124 10:05:16-!- daMark [5439bc64@gateway/web/freenode/ip.84.57.188.100] has joined #wesnoth-dev
20161124 10:06:08-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 10:10:05-!- daMark [5439bc64@gateway/web/freenode/ip.84.57.188.100] has quit [Client Quit]
20161124 10:13:27-!- daMark [5439bc64@gateway/web/freenode/ip.84.57.188.100] has joined #wesnoth-dev
20161124 10:39:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161124 10:39:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 10:59:05< Soliton> is anyone besides Ivanovic currently taking care of translations?
20161124 11:02:48< vultraz> not that i know of
20161124 11:03:11-!- irker572 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161124 11:03:11< irker572> wesnoth: Charles Dang wesnoth:master 586e0c8740c7 / src/ (gui/widgets/helper.cpp sdl/utils.cpp sdl/utils.hpp): Reimplemented string_to_color using gui2::decode_color's implementation https://github.com/wesnoth/wesnoth/commit/586e0c8740c75bf7ec8648a1b20d467155de1474
20161124 11:19:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161124 11:22:05-!- daMark [5439bc64@gateway/web/freenode/ip.84.57.188.100] has left #wesnoth-dev []
20161124 11:22:21< loonycyborg> Soliton: I'm taking care of some aspects, like pot-update
20161124 11:25:01< vultraz> ah, right, that's true
20161124 11:34:18< irker572> wesnoth: Charles Dang wesnoth:master 1546472f941c / src/sdl/utils.cpp: Made use of brace initialization https://github.com/wesnoth/wesnoth/commit/1546472f941c3b6a70d9163de66e2d2ba2eacb63
20161124 11:34:21< irker572> wesnoth: Charles Dang wesnoth:master aeee65d6da70 / src/font/ (marked-up_text.cpp marked-up_text.hpp standard_colors.cpp standard_colors.hpp): Moved more standard SDL_Color definitions to their appropriate file https://github.com/wesnoth/wesnoth/commit/aeee65d6da708058317d34bd79b126c96bd5cc3c
20161124 11:34:24< irker572> wesnoth: Charles Dang wesnoth:master 60450ed1087c / src/font/ (marked-up_text.cpp marked-up_text.hpp): Removed some unused GUI1 color constants stored as strings https://github.com/wesnoth/wesnoth/commit/60450ed1087c5a876c3b5ed221506254dfa2f5ad
20161124 11:45:19< Soliton> just wondering if Ivanovic is still active since he does not seem to respond to german translation questions. i guess he might still check in translations he gets.
20161124 11:46:28< zookeeper> he committed an update to portuguese translation just a few days ago
20161124 11:51:39-!- travis-ci [~travis-ci@ec2-54-204-186-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20161124 11:51:40< travis-ci> wesnoth/wesnoth#12148 (master - 586e0c8 : Charles Dang): The build is still failing.
20161124 11:51:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178559457
20161124 11:51:41-!- travis-ci [~travis-ci@ec2-54-204-186-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20161124 11:56:31-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20161124 12:01:07< irker572> wesnoth: Charles Dang wesnoth:master f5f575898590 / src/font/text_formatting.cpp: Reimplement color2hexa without using sprintf https://github.com/wesnoth/wesnoth/commit/f5f57589859012f7cccc66717bdd5af483ef0cd1
20161124 12:02:37-!- RatArmy [~RatArmy@om126161112076.8.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20161124 12:03:13< JyrkiVesterinen> +1. Sprintf needs to go.
20161124 12:03:29< vultraz> :)
20161124 12:06:06< vultraz> only one use of sprintf left in the codebase
20161124 12:06:49< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/server/simple_wml.cpp#L442
20161124 12:06:49< JyrkiVesterinen> Nice. :)
20161124 12:08:10< JyrkiVesterinen> IIRC, matthiaskrgr once reported that GCC 7 gives a "sprintf buffer is too small" compiler warning. I think you just got rid of that warning.
20161124 12:08:11< vultraz> i'm not.. sure what that is doing.
20161124 12:08:27< vultraz> ill let loonycyborg take care of that last case
20161124 12:08:38< vultraz> JyrkiVesterinen: ah, good, good :D
20161124 12:09:07< JyrkiVesterinen> %d simply converts the integer to string. Std::stoi() should do the same thing.
20161124 12:09:31< vultraz> you mean to_string?
20161124 12:09:46< JyrkiVesterinen> Oh, right. Yes.
20161124 12:10:51< vultraz> ah
20161124 12:10:56< vultraz> ok, i can deal with this, then
20161124 12:13:08< vultraz> not even gonna ask why there's this string_span class that only takes chars... :/
20161124 12:15:34< irker572> wesnoth: Charles Dang wesnoth:master 2f9592d2d8d4 / src/server/simple_wml.cpp: Removed last case of sprintf https://github.com/wesnoth/wesnoth/commit/2f9592d2d8d48b4e8a7757260ad5114d559526eb
20161124 12:20:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161124 12:26:13-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has joined #wesnoth-dev
20161124 12:26:14< travis-ci> wesnoth/wesnoth#12149 (master - 60450ed : Charles Dang): The build is still failing.
20161124 12:26:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178566137
20161124 12:26:14-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has left #wesnoth-dev []
20161124 12:30:49-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161124 12:34:00-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161124 12:43:19-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161124 12:59:01< zookeeper> unit help for a unit with hide_help=yes can't be opened from for example the recruit dialog, although it should work (just like it works through the context menu).
20161124 13:00:01< vultraz> won't fix.
20161124 13:00:19< vultraz> not until gui2 help
20161124 13:01:30< zookeeper> surely it doesn't have anything to do with gui2
20161124 13:01:56< vultraz> no
20161124 13:01:59< vultraz> it doesn't
20161124 13:02:08< vultraz> I just don't care to touch gui1 help. :P
20161124 13:05:03< zookeeper> are you sure that even makes any sense?
20161124 13:05:33< vultraz> i'm too lazy to touch that mountain of garbage code.
20161124 13:07:57< Soliton> i'm curious if you'll get offended when future maintainers refer to your code that way.
20161124 13:07:59< zookeeper> i take that as a "no"
20161124 13:13:11-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161124 13:15:13< vultraz> meh
20161124 13:18:35< vultraz> i challenge anyone to genuinely admit anything in src/help is good code
20161124 13:19:52-!- travis-ci [~travis-ci@ec2-23-20-6-67.compute-1.amazonaws.com] has joined #wesnoth-dev
20161124 13:19:53< travis-ci> wesnoth/wesnoth#12151 (master - 2f9592d : Charles Dang): The build is still failing.
20161124 13:19:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178575096
20161124 13:19:53-!- travis-ci [~travis-ci@ec2-23-20-6-67.compute-1.amazonaws.com] has left #wesnoth-dev []
20161124 14:01:17-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 240 seconds]
20161124 14:11:06< Soliton> not sure if arrogance or stupidity.
20161124 14:32:42-!- Appleman1234 [~Appleman1@KD106161198200.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20161124 14:33:44-!- Appleman1234 [~Appleman1@KD106161198200.au-net.ne.jp] has joined #wesnoth-dev
20161124 14:44:25-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 256 seconds]
20161124 14:46:47-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161124 14:50:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161124 14:51:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161124 14:57:32-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161124 15:00:25-!- Bonobo [~Bonobo@2001:44b8:254:3200:21f6:5588:2125:c4d4] has quit [Quit: Leaving]
20161124 15:12:07< vultraz> meh, i was overly critical, ill admit
20161124 15:12:22< vultraz> but it's still not good code and i really don't want to go poking around with it more than i have to
20161124 15:14:48-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161124 15:16:06-!- irker572 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161124 15:16:11< DeFender1031> I often refer to wesnoth development as more similar to archaeology than to engineering. Like "recent excavations into vector-handling.cpp reveal that the ancient wesnothians considered it good luck to add custom data to the beginning of a vector and re-index anything already referencing existing indexes".
20161124 15:23:56< vultraz> heh
20161124 15:25:44< zookeeper> i guess it's not possible to dynamically set hide_help for a unit via lua or something? doesn't look like it
20161124 15:28:52< zookeeper> well, i guess the relevant bit is that this worked in 1.12 but not anymore, so it's again something someone's broken
20161124 15:33:57< zookeeper> hmh. seems to work correctly still in 1.13.4.
20161124 15:35:24< zookeeper> in 1.13.5 it's broken
20161124 15:40:15-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161124 15:42:57< zookeeper> if i had to guess... i'd guess some mishap in c55d7cb50a4
20161124 15:57:01-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161124 16:09:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161124 16:30:44-!- gfgtdf [~chatzilla@x4e36363f.dyn.telefonica.de] has joined #wesnoth-dev
20161124 16:31:21< gfgtdf> 20161124 10:03:56< zookeeper> eh, surely a weapon special [filter_self] [filter_weapon] should filter the weapon picked, and not match if _another_ attack that the unit has matches that filter?
20161124 16:31:43< gfgtdf> zookeeper: the current haviour is correct, if you wna to filter on the pon use [filter_attack] in [event]
20161124 16:35:52-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161124 16:37:22< zookeeper> gfgtdf, right
20161124 17:04:09< vultraz> celticminstrel: around?
20161124 17:04:57< celticminstrel> ?
20161124 17:07:57< vultraz> celticminstrel: need some code advice. im playing around with the game_config::red_to_green/blue_to_white functions to make them use dynamic linear gradient instead of hardcoded color values, and i can kinda get a gradient, but it's always the wrong shade :/ (method from SO); http://pastebin.com/suYiRyUQ
20161124 17:08:16< vultraz> ie, the colors end up all shades of yellow, or blue/pink, but not red-to-green
20161124 17:09:47-!- JyrkiVesterinen [~jyrki@78-27-120-213.bb.dnainternet.fi] has joined #wesnoth-dev
20161124 17:10:07< vultraz> just the current version
20161124 17:10:10-!- prkc [~prkc@46.166.190.187] has joined #wesnoth-dev
20161124 17:10:19< vultraz> it ends up blue-to-pink if i bitshift it 16/8/0
20161124 17:10:25< celticminstrel> vultraz: Maybe your channel ordering is wrong. You have RGBA, what happens if you try BGRA?
20161124 17:10:41< celticminstrel> Or wait, are you forgetting bitshifts?
20161124 17:10:59< celticminstrel> I have no idea what the formula on eg line 10 means.
20161124 17:11:09-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161124 17:11:15< celticminstrel> If that calculates the red component, you need to shift it by the constant Aginor recently added.
20161124 17:12:04< vultraz> i was trying this interpolation formula: https://stackoverflow.com/questions/27532/generating-gradients-programmatically
20161124 17:12:43< vultraz> don't really understand exactly how it works, though, since im not sure how a color space gradient is set up.
20161124 17:14:05< vultraz> also when is bgra a thing o_O
20161124 17:17:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161124 17:17:07-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161124 17:17:50< vultraz> somehow i end up with 0000FF when i should be getting like, orange...
20161124 17:19:37-!- stikonas_ is now known as stikonas
20161124 17:21:28-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161124 17:22:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161124 17:28:43< vultraz> celticminstrel: for the record bgra doesn't work either
20161124 17:30:17< vultraz> oh hm
20161124 17:30:22< vultraz> ok i kinda got it working
20161124 17:30:30< vultraz> 16/8/0
20161124 17:30:37< vultraz> turns out blue was 24/16/8
20161124 17:31:13-!- JyrkiVesterinen [~jyrki@78-27-120-213.bb.dnainternet.fi] has quit [Quit: Leaving IRC for today]
20161124 17:31:16< zookeeper> sigh. something in weapon special filtering, or at least [filter_opponent], is broken again.
20161124 17:32:05< zookeeper> why can't i fix a single bug of my own without running into two engine bugs
20161124 17:32:33< vultraz> except the colors are off and weird
20161124 17:32:37< vultraz> 40% is correctly orange
20161124 17:32:53< vultraz> but 60% is also orange
20161124 17:32:58< vultraz> 20% is green
20161124 17:33:06< vultraz> wait, 40 is red
20161124 17:33:07< vultraz> :/
20161124 17:33:17< vultraz> ok, so it's...inversed
20161124 17:33:31< vultraz> ...huh
20161124 17:33:39< DeFender1031> zookeeper, archaeology. That's why.
20161124 17:33:49< DeFender1031> (See my earlier comment.)
20161124 17:34:07< zookeeper> DeFender1031, well usually they're not some ancient bug from days past long ago.
20161124 17:34:20< zookeeper> usually they're something someone just broke relatively recently :p
20161124 17:34:41< DeFender1031> Well then, there ought to be someone who you can actually smack for it.
20161124 17:35:08< zookeeper> of course
20161124 17:35:11< zookeeper> if one only knew who
20161124 17:35:32< vultraz> let's swap the colors..
20161124 17:35:36< zookeeper> well usually there's only a handful of potential suspects, but it's polite to make sure before malleting anyone :>
20161124 17:36:13< DeFender1031> zookeeper, git blame?
20161124 17:36:36< DeFender1031> (does git HAVE a blame command?)
20161124 17:36:37< zookeeper> DeFender1031, git blame something-wrong-with-a-filter? i don't think that works.
20161124 17:37:00< DeFender1031> yes! Exactly so!
20161124 17:37:08< celticminstrel> vultraz: BGRA is used by BMP IIRC
20161124 17:37:22< vultraz> huh
20161124 17:37:37< celticminstrel> vultraz: What's with the 16/8/0 vs 24/16/8?
20161124 17:37:48-!- Appleman1234 [~Appleman1@KD106161198200.au-net.ne.jp] has quit [Ping timeout: 258 seconds]
20161124 17:38:30< DeFender1031> zookeeper, sometimes I wish I had a time machine so I could go back in time and smack people for the stupid things they're about to do. Often that person is myself.
20161124 17:38:32< celticminstrel> DeFender1031: git does have a blame command.
20161124 17:38:50< celticminstrel> It tells you the last commit that touched each line of a file.
20161124 17:39:44< vultraz> welp, now it stopped working :|
20161124 17:39:51< vultraz> code y u do dis
20161124 17:40:05< DeFender1031> celticminstrel, yeah, that's how svn's works as well.
20161124 17:40:21< DeFender1031> vultraz, try reversing the polarity.
20161124 17:40:27 * celticminstrel hasn't used svn for years.
20161124 17:42:21< DeFender1031> celticminstrel, it's what we use at work. I actually have strong opinions about why NOT to use git, though many of them, including the largest, don't seem to apply to wesnoth, thankfully.
20161124 17:42:45< vultraz> i swear to god
20161124 17:42:52< vultraz> the result is differet every time i launch the program :|
20161124 17:42:56< vultraz> different
20161124 17:43:47 * celticminstrel is curious now.
20161124 17:44:03< zookeeper> celticminstrel, so have you read the logs?
20161124 17:44:11< celticminstrel> I have not. Should I?
20161124 17:44:14< vultraz> celticminstrel: ok so
20161124 17:44:26< vultraz> 			(((a.r * val + b.r * (1 - val)) << 16 ) ) +
20161124 17:44:27< vultraz> 			(((a.g * val + b.g * (1 - val)) << 8 ) ) +
20161124 17:44:28< celticminstrel> vultraz: The curiosity was at DeFender1031, just FTR
20161124 17:44:29< vultraz> 			(((a.b * val + b.b * (1 - val)) ) ) +
20161124 17:44:30< vultraz> 			SDL_ALPHA_OPAQUE;
20161124 17:44:32< vultraz> appears to work
20161124 17:44:37< vultraz> except the color isn't consistent
20161124 17:44:39< vultraz> :|
20161124 17:44:40< DeFender1031> vultraz, pointer to uninitialized memory perhaps?
20161124 17:44:51< celticminstrel> Why can't you use Aginor's constants?
20161124 17:45:06< celticminstrel> And what do you mean by inconsistent?
20161124 17:45:09< vultraz> his constant is 24 for redshift
20161124 17:45:12< zookeeper> celticminstrel, i was suspecting that maybe you broke something between 1.13.4 and 1.13.5. namely, the help pages for a unit with hide_help=yes can no longer be opened (even from a recruit menu or context menu).
20161124 17:45:13< celticminstrel> Oh.
20161124 17:45:15< DeFender1031> "Aginor's constant" sounds like one of those mathematical theorem things.
20161124 17:45:47< DeFender1031> celticminstrel, curious about my opinions on git? I can take that to PM, don't want to flood the channel with my negativity.
20161124 17:46:09< celticminstrel> zookeeper: Well, I don't remember doing anything that would obviously cause that... I don't recall touching help at all, actually...
20161124 17:46:11< vultraz> ok, it seems to generally work with this
20161124 17:46:15< vultraz> 		SDL_Color a = int_to_color(*color_scale.begin());
20161124 17:46:16< vultraz> 		SDL_Color b = int_to_color(*color_scale.end() - 1);
20161124 17:46:27< vultraz> but the colors are in the wrong order
20161124 17:46:36< vultraz> ie, 20% terrain defense displays with green
20161124 17:46:40< zookeeper> celticminstrel, c55d7cb50a4 seemed pretty big, maybe something went subtly wrong there
20161124 17:47:13< vultraz> but if i swap the values i get blue again :|
20161124 17:47:39< celticminstrel> zookeeper: It's not as big as it seems. https://github.com/wesnoth/wesnoth/commit/c55d7cb50a4?w=1
20161124 17:47:54 * celticminstrel will nevertheless scan it, just in case.
20161124 17:48:36< vultraz> this makes no sense :|
20161124 17:48:56< celticminstrel> vultraz: What are a and b?
20161124 17:49:04< vultraz> i literally just posted what they are
20161124 17:49:15< celticminstrel> No, I mean, what colour are they?
20161124 17:49:26< celticminstrel> The code doesn't tell me that.
20161124 17:49:34< zookeeper> celticminstrel, all the other commits between that timeframe seemed harmless, or containing some other boost/pointer/for/etc/etc conversion stuff which i didn't scan through
20161124 17:49:48< vultraz> e60000 and 00e600
20161124 17:49:49-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161124 17:49:50< vultraz> respectively
20161124 17:49:51< vultraz> i think
20161124 17:49:52< zookeeper> but it seemed to work correctly in 1.13.4 and to be broken from 1.13.5 onwards
20161124 17:50:04< celticminstrel> So, a is red and b is green?
20161124 17:50:08< vultraz> yes
20161124 17:50:20< celticminstrel> You could've just said that instead of posting the hex.
20161124 17:50:27< vultraz> and somehow that results in a low 'val' value yielding green...
20161124 17:50:33< vultraz> lost, I am :|
20161124 17:50:43< celticminstrel> So 20% is displaying green but it should be 80% displaying green while 20% is red, right?
20161124 17:50:55< vultraz> yes
20161124 17:51:07< celticminstrel> What about 10% or 5%?
20161124 17:52:44< vultraz> well, 0% is displaying very green...
20161124 17:52:55< vultraz> so, little darker green, i'd say
20161124 17:53:30< celticminstrel> Sounds like the obvious solution is to swap a and b in the formula.
20161124 17:53:34< vultraz> the weird thing is if i switch the values of a and b i get a blue/pink spectrum again :|
20161124 17:53:46< vultraz> but that just worked earlier!
20161124 17:53:49< vultraz> so now im lost :|
20161124 17:54:19< celticminstrel> Okay, so the per-channel formula is first * p + second * (1 - p)
20161124 17:55:02< celticminstrel> p is in the range [0,1), right?
20161124 17:55:44< vultraz> 1 - 100 in this case
20161124 17:56:03< celticminstrel> Oh, then there's your problem. You need to divide it by 100.
20161124 17:56:13< celticminstrel> (Or by 100.0 I guess.)
20161124 17:56:27< vultraz> it's not a double
20161124 17:56:36< celticminstrel> Irrelevant.
20161124 17:56:49< celticminstrel> The formula expects p to be in the range [0,1).
20161124 17:57:17< celticminstrel> But you actually have the range [0,100].
20161124 17:57:31< celticminstrel> Oh right, 1 is a valid value too, so [0,1].
20161124 17:58:09< celticminstrel> You probably don't need to cast anything to double, just multiple first and then divide by 100.
20161124 17:58:24< vultraz> now everything is yellow again :|
20161124 17:58:28< vultraz> wait, divide what by 100
20161124 17:58:54< celticminstrel> first * p / 100 + second * (1 - p) / 100
20161124 18:00:33< vultraz> now everything is pink-to-white!
20161124 18:00:38< vultraz> light pink*
20161124 18:01:41< celticminstrel> zookeeper: I'm not seeing anything suspicious introduced by that commit.
20161124 18:01:54< zookeeper> celticminstrel, mmkay, must be some other commit then
20161124 18:01:55< celticminstrel> Althuogh I did notice this: https://github.com/wesnoth/wesnoth/commit/c55d7cb50a4?w=1#diff-f996419c63b75999b83027d24c62abcfL290
20161124 18:02:03< celticminstrel> I wonder if it's appropriate to test hide_help() there.
20161124 18:02:44< vultraz> if i swap a and b i get black to green
20161124 18:02:50< vultraz> :|
20161124 18:02:54< vultraz> the hell is happening here
20161124 18:03:00< zookeeper> celticminstrel, i wouldn't know
20161124 18:03:32< zookeeper> vultraz, yeah that's my question too. something really wrong with [chance_to_hit] and/or [filter_opponent] and/or active_on=defense
20161124 18:03:59< celticminstrel> zookeeper: What's the symptom?
20161124 18:04:14< celticminstrel> vultraz: What's your formula now?
20161124 18:04:15< zookeeper> i'm not sure yet
20161124 18:05:30< vultraz> 			((a.r * val / 100 + b.r * (1 - val) / 100) << 16) +
20161124 18:05:31< vultraz> 			((a.g * val / 100 + b.g * (1 - val) / 100) << 8 ) +
20161124 18:05:33< vultraz> 			 (a.b * val / 100 + b.b * (1 - val) / 100)        +
20161124 18:05:34< vultraz> 			SDL_ALPHA_OPAQUE;
20161124 18:05:40< vultraz> and a and b swapped
20161124 18:05:55< vultraz> which gives black on low %s, and darker green on higher ones.
20161124 18:06:22< celticminstrel> vultraz: Try 100 - val
20161124 18:08:48< vultraz> that..actually kinda seems to work :O
20161124 18:08:53< vultraz> \ o /
20161124 18:09:27< vultraz> for some reason 0% is pink, though.
20161124 18:09:31< celticminstrel> Probably want a,b not b,a (ie, unswap them).
20161124 18:09:51< celticminstrel> That has nothing to do with the pink though.
20161124 18:10:24< celticminstrel> Hmm, no, you do want them swapped.
20161124 18:10:52< vultraz> yeah
20161124 18:10:54< celticminstrel> Because if you have a,b then the red component is 0 for 0%, when it should be 0xea or whatever.
20161124 18:11:48< vultraz> sadly, this doesn't directly approximate the old colors :/
20161124 18:11:56< vultraz> since it seems the old colors were not in a linear gradient 
20161124 18:12:00< celticminstrel> Not sure how 0% would become pink...
20161124 18:12:27< celticminstrel> How many degrees did the old colours have?
20161124 18:12:44< celticminstrel> ie color_scale.size()
20161124 18:13:02< vultraz> 11 members, size would be 12.
20161124 18:13:21< celticminstrel> Uh, no, if there's 11 members, size would be 11...
20161124 18:13:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161124 18:13:34< vultraz> oh
20161124 18:13:57< celticminstrel> Huh, so it's actually a specific colour for each value from 0..100 by 10.
20161124 18:13:58< vultraz> ...why have i been thinking size is num members + 1...
20161124 18:14:16< celticminstrel> In the old system, what colour would be selected for 5%?
20161124 18:14:32< vultraz> probably ff0000...
20161124 18:14:33< celticminstrel> The 0% colour, the 10% colour, or the (weighted?) average?
20161124 18:14:52< vultraz> the old formula was a plain 
20161124 18:14:59< vultraz> 		int lvl = (color_scale.size()-1) * val / 100;
20161124 18:15:01< vultraz> 		return color_scale[lvl];
20161124 18:15:17< celticminstrel> So the 0% colour.
20161124 18:15:26< celticminstrel> Wait...
20161124 18:15:56< celticminstrel> val is 5, so that's 10 * 5 / 100, or 0.5... okay yes, the 0% colour.
20161124 18:16:16< vultraz> I think that's e60000...
20161124 18:16:16< gfgtdf> zookeeper: what exactly is teh issue with filter_oppoinent?
20161124 18:16:34< gfgtdf> zookeeper: can help for those untis stil be opened with [open_help] ?
20161124 18:16:35< zookeeper> i'm not sure yet
20161124 18:16:46< zookeeper> gfgtdf, haven't tried that
20161124 18:16:55< zookeeper> most likely not
20161124 18:16:57< celticminstrel> zookeeper: You must be seeing certain things that lead you to believe something is wrong, though.
20161124 18:17:10< gfgtdf> zookeeper: please try with [open_help]
20161124 18:17:20< zookeeper> celticminstrel, well sure, i see wrong values. but that's not very helpful information
20161124 18:17:26< celticminstrel> gfgtdf: If you look at my link earlier, it appears that the topic isn't even generated if it's hidden.
20161124 18:17:52< celticminstrel> Unless I'm misinterpreting that.
20161124 18:18:04< vultraz> anyway, I don't think it's possible to write a polynomial for these values :/
20161124 18:18:19< celticminstrel> What are the values?
20161124 18:18:22< vultraz> I wonder if there's an app i can plug these in an get a curve..
20161124 18:18:25< celticminstrel> (Line number is fine.)
20161124 18:18:37< celticminstrel> (And file, of course.)
20161124 18:18:49< vultraz> oh, huh, the terrain defense mods use the text colors..
20161124 18:18:57< vultraz> celticminstrel: data/game_config.cfg:42
20161124 18:19:11< zookeeper> gfgtdf, what does topic= expect?
20161124 18:19:16< gfgtdf> celticminstrel: i think the code in your links just remoed it form the advance_to unit list
20161124 18:19:20< vultraz> i wonder if i can plug these values into somewhere and get a color curve
20161124 18:19:23< gfgtdf> zookeeper: unit_<unit_type_id> afaik
20161124 18:19:27< celticminstrel> gfgtdf: Ah okay.
20161124 18:19:53< gfgtdf> zookeeper: so unit_Knight for example
20161124 18:20:26-!- irker928 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161124 18:20:26< irker928> wesnoth: Charles Dang wesnoth:master c048d3982ba6 / src/font/ (marked-up_text.cpp marked-up_text.hpp): Removed font::draw_wrapped_text (unused) https://github.com/wesnoth/wesnoth/commit/c048d3982ba64dfb0956f8f0cb423e77350293f4
20161124 18:20:43< vultraz> eh...
20161124 18:20:45< vultraz> hm..
20161124 18:20:46< zookeeper> gfgtdf, same result, "this unit is unknown bla bla"
20161124 18:21:10< vultraz> so the problem with this curve actually is the x step is too wide...
20161124 18:21:34< gfgtdf> zookeeper: do you know an id if a mainline unti to test ?
20161124 18:22:34< celticminstrel> Okay, so the red is c8,dd,dd,dd,dd,dd,a5,6e,37,00,00.
20161124 18:22:45< zookeeper> gfgtdf, Fog Clearer
20161124 18:22:59< celticminstrel> The green is the same, but in reverse.
20161124 18:23:18< zookeeper> gfgtdf, you can create one of them with debug mode, and try to view unit description from context menu
20161124 18:25:46< celticminstrel> vultraz: It's unlikely you'll find a formula for it due to the repeated dd's.
20161124 18:26:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161124 18:26:06< celticminstrel> (And what do you mean about the x step?)
20161124 18:26:21< vultraz> celticminstrel: it's still orange by 60/70
20161124 18:26:24< vultraz> and not green
20161124 18:26:28< vultraz> ish
20161124 18:26:41< celticminstrel> So you're talking about the linear formula?
20161124 18:26:56< vultraz> yes
20161124 18:27:24< vultraz> what it uses for 70 should be like, 40
20161124 18:27:36< celticminstrel> ?
20161124 18:28:05< Soliton> vultraz: https://www.wolframalpha.com/input/?i=interpolating+polynomial+{1,10},{2,3},{4,7},{8,0}&lk=3
20161124 18:28:20< vultraz> if val is 70, the text color is more what it should be like when it's 40
20161124 18:28:49< vultraz> (I say 'should' meaning 'would be desired')
20161124 18:29:03< vultraz> Soliton: ohhh thanks :D
20161124 18:29:27< vultraz> anyway, i think ill work on this tomorrow..
20161124 18:31:10< celticminstrel> For the record, interpolating a polynomial as (x,y) = (red,green) does not work.
20161124 18:31:46< gfgtdf> zookeeper: [open_help] topic=".unit_Fog Clearer" works.
20161124 18:31:57< vultraz> celticminstrel: hm? how would you do it.
20161124 18:32:03< celticminstrel> ?
20161124 18:32:16< zookeeper> gfgtdf, huh, odd
20161124 18:32:18 * zookeeper tries too
20161124 18:32:20< vultraz> how would you do this if you wanted a color gradient between red and green
20161124 18:32:36< celticminstrel> I'm not sure.
20161124 18:34:12< zookeeper> gfgtdf, well that's interesting. so [open_help] _does_ work, although the normal means do not
20161124 18:34:50< zookeeper> or at least [open_help] works when you add that . in the beginning
20161124 18:35:06< Soliton> you have a set of color, percent pairs that you want to interpolate, no?
20161124 18:35:41< vultraz> yes
20161124 18:36:09< Soliton> should be able to put those into wolfram alpha and see what it spits out.
20161124 18:36:54< Soliton> not that i expect it to be more readable/usable than just the values as they are now...
20161124 18:38:26< gfgtdf> zookeeper: actuall i didnt have problem hsoing help for thoe units with context menu eigher
20161124 18:38:57< zookeeper> gfgtdf, really? hmh...
20161124 18:40:15< gfgtdf> zookeeper: testing on 1.13.6
20161124 18:40:38< zookeeper> gfgtdf, so what if you put the Fog Clearer on your recruit list, and then try to open the page from the recruit dialog?
20161124 18:41:50< gfgtdf> zookeeper: didnt test that but form looksing at the cod eit migth not work, i think the problem is that this code https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/unit_preview_pane.cpp#L407 uses help::show_unit_help instead of show_unit_description
20161124 18:42:02< zookeeper> gfgtdf, ok so the thing about the context menu was probably just my fault, i was messing with the help code and didn't recompile after reverting my experiments
20161124 18:44:55< gfgtdf> zookeeper: i wont be able to commit the change i suggested above since i it migth be too complicated for a github commit. (the new function takes a unit_type& not a std::string with its id)
20161124 18:45:06< gfgtdf> for a webpage commit i mean
20161124 18:49:12< zookeeper> vultraz, ^ isn't that in non-garbage code? :p
20161124 19:11:58< vultraz> yes
20161124 19:16:43< zookeeper> ah, my weapon special problem might be a WML bug after all
20161124 19:19:10< zookeeper> having to account for marksman makes this very tricky
20161124 19:19:26< zookeeper> this == the daze special/status, that is
20161124 19:22:43-!- travis-ci [~travis-ci@ec2-54-204-186-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20161124 19:22:44< travis-ci> wesnoth/wesnoth#12152 (master - c048d39 : Charles Dang): The build is still failing.
20161124 19:22:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178666548
20161124 19:22:44-!- travis-ci [~travis-ci@ec2-54-204-186-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20161124 19:31:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20161124 19:32:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 19:41:42-!- mjs-de [~mjs-de@x4db658c6.dyn.telefonica.de] has joined #wesnoth-dev
20161124 19:43:04< zookeeper> vultraz, are you aware that sometimes, maybe 1/10 or so, the interface (for example campaign menu) becomes _really_ laggy and sluggish? it disappears for example if i manage to start the campaign, or of course if i kill wesnoth and restart
20161124 19:43:33< vultraz> i think that;s known
20161124 19:43:36< zookeeper> it might be because i click on the campaign button really quickly when the title screen appears, not sure
20161124 19:43:40< zookeeper> mmkay
20161124 19:47:49-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 248 seconds]
20161124 20:02:45< zookeeper> 350 lines of events to make the daze special work right -.- and it could be made even better
20161124 20:03:28< celticminstrel> What does the daze special do?
20161124 20:04:03< zookeeper> makes the unit suffer -10% CtH and +10% CtBH
20161124 20:04:08< zookeeper> magical and marksman not affected
20161124 20:04:35< zookeeper> i'm contemplating just removing the whole thing, but it'd need a good replacement and i have precious few ideas for that
20161124 20:05:48< celticminstrel> Hmm.
20161124 20:05:58< celticminstrel> That sounds almost exactly like what parry/accuracy do.
20161124 20:06:10< DeFender1031> So in the end, instead of trying to fight with my system to get it to upgrade and potentially not having a working system while in the process, I got a thanksgiving bonus from work in the form of brand new drives and I'm going to install a fresh system on those. The idea being that if it's not to my satisfaction or encounters issues that take some time to tweak, I can swap my existing drives back in and still have a usable 
20161124 20:06:11< DeFender1031> system for doing other things in the meantime.
20161124 20:07:51< celticminstrel> But parry/accuracy apply to specific attacks, so if you wanted to use that you'd have to add it to all the unit's attacks and then remove it again. Still... [object] may be able to do this...
20161124 20:08:53< vultraz> zookeeper: ftr the campaign dialog lagging is different from the general gui2 lag that sometimes happens
20161124 20:09:52< zookeeper> celticminstrel, i feel it's too risky to rely on adding/removing that kind of things
20161124 20:10:46< celticminstrel> It also might not have the desired effect of leaving marksman/magical unaffected. (I'm not really sure what would happen in that event.)
20161124 20:10:51< zookeeper> although arguably i should probably test parry and see how well it might work for the purpose
20161124 20:10:58< zookeeper> yeah, that too
20161124 20:12:41< zookeeper> oh wait, no, parry/accuracy won't work. it'd only work if all units had both ranged and melee attacks.
20161124 20:13:08< celticminstrel> Hmm, yeah, I think you're right.
20161124 20:13:24< celticminstrel> Oh well.
20161124 20:13:29< zookeeper> can't make a unit have negative parry against ranged if it doesn't have a ranged attack. so all other units would need to have positive accuracy on their ranged attacks, and then that would work against all units.
20161124 20:14:06-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161124 20:15:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161124 20:21:09-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 20:30:18-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 258 seconds]
20161124 20:31:42< Elvish_Hunter> Hi all. I'm still around, just terribly busy :)
20161124 20:34:52< celticminstrel> Elvish_Hunter: Do you have time to look at the two PRs assigned to you?
20161124 20:35:41-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161124 20:36:08< Elvish_Hunter> I just looked at one.
20161124 20:46:56-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has quit [Ping timeout: 250 seconds]
20161124 20:47:28-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161124 20:48:54-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 20:49:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has joined #wesnoth-dev
20161124 20:49:25< aeth> Elvish_Hunter: A question on your name... Are you an elf who hunts or do you hunt anyone that's elvish?
20161124 20:50:07< celticminstrel> IIRC there's actually a unit called Elvish Hunter.
20161124 20:50:13< celticminstrel> Possibly in old UtBS?
20161124 20:50:24< celticminstrel> Certainly in IftU.
20161124 20:51:15-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20161124 20:51:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161124 20:51:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161124 20:59:08< Elvish_Hunter> Yep. My username is based exactly on that unit from IftU.
20161124 21:04:05< DeFender1031> aren't Elvish Hunters in UtBS also?
20161124 21:04:33< Elvish_Hunter> In that case, they're Desert Hunters.
20161124 21:05:19< celticminstrel> IIRC, that unit no longer exists in the Quenoth redesign.
20161124 21:07:01< zookeeper> yeah, sadly they got axed
20161124 21:09:44< DeFender1031> What's this "quenoth redesign"?
20161124 21:09:59< DeFender1031> was utbs significantly changed?
20161124 21:10:27< vultraz> Elvish_Hunter: we now support 16.04 for lts.
20161124 21:11:25< celticminstrel> I think just the units were completely redesigned.
20161124 21:12:51< DeFender1031> Really? I always thought they looked like regular elvish units with some slightly different coloring.
20161124 21:13:04< celticminstrel> That's why they were completely redesigned.
20161124 21:13:15< celticminstrel> To make them more distinct.
20161124 21:14:03< Elvish_Hunter> vultraz: I updated my comment. Thanks!
20161124 21:16:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161124 21:16:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 21:17:48< zookeeper> DeFender1031, the new units are in 1.13.6, although with a pile of bugs
20161124 21:18:44< DeFender1031> ahhh
20161124 21:18:45< DeFender1031> gotcha
20161124 21:18:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has quit [Remote host closed the connection]
20161124 21:20:32-!- irker928 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161124 21:20:42< vultraz> Elvish_Hunter: yw. :) We basically decided recently to focus on supporting just as far back as current LTS, whatever that may be. 
20161124 21:23:45< DeFender1031> what's LTS?
20161124 21:25:25-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has quit [Ping timeout: 248 seconds]
20161124 21:25:36< vultraz> long term support
20161124 21:25:42< DeFender1031> ah
20161124 21:28:23-!- louis94 [~~louis94@91.178.241.199] has quit [Quit: Konversation terminated!]
20161124 21:28:37-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161124 21:32:50-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has joined #wesnoth-dev
20161124 21:35:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161124 21:35:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 21:35:38< DeFender1031> isn't that a tautology though? we only support the things we're supporting?
20161124 21:36:10< celticminstrel> Nah, it's more like "we only support the things that other people support".
20161124 21:36:37< DeFender1031> ahhhh
20161124 21:36:54< DeFender1031> meaning, we won't support, for example, debian oldstable
20161124 21:37:02< celticminstrel> Or, "the things that their makers support"
20161124 21:37:08-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161124 21:37:14< celticminstrel> I think we don't support debian oldstable anymore, yeah.
20161124 21:37:38< DeFender1031> that makes some sense.
20161124 21:39:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20161124 21:39:42-!- wedge010 is now known as wedge009
20161124 21:49:27< vultraz> blah, i got sidetracked from what i should be doing
20161124 21:50:25< vultraz> hm
20161124 21:50:26< vultraz> strtol
20161124 21:50:42< vultraz> should definitely be using std::strtol
20161124 21:51:51< celticminstrel> Should be the same thing, but sure.
20161124 21:51:52< vultraz> do I have a 'string to uint32' function?
20161124 21:52:03< celticminstrel> Uhh. strtol?
20161124 21:52:15< vultraz> i meant wesnoth function
20161124 21:52:21< vultraz> so many conversion functions
20161124 21:52:36< vultraz> i should take the plunge and write that color_t wrapper class Aginor wants
20161124 21:52:39< celticminstrel> strtol probably produces an int32.
20161124 21:52:45< celticminstrel> I guess not uint32.
20161124 21:54:13< vultraz> right now there's code here that does
20161124 21:54:16< vultraz> 			char* endptr;
20161124 21:54:18< vultraz> 			rgb_hex = (0x00FFFFFF & strtol(c->c_str(), &endptr, 16));
20161124 21:54:25< vultraz> blah
20161124 21:55:08< celticminstrel> That's pretty bad. Good thing Wesnoth doesn't support big-endian platforms?
20161124 21:55:30< vultraz> im trying to figure out why game config converts the hexadecimal colors specified in the WML to vectors of uint32_t
20161124 21:55:31< celticminstrel> With that code, if you ran it on eg a Wii you'd get incorrect colours.
20161124 21:56:06< vultraz> bad, that is
20161124 21:56:24< celticminstrel> Is it converting hex colours to vectors of uint32_t, or is it converting a comma-separated list of hex colours.
20161124 21:56:41< vultraz> latter
20161124 21:57:04< celticminstrel> So doesn't that answer your question?
20161124 21:57:13< Aginor> celticminstrel: it's also a problem for ARM platforms, like your phones/tables kind of thing
20161124 21:57:23< celticminstrel> Oh, is ARM big-endian too?
20161124 21:57:24< vultraz> ya know, here's an annoying thing: GUI2 uses R G B A values, ie "255, 255, 255, 255"
20161124 21:57:29< vultraz> pango markup uses hex
20161124 21:57:30< Aginor> celticminstrel: some are
20161124 21:57:31 * celticminstrel only knew about PPC.
20161124 21:57:34< vultraz> but here in the game config we have hex too
20161124 21:57:39< vultraz> and not R G B A
20161124 21:58:01< celticminstrel> In game config it's probably HTML format without the #
20161124 21:58:04< celticminstrel> So, rrggbb
20161124 21:58:16< vultraz> wait, it's only hex with the hashtag?
20161124 21:58:21< celticminstrel> It's not entirely unreasonable.
20161124 21:58:25< celticminstrel> What are you talking about?
20161124 21:58:31< vultraz> grumble
20161124 21:58:42< vultraz> how is "e60000" different from "#e60000"
20161124 21:58:47< celticminstrel> It's not.
20161124 21:59:05< celticminstrel> It's just that HTML/CSS uses # as an indicator to show that what follows is a hex colour.
20161124 21:59:15< vultraz> i see
20161124 21:59:41< celticminstrel> Other conventions are 0xe50000 (C) and $e60000 (not entirely sure where that's from).
20161124 21:59:48< vultraz> ponder
20161124 21:59:51< celticminstrel> It's just a signal that "this is hex"
20161124 22:00:01< celticminstrel> In game_config it's presumably assumed hex, so no signal required.
20161124 22:00:06< vultraz> right
20161124 22:00:12< celticminstrel> And I think it's reasonable to use that format for lists of colours.
20161124 22:00:17< vultraz> there's also no need for an alpha component 
20161124 22:00:23< celticminstrel> Definitely not.
20161124 22:00:30< vultraz> so hex format is fine
20161124 22:00:36< celticminstrel> I'm mildly against including alpha as part of the colour in WML.
20161124 22:01:03< celticminstrel> I think keeping it as a separate key is easier to understand.
20161124 22:01:09< vultraz> have I deprecated red= green= blue= in [label] and such yet?
20161124 22:01:23< celticminstrel> (Of course there's some places where red,green,blue or r,g,b are separate keys too...)
20161124 22:01:28< celticminstrel> I have no idea.
20161124 22:01:39< vultraz> ok, I will deprecate them.
20161124 22:01:47< celticminstrel> In favour of what?
20161124 22:01:48< vultraz> we will use color= everywhere.
20161124 22:02:08< celticminstrel> If you're going to do that, make sure you really do use it everywhere.
20161124 22:02:14-!- RatArmy [~RatArmy@om126161112087.8.openmobile.ne.jp] has quit [Ping timeout: 252 seconds]
20161124 22:02:35< celticminstrel> I doubt [label] is the only place it's different.
20161124 22:03:17< vultraz> I suppose it should be color = RGB and not color = hex, right?
20161124 22:04:09< celticminstrel> Well, to be honest, to me it'd make sense to allow both color=rrggbb and color=r,g,b.
20161124 22:04:43< vultraz> hmm
20161124 22:04:44< celticminstrel> Maybe even color=name for some predefined names (either team-color names or basic CSS colours.)
20161124 22:04:56< vultraz> that's essentially what this does: https://github.com/wesnoth/wesnoth/blob/master/src/color_range.cpp#L91
20161124 22:05:11< vultraz> despite being ugly a'f
20161124 22:06:29< celticminstrel> I think I was wrong about that being endian-sensitive actually.
20161124 22:06:33< vultraz> if we allow color=name it would be akin to [side] color
20161124 22:06:39< celticminstrel> But it certainly is ugle.
20161124 22:06:40< vultraz> referring to color_range ids
20161124 22:06:41< celticminstrel> ugly
20161124 22:07:10< vultraz> blagh
20161124 22:07:24< vultraz> guess i need a whole new parse_color function
20161124 22:07:28< vultraz> the fun never stops
20161124 22:08:31-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161124 22:08:50< vultraz> so, I thought it'd be good to store stuff as SDL_Color internally
20161124 22:08:56< vultraz> or whatever wrapper class we get..
20161124 22:09:17< celticminstrel> The advantage of a wrapper class is that you can add converter methods for whatever colour types you need.
20161124 22:09:34< vultraz> do I have..uh
20161124 22:09:34< celticminstrel> And static parse functions too.
20161124 22:09:42< vultraz> hex color to SDL_Color?
20161124 22:09:46< vultraz> I don't think I do..
20161124 22:09:54< vultraz> ummm...
20161124 22:10:00< vultraz> how would that be done
20161124 22:10:39< vultraz> well, it would start as a string
20161124 22:10:49< vultraz> so I guess convert to uint32_t first
20161124 22:11:03< vultraz> and then we have int_to_color
20161124 22:11:04< vultraz> good, good
20161124 22:11:28< vultraz> should really be called uint32_to_color
20161124 22:13:05< vultraz> celticminstrel: I assume uint32_t temp = std::strtol(str); would be enough? or would it need to be 0x00FFFFFF & std::strtol(str)
20161124 22:13:28< celticminstrel> The & makes sure you don't accidentally add an alpha channel.
20161124 22:13:32< celticminstrel> So I'd recommend it.
20161124 22:13:54< vultraz> ok
20161124 22:14:16< celticminstrel> Alternatively you could require the string to be exactly 6 characters.
20161124 22:16:10< vultraz> you mean rrggbbaa is a thing?
20161124 22:16:26< celticminstrel> I doubt it?
20161124 22:17:15< celticminstrel> The code you posted above means that if someone writes aabbccdd they'll get the colour bbccdd.
20161124 22:17:26< celticminstrel> I think.
20161124 22:17:35< celticminstrel> Yeah, assuming the mask is included.
20161124 22:17:42< vultraz> ok, mask it is
20161124 22:17:46< celticminstrel> So aarrggbb.
20161124 22:17:56< celticminstrel> But it migth be better to verify rather than correct.
20161124 22:20:03< vultraz> I dislike checking string length
20161124 22:20:15< vultraz> mask it is
20161124 22:20:15< celticminstrel> Why?
20161124 22:20:38< vultraz> dunno
20161124 22:21:09< vultraz> it just seems something that could break easily in general 
20161124 22:21:12< vultraz> for example
20161124 22:21:42< vultraz> color="255,25". not sure what that would print, exactly, but if you did length == 6 { treat as hex} you'd get bad output
20161124 22:22:11< vultraz> better to check if vec = utils.split(str). if(vec.empty())
20161124 22:22:38< celticminstrel> Well, the length == 6 check obviously only applies if it's hex.
20161124 22:22:52< celticminstrel> If it's decimal you want size == 3 for the split vector.
20161124 22:23:33< vultraz> well, I meant not to use length == 6 as an "is this hex?" check
20161124 22:23:49< celticminstrel> Yeah, that wouldn't be good.
20161124 22:24:12< celticminstrel> 10,3,4 is a valid 6-character decimal colour.
20161124 22:24:26< celticminstrel> (Admittedly I doubt people would generally use single digits, but it's still valid.)
20161124 22:25:15< vultraz> That's why I dislike stuff like string length checks to determine branching logic
20161124 22:26:35< celticminstrel> I was thinking more for error messages when the colour is invalid; length==6 is a possible test to consider.
20161124 22:27:43< vultraz> thats a more appropriate use
20161124 22:27:55-!- atarocch [~atarocch@93.56.160.28] has quit [Quit: Leaving]
20161124 22:33:33 * celticminstrel has no idea why you thought I'd be talking about it being used for branching, given that I suggested it was a substitute for the mask.
20161124 22:39:49-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161124 22:40:13-!- mjs-de [~mjs-de@x4db658c6.dyn.telefonica.de] has quit [Remote host closed the connection]
20161124 23:12:30< vultraz> ok let's see
20161124 23:12:34< vultraz> time of day
20161124 23:12:35< vultraz> label..
20161124 23:12:44< vultraz> print
20161124 23:12:53< vultraz> color adjust..
20161124 23:13:14< vultraz> and whatever wml_animation_internal is used for
20161124 23:13:18< vultraz> 5 places
20161124 23:13:19< vultraz> blagh
20161124 23:17:19-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161124 23:34:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161124 23:34:42-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161124 23:39:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has joined #wesnoth-dev
20161124 23:44:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has quit [Ping timeout: 260 seconds]
20161124 23:52:20-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161124 23:52:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161124 23:55:53-!- VultCave [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20161124 23:57:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
--- Log closed Fri Nov 25 00:00:04 2016