--- Log opened Fri Nov 25 00:00:04 2016
--- Day changed Fri Nov 25 2016
20161125 00:00:04-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20161125 00:10:09-!- Bonobo [~Bonobo@2001:44b8:254:3200:655a:306e:a3b0:a975] has joined #wesnoth-dev
20161125 00:12:08-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 245 seconds]
20161125 00:12:41-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161125 00:50:34-!- Appleman1234 [~Appleman1@KD106161206045.au-net.ne.jp] has joined #wesnoth-dev
20161125 00:53:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161125 01:20:23-!- RatArmy_ [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 01:20:23-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 01:24:43-!- RatArmy_ [~RatArmy@133.15.175.65] has quit [Client Quit]
20161125 01:24:59-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 01:25:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161125 01:41:58-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 01:42:00-!- RatArmy_ [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 01:43:11-!- RatArmy [~RatArmy@om126200116240.15.openmobile.ne.jp] has joined #wesnoth-dev
20161125 01:45:01-!- RatArmy [~RatArmy@om126200116240.15.openmobile.ne.jp] has quit [Client Quit]
20161125 01:45:21-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 01:46:22-!- RatArmy_ [~RatArmy@133.15.175.65] has quit [Ping timeout: 250 seconds]
20161125 01:50:09-!- RatArmy [~RatArmy@133.15.175.65] has quit [Client Quit]
20161125 01:50:29-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 02:13:59-!- gfgtdf_ [~chatzilla@x4e363f60.dyn.telefonica.de] has joined #wesnoth-dev
20161125 02:14:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20161125 02:15:11-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161125 02:15:57-!- gfgtdf [~chatzilla@x4e36363f.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161125 02:16:08-!- gfgtdf_ is now known as gfgtdf
20161125 02:20:58-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161125 02:23:05-!- gfgtdf [~chatzilla@x4e363f60.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161125 02:41:57-!- RatArmy_ [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 02:41:58-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 03:01:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161125 03:08:53-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 03:08:55-!- RatArmy_ [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 03:09:03-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 246 seconds]
20161125 03:09:34-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 03:09:49-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 03:44:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has joined #wesnoth-dev
20161125 03:47:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has quit [Remote host closed the connection]
20161125 03:54:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has joined #wesnoth-dev
20161125 04:00:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:20af:8660:9968:d687] has quit [Remote host closed the connection]
20161125 04:03:38-!- JyrkiVesterinen [~JyrkiVest@87-100-205-164.bb.dnainternet.fi] has joined #wesnoth-dev
20161125 04:11:40-!- TechnologicalK9 [~AlexKlein@pool-108-48-89-75.washdc.fios.verizon.net] has joined #wesnoth-dev
20161125 04:12:22< TechnologicalK9> Heyo all
20161125 04:13:02< celticminstrel> 'lo
20161125 04:13:14< TechnologicalK9> How're you, minstrel?
20161125 04:13:20< celticminstrel> Fine
20161125 04:13:55< TechnologicalK9> Good good.
20161125 04:17:58< TechnologicalK9> I have a question..
20161125 04:18:56< TechnologicalK9> I am looking at the "Easy Coding" wiki page for developers... and I'd love to work on the Map Diff tool. At the end of it, though, there's a name and a date. Does that mean someone's "taken" i?
20161125 04:18:59< TechnologicalK9> *it?
20161125 04:19:40< celticminstrel> What's the name?
20161125 04:20:03< TechnologicalK9> Henry Stone (3/17/16)
20161125 04:20:17< celticminstrel> ...I have no idea who that is.
20161125 04:20:22< TechnologicalK9> :-P
20161125 04:20:55< celticminstrel> Also, there are not 17 months in the year.
20161125 04:21:47< celticminstrel> That aside, if it's from March, it's probably safe to say that he gave up.
20161125 04:21:57< TechnologicalK9> Haha, fair enough.
20161125 04:22:10< celticminstrel> Or got distracted/busy with other stuff.
20161125 04:23:32 * celticminstrel wishes MediaWiki had "blame" too.
20161125 04:23:37< TechnologicalK9> *grins*
20161125 04:24:05< JyrkiVesterinen> It is easy enough to find changes in MediaWiki.
20161125 04:24:06< JyrkiVesterinen> https://wiki.wesnoth.org/index.php?title=EasyCoding&diff=57609&oldid=56948
20161125 04:24:28< celticminstrel> How did you find that...
20161125 04:24:34< JyrkiVesterinen> celticminstrel: can I revert that change?
20161125 04:24:44 * celticminstrel got as far as this just by stepping back through history https://wiki.wesnoth.org/index.php?title=EasyCoding&diff=prev&oldid=57727
20161125 04:24:58< JyrkiVesterinen> I found the change via the history page: https://wiki.wesnoth.org/index.php?title=EasyCoding&action=history
20161125 04:25:17< JyrkiVesterinen> I simply performed some kind of approximate binary search.
20161125 04:25:23< celticminstrel> Oh right, it gives the person and edit summary for each of those.
20161125 04:27:05< celticminstrel> I guess the name could be removed, sure.
20161125 04:28:23< JyrkiVesterinen> Done.
20161125 04:40:27< JyrkiVesterinen> 20161124 21:57:23< celticminstrel> Oh, is ARM big-endian too?
20161125 04:40:35< JyrkiVesterinen> ARM is little-endian by default.
20161125 04:41:04< JyrkiVesterinen> AFAIK, there isn't even a single non-obscure phone or tablet that uses it in big-endian mode.
20161125 04:41:28< JyrkiVesterinen> Doing so would just create compatibility problems without any benefits.
20161125 05:23:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161125 05:23:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161125 05:25:17-!- TechnologicalK9 [~AlexKlein@pool-108-48-89-75.washdc.fios.verizon.net] has quit [Quit: Leaving]
20161125 05:30:18-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 252 seconds]
20161125 06:04:38-!- JyrkiVesterinen [~JyrkiVest@87-100-205-164.bb.dnainternet.fi] has quit [Quit: .]
20161125 06:29:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161125 06:49:27-!- Kwandulin [~Miranda@p200300760F6EBF8E647C17DE30A27AAA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161125 06:56:43-!- Kwandulin [~Miranda@p200300760F6EBF8E647C17DE30A27AAA.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
20161125 07:09:33-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 07:25:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161125 08:10:55-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161125 09:04:58< Soliton> celticminstrel: bitwise operators work the same way on any endianess.
20161125 09:20:19-!- RatArmy_ [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 09:20:20-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 09:21:38-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 09:21:38-!- RatArmy_ [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 09:37:05-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 09:37:12-!- RatArmy_ [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 09:39:36-!- RatArmy_ [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 09:39:46-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20161125 10:43:38-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161125 10:43:38-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161125 10:43:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161125 10:58:24-!- RatArmy [~RatArmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161125 11:03:02-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has joined #wesnoth-dev
20161125 11:09:53-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161125 11:16:12< vultraz> at some point we should reconsider our 'no translations via pr' rule.
20161125 11:24:13-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has joined #wesnoth-dev
20161125 11:25:12-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has quit [Remote host closed the connection]
20161125 11:33:01-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has joined #wesnoth-dev
20161125 11:40:14-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20161125 11:46:07-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has quit [Remote host closed the connection]
20161125 11:46:34-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has joined #wesnoth-dev
20161125 11:49:07-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 11:50:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161125 11:50:54-!- wedge010 is now known as wedge009
20161125 11:55:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161125 11:55:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 11:59:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161125 11:59:18-!- wedge010 is now known as wedge009
20161125 11:59:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161125 12:00:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 12:10:38-!- RatArmy [~RatArmy@om126204192079.6.openmobile.ne.jp] has quit [Ping timeout: 256 seconds]
20161125 12:18:41-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Ping timeout: 256 seconds]
20161125 12:20:01-!- irker229 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161125 12:20:02< irker229> wesnoth: Wedge009 wesnoth:master 760bb8330941 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project. https://github.com/wesnoth/wesnoth/commit/760bb833094145e8071a60efd6e8bd76f6dd7491
20161125 12:20:02< irker229> wesnoth: Wedge009 wesnoth:master 011759bf37dc / src/gui/widgets/helper.cpp: Correct missing return value in decode_color(). https://github.com/wesnoth/wesnoth/commit/011759bf37dc369fbd0caf66422ba873f073c785
20161125 12:21:52< wedge009> Is the rule to ensure that they go through the proper channels (eg translation leader?) It does feel a bit cumbersome when there's a team of one.
20161125 12:38:30-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20161125 12:56:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161125 12:56:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 12:57:30-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 13:00:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161125 13:01:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161125 13:02:12-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20161125 13:09:15-!- travis-ci [~travis-ci@ec2-54-81-231-103.compute-1.amazonaws.com] has joined #wesnoth-dev
20161125 13:09:16< travis-ci> wesnoth/wesnoth#12156 (master - 011759b : Wedge009): The build is still failing.
20161125 13:09:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178829608
20161125 13:09:16-!- travis-ci [~travis-ci@ec2-54-81-231-103.compute-1.amazonaws.com] has left #wesnoth-dev []
20161125 13:16:50< Soliton> yes.
20161125 13:29:12< loonycyborg> hmm I'm getting same error as on travis
20161125 13:31:11< JyrkiVesterinen> Which compiler (and which version) do you use?
20161125 13:31:52< loonycyborg> gcc (Gentoo 5.4.0 p1.0, pie-0.6.5) 5.4.0
20161125 13:33:56< loonycyborg> I finally can work on merging PR #847 and this error is kinda getting in the way :P
20161125 13:33:58< JyrkiVesterinen> I have GCC 6.2.1. If no one else gets around to fix this problem before that, I'll try it in the evening (about five hours from now).
20161125 13:34:41< JyrkiVesterinen> I haven't tried to compile the game with 6.2.1, so I don't know if the problem occurs with that version.
20161125 13:34:49< loonycyborg> I'll look into it
20161125 13:49:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:655a:306e:a3b0:a975] has quit [Ping timeout: 258 seconds]
20161125 13:57:43-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161125 14:04:22< loonycyborg> vultraz: it's caused by a name clash. Maybe you can rename that static member function?
20161125 15:07:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161125 15:15:01-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161125 15:53:06< vultraz>  I know the fix
20161125 16:07:53-!- prkc [~prkc@46.166.190.187] has quit [Remote host closed the connection]
20161125 16:17:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20161125 16:18:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161125 16:24:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161125 16:34:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161125 17:07:23-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161125 17:14:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161125 17:14:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161125 17:19:01-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Ping timeout: 248 seconds]
20161125 17:30:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161125 17:42:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161125 17:51:01-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161125 18:11:30-!- gfgtdf [~chatzilla@x4e363f60.dyn.telefonica.de] has joined #wesnoth-dev
20161125 18:15:15-!- irker229 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161125 18:25:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161125 18:27:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161125 18:30:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20161125 18:30:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161125 18:30:49-!- stikonas_ is now known as stikonas
20161125 18:33:15< EliDupree> LOL, a made a map where you fight more than 700 zombies, and it's actually playable
20161125 18:33:37< EliDupree> (This is partly because I use the EoHS swarm AI system, which handles having large numbers of units much better than the default AI)
20161125 18:39:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161125 18:39:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161125 18:43:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161125 18:50:44-!- irker827 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161125 18:50:44< irker827> wesnoth: ln-zookeeper wesnoth:master 26e9345349ea / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: UtBS: Fixed some non-fatal mistakes in support ability events https://github.com/wesnoth/wesnoth/commit/26e9345349ea4a309c648ef236f541e510e8756f
20161125 18:50:44< irker827> wesnoth: ln-zookeeper wesnoth:master 5b91e0bb9fb0 / data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg: UtBS: Fixed problems with the daze special https://github.com/wesnoth/wesnoth/commit/5b91e0bb9fb0d8c0be788e3f88ffdec7e4395a49
20161125 18:50:45< irker827> wesnoth: ln-zookeeper wesnoth:master 7d600aa29a12 / data/campaigns/Under_the_Burning_Suns/units/ (6 files in 2 dirs): UtBS: Some balancing for the Tauroch Rider line https://github.com/wesnoth/wesnoth/commit/7d600aa29a1231aad29bf601fa4fb84cef3727d9
20161125 18:50:46< irker827> wesnoth: ln-zookeeper wesnoth:master eddf9740510b / data/campaigns/Under_the_Burning_Suns/units/quenoth/Youth.cfg: UtBS: Forgot to bump Quenoth Youth MP for all levels https://github.com/wesnoth/wesnoth/commit/eddf9740510b929207fd883da41fbe1d6ef1758f
20161125 18:50:47< irker827> wesnoth: ln-zookeeper wesnoth:master abd4d96aa251 / / (11 files in 5 dirs): Merge branch 'master' of https://github.com/wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/abd4d96aa2517ca61496b50167626159db4268e2
20161125 18:51:29-!- louis94 [~~louis94@91.178.242.83] has joined #wesnoth-dev
20161125 18:51:57< celticminstrel> Annoying merge commits... oh well.
20161125 18:58:52< gfgtdf> zookeeper: afaik standard unit filters support status= directly, no reaosn to use filter_wml here
20161125 18:59:40< zookeeper> gfgtdf, ah, that's true
20161125 19:00:05-!- Kwandulin [~Miranda@p200300760F6EBF8E512AD2E53637785B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161125 19:00:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161125 19:00:36< celticminstrel> Whoa, lots of PR activity since I last checked.
20161125 19:05:26-!- louis94 [~~louis94@91.178.242.83] has quit [Ping timeout: 256 seconds]
20161125 19:10:12< celticminstrel> I think PR 877 should be closed but I'm worried that it might discourage them. >_>
20161125 19:10:25-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161125 19:17:17< vultraz> celticminstrel: I'm debating between making color_t a struct (akin to SDL_Color) with some (static?) conversion functions, or a class with a ctor.
20161125 19:17:19< vultraz> celticminstrel: thoughts?
20161125 19:20:17< vultraz> I'm leaning towards the first, since it would allow simple SDL_Color -> color_t replacement without changing the initialization method
20161125 19:21:27-!- JyrkiVesterinen [~jyrki@87-92-35-37.bb.dnainternet.fi] has joined #wesnoth-dev
20161125 19:22:44< celticminstrel> To avoid warnings, you'll want a constructor either way.
20161125 19:22:58< celticminstrel> Because certain compilers we use are warning about incomplete initializers.
20161125 19:23:08< JyrkiVesterinen> For the record, I would prefer constructors.
20161125 19:23:18< vultraz> but one cannot aggregate initialize a struct with a ctor :/ 
20161125 19:23:43< vultraz> "no user-provided, inherited, or explicit (since C++17) constructors (explicitly defaulted or deleted constructors are allowed) (since C++11)"
20161125 19:23:55< vultraz> unless I'm misreading this?
20161125 19:24:35< celticminstrel> Uh, well, it sounds like there may be confusion on the definition of "aggregate initialize"...
20161125 19:24:54< celticminstrel> If it has a constructor, certainly you can write "color_t c = {1,2,3};"
20161125 19:25:03< celticminstrel> Assuming the constructor takes three arguments.
20161125 19:25:18< celticminstrel> Or "color_t c{1,2,3};" or "color_t c(1,2,3);".
20161125 19:25:36< celticminstrel> They're all effectively equivalent (though with slight differences.)
20161125 19:26:03< vultraz> wait, then what's the difference between brace and aggregate initialization :/
20161125 19:28:34< celticminstrel> It's been awhile since I read the C++ standard, so I don't feel that I can answer that very effectively.
20161125 19:29:07< vultraz> another confusing thing: what's the difference between essentially 'calling' the ctor like a function (ie, c(1,2,3), which corresponds to ctor arguments), and {} initialization initializing members directly  
20161125 19:29:48< vultraz> like, when I do SDL_Color c  {r, g, b ,a};, I assume it's just assigning values to the members r, g, b, a
20161125 19:29:57< vultraz> not passing them as arguments to a ctor 
20161125 19:30:05< vultraz> but now you say some compilers we use should be complaining
20161125 19:30:10< vultraz> so now I'm very confused :|
20161125 19:31:23< celticminstrel> When you do that with SDL_Color, you're correct, because SDL_Color does not have a constructor.
20161125 19:31:42< celticminstrel> When you use that syntax on a type with a constructor, then it would be passing those values as arguments to the constructor.
20161125 19:31:53< vultraz> What if I gave color_t a default ctor with no arguments and tried to do color_t c {r, g, b, a}. What happens?
20161125 19:32:04< celticminstrel> Some of the compilers we use are set to complain on incomplete initializers.
20161125 19:32:21< zookeeper> i don't get how the game is supposed to determine whether i'm allowed to see a unit help page or not. i can wipe the encountered_units list clean in preferences, and yet when i for example start TSG, i can view royal guard but not halberdier.
20161125 19:32:21< celticminstrel> That is, if you write "SDL_Color c {r, g, b};", they will complain that a is uninitialized.
20161125 19:33:05< zookeeper> and i can view elvish avenger but not sharpshooter. doesn't make any sense.
20161125 19:33:07< vultraz> right, I remember that
20161125 19:33:07< celticminstrel> So if you want aggregate-like initialization with a constructor, you'd need a four-argument constructor, with default values for all the arguments.
20161125 19:33:34< celticminstrel> zookeeper: I think it automatically adds units on the recruit list and units you can see.
20161125 19:33:43< zookeeper> celticminstrel, that doesn't explain it
20161125 19:34:31-!- Kwandulin [~Miranda@p200300760F6EBF8E512AD2E53637785B.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20161125 19:34:34< vultraz> er, but wait, you once told me {} is supposed to be the new c++11 initialization method for all types.. ie, one could do int foo {1}; does this mean integral types have explicit constructors?
20161125 19:34:41< vultraz> s/method/syntax
20161125 19:34:43< celticminstrel> I don't know how to explain the royal guard though.
20161125 19:34:59-!- RatArmy [~RatArmy@om126161116215.8.openmobile.ne.jp] has joined #wesnoth-dev
20161125 19:35:37< celticminstrel> vultraz: Integral types do not have constructors, but they are treated as though they have a one-argument constructor (with default).
20161125 19:35:53< vultraz> I see
20161125 19:36:03-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161125 19:36:29< celticminstrel> ...or the avenger... why can you randomly see some L3 units...
20161125 19:36:43< vultraz> Ok, one last question: in the case of a class/struct with a no-argument default ctor, is there a difference between T foo; and T foo {};? Ie, will the first not be initialized?
20161125 19:36:48< zookeeper> hmh
20161125 19:37:09< zookeeper> ok i think i wasn't careful enough with my wiping of the encountered_units list
20161125 19:37:55< zookeeper> now it seems to work right
20161125 19:38:40< celticminstrel> There is no difference.
20161125 19:38:41< gfgtdf> vultraz: whats teh reaosn for addina  color_t type?
20161125 19:39:00< celticminstrel> gfgtdf: Because colours are used through the code inconsistently in various formats.
20161125 19:39:15< vultraz> celticminstrel: no difference?
20161125 19:40:26< celticminstrel> No difference.
20161125 19:41:06< vultraz> so, not initialized? 
20161125 19:41:13-!- travis-ci [~travis-ci@ec2-54-205-110-146.compute-1.amazonaws.com] has joined #wesnoth-dev
20161125 19:41:14< travis-ci> wesnoth/wesnoth#12158 (master - abd4d96 : ln-zookeeper): The build has errored.
20161125 19:41:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178912128
20161125 19:41:14-!- travis-ci [~travis-ci@ec2-54-205-110-146.compute-1.amazonaws.com] has left #wesnoth-dev []
20161125 19:42:27< zookeeper> at least from 1.13.4 onwards, all units are shown in help even if the "show all unit types in help" preference isn't set to yes.
20161125 19:43:00< zookeeper> and no units are shown as "unencountered", regardless of how empty my encountered_units list is
20161125 19:45:09< zookeeper> so it's kinda impossible to test a fix to the unit help opening problem, when i can't even get the expected normal behavior
20161125 19:46:00< irker827> wesnoth: Jyrki Vesterinen wesnoth:master 81380daf1d52 / src/gui/dialogs/terrain_layers.hpp: Fix build with GCC https://github.com/wesnoth/wesnoth/commit/81380daf1d52923355b719e2c9b3105718fe8103
20161125 19:46:18< JyrkiVesterinen> I was able to verify the fix. The error occurred with GCC 6.2.1 too.
20161125 19:46:46< vultraz> that wasn't the fix i was expecting :D
20161125 19:47:40< vultraz> thanks
20161125 19:49:54< celticminstrel> No difference, both ways it's initialized.
20161125 19:50:50< vultraz> oh wait, it's integral types that aren't initialized 
20161125 19:52:12< vultraz> is that a byproduct of not having ctors?
20161125 19:53:34< vultraz> or is it literally "oh, this is an integral type, we won't initialize"
20161125 19:54:38< celticminstrel> Primitive types, not integral types.
20161125 19:54:41< celticminstrel> I think?
20161125 19:54:48< celticminstrel> IIRC floats are also affected?
20161125 19:54:52 * celticminstrel isn't quite sure though.
20161125 19:54:59< celticminstrel> And pointers are also affected.
20161125 19:55:06< vultraz> primitive?
20161125 19:55:14< vultraz> wait, what's the differenc
20161125 19:55:27< celticminstrel> So if you write "T* p;", then p is probably pointing to some random unknown location.
20161125 19:55:38< celticminstrel> Also, all of this only applies to values on the stack IIRC.
20161125 19:55:46< celticminstrel> ie, declared in a function.
20161125 19:56:00< vultraz> yes, i realized that
20161125 19:56:11< vultraz> i thought T* p; would always be a nullptr
20161125 19:56:17< vultraz> but apparently it's not
20161125 19:56:20< celticminstrel> Pretty sure it's not, yeah.
20161125 19:56:46< celticminstrel> Primitive types would be integral types (which includes char and bool), floating-point types, and pointers, I think. I guess also arrays, functions, etc.
20161125 19:57:04< celticminstrel> But arrays have special treatment and you can't declare a variable of function type.
20161125 19:57:55< celticminstrel> Arrays inherit the behaviour of the base type IIRC, so an array of primitive types is uninitialzed but an array of classes is default-initialized.
20161125 19:58:43 * celticminstrel isn't sure if "primitive types" is an actual term used in the C++ standard; I'm using it because that's what Java calls them.
20161125 19:59:02< celticminstrel> (Though that'd exclude arrays and other fancy stuff.)
20161125 19:59:25< celticminstrel> (Arrays probably shouldn't be called primitive in any sense anyway.)
20161125 20:05:30-!- RatArmy [~RatArmy@om126161116215.8.openmobile.ne.jp] has quit [Ping timeout: 256 seconds]
20161125 20:10:13-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161125 20:11:49< gfgtdf> vultraz: is https://gna.org/bugs/?23321 fixed im master now that that dialog was moved to gui2?
20161125 20:13:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161125 20:14:20< vultraz> probably
20161125 20:18:25< celticminstrel> I suggest you test it. :P
20161125 20:20:53< celticminstrel> Sounds like you'd need a recall list of, say, ten units, and two leaders with exclusive [filter_recall].
20161125 20:20:58< celticminstrel> Then just try dismissing one.
20161125 20:21:11< celticminstrel> So, not that hard to test with a small test scenario.
20161125 20:33:16< JyrkiVesterinen> The problem with MP test is that the test doesn't proceed to the second scenario.
20161125 20:33:23< JyrkiVesterinen> Next I need to figure out why not...
20161125 20:43:46-!- travis-ci [~travis-ci@ec2-54-205-110-146.compute-1.amazonaws.com] has joined #wesnoth-dev
20161125 20:43:47< travis-ci> wesnoth/wesnoth#12159 (master - 81380da : Jyrki Vesterinen): The build passed.
20161125 20:43:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/178920817
20161125 20:43:47-!- travis-ci [~travis-ci@ec2-54-205-110-146.compute-1.amazonaws.com] has left #wesnoth-dev []
20161125 20:48:28-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161125 20:52:43-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Client Quit]
20161125 20:55:27-!- RatArmy [~RatArmy@om126161116215.8.openmobile.ne.jp] has joined #wesnoth-dev
20161125 21:15:28< JyrkiVesterinen> The problem seems to be in the joining side. It never yields control to the plugin in the second scenario.
20161125 21:15:32< JyrkiVesterinen> Call stack: https://gist.github.com/jyrkive/b9f460172a3128f8921af414482961cb
20161125 21:15:46< JyrkiVesterinen> It seems to just poll the network connection forever.
20161125 21:20:22< celticminstrel> ...is there supposed to be a network_transmission dialog here?
20161125 21:20:25 * celticminstrel poke vultraz 
20161125 21:21:04< celticminstrel> Ah, wait, that might be misleading... IIRC I changed something near there to not actually use the dialog and instead show a loading screen...
20161125 21:21:33< celticminstrel> I don't see stuff like dialog::show on the stack, so it's probably not actually in the network_transmission dialog.
20161125 21:23:06< celticminstrel> So I guess I have no insight on what could be happening here.
20161125 21:36:59< gfgtdf> JyrkiVesterinen: and what does the host do ?
20161125 21:38:25< JyrkiVesterinen> The host starts the second scenario, it reaches this line: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/playcampaign.cpp#L382
20161125 21:38:36< JyrkiVesterinen> After that, it loops waiting for the game to end.
20161125 21:39:52-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161125 21:41:00< vultraz> celticminstrel: isn't that a wrapper?
20161125 21:41:29< celticminstrel> ???
20161125 21:41:32< vultraz> oh wait
20161125 21:41:39< vultraz> that's wesnothd_dialog
20161125 21:41:40< vultraz> nvm
20161125 21:42:35-!- RatArmy [~RatArmy@om126161116215.8.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20161125 21:42:36< vultraz> maybe some dialog never closes
20161125 21:43:06< celticminstrel> If there's a dialog that never closes, the culprit is probably MP wait.
20161125 21:43:13< celticminstrel> How does that close?
20161125 21:43:23< vultraz> uhhhhhhh
20161125 21:43:25< vultraz> what do you mean?
20161125 21:43:26< celticminstrel> IIRC it's supposed to close automatically under certain conditions.
20161125 21:43:37< vultraz> yes
20161125 21:43:38< celticminstrel> How do you exit the MP wait dialog?
20161125 21:43:43< vultraz> i can't remember
20161125 21:44:29< vultraz> the plugins context is supposed to close it, right?
20161125 21:44:35< JyrkiVesterinen> I have been looking at mp_join_game::fetch_game_config.
20161125 21:44:36< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_join_game.cpp#L81
20161125 21:44:55< celticminstrel> vultraz: I mean during interactive play.
20161125 21:44:56< gfgtdf> does mp sneario transition work when you do it nomrlylly? meaning when you start a 2 player LoW game for example ?
20161125 21:44:56< vultraz> hm..
20161125 21:44:58< vultraz> perhaps mp_join_game::network_handler...
20161125 21:45:01< JyrkiVesterinen> It receives some data from the server, isn't interested in any of it, and then blocks waiting for more data.
20161125 21:45:01< celticminstrel> How does MP wait close normally?
20161125 21:45:12< vultraz> closes automatically
20161125 21:45:25< JyrkiVesterinen> It might be that the host and guest disagree about how progressing to the next scenario works.
20161125 21:45:39< vultraz> hm
20161125 21:45:45< vultraz> do i ever call that for transitional scenarios?
20161125 21:46:19< JyrkiVesterinen> It is called for the first scenario as well, and seems to work fine there.
20161125 21:46:43< JyrkiVesterinen> It's difficult to debug on the first scenario though. Timing interferes with it.
20161125 21:47:01< vultraz> hm, yes, i do call it for transient scenarios
20161125 21:48:24< celticminstrel> Which is it? Transient or transitional? :P
20161125 21:52:17< gfgtdf> JyrkiVesterinen: maybe you coudl use log debug network to see which data is actuall received.
20161125 21:53:28< JyrkiVesterinen> I'm currently trying to look up the GUI1 join game code for comparison.
20161125 21:54:51< gfgtdf> JyrkiVesterinen: the gui2 doawnload code is here https://github.com/wesnoth/wesnoth/blob/1.13.6/src/game_initialization/multiplayer_wait.cpp#L472
20161125 21:55:48< JyrkiVesterinen> I mean code that parses the received messages. GUI1's equivalent to mp_join_game::fetch_game_config.
20161125 21:56:53< JyrkiVesterinen> Ah. Your link is exactly that.
20161125 21:57:07-!- Kwandulin [~Miranda@p200300760F6EBF8E512AD2E53637785B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161125 21:58:07< vultraz> for the record, I merged two functions when porting the code
20161125 21:59:10< gfgtdf> JyrkiVesterinen: did you try using false as fourth parmaeter here: https://github.com/wesnoth/wesnoth/blob/325aef0a1bc29bdd857a88cbba8dc3eccd502616/src/game_initialization/multiplayer.cpp#L685 ?
20161125 22:00:07< vultraz> blah!
20161125 22:00:09< JyrkiVesterinen> No, I haven't tried that.
20161125 22:00:12< vultraz> stupid me
20161125 22:00:28< vultraz> i literally copied that ctor arg list from the other callsite verbatim
20161125 22:00:43< JyrkiVesterinen> In general, my way of fixing bugs is to carefully investigate with the debugger, and only try a change when I need more data.
20161125 22:00:59< vultraz> 	if(!first_scenario_) {
20161125 22:01:01< vultraz> 		wesnothd_connection_.send_data(config("load_next_scenario"));
20161125 22:01:02< vultraz> 	}
20161125 22:01:48< vultraz> i think gfgtdf very well might have found the issue
20161125 22:06:49< JyrkiVesterinen> gfgtdf's suggestion improves things, but doesn't get the test to pass.
20161125 22:07:06< gfgtdf> hmm so where does it fail now ?
20161125 22:07:14< JyrkiVesterinen> The join plugin now gets control regularly. However, it still says that it doesn't reach the second scenario.
20161125 22:07:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161125 22:08:24< gfgtdf> JyrkiVesterinen: what do you mean by "gets control regularly" ?
20161125 22:08:57< JyrkiVesterinen> The coroutine is run often, maybe ten times per second.
20161125 22:08:57< gfgtdf> JyrkiVesterinen: do you run the test in windowed or nogui mode ?
20161125 22:09:04< JyrkiVesterinen> I use nogui mode.
20161125 22:09:29< gfgtdf> JyrkiVesterinen: does it work in windowed mode?
20161125 22:09:42< JyrkiVesterinen> It can't work in windowed mode.
20161125 22:09:50< gfgtdf> JyrkiVesterinen: why that ?
20161125 22:10:10< JyrkiVesterinen> The ability to skip dialogs (which is necessary for the test plugins) is only available in nogui mode.
20161125 22:11:06< gfgtdf> JyrkiVesterinen: last time i has to fix the mp the mp tets they worked fine in windowed mode (but it was still the gui dialogs bakck then)
20161125 22:11:19< JyrkiVesterinen> It changed with GUI2.
20161125 22:11:37< JyrkiVesterinen> I implemented the ability to skip dialogs, but only did it for nogui mode.
20161125 22:12:42< gfgtdf> hmm ok
20161125 22:13:49< JyrkiVesterinen> Closer look at the log shows that the join plugin actually returns to the Multiplayer Join screen now, instead of staying ingame.
20161125 22:14:18< JyrkiVesterinen> I'll need to check how the plugin ends up there.
20161125 22:14:39< celticminstrel> It should be able to work in windowed mode if you manually skip the dialog, right?
20161125 22:14:56< gfgtdf> JyrkiVesterinen: in debug mode ame will show a mp connent/wait screen between 2 scnearios to allow reassigning sids to other players
20161125 22:15:07< celticminstrel> Also, the main dialogs (lobby, create, etc) should work without skipping.
20161125 22:16:05< JyrkiVesterinen> Whether or not the wait screen is shown between scenarios depends on timing.
20161125 22:16:07< JyrkiVesterinen> See https://github.com/wesnoth/wesnoth/commit/2c4d72f544b447d5a225f349b2078923e2f767cf
20161125 22:16:37< JyrkiVesterinen> That's exactly the commit that introduced the "waiting for second scenario" check where the tests are stuck now.
20161125 22:17:19< JyrkiVesterinen> celticminstrel: Hmm, indeed, manually skipping dialogs should work. I'll try that.
20161125 22:18:24< irker827> wesnoth: Pentarctagon wesnoth:master 458b9ce62db3 / SConstruct src/SConscript src/lua/SConscript: Update SConstruct https://github.com/wesnoth/wesnoth/commit/458b9ce62db398e6d88106e5ef1f7855560570e5
20161125 22:18:26< irker827> wesnoth: Pentarctagon wesnoth:master 84ab6fabf1c8 / SConstruct: Get clang as close to working as possible https://github.com/wesnoth/wesnoth/commit/84ab6fabf1c83a97b40e92e05240b8fb02df0280
20161125 22:18:28< irker827> wesnoth: Pentarctagon wesnoth:master 0d419cdc36ec / SConstruct src/SConscript src/lua/SConscript: Check if LTO is enabled https://github.com/wesnoth/wesnoth/commit/0d419cdc36ec7ed4c25a8068eaba3d1a739de666
20161125 22:18:30< irker827> wesnoth: Pentarctagon wesnoth:master e55e4a6d6020 / CMakeLists.txt: Make cmake's Release and Debug builds match scons https://github.com/wesnoth/wesnoth/commit/e55e4a6d602012fdcb7b429666f0c26eea5df545
20161125 22:18:32< irker827> wesnoth: Pentarctagon wesnoth:master 8ea76ce432eb / CMakeLists.txt SConstruct: Fix compiling with TDM-GCC-64 and -O3 https://github.com/wesnoth/wesnoth/commit/8ea76ce432eb6b866bcee94bc7dd757ff91f6767
20161125 22:18:34< irker827> wesnoth: pentarctagon wesnoth:master 9bc33ff79479 / CMakeLists.txt: Add Optimize build to cmake https://github.com/wesnoth/wesnoth/commit/9bc33ff7947968c19fcd89d27acea4ca59694a87
20161125 22:18:36< irker827> wesnoth: pentarctagon wesnoth:master 9de1f61924d6 / CMakeLists.txt SConstruct: Add -s flag, fix $OPT_FLAGS evaluating as an empty string, and correctly pass th https://github.com/wesnoth/wesnoth/commit/9de1f61924d6443e6e13b183c3135e97f527bc83
20161125 22:18:38< irker827> wesnoth: pentarctagon wesnoth:master e4b95ae2fe92 / SConstruct src/SConscript src/lua/SConscript: Use BoolVariable instead of EnumVariable for enable_lto https://github.com/wesnoth/wesnoth/commit/e4b95ae2fe929508c204d3ca79ee0ec57a9956a1
20161125 22:18:40< irker827> wesnoth: Sergey Popov wesnoth:master dd1351dc144a / CMakeLists.txt SConstruct src/SConscript src/lua/SConscript: Merge pull request #847 from Pentarctagon/Pentarctagon-optimize-build https://github.com/wesnoth/wesnoth/commit/dd1351dc144a00c897ec3b608d2241846b25e539
20161125 22:20:14< JyrkiVesterinen> In windowed mode, I get stuck in a dialog stating "waiting for players to join..."
20161125 22:20:37< gfgtdf> JyrkiVesterinen: at the host ?
20161125 22:20:44< JyrkiVesterinen> No, at the guest.
20161125 22:21:08< gfgtdf> JyrkiVesterinen: :/
20161125 22:44:23-!- Kwandulin [~Miranda@p200300760F6EBF8E512AD2E53637785B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161125 22:46:57< JyrkiVesterinen> I found the problem. Data arrives to the guest in a different order than it expects.
20161125 22:47:25< JyrkiVesterinen> mp_join_game::fetch_game_config() ends up eating the start_game message.
20161125 22:48:24< JyrkiVesterinen> AFAIK, in this situation the server is supposed to mark the scenario as started. I don't know why that isn't happening here.
20161125 22:53:47< JyrkiVesterinen> Ah, the scenario *is* marked as started.
20161125 22:54:09< JyrkiVesterinen> I'll try to make the dialog close automatically in this situation.
20161125 22:55:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161125 22:56:45-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161125 22:57:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161125 22:57:53-!- VultCave is now known as vultraz
20161125 22:58:44-!- louis94 [~~louis94@91.178.242.83] has joined #wesnoth-dev
20161125 23:11:40< irker827> wesnoth: Jyrki Vesterinen wesnoth:master c35257f8bea5 / src/ (game_initialization/multiplayer.cpp gui/dialogs/multiplayer/mp_join_game.cpp): Get MP test to pass https://github.com/wesnoth/wesnoth/commit/c35257f8bea5130d4c6836905d75601288f779b5
20161125 23:11:42< irker827> wesnoth: Jyrki Vesterinen wesnoth:master 55a57d539767 / .travis.yml: Turn on MP test in Travis CI https://github.com/wesnoth/wesnoth/commit/55a57d5397671c1fe3adf9981f78cb8548280a03
20161125 23:13:03< celticminstrel> \o/
20161125 23:13:35-!- JyrkiVesterinen [~jyrki@87-92-35-37.bb.dnainternet.fi] has quit [Quit: Going to bed...]
20161125 23:14:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161125 23:16:28-!- louis94 [~~louis94@91.178.242.83] has quit [Ping timeout: 256 seconds]
20161125 23:20:42< vultraz> \o/
20161125 23:30:50< vultraz> i wish jyrki would use the standard if() format instead of if ()
20161125 23:30:57< vultraz> even if he puts { on a new line :/
20161125 23:32:08< vultraz> though to be fair at one point i thought if () was the format :P
20161125 23:35:49< gfgtdf> JyrkiVesterinen: i wondt think the server sends a [start_game] message, it just sends the scenario wml with started=yes
20161125 23:40:32< gfgtdf> JyrkiVesterinen: is there a reason why you check "started" at network_handler() instead of after fetch_game_config() is called ? (where the eother change in that commit was made?)
20161125 23:41:54< gfgtdf> JyrkiVesterinen: the curetn code (compared to the 1.13.4 code) seems to have the disadvantage is that the might still be shown shortly even if in scenario was received with started=yes.
20161125 23:42:22< vultraz> no it won't
20161125 23:42:30< vultraz> this code is called before preshow
20161125 23:42:51< gfgtdf> vultraz: network_handler() ?
20161125 23:43:05< vultraz> oh that's called in preshow
20161125 23:43:20< vultraz> or wait
20161125 23:43:21< vultraz> it's not
20161125 23:43:27< vultraz> or is it?
20161125 23:43:34< celticminstrel> Why are you asking us? :P
20161125 23:43:38< vultraz> i dunno if a function is called when its timer is set up
20161125 23:43:50< celticminstrel> Probably not.
20161125 23:43:55< celticminstrel> Maybe if the timer is 0.
20161125 23:44:10< vultraz> iirc i call it manually in mp staging and it resulted in it being called twice...
20161125 23:44:13< celticminstrel> But probably not even then.
20161125 23:44:13< gfgtdf> vultraz: i think its not, it only adds entries to the event queue.
20161125 23:44:24< celticminstrel> A timer of 0 usually means "call me as soon as possible", not "call me right now".
20161125 23:46:43< vultraz> gfgtdf: if i understand https://gna.org/bugs/?23321 correctly it means dismissing a unit doesn't show the right unit in the preview pane?
20161125 23:49:56< gfgtdf> vultraz: yes https://gna.org/bugs/?25338 is a dublicate with a screenshot attached.
20161125 23:51:17< vultraz> yeah that should be fixed
20161125 23:52:09< vultraz> yeah dismissing reselects
20161125 23:56:30< vultraz> closed
--- Log closed Sat Nov 26 00:00:33 2016