--- Log opened Sun Nov 27 00:00:54 2016
20161127 00:05:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161127 00:05:29-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161127 00:17:07-!- travis-ci [~travis-ci@ec2-54-242-240-19.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 00:17:08< travis-ci> wesnoth/wesnoth#12180 (master - fc39435 : Celtic Minstrel): The build was broken.
20161127 00:17:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179106855
20161127 00:17:08-!- travis-ci [~travis-ci@ec2-54-242-240-19.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 00:18:11< celticminstrel> Oh, Travis is announcing again.
20161127 00:19:00< vultraz> should be fixed wiht my commit
20161127 00:24:23< celticminstrel> Maybe it wasn't announcing because it was a run of good builds.
20161127 00:25:42< vultraz> yeah
20161127 00:40:02-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has joined #wesnoth-dev
20161127 00:49:00-!- Appleman1234_ [~Appleman1@KD106161209015.au-net.ne.jp] has joined #wesnoth-dev
20161127 00:49:28-!- Appleman1234 [~Appleman1@KD106161196188.au-net.ne.jp] has quit [Disconnected by services]
20161127 00:49:36-!- Appleman1234_ is now known as Appleman1234
20161127 01:01:17< Aginor> celticminstrel: now I am, and yes, you're completely right about my ping settings
20161127 01:01:29< celticminstrel> Including the colon?
20161127 01:01:37< celticminstrel> So it won't ping if it's a comma, for example?
20161127 01:01:40< Aginor> ummm
20161127 01:01:49< celticminstrel> Or was that part wrong?
20161127 01:01:57-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has quit [Remote host closed the connection]
20161127 01:01:59< Aginor> I think it just looks for my nick, doesn't care about what follows
20161127 01:02:14< Aginor> well, it is probably a bit smarter than that
20161127 01:02:19< celticminstrel> Okay, so vultraz was building a colour class.
20161127 01:02:21< Aginor> but it's irssi default, I think
20161127 01:02:26< celticminstrel> Have you looked at it?
20161127 01:02:32< Aginor> it's been a long time since I changed/looked at it
20161127 01:02:44< celticminstrel> There was some question about whether the uint32 converter should be ARGB or RGBA.
20161127 01:02:45< Aginor> probably 4 years or so :D
20161127 01:03:07< celticminstrel> Might've been some other questions too, can't remember.
20161127 01:08:59< Aginor> ok...
20161127 01:09:19-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20161127 01:09:33< Aginor> I think we need functions to do both, ARGBA8888 and RGBA8888 as both are used internally within the game
20161127 01:10:13< Aginor> we should also typedef our packed values so that we have type information about whether it's ARGB8888 or RGBA8888
20161127 01:10:53< Aginor> but unless using an external API that requires it, I do not think we should ever internally use a raw uint32_t
20161127 01:16:06-!- Aginor [~andreas@unaffiliated/aginor] has quit [Quit: leaving]
20161127 01:16:16-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20161127 01:16:16-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20161127 01:16:16-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20161127 01:16:24-!- Aginor [~andreas@unaffiliated/aginor] has quit [Client Quit]
20161127 01:16:49< celticminstrel> Okay.
20161127 01:17:35 * celticminstrel has no idea whether we use any external APIs that need it.
20161127 01:17:50-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20161127 01:18:19< celticminstrel> Aginor: Do we use external APIs that require integers as colours?
20161127 01:18:32< vultraz> SDL?
20161127 01:18:36< pydsigner> vultraz: I'm looking at the stats dialog again and I'd suggest changing 1× to ×1
20161127 01:18:43< celticminstrel> vultraz: SDL uses its colour struct.
20161127 01:18:57< vultraz> some functions take Uint8
20161127 01:19:14< vultraz> pydsigner: why?
20161127 01:19:33< celticminstrel> vultraz: If you mean the RGB map functions or whatever, that's a special case... are there others?
20161127 01:19:37< pydsigner> It's on the wrong side to be 1×
20161127 01:20:04< Aginor> celticminstrel: possibly pango/cairo
20161127 01:20:57< Aginor> but it doesn't look like it's using packed values either
20161127 01:21:22< vultraz> Aginor: could you look over my color_t class and give feedback
20161127 01:21:26< vultraz> (not the individual commits)
20161127 01:21:33< Aginor> vultraz: sure, do you have a PR?
20161127 01:21:46< vultraz> no, it's checked in.
20161127 01:21:49< vultraz> src/sdl/color.*pp
20161127 01:21:52< Aginor> ok, which branch?
20161127 01:21:56< vultraz> master
20161127 01:22:03< Aginor> oh
20161127 01:22:04< Aginor> ok
20161127 01:22:42< celticminstrel> Checked in but not yet used anywhere.
20161127 01:27:16< Aginor> != and == operators do not follow the same semantics, that's going to be really confusing for someone
20161127 01:28:01< Aginor> I don't think we should have the addion operators at all, but if they're kept, they should treat both values as atomic
20161127 01:28:18< Aginor> int c = int a + int b shouldn't modify int a
20161127 01:28:48< celticminstrel> What do you mean about the comparisons?
20161127 01:28:52< Aginor> I think the hex string should contain the '#', it's commonly used
20161127 01:29:00< Aginor> celticminstrel: != uses pointer comparison
20161127 01:29:05< Aginor> celticminstrel: == does value comparison
20161127 01:29:25< celticminstrel> "*this" is not a pointer?
20161127 01:29:36< Aginor> sorry, I misread
20161127 01:29:49< Aginor> I didn't spot it being dereferenced
20161127 01:29:50< celticminstrel> The operator+ takes its argument by value.
20161127 01:30:03< celticminstrel> So it's not mutating either side.
20161127 01:30:19< celticminstrel> (That's why I wrote c += *this instead of *this += c, as well.)
20161127 01:31:14 * celticminstrel is ambivalent about the #, but will point out that some of the WML uses hex colours without a prefix.
20161127 01:31:32< celticminstrel> Though it's read-only WML, so maybe not relevant.
20161127 01:32:05< Aginor> color_t color_t::from_hex_string(const std::string& c)
20161127 01:32:12< Aginor> doesn't look endian safe
20161127 01:32:25< vultraz> show me a way to do away with strtol
20161127 01:32:27< Aginor> color_t color_t::from_rgba_uint32(uint32_t c)
20161127 01:32:56< Aginor> should use the bitshifts as well, not just the SDL_*_MASK
20161127 01:33:09< Aginor> those defines can be made endian safe
20161127 01:33:12< celticminstrel> I think it probably is endian safe, as strtol is converting a string of ASCII digits?
20161127 01:33:13< vultraz> your bitshists assume ARGB
20161127 01:33:20< Aginor> without changing the shifts
20161127 01:33:20< vultraz> shifts
20161127 01:33:36< Aginor> vultraz: so make more
20161127 01:33:58< Aginor> move those defines into the color header too
20161127 01:34:18< vultraz> I will when I have approval to deploy
20161127 01:34:28< vultraz> (i  guess i can copy them for not tho)
20161127 01:34:49< Aginor> 	color_t& operator+=(const color_t& c)
20161127 01:35:10< Aginor> gives me warnings as well, there's ints being passed into uint8s
20161127 01:36:00< celticminstrel> Blah, stupid promotion rules.
20161127 01:37:08< vultraz> anyway, is this a design you approve of.
20161127 01:37:27< vultraz> celticminstrel: can we revert += to use max?
20161127 01:37:38< Aginor> I'm not sure about the addition operator
20161127 01:38:03< celticminstrel> vultraz: Was thinking about doing that.
20161127 01:38:15< vultraz> i only added it for compatibility with "color addition" in display.cpp 
20161127 01:38:19< celticminstrel> Aginor: I'm kinda unsure about it too TBH.
20161127 01:38:24< vultraz> because tod's have their own color struct
20161127 01:38:25< Aginor> I think it'd make more sense to not use operator overloading, because I think we'll want other methods in the future
20161127 01:38:29< vultraz> with operator+
20161127 01:38:35< celticminstrel> Oh, so colour addition was there already?
20161127 01:38:52< Aginor> I'm in favour of having it, not just as operator+
20161127 01:38:56< Aginor> to be clear about it
20161127 01:38:57< celticminstrel> Aginor: Like, other methods of blending?
20161127 01:39:00< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/time_of_day.hpp#L35
20161127 01:39:09< Aginor> celticminstrel: yes
20161127 01:39:26< celticminstrel> Aginor: So, what would you call this one?
20161127 01:39:33< Aginor> and they won't be able to use the operators, so we should make it consistant
20161127 01:39:53< Aginor> celticminstrel: addition? :D
20161127 01:40:05< Aginor> we may also want an additional_blend
20161127 01:40:21< Aginor> also, why not wrap up an instance of SDL_color and use?
20161127 01:40:22< celticminstrel> How about color_t blend_add(color_t c)?
20161127 01:40:41< celticminstrel> (Possibly plus const/ref)
20161127 01:41:08< vultraz> Aginor: for direct member access
20161127 01:41:12< Aginor> celticminstrel: it's not blending unless you start to muck around with alpha as well
20161127 01:41:29< celticminstrel> Well, it is adding alpha, but...
20161127 01:41:31< vultraz> one cannot do color_t { r g b a } if r g b and a are part of a color member
20161127 01:41:47< vultraz> or color_t c;
20161127 01:41:48< celticminstrel> vultraz: Not true, the constructor takes priority.
20161127 01:41:49< vultraz> c.a
20161127 01:41:50< vultraz> etc
20161127 01:42:00< celticminstrel> However you can't do c.r etc.
20161127 01:42:03< Aginor> I also think it should be a class, not a struct :)
20161127 01:42:18< vultraz> yeah, can't do c.r, etc
20161127 01:42:21< vultraz> and that's very important
20161127 01:42:25< Aginor> c.r() would be fine though
20161127 01:42:26< vultraz> I don't want c.color.r
20161127 01:42:38-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 01:42:42< vultraz> Aginor: then I'd need setter methods too :|
20161127 01:42:43 * celticminstrel understands the encapsulation thing but doesn't really like having .getRed() and such for something this simple.
20161127 01:42:52< celticminstrel> vultraz: Well technically that's not true.
20161127 01:42:56< vultraz> wel]
20161127 01:43:01< vultraz> I COULD do c.color.r = 
20161127 01:43:03< vultraz> but that's ugly
20161127 01:43:06< celticminstrel> You could support c.r() = new_value;
20161127 01:43:19< vultraz> one can do that?
20161127 01:43:21< Aginor> that's ugly though ;)
20161127 01:43:26< celticminstrel> Yeah, just return a reference.
20161127 01:43:32< vultraz> huh
20161127 01:43:35< celticminstrel> But yes, it's ugly, that's why I prefer just having public members. :P
20161127 01:43:48< vultraz> that's why I don't have an SDL_Color internal
20161127 01:43:50< Aginor> I'm in favour of encapsulation here because we are trying to abstract away the internals
20161127 01:43:54< vultraz> and individual uint8_t members
20161127 01:44:01< vultraz> Aginor: ?
20161127 01:44:04< vultraz> what?
20161127 01:44:05< Aginor> exposing the internals limits flexibility
20161127 01:44:20< celticminstrel> Well, first of all, what are the internals in this situation.
20161127 01:44:25< vultraz> the class is pretty flexible :|
20161127 01:44:34< Aginor> vultraz: pass the colour class around, don't expose its internal state
20161127 01:44:59< vultraz> I see no reason for that
20161127 01:45:09< Aginor> celticminstrel: I'd count internal state, ie, the raw values, to be internls
20161127 01:45:31< Aginor> but I'm admittedly using language that also reflects that view
20161127 01:46:01< vultraz> I do not want to add 8 setter and getter methods :|
20161127 01:46:35< celticminstrel> Well, if you had 8 setters and getters it'd be totally possible for the internal values to be a single ARGB integer, if you wanted.
20161127 01:46:47< Aginor> indeed
20161127 01:47:00< vultraz> true
20161127 01:47:02< vultraz> ugh
20161127 01:47:04< celticminstrel> But this class is for a go-between that converts to whatever format we want.
20161127 01:47:11< Aginor> I was suggesting SDL_color because that's the most commonly used type we need
20161127 01:47:37< celticminstrel> BTW, if you're doing getters and setters, please spell the names out in full.
20161127 01:47:41< Aginor> in fact, my original suggestion was "make it a class to encapsulate SDL_color like we encapsulate SDL_Surface"
20161127 01:48:03< vultraz> I don't find that worth it
20161127 01:48:08< celticminstrel> Whether that's get_red/set_red, getRed/setRed, or just red, I don't care.
20161127 01:48:34< celticminstrel> (Actually I'd prefer them to be spelled out as public members, too...)
20161127 01:49:03< celticminstrel> (And yes, it's totally possible for the getter and setter to have the same name; the stream libraries do that a lot.)
20161127 01:49:31< celticminstrel> (Which is different from what I said about returning a reference.)
20161127 01:49:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 01:50:21< vultraz> Aginor: as I said above, the lack of being able to do color.r, color.g, etc, is why I decided to keep our own uint8_t members for each color value
20161127 01:50:27< Aginor> ok
20161127 01:50:35< Aginor> anyway, that's my opinions
20161127 01:50:43< Aginor> do with them as you please
20161127 01:50:47< vultraz> alright
20161127 01:51:08< vultraz> can I at least start using the class once the few things have been fixed?
20161127 01:51:13< vultraz> struct
20161127 01:51:31< Aginor> you can start using it whenever you want, you don't need my permission :)
20161127 01:51:32< celticminstrel> vultraz: So should I rename the addition operator?
20161127 01:51:44< vultraz> celticminstrel: sure
20161127 01:51:49< celticminstrel> vultraz: Or leave it as an operator?
20161127 01:51:49< Aginor> but I would suggest making it a proper class
20161127 01:51:50< celticminstrel> Okay.
20161127 01:52:57< vultraz> I see no reason for it to be a class since it has no private members
20161127 01:53:18< celticminstrel> vultraz: That comment misses the point. :P
20161127 01:53:34< vultraz> oh?
20161127 01:53:59< celticminstrel> When someone says "it should be a class instead of a struct" they're implying "you should make the members private".
20161127 01:57:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 01:58:51< vultraz> ah
20161127 01:59:19< celticminstrel> I realized that max is only correct when overflow does occur.
20161127 01:59:52< irker622> wesnoth: Celtic Minstrel wesnoth:master 8ee8ca6786ce / src/sdl/color.hpp: Rename addition operators to regular function https://github.com/wesnoth/wesnoth/commit/8ee8ca6786ceb7f37a5e78d5b026aea954ecbc9a
20161127 02:00:08< celticminstrel> ...whoops, forgot to mention color_t in the message. Oh well.
20161127 02:01:29< Aginor> oh yeah, as for making 8 getters/setters
20161127 02:01:56< Aginor> I press alt+insert in my IDE and choose which members I want them generated for
20161127 02:02:00< Aginor> easy :D
20161127 02:04:25< celticminstrel> Did someone delete the wml_tag_porting branch, or was that me?
20161127 02:04:54< celticminstrel> Or did the local branch just somehow lose its upstream information?
20161127 02:05:07< celticminstrel> I guess it's the latter.
20161127 02:05:32< irker622> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 44d6ed1947db / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/44d6ed1947dbd10ab4ed9a4730a4cc10235b1a9a
20161127 02:05:34< irker622> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting ace0e5a7ebaa / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/ace0e5a7ebaad9738ae3a7d3f78a20ba49439f32
20161127 02:05:36< irker622> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 3d03c7eafdb6 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/3d03c7eafdb6adbbf1354499838011faee00b925
20161127 02:05:38< irker622> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 0cc1d6b97c59 / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/0cc1d6b97c59acf37d58cb04c998d41979250b4b
20161127 02:05:40< irker622> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f29fb163f06c / / (3 files in 2 dirs): WIP port of [animate_unit] https://github.com/wesnoth/wesnoth/commit/f29fb163f06ca2f907b575a73b05c35be21b0b2e
20161127 02:05:52< celticminstrel> I haven't had the chance to test that last commit yet.
20161127 02:06:04< celticminstrel> Some of the others weren't extensively tested either, I think.
20161127 02:06:19< celticminstrel> ...maybe I should open a PR for this.
20161127 02:11:11 * celticminstrel is now working on the uint32 converters.
20161127 02:12:28< celticminstrel> vultraz: Were you planning to do anything more on color_t?
20161127 02:12:48< EliDupree> By the way, for UI purposes, I would quite like to have a way to trigger a script when the user clicks on a hex. (As far as I can tell, you can currently approximate this with the select event, but that only works with your own units.)
20161127 02:13:15< celticminstrel> EliDupree: I want that too. It might even already be on my list of things to maybe do someday.
20161127 02:13:38< EliDupree> Excellent! :-)
20161127 02:13:54< celticminstrel> Actually, just detecting a click would be significantly easier than blocking for mouse input...
20161127 02:14:03-!- gfgtdf [~chatzilla@x4e36a8ae.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161127 02:14:19< celticminstrel> But that would mean returning control to the player, so they might do something else you don't expect...
20161127 02:14:25-!- gfgtdf [~chatzilla@x4e3683f5.dyn.telefonica.de] has joined #wesnoth-dev
20161127 02:14:42< EliDupree> If you also let me trigger scripts on arbitrary keypresses and detect the pixel location of the mouse, I will be all set to write my Wesnoth-based side-scrolling arena shooter :-P
20161127 02:14:50< celticminstrel> (Assuming you're using it for, eg, targeting a spell. If you're using it for something they should be able to trigger at any time, that would be different.)
20161127 02:15:14< EliDupree> But more seriously, yes, I want it exactly to let the user targets spells conveniently
20161127 02:15:40< celticminstrel> Arbitrary keypresses are probably semi-possible using menuitems with default hotkeys.
20161127 02:16:21< EliDupree> You can set a default hotkey? What happens if the player already has used that as a hotkey?
20161127 02:16:51< celticminstrel> I suspect the key would trigger both things, but I could be wrong.
20161127 02:16:56< EliDupree> heh
20161127 02:17:34< EliDupree> Probably very few users customize their hotkeys, so I could mostly be successful with just dodging the standard ones.
20161127 02:18:33< EliDupree> Wiki says default_hotkey is even in 1.12 :-)
20161127 02:18:53< celticminstrel> There's a chance of the standard hotkeys suddenly changing though.
20161127 02:19:08< EliDupree> Then I could change my add-on
20161127 02:20:03< EliDupree> "Point-and-click" is still a much easier interface than "point and press E"
20161127 02:22:44< vultraz> celticminstrel: not immediately
20161127 02:23:02< celticminstrel> Wow, your from_rgba_string was also broken (used the first component for all 4).
20161127 02:23:37< celticminstrel> vultraz: Any reason why it should not be an error to have less than 3 colour components?
20161127 02:23:50< vultraz> no reason
20161127 02:23:59< vultraz> tho..
20161127 02:24:28< vultraz> nah
20161127 02:25:34< celticminstrel> vultraz: The format for Doxygen parameter comments is "@param the_param description of parameter". You missed the second component in your comments.
20161127 02:26:19< vultraz> ugh
20161127 02:26:27< vultraz> do we even look at this doxygen stuff anywhere
20161127 02:26:29 * celticminstrel has already fixed it locally.
20161127 02:26:34< celticminstrel> I don't know.
20161127 02:26:47< celticminstrel> Even if we don't, it's useful when just looking at the code too.
20161127 02:28:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161127 02:29:59< gfgtdf> EliDupree: there are afaik lua callbacks wesnoth.game_events.on_mouse_move, wesnoth.game_events.on_mouse_action callbacks not sure if they work correctly though 
20161127 02:30:14< gfgtdf> EliDupree: in wesnot 1.13 i mean
20161127 02:30:27< EliDupree> hmm
20161127 02:30:45< celticminstrel> vultraz: Should we support HTML-style 3-digit hex colours, or only 6-digit?
20161127 02:30:56< vultraz> 6
20161127 02:31:02< vultraz> what does 3 look like?
20161127 02:31:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 02:31:18< celticminstrel> "ddd" is equivalent to "dddddd"
20161127 02:31:27< celticminstrel> (In HTML-style notation.)
20161127 02:31:36< EliDupree> gfgtdf: Well, message me when they work correctly :-)
20161127 02:31:37< celticminstrel> (I guess it's more CSS-style now.)
20161127 02:31:50< vultraz> eh, nah
20161127 02:32:21< gfgtdf> EliDupree: well i didnt say they wont work correctly
20161127 02:32:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 02:32:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 02:35:18< celticminstrel> Why were you using masks in the to_hex_string routine... o.O
20161127 02:35:29< celticminstrel> That guaranteed your output was incorrect.
20161127 02:35:57 * celticminstrel is using int() again, feel free to replace with static_casts at your leisure.
20161127 02:40:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 02:42:43 * celticminstrel initiates build, will probably push in an hour or so once it's done.
20161127 02:43:07< celticminstrel> (A combination of actual time building and uncertainty of completion time.)
20161127 03:01:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161127 03:01:58-!- travis-ci [~travis-ci@ec2-54-242-135-15.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 03:01:59< travis-ci> wesnoth/wesnoth#12184 (master - 8ee8ca6 : Celtic Minstrel): The build has errored.
20161127 03:01:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179138174
20161127 03:01:59-!- travis-ci [~travis-ci@ec2-54-242-135-15.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 03:05:11-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 260 seconds]
20161127 03:15:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161127 03:16:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 03:20:12-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20161127 03:22:07-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161127 03:29:31-!- gfgtdf [~chatzilla@x4e3683f5.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161127 03:37:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161127 04:05:07-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 04:05:08< travis-ci> wesnoth/wesnoth#12186 (wml_tag_porting - f29fb16 : Celtic Minstrel): The build is still failing.
20161127 04:05:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179138656
20161127 04:05:08-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 04:14:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 04:43:56< vultraz> [13:35:18]	celticminstrel	Why were you using masks in the to_hex_string routine...
20161127 04:44:00< vultraz> im not supposed to?
20161127 04:44:11< vultraz> i kinda just copied it
20161127 04:44:28< vultraz> (also do i need to use std::hex, setfill, and setw 3 times?
20161127 04:52:38< celticminstrel> I'll let my commits answer that when I push them... which should be very soon now...
20161127 05:05:48-!- irker622 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161127 05:07:14< vultraz> good, good
20161127 05:10:34< celticminstrel> Wow, ranlib or something failed due to insufficient disk space.
20161127 05:10:55-!- irker676 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161127 05:10:55< irker676> wesnoth: Celtic Minstrel wesnoth:master 0ffa7f29e981 / src/sdl/color.hpp: color_t: Minor documentation fixes/clarifications https://github.com/wesnoth/wesnoth/commit/0ffa7f29e981fddde941c22dbda9a016c6c1f616
20161127 05:10:55< irker676> wesnoth: Celtic Minstrel wesnoth:master 37e0d98e5c5a / src/sdl/ (color.cpp color.hpp utils.cpp utils.hpp): color_t: Fix/improve uint32_t conversions https://github.com/wesnoth/wesnoth/commit/37e0d98e5c5a0450a2864a65b25d9c3cdea90b4c
20161127 05:10:56< irker676> wesnoth: Celtic Minstrel wesnoth:master dd43a96d7d94 / src/sdl/ (color.cpp color.hpp): color_t: Fix/improve string conversions https://github.com/wesnoth/wesnoth/commit/dd43a96d7d94f8c0709f2241d7e55d359a0388cb
20161127 05:10:58< celticminstrel> I need to do something about that.
20161127 05:11:38< celticminstrel> ...oh, did I add @throw std::invalid_argument to the from_hex_string...?
20161127 05:14:38< irker676> wesnoth: Celtic Minstrel wesnoth:master 4c56159dc15e / src/sdl/color.hpp: color_t: Minor docs clarification https://github.com/wesnoth/wesnoth/commit/4c56159dc15e92864871ca629bba1edeffc39084
20161127 05:15:14< celticminstrel> I guess I can delete the older versions of the libs used by XCode.
20161127 05:18:03< celticminstrel> wesnoth dir is 4.09GB, wesnoth1.12 dir is only 681.2MB.
20161127 05:19:09 * celticminstrel deletes Wesnoth.app, reduces it to 3.66GB.
20161127 05:22:37< vultraz> so many changes
20161127 05:22:42< celticminstrel> ?
20161127 05:23:28< celticminstrel> Well, I've gone from ~1GB available to ~6GB available, so yay.
20161127 05:23:56< vultraz> I see you got rid of the auto-insertion of '0' for missing fields
20161127 05:24:02< celticminstrel> What?
20161127 05:24:11< vultraz> in from_rgba_string
20161127 05:24:21< celticminstrel> Probably not?
20161127 05:24:26< celticminstrel> Oh, wait.
20161127 05:24:28< celticminstrel> from not to
20161127 05:24:53< celticminstrel> That's because if you have a colour "128,128" it's probably a mistake, rather than intending yellow.
20161127 05:25:03< celticminstrel> (Or muddy brown maybe.)
20161127 05:25:42< celticminstrel> However it's probably not a mistake if you omit the alpha, so it'll still consider "128,128,128" valid.
20161127 05:25:55< celticminstrel> But unlike before, it uses 255 instead of 0 for the alpha.
20161127 05:26:58< celticminstrel> BTW, we should probably refactor adjust_surface_alpha_formula out of sdl/utils.cpp
20161127 05:27:13< celticminstrel> Maybe just merge it into the single call site.
20161127 05:27:32< celticminstrel> (And move pixel_callable too.)
20161127 05:32:18< celticminstrel> Just noting, if you do decide to squash PR 875, make sure to rewrite the commit message so that it covers everything that's there, since each commit does introduce something different.
20161127 05:36:12< celticminstrel> wedge009, mattsc, DeFender1031, anyone else interested: If you have time, please test stuff on PR 881.
20161127 05:36:43< celticminstrel> Link for convenience: https://github.com/wesnoth/wesnoth/pull/881
20161127 05:37:23< celticminstrel> ...I bet the Travis failure on that branch is WML-tag-related... either that, or the [animate_unit] commit doesn't compile...
20161127 05:37:43< celticminstrel> s/WML-tag/WML-test/
20161127 05:38:30< celticminstrel> Oh.
20161127 05:38:53< celticminstrel> Well, I guess I'll need to rebase it again before anyone can actually test, but I'll go do that right now, so it'll probably be done by the time anyone actually gets to it.
20161127 05:43:22< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 819374f3a8b4 / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/819374f3a8b479e5255569d942e92928c5ea8cec
20161127 05:43:24< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 49789d763f85 / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/49789d763f85c6fff306fd3379846a012ec23a15
20161127 05:43:26< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 515302ed6858 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/515302ed68585f527657d588be17efb982197c42
20161127 05:43:28< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 12f747e217da / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/12f747e217dabe0d87478a9289b75f17c0cd9850
20161127 05:43:30< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting ae9f016588e2 / / (3 files in 2 dirs): WIP port of [animate_unit] https://github.com/wesnoth/wesnoth/commit/ae9f016588e2a029d611f9316d45d5e3f499b97a
20161127 05:49:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 06:00:51< celticminstrel> "There is no thread for the sprites. They are being handled internally."
20161127 06:00:55< celticminstrel> :|
20161127 06:04:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161127 06:04:30-!- travis-ci [~travis-ci@ec2-54-159-65-98.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 06:04:31< travis-ci> wesnoth/wesnoth#12187 (master - dd43a96 : Celtic Minstrel): The build failed.
20161127 06:04:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179152637
20161127 06:04:31-!- travis-ci [~travis-ci@ec2-54-159-65-98.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 06:05:44-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161127 06:09:24< irker676> wesnoth: Celtic Minstrel wesnoth:master 25c9b67a5d46 / src/sdl/color.hpp: color_t: Mark operator<< inline to avoid link errors https://github.com/wesnoth/wesnoth/commit/25c9b67a5d468f5839b44b84a4a1b41c81500d44
20161127 06:09:46< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f4bd95b79688 / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/f4bd95b7968840c34ff377c2c249f6c04e81fa7c
20161127 06:09:48< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 92a6ee8d5ca2 / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/92a6ee8d5ca2b5b1f539da288428f676f9133902
20161127 06:09:50< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting ae42c2d0722f / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/ae42c2d0722f5c0d852568987e3d291ba63046f8
20161127 06:09:52< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting a198a7eab488 / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/a198a7eab4887a1cbba566d135e826ee759d599d
20161127 06:09:54< irker676> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 043e754d1672 / / (3 files in 2 dirs): WIP port of [animate_unit] https://github.com/wesnoth/wesnoth/commit/043e754d16722e8f6c44c03a884af529013f16d2
20161127 06:12:13-!- JyrkiVesterinen [~JyrkiVest@87-100-224-231.bb.dnainternet.fi] has joined #wesnoth-dev
20161127 06:22:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 06:36:50-!- Kwandulin [~Miranda@p200300760F6EBF22EC0FC54EF8015AFD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161127 06:41:08-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 06:49:22-!- Kwandulin [~Miranda@p200300760F6EBF22EC0FC54EF8015AFD.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20161127 06:54:33-!- Kwandulin [~Miranda@p200300760F6EBF22EC0FC54EF8015AFD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161127 07:36:52-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161127 07:37:16-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:37:37-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:38:01-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:38:26-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:38:49-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:38:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161127 07:39:14-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:39:39-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:40:02-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:40:24-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:40:50-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:41:12-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:41:38-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:42:00-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:42:26-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:42:49-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:43:14-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:43:38-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161127 07:44:02-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161127 07:45:26-!- travis-ci [~travis-ci@ec2-54-242-135-15.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 07:45:27< travis-ci> wesnoth/wesnoth#12191 (master - 25c9b67 : Celtic Minstrel): The build is still failing.
20161127 07:45:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179156779
20161127 07:45:27-!- travis-ci [~travis-ci@ec2-54-242-135-15.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 07:45:41< celticminstrel> :(
20161127 07:46:05< celticminstrel> Hmm, the Mac build passed though. So it's probably something in tests.
20161127 07:47:24< celticminstrel> Yup, my changes to sdl/utils.cpp broke things that use those functions with invalid input.
20161127 07:47:51< celticminstrel> Well, it's not serious enough to address right now.
20161127 07:47:54< celticminstrel> Sleep time.
20161127 07:54:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161127 07:54:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161127 07:55:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161127 07:55:33-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161127 07:56:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161127 07:59:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20161127 08:01:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161127 08:20:37-!- travis-ci [~travis-ci@ec2-54-159-65-98.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 08:20:38< travis-ci> wesnoth/wesnoth#12192 (wml_tag_porting - 043e754 : Celtic Minstrel): The build is still failing.
20161127 08:20:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179156811
20161127 08:20:39-!- travis-ci [~travis-ci@ec2-54-159-65-98.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 08:43:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20161127 09:07:48< wedge009> celticminstrel: Maybe tomorrow. Sorry.
20161127 09:09:59-!- irker676 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161127 09:20:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161127 09:27:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161127 10:32:33-!- APic [apic@apic.name] has quit [Read error: No route to host]
20161127 10:34:15-!- APic [apic@apic.name] has joined #wesnoth-dev
20161127 10:41:07-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20161127 10:42:49-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161127 11:03:29-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has joined #wesnoth-dev
20161127 11:10:31-!- Kwandulin [~Miranda@p200300760F6EBF22EC0FC54EF8015AFD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161127 11:12:11-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has quit [Remote host closed the connection]
20161127 11:16:41-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20161127 11:22:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161127 11:34:41-!- JyrkiVesterinen [~JyrkiVest@87-100-224-231.bb.dnainternet.fi] has quit [Quit: .]
20161127 11:51:58-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has joined #wesnoth-dev
20161127 12:20:00-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20161127 12:25:48-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161127 12:36:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161127 12:57:22-!- Bonobo [~Bonobo@2001:44b8:254:3200:a8a6:3514:c4c5:86ad] has quit [Ping timeout: 258 seconds]
20161127 13:01:34-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161127 13:21:26-!- louis94 [~~louis94@91.178.240.141] has joined #wesnoth-dev
20161127 13:47:23-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has quit [Remote host closed the connection]
20161127 14:16:54-!- gfgtdf [~chatzilla@x4e3683f5.dyn.telefonica.de] has joined #wesnoth-dev
20161127 14:49:49< matthiaskrgr> game doesn't launch :( 
20161127 14:49:59< matthiaskrgr> Caught general exception:  Wrong number of components for RGB color  
20161127 14:52:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161127 15:17:24-!- Kwandulin [~Miranda@p200300760F6EBF22F4F803CA840BD0AE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161127 15:18:17-!- gfgtdf_ [~chatzilla@x4e3683f5.dyn.telefonica.de] has joined #wesnoth-dev
20161127 15:20:16-!- gfgtdf [~chatzilla@x4e3683f5.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20161127 15:20:26-!- gfgtdf_ is now known as gfgtdf
20161127 15:50:41-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161127 15:53:52-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20161127 15:54:05-!- VultCave is now known as vultraz
20161127 15:56:08-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161127 15:56:08-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161127 16:24:26-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161127 16:25:59-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has joined #wesnoth-dev
20161127 16:39:15-!- Kwandulin [~Miranda@p200300760F6EBF22F4F803CA840BD0AE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161127 16:46:20-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161127 16:48:32-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161127 16:59:43-!- Kwandulin [~Miranda@p200300760F6EBF22708C13F4FE61E215.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161127 17:01:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161127 17:05:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161127 17:25:37< celticminstrel> So, I noticed [floating_text] doesn't take a colour, but the Lua API call that implements it does.
20161127 17:25:50< celticminstrel> Why.
20161127 17:27:11< gfgtdf> celticminstrel: [floating_text] isnt the only tag that uses wesnoth.float_label
20161127 17:27:24< celticminstrel> Still a good question though.
20161127 17:28:00< celticminstrel> Is [print] different?
20161127 17:28:06< vultraz> yes
20161127 17:28:16< celticminstrel> 'kay
20161127 17:28:20< DeFender1031> celticminstrel, so why not just add attributes to allow a color, making whatever it currently uses default?
20161127 17:28:48< celticminstrel> float_label already defaults if not colour is passed, so yeah. I'll commit this.
20161127 17:29:00< vultraz> for the record one can use pango markup to customize the color
20161127 17:29:06< celticminstrel> As color=, not red,green,blue=
20161127 17:29:17< celticminstrel> Yeah, but pango markup is disgusting.
20161127 17:29:34< celticminstrel> I'd rather phase it out altogether.
20161127 17:29:42< celticminstrel> In favour of something more markdown-like.
20161127 17:33:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 17:33:21< celticminstrel> Why do red, lightred, and darkred all have the same minimap colour?
20161127 17:34:07< celticminstrel> Also, why do most of the team colours have pure white as the maximum highlight and pure black as the minimum shadow?
20161127 17:34:43< celticminstrel> Heh, you could use "color=reef" in a side if you wanted to. :P
20161127 17:48:53-!- Kwandulin [~Miranda@p200300760F6EBF22708C13F4FE61E215.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161127 17:50:48< zookeeper> celticminstrel, err, and what would reef mean there?
20161127 17:54:16< vultraz> the reef palette
20161127 17:55:19< vultraz> celticminstrel: no idea about the palette stuff
20161127 17:55:34< vultraz> for the record, we have a rather inefficient palette swap method.
20161127 18:01:07< Ravana_> Is it still needed to define palettes on toplevel?
20161127 18:11:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 18:11:40-!- mjs-de [~mjs-de@x4e312c17.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161127 18:11:53-!- mjs-de [~mjs-de@x4e3121ae.dyn.telefonica.de] has joined #wesnoth-dev
20161127 18:15:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has joined #wesnoth-dev
20161127 18:17:39< celticminstrel> zookeeper: Terrain icons are recoloured using team colours, so each terrain category has its own "team" colour.
20161127 18:19:19< zookeeper> where are those defined? there are no colors in terrain.cfg nor terrain-groups.cfg
20161127 18:41:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:ad9e:9fc1:fc47:250a] has quit [Remote host closed the connection]
20161127 18:46:51< celticminstrel> zookeeper: My guess is that it uses the terrain type's ID as a colour.
20161127 18:46:58< celticminstrel> Which is really not ideal.
20161127 18:48:02< celticminstrel> The hidden terrain archetypes at the bottom of terrain.cfg should probably specify the colour as a separate attribute, or maybe somehow encode it into icon_image as an ~RC() or something.
20161127 18:48:48< celticminstrel> (Though I guess terrain code transforms the image path, so it'd need to be aware of IPFs for that to work.)
20161127 18:49:02< celticminstrel> (No idea whether it is.)
20161127 18:49:25< zookeeper> "Terrain icons are recoloured using team colours, so each terrain category has its own "team" colour." <- so to clarify, where are those colours seen in-game?
20161127 18:49:49< celticminstrel> In the sidebar, on the small terrain icons.
20161127 18:50:14< celticminstrel> The actual icons on disk are magenta.
20161127 18:51:08< celticminstrel> Not quite sure where that image is...
20161127 18:51:33< celticminstrel> Looks like the icons themselves are transparent, so ~RC() wouldn't help; they're then superimposed on a TCed base.
20161127 18:52:16< zookeeper> the icons are white
20161127 18:52:22< zookeeper> not magenta
20161127 18:52:42< celticminstrel> There's a magenta base somewhere. I've seen it in-game even.
20161127 18:53:02< zookeeper> maybe they're recoloured using the magenta palette if white is part of the magenta palette, but still
20161127 18:55:03< zookeeper> images/buttons/icon-base
20161127 18:55:15< zookeeper> that's taken as a base and then the white icons are blitted onto them
20161127 18:55:20< celticminstrel> Yup, that's the one.
20161127 18:55:40< celticminstrel> Did you find that in the WML somewhere or in the filesystem?
20161127 18:55:54< zookeeper> grepped for icons/terrain in src/
20161127 18:56:03< celticminstrel> Ah.
20161127 18:56:36< celticminstrel> Somehow it feels like the Finder keeps forgetting my "show icon preview" settings.
20161127 18:57:13< zookeeper> although i might be looking at the unit help page generator code
20161127 18:57:25< celticminstrel> It's probably the same icon though.
20161127 18:57:31< celticminstrel> I mean, no, it is the same icon.
20161127 18:57:52< celticminstrel> I wonder if there's any easy way to find unused images in the Wesnoth data directories.
20161127 18:58:42< DeFender1031> For the record, I actually have a "color=frozen" in a side definition in one of my scenarios, because I liked that color for a specific group of characters.
20161127 18:59:07< zookeeper> right, there's a more general case in reports.cpp. however, it's still just constructing what's basically ~RC(magenta > terrain_id)... what sense does that make? where are those based-on-terrain-id palettes defined/generated?
20161127 18:59:11< celticminstrel> I was thinking it'd be a good idea to change some of those names though at some point.
20161127 18:59:35< celticminstrel> zookeeper: The team colours for terrains are defined in team_colors.cfg.
20161127 18:59:57< celticminstrel> Near the bottom.
20161127 19:00:08< zookeeper> ohhhhhh. right, in the middle. i scrolled over it
20161127 19:00:23< zookeeper> well, okay, clarity achieved
20161127 19:04:44< celticminstrel> It might be nice if the icons in images/icons/profiles could be finished and put to use...
20161127 19:20:03-!- louis94 [~~louis94@91.178.240.141] has quit [Ping timeout: 260 seconds]
20161127 19:33:44< DeFender1031> celticminstrel, even if they change, i cal always either update my code to point to the new name, or just re-add that color to my own add-on
20161127 19:35:03< celticminstrel> True enough.
20161127 19:41:20< DeFender1031> Though I thought it was kinda cool to use the terrain recolor hacked into the side-coloring system as an actual side color.
20161127 19:42:03< DeFender1031> it's like... taking a system implemented as a hack of another system and using it for what the system was originally designed for
20161127 19:43:08< DeFender1031> it's also strange to me that all those icons would be in magenta and handled through the recolor system, rather than just existing with the correct colors already... I mean, they're already separate icons so you don't really gain anything by making them magenta
20161127 20:12:04< zookeeper> yeah i don't really see why they're implemented in such a complicated manner
20161127 20:12:26< zookeeper> but if it works then it doesn't hurt, i guess.
20161127 20:14:59< celticminstrel> I can't fix the Travis failure because I can't get the debugger to break on thrown exceptions... :/
20161127 20:15:15< celticminstrel> Neither gdb (on Mac) nor MSVC is doing it.
20161127 20:15:43< celticminstrel> Even though it's a std::invalid_argument, which extends std::exception (indirectly), which MSVC is set to break on.
20161127 20:16:19< celticminstrel> I know where it's being thrown (one of two places), but I need the stack trace to figure out what the root of the problem is.
20161127 20:17:25< celticminstrel> If anyone needs a working master though, just comment out the exceptions thrown in src/sdl/color.cpp.
20161127 20:17:36< gfgtdf> celticminstrel: can't you just set msvc to break on all exceptions ?
20161127 20:17:39< celticminstrel> (Two of them.)
20161127 20:17:44< celticminstrel> gfgtdf: Uh. Not sure?
20161127 20:18:50< celticminstrel> gfgtdf: Apparently yes. That worked.
20161127 20:22:35< celticminstrel> Huh. The titlescreen panel colours are now broken somehow.
20161127 20:23:39< loonycyborg> gdb has catch throw
20161127 20:23:48< loonycyborg> it can break on all exceptions
20161127 20:23:59< loonycyborg> and iirc only on particular exceptions too
20161127 20:24:32< celticminstrel> GDB can't even identify the exception for some reason.
20161127 20:24:49< celticminstrel> It gives the "unknown exception caught" message instead of the proper exception message.
20161127 20:25:17< celticminstrel> Presumably some interaction of clang 3.8 with ancient 3.2-ish libc++.
20161127 20:26:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20161127 20:26:42-!- irker560 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161127 20:26:42< irker560> wesnoth: Celtic Minstrel wesnoth:master 1e2d6b6586c0 / changelog data/lua/wml-tags.lua: Add color= to [floating_text] https://github.com/wesnoth/wesnoth/commit/1e2d6b6586c07ae2a8cb47df941cb0b13ed4737f
20161127 20:26:42< irker560> wesnoth: Celtic Minstrel wesnoth:master 3e600a585799 / src/sdl/ (color.cpp color.hpp): color_t: An empty string now returns white instead of throwing https://github.com/wesnoth/wesnoth/commit/3e600a585799015c8dcf8c5705c16bb707345384
20161127 20:26:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161127 20:27:13< celticminstrel> So anyway, this should fix Travis, but some UI colours are now broken.
20161127 20:38:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161127 21:01:36-!- astrelyon [~astrelyon@dh207-48-227.xnet.hr] has quit [Ping timeout: 246 seconds]
20161127 21:05:20-!- gfgtdf [~chatzilla@x4e3683f5.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0/20161104212021]]
20161127 21:11:22-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20161127 21:15:47-!- astrelyon [~astrelyon@dh207-111-195.xnet.hr] has joined #wesnoth-dev
20161127 21:24:11-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161127 21:26:36-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 21:26:37< travis-ci> wesnoth/wesnoth#12194 (master - 3e600a5 : Celtic Minstrel): The build was fixed.
20161127 21:26:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179270772
20161127 21:26:37-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 21:27:25< irker560> wesnoth: Charles Dang wesnoth:master ccde26bbbee4 / src/sdl/ (color.cpp color.hpp): Small logic simplification https://github.com/wesnoth/wesnoth/commit/ccde26bbbee48aaa1238515693253417991bfb38
20161127 21:27:27< irker560> wesnoth: Charles Dang wesnoth:master f0f7022d0c3c / src/scripting/game_lua_kernel.cpp: Add deprecation notice for red=, green=, blue= in [print]. https://github.com/wesnoth/wesnoth/commit/f0f7022d0c3c0463ba97787e92aec06601e8a212
20161127 21:27:35< vultraz> how are they broken when no one uses color_t yet
20161127 21:28:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161127 21:29:14< irker560> wesnoth: Charles Dang wesnoth:master ba28e8c559fd / src/sdl/color.cpp: color_t: fixed an error message https://github.com/wesnoth/wesnoth/commit/ba28e8c559fd4db020f18f89bedeafd82f78fa49
20161127 21:34:10< celticminstrel> vultraz: Your small logic simplification is wrong.
20161127 21:34:30< celticminstrel> Previously it allowed 3 or 4, now it's only 4.
20161127 21:34:43< celticminstrel> (Admittedly, the comment was misleading. Sorry about that.)
20161127 21:35:34< celticminstrel> vultraz: Somewhere in Lua there's red,green,blue support, possibly unstore_unit?
20161127 21:35:38< celticminstrel> Can't remember
20161127 21:35:41< vultraz> yes
20161127 21:35:50< vultraz> I'll get to the rest
20161127 21:36:20< vultraz> anyway, since you added a separate rgb method, I think it makes sense to allow only 4.
20161127 21:36:56< celticminstrel> How many GUI2 colours are specified with implicit alpha?
20161127 21:37:02< vultraz> all.
20161127 21:37:10< celticminstrel> That's why you need to allow 3.
20161127 21:37:12< vultraz> er
20161127 21:37:14< vultraz> wait
20161127 21:37:18< vultraz> misread
20161127 21:37:21< celticminstrel> (Probably most, not all.)
20161127 21:37:25< vultraz> all are specified with 4 colors.
20161127 21:37:36< celticminstrel> Seriously? That's ridiculous though.
20161127 21:37:49< celticminstrel> Also they're called channels, not colours.
20161127 21:37:53< celticminstrel> (Or components.)
20161127 21:38:30< vultraz> how is it ridiculous?
20161127 21:40:16-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20161127 21:43:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161127 21:46:06-!- mjs-de [~mjs-de@x4e3121ae.dyn.telefonica.de] has quit [Remote host closed the connection]
20161127 21:46:42< DeFender1031> Is it not ridiculous to require an explicit alpha channel rather than defaulting for full?
20161127 21:49:58< vultraz> well gui2 used to default it to 0
20161127 21:50:30< vultraz> any uninitialized channel to 0*
20161127 21:51:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161127 21:51:35< vultraz> I'm wondering if we shouldn't just merge these functions
20161127 21:51:53< vultraz> if it gets 3, just add full alpha
20161127 21:51:57< celticminstrel> We should remove the alpha channel from all the GUI2 colours that use 255 and fix your logic break.
20161127 21:52:10< vultraz> what?
20161127 21:52:20< celticminstrel> Use from_rgba_string for GUI2 and from_rgb_string everywhere else.
20161127 21:52:46< vultraz> why do we even need to split this into separate] functions 
20161127 21:53:00< celticminstrel> Because alpha is not logically part of a colour.
20161127 21:53:52< vultraz> ok..
20161127 21:54:08< vultraz> so why did you remove the automatic addition of missing values
20161127 21:54:17< vultraz> oh, wait
20161127 21:54:19< vultraz> I see
20161127 21:54:21< vultraz> hm..
20161127 21:54:26< celticminstrel> Because a colour without a blue component is more likely an error than an intended blue of 0.
20161127 21:54:27< vultraz> ...
20161127 21:54:29< vultraz> hmmmm
20161127 21:54:49< vultraz> we should just make it auto 255
20161127 21:54:56< celticminstrel> I did that.
20161127 21:55:14< celticminstrel> https://github.com/wesnoth/wesnoth/commit/dd43a96d7d94f8c0709f2241d7e55d359a0388cb#diff-97136decbb3f1d72ef29c0e56aee2cf0R33
20161127 21:55:23< vultraz> well
20161127 21:55:34< vultraz> I was thinking automatically adding 255 for any channel missing
20161127 21:55:49< vultraz> like before
20161127 21:55:49< celticminstrel> That's as ridiculous as adding 0 for any missing channels.
20161127 21:56:05 * vultraz groans
20161127 21:56:12< celticminstrel> A colour with fewer than 3 channels is far more likely to be an error than something intentional.
20161127 21:56:16< vultraz> ok
20161127 21:56:19< vultraz> fine, fine
20161127 21:56:31< vultraz> so why do you want to allow RGB in the RGBA function
20161127 21:56:34< vultraz> you split them
20161127 21:56:41< celticminstrel> Just put the if statement back how it was before. (Or if you prefer you can just !=3 && !=4)
20161127 21:56:49< vultraz> fine, fine
20161127 21:56:52< vultraz> i was going to do that
20161127 21:57:12< celticminstrel> I allow RGB in the RGBA because a missing alpha channel is far less likely to be an error than a missing other channel.
20161127 21:58:27< irker560> wesnoth: Charles Dang wesnoth:master 59aad61610db / src/sdl/color.cpp: color_t: partially revert ccde26bbbee4 https://github.com/wesnoth/wesnoth/commit/59aad61610db090b5489499103adcc1f8033de88
20161127 21:59:29< celticminstrel> So, are you going to start using color_t in places now?
20161127 21:59:40< celticminstrel> BTW, there's something wrong currently, have you seen the titlescreen?
20161127 21:59:52< celticminstrel> (Unless one of your commits fixed that.)
20161127 22:00:02< vultraz> I see it :|
20161127 22:00:15 * vultraz curses soundly
20161127 22:00:17< celticminstrel> Maybe there are GUI2 colours that relied on the implicit 0 alpha from before?
20161127 22:00:25< celticminstrel> I dunno.
20161127 22:00:38< celticminstrel> No idea if that could cause that.
20161127 22:01:03 * vultraz curses more
20161127 22:01:20< celticminstrel> Why so much cursing.
20161127 22:01:47< celticminstrel> (The issue is probably caused by my changes to sdl/utils.cpp.)
20161127 22:02:20< vultraz> I have NFI what's going on there.
20161127 22:02:23< vultraz> that's an image!
20161127 22:02:28< celticminstrel> What is?
20161127 22:02:29< vultraz> not a color rect!
20161127 22:02:40< vultraz> the titlescreen glitched area
20161127 22:02:44< celticminstrel> It is?
20161127 22:02:54< vultraz> yes
20161127 22:02:56< celticminstrel> Well, that makes sense though.
20161127 22:03:01< vultraz> oh, looks like alpha is broken too..
20161127 22:03:09< celticminstrel> It fits my theory of implicit 0 alpha.
20161127 22:03:37< vultraz> jesus christ
20161127 22:03:39< celticminstrel> Perhaps using a background image requires setting the background colour fully transparent.
20161127 22:04:02< celticminstrel> I'd recommend looking over all the GUI2 colours.
20161127 22:04:23 * Aginor gives that suggestion thumbs up
20161127 22:04:42< celticminstrel> Removing any trailing ,255 alpha and adding any missing ,0 alpha.
20161127 22:04:52< celticminstrel> Hi Aginor 
20161127 22:04:54< vultraz> what's wrong with trailing 255 alpha
20161127 22:04:56< vultraz> it doesn't hurt anyone
20161127 22:05:04< celticminstrel> Well true. You can ignore it if you want.
20161127 22:05:14< vultraz> none of this makes any damn sense
20161127 22:05:17< celticminstrel> I'd prefer it to be removed, but it's not that important.
20161127 22:05:42< celticminstrel> Still, check if there are any 3-component colours anywhere, because that's a possible cause of this issue.
20161127 22:05:43< Aginor> hi celticminstrel 
20161127 22:05:59< Aginor> I'm doing a bit of lurking inbetween my meetings
20161127 22:06:21< Aginor> I've been thinking about starting to leave the channel when I'm not around
20161127 22:06:34< Aginor> instead of giving the impression that I may or may not be paying attention
20161127 22:06:44< vultraz> WHAT IN HELL IS GOING ON HERE.
20161127 22:06:51< vultraz> *some* alpha is working
20161127 22:06:56< vultraz> all colors are 4-challe
20161127 22:06:57< vultraz> channel
20161127 22:07:27< celticminstrel> What keys accept colours?
20161127 22:07:31< celticminstrel> "color="?
20161127 22:07:36< celticminstrel> Or something else?
20161127 22:07:38< vultraz> color
20161127 22:07:40< vultraz> border_color
20161127 22:07:42< vultraz> fill_color
20161127 22:07:58< celticminstrel> They all end in color, huh. Convenient.
20161127 22:08:26< celticminstrel> I see some {FONT_COLOR}.
20161127 22:08:30< vultraz> it's too early to deal with this shit
20161127 22:08:38 * vultraz goes to get coffee
20161127 22:08:41< celticminstrel> Huh, link_color=#fff00
20161127 22:08:45< celticminstrel> That can't be good.
20161127 22:08:53< celticminstrel> That's effectively an empty tag.
20161127 22:08:58< celticminstrel> Presumably not the intention at all.
20161127 22:09:10< celticminstrel> vultraz: Should link_color be a comma-separated list like all the others?
20161127 22:11:07< vultraz> yes
20161127 22:11:16< vultraz> probably
20161127 22:11:20< vultraz> that's an ugly link color anyway
20161127 22:11:35< celticminstrel> Well, I'm not gonna bother changing the colour.
20161127 22:11:55< vultraz> hmm
20161127 22:11:57< vultraz> ok
20161127 22:12:04< vultraz> some weird crap going on here
20161127 22:12:06< vultraz> at start
20161127 22:12:11< vultraz> if i remove the //return color_t(); stuff
20161127 22:12:21< vultraz> it says there's some color with the wrong number of components 
20161127 22:12:35< celticminstrel> Right, some colours are empty strings apparently.
20161127 22:12:40< vultraz> .....
20161127 22:12:42 * vultraz flips table
20161127 22:12:53< celticminstrel> Presumably that link_color is one of them.
20161127 22:12:56< vultraz> oh wait, do you mean *absent*, or color = ""
20161127 22:13:07< celticminstrel> Could be either, I guess.
20161127 22:13:21 * vultraz facedesks
20161127 22:14:32< celticminstrel> I assume you checked all the colour macros?
20161127 22:14:50< celticminstrel> I don't see any inline colours with missing alpha, although there's one place where the alpha is a macro argument.
20161127 22:16:22< celticminstrel> Hmm. I wonder how "4, 4, 4, "255"" would be parsed.
20161127 22:16:36< celticminstrel> I guess implicit + or something.
20161127 22:18:30< vultraz> there's an empty color somewhere
20161127 22:18:50< celticminstrel> Yes. data/gui/widget/label_default.cfg:28
20161127 22:19:13< vultraz> no
20161127 22:19:18< vultraz> that;s not it
20161127 22:19:22< celticminstrel> Yes it is.
20161127 22:19:35< celticminstrel> At least, that's definitely an empty colour.
20161127 22:19:40< celticminstrel> I don't guarantee it's the only one.
20161127 22:21:08< vultraz> restoring the implicit 0 behavior fixes all problems
20161127 22:22:02< celticminstrel> So something is definitely depending on that somewhere.
20161127 22:23:42< celticminstrel> Let's see if this change finds it...
20161127 22:27:57-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 22:27:58< travis-ci> wesnoth/wesnoth#12195 (master - f0f7022 : Charles Dang): The build was broken.
20161127 22:27:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179282336
20161127 22:27:58-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 22:28:19< celticminstrel> Seems like debug_border_color is a culprit.
20161127 22:28:39< celticminstrel> But I doubt that has anything to do with the display issue.
20161127 22:32:32< celticminstrel> It looks like there's nothing relying on implicit 0 alpha though.
20161127 22:33:12< celticminstrel> It also looks like the need for "" == white is because of defaults - if a colour parameter is missing, it's as if it was an empty string.
20161127 22:37:10-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161127 22:39:29< irker560> wesnoth: Celtic Minstrel wesnoth:master 8041a0964e7b / data/gui/widget/label_default.cfg: Fix missing GUI2 label link colour https://github.com/wesnoth/wesnoth/commit/8041a0964e7b6c7496019a0446e504ea6ed7fd8c
20161127 22:44:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 252 seconds]
20161127 22:59:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161127 23:05:56-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has joined #wesnoth-dev
20161127 23:05:57< travis-ci> wesnoth/wesnoth#12196 (master - ba28e8c : Charles Dang): The build was broken.
20161127 23:05:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179282607
20161127 23:05:57-!- travis-ci [~travis-ci@ec2-54-198-154-251.compute-1.amazonaws.com] has left #wesnoth-dev []
20161127 23:10:53< vultraz> BROKEN!
20161127 23:12:18< matthiaskrgr> man vs CI, the everlasting battle 
20161127 23:16:43< vultraz> tru dat
20161127 23:20:10< zookeeper> *epic battle music*
20161127 23:20:31< matthiaskrgr> :>
20161127 23:24:34< vultraz> zookeeper: https://www.youtube.com/watch?v=d2hRTLdvdnk
20161127 23:28:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20161127 23:30:57< matthiaskrgr> nice 
20161127 23:36:11< celticminstrel> Is that the latest build?
20161127 23:36:17< celticminstrel> Or is there another after that?
20161127 23:37:00-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20161127 23:38:16-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161127 23:39:03< matthiaskrgr> theres one build in progess
20161127 23:39:09< matthiaskrgr> https://travis-ci.org/wesnoth/wesnoth/builds/  
20161127 23:40:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:94be:5552:752f:4ef2] has joined #wesnoth-dev
20161127 23:49:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161127 23:50:42< vultraz> matthiaskrgr: nice as in the music?
20161127 23:50:52< matthiaskrgr> yeh
20161127 23:50:58< vultraz> indeed
20161127 23:51:04< vultraz> TSfH is the best
--- Log closed Mon Nov 28 00:00:11 2016