--- Log opened Wed Nov 30 00:00:58 2016
20161130 00:05:26-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20161130 00:06:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161130 00:07:43-!- louis94 [~~louis94@91.178.240.137] has quit [Quit: Konversation terminated!]
20161130 00:22:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161130 00:23:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 00:25:11-!- atarocch [~atarocch@host-78-65-187-129.homerun.telia.com] has quit [Quit: Leaving]
20161130 00:26:03< irker847> wesnoth: Charles Dang wesnoth:master d8d986d734c9 / src/ (19 files in 5 dirs): Cleaned up a bunch of unnecessary Boost includes https://github.com/wesnoth/wesnoth/commit/d8d986d734c92b99aec47aaa7027852de81b14a0
20161130 00:26:06< irker847> wesnoth: Charles Dang wesnoth:master f6c8e3ef183f / src/server/server.cpp: Fixup ab66dcd06d66 https://github.com/wesnoth/wesnoth/commit/f6c8e3ef183fd1de0982254a73abf3e8dee6732d
20161130 00:49:57-!- Appleman1234 [~Appleman1@KD106161212095.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20161130 00:51:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161130 00:59:06< irker847> wesnoth: Charles Dang wesnoth:master 9baabccf91e5 / src/ (23 files in 10 dirs): Use standard library includes instead of C includes when possible https://github.com/wesnoth/wesnoth/commit/9baabccf91e5ede7708c032c33bf08f3e3026994
20161130 00:59:09< irker847> wesnoth: Charles Dang wesnoth:master cea61b61ca61 / src/display.cpp: Removed a conditional include for Sun Studio https://github.com/wesnoth/wesnoth/commit/cea61b61ca61477a5bef36039d5c01d937b6eeb5
20161130 01:00:03-!- Appleman1234 [~Appleman1@KD106161205216.au-net.ne.jp] has joined #wesnoth-dev
20161130 01:03:05-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20161130 01:07:12< vultraz> celticminstrel: reference types can be forward-declared, right?
20161130 01:33:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161130 01:42:27-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 246 seconds]
20161130 01:43:56-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161130 01:48:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161130 01:48:37< celticminstrel> vultraz: What?
20161130 01:49:07< vultraz> if you have T& foo can you forward-delcare T.
20161130 01:49:53< vultraz> you said you cannot do so with T foo.
20161130 01:50:02< vultraz> But I thought you mentioned reference types.
20161130 01:52:38< celticminstrel> Forward-declared types are incomplete.
20161130 01:52:47< celticminstrel> Incomplete types can be used in reference declarations.
20161130 01:56:51< irker847> wesnoth: Charles Dang wesnoth:master 6465750cdf4f / src/ (6 files in 5 dirs): Avoid including team.hpp in diaplay.hpp https://github.com/wesnoth/wesnoth/commit/6465750cdf4f2d49b0c676a3945656d311b36d27
20161130 02:11:55-!- gfgtdf_ [~chatzilla@x4e369fde.dyn.telefonica.de] has joined #wesnoth-dev
20161130 02:14:00-!- gfgtdf [~chatzilla@x4e36a1fd.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161130 02:14:04-!- gfgtdf_ is now known as gfgtdf
20161130 02:20:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 02:24:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161130 02:24:50< vultraz> celticminstrel: how would i implement this with color_t? https://github.com/wesnoth/wesnoth/blob/master/src/display.hpp#L183
20161130 02:25:17< vultraz> not exactly sure what it's doing..
20161130 02:25:30< vultraz> giving the max channel value between two colors?
20161130 02:26:22< vultraz> (is that what plus_clipped does?)
20161130 02:28:15< celticminstrel> plus_clipped is addition, as the name should imply.
20161130 02:29:15< celticminstrel> What's max_rgb even for... o.O
20161130 02:29:26< vultraz> it's only used in one place
20161130 02:29:44< celticminstrel> BTW, tgb() clearly returns in ARGB format (or 0RGB wit no alpha channel).
20161130 02:29:54< celticminstrel> What place is it used?
20161130 02:30:36< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/units/frame.cpp#L948
20161130 02:31:52< celticminstrel> I don't even get what that's doing...
20161130 02:32:22< celticminstrel> Also, so much lack of space between things.
20161130 02:34:15< vultraz> yup
20161130 02:34:24< vultraz> so how do you recommend i handle this?
20161130 02:34:34< vultraz> straight-reimpl in color_t?
20161130 02:35:19< celticminstrel> I'm looking up stuff
20161130 02:35:46< vultraz> alright, im going to get lunch
20161130 02:36:42< celticminstrel> Okay, I think we can call it "color_t::blend_lighten". Apparently it's what image editing software tends to call "Lighten Only".
20161130 02:37:01< celticminstrel> And I think plus_clipped could be renamed to "blend_add" actually.
20161130 02:37:29< celticminstrel> Though "plus_clipped" does do a better job of conveying the fact that it maxes out at 255 rather than wrapping around.
20161130 03:26:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161130 03:28:03< vultraz> ah, I now have this lovely call :| 
20161130 03:28:05< vultraz> color_t::from_argb_bytes(engine_val.blend_with).blend_lighten(color_t::from_argb_bytes(result.blend_with)).to_argb_bytes()
20161130 03:34:48-!- Bonobo [~Bonobo@2001:44b8:254:3200:d97c:8a8e:acec:7d5b] has quit [Ping timeout: 258 seconds]
20161130 03:41:02< celticminstrel> Eventually the from_argb_bytes will be gone though.
20161130 03:44:02< celticminstrel> And it'll become engine_val.blend_lighten(result.blend_with).
20161130 03:44:02< vultraz> tru tru
20161130 03:50:31< celticminstrel> Just noticed I misspelled rgb() and with earlier... :/
20161130 03:54:29-!- gfgtdf [~chatzilla@x4e369fde.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.1/20161123182536]]
20161130 03:59:40-!- travis-ci [~travis-ci@ec2-54-226-26-23.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 03:59:41< travis-ci> wesnoth/wesnoth#12217 (master - a7daa12 : Charles Dang): The build has errored.
20161130 03:59:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179872722
20161130 03:59:42-!- travis-ci [~travis-ci@ec2-54-226-26-23.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 04:04:52< irker847> wesnoth: Charles Dang wesnoth:master 231effdb8559 / src/gui/dialogs/editor/custom_tod.hpp: GUI2/Custom ToD: include display.hpp directly instead of editor_display.hpp https://github.com/wesnoth/wesnoth/commit/231effdb8559e2e64bfd9657946047d9d2ca8e0a
20161130 04:04:55< irker847> wesnoth: Charles Dang wesnoth:master dfe091caffd3 / src/sdl/color.hpp: color_t: added blend_lighten function https://github.com/wesnoth/wesnoth/commit/dfe091caffd3b899bf9ee37475b6dcdde828cdbf
20161130 04:04:58< irker847> wesnoth: Charles Dang wesnoth:master a60433356def / src/ (6 files in 2 dirs): Refactored out display::rgb, red, blue, green, and blend_rgb https://github.com/wesnoth/wesnoth/commit/a60433356defdc0c5a2cbfd9ff0cbf13f393e39a
20161130 04:05:01< irker847> wesnoth: Charles Dang wesnoth:master e7ffd0df9637 / src/editor/palette/ (6 files): Avoid passing around display/editor_display references just for the CVideo gette https://github.com/wesnoth/wesnoth/commit/e7ffd0df9637bf42743a26cf4602279d2134a224
20161130 04:13:51< vultraz> ..\..\src\time_of_day.hpp|51|error: passing 'const color_t' as 'this' argument discards qualifiers [-fpermissive]|
20161130 04:13:53< vultraz> dammit...
20161130 04:13:55< vultraz> why :|
20161130 04:14:33< vultraz> for some reason I cannot compare two non-const color_t objects
20161130 04:14:35< vultraz> with ==
20161130 04:14:45-!- Shiki [~Shiki@141.39.226.226] has left #wesnoth-dev ["Verlassend"]
20161130 04:16:00< vultraz> celticminstrel: why is this?
20161130 04:17:18< vultraz> also, can someone cancel all the travis builds up until the current one
20161130 04:17:26< vultraz> it's so far behind
20161130 04:18:01< irker847> wesnoth: Celtic Minstrel wesnoth:CelticMinstrel-patch-1 9b1519d58d69 / src/sdl/color.hpp: const-correctness https://github.com/wesnoth/wesnoth/commit/9b1519d58d69527a09fb78c1db56158d368a661d
20161130 04:20:47< irker847> wesnoth: Celtic Minstrel wesnoth:CelticMinstrel-patch-1 c205ecd65c26 / src/sdl/color.cpp: const-correctness https://github.com/wesnoth/wesnoth/commit/c205ecd65c26d4f5655254479ac675e25d26bf3b
20161130 04:21:57< irker847> wesnoth: Celtic Minstrel wesnoth:master fa3c4682dbe8 / src/sdl/ (color.cpp color.hpp): color_t: Make the member functions const for const-correctness https://github.com/wesnoth/wesnoth/commit/fa3c4682dbe8bf5fa1ecf02a7dea09b06d251718
20161130 04:22:15< celticminstrel> vultraz: That should fix your problem.
20161130 04:24:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:f444:56db:dc6b:93c6] has joined #wesnoth-dev
20161130 04:25:25< vultraz> ah thanks
20161130 04:28:26 * celticminstrel probably should've let Travis pass the build first in case I missed one, but whatever. >_>
20161130 04:29:40-!- Bonobo [~Bonobo@2001:44b8:254:3200:f444:56db:dc6b:93c6] has quit [Ping timeout: 260 seconds]
20161130 04:29:57-!- Bonobo [~Bonobo@2001:44b8:254:3200:581b:1df4:4662:62e7] has joined #wesnoth-dev
20161130 04:42:28< irker847> wesnoth: Charles Dang wesnoth:master 9aff81a89cec / src/sdl/color.hpp: color_t: added an empty() function https://github.com/wesnoth/wesnoth/commit/9aff81a89ceccfb00b49b109f294257ce359f86f
20161130 04:42:31< irker847> wesnoth: Charles Dang wesnoth:master 0adeea43e0ee / src/ (6 files in 3 dirs): Replaced uses of the tod_color struct with color_t https://github.com/wesnoth/wesnoth/commit/0adeea43e0eec7356552ae91e9074f19edd3a3c7
20161130 04:42:34< irker847> wesnoth: Charles Dang wesnoth:master cd90652becc6 / src/gui/core/canvas.cpp: GUI2/Canvas: made use of color_t::empty https://github.com/wesnoth/wesnoth/commit/cd90652becc6f321be05fa482ac71a6cd79d2024
20161130 04:42:42< vultraz> for the record, plus_clipped is totally broken
20161130 04:42:55< vultraz> and as such, ToD colors are now totally broken
20161130 04:43:11< vultraz> though maybe it's because it considers alpha..
20161130 04:43:12< vultraz> hm..
20161130 04:43:29< vultraz> maybe I should add an alpha flag like in empty()...
20161130 04:43:34< vultraz> though I dunno if that's good design
20161130 04:43:45< vultraz> maybe i should have done empty_rgb and empty_rgba..
20161130 04:43:47< vultraz> not sur
20161130 04:43:49< vultraz> e
20161130 05:12:52-!- louis94 [~~louis94@91.178.240.137] has joined #wesnoth-dev
20161130 05:13:49< vultraz> gahh
20161130 05:16:04< vultraz> color.hpp has become the new utils.hpp :|
20161130 05:19:58-!- louis94 [~~louis94@91.178.240.137] has quit [Quit: Konversation terminated!]
20161130 05:41:06< celticminstrel> Don't call it empty() :(
20161130 05:41:22< celticminstrel> A colour can't be empty.
20161130 05:41:27< celticminstrel> It's not a thing that makes sense.
20161130 05:41:44< vultraz> what should I call it?
20161130 05:41:48< celticminstrel> 255 alpha is opaque, right?
20161130 05:41:57< vultraz> yes
20161130 05:42:06< celticminstrel> So it shouldn't matter that plus_clipped considers alpha.
20161130 05:42:12< vultraz> i think i found a fix for plus_clipped
20161130 05:42:32< celticminstrel> Weren't ToD colours using blend_lighten instead?
20161130 05:42:44< vultraz> no
20161130 05:42:49< vultraz> they were using operator+
20161130 05:42:50< celticminstrel> So what does empty() do?
20161130 05:43:04< vultraz> check if all channels are 0
20161130 05:43:10 * celticminstrel can't click the link because Firefox is in the middle of a long, possibly-infinite calculation.
20161130 05:43:18< celticminstrel> So, transparent()
20161130 05:43:24< vultraz> 	bool empty(const bool check_alpha = true) const
20161130 05:43:26< vultraz> 	{
20161130 05:43:27< vultraz> 		return r ==0 && g == 0 && b == 0 && (check_alpha ? a == 0 : true);
20161130 05:43:29< vultraz> 	}
20161130 05:43:34< celticminstrel> Though that really would only need to check the alpha channel.
20161130 05:43:39-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161130 05:43:41< celticminstrel> Or white() if you want to ignore the alpha.
20161130 05:43:51< celticminstrel> Maybe prepend is_
20161130 05:44:11< celticminstrel> Honestly it'd make more sense to do this completely differently.
20161130 05:44:24< vultraz> is_black and is_transparent?
20161130 05:44:30< celticminstrel> Declare static color_t::white and compare with ==
20161130 05:44:51< celticminstrel> For is_transparent I guess you could have a function, but why do you need that for c.a==0?
20161130 05:45:18< celticminstrel> I dunno, maybe a white already exists somewhere as a constant in the code.
20161130 05:45:40< vultraz> not really
20161130 05:53:37-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: End Transmission.]
20161130 05:55:18< vultraz> fucking fuck
20161130 05:55:24< vultraz> I can't get the tod colors to display right
20161130 05:55:27< vultraz> celticminstrel: can you look at them
20161130 05:58:49< irker847> wesnoth: Charles Dang wesnoth:master a8517a234d09 / src/ (6 files in 4 dirs): Made pango font rendering use color_t https://github.com/wesnoth/wesnoth/commit/a8517a234d09e4b8dfbf89bceae9ee6818d088b3
20161130 05:59:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 06:03:23< celticminstrel> operator*- wasn't used?
20161130 06:03:31< celticminstrel> In tod_color
20161130 06:03:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161130 06:03:37< vultraz> doesn't seem so
20161130 06:04:38< celticminstrel> Hmm, tod_color::operator+ wasn't clipping...
20161130 06:04:52< celticminstrel> Not sure if that's relevant though, because it could've easily clipped somewhere else...
20161130 06:05:09< celticminstrel> Presumably tod_color was translated to some other format at some point...
20161130 06:05:36< celticminstrel> image::set_color_adjustment...
20161130 06:08:09< celticminstrel> So it's clipped in adjust_surface_color.
20161130 06:08:38< celticminstrel> With std::min<int>, so no overflow would be happening to cause problems like with your std::min<uint8_t>.
20161130 06:10:11< celticminstrel> So what exactly is wrong with them anyway?
20161130 06:10:48< vultraz> lanch a game
20161130 06:10:50< vultraz> launch
20161130 06:10:58< celticminstrel> Oh wait.
20161130 06:11:50< celticminstrel> Okay, so the problem is actually quite simple.
20161130 06:11:57< celticminstrel> tod_color did not represent a colour.
20161130 06:12:19< celticminstrel> It represented a colour delta.
20161130 06:13:11< celticminstrel> Hmmm.
20161130 06:13:47< celticminstrel> I'm just wondering if there are any options besides reverting the commit.
20161130 06:14:00< vultraz> certainly do not do that
20161130 06:14:23< celticminstrel> I'll certainly do it if I don't see any other way.
20161130 06:15:07< vultraz> reimplement it somehow?
20161130 06:15:33< celticminstrel> color_t is simply unsuited to this task.
20161130 06:15:39< celticminstrel> Because it's unsigned.
20161130 06:15:53< vultraz> I see
20161130 06:15:57< celticminstrel> I don't really want to add a separate color_delta class though.
20161130 06:20:50< vultraz> well whatever you do please hold off awhile 
20161130 06:20:53< vultraz> I have a big change coming
20161130 06:21:02< vultraz> but it'll take awhile
20161130 06:23:37< vultraz> gahhh
20161130 06:23:40< vultraz> what does this error mean
20161130 06:23:45< vultraz> ..\..\src\map\label.hpp|57|error: no matching function for call to 'color_t::color_t(const color_t&)'|
20161130 06:23:55< vultraz>  const color_t color = font::NORMAL_COLOR,
20161130 06:23:59< vultraz> how is this a problem :/
20161130 06:24:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161130 06:26:01< vultraz> what's the issue :/
20161130 06:26:40< vultraz> assignment operators are implicit are they not
20161130 06:27:08< vultraz> or why is it treating this like a ctor call
20161130 06:27:54< celticminstrel> What's font::NORMAL_COLOR?
20161130 06:28:17< celticminstrel> Also, following that error should be notes about "no conversion to" or similar.
20161130 06:28:18< vultraz> ohhh
20161130 06:28:22< vultraz> wait
20161130 06:28:24< vultraz> i see my error
20161130 06:28:43< vultraz> over-zealous find/replace
20161130 06:59:47< irker847> wesnoth: Charles Dang wesnoth:master 4b3862493fb6 / src/ (63 files in 17 dirs): Convert all usecases of SDL_Color to color_t https://github.com/wesnoth/wesnoth/commit/4b3862493fb6d74717908796882b860bea6f757a
20161130 06:59:49< vultraz> celticminstrel: ok, you can proceed
20161130 07:00:07< celticminstrel> Might wait until tomorrow.
20161130 07:00:52< vultraz> oh, and
20161130 07:00:54< vultraz> Aginor: ^
20161130 07:37:43-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20161130 07:38:35-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 260 seconds]
20161130 07:39:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161130 07:45:09-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me]
20161130 07:45:46-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20161130 07:55:50-!- JyrkiVesterinen [~JyrkiVest@87-100-208-208.bb.dnainternet.fi] has joined #wesnoth-dev
20161130 08:03:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161130 08:03:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161130 08:31:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161130 09:14:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161130 09:18:12-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161130 09:32:08-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161130 09:50:50-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 09:50:52< travis-ci> wesnoth/wesnoth#12227 (master - 6465750 : Charles Dang): The build was broken.
20161130 09:50:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179966560
20161130 09:50:52-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 10:03:46-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 256 seconds]
20161130 10:06:26< Aginor> vultraz: good job
20161130 10:16:17-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161130 10:16:37-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: Connection reset by peer]
20161130 10:18:11-!- Ivanovic_ is now known as Ivanovic
20161130 10:19:22-!- Elsi [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 258 seconds]
20161130 10:19:38-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 258 seconds]
20161130 10:19:40-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has quit [Ping timeout: 258 seconds]
20161130 10:20:29-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20161130 10:20:47-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20161130 10:21:31-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161130 10:22:15-!- loonycyborg_ [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20161130 10:22:24-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev
20161130 10:24:41-!- Elvish_H1 [~elvish_hu@baldras.wesnoth.org] has joined #wesnoth-dev
20161130 10:25:44-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 258 seconds]
20161130 10:25:44-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Ping timeout: 258 seconds]
20161130 10:25:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:581b:1df4:4662:62e7] has quit [Ping timeout: 258 seconds]
20161130 10:25:44-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has quit [Ping timeout: 258 seconds]
20161130 10:25:45-!- loonycyborg_ is now known as loonycyborg
20161130 10:26:24-!- Bonobo [~Bonobo@2001:44b8:254:3200:581b:1df4:4662:62e7] has joined #wesnoth-dev
20161130 10:28:59< Soliton> vultraz: any reason you removed the use of boost::noncopyable?
20161130 10:32:14-!- JyrkiVesterinen [~JyrkiVest@87-100-208-208.bb.dnainternet.fi] has quit [Quit: .]
20161130 10:43:56< midzer> is it possible to build wesnoth master with debian testing? i stumbled upon missing dependencies yesterday, like some boost sub libraries, which are currently not available for debian stretch
20161130 10:48:39< Soliton> not available? what parts?
20161130 10:50:38< midzer> cannot look it up now, will check for it later
20161130 10:59:24-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 10:59:25< travis-ci> wesnoth/wesnoth#12228 (master - e7ffd0d : Charles Dang): The build failed.
20161130 10:59:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179982426
20161130 10:59:25-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 11:16:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161130 11:19:56< DeFender1031> well... that doesn't bode well for me...
20161130 11:36:45-!- irker847 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161130 12:01:58-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 12:01:59< travis-ci> wesnoth/wesnoth#12229 (master - fa3c468 : Celtic Minstrel): The build failed.
20161130 12:02:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179984447
20161130 12:02:00-!- travis-ci [~travis-ci@ec2-23-20-38-33.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 12:31:43-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20161130 12:37:27-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161130 12:44:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161130 12:46:24-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 256 seconds]
20161130 12:50:59-!- JyrkiVesterinen [~JyrkiVest@87-100-208-208.bb.dnainternet.fi] has joined #wesnoth-dev
20161130 12:53:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161130 12:53:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20161130 12:56:02-!- travis-ci [~travis-ci@ec2-54-158-21-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 12:56:03< travis-ci> wesnoth/wesnoth#12230 (master - cd90652 : Charles Dang): The build failed.
20161130 12:56:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/179986497
20161130 12:56:03-!- travis-ci [~travis-ci@ec2-54-158-21-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 13:21:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161130 13:51:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161130 13:51:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 13:57:44-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161130 14:05:13-!- stikonas_ is now known as stikonas
20161130 14:12:58< JyrkiVesterinen> Because AppVeyor doesn't react to commits for some reason, I set it to make builds on schedule now.
20161130 14:13:39< JyrkiVesterinen> It's now set to make a VS2013 build on 0:51, 8:51 and 16:51 UTC, and VS2015 build on 0:09, 8:09 and 16:09 UTC.
20161130 14:15:09-!- irker102 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161130 14:15:09< irker102> wesnoth: Gregory A Lundberg wesnoth:master 72e39953a16a / .appveyor.vs2013.yml .appveyor.vs2015.yml: Adjust AppVeyor configurations https://github.com/wesnoth/wesnoth/commit/72e39953a16a84369cf1eab2355436597a2d95d5
20161130 14:15:09< irker102> wesnoth: Jyrki Vesterinen wesnoth:master cb9ec9b22529 / .appveyor.vs2013.yml .appveyor.vs2015.yml: Merge pull request #886 from GregoryLundberg/GL_appveyor https://github.com/wesnoth/wesnoth/commit/cb9ec9b2252927c0af766d078da2e76542f4ee08
20161130 14:16:21< vultraz> Soliton: it was either the boost method or the standard method. both we've used, so I figure might as well stick with standard.
20161130 14:19:51-!- Bonobo [~Bonobo@2001:44b8:254:3200:581b:1df4:4662:62e7] has quit [Ping timeout: 246 seconds]
20161130 14:20:42< JyrkiVesterinen> 20161130 10:43:56< midzer> is it possible to build wesnoth master with debian testing? i stumbled upon missing dependencies yesterday, like some boost sub libraries, which are currently not available for debian stretch
20161130 14:21:08< JyrkiVesterinen> I built Wesnoth on siduction, which is baed on Debian Sid, last week without any trouble.
20161130 14:21:28< JyrkiVesterinen> AFAIK, Sid and Stretch are almost identical at the moment.
20161130 14:57:53-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161130 15:02:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161130 15:02:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161130 15:05:16< vultraz> god dammit
20161130 15:05:25< vultraz> cannot get to_hex_string working properly :\
20161130 15:05:54< DeFender1031> vultraz, what's being converted to a hex string?
20161130 15:05:59< DeFender1031> a color?
20161130 15:06:03< vultraz> er, wait
20161130 15:06:05< vultraz> from_hex_string
20161130 15:06:07< vultraz> not to_hex_string
20161130 15:06:30< DeFender1031> oka, then same question, same word replacement.
20161130 15:06:56< vultraz> yes, this function is supposed to convert a hex color string like FFFFFF to 255,255,255
20161130 15:07:26< vultraz> (internally, that is. each component is stored separately as uint8_t)
20161130 15:08:37< DeFender1031> right
20161130 15:08:40< DeFender1031> obviously
20161130 15:08:49< DeFender1031> it should be a simple enough algorithm
20161130 15:09:02< vultraz> yes... maybe there's something else wrong with my change here
20161130 15:10:17< vultraz> hmmm
20161130 15:10:22< vultraz> maybe the code is correct..
20161130 15:11:36< vultraz> hmmmm
20161130 15:11:44< vultraz> yes, actually, it seems it was working
20161130 15:11:48< vultraz> so what's going on here..
20161130 15:19:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20161130 15:19:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 15:37:54-!- astrelyon [~astrelyon@dh207-111-195.xnet.hr] has joined #wesnoth-dev
20161130 15:58:50-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161130 16:00:11-!- JyrkiVesterinen [~JyrkiVest@87-100-208-208.bb.dnainternet.fi] has quit [Quit: .]
20161130 16:01:34-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161130 16:03:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161130 16:06:41-!- travis-ci [~travis-ci@ec2-54-158-21-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 16:06:42< travis-ci> wesnoth/wesnoth#12232 (master - 4b38624 : Charles Dang): The build passed.
20161130 16:06:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180003074
20161130 16:06:42-!- travis-ci [~travis-ci@ec2-54-158-21-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 16:34:32-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161130 16:37:05< irker102> wesnoth: Celtic Minstrel wesnoth:master d0bb55159d60 / src/ (5 files in 2 dirs): Restore tod_color struct https://github.com/wesnoth/wesnoth/commit/d0bb55159d605bc4016ca8faa20a81407e23e1f0
20161130 16:37:07< irker102> wesnoth: Celtic Minstrel wesnoth:master f62240bcbdd4 / src/sdl/color.hpp: Fix MSVC build https://github.com/wesnoth/wesnoth/commit/f62240bcbdd4083ba52f38d8903dfd765ea47002
20161130 16:37:09< irker102> wesnoth: Celtic Minstrel wesnoth:master b61f8411b69f / src/ (gui/core/canvas.cpp sdl/color.hpp): color_t: Rename empty() to something more appropriate https://github.com/wesnoth/wesnoth/commit/b61f8411b69f856817d012839d6f3a0b1dc4819a
20161130 16:37:11< irker102> wesnoth: Celtic Minstrel wesnoth:master c77faf2223b5 / src/time_of_day.hpp: tod_color: Reformat and enforce max range https://github.com/wesnoth/wesnoth/commit/c77faf2223b535badbe56fdd30bc404e283e7c29
20161130 16:40:06< celticminstrel> 'Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.'
20161130 16:40:16< celticminstrel> Is that supported on AppVeyor, I wonder.
20161130 16:42:04< celticminstrel> The error on AppVeyor should be fixed by f62240, it seems.
20161130 16:43:29< celticminstrel> That also seems to be the first actual AppVeyor build, huh.
20161130 16:47:52-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161130 16:52:58-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 245 seconds]
20161130 16:58:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161130 16:58:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 16:59:08-!- JyrkiVesterinen [~JyrkiVest@87-92-26-223.bb.dnainternet.fi] has joined #wesnoth-dev
20161130 16:59:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161130 17:02:56< JyrkiVesterinen> I don't know if we should enable parallel builds in AppVeyor even if we can.
20161130 17:03:19< JyrkiVesterinen> I believe it would be more efficient for their servers to build multiple projects at the same time, one core for each.
20161130 17:05:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 17:06:26-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 17:07:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 17:09:18< irker102> wesnoth: Jyrki Vesterinen wesnoth:master 5ff4945b2649 / .appveyor.vs2013.yml utils/appveyor/irc-notify.py: Experimental: send an IRC notification when an AppVeyor build finishes https://github.com/wesnoth/wesnoth/commit/5ff4945b2649fa232992fb2586be931ac9c298ae
20161130 17:09:20< irker102> wesnoth: Jyrki Vesterinen wesnoth:master 860e03c697bf / .appveyor.vs2013.yml utils/appveyor/irc-notify.py: Merge branch 'appveyor-irc-notification' https://github.com/wesnoth/wesnoth/commit/860e03c697bf73a2628f18e663b6e6f4b4528547
20161130 17:09:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161130 17:09:41-!- wedge010 is now known as wedge009
20161130 17:15:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161130 17:15:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 17:20:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161130 17:22:03-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Changing host]
20161130 17:22:03-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20161130 17:24:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 17:31:18-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 246 seconds]
20161130 17:36:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161130 17:43:36-!- gfgtdf [~chatzilla@x4e369fde.dyn.telefonica.de] has joined #wesnoth-dev
20161130 17:54:48< zookeeper> gfgtdf, celticminstrel, any further comments on https://github.com/wesnoth/wesnoth/pull/876 ?
20161130 17:55:33< zookeeper> (or anyone else, naturally)
20161130 17:55:44< celticminstrel> I have no further comments.
20161130 17:59:07-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Ping timeout: 268 seconds]
20161130 18:10:06-!- atarocch [~atarocch@host-78-65-187-41.homerun.telia.com] has joined #wesnoth-dev
20161130 18:12:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161130 18:15:39< midzer> JyrkiVesterinen: i figured out that my IDE used cached results for those dependencies. scons --config=force rechecks everything on build
20161130 18:22:42-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20161130 18:24:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161130 18:25:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20161130 18:27:11-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161130 18:36:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161130 18:37:14-!- zookeeper_ is now known as zookeeper
20161130 18:37:16-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20161130 18:37:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161130 18:39:40-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20161130 18:42:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 245 seconds]
20161130 18:42:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161130 18:46:00-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Read error: No route to host]
20161130 18:46:07-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161130 18:46:14-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Changing host]
20161130 18:46:15-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20161130 18:47:43< zookeeper> celticminstrel, mmkay. i'm thinking that maybe i should still add the "check that NAME in NAME=VALUE is actually a recognized optional argument" thing. partly to allow a meaningful error message in that case (because it most likely indicates a mistake), and partly as pre-emptive future-proofing in case we want to allow the syntax for required arguments too.
20161130 18:48:15-!- Ivanovic_ is now known as Ivanovic
20161130 18:48:29< zookeeper> i'm not sure, really.
20161130 18:51:35-!- prkc [~prkc@46.166.138.148] has joined #wesnoth-dev
20161130 18:57:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161130 18:58:47< celticminstrel> That sounds like a good idea.
20161130 19:01:59< zookeeper> i'm also wondering whether the #arg/#endarg syntax is a bit clumsy. not that i have better ideas which wouldn't be something like {?NAME VALUE} which i think wouldn't be good because it looks exactly like macro substitution.
20161130 19:02:27< celticminstrel> And technically I'd bet ?NAME is a valid macro name already.
20161130 19:02:52< celticminstrel> I'm not entirely satisfied with argendarg either, TBH, but I can't think of anything better.
20161130 19:02:55< celticminstrel> ^/
20161130 19:14:41< gfgtdf> i don't have an opinion on that patch currently.
20161130 19:15:27< gfgtdf> i think the proprocessor.cpp code is quire messy and coudl be improved but thats not your fault.
20161130 19:18:22< zookeeper> it did take me a ghastly amount of time to figure out what i ought to be putting where, but then again i've never worked with any preprocessor code before so maybe they're all like that.
20161130 19:28:45< gfgtdf> zookeeper: do you know where in the wiki i cna find the predefined macros?
20161130 19:29:01< zookeeper> core macros?
20161130 19:29:53< gfgtdf> zookeeper: no, things like WESNOTH_VERSION, APPLE or DEBUG_MODE
20161130 19:30:20< zookeeper> https://wiki.wesnoth.org/PreprocessorRef#Built-in_macros
20161130 19:31:56< gfgtdf> zookeeper: thx, {CURRENT_DIRECTORY} is still missing on that list it seems. will add it
20161130 19:34:03< celticminstrel> There's probably some way to grep the source for them.
20161130 19:35:34< gfgtdf> zookeeper: you know why codes like https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/An_Orcish_Incursion/_main.cfg#L79 write {campaigns/An_Orcish_Incursion/scenarios} instead of something like {./scenarios} ?
20161130 19:36:09< zookeeper> probably no particular reason, i'd think
20161130 19:38:36< zookeeper> of course that makes it irrelevant where exactly the _main.cfg itself is being read from, but... i don't know if there's any practical benefit to anyone ever
20161130 19:46:09< gfgtdf> hmm i jus looked at the code and it sems we dont even support thing like for example {./../macors} (going uo the directoy)
20161130 19:48:26< zookeeper> might have been related to some security issues
20161130 19:49:09< gfgtdf> zookeeper: hmm yes, but it is possible to implement in in a safe way.
20161130 19:50:59< celticminstrel> I thought you already did that?
20161130 19:51:16< celticminstrel> Adding support for .. up to the base directory.
20161130 19:52:19< gfgtdf> celticminstrel: hmm yes but that was only for lua functions (require/dofile/read/havefile) and didnt erffect th prorpcessor code
20161130 19:52:36< celticminstrel> I thought they used the same code.
20161130 19:55:25< gfgtdf> celticminstrel: hmm only partly, they both use get_wml_location but the .. expansion was impemented in top of that, mostly to make sure not to break the get_wml_location securitly check
20161130 20:05:04-!- travis-ci [~travis-ci@ec2-54-196-173-111.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 20:05:05< travis-ci> wesnoth/wesnoth#12234 (master - c77faf2 : Celtic Minstrel): The build has errored.
20161130 20:05:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180137593
20161130 20:05:05-!- travis-ci [~travis-ci@ec2-54-196-173-111.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 20:06:58-!- JyrkiVesterinen [~JyrkiVest@87-92-26-223.bb.dnainternet.fi] has quit [Quit: .]
20161130 20:09:31-!- irker102 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161130 20:13:51< zookeeper> tooltips are broken, it seems
20161130 20:14:30< vultraz> what do you mean
20161130 20:15:36< gfgtdf> vultraz: are you still wroking on color_t ?
20161130 20:15:45< vultraz> no im working on game_config
20161130 20:16:30< gfgtdf> vultraz: but there are still many cases that use uint32 as color types that should be converted.
20161130 20:16:37< vultraz> yes
20161130 20:16:40< vultraz> I'm working on it
20161130 20:16:45< gfgtdf> ok
20161130 20:25:02-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161130 20:28:50< zookeeper> vultraz, i mean i just see the transparent black boxes, no text
20161130 20:28:59< vultraz> fuck
20161130 20:31:10-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161130 20:42:41-!- mjs-de [~mjs-de@x4e312e3b.dyn.telefonica.de] has joined #wesnoth-dev
20161130 20:48:39< celticminstrel> vultraz: What about game_config?
20161130 20:48:52< vultraz> I'm working on red_to_green
20161130 20:48:56< vultraz> and blue_to_white
20161130 20:49:00< vultraz> but the colors are all wrontg
20161130 20:49:01< vultraz> wrong
20161130 20:49:10< vultraz> despite them being correct in the vetor
20161130 20:49:18< vultraz> generated via from_hex_string
20161130 20:49:34< celticminstrel> Okay so are you saying that from_hex_string is wrong?
20161130 20:50:09< celticminstrel> When you say they're correct in the vector, do you mean the vector of strings split from the WML attribute value?
20161130 20:50:21< vultraz> yes
20161130 20:50:30< celticminstrel> Is that yes to both?
20161130 20:50:34< vultraz> the resulting colors generated via from_hex_string are correct
20161130 20:50:41< vultraz> but when they're used, they're incorrect :/
20161130 20:50:50< celticminstrel> So where are they used?
20161130 20:51:08< celticminstrel> Are you converting to rgba where you should use argb or vice versa?
20161130 20:51:25< celticminstrel> How are they incorrect?
20161130 20:51:28< vultraz> I don't know
20161130 20:51:38< vultraz> they're incorrect because 60% is bright green
20161130 20:51:44< vultraz> er wait no
20161130 20:51:45< vultraz> rd
20161130 20:51:49< vultraz> 20 is yellow
20161130 20:51:56< vultraz> 50 is green
20161130 20:52:06< vultraz> but I didn't touch the function that fetches the colors
20161130 20:52:09< vultraz> or the list of colors
20161130 20:52:13< vultraz> and the colors are correct :|
20161130 20:52:20-!- travis-ci [~travis-ci@ec2-54-196-173-111.compute-1.amazonaws.com] has joined #wesnoth-dev
20161130 20:52:21< travis-ci> wesnoth/wesnoth#12233 (master - cb9ec9b : Jyrki Vesterinen): The build was fixed.
20161130 20:52:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180094887
20161130 20:52:22-!- travis-ci [~travis-ci@ec2-54-196-173-111.compute-1.amazonaws.com] has left #wesnoth-dev []
20161130 20:54:42< vultraz> er...
20161130 20:55:13< vultraz> yeah, i dunno
20161130 20:55:25< vultraz> I'm just gonna commit what I have
20161130 20:56:10< celticminstrel> Looks like 50% should be yellow?
20161130 20:56:31< celticminstrel> Are these used for HP bars or terrain defense or what else?
20161130 20:56:35-!- irker095 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161130 20:56:35< irker095> wesnoth: Charles Dang wesnoth:master 3e0797d3a6c2 / src/ (5 files in 2 dirs): Initial refactor of game_config::red_to_green and blue_to_white to use color_t https://github.com/wesnoth/wesnoth/commit/3e0797d3a6c23555b5a7e06c0803173484e3ac46
20161130 20:56:45< vultraz> in the attack dialog
20161130 21:01:53< vultraz> I can't see anything obviously wrong 
20161130 21:02:39< celticminstrel> Why are you using transparent fallback colours?
20161130 21:02:48-!- prkc [~prkc@46.166.138.148] has quit [Ping timeout: 256 seconds]
20161130 21:03:02< celticminstrel> (Lines 298-301)
20161130 21:03:52< vultraz> oh, since the original ones had 0x00
20161130 21:04:21< celticminstrel> They were probably intended as 0RGB rather than ARGB (ie, no alpha channel, all colours are opaque).
20161130 21:04:39< celticminstrel> That's not gonna be related to the issue here though...
20161130 21:04:59< irker095> wesnoth: Charles Dang wesnoth:master fc15712845c4 / src/font/standard_colors.cpp: Don't set up standard colors with transparent alpha https://github.com/wesnoth/wesnoth/commit/fc15712845c4a74df60ad2f356059edbbd4c25f8
20161130 21:05:02< vultraz> zookeeper: ^ fixed
20161130 21:05:13< vultraz> (the tooltips, that is)
20161130 21:05:19< celticminstrel> Where's string2rgb implemented?
20161130 21:05:32< vultraz> color_range.*pp
20161130 21:05:43< vultraz> we need to phase that function out
20161130 21:05:48< celticminstrel> vultraz: You shouldn't really be specifying SDL_ALPHA_OPAQUE.
20161130 21:05:51-!- Appleman1234 [~Appleman1@KD106161205216.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20161130 21:05:56< celticminstrel> Just leave out the alpha and it should default to that.
20161130 21:06:17< vultraz> ah, true
20161130 21:06:36< celticminstrel> And do that for the fallbacks in game_config too.
20161130 21:10:17< irker095> wesnoth: Charles Dang wesnoth:master 3d7f14355414 / src/ (font/standard_colors.cpp game_config.cpp): Forgot I don't need to specify alpha (default is opaque) https://github.com/wesnoth/wesnoth/commit/3d7f1435541420a0b16a201566e9f387dc26a45c
20161130 21:11:40< celticminstrel> Okay, so just to be clear, there were no problems with red_to_green before you redid it to use color_t?
20161130 21:13:14< celticminstrel> I notice you actually changed the fallback colors - red_to_green from yellow to white, and blue_to_white from white to blue. Probably doesn't matter too much since you're not supposed to see them though...
20161130 21:13:58< vultraz> i don't think there were any issues, no
20161130 21:14:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161130 21:14:22< vultraz> also, I think I meant the former fallback to be read
20161130 21:14:23< vultraz> :/
20161130 21:15:19< celticminstrel> So it's used in draw_text_in_hex...
20161130 21:15:43< vultraz> remind me to make use of constexpr in game_config
20161130 21:15:46< celticminstrel> I think that's the defencse rating.
20161130 21:15:55< celticminstrel> Does it look wrong for defense rating?
20161130 21:16:07< vultraz> yes
20161130 21:16:18< vultraz> and cth chance in the attack dialog
20161130 21:16:24< celticminstrel> I probably won't remind you, because as someone (possibly iceiceice?) pointed out, we can't really use constexpr as long as we support MSVC 2013 (even though I added that macro).
20161130 21:16:43< vultraz> yes, that's why I wan to drop 2013
20161130 21:16:53< vultraz> but we can't until zoo keeper upgrades
20161130 21:17:11< celticminstrel> Three major devs use it.
20161130 21:17:32< celticminstrel> So dropping it seems like a poor plan to me.
20161130 21:17:38< vultraz> jyrki uses both 2013 and 2015. A change wouldn't affect him.
20161130 21:17:51< vultraz> who's the third?
20161130 21:17:53< celticminstrel> Me.
20161130 21:18:04< vultraz> I thought you also had 2015...
20161130 21:18:07< celticminstrel> I don't.
20161130 21:18:12< vultraz> or maybe i was thinking of jyrki
20161130 21:18:18< celticminstrel> I imagine I could probably obtain it if I really had to.
20161130 21:18:28< celticminstrel> But I have MSVC 2013 Ultimate.
20161130 21:18:42< celticminstrel> I imagine 2015 Express would be something of a downgrade in some ways.
20161130 21:19:00< vultraz> well, MSVC 2017 will be out soon
20161130 21:19:16< vultraz> so you might want to look into upgrading regardless.
20161130 21:19:31< vultraz> once that happens
20161130 21:19:39< celticminstrel> I dunno.
20161130 21:19:59< celticminstrel> I also never bothered to install Windows 10. No idea if that's relevant.
20161130 21:20:12< vultraz> :o
20161130 21:20:51< celticminstrel> I suppose in a worst-case scenario I could always switch to developing Wesnoth on Fedora, but I'd prefer not to have to do that, because that would make it a pain to switch between dev mode and gaming mode.
20161130 21:21:09< celticminstrel> (Sure there's Steam for Linux, but most games don't support it.)
20161130 21:21:12< gfgtdf> i thought you use mac?
20161130 21:21:21< celticminstrel> I do mostly.
20161130 21:21:58< celticminstrel> My IRC is all on Mac.
20161130 21:22:13< celticminstrel> (Except on the rare occasions I connect via the webchat.)
20161130 21:22:33< celticminstrel> All my stuff is on the Mac really. Documents, projects, etc.
20161130 21:23:18< vultraz> again, wesnoth inc could purchase a new mac to enable you to continue developing on mac os (which is very important right now).
20161130 21:23:57< celticminstrel> I can still develop in MacOS. It's a bit of a pain, but it's possible.
20161130 21:24:19< celticminstrel> Even if you had to drop clang 3.2 support, I can continue to compile with scons.
20161130 21:24:29< vultraz> your mac is ancient :|
20161130 21:24:35< celticminstrel> (I don't even know if clang 3.2 is officially supported though.)
20161130 21:24:46< celticminstrel> It's just over ten years old.
20161130 21:24:57< celticminstrel> I got it in 2006, probably around August or September.
20161130 21:24:58< vultraz> yes
20161130 21:25:01< vultraz> ancient
20161130 21:25:14< celticminstrel> My scons build uses clang 3.8.
20161130 21:25:50< celticminstrel> It seems to have ABI compatibility issues or something, though. I can't really run it in the debugger very well.
20161130 21:25:59< celticminstrel> And sometimes it can't catch exceptions that have catch clauses.
20161130 21:26:12< vultraz> I cannot imagine that it builds very quickly
20161130 21:26:18< celticminstrel> It's pretty slow, yeah.
20161130 21:26:39< celticminstrel> But it's not as bad as the XCode build which locks up Firefox and makes my computer largely unusable.
20161130 21:26:42< vultraz> not good for our sole main mac os developer
20161130 21:27:57< celticminstrel> Since it's a Mac Pro I might even be able to improve the situation quite a bit by installing more RAM. The only question is whether it's worth purchasing RAM for a computer that's near-EOL anyway.
20161130 21:28:10< vultraz> likely not
20161130 21:28:18< celticminstrel> If the RAM is cheap, it could be.
20161130 21:28:51 * celticminstrel hasn't investigated or anything.
20161130 21:32:00< celticminstrel> Honestly, I haven't had that many problems with this computer anyway. Apart from compiling Wesnoth, it seems to still be quite sufficient for most of my needs.
20161130 21:32:42< celticminstrel> Well okay, I should add gaming to the exceptions list too, but then, that was one of the main reasons for getting the Windows computer.
20161130 21:36:23< celticminstrel> Anyway, I can't see any reason why the colours would be wrong now...
20161130 21:36:31< celticminstrel> Maybe someone else can shed some light on it.
20161130 21:42:33-!- mjs-de [~mjs-de@x4e312e3b.dyn.telefonica.de] has quit [Remote host closed the connection]
20161130 21:49:03< loonycyborg> celticminstrel: What kind of ram your current pc uses? DDR4? 
20161130 21:49:27< celticminstrel> That sounds familiar, so it's probably correct or nearly correct.
20161130 21:49:58< celticminstrel> I currently have 5GB (2x 500MB and 2x 2GB) and I think there are four more open slots.
20161130 21:50:35< loonycyborg> according to wikipedia this std won't be replaced soon
20161130 21:50:40< celticminstrel> Firefox eats about half of that all by itself. XCode also takes a lot.
20161130 21:50:51< loonycyborg> so you could reuse it even if you later replace entire pc :P
20161130 21:51:30< celticminstrel> Hmm, maybe it's not that...
20161130 21:51:55< celticminstrel> Manual says 667MHz FB-DIMMs
20161130 21:52:10< zookeeper> i was just about to say that i'm pretty darn sure it's not DDR4 :P
20161130 21:52:13< celticminstrel> Whatever that means.
20161130 21:52:19< celticminstrel> :P
20161130 21:52:49< celticminstrel> The manual implies thet 2GB is the maximum size it can take.
20161130 21:52:53< celticminstrel> (Per card)
20161130 21:53:46< celticminstrel> Which in turn implies 16GB is the absolute max total RAM.
20161130 21:54:21< zookeeper> if it's 667mhz then surely it has to be DDR2, in which case you're limited to 8GB anyway
20161130 21:54:28< celticminstrel> ???
20161130 21:54:48< zookeeper> or at least that's how i recall it
20161130 21:55:03< celticminstrel> 8GB total or per card?
20161130 21:55:06< loonycyborg> I didn't even know that FB DIMM exists :P
20161130 21:55:07< zookeeper> total
20161130 21:55:12< zookeeper> what card are you even talking about?
20161130 21:55:18< celticminstrel> The memory card?
20161130 21:55:25< zookeeper> memory comes on cards? :P
20161130 21:55:27< loonycyborg> I thought macs already using stock pc hardware for like forever :P
20161130 21:55:29< celticminstrel> Yes?
20161130 21:55:33< zookeeper> oh, stick?
20161130 21:55:39< celticminstrel> No, the RAM card.
20161130 21:55:49< celticminstrel> That goes inside the computer.
20161130 21:56:02< celticminstrel> Why would it have 8 slots if it couldn't support them all being maxed?
20161130 21:57:04< zookeeper> maybe it supports more than one type of memory
20161130 21:57:10< zookeeper> 4 slots for one type, 4 for another
20161130 21:57:13< celticminstrel> It does sound like it's DDR2.
20161130 21:57:37< celticminstrel> They need to be installed in equal-size pairs.
20161130 21:59:01< loonycyborg> does it require that only one kind is used at the same time?
20161130 21:59:09< celticminstrel> ?
20161130 21:59:10< vultraz> DDR4 didn't even exist in 2006
20161130 21:59:13< zookeeper> surely all mobos have that requirement
20161130 21:59:17< vultraz> most likely you have DDR2
20161130 21:59:24< celticminstrel> We just established that, yes, vultraz 
20161130 22:00:08< celticminstrel> I'm pretty sure the RAM isn't on a motherboard.
20161130 22:00:23< celticminstrel> There's a board that slides out containing just the RAM slots.
20161130 22:01:04< zookeeper> weird. but then again i'm not exactly a hardware expert.
20161130 22:01:18< loonycyborg> anyway, chances are that any new pc you buy won't have DDR2 even
20161130 22:01:37< loonycyborg> iso buying it may indeed be a waste
20161130 22:01:51< celticminstrel> Depending on the cost, yeah.
20161130 22:01:54< zookeeper> yeah, and unless someone just sells you a dirt cheap DDR2 4x2gb kit or something, it seems pointless to try to upgrade that kind of system
20161130 22:02:29< aeth> Anything older than 2009 is overdue for a replacement imo.
20161130 22:03:03< aeth> You could say something even more recent than 2009, but 2009ish seems to be a bare minimum for quite a few things.
20161130 22:03:43< aeth> In fact, I think USB 3 is on 2010 or even 2011 computers.
20161130 22:04:22< zookeeper> well, you can add USB3 ports via pci... :p
20161130 22:04:24 * zookeeper has one
20161130 22:06:18< zookeeper> (one of those adapter cards, not one port)
20161130 22:07:54< zookeeper> the core of my system is basically 2008-2009, works like a charm hardware-wise.
20161130 22:08:14-!- Appleman1234 [~Appleman1@KD106161205216.au-net.ne.jp] has joined #wesnoth-dev
20161130 22:12:19< celticminstrel> Either way, it's probably not worth it unless I can get it cheap.
20161130 22:12:27< celticminstrel> But it's nevertheless something I've considered.
20161130 22:14:30< zookeeper> i doubt you can easily find something like a 8GB DDR2 kit cheap
20161130 22:15:22 * celticminstrel shrugs.
20161130 22:15:42< celticminstrel> (Just looking now I found one on eBay for cheap, but probably not quite old enough.)
20161130 22:17:50< zookeeper> huh. yeah looks like there are some dirt cheap ones listed there. dunno what the catch is.
20161130 22:32:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161130 22:32:55-!- Bonobo [~Bonobo@2001:44b8:254:3200:5421:9897:7424:da0] has joined #wesnoth-dev
20161130 22:38:06< tad_carlucci> I'm looking at the differences between VS 2015 Community vs Professional and wondering if the one or two missing features are worth the worry. 
20161130 22:38:54< Aginor> tad_carlucci: I would imagine the licensing differences are the main reason to worry, if you do commercial software you need a non-community version
20161130 22:40:35< celticminstrel> The licensing differences are a valid worry, yes.
20161130 22:41:02< tad_carlucci> As I read it, that only applies if your company has 5 or more developers. For me, sitting here alone at home, it looks like I can sell my work, too. Of course, the old Express allowed that for me, too.
20161130 22:41:04< celticminstrel> (Not sure if one could get around that by developing on MSVC but only distributing a MinGW build. >_> )
20161130 22:41:25< celticminstrel> Ah, if it only applies with 5 or more devs, then that's alright.
20161130 22:41:53 * celticminstrel has also heard Jonathon Blow complaining that 2015 is worse than 2013.
20161130 22:42:40< tad_carlucci> Well, if you use VS2015 you need to start it about half an hour before you sit down because it's so slow coming up. But I read they're going to fix that in a while.
20161130 22:46:02< Aginor> I've had some fun tracking down VS2010 express recently
20161130 22:46:19< Aginor> it's nigh impossible unless you shell out for an MSDN subscription
20161130 22:46:45< tad_carlucci> I think I have the ISO on my archive but, of course, it would be illegal to provide it to you.
20161130 22:48:58< Aginor> indeed
20161130 22:49:17< Aginor> I'm not asking for it, I'm just complaining about silly shenanigans
20161130 22:53:36< tad_carlucci> Shenanigans sounds about right. I remember having to go through quite a few gyrations to get the Express stuff downloaded way-back-when. Getting VS 2015 Community was easy but the panic when it popped up a license warning  bothered me until I read it and realized I just needed to click through and all was fine.
20161130 22:56:25-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 22:56:35-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161130 22:56:50-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161130 22:58:19-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161130 23:00:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161130 23:20:58-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161130 23:22:00-!- Appleman1234 [~Appleman1@KD106161205216.au-net.ne.jp] has quit [Read error: Connection reset by peer]
20161130 23:24:59-!- Appleman1234 [~Appleman1@KD106161205216.au-net.ne.jp] has joined #wesnoth-dev
20161130 23:39:45-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161130 23:49:35-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
--- Log closed Thu Dec 01 00:00:35 2016