--- Log opened Fri Dec 02 00:00:16 2016 20161202 00:00:47-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 00:00:48< travis-ci> wesnoth/wesnoth#12264 (master - 2aded54 : Jyrki Vesterinen): The build is still failing. 20161202 00:00:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180521432 20161202 00:00:48-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 00:01:55-!- atarocch [~atarocch@host-78-65-187-41.homerun.telia.com] has quit [Remote host closed the connection] 20161202 00:06:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20161202 00:40:37-!- gfgtdf [~chatzilla@x4e36900c.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20161202 00:42:38-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 00:42:38< Appveyor> [The Battle for Wesnoth (Visual Studio 2015):master] 32f6ef3: "Editor: use src/-relative include paths" (Charles Dang) Succeeded 20161202 00:42:38< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-5 20161202 00:42:38< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/32f6ef3beaa1af2cb9a726764f9580c775e8e2e4 20161202 00:42:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 00:43:46< vultraz> :o 20161202 00:54:00< celticminstrel> :O 20161202 01:00:27< irker804> wesnoth: Charles Dang wesnoth:master ed15163b9531 / src/ (55 files in 15 dirs): Convert uses of resources::units to resources::gameboard->units() https://github.com/wesnoth/wesnoth/commit/ed15163b95317cd36b65c5e32314015dd059431f 20161202 01:01:30< celticminstrel> Oh dear, there he goes again... 20161202 01:01:42< celticminstrel> Did you test the editor at all? 20161202 01:02:33< celticminstrel> Removing resources::teams caused problems. This probably would, too. 20161202 01:02:34< vultraz> yes 20161202 01:02:45< celticminstrel> So the editor doesn't crash? 20161202 01:03:00< vultraz> there's a crash when placing a unit, but I just confirmed that that doesn't *seem* to be caused by this 20161202 01:03:30< vultraz> #0 0x100da2e std::_Hashtable > >, std::allocator > > >, std::__detail::_Select1st, std::equal_to, std::hash, std::__detail::_Mod_range_hashing,... 20161202 01:03:31< vultraz> ...std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits >::fin (??:??) 20161202 01:03:33< celticminstrel> Yeah, that crash has been around awhile... 20161202 01:03:45-!- gfgtdf [~chatzilla@x4e36900c.dyn.telefonica.de] has joined #wesnoth-dev 20161202 01:03:49< celticminstrel> Someone should fix it. 20161202 01:04:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds] 20161202 01:05:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 01:07:13< vultraz> celticminstrel: hm? wrong? 20161202 01:07:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 01:07:17< Appveyor> [The Battle for Wesnoth (Visual Studio 2015):master] 32f6ef3: "Editor: use src/-relative include paths" (Charles Dang) Succeeded 20161202 01:07:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-5 20161202 01:07:17< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/32f6ef3beaa1af2cb9a726764f9580c775e8e2e4 20161202 01:07:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 01:07:28< celticminstrel> vultraz: I edited more detail you might've missed. 20161202 01:07:51 * celticminstrel ponders how to make Appveyor's notification prettier... 20161202 01:08:22< vultraz> confused, I am 20161202 01:08:26< vultraz> what is this map_context 20161202 01:08:46< celticminstrel> Units, teams, etc belong to the display_context. 20161202 01:09:00< celticminstrel> The game and editor have different display context classes. 20161202 01:09:09< celticminstrel> (display_context is a common superclass) 20161202 01:09:21< celticminstrel> So in-game, you use the gameboard. 20161202 01:09:28< celticminstrel> But in the editor, you use a map_context IIRC. 20161202 01:09:41< vultraz> ridiculous, this is 20161202 01:09:58< celticminstrel> What's ridiculous IMO is the existence of resources::gameboard. 20161202 01:10:35< vultraz> there are too many damn game classes 20161202 01:10:37< vultraz> game_board 20161202 01:10:39< vultraz> game_display 20161202 01:10:41< vultraz> display 20161202 01:10:42< vultraz> play_controller 20161202 01:10:50< vultraz> playsingle/mp_controller 20161202 01:10:57< vultraz> display_context 20161202 01:11:51< vultraz> game_state 20161202 01:11:53< vultraz> game_data 20161202 01:13:57< vultraz> how is this line wrong: resources::gameboard->units() = context_manager_.get_map_context().get_units(); if it's calling get_map_context 20161202 01:15:14< celticminstrel> It's the left of the = that's (probably) wrong. 20161202 01:15:33< celticminstrel> That was, most likely, the point within the editor's code where resources::units was first set. 20161202 01:16:07< celticminstrel> So, if you're dropping resources::units, it should be removed. If you're keeping it in for now, it should be reverted to what it was. 20161202 01:16:18< celticminstrel> ("it" being that line) 20161202 01:16:40< vultraz> what about the line after it that assigns resources::gameboard->teams() 20161202 01:19:25< celticminstrel> Probably the same situation. 20161202 01:20:04< celticminstrel> If resources::gameboard is null, that's gonna be corrupting memory... 20161202 01:20:15< vultraz> it's in a conditional 20161202 01:20:19< vultraz> if(resources::gameboard) 20161202 01:20:42< vultraz> but you say there's no gameboard in the editor? 20161202 01:22:22< celticminstrel> Ah, if it's in a conditional, then it might never be executed, which is good at least. Pointless to have it there though. 20161202 01:22:36< celticminstrel> The gameboard is a subclass of display_context, so it won't exist in the editor. 20161202 01:22:46< vultraz> ok 20161202 01:22:48< celticminstrel> This is probably related to the crash when placing a unit too... 20161202 01:24:02< gfgtdf> vultraz: i think we shodul maerge 2 or maybe all of of play/playsingle/playmp_controller 20161202 01:25:20-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161202 01:26:46< gfgtdf> vultraz: iirc when iceiceice wrote game_board the one of the intentions was to make mathods of all 'gamechanging' action like moving units, changing terrain etx there so that we can keep track easier whetehr teh gamestat has changed (for exaple for ai or whiateboard caches) 20161202 01:27:03< gfgtdf> vultraz: but irrc is was quite messier before 20161202 01:28:38< irker804> wesnoth: Celtic Minstrel wesnoth:master cec563cba2df / .appveyor.vs2013.yml .appveyor.vs2015.yml utils/appveyor/irc-notify.py: Prettify the Appveyor notification a little https://github.com/wesnoth/wesnoth/commit/cec563cba2dfcc1cf04e5bc8e15357f6b13445ca 20161202 01:28:44< gfgtdf> vultraz: for the other thing, we know that every play_controller is a (or subclass of) playsingle_controller so if those files werent quite huge already we would have merged them. 20161202 01:28:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds] 20161202 01:29:26< celticminstrel> Others can feel free to tweak too if they dislike that format. 20161202 01:30:11-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds] 20161202 01:30:32< gfgtdf> vultraz: 'game_data' is basically a misc_data that comtains random stuff thats part of the gamestate class. We shodul remove it in favor of a 'game_vairables' class that just holds the game varaibles config and move all the other stuff to game_state. 20161202 01:31:03< celticminstrel> gfgtdf: Feel free to do that? 20161202 01:31:35< irker804> wesnoth: Charles Dang wesnoth:master 4d621567a49b / src/editor/ (controller/editor_controller.cpp map/context_manager.cpp): Editor: correctly fetch unit_map https://github.com/wesnoth/wesnoth/commit/4d621567a49b4abcd42dde0eb21a894623376e67 20161202 01:32:04< celticminstrel> gfgtdf: Also I think it makes sense to have different single and MP controllers, though I'm not quite sure what the controller classes do, so it may make less sense if I knew that... 20161202 01:32:34< celticminstrel> vultraz: Does that fix the crash on unit placement? 20161202 01:32:37< gfgtdf> celticminstrel: might do some day, stuill suffering from my pc breakage, and didnt have time to download wesnoth sources etc yet. 20161202 01:32:41 * celticminstrel guess it wouldn't, but we can hope. 20161202 01:33:15 * celticminstrel seems to recall that that crash resulted from some code not specific to the editor assuming there was a gameboard. 20161202 01:35:08< gfgtdf> celticminstrel: basically mp container basically allows timer setings and some netowkr stuff, note that 'local multiplayer' (e.g without a network controller) also runs through playmp_cotnroller. 20161202 01:35:45< vultraz> unit::ability_active asserts now 20161202 01:35:48< vultraz> assert(resources::gameboard && resources::tod_manager); 20161202 01:38:04< gfgtdf> vultraz: hmm you have a stacktrace? i wonder why those functiosn are called 20161202 01:38:15< gfgtdf> vultraz: i mean we dont aheva side panel thst shows these abilities in the editor 20161202 01:38:21< gfgtdf> dont have a * 20161202 01:38:40< gfgtdf> so why should it calculate whether they are active. 20161202 01:39:25< vultraz> blagh 20161202 01:39:30< vultraz> now it's back to the hash thing 20161202 01:40:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 01:40:43< Appveyor> [The Battle for Wesnoth (Visual Studio 2013):master] 32f6ef3: "Editor: use src/-relative include paths" (Charles Dang) Succeeded 20161202 01:40:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-6 20161202 01:40:43< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/32f6ef3beaa1af2cb9a726764f9580c775e8e2e4 20161202 01:40:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 01:43:35< celticminstrel> gfgtdf: So does each side have a controller? 20161202 01:43:44< celticminstrel> Including AI sides? 20161202 01:43:51< gfgtdf> celticminstrel: no controler is unrelated to that 20161202 01:44:11< gfgtdf> celticminstrel: controller is the calss thta handles most of the uer input 20161202 01:44:39< celticminstrel> gfgtdf: I wouldn't be surprised if the reports generator simply generates all reports, regardless of whether the theme shows them. 20161202 01:44:51< celticminstrel> gfgtdf: Does the controller also handle network input then? 20161202 01:46:02< celticminstrel> Am I imagining things or did Appveyor announce the same build twice? 20161202 01:46:04< gfgtdf> celticminstrel: and some of tha game mechanincs, is basically wher it all rund together,. See it has a 'gui' member thwhich handles to gui, a 'playturn' member which handles th netowrk input, game_state a also a memebr of this calss. 20161202 01:46:16< gfgtdf> runs* 20161202 01:46:29< gfgtdf> celticminstrel: which remonds me that we sodul rename that 'playturn' class 20161202 01:46:51< celticminstrel> I am not imagining things. 20161202 01:47:02< celticminstrel> Appveyor really announced the same build twice. 20161202 01:47:55< celticminstrel> gfgtdf: Sounds like this "gui" and "playturn" is more what I think of when I think of controllers... is there one for AI then? 20161202 01:49:07< gfgtdf> celticminstrel: tis is the codde that stats the ai turn https://github.com/wesnoth/wesnoth/blob/master/src/playsingle_controller.cpp#L553 20161202 01:49:32-!- prkc [~prkc@46.166.188.222] has quit [Ping timeout: 244 seconds] 20161202 01:53:17-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161202 01:59:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20161202 01:59:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20161202 02:05:02-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 02:05:02< Appveyor> [The Battle for Wesnoth (Visual Studio 2013):master] 32f6ef3: "Editor: use src/-relative include paths" (Charles Dang) Succeeded 20161202 02:05:02< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-6 20161202 02:05:02< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/32f6ef3beaa1af2cb9a726764f9580c775e8e2e4 20161202 02:05:06-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 02:05:18-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev 20161202 02:05:50< vultraz> celticminstrel: looks like 4 reports per commit 20161202 02:08:33< tad_carlucci> Release and Debug for 2013 and 2015 20161202 02:08:41-!- gfgtdf_ [~chatzilla@x4e368823.dyn.telefonica.de] has joined #wesnoth-dev 20161202 02:10:30< tad_carlucci> And I think it was set up to run every 8 hours instead of per-push 20161202 02:11:37-!- gfgtdf [~chatzilla@x4e36900c.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20161202 02:11:51-!- gfgtdf_ is now known as gfgtdf 20161202 02:13:04< celticminstrel> Ah, I see. 20161202 02:14:00< celticminstrel> tad_carlucci: Is it possible to make the announcement specify whether it was release or debug then? 20161202 02:14:42< tad_carlucci> I dunno. Just added a comment on your commit about that. 20161202 02:15:13< tad_carlucci> It should be possible. I need to check the docs and the command-line or python will need adjustment 20161202 02:16:32 * celticminstrel also added underline to the dict even though I didn't use it in the announcement. 20161202 02:16:57 * tad_carlucci saw that. 20161202 02:20:21< tad_carlucci> celticminstrel, from docs, environment variable : CONFIGURATION - configuration name set on Build tab of project settings (or through configuration parameter in appveyor.yml); 20161202 02:20:42< tad_carlucci> So it's there, just need to use it 20161202 02:22:28< vultraz> ya know 20161202 02:22:43< vultraz> I wonder if it's just me, or is still where TCed images appear very slightly faster 20161202 02:23:35-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161202 02:27:40< vultraz> need to convert the Attack Prediction dialog to GUI2... 20161202 02:28:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds] 20161202 02:28:52< vultraz> I think that's the last "small" dialog 20161202 02:29:15< vultraz> then there's just addons 20161202 02:29:20< celticminstrel> Who was it working on a graph widget? 20161202 02:29:21< vultraz> and help 20161202 02:29:24< celticminstrel> Was that Shiki? 20161202 02:29:31< vultraz> I think so 20161202 02:31:40< vultraz> does anyone want to help work on the GUI2 addons manager? 20161202 02:42:48< celticminstrel> What kind of help? I can probably help a little at least. 20161202 02:44:35< vultraz> lay the initial implementation of the 'actually download something' code 20161202 02:44:52< vultraz> probably at least some of the gui1 code could be used 20161202 02:45:25< vultraz> not any fancy interface yet, just for now, get it to download 1 addon at a time like the old manager did 20161202 02:45:43< vultraz> then we can drop the gui1 one and focus on further developing the gui2 version 20161202 02:52:31< Shiki> celticminstrel, I tested that, it worked https://github.com/wesnoth/wesnoth/pull/890/commits/b4a44656ec280d8cfe8b9a4b4b476f96afd62001 20161202 02:54:02< Shiki> celticminstrel, what i didn't figure out to test was that this ( https://github.com/wesnoth/wesnoth/commit/c66325856b73d2d610d44377c187ddbadda2978d ) was originally goinf to fix 20161202 02:54:03< irker804> wesnoth: Gregory A Lundberg wesnoth:master e754bad894c2 / src/synced_commands.cpp: Fix segfault when debug kill last breath deletes the unit, GNA 25348 (#890) https://github.com/wesnoth/wesnoth/commit/e754bad894c2178b556edaa1a3f141dcf1b14f5e 20161202 02:55:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20161202 03:01:55< tad_carlucci> The older commit was to fix a bug in [have_unit] when using debug/kill. It caused the segfault in your scneario because it used 'last breath' to kill off the side .. invalidating the iterator (i) causing the segfault. Guarding with i>valid() avoids the segfauklt 20161202 03:07:54< Shiki> what about a case when i have aditionally sth. with [have_unit] in that event? 20161202 03:09:07< tad_carlucci> ? 20161202 03:11:29< Shiki> We had a bug with [have_unit] originally. could that happen now again after this change, if "i" is not valid? 20161202 03:11:53< tad_carlucci> No. 20161202 03:13:08< Shiki> ok 20161202 03:13:19< tad_carlucci> The 'i' iterator points to the unit you debug/killed. If you delete it (as today) 'die' won't run so [have_unit] isn't possible. If you don't delete it, i is still that unit, die runs and [have_unit] still sees it has 0 HP so ignored the dying unit 20161202 03:19:23< Shiki> I got it, thanks =) 20161202 03:20:43< tad_carlucci> I'm glad you 'got it' because it's a convoluted mess and I'm not surprised I caused a segfault becauase of all the negatated-negative logic. 20161202 03:27:27-!- JyrkiVesterinen [~JyrkiVest@87-100-189-15.bb.dnainternet.fi] has joined #wesnoth-dev 20161202 03:28:11< Shiki> I never read C++ before, so I have my problems with it ... 20161202 03:29:34< tad_carlucci> JyrkiVesterinen, can you take a look at appveyor environment variable CONFIGURATION? I think it should be "Release" or "Debug" and we can use it on your IRC script to make the messages mroe clear on wesnoth-dev ?? 20161202 03:30:17< JyrkiVesterinen> Sure. I can try adding it somewhere to the message. 20161202 03:31:17< tad_carlucci> I was goign to but my systems are still reeling from taking a couple weeks 'off' .. and my sinus headache is back so I'm crashing soon 20161202 03:32:46< tad_carlucci> In fact, I think I"ll crash now ... 20161202 03:32:49-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.] 20161202 03:43:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 04:15:32< irker804> wesnoth: Jyrki Vesterinen wesnoth:master 3d2bbf94b1da / utils/appveyor/irc-notify.py: AppVeyor IRC notifications: remove unnecessary delay https://github.com/wesnoth/wesnoth/commit/3d2bbf94b1da95e5eed23dbe8a306c554d275a8a 20161202 04:15:35< irker804> wesnoth: Jyrki Vesterinen wesnoth:master bd020fe19fda / .appveyor.vs2013.yml .appveyor.vs2015.yml utils/appveyor/irc-notify.py: Add configuration name to AppVeyor IRC notification message https://github.com/wesnoth/wesnoth/commit/bd020fe19fdac22a508ff224433e1faa4f45e02c 20161202 04:29:22-!- gfgtdf [~chatzilla@x4e368823.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]] 20161202 04:46:52-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161202 04:51:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 250 seconds] 20161202 05:35:34< celticminstrel> Is AppVeyor unable to function similarly to Travis in terms of when it builds? 20161202 05:36:18< celticminstrel> ^when and what 20161202 05:37:54< JyrkiVesterinen> Building on push worked for tad_carlucci, but not for me. 20161202 05:38:06< JyrkiVesterinen> I turned on scheduled builds as a workaround- 20161202 05:38:21< celticminstrel> So you couldn't figure out why it didn't work? 20161202 05:38:22< JyrkiVesterinen> With scheduled builds, AppVeyor only builds one branch. 20161202 05:38:40< JyrkiVesterinen> Indeed, I couldn't figure it out. 20161202 05:38:57< celticminstrel> Oh well. 20161202 05:39:16< celticminstrel> It'd be nice if it tested PRs, but we do at least have Travis for that. 20161202 05:40:00< celticminstrel> When does it build? 20161202 05:40:48 * celticminstrel wonders whether we should add Mac+XCode to the Travis build... though Mac builds apparently are exceptionally slow on Travis... 20161202 05:42:51< JyrkiVesterinen> 20161130 14:13:39< JyrkiVesterinen> It's now set to make a VS2013 build on 0:51, 8:51 and 16:51 UTC, and VS2015 build on 0:09, 8:09 and 16:09 UTC. 20161202 05:42:51< celticminstrel> BTW, do you know what the ps on line 12 of .appveyor.vc2013.yml means? 20161202 05:42:51< JyrkiVesterinen> Ps means PowerShell. 20161202 05:42:51< JyrkiVesterinen> In other words, the rest of that line is a PowerShell command. 20161202 05:42:51< celticminstrel> Huh. 20161202 05:42:51< celticminstrel> Okay. 20161202 05:42:51< celticminstrel> Interesting. 20161202 05:43:09 * celticminstrel alos wonders if it skips the scheduled build when there were no new commits. 20161202 05:44:08< JyrkiVesterinen> Likely not. 20161202 05:45:15< celticminstrel> Main problem with adding an XCode build on Travis is that it would fail a lot because people don't consistently update the XCode project. 20161202 05:45:22< irker804> wesnoth: Charles Dang wesnoth:master 59c51fa9e737 / README.md: Add Travis CI status indicator to README https://github.com/wesnoth/wesnoth/commit/59c51fa9e737058ac03885a4680c7d6466eacd3c 20161202 05:45:26< celticminstrel> So it'd have to be an allowed failure, which might defeat the point... 20161202 05:46:32< celticminstrel> Whyyyy is Travis so far behind o.O 20161202 05:47:00< vultraz> if you want that moved further down the file feel free to do so 20161202 05:48:10< celticminstrel> You should've put [ci skip] in that one. 20161202 05:48:46< irker804> wesnoth: Charles Dang wesnoth:master 9d6cbfefeb44 / README.md: Add GPL v2 license badge to README https://github.com/wesnoth/wesnoth/commit/9d6cbfefeb4496242649a4087d07d4676b7b5576 20161202 05:49:16< celticminstrel> Did you notice that said license badge exists in the project's top tab bar? 20161202 05:49:35< vultraz> Yes 20161202 05:50:29< irker804> wesnoth: Gregory A Lundberg wesnoth:master fd671b1132f1 / src/spirit_po/po_message.hpp: Fix warnings in spirit_po (#885) https://github.com/wesnoth/wesnoth/commit/fd671b1132f1dac983a63d2b625ac5191f84d143 20161202 05:50:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds] 20161202 05:51:19< vultraz> But it's certainly nice to have completeness 20161202 05:53:01-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend] 20161202 05:53:12< irker804> wesnoth: Jyrki Vesterinen wesnoth:master 211ade943a23 / README.md: Add AppVeyor build status badge, too https://github.com/wesnoth/wesnoth/commit/211ade943a234bc76d581cd58856b23491eae4db 20161202 05:54:57< vultraz> ah, you beat me to it :D 20161202 05:55:18< celticminstrel> Only minor gripe is that AppVeyor's contains an icon while Travis's does not... 20161202 05:56:22< vultraz> now we look like a respectable project 20161202 05:56:25< vultraz> with a failing build :D 20161202 05:57:15< celticminstrel> The build should be fixed with tad's commit, hopefully. 20161202 05:57:30< celticminstrel> e754bad that is 20161202 05:57:38< celticminstrel> Wait no 20161202 05:57:44< celticminstrel> 52ec04b 20161202 05:58:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20161202 06:01:38< celticminstrel> The adjustment to the draw event firing rate seems a likely cause for the bug currently being discussed in the release thread. 20161202 06:01:42< celticminstrel> Maybe we should revert it. 20161202 06:02:11< celticminstrel> ...is there something such as SDL_PeekEvents which can be used to check if an event of some type exists in the queue? 20161202 06:03:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds] 20161202 06:06:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20161202 06:10:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20161202 06:11:49< vultraz> celticminstrel: https://wiki.libsdl.org/SDL_PeepEvents 20161202 06:13:29< celticminstrel> Okay, so where are the draw events pushed? 20161202 06:14:29< vultraz> gui/widgets/window.cpp:578 20161202 06:14:43< vultraz> it's on a timer 20161202 06:15:21< celticminstrel> ...wait a second here. 20161202 06:15:52< celticminstrel> (Do local classes have a closure? I forget, since I never use them.) 20161202 06:16:12< celticminstrel> (Regardless, even if they did this one clearly doesn't care.) 20161202 06:16:32< celticminstrel> Is draw_timer a global variable, or what? 20161202 06:16:55< vultraz> static 20161202 06:16:59< vultraz> line 135 20161202 06:17:13< celticminstrel> Oh a function, duh. 20161202 06:17:30< vultraz> :P 20161202 06:17:33< celticminstrel> Okay so what the heck is actually. 20161202 06:18:19< vultraz> RAII method to keep the timer firing when a window is showed 20161202 06:19:12< vultraz> showing 20161202 06:19:26< celticminstrel> Is draw_interval a global or something? 20161202 06:19:52< vultraz> static 20161202 06:19:54< vultraz> line 126 20161202 06:19:57< vultraz> seriously, open the file 20161202 06:20:33< celticminstrel> So you say it's an RAII method, but unless I'm mistaken it's utterly failing to manage its resource. 20161202 06:20:39< celticminstrel> It's allocating but never deallocating. 20161202 06:20:54< celticminstrel> If I'm reading this right, a new timer is added every time a window is open. 20161202 06:21:06< celticminstrel> So after opening five windows you have five timers. 20161202 06:21:19< celticminstrel> And five draw events fired every 20ms. 20161202 06:21:38< celticminstrel> Have people noticed slowdown when running Wesnoth for long periods? 20161202 06:21:39< vultraz> o_O 20161202 06:22:41< vultraz> i think so 20161202 06:25:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20161202 06:25:56< celticminstrel> I'll test to see if removing the timer breaks stuff, and if not, if it helps with the lag I experienced in the server login window. 20161202 06:26:08< celticminstrel> ...which means I need to update the XCode project. Sigh. 20161202 06:26:09< vultraz> btw 20161202 06:26:14< vultraz> is tc still broken for you 20161202 06:26:28< celticminstrel> I haven't checked lately, but last I checked it was. 20161202 06:26:34< vultraz> do check again 20161202 06:26:35< celticminstrel> That was before color_t. 20161202 06:27:17< celticminstrel> IIRC it's not broken in ancestral's build even when run on my machine, so either ir's a) something in the debug build settings or b) something about my build environment. 20161202 06:31:47< vultraz> maybe you had LOW_MEM 20161202 06:32:00< celticminstrel> Last time I checked was after LOW_MEM was removed. 20161202 06:32:04< vultraz> I see 20161202 06:32:09< vultraz> well, check again now 20161202 06:32:27< celticminstrel> Probably won't check until tomorrow. 20161202 06:32:44< celticminstrel> I'll take the opportunity while it's compiling to play some games on the other computer. 20161202 06:33:57< celticminstrel> Ah, I see, so the timers do get cancelled eventually. 20161202 06:34:37< celticminstrel> Because they return their new interval, so if they return 0, they are cancelled. 20161202 06:34:46< celticminstrel> I could still see it being an issue though. 20161202 06:35:17< celticminstrel> If there were only ever one GUI2 window open at a time, it would be perfectly fine. 20161202 06:36:45< celticminstrel> Oh wait, maybe I was reading it wrong. It only... wait no, it looks like the intent was fine but had a major logic error. 20161202 06:37:01< celticminstrel> Wait no, not true, because interval_ is initialized. 20161202 06:38:30< celticminstrel> Okay so when you first open a GUI2 window, draw_interval is 0, so the timer is added and draw_interval is set to 20. If another one opens over it, draw_interval is no longer 0, so now the timer is not added. The timer is never explicitly removed, but it returns draw_interval, so it'll be cancelled implicitly once draw_interval is reset to 0 by the destructor after the last GUI2 window closes. 20161202 06:38:53< celticminstrel> I'm still wondering why it's done that way instead of explicitly removing the timer though. 20161202 06:47:54-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161202 06:52:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds] 20161202 07:41:14-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev 20161202 07:41:37-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20161202 07:41:39-!- RatArmu [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20161202 07:42:12-!- RatArmu [~ratarmy@133.15.175.65] has quit [Client Quit] 20161202 07:42:42-!- RatArmu [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20161202 07:42:44-!- RatArmu [~ratarmy@133.15.175.65] has quit [Client Quit] 20161202 07:43:26-!- RatArmu [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20161202 07:44:03-!- RatArmu is now known as RatArmy 20161202 08:02:44-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer] 20161202 08:02:45-!- RatArmy [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer] 20161202 08:02:57-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20161202 08:17:50-!- celticminstrel is now known as celmin|sleep 20161202 08:27:18-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 268 seconds] 20161202 08:41:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20161202 08:52:53-!- RatArmy_ [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev 20161202 08:56:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds] 20161202 09:00:30-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me] 20161202 09:01:12-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20161202 09:38:15-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 246 seconds] 20161202 09:39:04-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev 20161202 09:40:47-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 09:40:48< travis-ci> wesnoth/wesnoth#12268 (master - ed15163 : Charles Dang): The build has errored. 20161202 09:40:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180581996 20161202 09:40:48-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 10:02:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20161202 10:02:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20161202 10:02:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20161202 10:14:27-!- Kwandulin [~Miranda@p200300760F6EBFE9D58520AE38F75A87.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161202 10:25:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161202 10:28:28< irker804> wesnoth: Jyrki Vesterinen wesnoth:master 5729d3dbf826 / utils/appveyor/irc-notify.py: Revert "AppVeyor IRC notifications: remove unnecessary delay" https://github.com/wesnoth/wesnoth/commit/5729d3dbf826466a5d2593feff1372607a32c891 20161202 10:35:15-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Quit: Leaving] 20161202 11:24:37-!- RatArmy_ [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20161202 11:30:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161202 11:39:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer] 20161202 11:40:13-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20161202 11:40:13-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20161202 11:40:13-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20161202 11:50:24-!- atarocch [~atarocch@185.69.144.117] has joined #wesnoth-dev 20161202 11:50:50-!- RatArmy_ [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev 20161202 11:52:27-!- RatArmy_ is now known as RatArmy 20161202 12:02:18-!- atarocch [~atarocch@185.69.144.117] has quit [Ping timeout: 244 seconds] 20161202 12:12:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 12:20:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20161202 12:21:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 12:32:14-!- Kwandulin [~Miranda@p200300760F6EBFE9D58520AE38F75A87.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161202 13:12:54-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161202 13:14:35< tad_carlucci> Travis is hung. Don't know how or why. It would be "Passing" but it's not running anything for several hours now. 20161202 13:28:33-!- irker804 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20161202 13:35:52-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has quit [Quit: I'm not back now.] 20161202 13:55:50-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.] 20161202 14:27:28-!- Kwandulin [~Miranda@p200300760F6EBFE9C8551947FDF1C509.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161202 14:30:16-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye] 20161202 14:30:26-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20161202 14:46:52-!- Kwandulin [~Miranda@p200300760F6EBFE9C8551947FDF1C509.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 20161202 15:01:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20161202 15:05:36-!- gfgtdf [~chatzilla@x4e368823.dyn.telefonica.de] has joined #wesnoth-dev 20161202 15:07:49-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 15:07:50< travis-ci> wesnoth/wesnoth#12266 (master - 52ec04b : Gregory A Lundberg): The build was fixed. 20161202 15:07:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180529210 20161202 15:07:50-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 15:11:14-!- JyrkiVesterinen [~JyrkiVest@87-100-189-15.bb.dnainternet.fi] has quit [Quit: .] 20161202 15:18:24-!- Kwandulin [~Miranda@p200300760F6EBFE9C8551947FDF1C509.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161202 15:55:31-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161202 16:41:36-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-138.pppoe.mtu-net.ru] has joined #wesnoth-dev 20161202 16:45:14-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 16:45:14< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen 5729d3d: Revert "AppVeyor IRC notifications: remove unnecessary delay" Succeeded 20161202 16:45:14< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-7 20161202 16:45:14< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/5729d3dbf826466a5d2593feff1372607a32c891 20161202 16:45:18-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 16:47:41< Shiki> https://forums.wesnoth.org/viewtopic.php?f=5&p=605719#p605719 20161202 16:50:03< gfgtdf> Shiki: ? 20161202 16:50:46< Shiki> just wanted to link, he just answered gfgtdf 20161202 16:54:22-!- celmin|sleep is now known as celticminstrel 20161202 16:54:43< celticminstrel> XCode build successful... trying units tests now... 20161202 16:54:48< celticminstrel> ^-s 20161202 16:57:07< celticminstrel> Server MOTD is broken apparently (invalid markup). No idea whether that's a problem on the code or config side. 20161202 17:09:01-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161202 17:12:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 17:12:09< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen 5729d3d: Revert "AppVeyor IRC notifications: remove unnecessary delay" Succeeded 20161202 17:12:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-7 20161202 17:12:09< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/5729d3dbf826466a5d2593feff1372607a32c891 20161202 17:12:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 17:13:51< Ravana_> hmm, new bot, might need to edit my forwarding patterns 20161202 17:22:19-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 17:22:20< travis-ci> wesnoth/wesnoth#12267 (master - 32f6ef3 : Charles Dang): The build was fixed. 20161202 17:22:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180569316 20161202 17:22:20-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 17:23:42-!- Greg-Bog_ [~greg_bogg@2601:1c2:f00:9780:cc35:4ac5:c2a1:82fe] has joined #wesnoth-dev 20161202 17:26:17-!- Kwandulin [~Miranda@p200300760F6EBFE9C8551947FDF1C509.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161202 17:26:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 250 seconds] 20161202 17:26:31-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev 20161202 17:27:07-!- travis-ci [~travis-ci@ec2-54-147-175-252.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 17:27:08< travis-ci> wesnoth/wesnoth#12269 (master - 4d62156 : Charles Dang): The build was fixed. 20161202 17:27:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180586900 20161202 17:27:08-!- travis-ci [~travis-ci@ec2-54-147-175-252.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 17:27:36< Shiki> Is somebody using here Fedora or Suse? 20161202 17:28:15< Shiki> The instructions for installing the dependencies when compiling are still for 1.10 here. https://wiki.wesnoth.org/CompilingWesnoth#Linux_Tips_to_Easily_Gather_Dependencies 20161202 17:46:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 17:46:17< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen 5729d3d: Revert "AppVeyor IRC notifications: remove unnecessary delay" Succeeded 20161202 17:46:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-8 20161202 17:46:17< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/5729d3dbf826466a5d2593feff1372607a32c891 20161202 17:46:22-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 17:54:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161202 17:55:36-!- travis-ci [~travis-ci@ec2-54-147-175-252.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 17:55:37< travis-ci> wesnoth/wesnoth#12265 (master - 9cbd31d : Celtic Minstrel): The build is still failing. 20161202 17:55:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180528960 20161202 17:55:38-!- travis-ci [~travis-ci@ec2-54-147-175-252.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 18:12:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161202 18:12:26< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen 5729d3d: Revert "AppVeyor IRC notifications: remove unnecessary delay" Succeeded 20161202 18:12:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-8 20161202 18:12:26< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/5729d3dbf826466a5d2593feff1372607a32c891 20161202 18:12:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161202 18:12:40-!- JyrkiVesterinen [~JyrkiVest@87-100-145-11.bb.dnainternet.fi] has joined #wesnoth-dev 20161202 18:30:25-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20161202 18:32:17 * celticminstrel ponders the AppVeyor announcement format. It's nicer than before, but that's a lot of bold. 20161202 18:34:25-!- irker734 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20161202 18:34:26< irker734> wesnoth: Celtic Minstrel wesnoth:master 57f13b848ad8 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/57f13b848ad8c95dc4fe87cebe4d516427e07de0 20161202 18:43:16< celticminstrel> I'd really like to know whether mattsc/ancestral can build... 20161202 18:43:42< celticminstrel> Because I just discovered that my libharfbuzz depends on libintl... :| 20161202 18:48:47< celticminstrel> vultraz: My build still has no TC. 20161202 18:57:57< zookeeper> libharfbuzz? that's maybe the first library name which doesn't sound boring 20161202 19:07:25-!- Greg-Bog_ [~greg_bogg@2601:1c2:f00:9780:cc35:4ac5:c2a1:82fe] has quit [Remote host closed the connection] 20161202 19:24:15-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-138.pppoe.mtu-net.ru] has quit [Quit: I need to go. Bye!] 20161202 19:24:19< loonycyborg> it's farsi afaik :P 20161202 19:37:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161202 20:01:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20161202 20:02:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 20:28:52-!- JyrkiVesterinen [~JyrkiVest@87-100-145-11.bb.dnainternet.fi] has quit [Quit: .] 20161202 20:39:32< EliDupree> celticminstrel: By the way, if any of the new 1.13 UI stuff good for having asynchronous user interactions? (i.e. can I have a dialog or something without blocking chat, blocking other players' moves that use synchronize_choice, etc.) 20161202 20:39:39< EliDupree> *is any 20161202 20:40:16< celticminstrel> No. 20161202 20:40:46< EliDupree> I guess I'll have to resort to glorious hacks, then :-) 20161202 20:40:49< celticminstrel> GUI2 supports modeless dialogs, but only on top of other GUI2 dialogs, which means they won't work in-game (and they're not exposed to the Lua API, naturally). 20161202 20:42:26< EliDupree> ...Although, my main tricky idea is to draw all of the information on the map, which would make it incompatible with very small maps 20161202 20:42:29< vultraz> they won't work in-game until we transition the main UI to GUI2* 20161202 20:42:57< celticminstrel> Yes. 20161202 20:43:12< celticminstrel> Once that's done we could support a modeless=yes key in Lua dialogs. 20161202 20:43:18< celticminstrel> Or modal=no 20161202 20:43:23< celticminstrel> Whichever you prefer. 20161202 20:43:29< EliDupree> -_- 20161202 20:43:39< celticminstrel> However, I doubt that'll be ready for 1.14. 20161202 20:44:29< celticminstrel> We should be able to get all GUI1 dialogs ported by 1.14 (addons, attack prediction, help), but porting the in-game UI is a much larger task. 20161202 20:44:49< vultraz> yes 20161202 20:44:57< vultraz> table-flipping level task 20161202 20:45:04< celticminstrel> Especially since it doesn't have a fixed layout. 20161202 20:45:28< vultraz> nothing is in one place 20161202 20:45:31< vultraz> everything is everywhere 20161202 20:45:35< celticminstrel> What? 20161202 20:45:36< vultraz> it's all a mess 20161202 20:46:12 * celticminstrel doesn't think we're talking about the same thing here. 20161202 20:46:23< vultraz> the code 20161202 20:46:27< vultraz> the code is all over the plac 20161202 20:46:29< vultraz> e 20161202 20:46:44< celticminstrel> I'm talking about the onscreen layout of the UI. 20161202 20:46:54< vultraz> what's wrong with it 20161202 20:47:02< vultraz> writing the layout in GUI2 would be pretty simple 20161202 20:47:04< vultraz> maybe 20161202 20:47:25< celticminstrel> It's not fixed. 20161202 20:47:40< celticminstrel> You can't write the layout in GUI2. 20161202 20:47:48< vultraz> what do you mean by "fixed" 20161202 20:48:33< celticminstrel> UI elements can be moved around depending on your settings. 20161202 20:48:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds] 20161202 20:49:16< vultraz> you mean per-resolution? 20161202 20:49:23< celticminstrel> Nothing to do with resolution. 20161202 20:49:39< vultraz> theme? 20161202 20:49:45< celticminstrel> Yes. 20161202 20:50:12< vultraz> I see 20161202 20:50:19< vultraz> well, forget themes for now 20161202 20:50:28< celticminstrel> Don't forget themes. 20161202 20:50:40< celticminstrel> Write it with themes in mind from the start. 20161202 20:50:51< celticminstrel> You can invent a totally new ThemeWML syntax if you want though. 20161202 20:51:35< vultraz> hm, I forget GUI2 themes are not the same as "themes" 20161202 20:51:59< vultraz> which reminds me.. 20161202 20:53:12< irker734> wesnoth: Charles Dang wesnoth:master 6d704071b981 / data/themes/pandora.cfg: Removed Pandora theme https://github.com/wesnoth/wesnoth/commit/6d704071b981c5c6d672c9efa18798cdb0f199f9 20161202 20:53:41< vultraz> but yes 20161202 20:53:45< vultraz> ThemeWML must die 20161202 20:54:12< celticminstrel> If by "die" you mean "new incompatible syntax", then sure. 20161202 20:54:42< celticminstrel> Or do you plan to also remove the ability to view the details of two units at once? 20161202 20:55:19< vultraz> that's the widescreen theme 20161202 20:55:50< celticminstrel> (I forget, does it actually work?) 20161202 20:55:53< vultraz> but, no, I suppose themewml must still exist in some form since I use it in my addon, as does shadowm. 20161202 20:56:32< vultraz> I have no idea 20161202 20:56:36< celticminstrel> If we do define a new incompatible ThemeWML, I can attempt to write a converter. 20161202 20:56:44< celticminstrel> No idea of what? 20161202 20:56:50< vultraz> if widescreen works 20161202 20:56:54< celticminstrel> Oh. 20161202 20:57:24< vultraz> we have Classic, UnitBox, Widescreen, and Default 20161202 20:57:38< vultraz> Classic will be dropped. UnitBox was never completed. Widescreen maybe works. 20161202 20:57:50-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 20:57:51< travis-ci> wesnoth/wesnoth#12268 (master - ed15163 : Charles Dang): The build was fixed. 20161202 20:57:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180581996 20161202 20:57:51-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 20:58:19< celticminstrel> Where does shadowm use ThemeWML? 20161202 20:58:27< celticminstrel> Oh found it. 20161202 20:58:31< vultraz> we use it to make a cutscene theme 20161202 20:58:35< vultraz> sans sidebar 20161202 20:59:20< vultraz> (UnitBox and Default might merge into ancestral's proposed new theme) 20161202 20:59:59< celticminstrel> The cutscene themes really don't look too bad. 20161202 21:00:31< vultraz> they're the only good use of themewml 20161202 21:02:41< gfgtdf> ancestral is wokring on themewml ? 20161202 21:03:21< celticminstrel> The main questionable point I'm seeing is the rect attribute. 20161202 21:03:50< vultraz> gfgtdf: he said he wanted to work on updating the main theme 20161202 21:03:57< vultraz> celticminstrel: yes, the rect is the worst part 20161202 21:03:59< vultraz> and ref 20161202 21:04:43-!- m1guelpiedrafita [~mpirc@cm-81-9-217-43.telecable.es] has joined #wesnoth-dev 20161202 21:04:54< m1guelpiedrafita> Hi! 20161202 21:05:25< m1guelpiedrafita> Can anyone add me to the Github organization 20161202 21:05:34< m1guelpiedrafita> I am m1guelpf on Github 20161202 21:05:38< m1guelpiedrafita> Thank you! 20161202 21:05:44< irker734> wesnoth: Celtic Minstrel wesnoth:master 435609549efe / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Add libintl back; apparently libharfbuzz depends on it https://github.com/wesnoth/wesnoth/commit/435609549efe6f7a21533511d93dbd009fb11ed0 20161202 21:05:46< irker734> wesnoth: Celtic Minstrel wesnoth:master 86675c28de34 / data/themes/ (classic.cfg default.cfg editor.cfg unit_box.cfg widescreen.cfg): Remove 800x480 support from the themes https://github.com/wesnoth/wesnoth/commit/86675c28de3434a55e20deccf236fa8e5a76b4b3 20161202 21:06:02< celticminstrel> Wow, what a request. 20161202 21:06:20< celticminstrel> Normally contributions are accepted by PR rather than by adding people to the organization. 20161202 21:06:29< celticminstrel> vultraz: What does ref do? 20161202 21:06:55< vultraz> i don't know 20161202 21:07:01< vultraz> provide a reference for the rect or something 20161202 21:07:05< celticminstrel> vultraz: I'm also questioning [change] a little. 20161202 21:07:09-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20161202 21:07:17< celticminstrel> In fact, [partialresolution] too. 20161202 21:08:10-!- m1guelpiedrafita [~mpirc@cm-81-9-217-43.telecable.es] has left #wesnoth-dev [] 20161202 21:13:51< gfgtdf> actually i'd exapect tht when we port the main game ui to gui2 then theme will basically be the 'game dialog's dialog defintion in normal gui2 wml, with some new widgets like foe eample [game_map] or [menu_strip] 20161202 21:13:59< gfgtdf> themewml* 20161202 21:14:56< celticminstrel> That's terrible. 20161202 21:15:47< celticminstrel> IMO the game UI shouldn't have an actual dialog. 20161202 21:16:09< celticminstrel> ie, no REGISTER_DIALOG 20161202 21:25:13< celticminstrel> Not a subclass of modal_dialog or modeless_dialog. 20161202 21:25:42< celticminstrel> (Though it could subclass modal_dialog and just not register itself, maybe.) 20161202 21:26:32< celticminstrel> It should probably parse ThemeWML into GUI2 WML and pass that to the window_builder... though using a custom window_builder may also be possible. 20161202 21:27:11< celticminstrel> Also, IMO we need a BorderLayout for the game UI (and it'd be useful in other cases too). 20161202 21:27:31< celticminstrel> I thought matrix did that, but apparently I was wrong? 20161202 21:43:13-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 21:43:14< travis-ci> wesnoth/wesnoth#12272 (master - e754bad : Gregory A Lundberg): The build was fixed. 20161202 21:43:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180598356 20161202 21:43:15-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 21:47:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161202 22:03:16-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev 20161202 22:04:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20161202 22:04:33-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20161202 22:04:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161202 22:16:34< gfgtdf> Shiki: are you the same as the one who filed http://gna.org/bugs/?25323 ? Yould you please test whether https://github.com/gfgtdf/wesnoth-old/commit/75313411fdda2e1fe2cd92189bb8083c1c6d139e (not in master yet) fixes the issue ? 20161202 22:18:58< celticminstrel> I'm still dubious about the loading screen being threaded. 20161202 22:19:06-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 22:19:07< travis-ci> wesnoth/wesnoth#12275 (master - fd671b1 : Gregory A Lundberg): The build passed. 20161202 22:19:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180617893 20161202 22:19:07-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 22:22:27-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev 20161202 22:24:44< Shiki> gfgtdf, yes, I'm the same. 20161202 22:24:54< Shiki> can I use a git command to get this commit? 20161202 22:25:43< celticminstrel> git fetch https://github.com/gfgtdf/wesnoth-old.git master 20161202 22:25:49< celticminstrel> (I think that's the right URL) 20161202 22:26:06< celticminstrel> git checkout -b name_the_branch FETCH_HEAD 20161202 22:26:29< celticminstrel> Or rebase/merge to FETCH_HEAD. 20161202 22:26:45 * celticminstrel assumes you know how to rebase and merge. 20161202 22:28:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV] 20161202 22:32:44< Shiki> Thanks. 20161202 22:35:01-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 22:35:02< travis-ci> gfgtdf/wesnoth-old#699 (master - 7ae6aaa : gfgtdf): The build has errored. 20161202 22:35:03< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/180800685 20161202 22:35:03-!- travis-ci [~travis-ci@ec2-54-226-97-1.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 22:36:13< gfgtdf> wonder why it shows me that old build now. 20161202 22:40:10-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20161202 22:41:49< Shiki> travis is a busy man 20161202 22:45:27-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev 20161202 22:46:14< Shiki> gfgtdf, ok 20161202 22:46:30< Shiki> I have the error in the era files 20161202 22:46:43< gfgtdf> Shiki: of you addon ? 20161202 22:46:48< gfgtdf> your* 20161202 22:46:49< Shiki> yes 20161202 22:47:13< Shiki> when clicking on multiplayer i get the errormessage and no crash after clicking ok, However... 20161202 22:47:13< gfgtdf> Shiki: does it fix the cras or does ti make it worse ? 20161202 22:47:49< Shiki> when I start a campaign, which reads the files of this era, it crashes. 20161202 22:48:15< gfgtdf> hmm 20161202 22:48:35< Shiki> Caught a string thrown as an exception: 20161202 22:48:38< Shiki> No scenariodata found 20161202 22:49:02< gfgtdf> Shiki: is that literally te message ? scenariodata one word `? 20161202 22:49:17< Shiki> yes 20161202 22:49:22< Shiki> in stderr 20161202 22:49:30< celticminstrel> Try git grep '"No scenariodata found"' 20161202 22:50:31< gfgtdf> its in https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/connect_engine.hpp do you ahve a stactrace frm where (callstack) that exception is thorwn ? 20161202 22:51:01< gfgtdf> maybe replcbng the thowing line https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/connect_engine.hpp#L92 with a assert(false) woudl help 20161202 22:51:39< Shiki> I try to get that, but seems i have a bit trouble to find the corefile 20161202 22:53:17< gfgtdf> actually thinking about it.. i'd assume that if the addon has an syntax erro in it woudlnt appear in the campaign list at all. so mabye the question is why are you able to select that campaign 20161202 22:54:18< Shiki> the campaign is a different add-on 20161202 22:54:46< gfgtdf> hmm ok 20161202 22:55:31< Shiki> for the campaign crash, i did skip the part with testing if the era breaks when clicking mp. just starting wesnoth and choosing the campaign 20161202 22:56:55< gfgtdf> Shiki: if you just remve (rename) the era (with no syntax error) and start the campaign what happens then ? 20161202 22:59:28< Shiki> crashes as well, after clicking ok. same message in stderr 20161202 23:02:16< Shiki> oh, I think I figuered out why i get no coredumps anymore. just 400mb free on / 20161202 23:02:17-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20161202 23:04:09< gfgtdf> Shiki: do you get a 'Cannot find era $era' somehere ? 20161202 23:04:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20161202 23:05:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161202 23:05:37< gfgtdf> Shiki: hmm yes a stacktrace woudl be still be nice, i have some idea that it coudl cme form connect_engines dtor but im not sure 20161202 23:05:42-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev 20161202 23:06:03< gfgtdf> or frm some other dtor 20161202 23:06:07< gfgtdf> from* 20161202 23:08:19-!- mjs-de [~mjs-de@x4db56609.dyn.telefonica.de] has joined #wesnoth-dev 20161202 23:08:52< Shiki> yes, there is a message that the era is missing 20161202 23:09:04< Shiki> sth like macro file .... is missing 20161202 23:09:36< Shiki> but not like 'Cannot find era $era' 20161202 23:13:55-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 23:13:56< travis-ci> gfgtdf/wesnoth-old#700 (master - 002ab4d : gfgtdf): The build has errored. 20161202 23:13:56< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/180807966 20161202 23:13:56-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 23:14:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161202 23:14:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 23:14:12< Shiki> brb 20161202 23:14:13-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend] 20161202 23:15:41-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161202 23:16:34< Shiki> there is no coredump getting created 20161202 23:16:54< Shiki> could it be that wesnoth shuts down peacefully after the exception 20161202 23:17:54< gfgtdf> Shiki: hmm yes thats why i suggestd to replace https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/connect_engine.hpp#L92 line with a assert(false); 20161202 23:19:07< Shiki> must have missed that 20161202 23:19:56< celticminstrel> If it's just for testing, sure. 20161202 23:20:08< celticminstrel> But don't commit something like that. 20161202 23:21:33< gfgtdf> celticminstrel: throw "string" is not somnethin meant to be thorn, the onyl reason why its a throw and not a assert() is that that functions reqires required a return value and with assert the compiler woudl complain. 20161202 23:22:20< gfgtdf> Shiki: so mabye insrting the assertionm ebfore, ratherather than replacing the thorw would be better (because it migth not complie otherwise) 20161202 23:22:23< celticminstrel> There's not really a concept of whether something is meant to be thrown in most programming languages. 20161202 23:22:24< gfgtdf> inserting* 20161202 23:22:37< celticminstrel> IMO there's nothing really wrong with throwing a plain string. 20161202 23:23:02< celticminstrel> Sure, an exception class can give more info, but maybe there's no more info to give. 20161202 23:23:44 * vultraz is cleaning up the animation code 20161202 23:25:57-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161202 23:26:34< vultraz> gah 20161202 23:26:42< vultraz> who decided to make a member function "override" :| 20161202 23:26:49< vultraz> name* 20161202 23:27:04< celticminstrel> ??? 20161202 23:27:09< tad_carlucci> And it compiled? 20161202 23:27:12-!- Appleman1234 [~Appleman1@106.161.199.206] has quit [Ping timeout: 260 seconds] 20161202 23:27:14< Shiki> it did compiel 20161202 23:27:15< Shiki> warning: core file may not match specified executable file. 20161202 23:27:15< Shiki> [New LWP 1706] 20161202 23:27:15< Shiki> [New LWP 1707] 20161202 23:27:15< Shiki> [New LWP 1709] 20161202 23:27:15< Shiki> [New LWP 1708] 20161202 23:27:17< Shiki> [Thread debugging using libthread_db enabled] 20161202 23:27:19< Shiki> Using host libthread_db library "/usr/lib/libthread_db.so.1". 20161202 23:27:21< Shiki> Core was generated by `wesnoth-git'. 20161202 23:27:23< Shiki> Program terminated with signal SIGABRT, Aborted. 20161202 23:27:25< Shiki> #0 0x00007fee2613b04f in raise () from /usr/lib/libc.so.6 20161202 23:27:29< Shiki> [Current thread is 1 (Thread 0x7fee2acf8980 (LWP 1706))] 20161202 23:27:31< Shiki> (gdb) backtrace 20161202 23:27:33< Shiki> #0 0x00007fee2613b04f in raise () at /usr/lib/libc.so.6 20161202 23:27:35< Shiki> #1 0x00007fee2613c47a in abort () at /usr/lib/libc.so.6 20161202 23:27:37< Shiki> #2 0x00007fee26133ea7 in __assert_fail_base () at /usr/lib/libc.so.6 20161202 23:27:39< Shiki> #3 0x00007fee26133f52 in () at /usr/lib/libc.so.6 20161202 23:27:41< Shiki> Python Exception maximum recursion depth exceeded while getting the str of an object: 20161202 23:27:42< celticminstrel> Whyyy Shiki why 20161202 23:27:44< Shiki> #4 0x0000000000bf6dfc in ng::connect_engine::scenario() (this=0x7ffdbd4d38a8) at src/game_initialization/connect_engine.hpp:92 20161202 23:27:47< Shiki> Python Exception maximum recursion depth exceeded while getting the str of an object: 20161202 23:27:50< Shiki> #5 0x0000000000f97296 in ng::connect_engine::connect_engine(saved_game&, bool, mp_campaign_info*) (this=0x7ffdbd4d38a8, state=..., first_scenario=true, campaign_info=0x0) at src/game_initialization/connect_engine.cpp:93 20161202 23:27:53< Shiki> #6 0x0000000000ab3833 in sp::enter_connect_mode(CVideo&, config const&, saved_game&, bool) (state=...) 20161202 23:27:53< vultraz> oh deer 20161202 23:27:56< Shiki> at src/game_initialization/singleplayer.cpp:136 20161202 23:28:00< Shiki> #7 0x0000000000ab37ce in sp::enter_configure_mode(CVideo&, config const&, saved_game&, ng::create_engine&, bool) (video=..., game_config=..., state=..., create_eng=..., local_players_only=true) at src/game_initialization/singleplayer.cpp:129 20161202 23:28:04< Shiki> #8 0x0000000000ab35b2 in sp::enter_create_mode(CVideo&, config const&, saved_game&, jump_to_campaign_info, bool) (video=..., game_config=..., state=..., jump_to_campaign=..., local_players_only=true) at src/game_initialization/singleplayer.cpp:113 20161202 23:28:08< Shiki> #9 0x00000000004dd524 in game_launcher::new_campaign() (this=0x2168af0) at src/game_launcher.cpp:721 20161202 23:28:10< Shiki> #10 0x000000000056bcf0 in gui2::dialogs::ti 20161202 23:28:12< Shiki> upppp 20161202 23:28:14< Shiki> https://bpaste.net/show/a740a133bbdd 20161202 23:28:16< Shiki> just pasted the wrong things 20161202 23:28:19 * tad_carlucci points at Pastebin 20161202 23:28:20< celticminstrel> vultraz: What were you talking about? 20161202 23:28:33< vultraz> celticminstrel: animations.back().unit_anim_.override(0,1,particule::UNSET,"0.4","",0,"","","~GS()"); 20161202 23:28:40< vultraz> override is a member function here 20161202 23:28:42< Shiki> tad_carlucci, pastbin is here too 20161202 23:28:56< vultraz> but my editor makes it look like the override keyword 20161202 23:28:58< celticminstrel> vultraz: I assume there's a good reason to call it that... 20161202 23:29:01< vultraz> which is confusing >_> 20161202 23:29:10< celticminstrel> What's confusing about it? 20161202 23:29:21< tad_carlucci> keyword as function name. 20161202 23:29:49< celticminstrel> override is not a keyword 20161202 23:29:54< celticminstrel> Nor is overrides 20161202 23:30:08< celticminstrel> Or final 20161202 23:30:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161202 23:30:35< celticminstrel> Personally I don't see why using a keyword as a member function name would be confusing though. 20161202 23:30:51< gfgtdf> vultraz: just rename it. 20161202 23:30:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20161202 23:30:55< vultraz> yes 20161202 23:31:00< vultraz> I'll get to that 20161202 23:31:02< celticminstrel> (If it was a non-member function name, then it would be confusing since a lot of keywords are used with a function-like syntax.) 20161202 23:31:09< vultraz> mostly I'm just cleaning up the abysmal formatting 20161202 23:31:12< celticminstrel> vultraz: What does the function do? 20161202 23:31:15< tad_carlucci> In addition to keywords, there are identifiers with special meaning, which may be used as names of objects or functions, but have special meaning in certain contexts. 20161202 23:31:15< tad_carlucci> override (C++11) 20161202 23:31:26< vultraz> NO idea 20161202 23:31:36< vultraz> no documentation 20161202 23:31:42< vultraz> hard to say from just looking at it 20161202 23:31:45< celticminstrel> Well if you're going to rename it you need to figure that out. If you can't figure that out, don't rename it. 20161202 23:31:55< tad_carlucci> So it's legal but I agree it's a bad idea 20161202 23:32:17< gfgtdf> the only reason why they a are now keywods if for complailty with older programs, beeing legal doesn't mean its good thing to do. 20161202 23:32:25< gfgtdf> s/now/not* 20161202 23:32:28< celticminstrel> I'd like it if some other C++ keywords were demoted to the contextual status. 20161202 23:32:33< celticminstrel> Particularly "default". 20161202 23:32:36-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev 20161202 23:32:37< travis-ci> wesnoth/wesnoth#12277 (master - 5729d3d : Jyrki Vesterinen): The build passed. 20161202 23:32:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180662951 20161202 23:32:37-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161202 23:32:54< celticminstrel> public/private/protected could probably also be demoted. 20161202 23:33:14-!- mjs-de [~mjs-de@x4db56609.dyn.telefonica.de] has quit [Remote host closed the connection] 20161202 23:34:06< vultraz> much a mess, this code is 20161202 23:34:42< tad_carlucci> You're looking in ~wesnoth/src you gotta expect that :P 20161202 23:35:12< vultraz> indeed >_> 20161202 23:38:53< vultraz> looks like a lot of animation effects are hardcoded 20161202 23:41:11< celticminstrel> Yeah, probably. Several animations have built-in defaults. 20161202 23:41:56< celticminstrel> ...you know, it might be possible to remove all the teleport animation frames and use ~ADJUST_ALPHA()... 20161202 23:42:20< gfgtdf> Shiki: i asume you start the campaign via the mp mode ? 20161202 23:42:29< gfgtdf> Shiki: hmm wi tno 20161202 23:42:57< celticminstrel> Something like ~ADJUST_ALPHA(y < x, 255, 0), except with some coefficient. Also might need to be > rather than <, not sure. 20161202 23:43:03< gfgtdf> Shiki: i wonder what "era" in campaign actuall means? Afaik you specif an era in a sp campaign. 20161202 23:43:05< Shiki> no. sp campaign. it then sources a file in the era, which sources the era 20161202 23:43:17< celticminstrel> I forgot to wrap that in an if(). 20161202 23:43:34< vultraz> ccharrrs 20161202 23:45:21< Shiki> gfgtdf, actually it's nowhere officially called era. you must source the unit files etc to have them availaible in the campaign 20161202 23:45:22< tad_carlucci> Not been watching shiki's comments but I recall yesterday when testing his GNA bug I used the 1.12 version of something which had been updated and got a mess of errors as a result. It went a lot better when I updated to the 1.13 for the requisite and only used the 1.12 for the campaign exhibiting the bug which he's updating. 20161202 23:47:18< gfgtdf> Shiki: ok please tr< adding a if(!state.valid()) { throw config::error(""); } at src/game_initialization/mp_game_utils.cpp line 62 20161202 23:49:02< gfgtdf> try* 20161202 23:51:19< Shiki> gfgtdf, wesnoth-exits after the ingame message as usual, but i get no coredump 20161202 23:52:16< Shiki> seems it exists at that line 62 20161202 23:52:57-!- Appleman1234 [~Appleman1@KD106161199053.au-net.ne.jp] has joined #wesnoth-dev 20161202 23:55:13< gfgtdf> Shiki: hmm then we shodul add catch for that exception here https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/title_screen.cpp#L321 20161202 23:55:48< zookeeper> ok, so, i guess i'll merge the macro arguments PR? 20161202 23:56:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20161202 23:56:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161202 23:58:26< irker734> wesnoth: Shiki wesnoth:master 41938189e1f9 / data/core/units/elves/ (Avenger.cfg Ranger.cfg): un-cut the bow of the female ranger/avenger (#892) https://github.com/wesnoth/wesnoth/commit/41938189e1f91272e55028e71af991b046ca6348 --- Log closed Sat Dec 03 00:00:18 2016