--- Log opened Sat Dec 03 00:00:18 2016
20161203 00:00:39< irker734> wesnoth: Adrian Heine né Lang wesnoth:master 663fde109ae3 / data/campaigns/Under_the_Burning_Suns/scenarios/01_The_Morning_After.cfg: UtbS S1: Fix objectives if Necro appears early (#891) https://github.com/wesnoth/wesnoth/commit/663fde109ae3567b4f7a4bb71e63c894989c0a1d
20161203 00:00:46< celticminstrel> I have no objections, zookeepe. vultraz, gfgtdf?
20161203 00:00:51< celticminstrel> ^ zookeeper 
20161203 00:00:56< vultraz> no objections
20161203 00:01:11< vultraz> much as I wish we would move away from the preprocessor 
20161203 00:01:16< tad_carlucci> zookeeper, My only comment is that Travis didn't pass.
20161203 00:01:46< celticminstrel> tad_carlucci: Could that be simply because it came at a time that Travis was failing in master?
20161203 00:01:49 * celticminstrel hasn't looked.
20161203 00:02:20< tad_carlucci> celticminstrel, probably so. And today's not a good day to re-push what this the travis crash and the backlog resulting from that.
20161203 00:02:43< tad_carlucci> s/what this/what with/
20161203 00:03:08< celticminstrel> The backlog doesn't look too bad now though... before zookeeper's merges there were three builds pending.
20161203 00:03:20< celticminstrel> Three master builds... probably one or two PR builds too.
20161203 00:03:32< Shiki> gfgtdf, how exactly?
20161203 00:03:41< tad_carlucci> Yeah. The travis ppl said they're pushing the OS/x backlog as fast as possible.
20161203 00:04:08< celticminstrel> Oh, is it just OSX holding things up?
20161203 00:04:53< tad_carlucci> celticminstrel, OS/x was the main effect. They promise a post-mortem in a few days.
20161203 00:06:43< gfgtdf> Shiki: like in http://pastebin.com/q4takh5Y
20161203 00:07:00< gfgtdf> zookeeper: no obvections.
20161203 00:07:30< vultraz> tfw you forget how functions work and try to declare a static std::function >_>
20161203 00:08:13< vultraz> c++ isn't functional enough.
20161203 00:10:52< Shiki> gfgtdf, oh, hey, yeah. I come back to the title screen after the error message now.
20161203 00:13:15< celticminstrel> vultraz: What are you talking about?
20161203 00:20:03< tad_carlucci> Yes, finally. I just need to pretty up some commits and I'll have VC14 compiling 0 errors, 0 warnings for both Debug and Release.
20161203 00:24:45-!- iceiceice [~chris@50-245-222-235-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20161203 00:24:45-!- iceiceice [~chris@50-245-222-235-static.hfc.comcastbusiness.net] has quit [Changing host]
20161203 00:24:45-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161203 00:26:42< vultraz> celticminstrel: i was trying to declare a static std::function variable instead of just declaring an actual static function
20161203 00:28:41-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20161203 00:28:42< travis-ci> gfgtdf/wesnoth-old#701 (master - 9961d27 : gfgtdf): The build has errored.
20161203 00:28:42< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/180816604
20161203 00:28:42-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20161203 00:28:52< celticminstrel> Technically possible if you use lambda syntax, I guess... but don't do that.
20161203 00:37:01< zookeeper> well, i guess i'll merge my PR the next time i actually have time to start making use of it... which is not tonight
20161203 00:43:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 00:43:09< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Adrian Heine n, Lang 663fde1: UtbS S1: Fix objectives if Necro appears early (#891) Succeeded
20161203 00:43:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-8
20161203 00:43:09< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/663fde109ae3567b4f7a4bb71e63c894989c0a1d
20161203 00:43:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 00:44:55< matthiaskrgr> woot
20161203 00:44:57< matthiaskrgr> nice
20161203 00:46:21< celticminstrel> Formatting nice too?
20161203 00:46:29< celticminstrel> Should there be less bold?
20161203 00:46:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161203 00:48:59< gfgtdf> Shiki: if it fixes t feel free to commit
20161203 00:49:47< Shiki> gfgtdf, the story not finished ... :/
20161203 00:49:59< gfgtdf> hmm
20161203 00:50:34< Shiki> it's different if i don't delete my cache before i start wesnoth
20161203 00:51:03< gfgtdf> hwo exactly different?
20161203 00:51:06< gfgtdf> how*
20161203 00:51:44< Shiki> or, if i click the campaign, get thrown back to title screen and sagain to campaigns... then it's not listed anymore. but if i start then another one and exit it and go again to campaigns, it's there again
20161203 00:53:17< Shiki> or... lets say i use a send campaign which uses this era too, and try to start first the one, then the other one.... behavior is strange, it's not everytime the same message
20161203 00:53:53< Shiki> I think I best upload this to the addonserver you can try it
20161203 00:54:01< gfgtdf> Shiki: hmm i remember similar issues even in 1.12 iirc.
20161203 00:56:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161203 00:57:26< gfgtdf> Shiki: when i played the game i always thought this intntional (like the game is 'thinking': "after we failed the start this campaign lets remove it from the list since it unplayable ") , but now i'd just guess  this is likeley just a side effect of some other maechanic.
20161203 00:59:28-!- Appleman1234 [~Appleman1@KD106161199053.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20161203 01:01:53< Shiki> gfgtdf, but why is it getting added again? and i do get two kind of error messages, and somehow I didn't figure it completely out
20161203 01:02:51-!- Appleman1234 [~Appleman1@KD106161214209.au-net.ne.jp] has joined #wesnoth-dev
20161203 01:05:12< Shiki> gfgtdf, can you download this and save it as Era_of_Myths. I can't upload it to the add-on server, there seems to be a space in a filename or sth like that: https://github.com/sevu/EoM
20161203 01:05:36< Shiki> gfgtdf, the campaigns War of the Dragon and Count Kromire are on the add-on server
20161203 01:07:08-!- Appleman1234_ [~Appleman1@KD106161210008.au-net.ne.jp] has joined #wesnoth-dev
20161203 01:07:55-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 01:07:55< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Adrian Heine n, Lang 663fde1: UtbS S1: Fix objectives if Necro appears early (#891) Succeeded
20161203 01:07:55< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-8
20161203 01:07:55< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/663fde109ae3567b4f7a4bb71e63c894989c0a1d
20161203 01:08:00-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 01:08:14-!- Appleman1234 [~Appleman1@KD106161214209.au-net.ne.jp] has quit [Disconnected by services]
20161203 01:08:18-!- Appleman1234_ is now known as Appleman1234
20161203 01:09:04< Shiki> gfgtdf, I just pushed again, so the addon will be broken
20161203 01:09:27< Shiki> gfgtdf, maybe empty your cache, and then start clicking the one and other campaign of the two
20161203 01:26:25< Shiki> I see, in 1.12 it's similar
20161203 01:29:54-!- travis-ci [~travis-ci@ec2-54-166-88-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20161203 01:29:55< travis-ci> wesnoth/wesnoth#12279 (master - 57f13b8 : Celtic Minstrel): The build passed.
20161203 01:29:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180788760
20161203 01:29:55-!- travis-ci [~travis-ci@ec2-54-166-88-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20161203 01:36:13< EliDupree> Does every get_global_variable now block until it receives feedback from every other player?
20161203 01:37:44< EliDupree> And does synchronize_choice behave the same way? I'm definitely glad it's now POSSIBLE to get network input from players who aren't the current player, but it seems that this has also made the feature worse when you ARE only doing it for the current player.
20161203 01:37:45-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 01:38:22< EliDupree> (1.12, Although I'm also curious if it has changed in 1.13)
20161203 01:40:19-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has joined #wesnoth-dev
20161203 01:40:53-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 01:40:53< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Adrian Heine n, Lang 663fde1: UtbS S1: Fix objectives if Necro appears early (#891) Succeeded
20161203 01:40:53< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-9
20161203 01:40:53< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/663fde109ae3567b4f7a4bb71e63c894989c0a1d
20161203 01:40:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 01:47:16< gfgtdf> EliDupree: [get_global_variable] uss someting liek sync_chocie internally, and no ir onyl wait for feedback form that side that gets the varaible from
20161203 01:47:25< gfgtdf> s/ir/it
20161203 01:47:47< EliDupree> odd
20161203 01:47:58< gfgtdf> EliDupree: how is that odd ?
20161203 01:48:19< EliDupree> Maybe somewhere in my code is actually requesting variables from players I don't realize it is
20161203 01:50:57< gfgtdf> EliDupree: in 1.12 get_global_variable is the only was to get varaibles or user input from anther player
20161203 01:51:26< gfgtdf> EliDupree: and if you omit the side= atribute it shoudl always default to the currently playing side,
20161203 01:53:01< EliDupree> Well, I have a case where the player 2's turn doesn't start until player 3 leaves a menu, and as far as I can tell, I'm not using get_global_variable at all (I disabled it for testing)
20161203 01:53:39< EliDupree> Wait, no, I have evidence that it is still being used, so I need to do more debugging
20161203 01:55:46-!- RatArmy [~ratarmy@om126204192126.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 01:58:48< EliDupree> Okay, problem solved
20161203 02:04:50-!- RatArmy [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 02:05:45-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 02:05:46< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Adrian Heine n, Lang 663fde1: UtbS S1: Fix objectives if Necro appears early (#891) Succeeded
20161203 02:05:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-9
20161203 02:05:46< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/663fde109ae3567b4f7a4bb71e63c894989c0a1d
20161203 02:05:49-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 02:09:13-!- gfgtdf_ [~chatzilla@x4e363546.dyn.telefonica.de] has joined #wesnoth-dev
20161203 02:11:17-!- gfgtdf [~chatzilla@x4e368823.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161203 02:11:23-!- gfgtdf_ is now known as gfgtdf
20161203 02:16:59< vultraz> 		if(anim["offset"].empty()) {
20161203 02:17:01< vultraz> 			anim["offset"] = "0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,0~1:200,";
20161203 02:17:02< vultraz> 		}
20161203 02:17:04< vultraz> whyy
20161203 02:17:05< vultraz> is this repeated
20161203 02:17:07< vultraz> so many times
20161203 02:18:11< vultraz> 35 times, to be exact
20161203 02:20:41< vultraz> celticminstrel: thoughts?
20161203 02:25:07< gfgtdf> vultraz: you think it shodul be less ?
20161203 02:25:35< celticminstrel> What is that for?
20161203 02:27:15< gfgtdf> vultraz: you can try replacing them with a BOOST_PP_REPEAT("0~1:200,", 35) not sure it works
20161203 02:27:42-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 268 seconds]
20161203 02:28:58-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20161203 02:28:59< travis-ci> wesnoth/wesnoth#12281 (master - 6d70407 : Charles Dang): The build has errored.
20161203 02:29:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180822221
20161203 02:29:00-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20161203 02:29:23< gfgtdf> Shiki: sry wont have time to think about it more today.
20161203 02:32:10< Shiki> gfgtdf, no problem. I commited it, in one of the files is a TODO left, which seems to be the part which is different about 1.12
20161203 02:33:45< vultraz> celticminstrel: some default offset value in anims
20161203 02:33:59< vultraz> why the hell is it this weird value repeated 35 times
20161203 02:35:20< celticminstrel> What I asked "what is that for" I meant "which animation".
20161203 02:35:29< celticminstrel> I can't guess why it is what it is without that info.
20161203 02:37:16< vultraz> movement_anim
20161203 02:37:52< celticminstrel> Oh.
20161203 02:38:08< celticminstrel> IIRC, the unit stays in each hex for 200 ticks.
20161203 02:38:20< celticminstrel> So the offset's reference is reset every 200 ticks.
20161203 02:38:26< celticminstrel> Thus requiring that sort of thing.
20161203 02:39:20< celticminstrel> I wonder if "0~1:200*35" or similar would work... probably not. Might be an idea to make it possible though.
20161203 02:39:47< gfgtdf> vultraz: you can use git blame to find out why it was commited liek that.
20161203 02:39:58< celticminstrel> Could also check if it's truly necessary, or somehow calculate from the animation just how many repetitions are required.
20161203 02:41:27< vultraz> this file is way too big
20161203 02:41:57< gfgtdf> vultraz: https://github.com/wesnoth/wesnoth/commit/e7ca8e2e08a25fba354e64d181a0e35b7dd501a8
20161203 02:42:35< vultraz> . . .
20161203 02:42:40< vultraz> brilliant bugfix...
20161203 02:43:04< celticminstrel> I do think using BOOST_PP_REPEAT would've been better.
20161203 02:43:17< celticminstrel> It's convenient how C/C++ automatically concatenates adjacent string literals.
20161203 02:43:19< vultraz> what is BOOST_PP_REPEAT
20161203 02:43:50< celticminstrel> BOOST_PP_* are macros defined by Boost.Preprocessor.
20161203 02:44:09< gfgtdf> i doubt the autor knew about BOOST_PP
20161203 02:44:14< celticminstrel> Looks like BOOST_PP_REPEAT doesn't work that way though.
20161203 02:44:56< celticminstrel> But you could probably still use it somehow.
20161203 02:45:45< celticminstrel> What BOOST_PP_REPEAT does is invoke a macro a specified number of times.
20161203 02:46:07< celticminstrel> So if you had a #define ONCE() "0~1:200"
20161203 02:46:21< celticminstrel> Then you could write BOOST_PP_REPEAT(35, ONCE, )
20161203 02:46:24< celticminstrel> I think.
20161203 02:46:40< celticminstrel> And it'd be equivalent to ONCE() ONCE() ONCE() ... 35 times.
20161203 02:52:21-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 248 seconds]
20161203 02:56:39-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20161203 03:02:34-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161203 03:03:33-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161203 03:03:54-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161203 03:15:49-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 03:17:57-!- RatArmy [~ratarmy@133.15.175.65] has quit [Ping timeout: 265 seconds]
20161203 03:17:58-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 03:21:32-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 03:22:22-!- RatArmy [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 03:22:27-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 03:33:29< vultraz> what is.. INT_MAX
20161203 03:33:36< vultraz> and why is it being used here
20161203 03:36:45< tad_carlucci> INT_MAX is the largest value which can by stored in an 'int' .. generally (2^31 - 1) or (2^63 - 1)
20161203 03:37:09< vultraz> I see
20161203 03:38:06< vultraz> looks like it's being used in std::min here p_p
20161203 03:39:24< tad_carlucci> Um .. ok. Not a very good idea, but I guess.
20161203 03:40:08< tad_carlucci> Nah .. actually a very bad idea .. rewrite it and make the std::min and int_max go away
20161203 03:40:11< vultraz> and here's a use of INT_MIN
20161203 03:41:00< tad_carlucci> Same idea.  Max negative.  -(2^31) or -(2^63)
20161203 03:41:38< vultraz> right
20161203 03:41:47< vultraz> i just find it odd this code would expect a value to get that large
20161203 03:42:16< tad_carlucci> If it's trying to ensure an int is not overflowing using std:min or std::max it's lame and SCREAMING to be rewritten because it can't possibly do what it wants.
20161203 03:42:50-!- RatArmy [~ratarmy@133.15.175.65] has quit [Ping timeout: 250 seconds]
20161203 03:43:26< vultraz> starting_frame_time_ = INT_MAX;
20161203 03:43:31< vultraz> 	if(!range.empty() && cfg[frame_string + "start_time"].empty()) {
20161203 03:43:32< vultraz> 		for(const config& frame : range) {
20161203 03:43:33< tad_carlucci> Maybe, if it's using std::max<long long> and int is long or short it MIGHT work
20161203 03:43:34< vultraz> 			starting_frame_time_ = std::min(starting_frame_time_, frame["begin"].to_int());
20161203 03:43:53< vultraz> same concept
20161203 03:43:54< vultraz> begin_time = std::min<int>(begin_time, anim.animation->get_begin_time());
20161203 03:44:00< vultraz> (begin_time is initially INT_MAX)
20161203 03:44:16< tad_carlucci> initially or always?
20161203 03:44:40< vultraz> initially
20161203 03:45:31-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 03:45:36< tad_carlucci> Then it's saying, "The starting frame can never be INT_MAX because it's so large." And it is looking for the smallest starting frame number. Probably OK.
20161203 03:45:46-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 03:46:07-!- RatArmy [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 03:46:49< tad_carlucci> You could re-write it with some thinking but it may not be worth the effort.
20161203 03:47:19< vultraz> probably not
20161203 03:47:35< vultraz> this damn file is 1500 lines long anyway
20161203 03:47:40< vultraz> a lot could probably be rewritten :|
20161203 03:49:06< tad_carlucci> I'd start by asking if it could simply be broken down into smaller files.
20161203 03:51:06< vultraz> std::find(anim.event_.begin(), anim.event_.end(), std::string("default")
20161203 03:51:14< vultraz> whyyy >_>
20161203 03:52:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161203 03:53:22< tad_carlucci> Hey, one guess what sort of stuff I was reading when I decided to step away from the smart_list mess for a while ... at least your 1500 lines are all in one file and not smeared all over the place.
20161203 03:53:53< vultraz> why, what were you looking at
20161203 03:55:20< tad_carlucci> Three queues doing the job of one, badly.  References to weak pointers to pointers to structures. Maps of the above. Vectors of the above. The same function written 3 or 4 times, slightly differently, none correctly.
20161203 03:56:08< vultraz> how fun!
20161203 03:57:49< tad_carlucci> I gave up one night and wrote a proof-of-concept project from scratch in 4 hours which does what I **think** was intended. But proving I understand it to be sure I have it right?  I need another mega-bottle of ibuprofen before I start THAT!
20161203 04:00:01-!- gfgtdf [~chatzilla@x4e363546.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161203 04:01:02-!- gfgtdf [~chatzilla@x4e363546.dyn.telefonica.de] has joined #wesnoth-dev
20161203 04:01:13< vultraz> as long as it works :P
20161203 04:02:34< vultraz> ya know, i sometimes wonder if the people who worked on early wesnoth just gave 0 fucks about formatting
20161203 04:04:17< vultraz> actually, not even 0 fucks
20161203 04:04:20< vultraz> negative fucks
20161203 04:05:10-!- irker734 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161203 04:05:47< vultraz> INT_MIN fucks
20161203 04:06:20< celticminstrel> Well, using INT_MAX in std::min makes sense if you think your type is larger than int but want to constrain it to the range of int... >_>
20161203 04:06:43< celticminstrel> Incidentally, INT_MAX and INT_MIN often function as ±∞
20161203 04:08:52-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20161203 04:08:53< travis-ci> wesnoth/wesnoth#12283 (master - 4356095 : Celtic Minstrel): The build passed.
20161203 04:08:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/180825286
20161203 04:08:53-!- travis-ci [~travis-ci@ec2-54-196-7-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20161203 04:08:55< tad_carlucci> But more often are simply there to cause a bug to lurk for ages until someone does something REALLY off-the-wall.
20161203 04:15:33-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161203 04:17:13-!- knotwork__ [~markm@99.192.95.6] has quit [Remote host closed the connection]
20161203 04:23:52-!- gfgtdf [~chatzilla@x4e363546.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161203 04:31:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161203 04:46:41-!- RatArmy [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20161203 04:47:34-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 04:48:03-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 04:48:10-!- RatArmy [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 05:30:01-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 05:30:01-!- RatArmy [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161203 05:32:18-!- RatArmy_ [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 05:33:53-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 05:36:01-!- RatArmy_ is now known as RatArmy
20161203 05:57:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 06:06:07-!- RatArmy [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20161203 06:13:01-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 06:13:35-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161203 06:13:36-!- RatArmy [~ratarmy@om126212248228.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 06:15:53< vultraz> what is a... particule
20161203 06:16:48< vultraz> google tells me it's... french?
20161203 06:23:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20161203 06:25:44< celticminstrel> Probable "particle" is the intended meaning.
20161203 06:30:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161203 06:33:10-!- JyrkiVesterinen [~JyrkiVest@87-100-177-85.bb.dnainternet.fi] has joined #wesnoth-dev
20161203 06:44:38-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 245 seconds]
20161203 06:45:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161203 06:45:05-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161203 06:49:15-!- irker631 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161203 06:49:15< irker631> wesnoth: Charles Dang wesnoth:master 82a879725c88 / src/units/ (animation.cpp animation.hpp): Cleaned up unit animation code https://github.com/wesnoth/wesnoth/commit/82a879725c8882cd1e4b2171af2a49eb33cbefe0
20161203 06:49:17< vultraz> no git blame for you!
20161203 06:51:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161203 06:56:16< vultraz> at some point I'd still like to refactor out the intrusive_ptr in the unit map
20161203 06:56:26< vultraz> replace it with a shared_ptr
20161203 07:02:15< celticminstrel> Please don't bother.
20161203 07:02:27< vultraz> why not?
20161203 07:03:51< celticminstrel> ...
20161203 07:03:53< celticminstrel> ...
20161203 07:03:55< celticminstrel> ...
20161203 07:04:11< vultraz> no, really, if I want to waste time on a pointless task, why should I not :P
20161203 07:04:31< celticminstrel> Oh my stars, with std::enable_shared_from_this you can set it up so that &obj returns a shared_ptr O_O
20161203 07:04:44< vultraz> what?
20161203 07:04:55< celticminstrel> http://stackoverflow.com/a/712307/1502810
20161203 07:05:09< celticminstrel> If instead of f() you call that function operator&
20161203 07:05:32< celticminstrel> (Just to clarify, the ellipses were not about your "why not?".)
20161203 07:05:37< irker631> wesnoth: Charles Dang wesnoth:master bcd51524bdee / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: clear a variable instead of re-declaring it https://github.com/wesnoth/wesnoth/commit/bcd51524bdeeb76267ade0bbfc5cd98e66acd21e
20161203 07:05:46< vultraz> oh
20161203 07:05:49< celticminstrel> Note that I'm not recommending this. One should never recommend overloading unary operator&.
20161203 07:05:57< vultraz> is enable_shared_from_this useful?
20161203 07:06:29< celticminstrel> Well, I don't think you could do away with the intrusive_ptr without using it.
20161203 07:07:42< celticminstrel> To answer your question, the reason I don't think removing intrusive_ptr is a good idea is because it's quite difficult to know when a unit is no longer needed. A unit could get passed into Lua and then removed from the map, and now Lua has the sole reference to that unit.
20161203 07:08:29< celticminstrel> Still, if you used enable_shared_from_this, maybe you could do it.
20161203 07:09:02< vultraz> it's something I'd certainly like to work on, if only as a coding exercise 
20161203 07:09:10< vultraz> but I don't know if I understand the code well enough
20161203 07:11:08< vultraz> also oops
20161203 07:11:15< vultraz> i think i misread my own code in bcd51524bdee 
20161203 07:11:16< vultraz> :|
20161203 07:11:33< celticminstrel> A later answer in that SO thread actually recomments intrusive_ptr, heh.
20161203 07:11:59< vultraz> fuck
20161203 07:12:21< celticminstrel> How so? It looks fine at a glance.
20161203 07:12:29< celticminstrel> Oh wait.
20161203 07:13:03< celticminstrel> Yeah okay, I see what you mean; however, I think it would be fine if line 167 were instead before the if?
20161203 07:13:27< vultraz> no, it needs to be after
20161203 07:13:35< celticminstrel> What if it were in an else?
20161203 07:14:06< celticminstrel> But yeah, if neither of those work, then your commit completely changes what it's doing.
20161203 07:14:13< vultraz> no, it really needs to be after
20161203 07:14:15< celticminstrel> Well okay, it does completely change it anyway.
20161203 07:14:48< vultraz> the conditional adds the member to the map if it doesn't exist yet
20161203 07:14:53< vultraz> then the line after fetches that member
20161203 07:16:16< irker631> wesnoth: Charles Dang wesnoth:master 87227575831f / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: revert bcd51524bdee https://github.com/wesnoth/wesnoth/commit/87227575831f6fa7f774912e4cab0ee7444c6cc2
20161203 07:17:54< celticminstrel> Apparently enable_shared_from_this is a little unsafe.
20161203 07:18:02< vultraz> unsafe?
20161203 07:18:28< celticminstrel> Specifically, the shared_from_this() function that it adds to your class (since you inherit from it) assumes that a shared_ptr to your class has already been created.
20161203 07:21:22< vultraz> that seems like oversight :/
20161203 07:22:25-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161203 07:22:41< celticminstrel> Hmmm... some of the pages I was reading were talking about the Boost version, but now I'm reading something that says it throws an exception instead.
20161203 07:22:43< vultraz> I did try to get rid of that intrusive_ptr once, ftr
20161203 07:22:53< vultraz> but I failed because I didn't know what I was doing
20161203 07:22:55< celticminstrel> So maybe the unsafeness is no longer the case.
20161203 07:23:23< celticminstrel> I really don't think it's worth getting rid of the intrusive_ptr though.
20161203 07:23:46< celticminstrel> I don't understand why you dislike the intrusive_ptr so much.
20161203 07:24:18< vultraz> I'm trying to remove boost stuff when possible
20161203 07:24:27< vultraz> and as I said
20161203 07:24:31< vultraz> good coding exercise
20161203 07:24:39< celticminstrel> But it's not like we'll ever remove boost entirely.
20161203 07:24:44< vultraz> no
20161203 07:24:48< vultraz> but the way I look at it
20161203 07:24:54< vultraz> stl > boost > custom impl
20161203 07:25:12< vultraz> ie, if something is in the stl that we're using boost for, we should use the stl version
20161203 07:25:18< celticminstrel> Well, intrusive_ptr is not the same as shared_ptr, so I don't really see how that ordering applies.
20161203 07:25:23< vultraz> if we have a custom impl that we could use boost for, use boost
20161203 07:27:23< vultraz> celticminstrel: difference by how much>
20161203 07:27:25< vultraz> ?
20161203 07:27:52< celticminstrel> It's safe to construct an intrusive_ptr from a raw pointer. It's not safe to construct a shared_ptr from a raw pointer.
20161203 07:28:52< vultraz> do we need to construct a shared_ptr from a raw pointer?
20161203 07:29:05< vultraz> especially if we have enable_shared_from_this>
20161203 07:29:12< celticminstrel> I have no idea.
20161203 07:29:30< celticminstrel> enable_shared_from_this does solve the same problem that intrusive_ptr does though in a totally different way.
20161203 07:33:29< vultraz> i assume it would be the unit class that inherits?
20161203 07:39:07-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161203 07:42:13-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161203 07:43:22-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161203 07:43:58-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161203 07:50:10-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20161203 07:50:34-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161203 07:53:11-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161203 07:57:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 240 seconds]
20161203 08:13:39-!- RatArmy_ [~ratarmy@om126237116138.9.openmobile.ne.jp] has joined #wesnoth-dev
20161203 08:16:17-!- RatArmy_ [~ratarmy@om126237116138.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 08:17:28-!- RatArmy_ [~ratarmy@om126237116138.9.openmobile.ne.jp] has joined #wesnoth-dev
20161203 08:22:00-!- RatArmy_ [~ratarmy@om126237116138.9.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20161203 08:22:34-!- RatArmy_ [~ratarmy@om126204196139.6.openmobile.ne.jp] has joined #wesnoth-dev
20161203 08:31:26-!- RatArmy_ [~ratarmy@om126204196139.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 08:39:45-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 08:39:45< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 8722757: MP Staging: revert bcd51524bdee Failed
20161203 08:39:45< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-9
20161203 08:39:45< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87227575831f6fa7f774912e4cab0ee7444c6cc2
20161203 08:39:50-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 08:43:25< celticminstrel> Uh-oh.
20161203 08:45:04< celticminstrel> I'd guess unit animation cleanup is the most likely culprit.
20161203 08:45:16< celticminstrel> (Which reminds me, what happened to that tag manager thing at the top of the file?)
20161203 08:45:41-!- RatArmy_ [~ratarmy@om126204196139.6.openmobile.ne.jp] has joined #wesnoth-dev
20161203 08:46:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161203 09:02:04-!- RatArmy_ [~ratarmy@om126204196139.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 09:05:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 09:05:10< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 8722757: MP Staging: revert bcd51524bdee Succeeded
20161203 09:05:10< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-9
20161203 09:05:10< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87227575831f6fa7f774912e4cab0ee7444c6cc2
20161203 09:05:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 09:06:11< celticminstrel> Interesting...
20161203 09:06:49-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161203 09:09:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161203 09:10:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Client Quit]
20161203 09:26:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161203 09:36:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 09:36:05< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 8722757: MP Staging: revert bcd51524bdee Succeeded
20161203 09:36:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-10
20161203 09:36:05< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87227575831f6fa7f774912e4cab0ee7444c6cc2
20161203 09:36:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 09:54:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 09:57:21-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 09:59:07< zookeeper> vultraz, celticminstrel, considering boucman is french i'm pretty sure it isn't just a typo of "particle" :p
20161203 09:59:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 09:59:43< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 8722757: MP Staging: revert bcd51524bdee Succeeded
20161203 09:59:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-10
20161203 09:59:43< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87227575831f6fa7f774912e4cab0ee7444c6cc2
20161203 09:59:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 09:59:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 240 seconds]
20161203 10:08:35< Nikitaw99> whats exactly appveyor?
20161203 10:08:38< Nikitaw99> the service
20161203 10:09:59-!- Kwandulin [~Miranda@p200300760F6EBF50348DFBEBC24CCD71.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161203 10:16:51-!- irker631 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161203 10:21:14-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161203 10:21:41-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 10:44:56< JyrkiVesterinen> Nikitaw99: As the AppVeyor website says, AppVeyor is a Continuos Integration service for Windows.
20161203 10:44:57< JyrkiVesterinen> https://www.appveyor.com/
20161203 10:45:26< JyrkiVesterinen> It's useful mainly because Microsoft Visual Studio 2013 is the most restrictive compiler we support.
20161203 10:45:28< Nikitaw99> whats the difference between travis ci and appveyor?
20161203 10:46:04< JyrkiVesterinen> AppVeyor will now automatically let us know if someone accidentally commits code that VS2013 can't compile.
20161203 10:46:33< JyrkiVesterinen> The difference is the host operating system. Travis CI supports GNU/Linux and macOS whereas AppVeyor runs Windows.
20161203 10:53:34< vultraz> hmm
20161203 10:53:50< vultraz> so, it seems the refcounts control whether a unit is in the unit_map
20161203 10:54:42-!- mjs-de [~mjs-de@x4db56609.dyn.telefonica.de] has joined #wesnoth-dev
20161203 10:54:48< vultraz> yeah, for this, i should consult iceiceice
20161203 10:55:12< Nikitaw99> where can i get visual studio?
20161203 10:55:40< Nikitaw99> i dont wanna wait like a whole day to install 15GB for visual studio 2015 community....
20161203 10:55:48< Nikitaw99> my internet cant handle it
20161203 10:55:51< vultraz> that's visual studio :)
20161203 10:56:20< Nikitaw99> ;-;
20161203 10:56:29< Nikitaw99> i really wanna get visual studio
20161203 10:56:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 10:57:00< vultraz> I don't think it;'s 15 GB to download
20161203 10:57:28-!- irker636 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161203 10:57:28< irker636> wesnoth: Charles Dang wesnoth:master 05479c4379e4 / src/units/ (animation.cpp animation.hpp): Renamed class "particule" to "particle" https://github.com/wesnoth/wesnoth/commit/05479c4379e49c061150416bdd0e752c3cfcce71
20161203 11:01:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 258 seconds]
20161203 11:01:54< vultraz> eh
20161203 11:01:57< vultraz>  /** Default implementation, but defined out-of-line for efficiency reasons. */
20161203 11:02:05< vultraz> it's an empty dtor
20161203 11:02:11< vultraz> how is that efficient 
20161203 11:02:22< vultraz> well, more efficient than not having one at all
20161203 11:05:08< JyrkiVesterinen> Indeed. As far as I know, there isn't any efficiency difference between an explicitly defined empty destructor and the automatically generated default destructor.
20161203 11:18:38< Nikitaw99> vultraz, http://i.imgur.com/Mf80i8P.png default installation
20161203 11:18:57< Nikitaw99> 8gb
20161203 11:20:11< Nikitaw99> and it's without the features i need
20161203 11:20:46< Nikitaw99> http://i.imgur.com/1oVMoHS.png custom with some features i would like
20161203 11:21:02< vultraz> I think that's disk space
20161203 11:21:04< vultraz> not download size
20161203 11:21:23< Nikitaw99> wha
20161203 11:21:24< Nikitaw99> still
20161203 11:21:30< Nikitaw99> thats too much for my internet
20161203 11:23:49< Nikitaw99> where can i get visual studio 2013, though?
20161203 11:24:06< vultraz> dunno if you still can
20161203 11:24:12-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 246 seconds]
20161203 11:24:19< vultraz> and it's unlikely to be much smaller
20161203 11:27:58< Nikitaw99> http://i.imgur.com/GXQELBr.png
20161203 11:31:24-!- JyrkiVesterinen [~JyrkiVest@87-100-177-85.bb.dnainternet.fi] has quit [Quit: Going somewhere]
20161203 11:41:02-!- RatArmy_ [~ratarmy@om126211121040.13.openmobile.ne.jp] has joined #wesnoth-dev
20161203 11:57:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 12:01:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 245 seconds]
20161203 12:18:53-!- Kwandulin [~Miranda@p200300760F6EBF50348DFBEBC24CCD71.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161203 12:58:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 12:59:35-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161203 13:02:41-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 258 seconds]
20161203 13:04:59-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161203 13:06:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161203 13:06:54< irker636> wesnoth: Charles Dang wesnoth:master 44f8d2e5393b / src/ (6 files in 3 dirs): Convert a few more things to use color_t https://github.com/wesnoth/wesnoth/commit/44f8d2e5393b69c079168bbd0e51ec7c07a7fb8b
20161203 13:11:13-!- RatArmy_ [~ratarmy@om126211121040.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 13:12:48< irker636> wesnoth: Charles Dang wesnoth:master cc5071f2e9a8 / src/game_config.cpp: Game Config: fixup color_info not parsing the color range correctly https://github.com/wesnoth/wesnoth/commit/cc5071f2e9a8c1edb2f4aeff46af7e51da42c135
20161203 13:24:19< vultraz> huh
20161203 13:26:05< vultraz> interesting, this is
20161203 13:27:40< vultraz> so, game_config::tc_info is passed palette names... "magenta", "flag_green", etc..
20161203 13:27:58< vultraz> but it seems both my impl and the old one were in error when it comes to the fallback
20161203 13:28:02< vultraz> I call from_hex_string
20161203 13:28:05< vultraz> which is wrong
20161203 13:28:14< vultraz> and the old one called string2rgb.. which also parsed a coloe
20161203 13:28:16< vultraz> color
20161203 13:59:45-!- Nobun [~nobun@host14-22-dynamic.5-87-r.retail.telecomitalia.it] has joined #wesnoth-dev
20161203 14:15:00-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161203 14:19:34-!- Nobun [~nobun@host14-22-dynamic.5-87-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20161203 14:19:42< Nikitaw99> http://i.imgur.com/hx0VJMJ.png
20161203 14:59:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 15:04:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 258 seconds]
20161203 15:04:28< Nikitaw99> ffffffun
20161203 15:08:44< Nikitaw99> my internet connection is being an asshole yet again
20161203 15:56:20-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161203 16:00:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 16:05:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 258 seconds]
20161203 16:08:39-!- louis94 [~~louis94@91.178.240.25] has joined #wesnoth-dev
20161203 16:12:54-!- irker636 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161203 16:18:05-!- mjs-de [~mjs-de@x4db56609.dyn.telefonica.de] has quit [Remote host closed the connection]
20161203 16:22:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 16:27:42-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 16:27:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Ping timeout: 258 seconds]
20161203 16:38:25< EliDupree> Has anyone tried compiling Wesnoth with ASan? Would it be easy to do so? https://github.com/elidupree/EoHS/issues/56
20161203 16:40:50-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 16:40:51< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang cc5071f: Game Config: fixup color_info not parsing the color range correctly Failed
20161203 16:40:51< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-10
20161203 16:40:51< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/cc5071f2e9a8c1edb2f4aeff46af7e51da42c135
20161203 16:40:54-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 16:47:58< matthiaskrgr> EliDupree: yes, I reported numerous of issue found via asan already :P 
20161203 16:48:17< EliDupree> Nice. Want to investigate this one for me? :-P
20161203 16:48:40< matthiaskrgr> http://pastebin.com/TzRv74D1  
20161203 16:48:56< EliDupree> thanks
20161203 16:49:25< matthiaskrgr> mmh
20161203 16:51:28< matthiaskrgr> it's not on the campaign server?
20161203 16:52:02< matthiaskrgr> of 1.13.6 dev
20161203 16:53:46< EliDupree> Right, I'm only developing it for 1.12 currently
20161203 16:58:20< EliDupree> I have added a GitHub issue for EoHS to start supporting 1.13 :-P
20161203 16:59:28< EliDupree> afk
20161203 16:59:57-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161203 17:01:36-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 17:05:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 17:05:05< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang cc5071f: Game Config: fixup color_info not parsing the color range correctly Succeeded
20161203 17:05:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-10
20161203 17:05:05< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/cc5071f2e9a8c1edb2f4aeff46af7e51da42c135
20161203 17:05:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 17:10:28-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161203 17:11:03-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 17:11:58-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161203 17:14:30-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has joined #wesnoth-dev
20161203 17:37:28-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 17:37:28< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang cc5071f: Game Config: fixup color_info not parsing the color range correctly Succeeded
20161203 17:37:28< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-11
20161203 17:37:28< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/cc5071f2e9a8c1edb2f4aeff46af7e51da42c135
20161203 17:37:32-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 17:50:26< EliDupree> Building 1.12.6, I'm getting a linking error
20161203 17:50:27< EliDupree> CMakeFiles/wesnoth.dir/serialization/schema_validator.cpp.o: In function `boost::cpp_regex_traits<char>::transform_primary[abi:cxx11](char const*, char const*) const':
20161203 17:50:27< EliDupree> /usr/include/boost/regex/v4/cpp_regex_traits.hpp:965: undefined reference to `boost::re_detail::cpp_regex_traits_implementation<char>::transform_primary[abi:cxx11](char const*, char const*) const'
20161203 17:50:54< EliDupree> (I just checked and I'm sure I have libboost-regex installed)
20161203 17:53:58< EliDupree> following matthiaskrgr 's instructions
20161203 18:01:47-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161203 18:01:47< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang cc5071f: Game Config: fixup color_info not parsing the color range correctly Succeeded
20161203 18:01:47< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-11
20161203 18:01:47< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/cc5071f2e9a8c1edb2f4aeff46af7e51da42c135
20161203 18:01:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161203 18:20:39-!- Appleman1234 [~Appleman1@KD106161210008.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20161203 18:20:42-!- louis94 [~~louis94@91.178.240.25] has quit [Ping timeout: 246 seconds]
20161203 18:29:54-!- irker775 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161203 18:29:54< irker775> wesnoth: Lari Nieminen wesnoth:master 255dd6bfc32a / changelog src/serialization/preprocessor.cpp src/serialization/preprocessor.hpp: Implemented support for optional macro arguments https://github.com/wesnoth/wesnoth/commit/255dd6bfc32aafebdf6b83dd7ddc25ceb9dd7e86
20161203 18:42:02-!- gfgtdf [~chatzilla@x4e363546.dyn.telefonica.de] has joined #wesnoth-dev
20161203 18:43:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161203 19:02:05-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 260 seconds]
20161203 19:03:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20161203 19:04:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161203 19:28:51< celticminstrel> I like how that runes thread spiralled into linguistical discussions.
20161203 19:34:58-!- Appleman1234 [~Appleman1@KD106161210008.au-net.ne.jp] has joined #wesnoth-dev
20161203 19:47:01< DeFender1031> celticminstrel, link?
20161203 19:47:34< celticminstrel> https://forums.wesnoth.org/viewtopic.php?f=32&t=44805
20161203 19:48:43< celticminstrel> I wish Kitty's scripts would see more use, too...
20161203 19:48:49< celticminstrel> In mainline I mean.
20161203 19:49:11< celticminstrel> ISTR hearing that they were used in a couple places maybe... don't remember seeing it myself though...
20161203 19:51:19< vultraz> [19:45:15]	celticminstrel	(Which reminds me, what happened to that tag manager thing at the top of the file?)
20161203 19:51:22< vultraz> t'was unused
20161203 19:51:24< vultraz> and removed
20161203 19:51:55< celticminstrel> ...it was unused?
20161203 19:51:59< celticminstrel> Okay then, weird.
20161203 20:08:25< vultraz> I'm curious why attack_type is used with a vector of intrusive_ptrs
20161203 20:08:55< celticminstrel> So that attacks don't disappear if you remove them from Lua.
20161203 20:09:08< vultraz> eh?
20161203 20:09:21< vultraz> elaborate
20161203 20:09:38< celticminstrel> You can remove an attack in Lua by assigning nil to it IIRC.
20161203 20:10:20< vultraz> ok, but why would you want that to not remove the attack. 
20161203 20:10:24< celticminstrel> If you first save a reference to that attack though, it shouldn't disappear.
20161203 20:10:49< celticminstrel> You might want to remove an attack from one unit and give it to a different unit.
20161203 20:11:37< vultraz> I see
20161203 20:11:38< celticminstrel> (I think I made it copy attacks when adding them through Lua though, so as to avoid bizarre situations where changing one unit's attack attributes affects some other attack on the same or a different unit.)
20161203 20:12:02 * celticminstrel assumes that removing an attack from one unit and giving it to another is actually a pretty common use case.
20161203 20:12:27< vultraz> How would one keep a reference to an attack in lua :/ Lua doesn't have references.
20161203 20:12:40< celticminstrel> Yes it does.
20161203 20:12:51< vultraz> wait what
20161203 20:12:51< celticminstrel> Everything in Lua that is not a string, number, or boolean is a reference.
20161203 20:12:59< celticminstrel> (Oh, nil is not a reference either.)
20161203 20:13:11< celticminstrel> If you have a table or userdata, that's a reference.
20161203 20:13:12< vultraz> I see
20161203 20:13:20< vultraz> Know this, I did not.
20161203 20:14:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161203 20:17:55< vultraz> for some reason, the game will crash when loading any save that uses color attributes in something like [label]
20161203 20:18:08< vultraz> with "wrong number of components for RGB color" :/
20161203 20:18:15< celticminstrel> Fun!
20161203 20:18:42< celticminstrel> Do they have the right number of components?
20161203 20:18:53< vultraz> well, they initially worked
20161203 20:19:14< celticminstrel> I mean, if you open the save file in a text editor.
20161203 20:20:25< vultraz> color="155,155,155,255"
20161203 20:20:41< celticminstrel> So that's why.
20161203 20:20:45< vultraz> specify alpha, I did not..
20161203 20:21:01< vultraz> what's saving it as RGBA
20161203 20:21:05< celticminstrel> You probably used to_rgba_string instead of to_rgb_string somewhere.
20161203 20:21:21< vultraz> no, I use neither..
20161203 20:21:43< DeFender1031> celticminstrel, intersting
20161203 20:22:02< celticminstrel> :D
20161203 20:22:10< vultraz> ah!
20161203 20:22:17< vultraz> std::string terrain_label::cfg_color() const
20161203 20:22:25< vultraz> it...writes alpha
20161203 20:22:27< vultraz> why :/
20161203 20:22:46< vultraz> I assume we can do away with this
20161203 20:22:47< celticminstrel> No idea. Where's it called? It probably shouldn't write alpha.
20161203 20:23:04< vultraz> terrain_label::write
20161203 20:23:17< vultraz> I'm just going to call to_rgb_string here
20161203 20:25:36< vultraz> caught general exception
20161203 20:25:41< vultraz> stoul
20161203 20:25:43< vultraz> o-O
20161203 20:27:50-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161203 20:28:30< vultraz> the fuck
20161203 20:28:37< vultraz> now the color is...
20161203 20:28:43< vultraz> xFF
20161203 20:28:59< vultraz> to_*_string is broken!
20161203 20:30:23< celticminstrel> ???
20161203 20:30:43< vultraz> int cast is needed
20161203 20:30:58< celticminstrel> Ah, right. Oops.
20161203 20:31:05< celticminstrel> rgba would need it too then
20161203 20:37:16< irker775> wesnoth: Charles Dang wesnoth:master ae156cb3d1d8 / src/map/ (label.cpp label.hpp): Don't save [label] colors with alpha https://github.com/wesnoth/wesnoth/commit/ae156cb3d1d81407c1ba0d8069e1b43ea6a012e1
20161203 20:37:19< irker775> wesnoth: Charles Dang wesnoth:master 12254f4e1859 / src/color.cpp: color_t: fix to_rgb_string and to_rgba_string returning garbled data https://github.com/wesnoth/wesnoth/commit/12254f4e18592bb071767e679c8c69f0653ef800
20161203 20:49:41-!- Appleman1234 [~Appleman1@KD106161210008.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20161203 20:56:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161203 20:58:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 21:01:02-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161203 21:02:43-!- Nikitaw99 [~Nikitaw99@ppp85-140-1-33.pppoe.mtu-net.ru] has quit [Client Quit]
20161203 21:07:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161203 21:07:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161203 21:09:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161203 21:11:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 21:12:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161203 21:17:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 21:27:50< gfgtdf> Shiki: do you intent do implement the errormessage in the todo of your pr?
20161203 21:28:06< Shiki> gfgtdf, no
20161203 21:28:40< gfgtdf> ok
20161203 21:29:18< Shiki> gfgtdf, I can test things, but i can't write c++
20161203 21:31:31< gfgtdf> Shiki: should be as easly as gui2::show_error_message(game_.video(), e.what()); and in the line above insert a e beteeen te & and the )
20161203 21:34:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161203 21:40:15< Shiki> gfgtdf, looks like this https://unsee.cc/bosutedi/
20161203 21:41:02< gfgtdf> Shiki: hmm yes the actual messes is still missing but that code is correct
20161203 21:41:51< gfgtdf> Shiki: to add a actual message you ahve to change the line throw config::error(""); to throw config::error("<your erro message>");
20161203 21:52:05-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 22:06:07< vultraz> for the record, my local copy of wesnothd is linked with SDL
20161203 22:07:34< gfgtdf> vultraz: hmm mabyeyour projectfiles werent updated for the sdl rmeoval ?
20161203 22:07:37-!- Appleman1234 [~Appleman1@106.161.210.8] has joined #wesnoth-dev
20161203 22:07:55< vultraz> SDL2, that is
20161203 22:08:18-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 22:10:11< gfgtdf> vultraz: yes
20161203 22:25:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161203 22:25:48-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 22:28:47-!- mjs-de [~mjs-de@x5ce4bac4.dyn.telefonica.de] has joined #wesnoth-dev
20161203 22:43:13-!- mjs-de [~mjs-de@x5ce4bac4.dyn.telefonica.de] has quit [Remote host closed the connection]
20161203 22:57:21-!- celticminstrel is now known as celmin|away
20161203 23:19:33-!- louis94 [~~louis94@91.178.240.25] has joined #wesnoth-dev
20161203 23:25:49-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 23:27:55-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 23:37:52-!- irker775 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161203 23:40:13-!- irker275 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161203 23:40:13< irker275> wesnoth: gfgtdf wesnoth:master 6977908b696d / src/utils/ (sha1.cpp sha1.hpp): remove  a sdl include https://github.com/wesnoth/wesnoth/commit/6977908b696d894daeadc25432e05163aab79577
20161203 23:40:13< irker275> wesnoth: gfgtdf wesnoth:master fb2e87b36be4 / src/ (events.cpp events.hpp game_config_manager.cpp): attempt to fix crash when wml erros message showed during the loadingscreen. https://github.com/wesnoth/wesnoth/commit/fb2e87b36be4206db4a1b8e12f94c71f54f1edba
20161203 23:40:13< irker275> wesnoth: Severin Glöckner wesnoth:master 7c1e885d57ff / src/ (game_initialization/mp_game_utils.cpp gui/dialogs/title_screen.cpp): toggle back to title screen if scenario is buggy, instead of exiting wesnoth https://github.com/wesnoth/wesnoth/commit/7c1e885d57ff4cdd428f885f0168ef33704361c3
20161203 23:40:14< irker275> wesnoth: gfgtdf wesnoth:master 57f5ffe99593 / src/game_initialization/mp_game_utils.cpp: improve a comment https://github.com/wesnoth/wesnoth/commit/57f5ffe99593d9f337205933f2b4e5a7a4515da5
20161203 23:43:46-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161203 23:57:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161203 23:57:28-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161203 23:58:46< vultraz> I wonder why I've never used reinterpret_cast
--- Log closed Sun Dec 04 00:00:38 2016