--- Log opened Sun Dec 04 00:00:38 2016
20161204 00:10:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161204 00:28:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has joined #wesnoth-dev
20161204 00:29:18< DeFender1031> it's rare to ever need it
20161204 00:31:05< DeFender1031> and can cause some very bad out-of-bounds issues if misused.
20161204 00:40:44-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 00:40:44< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 57f5ffe: improve a comment Failed
20161204 00:40:44< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-11
20161204 00:40:44< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/57f5ffe99593d9f337205933f2b4e5a7a4515da5
20161204 00:40:48-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 00:41:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:cd3:70f7:9691:d8a] has quit [Remote host closed the connection]
20161204 00:51:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161204 00:52:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161204 01:01:23-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161204 01:04:02< irker275> wesnoth: ln-zookeeper wesnoth:master 8155450cfcac / data/core/ (terrain-graphics.cfg terrain-graphics/new-macros.cfg): Added an optional argument to let NEW:TRANSITION be more widely used https://github.com/wesnoth/wesnoth/commit/8155450cfcac82687e5993ba5490e667692f59d9
20161204 01:05:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 01:05:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf 57f5ffe: improve a comment Succeeded
20161204 01:05:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-11
20161204 01:05:21< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/57f5ffe99593d9f337205933f2b4e5a7a4515da5
20161204 01:05:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 01:09:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161204 01:10:00-!- Appleman1234 [~Appleman1@106.161.210.8] has quit [Ping timeout: 260 seconds]
20161204 01:11:48-!- louis94 [~~louis94@91.178.240.25] has quit [Quit: Konversation terminated!]
20161204 01:12:25< mattsc> celmin|away: just coming online briefly to say that yes, I can build current master with Xcode.
20161204 01:15:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20161204 01:17:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161204 01:21:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161204 01:25:49-!- Appleman1234 [~Appleman1@KD106161214057.au-net.ne.jp] has joined #wesnoth-dev
20161204 01:28:07-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 01:28:08< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release gfgtdf 57f5ffe: improve a comment Failed
20161204 01:28:08< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-12
20161204 01:28:08< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/57f5ffe99593d9f337205933f2b4e5a7a4515da5
20161204 01:28:11-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 01:45:39< Shiki> gfgtdf, thanks for finishing that
20161204 01:46:27< Shiki> vultraz, you made sth with colors. there seems to be a bug
20161204 01:46:33< Shiki> Caught general exception:
20161204 01:46:40< Shiki> Wrong number of components for RGB color
20161204 01:49:33-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 01:49:33< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug gfgtdf 57f5ffe: improve a comment Failed
20161204 01:49:33< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-12
20161204 01:49:33< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/57f5ffe99593d9f337205933f2b4e5a7a4515da5
20161204 01:49:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 01:51:25-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161204 01:52:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Write error: Broken pipe]
20161204 01:53:18-!- Ivanovic_ is now known as Ivanovic
20161204 02:07:13-!- gfgtdf_ [~chatzilla@x4e363921.dyn.telefonica.de] has joined #wesnoth-dev
20161204 02:09:04-!- gfgtdf [~chatzilla@x4e363546.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20161204 02:09:08-!- gfgtdf_ is now known as gfgtdf
20161204 02:16:17< vultraz> Shiki: when?
20161204 02:17:21-!- celmin|away is now known as celticminstrel
20161204 02:17:23< vultraz> Shiki: i just fixed a bug related to that
20161204 02:17:31< vultraz> Shiki: but some of your recent saves may be affected
20161204 02:19:23< Shiki> vultraz, maybe it's fixed then
20161204 02:19:43< Shiki> It was in httt scenario 13, turn 4
20161204 02:20:14< Shiki> the turns before not, but when i try to load them not I get that
20161204 02:20:36< celticminstrel> Yeah, saves from before the bugfix will still error.
20161204 02:20:55< celticminstrel> Since the bug was incorrectly writing to savefile.
20161204 02:23:30< celticminstrel> vultraz: Any objections to merging 894?
20161204 02:23:42< vultraz> no
20161204 02:25:46< Shiki> seems to be fixed
20161204 02:26:44< irker275> wesnoth: GregoryLundberg wesnoth:master fbfe0923bea6 / src/gettext_boost.cpp: Fix C4458 'id' hides class member https://github.com/wesnoth/wesnoth/commit/fbfe0923bea6ab7f9bb6d1bf9f11fb2f082b550d
20161204 02:26:46< irker275> wesnoth: GregoryLundberg wesnoth:master 5667fa26ac07 / src/ (generators/default_map_generator_job.cpp gui/core/canvas.cpp units/unit.cpp): Fix C4456 scope_logging_object hides previous local declaration https://github.com/wesnoth/wesnoth/commit/5667fa26ac07f353852ddf07036d0fcf7c84db47
20161204 02:26:48< irker275> wesnoth: Gregory A Lundberg wesnoth:master 7f4cfdbcf501 / src/game_config.cpp: Fix C4101 unreferenced local variable https://github.com/wesnoth/wesnoth/commit/7f4cfdbcf501a983429a9bfa21ac1bdfcc5ca37e
20161204 02:26:50< irker275> wesnoth: GregoryLundberg wesnoth:master ea6a104c2f1a / src/gui/widgets/window.cpp: Fix C4458 'g' hides ... https://github.com/wesnoth/wesnoth/commit/ea6a104c2f1acd9fae8ddeb4e917089882ccdea5
20161204 02:26:52< irker275> wesnoth: GregoryLundberg wesnoth:master 93e3ac48000f / src/ (serialization/parser.cpp server/simple_wml.cpp wesnoth.cpp): Hide C4456 and C4458 due to bugs in boost gzip implementation https://github.com/wesnoth/wesnoth/commit/93e3ac48000faeb47f79b1e778bb2a0da609656a
20161204 02:26:54< irker275> wesnoth: GregoryLundberg wesnoth:master e19f55c238cd / src/terrain/translation.hpp: Hide C4459 due to bugs im boost multi-array implementation https://github.com/wesnoth/wesnoth/commit/e19f55c238cd5aeaa084a8027de3593b41cb0a02
20161204 02:26:56< irker275> wesnoth: GregoryLundberg wesnoth:master 67c65582cf7a / src/gettext_boost.cpp: Hide  C4714 and C4459 due to bugs in spirit_po implementation https://github.com/wesnoth/wesnoth/commit/67c65582cf7a86d88095a8a0f81c8e1d10ce4dc3
20161204 02:26:56-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 02:26:58< irker275> wesnoth: Gregory A Lundberg wesnoth:master a626d122b809 / src/serialization/preprocessor.cpp: Fix 4456 'arg' hides previous local definition https://github.com/wesnoth/wesnoth/commit/a626d122b809b90c8847d7974a813897cf336eaa
20161204 02:27:00< irker275> wesnoth: Celtic Minstrel wesnoth:master 707c9d745171 / src/ (11 files in 8 dirs): Merge pull request #894 from GregoryLundberg/GL_VC14_cleanup https://github.com/wesnoth/wesnoth/commit/707c9d745171af8cf488bb1e756b61eb361b143a
20161204 02:27:40< celticminstrel> Blargh, what should we do about the French PRs... :|
20161204 02:33:05< Shiki> They all update different translation files. 
20161204 02:33:33< celticminstrel> More the fact that they're not following the typical procedure for translations.
20161204 02:34:29< celticminstrel> Mind you, if it were up to me alone, I'd probably just merge them...
20161204 02:34:41< vultraz> so would I
20161204 02:37:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161204 02:42:26< Shiki> maybe write a mail to the last person who was in charge of that, asking about the problem with the mailing list
20161204 02:56:30-!- gfgtdf [~chatzilla@x4e363921.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161204 03:23:13-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 03:39:50-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 04:16:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20161204 04:22:24-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 04:25:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161204 05:21:27-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161204 05:24:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 258 seconds]
20161204 05:25:02-!- VultCave is now known as vultraz
20161204 05:26:24-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161204 05:26:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161204 05:39:47-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161204 06:18:07-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161204 06:18:25-!- allaroundArtist [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161204 06:18:30-!- allaroundArtist [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161204 06:34:14-!- TC02 [~quassel@venus.arosser.com] has quit [Quit: No Ping reply in 180 seconds.]
20161204 06:35:20-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20161204 06:42:31-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161204 06:44:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161204 06:44:32-!- wedge010 is now known as wedge009
20161204 06:47:57-!- Nikitaw99 is now known as [80R3D0M]
20161204 07:07:22-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161204 07:11:49-!- [80R3D0M] is now known as Nikitaw99
20161204 07:14:56-!- mjs-de [~mjs-de@x5ce4bac4.dyn.telefonica.de] has joined #wesnoth-dev
20161204 07:21:39-!- celticminstrel is now known as celmin|sleep
20161204 07:41:23-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has quit [Remote host closed the connection]
20161204 07:42:03-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 07:43:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161204 07:43:58-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161204 07:44:28-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has quit [Max SendQ exceeded]
20161204 07:45:13-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161204 07:46:44-!- JyrkiVesterinen [~JyrkiVest@87-100-131-102.bb.dnainternet.fi] has joined #wesnoth-dev
20161204 07:49:05< vultraz> what's the difference between class a : b {}; and class a : public b {};
20161204 07:49:07< vultraz> ?
20161204 07:49:52< Nikitaw99> (shouldn't you ask this in ##c++?)
20161204 07:50:01< vultraz> not really
20161204 07:50:25< vultraz> i mean, i could, but i always badger my fellow devs with syntax questions :P
20161204 07:51:27< JyrkiVesterinen> I don't recall if "class a : b {};" is even allowed in C++.
20161204 07:52:14< JyrkiVesterinen> In any case, the "public" means public inheritance. As a result, any members of the b class are accessible in objects of type a.
20161204 07:52:31< vultraz> ah, I see
20161204 07:53:01< JyrkiVesterinen> Private and protected inheritance are also possible. With private inheritance, for example, the a class can access members of the b class it inherits, but all other code can't see that a inherits b.
20161204 07:53:18< JyrkiVesterinen> In practice, private and protected inheritance are rarely used.
20161204 07:57:26-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 07:57:59-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 08:02:05-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Changing host]
20161204 08:02:05-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20161204 08:11:57-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 08:16:47-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161204 08:18:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Client Quit]
20161204 08:22:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161204 08:22:48 * vultraz is playing around with enable_shared_from_this in attack_type
20161204 08:24:13-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 08:24:55-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 08:25:03-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 08:27:00< Nikitaw99> i just tried out an opensource agar.io clone
20161204 08:27:26< Nikitaw99> fun
20161204 08:27:31< Nikitaw99> really was
20161204 08:27:38< vultraz> slither.io?
20161204 08:27:41< Nikitaw99> i am not sure why #wesnoth is so dead, though
20161204 08:27:45< Nikitaw99> nope
20161204 08:28:08< Nikitaw99> https://github.com/huytd/agar.io-clone
20161204 08:35:16-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 08:38:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161204 08:39:33-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 08:39:33< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel 707c9d7: Merge pull request #894 from GregoryLundberg/GL_VC14_cleanup Failed
20161204 08:39:33< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-12
20161204 08:39:33< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/707c9d745171af8cf488bb1e756b61eb361b143a
20161204 08:39:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 08:43:56< Aginor> hmm
20161204 08:44:19< Aginor> are the tests really broken in appveyor/windows, or is it a genuine bad build?
20161204 08:46:33-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 08:48:04-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 08:48:11-!- htee_ [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 08:51:29< JyrkiVesterinen> Because only 33 of the 158 tests fail, I think it's indeed some kind of bug in the game itself.
20161204 08:52:37< JyrkiVesterinen> It's quite hard to tell why the same tests pass in Travis, mind you...
20161204 08:58:14< Aginor> it might be related to the oodles of type coersion errors
20161204 08:58:27< Aginor> and different compilers behaving differently
20161204 08:58:39< Aginor> but that's just a guess with a weak basis in reality ;)
20161204 09:05:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 09:05:17< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel 707c9d7: Merge pull request #894 from GregoryLundberg/GL_VC14_cleanup Succeeded
20161204 09:05:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-12
20161204 09:05:17< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/707c9d745171af8cf488bb1e756b61eb361b143a
20161204 09:05:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 09:08:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161204 09:24:17-!- JyrkiVesterinen [~JyrkiVest@87-100-131-102.bb.dnainternet.fi] has quit [Quit: Leaving IRC for some time]
20161204 09:28:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 09:28:31< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Celtic Minstrel 707c9d7: Merge pull request #894 from GregoryLundberg/GL_VC14_cleanup Failed
20161204 09:28:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-13
20161204 09:28:31< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/707c9d745171af8cf488bb1e756b61eb361b143a
20161204 09:28:36-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 09:48:01-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 09:52:00-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 09:52:01< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Celtic Minstrel 707c9d7: Merge pull request #894 from GregoryLundberg/GL_VC14_cleanup Failed
20161204 09:52:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-13
20161204 09:52:01< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/707c9d745171af8cf488bb1e756b61eb361b143a
20161204 09:52:04-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 09:55:58< vultraz> Aginor: I have almost completed the color_t conversion
20161204 09:56:11< vultraz> only a few types left in src/units/ to deal with
20161204 10:07:09< Aginor> sweet
20161204 10:13:43< zookeeper> umm... i'm getting a bunch of syntax errors from src\utils/sha1.hpp
20161204 10:15:07< vultraz> I;m not
20161204 10:15:07< zookeeper> presumably all stemming from error C2061: syntax error : identifier 'uint8_t'
20161204 10:15:33< zookeeper> oh wait, no it wasn't just because of that
20161204 10:16:15< zookeeper> https://paste.ee/p/DTD8m
20161204 10:20:46-!- htee_ [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161204 10:21:12-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 10:22:34< vultraz> zookeeper: talk to tad 
20161204 10:22:52< vultraz> celmin|sleep: https://github.com/Vultraz/wesnoth/commit/93fcc8fbce93c8854e51e05a72abf91e8d343c47 could you look at this
20161204 10:24:25-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 10:25:42-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Ping timeout: 258 seconds]
20161204 10:31:38-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161204 10:39:37-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 10:43:45< zookeeper> tad_carlucci, ^ adding #include <stdint.h> to sha1.hpp seems to fix it.
20161204 10:56:00-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 10:58:33-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 11:00:01-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161204 11:02:58-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Ping timeout: 245 seconds]
20161204 11:07:21< vultraz> zookeeper: not cstdint?
20161204 11:07:31< zookeeper> no idea
20161204 11:07:43< vultraz> would recommend you try that instead of .h
20161204 11:10:06< vultraz> if it works just commit it
20161204 11:16:33< zookeeper> sure, seems to work
20161204 11:16:55< vultraz> I'd be surprised if it didn't
20161204 11:17:16< irker275> wesnoth: ln-zookeeper wesnoth:master a2cc25821c08 / src/utils/sha1.hpp: Fixed compilation https://github.com/wesnoth/wesnoth/commit/a2cc25821c08592a872db96ccf6f967099ce6b09
20161204 12:08:27-!- Nikitaw99 [~Nikitaw99@ppp85-140-3-90.pppoe.mtu-net.ru] has quit [Quit: Going out for a walk.]
20161204 12:19:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161204 12:25:15-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 12:29:38-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Ping timeout: 245 seconds]
20161204 12:37:36-!- louis94 [~~louis94@91.178.241.57] has joined #wesnoth-dev
20161204 12:46:44< irker275> wesnoth: ln-zookeeper wesnoth:master 8fdf689681ce / data/core/ (terrain-graphics.cfg terrain-graphics/new-macros.cfg): Added macro NEW:OVERLAY and used it to place most terrain overlays https://github.com/wesnoth/wesnoth/commit/8fdf689681ce03edf7aea44f24981614ca49157f
20161204 13:05:30-!- Nikitaw99 [~Nikitaw99@ppp85-140-0-92.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161204 13:24:35-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161204 13:25:23-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161204 13:31:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161204 13:38:40-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161204 13:39:55< tad_carlucci> I was about to look at why the VC12 compile failed. Thanks for fixing it but I didn't change sha1.h I think that was someone else a few days ago.
20161204 13:41:21< vultraz> oh right
20161204 13:43:18-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161204 15:00:04-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161204 15:20:49-!- gfgtdf [~chatzilla@x4e363921.dyn.telefonica.de] has joined #wesnoth-dev
20161204 15:27:06-!- gfgtdf [~chatzilla@x4e363921.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161204 15:31:25-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20161204 15:39:31-!- htee [~htee@dtcqfkyy1mttjnhx0jm7y-3.rev.dnainternet.fi] has quit [Quit: Leaving...]
20161204 15:46:55-!- irker275 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161204 16:14:42-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20161204 16:16:11-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20161204 16:16:44-!- Elvish_H1 [~elvish_hu@baldras.wesnoth.org] has quit [Quit: WeeChat 1.5]
20161204 16:16:53-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20161204 16:41:01-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 16:41:01< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 8fdf689: Added macro NEW:OVERLAY and used it to place most terrain overlays Failed
20161204 16:41:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-13
20161204 16:41:01< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8fdf689681ce03edf7aea44f24981614ca49157f
20161204 16:41:05-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 16:44:33-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161204 16:52:13-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 265 seconds]
20161204 17:04:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 17:04:59< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 8fdf689: Added macro NEW:OVERLAY and used it to place most terrain overlays Succeeded
20161204 17:04:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-13
20161204 17:04:59< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8fdf689681ce03edf7aea44f24981614ca49157f
20161204 17:05:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 17:35:26< celmin|sleep> "class a : b {};" is private inheritance, vultraz 
20161204 17:35:42< celmin|sleep> It means that only the class itself is allowed to know that it inherits.
20161204 17:36:08< celmin|sleep> So, for example, outside of the class's own methods, casting to the base class is not allowed.
20161204 17:36:13-!- celmin|sleep is now known as celticminstrel
20161204 17:37:11< celticminstrel> BTW, did zookeeper update the changelog with regards to optional macro arguments?
20161204 17:37:11-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 17:37:11< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 8fdf689: Added macro NEW:OVERLAY and used it to place most terrain overlays Succeeded
20161204 17:37:11< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-14
20161204 17:37:11< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8fdf689681ce03edf7aea44f24981614ca49157f
20161204 17:37:16-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 17:39:16< celticminstrel> Private inheritance also means that any members of the base class are effectively private in the derived class, unless you explicitly change their visibility with using.
20161204 18:00:22-!- Nikitaw99 [~Nikitaw99@ppp85-140-0-92.pppoe.mtu-net.ru] has quit [Ping timeout: 250 seconds]
20161204 18:01:15-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161204 18:01:15< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 8fdf689: Added macro NEW:OVERLAY and used it to place most terrain overlays Succeeded
20161204 18:01:15< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-14
20161204 18:01:15< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8fdf689681ce03edf7aea44f24981614ca49157f
20161204 18:01:20-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161204 18:08:32-!- markus_ [~mjs-de@x4db64e3f.dyn.telefonica.de] has joined #wesnoth-dev
20161204 18:12:17-!- mjs-de [~mjs-de@x5ce4bac4.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161204 18:19:27-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161204 18:19:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161204 18:38:16-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161204 19:04:24-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161204 19:04:37-!- louis94 [~~louis94@91.178.241.57] has quit [Ping timeout: 248 seconds]
20161204 19:05:23< tad_carlucci> Anyone have any thoughts on the VC14 WML Tests failing? I'm about to dig into them unless someone is already on it?
20161204 19:08:16< zookeeper> the appveyor output here is rather... bold.
20161204 19:08:49< tad_carlucci> Talk to celmin about it I think he's the BOLD one .. :P All I've seen is in the plain-text logs
20161204 19:09:13< celticminstrel> I made it bold, yes. Travis's announcment is bold too though.
20161204 19:09:21< celticminstrel> Maybe not quite as bold though.
20161204 19:09:41< celticminstrel> Are the WML test failures timeouts? Or maybe log-strict failures?
20161204 19:09:48< zookeeper> well, bold and verbose.
20161204 19:09:52< celticminstrel> Those would seem to be the most likely.
20161204 19:10:05< tad_carlucci> celticminstrel, I get the same failures locally, so I'll look into them
20161204 19:10:19-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 268 seconds]
20161204 19:11:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161204 19:11:22< tad_carlucci> The appveyor run is on a schedule. We could make the case that the commit text has no meaning and make the first line a lot shorter
20161204 19:12:18< zookeeper> the only thing of interest 99% of the time is that if there's a failure
20161204 19:12:30< zookeeper> or so i'd imagine
20161204 19:13:08< tad_carlucci> The link to the run log and commit help and I use them often. But on line 1 all I check it 2013 vs 2015 / Release vs Debug / Success vs Failure
20161204 19:15:38< zookeeper> sure, i just meant that on success there doesn't seem to be any purpose to including for example the commit link
20161204 19:16:00< zookeeper> and everything could surely be in one message anyway, not split across three
20161204 19:16:07< celticminstrel> True.
20161204 19:16:12< zookeeper> i'd think that would make it seem less spammy
20161204 19:16:38< tad_carlucci> zookeeper, Ah. Good points. Well jkive ??? did the python. 
20161204 19:16:55-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has joined #wesnoth-dev
20161204 19:17:39< celticminstrel> Combining all three would not exceed the IRC length limit, either...
20161204 19:18:52< tad_carlucci> Well, I'm just happy it's up and running. I'm hoping it will help up keep the MSVC side up-to-snuff sooner/better
20161204 19:27:41-!- oldlaptop [~quassel@162.247.150.37] has quit [Remote host closed the connection]
20161204 19:27:59-!- oldlaptop [~quassel@162.247.150.37] has joined #wesnoth-dev
20161204 19:32:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161204 19:41:31-!- JyrkiVesterinen [~JyrkiVest@87-100-214-160.bb.dnainternet.fi] has joined #wesnoth-dev
20161204 19:42:28< JyrkiVesterinen> tad_carlucci: the copyright notice in the Python script says that Christopher R. Wood wrote it initially.
20161204 19:42:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161204 19:42:39< JyrkiVesterinen> It was later improved by nexB, and then by me.
20161204 19:44:14 * tad_carlucci shrugs. I thought you grabbed it from someone/someplace else. I don't do Python so it's all "Not Me".
20161204 19:51:37-!- gfgtdf [~chatzilla@x4e363921.dyn.telefonica.de] has joined #wesnoth-dev
20161204 20:06:05< vultraz> celticminstrel: ah
20161204 20:25:33-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20161204 20:25:34< travis-ci> gfgtdf/wesnoth-old#704 (master - a60be1e : gfgtdf): The build was broken.
20161204 20:25:35< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181176877
20161204 20:25:35-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20161204 20:42:33-!- gimemor [~gimemor@host-95-152-34-56.dsl.sura.ru] has quit [Ping timeout: 245 seconds]
20161204 20:43:06-!- louis94 [~~louis94@91.178.241.57] has joined #wesnoth-dev
20161204 20:48:31-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161204 20:49:08< vultraz> celticminstrel: no other objections besides the make_shared change?
20161204 20:53:34< celticminstrel> I didn't see anything else obviously wrong, but I'm not too sure about it.
20161204 20:54:39-!- JyrkiVesterinen [~JyrkiVest@87-100-214-160.bb.dnainternet.fi] has quit [Quit: .]
20161204 20:55:20-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20161204 20:55:21< travis-ci> gfgtdf/wesnoth-old#705 (master - ae0d80d : gfgtdf): The build is still failing.
20161204 20:55:21< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181179800
20161204 20:55:21-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20161204 20:57:35< vultraz> so, commit or not commit?
20161204 21:09:32-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me]
20161204 21:11:56-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20161204 21:20:56< celticminstrel> I don't see anything wrong with it, but I'm not sure if it's sufficiently safe. According to cppreference.com, calling shared_from_this() can result in undefined behviour prior to C++17.
20161204 21:21:30< Aginor> undefined behaviour is a bad thing
20161204 21:21:44< celticminstrel> Yes.
20161204 21:23:37< celticminstrel> The undefined behaviour would not be able to occur if you made the constructors private (including the implicit ones) and added static functions that return a shared_ptr.
20161204 21:23:44< celticminstrel> I don't personally like that solution though.
20161204 21:24:53-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 248 seconds]
20161204 21:26:34< celticminstrel> I think I'd recommend not committing it at this time. Maybe in a few years.
20161204 21:27:23< celticminstrel> (It's probably possible to manually implement the safeguard C++17 requires for shared_from_this(). I'm not sure how to do that though.)
20161204 21:28:24< celticminstrel> (Obviously I'm assuming the safeguard doesn't require any change to the shared_ptr class. Not sure if that's a reasonable assumption.)
20161204 21:29:16< tad_carlucci> I have no idea what you're doing but undefined behavior is bad and coding to a moving target like C++17 isn't much better.
20161204 21:31:20-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161204 21:35:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 258 seconds]
20161204 21:40:11-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20161204 21:40:12< travis-ci> gfgtdf/wesnoth-old#706 (master - 31d4fc9 : gfgtdf): The build is still failing.
20161204 21:40:12< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181187636
20161204 21:40:12-!- travis-ci [~travis-ci@ec2-54-204-185-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20161204 21:48:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has joined #wesnoth-dev
20161204 21:50:28-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 245 seconds]
20161204 21:58:31< tad_carlucci> OK. I'm stumped. I'm trying to determine why the test "wesnoth.exe -ucheck_victory_basic_timeout" is failing for VC14. Using a Debug build I get a C Runtime Breakpoint for "list erase iterator outside range" in a callstack having to do with animations.
20161204 22:02:56< tad_carlucci> ~wesnoth/src/units/animation.cpp line 166
20161204 22:04:44< tad_carlucci> https://github.com/wesnoth/wesnoth/commit/82a879725c8882cd1e4b2171af2a49eb33cbefe0
20161204 22:05:34< tad_carlucci> vultraz ^
20161204 22:08:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has quit [Remote host closed the connection]
20161204 22:12:40-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161204 22:14:29-!- 7IZAANQ5Y [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has joined #wesnoth-dev
20161204 22:22:50-!- 7IZAANQ5Y [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has quit [Remote host closed the connection]
20161204 22:25:43-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 22:27:50-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 22:43:33-!- markus_ [~mjs-de@x4db64e3f.dyn.telefonica.de] has quit [Remote host closed the connection]
20161204 22:45:53-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161204 22:48:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has joined #wesnoth-dev
20161204 23:05:04-!- travis-ci [~travis-ci@ec2-54-163-104-101.compute-1.amazonaws.com] has joined #wesnoth-dev
20161204 23:05:05< travis-ci> gfgtdf/wesnoth-old#709 (master - 92f2566 : gfgtdf): The build is still failing.
20161204 23:05:05< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181199923
20161204 23:05:05-!- travis-ci [~travis-ci@ec2-54-163-104-101.compute-1.amazonaws.com] has left #wesnoth-dev []
20161204 23:14:38-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 23:19:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:2428:b5e9:d7f9:8d5a] has quit [Remote host closed the connection]
20161204 23:22:42-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 23:24:54-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 23:45:41-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has joined #wesnoth-dev
20161204 23:47:54-!- RatArmy_ [~ratarmy@om126212245029.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161204 23:54:13-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161204 23:56:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
--- Log closed Mon Dec 05 00:00:08 2016