--- Log opened Tue Dec 06 00:00:33 2016
20161206 00:02:29-!- travis-ci [~travis-ci@ec2-54-147-34-26.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 00:02:30< travis-ci> wesnoth/wesnoth#12312 (master - c003bc1 : gfgtdf): The build passed.
20161206 00:02:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181481344
20161206 00:02:30-!- travis-ci [~travis-ci@ec2-54-147-34-26.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 00:13:41< zookeeper> yeah, i think i'm done with this lava...
20161206 00:16:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 00:17:13-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161206 00:22:26< zookeeper> aww, volcanos...
20161206 00:23:16 * zookeeper is going to ignore volcanos for the time being
20161206 00:26:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 00:28:59 * DeFender1031 would love to see a special version of the large volcano (the special graphic for volcano at the peak of three mountain hexes) where if the center of the base is also volcano, it's still the large volcano, only with lava running down the side. Also, that that would play nicely with lava hexes such that it makes the volcano look like the source of the lava.
20161206 00:30:48< celticminstrel> So basically, if you have two vertically adjacent volcano hexes with a mountain hex nestled between them on both sides?
20161206 00:30:54-!- louis94 [~~louis94@91.178.240.133] has quit [Ping timeout: 268 seconds]
20161206 00:36:39< DeFender1031> yeah, basically
20161206 00:37:45< irker067> wesnoth: ln-zookeeper wesnoth:master 7ff816f71dc2 / / (22 files in 3 dirs): New animated lava https://github.com/wesnoth/wesnoth/commit/7ff816f71dc28b129a643f8e2c2dcd829693a9c0
20161206 00:38:25< zookeeper> i think the brightness/saturation/etc is fine, but it can be tweaked later if it seems too muted.
20161206 00:38:36< zookeeper> DeFender1031, well... draw the tiles and i'll make it work
20161206 00:40:00< DeFender1031> zookeeper, I'm unfortuantely total crap at graphics...
20161206 00:43:24-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 00:43:24< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf c003bc1: remove some utils::split Succeeded
20161206 00:43:24< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-17
20161206 00:43:24< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/c003bc1e18e82a7e4a06f55668f0a6fe66fcd023
20161206 00:43:28-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 00:58:03-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161206 00:58:18< zookeeper> ah, i didn't remember to crop them exactly as i planned... which means there ought to be a really subtle seam somewhere. virtual cookie for whoever can find it by only looking in-game.
20161206 01:03:23-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161206 01:03:28< DeFender1031> damn! I still can't compile!
20161206 01:03:43< DeFender1031> But I want to get a virtual cookie!
20161206 01:04:02< DeFender1031> Whatever. I'll just log into some website. That'll give me a virtual cookie.
20161206 01:06:09< zookeeper> well, for what it's worth, i can't spot it myself from a screenshot
20161206 01:07:16-!- Appleman1234_ [~Appleman1@KD106161205160.au-net.ne.jp] has joined #wesnoth-dev
20161206 01:07:34-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161206 01:07:55-!- Appleman1234 [~Appleman1@KD106161200237.au-net.ne.jp] has quit [Disconnected by services]
20161206 01:08:01-!- Appleman1234_ is now known as Appleman1234
20161206 01:08:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 01:08:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf c003bc1: remove some utils::split Succeeded
20161206 01:08:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-17
20161206 01:08:20< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/c003bc1e18e82a7e4a06f55668f0a6fe66fcd023
20161206 01:08:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 01:09:29-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161206 01:10:25< zookeeper> hmh, looks like i accidentally saved them as 8bit although i intended not to. oh well, what's done is done and they seem to be functioning all right, so whatever.
20161206 01:14:14< vultraz> now all this needs is a smoke particle effect 
20161206 01:15:11< vultraz> you forgot to update the editor icons
20161206 01:15:45< vultraz> otherwise, looks great :D
20161206 01:16:19< celticminstrel> I see updated icons though?
20161206 01:16:22< celticminstrel> In the commit.
20161206 01:17:05< vultraz> yeah
20161206 01:17:20< vultraz> odd that when you drag with the mouse w/o auto transition updates, you get the old icon
20161206 01:18:07< zookeeper> no i didn't?
20161206 01:18:47< celticminstrel> I do notice that the lava tile icon was added, not replaced, according to the diff.
20161206 01:19:14< celticminstrel> The lava chasm tile was replaced.
20161206 01:19:25< zookeeper> huh. yeah, where are those old images coming from...
20161206 01:19:35< celticminstrel> So there's probably both an old and a new lava tile in there?
20161206 01:19:50< zookeeper> oh right, symbol_image
20161206 01:22:02< irker067> wesnoth: ln-zookeeper wesnoth:master 8986732a8f75 / data/core/terrain.cfg: Updated lava symbol_images https://github.com/wesnoth/wesnoth/commit/8986732a8f752a3a0407b4014f7b6838a53dbfa5
20161206 01:22:05< zookeeper> that should do it
20161206 01:25:12-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 260 seconds]
20161206 01:25:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 01:29:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 01:31:36-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20161206 01:34:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20161206 01:35:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161206 01:40:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 01:40:59< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 7ff816f: New animated lava Succeeded
20161206 01:40:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-18
20161206 01:40:59< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/7ff816f71dc28b129a643f8e2c2dcd829693a9c0
20161206 01:40:59-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161206 01:41:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 01:48:25-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161206 01:49:45-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161206 01:55:09-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161206 01:56:10-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Read error: Connection reset by peer]
20161206 02:04:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 02:04:06< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 7ff816f: New animated lava Succeeded
20161206 02:04:06< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-18
20161206 02:04:06< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/7ff816f71dc28b129a643f8e2c2dcd829693a9c0
20161206 02:04:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 02:05:10-!- gfgtdf_ [~chatzilla@x4e36964f.dyn.telefonica.de] has joined #wesnoth-dev
20161206 02:06:23-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161206 02:07:08-!- gfgtdf [~chatzilla@x4e363a9e.dyn.telefonica.de] has quit [Ping timeout: 245 seconds]
20161206 02:07:23-!- gfgtdf_ is now known as gfgtdf
20161206 02:18:31-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 02:18:32< travis-ci> wesnoth/wesnoth#12313 (master - 7ff816f : ln-zookeeper): The build has errored.
20161206 02:18:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181523133
20161206 02:18:32-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 02:58:58-!- gfgtdf [~chatzilla@x4e36964f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161206 03:22:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161206 03:58:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Quit: Leaving]
20161206 04:05:48-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 258 seconds]
20161206 04:06:51-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161206 04:22:13-!- irker067 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161206 04:23:42-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me]
20161206 04:24:18-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20161206 05:20:16-!- RatArmy_ [~ratarmy@om126237116023.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 05:24:57-!- RatArmy_ [~ratarmy@om126237116023.9.openmobile.ne.jp] has joined #wesnoth-dev
20161206 05:28:55-!- RatArmy_ [~ratarmy@om126237116023.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 05:29:52-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161206 06:47:28-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20161206 06:49:05-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20161206 07:13:49-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161206 07:15:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 07:16:26-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 07:19:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161206 07:36:10-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 07:40:20-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 07:59:02-!- Kwandulin [~Miranda@p200300760F6EBFC315C18785A4008AA0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161206 08:03:24-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 08:21:23< matthiaskrgr> 	surface const fb = nullptr;
20161206 08:21:27< matthiaskrgr> 	if(fb != nullptr) { ... } 
20161206 08:21:40< matthiaskrgr> this looks kinda weird imo 
20161206 08:21:50< matthiaskrgr> src/video.cpp:135  
20161206 08:23:10< matthiaskrgr> does it mean the condition will always fail?
20161206 08:42:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161206 08:42:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161206 08:43:02-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 08:43:02< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 8986732: Updated lava symbol_images Succeeded
20161206 08:43:02< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-18
20161206 08:43:02< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8986732a8f752a3a0407b4014f7b6838a53dbfa5
20161206 08:43:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 08:46:42< vultraz> matthiaskrgr: looks like it
20161206 08:47:34< vultraz> I think Aginor said these functions could be removed..
20161206 08:47:44< vultraz> Aginor: can CVideo::update_rect be removed?
20161206 08:53:30< vultraz> actually I think yes
20161206 08:53:40< vultraz> since the function never does anything
20161206 08:53:56< vultraz> and there are no adverse affects now
20161206 08:54:00< vultraz> it should be removable 
20161206 09:00:26-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 09:03:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 09:08:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161206 09:08:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161206 09:09:55-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 09:09:56< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 8986732: Updated lava symbol_images Succeeded
20161206 09:09:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-18
20161206 09:09:56< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8986732a8f752a3a0407b4014f7b6838a53dbfa5
20161206 09:09:59-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 09:28:46-!- RatArmy_ [~ratarmy@om126161124042.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 09:45:02-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 09:45:02< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 8986732: Updated lava symbol_images Succeeded
20161206 09:45:02< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-19
20161206 09:45:02< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8986732a8f752a3a0407b4014f7b6838a53dbfa5
20161206 09:45:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 09:50:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161206 09:53:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 09:53:35< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 8986732: Updated lava symbol_images Failed
20161206 09:53:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-19
20161206 09:53:35< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/8986732a8f752a3a0407b4014f7b6838a53dbfa5
20161206 09:53:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 10:24:45-!- JyrkiVesterinen [~JyrkiVest@78-27-99-207.bb.dnainternet.fi] has joined #wesnoth-dev
20161206 10:27:46-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20161206 10:45:28-!- Kwandulin [~Miranda@p200300760F6EBFC315C18785A4008AA0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161206 10:50:43-!- louis94 [~~louis94@91.178.241.93] has joined #wesnoth-dev
20161206 10:51:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 10:54:13-!- Duthlet [~Duthlet@dslb-146-060-035-062.146.060.pools.vodafone-ip.de] has quit [Ping timeout: 245 seconds]
20161206 10:56:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161206 11:11:40-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161206 11:32:10-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 11:33:40-!- JyrkiVesterinen [~JyrkiVest@78-27-99-207.bb.dnainternet.fi] has quit [Quit: .]
20161206 12:28:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161206 12:28:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161206 12:40:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 12:42:28-!- Kwandulin [~Miranda@p200300760F6EBFC3F4DAFD2EC2928FE1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161206 12:44:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20161206 12:47:26-!- Kwandulin [~Miranda@p200300760F6EBFC3F4DAFD2EC2928FE1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161206 13:20:18-!- irker506 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161206 13:20:18< irker506> wesnoth: ln-zookeeper wesnoth:master ae91632ea731 / data/core/terrain-graphics.cfg: Prevent base terrain from being drawn under mountains when not needed https://github.com/wesnoth/wesnoth/commit/ae91632ea731a57317c0654ba703a7b87c5bde24
20161206 13:43:46-!- Kwandulin [~Miranda@p200300760F6EBFC3F0AF9EBB55C0A020.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161206 13:53:42-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 246 seconds]
20161206 13:56:29-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161206 14:44:26< irker506> wesnoth: Charles Dang wesnoth:master 0c18c9cb204e / src/ (display.cpp gui/core/canvas.cpp video.cpp video.hpp): CVideo: removed get_screen_surface in favor of getSurface https://github.com/wesnoth/wesnoth/commit/0c18c9cb204ef98c6a2db047216170635e9314d4
20161206 14:44:29< irker506> wesnoth: Charles Dang wesnoth:master bf869123715f / src/ (20 files in 7 dirs): CVideo: removed update_rect functions https://github.com/wesnoth/wesnoth/commit/bf869123715fae82eee7442570a69d78b8b337f4
20161206 14:44:32< irker506> wesnoth: Charles Dang wesnoth:master 5f3a0bb69f68 / src/ (controller_base.cpp desktop/notifications.cpp video.cpp video.hpp): CVideo: refactored out custom SDL window state flags https://github.com/wesnoth/wesnoth/commit/5f3a0bb69f68ace8b9c6b7a13b6057431701fba0
20161206 14:44:35< irker506> wesnoth: Charles Dang wesnoth:master cbcb355ee9cb / src/ (font/text.cpp gui/dialogs/addon/manager.cpp image.cpp storyscreen/part.cpp): Cleaned up a few video.hpp includes https://github.com/wesnoth/wesnoth/commit/cbcb355ee9cbb1bfb1defd0f054a7822d3cb9804
20161206 14:44:38< irker506> wesnoth: Charles Dang wesnoth:master b33fc6a74f59 / src/ (sdl/window.cpp sdl/window.hpp video.cpp): Added an sdl::window wrapper for SDL_GetWindowDisplayIndex https://github.com/wesnoth/wesnoth/commit/b33fc6a74f59e7e3aa3fa12e7be69878f2245b79
20161206 14:44:41< irker506> wesnoth: Charles Dang wesnoth:master ec8ff1ac913c / src/ (video.cpp video.hpp): CVideo: general cleanup https://github.com/wesnoth/wesnoth/commit/ec8ff1ac913cee90ebed5706da4380cb34e0d451
20161206 14:44:44< vultraz> Aginor: ^
20161206 14:46:19< celticminstrel> Well!
20161206 14:47:21< celticminstrel> Huh, why is SFD the one opening a PR for SotA?
20161206 14:47:34< vultraz> We told him he could
20161206 14:47:47< celticminstrel> Still strange though...
20161206 14:48:37< celticminstrel> Your commit message says "get_screen_surface". Actual function is "get_video_surface". :|
20161206 14:49:01< vultraz> oops
20161206 14:49:18< celticminstrel> Also, what's with this thing being a global function...
20161206 14:49:40< vultraz> no idea
20161206 14:51:19< celticminstrel> "however, it's very unlikely the former flag would be ever set if the latter were as well"
20161206 14:51:34< celticminstrel> On what basis do you say this?
20161206 14:51:54< celticminstrel> (The flags are SDL_WINDOW_SHOWN and SDL_WINDOW_MINIMIZED, for reference.)
20161206 14:54:07< vultraz> the fact that they exist separately. how can it be visible and minimized at the same time?
20161206 14:54:16< celticminstrel> Easy?
20161206 14:55:47< vultraz> well, either way
20161206 14:56:03< vultraz> the code seems to be specifically tailored to visibility, not minimized status.
20161206 14:59:28< celticminstrel> Hmm.
20161206 15:00:58< celticminstrel> The case in controller_base is probably wrong if the window is both visible and minimized.
20161206 15:01:16< celticminstrel> (I have no idea whether that can happen, but I have no proof that it can't either.)
20161206 15:01:50< celticminstrel> The case in notifications.cpp should be fine if it's both visible and minimized, I think. Because then it should fail the second test.
20161206 15:02:52< celticminstrel> ...wait, if I move Wesnoth to the other monitor, will it show different resolution options in prefs? :O
20161206 15:04:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161206 15:07:11< vultraz> probably?
20161206 15:12:18-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161206 15:53:19-!- louis94 [~~louis94@91.178.241.93] has quit [Quit: Konversation terminated!]
20161206 15:53:28-!- louis94 [~~louis94@91.178.241.93] has joined #wesnoth-dev
20161206 15:54:37-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 15:54:38< travis-ci> wesnoth/wesnoth#12317 (master - ec8ff1a : Charles Dang): The build was broken.
20161206 15:54:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181674103
20161206 15:54:38-!- travis-ci [~travis-ci@ec2-54-92-137-167.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 15:57:00-!- DeFender1031 [~DeFender1@93-172-151-164.bb.netvision.net.il] has joined #wesnoth-dev
20161206 15:59:41< celticminstrel> :O
20161206 15:59:47< celticminstrel> Let me guess, tests?
20161206 15:59:55< celticminstrel> vultraz: Did you ever try that tests.cbp?
20161206 16:12:10-!- JyrkiVesterinen [~JyrkiVest@87-92-51-67.bb.dnainternet.fi] has joined #wesnoth-dev
20161206 16:33:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161206 16:47:03-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 16:47:03< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang ec8ff1a: CVideo: general cleanup Failed
20161206 16:47:03< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-19
20161206 16:47:03< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/ec8ff1ac913cee90ebed5706da4380cb34e0d451
20161206 16:47:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 16:47:49< celticminstrel> Yup, given that only OSX and translations passed, it's definitely tests.
20161206 16:50:15-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161206 16:50:44< irker506> wesnoth: Jyrki Vesterinen wesnoth:master 3e41a51ea60a / src/desktop/notifications.cpp: Fix a frequent crash in unit tests https://github.com/wesnoth/wesnoth/commit/3e41a51ea60a698e3b753c1a783712f2a7c51500
20161206 16:50:51< JyrkiVesterinen> ^ This should help. :)
20161206 16:50:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 16:52:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 16:52:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20161206 17:05:41-!- louis94 [~~louis94@91.178.241.93] has quit [Ping timeout: 248 seconds]
20161206 17:13:50-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 17:13:50< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang ec8ff1a: CVideo: general cleanup Succeeded
20161206 17:13:50< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-19
20161206 17:13:50< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/ec8ff1ac913cee90ebed5706da4380cb34e0d451
20161206 17:13:54-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 17:19:10-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-240.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161206 17:21:10-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-240.pppoe.mtu-net.ru] has quit [Read error: Connection reset by peer]
20161206 17:21:41-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-240.pppoe.mtu-net.ru] has joined #wesnoth-dev
20161206 17:28:53< irker506> wesnoth: Jyrki Vesterinen wesnoth:master 30524b73187a / src/controller_base.cpp: Add more null checks for the window https://github.com/wesnoth/wesnoth/commit/30524b73187acafbdeb085fd1b72c6f91ab4aad6
20161206 17:29:43-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161206 17:35:23-!- Kwandulin [~Miranda@p200300760F6EBFC3F0AF9EBB55C0A020.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161206 17:36:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161206 17:47:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 17:47:35< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen 3e41a51: Fix a frequent crash in unit tests Failed
20161206 17:47:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-20
20161206 17:47:35< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/3e41a51ea60a698e3b753c1a783712f2a7c51500
20161206 17:47:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 17:53:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161206 17:53:15-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 17:53:40-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161206 17:53:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 17:55:22-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161206 17:58:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161206 18:06:38-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161206 18:09:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 18:14:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161206 18:14:20< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen 3e41a51: Fix a frequent crash in unit tests Succeeded
20161206 18:14:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-20
20161206 18:14:20< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/3e41a51ea60a698e3b753c1a783712f2a7c51500
20161206 18:14:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161206 18:15:46-!- serin| [~serin@209.77.159.143.dyn.plus.net] has joined #wesnoth-dev
20161206 18:19:39< serin|> In 1.13.6, from the Windows installer, I just moved Li'sar onto the sceptre of fire, but Konrad was given the fire attack (and the dialogue is as if Li'sar got the sceptre. This continues in the next mission. Is this already known, and is it a bug or a design decision?
20161206 18:19:45< serin|> +)
20161206 18:20:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161206 18:24:26-!- serin| [~serin@209.77.159.143.dyn.plus.net] has quit [Ping timeout: 244 seconds]
20161206 18:24:43-!- serin| [~serin@209.77.159.143.dyn.plus.net] has joined #wesnoth-dev
20161206 18:25:57< zookeeper> serin|, eh, sounds like a bug...
20161206 18:26:22 * zookeeper looks
20161206 18:26:59< serin|> I can upload a save file from just before she takes the sceptre if it helps?
20161206 18:27:33< zookeeper> well, sure... although i don't think it's needed
20161206 18:28:24< serin|> I'll save myself the effort then :)
20161206 18:29:40< zookeeper> say, in what direction on the map was konrad, in relation to the sceptre/li'sar? northwest perhaps?
20161206 18:30:34< serin|> southest, tackling the orcish warlord leader
20161206 18:30:44< zookeeper> ah, okay
20161206 18:38:46< zookeeper> yeah, managed to reproduce
20161206 18:43:30< zookeeper> celticminstrel, i feel like this might be due to some changed behavior in [object]
20161206 18:44:39< zookeeper> the sceptre object filtering relies on the "given to unit at x1,y1 by default" behavior, but maybe the [filter] block interfered with it or something
20161206 18:44:56< zookeeper> i'm not sure why exactly it keeps picking konrad
20161206 18:45:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161206 18:45:38< celticminstrel> Doesn't it take the first unit matching the filter?
20161206 18:46:07< celticminstrel> The filter should add x,y=$x1,$y1 shouldn't it?
20161206 18:46:35< zookeeper> sure it should add it for clarity, but it hasn't been required
20161206 18:46:44 * celticminstrel goes to check.
20161206 18:47:22< zookeeper> i dunno when the breakage, whatever it is exactly, has happened because i first tried to test with 1.13.4 but it was so broken in all sorts of other ways and no one got the sceptre effect that it was inconclusive :>
20161206 18:48:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161206 18:52:09< zookeeper> yeah, it does seem to just pick according to the [filter] block and for whatever reason it's always konrad over li'sar
20161206 18:52:35< zookeeper> however...
20161206 18:52:38< celticminstrel> Probably because Konrad is the leader and thus has the lowest underlying ID.
20161206 18:52:44< zookeeper> yeah
20161206 18:53:31< zookeeper> is that even a bug? i mean, even according to the wiki x1,y1 is only the default if no [filter] is given (or no matching unit exists)...
20161206 18:53:54< celticminstrel> I'm trying to check the original code, but I think that's how it's supposed to work, yes.
20161206 18:54:33< zookeeper> so, maybe the WML has been working so far due to some undocumented little detail which no longer exists?
20161206 18:54:47< zookeeper> serin|, anyway, great, thanks for the report :P
20161206 18:55:04< celticminstrel> Basically, yes.
20161206 18:55:13< celticminstrel> Which I'm trying to verify.
20161206 18:55:20< zookeeper> nice...
20161206 18:55:25< zookeeper> well, i'll fix the WML
20161206 18:55:37< serin|> no problem :) trying to figure out how to fix the situation with the debug console now
20161206 18:55:43< celticminstrel> If so, should that feature be restored and documented?
20161206 18:55:50< celticminstrel> Or should it just be forgotten?
20161206 18:56:30< zookeeper> serin|, ah, well if you post your savefile then i can hotfix it so that the sceptre correctly goes to li'sar
20161206 18:56:52< zookeeper> might be hard or impossible to use the debug mode to do it
20161206 18:57:14< celticminstrel> Probably impossible with debug mode, yeah.
20161206 18:57:26< celticminstrel> You need to edit the event handler, which means the saved game or the original scenario.
20161206 18:57:44< zookeeper> so, if you want i can do that for you, it's not a big deal
20161206 18:59:26-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 19:00:29-!- Serin [~Serin@209.77.159.143.dyn.plus.net] has joined #wesnoth-dev
20161206 19:00:38< Serin> here's the save: https://www.dropbox.com/s/jet2bi5zss091ch/HttT-The_Sceptre_of_Fire_Turn_16a.gz?dl=0
20161206 19:01:18< zookeeper> ok, just give me a few minutes...
20161206 19:01:30< serin|> sure
20161206 19:02:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161206 19:02:45< celticminstrel> Is it possible to make terrain draw above units, without customizing the units?
20161206 19:02:56< zookeeper> yes
20161206 19:03:11< celticminstrel> So why didn't SotA do that...?
20161206 19:03:22< zookeeper> i don't know the context
20161206 19:03:34< celticminstrel> images/terrain/ship/README
20161206 19:03:39< zookeeper> is there something wrong with that dropbox link or does dropbox just not like me?
20161206 19:03:54-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161206 19:04:09< celticminstrel> IIRC dropbox requires you to accept cookies to download stuff.
20161206 19:04:23< celticminstrel> You might also try removing ?dl=0 though.
20161206 19:04:28< Serin> try https://dl.dropbox.com/s/jet2bi5zss091ch/HttT-The_Sceptre_of_Fire_Turn_16a.gz?dl=0
20161206 19:04:38< zookeeper> yeah, but i did just temporarily allow cookies...
20161206 19:04:48< zookeeper> Serin, okay, that worked
20161206 19:05:18 * celticminstrel is happy to hear that I'm not the only one who disables cookies in general (with a whitelist for sites I trust).
20161206 19:05:46< Serin> dropbox thinks it's cool to make the default copied link be the "look at our nice web page and signup form" page rather than the direct link
20161206 19:07:20-!- Nikitaw99 [~Nikitaw99@ppp85-140-2-240.pppoe.mtu-net.ru] has quit [Ping timeout: 260 seconds]
20161206 19:08:42< zookeeper> https://dl.dropboxusercontent.com/u/63964618/wesnoth/HttT-The_Sceptre_of_Fire_Turn_16a_fixed.gz
20161206 19:08:50< zookeeper> that should do it
20161206 19:09:50< serin|> it does, thanks zookeeper :)
20161206 19:10:38< celticminstrel> zookeeper: I don't see anything in the C++ [object] code to suggest that it would favour a unit at $x1,$y1 if there are multiple matches for the filter.
20161206 19:11:06-!- Serin [~Serin@209.77.159.143.dyn.plus.net] has quit [Quit: Leaving]
20161206 19:11:37< celticminstrel> If anyone else wants to take a look, it's here https://github.com/wesnoth/wesnoth/commit/376020097fbce1409d59838437c7510736038b88#diff-9a44dafa9a574351f5e1570159c3edb0L495
20161206 19:11:54< zookeeper> maybe i should test on 1.12 and see if i can trigger the bug there... somehow
20161206 19:13:32< irker506> wesnoth: ln-zookeeper wesnoth:master 43fd758dae5a / data/campaigns/Heir_To_The_Throne/utils/httt_utils.cfg: HttT: Fixed bug allowing the wrong person to receive the scepter https://github.com/wesnoth/wesnoth/commit/43fd758dae5a1722cf264fdd9536aa62233b1439
20161206 19:14:36-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 19:14:37< travis-ci> wesnoth/wesnoth#12319 (master - 30524b7 : Jyrki Vesterinen): The build was fixed.
20161206 19:14:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181722724
20161206 19:14:37-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 19:15:06< vultraz> ah, ty ty
20161206 19:15:53< celticminstrel> vultraz: You should get set up to build the tests.
20161206 19:16:48< zookeeper> can't trigger the bug in 1.12 no matter what i try.
20161206 19:25:47-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 19:26:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 19:26:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 19:26:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 19:35:01-!- APic [apic@apic.name] has quit [Ping timeout: 248 seconds]
20161206 19:35:01-!- lobby [~wesnoth@wesnoth/bot/lobby] has quit [Ping timeout: 248 seconds]
20161206 19:35:19-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20161206 19:35:19-!- Topic for #wesnoth-dev: 1.13.7 tentatively scheduled for December 18th (00:00 UTC) | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161206 19:35:19-!- Topic set by vultraz [~chatzilla@wesnoth/developer/vultraz] [Fri Nov 11 00:05:42 2016]
20161206 19:35:19[Users #wesnoth-dev]
20161206 19:35:19[ _laco         ] [ ChipmunkV      ] [ Greywhind      ] [ lobby       ] [ pydsigner] [ timotei_ ] 
20161206 19:35:19[ abruanese     ] [ clavi          ] [ heirecka       ] [ loonycyborg ] [ RatArmy_ ] [ tomreyn  ] 
20161206 19:35:19[ aeth          ] [ crimson_penguin] [ higgins        ] [ matthiaskrgr] [ Ravana_  ] [ vincent_c] 
20161206 19:35:19[ Aginor        ] [ DDR            ] [ irker506       ] [ midzer      ] [ Rhonda   ] [ vultraz  ] 
20161206 19:35:19[ AI0867        ] [ DeFender1031   ] [ Ivanovic       ] [ minbonbon   ] [ Samual   ] [ wedge009 ] 
20161206 19:35:19[ aidanhs       ] [ elias          ] [ iwaim          ] [ mkdroid     ] [ serin|   ] [ Yaiyan   ] 
20161206 19:35:19[ Appleman1234  ] [ EliDupree      ] [ janebot        ] [ new_one     ] [ Sirp     ] [ zookeeper] 
20161206 19:35:19[ atarocch      ] [ Elvish_Hunter  ] [ Jetrel         ] [ nore        ] [ Soliton  ] 
20161206 19:35:19[ bobbytables   ] [ esr            ] [ Jetrel_bot     ] [ nurupo      ] [ stikonas ] 
20161206 19:35:19[ boucman       ] [ FinalBossDad   ] [ JyrkiVesterinen] [ oldlaptop   ] [ TC01     ] 
20161206 19:35:19[ bumbadadabum  ] [ Gambit         ] [ kidneb         ] [ Polsaker    ] [ TC02     ] 
20161206 19:35:19[ celticminstrel] [ Greg-Boggs     ] [ knotwork       ] [ prkc        ] [ TheJJ    ] 
20161206 19:35:19-!- Irssi: #wesnoth-dev: Total of 67 nicks [0 ops, 0 halfops, 0 voices, 67 normal]
20161206 19:35:22-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20161206 19:36:13-!- Irssi: Join to #wesnoth-dev was synced in 62 secs
20161206 19:36:22-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161206 19:36:26-!- APic [apic@apic.name] has joined #wesnoth-dev
20161206 19:50:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161206 19:52:05< irker506> wesnoth: Severin Glöckner wesnoth:master 06d9909c86e0 / / (21 files in 7 dirs): Changed Shebang line of python scripts. https://github.com/wesnoth/wesnoth/commit/06d9909c86e06c69794e931768cfdfa6b4323ae7
20161206 19:52:07< irker506> wesnoth: Severin Glöckner wesnoth:master bccdb549e26f / data/tools/terrain2wiki.py: terrain2wiki uses the image of the stable github branch instead of master https://github.com/wesnoth/wesnoth/commit/bccdb549e26fae6c9d3adcf20cd3d41b44969cd7
20161206 19:52:09< irker506> wesnoth: Elvish_Hunter wesnoth:master 1662abb622d2 / / (21 files in 7 dirs): Merge pull request #861 from sevu/python https://github.com/wesnoth/wesnoth/commit/1662abb622d2229c078f1b04f39a98d3403df17b
20161206 19:56:04-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161206 19:58:54< celticminstrel> Ah, good, things are getting merged. \o/
20161206 20:00:08< Elvish_Hunter> matthiaskrgr: about PR #804, you can test the script on Windows by using one of the free testing VMs kindly supplied by Microsoft: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/
20161206 20:01:33< celticminstrel> That PR just merged was Shiki, right?
20161206 20:01:38< Elvish_Hunter> Also, most of our developers are using Windows currently. Not being able to run this script might be a problem for them.
20161206 20:01:48< Shiki> yes
20161206 20:01:48< Elvish_Hunter> celticminstrel: yes.
20161206 20:03:01< Elvish_Hunter> Not to mention the fact that even a Linux system isn't guaranteed to have ImageMagick (just to say one of the tools) installed.
20161206 20:03:34< celticminstrel> I'd assume anyone who wants to run that script understands enough to install those tools first.
20161206 20:03:35-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161206 20:06:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161206 20:06:16< Elvish_Hunter> Perhaps yes. Then again, one might want to use it without reading the source code before.
20161206 20:13:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 20:23:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161206 20:23:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161206 20:27:24-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161206 20:27:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161206 20:41:09-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 20:41:10< travis-ci> wesnoth/wesnoth#12320 (master - 43fd758 : ln-zookeeper): The build was fixed.
20161206 20:41:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181750847
20161206 20:41:10-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 20:42:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161206 20:44:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161206 20:45:04-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Quit: AtomicIRC: The nuclear option.]
20161206 20:45:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 20:45:13-!- stikonas_ is now known as stikonas
20161206 20:56:28-!- gfgtdf [~chatzilla@x4e36964f.dyn.telefonica.de] has joined #wesnoth-dev
20161206 22:03:15< vultraz> hmm
20161206 22:03:21< vultraz> small problem with color_t
20161206 22:03:42< vultraz> there isn't a good bool "yes, this color was initialized" state.
20161206 22:04:14< celticminstrel> The color is always initialized.
20161206 22:04:34< celticminstrel> If you need it to maybe not be initialized, consider using boost::optional<color_t>
20161206 22:04:42< vultraz> I'm converting the animation code to color_t, and all of the default arguments/initialization values were 0.
20161206 22:04:54< vultraz> but then you have code like
20161206 22:04:55< vultraz> assert(engine_val.text_color == 0);
20161206 22:04:58< vultraz> how do I deal with this :/
20161206 22:05:04< vultraz> or
20161206 22:05:05-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 22:05:13< vultraz> result.text_color = current_val.text_color ? current_val.text_color : animation_val.text_color;
20161206 22:05:35-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 22:05:44< vultraz> I can't use .null(), since that implies 0 alpha too
20161206 22:05:50< vultraz> (as is appropriate)
20161206 22:05:51< celticminstrel> If you use optional it'd be assert(engine_val.text_color == boost::none) or even assert(!engine_val.text_color)
20161206 22:06:21< vultraz> and the default argument for alpha is opaque
20161206 22:07:01< celticminstrel> I suppose you could default-initialized them with 0 alpha and use .null()
20161206 22:07:09< celticminstrel> ^-default
20161206 22:07:29< celticminstrel> I personally think .null() is a bad idea though.
20161206 22:08:28< vultraz> yeah...
20161206 22:08:33< vultraz> null was supposed to be for gui2
20161206 22:08:42< vultraz> if you left out a color, it would be 0,0,0,0
20161206 22:08:50< vultraz> but now, we don;t do that anymore
20161206 22:09:01< vultraz> oh wait
20161206 22:09:06< vultraz> we do
20161206 22:09:08< vultraz> hmmm
20161206 22:09:28< vultraz> oh, but that's only in from_rgb[a]_string
20161206 22:15:49< gfgtdf> zookeeper: does the preoproceccor also accept spaces bewewn the # and the define like # define MACRO ? in c++ its quite commeon to indent maros the like https://github.com/wesnoth/wesnoth/blob/master/src/network_asio.hpp#L18
20161206 22:18:43-!- JyrkiVesterinen [~JyrkiVest@87-92-51-67.bb.dnainternet.fi] has quit [Quit: .]
20161206 22:20:08< zookeeper> gfgtdf, no, but i can't say i recall ever seeing anyone use "# define" in WML
20161206 22:20:52< zookeeper> err, i misread the question
20161206 22:20:53-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 22:21:24< zookeeper> no, it doesn't, so "# define MACRO" doesn't work
20161206 22:22:23< gfgtdf> zookeeper: ok thx
20161206 22:23:47< zookeeper> gfgtdf, not planning on adding that, are you?
20161206 22:23:48-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 22:25:13< gfgtdf> zookeeper: hmm no, i tought about it but it's not that important to me. So i'll rather work on somethin else, mabye http://gna.org/bugs/?25322
20161206 22:27:58< vultraz> should be simple
20161206 22:28:12< zookeeper> gfgtdf, do you recall whether we came to any conclusion about the last_breath+endlevel thing a while back?
20161206 22:28:38< zookeeper> because that's still up in the air, i believe
20161206 22:29:18< gfgtdf> zookeeper: well we found out that chan change was that this workaroudn on the c++ side https://github.com/wesnoth/wesnoth/blob/1.12/src/game_events/action_wml.cpp#L713 was revmoed.
20161206 22:30:42< celticminstrel> That workaround could easily be included in the Lua, though I'd prefer a non-Lua solution if possible...
20161206 22:31:31< DeFender1031> allowing the preprocessor to accept spaces after the # would potentially conflict with the comment syntax
20161206 22:31:50< DeFender1031> I.E. there's be no way to begin a comment with the word "define".
20161206 22:32:07< zookeeper> DeFender1031, yeah. "# define some variables here" etc, might be pretty common
20161206 22:32:08< gfgtdf> zookeeper: i dont remmeber what exactly the issue were but i still think this workaroudn was rather strange and we should adapt our wml to the changed behaviour.
20161206 22:32:31< DeFender1031> gfgtdf, it DOES accept spaces before the # though, so you can indent that way.
20161206 22:32:51< gfgtdf> DeFender1031: yes i know.
20161206 22:33:01< DeFender1031> (which looks nice even in C++ IMO)
20161206 22:33:04< DeFender1031> nicer*
20161206 22:33:41< DeFender1031> anyway, the point is, it's a bad idea to add it to WML.
20161206 22:34:46< zookeeper> gfgtdf, the issue is basically that it's almost impossible to tell where it might currently cause problems. there's a lot of die events which might now be triggering after defeat is declared in a preceding last breath event.
20161206 22:36:01< celticminstrel> It was a mistake to make preprocessor directives and comments start with the same character.
20161206 22:36:19< celticminstrel> Any votes for changing preprocessor directives to @define, @ifdef, etc?
20161206 22:36:32< zookeeper> uh...
20161206 22:36:39 * celticminstrel is only half serious.
20161206 22:41:16< gfgtdf> zookeeper: hmm well w cna just to  areext search for all die event in mainline anccheck whether tehy are effectd
20161206 22:42:28< gfgtdf> zookeeper: i'd guess that 90% of them contain only [message] and [endlevle] so uit shodu ba rther easy to check
20161206 22:44:20-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20161206 22:47:22< zookeeper> gfgtdf, yeah we could probably sort out all mainline cases, but it's still a bit of an unnerving change in behavior somehow. you'll basically have to always filter your die events so that they won't trigger if a can't-die-unit dies.
20161206 22:47:46-!- louis94 [~~louis94@91.178.241.93] has joined #wesnoth-dev
20161206 22:48:33< zookeeper> die events which aren't specific to any particular unit, that is. so, events which for example have general dialogue about units being lost, or whatever.
20161206 22:49:23< zookeeper> every "He’s raising our dead!" bit of dialogue needs to be filtered to not trigger on a bunch of hero units, etc
20161206 22:50:07< zookeeper> and sadly that's the kind of thing that will only be seen when you actually lose, so easily missed in testing
20161206 22:52:31-!- irker506 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161206 22:52:42< zookeeper> this isn't to say that the 1.12 behavior is _great_, since at least i claimed earlier that because of the code workaround, the dying unit doesn't get to play its death animation. dunno if that's actually true though.
20161206 22:56:41< gfgtdf> zookeeper: first, this doest effect all campaigns, some of our campaigns (for exampe  tHoT, DW) do the herodeths endlevel in die evnets so they arent effected, second  most even t are egher specific to units or to onyl internl bookkeeping so i think the number of events that we need to check are rather limited.
20161206 22:58:02< celticminstrel> The workaround comment says that endlevel in die events is exactly the problem.
20161206 22:58:08< gfgtdf> hmm it seems like DM does some its deths event in die and some other n last breath event, https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Delfadors_Memoirs/utils/deaths.cfg#L7 do you know why
20161206 22:58:37< gfgtdf> celticminstrel: yes that was the problem why that workarudn was added but not the problme that we have now
20161206 22:58:37< DeFender1031> celticminstrel, they don't start with the same character. Directives start with "#", comments start with "# ". As a courtesy to people who write comments badly, it also allows "#" for comments when it's not a recognized directive, but that really shouldn't be done
20161206 22:58:50< gfgtdf> celticminstrel: the original problem was fixed and thans why rteh workaround was rmeoved
20161206 22:59:01< celticminstrel> DeFender1031: Uh. That's still starting with the same character.
20161206 22:59:02< gfgtdf> thats why*
20161206 22:59:25< celticminstrel> Also, is "textdomain" a directive, a comment, or something altogether separate?
20161206 22:59:52< celticminstrel> gfgtdf: Ah, okay.
20161206 23:00:13< DeFender1031> celticminstrel, nope. comments start with two characters. :P
20161206 23:00:23< DeFender1031> (yes, i realize i'm splitting hairs here.)
20161206 23:01:23< gfgtdf> i wonder whether the comment compability is also a problem when implementing  #if as suggested http://gna.org/bugs/?22969
20161206 23:02:51< DeFender1031> gfgtdf, i'd be less concerned about adding new directives than allowing spaces, as the documentation very clearly says that it's a bad idea to not use spaces after the # in comments
20161206 23:03:40< DeFender1031> and a comment could begin with "if" as long as there's a space there, whereas if spaces were allowed for directives, no comment could ever begin with "define"
20161206 23:04:17< DeFender1031> basically, as long as there's a syntax which allows something to be represented unambiguously, it's not really an issue
20161206 23:05:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 23:06:05< zookeeper> gfgtdf, well if the dying unit needs to speak, it has to do it in a last breath event because otherwise it'll speak after a death animation and that's a bit silly
20161206 23:06:10< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\units\frame.cpp|560|error: no match for 'operator=' (operand types are 'color_t' and 'const boost::optional<color_t>')|
20161206 23:06:37< vultraz> oh, I forgot to make one optional
20161206 23:06:48< vultraz> (is there a get() function for optional or something though?_
20161206 23:06:50< vultraz> )
20161206 23:09:14< vultraz> ok now I really need a get()..
20161206 23:09:31< vultraz> oh what do you know
20161206 23:09:36< vultraz> it's called get()
20161206 23:11:29< Shiki> DeFender1031, I would never have gotten the idea that there should be a space after # 
20161206 23:12:30< DeFender1031> Shiki, https://wiki.wesnoth.org/SyntaxWML#Comments "It is a very good coding convention to always add a space immediately following a pound sign for every comment. Not only does it avoid accidentally calling a preprocessor directive (for example, a commented line that begins with the word “define”) but it also makes comments stand further apart from the code."
20161206 23:12:48< vultraz> fuck
20161206 23:13:02< DeFender1031> vultraz, ???
20161206 23:13:14< vultraz> this->is_initialized is asserting 
20161206 23:14:33-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 23:14:35< Shiki> DeFender1031, first time that I see this page
20161206 23:14:37-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 23:14:45< vultraz> celticminstrel: does one have to do something special when handling boost::optional stuff?
20161206 23:15:02< vultraz> ie, do I always have to check its validity before using .get()?
20161206 23:15:11< DeFender1031> Shiki, I hate to say it, but if you don't RTFM, you're asking for trouble.
20161206 23:15:54< vultraz> DeFender1031: FTR, I think that's a fairly recent addition to that page
20161206 23:16:03< Shiki> DeFender1031, I'm reading  a lot of the reference wml. And about everything get's answered there. But I jzst never came across that page
20161206 23:16:24 * vultraz groans
20161206 23:16:28< vultraz> another thing for me to do...
20161206 23:16:32< vultraz> finish the wiki cleanup :|
20161206 23:17:10 * DeFender1031 checks the page history
20161206 23:17:38< vultraz> huh
20161206 23:17:40< vultraz> Jan 2015
20161206 23:18:29< DeFender1031> https://wiki.wesnoth.org/index.php?title=SyntaxWML&diff=56049&oldid=52485 nearly two years ag- yeah
20161206 23:18:37-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has joined #wesnoth-dev
20161206 23:19:58< vultraz> time to fire up the debugger
20161206 23:19:59-!- RatArmy_ [~ratarmy@om126161112077.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161206 23:20:23< zookeeper> gfgtdf, celticminstrel, anyway, we can try to fix all mainline cases. if they're all easy enough to do then i guess someone just has to write a forum post informing UMC folks about it (i think that's the kind of weird behavioral change that needs more than a... well, we can't add a changelog for it anymore). there's 269 matches for "name=die" in mainline campaigns.
20161206 23:20:48< vultraz> ...
20161206 23:20:56< vultraz> did someone make GUI2 fire Infinite Exceptions
20161206 23:21:06< zookeeper> yeah, i did that while you weren't looking
20161206 23:21:14< zookeeper> i thought it'd be a funny prank
20161206 23:21:21< DeFender1031> vultraz, i did know that line was there since I originally read up on WMl
20161206 23:23:21-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20161206 23:23:22< travis-ci> gfgtdf/wesnoth-old#714 (master - f305389 : gfgtdf): The build has errored.
20161206 23:23:22< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181789861
20161206 23:23:22-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20161206 23:24:52< celticminstrel> vultraz: Yes. if(optional_val) is sufficient, as if it were a pointer. (But don't use if(optional_val == nullptr), because it's not actually a pointer.)
20161206 23:26:16-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161206 23:29:20-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161206 23:39:26-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161206 23:40:31< celticminstrel> Speaking of WML syntax, I made this page: https://wiki.wesnoth.org/GrammarWML
20161206 23:40:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161206 23:40:56< celticminstrel> Mainly becaus fabi asked for a grammar, but I imagine it could be useful for someone (and also could use improvement from code-reading).
20161206 23:41:44< DeFender1031> celticminstrel, nice.
20161206 23:41:52< celticminstrel> ^because
20161206 23:42:34< celticminstrel> Also, it's orphaned... now that it's not horrible maybe I should link to it from some other page.
20161206 23:42:43-!- louis94 [~~louis94@91.178.241.93] has quit [Ping timeout: 268 seconds]
20161206 23:45:19-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 258 seconds]
20161206 23:48:05-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161206 23:49:14< vultraz> celticminstrel: can you confirm a bug?
20161206 23:49:26< vultraz> (can you run a debugger right now)
20161206 23:49:33-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161206 23:50:51< vultraz> celticminstrel: well, when you can, run wesnoth in a debugger and open a dialog with scrollbars like Load Game
20161206 23:51:01< vultraz> celticminstrel: usually, this throws an exception due to scrollbars
20161206 23:51:15< vultraz> I used to be able to bypass it with 'continue' (gdb)
20161206 23:51:22< vultraz> but now when I use continue, it keeps rethrowing
20161206 23:55:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161206 23:59:54< vultraz> there was a change recently to event handling
--- Log closed Wed Dec 07 00:00:18 2016