--- Log opened Wed Dec 07 00:00:18 2016
20161207 00:00:32< vultraz> problem is
20161207 00:00:41< vultraz> I can't find out where this assertion is coming from now :|
20161207 00:02:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161207 00:10:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 00:11:07-!- irker971 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161207 00:11:07< irker971> wesnoth: Charles Dang wesnoth:master f2d730bd86d6 / src/units/ (8 files): Convert unit animation code to use color_t https://github.com/wesnoth/wesnoth/commit/f2d730bd86d6b8b97d89d3f92176a44af6026dc4
20161207 00:11:19< vultraz> Aginor: ^ should be the rest of the color_t conversion, barring outlying cases
20161207 00:22:33< Aginor> ok
20161207 00:23:09< vultraz> did you see the CVideo cleanup earlier?
20161207 00:23:49< Aginor> no
20161207 00:24:02< Aginor> I generally don't review commits on master
20161207 00:24:14< vultraz> well, I had pinged you
20161207 00:24:21< vultraz> anyway,  i just cleaned up a bunch of cruft
20161207 00:24:41< vultraz> including update_rect
20161207 00:25:57< Aginor> I don't think I noticed being pinged either
20161207 00:26:26< Aginor> if you really want my feedback on something, best way is to do it through a PR
20161207 00:26:48< vultraz> I see
20161207 00:27:06< Aginor> I'm so-so with paying attention to IRC or all of the commits flying past, a PR comes through as an email, which I do pay attention to
20161207 00:30:22< vultraz> Anyway, I think I've gotten rid of all the custom sdl flags and any remaining SDL 1.2 cruft sitting around
20161207 00:31:35< Aginor> ok
20161207 00:32:17< vultraz> CVideo is cleaned up, and color_t has been deployed
20161207 00:32:28< vultraz> anything specifically you'd like me to work on next?
20161207 00:32:33< vultraz> specific
20161207 00:33:37< irker971> wesnoth: Charles Dang wesnoth:master 95ab15c13cb4 / src/events.cpp: Removed two unnecessary includes https://github.com/wesnoth/wesnoth/commit/95ab15c13cb411b4613547b81cb322b56c7e3201
20161207 00:33:53< vultraz> oh, that window stack class
20161207 00:33:58< vultraz> I forgot about that
20161207 00:41:46< celticminstrel> vultraz: Not sure if such a test would be useful since you're using MinGW while my Windows build uses msvcp.
20161207 00:41:51< Aginor> vultraz: no, do what you see fit
20161207 00:43:33-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 00:43:33< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Elvish_Hunter 1662abb: Merge pull request #861 from sevu/python Succeeded
20161207 00:43:33< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-20
20161207 00:43:33< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1662abb622d2229c078f1b04f39a98d3403df17b
20161207 00:43:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 00:47:09< vultraz> AHHHHH
20161207 00:47:13< vultraz> I've found chars_equal_insensitive :|
20161207 00:47:22< celticminstrel> Oh my!
20161207 00:47:31< celticminstrel> Note that that's not necessarily identical to icompare/
20161207 00:47:35< vultraz> I thought this was an stdlib function
20161207 00:47:42< vultraz> and I've been looking everywhere for it
20161207 00:47:55< celticminstrel> There is a semistandard stdlib function that does that.
20161207 00:49:48< vultraz> being?
20161207 00:51:02< celticminstrel> Depends on your platform. (That's why it's semistandard.)
20161207 00:51:25< celticminstrel> What's it used for in Wesnoth?
20161207 00:51:54< vultraz> string matching
20161207 00:52:19< vultraz> basically in the filter_text_match functions that are copied too all dialogs with filter textboxes
20161207 00:52:39< vultraz> found = std::search(type_label.get_label().str().begin(), type_label.get_label().str().end(), word.begin(), word.end(), chars_equal_insensitive) != type_label.get_label().str().end();
20161207 00:52:54< vultraz> for c++17 I think we should probably use std::make_boyer_moore_searcher
20161207 00:53:03< celticminstrel> Seems like translation::icompare would give the expected result then.
20161207 00:53:09< celticminstrel> ...use what now.
20161207 00:53:22< vultraz> http://en.cppreference.com/w/cpp/utility/functional/boyer_moore_searcher
20161207 00:53:25< celticminstrel> Also, it's far, far too early to talk about C++17.
20161207 00:53:52< celticminstrel> Wait until at least 2020 before even considering it. (And that's assuming it actually finalizes next year.)
20161207 00:55:57< vultraz> I wonder if std::lexicographical_compare could be used now
20161207 00:56:23< celticminstrel> That's for containers. (Which does include strings, though.) But why use that when icompare already exists?
20161207 00:56:54< vultraz> doesn't that deal with translations?
20161207 00:58:10< celticminstrel> Not directly, but it gives a locale-sensitive comparison.
20161207 00:58:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161207 01:00:18-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 01:00:56< vultraz> I do need to make this a GUI2 utility function
20161207 01:06:48< vultraz> how come sometimes you can have implemented functions without a class in the header and sometimes not
20161207 01:06:58< vultraz> or is it only templated functions that can do that
20161207 01:07:07-!- Appleman1234_ [~Appleman1@KD106161198145.au-net.ne.jp] has joined #wesnoth-dev
20161207 01:07:56-!- Appleman1234 [~Appleman1@KD106161205160.au-net.ne.jp] has quit [Disconnected by services]
20161207 01:08:00-!- Appleman1234_ is now known as Appleman1234
20161207 01:08:47-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 01:08:47< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Elvish_Hunter 1662abb: Merge pull request #861 from sevu/python Succeeded
20161207 01:08:47< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-20
20161207 01:08:47< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1662abb622d2229c078f1b04f39a98d3403df17b
20161207 01:08:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 01:09:02< celticminstrel> I'm not entirely sure what you mean, but templates need their entire definition visible, so if they're public (which also implies being in the header) then they need to be implemented in the header.
20161207 01:09:35< celticminstrel> If they're private they don't need to be implemented in the header unless something else that is implemented in the header uses them.
20161207 01:09:52< vultraz> I found out recently one cannot fully implement a (non-templated, I guess) function in a header without a class
20161207 01:10:01< vultraz> or a struct
20161207 01:10:06< celticminstrel> What are you talking about?
20161207 01:10:24< celticminstrel> Oh, wait, you mean putting an entire function definition in the header?
20161207 01:10:28< vultraz> yes
20161207 01:10:34< celticminstrel> BTW, that fails just as much for templated functions.
20161207 01:10:43< celticminstrel> In both cases you need the inline keyword to fix it.
20161207 01:11:05< celticminstrel> Though if it's not a template you can just move it to the source file instead.
20161207 01:11:25< vultraz> so why is this fine: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/helper.hpp#L33
20161207 01:12:11< celticminstrel> It's not.
20161207 01:12:22< celticminstrel> I think.
20161207 01:12:38< celticminstrel> If that was called in two different source files with the same template arguments, I think it would give you a compile error.
20161207 01:12:45< celticminstrel> Sorry, a link error.
20161207 01:14:05< celticminstrel> Assuming I'm right, it probably only works because no two source files that use it use the same template arguments. Which seems like a totally likely situation, given what it's used for.
20161207 01:14:18< vultraz> that function is never called, only bound
20161207 01:14:26< celticminstrel> By the way, is there any reason not to delete that whole file?
20161207 01:14:37< celticminstrel> Whether it's called or bound makes no difference.
20161207 01:14:42< celticminstrel> Either way the template is instantiated.
20161207 01:14:42< vultraz> I was going to put something in i
20161207 01:14:44< vultraz> t
20161207 01:14:50< celticminstrel> Oh. Like what?
20161207 01:15:01< vultraz> [12:00:55]	vultraz	I do need to make this a GUI2 utility function
20161207 01:15:23< celticminstrel> But I don't know what "this" was.
20161207 01:15:43< vultraz> the general 'filter listbox based on text filter results'
20161207 01:15:46< vultraz> function
20161207 01:16:24< celticminstrel> Does this already exist somewhere?
20161207 01:16:47< vultraz> it's copied to multiple dialogs
20161207 01:16:55< celticminstrel> Link one?
20161207 01:17:59< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/unit_create.cpp#L209
20161207 01:20:24-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 01:20:32-!- RatArmy_ [~ratarmy@om126211116091.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 01:23:01-!- RatArmy_ [~ratarmy@om126211116091.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 01:23:17-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161207 01:28:42< gfgtdf> vultraz: https://github.com/wesnoth/wesnoth/commit/95ab15c13cb411b4613547b81cb322b56c7e3201 is not a good candidate for [ci skip] since those commits can break complication even it it compiled for you locally.
20161207 01:30:16< gfgtdf> vultraz: it is possible that one of those headers  incuded some other (std) header that is then missing in that file. And the tree in which standard header include other standard headers is different among the compilers.
20161207 01:36:39-!- RatArmy_ [~ratarmy@om126211116091.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 01:37:09< celticminstrel> Agreed. In general I'd suggest that anything touching C++ code shouldn't be [ci skip], unless it's something like only changing comments.
20161207 01:37:36< celticminstrel> Big WML or Lua changes probably shouldn't be either, since they could potentially break WML tests.
20161207 01:38:44< celticminstrel> So anyway, if SotA is being added, what about ... what was it, OoA?
20161207 01:39:10< celticminstrel> I assume the other beetlenaut one is not being added?
20161207 01:39:11-!- RatArmy_ [~ratarmy@om126211116091.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 01:39:30-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 01:41:07-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 01:41:07< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 95ab15c: Removed two unnecessary includes Succeeded
20161207 01:41:07< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-21
20161207 01:41:07< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/95ab15c13cb411b4613547b81cb322b56c7e3201
20161207 01:41:11-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 01:45:23-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 01:45:38-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 01:50:08< gfgtdf> hmm Appveyor doesnt seem to understand [ci skip], mabe is possible to configure it to respect ci skip aswell ?
20161207 01:51:56< celticminstrel> gfgtdf: It's totally irrelevant for Appveyor with the current configuration.
20161207 01:52:06< celticminstrel> Since it builds on a fixed schedule.
20161207 01:52:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 01:53:05< gfgtdf> celticminstrel: so it build even when no new commits were made ?
20161207 01:53:11< celticminstrel> Apparently.
20161207 01:53:36< celticminstrel> There were some issues getting it to build in response to a push.
20161207 01:53:53< celticminstrel> It's supposed to support it, but apparently it didn't work.
20161207 01:53:59< gfgtdf> celticminstrel: can i download the generated executables from Appveyor like i can from our jebkins ci?
20161207 01:54:05< celticminstrel> No idea.
20161207 01:54:30< celticminstrel> Pretty sure there is no jenkins CI, and Travis isn't set up for that either.
20161207 01:55:52< gfgtdf> celticminstrel: well maybe ci is the wrong word but jenkins also does timed wensoth build
20161207 01:56:16< celticminstrel> Since when has there been such a thing.
20161207 01:56:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161207 01:56:43< gfgtdf> celticminstrel: you can doanload lastet master executable http://baldras.wesnoth.org:8080/job/Wesnoth/branch=master,compiler=mingw32,label=Gentoo-64/ws/
20161207 01:57:08< gfgtdf> celticminstrel: its there since quite long, afaik loonycyborg maintains it.
20161207 02:00:41< Shiki> Last Success   	2 yr 1 mo - #248
20161207 02:01:10< gfgtdf> Shiki: hmm but this mean last succes on all builds, a few builds are borken, but most of them work
20161207 02:02:48< Shiki> ah, so that's fine
20161207 02:03:42-!- gfgtdf_ [~chatzilla@x4e368245.dyn.telefonica.de] has joined #wesnoth-dev
20161207 02:04:47< gfgtdf_> someone said somthign while i reconnected?
20161207 02:05:45-!- gfgtdf [~chatzilla@x4e36964f.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161207 02:05:51-!- gfgtdf_ is now known as gfgtdf
20161207 02:06:06-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 02:06:06< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 95ab15c: Removed two unnecessary includes Succeeded
20161207 02:06:06< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-21
20161207 02:06:06< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/95ab15c13cb411b4613547b81cb322b56c7e3201
20161207 02:06:10-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 02:06:47< Shiki> Not really
20161207 02:09:17-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 02:09:18< travis-ci> gfgtdf/wesnoth-old#715 (master - 1b0cac8 : gfgtdf): The build failed.
20161207 02:09:18< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181833691
20161207 02:09:18-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 02:21:12-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20161207 02:29:02-!- serin| [~serin@209.77.159.143.dyn.plus.net] has quit [Ping timeout: 250 seconds]
20161207 02:48:00-!- serin| [~serin@209.77.159.143.dyn.plus.net] has joined #wesnoth-dev
20161207 02:49:43-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 02:49:49-!- RatArmy_ [~ratarmy@om126211120010.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 02:52:22-!- RatArmy_ [~ratarmy@om126211120010.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 02:53:24-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 03:05:23-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 03:05:24< travis-ci> gfgtdf/wesnoth-old#716 (master - 320bd0b : gfgtdf): The build was fixed.
20161207 03:05:24< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/181841466
20161207 03:05:24-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 03:08:48< gfgtdf> oh fixed
20161207 03:10:59-!- RatArmy_ is now known as RatArmy
20161207 03:14:07< irker971> wesnoth: gfgtdf wesnoth:master 43ac6ca037ef / src/gui/ (4 files in 2 dirs): refactor gui2::register_widget https://github.com/wesnoth/wesnoth/commit/43ac6ca037ef1ee8fc7608ef8185a57e6de046b1
20161207 03:14:09< irker971> wesnoth: gfgtdf wesnoth:master 118d18ec7a01 / src/ (6 files in 3 dirs): add lua add_widget_definition function https://github.com/wesnoth/wesnoth/commit/118d18ec7a016b81ee6fc540eae8f8f7c2945431
20161207 03:14:11< irker971> wesnoth: gfgtdf wesnoth:master 283fd32077b7 / src/ (5 files in 2 dirs): remove added widget definitions on lua kernel destruction. https://github.com/wesnoth/wesnoth/commit/283fd32077b7c9c9ed129799ada2a4e037eaf53b
20161207 03:14:13< irker971> wesnoth: gfgtdf wesnoth:master 1202eb160edd / src/ (8 files in 3 dirs): Merge pull request #895 from gfgtdf/master https://github.com/wesnoth/wesnoth/commit/1202eb160edd1a454d09e3c6f9fcda90f432670b
20161207 03:24:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161207 03:41:48-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-sxihadzlgpytzysg] has quit [Ping timeout: 246 seconds]
20161207 03:41:50-!- gfgtdf [~chatzilla@x4e368245.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161207 03:43:51-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-gddpaiwckcnmrtlz] has joined #wesnoth-dev
20161207 03:44:14-!- matthiaskrgr is now known as Guest42664
20161207 04:09:53-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20161207 04:34:07-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161207 04:40:03-!- serin| [~serin@209.77.159.143.dyn.plus.net] has quit [Ping timeout: 245 seconds]
20161207 04:43:11-!- serin| [~serin@209.77.159.143.dyn.plus.net] has joined #wesnoth-dev
20161207 05:04:01-!- JyrkiVesterinen [~JyrkiVest@87-100-172-68.bb.dnainternet.fi] has joined #wesnoth-dev
20161207 05:15:37-!- FinalBossDad_ [sid1929@gateway/web/irccloud.com/x-hpqblsltxjldxaxu] has joined #wesnoth-dev
20161207 05:15:53-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 260 seconds]
20161207 05:15:54-!- FinalBossDad [sid1929@gateway/web/irccloud.com/x-rjhyplavlcrdrjzk] has quit [Ping timeout: 260 seconds]
20161207 05:17:00< JyrkiVesterinen> gfgtdf: If you need it, I can turn on packaging of AppVeyor executables: https://www.appveyor.com/docs/packaging-artifacts/
20161207 05:17:14< JyrkiVesterinen> Although I'd first like to hear what you need them for.
20161207 05:17:45< vultraz> not really useful unless we want to do dev/nightly builds
20161207 05:20:29-!- Samual [~Samual@2601:547:1000:86f:713a:ea29:1bb1:5735] has joined #wesnoth-dev
20161207 05:20:29-!- Samual [~Samual@2601:547:1000:86f:713a:ea29:1bb1:5735] has quit [Changing host]
20161207 05:20:29-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20161207 05:23:31-!- Appleman1234 [~Appleman1@KD106161198145.au-net.ne.jp] has left #wesnoth-dev ["Leaving"]
20161207 05:23:48-!- Appleman1234 [~Appleman1@KD106161198145.au-net.ne.jp] has joined #wesnoth-dev
20161207 05:27:19-!- RatArmy_ [~ratarmy@om126229084095.12.openmobile.ne.jp] has joined #wesnoth-dev
20161207 05:27:28-!- RatArmy_ [~ratarmy@om126229084095.12.openmobile.ne.jp] has quit [Remote host closed the connection]
20161207 05:27:30-!- RatArmy [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 05:27:43-!- RatArmy_ [~ratarmy@om126229084095.12.openmobile.ne.jp] has joined #wesnoth-dev
20161207 05:29:55-!- RatArmy_ [~ratarmy@om126229084095.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 05:30:03-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 05:43:25< EliDupree> Sweet! We found a repeatable test case for the segmentation fault with EoHS zombies. It's practically my bedtime now though, so I'll investigate some other day
20161207 05:59:13-!- JyrkiVesterinen [~JyrkiVest@87-100-172-68.bb.dnainternet.fi] has quit [Quit: .]
20161207 06:12:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 06:14:26-!- irker971 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161207 06:16:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161207 06:44:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161207 06:44:41-!- JyrkiVesterinen [~JyrkiVest@85-76-111-42-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161207 07:04:04< vultraz> hmm
20161207 07:04:17< vultraz> the "new" lexical cast impl doesn't seem to have an equivalent for lexical_cast_default
20161207 07:06:44-!- celticminstrel is now known as celmin|sleep
20161207 07:29:15-!- Guest42664 [matthiaskr@gateway/shell/panicbnc/x-gddpaiwckcnmrtlz] has quit [Changing host]
20161207 07:29:15-!- Guest42664 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161207 07:29:15-!- Guest42664 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20161207 07:29:15-!- Guest42664 [matthiaskr@gateway/shell/panicbnc/x-gddpaiwckcnmrtlz] has joined #wesnoth-dev
20161207 07:29:24-!- Guest42664 is now known as matthiaskrgr
20161207 07:32:37-!- htee [~htee@dtcqfkygytlcdrb7jpkyt-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161207 07:32:44-!- htee [~htee@dtcqfkygytlcdrb7jpkyt-3.rev.dnainternet.fi] has quit [Client Quit]
20161207 08:00:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 08:05:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161207 08:15:02< vultraz> blagh
20161207 08:15:21< vultraz> deployed the "new" lexical_cast code, but now something's throwing bad_lexical_cast 
20161207 08:18:59-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 08:19:02< vultraz> ah, 
20161207 08:19:04< vultraz> found it
20161207 08:42:53-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 08:42:53< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 1202eb1: Merge pull request #895 from gfgtdf/master Succeeded
20161207 08:42:53< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-21
20161207 08:42:53< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1202eb160edd1a454d09e3c6f9fcda90f432670b
20161207 08:42:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 08:45:18-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 08:52:26-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 08:52:41-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20161207 08:54:46-!- irker814 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161207 08:54:47< irker814> wesnoth: Charles Dang wesnoth:master 626d6c63cb52 / src/ (16 files in 10 dirs): Made use of the "new" lexical_cast implementation https://github.com/wesnoth/wesnoth/commit/626d6c63cb52d574aa1a1cf928892463c6c16b84
20161207 08:54:47-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20161207 08:54:49< irker814> wesnoth: Charles Dang wesnoth:master 81e331331262 / src/ (game_preferences.cpp preferences.cpp settings.cpp util.hpp): Removed lexical_cast_in_range in favor of util::clamp + lexical_cast_default https://github.com/wesnoth/wesnoth/commit/81e331331262d7d84d83ae8c184e41bf610aa3f2
20161207 08:56:02-!- RatArmy_ [~ratarmy@om126211125019.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 09:02:02-!- RatArmy_ [~ratarmy@om126211125019.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 09:08:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 09:08:09< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf 1202eb1: Merge pull request #895 from gfgtdf/master Succeeded
20161207 09:08:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-21
20161207 09:08:09< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1202eb160edd1a454d09e3c6f9fcda90f432670b
20161207 09:08:10-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20161207 09:08:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 09:17:14< Aginor> hmmm
20161207 09:17:35< Aginor> sdl_joystick vs sdl_gamepad
20161207 09:17:58< JyrkiVesterinen> If you're naming a class, I find sdl_gamepad a better name.
20161207 09:18:06< JyrkiVesterinen> Because gamepads are more common that joysticks.
20161207 09:18:18< JyrkiVesterinen> *than
20161207 09:20:28< irker814> wesnoth: Charles Dang wesnoth:master aeb768c7aad7 / src/font/marked-up_text.cpp: Revert accidental change in 626d6c63cb52 https://github.com/wesnoth/wesnoth/commit/aeb768c7aad70fb0bb0eb76e1ecd3f1cc52f1265
20161207 09:20:31< irker814> wesnoth: Charles Dang wesnoth:master 2eeec1cf7acd / src/lexical_cast.hpp: lexical_cast: made use of noexcept as recommended https://github.com/wesnoth/wesnoth/commit/2eeec1cf7acd4272ac82b916d358448fa025d770
20161207 09:20:55< Aginor> JyrkiVesterinen: no, I'm reintroducing joystick hotkeys
20161207 09:21:18< Aginor> but I'm also looking at it, going "this should be gamepads, not joysticks"
20161207 09:24:05< vultraz> isn't the term "controller"
20161207 09:25:48< Aginor> it was called joystick in sdl 1.2, so I think that was carried across into the game
20161207 09:26:26< vultraz> I don't recommend calling it a joystick
20161207 09:26:28< vultraz> those are rare
20161207 09:26:51< vultraz> I mean, I have one, but only because I used to play this flight sim.
20161207 09:26:55< vultraz> and no one uses the term "gamepad"
20161207 09:27:02< vultraz> "controller" is the way to go
20161207 09:33:34-!- RatArmy_ [~ratarmy@om126211125019.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 09:34:43< vultraz> JyrkiVesterinen: should I be able to remove these lines? https://github.com/wesnoth/wesnoth/blob/master/src/lexical_cast.hpp#L44-L51
20161207 09:34:48-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 09:34:49< travis-ci> wesnoth/wesnoth#12326 (master - 81e3313 : Charles Dang): The build was broken.
20161207 09:34:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181897756
20161207 09:34:49-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 09:37:14< JyrkiVesterinen> MSVC #defines you can remove. A quick check showed that strtoll() (and likely strtoull(), although I didn't check) was implemented in VS2013.
20161207 09:37:29< irker814> wesnoth: Charles Dang wesnoth:master fe5089fdd1ab / src/gui/dialogs/lua_interpreter.cpp: Add include to satisfy Travis https://github.com/wesnoth/wesnoth/commit/fe5089fdd1ab83a7a85f84fa38a4a7435df71b6e
20161207 09:38:16-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161207 09:38:17< JyrkiVesterinen> I would leave the FreeBSD #define there. There aren't many players on FreeBSD: if you break something, it will be a long time before anyone is going to let us know.
20161207 09:38:46< vultraz> alright
20161207 09:40:10-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 09:40:10< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release gfgtdf 1202eb1: Merge pull request #895 from gfgtdf/master Succeeded
20161207 09:40:10< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-22
20161207 09:40:10< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1202eb160edd1a454d09e3c6f9fcda90f432670b
20161207 09:40:14-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 09:48:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 09:53:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161207 09:59:23< irker814> wesnoth: Charles Dang wesnoth:master 7664147cdca7 / src/lexical_cast.hpp: lexical_cast: removed some legacy MSVC defines https://github.com/wesnoth/wesnoth/commit/7664147cdca7896d4b27253c82bf36d45d7e1550
20161207 10:06:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 10:06:42< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug gfgtdf 1202eb1: Merge pull request #895 from gfgtdf/master Succeeded
20161207 10:06:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-22
20161207 10:06:42< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/1202eb160edd1a454d09e3c6f9fcda90f432670b
20161207 10:06:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 10:08:51-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 10:08:52< travis-ci> wesnoth/wesnoth#12327 (master - 2eeec1c : Charles Dang): The build was broken.
20161207 10:08:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181902876
20161207 10:08:52-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 10:23:51-!- JyrkiVesterinen [~JyrkiVest@85-76-111-42-nat.elisa-mobile.fi] has quit [Quit: .]
20161207 10:49:35-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 10:49:36< travis-ci> wesnoth/wesnoth#12328 (master - fe5089f : Charles Dang): The build has errored.
20161207 10:49:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181906292
20161207 10:49:36-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 11:04:47< irker814> wesnoth: Charles Dang wesnoth:master 02ea491bff54 / src/server/ (sample_user_handler.cpp server_base.cpp): Fix wesnothd build https://github.com/wesnoth/wesnoth/commit/02ea491bff54c774bec6ca7a46eb253427333fef
20161207 11:10:49-!- JyrkiVesterinen [~JyrkiVest@85-76-111-42-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161207 11:34:50< irker814> wesnoth: Charles Dang wesnoth:master 5637dfa8f0e9 / projectfiles/CodeBlocks/wesnothd.cbp: Add color.*pp to CB wesnothd projectfile https://github.com/wesnoth/wesnoth/commit/5637dfa8f0e9c28a96ca21beee11741c1694b1ac
20161207 11:47:56-!- RatArmy_ [~ratarmy@om126211125019.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20161207 11:54:27-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 252 seconds]
20161207 11:56:12-!- louis94 [~~louis94@91.178.242.211] has joined #wesnoth-dev
20161207 11:56:42-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has quit [Ping timeout: 246 seconds]
20161207 11:57:01-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20161207 12:09:43-!- RatArmy_ [~ratarmy@om126211125019.13.openmobile.ne.jp] has joined #wesnoth-dev
20161207 12:12:37-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 12:12:38< travis-ci> wesnoth/wesnoth#12330 (master - 02ea491 : Charles Dang): The build has errored.
20161207 12:12:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181926288
20161207 12:12:38-!- travis-ci [~travis-ci@ec2-54-198-62-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 12:15:22< irker814> wesnoth: Charles Dang wesnoth:master f07e8622ee77 / src/campaign_server/campaign_server.cpp: More include fixup https://github.com/wesnoth/wesnoth/commit/f07e8622ee77336fa391182779eca483921e8943
20161207 12:53:57-!- louis94 [~~louis94@91.178.242.211] has quit [Ping timeout: 248 seconds]
20161207 13:07:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161207 13:16:00-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 13:16:01< travis-ci> wesnoth/wesnoth#12331 (master - f07e862 : Charles Dang): The build failed.
20161207 13:16:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181940744
20161207 13:16:02-!- travis-ci [~travis-ci@ec2-54-205-111-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 13:21:07-!- Kwandulin [~Miranda@p200300760F6EBF2584CDA3B5BE9EBF05.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161207 13:22:22< irker814> wesnoth: Charles Dang wesnoth:master 6d11a8df388d / src/tests/ (test_make_enum.cpp test_util.cpp): Fixup test includes https://github.com/wesnoth/wesnoth/commit/6d11a8df388d30843f741b4dd21e9f47eb880b3d
20161207 13:24:28-!- gfgtdf [~chatzilla@x4e368245.dyn.telefonica.de] has joined #wesnoth-dev
20161207 13:37:20< vultraz> ok, I have a replacement for lexical_cast default
20161207 13:37:29< vultraz> lexical_cast_default*
20161207 13:43:09< gfgtdf> vultraz: iirc the old lexical_cast implementaion was broken at some point where it also accepts strings like "234sometext" which the new one doesn't, the new bahviour is the better abhviour but its still posible that this casues bugs when some random code relied on the odl behaviour
20161207 13:43:34< vultraz> then better to fix the code
20161207 14:21:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161207 14:21:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161207 14:30:40-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has joined #wesnoth-dev
20161207 14:30:41< travis-ci> wesnoth/wesnoth#12332 (master - 6d11a8d : Charles Dang): The build was fixed.
20161207 14:30:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/181955601
20161207 14:30:41-!- travis-ci [~travis-ci@ec2-54-92-248-53.compute-1.amazonaws.com] has left #wesnoth-dev []
20161207 14:33:25< vultraz> heh
20161207 14:33:33< vultraz> I'll probably break it again soon
20161207 15:04:08< vultraz> blagh
20161207 15:05:19< vultraz> ok, I'm just gonna push the impl 
20161207 15:05:26< irker814> wesnoth: Charles Dang wesnoth:master 87405f8f89c1 / src/lexical_cast.hpp: Added optional second fallback value argument to lexical_cast https://github.com/wesnoth/wesnoth/commit/87405f8f89c1ca3828b03769c9616b9bcb0c663b
20161207 15:05:40< vultraz> Hopefully I'll get some feedback on that
20161207 15:06:45< vultraz> while it works for "providing a default value", it seems a bunch of places in the code used it to simply return T() on fail
20161207 15:06:54< vultraz> s/it/lexical_cast_default
20161207 15:07:29< vultraz> however..
20161207 15:07:42< JyrkiVesterinen> Your implementation looks good to me in a quick check.
20161207 15:07:43< vultraz> I *think* the new implementation does that implicitly 
20161207 15:08:50< vultraz> hmm...
20161207 15:09:38< vultraz> (the problem I'm having locally is wesnoth won't even start, I get bad_lexical_cast)
20161207 15:09:42< JyrkiVesterinen> No, that doesn't happen. The fallback parameter is boost::none by default, and thus the default behavior is to throw bad_lexical_cast if the lexical cast fails.
20161207 15:09:46< vultraz> I think I understand why
20161207 15:09:55< vultraz> yeah I was about to say that
20161207 15:10:18< vultraz> l_c_d never threw, only returned To() on fail
20161207 15:10:46< vultraz> which means for every case of l_c_d, I now need to essentially provide the second argument or get bad_lexical_cast
20161207 15:12:44< vultraz> or restructure the code to not rely on lexical_cast to initialize variables
20161207 15:13:05< vultraz> which is really not the intended usecase >_>
20161207 15:14:02< vultraz> I'll finish this tomorrow
20161207 15:14:08< celmin|sleep> Yay?
20161207 15:14:40< vultraz> I have most of the code locally, but I still need to figure out where wesnoth is throwing b_l_c
20161207 15:15:31< vultraz> my debugger is absolutely useless right now, for some reason
20161207 15:16:27< vultraz> must make... debug build!
20161207 15:21:41-!- JyrkiVesterinen [~JyrkiVest@85-76-111-42-nat.elisa-mobile.fi] has quit [Quit: Going home]
20161207 15:25:09-!- celmin|sleep is now known as celticminstrel
20161207 15:48:20< gfgtdf> vultraz: i think its better to keep the curent make lecial_cast_default ad lexical_cast, you codul for examepl keep the implementation:: code than then just define the interface as http://pastebin.com/8ts1PgKN
20161207 15:49:38< vultraz> why?
20161207 15:51:18-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161207 15:53:27< vultraz> gfgtdf: also, then there's no way to check whether the second argument was provided or not
20161207 15:54:06< gfgtdf> vultraz: what do you eja exactly ?
20161207 15:54:50< gfgtdf> vultraz: it'd behave exactly as teh odl lexicl_cast default
20161207 15:55:12< vultraz> well, unless lexical_cast_default uses boost::optional<To> fallback = To();
20161207 15:55:30< vultraz> but why do you recommend this?
20161207 15:57:47< vultraz> I suppose it couldn't hurt
20161207 15:57:52< vultraz> I'll think about it tomorrow
20161207 15:58:37< gfgtdf> jut personaly taste i guess, habing 2 siddferent function form which oen can throw looks better to me than jus having one function which can throw if a second argument was not given.
20161207 15:59:05< gfgtdf> also boost::optional make the interface a little more complicated for people who don't know it.
20161207 16:03:55< vultraz> I'd still have to use it tho
20161207 16:04:05< vultraz> for the implementation
20161207 16:08:31< gfgtdf> hmm yes but he use doesnt have to know uit, plus its also possible to implement it without boost::optionl, jut add 'get_default_value' template paremter to implementation::lexical_caster, and callll it like http://pastebin.com/qQWmHDes
20161207 16:10:10< Shiki> Hey, you two. there's an bug with combat animations ... I think one of your two commits an on animation.*pp broke sth
20161207 16:14:56< celticminstrel> Well, we already know it broke at least one thing (which I already fixed).
20161207 16:15:20< celticminstrel> What's the bug?
20161207 16:17:40< Shiki> I saw recently your fix, it just broke sth else again. Melee combat animations either don't display or they don't move into the others. hex. I guess the later one.
20161207 16:18:20< Shiki> and missile_frames don't move either
20161207 16:19:15< celticminstrel> I doubt my fix broke something else.
20161207 16:20:00< Shiki> No, after your fix on animations.cpp everything was fine
20161207 16:20:06< celticminstrel> Okay.
20161207 16:21:30< Shiki> There are two new commits on animations.cpp since then.
20161207 16:21:49< celticminstrel> I'd guess more likely f2d730b, but not really sure.
20161207 16:22:36< EliDupree> Hooray! Reduced the segmentation fault to a "simple" test case ("load the save and then end turn", even though the scenario is complicated)
20161207 16:23:50< celticminstrel> That commit honestly doesn't seem very likely either.
20161207 16:30:15< celticminstrel> I suppose there's the option of reverting it to see if it's the cause.
20161207 16:31:01< celticminstrel> I don't see anything obvious in the commit that could go wrong, but I was a little suspicious of changing 0 to {0,0,0} in several places.
20161207 16:31:06< Shiki> ok, it's none of the both..
20161207 16:31:16< Shiki> i just reverted them
20161207 16:31:25< celticminstrel> Okay.
20161207 16:32:48-!- JyrkiVesterinen [~JyrkiVest@89-166-108-22.bb.dnainternet.fi] has joined #wesnoth-dev
20161207 16:38:49< EliDupree> OMFG, my save file was 1078 out of the gna.org limit of 1024 kB :(
20161207 16:39:24< EliDupree> What should I do?
20161207 16:39:26< zookeeper> try higher compression? :p
20161207 16:39:32< EliDupree> -_-
20161207 16:43:05< zookeeper> post a link instead of an attachment, or get the filesize below the limit however you can. but i'd think you knew those already
20161207 16:43:46< EliDupree> Yeah, I'm just trying to find the easiest way to upload it somewhere else and link
20161207 16:44:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 16:44:42< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 87405f8: Added optional second fallback value argument to lexical_cast Succeeded
20161207 16:44:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-22
20161207 16:44:42< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87405f8f89c1ca3828b03769c9616b9bcb0c663b
20161207 16:44:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 16:45:33< EliDupree> ...My Windows computer doesn't have a program that can decompress a gzip?!
20161207 16:46:39< JyrkiVesterinen> 7-Zip can decompress it and it's a very common program.
20161207 16:46:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 16:47:34< JyrkiVesterinen> And if you're looking for a program to decompress gzip on Windows, I recommend Universal Extractor 2: https://github.com/Bioruebe/UniExtract2/releases
20161207 16:47:49< JyrkiVesterinen> It can decompress pretty much anything you throw at it.
20161207 16:49:02< Shiki> I everytime convert the picture to jpeg, and eventually reduce quality to 85% while doing that
20161207 16:50:21< EliDupree> Bug submitted! https://gna.org/bugs/index.php?25370
20161207 17:11:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 17:11:43< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 87405f8: Added optional second fallback value argument to lexical_cast Succeeded
20161207 17:11:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-22
20161207 17:11:43< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87405f8f89c1ca3828b03769c9616b9bcb0c663b
20161207 17:11:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 17:17:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 17:17:17< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 87405f8: Added optional second fallback value argument to lexical_cast Failed
20161207 17:17:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-23
20161207 17:17:17< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87405f8f89c1ca3828b03769c9616b9bcb0c663b
20161207 17:17:22-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 17:23:49-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161207 17:23:49< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 87405f8: Added optional second fallback value argument to lexical_cast Failed
20161207 17:23:49< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-23
20161207 17:23:49< Appveyor> Commit: https://gitHub.com/wesnoth/wesnoth/commit/87405f8f89c1ca3828b03769c9616b9bcb0c663b
20161207 17:23:53-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161207 17:25:40-!- Kwandulin [~Miranda@p200300760F6EBF2584CDA3B5BE9EBF05.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161207 17:26:11-!- louis94 [~~louis94@91.178.242.211] has joined #wesnoth-dev
20161207 17:28:59-!- ChipmunkV [~vova@89.94.113.91] has joined #wesnoth-dev
20161207 18:05:39-!- irker814 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161207 18:11:51-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161207 18:11:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Write error: Broken pipe]
20161207 18:11:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161207 18:12:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 18:12:44-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20161207 18:12:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Write error: Broken pipe]
20161207 18:13:39-!- Ivanovic_ is now known as Ivanovic
20161207 18:16:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20161207 18:21:19-!- zookeeper_ is now known as zookeeper
20161207 18:21:22-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20161207 18:21:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161207 18:25:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 18:50:45-!- louis94 [~~louis94@91.178.242.211] has quit [Ping timeout: 248 seconds]
20161207 19:21:52< EliDupree> On Linux, I use a symlink so that my EoHS directory can be shared between different wesnoth versions (so I can make sure it's compatible with all of them). I'm trying to figure out a way to do this on Windows 7. A symlink didn't work. Any suggestions?
20161207 19:22:26< EliDupree> I could tell them all to point at the same directory, but that doesn't work if I have other add-ons that aren't compatible with all versions
20161207 19:32:50< gfgtdf> how do you use symlink on windows? with mklink ?
20161207 19:38:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit []
20161207 19:42:11-!- louis94 [~~louis94@91.178.242.211] has joined #wesnoth-dev
20161207 19:42:19< EliDupree> gfgtdf: yes
20161207 19:44:21< gfgtdf> EliDupree: i dont know any other way to 'share' folders in windows. hen i develop my addons i usualyl develop them on 1.13 and download them in 1.12 from the addon server and then test them there.
20161207 19:44:31< EliDupree> heh
20161207 19:45:03< EliDupree> From the 1.13 add-on server?
20161207 19:45:42< EliDupree> Actually, since I have a script that automatically runs whenever I change an EoHS file, I could just have that script also copy the whole directory into the 1.13 add-ons directory, ha ha
20161207 19:46:13< gfgtdf> EliDupree: hmm no iusuall push them to both the 1.12 and 1.13 addon server from wenoth 1.13, just just pushign them to the 1.13 server and doanloading them fron these would likeley also work.
20161207 19:47:11< EliDupree> So you push versions without testing them first? LOL. Not that I don't do the same thing all the time
20161207 19:49:30< gfgtdf> well i usuual test them immidiateley after it also has the advantage that i know 100% that the version is test is eactly the one on the addon server, it previousl for example happened sometimesthat the version test isnt exactly the same as on athe addonserver because i forgot to save form file in the editor.
20161207 19:49:39< gfgtdf> version i test*
20161207 19:55:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 19:57:41-!- louis94 [~~louis94@91.178.242.211] has quit [Ping timeout: 260 seconds]
20161207 20:03:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161207 20:27:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161207 20:27:20-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds]
20161207 20:29:25-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161207 20:34:56-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20161207 20:38:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161207 20:39:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 20:42:28-!- prkc_ [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161207 20:43:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161207 20:44:10-!- prkc__ [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161207 20:44:21-!- prkc__ [~prkc@gateway/vpn/privateinternetaccess/prkc] has left #wesnoth-dev []
20161207 20:45:56-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20161207 20:47:06-!- prkc_ [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 250 seconds]
20161207 20:51:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161207 20:54:59-!- louis94 [~~louis94@91.178.242.211] has joined #wesnoth-dev
20161207 21:09:33-!- louis94 [~~louis94@91.178.242.211] has quit [Ping timeout: 260 seconds]
20161207 21:13:16-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Quit: Leaving]
20161207 21:25:45-!- JyrkiVesterinen [~JyrkiVest@89-166-108-22.bb.dnainternet.fi] has quit [Quit: .]
20161207 21:25:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161207 21:25:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161207 21:38:26-!- louis94 [~~louis94@91.178.242.211] has joined #wesnoth-dev
20161207 21:59:35< Shiki> /usr/include/boost/optional/optional.hpp:868: reference_type boost::optional<color_t>::get() [T = color_t]: Assertion `this->is_initialized()' failed.
20161207 22:03:06< Shiki> https://bpaste.net/show/730c2d1ca666
20161207 22:04:20< Shiki> vultraz, sounds like the part where you are working on
20161207 22:24:33-!- ChipmunkV [~vova@89.94.113.91] has quit [Quit: ChipmunkV]
20161207 23:10:53-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Quit: leaving]
20161207 23:20:26-!- irker620 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161207 23:20:26< irker620> wesnoth: ln-zookeeper wesnoth:master 89d38ac103a8 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (06_Temple_in_the_Deep.cfg 22_The_Rise_of_Wesnoth.cfg): TRoW: Prevent dialogue of dead being raised getting shown on defeat https://github.com/wesnoth/wesnoth/commit/89d38ac103a8a021da65c41fbbc0e44c1e8a736c
20161207 23:34:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20161207 23:44:26< EliDupree> Is it true that the stable version isn't being maintained?
20161207 23:49:01< celticminstrel> ...I forgot I'd left a client open logged into the server. How many days have I been logged in for...
20161207 23:52:06-!- louis94 [~~louis94@91.178.242.211] has quit [Ping timeout: 256 seconds]
20161207 23:52:26< irker620> wesnoth: Celtic Minstrel wesnoth:master e6cae2e16e40 / src/lexical_cast.hpp: Fix lexical_cast compiler errors on MSVC 2013 https://github.com/wesnoth/wesnoth/commit/e6cae2e16e40fc3e8c7190b0aa821dd7202cef8d
20161207 23:56:29< EliDupree> ...In 1.13.6, loading the current EoHS not only has a buggy preprocessor directive, but also causes an assertion failure in wesnoth itself!
20161207 23:58:13< celticminstrel> Same as Shiki posted above, or...?
20161207 23:59:54< EliDupree> I don't know. Right after the assertion failure dialog appeared, the entire window immediately disappeared as well
--- Log closed Thu Dec 08 00:00:47 2016