--- Log opened Sat Dec 10 00:00:12 2016
20161210 00:01:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161210 00:03:55-!- louis94 [~~louis94@91.178.241.241] has quit [Ping timeout: 252 seconds]
20161210 00:04:15-!- mjs-de [~mjs-de@x4e31875d.dyn.telefonica.de] has quit [Remote host closed the connection]
20161210 00:11:52< celticminstrel> Shiki: That would need a stack trace to be useful.
20161210 00:12:00-!- Appleman1234 [~Appleman1@KD106161208121.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20161210 00:14:26< Shiki> celticminstrel, voilà https://bpaste.net/show/946f1acfef87
20161210 00:17:41< gfgtdf> zookeeper: you know why this is outcommented https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Dead_Water/scenarios/01_Invasion.cfg#L627 ?
20161210 00:19:40< zookeeper> gfgtdf, no, i can't see any reason for that
20161210 00:19:56< gfgtdf> ok will fix it
20161210 00:20:16< celticminstrel> gfgtdf: Any idea why display_context::calculate_team_data takes a side as a parameter instead of just using the side from the team?
20161210 00:21:40< celticminstrel> gfgtdf: That number_of_zombies variable does exist, right?
20161210 00:21:51< celticminstrel> And really isn't needed beyond that point?
20161210 00:22:05< gfgtdf> celticminstrel: no diea why it takes a side parameter
20161210 00:22:34< gfgtdf> celticminstrel: it exists but m currently about do to some wml cleanups.
20161210 00:30:56< gfgtdf> i wonder whetehr we shodul have some wml container varaible "s" that is automatically cleared at the end of the scenario that way people coudl just use s.variablename for their scenario-variables without havign to worry about cleaning them.
20161210 00:32:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161210 00:34:15< gfgtdf> any opinion of making [random_placement] also store the terrain data?
20161210 00:38:41< celticminstrel> I don't think I like the idea of having an auto-cleared "s" variable.
20161210 00:40:19< gfgtdf> why not ?
20161210 00:41:55< celticminstrel> It would be easy for someone to use it for something and get confused about why their variables are disappearing.
20161210 00:42:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 00:42:37< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf d98525d: replace true/false with yes/no in mainline Succeeded
20161210 00:42:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-29
20161210 00:42:41-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 00:44:10< gfgtdf> hmm
20161210 00:50:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161210 00:55:54-!- Greg-Bog_ [~greg_bogg@2601:1c2:f00:9780:49cc:5cbd:4b01:83a9] has quit [Remote host closed the connection]
20161210 00:57:53< celticminstrel> Shiki: I have a fix coming. At least, I'm 99% sure it'll fix it.
20161210 00:58:15< Shiki> celticminstrel, ok
20161210 00:58:31 * celticminstrel also has something that EliDupree will like.
20161210 00:58:39< vultraz> celticminstrel: no progress
20161210 00:58:50< celticminstrel> On what?
20161210 00:58:58< vultraz> [04:21:46]	celticminstrel	vultraz: What's up with this relicensing thing?
20161210 00:59:00< EliDupree> :)
20161210 00:59:07< celticminstrel> Oh that.
20161210 01:02:27< celticminstrel> So I can't test because there's an incomprehensible error in lexical_cast.
20161210 01:03:17< celticminstrel> Which prevents the game from launching.
20161210 01:03:18-!- irker367 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161210 01:03:18< irker367> wesnoth: Celtic Minstrel wesnoth:master c71b9306eda4 / src/ (display_context.cpp display_context.hpp gui/dialogs/game_stats.cpp reports.cpp): Remove redundant argument from display_context::calculate_team_data() https://github.com/wesnoth/wesnoth/commit/c71b9306eda4efa0c44389723509b0058936d2ec
20161210 01:03:18< irker367> wesnoth: Celtic Minstrel wesnoth:master ef1d052136f3 / changelog src/scripting/lua_team.cpp: Add Lua API for fetching net income and related values https://github.com/wesnoth/wesnoth/commit/ef1d052136f32932fea484cb63170d0c6e083ef2
20161210 01:03:19< irker367> wesnoth: Celtic Minstrel wesnoth:master 97b675ea479a / src/units/frame.cpp: Fix animations trying to blend with a nonexistent colour https://github.com/wesnoth/wesnoth/commit/97b675ea479a24d5d5239765f12d5449a5fb0066
20161210 01:03:26< celticminstrel> But, well, there it is.
20161210 01:05:50< Shiki> so I better don't pull and build now?
20161210 01:07:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 01:07:09< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf d98525d: replace true/false with yes/no in mainline Succeeded
20161210 01:07:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-29
20161210 01:07:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 01:08:38-!- Appleman1234 [~Appleman1@KD106161206042.au-net.ne.jp] has joined #wesnoth-dev
20161210 01:14:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:49cc:5cbd:4b01:83a9] has joined #wesnoth-dev
20161210 01:21:18< irker367> wesnoth: Charles Dang wesnoth:master 5b3e3a7b2164 / src/gui/widgets/unit_preview_pane.cpp: Unit Preview Pane: code and tooltip formatting https://github.com/wesnoth/wesnoth/commit/5b3e3a7b2164b0b6592bde24dc50d24d8958e0ee
20161210 01:21:21< irker367> wesnoth: Charles Dang wesnoth:master 77777666de97 / src/map/label.cpp: Catch exception when reading map label colors to enable loading old saves again https://github.com/wesnoth/wesnoth/commit/77777666de97b53b0251e79b7caf20a1cae8210a
20161210 01:21:51< vultraz> Shiki: ^ you can load old saves with labels again
20161210 01:22:17< Shiki> vultraz, labels?
20161210 01:23:32< vultraz> yes
20161210 01:25:18< Shiki> you mean things like the "go here" in the tutorial?
20161210 01:25:50< vultraz> yes
20161210 01:25:53< vultraz> [label]s
20161210 01:27:07< Shiki> ok :)
20161210 01:27:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:49cc:5cbd:4b01:83a9] has quit [Remote host closed the connection]
20161210 01:27:46 * Shiki is building
20161210 01:37:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161210 01:39:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 01:39:35< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release gfgtdf d98525d: replace true/false with yes/no in mainline Succeeded
20161210 01:39:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-30
20161210 01:39:40-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 01:58:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161210 02:03:04-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 02:03:04< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug gfgtdf d98525d: replace true/false with yes/no in mainline Succeeded
20161210 02:03:04< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-30
20161210 02:03:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 02:04:11-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161210 02:06:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161210 02:15:21-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 02:15:22< travis-ci> wesnoth/wesnoth#12352 (master - 97b675e : Celtic Minstrel): The build has errored.
20161210 02:15:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182766777
20161210 02:15:22-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 02:32:17< celticminstrel> It'd be nice if someone could verify that ef1d0521 works.
20161210 02:32:26< celticminstrel> (Using the Lua console presumably.)
20161210 02:38:54< gfgtdf> celticminstrel: that commit looks leik whenever i use tema methos liek team:mathces it befroe calls calculate_team_data whic iterated through all units on the map....
20161210 02:39:24< gfgtdf> celticminstrel: i can simply use wensoth.match_side instead, but still 
20161210 02:44:11< EliDupree> celticminstrel: What was the thing I'll like?
20161210 02:57:11-!- gfgtdf_ [~chatzilla@x4e368976.dyn.telefonica.de] has joined #wesnoth-dev
20161210 02:57:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161210 02:59:05-!- gfgtdf [~chatzilla@x4e3699e9.dyn.telefonica.de] has quit [Ping timeout: 258 seconds]
20161210 02:59:06-!- gfgtdf_ is now known as gfgtdf
20161210 03:00:35< irker367> wesnoth: mattsc wesnoth:master 8d76ad32b095 / data/ai/lua/ai_helper.lua: ai_helper: new function find_path_with_shroud() https://github.com/wesnoth/wesnoth/commit/8d76ad32b095fa3f4e8d89dac1031a5e7a5a8c8b
20161210 03:00:37< irker367> wesnoth: mattsc wesnoth:master 36b2b4e9a727 / data/ai/lua/ (ai_helper.lua battle_calcs.lua): AI helper functions: consistently ignore shroud when path finding https://github.com/wesnoth/wesnoth/commit/36b2b4e9a727b92c064c12f041bae76891650a63
20161210 03:00:39< irker367> wesnoth: mattsc wesnoth:master 3236a4b0857a / data/ai/micro_ais/cas/ (8 files): Micro AIs: fix some MAIs not working under shroud https://github.com/wesnoth/wesnoth/commit/3236a4b0857a24d523767ee13f2fddb2c2395bf8
20161210 03:01:15< mattsc> celticminstrel, all: ^ do you think that that is important enough be in the release notes or is the changelog good enough?
20161210 03:01:46< mattsc> I will also update the wiki and make a short note in the forum thread where somebody pointed out the problem with MAIs and shroud.
20161210 03:01:58< mattsc> celticminstrel: PR 881 is next on my list now.
20161210 03:15:12< irker367> wesnoth: Charles Dang wesnoth:master 71bb2163520d / src/ (5 files in 5 dirs): Use font::unicode_bullet instead of manually writing • https://github.com/wesnoth/wesnoth/commit/71bb2163520d4bf0f585104c8b77e0e37dbf2877
20161210 03:15:18< vultraz> ah, forgot [ci skip]
20161210 03:15:20< vultraz> oh well
20161210 03:20:59< celticminstrel> mattsc: Not sure if it should be in release notes. Any opinion on that, vultraz?
20161210 03:22:22< mattsc> celticminstrel: Yeah, I think it’s a borderline case and that just putting it in the changelog is good enough, but I thought I’d ask.
20161210 03:24:38-!- gfgtdf [~chatzilla@x4e368976.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161210 03:24:51< vultraz> changelog is fine
20161210 03:35:51-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has quit [Write error: Broken pipe]
20161210 03:36:32-!- EliDupree [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20161210 03:38:25< irker367> wesnoth: mattsc wesnoth:master 30a47da04856 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/30a47da0485641eec3edb8b9326c371d17bdc887
20161210 03:41:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161210 03:57:36< mattsc> celticminstrel: do you want me to update the Xcode project?
20161210 03:58:22< celticminstrel> Sure.
20161210 03:59:37< irker367> wesnoth: mattsc wesnoth:master 0f2b2f527101 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/0f2b2f52710167a8884d79734bbdf7128697d28c
20161210 04:06:43< celticminstrel> I have no idea what to do about this incomprehensible null pointer access error in the static initializers...
20161210 04:07:41< celticminstrel> It's incomprehensible because I can't see any pointers anywhere.
20161210 04:28:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161210 04:30:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161210 04:46:34-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 04:46:35< travis-ci> wesnoth/wesnoth#12356 (master - 3236a4b : mattsc): The build has errored.
20161210 04:46:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182780882
20161210 04:46:35-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 05:08:28-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161210 05:32:24-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 05:32:25< travis-ci> wesnoth/wesnoth#12357 (master - 71bb216 : Charles Dang): The build passed.
20161210 05:32:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182782473
20161210 05:32:25-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 06:09:37< irker367> wesnoth: Charles Dang wesnoth:master 9d51c40c5cd2 / src/ (CMakeLists.txt SConscript tools/dummy_video.cpp): Removed dummy_video https://github.com/wesnoth/wesnoth/commit/9d51c40c5cd2dc60696ab457d1d5e08186d51e2e
20161210 06:12:39< celticminstrel> vultraz: You sure that wasn't used in the tests?
20161210 06:13:18< vultraz> oh, the tests. I was checking the tools.
20161210 06:13:25< vultraz> Oh well, we'll see what travis says.
20161210 06:15:21-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 06:15:22< travis-ci> wesnoth/wesnoth#12358 (master - 30a47da : mattsc): The build passed.
20161210 06:15:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182785087
20161210 06:15:22-!- travis-ci [~travis-ci@ec2-54-204-79-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 06:15:46-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has joined #wesnoth-dev
20161210 06:23:45-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20161210 06:24:15-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161210 06:26:17-!- JyrkiVesterinen [~JyrkiVest@87-100-234-78.bb.dnainternet.fi] has joined #wesnoth-dev
20161210 06:32:18< JyrkiVesterinen> 20161210 01:02:27< celticminstrel> So I can't test because there's an incomprehensible error in lexical_cast.
20161210 06:32:21< JyrkiVesterinen> Any details?
20161210 06:38:50< celticminstrel>  http://pastebin.com/NFMS2uuk
20161210 06:42:19< JyrkiVesterinen> I don't see how that line can attempt to dereference a null pointer...
20161210 06:42:37< celticminstrel> Nor do I! That's why it's incomprehensible.
20161210 06:49:40-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 06:49:41< travis-ci> wesnoth/wesnoth#12359 (master - 0f2b2f5 : mattsc): The build passed.
20161210 06:49:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182786843
20161210 06:49:41-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 07:22:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161210 07:39:47< vultraz> ok, the removal of dummy_video was fine
20161210 08:03:02-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161210 08:03:02-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161210 08:25:32-!- abbradar [~user@95-28-164-189.broadband.corbina.ru] has joined #wesnoth-dev
20161210 08:29:57< abbradar> Hi all! I'm a maintainer of stable (1.12.6) wesnoth package for NixOS, a Linux distro. I'm trying to debug a strange bug: I can't type Russian in label set dialog. What makes it strange is that if I build wesnoth by myself with exactly the same compiler, set of flags and linked to exactly the same libraries (NixOS guarantees this but just to be sure I verified the result with ldd -- both load same libraries) and run it from the build
20161210 08:29:58< abbradar> dir, it works! I think of adding some printf's to SDL key event receiving code next but wanted to ask there first if there's something known about this.
20161210 08:31:34< abbradar> Uh, even more funny: it works if I copy the binary from the package to the build dir and run it
20161210 08:32:22< vultraz> abbradar: 1.12 is nearing EOL. It's very likely such a bug was fixed in 1.13.
20161210 08:32:52< abbradar> vultraz: we have 1.13 too but 1.12 is advertised as "stable" recommended version, am I correct?
20161210 08:33:08< abbradar> (and yes, it works in 1.13)
20161210 08:33:24< vultraz> Yes. But it's unlikely we will be making any more releases in the 1.12 series, barring security patch.
20161210 08:33:30< vultraz> patches*
20161210 08:33:51< abbradar> Yep, of course -- I just had hope that someone already heard something about this
20161210 08:34:29< vultraz> Given the massive changes to the codebase in 1.13, such as switching to SDL2, debugging the issue on 1.12 would be rather tedious and perhaps not worth the effort.
20161210 08:35:23< vultraz> I seem to recall several bugs related to foreign text handling on our bug tracker, but we closed them since they were fixed in 1.13
20161210 08:35:50< abbradar> Hm, maybe I just leave it after tackling a bit. Anyway I start to think that it's an environment problem -- if I clean env it works too
20161210 08:36:19< abbradar> Now I just need to figure out which variable causes this...
20161210 08:37:06< irker367> wesnoth: Charles Dang wesnoth:master 8da0284a3ade / data/gui/window/tooltip_large.cfg: Tooltips: improve placement to avoid source widget overlap https://github.com/wesnoth/wesnoth/commit/8da0284a3adee086831c9f1e4c27f8341d29ba60
20161210 08:42:27-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 08:42:27< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 9d51c40: Removed dummy_video Succeeded
20161210 08:42:27< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-30
20161210 08:42:31-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 08:44:56-!- louis94 [~~louis94@91.178.242.203] has joined #wesnoth-dev
20161210 08:45:25-!- abbradar` [~user@95-28-164-189.broadband.corbina.ru] has joined #wesnoth-dev
20161210 08:46:19-!- abbradar [~user@95-28-164-189.broadband.corbina.ru] has quit [Remote host closed the connection]
20161210 08:51:11-!- louis94 [~~louis94@91.178.242.203] has quit [Ping timeout: 252 seconds]
20161210 08:53:06-!- louis94 [~~louis94@91.178.242.203] has joined #wesnoth-dev
20161210 08:56:11-!- louis94 [~~louis94@91.178.242.203] has quit [Client Quit]
20161210 08:56:27-!- louis94 [~~louis94@91.178.242.203] has joined #wesnoth-dev
20161210 09:01:25-!- louis94 [~~louis94@91.178.242.203] has quit [Ping timeout: 248 seconds]
20161210 09:01:34< abbradar`> Found it, when ibus is enabled Russian doesn't work in Wesnoth
20161210 09:01:56< abbradar`> Okay, seems that it's not Wesnoth's fault anyway. Thanks and good day!
20161210 09:02:02-!- abbradar` [~user@95-28-164-189.broadband.corbina.ru] has quit [Remote host closed the connection]
20161210 09:07:07-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 09:07:07< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 9d51c40: Removed dummy_video Succeeded
20161210 09:07:07< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-30
20161210 09:07:12-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 09:14:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161210 09:20:14< zookeeper> gfgtdf, sure, [random_placement] could store all the things [store_locations] does, i suppose. although if you want to do something based on terrain then checking the variable isn't really any simpler than [have_location]... unless for example you want to use a [switch]. so doesn't seem very important but wouldn't hurt either.
20161210 09:39:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 09:39:46< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 8da0284: Tooltips: improve placement to avoid source widget overlap Succeeded
20161210 09:39:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-31
20161210 09:39:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 09:48:54< JyrkiVesterinen> celticminstrel: I can't reproduce the crash. I tried both VS2013 and VS2015, and both Debug and Release builds. All four combinations.
20161210 09:49:33< JyrkiVesterinen> Have you installed latest Visual Studio updates? I'm just guessing, but you might be hitting a compiler bug that Microsoft has already fixed.
20161210 10:02:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 10:02:37< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 8da0284: Tooltips: improve placement to avoid source widget overlap Succeeded
20161210 10:02:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-31
20161210 10:02:41-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 10:07:01-!- RatArmy_ [~ratarmy@om126212240029.14.openmobile.ne.jp] has quit [Ping timeout: 248 seconds]
20161210 10:21:38< irker367> wesnoth: Charles Dang wesnoth:master 7b34afdbe372 / src/color.cpp: color_t: fix from_rgb_string https://github.com/wesnoth/wesnoth/commit/7b34afdbe372e939ae6b0b7e170e9ecc0eb0dcbf
20161210 10:21:41< irker367> wesnoth: Charles Dang wesnoth:master 4dbd219292db / src/gui/widgets/label.cpp: GUI2/Label: quick fix for label links not being formatted correctly https://github.com/wesnoth/wesnoth/commit/4dbd219292db7a143315164382c355a1506c846b
20161210 10:22:40< vultraz> Should really come up with a better link color than yellow
20161210 10:23:09< vultraz> hm
20161210 10:23:10< vultraz> maybe i should use one of the golds
20161210 10:25:34< vultraz> eh, too little contrast sometimes
20161210 10:36:51-!- mjs-de [~mjs-de@x4db5636e.dyn.telefonica.de] has joined #wesnoth-dev
20161210 11:03:51-!- JyrkiVesterinen [~JyrkiVest@87-100-234-78.bb.dnainternet.fi] has quit [Quit: .]
20161210 11:10:40-!- Kwandulin [~Miranda@p200300760F6EBF283D2270C7BDD44AD8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161210 11:34:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161210 11:36:54< irker367> wesnoth: Charles Dang wesnoth:master 98cca22c6509 / src/ (6 files in 2 dirs): Moved the SDL_Rect ostream operator to the appropriate file https://github.com/wesnoth/wesnoth/commit/98cca22c6509437cb1bf8075577031f624139c6f
20161210 11:36:57< irker367> wesnoth: Charles Dang wesnoth:master 09e73dbc984e / src/ (font/standard_colors.cpp sdl/utils.cpp sdl/utils.hpp): Moved inverse to standard_colors.cpp https://github.com/wesnoth/wesnoth/commit/09e73dbc984e654bba54de74eea20b16a0f7140b
20161210 11:37:00< irker367> wesnoth: Charles Dang wesnoth:master b97a20b05927 / src/ (39 files in 14 dirs): Split SDL_Surface wrapper class and related helper struts into their own file https://github.com/wesnoth/wesnoth/commit/b97a20b059271c419492122b35472d897e258166
20161210 11:41:31< irker367> wesnoth: Charles Dang wesnoth:master 3c498eb0e479 / projectfiles/CodeBlocks/wesnoth.cbp: Update CB projectfile https://github.com/wesnoth/wesnoth/commit/3c498eb0e479431d2662925dc6a7a0231f549328
20161210 11:42:28< vultraz> JyrkiVesterinen: is there any reason uses of this: https://github.com/wesnoth/wesnoth/blob/master/src/sdl/surface.hpp#L127-L137 cannot be replaced with 'const surface_lock'?
20161210 11:48:31< vultraz> hm, I see
20161210 11:48:37< vultraz> qualifier conflict
20161210 11:50:02< vultraz> though why can't surface_lock provide two versions of pixels()?
20161210 12:10:18< vultraz> ah, it's the ctor
20161210 12:10:20< vultraz> oh well
20161210 12:14:50-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161210 12:15:54-!- Kwandulin [~Miranda@p200300760F6EBF283D2270C7BDD44AD8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161210 12:17:02-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 12:17:03< travis-ci> wesnoth/wesnoth#12364 (master - b97a20b : Charles Dang): The build has errored.
20161210 12:17:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182825195
20161210 12:17:04-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 12:34:30< vultraz> celticminstrel: ^ a <string> include is needed, I think?
20161210 12:53:38-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has quit [Ping timeout: 258 seconds]
20161210 13:02:54-!- gfgtdf [~chatzilla@x4e368976.dyn.telefonica.de] has joined #wesnoth-dev
20161210 13:05:47-!- JyrkiVesterinen [~JyrkiVest@87-100-247-109.bb.dnainternet.fi] has joined #wesnoth-dev
20161210 13:07:17< irker367> wesnoth: gfgtdf wesnoth:master a53090d648bb / data/ (9 files in 8 dirs): wml cleanups, add terrain= attribute to [random_placement] loc https://github.com/wesnoth/wesnoth/commit/a53090d648bbbc49c2a1ae42f4ea5297b0424909
20161210 13:16:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161210 13:30:44< irker367> wesnoth: Charles Dang wesnoth:master 7d83d0616a6a / src/ (video.cpp video.hpp): Removed CVideo::modeChanged() (unused) https://github.com/wesnoth/wesnoth/commit/7d83d0616a6a872ec5c9b7c5abd9d4b48a777a0b
20161210 13:30:47< irker367> wesnoth: Charles Dang wesnoth:master 1b8c04fbba31 / src/ (4 files in 3 dirs): Moved an erroneous sdl/utils.hpp include out of text header https://github.com/wesnoth/wesnoth/commit/1b8c04fbba31274bd6aafb5f5a629f50396e3570
20161210 13:30:50< irker367> wesnoth: Charles Dang wesnoth:master fb9831cfe553 / src/sdl/ (utils.cpp utils.hpp): Removed sdl_keysym_from_name (unused) https://github.com/wesnoth/wesnoth/commit/fb9831cfe553c48536f7e1c0a6ae6b1ee2193058
20161210 13:37:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161210 13:38:57< gfgtdf> vultraz: i think its ratehr confusion that we have  util.hpp file and a utils/ folder, since util.hpp afaik onyl coantains math functions now, maybe we shodul move it to utils/math.hpp or similar?
20161210 13:45:11-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 13:45:12< travis-ci> wesnoth/wesnoth#12365 (master - a53090d : gfgtdf): The build failed.
20161210 13:45:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182835238
20161210 13:45:12-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 13:46:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 258 seconds]
20161210 14:04:14< vultraz> gfgtdf: probably
20161210 14:04:49< vultraz> well, there are a few misc functions
20161210 14:23:15-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 14:23:16< travis-ci> wesnoth/wesnoth#12366 (master - fb9831c : Charles Dang): The build has errored.
20161210 14:23:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182837653
20161210 14:23:16-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 14:38:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 14:42:57< irker367> wesnoth: Charles Dang wesnoth:master f90e466360e6 / / (27 files in 14 dirs): Split util.hpp into utils/math.hpp and utils/general.hpp https://github.com/wesnoth/wesnoth/commit/f90e466360e667ae9f21894050ecc99ca603869d
20161210 14:43:01< vultraz> gfgtdf: ^
20161210 14:43:13< gfgtdf> nice
20161210 14:44:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161210 14:47:07< irker367> wesnoth: Charles Dang wesnoth:master 85537afa482b / src/widgets/widget.hpp: Attempt to fix macOS build https://github.com/wesnoth/wesnoth/commit/85537afa482b34c4807f4fc992da33236f59f96b
20161210 14:49:06-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20161210 15:01:50-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161210 15:02:22-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161210 15:17:25-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20161210 15:18:57-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20161210 15:21:00-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 15:21:01< travis-ci> wesnoth/wesnoth#12367 (master - f90e466 : Charles Dang): The build failed.
20161210 15:21:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182847799
20161210 15:21:02-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 15:26:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 15:27:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161210 15:32:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 15:32:30-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 15:32:56< EliDupree> EoHS 2.2.5 released :-)
20161210 15:37:45-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 15:39:16-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 15:40:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161210 15:52:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161210 15:54:47-!- DeFender1031 [~DeFender1@46-116-15-217.bb.netvision.net.il] has joined #wesnoth-dev
20161210 15:55:22-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 15:57:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 16:07:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161210 16:07:26-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 16:15:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161210 16:17:03-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 16:17:04< travis-ci> wesnoth/wesnoth#12368 (master - 85537af : Charles Dang): The build has errored.
20161210 16:17:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182848494
20161210 16:17:04-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 16:22:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 16:27:26< zookeeper> i didn't realize you can get a loyal bat WC in dead water S2. so... the player can get an unlimited amount of corpses with plague? O.o
20161210 16:28:11< gfgtdf> zookeeper: is this a problem?
20161210 16:28:16< zookeeper> i wonder if a corpses only run would be feasible, starting from S3 onwards of course
20161210 16:28:54< zookeeper> gfgtdf, not unless you count the fact that it's a bit weird to be able to have tons of undead units :p
20161210 16:29:11< gfgtdf> zookeeper: recall costs is still 20 gold for lvl 0or 1 uti
20161210 16:29:28< gfgtdf> zookeeper: so not something prople woudl do unless just for fun
20161210 16:29:49< zookeeper> right, i guess recall costs would be a problem
20161210 16:32:21< zookeeper> i wonder if the possibility of plague has been taken into account everywhere, though.
20161210 16:32:41< zookeeper> like assumptions of a hex being empty just because the enemy leader just died in it, etc
20161210 16:34:21-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 16:35:45-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 16:35:45< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 85537af: Attempt to fix macOS build Failed
20161210 16:35:45< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-31
20161210 16:35:49-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 16:36:15< DeFender1031> zookeeper, how do you get that bat?
20161210 16:36:47< zookeeper> kill the death knight
20161210 16:37:00< vultraz> someone needs to update the vs files
20161210 16:37:47-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 16:39:07 * DeFender1031 goes to check
20161210 16:39:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 16:40:49-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 16:41:10< DeFender1031> that comment at 421 needs to have a princess bride joke in there...
20161210 16:43:13< DeFender1031> zookeeper, that's not a bat WC, that's a normal dread bat
20161210 16:43:19< DeFender1031> unless i', much mistaken
20161210 16:43:55< zookeeper> i dunno, i think type=Walking Corpse is pretty clear-cut
20161210 16:44:24< DeFender1031> I don't know where you're looking, but I see "type=Dread Bat"
20161210 16:44:31< DeFender1031> oh, i'm looking in 1.12
20161210 16:44:42< DeFender1031> oops
20161210 16:45:37< zookeeper> oh wait
20161210 16:45:41< zookeeper> it can be dread, normal, or WC
20161210 16:45:44< DeFender1031> okay, i'm in master... still dread bat
20161210 16:45:44< zookeeper> depending on who you kill
20161210 16:45:53< DeFender1031> oooooooooohh
20161210 16:46:08< DeFender1031> okay, i understand now
20161210 16:46:12< DeFender1031> strange
20161210 16:46:13< zookeeper> i was only looking at the death knight event
20161210 16:46:28< DeFender1031> still, the fact remains that there IS a path that gets you a WC
20161210 16:46:39< zookeeper> yeah
20161210 16:47:05< DeFender1031> that also seems... strange... to have it change like that
20161210 16:47:24< zookeeper> maybe there could be an evil ending if you just get all merfolk killed but have lots of corpses... :>
20161210 16:47:34< DeFender1031> hahahaha
20161210 16:47:49< DeFender1031> you'd have to play a VERY specific game to do that
20161210 16:48:04< zookeeper> sure
20161210 16:48:35< DeFender1031> though a plot path that would lead to krellis becoming a necromancer-merman... or a lich-merman would be quite interesting
20161210 16:48:48-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 245 seconds]
20161210 16:53:58< zookeeper> well... in the last scenario, there are no can't-die units except krellis himself. so maybe if everyone else is dead by the time you win the scenario with corpses, you could get a secret ending
20161210 16:55:05< zookeeper> it would be fun if you could get a few subtle hints throughout the campaign, if your number of corpses keeps increasing
20161210 16:56:37< DeFender1031> if it were going to be like that, there'd have to be more opportunities for getting corpses than one particular enemy death in one particular combination at one particular point.
20161210 16:57:47< zookeeper> maybe. but just having any of the 3 kills in S2 give you a WC bat would be enough
20161210 16:57:59< zookeeper> instead of only one of the 3
20161210 16:58:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 16:58:37< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 85537af: Attempt to fix macOS build Failed
20161210 16:58:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-31
20161210 16:58:41-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 17:07:56-!- Kwandulin [~Miranda@p200300760F6EBF28594DA96080F6638E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161210 17:09:05< DeFender1031> true, though if we're going to make the reward for all identical, it would probably make more sense for it to always be a living bat.
20161210 17:10:31< zookeeper> yeah, but then it'd have to be a living bat with plague
20161210 17:10:45< zookeeper> which i suppose wouldn't be extraordinarily weird since it'd clearly be a special unit
20161210 17:14:00< DeFender1031> ... i think you missed my point
20161210 17:14:15< DeFender1031> my point was, it makes more sense for krellis not to have a unit capable of creating corpses
20161210 17:14:24< DeFender1031> like your original premise
20161210 17:15:28< zookeeper> oh, right
20161210 17:15:55< DeFender1031> :P
20161210 17:19:32< irker367> wesnoth: ln-zookeeper wesnoth:master 2cf66ff44239 / data/campaigns/Dead_Water/scenarios/02_Flight.cfg: DW: Clarified the Death Knight's gold chest; fixes bug #25363 https://github.com/wesnoth/wesnoth/commit/2cf66ff44239f71bc8acd35bf4da9aade959efa4
20161210 17:23:38-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161210 17:23:38< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 85537af: Attempt to fix macOS build Failed
20161210 17:23:38< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-32
20161210 17:23:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161210 17:43:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 17:44:41< zookeeper> visual studio is dumb, it deletes the old executable even if compiling the new one fails
20161210 17:44:52< zookeeper> s/compiling/linking perhaps
20161210 17:45:02< DeFender1031> :/
20161210 17:45:22-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 17:45:47< zookeeper> vultraz, so which files do i need to add in the VS project files?
20161210 17:51:44-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20161210 17:53:13-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20161210 17:56:45< vultraz> sdl/surface.*pp
20161210 17:56:48< vultraz> add
20161210 17:56:53< vultraz> util.hpp
20161210 17:56:54< vultraz> delete
20161210 17:57:00< vultraz> utils/math.hpp and util/general.hpp
20161210 17:57:02< vultraz> add
20161210 18:05:15-!- louis94 [~~louis94@91.178.242.203] has joined #wesnoth-dev
20161210 18:06:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161210 18:06:32< zookeeper> great, thanks
20161210 18:15:53-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 18:15:54< travis-ci> wesnoth/wesnoth#12369 (master - 2cf66ff : ln-zookeeper): The build passed.
20161210 18:15:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182872183
20161210 18:15:54-!- travis-ci [~travis-ci@ec2-54-197-171-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 18:21:35-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20161210 18:21:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 18:29:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161210 18:31:14-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 18:33:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161210 18:36:11< celticminstrel> vultraz: Where are there formulas operating in link_color that require it to be in hex format?
20161210 18:36:53< celticminstrel> ^on
20161210 18:37:30< zookeeper> so, changing https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/unit_preview_pane.cpp#L496 to help::show_unit_description((*get_window()).video(), *unit_types.find(current_type_)); seems to fix the problem of not being able to open the help pages of recruitable units in UtBS.
20161210 18:37:32< zookeeper> ^ gfgtdf, vultraz, etc, any opinions on whether that's safe?
20161210 18:37:33-!- louis94 [~~louis94@91.178.242.203] has quit [Ping timeout: 245 seconds]
20161210 18:39:19< gfgtdf> zookeeper: hmm that could woudl assimre that current_type_ is atuall a valid unit typoe id
20161210 18:39:43< celticminstrel> If it's a valid unit type, it's definitely safe, but what gfgtdf said.
20161210 18:39:55< gfgtdf> zookeeper: checking unit_types.find(current_type_) != unit_types.end() woudl be safer
20161210 18:39:59< celticminstrel> I'm not sure if there are situations where it might not be a valid unit type.
20161210 18:40:28< celticminstrel> There may not be such situations.
20161210 18:41:08< gfgtdf> hmm when the object is firstly construction i'd asusme that current_type_ is empty
20161210 18:41:48< gfgtdf> constructed
20161210 18:42:26< gfgtdf> the recuit dislaog doesnt show when there are no units avaiable not note that unit_previewpanl can also be used from lua show_dialog
20161210 18:42:38< gfgtdf> s/not/but
20161210 18:43:37-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has joined #wesnoth-dev
20161210 18:45:38 * celticminstrel hopes mattsc can update the XCode project again.
20161210 18:46:31< celticminstrel> gfgtdf: IIRC, the unit preview pane is set from an actual unit or unit type object, so assuming you always set it I think the type should always be valid... but I guess maybe defaults could pose a problem.
20161210 18:48:06< gfgtdf> ´hmm yes but my point was that you cannot assume its always set. (another question whether that button is actually avaiable/active when the unit is not set)
20161210 18:48:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161210 18:48:48< gfgtdf> i see no code that deactivates that button whe the unit is not set.
20161210 18:50:42-!- Kwandulin [~Miranda@p200300760F6EBF28594DA96080F6638E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161210 18:50:59< celticminstrel> Oh, that'd be a good idea.
20161210 18:51:04< celticminstrel> (Adding such code I mean)
20161210 18:54:05-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161210 19:04:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161210 19:15:49-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161210 19:16:47< zookeeper> ok, so...
20161210 19:17:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161210 19:27:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161210 19:27:58< gfgtdf> zookeeper: was that a question ?
20161210 19:28:33< zookeeper> yeah; did you come to a conclusion regarding my original question? :p
20161210 19:30:00< celticminstrel> Yes. :P
20161210 19:30:12< celticminstrel> The basic idea of what you said is sound.
20161210 19:30:53< celticminstrel> But it's better to store that find call in a variable (you can use auto) and only call show_unit_descrition if it != unit_types.end().
20161210 19:31:16< celticminstrel> (I'm assuming unit_types is a map here though, but I suspect that's not true... let me check...)
20161210 19:31:43< zookeeper> and you don't fancy just doing it while you're at it, perhaps? :p
20161210 19:32:05-!- louis94 [~~louis94@91.178.242.203] has joined #wesnoth-dev
20161210 19:32:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161210 19:33:18< celticminstrel> Uh, I guess I could. What was the line number again...
20161210 19:33:26< celticminstrel> 496, okay.
20161210 19:36:33< zookeeper> i believe the problem was affecting any unit type with hide_help=yes
20161210 19:37:02< zookeeper> so, the fix allows help pages for unit types with hide_help=yes to be opened
20161210 19:39:07< irker367> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 22cc0f129ba9 / / (8 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/22cc0f129ba95e5489dc42f59cdf23f137bca5ff
20161210 19:39:09< irker367> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 9dabd21756b6 / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/9dabd21756b68df28e53baab8d78e7cdda156239
20161210 19:39:11< irker367> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c6f8d3946e05 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/c6f8d3946e0588e62a9e31a374599c112827b0d8
20161210 19:39:13< irker367> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting b586e786af09 / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/b586e786af09f802a02b1c138762c7dd5f3bd1a5
20161210 19:39:15< irker367> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 4517caf4d68f / / (7 files in 5 dirs): WIP port of [animate_unit] https://github.com/wesnoth/wesnoth/commit/4517caf4d68fc4fb13365429c3181f754dafed5a
20161210 19:48:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161210 19:53:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 258 seconds]
20161210 19:53:41-!- louis94 [~~louis94@91.178.242.203] has quit [Ping timeout: 248 seconds]
20161210 19:59:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f0b4:3ede:d917:884e] has joined #wesnoth-dev
20161210 20:01:07< irker367> wesnoth: mattsc wesnoth:master 057749bd7691 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/057749bd7691b709898cecff678b3467f0db7940
20161210 20:02:33< mattsc> celticminstrel: ^
20161210 20:03:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:f0b4:3ede:d917:884e] has quit [Ping timeout: 240 seconds]
20161210 20:05:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161210 20:06:30-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161210 20:06:40< EliDupree> zookeeper: "like assumptions of a hex being empty just because the enemy leader just died in it, etc" -- Well, awkwardly, there's no event type that actually occurs AFTER the unit has been removed (with or without being replaced by plague afterwards), so it would be a moot point
20161210 20:07:07-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161210 20:07:37< EliDupree> In EoHS I wanted to modify units created by plague, so I had actually completely reimplement the plague rules in my own combat events and override the default ones
20161210 20:08:17< zookeeper> right
20161210 20:09:36< EliDupree> Usually the only problem assumptions are "the player has only the units that I specifically let them get"
20161210 20:10:48< gfgtdf> which also might be wrong since 1.13 supports [modification]s in sp.
20161210 20:11:49< EliDupree> Like, in campaigns?
20161210 20:12:01< gfgtdf> yes
20161210 20:12:04< EliDupree> awesome
20161210 20:12:38< EliDupree> So now I can use EoHS to become overpowered in whatever campaign I want :-P
20161210 20:13:07< gfgtdf> i mean ofcourse you cannot expect any modification to work smoothly with any campaign, but you shouldn't but unneesary restrictions/assumptions in your code.
20161210 20:13:20< EliDupree> exactly
20161210 20:14:53< celticminstrel> I feel like mattsc missed something in the XCode update...
20161210 20:15:27< celticminstrel> Ah, I guess because those headers don't have corresponding source files.
20161210 20:20:37< Shiki> celticminstrel, can you add array= to the wiki? it's not explained here https://wiki.wesnoth.org/ConditionalActionsWML#.5Bforeach.5D
20161210 20:20:57< celticminstrel> Huh?
20161210 20:21:17< celticminstrel> What does it do again?
20161210 20:22:09< Shiki> that's what I just wanted to find out :D
20161210 20:23:17< Shiki> celticminstrel, https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Dead_Water/scenarios/01_Invasion.cfg#L488
20161210 20:24:25< celticminstrel> Sounds like fabi renamed the variable attribute to array. Hmm.
20161210 20:25:41< celticminstrel> Ah, maybe to make it more consistent with [for].
20161210 20:29:32< Shiki> this sounds actually more intuitive
20161210 20:29:43< zookeeper> a rename that's not properly documented, and no reason whatsoever to silently support the old key names as well? sounds typical
20161210 20:30:04< zookeeper> s/support/not support
20161210 20:31:03< celticminstrel> zookeeper: Well, the old key names were only in a dev version, so backwards compatibility for them isn't as important.
20161210 20:31:11< zookeeper> certainly
20161210 20:38:52< gfgtdf> zookeeper: the code in https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg looks like whether you can recruit Ghouls in the end depends on whether you first step at (36,11) or met rorthin first is this corect/intended ?
20161210 20:39:45< zookeeper> gfgtdf, i don't know what the intent might be, will have to stare at the code a bit...
20161210 20:43:00< zookeeper> umm, there's pretty much weirdness there
20161210 20:43:07-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161210 20:43:13< zookeeper> like, a moveto event which triggers on every move? you can't undo in that scenario, ever?
20161210 20:43:36< celticminstrel> Sounds terrible! :O
20161210 20:43:55< zookeeper> why does someone do that and why hasn't everyone who has seen it said anything? :x
20161210 20:46:57< gfgtdf> zookeeper: maybe beasue you cannot undo most moves anyway since it has fog.
20161210 20:47:26< celticminstrel> That assumes you don't enable delayed shroud updates.
20161210 20:48:09< zookeeper> most moves, sure, but not all
20161210 20:48:14-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20161210 20:50:21< zookeeper> gfgtdf, anyway, i'm not sure what the map layout is so i don't know if you can in practise bypass rorthin
20161210 20:50:49< zookeeper> if you can then the MEMOIRS_DEAD_HOUSE moveto events should use [filter_condition] and not [if]
20161210 20:51:37< gfgtdf> hmm
20161210 20:52:58< DeFender1031> the map layout is easy enough to check
20161210 20:53:42< gfgtdf> zookeeper: is there a reason to keep it in the current form (using [if]) ?
20161210 20:54:25< zookeeper> gfgtdf, only if it should be possible to miss out on those units if you get to the houses before seeing rorthin. which doesn't sound like a good idea to me.
20161210 20:55:33 * zookeeper tries the scenario
20161210 20:57:54< zookeeper> looks like in practise you can't avoid rorthin? his AI is set to try to catch delfador, and it's a ghost so it can get to you before you can get to any of the houses
20161210 20:59:02< zookeeper> it's kind of an unnerving way to have the scenario work though, relying on an AI goal like that. maybe i'm just unnecessarily paranoid of trusting the AI.
20161210 21:01:27< zookeeper> so, yeah, it looks like there is no danger of anything going wrong currently
20161210 21:01:38< zookeeper> it's just written in a weird way, and the undo issue of course remains
20161210 21:03:03< DeFender1031> nah, I agree with you zookeeper, I don't like code that relies on unconnected preconditions that will always be met with the current code, but are not readily obvious or guaranteed internally
20161210 21:04:03< zookeeper> i see no reason why rorthin shouldn't just pop out of somewhere during turn 2 or 3 or something in a scripted fashion. making him find delfador with an AI goal doesn't seem to serve any actual purpose.
20161210 21:04:11< DeFender1031> sometimes there's no other way to do things, but where there is, it should be done properly.
20161210 21:05:14< DeFender1031> you could even make it an event that triggers the first time delfy is within one move of a house, and remove all ambiguity whatsoever.
20161210 21:05:39< zookeeper> yeah
20161210 21:05:58< zookeeper> maybe i should just rewrite it like that right away...
20161210 21:06:24< zookeeper> because the undo issue needs to be fixed anyway
20161210 21:08:42-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 21:08:43< travis-ci> wesnoth/wesnoth#12371 (wml_tag_porting - 4517caf : Celtic Minstrel): The build is still failing.
20161210 21:08:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182892975
20161210 21:08:43-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 21:15:17< zookeeper> ah, SLF's are so capable nowadays...
20161210 21:16:38< celticminstrel> ???
20161210 21:17:46< DeFender1031> celticminstrel, do you not think that SLFs are capable?
20161210 21:17:57< celticminstrel> Well, sure.
20161210 21:18:10< celticminstrel> But I assime his comment was triggered by something in particular.
20161210 21:18:39< DeFender1031> Ah, you people always wanting to know specifics... (Just kidding. If you hadn't asked, I would have.)
20161210 21:18:53< zookeeper> well, triggered by doing what i was suggesting i might do a few lines above it :p
20161210 21:23:23-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 245 seconds]
20161210 21:25:15< zookeeper> i guess i still regularly find myself craving for a feature which would allow me to store X number of random units/locations out of all the matching ones. it gets tiring to have to generate random index variables.
20161210 21:25:24-!- grzywacz [~karol@163.172.154.146] has joined #wesnoth-dev
20161210 21:25:56< gfgtdf> zookeeper: for locations there is [random_placement]
20161210 21:26:39< zookeeper> yeah, i guess that works nicely in many situations, maybe not all
20161210 21:28:34< celticminstrel> Didn't someone add limit=? Or was that only in unit filters? Then again that wouldn't be a random selection of the matching ones, it'd be the first N matched ones, which is less likely to be what you want with location filters than with unit filters.
20161210 21:29:28< gfgtdf> zookeeper: well in the worse case you can just add the elemnts to a list in the random_placement command.
20161210 21:29:58 * celticminstrel attempts to attract vultraz's attention again.
20161210 21:30:33< zookeeper> gfgtdf, well, it's shorter to just generate a random index with RANDOM or something
20161210 21:31:01< zookeeper> but it's not a problem really, i'm just trying to keep code as short and simple as possible
20161210 21:31:13< zookeeper> and adding one or two extra lines isn't exactly a travesty
20161210 21:34:14< DeFender1031> zookeeper, you could always create a macro to simplify it.
20161210 21:34:30< DeFender1031> it IS a construct that's used a lot
20161210 21:34:53< DeFender1031> (though having a more engine-based way to do it would be better)
20161210 21:35:24< gfgtdf> if its really used a lot i think lua defiend tg woudlbe easier
20161210 21:35:28< DeFender1031> still, a macro would at least centralize it so that if an engine-based way were added down the line, the macro could be replaced with it and everywhere would get the benefit
20161210 21:35:58< DeFender1031> gfgtdf, the problem is it really ought to be part of the filter-using tags themselves.
20161210 21:36:20< gfgtdf> DeFender1031: ?
20161210 21:36:51< gfgtdf> DeFender1031: you have an example of "store X number of random locations " where random_placement is not optimal ?
20161210 21:38:34< zookeeper> ehhh, when generating a random index is as simple as {RANDOM "0..$($locs.length - 1)"}, then macroifying it further is just making it more complicated
20161210 21:39:51< DeFender1031> gfgtdf, not for storing, but for making use of. Meaning, let's say i wanted to change 5 random hexes matching a certain filter to be a new terrain type. You could do it with random_placement, but that's 5 separate calls to [terrain], rather than 1 if there were some attribute in filters themselves.
20161210 21:41:56< gfgtdf> DeFender1031: not sure what you mean, coudl you give the code?
20161210 21:43:27< DeFender1031> gfgtdf, already working on it
20161210 21:46:05-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has joined #wesnoth-dev
20161210 21:46:06< travis-ci> wesnoth/wesnoth#12372 (master - 057749b : mattsc): The build has errored.
20161210 21:46:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182895897
20161210 21:46:06-!- travis-ci [~travis-ci@ec2-54-166-111-222.compute-1.amazonaws.com] has left #wesnoth-dev []
20161210 21:46:38< DeFender1031> gfgtdf, http://paste.nachsoftware.com/DeFender1031/rCjCh9a62c1b33582edbed34b584c7750db4a3XK will run the [terrain] action five times internally. Compare with http://paste.nachsoftware.com/DeFender1031/FGzVVY9473e0967dec19e5e09584c775d3e34aww which could be done if there were a "rand_limit" attribute to filters, which only runs the action once, and is far less WML.
20161210 21:46:58< Shiki> Oh, wesnoth has 352 branches. great.
20161210 21:47:29< gfgtdf> DeFender1031: afaik terrain doesn't have  rand_limit parameter
20161210 21:48:23< Shiki> or 367..
20161210 21:48:47< gfgtdf> Shiki: wher do yu see that ?
20161210 21:49:08< gfgtdf> DeFender1031: rght didnt read your post to the end
20161210 21:49:14< DeFender1031> gfgtdf, that's what i said, if a "rand_limit" was added to the filters, then it'd simplify a lot of cases.
20161210 21:49:21< DeFender1031> gfgtdf, okay then
20161210 21:49:52< Shiki> gfgtdf, with git branch <tab> or git checkout <tab>
20161210 21:50:00< DeFender1031> basically, something that says "in addition to everything else, this filter only matches at most this amount chosen at random"
20161210 21:50:15< gfgtdf> <tab> ?
20161210 21:50:28< Shiki> tabulator key on your keyboard
20161210 21:50:38< gfgtdf> ok
20161210 21:53:10< gfgtdf> Shiki: i see ~30 branches
20161210 21:54:23< Shiki> True, me too. The rest are tags.
20161210 22:06:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161210 22:07:48-!- JyrkiVesterinen [~JyrkiVest@87-100-247-109.bb.dnainternet.fi] has quit [Quit: .]
20161210 22:10:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161210 22:17:48-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20161210 22:20:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161210 22:23:22< mattsc> celticminstrel: very first test I did, wml_actions.modify_ai() complains that wesnoth.delete_ai_component() wants a number, not a side.
20161210 22:23:38< mattsc> Should probably be sides[i].side as first argument, not sides[i] (but have not checked or tested that)
20161210 22:23:51< mattsc> Same for add_… and change_… as well
20161210 22:24:12< gfgtdf> i wonder is one of {QUANTITY var 1 2 3} or var={ON_DIFFICULCY 1 2 3} prefered over th other?
20161210 22:24:41< mattsc> I need to be off again for a couple hours, just thought I let you know quickly.
20161210 22:29:40-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161210 22:47:48-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161210 22:48:52-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161210 22:55:13< DeFender1031> isn't sides[i].side just i?
20161210 23:01:30-!- irker367 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161210 23:02:31-!- mjs-de [~mjs-de@x4db5636e.dyn.telefonica.de] has quit [Remote host closed the connection]
20161210 23:02:37< gfgtdf> DeFender1031: assuming you mean wesnoth.sides, yes
20161210 23:04:04< DeFender1031> i mean whatever mattsc was referring to, which seems to have been such.
20161210 23:08:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161210 23:37:08< zookeeper> now i ended up OCD'ing over the best, shortest and most elegant way to find the "from" and "to" locations for move_unit_faking rorthin from the nearest shrouded location next to delfador on the correct side (so he doesn't move through delfador etc)
20161210 23:37:29< zookeeper> and i'm still undecided
20161210 23:37:46< zookeeper> i guess this counts as some kind of mental exercise so not a complete waste of time
20161210 23:41:38< DeFender1031> that seems like it shouldn't be hard.
20161210 23:41:58< DeFender1031> probably something with a filter_radius
20161210 23:42:30< DeFender1031> mental excersize is fun
20161210 23:55:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161210 23:56:05< mattsc> DeFender1031: I did not mean wesnoth.sides.
20161210 23:56:35< zookeeper> the multiplayer side setup screen is confusing. have to set the faction/gender through this weird blue >> symbol and not via the actual faction/gender labels.
20161210 23:57:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161210 23:58:03< zookeeper> celticminstrel, for you, i believe: https://forums.wesnoth.org/viewtopic.php?f=21&t=44897
20161210 23:58:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
--- Log closed Sun Dec 11 00:00:40 2016