--- Log opened Sun Dec 11 00:00:40 2016
20161211 00:03:16< DeFender1031> mattsc, what's sides then?
20161211 00:03:20< mattsc> Of course, from earlier comments by celticminstrel, I’d assume that he prefers/wants wesnoth.delete_ai_component() to work with both a side number and table, but at least at the moment that does not appear to be the case.
20161211 00:04:08< mattsc> DeFender1031: the one used by wml_actions.modify_ai() in celticminstrel PR.
20161211 00:04:25< mattsc> * celticminstrel’s
20161211 00:06:56< mattsc> also: s/table/one
20161211 00:07:31< mattsc> I’m not really here, Just typing a few lines on the side while doing something else   :| 
20161211 00:12:30-!- Appleman1234 [~Appleman1@KD106161206042.au-net.ne.jp] has quit [Ping timeout: 258 seconds]
20161211 00:18:36< zookeeper> celticminstrel, you never fixed that problem with [for] requiring step=
20161211 00:21:19< mattsc> DeFender1031: it’s a table of sides that match a filter, i.e. a subset of wesnoth.sides.
20161211 00:21:42< mattsc> Thus, sides[i].side does not generally equal i.
20161211 00:27:01< DeFender1031> ahhhhh, got it
20161211 00:27:14< DeFender1031> i keep forgetting about that function
20161211 00:29:27-!- grzywacz [~karol@163.172.154.146] has quit [Remote host closed the connection]
20161211 00:34:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 00:34:46< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release mattsc 057749b: Update Xcode project Failed
20161211 00:34:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-32
20161211 00:34:50-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 00:35:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 00:39:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 00:41:04< zookeeper> good grief, this scenario
20161211 00:41:06-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161211 00:41:12< zookeeper> "Move Delfador to the signpost"
20161211 00:41:23-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161211 00:44:12< zookeeper> and these stupid pointless macros... 
20161211 00:44:15 * zookeeper rolls eyes
20161211 00:46:02< zookeeper> and hey, a translated string used to select a speaker, i bet that works great with translations
20161211 00:50:25-!- Appleman1234 [~Appleman1@KD106161213174.au-net.ne.jp] has joined #wesnoth-dev
20161211 00:51:06< DeFender1031> hahahaha
20161211 00:53:02< gfgtdf> zookeeper: if you are currnetly at fixing that scneario coudl you also make MEMOIRS_DEAD_HOUSE a balanced macro, like #define MEMOIRS_DEAD_HOUSE X Y TYPE ID NAME_STRING WML ?
20161211 00:53:13< zookeeper> gfgtdf, already did
20161211 00:53:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161211 00:53:17< zookeeper> + a bunch of other stuff
20161211 00:53:37< gfgtdf> ok thx
20161211 00:53:57< zookeeper> the dumbest and worst written stuff i've seen in mainline in a while :x
20161211 00:55:57< zookeeper> i sure hope this is just an exception and the rest of the campaign isn't the same?
20161211 00:56:59< gfgtdf> zookeeper: don't know, that scenario just attracted my attention becasue of that unbalanced macro
20161211 00:58:19-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 00:58:19< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug mattsc 057749b: Update Xcode project Failed
20161211 00:58:19< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-32
20161211 00:58:23-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 01:12:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 01:15:25< zookeeper> now, a whole lot of our hero death messages are cheesy and don't make much sense, but... delfador, really? you die exclaiming "No! So young..." about yourself?
20161211 01:17:09< DeFender1031> ugh
20161211 01:17:15< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/blob/master/src/gui/core/canvas.cpp#L1221
20161211 01:17:51< DeFender1031> i suggest that unless some kind of message actually makes sense and fits, there instead be a narration about what happened in the hero's absense.
20161211 01:19:01< DeFender1031> it can be short, just something like "Without [hero's name], the armies of [good faction] lost their will to fight, and the forces of [bad guy's name] plunged the land into darkness and despair."
20161211 01:19:27< gfgtdf> zookeeper: i think this is intended and unrelated to the change w taked about a few days ago, see the code in deaths.cfg
20161211 01:19:29< zookeeper> DeFender1031, yeah, that's the thing i like about AOI, it has nice defeat messages
20161211 01:19:46< celticminstrel> vultraz: Okay, what about it?
20161211 01:20:07 * celticminstrel was out shopping, so that's why I didn't get to respond to mattsc.
20161211 01:20:08< zookeeper> gfgtdf, uh, what? i'm just saying his death message is bad
20161211 01:20:10< vultraz> [05:36:10]	celticminstrel	vultraz: Where are there formulas operating in link_color that require it to be in hex format?
20161211 01:20:22< vultraz> it's not that it needs to be in hex format, just a string
20161211 01:20:23< celticminstrel> Yes, but that link just points me at the definition of a variable.
20161211 01:20:41< celticminstrel> Are there other typed_formulas used for colours?
20161211 01:21:24< vultraz> um
20161211 01:21:38< vultraz> possibly one other
20161211 01:21:44< vultraz> where it's run through variant()
20161211 01:21:50< celticminstrel> Where's that?
20161211 01:21:52< zookeeper> DeFender1031, i'd very much like more campaigns to have elaborate death messages like those in AOI. hint, hint.
20161211 01:21:58< gfgtdf> zookeeper: hmm ok i thought "now a whole lot of our hero death messages are cheesy" referes to the change in [endlevel] in last breath events we talked about.
20161211 01:22:08< zookeeper> gfgtdf, nah, just the writing in general
20161211 01:22:14< vultraz> styled_widget
20161211 01:22:16< vultraz> or label
20161211 01:22:56< celticminstrel> [Dec 10@8:17:51pm] DeFender1031: i suggest that unless some kind of message actually makes sense and fits, there instead be a narration about what happened in the hero's absense.
20161211 01:22:57< celticminstrel> [Dec 10@8:19:01pm] DeFender1031: it can be short, just something like "Without [hero's name], the armies of [good faction] lost their will to fight, and the forces of [bad guy's name] plunged the land into darkness and despair."
20161211 01:22:57< celticminstrel> This sounds like a good idea, maybe I'll apply it to my campaign too...
20161211 01:23:06< DeFender1031> zookeeper, i wouldn't mind improving some of the text in various campaigns...
20161211 01:23:32-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 01:23:32< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release mattsc 057749b: Update Xcode project Failed
20161211 01:23:32< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-33
20161211 01:23:36-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 01:24:06< DeFender1031> celticminstrel, zookeeper, in my campaign, I try to keep the dialogue realistic and people's motivations and speaking style consistent.
20161211 01:24:30< vultraz> celticminstrel: btw, can you add a rect() object to WFL?
20161211 01:24:42< celticminstrel> vultraz: That would be super-easy.
20161211 01:24:48< celticminstrel> You could probably do it yourself.
20161211 01:24:51< zookeeper> anyway, i think i got that scenario's code sorted out, but will have to test it a bit more...
20161211 01:24:56< vultraz> I don't know where the code is.
20161211 01:24:58 * zookeeper goes sleep
20161211 01:25:22< gfgtdf> zookeeper: did you update the projectifles?
20161211 01:25:29< celticminstrel> All you need is a new descendant of formula_callable (add to formula/callable.?pp) and, if you want it to be constructible from WFL code, a new formula function (in formula/functions.cpp IIRC).
20161211 01:27:21< gfgtdf> celticminstrel, vultraz formula with locations currently leak memory, it seems like this https://github.com/wesnoth/wesnoth/blob/master/src/formula/function.cpp#L1387 location_callable isn't freed
20161211 01:28:20< celticminstrel> Does that apply only to locations? What about the pair() function for example?
20161211 01:28:44< celticminstrel> (FTR vultraz, that's precisely where you'd add the definition for a rect() WFL function.)
20161211 01:28:50-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has quit [Ping timeout: 264 seconds]
20161211 01:29:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20161211 01:30:44< gfgtdf> celticminstrel: don't know, i just saw some bugreports on our tracter about memoryleaks from that line, and you mentioing formula_callable rememberd me of that
20161211 01:31:41< celticminstrel> You mean reminded, not remembered.
20161211 01:32:01< gfgtdf> not sure what teh difference is
20161211 01:32:30< celticminstrel> You remind a person of something, which helps that person to remember the aforementioned something.
20161211 01:32:57 * celticminstrel is currently all fuddled and trying to sort out what I need to do next.
20161211 01:33:11< gfgtdf> my guess is that this is related by your removal of instrusive_ptr in formula.
20161211 01:33:22< celticminstrel> That was vultraz, not me.
20161211 01:33:33< celticminstrel> I have no idea why he decided to do that.
20161211 01:34:05< celticminstrel> Mind you, the intrusive_ptr use in formulas was a bit weird - in many cases the code had to manually increase the refcount.
20161211 01:36:29< celticminstrel> Possibility: Make variant (or formula_callable? Not 100% sure THB) inherit from enable_shared_from_this, and delete all predefined constructors and use the named constructor idiom.
20161211 01:37:08< celticminstrel> The named constructors would of course return a shared_ptr in that case.
20161211 01:37:27< celticminstrel> I'm not sure if this is a good idea (mainly due to that parenthetical above).
20161211 01:37:33< celticminstrel> ^TBH
20161211 01:45:39-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 01:45:39< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug mattsc 057749b: Update Xcode project Failed
20161211 01:45:39< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-33
20161211 01:45:43-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 01:50:19< celticminstrel> Oh right, that failure is probably because no-one updated the VC priject.
20161211 01:55:47-!- irker099 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161211 01:55:47< irker099> wesnoth: Celtic Minstrel wesnoth:master 87d92119f38d / src/gui/widgets/unit_preview_pane.cpp: Fix problem with viewing unit descriptions for hidden units https://github.com/wesnoth/wesnoth/commit/87d92119f38d6a3f52f9c3999affc2fbfe731498
20161211 01:55:47< irker099> wesnoth: Celtic Minstrel wesnoth:master 76f725415d3f / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update MSVC project https://github.com/wesnoth/wesnoth/commit/76f725415d3f27ca3ef2c68e65d5a752a03cb034
20161211 01:55:50< celticminstrel> zookeeper: ^
20161211 02:10:44-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 02:11:03< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f76365570b8f / / (8 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/f76365570b8f9276acbec6b3dc865e8ca9923ca9
20161211 02:11:05< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f00e2e1338f7 / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/f00e2e1338f781424c88ab034dbf0bbe0ff875c9
20161211 02:11:07< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting eb369ff27bd6 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/eb369ff27bd6dbfcb0abb8d0c7b67b5836f789a5
20161211 02:11:09< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5008b5b9b2f4 / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/5008b5b9b2f47330bc400f9efaf4ba6c3c8cd3ab
20161211 02:11:11< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c1bc47861f59 / / (7 files in 5 dirs): WIP port of [animate_unit] https://github.com/wesnoth/wesnoth/commit/c1bc47861f59fc03c412ff97624771b0131ab247
20161211 02:11:28< celticminstrel> gfgtdf: Renamed it set_side_id for the moment, still open for further suggestions.
20161211 02:11:36< celticminstrel> mattsc: That should also fix the modify_ai issue.
20161211 02:11:51< celticminstrel> Now, was there something else I needed to do...?
20161211 02:44:33< mattsc> celticminstrel: thanks, but: “src/scripting/game_lua_kernel.cpp:2852:22: error: out-of-line definition of 'intf_set_side_id' does not match any declaration in 'game_lua_kernel’”
20161211 02:46:31< gfgtdf> celticminstrel: sp how is it named now?
20161211 02:46:34< gfgtdf> so*
20161211 02:48:10< gfgtdf> celticminstrel: i dont really now the forumla code, neigher i know all cases that need to be tested to make sure this issue is fixed, so if i had to fix those meeory issues i'd most likeley tr to revert the instrusive_ptr removal.
20161211 02:52:20-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 02:52:21< travis-ci> wesnoth/wesnoth#12374 (master - 76f7254 : Celtic Minstrel): The build passed.
20161211 02:52:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182948956
20161211 02:52:22-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 02:55:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 02:55:26-!- gfgtdf [~chatzilla@x4e368976.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161211 02:56:16-!- gfgtdf [~chatzilla@x4e363730.dyn.telefonica.de] has joined #wesnoth-dev
20161211 02:56:32< celticminstrel> mattsc: Oh, whoops. I forgot to change it in the header.
20161211 02:56:52< celticminstrel> mattsc: Quickfix: Search game_lua_kernel.hpp for set_team_id and replace it with set_side_id.
20161211 02:57:04< celticminstrel> gfgtdf: How is what named?
20161211 02:57:33< mattsc> celticminstrel: cool, that’s easy (and I guess I could have figured that out myself …)
20161211 02:58:07< gfgtdf> celticminstrel: if i knew it's name i wouldnt ask :p
20161211 02:58:19< gfgtdf> celticminstrel: but i meant set_side_id
20161211 02:58:39< celticminstrel> Yeah, that's how I named it. I can rename it again if we can settle on a better name.
20161211 02:59:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 02:59:46< celticminstrel> gfgtdf: As for the intrusive_ptr removal, just reverting it wouldn't really make me feel much better, since it seemed like there were some holes in it.
20161211 03:00:13< gfgtdf> celticminstrel: i still say id isnt a good name, i agree that  set_flag_and_color doesn't that good but i still think its better.
20161211 03:00:21< gfgtdf> celticminstrel: why do you think there were holes?
20161211 03:00:49< celticminstrel> gfgtdf: Because there were several places where the refcount was manually incremented or decremented.
20161211 03:01:50< celticminstrel> And I definitely see why you'd say id isn't a good name.
20161211 03:03:15< gfgtdf> celticminstrel: which dosnt mean that that code is wrong, i think the reason why they were manually added/removed is that https://github.com/wesnoth/wesnoth/blob/master/src/formula/variant.hpp#L163is an a union so it has to be a pod (likepointer) type (instead of intrusive_ptr) so thee variant cose handles th refcount manually
20161211 03:07:44< celticminstrel> gfgtdf: I'm saying that the fact they needed to be manually added/removed is suspicious.
20161211 03:14:08-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 03:14:09< travis-ci> wesnoth/wesnoth#12375 (wml_tag_porting - c1bc478 : Celtic Minstrel): The build is still failing.
20161211 03:14:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182950580
20161211 03:14:09-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 03:16:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 03:21:50< mattsc> celticminstrel: This code http://pastebin.com/w45Vw9Mn removes the CA from side 1, not side 2.
20161211 03:21:53< mattsc> I checked that sides[i].side has the correct value (2) in wml_actions.modify_ai(), so the problem must be in wesnoth.delete_ai_component()
20161211 03:22:15< mattsc> I really have to go right now though, so I can’t investigate further.
20161211 03:24:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161211 03:29:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 03:32:46< celticminstrel> mattsc: My initial suspicion is that it simply subtracts 1 from the side number when it shouldn't.
20161211 03:33:41< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 941a1bf2550f / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp): fixup! Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/941a1bf2550fee14afe4fc0b52ad10f7be05f591
20161211 03:34:00< celticminstrel> So, if specifying side 3 instead modifies side 2, that would support my suspicion.
20161211 03:34:15< celticminstrel> Figuring it out from code-reading is nontrivial. >_>
20161211 03:35:52< gfgtdf> celticminstrel: hmm but i dont really see another way without using boost::variant or a manual equivalent. The new code just doesnt update the refcount and leaks memory.
20161211 03:36:32< celticminstrel> Well, it doesn't have a refcount anymore, right?
20161211 03:37:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161211 03:38:35< celticminstrel> Theoretically you could probably put shared_ptr or similar in the union now, but not sure if MSVC 2013 supports it.
20161211 03:41:56< mattsc> celticminstrel: well, you can’t just add side=3 in the WML as it then does not match any sides (my test scenario only has 2 sides), but when I add +1 to the call to delete_ai_component() then that’s what happens, yes.
20161211 03:42:36< celticminstrel> So if you do that, using it on side 1 works as well?
20161211 03:42:43< celticminstrel> While if you don't do that, it's probably an error?
20161211 03:42:51< mattsc> umm, haven’t tried that, give me a second
20161211 03:42:57< celticminstrel> (Might need my latest push for it to be an error, not sure.)
20161211 03:43:18< celticminstrel> (Oh, no, that was something else.)
20161211 03:43:26< celticminstrel> (The latest push is irrelevant to modify_ai.)
20161211 03:44:33< mattsc> yes, works on side 1 with the +1
20161211 03:45:28< mattsc> and nothing happens if you omit the +1 in that case (no error, no removal of CA from any side)
20161211 03:45:30-!- gfgtdf [~chatzilla@x4e363730.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.0.2/20161129173726]]
20161211 03:45:48< celticminstrel> Seems like the AI code will just blindly create an AI stack for sides that don't exist.
20161211 03:46:01< celticminstrel> (I really want to know why there's a stack there at all.)
20161211 03:46:11< mattsc> okay, I’m _really_ out of time now though, sorry.  I’ll pick this up again either later tonight or, more likely, tomorrow.
20161211 03:46:15< celticminstrel> Okay.
20161211 03:46:25< celticminstrel> I'll push a fix for this like, now.
20161211 03:46:31< celticminstrel> And rebase it later.
20161211 03:46:33< mattsc> okay
20161211 03:46:37< mattsc> ttyl
20161211 03:46:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161211 03:47:25< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting dd5f290944cb / src/scripting/game_lua_kernel.cpp: fixup! Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/dd5f290944cb73c15da13d12a387f3f096ceb353
20161211 04:03:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161211 04:22:13-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 04:22:14< travis-ci> wesnoth/wesnoth#12377 (wml_tag_porting - 941a1bf : Celtic Minstrel): The build is still failing.
20161211 04:22:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182958819
20161211 04:22:14-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 04:31:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 04:32:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 04:36:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Ping timeout: 258 seconds]
20161211 04:37:11 * celticminstrel pokes vultraz 
20161211 04:37:25< celticminstrel> Is there any particular reason to support http(s) links only?
20161211 04:37:32< vultraz> eh?
20161211 04:37:39< vultraz> what are you talking about
20161211 04:37:59< celticminstrel> src/font/pango/hyperlink.hpp
20161211 04:39:58< vultraz> it supports both
20161211 04:40:57< vultraz> we should probably use https for all links we post
20161211 04:41:20< celticminstrel> Is there any particular reason to only support http(s)?
20161211 04:41:35 * celticminstrel notes that this is mainly relevant to lobby chat, probably.
20161211 04:41:52< vultraz> I don't really see a particular reason either way
20161211 04:42:03< Aginor> security, proof against modification, to some extent privacy
20161211 04:42:26< vultraz> A wild Aginor appears!
20161211 04:42:37< celticminstrel> Proof against modification?
20161211 04:42:40< celticminstrel> I don't really get it?
20161211 04:43:06< Aginor> celticminstrel: it's hard for a proxy/<device> to do in-stream modification of an encrypted stream
20161211 04:43:24< celticminstrel> ...
20161211 04:43:38< celticminstrel> I'm asking if there is any reason to support only http and https.
20161211 04:43:49< celticminstrel> Not if there is any reason to support one of those over the other.
20161211 04:43:54< Aginor> :D
20161211 04:43:58< Aginor> sorry
20161211 04:44:12< Aginor> no, but what consists of a real valid URI?
20161211 04:44:23< celticminstrel> That's an extremely hard question, admittedly.
20161211 04:44:32< Aginor> yes, there's an RFC for it
20161211 04:44:36< celticminstrel> But I'd just say "if it starts with [a-z]:// or www\.".
20161211 04:45:09< Aginor> but it's also been somewhat ambiguiated by various places extending them to be skype://blah or hipchat://<blah> and so on
20161211 04:45:24< Aginor> https://tools.ietf.org/html/rfc3986
20161211 04:45:29< Aginor> for the interested party
20161211 04:45:29< celticminstrel> But those are valid URLs, aren't they?
20161211 04:45:43< Aginor> URL is a special case of an URI
20161211 04:45:55< celticminstrel> URIs or whatever.
20161211 04:47:06< Aginor> celticminstrel: so what additional schemes do you want to support?
20161211 04:47:53< celticminstrel> Well, the only one I was really thinking about was irc, but I don't have strong opinions here. It was just a thought about something I noticed in passing.
20161211 04:48:24< Aginor> http://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
20161211 04:48:26 * celticminstrel also thought of ftp, but I doubt that one's worth it if you're going to just consider a whitelist of schemes.
20161211 04:48:31< Aginor> there's your list of official ones :D
20161211 04:48:53< Aginor> http://www.iana.org/assignments/uri-schemes/prov/irc
20161211 04:49:34< Aginor> http://www.iana.org/assignments/uri-schemes/prov/irc6
20161211 04:49:39< Aginor> http://www.iana.org/assignments/uri-schemes/prov/ircs
20161211 04:50:01< celticminstrel> I really want to know why there are three of them when they're all identical.
20161211 04:50:16< Aginor> it's three different schemas though
20161211 04:50:33< Aginor> the first one is for ipv4, the second for ipv6, the final for tls support
20161211 04:50:47< celticminstrel> Why would you need a separate scheme for ipv6?
20161211 04:51:06< Aginor> because someone thought it was a good idea at the time
20161211 04:51:08< celticminstrel> A separate scheme for tls support does sorta make sense though.
20161211 04:51:10< Aginor> I think it's silly
20161211 04:52:50< Aginor> I wonder how many of these old crufty schemas can be used for attacks :D
20161211 04:52:57< celticminstrel> vultraz: I think inverse makes sense to add to color_t.
20161211 04:53:17< celticminstrel> Shall I do that?
20161211 04:53:23< vultraz> sure
20161211 04:53:35< vultraz> but you need to decide how to deal with alpha
20161211 04:53:44< vultraz> since the current use is ignore it
20161211 04:53:48< celticminstrel> That's obvious to me - preserve it.
20161211 04:54:14< Aginor> seconded
20161211 04:55:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 04:56:47< vultraz> youll end up with an invisible color then
20161211 04:56:56< celticminstrel> Why?
20161211 04:57:12< vultraz> const color_t DISABLED_COLOR = inverse(PETRIFIED_COLOR);
20161211 04:57:21< vultraz> PETRIFIED_COLOR {0xA0, 0xA0, 0xA0},
20161211 04:57:24< vultraz> implicit 255 alpha
20161211 04:57:30< celticminstrel> If the behaviour is to preserve alpha, then you'll only get an invisible colour if the input was an invisible colour.
20161211 04:57:32< vultraz> which would mean 0 alpha for DISABLED_COLOR
20161211 04:57:36< celticminstrel> Uhh.
20161211 04:57:40< celticminstrel> I said preserve, not invert.
20161211 04:57:45< vultraz> oh
20161211 04:57:49< vultraz> derrpp
20161211 04:57:50< vultraz> >_>
20161211 04:57:54< celticminstrel> :P
20161211 05:00:00< vultraz> what happens when you're looking at two things at once
20161211 05:00:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Ping timeout: 258 seconds]
20161211 05:10:11-!- JyrkiVesterinen [~JyrkiVest@87-100-178-101.bb.dnainternet.fi] has joined #wesnoth-dev
20161211 05:19:02< irker099> wesnoth: Celtic Minstrel wesnoth:master 3f0485aaa4cc / src/ (8 files in 4 dirs): Store link colour as color_t https://github.com/wesnoth/wesnoth/commit/3f0485aaa4cc5964e64f34ae26bf2c50159a2494
20161211 05:19:04< irker099> wesnoth: Celtic Minstrel wesnoth:master 9f102269bca9 / src/ (color.hpp font/standard_colors.cpp): Move inverse function into color_t https://github.com/wesnoth/wesnoth/commit/9f102269bca9420937704c9266dfc990411d1cb9
20161211 05:19:06< irker099> wesnoth: Celtic Minstrel wesnoth:master aa6ee42db5d1 / src/ (image_modifications.cpp sdl/utils.cpp sdl/utils.hpp): Remove adjust_surface_alpha_formula https://github.com/wesnoth/wesnoth/commit/aa6ee42db5d1564f4dcdbf2bc81d4a317240ee01
20161211 05:19:08< celticminstrel> vultraz: How's that look?
20161211 05:21:07< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 683a1fd2c648 / data/lua/wml-tags.lua src/scripting/game_lua_kernel.cpp: fixup! Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/683a1fd2c648d735f0c23ddf0cc2eee669d4e434
20161211 05:22:30< celticminstrel> (And anyone else is welcome to look it over too.)
20161211 05:29:24< celticminstrel> Also, vultraz, should forum-Shiki get a title?
20161211 05:32:42-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 05:32:43< travis-ci> wesnoth/wesnoth#12381 (master - aa6ee42 : Celtic Minstrel): The build was broken.
20161211 05:32:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182967085
20161211 05:32:43-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 05:35:43< celticminstrel> Uh-oh.
20161211 05:37:05< celticminstrel> Aww, meh.
20161211 05:38:01< irker099> wesnoth: Celtic Minstrel wesnoth:master b5d25135fcf5 / src/color.hpp: Remove constexpr, because it needs to be everywhere or nowhere https://github.com/wesnoth/wesnoth/commit/b5d25135fcf586a629657c0a5b6478a68661cd62
20161211 05:38:14< celticminstrel> ...slightly misleading message, I guess, but the diff speaks for itself.
20161211 05:40:39< celticminstrel> Also I'm still getting the incomprehensible null pointer access.
20161211 05:43:21< JyrkiVesterinen> celticminstrel: As I asked when you were sleeping, have you installed latest Visual Studio updates?
20161211 05:43:30< celticminstrel> Uh.
20161211 05:43:41< celticminstrel> Well, I don't recall seeing any notifications about VS updates.
20161211 05:44:12< JyrkiVesterinen> There isn't much that _can_ be different between your Wesnoth builds and mine. Both the source code and the compiler are the same.
20161211 05:44:27< JyrkiVesterinen> And I can't reproduce the crash.
20161211 05:46:22< celticminstrel> I have a few Windows 7 updates pending but nothing that looks VS-related... is there a way to check for updates within the program?
20161211 05:46:22< JyrkiVesterinen> Tools -> Extensions and Updates... -> Updates.
20161211 05:46:55< celticminstrel> Oh hey, five updates pending there.
20161211 05:47:29< celticminstrel> Two of which look possibly-relevant.
20161211 05:47:33< celticminstrel> I'll install them and try again.
20161211 05:48:07< celticminstrel> Correction: One of which looks relevant.
20161211 05:48:12 * celticminstrel misread the other one.
20161211 05:55:09< celticminstrel> Updates are now installing. Both Windows updates and MSVC updates. At the same time. >_>
20161211 05:56:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 06:01:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Ping timeout: 258 seconds]
20161211 06:21:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 06:24:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 06:46:04-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has joined #wesnoth-dev
20161211 07:12:53< celticminstrel> So the updates didn't make any difference.
20161211 07:14:17< celticminstrel> Only other thing I can think of is something about the Boost version?
20161211 07:16:48< celticminstrel> Unrelatedly, I'm wondering why we haven't seen a single AppVeyor announcement since I updated the MSVC project.
20161211 07:17:42< celticminstrel> Last one was five and a half hours ago.
20161211 07:18:15< vultraz> celticminstrel: thanks for those commits
20161211 07:18:16< celticminstrel> Maybe that's expected, not sure.
20161211 07:18:23< celticminstrel> vultraz: So how do they look
20161211 07:18:33< vultraz> fine to me at a glance
20161211 07:18:50< celticminstrel> Hopefully I didn't break link_color since my build won't run at all.3
20161211 07:18:54< celticminstrel> <_<
20161211 07:19:03< vultraz> I'll check once I compile
20161211 07:19:25< vultraz> color.hpp causes a huge rebuild :P
20161211 07:20:16< vultraz> and it cannot be forward-declared
20161211 07:20:24< celticminstrel> Why not?
20161211 07:20:35< celticminstrel> Oh, I guess because it's generally used by value.
20161211 07:21:22< celticminstrel> So what should we do with PR 882?
20161211 07:22:51< vultraz> we need to hear from tad
20161211 07:23:07< celticminstrel> I thought the plan would be to merge that first, then have tad update his "all tools" PR.
20161211 07:23:23< celticminstrel> What do we need to hear from tad about?
20161211 07:24:21< vultraz> oh wait
20161211 07:24:24< vultraz> wrong pr
20161211 07:24:26< vultraz> i have no idea
20161211 07:24:50< celticminstrel> Basically means you don't need to separately update CMake and Sconscript every time you add/remove/move a file.
20161211 07:25:00< vultraz> oh?
20161211 07:25:16< celticminstrel> Instead you just add the file to a single list used by both.
20161211 07:25:35< celticminstrel> Admittedly it may occasionally be non-obvious whether it should go in wesnoth or some libwesnoth thing.
20161211 07:25:44< vultraz> that would be desirable 
20161211 07:25:55< celticminstrel> https://github.com/wesnoth/wesnoth/pull/882
20161211 07:31:46< celticminstrel> I also wish we could get PR 616 merged. It's been sitting there forever.
20161211 07:32:13< celticminstrel> I'm not super-invested in it, admittedly, but it seems like some people want it, and it doesn't really hurt IMO.
20161211 07:32:30< vultraz> what is it?
20161211 07:32:36< Aginor> I'm not too keen on it, it'll look like it will break how my IDE picks up source files
20161211 07:32:37< celticminstrel> bootstrap.py
20161211 07:32:41< vultraz> ah yes
20161211 07:32:45< celticminstrel> Aginor: You mean 882?
20161211 07:32:51< Aginor> yes
20161211 07:33:01< celticminstrel> Can you elaborate?
20161211 07:33:04< Aginor> I use cLion, which uses cmake as project definitions
20161211 07:33:17< Aginor> I suspect it'll not work great if cmake reads the source lists
20161211 07:33:31< Aginor> but I'd have to try it out before I could have a firmer opinion
20161211 07:33:39< celticminstrel> I see.
20161211 07:34:13< celticminstrel> ...oh wow, github now offers conflict resolution.
20161211 07:34:21< celticminstrel> I only just noticed that now.
20161211 07:34:30< vultraz> eh?
20161211 07:34:40< celticminstrel> When did that appear? o.o
20161211 07:34:57< vultraz> no ide
20161211 07:34:59< vultraz> a
20161211 07:35:03< celticminstrel> Well, we should probably not merge it right now if it might cause problems for Aginor though.
20161211 07:36:07< vultraz> but that's awesome
20161211 07:37:47< Aginor> I'll try out the PR locally later
20161211 07:38:01< Aginor> curerntly trying to get some consulting done
20161211 07:38:18< celticminstrel> I also want to resolve these French PRs somehow.
20161211 07:38:42< celticminstrel> Definitely not merging them as-is, they'd need to be squashed into one (yes, all three PRs).
20161211 07:38:58< celticminstrel> But I don't want to step on Ivanovic's toes or anything.
20161211 07:41:15< vultraz> Ivanovic won't get involved, probably
20161211 07:41:51< vultraz> he's barely involved as it s
20161211 07:44:44< celticminstrel> So many PRs to resolve... :|
20161211 07:45:16< celticminstrel> Mainly :| because some of them have been sitting around for quite some time.
20161211 07:45:25< vultraz> celticminstrel: link colors are fine\
20161211 07:45:29-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 07:45:30< travis-ci> wesnoth/wesnoth#12384 (master - b5d2513 : Celtic Minstrel): The build is still failing.
20161211 07:45:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182968215
20161211 07:45:30-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 07:45:36< celticminstrel> Aww.
20161211 07:46:40< celticminstrel> Segfault in tests.
20161211 07:47:46< celticminstrel> Something to do with config cache?
20161211 07:47:57< celticminstrel> Or something?
20161211 07:48:12< celticminstrel> (If you scroll to the very bottom of the log there's a thing you can expand for a stack trace.)
20161211 07:49:18< vultraz> it's something in your color_t formula
20161211 07:49:21< celticminstrel> Wait, the stack trace seems to indicate something config related, but just above that it mentions something formula related.
20161211 07:49:32< celticminstrel> Okay sure.
20161211 07:49:50< celticminstrel> How can you tell?
20161211 07:49:54< vultraz> as_int
20161211 07:50:01< celticminstrel> Well okay, sure.
20161211 07:50:07< vultraz> #0  0x0000000000600f54 in variant::as_int() const ()
20161211 07:50:08< vultraz> #1  0x00000000006a80c9 in gui2::typed_formula<color_t>::execute(game_logic::map_formula_callable const&, game_logic::function_symbol_table*) const ()
20161211 07:50:10< vultraz> #2  0x00000000006a908e in gui2::typed_formula<color_t>::operator()(game_logic::map_formula_callable const&, game_logic::function_symbol_table*) const ()
20161211 07:50:11< vultraz> #3  0x00000000006a28eb in gui2::(anonymous namespace)::text_shape::draw(surface&, SDL_Renderer*, game_logic::map_formula_callable const&) ()
20161211 07:50:24< celticminstrel> Ohhhh, there are multiple threads and thus multiple stacks.
20161211 07:50:28< celticminstrel> I was reading the wrong stack.
20161211 07:50:41< celticminstrel> Okay.
20161211 07:50:58< celticminstrel> But it's a segfault, not an assertion failure as I would've expected.
20161211 07:51:11< celticminstrel> Doesn't seem to have line numbers.
20161211 07:52:49< celticminstrel> It's either line 235 or 236 in typed_formula.hpp.
20161211 07:52:55< celticminstrel> But 236 seems unlikely since it uses .at().
20161211 07:53:17< celticminstrel> And 235 seems unlikely since it only indexes the vector if the element has been tested to exist.
20161211 07:53:41< celticminstrel> Obviously it has to be one of them though.
20161211 07:54:14< celticminstrel> Oh wait, what about the possibility that the vector was already destroyed...
20161211 07:55:55< irker099> wesnoth: Celtic Minstrel wesnoth:master 2bbe419a4478 / src/gui/auxiliary/typed_formula.hpp: Fix segfault in typed_formula<color_t>::execute https://github.com/wesnoth/wesnoth/commit/2bbe419a44783aa00a8f060276a8e534097a53b4
20161211 07:55:57< celticminstrel> Pretty sure that's it.
20161211 07:56:00< celticminstrel> Now bed.
20161211 07:56:04-!- celticminstrel is now known as celmin|sleep
20161211 08:12:17-!- Kwandulin [~Miranda@p200300760F6EBFB140AAE4A339A31A8A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161211 08:39:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 08:39:18< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel 2bbe419: Fix segfault in typed_formula<color_t>::execute Succeeded
20161211 08:39:18< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-33
20161211 08:39:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 08:53:58-!- TC02 [~quassel@venus.arosser.com] has quit [Ping timeout: 250 seconds]
20161211 08:55:12-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 08:55:13< travis-ci> wesnoth/wesnoth#12385 (master - 2bbe419 : Celtic Minstrel): The build was fixed.
20161211 08:55:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/182977864
20161211 08:55:13-!- travis-ci [~travis-ci@ec2-54-161-246-149.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 08:58:11< Aginor> Ok, PR 822 seems to work for me
20161211 09:01:39< Aginor> although I really hope I did somehting wrong when merging because the debug builds seems to have disappeared for me at the same time
20161211 09:02:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 09:02:46< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel 2bbe419: Fix segfault in typed_formula<color_t>::execute Succeeded
20161211 09:02:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-33
20161211 09:02:50-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 09:10:28-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161211 09:25:19< irker099> wesnoth: Wedge009 wesnoth:master f535b6a9f7c8 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters wesnothlib.vcxproj.filters): Minor updates to VC project. https://github.com/wesnoth/wesnoth/commit/f535b6a9f7c8a19bd327f192056947becf73b930
20161211 09:27:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161211 09:34:54-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 09:34:54< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Celtic Minstrel 2bbe419: Fix segfault in typed_formula<color_t>::execute Succeeded
20161211 09:34:54< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-34
20161211 09:34:58-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 09:38:43< zookeeper> celmin|sleep, <zookeeper> celticminstrel, you never fixed that problem with [for] requiring step=
20161211 09:42:01-!- vultraz changed the topic of #wesnoth-dev to: 1.13.7 scheduled for sometime in the new year | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161211 09:46:31< zookeeper> oh, delayed?
20161211 09:46:37< zookeeper> why's that
20161211 09:48:37< vultraz> sota won't be done by next week
20161211 09:48:44< vultraz> and im heading stateside in a week and won't be able to manage stuff
20161211 09:48:53< vultraz> it's too close to the holidays
20161211 09:49:02< vultraz> so im basically giving everyone off until january
20161211 09:49:42< zookeeper> i see
20161211 09:52:55< vultraz> do you want to work over christmas? :P
20161211 09:53:26< zookeeper> best time to get stuff done
20161211 09:53:53< zookeeper> although i admit that usually over the holidays i tend to get sloppy and actually - gasp - play some games
20161211 09:54:20< vultraz> :O
20161211 09:58:19< vultraz> the biggest reason, though, is there simply isn't enough content for a release
20161211 09:58:24-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 09:58:24< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Celtic Minstrel 2bbe419: Fix segfault in typed_formula<color_t>::execute Succeeded
20161211 09:58:24< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-34
20161211 09:58:29-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 09:58:30< vultraz> I've converted 2 more dialogs to gui2
20161211 09:58:35-!- Kwandulin [~Miranda@p200300760F6EBFB140AAE4A339A31A8A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161211 09:58:38< vultraz> but one is a hidden debug dialog
20161211 09:58:45< vultraz> the new campaign isn't ready
20161211 09:59:00< vultraz> we haven't fixed a large number of bugs reported on the thread
20161211 10:00:22< vultraz> We can't rush a release in a week.
20161211 10:00:31< vultraz> not with so much to do
20161211 10:01:48< vultraz> nor would one want to
20161211 10:12:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161211 10:16:46< zookeeper> the UtBS bugs and fixes are kind of a big thing, so maybe i'll just post fixed files on the forums in the meanwhile or something.
20161211 10:17:08< vultraz> well
20161211 10:17:21< vultraz> I suppose we could make a release
20161211 10:17:25< vultraz> just not with much stuff
20161211 10:33:59-!- mjs-de [~mjs-de@x4e312cc1.dyn.telefonica.de] has joined #wesnoth-dev
20161211 10:34:32-!- Kwandulin [~Miranda@p200300760F6EBFB198012A6B939CA276.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161211 10:40:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161211 10:43:50-!- DeFender1031 [~DeFender1@46-116-15-217.bb.netvision.net.il] has quit [Ping timeout: 264 seconds]
20161211 10:50:08< zookeeper> vultraz, the standing anims for shadows (at least when nightstalking) is messed up, the transparency disappears for a moment between every repeat, i think.
20161211 10:51:35< zookeeper> yeah, only when nightstalking.
20161211 10:52:34< zookeeper> _maybe_ the alpha wrapsaround, when the normal standing anim alpha and the nightstalk alpha reduction are combined
20161211 10:52:38 * zookeeper shrugs
20161211 10:57:13-!- abruanese_ [U2FsdGVkX1@ma.sdf.org] has joined #wesnoth-dev
20161211 11:00:38-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has quit [Ping timeout: 264 seconds]
20161211 11:03:46-!- abruanese [~a@45.63.76.107] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in]
20161211 11:04:45-!- Kwandulin [~Miranda@p200300760F6EBFB198012A6B939CA276.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161211 11:07:27-!- abruanese_ is now known as abruanese
20161211 11:24:22< irker099> wesnoth: ln-zookeeper wesnoth:master 61ede9abc811 / data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg: DM: Fixed and improved the code of S09 https://github.com/wesnoth/wesnoth/commit/61ede9abc8111c9e062bd16454aff539205f8e51
20161211 11:35:12< zookeeper> the things that were wrong with that scenario: https://paste.ee/p/7rxmf (i might have already forgotten some)
20161211 11:48:33-!- JyrkiVesterinen [~JyrkiVest@87-100-178-101.bb.dnainternet.fi] has quit [Quit: .]
20161211 12:02:00-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161211 12:04:45-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 258 seconds]
20161211 12:08:56-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20161211 12:09:11-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161211 12:31:15< vultraz> wow
20161211 13:01:00< irker099> wesnoth: gfgtdf wesnoth:master 0383e713ec7e / src/scripting/lua_team.cpp: fix lua side:matches always iterating over all units on the map. https://github.com/wesnoth/wesnoth/commit/0383e713ec7e394351c2ed94f91c2e7a9969dbaf
20161211 13:04:08< vultraz> gfgtdf: hm how does that work?
20161211 13:05:28< vultraz> gfgtdf: I can't see how that would reduce iterations 
20161211 13:10:18-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 258 seconds]
20161211 13:10:50-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161211 13:14:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161211 13:14:35-!- mkdr0id is now known as mkdroid
20161211 13:18:31-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161211 13:30:41-!- DeFender1031 [~DeFender1@dsl217-132-62-187.bb.netvision.net.il] has joined #wesnoth-dev
20161211 13:32:50 * zookeeper wonders why elvish shamans' attack is called entangle, while druids' is called ensnare
20161211 13:33:10< zookeeper> sorceress line retains entangle
20161211 13:34:10< DeFender1031> variety?
20161211 13:34:54< zookeeper> maybe, maybe not
20161211 13:41:07-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has joined #wesnoth-dev
20161211 13:54:36-!- JyrkiVesterinen [~JyrkiVest@87-92-28-81.bb.dnainternet.fi] has joined #wesnoth-dev
20161211 13:57:03< JyrkiVesterinen> vuktraz: Neither do I. To me, it looks like gfgtdf's commit only _increases_ the amount of work.
20161211 13:57:34< JyrkiVesterinen> calculate_team_data() was previously called once. Now it's called five times.
20161211 13:58:39< vultraz> exactly
20161211 14:00:39-!- gfgtdf [~chatzilla@x4e363730.dyn.telefonica.de] has joined #wesnoth-dev
20161211 14:08:25-!- Kwandulin [~Miranda@p200300760F6EBFB1B0D7202DF4EEBA9B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161211 14:14:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161211 14:42:08< irker099> wesnoth: ln-zookeeper wesnoth:master f16550f53891 / data/campaigns/Delfadors_Memoirs/scenarios/09_Houses_of_the_Undead.cfg: DM: Fixed very unlikely case of possible breakage https://github.com/wesnoth/wesnoth/commit/f16550f53891c71ae1a2cda00a96ce42be206713
20161211 14:52:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161211 14:52:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161211 15:14:13-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161211 15:18:52-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161211 15:33:39< mattsc> celmin|sleep: I left two comments on code problems in PR881 on the github website.  I apparently don’t get notifications about my own comments.  Did you get notified about it?
20161211 15:33:52< mattsc> Just asking so that next time I know whether I need to point this out to you...
20161211 15:40:38< zookeeper> i don't get e-mails about my own comments either
20161211 15:45:53< mattsc> zookeeper: okay, thanks
20161211 15:46:41< mattsc> celmin|sleep: also, ‘~compoment’ needs to be ‘not component’ for ‘change’ in modify_ai().
20161211 15:47:13< mattsc> I’m glad I am doing all this testing, I guess ...
20161211 15:48:03-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161211 15:48:49< mattsc> s/compoment/component, of course
20161211 16:04:38-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 16:04:39< travis-ci> gfgtdf/wesnoth#725 (master - 2e69b4c : gfgtdf): The build has errored.
20161211 16:04:39< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/183025202
20161211 16:04:39-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 16:06:11-!- gimemor [~gimemor@host-95-152-57-4.dsl.sura.ru] has quit [Ping timeout: 246 seconds]
20161211 16:06:16< celmin|sleep> vultraz, JyrkiVesterinen: The key to gfgtdf's commit is that simply calculating the team_data iterates over all units. Presumably the problem is that the team data was being calculated for cases where it wasn't needed, namely if you try to fetch __cfg or if you want to use the matches method. Each of those macros creates an if-conditional, so with the change, d is only called if m is equal to one of those strings.
20161211 16:07:11< celmin|sleep> Thus it's not called five times, and may not be called at all if m doesn't match.
20161211 16:11:34< irker099> wesnoth: Charles Dang wesnoth:master d5f172b942a4 / src/gui/dialogs/title_screen.cpp: Title Screen: fixed crash if game_config::game_title or game_title_background wa https://github.com/wesnoth/wesnoth/commit/d5f172b942a45e0918e7c72f1f8084dd2b97243e
20161211 16:12:28< vultraz> celmin|sleep: I don't know if it constitutes an additional bug that an unset canvas variable causes a crash.
20161211 16:12:37< JyrkiVesterinen> Ah. Return_int_attrib is a macro, and it runs the accessor code only if the name matches.
20161211 16:12:57< celmin|sleep> mattsc: What about that type mismatch warning?
20161211 16:13:03< JyrkiVesterinen> Macros are evil. They can make the code look completely different than what it actually does. :S
20161211 16:13:06< celmin|sleep> I assume you're referring to a printf format warning?
20161211 16:14:21< celmin|sleep> It's an int though. I was pretty sure %d was for int...
20161211 16:15:08-!- celmin|sleep is now known as celticminstrel
20161211 16:17:03< mattsc> celticminstrel: game_lua_kernel.cpp:2861:26: error: comparison of integers of different signs: 'int' and 'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
20161211 16:17:50< celticminstrel> Ohhh, you're talking about the conditional, not the error call.
20161211 16:17:55< celticminstrel> Okay, that maeks more sense.
20161211 16:17:57< celticminstrel> ^makes
20161211 16:19:23< celticminstrel> Argh, now I have to reboot because the windows computer no longer recognizes my mouse. ><
20161211 16:23:16< celticminstrel> ...Notepad++ lost all my open documents. :(
20161211 16:26:43< zookeeper> how did that happen?
20161211 16:27:11< celticminstrel> Not sure, but I suspect it might be that it saves the session on every exit, even if -nosession was passed.
20161211 16:27:40< celticminstrel> I think there wasn't anything super-important there that I can't recover, at least.
20161211 16:27:41< zookeeper> and/or what version is it? at least after i updated to 6.9.1 it seemed to be improved so i didn't lose the open docs list if it crashed or was killed, etc
20161211 16:28:01< celticminstrel> I updated recently, so it's probably the latest version.
20161211 16:28:09< zookeeper> oww
20161211 16:28:22 * zookeeper takes note to _not_ update
20161211 16:28:25< celticminstrel> I use it with -nosession as my git commit hook, so I suspect that's related.
20161211 16:30:55< celticminstrel> Something weird happened with MSVC too, I can't find the files list.
20161211 16:31:08< celticminstrel> Oh, there it is.
20161211 16:33:37< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting e803366f6912 / data/lua/wml-tags.lua: fixup! Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/e803366f69125ab1c277cae7bf87ca949c17e6e9
20161211 16:33:39< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5d353397be97 / src/scripting/game_lua_kernel.cpp: fixup! Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/5d353397be9784ad1c5b64785ef7fb382079ce62
20161211 16:39:10< celticminstrel> vultraz: I'd say it was a bug that the variable was only set if it was non-empty.
20161211 16:42:04-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 16:42:04< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper f16550f: DM: Fixed very unlikely case of possible breakage Succeeded
20161211 16:42:04< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-34
20161211 16:42:08-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 16:53:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 16:54:07-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 16:54:08< travis-ci> gfgtdf/wesnoth#728 (master - e31596d : gfgtdf): The build failed.
20161211 16:54:08< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/183035758
20161211 16:54:08-!- travis-ci [~travis-ci@ec2-54-198-0-231.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 17:06:45-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 17:06:45< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper f16550f: DM: Fixed very unlikely case of possible breakage Succeeded
20161211 17:06:45< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-34
20161211 17:06:49-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 17:07:25-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 17:07:26< travis-ci> wesnoth/wesnoth#12389 (master - d5f172b : Charles Dang): The build has errored.
20161211 17:07:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183035435
20161211 17:07:26-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 17:14:01< vultraz> god dammit
20161211 17:14:10< vultraz> that one build keeps erroring
20161211 17:21:43< vultraz> No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
20161211 17:21:44< vultraz> Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
20161211 17:21:48< celticminstrel> bumba: https://forums.wesnoth.org/viewtopic.php?f=21&t=44897
20161211 17:21:49< vultraz> >_>
20161211 17:21:53< celticminstrel> Whoops, sorry.
20161211 17:21:56< celticminstrel> That should've been vultraz 
20161211 17:22:15< celticminstrel> I have no idea who bumba even is.
20161211 17:22:34< vultraz> magenta is hardcoded in some places
20161211 17:22:54< celticminstrel> I'm linking you to that because I suspect this is, in fact, a bug in the new MP Staging.
20161211 17:24:03-!- mjs-de [~mjs-de@x4e312cc1.dyn.telefonica.de] has quit [Remote host closed the connection]
20161211 17:29:03< vultraz> item["label"] = "units/unknown-unit.png~RC(magenta>" + std::to_string(side->color() + 1) + ")";
20161211 17:29:09< vultraz> hmm
20161211 17:29:10< vultraz> not this
20161211 17:29:23< vultraz> new_image = formatter() << type.image() << "~RC(magenta>" << side->color_id() << ")";
20161211 17:29:51< celticminstrel> I assume it would be something about selecting a faction.
20161211 17:29:55< vultraz> problem is we don't have a unit here
20161211 17:32:08< celticminstrel> Huh?
20161211 17:32:08< vultraz> and flag_rgb is a unit key
20161211 17:32:17< celticminstrel> No, the point was that it's also a faction key.
20161211 17:32:18< vultraz> this is a type image
20161211 17:32:49< celticminstrel> Which indicates the source palette for recolouring the faction icon.
20161211 17:32:51< celticminstrel> I think.
20161211 17:33:00< celticminstrel> Usually the faction icon is a unit image, but it doesn't have to be.
20161211 17:33:58< zookeeper> just look at the file and it's obvious
20161211 17:34:09< zookeeper> [multiplayer_side]
20161211 17:34:09< zookeeper>     id=Northerners
20161211 17:34:09< zookeeper>     name= _"Northerners"
20161211 17:34:09< zookeeper>     image="units/orcs/warrior.png"
20161211 17:34:09< zookeeper>     {MAGENTA_IS_THE_TEAM_COLOR}
20161211 17:34:13< zookeeper> this isn't rocket science
20161211 17:35:50-!- bumba is now known as bumbadadabum
20161211 17:38:36-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 17:38:36< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang d5f172b: Title Screen: fixed crash if game_config::game_title or game_title_background was empty (bug #22028) Succeeded
20161211 17:38:36< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-35
20161211 17:38:40-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 17:45:15-!- Kwandulin [~Miranda@p200300760F6EBFB1B0D7202DF4EEBA9B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161211 17:50:19-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 17:50:20< travis-ci> wesnoth/wesnoth#12390 (wml_tag_porting - 5d35339 : Celtic Minstrel): The build has errored.
20161211 17:50:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183038570
20161211 17:50:20-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 17:50:30< celticminstrel> Faction select dialog might also be relevant maybe?
20161211 17:54:04< celticminstrel> So what was that about [for] and step again.
20161211 17:55:14< celticminstrel> zookeeper: ?
20161211 17:55:24< zookeeper> exactly what i said
20161211 17:55:40< celticminstrel> Doesn't work if you don't specify step?
20161211 17:57:43< zookeeper> at least warning
20161211 17:58:19< celticminstrel> Warning?
20161211 18:00:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 18:00:48-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 18:02:43< irker099> wesnoth: gfgtdf wesnoth:master 5a1393705415 / src/scripting/game_lua_kernel.cpp: hide wesnoth.fire_wml_menu_item for normal scenarios https://github.com/wesnoth/wesnoth/commit/5a1393705415b277ad370961f75d3d7e3be169c4
20161211 18:03:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161211 18:03:05< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang d5f172b: Title Screen: fixed crash if game_config::game_title or game_title_background was empty (bug #22028) Succeeded
20161211 18:03:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-35
20161211 18:03:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161211 18:03:35< celticminstrel> That seems slightly questionable, but whatever.
20161211 18:05:01-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 18:06:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:07:47< celticminstrel> Why are append, immediate, and shuffle attributes of a music track. :|
20161211 18:09:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 18:10:03< vultraz> because we have an "amazing" music management API :P
20161211 18:10:50< celticminstrel> Why is the track title reader disabled on Windows and MacOSX.
20161211 18:11:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:12:12< celticminstrel> Surely the only thing needed for it to work would be to actually have the vorbis headers?
20161211 18:12:32 * celticminstrel doesn't have them, so won't enable it right now.
20161211 18:12:55< celticminstrel> (Or maybe I have them only in VC12/include and not in external/include.)
20161211 18:13:04< celticminstrel> (Will check later I guess.)
20161211 18:13:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 18:14:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:14:45-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 18:14:46< travis-ci> gfgtdf/wesnoth#729 (master - 4091a16 : gfgtdf): The build was fixed.
20161211 18:14:46< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/183045284
20161211 18:14:46-!- travis-ci [~travis-ci@ec2-54-211-29-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 18:18:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 18:19:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:21:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 18:22:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:24:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Remote host closed the connection]
20161211 18:24:51-!- mjs-de [~mjs-de@x4e312cc1.dyn.telefonica.de] has joined #wesnoth-dev
20161211 18:28:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has joined #wesnoth-dev
20161211 18:33:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bd91:a0bf:4ca5:9ca5] has quit [Ping timeout: 258 seconds]
20161211 18:34:38-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 18:36:16-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 18:40:10< zookeeper> celticminstrel, i was busy defending objective and barely had any time to say anything between my supremely rare respawns, so...
20161211 18:40:19< zookeeper> i don't remember what the warning was, something about nil :p
20161211 18:40:37< zookeeper> anyway, as said it requires step= while naturally it shouldn't
20161211 18:50:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 18:51:50< celticminstrel> Okay, so in [scenario][music] I assume you need append=yes (except maybe in the first tag) or else it won't give the correct result.
20161211 18:52:03< celticminstrel> This seems pointless.
20161211 18:54:10< zookeeper> why would it be pointless? because you always want the first track to start playing and then all others to be appended to the playlist?
20161211 18:54:45< celticminstrel> I feel like I'm missing some subtlety here.
20161211 18:55:06< celticminstrel> I said it seems pointless because presumably if you have several music tags you want all of them to be on the playlist.
20161211 18:55:33< celticminstrel> But omitting append=yes would cause the playlist to consist of just the last track.
20161211 18:55:59< celticminstrel> I also assume omitting append=yes on the first one makes no difference because the playlist starts out empty.
20161211 18:56:49< zookeeper> you seem to be thinking that [scenario][music] is somehow common
20161211 18:56:57< celticminstrel> Eh?
20161211 18:57:07< zookeeper> whereas music is almost always specified in an event, AFAICT
20161211 18:58:16< celticminstrel> Hm, only direct use is UtBS12...
20161211 18:59:29< celticminstrel> {DEFAULT_MUSIC_PLAYLIST} isn't even used often. o.o
20161211 18:59:49< celticminstrel> In campaigns at least. Looks like it's in all the MP scenarios (or nearly all).
20161211 19:00:37< zookeeper> another thing that SotA would need to have tweaked, it seems. it seems to use nothing but DEFAULT_MUSIC_PLAYLIST.
20161211 19:00:49< zookeeper> sadly it's made its way to two EI scenarios too
20161211 19:01:06< celticminstrel> Is there something wrong with DEFAULT_MUSIC_PLAYLIST?
20161211 19:01:54< zookeeper> yes? it includes all tracks?
20161211 19:06:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 19:10:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 19:13:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 19:13:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 19:15:00< pydsigner> The problem with the default playlist is that it doesn't reflect scenario moods at all
20161211 19:17:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 19:17:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 19:42:38< irker099> wesnoth: ln-zookeeper wesnoth:master 37d88d08af4a / data/campaigns/Eastern_Invasion/scenarios/ (10_Lake_Vrug.cfg 15_The_Council.cfg): EI: Added custom music to scenarios still using DEFAULT_MUSIC_PLAYLIST https://github.com/wesnoth/wesnoth/commit/37d88d08af4abb52286bdc1403c506fcf8adeeae
20161211 19:47:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 19:48:07-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 19:48:08< travis-ci> wesnoth/wesnoth#12393 (master - 5a13937 : gfgtdf): The build passed.
20161211 19:48:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183052578
20161211 19:48:08-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 19:48:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 19:48:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 19:49:27-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 19:49:57< vultraz> god dammit
20161211 19:50:59< vultraz> this thing is worse than I thought
20161211 19:54:11< vultraz> hmmm
20161211 19:54:13< vultraz> well
20161211 19:54:26< vultraz> ok, I might be able to fix this for faction select
20161211 19:54:29< vultraz> but not staging
20161211 19:54:31< vultraz> or anything else
20161211 19:56:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 19:58:34< vultraz> who;s bright idea was to add that key anyway
20161211 19:59:21< zookeeper> flag_rgb to [multiplayer_side]?
20161211 19:59:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 19:59:53< vultraz> yes
20161211 20:00:00< zookeeper> well, duh, how else would you have done it in 2006 or whenever it might have been added.
20161211 20:00:08< zookeeper> by making it work by magic? :p
20161211 20:00:20< vultraz> ~RC
20161211 20:01:32< vultraz> anyway
20161211 20:01:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 20:01:40< vultraz> there's no easy way to fix this
20161211 20:03:23< vultraz> I mean, when would you even need anything other than magenta
20161211 20:03:29< vultraz> for a faction image
20161211 20:03:59< vultraz> well, I suppose if you don;t have a unit image
20161211 20:04:15< vultraz> oh
20161211 20:04:17< vultraz> wait
20161211 20:04:22< vultraz> mp staging is the display of the LEADER
20161211 20:04:33< vultraz> hmmmm
20161211 20:05:05< vultraz> right
20161211 20:05:07< vultraz> right
20161211 20:05:09< vultraz> ok
20161211 20:05:22< vultraz> zookeeper: does this only affect the *faction* icon?
20161211 20:05:44< zookeeper> that's the only way which makes any sense, so i presume so
20161211 20:05:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 20:08:02< irker099> wesnoth: Charles Dang wesnoth:master e11c9eccb308 / src/gui/dialogs/multiplayer/faction_select.cpp: Faction Select: attempt to make [multiplayer_side] flag_rgb= work again https://github.com/wesnoth/wesnoth/commit/e11c9eccb3082518bced750c20f58f3dbf5386e1
20161211 20:08:03< vultraz> ^
20161211 20:08:05< vultraz> untested
20161211 20:08:38< vultraz> actually that might break default handling!
20161211 20:08:39< vultraz> hm
20161211 20:08:56< vultraz> yes
20161211 20:09:03< vultraz> I forgot it's not preparesed
20161211 20:09:06< vultraz> it's a raw config
20161211 20:09:50 * vultraz had no sleep
20161211 20:10:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Ping timeout: 240 seconds]
20161211 20:11:00< irker099> wesnoth: Charles Dang wesnoth:master 47f2df878ea9 / src/gui/dialogs/multiplayer/faction_select.cpp: Fixup e11c9eccb308 https://github.com/wesnoth/wesnoth/commit/47f2df878ea9cb4835faec7dfcf993713db45e10
20161211 20:11:11< vultraz> zookeeper: do test again when you can
20161211 20:13:53< celticminstrel> Does play_once and immediate have any effect in [scenario][music[ or are these really only for event-initiated music?
20161211 20:14:13< vultraz> probably the latter
20161211 20:14:23< vultraz> though wait
20161211 20:14:39< zookeeper> vultraz, seems to work
20161211 20:14:47< vultraz> wait
20161211 20:14:49< vultraz> nvm
20161211 20:14:50< vultraz> ok
20161211 20:14:53< vultraz> idk
20161211 20:14:55< vultraz> zookeeper: good
20161211 20:15:07< vultraz> yeah it's event only i think
20161211 20:15:32< celticminstrel> Well technically it's currently supported in [scenario][music] though.
20161211 20:15:46< celticminstrel> But I don't think it would really have an effect.
20161211 20:15:57< celticminstrel> Maybe I'm wrong.
20161211 20:16:17< celticminstrel> I could imagine it being a way to force the scenario to start with a specific track and then move onto the playlist...
20161211 20:16:34< vultraz> one uses [story][part]music=
20161211 20:16:36< vultraz> for that :P
20161211 20:17:12< vultraz> and then one can do this: https://github.com/Vultraz/Shadows_of_Deception/blob/master/macros/soundfx.cfg#L3-L9
20161211 20:17:14< vultraz> which works
20161211 20:17:16< vultraz> somehow
20161211 20:18:55< celticminstrel> That doesn't make any sense whatsoever.
20161211 20:19:11< vultraz> shurg
20161211 20:19:23< celticminstrel> Link to a use?
20161211 20:20:01< vultraz> https://github.com/Vultraz/Shadows_of_Deception/blob/master/episode1/scenarios/03_Gathering_Storm.cfg#L18
20161211 20:20:08< vultraz> i copied said macro from shadowm
20161211 20:21:49< zookeeper> looks the same as the core LET_INTRO_MUSIC_FINISH
20161211 20:22:41< celticminstrel> That idiom in the commit you just pushed has been vaguely annoying me for awhile now.
20161211 20:22:54< vultraz> who added such a thing!
20161211 20:22:55< vultraz> celticminstrel: ?
20161211 20:23:14< zookeeper> anyway, it seems that currently you can't have music carry on from one scenario to the next (endlevel interrupts it, for one), but ideally that should be possible, so at least [scenario][music]immediate=no is perfectly sensical to me in principle even if it doesn't currently work.
20161211 20:23:30< celticminstrel> The cfg["xyz"].blank() ? "default" : cfg["xyz"] idiom (for strings)
20161211 20:23:38< celticminstrel> Sometimes with empty() instead of blank()
20161211 20:23:44< vultraz> what's wrong with it?
20161211 20:24:04< celticminstrel> It's so long. Why can't we just do cfg["xyz"].str("default").
20161211 20:24:19< celticminstrel> That works for integers. Why not for strings.
20161211 20:24:19< vultraz> ...oh mah gawd
20161211 20:24:24< vultraz> is that a thing
20161211 20:24:31< celticminstrel> I just implemented it.
20161211 20:24:51< vultraz> it is not :(
20161211 20:24:58< vultraz> commit this immediately!
20161211 20:32:07< irker099> wesnoth: Celtic Minstrel wesnoth:master 41884fca586d / src/ (config.cpp config.hpp): Add optional default value argument to config::str() https://github.com/wesnoth/wesnoth/commit/41884fca586d5839d780a90469798a53c328a9b3
20161211 20:38:55< celticminstrel> vultraz: There you go. Didn't actually make anything use it though.
20161211 20:39:45< celticminstrel> Equivalent to the .blank() ? ... form. Slightly different from the .empty() ? ... form.
20161211 20:40:04-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 20:40:05< travis-ci> wesnoth/wesnoth#12394 (master - 37d88d0 : ln-zookeeper): The build has errored.
20161211 20:40:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183068071
20161211 20:40:05-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 20:40:55< vultraz> we usually want empty
20161211 20:41:30< celticminstrel> I suspect the difference between then usually doesn't matter too much.
20161211 20:41:34< celticminstrel> ^them
20161211 20:41:51< celticminstrel> They give different results iff the user specifies the key with no value.
20161211 20:42:23< celticminstrel> Generally the point of these tests is to provide a default if the key is omitted altogether.
20161211 20:44:10-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161211 20:45:05< vultraz> actually the general usecase proably should use blank
20161211 20:45:11< vultraz> now that i think of it
20161211 20:45:16< celticminstrel> Mind you, if you really want it to be equivalent to the .empty() form, then you could alter the string visitor to test if the string is empty.
20161211 20:45:26< celticminstrel> But I think generally .blank() is, indeed, the better option.
20161211 20:47:31< mattsc> celticminstrel: it looks like you did not fix this line?  https://github.com/wesnoth/wesnoth/blob/e803366f69125ab1c277cae7bf87ca949c17e6e9/data/lua/wml-tags.lua#L776
20161211 20:48:24< celticminstrel> Oh right.
20161211 20:48:58< mattsc> Also, just looking at it again, shouldn’t that id:match also include an underscore?
20161211 20:50:31< celticminstrel> Uhhh, not sure. What does that match again...
20161211 20:50:51< mattsc> The id of the component.  Which can include underscore.
20161211 20:50:57< mattsc> underscores
20161211 20:51:19< mattsc> oh, no, it’s when it is a numerical value, never mind.
20161211 20:51:29< celticminstrel> Oh, yeah, so it is.
20161211 20:51:41-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161211 20:54:07< celticminstrel> Why have I been using ~ as if it were equivalent to not, anyway...
20161211 20:56:13-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161211 20:56:37< irker099> wesnoth: gfgtdf wesnoth:master 3cc386d0cd20 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/19_The_Vanguard.cfg: TRoW: simplify wml by using [remove_object] https://github.com/wesnoth/wesnoth/commit/3cc386d0cd20ef3265a2b0d4358d33e435cafd24
20161211 20:57:54< celticminstrel> Why do I feel like something is off about that commit...
20161211 20:58:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161211 21:00:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 21:00:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 21:00:53< celticminstrel> Ah. Because I totally forgot how the [remove_object] tag actually works.
20161211 21:02:40-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Remote host closed the connection]
20161211 21:02:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 21:05:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 21:05:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 21:10:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Ping timeout: 240 seconds]
20161211 21:12:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 21:12:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 21:14:51-!- JyrkiVesterinen [~JyrkiVest@87-92-28-81.bb.dnainternet.fi] has quit [Quit: .]
20161211 21:22:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has joined #wesnoth-dev
20161211 21:47:27< zookeeper> celticminstrel, so was there still something unclear about the step= issue..?
20161211 21:48:27< celticminstrel> Something about nil is what I remember from before.
20161211 21:48:37< celticminstrel> Hmm, actually I can see a problem in the current code.
20161211 21:58:35-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161211 22:00:27-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 22:00:28< travis-ci> wesnoth/wesnoth#12396 (master - 47f2df8 : Charles Dang): The build has errored.
20161211 22:00:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183072603
20161211 22:00:28-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 22:03:57< vultraz> good god
20161211 22:04:00< vultraz> ALWAYS ONE BUILD
20161211 22:04:24< vultraz> 20161211 21:30:05 error display: Could not initialize SDL_video: Failed to connect to the Mir Server
20161211 22:04:25< vultraz> test gave error code 200 (segfault).. trying again.
20161211 22:04:27< vultraz> the hell
20161211 22:04:44< vultraz> ok, then it spits out the Cannot Place Grid crap :/
20161211 22:07:04< zookeeper> mir server, what the heck is that anyway...
20161211 22:07:19< zookeeper> ah
20161211 22:08:10< vultraz> also you should use [ci skip] in your WML commits
20161211 22:08:16< vultraz> messages
20161211 22:08:21< vultraz> to avoid travis building them
20161211 22:09:06-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161211 22:11:04< zookeeper> right
20161211 22:11:20< zookeeper> couldn't it be smart and only build if the commit touches src/ or similar?
20161211 22:11:36< vultraz> would be nice
20161211 22:11:45< celticminstrel> Well, just src isn't enough.
20161211 22:11:52-!- mjs-de [~mjs-de@x4e312cc1.dyn.telefonica.de] has quit [Remote host closed the connection]
20161211 22:12:10< celticminstrel> For data/lua changes a rebuild makes sense too (because of WML tests).
20161211 22:12:32< celticminstrel> I don't know if it's possible, but it's not as easy as it sounds to decide whether a given commit needs to trigger a rebuild.
20161211 22:14:41< zookeeper> i'm still under the impression that the builds just randomly fail all the time because it takes too long or something.
20161211 22:16:30< mattsc> celticminstrel: I believe I am done testing [modify_ai].  It’s pretty much impossible to test every possible combination, but I think I’ve been pretty thorough.  I’ve tested CAs, goals, aspects of different types; add, delete and change; with string, number or * for id; I’ve used it with the side filter matching one or several sides, …
20161211 22:16:47< mattsc> So unless you can think of something else, [modify_ai] is good, as far as I can tell
20161211 22:16:48< celticminstrel> mattsc: Thanks!
20161211 22:17:08< celticminstrel> mattsc: What about [modify_side]switch_ai and [modify_side][ai]? Were you going to test those too?
20161211 22:17:16< mattsc> I’ll try switch_ai and [modify_side][ai] later
20161211 22:17:20< celticminstrel> Okay.
20161211 22:17:24< celticminstrel> There's no hurry.
20161211 22:17:33< gfgtdf> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L596
20161211 22:17:38< celticminstrel> BTW I've changed all the ~ to not locally.
20161211 22:17:51< mattsc> I’d like to get it done so that I can go back to hitting my head against a wall with Fred …  :P
20161211 22:18:00< celticminstrel> gfgtdf: What about it?
20161211 22:18:28< gfgtdf> i strongly doubt that !std::equal(name.rbegin(), name.rbegin() + 4, "gfc.") is so much faster than !std::equal(name.end() - 4, name.end(), ".cfg") to be worth it
20161211 22:18:51< celticminstrel> Well, strings have random-access iterators, so you're probably right.
20161211 22:19:28< celticminstrel> Why is a preprocessor_file allocated on the heap and then discarded?
20161211 22:21:24< gfgtdf> celticminstrel: thats the black magic the preprocessor.cpp code is build on.
20161211 22:30:53< Shiki> sometime I think you are going to rewrite everything
20161211 22:32:07< vultraz> black magic?
20161211 22:32:09< vultraz> how black
20161211 22:33:02< gfgtdf> vultraz: he asked abotu this line https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L598
20161211 22:33:08< celticminstrel> You can't get any blacker than black.
20161211 22:33:29< vultraz> celticminstrel: vantablack
20161211 22:33:31< celticminstrel> I'm assuming the constructor adds itself to a list somewhere so that they're properly freed.
20161211 22:33:40 * celticminstrel has no idea what vultraz just said.
20161211 22:33:55< vultraz> https://en.wikipedia.org/wiki/Vantablack
20161211 22:34:22< gfgtdf> celticminstrel: yes but still this is surley not clean code.
20161211 22:34:43< celticminstrel> Agreed.
20161211 22:35:07< celticminstrel> I'd rather see a placement new syntax for something like that.
20161211 22:39:44-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 22:39:45< travis-ci> wesnoth/wesnoth#12397 (master - 41884fc : Celtic Minstrel): The build has errored.
20161211 22:39:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183076181
20161211 22:39:45-!- travis-ci [~travis-ci@ec2-54-221-157-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 22:43:26< mattsc> celticminstrel: [modify_side][ai] seems to work just fine.
20161211 22:43:28< mattsc> I tested it with [goal]s too, and that works as well, as you said.
20161211 22:43:35< mattsc> [modify_side]switch_ai= works also, but has the same 'side number offset by 1' problem that [modify_ai] had yesterday.
20161211 22:43:42< celticminstrel> Okay.
20161211 22:44:16< mattsc> So, I think other than the ~component typo and changing that last side number issue, this is good to go (for these tags, at least)
20161211 22:45:59< celticminstrel> Yay!
20161211 22:46:31< celticminstrel> Still needs more testing on the other stuff, but I can probably do that myself... or maybe get wedge009 or someone else to help out.
20161211 22:46:51< celticminstrel> [animate_unit] hasn't been tested at all yet... I think the others have been tested a little.
20161211 22:46:59< celticminstrel> Can't remember though.
20161211 22:47:12< mattsc> Okay, sounds good.
20161211 22:48:40< mattsc> Btw, I did all of this with moveto event triggered by different units in my test scenario.  I find that a convenient way of trying different combinations of adding/changing/removing without having to start or f5 all the time.
20161211 22:48:52< mattsc> The events also automatically bring up the inspector at the end.
20161211 22:57:24< celticminstrel> Trying to decide on a good Lua API for music.
20161211 22:57:48< celticminstrel> As in, manipulating the game's playlist.
20161211 22:58:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:1dd3:dcf6:1111:6e0a] has quit [Remote host closed the connection]
20161211 23:01:00< celticminstrel> Might skip it and move onto the next tag.
20161211 23:01:19< zookeeper> celticminstrel, so are you going to fix the step= issue?
20161211 23:01:29< celticminstrel> Oh right.
20161211 23:01:40< celticminstrel> Yes, I'll fix that next, sure.
20161211 23:01:44< zookeeper> okay, great
20161211 23:02:17< celticminstrel> Well, I can't test it though, because my build still won't run for some reason, but there's definitely a problem visible in the code, so I'll fix that and hope it's enough.
20161211 23:02:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 23:05:25-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20161211 23:07:02< irker099> wesnoth: Celtic Minstrel wesnoth:master 5fdb73b92f9b / data/lua/wml-flow.lua: Fix an error in [for] if step not specified https://github.com/wesnoth/wesnoth/commit/5fdb73b92f9b5fe7ff9a629c27f49289694469c8
20161211 23:07:32< vultraz> I need to figure out how to fix this damn "labels cause window overflow" stuff
20161211 23:07:47< vultraz> and the UPP size stuff
20161211 23:07:57< vultraz> would be a lot easier if default_width/height worked
20161211 23:08:01< vultraz> and min_width/height
20161211 23:08:08< vultraz> maybe I can get jyrki to work on that
20161211 23:08:17< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting e0d07e854ecd / / (8 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/e0d07e854ecd4a731aebcf72c7af2fe5f5f48034
20161211 23:08:19< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 37368c3654e6 / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/37368c3654e68d9efc83d9caa8c4f2da77f3df18
20161211 23:08:21< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting bf9581cce4a7 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/bf9581cce4a7fa7a9ddac7e65802887abd940530
20161211 23:08:23< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c58e2d00957d / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/c58e2d00957d79889951de04416a8b3b3ccf7609
20161211 23:08:25< irker099> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 010acd870d31 / / (7 files in 5 dirs): Properly port [animate_unit] to Lua https://github.com/wesnoth/wesnoth/commit/010acd870d316de9e89e984a236d809d638965ec
20161211 23:10:38< celticminstrel> Heh, so my switch_ai and append_ai functions actually did disagree on whether the side number was 0-indexed or 1-indexed.
20161211 23:10:58< celticminstrel> Which is why [modify_side][ai] worked correctly and [modify_ai]switch_ai did not.
20161211 23:11:22< celticminstrel> BTW vultraz, any better name for a function that sets a side's flag style and colour?
20161211 23:11:33< celticminstrel> I was sorta half-seriously thinking "set_side_heraldry". :P
20161211 23:11:39< mattsc> celticminstrel: okay, glad you found the reason; is there anything else you want me to do on this?
20161211 23:11:48< vultraz> what's wrong with set_side_flag
20161211 23:12:14< celticminstrel> vultraz: Well, the colour is more than just the colour of the flag, it's the overall colour of the team.
20161211 23:12:38< vultraz> hm
20161211 23:12:59< celticminstrel> mattsc: I don't think there's anything else I needed from you for this PR.
20161211 23:13:19 * celticminstrel also considered "set_side_visual_id"
20161211 23:14:07< mattsc> celticminstrel: okay, good
20161211 23:15:00< celticminstrel> Maybe I could put a testing TODO list in the PR description.
20161211 23:15:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 23:15:17< mattsc> vultraz: BTW, the Micro AI + shroud fix was the only thing on my must-do list for 1.13.7.
20161211 23:15:19< vultraz> no, not that
20161211 23:15:27< vultraz> mattsc: sweet
20161211 23:15:36< celticminstrel> I'm assuming you mean "not set_side_visual_id".
20161211 23:15:57< vultraz> yes
20161211 23:16:00< zookeeper> celticminstrel, why would you make a function for changing a side's flag and colour..? can't you change them, and all other attributes too, through wesnoth.sides or something?
20161211 23:16:09< celticminstrel> I could do that.
20161211 23:16:17< celticminstrel> The reason I made a separate function was...
20161211 23:16:22< celticminstrel> Something about screen updates...
20161211 23:16:55< celticminstrel> Oh right, changes to either of the two necessitate calling a function to reinitialize the flag definitions for the side.
20161211 23:17:01< celticminstrel> ^necessitates
20161211 23:17:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161211 23:17:15< celticminstrel> https://github.com/wesnoth/wesnoth/commit/e0d07e854ecd4a731aebcf72c7af2fe5f5f48034#diff-cbc1ee771a060a08f4e069e6049ce7acR2819
20161211 23:17:43< vultraz> ...why
20161211 23:17:57< celticminstrel> But I suppose I could just put it in the side proxy instead, and accept the slight redundancy in the event of changing both at the same time.
20161211 23:18:02< zookeeper> ...so through what logic does that become a reason? i'm not following
20161211 23:18:13< celticminstrel> See my previous comment.
20161211 23:18:35< celticminstrel> I'm not actually sure if the redundancy is significant. I forget what that function actually does.
20161211 23:19:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161211 23:19:48< celticminstrel> Looks like it potentially loads images from disk.
20161211 23:20:14< celticminstrel> I say potentially because the image cache is a thing, so I assume if it wouldn't reload them if you changed the colour but kept the same flag style.
20161211 23:20:59< celticminstrel> Implementation is in display.cpp:284
20161211 23:21:16< zookeeper> well you make it sound like you're doing something without really knowing why you're doing it
20161211 23:21:42< celticminstrel> If anything I'm just preserving an optimization that was in the original code.
20161211 23:21:51< irker099> wesnoth: Charles Dang wesnoth:master cf412fc16831 / src/game_initialization/flg_manager.cpp: FLG Manager: sort faction choices alphabetically (FR #21458) https://github.com/wesnoth/wesnoth/commit/cf412fc168314e6fae4fc8cb8fb8cbe563cdadc9
20161211 23:23:40-!- travis-ci [~travis-ci@ec2-54-147-241-75.compute-1.amazonaws.com] has joined #wesnoth-dev
20161211 23:23:41< travis-ci> wesnoth/wesnoth#12398 (master - 3cc386d : gfgtdf): The build passed.
20161211 23:23:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/183080343
20161211 23:23:41-!- travis-ci [~travis-ci@ec2-54-147-241-75.compute-1.amazonaws.com] has left #wesnoth-dev []
20161211 23:23:45< vultraz> :O
20161211 23:26:01-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161211 23:27:53-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20161211 23:29:28< gfgtdf> vultraz: i think that sort commit migth break some things, for example some eras like ageless have multiple "random" factions (random, random no default,  ...)
20161211 23:30:30< celticminstrel> vultraz: I suggest doing something similar to campaigns and adding an optional "rank" for the faction choices - first sort alphabetically, then stable_sort by rank.
20161211 23:30:51< celticminstrel> Maybe "rank" isn't a good key name, but hopefully you get the general idea.
20161211 23:42:11< zookeeper> awesome, we can (i think) have perfect connections between different castle types (as long as the tiles are at least somewhat compatible, as is the case with most castles). no more annoying encampment walls as connectors.
20161211 23:42:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161211 23:48:53< Aginor> I hope nobody has a netgear router at home: https://www.kb.cert.org/vuls/id/582384
20161211 23:51:21< zookeeper> nice
20161211 23:52:06< zookeeper> castles <3 https://dl.dropboxusercontent.com/u/63964618/wesnoth/castleconnections.png of course there's still small glitches with mismatching shadows, but that can't be helped.
20161211 23:56:30< vultraz> :O
20161211 23:56:37< vultraz> COMMIT IMMEDIATELY!
20161211 23:57:15< zookeeper> no!
20161211 23:57:19 * celticminstrel gives vultraz an extra helping of patience.
20161211 23:58:18< zookeeper> funnily enough, i think all that requires is two [terrain_graphics] tags
20161211 23:58:38< zookeeper> some macro API changes too of course, but still
20161211 23:59:15< zookeeper> i had been pinballing that idea in my head for quite a while, and it was surprisingly easy to do
--- Log closed Mon Dec 12 00:00:05 2016