--- Log opened Sat Dec 17 00:00:47 2016
20161217 00:00:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6967:2f09:8430:905c] has quit [Ping timeout: 258 seconds]
20161217 00:05:23< celticminstrel> Yet another [for] issue... :|
20161217 00:06:29< celticminstrel> Ohh.
20161217 00:13:29< celticminstrel> Not strictly speaking an issue.
20161217 00:29:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 00:29:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 00:32:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 00:33:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 00:36:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 00:37:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 00:40:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 00:41:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 00:42:33-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 00:42:33< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel 4d7b229: Refactor std::put_time detection Succeeded
20161217 00:42:33< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-50
20161217 00:42:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 00:53:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20161217 00:53:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6967:2f09:8430:905c] has joined #wesnoth-dev
20161217 01:03:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161217 01:03:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161217 01:06:51-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 01:06:51< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel 4d7b229: Refactor std::put_time detection Succeeded
20161217 01:06:51< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-50
20161217 01:06:55-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 01:14:10-!- irker677 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161217 01:18:58-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has quit [Quit: leaving]
20161217 01:27:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6967:2f09:8430:905c] has quit [Remote host closed the connection]
20161217 01:27:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6967:2f09:8430:905c] has joined #wesnoth-dev
20161217 01:30:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 01:31:09-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20161217 01:32:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6967:2f09:8430:905c] has quit [Ping timeout: 245 seconds]
20161217 01:39:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 01:39:47< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Celtic Minstrel 4d7b229: Refactor std::put_time detection Succeeded
20161217 01:39:47< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-51
20161217 01:39:50-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 01:43:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 01:45:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 01:51:56< celticminstrel> Looks like it didn't announce, but Travis is finally passing.
20161217 01:59:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 02:03:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Ping timeout: 240 seconds]
20161217 02:03:49-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 02:03:49< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Celtic Minstrel 4d7b229: Refactor std::put_time detection Succeeded
20161217 02:03:49< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-51
20161217 02:03:53-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 02:21:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 02:22:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 02:25:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 02:25:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 02:26:48< vultraz> [08:14:39]	zookeeper	we already have this little vultraz-jet-lordbob bubble where you clearly talk and plan amongst yourselves in isolation out there somewhere about wesnoth development, but no one knows to what degree, and it's awkward because it means potential input from other developers enters the picture much later.
20161217 02:26:59< vultraz> for the record, that "bubble" was on Discord 
20161217 02:27:02-!- louis94 [~~louis94@91.178.242.165] has quit [Ping timeout: 256 seconds]
20161217 02:27:40< celticminstrel> So?
20161217 02:27:47< vultraz> the wesnoth inc discussions are on Discord, albeit private.
20161217 02:28:07< celticminstrel> So?
20161217 02:28:15< vultraz> so i decided we might as well open up other channels on the server and see how people respond.
20161217 02:28:22< celticminstrel> Wesnoth Inc is not development.
20161217 02:28:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 02:28:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 02:29:07< celticminstrel> Well you're welcome to open up other channels.
20161217 02:29:18< celticminstrel> But that's hardly a reason to suggest switching. :P
20161217 02:29:46< vultraz> I'm not forcing anything.
20161217 02:29:51< celticminstrel> Oh, good.
20161217 02:29:59< celticminstrel> I guess we'll stay in IRC then. ;)
20161217 02:30:14< vultraz> Frogatto seems to have organically migrated away from IRC primary.
20161217 02:30:21< vultraz> If we do the same, no downside.
20161217 02:30:24< vultraz> If we don't, no downside.
20161217 02:31:25< vultraz> "it's potentially hazardous community-wise to advertise something new as the "primary platform"
20161217 02:31:33< vultraz> I am not doing this.
20161217 02:31:34< celticminstrel> I'm not sure I agree there's no downside in moving.
20161217 02:31:42< vultraz> "08:04:10]	Soliton	and tweeting about it when barely anyone is even there yet."
20161217 02:31:48< vultraz> The tweet was to GET people there :P
20161217 02:33:32< vultraz> I'm not saying any new platform is "official"
20161217 02:33:57< vultraz> Just making use of the discord server and seeing how it goes from there.
20161217 02:34:10< vultraz> Perhaps I should have made this clear last night.
20161217 02:45:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 02:45:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 02:47:36-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161217 02:49:12-!- gfgtdf_ [~chatzilla@78.54.141.224] has joined #wesnoth-dev
20161217 02:50:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161217 02:51:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 02:51:25-!- gfgtdf [~chatzilla@78.54.48.241] has quit [Ping timeout: 260 seconds]
20161217 02:51:37-!- gfgtdf_ is now known as gfgtdf
20161217 02:54:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 02:54:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 03:09:49 * vultraz makes note to deploy NOEXCEPT
20161217 03:11:50-!- iceiceice [~chris@unaffiliated/iceiceice] has left #wesnoth-dev ["Ex-Chat"]
20161217 03:25:11< celticminstrel> That should be safe, because it expands to throw() on compilers that don't support noexcept, which is just the old way of specifying the exact same thing.
20161217 03:36:59-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161217 03:37:11< iceiceice> celticminstrel, that's not really true at all
20161217 03:37:34< iceiceice> sticking throw() everywhere that you would put noexcept is a really bad idea
20161217 03:37:39< iceiceice> it will make everything much slower
20161217 03:37:53< vultraz> right now it's throw()
20161217 03:38:05< iceiceice> also exception specifications are not implemented by all major compilers
20161217 03:38:07< vultraz> I want to use NOEXCEPT so it only uses throw() on msvc2013
20161217 03:38:23< iceiceice> you should basically never use throw()
20161217 03:38:57< vultraz> said compiler doesn't have noexcept
20161217 03:39:17< iceiceice> do whatever you want i dont care, but it's very unsonud C++ advice to have a NOEXCEPT macro which is noexcept on recent compilers and throw() on old ones
20161217 03:39:23< iceiceice> it should just be, expands to nothing on old ones
20161217 03:39:54< iceiceice> all you'll do is create a bunch of wierd platform-dependent slow-downs and/or crashes with throw()
20161217 03:40:38< iceiceice> the reason noexcept is performant is because it's usually implemented by a simple hack,
20161217 03:40:48< iceiceice> you go to the matrix of all exception throw sites and all exceptoin handlers
20161217 03:41:01< iceiceice> and you make it so that the exception throw sites that go across noexcept go right to std::terminate instead
20161217 03:41:14< iceiceice> when you use throw() it can't be implemented the fast way at all,
20161217 03:41:23< iceiceice> every single throw() you jump across requires an independent runtime test
20161217 03:42:07< iceiceice> it's always a bad idea to write an exception specification in modern code, the only reason to do it is if like you have to override something from std::exception or something
20161217 03:43:07< iceiceice> saying "noexcept is basically the same as throw()" is about as accurate as saying "constexpr is basically the same as const"
20161217 03:43:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 04:21:57-!- irker270 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161217 04:21:57< irker270> wesnoth: Charles Dang wesnoth:master e22c8967ee1c / src/ (160 files in 31 dirs): Cleaned up global.hpp includes https://github.com/wesnoth/wesnoth/commit/e22c8967ee1ca4aca08b9e8d3c4d0d8c15f2b55a
20161217 04:26:10-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 04:33:42-!- Appleman1234_ [~Appleman1@KD106161201131.au-net.ne.jp] has joined #wesnoth-dev
20161217 04:35:36-!- Appleman1234 [~Appleman1@KD106161208011.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20161217 04:46:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 04:47:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 04:51:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Ping timeout: 258 seconds]
20161217 04:58:02< celticminstrel> What.
20161217 04:59:06-!- gfgtdf [~chatzilla@78.54.141.224] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.1.0/20161208153507]]
20161217 04:59:38< celticminstrel> I don't know about performance or whatever, but a compiler would be totally able to implement throw() in the exact same way as noexcept (assuming empty exception specification, of course). If they didn't bother, that's not exactly our fault.
20161217 05:10:09< celticminstrel> I'm not sure why you'd jump across more than one throw(), given that jumping across one is supposed to be a fatal error. (Okay, a call to std::unexpected, but IIRC that defaults to calling std::terminate?).
20161217 05:11:20< celticminstrel> So anywa vultraz, why'd you remove all the global.hpp includes.
20161217 05:11:23< celticminstrel> ^anyway
20161217 05:11:29< celticminstrel> Doesn't that seem like a bad idea?
20161217 05:12:42< iceiceice> celticminstrel, no, for reasons I don't understand, it cannot
20161217 05:12:53< iceiceice> throw() is not specified in the same way as noexcept
20161217 05:13:15< iceiceice> but it's been discussed many times that noexcept is different and much better
20161217 05:13:51< celticminstrel> I doubt it'll have a significant impact. Especially if as vultraz implies he's replacing throw() with NOEXCEPT.
20161217 05:16:23< iceiceice> celticminstrel, i think Loki Astari comment here is the difference: http://stackoverflow.com/questions/12833241/difference-between-c03-throw-specifier-c11-noexcept
20161217 05:16:31< iceiceice> @NicolBolas: One other difference worth noting. If a function is marked throws() then if an exception is thrown the stack must be unwound upto the scope of that function (so all automatic variables in the function are destroyed) at which point terminate() is called (via unexpected()). If a function is marked noexcept then if an exception is thrown then terminate is called (the unwinding of the stack is implementation defined detail).
20161217 05:17:16< iceiceice> this sounds like a really minor thing, but i think on some compilers, like msvc, it is so difficult for them to do within the framework for exceptions that they have, that it caused horrible overhead and they basically didn't implement it as specified
20161217 05:18:26< iceiceice> i dont remember what the outcome was i guess
20161217 05:18:40< iceiceice> if its that, on msvc, they basically did whatever they want that is fast,
20161217 05:18:47< iceiceice> or if they did something stupid that is slow because the standard requires it
20161217 05:19:06< iceiceice> either way they say its bad to write throw() because of such uncertainty
20161217 05:19:30< iceiceice> if actually though, msvc just does what they also do under `noexcept` then i guess it's great for your purpose :)
20161217 05:20:40< iceiceice> idk i never saw a macro thats "noexcept" if available and "throw()" otherwise
20161217 05:20:51< iceiceice> everyone i talked to just says avoid throw() like the plague
20161217 05:21:22< iceiceice> can't remember how throw() works exactly anymore
20161217 05:42:17< vultraz> celticminstrel: because they're not needed\
20161217 05:42:46< vultraz> anymore
20161217 05:51:19< iceiceice> celticminstrel, i guess i'm not sure but i dont think it's entirely some language lawyer issue
20161217 05:51:33< iceiceice> i think there actually are a bunch of compilers out there that do really stupid stuff with throw()
20161217 05:51:46< celticminstrel> I dunno, maybe.
20161217 05:53:50< iceiceice> gn
20161217 05:53:54-!- iceiceice [~chris@unaffiliated/iceiceice] has left #wesnoth-dev ["Ex-Chat"]
20161217 06:23:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161217 06:58:17-!- Appleman1234_ is now known as Appleman1234
20161217 07:22:21-!- irker270 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161217 07:42:55-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 08:40:46-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 08:40:46< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang e22c896: Cleaned up global.hpp includes Succeeded
20161217 08:40:46< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-51
20161217 08:40:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 09:03:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 09:03:56< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang e22c896: Cleaned up global.hpp includes Succeeded
20161217 09:03:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-51
20161217 09:04:00-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 09:35:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 09:35:42< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang e22c896: Cleaned up global.hpp includes Succeeded
20161217 09:35:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-52
20161217 09:35:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 09:50:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161217 09:58:33-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 09:58:33< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang e22c896: Cleaned up global.hpp includes Succeeded
20161217 09:58:33< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-52
20161217 09:58:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 10:08:28< zookeeper> portraits probably get downscaled using NN? https://forums.wesnoth.org/viewtopic.php?p=606347#p606347
20161217 10:08:34< zookeeper> that's my guess anyway
20161217 10:21:54-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 10:31:30-!- mjs-de [~mjs-de@78.49.146.0] has joined #wesnoth-dev
20161217 10:51:37-!- irker570 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161217 10:51:37< irker570> wesnoth: Charles Dang wesnoth:master c5aa4f208603 / src/ (13 files in 4 dirs): Replaced cases of throw() with NOEXCEPT https://github.com/wesnoth/wesnoth/commit/c5aa4f208603fae89068d035b628559aa28bd999
20161217 10:52:20< vultraz> zookeeper: not a simple fix
20161217 10:52:34< zookeeper> oh?
20161217 10:55:46< vultraz> zookeeper: it's a bug in the scaling algorithm 
20161217 11:05:15-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has joined #wesnoth-dev
20161217 11:19:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161217 11:42:10< matthiaskrgr> http://pastebin.com/Eb 
20161217 11:49:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 11:54:21-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has joined #wesnoth-dev
20161217 11:54:22< travis-ci> wesnoth/wesnoth#12438 (master - c5aa4f2 : Charles Dang): The build has errored.
20161217 11:54:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184749894
20161217 11:54:22-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has left #wesnoth-dev []
20161217 12:03:04< zookeeper> matthiaskrgr, well that expired quick
20161217 12:14:05< matthiaskrgr> oh, oops
20161217 12:14:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 12:14:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 12:15:00< matthiaskrgr> http://pastebin.com/zpEQMd5Y 
20161217 12:15:11< matthiaskrgr> cppcheck struggles as well
20161217 12:15:25< matthiaskrgr> [src/utils/io.hpp:22]: (error) failed to evaluate #if condition
20161217 12:20:20< matthiaskrgr> is it know that DiD is broken?
20161217 12:21:01< matthiaskrgr> http://pastebin.com/ppuchHWr 
20161217 12:21:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 12:21:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 12:21:49< matthiaskrgr> the game crashes after exiting that screen, is that "ok" or should it continue runningß
20161217 12:21:52< matthiaskrgr> ?
20161217 12:23:11-!- stikonas_ is now known as stikonas
20161217 12:23:49< zookeeper> gfgtdf, ^ you must have broken DiD in a53090d648
20161217 12:24:45< zookeeper> (because you didn't quote the second argument)
20161217 12:25:11< zookeeper> ah, well, i'll just quickfix that myself
20161217 12:25:44< zookeeper> except with git it's never quick
20161217 12:26:52< matthiaskrgr> why?
20161217 12:28:25< zookeeper> because i have to first pull, and then pull fails because of local changes, so i need to stash/revert those, then pull again, then restore the local changes, and then i can commit and push
20161217 12:31:56< irker570> wesnoth: ln-zookeeper wesnoth:master 491e9d6aa216 / data/campaigns/Descent_Into_Darkness/scenarios/08_A_Small_Favor2.cfg: Fixed broken macro arguments introduced in a53090d64 https://github.com/wesnoth/wesnoth/commit/491e9d6aa216127f13563ef46284f77a049ff6bc
20161217 12:32:26< matthiaskrgr> oh
20161217 12:32:41< zookeeper> with svn, IIRC you didn't even need to update before you could commit (unless there were conflicts, of course), and it definitely knew how to merge in updates into files you had local changes in so you didn't need to go through the stupid stash/revert/unstash/etc hassle all the time.
20161217 12:36:56< zookeeper> and that's pretty much the dumbest thing in git. it can't deal with pulling in updates to a file i have local changes in no matter what, so it constantly forces me to deal with that manually.
20161217 12:37:13< matthiaskrgr> hmmhmm
20161217 12:37:22< matthiaskrgr> theres a crash in the MP create game screen
20161217 12:37:33< matthiaskrgr> but the stacktrace is a bit odd
20161217 12:38:02< matthiaskrgr> I build wesnoth with a locally compiled llvm/clang, and I'm not sure if the stacktrace points to a bug in wesnoth of if its an issue in llvm 
20161217 12:38:28< matthiaskrgr> http://pastebin.com/raw/kWkHnVqR  
20161217 12:38:55< matthiaskrgr> it looks like it might be trying to report UB and then crashes inside the UB library
20161217 12:46:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161217 12:49:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 12:49:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 12:55:26-!- gfgtdf [~chatzilla@x4e368de0.dyn.telefonica.de] has joined #wesnoth-dev
20161217 12:56:08-!- gfgtdf [~chatzilla@x4e368de0.dyn.telefonica.de] has quit [Client Quit]
20161217 13:01:12< vultraz> zookeeper: or you could use the web interface
20161217 13:01:41-!- louis94 [~~louis94@91.178.242.25] has joined #wesnoth-dev
20161217 13:02:24< vultraz> zookeeper: are you the one who uses TGit?
20161217 13:02:30< vultraz> (besides me)
20161217 13:05:11< vultraz> your workflow seems unnecessarily complicated. You can make a commit containing only a subset of changes to a file, then pull and rebase.
20161217 13:05:47< vultraz> or stash, pull, commit, pop
20161217 13:06:10< vultraz> why restore local changes BEFORE committing?
20161217 13:08:26< zookeeper> vultraz, i am
20161217 13:08:44< zookeeper> anyway, no time ->
20161217 13:16:40-!- JyrkiVesterinen [~JyrkiVest@87-92-17-170.bb.dnainternet.fi] has joined #wesnoth-dev
20161217 13:30:40-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161217 13:30:41< travis-ci> wesnoth/wesnoth#12440 (master - 491e9d6 : ln-zookeeper): The build passed.
20161217 13:30:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184759809
20161217 13:30:41-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161217 13:41:13< irker570> wesnoth: Jyrki Vesterinen wesnoth:master e0ca5576e06e / src/global.hpp: Attempt to fix a compiler warning with modern Clang https://github.com/wesnoth/wesnoth/commit/e0ca5576e06e6dd405dcaf0043566172405979c2
20161217 13:41:22< JyrkiVesterinen> matthiaskrgr: ^
20161217 13:48:05< matthiaskrgr> looks good I think
20161217 13:49:19-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161217 13:53:11-!- mjs-de [~mjs-de@78.49.146.0] has quit [Ping timeout: 258 seconds]
20161217 13:55:40< vultraz> zookeeper: so, any thoughts on a release tomorrow?
20161217 13:55:56< vultraz> if you don't want one we can wait until the new year
20161217 13:59:22< vultraz> thought actually we may not be able to
20161217 13:59:23< vultraz> anyway
20161217 13:59:39< vultraz> since i haven't fully dealt with the ramifications of shadowm's departure.
20161217 14:13:30< matthiaskrgr> hmm
20161217 14:13:44< matthiaskrgr> so I recompiled everything and that map crash still happens, odd
20161217 14:14:09-!- louis94 [~~louis94@91.178.242.25] has quit [Ping timeout: 260 seconds]
20161217 14:19:47-!- louis94 [~~louis94@91.178.242.25] has joined #wesnoth-dev
20161217 14:28:58-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20161217 14:29:39-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20161217 14:40:08-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has quit [Quit: leaving]
20161217 14:40:14-!- louis94 [~~louis94@91.178.242.25] has quit [Ping timeout: 264 seconds]
20161217 14:58:25< JyrkiVesterinen> ** @todo this point shouldn't be reached, find out why it does. */
20161217 14:58:36< JyrkiVesterinen> Line 241 of grid.cpp. I just reached it in a debugger.
20161217 14:58:46< JyrkiVesterinen> A bug in the container_base class. Will fix.
20161217 15:19:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20161217 15:22:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 15:23:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:23:21-!- stikonas_ is now known as stikonas
20161217 15:23:58-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161217 15:25:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 15:25:34-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:26:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 15:26:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:27:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 15:27:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:32:55-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 15:34:25-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:36:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:36:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 15:39:33< vultraz> I see to have committed a change to unit_preview_pane I didn't intend to..
20161217 15:39:39< vultraz> oh well
20161217 15:40:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 15:40:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:41:44< matthiaskrgr> ok, with gcc, the crash looks diffrent
20161217 15:41:52< matthiaskrgr> and there is no direct sign of UB involved, funny
20161217 15:42:02< matthiaskrgr> https://gna.org/bugs/index.php?25393  
20161217 15:42:19< irker570> wesnoth: Charles Dang wesnoth:master f5e0d38f02e2 / src/gui/widgets/unit_preview_pane.cpp: Unit Preview Pane: further format updates to weapon special and ability tooltips https://github.com/wesnoth/wesnoth/commit/f5e0d38f02e2eb21529b4e5babfccb80b1e7680c
20161217 15:43:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 15:43:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:45:05-!- DeFender1031 [~DeFender1@dsl217-132-62-187.bb.netvision.net.il] has joined #wesnoth-dev
20161217 15:45:22< vultraz> matthiaskrgr: cannot repro
20161217 15:45:28< matthiaskrgr> hmm
20161217 15:46:26< matthiaskrgr> ok, can you try something different; (might be a related  crash:)  
20161217 15:47:41< matthiaskrgr> multiplayer -> local game -> create game ->  in the map-starting position menu (where it says north/south/west etc) click it and just click on the upper-most option again
20161217 15:47:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds]
20161217 15:47:56< matthiaskrgr> I get a crash there as well 
20161217 15:48:03< matthiaskrgr> (also heap use after free)
20161217 15:48:11-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:48:38< vultraz> cannot repro.
20161217 15:48:47< matthiaskrgr> :|
20161217 15:48:48< vultraz> there used to be a crashthere but that was fixed 
20161217 15:48:52< matthiaskrgr> yes
20161217 15:49:07< matthiaskrgr> maybe try with valgrind?
20161217 15:49:21< vultraz> don;t have that installed
20161217 15:49:28< matthiaskrgr> hm
20161217 15:51:37< matthiaskrgr> well I can reproduce it with asan under llvm and gcc
20161217 15:52:16< vultraz> :/
20161217 15:53:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 15:53:18-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 15:59:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161217 15:59:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 16:01:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161217 16:01:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 16:08:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 16:08:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 16:13:12< irker570> wesnoth: Jyrki Vesterinen wesnoth:grid-size-control 78f026280d30 / src/gui/widgets/container_base.cpp: Fix: container_base with explicit minimum size can't shrink below that https://github.com/wesnoth/wesnoth/commit/78f026280d30ec02a3b2e26b341e56422e6a8532
20161217 16:15:52-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161217 16:15:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161217 16:17:50-!- stikonas_ is now known as stikonas
20161217 16:18:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161217 16:25:06< irker570> wesnoth: Jyrki Vesterinen wesnoth:grid-size-control 864e302f7c71 / src/gui/widgets/container_base.cpp: Fix: container_base with explicit minimum size can't shrink below that https://github.com/wesnoth/wesnoth/commit/864e302f7c712a5b57d4639d27bd69f1c3e80e0f
20161217 16:25:36< JyrkiVesterinen> ^ History rewriting. Some spaces were missing in the earlier version of the commit.
20161217 16:25:44< JyrkiVesterinen> Also, I opened pull request 904.
20161217 16:34:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 16:42:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 16:42:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang f5e0d38: Unit Preview Pane: further format updates to weapon special and ability tooltips Succeeded
20161217 16:42:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-52
20161217 16:42:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 16:45:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 16:46:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 16:57:38-!- travis-ci [~travis-ci@ec2-54-224-7-103.compute-1.amazonaws.com] has joined #wesnoth-dev
20161217 16:57:39< travis-ci> wesnoth/wesnoth#12443 (grid-size-control - 78f0262 : Jyrki Vesterinen): The build has errored.
20161217 16:57:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184787926
20161217 16:57:39-!- travis-ci [~travis-ci@ec2-54-224-7-103.compute-1.amazonaws.com] has left #wesnoth-dev []
20161217 17:04:39-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161217 17:06:50-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 17:06:50< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang f5e0d38: Unit Preview Pane: further format updates to weapon special and ability tooltips Succeeded
20161217 17:06:50< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-52
20161217 17:06:55-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 17:20:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection]
20161217 17:34:18< DeFender1031> vultraz, dunno if you saw yesterday, but i'm finally able to compile
20161217 17:34:32< DeFender1031> (or if you're still here right now)
20161217 17:38:59-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 17:38:59< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang f5e0d38: Unit Preview Pane: further format updates to weapon special and ability tooltips Succeeded
20161217 17:38:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-53
20161217 17:39:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 17:41:00< vultraz> DeFender1031: ah, good, good
20161217 17:42:52< DeFender1031> now to take a look at that file i was planning on rewriting
20161217 17:44:04< DeFender1031> "while (true)"??? ugh!
20161217 17:44:15< celticminstrel> What's ugh about it?
20161217 17:44:55< vultraz> not very nice coding
20161217 17:45:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 17:46:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20161217 17:47:23< DeFender1031> celticminstrel, infinite loops should be "for(;;)" in the few cases where they're actually necessary in the first place
20161217 17:47:32< celticminstrel> Ew, no.
20161217 17:47:49< celticminstrel> I hate that, it's ugly.
20161217 17:47:50< DeFender1031> what?!
20161217 17:48:46< DeFender1031> Well, that's a matter of opinion. What not a matter of opinion is that "while (true)" can be less efficient if a compiler isn't doing optimization on it
20161217 17:49:06< JyrkiVesterinen> I also think that "while(true)" is more clear than "for(;;)".
20161217 17:49:41< DeFender1031> now granted, any modern compiler should know to optimize that our, but it's true that as interpreted literally "while(true) does a check every time whereas "for(;;)" does not.
20161217 17:49:46< DeFender1031> out*
20161217 17:50:31< DeFender1031> also it's good practice because other interpreted languages which use a similar syntax may not have optimizers as such
20161217 17:51:21< DeFender1031> i have sometimes done a "#define loop for(;;)" to make it prettier, but I do still think that it's the right way.
20161217 17:51:47< celticminstrel> Doesn't look like our coding standards mentions this...
20161217 17:52:16< vultraz> I've seen both in our code
20161217 17:52:25< vultraz> FWIW while(true) is easier to read
20161217 17:52:25< JyrkiVesterinen> DeFender1031: The "for(;;)" loop *also* does a check every time if interpreted literally.
20161217 17:52:32< celticminstrel> So I guess that means you're free to do what you want.
20161217 17:52:33< JyrkiVesterinen> From the C99 standard:
20161217 17:52:43< JyrkiVesterinen> "for ( clause-1 ; expression-2 ; expression-3 ) statement"
20161217 17:52:47< vultraz> for(;;) isn't immediately obvious 
20161217 17:52:52< JyrkiVesterinen> "Both clause-1 and expression-3 can be omitted. An omitted expression-2 is replaced by a
20161217 17:52:52< JyrkiVesterinen> nonzero constant."
20161217 17:53:00< celticminstrel> Well, it's obvious to me.
20161217 17:53:00< DeFender1031> vultraz, it is to anyone who regularly codes that way.
20161217 17:53:12< celticminstrel> I don't use it, but.
20161217 17:53:13< vultraz> yes
20161217 17:53:23< JyrkiVesterinen> In other words, "for(;;)" is syntactically equivalent to "for(;1;)".
20161217 17:53:40< DeFender1031> JyrkiVesterinen, true, but it's generally not implemented as such internally. That's referring to behavior, not implementation.
20161217 17:54:15< JyrkiVesterinen> Neither is "while(true)" implemented with a check internally, at least if optimizations are enabled.
20161217 17:55:10< DeFender1031> true, but as i said, that doesn't necessarily hold when jumping languages, and it's therefore a good habit to get into to do what's known to be optimal everywhere.
20161217 17:57:02< JyrkiVesterinen> I disagree. IMHO, "while(true)" is slightly clearer syntax, which is more important than the fact that "for(;;)" is faster in some other languages.
20161217 17:57:11< celticminstrel> So you'rs suggesting for(;;) is also more optimal in eg JS or Java.
20161217 17:57:21< celticminstrel> ^you're
20161217 17:57:34 * celticminstrel doesn't care that much though, still prefers while(true).
20161217 18:00:25< celticminstrel> Oh hey, "Do not use #define for constants" is in the coding standards.
20161217 18:01:24< celticminstrel> vultraz: So if you want to replace #define'd integers with static const variables, go for it!
20161217 18:01:34< celticminstrel> (Or const variables in an anonymous namespace.)
20161217 18:01:45< vultraz> constexpr!
20161217 18:01:55< celticminstrel> Unfortunately, no.
20161217 18:02:07< celticminstrel> But it doesn't matter - constexpr would be meaningless there anyway.
20161217 18:02:21< celticminstrel> Basically, we can't use constexpr at all.
20161217 18:02:31< celticminstrel> The macro doesn't work.
20161217 18:02:36< celticminstrel> It should probably be removed.
20161217 18:02:42< vultraz> how does it not work :|
20161217 18:03:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161217 18:03:21< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang f5e0d38: Unit Preview Pane: further format updates to weapon special and ability tooltips Succeeded
20161217 18:03:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-53
20161217 18:03:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161217 18:03:31< vultraz> also, what is this "there" you speak of
20161217 18:03:45< celticminstrel> If you declare something constexpr and then rely on it elsewhere, it will potentially break the MSVC 2013 build.
20161217 18:03:55< DeFender1031> JyrkiVesterinen, I hear your argument and it's completely valid. I just happen to come from a school of thought that cares more about efficiency than code aesthetics unless it's a huge tradeoff on the readability side.
20161217 18:04:04< celticminstrel> And "there" refers to declaring integer constant variables. They basically have constexpr semantics automatically.
20161217 18:04:31 * vultraz curses the msvc2013 build
20161217 18:04:34< DeFender1031> JyrkiVesterinen, especially in a case like this where anyone who becomes familiar with the syntax will easily recognize it.
20161217 18:04:51 * celticminstrel curses vultraz's build. :P
20161217 18:05:01< vultraz> you should
20161217 18:05:04< vultraz> im still on gcc 5 :(
20161217 18:05:07< celticminstrel> Speaking of vultraz's build... could you get a tests project working already?
20161217 18:05:07 * DeFender1031 has cursed MSVC many times in his career.
20161217 18:05:22< JyrkiVesterinen> DeFender1031: Yeah, myself I come from the school of thought that aesthetics is way more important than efficiency, except in the 0,1 % of code that really needs to be fast.
20161217 18:05:24< vultraz> (mostly joking)
20161217 18:05:32< DeFender1031> btw, celticminstrel, did you fix that GCC 4 thing from yesterday?
20161217 18:05:33< vultraz> (but tdm gcc hasn't been updated since july 2015)
20161217 18:05:46< celticminstrel> DeFender1031: What thing?
20161217 18:05:56< DeFender1031> celticminstrel, something about put_time
20161217 18:05:57< vultraz> celticminstrel: next year
20161217 18:06:03< JyrkiVesterinen> I have even programmed in Ruby. It's a language that ignores efficiency almost completely.
20161217 18:06:05< celticminstrel> vultraz: What?
20161217 18:06:20< celticminstrel> DeFender1031: That's not very descriptive?
20161217 18:06:21< vultraz> I have no tests project
20161217 18:06:28< celticminstrel> vultraz: That's the problem.
20161217 18:06:28< DeFender1031> JyrkiVesterinen, like games with animations in real-time for instance? ;P
20161217 18:06:56< vultraz> celticminstrel: ill set one up next year
20161217 18:06:57< vultraz> maybe
20161217 18:07:03< JyrkiVesterinen> Even in games, the majority of code isn't performance-critical.
20161217 18:07:07< celticminstrel> DeFender1031: Oh, if you mean the thing I told you to revert commits for, I did fix that.
20161217 18:07:23< celticminstrel> So you can rebase out the revert now and compile master.
20161217 18:07:34< JyrkiVesterinen> The important parts can be optimized. But, IMO, nothing else should be.
20161217 18:07:37< celticminstrel> Travis is now passing, and it uses GCC 4.8.
20161217 18:08:10< DeFender1031> celticminstrel, yes, that thing
20161217 18:08:24< DeFender1031> how do i rebase out my revert?
20161217 18:08:58< DeFender1031> JyrkiVesterinen, where I come from, if you write everything optimal from the get-go you don't need to worry about optimizing it later.
20161217 18:09:00< vultraz> why are *you* using gcc 4 O_O
20161217 18:09:04< JyrkiVesterinen> For example, this function I wrote *is* optimized because it needs to be fast.
20161217 18:09:05< celticminstrel> Assuming you're on a branch, "git rebase -i master". If you're not on a branch, origin/master should work (might want to first run git fetch).
20161217 18:09:05< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/attack_prediction.cpp#L1289
20161217 18:09:13< celticminstrel> vultraz: Probably the same reason Travis is.
20161217 18:09:29< celticminstrel> DeFender1031: Then an editor should come up where you delete the line pertaining to the revert, save, and exit.
20161217 18:09:30< DeFender1031> vultraz, because debian stable doesn't have GCC5?
20161217 18:09:37< JyrkiVesterinen> Note the use of ternaries, for example. I tried to hint the compiler to use conditional moves if possible.
20161217 18:09:37< vultraz> I see
20161217 18:09:44< vultraz> :/
20161217 18:10:29< vultraz> ternaries are performance optimizations? 
20161217 18:10:39< celticminstrel> I wouldn't say that's true in general, no.
20161217 18:11:20< vultraz> honestly, the optimization i do mostly has to do with making sure less stuff needs to be done.
20161217 18:11:25< DeFender1031> vultraz, only in some very select cases
20161217 18:11:29< vultraz> optimizations 
20161217 18:11:30< vultraz> have
20161217 18:14:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 18:15:16< DeFender1031> celticminstrel, no editor, just some crypic error message about conflicts
20161217 18:16:57< celticminstrel> Eh?
20161217 18:17:13< celticminstrel> You did specify -i right
20161217 18:18:44< DeFender1031> i'm not in a branch
20161217 18:18:57< celticminstrel> "git rebase --abort"
20161217 18:19:05< DeFender1031> i just cloned and then removed those two commits you told me to
20161217 18:19:11< DeFender1031> did that already
20161217 18:19:23< JyrkiVesterinen> Try "git checkout master".
20161217 18:19:54< DeFender1031> i'm already in master if i nevver made a branch, aren't i?
20161217 18:19:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Ping timeout: 258 seconds]
20161217 18:20:11< celticminstrel> Yes.
20161217 18:20:18< celticminstrel> So did you fix it or not?
20161217 18:20:22-!- gfgtdf [~chatzilla@78.54.141.224] has joined #wesnoth-dev
20161217 18:20:25< celticminstrel> "git rebase -i origin/master"
20161217 18:20:29< celticminstrel> Delete that line
20161217 18:20:31< celticminstrel> Save, exit
20161217 18:20:32< DeFender1031> i don't know
20161217 18:20:56-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 18:21:13< celticminstrel> "git log" and see if the revert is still there? Does "git status" say you're in the middle of a rebase?
20161217 18:21:18< DeFender1031> delete what line?
20161217 18:21:45< DeFender1031> no, i'm not in a rebase.
20161217 18:21:56-!- Kwandulin [~Miranda@p200300760F6EBF8D182C974AF98E7D60.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161217 18:22:07< DeFender1031> running the command you said brings up an editor with two lines beginning with "pick" and a bunch of #
20161217 18:22:25< celticminstrel> Right, one of those picks is probably the revert, so delete that line and save.
20161217 18:22:54< celticminstrel> (It should say revert if it's a revert.)
20161217 18:23:09-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161217 18:23:19< DeFender1031> they both seem to be reverts
20161217 18:23:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 18:23:51< celticminstrel> Oh, then forget it.
20161217 18:24:17< celticminstrel> Do you have unstaged changes?
20161217 18:24:41< DeFender1031> i have thusfar made no changes of any kind aside from reverting the two commits you told me to
20161217 18:25:00< celticminstrel> Okay, so get out of the editor.
20161217 18:25:04< DeFender1031> okay...
20161217 18:25:10< DeFender1031> conflict again
20161217 18:25:13< DeFender1031> rerand abort
20161217 18:25:18< celticminstrel> Right
20161217 18:25:21< DeFender1031> reran*
20161217 18:25:27< celticminstrel> git reset --hard origin/master
20161217 18:25:33< DeFender1031> ahhh
20161217 18:27:22< DeFender1031> thanks. I feel like I'm going to be a pain until I get accustomed to git.
20161217 18:27:38< DeFender1031> so I apologize in advance.
20161217 18:32:09-!- travis-ci [~travis-ci@ec2-54-224-7-103.compute-1.amazonaws.com] has joined #wesnoth-dev
20161217 18:32:10< travis-ci> wesnoth/wesnoth#12445 (grid-size-control - 864e302 : Jyrki Vesterinen): The build passed.
20161217 18:32:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184789723
20161217 18:32:10-!- travis-ci [~travis-ci@ec2-54-224-7-103.compute-1.amazonaws.com] has left #wesnoth-dev []
20161217 18:32:49< DeFender1031> I also feel like I'm going to have strong differing opinions on coding standards in various ways, so I apologize for that too, and I will try to stick to wesnoth's standards as best I can, even where I don't generally agree.
20161217 18:34:25< JyrkiVesterinen> For the record, the infinite loop style is *not* in our coding standards. Both styles are allowed.
20161217 18:39:10< DeFender1031> JyrkiVesterinen, yeah, i caught that
20161217 18:39:20< DeFender1031> But there are things that are which I don'
20161217 18:39:23< DeFender1031> t like
20161217 18:39:30< DeFender1031> Such as tab indentation
20161217 18:40:00< DeFender1031> but like i said, i'm not here to make waves, i'm here to help the project, so i'll live with it.
20161217 18:40:26< DeFender1031> i just wish my editor's setting for indentation was per-session and not global. :/
20161217 18:41:46-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20161217 18:43:49< celticminstrel> Bizarrely, the standards for WML (except GUI2 WML) is spaces.
20161217 18:44:54< DeFender1031> ah, well that too... i prefer 2 over 4, but whatever.
20161217 18:46:32< celticminstrel> If I was in charge of everything, it'd be tabs everywhere. Including the python code.
20161217 18:46:46-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20161217 18:52:53< DeFender1031> if i was in charge of everything, i'd probably insist that everything be tabs as well, but also add some kind of hook that automatically converted tabs to spaces on every checkout/clone/fetch, and automatically converted back to tabs on every commit
20161217 18:53:40< DeFender1031> but the lack of consistency between sections of the project makes that much more difficult
20161217 18:53:48< celticminstrel> I did that in reverse, but for Python only. It causes some minor problems sometimes though.
20161217 18:54:03< celticminstrel> There is one python file that is indented with... 6 or 8 spaces instead of 4.
20161217 18:54:07< DeFender1031> oh, yeah, i'd also add some kind of JS hack to make web-viewing turn tabs into spaces
20161217 18:54:11< celticminstrel> I can't remember exactly.
20161217 18:54:18< DeFender1031> ...
20161217 18:54:32< DeFender1031> Consistency, people, consistency!
20161217 18:55:01< celticminstrel> Oh wait, was it indented with tabs after all?
20161217 18:55:18< celticminstrel> It looked like spaces in the diff when it was getting in my way.
20161217 18:55:36< celticminstrel> Well, I can't be bothered fixing it though.
20161217 18:56:56< DeFender1031> would it be insane for someone to propose we standardize on tabs everywhere and then go through everything and fix it?
20161217 18:57:12< celticminstrel> It would not be too insane.
20161217 18:57:13< DeFender1031> probably... it'd probably cause mass-conflicts with every branch.
20161217 18:57:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 18:57:44< celticminstrel> I suspect the Python people would be strongly against it though. They seem to think that PEP-8 is sacred or something.
20161217 18:58:08< celticminstrel> It would cause a lot of conflicts in branches, yes.
20161217 18:58:39< gfgtdf> i think it would, i also think tabs woudl be better here, but i really don't want to loose the ability to easily use git blame on the wml files.
20161217 18:59:13< DeFender1031> screw PEP-8. You don't get to dictate what conventions come with a language (unless you enforce it in the parser, but then you're just an asshole.)
20161217 18:59:22< celticminstrel> Oh hey, there's a "git blame -w".
20161217 18:59:29< celticminstrel> DeFender1031: That's pretty much my view as well.
20161217 18:59:32< DeFender1031> gfgtdf, agreed
20161217 18:59:41< DeFender1031> celticminstrel, what's -w?
20161217 18:59:45< celticminstrel> Ignore whitespace.
20161217 18:59:57< DeFender1031> hmm
20161217 19:00:12< DeFender1031> it'd be nice if -w were doable at commit-time though
20161217 19:01:01< DeFender1031> some command that said "retain the old blame on any lines where the only changes are whitespace"
20161217 19:01:10< gfgtdf> celticminstrel: hmm but github webpage (like https://github.com/wesnoth/wesnoth/blame/master/data/core/macros/abilities.cfg ) doesn't seem to support it.
20161217 19:01:21< celticminstrel> I think the blame is calculated dynamically.
20161217 19:01:31< celticminstrel> On demand.
20161217 19:02:14< celticminstrel> gfgtdf: Looks like you're right, adding ?w=1 didn't do anything. Github feature request maybe? :P
20161217 19:02:25< DeFender1031> celticminstrel, even so, commits could still be marked with such a flag, and then when calculating, it'd treat those commits differently
20161217 19:02:54< celticminstrel> I suppose.
20161217 19:03:33< TC01> DeFender1031: ironically, PEP-8 was actually only intended to be the *Python standard library*'s coding guidelines, not  guidelines for the entire language ("This document gives coding conventions for the Python code comprising the standard library in the main Python distribution.")
20161217 19:04:53< DeFender1031> TC01, I don't know anything about it aside from what celticminstrel just said, but it sounds like it was taken to mean "all code" by some not-insignificant group of elitists.
20161217 19:05:20< TC01> Oh, it has been, but it's just amusing/sad because the document itself expressely says that's not it's purpose :/
20161217 19:05:22< DeFender1031> (I googled to see what PEP-8 was and formed an admittedly snap opinion.)
20161217 19:05:24< celticminstrel> There've been one or two arguments about it in here since I showed up (generally in response to me).
20161217 19:07:03< DeFender1031> :/
20161217 19:08:15< DeFender1031> The coding standards used by the standard libraries are often not necessarily the best for general usage. For example, I prefer something rather close to the Qt conventions for C++ far more than the conventions used by the STL.
20161217 19:09:30< celticminstrel> In my own code I generally start classes with a capital letter too.
20161217 19:11:28-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has left #wesnoth-dev ["Ex-Chat"]
20161217 19:11:58< DeFender1031> there's more than just that, but yes, that's one example
20161217 19:15:33< DeFender1031> https://bugs.kde.org/show_bug.cgi?id=276027 stupid stupid stupid.
20161217 19:16:46< DeFender1031> i don't know why they can't have a "configure session" dialog that is identical to the main one, but where every setting has an additional "use default" option.
20161217 19:18:00< DeFender1031> so instead i have to add a special config file for every directory in wesnoth
20161217 19:18:16< DeFender1031> (assuming i can figure out what that file should look like)
20161217 19:20:50< JyrkiVesterinen> https://kate-editor.org/2006/02/09/kateconfig-files/
20161217 19:21:16< JyrkiVesterinen> Kate can search for .kateconfig files in parent directories too. Only one file is necessary.
20161217 19:21:52< JyrkiVesterinen> You can even make a pull request about it. I would gladly merge it.
20161217 19:23:04< DeFender1031> JyrkiVesterinen, ah, it respects the config file of a whole directory tree? (Meaning, it traverses upward looking for a file?)
20161217 19:23:31< JyrkiVesterinen> According to that blog post it's configurable depth.
20161217 19:24:51< JyrkiVesterinen> IIRC, we don't have any C++ files more than two levels deep. (that is, src -> subdir -> subdir)
20161217 19:24:54< DeFender1031> in that case, it's far less problematic. If you think it makes sense to actually be in the repo, I can certainly add it (i'll be very conservative with it, limiting its options to just the indentation styles themselves and nothing else).
20161217 19:25:15-!- irker570 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161217 19:25:21< celticminstrel> GUI2 gets to three levels I think.
20161217 19:25:34< celticminstrel> eg src/gui/auxiliary/iterator
20161217 19:26:13< JyrkiVesterinen> Yes, you're right.
20161217 19:26:26< DeFender1031> celticminstrel, if there's a "unlimited depth" option, i'll just go with that (also assuming that a config in a child dir overrides that of a parent)
20161217 19:26:45< celticminstrel> From the description, it does.
20161217 19:27:23< celticminstrel> So basically, tabs for src and data/gui, spaces for data, I think.
20161217 19:27:57< celticminstrel> I guess utils probably gets spaces too.
20161217 19:28:30< celticminstrel> Not sure about the scons and cmake folders.
20161217 19:28:40< DeFender1031> question about git: is it better (for those managing master) to do unrelated things like adding these kate configs vs actual code changes in separate branches, is it better in the same branch, or does it not matter? How do branches translate to PRs? Should these be in separate PRs?
20161217 19:29:00< celticminstrel> When you open a PR, you specify its source branch.
20161217 19:29:29< celticminstrel> So if you don't have any branches, you can only have one PR open at a time.
20161217 19:30:44< DeFender1031> celticminstrel, would you mind putting together a comprehensive list of sourcedir-numberofspaces/tabs? I can go add those configs and make sure it all works right if i know what should go where, but i don't know what might be different where.
20161217 19:31:22< DeFender1031> celticminstrel, and do those who manage master tend to prefer that unrelated changes be in their own PRs?
20161217 19:31:46< celticminstrel> I think it makes sense to keep unrelated changes in separate PRs.
20161217 19:32:12< DeFender1031> okay, then that's what i'll do
20161217 19:32:13< celticminstrel> The cmake dir appears to use 2 spaces... though its indentation seems somewhat inconsistent...
20161217 19:32:38< DeFender1031> if there are directories with inconsistencies, i'd go with the majority.
20161217 19:32:57< DeFender1031> (might also be worth making those consistent)
20161217 19:33:40< celticminstrel> Python code seems to all be 4 spaces, which means the scons dir, utils dir (mostly), data/tools; WML and Lua is also 4 spaces, I think, so that covers all of data; however, GUI2 in data/gui is tabs.
20161217 19:33:52< gfgtdf> lua is tabs
20161217 19:34:12< celticminstrel> Is it?
20161217 19:34:35< gfgtdf> celticminstrel: yes at lest the tings in data/lua
20161217 19:34:42< celticminstrel> Well, Lua is in data/lua and data/ai/lua.
20161217 19:35:03< celticminstrel> The latter appears to be using spaces.
20161217 19:35:32< celticminstrel> Also data/ai/micro_ais/cas
20161217 19:35:41< celticminstrel> Which also uses spaces.
20161217 19:36:07< celticminstrel> data/ai/micro_ais/mai-defs is tabs, probably because I created that folder.
20161217 19:36:20< gfgtdf> celticminstrel: hmm i'd votefor mkaing all lua use tab
20161217 19:36:26< gfgtdf> making*
20161217 19:36:44< celticminstrel> There's also Lua in data/ai/micro_ais/engines...
20161217 19:37:02< celticminstrel> Actually, I guess data/ai/micro_ais is pretty much all Lua.
20161217 19:37:11< celticminstrel> Oh, but there's a scenarios subfolder.
20161217 19:37:12< gfgtdf> maybe we shodul ask masstc first though since he is agfaik the one who orks most with the data/ai/lua files.
20161217 19:37:23< gfgtdf> before mkaing it tabs i mean.
20161217 19:37:32< celticminstrel> I think he said once that he doesn't really care either way, but yeah, it'd be good to confirm.
20161217 19:40:26< gfgtdf> the cmakefile in src/CMakeLists.txt is also tabs. not sure if we shodul make it consitent wiht the files in the cmake dir.
20161217 19:41:22< celticminstrel> Well, from the sounds of it, Kate cannot specify different values for files within one directory.
20161217 19:41:46< celticminstrel> Which means that the SConscript will be spaces while everything else in src/ is tabs...
20161217 19:41:56< celticminstrel> At least, I'm assuming it's spaces.
20161217 19:42:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 19:42:16< gfgtdf> yes, afaik sconstript is spaces.
20161217 19:43:48< DeFender1031> like i said, just use the majority... get me a list, i'll set up the configs. You guys can worry about making it consistent.
20161217 19:43:51< celticminstrel> Some of the data/tools stuff is probably outdated and needs updating.
20161217 19:44:31< celticminstrel> This is my list so far: http://pastebin.com/Ht2cpsx4
20161217 19:45:05< celticminstrel> WFL files have a .fai extension.
20161217 19:45:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 19:45:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 19:46:07< celticminstrel> I don't suppose anyone here uses vim or emacs?
20161217 19:46:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161217 19:46:45< DeFender1031> celticminstrel, what do those have to do with this?
20161217 19:46:49< celticminstrel> Nothing.
20161217 19:46:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 19:47:00< celticminstrel> Just that I noticed related stuff in data/tools which is probably outdated.
20161217 19:47:05< DeFender1031> ah
20161217 19:47:08< DeFender1031> gotcha
20161217 19:47:21< DeFender1031> i use nano if i need a terminal-based editor, kate otherwise
20161217 19:47:35< celticminstrel> I use nano too when I need a terminal-based editor.
20161217 19:47:43< celticminstrel> Which basically means only when doing stuff over ssh.
20161217 19:50:30< celticminstrel> What's the castle-cutter for?
20161217 19:50:40< celticminstrel> Or rather, is it still used?
20161217 19:50:50< celticminstrel> Since I guess the name makes its purpose obvious.
20161217 19:51:19< celticminstrel> Even if it's still used, are the old castle/keep/encampment images really needed?
20161217 19:52:22< celticminstrel> Do we still need wmlxgettext_perl?
20161217 19:54:22< DeFender1031> for me it's either over ssh or as root. For modifying simple config files it's simpler than allowing xhost to connect and stuff
20161217 19:58:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 20:00:33-!- JyrkiVesterinen [~JyrkiVest@87-92-17-170.bb.dnainternet.fi] has quit [Quit: .]
20161217 20:04:47-!- DeFender1031 [~DeFender1@dsl217-132-62-187.bb.netvision.net.il] has quit [Remote host closed the connection]
20161217 20:07:36-!- DeFender1031 [~DeFender1@dsl217-132-62-187.bb.netvision.net.il] has joined #wesnoth-dev
20161217 20:20:26< zookeeper> vultraz, about release tomorrow... uh, yeah i guess that'd be nice. i'll have to do some testing though first.
20161217 20:23:18< DeFender1031> Found my first bit of real stupidity: https://github.com/wesnoth/wesnoth/blob/master/src/serialization/string_utils.cpp#L45
20161217 20:24:48< gfgtdf> how is that stupid?
20161217 20:25:38< DeFender1031> because isspace doesn't act any differently on mac vs. windows vs. unix
20161217 20:26:00< gfgtdf> DeFender1031: it migth depnd on locales though.
20161217 20:26:19< DeFender1031> sure, but that's not what the comment says. also, you can force a locale.
20161217 20:26:41< DeFender1031> does wesnoth use locales?
20161217 20:28:32< gfgtdf> DeFender1031: if calls setlocale if thats what you mean
20161217 20:28:39< DeFender1031> fine.
20161217 20:29:24< DeFender1031> still, this would be better as a set of 6 ||s rather than this.
20161217 20:29:57< gfgtdf> DeFender1031: yes, i agree that 6 || would be better, feel free to change it.
20161217 20:30:21< DeFender1031> "c == ' ' || c == '\t' || c == '\n' || c == '\v' || c == '\f' || c == '\r'"
20161217 20:30:28< DeFender1031> also inlining makes sense here
20161217 20:31:03< gfgtdf> DeFender1031: agree aswell.
20161217 20:31:45< DeFender1031> actually, i'm going to reorder that to put the most commonly used characters first
20161217 20:31:51< DeFender1031> but same basic idea
20161217 20:34:39-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 20:36:39< celticminstrel> Do we even need to accept \v and \f
20161217 20:36:53< celticminstrel> No-one can type those anyway, right?
20161217 20:37:32< celticminstrel> Then again it's not like it hurts to accept them.
20161217 20:38:44< DeFender1031> may as well just to be standard, but i put them at the end
20161217 20:38:59< celticminstrel> Of course.
20161217 20:39:01< DeFender1031> also, apparently you CAN customize by file, but it's not pretty:
20161217 20:39:02< DeFender1031> https://docs.kde.org/trunk5/en/applications/katepart/config-variables.html
20161217 20:39:17< DeFender1031> (meaning, the line needs to be IN the source files themselves)
20161217 20:39:28< celticminstrel> Oh.
20161217 20:39:38< DeFender1031> (which would of course confuse anyone not using kate
20161217 20:39:40< DeFender1031> )
20161217 20:39:52< DeFender1031> (unless ANOTHER comment explaining the comment was used)
20161217 20:39:56< celticminstrel> Well I suppose it could be added to the SConscript... not sure if I like that...
20161217 20:40:24< celticminstrel> I seem to recall some files had mode lines for vim or emacs or something...
20161217 20:40:34< DeFender1031> this is just about the worst way of configuring this that I can think of.
20161217 20:41:05< DeFender1031> just give me a per-session or a per-file configuration for it, and save it in some cache somewhere.
20161217 20:41:12< DeFender1031> hmm
20161217 20:41:20< DeFender1031> in general, i dislike modelines
20161217 20:41:40< DeFender1031> they clutter up code, look ugly, and only help the people using those particular tools
20161217 20:43:12< DeFender1031> that said, if people don't mind having them in the code, i can add them.
20161217 20:48:28-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 20:48:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20161217 20:52:58< DeFender1031> hmm... it doesn't seem to be working.
20161217 20:54:19-!- mjs-de [~mjs-de@x4e319200.dyn.telefonica.de] has joined #wesnoth-dev
20161217 20:59:44< DeFender1031> ah, i see the problem...
20161217 21:00:11< DeFender1031> there doesn't seem to be a way to use this to say "indent with tabs" without also specifying how wide a tab will be when displayed.
20161217 21:04:33< DeFender1031> that's really annoying. the main configuration has a setting for "tabs only", but it seems these configs only allow either "spaces" or "mixed", and, sure, you can set it to mixed, but then you need to set an indent width equal to the tab width or else it won't use exactly one tab...
20161217 21:04:49< DeFender1031> let's see on google if someone else has had this issue..
20161217 21:07:42< DeFender1031> nope... gonna join #kate and see if anyone there knows.
20161217 21:08:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 21:08:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection]
20161217 21:08:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 21:10:20< DeFender1031> the channel looks dead... i wonder if there's a more active kate channel on another server...
20161217 21:12:53< DeFender1031> if there's no way to do it without defining a display width, then i'm not going to commit, as I don't want to impose my preferred width on any other kate users who might come after me.
20161217 21:18:47-!- irker172 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161217 21:18:47< irker172> wesnoth: gfgtdf wesnoth:master 1fd6fb35dd10 / src/filesystem_boost.cpp: fix backslashes in {CURRENT_DIRECTORY} https://github.com/wesnoth/wesnoth/commit/1fd6fb35dd1031ab55f0107675b136cbaf5aadda
20161217 21:22:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 21:23:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev
20161217 21:31:27-!- Kwandulin [~Miranda@p200300760F6EBF8D182C974AF98E7D60.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161217 21:34:56-!- stikonas_ is now known as stikonas
20161217 21:39:11< DeFender1031> gfgtdf, there's actually an even simpler way: std::isspace(c, std::locale("C"))
20161217 21:41:35< gfgtdf> DeFender1031: hmm not sure thi is simpler thatn the || way, i mean with the || way its compleeley obvious when it returns true.
20161217 21:42:04< celticminstrel> Isn't std::locale() the same as std::locale("C")?
20161217 21:42:37< DeFender1031> probably
20161217 21:42:47< DeFender1031> and actually, i should use std::locale::classic()
20161217 21:43:09< DeFender1031> gfgtdf, well, it's using something built-in at least rather than adding bloat.
20161217 22:06:36< DeFender1031> https://github.com/wesnoth/wesnoth/blob/master/src/serialization/string_utils.hpp#L60 someone doesn't know how templates work...
20161217 22:07:38-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 250 seconds]
20161217 22:09:58< celticminstrel> Eh?
20161217 22:18:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161217 22:19:08< DeFender1031> celticminstrel, split() could be a templated function that builds whatever container type specified (defaulted to vector) rather than having a separate function which builds it into a vector and then unnecessarily loops through the vector and copies it into a set.
20161217 22:19:41< celticminstrel> Well, set and vector APIs are incompatible, so that would mean you need two separate implementations... but sure, it's a possibility.
20161217 22:20:06< DeFender1031> not entirely
20161217 22:20:15< DeFender1031> most of the logic could be merged
20161217 22:20:36< DeFender1031> you'd need some kind of local wrapper class for the insert
20161217 22:20:59< celticminstrel> Speaking of insert, that's one function provided by both classes...
20161217 22:21:07< celticminstrel> Though with different arguments.
20161217 22:21:13< DeFender1031> actually, in that case, it doesn't even need templates (although i'd think that split<set> is nicer than set_split())
20161217 22:21:31< DeFender1031> well yes, but still wouldn't work
20161217 22:21:38-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161217 22:21:38< DeFender1031> whatever, you'll see what i mean when i'm done with it
20161217 22:21:41< celticminstrel> split<set> would be difficult to support, as set and vector have different template arguments.
20161217 22:22:06< celticminstrel> So you can't accept both with the same template-template argument.
20161217 22:22:30< celticminstrel> But yes, I suppose I will indeed see what you mean when you're finished.
20161217 22:22:32-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161217 22:22:32-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20161217 22:27:47< DeFender1031> celticminstrel, ah, good point.
20161217 22:28:14< DeFender1031> TBH, it's been a while since i did any serious work in C++, so i've forgotten a lot of the stuff that i used to know offhand
20161217 22:29:22< celticminstrel> I think it's possible in the later standards (that we don't support).
20161217 22:29:28< celticminstrel> But that's not very helpful.
20161217 22:30:25< DeFender1031> maybe, but after you pointed that out, I'm no longer planning on templatifying them
20161217 22:30:55< DeFender1031> or rather, i'm planning on templatifying split() so that any compatible container will work
20161217 22:31:03< DeFender1031> (obviously, still defaulting to vector)
20161217 22:31:12< gfgtdf> but not set?
20161217 22:31:14< DeFender1031> but i'll leave the set one as as separate function
20161217 22:31:29< gfgtdf> i wonder what other container than vector woudl that match ?
20161217 22:31:31-!- mjs-de [~mjs-de@x4e319200.dyn.telefonica.de] has quit [Remote host closed the connection]
20161217 22:31:36< DeFender1031> i will, however, be wrapping both to the same helper function internally
20161217 22:31:41< celticminstrel> gfgtdf: list, forward_list, deque
20161217 22:31:50< gfgtdf> do we ever use them with those containers
20161217 22:31:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection]
20161217 22:31:58< celticminstrel> (Not 100% sure on forward_list)
20161217 22:32:01< celticminstrel> gfgtdf: No idea!
20161217 22:32:12< DeFender1031> gfgtdf, if all that's being used is push_back, then shouldn't everything match?
20161217 22:32:29< celticminstrel> There may be decent reasons to use deque instead of vector in some places. I dunno.
20161217 22:32:38< celticminstrel> I'm not sure whether forward_list has push_back or push_front.
20161217 22:32:47< gfgtdf> by common helper functions you mean that set_plit will no onger create a temporary vector ?
20161217 22:33:15< DeFender1031> gfgtdf, that's right
20161217 22:33:22< DeFender1031> it'll load a set directly
20161217 22:33:27< celticminstrel> I dunno if it's useful for set_split to be able to produce unirdered_set either...
20161217 22:33:36< celticminstrel> ^unordered
20161217 22:34:11< DeFender1031> whatever, when you see how i'm doing this, it'll be clear how to expand it.
20161217 22:34:46< DeFender1031> oh, and i plan to set up all the various split functions the same way, obviously.
20161217 22:34:58< DeFender1031> actually, it may still be possible to template this...
20161217 22:35:18< DeFender1031> whatever, i'm going to look into the options here ad get back to you guys.
20161217 22:35:37< DeFender1031> i should actually probably go to sleep relatively soon and pick this up on thursday
20161217 22:35:59< DeFender1031> but whatever, nice to be making progress and actually diving into the code for a change.
20161217 22:36:40< DeFender1031> ugh, compiling takes FOREVER
20161217 22:39:46< DeFender1031> ah, make -j8 helps
20161217 22:39:56< vultraz> of course :)
20161217 22:40:50< DeFender1031> but not much
20161217 22:41:05< DeFender1031> using -j without a number goes flying but locks up my system
20161217 22:41:12< DeFender1031> need to find the right balance here,
20161217 22:42:42< DeFender1031> ah, and eventually crashed the make when it uses all my RAM.
20161217 22:42:53< DeFender1031> crashes*
20161217 22:43:32< DeFender1031> i would have expected it to have smarter heuristics than just "literally run everything"
20161217 22:44:27-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 22:45:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161217 22:46:00< DeFender1031> how do you guys work like this? I made one set of changes and it's taking several minutes to compile
20161217 22:46:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 22:46:21< DeFender1031> (even while running 32 jobs at once)
20161217 22:46:27< celticminstrel> 32 jobs o.o
20161217 22:47:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161217 22:47:08< celticminstrel> But yeah, it takes time to compile.
20161217 22:47:40< celticminstrel> I don't know if there's anything that can be done about this.
20161217 22:48:06< celticminstrel> There are a lot of files, after all.
20161217 22:48:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 22:48:44< DeFender1031> celticminstrel, yeah, 32 is actually running, though I won't do this consistently, as it's using around 20gb of RAM
20161217 22:48:53< DeFender1031> i'll probably stick to 8 or 16
20161217 22:49:20< vultraz> j should be equal to your cores (including virtual ones)
20161217 22:49:38< DeFender1031> well, the only thing to do would be to optimize all the code and cut out cruft and bloat all over, which is what we're all trying to do anyway
20161217 22:49:48< vultraz> yes
20161217 22:50:09< celticminstrel> Speaking of cruft and bloat, maybe src/strftime can be removed?
20161217 22:50:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20161217 22:50:59< DeFender1031> vultraz, equal to cores, you say? I figured running a couple on each core would be better
20161217 22:51:14< vultraz> o_O
20161217 22:51:17< DeFender1031> (bear in mind, i know very little about hardware)
20161217 22:51:19< vultraz> dat processing power
20161217 22:51:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 22:51:29< DeFender1031> vultraz, what processing power?
20161217 22:51:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 22:51:49< DeFender1031> oh, 32 isn't "a couple on each core"
20161217 22:52:05< DeFender1031> i was just curious how many it'd be able to run at once
20161217 22:52:13< DeFender1031> i only have 4 cores.
20161217 22:52:19< DeFender1031> tons of RAM though
20161217 22:52:27< DeFender1031> ooh, compile's done.
20161217 22:52:58< DeFender1031> is there any practical reason to have a separate build directory?
20161217 22:53:16< vultraz> I assume you have a 4-core cpu? (so, 8 functional cores?)
20161217 22:54:25< irker172> wesnoth: Charles Dang wesnoth:master 28d56206bc3e / / (4 files in 3 dirs): Removed strftime.*pp https://github.com/wesnoth/wesnoth/commit/28d56206bc3e1907686b7fd8dc6b5220dd889467
20161217 22:55:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 22:55:37-!- vultraz changed the topic of #wesnoth-dev to: 1.13.7 scheduled for sometime in the new year | Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161217 22:57:26< celticminstrel> Blah, discord.
20161217 22:57:35< vultraz> assuming no change of plans I won't be around tomorrow to coordinate a release.
20161217 22:57:45< DeFender1031> vultraz, 4 core, yeah
20161217 22:57:55< DeFender1031> vultraz, what do you mean by "8 functional"?
20161217 22:58:11< DeFender1031> yay! my first local commit!
20161217 22:58:12< vultraz> 4 + 4 virtual.
20161217 22:58:19< vultraz> = 8 "cores"
20161217 22:58:20< celticminstrel> Yay!
20161217 22:58:23< vultraz> meaning -j8
20161217 22:58:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 22:58:33< DeFender1031> vultraz, i don't think i have any virtual cores... what are those and how does one enable them and what are they good for?
20161217 22:58:39< celticminstrel> Do you have a github account yet by the way?
20161217 22:58:44< DeFender1031> celticminstrel, of course
20161217 22:58:50< vultraz> DeFender1031: what is your cpu?
20161217 22:58:50< celticminstrel> And a Wesnoth fork?
20161217 22:58:57< DeFender1031> vultraz, phenom II
20161217 22:59:01< vultraz> oh
20161217 22:59:08< vultraz> well then no, you probably don't
20161217 22:59:11< vultraz> j4 then it is
20161217 22:59:20< DeFender1031> vultraz, it's funny, it was top-of-the-line when i got it, but now it's the oldest piece of harware in this rig.
20161217 22:59:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161217 22:59:47< vultraz> DeFender1031: virtual cores are a feature found in intel I- series CPUs
20161217 22:59:57< vultraz> it essentially doubles the functional number of cores you have.
20161217 23:00:02< vultraz> so I have a dual-core i5
20161217 23:00:08< vultraz> but have 4 functional cored
20161217 23:00:10< vultraz> cores
20161217 23:01:19< DeFender1031> ahhh
20161217 23:01:59< DeFender1031> i just realized that my computer is almost a ship of theseus. aside from the case, the processor is literally the only original piece left
20161217 23:02:28 * celticminstrel has an i7 with "8 CPUs", not sure if that's counting the virtual ones or not.
20161217 23:05:13< DeFender1031> celticminstrel, sounds like it
20161217 23:05:51< DeFender1031> now i need to figure out how to set up push access for my github fork
20161217 23:06:02< DeFender1031> and later i'll need to figure out how to make a pull request
20161217 23:06:08< celticminstrel> Something like, "git remote add" ... I forget the proper params.
20161217 23:06:14< zookeeper> well there are i7's with 8 cores
20161217 23:06:50< DeFender1031> celticminstrel, i was just going to change the push destination in my existing config, as i can't currently push to master, it makes sense to just pull from master and push to my fork.
20161217 23:06:55< celticminstrel> Task Manager shows 8.
20161217 23:07:05< celticminstrel> DeFender1031: Sure whatever
20161217 23:07:19< DeFender1031> i meant the part about the ssh keys
20161217 23:07:26< celticminstrel> Oh that.
20161217 23:07:40< celticminstrel> You can do without the ssh keys if you have to, but it certainly is more convenient to use them.
20161217 23:07:45< DeFender1031> i know
20161217 23:08:03< DeFender1031> crap, i'mot even sure i remember the password i set up for GH...
20161217 23:08:12< DeFender1031> might need to do a reset
20161217 23:09:19< DeFender1031> i can't wait until U2F keys become standard and I can use weaker, easier to remember passwords again.
20161217 23:09:31< celticminstrel> U2F?
20161217 23:09:50< DeFender1031> https://en.wikipedia.org/wiki/Universal_2nd_Factor
20161217 23:10:05 * celticminstrel tries to use phrase passwords since seeing that xkcd, though some ot them still aren't.
20161217 23:10:11< celticminstrel> ^of
20161217 23:10:29< DeFender1031> it's basically a self-contained encryption cpu that you can't get the key out of and that is required to be physically plugged into the computer in order to authenticate
20161217 23:11:12< pydsigner> I need to order my Yubikey
20161217 23:11:19< DeFender1031> celticminstrel, the problem with the xkcd is that it oversimplifies the problem, and the "four random words" thing fails terribly when exposed to dictionary attacks.
20161217 23:11:28< matthiaskrgr> /home/matthias/vcs/github/wesnoth_gcc/src/format_time_summary.cpp:20:24: fatal error: strftime.hpp: No such file or directory
20161217 23:11:34< DeFender1031> pydsigner, my day job just ordered three of them for each dev.
20161217 23:12:14< matthiaskrgr> vultraz:  ^ ? 
20161217 23:12:33< celticminstrel> Silly vultraz.
20161217 23:12:45< matthiaskrgr> ._.
20161217 23:13:10< celticminstrel> DeFender1031: Well, that's obvious if you think about it, sure.
20161217 23:13:50-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161217 23:14:16< celticminstrel> But having more than one dictionary word does greatly increase the time you'd need to guess it IIUC.
20161217 23:15:13< DeFender1031> celticminstrel, a colleague of mine says that the best way to get a password is to take a phrase from some book you like in some language that doesn't use the roman alphabet, transliterate it, and replace any mention of a number with the actual number. (This of course depends on one being multilingual with such a language, but whatever.)
20161217 23:15:37< celticminstrel> Interesting idea.
20161217 23:15:45< DeFender1031> s/phrase/sentence
20161217 23:15:58< celticminstrel> Obviously using non-dictionary words helps a lot.
20161217 23:16:04< DeFender1031> exactly
20161217 23:16:40< celticminstrel> I think most of my important ones have some non-dictionary words.
20161217 23:16:46< celticminstrel> Or at least rare words.
20161217 23:17:00< celticminstrel> (Like obscure place-names and such.)
20161217 23:17:43< DeFender1031> celticminstrel, "thereOnceWasALadyFr0mChatanooga"?
20161217 23:17:50< celticminstrel> Finding a sentence that mentions a number seems like it'd be hard though. :P
20161217 23:17:54< celticminstrel> Uh sure?
20161217 23:18:27< DeFender1031> celticminstrel, nevermind. Apparently it wasn't as funny as I expected it to be.
20161217 23:18:46-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161217 23:18:48< DeFender1031> celticminstrel, depends on where you're sourcing from...
20161217 23:18:56 * celticminstrel is pretty sure that references a limerick, but I can't remember the actual one.
20161217 23:19:36< zookeeper> you don't have nonsense words or unguessable combinations of words floating in your mind that you can use for passwords? :p
20161217 23:19:40< DeFender1031> celticminstrel, religious texts for example are wonderful. "653 from this tribe, and 727 from that tribe fought against the 5000 men from this nation" etc.
20161217 23:19:54< celticminstrel> zookeeper: Maaaybe?
20161217 23:20:09< DeFender1031> celticminstrel, I actually don't know of any limeric that starts quite like that, but I'd sure like to hear the end of it :P
20161217 23:21:01< DeFender1031> zookeeper, nonsense words, hmm?
20161217 23:21:11< celticminstrel> I guess it's a bit different: https://en.wikisource.org/wiki/There_was_a_Young_Lady_of_Hull
20161217 23:21:17< DeFender1031> the other problem is the sheer number of different passwords you need in the modern age.
20161217 23:22:07< celticminstrel> For awhile I was using the same password everywhere. Then I started using a different one just for "important" places, which mainly means places that store financial information.
20161217 23:22:24< DeFender1031> every site has its own login, so you either compromise yourself by using the same one on multiple sites or compromise yourself by writing them down or using some kind of password management system.
20161217 23:23:14< irker172> wesnoth: Wedge009 wesnoth:master 7ff076b890bc / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project. https://github.com/wesnoth/wesnoth/commit/7ff076b890bc4a45287a9a213f9ff5afcc8c4117
20161217 23:24:03< pydsigner> There was a lady of Chatanooga/Who desired to take ship for Aruba/When her attempts were denied/She stepped out to the tide/And embarked on a simple Beluga
20161217 23:24:23< pydsigner> There, it exists now
20161217 23:24:25< DeFender1031> the big sites like facebook and google try to mitigate this somewhat by allowing sites to use OAuth to log in using those accounts, except that OAuth 2.0 has so many issues with it that it's not all that much better than using the same password everywhere.
20161217 23:24:29< celticminstrel> XCode project needs updating again...
20161217 23:24:33< zookeeper> DeFender1031, well, hard to explain when i can't exactly give any examples. some kind of phoneticizations or morphing of words into weird imaginary forms. written like that, it sounds weirder than it is though. i just mean the normal kind of mangling people might do for fun or as a joke or whatever.
20161217 23:24:40< celticminstrel> XD
20161217 23:24:51< DeFender1031> pydsigner, i had been things "Beluga" had to be in there somewhere :P
20161217 23:24:58< DeFender1031> s/things/thinking
20161217 23:24:59< celticminstrel> The metre seems slightly off though.
20161217 23:25:07< pydsigner> celticminstrel: Yes
20161217 23:25:23< DeFender1031> celticminstrel, it's off on the first line that i came up with even.
20161217 23:25:27< pydsigner> But Chatanooga will do that to you
20161217 23:25:33< celticminstrel> Well yes, it was indeed.
20161217 23:26:31< zookeeper> i have like 60+ entries in my password manager. a lot of unimportant logins for random forums or whatever use the same password or simple variations, but there's no way i could cope without a password manager of some kind.
20161217 23:27:02< DeFender1031> zookeeper, right, but that makes your password manager your single point of failure
20161217 23:27:08< zookeeper> sure
20161217 23:27:28< zookeeper> kinda hard to do anything about that
20161217 23:27:46< DeFender1031> well, that's where the U2F keys come in.
20161217 23:28:12< celticminstrel> ...the linked limerick also actually seems to have the meter slightly off?
20161217 23:28:27< DeFender1031> they provide an additional verification item which is far more secure than any password you could remember yourself, and turn any single point of failure into a double-layer of security
20161217 23:28:36< DeFender1031> unfortunately, they're not widely supported yet.
20161217 23:28:38< celticminstrel> Sounds like a good idea.
20161217 23:28:57-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20161217 23:28:57< celticminstrel> I haven't enabled Goodle's two-factor because I don't feel like giving them my phone number.
20161217 23:29:03< pydsigner> celticminstrel: Limerick writers seem to like taking liberties with meter
20161217 23:29:10< zookeeper> DeFender1031, so it's, say, a physical usb key?
20161217 23:29:11< celticminstrel> I've enabled email-based two-factors, though.
20161217 23:29:15-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20161217 23:29:17< travis-ci> wesnoth/wesnoth#12448 (master - 28d5620 : Charles Dang): The build was broken.
20161217 23:29:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184846362
20161217 23:29:17-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20161217 23:29:22< pydsigner> Since the basic pattern is pretty obvious and the whole point is to be funny anyways
20161217 23:29:34< celticminstrel> Fair enough, I guess.
20161217 23:30:36< pydsigner> I didn't even get proper rhyme with "Chatanooga/Aruba/Beluga"
20161217 23:30:44< DeFender1031> zookeeper, yep
20161217 23:30:58< celticminstrel> It's impossible to fit "Chatanooga" into a limerick, because it has four syllables, so you'd need to either stress the first and last or one of the other two.
20161217 23:31:10< zookeeper> DeFender1031, so what happens if i lose it?
20161217 23:31:15< zookeeper> or if it breaks
20161217 23:31:16< celticminstrel> Assuming strict metre, of course.
20161217 23:31:29< celticminstrel> You could elide the second syllable, I guess.
20161217 23:32:23< DeFender1031> celticminstrel, my issue with phone-based two factor is that the times when it applies are when you sign in from an unrecognized device, which most often happens while traveling, which is also often when you don't have access to your usual phone network.
20161217 23:32:29-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161217 23:32:29-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161217 23:32:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161217 23:33:03< celticminstrel> vultraz! You broke it!
20161217 23:33:06< DeFender1031> zookeeper, you can have more than one and set them all up to work with your accounts.
20161217 23:33:26< celticminstrel> DeFender1031: What if they all break?
20161217 23:33:59< DeFender1031> celticminstrel, presumably, you'd have one for regular use and a backup in a safe somewhere, and if the first one breaks, you replace it immediately.
20161217 23:34:08< DeFender1031> celticminstrel, presumably they won't all break at once.
20161217 23:34:36< zookeeper> ok, so you're screwed if they all break, but you can have as many copies as you want
20161217 23:34:38< celticminstrel> True.
20161217 23:35:08< zookeeper> which is, i suppose, fine
20161217 23:35:11< DeFender1031> the thing is that all authentication is inherently based on something you know (like a password), something you have (like a key) or something you are (like a retina)
20161217 23:35:30< DeFender1031> i suppose DNA is more apt for the last one but whatever.
20161217 23:35:45< DeFender1031> the point is that it supplements "what you know" security with "what you have" security
20161217 23:36:05< celticminstrel> I'm not sure if an email really counts as "something you have" though.
20161217 23:36:11< DeFender1031> zookeeper, it's not QUITE copies. each one contains its own hardwired key
20161217 23:36:46< DeFender1031> zookeeper, you'd have to authorize each key separately to an account
20161217 23:36:52< zookeeper> right
20161217 23:36:55< DeFender1031> celticminstrel, an email?
20161217 23:36:58< zookeeper> and you need a password for that account? :P
20161217 23:37:08< celticminstrel> DeFender1031: SteamGuard
20161217 23:37:09< celticminstrel> For example
20161217 23:37:36< celticminstrel> (This is again only with unrecognized devices though.)
20161217 23:37:38-!- louis94 [~~louis94@91.178.242.25] has joined #wesnoth-dev
20161217 23:37:43< DeFender1031> zookeeper, presumably yes. (Actually, IIRC i think the protocol involves encrypting the password, so almost certainly yes.)
20161217 23:38:09< DeFender1031> celticminstrel, yeah, an email is generally a something you know (your email password)
20161217 23:38:22< DeFender1031> celticminstrel, although email is really rather insecure as an authentication device
20161217 23:41:10-!- ToBeCloud [uid51591@gateway/web/irccloud.com/x-fbsxrifztyaapecp] has joined #wesnoth-dev
20161217 23:41:14-!- ToBeCloud is now known as Guest38629
20161217 23:44:14-!- Guest38629 [uid51591@gateway/web/irccloud.com/x-fbsxrifztyaapecp] has quit [Client Quit]
20161217 23:45:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161217 23:45:46< DeFender1031> Oh yeah, some of the keys even have yet another step which is that you have to punch in a code on them in order to use them.
20161217 23:46:08< DeFender1031> i think some even have a self-destruct code.
20161217 23:53:29< DeFender1031> Like I said, password-based security has become untenable in today's day and age.
20161217 23:55:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161217 23:55:19< vultraz> celticminstrel: ?
20161217 23:55:37< vultraz> oh
20161217 23:55:38< celticminstrel> Hi matthiaskrgr 
20161217 23:55:38< vultraz> fuck
20161217 23:55:45< celticminstrel> mattsc I mean
20161217 23:55:55< matthiaskrgr> :( 
20161217 23:56:17< mattsc> hi matthiaskrgr 
20161217 23:56:31< matthiaskrgr> :D
20161217 23:56:44< matthiaskrgr> hi everyone ^^
20161217 23:56:46< mattsc> celticminstrel, gfgtdf: indeed, I do not care about tabs vs. spaces, as long as it’s done consistently.
20161217 23:56:51< celticminstrel> mattsc: Are you able to update the XCode project?
20161217 23:57:17< mattsc> celticminstrel: possibly, not right this moment though; I’ll try in a little while
20161217 23:57:17< celticminstrel> Preferably after vultraz's next commit (assuming you want a successful build).
20161217 23:57:30< celticminstrel> If you do, there are also some headers in I think src/utils that should be added.
20161217 23:57:32< mattsc> successful builds are nice
20161217 23:57:46< mattsc> ok
20161217 23:59:47< mattsc> gfgtdf: FYI, at the moment I have a script running over the irc logs once a day or so that greps for my nick and a couple other things.  So I only saw your message (with misspelled nick) accidentally because I also grep for ‘ai’.  Otherwise I would have missed it.
--- Log closed Sun Dec 18 00:00:40 2016