--- Log opened Sun Dec 18 00:00:40 2016 20161218 00:00:45< DeFender1031> hey mattsc 20161218 00:00:51< irker172> wesnoth: Charles Dang wesnoth:master 76cfdd589de9 / src/format_time_summary.cpp: Removed strftime.hpp include (fixup 28d56206bc3e) https://github.com/wesnoth/wesnoth/commit/76cfdd589de99f9fbd134ddc96f06ed797934f74 20161218 00:03:26< mattsc> Hi DeFender1031 20161218 00:07:25< vultraz> why are all the sources_list files just files 20161218 00:07:29< vultraz> no extension 20161218 00:08:30< DeFender1031> mattsc, i caved and finally started working on the actual source. 20161218 00:09:01< mattsc> DeFender1031: Cool! Any specific aspect of it? 20161218 00:09:27< DeFender1031> currently i'm rewriting string_utils.cpp because the code there is rather terrible. 20161218 00:09:45< DeFender1031> (Started with finding one bug and then looking at the code and realizing what a mess it was) 20161218 00:10:24< DeFender1031> (vult was the one who pointed out how terrible the code is and asked if I wanted to fix it IIRC) 20161218 00:10:43< irker172> wesnoth: Charles Dang wesnoth:master fc91f5df10f9 / / (7 files in 5 dirs): GUI2: initial basic implementation of a GUI2 Attack Predictions dialog (WIP) https://github.com/wesnoth/wesnoth/commit/fc91f5df10f91531a5cab5bc0fc208261a410ca1 20161218 00:12:19< mattsc> DeFender1031: Nice. You doing it, not the mess, I mean. As for me, I really only venture into the C++ code when I can’t convince somebody else to fix a certain bug that I want fixed. ;) 20161218 00:13:02< DeFender1031> mattsc, i know, you're a mathy-type :P 20161218 00:13:52< DeFender1031> mattsc, well, the mess is kinda nice too... it's a small, relatively isolated file and allows me to get into it without having too much unfamiliar terrain. 20161218 00:15:03< mattsc> right; and that sounds pretty good actually 20161218 00:16:39< mattsc> The little time I have for Wesnoth at the moment I am spending on trying to turn my biggest failure into not quite so big a failure. (That would be my ‘Fred’ AI.) It’s not going anywhere fast though. 20161218 00:17:49< DeFender1031> Who's "Fred"? 20161218 00:18:30-!- stikonas_ is now known as stikonas 20161218 00:19:41< mattsc> The AI formerly known as the Grunt Rush on Freelands. 20161218 00:20:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20161218 00:20:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 00:21:00< DeFender1031> what's it supposed to do? 20161218 00:22:16< mattsc> My main goal is to have an AI that is a bit better at playing defensively and use the terrain. 20161218 00:23:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20161218 00:23:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 00:26:18< mattsc> celticminstrel: All I had to do for Xcode to compile was removing 3 files. Is that all you need me to do? 20161218 00:26:31< mattsc> And is the commit by vultraz you were talking about? 20161218 00:26:36< mattsc> * fc91f5df10f9 20161218 00:39:04< irker172> wesnoth: Charles Dang wesnoth:master edfe69f33634 / src/gui/dialogs/multiplayer/mp_options_helper.cpp: MP Options Helper: iterate over options data by reference https://github.com/wesnoth/wesnoth/commit/edfe69f336344755514896581530532c89ee40a3 20161218 00:42:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 00:42:26< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 76cfdd5: Removed strftime.hpp include (fixup 28d56206bc3e) Succeeded 20161218 00:42:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-53 20161218 00:42:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 00:45:28-!- louis94 [~~louis94@91.178.242.25] has quit [Ping timeout: 245 seconds] 20161218 00:46:16< mattsc> Ah, now it’s failing … 20161218 00:52:33< irker172> wesnoth: mattsc wesnoth:master 15b8fd1deaa6 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/15b8fd1deaa6a50eb6654c4a6667865a231a3115 20161218 00:52:41-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection] 20161218 00:56:17-!- Aginor [~andreas@unaffiliated/aginor] has quit [Ping timeout: 252 seconds] 20161218 00:59:45-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 00:59:46< travis-ci> wesnoth/wesnoth#12449 (master - 76cfdd5 : Charles Dang): The build was fixed. 20161218 00:59:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184854453 20161218 00:59:46-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 01:02:39< celticminstrel> mattsc: There are some files to add. 20161218 01:02:57< celticminstrel> I think they're all in src/utils and are header files. 20161218 01:03:20< celticminstrel> XCode can still compile if a header file is not explicitly included in the project, but it's more convenient if they are included. 20161218 01:04:09< celticminstrel> The vultraz commit I spoke of was 76cfdd589de9, the one before the one you mentioned. 20161218 01:05:42< celticminstrel> vultraz: Ask pentarctagon about the source_lists, I guess. 20161218 01:06:42< irker172> wesnoth: mattsc wesnoth:master d02d14553354 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Xcode project: add some more header files https://github.com/wesnoth/wesnoth/commit/d02d1455335444454ff4646529ff7833c88a7ecd 20161218 01:06:47< mattsc> celticminstrel: ^ 20161218 01:06:53-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 01:06:53< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 76cfdd5: Removed strftime.hpp include (fixup 28d56206bc3e) Succeeded 20161218 01:06:53< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-53 20161218 01:06:57-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 01:07:11< mattsc> celticminstrel: define “more convenient” (I’m asking out of curiosity, not as an argument) 20161218 01:08:39< celticminstrel> I'm not sure how to describe it well... one thing is that if you jump to something declared there, XCode recognizes that it's part of your project, and possibly omitting it might hurt the indexing... 20161218 01:10:33< mattsc> okay, that makes sense 20161218 01:11:52< mattsc> I’m off again then. 20161218 01:12:26< mattsc> Just ping me if there’s something else, I usually see it within less than 24 hours (often much less than that). 20161218 01:12:31< mattsc> Cheers, everybody. 20161218 01:13:17< celticminstrel> Okay. 20161218 01:13:21< celticminstrel> Bye. 20161218 01:13:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20161218 01:19:33-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 01:19:34< travis-ci> wesnoth/wesnoth#12450 (master - fc91f5d : Charles Dang): The build is still failing. 20161218 01:19:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184855730 20161218 01:19:34-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 01:19:44< celticminstrel> :( 20161218 01:20:33< celticminstrel> ...wait, why is that error only appearing now? 20161218 01:20:57< celticminstrel> The code erroring has been there since my big rename. 20161218 01:26:17< vultraz> no? 20161218 01:26:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20161218 01:26:59< celticminstrel> No what? 20161218 01:27:08< vultraz> that's my code 20161218 01:27:10< vultraz> in the new dialog 20161218 01:27:21< celticminstrel> "const combatant& combatant"? 20161218 01:27:25< celticminstrel> Oh, okay. 20161218 01:31:58-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 01:31:58< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang edfe69f: MP Options Helper: iterate over options data by reference Failed 20161218 01:31:58< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-54 20161218 01:32:02-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 01:38:18< celticminstrel> So uh, are you going to fix it? All you need to do is change the name of the variable. 20161218 01:46:32-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 01:46:33< travis-ci> wesnoth/wesnoth#12451 (master - edfe69f : Charles Dang): The build has errored. 20161218 01:46:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184859262 20161218 01:46:33-!- travis-ci [~travis-ci@ec2-54-160-175-240.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 01:54:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 01:54:17< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang edfe69f: MP Options Helper: iterate over options data by reference Failed 20161218 01:54:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-54 20161218 01:54:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 01:57:05< irker172> wesnoth: Charles Dang wesnoth:master 4629990dec1a / src/gui/dialogs/ (attack_predictions.cpp attack_predictions.hpp): Attack Predictions: fixup variable names shadowing type names https://github.com/wesnoth/wesnoth/commit/4629990dec1afa5191bc458211715a4f9fc051aa 20161218 02:06:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20161218 02:11:48-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 02:11:49< travis-ci> wesnoth/wesnoth#12452 (master - 15b8fd1 : mattsc): The build is still failing. 20161218 02:11:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184860405 20161218 02:11:49-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 02:17:50-!- gfgtdf [~chatzilla@78.54.141.224] has quit [Read error: Connection reset by peer] 20161218 02:33:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV] 20161218 02:34:57-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 02:34:58< travis-ci> wesnoth/wesnoth#12453 (master - d02d145 : mattsc): The build was broken. 20161218 02:34:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184861718 20161218 02:34:58-!- travis-ci [~travis-ci@ec2-54-92-211-92.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 02:40:13< celticminstrel> Why does it say "broken" instead of "still failing"... 20161218 02:40:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161218 02:41:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev 20161218 02:49:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection] 20161218 02:56:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161218 03:18:17-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 03:18:18< travis-ci> wesnoth/wesnoth#12454 (master - 4629990 : Charles Dang): The build has errored. 20161218 03:18:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184865807 20161218 03:18:18-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 03:56:12-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 04:35:13-!- Appleman1234 [~Appleman1@KD106161201131.au-net.ne.jp] has quit [Ping timeout: 258 seconds] 20161218 04:36:06-!- Appleman1234 [~Appleman1@KD106161204235.au-net.ne.jp] has joined #wesnoth-dev 20161218 04:39:49-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 05:06:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20161218 05:21:54-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev 20161218 05:23:25-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161218 05:26:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer] 20161218 05:26:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20161218 05:28:14-!- irker172 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20161218 05:32:00-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection] 20161218 05:44:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20161218 05:48:28-!- Nikitaw99 [~Nikitaw99@ppp85-140-0-107.pppoe.mtu-net.ru] has joined #wesnoth-dev 20161218 06:04:51< vultraz> celticminstrel: assuming no change of plans on my part, you're in charge while im gone. 20161218 06:05:04< celticminstrel> 'kay 20161218 06:05:15< celticminstrel> In that case I guess I'll merge a few things. 20161218 06:05:19< celticminstrel> Or something. 20161218 06:06:50< celticminstrel> Oh right, I remembered why I didn't yet merge that PR. 20161218 06:06:57< celticminstrel> I was hoping he'd move the file for us. >_> 20161218 06:12:37< vultraz> no release tomorrow, sadly, since by tomorrow I had meant today. 20161218 06:12:52< celticminstrel> ? 20161218 06:13:07< vultraz> zookeeper said he was still considering a release "tomorrow" 20161218 06:13:56 * celticminstrel confused 20161218 06:14:16< vultraz> bottom line: no releases until the new year 20161218 06:29:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 06:40:55-!- Kwandulin [~Miranda@p200300760F6EBF6DF4C1D2B964CBC2ED.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161218 07:18:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Permission denied] 20161218 07:19:14-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20161218 07:32:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20161218 07:47:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20161218 07:48:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20161218 08:33:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 08:33:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 08:33:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-54 20161218 08:33:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 08:57:10-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 08:57:10< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 08:57:10< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-54 20161218 08:57:14-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 09:21:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer] 20161218 09:21:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20161218 09:22:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 09:22:43< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 09:22:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-55 20161218 09:22:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 09:44:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 09:44:17< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 09:44:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-55 20161218 09:44:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 09:44:32-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 09:46:50-!- Nikitaw99 [~Nikitaw99@ppp85-140-0-107.pppoe.mtu-net.ru] has quit [Ping timeout: 264 seconds] 20161218 09:49:48-!- mjs-de [~mjs-de@x4e312ff9.dyn.telefonica.de] has joined #wesnoth-dev 20161218 10:15:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20161218 10:28:29-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has joined #wesnoth-dev 20161218 10:40:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev 20161218 11:00:06-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV] 20161218 12:05:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 12:07:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: leaving] 20161218 12:10:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 256 seconds] 20161218 12:30:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev 20161218 12:52:16-!- Kwandulin [~Miranda@p200300760F6EBF6DF4C1D2B964CBC2ED.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161218 13:04:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 13:18:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20161218 13:19:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 13:20:12< DeFender1031> is there any practical reason to have a separate build directory? (I asked last night, but it got lost in the rest of the conversation.) 20161218 13:21:57-!- JyrkiVesterinen [~JyrkiVest@78-27-119-209.bb.dnainternet.fi] has joined #wesnoth-dev 20161218 13:22:27< JyrkiVesterinen> DeFender1031: The primary advantage is that you can have multiple build directories with different build settings. 20161218 13:22:59< JyrkiVesterinen> For example, in one directory you can enable the UBSan (undefined behavior sanitizer). 20161218 13:26:02< DeFender1031> what's that? 20161218 13:26:50< JyrkiVesterinen> http://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html 20161218 13:27:25< JyrkiVesterinen> GCC has its own implementation as well. I don't know if GCC 4.8 has it, though. 20161218 13:27:29< JyrkiVesterinen> 4.8 is ancient. 20161218 13:33:41-!- irker814 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20161218 13:33:41< irker814> wesnoth: Jyrki Vesterinen wesnoth:grid-size-control 3442101f90ac / src/gui/widgets/container_base.cpp: container_base: query default size instead of minimum size https://github.com/wesnoth/wesnoth/commit/3442101f90ac1601d29eee163054a4519cbb9644 20161218 13:33:55< DeFender1031> I'm on 4.9 20161218 13:34:13< JyrkiVesterinen> Well, it's not much newer. 20161218 13:39:54< DeFender1031> I remember when GCC 4.0 was new. 20161218 14:32:05-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 14:32:06< travis-ci> wesnoth/wesnoth#12455 (grid-size-control - 3442101 : Jyrki Vesterinen): The build has errored. 20161218 14:32:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184930057 20161218 14:32:06-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 14:35:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20161218 14:35:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 14:37:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20161218 14:38:19-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 14:38:19-!- stikonas_ is now known as stikonas 20161218 15:25:20-!- Kwandulin [~Miranda@p200300760F6EBF6DBC00FF6D0B47A9AD.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161218 16:33:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 16:35:41-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 16:35:41< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 16:35:41< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-55 20161218 16:35:45-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 16:45:15-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 16:59:18-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 16:59:18< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 16:59:18< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-55 20161218 16:59:23-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 17:01:13< irker814> wesnoth: ln-zookeeper wesnoth:master fd34c289fdeb / data/core/units/undead/Necro_Lich.cfg: Fixed Lich's broken idle animation https://github.com/wesnoth/wesnoth/commit/fd34c289fdebc67fbb066abca30437e478252c8c 20161218 17:01:34< zookeeper> only took almost 4 years to get that fixed 20161218 17:01:58< zookeeper> i guess people really don't care about those animations? :p 20161218 17:04:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20161218 17:17:05< DeFender1031> heh 20161218 17:17:55< irker814> wesnoth: ln-zookeeper wesnoth:master c3ed1c75aa16 / data/core/units/undead/Necro_Ancient_Lich.cfg: Added Lich's idle animation to Ancient Lich as well https://github.com/wesnoth/wesnoth/commit/c3ed1c75aa1603b143073204ce17dd6087efbbe8 20161218 17:18:18< DeFender1031> zookeeper, in all seriousness though, I feel like certain animations and the lack thereof are noticed more than others. Top of the list is attack animations. If there's no attack animation, people will notice. I think idle is pretty close to the bottom of the list. 20161218 17:18:47< DeFender1031> defend and death are closer to the top, movement is closer to the bottom. 20161218 17:19:07< zookeeper> well i noticed it in 2014 already, i just forgot about it 20161218 17:19:11< DeFender1031> and of course, different nimations for all six directions is near the bottom. 20161218 17:19:31< DeFender1031> zookeeper, how is 2016-2014=4? 20161218 17:19:42< zookeeper> because it was added in early 2013 20161218 17:19:50< zookeeper> s/added/broken 20161218 17:19:53< DeFender1031> I can see at most 3, since we're near the end of the yea-ah 20161218 17:20:08< DeFender1031> oh, you NOTICED in 2014, but it's BEEN THERE since 2013, got it. 20161218 17:22:34< celticminstrel> So I guess I should just merge 903 now and move tag.?pp myself. 20161218 17:23:35< celticminstrel> Unless of course someone thinks these tools shouldn't be deleted. 20161218 17:23:50< celticminstrel> But no-one has said anything yet, so. 20161218 17:25:02< zookeeper> is there some reason to delete them and not just stash them somewhere where they're not in anyone's way? 20161218 17:25:18< zookeeper> i don't know whether they might contain some useful historical tidbits or something 20161218 17:25:30< celticminstrel> Well, technically, there's not really any difference between "deleting them" and "stashing them somewhere where they're not in anyone's way". 20161218 17:25:41< celticminstrel> Since they'll always be there in the git history. 20161218 17:26:03-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 17:26:03< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 17:26:03< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-56 20161218 17:26:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 17:26:37< celticminstrel> BTW zookeeper, do you know if these ancient images are still needed? https://github.com/wesnoth/wesnoth/tree/master/data/tools/castle-cutter 20161218 17:27:00< zookeeper> there's the seemingly obvious difference that if something is deleted then no one will know what to look for in the history 20161218 17:27:29< celticminstrel> Eh, I suppose. 20161218 17:28:54< zookeeper> i don't think those templates are actually needed, no 20161218 17:31:34< zookeeper> i dunno about the src/ files, but at least all the stuff in data/tools/ could be moved to the attic. i guess we rarely move anything there anymore, but those kinds of things seem to fit there. 20161218 17:32:35< celticminstrel> Confused now. 20161218 17:32:53< celticminstrel> PR 903 doesn't delete anything in data/tools. Are you saying there are things in data/tools that should be removed? 20161218 17:33:34< celticminstrel> Although... 20161218 17:33:54< celticminstrel> Could it be that castle-cutter and exploder dirs in data/tools are in fact related to the removed tools? 20161218 17:34:03< zookeeper> well there are the data files used by cutter and exploder AFAICT 20161218 17:34:09< celticminstrel> Okay. 20161218 17:34:17< zookeeper> i'm not sure, but... the naming would suggest that :p 20161218 17:36:51< celticminstrel> They don't seem to be directly referenced by the source, so it's hard to tell, but... I think they probably are. 20161218 17:37:09< celticminstrel> But why would they be moved to attic if the source is deleted? 20161218 17:37:37< zookeeper> yeah, wouldn't make sense 20161218 17:39:23< celticminstrel> The data/tools/exploder dir is hardcoded, but the data/tools/castle-cutter one isn't... 20161218 17:46:51< celticminstrel> Seems like data/tools/castle-cutter is a different castle cutter tool. 20161218 17:49:10-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20161218 17:49:10< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Charles Dang 4629990: Attack Predictions: fixup variable names shadowing type names Failed 20161218 17:49:10< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-56 20161218 17:49:15-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20161218 17:50:22< celticminstrel> I think castle.png, encampment.png, keep1.pne, keep2.png, and mk-all-castles.sh could be deleted, and likely the *.tmpl files as well, but not sure. Is that castle cutter actually used though? For example, was some cutter tool used for the aquatic castles? 20161218 17:51:25< zookeeper> no, i don't expect anyone has used it in aged. the way the dwarvish castle is cut suggests it may have been cut using it, but since then... not as far as i know 20161218 17:51:29< zookeeper> ages, even 20161218 17:52:27< celticminstrel> Should we remove that tool altogether, then? 20161218 17:54:00< zookeeper> well we don't need to keep it where it is, sure, since no one uses it 20161218 17:54:07< celticminstrel> Are the colourful images (cutter-fg and cutter-bg) useful without it? I see similar images in images/tools. 20161218 17:54:26< zookeeper> what 20161218 17:54:35< zookeeper> of course if you remove castle-cutter you remove all files in castle-cutter 20161218 17:56:03< celticminstrel> ...okay, so do you know what images/tools/chasm-*.png is for. 20161218 17:56:55< zookeeper> well, cutting chasms naturally. i don't know which decade anyone's last used those for anything 20161218 17:57:41< celticminstrel> How do people do cutting now, then? 20161218 17:57:45< zookeeper> they're not in any UMC use, nor is anything in tools/exploder/ 20161218 17:57:52< zookeeper> manually, i'd imagine 20161218 17:57:57< celticminstrel> I see. 20161218 17:58:05< celticminstrel> Should we remove the chasm cutters too, then? 20161218 18:00:12< celticminstrel> Might want to comment on the PR, anyway. 20161218 18:00:27< zookeeper> i don't know, i guess you can remove them if you want 20161218 18:02:36-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 18:02:37< travis-ci> wesnoth/wesnoth#12457 (master - fd34c28 : ln-zookeeper): The build has errored. 20161218 18:02:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184959889 20161218 18:02:37-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 18:11:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 18:18:37-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 18:19:10< irker814> wesnoth: Celtic Minstrel wesnoth:master d46d713fb9d5 / / (3 files in 2 dirs): Update MSVC project and fix warnings https://github.com/wesnoth/wesnoth/commit/d46d713fb9d5fb17f7bb67819bb23515a989244e 20161218 18:38:16-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 18:38:17< travis-ci> wesnoth/wesnoth#12458 (master - c3ed1c7 : ln-zookeeper): The build passed. 20161218 18:38:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184962633 20161218 18:38:17-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 19:05:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 19:07:13< zookeeper> waitwhat... i made a mid-scenario save on master, then tried to load that save in 1.13.5, and got an error about the macro ON_DIFFICULTY being missing. how does that make sense, there are no macros in savefiles. 20161218 19:12:13-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20161218 19:12:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 19:13:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev 20161218 19:17:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Ping timeout: 258 seconds] 20161218 19:28:15-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 19:28:16< travis-ci> wesnoth/wesnoth#12459 (master - d46d713 : Celtic Minstrel): The build has errored. 20161218 19:28:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184971152 20161218 19:28:16-!- travis-ci [~travis-ci@ec2-54-224-40-4.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 19:29:55< irker814> wesnoth: Celtic Minstrel wesnoth:master 9c8e597005ff / changelog src/formula/function.cpp: Add str_upper and str_lower functions to WFL https://github.com/wesnoth/wesnoth/commit/9c8e597005ff131b5e91ebbda3e5f24a20309d1c 20161218 19:31:49< zookeeper> yay, i have corner-based [time_area] transitions <3 20161218 19:33:33< zookeeper> was a bit awkward to write the rotation logic engine-side, though 20161218 19:37:13< celticminstrel> I'm not even sure what this means... 20161218 19:38:11< zookeeper> the fade transitions between time areas which have different color shifts 20161218 19:38:40< celticminstrel> Oh. 20161218 19:38:58< zookeeper> the current way is to do them using normal n,ne,se,etc style transitions, which can never look good with transparency 20161218 19:44:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev 20161218 19:46:46-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Quit: horrowind] 20161218 19:52:40-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 19:52:41< travis-ci> wesnoth/wesnoth#12460 (master - 9c8e597 : Celtic Minstrel): The build failed. 20161218 19:52:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/184981279 20161218 19:52:41-!- travis-ci [~travis-ci@ec2-54-197-128-146.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 19:52:59< celticminstrel> ... 20161218 19:56:04< celticminstrel> Okay, I have no idea why it can't infer the tempate argument, so I'll see if someone who actually uses GCC can figure it out. 20161218 19:56:08< celticminstrel> ^template 20161218 20:07:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection] 20161218 20:25:57-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20161218 20:37:16-!- JyrkiVesterinen [~JyrkiVest@78-27-119-209.bb.dnainternet.fi] has quit [Quit: .] 20161218 21:00:39-!- Kwandulin [~Miranda@p200300760F6EBF6DBC00FF6D0B47A9AD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161218 21:11:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20161218 21:40:21-!- mjs-de [~mjs-de@x4e312ff9.dyn.telefonica.de] has quit [Remote host closed the connection] 20161218 21:56:51-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20161218 22:29:00< irker814> wesnoth: Celtic Minstrel wesnoth:master 0be99ede50d0 / src/formula/function.cpp: Attempt to fix GCC/clang builds https://github.com/wesnoth/wesnoth/commit/0be99ede50d066c488c2fe8ff3e26c7d0e7eacd2 20161218 22:33:53< celticminstrel> Okay, so the PRs I want to merge soon are... 904, 903, 901, 900, 804; maybe 875. 20161218 22:34:15< celticminstrel> I also want to merge the French PRs. Would that be stepping on Ivanovic's toes, I wonder. 20161218 22:35:13< celticminstrel> Not sure what to do with 898, 20161218 22:35:39< celticminstrel> Conceptually the idea is good, but I have no idea if the implementation is correct. 20161218 22:51:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20161218 23:02:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has joined #wesnoth-dev 20161218 23:06:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20161218 23:10:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161218 23:10:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds] 20161218 23:28:17-!- travis-ci [~travis-ci@ec2-54-160-128-76.compute-1.amazonaws.com] has joined #wesnoth-dev 20161218 23:28:18< travis-ci> wesnoth/wesnoth#12462 (master - 0be99ed : Celtic Minstrel): The build was fixed. 20161218 23:28:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/185011392 20161218 23:28:18-!- travis-ci [~travis-ci@ec2-54-160-128-76.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161218 23:29:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7dcf:eff4:d590:eb7a] has quit [Remote host closed the connection] --- Log closed Mon Dec 19 00:00:54 2016