--- Log opened Wed Dec 21 00:00:12 2016
20161221 00:27:05-!- prkc [~prkc@46.166.190.129] has joined #wesnoth-dev
20161221 00:42:11-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 00:42:11< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 00:42:11< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-62
20161221 00:42:15-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 00:51:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has joined #wesnoth-dev
20161221 00:53:20-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has quit [Quit: leaving]
20161221 00:59:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has quit [Remote host closed the connection]
20161221 01:07:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 01:07:42< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 01:07:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-62
20161221 01:07:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 01:16:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161221 01:34:39-!- atarocch [~atarocch@athe-bt-souel-peer.customers.otenet.gr] has quit [Remote host closed the connection]
20161221 01:40:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 01:40:26< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 01:40:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-63
20161221 01:40:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 02:01:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161221 02:01:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161221 02:04:55-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 02:04:55< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 02:04:55< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-63
20161221 02:04:59-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 02:06:25-!- gfgtdf [~chatzilla@x4e36953f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 50.1.0/20161208153507]]
20161221 03:37:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has joined #wesnoth-dev
20161221 04:13:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has quit [Remote host closed the connection]
20161221 04:32:36-!- Appleman1234_ [~Appleman1@KD106161213200.au-net.ne.jp] has joined #wesnoth-dev
20161221 04:34:02-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161221 04:35:20-!- Appleman1234 [~Appleman1@KD106161209188.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20161221 04:35:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20161221 04:35:48-!- wedge010 is now known as wedge009
20161221 04:42:46-!- Appleman1234_ is now known as Appleman1234
20161221 05:44:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161221 06:10:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161221 06:10:42-!- boucman [~rosen@2a02-8428-034f-f800-e08b-ef0c-c24d-a166.rev.sfr.net] has joined #wesnoth-dev
20161221 06:10:46-!- boucman [~rosen@2a02-8428-034f-f800-e08b-ef0c-c24d-a166.rev.sfr.net] has quit [Changing host]
20161221 06:10:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161221 06:44:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161221 06:47:49-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161221 06:48:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has joined #wesnoth-dev
20161221 07:36:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161221 07:43:55-!- atarocch [~atarocch@2.43.3.197] has joined #wesnoth-dev
20161221 07:57:12-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has joined #wesnoth-dev
20161221 08:06:43-!- JyrkiVesterinen [~JyrkiVest@85-76-44-207-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161221 08:26:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161221 08:29:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 246 seconds]
20161221 08:29:09-!- wedge010 is now known as wedge009
20161221 08:43:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 08:43:05< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 08:43:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-63
20161221 08:43:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 08:56:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:901c:5283:e926:a0c4] has quit [Remote host closed the connection]
20161221 09:07:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 09:07:56< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 09:07:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-63
20161221 09:08:00-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 09:11:18-!- Kwandulin [~Miranda@WL-POOL2-ONT-096.UNI-MUENSTER.DE] has joined #wesnoth-dev
20161221 09:40:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 09:40:42< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 09:40:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-64
20161221 09:40:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 09:41:36-!- Appleman1234 [~Appleman1@KD106161213200.au-net.ne.jp] has left #wesnoth-dev ["Leaving"]
20161221 09:41:45-!- Appleman1234 [~Appleman1@KD106161213200.au-net.ne.jp] has joined #wesnoth-dev
20161221 09:49:56-!- JyrkiVesterinen [~JyrkiVest@85-76-44-207-nat.elisa-mobile.fi] has quit [Quit: .]
20161221 10:05:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 10:05:26< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen 1155cb8: Merge pull request #901 from wesnoth/shrinking-styled-widgets Succeeded
20161221 10:05:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-64
20161221 10:05:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 10:30:46-!- JyrkiVesterinen [~JyrkiVest@85-76-44-207-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161221 11:20:03< DeFender1031> question: coding standards don't seem to include a line length limit of any sort. What's the preferred line length to try not to exceed in C++ code?
20161221 11:22:17< JyrkiVesterinen> From what I can tell, it depends on the developer in question.
20161221 11:22:33< JyrkiVesterinen> Personally I try to avoid exceeding line length of surrounding code.
20161221 11:23:46< JyrkiVesterinen> But other than that I don't limit the length of lines at all.
20161221 11:24:05< JyrkiVesterinen> When writing brand new C++ files, I try to stick to 100 columns or so.
20161221 11:27:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161221 11:44:47< DeFender1031> i tend to stick to 130 in my own projects
20161221 11:45:21-!- Kwandulin [~Miranda@WL-POOL2-ONT-096.UNI-MUENSTER.DE] has quit [Read error: Connection reset by peer]
20161221 12:55:33-!- atarocch [~atarocch@2.43.3.197] has quit [Ping timeout: 248 seconds]
20161221 13:01:00< DeFender1031> found a weird edge-case difference between my split() code and the existing split() code in string_utils, where if you pass an empty string and a flags parameter not containing REMOVE_EMPTY (meaning, we're NOT removing empty) the old version would still return an empty vector, whereas my code returns a vector with a single empty string. I would ordinarily treat the old code's behavior as a bug, but without knowing how it's 
20161221 13:01:01< DeFender1031> used, I don't know if there are any cases where it actually relies on that behavior. Also of note is that if the string contains, for example, a single space, then it WILL return a vector with a single entry (either empty or with a space, depending on whether the flags contained STRIP_SPACES or not)
20161221 13:01:13< DeFender1031> I can elaborate if this is not clear.
20161221 13:03:32< JyrkiVesterinen> I believe that none of us knows whether anything relies on the old behavior.
20161221 13:03:35< DeFender1031> I mean, it's simple enough to add a check to my code to make it behave the same way for an empty string, but I'd rather not if this is actually a bug
20161221 13:03:58< DeFender1031> JyrkiVesterinen, so how would one go about determining this?
20161221 13:04:19< JyrkiVesterinen> I suggest that you simply try running the game with your split() implementation and see if anything breaks.
20161221 13:04:28-!- irker840 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161221 13:04:28< irker840> wesnoth: ln-zookeeper wesnoth:master 5dbff70e155d / data/campaigns/Under_the_Burning_Suns/scenarios/ (9 files): UtBS: Fixed capitalization and a few other details in objectives https://github.com/wesnoth/wesnoth/commit/5dbff70e155de5d061ea7e048d8c5cc46a29bd18
20161221 13:05:08< DeFender1031> already did. the menu screen loads properly without any sort of issue. The question is how much running the game I should be doing before being comfortable with the change
20161221 13:05:45< DeFender1031> for all i know, this is relevant, but only in some obscure edge case with some specific WML that i won't necessarily encounter.
20161221 13:05:58< JyrkiVesterinen> It's up to you. No one can really give any hard rules about how much you should test.
20161221 13:06:16< JyrkiVesterinen> Personally I test my own changes only lightly before I push them to master.
20161221 13:07:23< DeFender1031> hmm... should I add a note to the code saying that the behavior has changed, the date, and that if no issue is discovered that was the result of the change, the note can be removed in two years?
20161221 13:08:09< JyrkiVesterinen> I think it's unnecessary. We can use git blame to check when the function was changed.
20161221 13:08:32< JyrkiVesterinen> Noting the semantic change in the commit message is enough.
20161221 13:09:15< DeFender1031> okay.
20161221 13:09:43< DeFender1031> though, won't my commits get rebased before being stuck into master?
20161221 13:10:29< JyrkiVesterinen> History rewriting doesn't necessarily erase commit messages.
20161221 13:10:49< JyrkiVesterinen> A developer can change commit messages when rewriting history but doesn't *have to*.
20161221 13:11:41-!- atarocch [~atarocch@2.43.3.197] has joined #wesnoth-dev
20161221 13:11:44< JyrkiVesterinen> In addition, it may not be necessary to rewrite the history of your branch in the first place.
20161221 13:11:58< DeFender1031> okay
20161221 13:12:29< DeFender1031> basically, "include it in the commit message and then it becomes the responsibility of whoever's merging". I can live with that
20161221 13:20:57< DeFender1031> I currently have some debugging output lines any time my code produces a different result than the old one. Found a bunch of cases where the empty string thing happens, but it doesn't seem to be having any sort of adverse effect on execution
20161221 15:25:31-!- JyrkiVesterinen [~JyrkiVest@85-76-44-207-nat.elisa-mobile.fi] has quit [Quit: .]
20161221 15:59:11-!- Kwandulin [~Miranda@p200300760F6EBF2655DE9148291BB4C0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161221 16:04:34-!- irker840 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161221 16:14:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161221 16:45:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 16:45:56< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 5dbff70: UtBS: Fixed capitalization and a few other details in objectives Succeeded
20161221 16:45:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-64
20161221 16:46:00-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 17:02:09-!- JyrkiVesterinen [~JyrkiVest@87-92-52-225.bb.dnainternet.fi] has joined #wesnoth-dev
20161221 17:12:49-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 17:12:49< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 5dbff70: UtBS: Fixed capitalization and a few other details in objectives Succeeded
20161221 17:12:49< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-64
20161221 17:12:53-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 17:33:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161221 17:34:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 17:45:47-!- atarocch [~atarocch@2.43.3.197] has quit [Ping timeout: 252 seconds]
20161221 17:48:19-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 17:48:19< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 5dbff70: UtBS: Fixed capitalization and a few other details in objectives Succeeded
20161221 17:48:19< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-65
20161221 17:48:23-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 18:11:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 18:11:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 18:14:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20161221 18:14:35< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 5dbff70: UtBS: Fixed capitalization and a few other details in objectives Succeeded
20161221 18:14:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-65
20161221 18:14:39-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20161221 18:16:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161221 18:19:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161221 18:19:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161221 18:25:43-!- atarocch [~atarocch@athe-bt-souel-peer.customers.otenet.gr] has joined #wesnoth-dev
20161221 18:30:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 18:35:12-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has quit [Quit: leaving]
20161221 19:08:17-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161221 19:19:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 19:23:32-!- Kwandulin [~Miranda@p200300760F6EBF2655DE9148291BB4C0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161221 19:24:31-!- DeFender1031 [~DeFender1@93-173-175-150.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161221 19:25:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 19:30:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 19:30:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 19:32:11-!- gfgtdf [~chatzilla@x4e363efa.dyn.telefonica.de] has joined #wesnoth-dev
20161221 19:58:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 19:59:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 20:04:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161221 20:16:24-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161221 20:39:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161221 20:41:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 20:42:07-!- JyrkiVesterinen [~JyrkiVest@87-92-52-225.bb.dnainternet.fi] has quit [Quit: .]
20161221 21:39:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161221 21:58:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 21:59:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 22:19:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161221 22:19:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161221 22:20:45-!- kidneb [kidneb@2a01:7e00::f03c:91ff:fe33:363c] has quit [Quit: Oh no]
20161221 22:25:25-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20161221 22:54:35-!- kidneb [kidneb@2a01:7e00::f03c:91ff:fe33:363c] has joined #wesnoth-dev
20161221 22:55:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161221 23:41:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161221 23:42:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161221 23:44:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds]
20161221 23:46:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
--- Log closed Thu Dec 22 00:00:32 2016