--- Log opened Sun Jan 01 00:00:39 2017
20170101 00:26:13-!- Appleman1234 [~Appleman1@KD106161209018.au-net.ne.jp] has joined #wesnoth-dev
20170101 00:31:39< matthiaskrgr> were these some changes regarding boost headers recently? 
20170101 00:32:00< matthiaskrgr> (includes)
20170101 00:32:24< vultraz_iOS> Don't ask me I'm on vacation
20170101 00:32:29< vultraz_iOS> celticminstrel is in charge
20170101 00:32:48< matthiaskrgr> why do you reply if you're on vacation? :p
20170101 00:35:24< vultraz_iOS> Because I need to let people know I'm on vacation
20170101 00:40:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170101 00:42:03-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 00:42:03< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 00:42:03< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-95
20170101 00:42:07-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 00:47:17-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170101 00:51:39< celticminstrel> I don't know of any Boost header changes.
20170101 00:55:31-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:889c:2e6:44dc:ef31] has joined #wesnoth-dev
20170101 01:02:24-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170101 01:07:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 01:07:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 01:07:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-95
20170101 01:07:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 01:39:36-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 01:39:36< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 01:39:36< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-96
20170101 01:39:40-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 01:59:01< vultraz_iOS> God dammit stop removing deprecation warnings
20170101 01:59:14< vultraz_iOS> We need deprecation warnings for deprecated stuff or no one will know not to use them
20170101 02:03:40-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 02:03:40< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 02:03:40< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-96
20170101 02:03:45-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 02:10:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170101 02:30:30-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:889c:2e6:44dc:ef31] has quit [Ping timeout: 258 seconds]
20170101 03:00:39-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170101 03:06:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170101 05:06:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170101 05:54:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 05:55:29-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170101 06:03:03-!- JyrkiVesterinen [~JyrkiVest@87-100-242-49.bb.dnainternet.fi] has joined #wesnoth-dev
20170101 06:08:11< JyrkiVesterinen> matthiaskrgr: There was this commit: https://github.com/wesnoth/wesnoth/commit/90356fce46c376a7450c46752cd8d4d5cc973d96
20170101 06:09:05< JyrkiVesterinen> Semantically it shouldn't change anything. Its meaning, in short, is "don't force-#include the patched header for files outside the src directory", and all our code is in that directory.
20170101 06:09:59< JyrkiVesterinen> (Also, I don't get why CMake build was failing for Aginor. It was working for me locally, and in Travis.)
20170101 06:10:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Remote host closed the connection]
20170101 06:48:49-!- Kwandulin [~Miranda@p200300760F6EBF34A8009C5D933431C0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170101 07:11:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 07:16:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 07:26:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170101 07:26:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20170101 08:12:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 08:17:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 08:28:09-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: No route to host]
20170101 08:36:18-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20170101 08:42:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 08:42:17< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 08:42:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-96
20170101 08:42:21-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 08:47:39-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:889c:2e6:44dc:ef31] has joined #wesnoth-dev
20170101 09:06:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 09:06:42< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 09:06:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-96
20170101 09:06:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 09:13:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 09:19:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 09:37:17-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 09:37:17< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 09:37:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-97
20170101 09:37:22-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 09:59:28-!- Kwandulin [~Miranda@p200300760F6EBF34A8009C5D933431C0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170101 09:59:41-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 09:59:41< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 09:59:41< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-97
20170101 09:59:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 10:18:11-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:889c:2e6:44dc:ef31] has quit [Ping timeout: 258 seconds]
20170101 10:24:00-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170101 10:28:07-!- RatArmy_ [~ratarmy@ZB064123.ppp.dion.ne.jp] has joined #wesnoth-dev
20170101 10:34:46-!- Kwandulin [~Miranda@p200300760F6EBF3484142174CF68D458.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170101 10:35:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170101 10:40:31-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.7 scheduled for sometime this year | Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170101 11:16:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 11:20:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 11:26:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170101 11:33:50-!- JyrkiVesterinen [~JyrkiVest@87-100-242-49.bb.dnainternet.fi] has quit [Quit: .]
20170101 12:01:31< zookeeper> vultraz_iOS, yeah, i guess i didn't realize that everyone will be super inconvenienced by not knowing they just really absolutely should change one thing for another thing for no reason :(
20170101 12:01:34< zookeeper> my bad, totally
20170101 12:03:00< vultraz_iOS> They will be inconvenienced once i drop support for a feature and you never showed them a deprecation notice
20170101 12:03:43< zookeeper> well naturally you won't drop support for a feature
20170101 12:03:48< zookeeper> so there's no problem
20170101 12:16:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 12:21:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 12:26:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170101 12:37:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170101 12:51:13-!- JyrkiVesterinen [~JyrkiVest@87-92-35-172.bb.dnainternet.fi] has joined #wesnoth-dev
20170101 13:06:33-!- mjs-de [~mjs-de@185.22.140.88] has joined #wesnoth-dev
20170101 13:07:15-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20170101 13:17:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 13:22:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 13:31:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170101 13:33:05-!- mjs-de [~mjs-de@185.22.140.88] has quit [Remote host closed the connection]
20170101 14:05:27-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170101 14:08:43-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170101 14:13:37< zookeeper> i wonder, how easy/hard would it be to produce a list of all deleted images between 1.12 and master? and if it helps, "images" can mean "any file in data/core/images/".
20170101 14:18:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 14:23:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Ping timeout: 258 seconds]
20170101 14:25:32< Ravana_> I believe git diff can do that
20170101 14:25:49< matthiaskrgr> sure
20170101 14:32:28-!- RatArmy_ [~ratarmy@ZB064123.ppp.dion.ne.jp] has quit [Ping timeout: 260 seconds]
20170101 14:34:06< matthiaskrgr> zookeeper: I think this might work   git diff 1.12.0 HEAD --diff-filter=D --name-only data/core/images   
20170101 14:34:45< matthiaskrgr> well, you can slap a |grep "\.png$" at the end 
20170101 14:40:40< zookeeper> neat, i'll give that a try in a bit...
20170101 14:50:59-!- Kwandulin [~Miranda@p200300760F6EBF3484142174CF68D458.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170101 15:10:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170101 15:10:31-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.4]
20170101 15:11:14-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20170101 15:16:41< DeFender1031> zookeeper, a list of removed/added/changed might be best.
20170101 15:16:51< DeFender1031> rather than just removed
20170101 15:17:25< DeFender1031> since certain IPF stuff is done based on image content, and as such it might be useful to people to have a list of what changed as well
20170101 15:18:01< zookeeper> yeah, but it's not feasible to sift through all changed images and try to determine which changes out of hundreds are big enough to warrant mention.
20170101 15:18:01< DeFender1031> and added might be nice so people can see if there are any new images that are better than something they're already using.
20170101 15:18:11< DeFender1031> i wouldn't sift.
20170101 15:18:34< DeFender1031> I would literally just provide a list of added, a list of changed, and a list of deleted, and people can take it or leave it
20170101 15:18:42< zookeeper> then they'd all leave it
20170101 15:18:51< zookeeper> (probably)
20170101 15:19:02< DeFender1031> i can't speak for anyone else, but I know I wouldn't
20170101 15:19:46< DeFender1031> i'd basically go through my wml, cross-reference any images i'm doing complicated IPF on with the list, if it's there, check to see if it still looks the same, and if not, go on.
20170101 15:19:56< DeFender1031> I personally would find it useful.
20170101 15:20:03< DeFender1031> And I suspect others would as well.
20170101 15:20:13< zookeeper> a whole lot of image changes are pretty trivial and won't change anything notable, so i'd expect the list to be too long to be convenient for that purpose
20170101 15:21:10< zookeeper> so i'd at least weed out the utterly trivial changes, like all those stray pixel removals or optimization runs etc. which, again, is manual work that the one compiling the list would have to do.
20170101 15:21:48< DeFender1031> zookeeper, not if it's alphabetically sorted.
20170101 15:22:36< DeFender1031> if it's alphabetically sorted, it's much quicker to find the image you're using
20170101 15:22:50< zookeeper> fair enough
20170101 15:27:24< zookeeper> matthiaskrgr, yeah, thanks, seems to work.
20170101 15:28:23< matthiaskrgr> iirc you can --diff-filter=A and =M for added and modified files
20170101 15:30:07< zookeeper> makes sense
20170101 15:34:26< DeFender1031> i'd actually have everything in the same list, sorted alphabetically by image name with a letter or word afterward indicating what the deal is
20170101 15:35:01< DeFender1031> that way, someone using the list as i described can easily find whatever image they're using and then see if it's a change or deletion
20170101 15:38:21< zookeeper> it'd be convenient if the list would actually display a diff of the (changed) image... :p
20170101 15:38:35< zookeeper> so one wouldn't need to check it by hand
20170101 15:38:41< DeFender1031> zookeeper, that should be doable as well, no?
20170101 15:39:00< zookeeper> well sure, if someone writes some kind of script to create such a page or whatever
20170101 15:39:41< DeFender1031> in fact, i could probably throw together a script that loops through 1.12 and 1.13 and checks for any changed files, and generates an html table with the old and new images
20170101 15:40:06< DeFender1031> either in base-64 encoded or by hotlinking to the github images.
20170101 15:40:28< zookeeper> sounds like that could be useful
20170101 15:40:33< DeFender1031> then i'll do that.
20170101 15:40:52< DeFender1031> i assume a pull from the latest master is what we want?
20170101 15:40:58< zookeeper> i don't think there are actually a lot of images which have changed contents in a meaningful way, but it'd be a very convenient way for people to assure themselves of that fact
20170101 15:41:06< DeFender1031> last 1.12 is .6, right?
20170101 15:41:12< DeFender1031> right, that's true too.
20170101 15:41:38< DeFender1031> i don't have the skills to write a script that will analyze the changes and find only significant ones.
20170101 15:41:57< DeFender1031> but what i can write is itself helpful
20170101 15:42:09< zookeeper> yeah, 1.12.6. i wasn't sure if one should compare master with the point at which 1.12 was branched off, or master with 1.12.6, but i guess the latter makes sense in this context?
20170101 15:42:14< DeFender1031> also, i can imagine that what's "significant" depends on what someone is soing with the thing
20170101 15:42:35-!- Kwandulin [~Miranda@p200300760F6EBF34DCC2D08CB1FB5063.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170101 15:42:41< DeFender1031> for example, changes that wouldn't be significant to most people might be significant to people doing crazy stuff like your IPF-only portrait mods.
20170101 15:42:58< zookeeper> sure, but i just meant changes that are insignificat even in that context
20170101 15:43:06< DeFender1031> zookeeper, i was going to compare it with my local 1.12.6 install.
20170101 15:43:25< DeFender1031> i'll also send you the script once i'm done with it so you can use it in the future.
20170101 15:43:35< DeFender1031> (it'll require php cli though)
20170101 15:43:44< DeFender1031> (I write most of my scripts in php)
20170101 15:43:54< DeFender1031> (because it's far nicer than bash)
20170101 15:43:58< DeFender1031> (IMO)
20170101 15:44:03< zookeeper> err, yeah i probably won't be able to run that myself then
20170101 15:44:44< DeFender1031> either way, i can run it now.
20170101 15:45:05< zookeeper> now, are you just up for making something quick and dirty or would you want to plan the details a bit more? :p
20170101 15:47:05< DeFender1031> no planning needed. I'm basically going to loop through the old directory, see if there's a file in the new directory with the same name, if not, list it as deleted, if yes, compare them, if they're not the same, add them to the list, then go through the new directory, find any paths that exist there that don't in the old one, then output all that as an html table which is sorted alphabetically, done.
20170101 15:47:39< DeFender1031> unless of course this should be a wiki page, in which case i can format the output for wiki, but that's just a cosmetic change basically
20170101 15:47:54< DeFender1031> shouldn't take me even an hour.
20170101 15:49:02< zookeeper> well, if you insist
20170101 15:50:00< DeFender1031> i mean, do you think there are any other details that we need to plan?
20170101 15:51:03< zookeeper> maybe? it's not like i've had time to think about this for more than 10 minutes so i don't yet know if there's something relevant i haven't thought of
20170101 15:52:14< DeFender1031> as i understand, the goal is to have a list of images changed or removed for easy reference?
20170101 15:52:29< zookeeper> pretty much, yes
20170101 15:52:41< DeFender1031> also, even if there is more we want it to do, i can update the script as necessary.
20170101 15:54:18< zookeeper> all right. i wouldn't expect major changes to be necessary in later revisions, although comparing several dirs (images/ and data/core/images/) would be handy, and maybe optionally excluding specific optimization/etc commits by hash or commit message or something.
20170101 15:55:42< zookeeper> and like, probably don't actually show the deleted images because then you end up with tons of huge images from that portraits/race/transparent/ cleanup.
20170101 16:01:24< zookeeper> but you're gonna get the same from replacing portraits/race/unit.png's with the transparent versions, so maybe exclude those too and just hand-add a remark about that operation in the publicized version...
20170101 16:02:41< zookeeper> redundancy isn't that bad for most images, but a couple hundred portrait-sized diffs might make it a bit unwieldy to navigate (and/or load, for that matter)
20170101 16:02:55< DeFender1031> hmm
20170101 16:03:13< DeFender1031> let me get the skeleton going and then we can tweak it afterward...
20170101 16:03:46< DeFender1031> I might use a lib to not show changes to any images larger than, say, 144px in either direction or whatever.
20170101 16:04:04< DeFender1031> use a lib to determine image resolution in order to not show*
20170101 16:04:29< DeFender1031> have to see if there's even a way to get that info from php
20170101 16:04:56< DeFender1031> but like i said, let me get the basic skeleton going first
20170101 16:07:46< zookeeper> sure
20170101 16:08:00< zookeeper> i'll work on my dinner in the meanwhile ->
20170101 16:24:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170101 16:24:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170101 16:42:21< DeFender1031> zookeeper, preliminary output from the script: http://paste.nachsoftware.com/DeFender1031/ztvlr46dee3fdbb5537a793b5586931546c4c3TR
20170101 16:42:26-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 16:42:26< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 16:42:26< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-97
20170101 16:42:30-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 16:44:05< zookeeper> that was fast
20170101 16:45:04< DeFender1031> zookeeper, I told you, I didn't expect it to take me more than an hour.
20170101 16:45:07< zookeeper> it can't be correct, though: for example "data/core/images/terrain/water/ocean-A01-n.png - Added" <- that image has been there forever, and only modified 2 years ago.
20170101 16:45:20< DeFender1031> hmm...
20170101 16:45:32< DeFender1031> okay, then there's a bug.
20170101 16:45:45< zookeeper> there seems to be tons of stuff that shows up as added
20170101 16:45:50< DeFender1031> indeed.
20170101 16:46:08< DeFender1031> oh, i'm an idiot
20170101 16:46:49< DeFender1031> forgot a check
20170101 16:47:03< DeFender1031> let me get you some more accurate output after putting in a fix here...
20170101 16:48:26< DeFender1031> zookeeper, this output should be more reasonable: http://paste.nachsoftware.com/DeFender1031/RtLVN633420f6e4f5e475507f586932cfe1271Sm
20170101 16:49:41< DeFender1031> yeah, that first list listed EVERYTHING not changed or deleted as added.
20170101 16:49:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170101 16:49:49-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170101 16:50:01< DeFender1031> because I forgot to have it check if the file actually existed in the old path :P
20170101 16:50:22< zookeeper> yeah that looks more like it
20170101 16:50:34< zookeeper> ok, something other that should be excluded: all the l10n images
20170101 16:50:42< zookeeper> s/other/else
20170101 16:50:53< DeFender1031> i can add a check to exclude those dirs.
20170101 16:51:07< DeFender1031> isn't that how translations are done?
20170101 16:51:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 16:52:02< zookeeper> i wonder how big that output is gonna be if you inline all the images for the diffs...
20170101 16:52:17< DeFender1031> no idea. we can find out.
20170101 16:52:26< DeFender1031> anyway, what's with the l10ns?
20170101 16:53:06< zookeeper> they're just the image "translations" that get used automatically
20170101 16:53:26< DeFender1031> right. why were a bunch removed? (and why shouldn't they be included?)
20170101 16:53:30< zookeeper> i suppose in theory one could refer to those images from WML directly, but... i'm pretty sure no one does
20170101 16:53:57< zookeeper> presumably they are removed only when the parent image is removed
20170101 16:54:12< zookeeper> such as is the case for example for data/core/images/misc/logo.png - Removed
20170101 16:55:14< zookeeper> and they shouldn't be included because... they're just redundant noise in the output
20170101 16:56:01< DeFender1031> hmm
20170101 16:56:04< DeFender1031> fair enough
20170101 16:56:15< DeFender1031> (i already added the change like 5 minutes ago)
20170101 16:56:49< zookeeper> i mean, if you want then you can put all these exclusions behind a toggle i suppose (excluding by default, though, i'd say)
20170101 16:57:34< DeFender1031> alright, we're up to the point of generating real output. Several questions: 1. wiki or plain html? 2. inline or hotlinking from github?
20170101 16:58:49< zookeeper> not sure about 1, but i guess inlining is much better and faster if the filesize stays manageable?
20170101 16:58:57< DeFender1031> we'll see.
20170101 16:59:08< zookeeper> i'd be interested in seeing that, anyway
20170101 16:59:31< zookeeper> and i guess plain html is easier in this phase, not to mention that i have no idea if you could inline images on a wiki page
20170101 16:59:52< zookeeper> anyway... i only finished with the preparations for cooking my dinner so far, so i shall have to return to it ->
20170101 17:00:11< DeFender1031> i'm also thinking that we should include thumbnails of all the images, even the portraits, and just scaling them down to a max of 144x144. (if i'm inlining, i'll have imagemagick pre-scale them rather than including full-size just to throw away half the data)
20170101 17:00:47< DeFender1031> hmm.... it ought to be doable to inline images on a wiki page... just need to look up how
20170101 17:04:10-!- mjs-de [~mjs-de@b9168e0c.cgn.dg-w.de] has joined #wesnoth-dev
20170101 17:07:08-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 17:07:08< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 17:07:08< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-97
20170101 17:07:12-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 17:07:15-!- mjs-de [~mjs-de@b9168e0c.cgn.dg-w.de] has quit [Remote host closed the connection]
20170101 17:08:02-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20170101 17:10:31< DeFender1031> zookeeper, inline html is 129mb, but i haven't added code to scale things down yet. Also, I'm thinking it makes sense to make each image a link to the github image in full size, so it may be prudent to just hotlink to there anyway.
20170101 17:20:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170101 17:24:48-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Quit: Leaving]
20170101 17:29:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Remote host closed the connection]
20170101 17:30:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has joined #wesnoth-dev
20170101 17:36:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:bcb2:2725:5845:6d2e] has quit [Remote host closed the connection]
20170101 17:37:59< DeFender1031> zookeeper, 38mb with the scaling code. I'm thinking I'm gonna see how easy it is to hotlink the github images.
20170101 17:40:00-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 17:40:00< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 17:40:00< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-98
20170101 17:40:04-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 17:42:19< DeFender1031> i like the new tentacle sprites
20170101 17:43:04< DeFender1031> hmmm... skeleton archer was moved to its own subdir...
20170101 17:44:02< DeFender1031> i'm wondering if this code should be smarter in its output and possibly its comparisons as well...
20170101 17:45:07< DeFender1031> (i.e. listing images that were moved as having been moved rather than deleted, and comparing images by pixel rather than by data, in case the png is identical but more optimized...)
20170101 17:45:24< DeFender1031> (unfortunately, i don't know of a tool to do the latter automatically)
20170101 17:46:48< matthiaskrgr> https://github.com/matthiaskrgr/woptipng/blob/master/woptipng.py#L93  
20170101 17:46:56< matthiaskrgr> should work 
20170101 17:47:08< celticminstrel> Which code?
20170101 17:47:18< matthiaskrgr> the function at L93
20170101 17:47:27< matthiaskrgr> return PIL.open(image1).tobytes() == PIL.open(image2).tobytes()   
20170101 17:47:50< DeFender1031> matthiaskrgr, how could i use that from a php script?
20170101 17:48:25< DeFender1031> celticminstrel, read the chatlog. I'm trhowing together a script to generate a page listing what images were removed/added/changed from 1.12.6 to 1.13
20170101 17:48:33< matthiaskrgr> $command = escapeshellcmd('pythonscript.py');   ? :P
20170101 17:48:35 * matthiaskrgr googled
20170101 17:49:06< celticminstrel> There might be PIL for PHP maybe?
20170101 17:49:10< DeFender1031> matthiaskrgr, not quite correct, but yes, my question was more, i need a script that just takes two image paths and returns whether they are identical.
20170101 17:49:13< celticminstrel> Oh wait,PIL is PythonImage Lib
20170101 17:49:16< celticminstrel> Never mind then.
20170101 17:49:27 * celticminstrel inserts the missing spaces.
20170101 17:49:31< matthiaskrgr> PHPImageLib? :P
20170101 17:49:48< celticminstrel> There should be ways in PHP to detect that images are identical.
20170101 17:49:51< DeFender1031> i looked several months ago for something that could do it, didn't find anything.
20170101 17:49:58< DeFender1031> could do it in PHP*
20170101 17:50:02< celticminstrel> Maybe using a module.
20170101 17:50:06< DeFender1031> there should be.
20170101 17:50:21< DeFender1031> actually... I have a friend who did a bunch of image manipulation stuff in php a while back
20170101 17:50:23< celticminstrel> ImageMagick can produce image diffs, so maybe it could do this.
20170101 17:50:24< DeFender1031> I can ask him
20170101 17:50:34< DeFender1031> celticminstrel, interesting idea.
20170101 17:51:27< celticminstrel> Do you want to test binary equality or pixel equality?
20170101 17:51:32< matthiaskrgr> mh wait
20170101 17:51:34< matthiaskrgr> > I'm trhowing together a script to generate a page listing what images were removed/added/changed from 1.12.6 to 1.13
20170101 17:51:47< matthiaskrgr> so you want to know images that only "moved" and images that actually changed? 
20170101 17:52:35-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170101 17:52:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170101 17:53:17< DeFender1031> binary equality is what i have been doing, but what i really care about is whether the images are the same, not the data describing them
20170101 17:53:35< DeFender1031> matthiaskrgr, no, that i can handle in my script.
20170101 17:53:40< DeFender1031> the only part i
20170101 17:53:43< celticminstrel> So you'd prefer pixel equality.
20170101 17:53:49< DeFender1031> gah
20170101 17:54:17< DeFender1031> the only part i'm missing is basically a function i can call that takes two images and returns a boolean of whether they're identical or not.
20170101 17:54:34< DeFender1031> (based on pixelequality rather than binary equality, as celticminstrel says)
20170101 18:00:00-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170101 18:00:47< DeFender1031> zookeeper, it seems that https://wiki.wesnoth.org/TerrainCodeTableWML is hotlinking from github, so my thing will do the same.
20170101 18:04:06-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170101 18:04:06< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded
20170101 18:04:06< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-98
20170101 18:04:11-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170101 18:07:35< zookeeper> DeFender1031, okay. i suppose github serves data pretty fast.
20170101 18:08:32< zookeeper> matthiaskrgr, i probably asked this before, but does that image comparison check rgb values of completely transparent pixels?
20170101 18:08:59< zookeeper> not that that's probably relevant for this at all.
20170101 18:09:04< zookeeper> but just curious
20170101 18:09:31< zookeeper> (and if i'm only curious about something, it's not important enough to actually remember, so i end up asking it over and over again :p)
20170101 18:09:59< matthiaskrgr> mh I'm not sure
20170101 18:10:38< DeFender1031> zookeeper, yeah, the page loads slowly not because GH serves the images slow but because there are a TON of images to load.
20170101 18:11:44< zookeeper> DeFender1031, if your inlining test included the portrait diffs, then those probably were to blame for most of the filesize, i'd imagine
20170101 18:11:51< zookeeper> so make of that what you will
20170101 18:12:10< DeFender1031> zookeeper, true, but even after the resize it was still quite large.
20170101 18:12:23< DeFender1031> zookeeper, either way, it seems like a better idea to just link to GH
20170101 18:13:28< DeFender1031> zookeeper, i can DCC you the current (rather ugly and incomplete) html if you'd like to see its current state. (Same goes for anyone else who's curious.)
20170101 18:14:02< zookeeper> sure, i wouldn't mind taking a look, although DCC probably won't work
20170101 18:16:26< DeFender1031> why not?
20170101 18:16:35< zookeeper> because in my experience it never does :p
20170101 18:16:46< DeFender1031> well, we'll give it a shot.
20170101 18:17:11< DeFender1031> In my experience, it doesn't work because most people don't know how to set up their port forwarding to allow it
20170101 18:17:25< DeFender1031> I have done so and use DCC all the time.
20170101 18:17:44< DeFender1031> Anyway, you should see a DCC file transfer waiting for you to accept it.
20170101 18:17:56< DeFender1031> if this doesn't work, i'll figure out some other way.
20170101 18:17:58< zookeeper> ok, try again now
20170101 18:18:23< zookeeper> huh, rare. it works.
20170101 18:18:32< DeFender1031> like i said, it's a configuration issue.
20170101 18:18:43< DeFender1031> (also, only the sender needs forwarding set up.)
20170101 18:18:51< zookeeper> i have probably not received a successful DCC in 10+ years :p
20170101 18:18:57< DeFender1031> heh
20170101 18:19:22< DeFender1031> And I've been using it for around the same amount of time so...
20170101 18:20:16< DeFender1031> so, what do we think?
20170101 18:22:48< DeFender1031> bbiab, going over to my neighbor for a bit.
20170101 18:23:05< zookeeper> umm, seems pretty good. although i'm wondering whether it'd be better to put added images into a separate list, instead of mixing all changes together like that.
20170101 18:23:49< zookeeper> and of course if moved/renamed images could be condensed so they wouldn't show up as removed and added then that'd trim down the list quite a bit already.
20170101 18:56:07-!- mjs-de [~mjs-de@b9168e19.cgn.dg-w.de] has joined #wesnoth-dev
20170101 19:56:19< DeFender1031> okay, i'm back and my friend got back to me with a ton of information about how to compare images in php, so i can finish up this stupid script and add support for detecting identical images. As for your suggestion zookeeper, about not including the added images in the same list, my concern is images which were both moved and modified. The script as it currently is will register them as removed, so unless they're in the 
20170101 19:56:21< DeFender1031> main list, people might think they're gone rather than moved and changed. Another approach I could take is to add some logic here that checks the git history for any added images to see if they were originally in the spot where a removed image was, and if so, treat that as moved as well, though I'm not that familiar with git yet, so it might not be so simple for me to add that.
20170101 20:03:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170101 20:03:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170101 20:12:48< zookeeper> right
20170101 20:23:13< DeFender1031> there's also the possibility of trying to detect similar-but-not-exactly-the-same images, but that's probably a little crazier than is worth doing here.
20170101 20:25:04-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170101 20:25:08< vultraz_iOS> Actually I will drop support for a feature
20170101 20:26:43< zookeeper> but are you still talking about the same feature? :p
20170101 20:39:53< DeFender1031> hey vultraz_iOS, enjoying your vaca?
20170101 20:40:19< vultraz_iOS> Yes, it's refreshing
20170101 20:40:34< vultraz_iOS> How's the string utils refactor?
20170101 20:42:37< DeFender1031> going alright. i still need to write that script i mentioned to pull out all uses of the bracket syntax and create a test script out of them, but it's progressing otherwise.
20170101 20:43:07< DeFender1031> i haven't had much time to work on it though, i've had too much real life to do
20170101 20:50:37< vultraz_iOS> Good, good
20170101 20:50:42< vultraz_iOS> It's the holidays
20170101 20:51:44< DeFender1031> Aye, that it is.
20170101 20:52:38< DeFender1031> you'd think there'd be more time, but then I got invitations to parties and outings nearly every day.
20170101 20:52:49< DeFender1031> Went to laser tag twice though... that was pretty awesome.
20170101 20:53:12< DeFender1031> actually, three times, if you count the fact that the second group I went with did two games rather than just one.
20170101 20:57:13< DeFender1031> is laser tag a thing that exists wherever you guys live?
20170101 20:58:42< pydsigner> Yes
20170101 21:01:52< vultraz_iOS> Are you not stateside
20170101 21:18:07< DeFender1031> vultraz_iOS, who? me?
20170101 21:52:38-!- mjs-de [~mjs-de@b9168e19.cgn.dg-w.de] has quit [Remote host closed the connection]
20170101 21:57:39-!- JyrkiVesterinen [~JyrkiVest@87-92-35-172.bb.dnainternet.fi] has quit [Quit: .]
20170101 22:25:09-!- Kwandulin [~Miranda@p200300760F6EBF34DCC2D08CB1FB5063.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170101 22:29:21< vultraz_iOS> Yes
20170101 22:42:58-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170101 22:49:42< DeFender1031> not even close.
20170101 22:50:04< DeFender1031> Grew up there, but haven't leved in the States for over a decade now.
20170101 22:50:06< DeFender1031> lived*
20170101 22:55:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170101 23:17:56-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 260 seconds]
20170101 23:26:54-!- Appleman1234_ [~Appleman1@KD106161212047.au-net.ne.jp] has joined #wesnoth-dev
20170101 23:29:10-!- Appleman1234 [~Appleman1@KD106161209018.au-net.ne.jp] has quit [Disconnected by services]
20170101 23:29:16-!- Appleman1234_ is now known as Appleman1234
20170101 23:31:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170101 23:48:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170101 23:56:09-!- Samual [~Samual@2601:547:1000:86f:61f6:6077:78f7:4363] has joined #wesnoth-dev
20170101 23:56:09-!- Samual [~Samual@2601:547:1000:86f:61f6:6077:78f7:4363] has quit [Changing host]
20170101 23:56:09-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
--- Log closed Mon Jan 02 00:00:15 2017