--- Log opened Tue Jan 03 00:00:55 2017 20170103 00:07:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20170103 00:26:11-!- Appleman1234 [~Appleman1@KD106161213182.au-net.ne.jp] has joined #wesnoth-dev 20170103 00:38:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170103 00:43:09-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 00:43:09< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 00:43:09< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-101 20170103 00:43:13-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 00:51:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 01:06:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 01:08:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 01:08:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 01:08:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-101 20170103 01:08:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 01:15:10-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170103 01:15:27-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 245 seconds] 20170103 01:19:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20170103 01:21:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 01:26:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 01:28:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20170103 01:29:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 01:34:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 01:38:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170103 01:40:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 01:40:56< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 01:40:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-102 20170103 01:41:00-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 02:02:27-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection] 20170103 02:05:42-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 02:05:42< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 02:05:42< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-102 20170103 02:05:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 02:16:13-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20170103 03:13:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 03:18:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170103 03:18:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170103 03:34:50-!- Netsplit *.net <-> *.split quits: Appleman1234, janebot 20170103 03:35:08-!- Netsplit over, joins: Appleman1234, janebot 20170103 04:05:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 04:31:45-!- prkc [~prkc@109.201.138.239] has joined #wesnoth-dev 20170103 04:56:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20170103 05:05:44-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170103 05:07:05-!- JyrkiVesterinen [~JyrkiVest@87-100-242-239.bb.dnainternet.fi] has joined #wesnoth-dev 20170103 05:11:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds] 20170103 05:52:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 06:06:56-!- Kwandulin [~Miranda@p200300760F6EBF7661C42B543DB237A6.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 06:51:20-!- JyrkiVesterinen [~JyrkiVest@87-100-242-239.bb.dnainternet.fi] has quit [Quit: .] 20170103 06:58:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 07:07:05-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20170103 07:09:38< vultraz_iOS> Status report 20170103 07:24:48< celticminstrel> Circular 20170103 07:33:07-!- JyrkiVesterinen [~JyrkiVest@85-76-45-206-nat.elisa-mobile.fi] has joined #wesnoth-dev 20170103 08:20:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has joined #wesnoth-dev 20170103 08:22:11-!- Coffee_irc [~david@2001:44b8:254:3200:5cc4:40c0:ffe3:1583] has quit [Remote host closed the connection] 20170103 08:24:44-!- Coffee_irc [~david@2001:44b8:254:3200:4ca8:2fd6:20d4:7d00] has joined #wesnoth-dev 20170103 08:43:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 08:43:21< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 08:43:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-102 20170103 08:43:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 08:44:55< Aginor> so I'm still not able to run the tests... 20170103 08:45:08< Aginor> has anyone else run into this? 20170103 08:45:14< Aginor> Automatically found a possible data directory at /home/andreas/projects/wesnoth-master 20170103 08:45:17< Aginor> Overriding data directory with 20170103 08:45:19< Aginor> Could not find directory '' 20170103 08:45:22< Aginor> directory not found 20170103 08:46:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:9426:4ded:e4d1:bdce] has quit [Remote host closed the connection] 20170103 08:48:55< Aginor> andreas@goddess:~/projects/wesnoth-master$./wesnoth -u test_modify_ai_change_aspect --validcache --log-strict=warning 20170103 08:48:59< Aginor> for example 20170103 08:49:24< celticminstrel> Goddess, huh 20170103 08:49:42< JyrkiVesterinen> Hmm, it might be that Wesnoth interprets the unit test name as the data directory. 20170103 08:49:47< Aginor> that's the name of the big honking machine I build wesnoth on :D 20170103 08:49:58< JyrkiVesterinen> Try "-u=test_modify_ai_change_aspect". 20170103 08:50:10< JyrkiVesterinen> (i.e. equals sign instead of a space) 20170103 08:50:17< celticminstrel> I'm pretty sure I usually fo it as two separate arguments though... 20170103 08:50:24< Aginor> that works... 20170103 08:50:31< celticminstrel> ^do 20170103 08:50:37< celticminstrel> Huh. 20170103 08:50:45< Aginor> actually, it doesn't work :( 20170103 08:50:50< celticminstrel> Oh. 20170103 08:51:15< Aginor> ./wesnoth -utest_modify_ai_change_aspect --validcache --log-strict=warning seems to work though 20170103 08:51:34< Aginor> I wonder if the argument parsing has changed in versions of boost 20170103 08:52:08< Aginor> -- Boost version: 1.60.0 20170103 08:53:26< Aginor> but that does't make sense either 20170103 08:55:51-!- atarocch [~atarocch@93.68.160.250] has joined #wesnoth-dev 20170103 09:01:52-!- Kwandulin [~Miranda@p200300760F6EBF7661C42B543DB237A6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170103 09:06:40< Aginor> hmm 20170103 09:06:50< Aginor> yeah, no space seems to make it work fine 20170103 09:09:50-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 09:09:50< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 09:09:50< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-102 20170103 09:09:54-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 09:15:32-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20170103 09:15:47-!- Kwandulin [~Miranda@p200300760F6EBF76E871A078A839FFF3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 09:21:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170103 09:31:01-!- atarocch [~atarocch@93.68.160.250] has quit [Ping timeout: 248 seconds] 20170103 09:31:57< Aginor> this is exciting... 20170103 09:32:27< Aginor> so those random hangs that's been plaguing travis for ages? 20170103 09:32:32< Aginor> they're happening here too 20170103 09:32:51< Aginor> took me 6 runs or so to replicate, but it's hung here now 20170103 09:33:40< JyrkiVesterinen> Can you attach GDB or something? 20170103 09:33:49< Aginor> just did 20170103 09:34:32< Aginor> http://pastebin.com/PpA23aaM 20170103 09:34:58< Aginor> the question is if it's the same thing or not 20170103 09:35:11< Aginor> but the timeout command sure isn't killing it... 20170103 09:36:20< JyrkiVesterinen> According to that call stack, the process is stuck *because* something tried to kill it. 20170103 09:36:38< JyrkiVesterinen> In a signal handler, it tries to acquire a mutex that's already locked. 20170103 09:37:28< Aginor> yes 20170103 09:38:11< Aginor> but all of that is within X and/or the nvidia drivers 20170103 09:38:23< Aginor> which may be different within the travis setup 20170103 09:39:08< JyrkiVesterinen> Indeed. It seems none of the buggy code is under our control. 20170103 09:40:19< Aginor> I'd expect all of that to be different between my desktop machine and travis 20170103 09:41:26< Aginor> it'd be useful to know what signal was being handled 20170103 09:41:49-!- mjs-de [~mjs-de@x4db65e88.dyn.telefonica.de] has joined #wesnoth-dev 20170103 09:43:30-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 09:43:30< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 09:43:30< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-103 20170103 09:43:34-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 09:43:40< JyrkiVesterinen> One thing we could try is not initializing SDL video subsystem if we don't need video. Then X wouldn't be involved at all, and this bug wouldn't affect us. 20170103 09:43:41< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/e22c8967ee1ca4aca08b9e8d3c4d0d8c15f2b55a/src/video.cpp#L108 20170103 09:43:50< JyrkiVesterinen> IDK how feasible that would be. 20170103 09:44:50< Aginor> I suspect that it'll be going poorly 20170103 09:45:35< Aginor> there's no clear separation between rendering and game logic in many places, and all of it assumes that rendering will work 20170103 09:45:55< Aginor> there'll be many null-pointers dereferenced 20170103 09:46:25< Aginor> besides, I think there's some value in actually spinning up the whole application 20170103 09:47:46< JyrkiVesterinen> Hey, the timeout command allows us to choose the signal to send. 20170103 09:47:47< JyrkiVesterinen> https://linux.die.net/man/1/timeout 20170103 09:48:16< JyrkiVesterinen> With "timeout -s KILL" we'd at least get the process to die. 20170103 09:51:49< Aginor> yeah 20170103 09:52:08< Aginor> it'll also send a sigkill instead of a sigterm after a secondary timeout 20170103 09:52:28< Aginor> I'm currently looking at how the bash script is broken when it decides to not use that option 20170103 09:55:56< Aginor> I'm rather tempted to just take out the test, I don't see how this will not be supported on a modern OS 20170103 09:59:26< Soliton> https://github.com/wesnoth/wesnoth/commit/6957c8224 removed the allow_guessing style weirdly with a xor. should be either done properly with & ~... or reverted. 20170103 10:00:21< celticminstrel> Take out what test? 20170103 10:03:32< Aginor> it's alright, I fixed the test instead 20170103 10:03:38< Aginor> you can look shortly... 20170103 10:04:06-!- irker129 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170103 10:04:06< irker129> wesnoth: Andreas Löf wesnoth:master c820d456ec5d / run_wml_tests: Fix the check for timeout command options https://github.com/wesnoth/wesnoth/commit/c820d456ec5d1fe837ac7a77c22c764043ce29f4 20170103 10:05:30< Aginor> I also removed the space for the unit test name 20170103 10:05:56-!- Kwandulin [~Miranda@p200300760F6EBF76E871A078A839FFF3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170103 10:05:56< celticminstrel> Oh, the test for the kill-after flag. 20170103 10:06:02< Aginor> yes 20170103 10:06:08< celticminstrel> I think I added that test because my timeout doesn't support it. 20170103 10:06:18< celticminstrel> Not sure if that's true on newer MacOS though. 20170103 10:06:24< Aginor> good thing I didn't remove it then :) 20170103 10:06:41< Aginor> but the test was always failing, globally disabling it 20170103 10:09:25< Soliton> could just execute true and you can use the if normally again. 20170103 10:09:57< Soliton> (and wouldn't need to wait a second.) 20170103 10:11:27< Aginor> good point 20170103 10:11:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 10:11:31< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug ln-zookeeper 45c81b3: Removed deprecation warning of [print] red,green,blue= Succeeded 20170103 10:11:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-103 20170103 10:11:35-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 10:13:41< irker129> wesnoth: Andreas Löf wesnoth:master 1a7458cb1313 / run_wml_tests: Change the program used when testing capabilities of the "timeout" command https://github.com/wesnoth/wesnoth/commit/1a7458cb131300c454fd0465e364e1a27a9e8d06 20170103 10:19:36< Soliton> surprising that script works at all. 20170103 10:19:54< celticminstrel> Why? 20170103 10:20:27< Soliton> it lacks a remarkable number of quotes for one. 20170103 10:23:37< Soliton> i guess it works as long as the tests have simple names with no whitespace or other shell metacharacters and certain commands don't give unexpected output. 20170103 10:30:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20170103 10:33:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20170103 11:10:16-!- travis-ci [~travis-ci@ec2-54-90-126-148.compute-1.amazonaws.com] has joined #wesnoth-dev 20170103 11:10:17< travis-ci> wesnoth/wesnoth#12512 (master - c820d45 : Andreas Löf): The build passed. 20170103 11:10:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/188478082 20170103 11:10:17-!- travis-ci [~travis-ci@ec2-54-90-126-148.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170103 11:14:12< irker129> wesnoth: Elvish_Hunter wesnoth:master 795624ab4e47 / changelog data/tools/wesnoth/wmltools3.py: Teach wmlscope how to handle the square braces notation https://github.com/wesnoth/wesnoth/commit/795624ab4e479d45f34700e899652d208fef8eda 20170103 11:16:46< Elvish_Hunter> Finally I found a decent solution to do it... 20170103 11:18:49< Elvish_Hunter> Now the problem is to teach the Python tools how to handle optional macro arguments 20170103 11:21:56< zookeeper> which all tools need to be able to handle them? 20170103 11:22:55< Elvish_Hunter> Also, we have six macro files in data/core/terrain-graphics/ which contain some lines that fool wmlscope and match every single image path: new-macros.cfg, bridge.cfg, trash.cfg, editor.cfg, builder.cfg, gates.cfg 20170103 11:23:20< zookeeper> which lines would those be? 20170103 11:23:52< Elvish_Hunter> Macros containing paths like {IMAGE}.png 20170103 11:24:59< Elvish_Hunter> Since wmlscope can't perform macro substitution, it considers everything inside curly braces to match everything 20170103 11:25:25< Elvish_Hunter> As for the tools, I suppose that at least wmlindent and wmlscope need to recognize optional arguments 20170103 11:25:25< zookeeper> uh, okay. does that really make sense though, compared to just ignoring it? 20170103 11:26:43< Elvish_Hunter> That's another option. I can modify the regex and avoid matching on curly braces. 20170103 11:27:11< Elvish_Hunter> It'll all depend on the output of wmlscope with the --crossreference flag 20170103 11:29:46< zookeeper> i don't really know what's the best option there 20170103 11:31:35< zookeeper> as for wmlindent, i'd think that it probably wouldn't need updating? i mean, if it just handles multiline optional arguments like all other macro arguments, then i'd expect it to work right with them... but of course i haven't tried. maybe it messes up quoted args like FOO="bar" or maybe you were referring to the #arg syntax. 20170103 11:32:15< Elvish_Hunter> Exactly, the #arg syntax isn't yet recognized. 20170103 11:32:56< Elvish_Hunter> Although it should be easier to support it in wmlindent than in wmlscope. 20170103 11:34:22< zookeeper> seeing how little wmlscope is probably used, optional args could just be ignored for now if that's much easier to implement (and if their existence currently breaks wmlscope). 20170103 11:34:58< zookeeper> it's not a very widely-used feature after all 20170103 11:47:32-!- travis-ci [~travis-ci@ec2-54-81-242-91.compute-1.amazonaws.com] has joined #wesnoth-dev 20170103 11:47:33< travis-ci> wesnoth/wesnoth#12513 (master - 1a7458c : Andreas Löf): The build passed. 20170103 11:47:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/188480307 20170103 11:47:33-!- travis-ci [~travis-ci@ec2-54-81-242-91.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170103 12:28:24< zookeeper> ah, i think i know how i should be making a proper beach waves animation... 20170103 12:41:58-!- Kwandulin [~Miranda@p200300760F6EBF7640481CAC60557AFB.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 13:02:17-!- midzer_ [~quassel@p57B45317.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 13:02:49-!- midzer [~quassel@p57B45FB4.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 20170103 13:47:28-!- Netsplit *.net <-> *.split quits: knotwork 20170103 13:48:44-!- Netsplit over, joins: knotwork 20170103 14:04:55-!- atarocch [~atarocch@37.177.92.30] has joined #wesnoth-dev 20170103 14:14:40-!- irker129 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170103 14:19:57-!- Kwandulin [~Miranda@p200300760F6EBF7640481CAC60557AFB.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170103 14:24:30-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has joined #wesnoth-dev 20170103 14:31:43-!- atarocch [~atarocch@37.177.92.30] has quit [Remote host closed the connection] 20170103 14:41:38-!- midzer_ is now known as midzer 20170103 14:49:37-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 245 seconds] 20170103 14:51:55-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev 20170103 15:23:48-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170103 15:30:34-!- Kwandulin [~Miranda@p5DDD2183.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 15:31:53-!- JyrkiVesterinen [~JyrkiVest@85-76-45-206-nat.elisa-mobile.fi] has quit [Quit: .] 20170103 15:46:59-!- Duthlet [~Duthlet@dslb-178-012-099-073.178.012.pools.vodafone-ip.de] has quit [Ping timeout: 246 seconds] 20170103 16:08:23-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20170103 16:31:49-!- gfgtdf [~chatzilla@x4e368d35.dyn.telefonica.de] has joined #wesnoth-dev 20170103 16:32:19< gfgtdf> zookeeper: in f75dc8d17240278adf583a6adbc6d871d18f9be1 i wonder what will happen if the unit has level 0? will the player then get old for those units per turn? 20170103 16:40:44-!- Coffee_irc [~david@2001:44b8:254:3200:4ca8:2fd6:20d4:7d00] has quit [Ping timeout: 258 seconds] 20170103 16:42:01-!- mjs-de [~mjs-de@x4db65e88.dyn.telefonica.de] has quit [Ping timeout: 246 seconds] 20170103 16:45:49-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 16:45:49< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Elvish_Hunter 795624a: Teach wmlscope how to handle the square braces notation Succeeded 20170103 16:45:49< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-103 20170103 16:45:54-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 17:03:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 17:03:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20170103 17:07:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds] 20170103 17:13:38-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 17:13:38< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Elvish_Hunter 795624a: Teach wmlscope how to handle the square braces notation Succeeded 20170103 17:13:38< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-103 20170103 17:13:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 17:13:46-!- Kwandulin [~Miranda@p5DDD2183.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170103 17:23:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 17:25:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170103 17:25:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 17:26:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170103 17:26:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 17:45:30-!- JyrkiVesterinen [~JyrkiVest@89-166-114-214.bb.dnainternet.fi] has joined #wesnoth-dev 20170103 17:48:13-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 17:48:13< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Elvish_Hunter 795624a: Teach wmlscope how to handle the square braces notation Succeeded 20170103 17:48:13< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-104 20170103 17:48:17-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 18:12:43< zookeeper> gfgtdf, not directly... but it looks like the lvl0 units still count against the "1 unit supported per village" thing, so in fact yeah moving lvl0 units next to a support unit can increase income that way. 20170103 18:13:32< zookeeper> you can't get any lvl0 units so i didn't bother taking them into account, but i guess i'll fix that anyway 20170103 18:13:40-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170103 18:13:40< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Elvish_Hunter 795624a: Teach wmlscope how to handle the square braces notation Succeeded 20170103 18:13:40< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-104 20170103 18:13:44-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170103 18:15:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20170103 18:17:49-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20170103 18:17:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20170103 18:27:42< gfgtdf> s/old/gold, thx for fixing it. (formula has a max function afaik) 20170103 18:29:52-!- irker953 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170103 18:29:52< irker953> wesnoth: Jyrki Vesterinen wesnoth:master eeaba62fd434 / src/events.cpp: Fix bug #25410: Missing mouse input events https://github.com/wesnoth/wesnoth/commit/eeaba62fd434be82f6383164a5f2fcc50e8921e4 20170103 19:28:39-!- atarocch [~atarocch@31.157.134.35] has joined #wesnoth-dev 20170103 19:29:33-!- Kwandulin [~Miranda@p200300760F6EBF76415119A192BD8171.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 19:35:52-!- Netsplit *.net <-> *.split quits: TC01, clavi, Sirp, Aginor 20170103 19:35:52-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev 20170103 19:35:55-!- Netsplit over, joins: TC01 20170103 19:35:55-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host] 20170103 19:35:55-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev 20170103 19:35:59-!- Sirp_ [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev 20170103 19:36:06-!- Netsplit over, joins: clavi 20170103 19:41:44-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20170103 19:48:06-!- atarocch [~atarocch@31.157.134.35] has quit [Remote host closed the connection] 20170103 20:04:17-!- JyrkiVesterinen [~JyrkiVest@89-166-114-214.bb.dnainternet.fi] has quit [Quit: .] 20170103 20:55:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 20:59:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20170103 21:18:26-!- Kwandulin_2 [~Miranda@p200300760F6EBF76415119A192BD8171.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170103 21:19:47-!- Kwandulin [~Miranda@p200300760F6EBF76415119A192BD8171.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 20170103 21:30:41-!- irker953 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170103 21:33:13-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170103 21:33:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 21:38:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds] 20170103 21:45:27-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20170103 22:10:00-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 258 seconds] 20170103 22:16:09-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev 20170103 22:22:09-!- mjs-de [~mjs-de@x4db65e88.dyn.telefonica.de] has joined #wesnoth-dev 20170103 22:30:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 22:34:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170103 22:41:25-!- Kwandulin_2 [~Miranda@p200300760F6EBF76415119A192BD8171.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170103 22:43:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170103 22:43:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170103 22:51:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170103 22:56:53-!- mjs-de [~mjs-de@x4db65e88.dyn.telefonica.de] has quit [Ping timeout: 248 seconds] 20170103 23:29:33-!- Appleman1234 [~Appleman1@KD106161213182.au-net.ne.jp] has quit [Ping timeout: 256 seconds] 20170103 23:36:56-!- Coffee_irc [~david@2001:44b8:254:3200:4ca8:2fd6:20d4:7d00] has joined #wesnoth-dev 20170103 23:40:04< zookeeper> celticminstrel, in [modify_unit], are the keys/tags guaranteed to be handled in the written order? like if i have [modify_unit] hitpoints=$this_unit.max_hitpoints max_hitpoints=$this_unit.hitpoints [/modify_unit] (nonsensical example) then can the unit's max_hitpoints ever get modified? 20170103 23:40:26< zookeeper> and by modified i mean changed, of course. 20170103 23:41:40< celticminstrel> Uh. Probably not? 20170103 23:42:04< celticminstrel> That is, there's probably no guarantee about order. 20170103 23:42:17< celticminstrel> I believe the original ordering of keys is lost when processing the WML. 20170103 23:43:16< zookeeper> right. so in those kinds of cases where order matters, you should use two [modify_unit]s 20170103 23:43:21< celticminstrel> And could then be lost again if the WML table is converted to a Lua table. 20170103 23:43:28< celticminstrel> Yeah, I would recommend that. 20170103 23:43:36< zookeeper> all right then 20170103 23:44:17< celticminstrel> (The order keys are stored as a WML table and the order keys are stored as a Lua table is unlikely to be the same, as the latter is a hashtable and the former is a binary tree.) 20170103 23:44:45< Ravana_> https://www.wesnoth.org/macro-reference.html loads css from http which makes chrome complain 20170103 23:45:01< celticminstrel> If you think it's worthwhile it should be easy to accept eg a [then] subtag of [modify_unit] for forcing specific ordering of effects. 20170103 23:45:31< celticminstrel> No idea if it's worthwhile, this doesn't seem like a thing that would matter frequently. 20170103 23:46:11< zookeeper> yeah, i don't know. it's a bugger WRT this one very specific thing i'm doing right now, but should be pretty rare. 20170103 23:46:36< zookeeper> so probably not worth doing anything about it until you get lots of complaints about it 20170103 23:47:05< celticminstrel> Ravana_: Well, that should be easily fixed by anyone who has access to that server (just delete the domain prefix of the link). 20170103 23:53:52< Ravana_> celticminstrel: wouldn't it work to just change this file https://github.com/wesnoth/wesnoth/blob/dc89612dc4cde077dfa55dd062925bffdc77f6c8/data/tools/helpheader.html#L12-L13 20170103 23:54:38< celticminstrel> That is indeed the relevant file. I have no idea if that's automatically updated to the website. 20170103 23:54:49< celticminstrel> I guess I could test it. 20170103 23:58:27< celticminstrel> Ah, looks like it's not. 20170103 23:58:42< celticminstrel> Well, I can at least fix the issue, presumably. 20170103 23:59:42< celticminstrel> Huh, apparently it's wmlscope that extracts documentation from the macro files. --- Log closed Wed Jan 04 00:00:13 2017