--- Log opened Thu Feb 23 00:00:15 2017
20170223 00:14:40-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 260 seconds]
20170223 00:15:15-!- Shiki_ [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170223 00:39:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20170223 00:42:18-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 00:42:18< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 00:42:18< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-253
20170223 00:42:22-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 00:54:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 01:03:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170223 01:03:21-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170223 01:07:44-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 01:07:44< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 01:07:44< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-253
20170223 01:07:48-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 01:16:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170223 01:31:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170223 01:42:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 01:42:20< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 01:42:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-256
20170223 01:42:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 01:54:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 01:55:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 01:59:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170223 02:03:21-!- gfgtdf_ [~chatzilla@x4e3685b8.dyn.telefonica.de] has joined #wesnoth-dev
20170223 02:05:12-!- gfgtdf__ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 02:05:47-!- gfgtdf [~chatzilla@x4e3685b8.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170223 02:05:52-!- gfgtdf__ is now known as gfgtdf
20170223 02:08:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 02:08:31< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 02:08:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-256
20170223 02:08:35-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 02:08:44-!- gfgtdf_ [~chatzilla@x4e3685b8.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 02:48:33-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 02:50:27-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 02:50:28-!- gfgtdf_ is now known as gfgtdf
20170223 03:16:44-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 03:21:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20170223 03:29:18-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 03:30:14-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 03:30:28-!- gfgtdf_ is now known as gfgtdf
20170223 03:33:17-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 03:36:47-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170223 03:36:56-!- gfgtdf_ is now known as gfgtdf
20170223 03:40:50-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 03:42:27-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 03:42:30-!- gfgtdf_ is now known as gfgtdf
20170223 04:00:27-!- madmax28 [~madmax28@xdsl-87-78-220-107.netcologne.de] has quit [Ping timeout: 240 seconds]
20170223 04:03:08-!- madmax28 [~madmax28@xdsl-213-196-251-253.netcologne.de] has joined #wesnoth-dev
20170223 04:12:03-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]]
20170223 04:24:44-!- Appleman1234 [~Appleman1@pl1971.nas824.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170223 04:36:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 04:54:52-!- Appleman1234 [~Appleman1@pl2450.nas82g.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170223 04:55:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 04:59:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 05:04:54-!- Kwandulin [~Miranda@p200300760F7B9691502FAABB272491C7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 05:06:09-!- JyrkiVesterinen [~JyrkiVest@87-100-209-16.bb.dnainternet.fi] has joined #wesnoth-dev
20170223 05:52:39-!- Kwandulin [~Miranda@p200300760F7B9691502FAABB272491C7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170223 06:41:40-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170223 06:43:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 06:48:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 06:57:29-!- JyrkiVesterinen [~JyrkiVest@87-100-209-16.bb.dnainternet.fi] has quit [Quit: .]
20170223 07:04:22-!- mjs-de [~mjs-de@x5ce4a395.dyn.telefonica.de] has joined #wesnoth-dev
20170223 07:05:38-!- mjs-de [~mjs-de@x5ce4a395.dyn.telefonica.de] has quit [Remote host closed the connection]
20170223 07:34:00-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170223 07:53:17-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170223 07:54:01-!- atarocch [~atarocch@93.56.160.29] has joined #wesnoth-dev
20170223 08:11:19-!- Duthlet [~Duthlet@dslb-188-105-113-146.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170223 08:31:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 08:36:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 08:44:12-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 08:44:12< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 08:44:12< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-254
20170223 08:44:16-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 09:08:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 09:08:37< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 09:08:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-254
20170223 09:08:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 09:24:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20170223 09:43:15-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 09:43:15< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 09:43:15< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-257
20170223 09:43:20-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 09:45:13< Soliton> why was it again that appveyor cannot be configured to just build on changes?
20170223 09:45:49< JyrkiVesterinen> In theory, it can. And I initially configured it that way.
20170223 09:46:07< JyrkiVesterinen> Unfortunately AppVeyor didn't build at all with that configuration.
20170223 09:46:20< Soliton> can we try that again?
20170223 09:46:38< Soliton> it's really annoying currently.
20170223 09:47:42< JyrkiVesterinen> Done. Scheduled builds are now disabled. :)
20170223 09:48:21< Soliton> thanks.
20170223 09:50:19< Soliton> if it still doesn't work maybe another idea is to only announce on failure.
20170223 09:51:29< JyrkiVesterinen> That would be trivial to do, by removing this line, and the equivalent line in .appveyor.vs2015.yml:
20170223 09:51:30< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/.appveyor.vs2013.yml#L22
20170223 09:52:08< JyrkiVesterinen> ...not that line, line 19. Oops. :D
20170223 09:54:52< Soliton> have we done this thing? http://help.appveyor.com/discussions/questions/528-unable-to-setup-github-auto-build-on-commit
20170223 09:59:46< JyrkiVesterinen> No, we haven't. I looked into the situation a bit.
20170223 09:59:46< JyrkiVesterinen> https://www.appveyor.com/docs/
20170223 09:59:55< JyrkiVesterinen> "For every project AppVeyor will configure webhooks for its repository to automatically start a build when you push the changes."
20170223 10:00:37< JyrkiVesterinen> However, it seems like creating webhooks happens in the GitHub repository settings file, which I can't access.
20170223 10:01:22< JyrkiVesterinen> I believe that because I was the one to integrate AppVeyor, and I don't have necessary privileges to set up webhooks, AppVeyor couldn't set up the webhook.
20170223 10:01:33< JyrkiVesterinen> Which would explain why building on push doesn't work.
20170223 10:01:34< Soliton> right, was going to say that.
20170223 10:02:10< Soliton> maybe you can ask vultraz to take a look.
20170223 10:03:40-!- Bonobo [~Bonobo@2001:44b8:254:3200:b06b:1fb3:3ccb:50ad] has quit [Ping timeout: 255 seconds]
20170223 10:04:02-!- Bonobo [~Bonobo@2001:44b8:254:3200:b06b:1fb3:3ccb:50ad] has joined #wesnoth-dev
20170223 10:06:52< JyrkiVesterinen> Hmm... I think the only easy solution would be if someone with necessary permissions created completely new AppVeyor projects.
20170223 10:07:30< JyrkiVesterinen> I think I'll just restore scheduled builds and set them to only send an IRC notification on failure.
20170223 10:10:47-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170223 10:10:47< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Debug Jyrki Vesterinen afb7715: Update image modification unit tests Succeeded
20170223 10:10:47< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-257
20170223 10:10:49< Soliton> sounded to me like you can just add the webhook to github separately. no need to redo everything.
20170223 10:10:51-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170223 10:11:41< JyrkiVesterinen> I couldn't find any documentation about how to do that. It looks like AppVeyor relies on automatic webhook adding.
20170223 10:11:53-!- astrelyon [~astrelyon@85.114.46.74] has joined #wesnoth-dev
20170223 10:12:25< Soliton> if you read the link i mentioned earlier that heavily implies that you can do it manually.
20170223 10:12:57< JyrkiVesterinen> The link is from 2014. AppVeyor has likely changed since then.
20170223 10:13:32< JyrkiVesterinen> There is an official REST endpoint to trigger a new build, but it's incompatible with GitHub's built-in webhooks: https://www.appveyor.com/docs/api/projects-builds/#start-build-of-branch-most-recent-commit
20170223 10:14:15< JyrkiVesterinen> If we wanted to use that endpoint, we'd need a server in the middle to translate the GitHub webhook into the Appveyor API call.
20170223 10:17:58-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: Lunch]
20170223 10:20:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 10:24:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 10:43:53-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170223 10:45:30-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Network is unreachable]
20170223 10:45:45-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170223 10:52:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 10:59:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170223 11:00:44-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 240 seconds]
20170223 11:05:37-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170223 11:06:01< vultraz_iOS> oh huh IRCCloud has a web client
20170223 11:06:30< vultraz_iOS> looks better on mobile kinda
20170223 11:09:44-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20170223 11:10:47< vultraz_iOS> do you guys have anything i need to address?
20170223 11:12:02< JyrkiVesterinen> Soliton suggested adding webhooks to the GitHub repository, which would allow AppVeyor to build on push.
20170223 11:12:10< JyrkiVesterinen> I believe it would be too difficult to do, however.
20170223 11:14:04< JyrkiVesterinen> Would you be willing to just create new AppVeyor projects (which would allow Appveyor to set up the webhooks automatically)?
20170223 11:14:11< JyrkiVesterinen> Instructions are in https://github.com/wesnoth/wesnoth/pull/884
20170223 11:14:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 11:16:21< vultraz_iOS> I don't follow what the projects have to do with webhooks
20170223 11:16:41< vultraz_iOS> or why it's absolutely necessary to have build-on-push for both systems
20170223 11:17:16< JyrkiVesterinen> Appveyor attempts to automatically set up webhooks when a project is created.
20170223 11:17:43< JyrkiVesterinen> Most likely it failed to do so when I set up the projects because I don't have the necessary permissions.
20170223 11:18:05-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170223 11:18:12< JyrkiVesterinen> If you were to create new projects, setting up webhooks would most likely succeed.
20170223 11:18:36< JyrkiVesterinen> Regarding build-on-push, I don't find it "absolutely necessary" either.
20170223 11:20:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170223 11:23:03< vultraz_iOS> hmmm
20170223 11:23:19< Soliton> it's not "absolutely necessary" to use appveyor either.
20170223 11:34:35-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20170223 11:36:35-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20170223 11:38:44-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Client Quit]
20170223 11:41:15-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20170223 12:08:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 12:12:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 12:15:18-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170223 12:20:53-!- irker420 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170223 12:20:53< irker420> wesnoth: ln-zookeeper wesnoth:master d22711af3dd3 / data/campaigns/Eastern_Invasion/scenarios/17b_Weldyn_Besieged.cfg: EI: Redesigned the lich identity revealing system, and other tweaks https://github.com/wesnoth/wesnoth/commit/d22711af3dd3c4095ea5920f348e38e35c6b6a60
20170223 12:24:25< vultraz_iOS> zookeeper: I'll leave it up to you to merge https://github.com/wesnoth/wesnoth/pull/915 and https://github.com/wesnoth/wesnoth/pull/927
20170223 12:24:31-!- horrowind [~Icedove@2a02:810a:83c0:e4b4:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20170223 12:25:21< vultraz_iOS> and what to do with https://github.com/wesnoth/wesnoth/pull/935
20170223 12:28:05< vultraz_iOS> also, to everyone: despite 1.12 being essentially EOL, I'm declaring it officially EOL once 1.13.8 (which will hopefully be 1.14 RC1) is released. Note this is *not* the next release, which is 1.13.7
20170223 12:28:47< Soliton> and what does that mean?
20170223 12:29:45< vultraz_iOS> Practically, nothing, except I suppose it means we'll no longer be adding new translations/bug fixes of any kind to 1.12
20170223 12:30:37-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.7 scheduled for Saturday, March 4th 00:00 UTC | Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170223 12:30:49< vultraz_iOS> er, wait
20170223 12:31:03-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.7 scheduled for Sunday, March 5th 00:00 UTC | Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170223 12:32:51< Soliton> so if a bug is discovered in 1.12 when 1.13.8 is released we do what?
20170223 12:32:58-!- Kwandulin [~Miranda@p200300760F7B96626509889D186D2104.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 12:33:22< vultraz_iOS> nothing. We'll no longer be supporting 1.12.
20170223 12:33:58-!- Bonobo [~Bonobo@2001:44b8:254:3200:b06b:1fb3:3ccb:50ad] has quit [Ping timeout: 255 seconds]
20170223 12:34:11< Soliton> how did you come up with that policy change?
20170223 12:34:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 12:34:43< vultraz_iOS> (Obviously, the servers will remain up)
20170223 12:34:46-!- Bonobo [~Bonobo@2001:44b8:254:3200:b06b:1fb3:3ccb:50ad] has joined #wesnoth-dev
20170223 12:35:08< vultraz_iOS> well, we need to declare 1.12 EOL offically sometime
20170223 12:35:19< vultraz_iOS> would you rather it be done precisely when 1.124 is out?
20170223 12:35:26< vultraz_iOS> 1.14*
20170223 12:35:44< Soliton> that'd at least make sense.
20170223 12:36:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170223 12:37:03< vultraz_iOS> ok, then
20170223 12:37:10< vultraz_iOS> as soon as 1.14 is out 1.12 is EOL
20170223 12:37:21< zookeeper> that's how it's usually worked
20170223 12:38:08< Soliton> btw, i'm asking how you came up with that policy because you don't need to make these up alone you know, you can discuss them first with other developers.
20170223 12:38:30< vultraz_iOS> I just came up with it
20170223 12:38:55< vultraz_iOS> since 1.12 has been practically EOL for months now
20170223 12:39:10< Soliton> depends on what you mean with EOL.
20170223 12:39:44< Soliton> we've fixed security bugs or just bugs that prevent building even in much older releases.
20170223 12:40:07< Soliton> and there is no reason why we should forbid that or whatever you intend with your policy.
20170223 12:40:21< vultraz_iOS> obviously those are an exception
20170223 12:40:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 12:40:59< vultraz_iOS> but we've essentially sidelined 1.12 for 1.13 for a long time now, even if there's a bug that appears in both.
20170223 12:41:26< vultraz_iOS> so we might as well declare it officially EOL soon
20170223 12:42:19< Soliton> well, that's great that that is obvious to you. quite obviously it is not obvious at least to me so you may have to clarify what EOL means to you.
20170223 12:42:52< vultraz_iOS> no new releases, no translation updates, no bug fixes or backports besides security ones
20170223 12:47:08< vultraz_iOS> also, i have a proposal for a new rolling release model after 1.14 I need to discuss with you guys
20170223 12:47:49< zookeeper> we could also backport what can easily be backported and then do a final 1.12.7 release if there's a meaningful amount of fixes.
20170223 12:47:59< vultraz_iOS> essentially, would there be any benefit to dropping the stable/dev cycles and simply working on and pushing each new release as they are completed
20170223 12:48:28< zookeeper> uh... yes, but quite dwarfed by the drawbacks i'm sure
20170223 12:48:50< vultraz_iOS> what are the drawbacks?
20170223 12:48:53< zookeeper> the obvious one
20170223 12:48:55< zookeeper> come on now
20170223 12:49:17< vultraz_iOS> bugs?
20170223 12:50:03< zookeeper> yes, you can't have a bugfix release which doesn't also introduce a dozen other bugs due to someone's fancy new rewrites or whatever.
20170223 12:53:25< zookeeper> AFAICT that kind of release model only works if there's no big overhauls requiring lots of testing being done, but only smaller iterative improvements.
20170223 12:53:39< vultraz_iOS> well, there are two methods to consider: I'll call them the Dota 2 model and the Terraria model. In the former case, bugfixes are distributed via steam on a potentially daily basis, in the form of small patches. Steam enables this easily, *but* it might not be good for us since it would mean Steam users have features before "desktop" releases. In the latter
20170223 12:53:39< vultraz_iOS> case is more akin to our current one: new releases are pushed out periodically, major ones interspaced by minor bugfix/feature releases
20170223 12:54:39< vultraz_iOS> obviously big changes are held off on until ready in both cases
20170223 12:55:30< vultraz_iOS> I question whether our model of 2+ years between "stable" releases is the bets course to take from here on in
20170223 12:55:33< vultraz_iOS> best*
20170223 12:56:37< vultraz_iOS> even in stable series, a bug may be fixed and sit in the repo for months before we accumulate enough changes to make a new release
20170223 12:57:18< zookeeper> well of course everyone would like a patching feature
20170223 12:57:23< vultraz_iOS> Steam should allow these more minor fixes to be pushed out as patches.
20170223 12:57:48< vultraz_iOS> though how exactly that works I don't know
20170223 12:58:35< vultraz_iOS> if we decide to take that route, Steam users would have more up-to-date and less buggy games than desktop app users
20170223 12:59:18< Soliton> before deciding on a new model requiring new technical features it might be good to have those features working.
20170223 13:00:26< vultraz_iOS> yes, true
20170223 13:01:16< vultraz_iOS> I have not yet begun to figure out how the steam releases will work
20170223 13:01:16< vultraz_iOS> who will handle them, how they will be handled...
20170223 13:01:25< Soliton> i agree that a 2 year release cycle is not good. the question is how to do it better with the resources we have.
20170223 13:02:48-!- Kwandulin_2 [~Miranda@p200300760F7B96626509889D186D2104.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 13:03:05< vultraz_iOS> indeed
20170223 13:03:18< vultraz_iOS> I'm not declaring anything at this point, just putting the ideas out there
20170223 13:03:39< vultraz_iOS> I still need to figure out the actual steam release pipeline, as you say :P
20170223 13:04:01-!- Kwandulin [~Miranda@p200300760F7B96626509889D186D2104.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170223 13:04:05< zookeeper> since i mostly just work on very iterative stuff, i wouldn't mind a rolling release model that much myself, but seeing how broken things tend to get in dev branches, it'd mean that developers in general would really have to change the way they do things.
20170223 13:06:55< JyrkiVesterinen> No one should break stuff and then leave it broken for a long time.
20170223 13:07:22< vultraz_iOS> indeed
20170223 13:07:37< vultraz_iOS> stuff will obviously break in the course of refactors of the introduction of new features
20170223 13:07:44< vultraz_iOS> but that should be fixed quickly
20170223 13:07:45< JyrkiVesterinen> I'd say that the existence of dev branches only makes the problem worse. When there can be even over an year until the next release, it opens up the possibility of just leaving severe bugs there.
20170223 13:07:58< JyrkiVesterinen> Personally I'm in favor of dropping dev branches.
20170223 13:09:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170223 13:10:07< DeFender1031> I too vote for not committing anything broken to master and no dev branches, that way if something broken DOES get committed to master, people will notice it quickly because they're USING it.
20170223 13:10:08< zookeeper> sure, but at least the dev releases are clearly named as experimental and that ordinary players should stick to stable releases. even if it does allow people to leave bugs lingering for a long time because it's "only" a dev branch, making it so that everything goes straight to the next "stable" version might make it prohibitively difficult to actually get any major changes done and tested 
20170223 13:10:08< zookeeper> well enough.
20170223 13:11:21< DeFender1031> zookeeper, i thought the whole point of git was to have branches where you can make and test major changes as an isolated unit while still maintaining the working codebase until that unit is ready for merging.
20170223 13:12:35< zookeeper> DeFender1031, generally almost no one will test someone else's feature branches. if people are personally very interested in what's in that branch then they might, but they will get no "passive" testing.
20170223 13:13:17< zookeeper> i constantly stumble on bugs others have introduced, when just trying to do my own stuff
20170223 13:14:16< vultraz_iOS> speaking of which...
20170223 13:14:22< vultraz_iOS> DeFender1031: any progress on the string stuff?
20170223 13:14:57< vultraz_iOS> zookeeper: wasn't there something you wanted me to revert...?
20170223 13:15:32< vultraz_iOS> oh, and..
20170223 13:15:32< vultraz_iOS> Elvish_Hunter: ping ping
20170223 13:15:53< Soliton> not having a clearly experimental release/branch might help devs not get into the mindset that they can just break stuff and not care that much that they get fixed (since it's the dev branch "someone" will clean it up before stable release).
20170223 13:15:57< DeFender1031> And that's fine, so long as people take responsibility for testing their own code and don't leave it as someone else's problem. I'll tell you also that in my day job, each module in the code "belongs" to a particular dev, meaning that the code therein is primarily worked on by that one dev, and any bugs in that module are that dev's responsibility. Each dev is responsible for testing their code to a reasonable degree BEFORE 
20170223 13:15:58< DeFender1031> sending it to QA, and that if after that any bug is discovered in one of their modules, they are required to drop whatever other project they're working on for the half hour or hour that it takes to fix the bug.
20170223 13:15:58< zookeeper> <zookeeper> vultraz, the blonde TC/palette/whatever thing in test scenario, and the DiD:11 guardians
20170223 13:17:24-!- Kwandulin_2 [~Miranda@p200300760F7B96626509889D186D2104.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170223 13:17:28< vultraz_iOS> i see, i see...
20170223 13:17:36< vultraz_iOS> right, the first was a dropped feature
20170223 13:17:58< DeFender1031> vultraz_iOS, unfortunately my day job is up against a release deadline and making sure that we can deliver has mostly taken over my life at the moment.
20170223 13:18:22< vultraz_iOS> ah, ok
20170223 13:19:19< Bonobo> you could just add another decimal to the releases and change the third for the major change releases, but having four numbers like 1.14.0.3 is a bit long
20170223 13:19:44< DeFender1031> vultraz_iOS, On the one hand, I don't want to seem like the flaky volunteer who promises to do stuff and then doesn't follow through, but on the other, making sure that I continue to have a roof over my head and the electricity necessary to do this stuff has to take priority.
20170223 13:20:13< vultraz_iOS> obviously, obviously 
20170223 13:20:35< vultraz_iOS> hopefully you can make it into 1.13.8, though
20170223 13:20:49< DeFender1031> when's that likely to be?
20170223 13:21:56< vultraz_iOS> let's aim for... mid-April?
20170223 13:36:18< vultraz_iOS> also, to everyone: if I'm not around here you can always reach me on Discord
20170223 13:47:05< matthiaskrgr> hmm will some of the crashes I reported get fixed for 1.13.7 ? 
20170223 13:51:37< vultraz_iOS> perhaps
20170223 13:52:15< matthiaskrgr> hmm, did I not report the MP screen crash?!?
20170223 13:53:18< vultraz_iOS> eh?
20170223 13:53:51< vultraz_iOS> zookeeper: do you want the DiD commit reverted, or just GUARDIAN applied to each of the GENERIC_UNITs?
20170223 13:54:20< matthiaskrgr> strange! I can't find a ticket for that... The crash was so prevalent that I as 99% sure I already reported this
20170223 13:54:21< zookeeper> i don't remember what else the commit did, so dunno
20170223 13:54:29< zookeeper> whatever works
20170223 13:54:32-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 260 seconds]
20170223 13:54:32< vultraz_iOS> if i revert it they get the loyal overlay back
20170223 13:54:41< vultraz_iOS> is it important they have it?
20170223 13:55:15< zookeeper> i don't know, as said i don't remember what the commit does or why or whether it fixes some user-visible problem or not
20170223 13:55:26< vultraz_iOS> ok, just guardian for now
20170223 13:55:48< matthiaskrgr> in the game lobby, when assigning players to teams, the game crashes when clicking on "south" or "north" faction-location of a player
20170223 13:55:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 13:56:58< vultraz_iOS> matthiaskrgr: is this still on master?
20170223 13:57:11< matthiaskrgr> yes
20170223 13:57:24< matthiaskrgr> didn't we already have this for some other menu where it was fixed?
20170223 13:57:37< matthiaskrgr> (it's a heap use after free crash)
20170223 13:57:59< vultraz_iOS> it was apparent in that menu and i fixed it :/
20170223 13:58:06< matthiaskrgr> hm :(
20170223 13:58:18< matthiaskrgr> I'll update my build and make a ticket
20170223 14:00:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 14:01:55-!- UnwiseOwl [~UnwiseOwl@85.255.237.203] has joined #wesnoth-dev
20170223 14:02:59< irker420> wesnoth: Charles Dang wesnoth:master 504487b34052 / src/game_config.cpp: Game Config: Game Config: fixup tc_info not parsing the color range correctly https://github.com/wesnoth/wesnoth/commit/504487b34052d756ccfec4608c86d622cba4759c
20170223 14:03:02< irker420> wesnoth: Charles Dang wesnoth:master a6d84b87cd46 / data/scenario-test.cfg: Test Scenario: covert RGB-format color ranges and palettes to hex format https://github.com/wesnoth/wesnoth/commit/a6d84b87cd461009cef26b48cf51e3854cfd14b6
20170223 14:03:05< irker420> wesnoth: Charles Dang wesnoth:master 1c7ac5a3ea02 / data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg: DiD S11: fixup 288c307a9 https://github.com/wesnoth/wesnoth/commit/1c7ac5a3ea026e3bd309f4c70bf7c4178f511a5f
20170223 14:03:08< irker420> wesnoth: Charles Dang wesnoth:master e24336afeb7b / data/gui/macros/ (horizontal_scrollbar.cfg vertical_scrollbar.cfg): GUI2: temporarily remove directional buttons from scrollbars https://github.com/wesnoth/wesnoth/commit/e24336afeb7bce5fab3b918fdff309d7e748675e
20170223 14:03:17< vultraz_iOS> zookeeper: ^
20170223 14:03:28< vultraz_iOS> matthiaskrgr: cannot repro bug
20170223 14:04:09< matthiaskrgr> did you do a normal or an asan-build? 
20170223 14:04:30< zookeeper> vultraz_iOS, excellent
20170223 14:04:36< matthiaskrgr> a use after free might not always crash without asan 
20170223 14:05:10< vultraz_iOS> normal
20170223 14:05:41< matthiaskrgr> ok
20170223 14:05:50< matthiaskrgr> I'm not surprised then ;) 
20170223 14:05:56< matthiaskrgr> rebuilding still in progress
20170223 14:12:57-!- Bonobo [~Bonobo@2001:44b8:254:3200:b06b:1fb3:3ccb:50ad] has quit [Quit: Leaving]
20170223 14:15:34-!- Appleman1234 [~Appleman1@pl2450.nas82g.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170223 14:16:00-!- DeFender1031 [~DeFender1@46-116-117-53.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170223 14:16:48-!- UnwiseOwl [~UnwiseOwl@85.255.237.203] has quit [Ping timeout: 268 seconds]
20170223 14:25:10-!- DeFender1031 [~DeFender1@46-116-117-53.bb.netvision.net.il] has joined #wesnoth-dev
20170223 14:29:22< matthiaskrgr> still crashes, yup
20170223 14:30:58< vultraz_iOS> new bug report plox
20170223 14:31:23< vultraz_iOS> ftr is this still an issue? https://gna.org/bugs/index.php?25393
20170223 14:33:15< irker420> wesnoth: Charles Dang wesnoth:master b8bdea84873d / data/gui/window/ (addon_list.cfg addon_manager.cfg): Addons Manager: rename WML file https://github.com/wesnoth/wesnoth/commit/b8bdea84873d52afd05786381190f6595158c8a5
20170223 14:33:31-!- Appleman1234 [~Appleman1@pl173.nas825.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170223 14:33:31< matthiaskrgr> https://gna.org/bugs/index.php?25534   
20170223 14:39:03-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has joined #wesnoth-dev
20170223 14:39:35< vultraz_iOS> gah
20170223 14:39:42< vultraz_iOS> how to investigate this...
20170223 14:39:54< vultraz_iOS> the tree view uses a boost::ptr_vector 
20170223 14:41:36< vultraz_iOS> yeah I have no idea here :/
20170223 14:43:30< matthiaskrgr> :(
20170223 14:44:34< vultraz_iOS> well..
20170223 14:45:01< vultraz_iOS> the vector keeps two vector of tree_view_node pointers..
20170223 14:45:05< vultraz_iOS> er
20170223 14:45:06< vultraz_iOS> the class
20170223 14:45:10< vultraz_iOS> keeps two vectors
20170223 14:46:15< vultraz_iOS> pointers here are ressigned when you change teams..
20170223 14:46:15< vultraz_iOS> side_tree_map_[side] = &node;
20170223 14:46:26< vultraz_iOS> is it possible the old pointer is left dangling somewhere
20170223 14:47:58< vultraz_iOS> i should probably really, really use a shared_ptr here
20170223 14:48:03< vultraz_iOS> and really, the tree view widget should
20170223 14:53:10-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 14:57:20< vultraz_iOS> weelll this didn't work
20170223 14:58:15< vultraz_iOS> i get a crash if i make this dialog use smart pointers
20170223 14:58:19< vultraz_iOS> wonder what this means
20170223 14:59:12< matthiaskrgr> the crash refuses to be outsmarted? :p
20170223 14:59:13< JyrkiVesterinen> "A crash" tells almost nothing. What's the error message? Call stack may also be useful.
20170223 15:02:35< vultraz_iOS> https://www.irccloud.com/pastebin/sakc0gIG/
20170223 15:03:07-!- astrelyon [~astrelyon@85.114.46.74] has quit [Quit: WeeChat 1.4]
20170223 15:03:20< vultraz_iOS> nothing much here..
20170223 15:03:53< JyrkiVesterinen> You haven't shown the error message, only the call stack...
20170223 15:04:45-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 15:05:13< vultraz_iOS> there is none, just a crash 
20170223 15:05:19< vultraz_iOS> i don' have matthiaskrgr's fancy build
20170223 15:05:23< vultraz_iOS> don't*
20170223 15:05:50< matthiaskrgr> :>
20170223 15:05:53< matthiaskrgr> do you have gcc or clang available?
20170223 15:06:35< JyrkiVesterinen> I don't have ASAN either, but I do get an useful error message when the game crashes under a debugger.
20170223 15:06:42< matthiaskrgr> JyrkiVesterinen: the attached files includes the asan error message + stacks   https://www.irccloud.com/pastebin/sakc0gIG/
20170223 15:06:45< matthiaskrgr> err
20170223 15:06:47< matthiaskrgr> https://gna.org/bugs/index.php?25534  
20170223 15:07:00< vultraz_iOS> well, it just says segfault
20170223 15:07:14-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 15:07:24-!- gfgtdf_ is now known as gfgtdf
20170223 15:08:07< JyrkiVesterinen> Segfault points at dereferencing an invalid pointer or reference. That's at least useful to know.
20170223 15:08:42< vultraz_iOS> hmmm
20170223 15:08:44< JyrkiVesterinen> Judging from the lack of line numbers, you seem to be using an optimized build, which makes investigating harder.
20170223 15:09:20< vultraz_iOS> yeah i can whip up a debug build
20170223 15:09:22-!- Kwandulin [~Miranda@p200300760F7B9662B5E104BF62595F67.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 15:10:14< JyrkiVesterinen> A quick guess is that the crash actually happens in add_side_node(), but the compiler inlined it.
20170223 15:11:09< JyrkiVesterinen> Anyway, my guess is that you invalidate the "side" pointer when you remove that node.
20170223 15:19:14-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170223 15:21:53-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 15:24:04< vultraz_iOS> looks like the original issue might have something to do with the ptr_vector
20170223 15:25:32< vultraz_iOS> ill have to do more research
20170223 15:27:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 15:28:43-!- DeFender1031 [~DeFender1@46-116-117-53.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170223 15:36:21-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: .]
20170223 15:45:17-!- boucman [~rosen@wesnoth/developer/boucman] has left #wesnoth-dev []
20170223 15:54:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20170223 15:58:55< zookeeper> vultraz_iOS, you yourself added the unpoison manual entry in 72d6f9669. but the list already has "cures" in it, which is the actual name used for the ability. so the PR seems to be in the right.
20170223 16:06:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 16:18:43-!- DeFender1031 [~DeFender1@46-116-117-53.bb.netvision.net.il] has joined #wesnoth-dev
20170223 16:25:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 16:36:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170223 16:42:28< gfgtdf> vultraz_iOS: if you don't like boost::ptr_vector<T> you can replace it with std::vector<std::unique_ptr<T>>, but note that this means you migth ahve to derefrence all iterator once more, meaing you migth need to use (**i).stuff instead of i->stuff for iterators.
20170223 16:43:16< gfgtdf> vultraz_iOS: i personally think pre_vector is a good idea but it also has some disadvantage, in particular it doesnt have a move ctor afaik
20170223 16:43:26< gfgtdf> vultraz_iOS: that disadvantage is unrelated to you issue tohugh
20170223 16:45:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170223 16:46:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 16:53:02< gfgtdf> vultraz_iOS: actuall i think the this carhas is bug in thrreview introduced in https://github.com/wesnoth/wesnoth/commit/50867795352861762ebe4b42da8e13b0ecb9b3ee
20170223 16:53:26< gfgtdf> vultraz_iOS: you are delting the node in line 80 and then using it in line 84 of tree_view.cpp
20170223 16:55:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 16:57:08-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has quit [Ping timeout: 268 seconds]
20170223 17:01:16< Soliton> would probably help to have a little comment explaining what that parent -> children round trip does.
20170223 17:01:32-!- JyrkiVesterinen [~JyrkiVest@89-166-116-242.bb.dnainternet.fi] has joined #wesnoth-dev
20170223 17:01:35< Soliton> at least two people have reviewed that commit and didn't see the error.
20170223 17:02:24-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20170223 17:02:24-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20170223 17:02:24-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 17:02:31-!- Kwandulin [~Miranda@p200300760F7B9662B5E104BF62595F67.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170223 17:02:45-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20170223 17:05:28-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20170223 17:05:51< Soliton> or maybe just renaming itor to node_itor.
20170223 17:08:40-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has joined #wesnoth-dev
20170223 17:09:34< irker420> wesnoth: Jyrki Vesterinen wesnoth:master 5bde7428a33e / .appveyor.vs2013.yml .appveyor.vs2015.yml: AppVeyor: only notify on failure https://github.com/wesnoth/wesnoth/commit/5bde7428a33e269ad241c4bed276a1a071e95358
20170223 17:12:37< JyrkiVesterinen> I set up scheduled AppVeyor builds again, but now it builds only every 24 hours and not every 8 hours.
20170223 17:12:49< JyrkiVesterinen> And, as above, it only notifies us on failure.
20170223 17:32:18-!- higgins` [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving]
20170223 17:34:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 17:37:18< celticminstrel> vultraz_iOS: About the appveyor webhooks thing, I assume giving JyrkiVesterinen administrative access to the project (even just temporarily) could also solve the issue.
20170223 17:37:27< celticminstrel> Also no, I can't reach you on Discord.
20170223 17:37:33< celticminstrel> Because I don't have Discord.
20170223 17:37:51< celticminstrel> Presumably I could reach through eg Steam or email though.
20170223 17:38:35< celticminstrel> By the way, MSVC debug builds have a lot of asan-like checks in place by default, which can actually be really useful.
20170223 17:38:54< irker420> wesnoth: gfgtdf wesnoth:master 6140f83eb17d / src/gui/dialogs/drop_down_menu.cpp: small code cleanup https://github.com/wesnoth/wesnoth/commit/6140f83eb17d28dbb78d253785ad675ac1395318
20170223 17:41:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170223 17:41:20-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170223 17:41:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 17:43:44-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has quit [Ping timeout: 260 seconds]
20170223 17:47:39-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170223 17:48:24< irker420> wesnoth: Jyrki Vesterinen wesnoth:master e98531541de7 / src/gui/widgets/tree_view.cpp: Fix UB in tree_view::remove_node() https://github.com/wesnoth/wesnoth/commit/e98531541de78317e088ecd96d849a57087fd503
20170223 17:49:31< zookeeper> so what's this mysterious UB that people have started referring to constantly recently? upstream bug?
20170223 17:49:44< celticminstrel> Undefined behaviour.
20170223 17:50:11< zookeeper> oh.
20170223 17:50:42< celticminstrel> Basically things where the C++ standard says "your code can do literally anything here"...
20170223 17:54:26-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has joined #wesnoth-dev
20170223 17:55:43-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170223 17:56:45< matthiaskrgr> fix confirmed :) 
20170223 17:57:32< JyrkiVesterinen> Excellent.
20170223 17:59:16< matthiaskrgr> found something new :>
20170223 17:59:54< Soliton> delete it!
20170223 18:00:00< JyrkiVesterinen> Let me guess: the scrollable area gets smaller and smaller?
20170223 18:00:11< matthiaskrgr> I mewn its probably unrelated to previous change
20170223 18:00:13< matthiaskrgr> a buffer overflow
20170223 18:00:51< JyrkiVesterinen> Vultraz told me about the "scrollable area shrinks" bug in Discord. He suspect that it's related to GUI2 changes I have made.
20170223 18:01:00< JyrkiVesterinen> So, I am investigating that now.
20170223 18:01:28< JyrkiVesterinen> I needed to get MSVC debug builds to not crash first, though, and I went on to fix the UB bugs because of that. ;)
20170223 18:03:41< matthiaskrgr> https://gna.org/bugs/index.php?25536  
20170223 18:08:28-!- UnwiseOwl [~UnwiseOwl@student-nat.bnc.ox.ac.uk] has quit [Ping timeout: 260 seconds]
20170223 18:11:53< irker420> wesnoth: Jyrki Vesterinen wesnoth:master 10d477bea4b2 / src/gui/widgets/tree_view_node.cpp: Fix: tree view doesn't grow when new nodes are added https://github.com/wesnoth/wesnoth/commit/10d477bea4b28c313354cd90c8d6be3cab1c8517
20170223 18:28:34-!- Kwandulin [~Miranda@p200300760F7B9662B9B1C10D3C62E274.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 18:34:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170223 18:35:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170223 18:36:54-!- Kwandulin_2 [~Miranda@p200300760F7B9662B9B1C10D3C62E274.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170223 18:39:41-!- Kwandulin [~Miranda@p200300760F7B9662B9B1C10D3C62E274.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170223 18:51:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Read error: Connection reset by peer]
20170223 19:41:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 19:42:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 19:46:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 19:47:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 19:47:17-!- gfgtdf_ [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 19:49:48-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170223 19:49:58-!- gfgtdf_ is now known as gfgtdf
20170223 19:51:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 19:51:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 20:01:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20170223 20:11:00-!- prkc [~prkc@e2.85.7a9f.ip4.static.sl-reverse.com] has joined #wesnoth-dev
20170223 20:12:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 20:27:05-!- Kwandulin_2 [~Miranda@p200300760F7B9662B9B1C10D3C62E274.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170223 20:37:21-!- RatArmy_ [~ratarmy@om126204196166.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170223 20:51:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 20:56:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170223 21:04:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 21:08:11-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170223 21:13:28-!- irker420 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170223 21:17:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 21:19:13-!- travis-ci [~travis-ci@ec2-54-205-252-124.compute-1.amazonaws.com] has joined #wesnoth-dev
20170223 21:19:14< travis-ci> gfgtdf/wesnoth#733 (no_on_redo - 8b0fe84 : gfgtdf): The build failed.
20170223 21:19:14< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/204679793
20170223 21:19:14-!- travis-ci [~travis-ci@ec2-54-205-252-124.compute-1.amazonaws.com] has left #wesnoth-dev []
20170223 21:35:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20170223 21:35:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170223 21:43:44-!- louis94 [~~louis94@17.49-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170223 22:00:56-!- JyrkiVesterinen [~JyrkiVest@89-166-116-242.bb.dnainternet.fi] has quit [Quit: .]
20170223 22:24:43-!- louis94 [~~louis94@17.49-65-87.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20170223 22:35:48-!- RatArmy_ [~ratarmy@om126204196166.6.openmobile.ne.jp] has joined #wesnoth-dev
20170223 23:01:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 23:03:14-!- RatArmy_ [~ratarmy@om126204196166.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170223 23:03:53-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170223 23:05:59< vultraz_iOS> gfgtdf: thanks for pointing that bug out
20170223 23:08:24-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 23:10:20-!- irker669 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170223 23:10:20< irker669> wesnoth: Charles Dang wesnoth:master e19255c4fd45 / src/game_initialization/ (create_engine.cpp create_engine.hpp): Create Engine: major refactor of game list storage and code cleanup https://github.com/wesnoth/wesnoth/commit/e19255c4fd451dbcd8cd4b621aa725ac5e634cc0
20170223 23:12:09 * vultraz_iOS waits for travis report
20170223 23:14:56 * vultraz_iOS has also discovered the useful std::iota
20170223 23:15:04-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 23:15:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 23:16:27< vultraz_iOS> let's hope it's not something gcc hasn't implemented
20170223 23:16:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170223 23:16:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170223 23:18:25< gfgtdf> i wonder what 'iota' abbreviates
20170223 23:18:50< vultraz_iOS> good question
20170223 23:19:12< DeFender1031> i don't have one iota of a clue what it might stand for... :P
20170223 23:20:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170223 23:20:22< DeFender1031> http://stackoverflow.com/questions/9244879/what-does-iota-of-stdiota-stand-for
20170223 23:20:55< DeFender1031> so it is actually not an abbreviation, but literally referring to iota.
20170223 23:25:02< vultraz_iOS> huh
20170223 23:25:58< vultraz_iOS> anyway, that's a rather huge commit, so i expect some issues
20170223 23:26:17< gfgtdf> vultraz_iOS: did you see https://gna.org/bugs/?25536 ?
20170223 23:26:34< vultraz_iOS> yes but i don't know what one might do about it
20170223 23:27:35< gfgtdf> vultraz_iOS: the restur value here https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_create_game.cpp#L786 (selected_cndex()) might npot be in range
20170223 23:28:26< gfgtdf> vultraz_iOS: you coudl for example just wrap the dlg.selected_index() in a util::clamp
20170223 23:28:46< vultraz_iOS> how could it not be in range?
20170223 23:29:24< gfgtdf> its -1 if the dialog was canceled
20170223 23:30:12< vultraz_iOS> you can't
20170223 23:30:31< vultraz_iOS> dlg.set_single_button(true);
20170223 23:30:41< vultraz_iOS> pretty sure that also disables Esc..
20170223 23:30:43< vultraz_iOS> I'll have to test
20170223 23:30:46< gfgtdf> vultraz_iOS: well the reported of th ebug said he did calcel the dialog
20170223 23:30:56< gfgtdf> reporter*
20170223 23:31:46< vultraz_iOS> ah
20170223 23:32:07-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]]
20170223 23:32:08< vultraz_iOS> ok 
20170223 23:32:32-!- gfgtdf [~chatzilla@x4e368b83.dyn.telefonica.de] has joined #wesnoth-dev
20170223 23:33:39< vultraz_iOS> ill disable Esc
20170223 23:34:58< irker669> wesnoth: Charles Dang wesnoth:master bd47e75d32e0 / src/gui/dialogs/simple_item_selector.cpp: Simple Item Selector: disable Esc canceling if single button mode is enabled https://github.com/wesnoth/wesnoth/commit/bd47e75d32e07a29c204ceb71dd7a837486ad73a
20170223 23:37:17< gfgtdf> i disagree with that, i think it quite annoyign to you cannot skip dialogs with escape, in particular this will also effect the 'a player left ..' dialog which previousl esc just defaultes to the most harmless value (e.g set the side to idle)
20170223 23:37:45< vultraz_iOS> hmm
20170223 23:38:36< vultraz_iOS> yeah that's not good
20170223 23:40:23< vultraz_iOS> ok I wonder if a better solution is to just save the selected index regardless of dialog retval
20170223 23:40:23< zookeeper> matthiaskrgr, with the hex grid being offset wrong you just mean the bottom (and/or left) edge, right?
20170223 23:41:39< vultraz_iOS> or if i should handle Canceling on a per-usecase basis
20170223 23:42:18< vultraz_iOS> gfgtdf: which do you think
20170223 23:42:42< matthiaskrgr> zookeeper: yeah
20170223 23:43:00-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170223 23:43:56< gfgtdf> vultraz_iOS: hmm i think it makes sense for single_button to just use the currently selected index if escape was pressed.
20170223 23:44:09< vultraz_iOS> ok
20170223 23:44:45< zookeeper> matthiaskrgr, roger. replying...
20170223 23:46:01< matthiaskrgr> wontfix? :p
20170223 23:47:07< zookeeper> nah
20170223 23:47:19< matthiaskrgr> btw there is this very weird case where ASAN does not report any kind of memleaks when in a multiplayer match I leave the wesnoth window with the cursor and come back to it 
20170223 23:47:33< matthiaskrgr> this is super weird
20170223 23:47:44< matthiaskrgr> any ideas what might cause this?
20170223 23:47:46< irker669> wesnoth: Charles Dang wesnoth:master 789fcb6f90c6 / src/gui/dialogs/simple_item_selector.cpp: Revert "Simple Item Selector: disable Esc canceling if single button mode is ena https://github.com/wesnoth/wesnoth/commit/789fcb6f90c69cea25353b369997f5fe1b3bd44b
20170223 23:47:49< irker669> wesnoth: Charles Dang wesnoth:master 0474c2eb1f7e / src/gui/dialogs/simple_item_selector.cpp: Simple Item Selector: save selected index even on cancel https://github.com/wesnoth/wesnoth/commit/0474c2eb1f7e05942ff0b1abf45290e672cfb93d
20170223 23:47:55< vultraz_iOS> gfgtdf: ^
20170223 23:49:11< gfgtdf> vultraz_iOS: hmm i thought this woudl only apply die item selectors that have no abbort button
20170223 23:49:26< vultraz_iOS> should it?
20170223 23:50:43< gfgtdf> vultraz_iOS: well afaik one only item selector with abort button is the ':cl' scenario list list
20170223 23:51:11< gfgtdf> vultraz_iOS: i think it makes e sense just to do nothing there (return -1) if the user pressed escape/abort.
20170223 23:51:39< vultraz_iOS> hm
20170223 23:51:47< vultraz_iOS> i don't think it matters much but i could help
20170223 23:51:50< vultraz_iOS> ill add a condition
20170223 23:52:31< gfgtdf> matthiaskrgr: ^no idea
20170223 23:52:32< vultraz_iOS> gfgtdf: btw on an unrelated note i realized i forgot to enable the new save options code: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_options_helper.cpp#L328
20170223 23:52:51< vultraz_iOS> gfgtdf: i think you said i also needed to change something in preferences
20170223 23:52:54< vultraz_iOS> to use config::merge?
20170223 23:53:44< zookeeper> matthiaskrgr, done. i'm also trying to check really quickly whether it's as easy to fix as changing one thing in the code...
20170223 23:54:27< gfgtdf> vultraz_iOS: hmm i am not so sure anymore the problme is that i dont knwo whether we support 'id=my_container.my_attribute'
20170223 23:55:09< gfgtdf> in that case we cannot make the format <id>=<value> since the id migth not be a valid wml attribute key.
20170223 23:56:36< irker669> wesnoth: Charles Dang wesnoth:master b94904623639 / src/gui/dialogs/simple_item_selector.cpp: Simple Item Selector: add condition to only save index on cancel if single butto https://github.com/wesnoth/wesnoth/commit/b949046236390b6ef11e09c5ad68b748eea8dabf
--- Log closed Fri Feb 24 00:00:04 2017