--- Log opened Sat Feb 25 00:00:29 2017
20170225 00:21:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 00:22:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 00:39:34-!- Appleman1234 [~Appleman1@pl1630.nas82h.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 00:41:16< matthiaskrgr> oh wow
20170225 00:41:31< matthiaskrgr> someone interested in unsigned integer overflows?
20170225 00:42:04< matthiaskrgr> there are *a lot*
20170225 00:45:20< matthiaskrgr> appetizer: http://pastebin.com/raw/neAKqxHr   
20170225 00:46:58< matthiaskrgr> and no, this is not UB, but it might be interesting anyway
20170225 00:53:43-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170225 00:53:47< irker855> wesnoth: Charles Dang wesnoth:master 92a37da4d049 / src/gui/dialogs/end_credits.cpp: End Credits: fixed crash related to e24336afeb7 https://github.com/wesnoth/wesnoth/commit/92a37da4d049ded6679701cee20fa89f8b517589
20170225 00:55:32-!- atarocch [~atarocch@93.56.160.29] has quit [Ping timeout: 260 seconds]
20170225 00:57:42-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has joined #wesnoth-dev
20170225 01:12:20-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 01:15:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 01:15:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 01:18:20-!- gk_-1wm_- [~su@50.118.213.31] has joined #wesnoth-dev
20170225 01:18:22-!- gk_-1wm_- [~su@50.118.213.31] has left #wesnoth-dev []
20170225 01:25:35< gfgtdf> matthiaskrgr: hm yes but i think most of there are art of has function that usualy rely on interger overflow
20170225 01:27:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 01:27:45< gfgtdf> matthiaskrgr: aslo soem of there are asigned to signed dirctly aftert the calculation
20170225 01:29:01< gfgtdf> matthiaskrgr: if you have codes like 'unsigned int u= ..; int s= ..; int res = u +i;' you odten dont botzher to change then into the more strict 'int res = cast<int>(u) +i;'
20170225 01:29:20< matthiaskrgr> ok
20170225 01:34:04< gfgtdf> i mean its possible that that long list contains one case of real bug, 
20170225 01:34:21< gfgtdf> but most cases sureley fall into one of the categories menationed above.
20170225 01:37:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 01:38:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 01:38:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170225 01:51:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 01:52:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 02:02:35-!- gfgtdf_ [~chatzilla@x4e3699c7.dyn.telefonica.de] has joined #wesnoth-dev
20170225 02:04:42-!- gfgtdf [~chatzilla@x4e363141.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170225 02:04:45-!- gfgtdf_ is now known as gfgtdf
20170225 02:05:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Remote host closed the connection]
20170225 02:07:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 02:08:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 02:44:27-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 240 seconds]
20170225 03:06:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 03:09:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Remote host closed the connection]
20170225 03:11:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 03:27:53-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 03:35:30-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170225 03:36:38-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 03:49:20-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has joined #wesnoth-dev
20170225 03:53:10-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 03:53:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 03:54:06-!- irker855 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170225 03:58:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Ping timeout: 240 seconds]
20170225 04:03:57-!- gk__1wm_ [~su@204.93.60.195] has joined #wesnoth-dev
20170225 04:03:58-!- gk__1wm_ [~su@204.93.60.195] has left #wesnoth-dev []
20170225 04:12:24-!- gk-----------1wm [~su@50.118.218.83] has joined #wesnoth-dev
20170225 04:13:15-!- gk-----------1wm [~su@50.118.218.83] has quit [K-Lined]
20170225 04:21:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170225 04:23:30-!- IRCFrEAK [~GK1wmSU@23.27.14.106] has joined #wesnoth-dev
20170225 04:25:27-!- IRCFrEAK [~GK1wmSU@23.27.14.106] has quit [K-Lined]
20170225 04:28:00-!- Appleman1234 [~Appleman1@pl1630.nas82h.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170225 04:29:13-!- Appleman1234 [~Appleman1@pl4901.nas823.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 04:39:15-!- gfgtdf [~chatzilla@x4e3699c7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]]
20170225 04:42:38-!- gk_-__-1wm [~su@23.27.14.237] has joined #wesnoth-dev
20170225 04:44:43-!- gk_-__-1wm [~su@23.27.14.237] has quit [K-Lined]
20170225 04:56:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170225 04:56:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170225 04:59:52-!- GK[]\`_^{|}1WM [~SU@204.93.60.128] has joined #wesnoth-dev
20170225 05:08:03-!- GK[]\`_^{|}1WM [~SU@204.93.60.128] has quit [K-Lined]
20170225 05:13:23-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20170225 05:14:47-!- Rh0nda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20170225 05:14:57-!- GK[]\`_^{|}1WM [~SU@23.27.18.156] has joined #wesnoth-dev
20170225 05:16:07-!- GK[]\`_^{|}1WM [~SU@23.27.18.156] has quit [K-Lined]
20170225 05:16:41-!- elias [~allefant@allegro/developer/allefant] has quit [Ping timeout: 260 seconds]
20170225 05:16:43-!- clavi [~clavi@163-172-10-77.rev.poneytelecom.eu] has quit [Ping timeout: 260 seconds]
20170225 05:16:43-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 260 seconds]
20170225 05:16:46-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 240 seconds]
20170225 05:16:46-!- Appleman1234 [~Appleman1@pl4901.nas823.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170225 05:16:46-!- vincent_c [~bip@vcheng.org] has quit [Ping timeout: 240 seconds]
20170225 05:16:47-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Ping timeout: 240 seconds]
20170225 05:16:47-!- APic [apic@apic.name] has quit [Ping timeout: 240 seconds]
20170225 05:16:48-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 240 seconds]
20170225 05:16:49-!- vincent_` [~bip@vcheng.org] has joined #wesnoth-dev
20170225 05:17:29-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170225 05:17:34-!- APic [apic@apic.name] has joined #wesnoth-dev
20170225 05:18:01-!- clavi [~clavi@163-172-10-77.rev.poneytelecom.eu] has joined #wesnoth-dev
20170225 05:18:01-!- irker159 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170225 05:18:01< irker159> wesnoth: Charles Dang wesnoth:master ebf16031cb31 / doc/manual/manual.txt: Merge pull request #935 from fujimo-t/fix_manual https://github.com/wesnoth/wesnoth/commit/ebf16031cb313b911d60c19fcbe8fca92a505d28
20170225 05:18:09-!- elias [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20170225 05:19:11-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170225 05:23:36-!- Appleman1234 [~Appleman1@pl4901.nas823.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 05:31:15-!- vincent_` is now known as vincent_c
20170225 06:02:17-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170225 06:21:42< irker159> wesnoth: Jyrki Vesterinen wesnoth:master 0dbf686c4ffd / src/gui/widgets/ (listbox.cpp toggle_button.cpp): Fix bug #25539: crash if a checkbox in a listbox is initially selected https://github.com/wesnoth/wesnoth/commit/0dbf686c4ffdac2421059d3e3be14b165aa06ef0
20170225 06:45:37-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170225 07:21:24-!- Kwandulin [~Miranda@p200300760F7B9673B8767D0084D86FD1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170225 07:53:20-!- celticminstrel is now known as celmin|sleep
20170225 08:07:35-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has quit [Quit: .]
20170225 08:08:37-!- Kwandulin [~Miranda@p200300760F7B9673B8767D0084D86FD1.dip0.t-ipconnect.de] has quit [Read error: Network is unreachable]
20170225 08:09:40-!- Kwandulin [~Miranda@p200300760F7B9673B8767D0084D86FD1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170225 08:58:39-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has joined #wesnoth-dev
20170225 09:15:02-!- Appleman1234 [~Appleman1@pl4901.nas823.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170225 09:15:46-!- Appleman1234 [~Appleman1@pl1511.nas82b.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 09:23:17-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170225 09:23:51-!- irker159 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170225 09:38:47-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170225 09:49:07-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has joined #wesnoth-dev
20170225 09:51:41-!- atarocch [~atarocch@93.56.160.29] has joined #wesnoth-dev
20170225 09:56:22-!- Duthlet [~Duthlet@dslb-188-105-113-146.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170225 10:22:56-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170225 10:33:58-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has joined #wesnoth-dev
20170225 10:53:46-!- zookeeper_ [zookeeper@37.35.31.211] has joined #wesnoth-dev
20170225 10:54:29-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Disconnected by services]
20170225 10:54:33-!- zookeeper_ is now known as zookeeper
20170225 10:54:36-!- zookeeper [zookeeper@37.35.31.211] has quit [Changing host]
20170225 10:54:36-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170225 11:12:27-!- Appleman1234 [~Appleman1@pl1511.nas82b.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170225 11:17:26-!- irker504 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170225 11:17:26< irker504> wesnoth: loonycyborg wesnoth:sql_prepared_statements 8c3c0abe838c / src/server/mysql_prepared_statement.ipp: Ensure that mysql_stmt_free_result is called even if exception is thrown https://github.com/wesnoth/wesnoth/commit/8c3c0abe838cdf825cdae94fd3424d0da22747ba
20170225 11:44:41-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has quit [Quit: .]
20170225 11:49:46-!- Appleman1234 [~Appleman1@pl425.nas82f.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 11:58:40-!- Kwandulin [~Miranda@p200300760F7B9673B8767D0084D86FD1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170225 12:09:10-!- madmax28 [~madmax28@xdsl-81-173-154-134.netcologne.de] has joined #wesnoth-dev
20170225 12:18:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 12:54:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 12:58:52-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds]
20170225 13:03:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 13:04:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 13:08:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:f99c:4058:4bdc:b87d] has quit [Quit: Leaving]
20170225 13:13:14-!- Kwandulin [~Miranda@p200300760F7B9673910BE46884542D96.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170225 13:27:18-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170225 13:31:35-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170225 13:34:34-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 256 seconds]
20170225 13:36:04-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 255 seconds]
20170225 13:36:33-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20170225 13:37:08-!- Appleman1234 [~Appleman1@pl425.nas82f.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170225 13:41:42-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 240 seconds]
20170225 13:47:13-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has joined #wesnoth-dev
20170225 13:51:02-!- Appleman1234 [~Appleman1@pl1377.nas829.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170225 13:53:21-!- mjs-de [~mjs-de@x5ce4a25e.dyn.telefonica.de] has joined #wesnoth-dev
20170225 14:00:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 14:00:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 14:01:27-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170225 14:03:06-!- gfgtdf [~chatzilla@x4e3699c7.dyn.telefonica.de] has joined #wesnoth-dev
20170225 14:10:57-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 240 seconds]
20170225 14:17:32-!- irker504 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170225 14:23:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170225 14:24:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170225 14:31:20-!- atarocch [~atarocch@93.56.160.29] has quit [Read error: Connection reset by peer]
20170225 14:33:33-!- atarocch [~atarocch@93.56.160.29] has joined #wesnoth-dev
20170225 15:28:23-!- Tad_Carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170225 15:29:20< Tad_Carlucci> game_initialization/create_engine.hpp:59:7: error: ‘class ng::level’ has virtual functions and accessible non-virtual destructor
20170225 15:29:45< Tad_Carlucci> game_initialization/create_engine.hpp:126:7: error: ‘class ng::scenario’ has virtual functions and accessible non-virtual destructor 
20170225 15:30:00< Tad_Carlucci> game_initialization/create_engine.hpp:161:7: error: ‘class ng::user_map’ has virtual functions and accessible non-virtual destructor
20170225 15:30:17< Tad_Carlucci> game_initialization/create_engine.hpp:188:7: error: ‘class ng::random_map’ has virtual functions and accessible non-virtual destructor
20170225 15:30:35< Tad_Carlucci> game_initialization/create_engine.hpp:220:7: error: ‘class ng::campaign’ has virtual functions and accessible non-virtual destructor
20170225 15:31:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 15:32:26-!- Kwandulin [~Miranda@p200300760F7B9673910BE46884542D96.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170225 15:36:31< gfgtdf> ye that should  be fixed thx for noticing
20170225 15:37:49-!- Grickit is now known as Gambit
20170225 15:38:56< Tad_Carlucci> gfgtdf, Back in November you asked about replacing the list-like structures driving events. I'm using that to try to get my head back into programming.
20170225 15:39:38-!- irker045 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170225 15:39:38< irker045> wesnoth: gfgtdf wesnoth:master 98b2362604bf / src/game_initialization/create_engine.hpp: fix missing virtual dtor in ng::level https://github.com/wesnoth/wesnoth/commit/98b2362604bf4c18072ca08c46fe8a9155441267
20170225 15:40:14< gfgtdf> Tad_Carlucci: you sue i was that? I mean it's possible but i currently cannot remember
20170225 15:40:39< gfgtdf> Tad_Carlucci: please check if you still get those warnings after that commit^
20170225 15:41:11< Tad_Carlucci> I don't remember the name of the list "smartlist" or somesuch and it works but is messy.  (Checking now)
20170225 15:41:29< gfgtdf> Tad_Carlucci: i think makring an explicit  victual dtor in the derived calsses is not needd but i'm not 100% sure 
20170225 15:44:08< Tad_Carlucci> Compile is running (cmake) and is past the error so looks like you did it correctly.
20170225 15:44:55< celmin|sleep> Yeah, only the base class needs an explicit virtual destructor.
20170225 15:45:22< celmin|sleep> Virtualness of functions propagates down the inheritance chain.
20170225 15:45:25-!- celmin|sleep is now known as celticminstrel
20170225 15:45:49 * Tad_Carlucci nods.
20170225 16:09:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 16:10:37< gfgtdf> anyone an opinion on my pr https://github.com/wesnoth/wesnoth/pull/936 ?
20170225 16:11:02-!- clavi [~clavi@163-172-10-77.rev.poneytelecom.eu] has quit [Quit: ZNC - 1.6.4 - http://znc.in]
20170225 16:11:09-!- Kwandulin [~Miranda@p200300760F7B9673352182B7EEF90C15.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170225 16:12:14< celticminstrel> Well, I'd say that, if you're doing it, you should make it all-or-nothing, not add a toggle preference. 
20170225 16:12:35< celticminstrel> But I'm not sure whether it's a good idea.
20170225 16:12:48< celticminstrel> That is, I'm really not sure one way or another.
20170225 16:13:52< celticminstrel> I mean, with explicit [on_redo] you could for example set it up so only part of the event is undoable. Not sure if that would cause other problems, mind you...
20170225 16:14:39-!- clavi [~clavi@163-172-10-77.rev.poneytelecom.eu] has joined #wesnoth-dev
20170225 16:14:56< celticminstrel> I could imagine situations where you might want a different effect on redo than on the original action. Generally when the original action had a long sequence of dialogue.
20170225 16:15:32< celticminstrel> On the other hand, it's true that in many situations the [on_redo] is likely to simply duplicate the content of the event.
20170225 16:15:52< gfgtdf> celticminstrel: well yes that pr removes the toggle preference, the toggle prefernce was in master before for me to test it
20170225 16:16:28< celticminstrel> Wait, this is already in master?
20170225 16:17:41< celticminstrel> Well, even with this though, you could support optional [on_redo].
20170225 16:17:46< gfgtdf> yes it is, but the perference is really just for testing, its not possible to togele it without manually changing th perferences file
20170225 16:17:59< celticminstrel> That's beside the point.
20170225 16:18:12-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 16:18:13< celticminstrel> The question is whether removing [on_redo] is really a good idea.
20170225 16:18:21< gfgtdf> celticminstrel: you asked whather it already in master
20170225 16:18:44< celticminstrel> I'm not sure, but like I said, I can imagine at least one scenario where you might want the redo to have a (slightly) different effect than the original action.
20170225 16:19:16< celticminstrel> At the same time, I would imagine that in the vast majority of scenarios you would want the redo to have the exact same effect as the original action.
20170225 16:20:29< celticminstrel> I suggest getting zookeeper to figure out which addons use on_redo and taking a look at how they use it, if you haven't already done so.
20170225 16:23:42-!- Kwandulin [~Miranda@p200300760F7B9673352182B7EEF90C15.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170225 16:40:43-!- DeFender1031 [~DeFender1@46-116-117-53.bb.netvision.net.il] has joined #wesnoth-dev
20170225 16:48:57-!- trewe [~trewe@2001:8a0:d104:2801:4fa9:7644:643d:2504] has joined #wesnoth-dev
20170225 16:51:56-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 16:55:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 16:58:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 17:03:54-!- Tad_Carlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20170225 17:09:51-!- jtn [jacobn@chiark.greenend.org.uk] has joined #wesnoth-dev
20170225 17:12:59< jtn> Hello Wesnoth folks. I'm from Freeciv. Is this a good place to ask what your plans are in light of gna.org's likely closure? (We are affected too so I'm looking for ideas.)
20170225 17:13:34< zookeeper> yes
20170225 17:13:46< celticminstrel> The possibilities that have been discussed are JIRA, GitHub issues, or a self-hosted Redmine instance.
20170225 17:13:48< zookeeper> although i believe our plans are still sort of all over the place
20170225 17:14:02< celticminstrel> GitHub apparently lacks some features that certain devs consider essential, though.
20170225 17:14:07< zookeeper> (...which isn't good because we're quickly running out of time)
20170225 17:14:13< jtn> We're looking at hostedredmine.com.
20170225 17:14:30< jtn> zookeeper: do you have more info on closure date? Admins on #gna were vague when I asked them.
20170225 17:14:45< zookeeper> jtn, i was just going to ask you :p
20170225 17:14:52< jtn> I suspect it's not Nov 2016 + 6 months
20170225 17:14:59< zookeeper> oh?
20170225 17:15:19< jtn> As in, you could read the announcement that way but that wasn't the impression I got when I spoke to them
20170225 17:15:32< jtn> How about mailing lists / file hosting?
20170225 17:16:00< jtn> announcement> by which I mean https://mail.gna.org/public/project/2016-11/msg00001.html which is all that's public on the subject
20170225 17:16:35< jtn> Here comes an IRC log:
20170225 17:16:41< jtn> (from #gna a few days ago)
20170225 17:16:44< jtn> 17:58 < jtn> Does the 6 months start from that email (i.e., shutdown May 20, 2017), or will there be a more official announcement?
20170225 17:16:52< jtn> 19:11 < zerodeux> erm, that's a bit unclear I must admin
20170225 17:16:58< jtn> 19:11 < zerodeux> I think Sylvain did'nt want to push the agenda to hard
20170225 17:17:03< jtn> 19:11 < zerodeux> but that would be safer to consider it's 6 months starting from this email
20170225 17:17:08< jtn> 19:11 < zerodeux> we'll fire some other notices anyway
20170225 17:17:09< jtn> done
20170225 17:17:25< jtn> I haven't seen other notices.
20170225 17:17:59< zookeeper> well, that's at least reassuring
20170225 17:18:25< jtn> I was lucky to get an answer from them on IRC. They're not very active.
20170225 17:18:35< zookeeper> our mailing lists are used very little so they're not a pressing concern and i don't recall seeing anyone give much thought to those yet.
20170225 17:19:58-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 17:20:09< jtn> lists> Right. We use ours rather more. We're looking at freelists.org but another admin (cazfi) says it looks a bit disappointing.
20170225 17:21:40< celticminstrel> Oh wait, GNA hosts the mailing lists too?
20170225 17:21:56< celticminstrel> I kinda forgot about those.
20170225 17:22:48< DeFender1031> eh, who needs 'em anyway? :P
20170225 17:27:11< zookeeper> yeah, i guess just substituting the mailing lists with something else is a possible option. these days they're mainly just used to notify packagers of new releases, i think.
20170225 17:32:56< zookeeper> then again, that's the kind of thing a mailing list is good for.
20170225 17:43:02-!- trewe [~trewe@2001:8a0:d104:2801:4fa9:7644:643d:2504] has quit [Quit: quit]
20170225 18:07:54< DeFender1031> doesn't gmail have mailing lists?
20170225 18:11:28-!- mjs-de [~mjs-de@x5ce4a25e.dyn.telefonica.de] has quit [Remote host closed the connection]
20170225 18:36:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 18:40:56-!- irker045 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170225 18:45:02-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Ping timeout: 240 seconds]
20170225 18:46:19-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170225 18:50:14-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170225 18:56:48-!- irker344 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170225 18:56:48< irker344> wesnoth: Charles Dang wesnoth:master 95b2d8c4e536 / src/game_initialization/connect_engine.cpp: Connect Engine: fix sides with their controller set as Empty still getting a lea https://github.com/wesnoth/wesnoth/commit/95b2d8c4e536e86caa661f4d5893870429d2c08b
20170225 19:08:07-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170225 19:30:37-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 19:31:01-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 19:35:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 19:55:11-!- Kwandulin [~Miranda@p200300760F7B967388A26B9F8B33CD21.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170225 19:59:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 20:03:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 20:32:32-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Ping timeout: 252 seconds]
20170225 20:34:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 20:38:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 20:41:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 20:43:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 20:47:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Ping timeout: 240 seconds]
20170225 20:49:30-!- gfgtdf_ [~chatzilla@x4e3699c7.dyn.telefonica.de] has joined #wesnoth-dev
20170225 20:52:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 20:52:39-!- gfgtdf [~chatzilla@x4e3699c7.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170225 20:52:40-!- gfgtdf_ is now known as gfgtdf
20170225 20:57:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Remote host closed the connection]
20170225 20:58:01-!- mjs-de [~mjs-de@92.228.162.94] has joined #wesnoth-dev
20170225 20:58:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 20:58:05-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 21:11:33-!- mjs-de [~mjs-de@92.228.162.94] has quit [Remote host closed the connection]
20170225 21:31:47-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 21:33:37-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 21:36:01-!- JyrkiVesterinen [~JyrkiVest@87-100-154-69.bb.dnainternet.fi] has quit [Quit: .]
20170225 21:39:38-!- Kwandulin [~Miranda@p200300760F7B967388A26B9F8B33CD21.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170225 21:39:39-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170225 21:44:42-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has joined #wesnoth-dev
20170225 21:49:41-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 240 seconds]
20170225 21:52:09< zookeeper> https://forums.wesnoth.org/viewtopic.php?f=12&t=45108 <- if he is correct, then any idea _why_ [tunnel] would treat variable substitution in an unusual way like that?
20170225 21:56:56-!- irker344 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170225 22:03:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 22:15:13-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170225 22:17:02< DeFender1031> is it possible he's incorrect and it's actually a nested event with delayed variable substitution thing?
20170225 22:17:28< DeFender1031> nevermind. shoulda read the whole post before commenting
20170225 22:17:40< DeFender1031> actually, it could still be that...
20170225 22:18:34< DeFender1031> it also seems strange that somehow nesting a start event fixes it
20170225 22:19:38< zookeeper> well presumably a nested event is variable-substituted as a whole first, and then the result is what's used to actually create the event
20170225 22:19:48-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has quit [Ping timeout: 260 seconds]
20170225 22:19:49< zookeeper> so it makes sense that that would be a workaround
20170225 22:20:43< DeFender1031> oh, got it, it's a separate event for each iteration
20170225 22:21:44< celticminstrel> A better workaround would probably involve cosntructing the tunnel tag in a variable and using [insert_tag[.
20170225 22:22:07< DeFender1031> perhaps
20170225 22:22:22< celticminstrel> But the crux of the issue appear to be that the [tunnel] tag does not undergo variable substitution?
20170225 22:22:35< celticminstrel> ^+d
20170225 22:22:38< celticminstrel> +s
20170225 22:22:52< DeFender1031> seems highly odd that it wouldn't
20170225 22:22:55< DeFender1031> unless...
20170225 22:23:16< celticminstrel> Well, my impression is that an encountered tunnel tag is simply stored, without substitution/
20170225 22:23:31< DeFender1031> i think it may be special because it has the ability to change what's allowed based on the unit accessing it
20170225 22:23:37< celticminstrel> Then substitution occurs when it attempts to resolve the tunnel, eg for pathfinding.
20170225 22:23:58< celticminstrel> But really, it should substitute twice.
20170225 22:24:18< celticminstrel> And support delayed_variable_substitution=yes to prevent the first time.
20170225 22:26:04< DeFender1031> hard to do... it could support the same syntax as events for whether to do so now or later or mix, but there's no way to have it support both "i want $unit to mean the unit accessing it" and "i want $whatever to mean the variable I have when creating it"
20170225 22:26:29< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/src/game_events/action_wml.cpp#L857
20170225 22:26:49< celticminstrel> Hmm...
20170225 22:27:26< celticminstrel> cfg is a vconfig and is passed to the teleport_group constructor...
20170225 22:27:31< celticminstrel> I have no idea where that's defined.
20170225 22:28:33< celticminstrel> From the code in action_wml it would appear that substitution should be occurring.
20170225 22:28:56< celticminstrel> But of course it depents on teleport_group as well.
20170225 22:29:35< celticminstrel> ^depends
20170225 22:29:48< DeFender1031> it also seems strange that it would fail to substitute outside of the filter tag.
20170225 22:29:51< celticminstrel> I guess the fix would be to call .parsed_config() at some point.
20170225 22:30:23< celticminstrel> Well, all three tags are filters, right?
20170225 22:30:32< celticminstrel> The first is a unit filter, the others are location filters.
20170225 22:30:41< DeFender1031> oh, good point
20170225 22:32:27< zookeeper> would that make it so that $foo would substitute immediately but $|foo would substitute later (when doing pathfinding)?
20170225 22:32:31< DeFender1031> i think that if that's the case, substituting at creation time would cause issues.
20170225 22:32:48< celticminstrel> Well yes, it would cause issues.
20170225 22:32:56< celticminstrel> Which is why it would need to be optional.
20170225 22:33:00< DeFender1031> ah
20170225 22:33:01< DeFender1031> gotcha
20170225 22:33:25< DeFender1031> zookeeper, it would. as i understand it, internally, all $| is doing is turninig into a $ which tne gets parsed normally the next iteration\
20170225 22:33:51< celticminstrel> That's exactly correct.
20170225 22:33:52< DeFender1031> in fact, IIRC, a triple-nested event can have variables for the innermost escaped with $||foo
20170225 22:34:00< celticminstrel> Correct again.
20170225 22:34:26< DeFender1031> (meaning, the first substitution turns into "$|foo", the second into "$foo", and the final one into whatever is contained by $foo)
20170225 22:34:57< celticminstrel> For this reason, there's probably fewer issues from substituting than from not substituting.
20170225 22:35:11< DeFender1031> right.
20170225 22:35:56< DeFender1031> hmm... interesting. that'd mean that anything which is going to get multi-substituted would need to be multi-escaped for a plain $.
20170225 22:36:38-!- Bonobo [~Bonobo@2001:44b8:254:3200:6480:d056:2022:d29c] has joined #wesnoth-dev
20170225 22:36:45< DeFender1031> on the other hand, understanding that $| just turns into a $ and that the $|foo syntax is basically a manual delay of the substitution in that regard makes the whole issue somewhat less confusing.
20170225 22:36:57-!- UnwiseOwl [~UnwiseOwl@2.24.225.239] has joined #wesnoth-dev
20170225 22:44:42-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170225 22:59:23-!- RatArmy [~ratarmy@om126212080097.11.openmobile.ne.jp] has joined #wesnoth-dev
20170225 23:00:44-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 23:01:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has joined #wesnoth-dev
20170225 23:01:39-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3058:c31f:cead:441a] has quit [Remote host closed the connection]
20170225 23:05:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 23:13:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 23:14:25-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 23:16:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 23:40:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170225 23:40:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170225 23:54:41-!- gfgtdf_ [~chatzilla@x4e3699c7.dyn.telefonica.de] has joined #wesnoth-dev
20170225 23:57:20-!- gfgtdf [~chatzilla@x4e3699c7.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170225 23:57:20-!- gfgtdf_ is now known as gfgtdf
--- Log closed Sun Feb 26 00:00:03 2017