--- Log opened Tue Feb 28 00:00:09 2017
20170228 00:02:00-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170228 00:07:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170228 00:16:28-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170228 00:24:04-!- Bonobo [~Bonobo@129.127.113.21] has quit [Ping timeout: 255 seconds]
20170228 00:28:21-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 00:28:22< travis-ci> wesnoth/wesnoth#12784 (master - aa421ef : Celtic Minstrel): The build has errored.
20170228 00:28:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/205891696
20170228 00:28:22-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 00:37:46-!- TC04 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170228 00:38:59-!- Appleman1234 [~Appleman1@pl2098.nas824.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 00:50:59-!- Appleman1234 [~Appleman1@pl2098.nas824.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 252 seconds]
20170228 01:08:40-!- Appleman1234 [~Appleman1@pl1322.nas82h.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 01:25:41< irker966> wesnoth: Charles Dang wesnoth:master 08c82ccb4ff8 / src/game_initialization/ (flg_manager.cpp flg_manager.hpp): FLG Manager: code cleanup https://github.com/wesnoth/wesnoth/commit/08c82ccb4ff85455aa622aa9982a27685e1c95d5
20170228 01:25:44< irker966> wesnoth: Charles Dang wesnoth:master 275a72818496 / src/gui/dialogs/multiplayer/faction_select.cpp: Faction Select: use string constant for random enemy image https://github.com/wesnoth/wesnoth/commit/275a7281849677a13e9ede1a7dc3ca8eccddb0a5
20170228 01:25:47< irker966> wesnoth: Charles Dang wesnoth:master 9ef1e928c764 / src/ (6 files in 4 dirs): Cleaned up wml_separators.hpp includes https://github.com/wesnoth/wesnoth/commit/9ef1e928c764d961baa7d029ffccd94aea1ba38c
20170228 01:26:56< SigurdFD> celticminstrel: pr#941
20170228 01:29:22< irker966> wesnoth: sigurdfdragon wesnoth:master 05bc654e7675 / data/lua/wml-tags.lua: Fix a Lua error in [modify_side] https://github.com/wesnoth/wesnoth/commit/05bc654e7675119ece92e2145ac6950f2f7a59ab
20170228 01:35:47-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 01:35:48< travis-ci> wesnoth/wesnoth#12785 (master - 383f29c : gfgtdf): The build has errored.
20170228 01:35:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/205980197
20170228 01:35:48-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 01:43:08< SigurdFD> I've noticed two behavior changes with mp campaigns:
20170228 01:44:37< SigurdFD> 1. the 'use_map_settings' settings now have to be directly in [campaign] (including a dummy [side]) instead of the first [scenario]
20170228 01:45:00< SigurdFD> one can see the settings in scenario not working by looking at LoW
20170228 01:45:14< SigurdFD> with xp modifier 70/100
20170228 01:45:26< SigurdFD> this may have been recent?
20170228 01:46:57< irker966> wesnoth: Hironori Fujimoto wesnoth:master de090c164c27 / src/gui/widgets/text_box_base.cpp: Change std::string::length() to utf8::size() for unicode characters https://github.com/wesnoth/wesnoth/commit/de090c164c27188430747c43fa9e5c93c46a8a61
20170228 01:46:59< SigurdFD> 2. there used to be passthrough of stuff like xp_modifier and random_start_time. By that, I mean if you set xp to, say, 150, and if ...
20170228 01:47:26< SigurdFD> ... none of the following scenarios contained an xp_modifier key, you'd get 150 for all of them
20170228 01:48:01< SigurdFD> but now there isn't. I have no idea when this might have occured.
20170228 01:53:51-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170228 01:57:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170228 02:08:35-!- Appleman1234_ [~Appleman1@pl2136.nas82g.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 02:09:49< matthiaskrgr> In file included from ../src/game_initialization/flg_manager.cpp:15:
20170228 02:09:50< matthiaskrgr> ../src/game_initialization/flg_manager.hpp:108:13: warning: private field 'use_map_settings_' is not used [-Wunused-private-field]
20170228 02:09:52< matthiaskrgr>         const bool use_map_settings_;
20170228 02:09:53< matthiaskrgr> this is new, I think?
20170228 02:09:55< matthiaskrgr>                    ^
20170228 02:10:20< matthiaskrgr> probably since 08c82ccb4ff8  
20170228 02:11:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170228 02:11:16< matthiaskrgr> (clang build) 
20170228 02:11:46-!- Appleman1234 [~Appleman1@pl1322.nas82h.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 264 seconds]
20170228 02:15:14-!- Bonobo [~Bonobo@2001:44b8:254:3200:4809:cea3:8765:1fdd] has joined #wesnoth-dev
20170228 02:26:06< matthiaskrgr> wtf 
20170228 02:26:18< matthiaskrgr> 20170228 03:25:36 error preprocessor: Macro/file 'multiplayer/maps/2p_Swamp_Of_Dread.map' is missing
20170228 02:32:42-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 02:32:43< travis-ci> wesnoth/wesnoth#12786 (master - 76291ed : Charles Dang): The build has errored.
20170228 02:32:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/205992348
20170228 02:32:43-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 02:35:20-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20170228 02:46:27-!- Appleman1234_ [~Appleman1@pl2136.nas82g.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170228 02:57:58-!- Appleman1234_ [~Appleman1@pl325.nas82a.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 03:01:14-!- Appleman1234_ is now known as Appleman1234
20170228 03:38:41< celticminstrel> matthiaskrgr: Where'd you get the error in http://pastebin.com/36YFBGYD ? While the error message isn't useful, I think it actually suggests a problem in the WML.
20170228 03:39:58< celticminstrel> Specifically, if you use [animate_unit] with flag set to attack or defend, the hits=yes|no|hit|miss|kill key is required.
20170228 03:40:11< celticminstrel> The wiki says it's required, at least.
20170228 03:40:22< celticminstrel> I don't know if that should be enforced or relaxed.
20170228 03:40:41< celticminstrel> If zookeeper were around I'd ask him if he knows what the default effect is when it's missing...
20170228 03:47:26-!- TC04 is now known as TC01
20170228 03:49:29 * DeFender would vote for "hits" as default.
20170228 04:18:12-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 04:18:29-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has joined #wesnoth-dev
20170228 04:25:51-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 04:25:52< travis-ci> wesnoth/wesnoth#12789 (master - 9ef1e92 : Charles Dang): The build has errored.
20170228 04:25:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206024631
20170228 04:25:52-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 04:34:54-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 04:48:56-!- irker966 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170228 04:57:37-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170228 04:58:23< vultraz_iOS> celmin|sleep: I'm still seeing scrolling for messages :(
20170228 05:01:39-!- travis-ci [~travis-ci@ec2-54-196-19-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 05:01:40< travis-ci> wesnoth/wesnoth#12790 (master - 05bc654 : sigurdfdragon): The build has errored.
20170228 05:01:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206025358
20170228 05:01:40-!- travis-ci [~travis-ci@ec2-54-196-19-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 05:09:46< celticminstrel> vultraz_iOS: Maybe I forgot to update [message] to use the new feature?
20170228 05:10:39< celticminstrel> Hmm, that doesn't seem to be the case though...
20170228 05:12:08< celticminstrel> vultraz_iOS: Check if it works when you change that third false to true in message.lua. If so, it means I got the logic backwards in game_lua_kernel.cpp.
20170228 05:12:36< celticminstrel> That's line 357 in message.lua, lines 2380-2386 in game_lua_kernel.cpp.
20170228 05:12:56-!- irker348 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170228 05:12:56< irker348> wesnoth: Charles Dang wesnoth:master 42b53e69531d / data/multiplayer/scenarios/2p_Swamp_of_Dread.cfg: MP/Swamp of Dread: fixed incorrect case in map path (bug #25546) https://github.com/wesnoth/wesnoth/commit/42b53e69531d242c3b85897e74e3d6e33e54a74d
20170228 05:13:26< celticminstrel> Ah, is that what caused that.
20170228 05:14:53< vultraz_iOS> celticminstrel: I've also assigned bug 25541 to you
20170228 05:16:30< vultraz_iOS> Also this code doesn't make sense (message)
20170228 05:16:43< vultraz_iOS> You check scroll ~= false
20170228 05:16:53< vultraz_iOS> The comment even says scrolling is the default behavior..
20170228 05:16:56< vultraz_iOS> Oh, wait
20170228 05:17:13< vultraz_iOS> That's for the scroll key
20170228 05:17:16< celticminstrel> Yes.
20170228 05:17:26< celticminstrel> If it's false, don't scroll. If it's true or missing, scroll.
20170228 05:17:39< vultraz_iOS> Either way, changing the 4th argument to true doesn't do anything
20170228 05:17:45< vultraz_iOS> Neither the third one
20170228 05:17:48< celticminstrel> Hmm.
20170228 05:18:32< celticminstrel> Needs more investigation, I guess... it does look like the logic might be backwards, but it sounds like that's not the soleissue.
20170228 05:19:22-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has joined #wesnoth-dev
20170228 05:22:24< vultraz_iOS> celticminstrel: scrolling doesn't happen if the *last* arg is false
20170228 05:22:39< celticminstrel> ?
20170228 05:22:53< celticminstrel> Isn't that what I told you to try in the first place?
20170228 05:23:03< celticminstrel> Change false, false, true to false, false, false
20170228 05:23:07< vultraz_iOS> Oh
20170228 05:23:11< celticminstrel> Are you saying that does work, then?
20170228 05:23:18< vultraz_iOS> Yes that does work
20170228 05:23:25< vultraz_iOS> Sorry I got mixed up
20170228 05:23:32< vultraz_iOS> I thought you mean third or fourth argument
20170228 05:23:41< celticminstrel> Okay.
20170228 05:24:04< celticminstrel> So that means the contants need to be swapped in game_lua_kernel.
20170228 05:24:24< vultraz_iOS> The top level ternary?
20170228 05:24:41< celticminstrel> Yeah, it's the top level ternary that's backwards, not the nested one.
20170228 05:24:51< celticminstrel> So WARP and ONSCREEN_WARP swap.
20170228 05:24:55< celticminstrel> And the other two swap.
20170228 05:25:05< celticminstrel> ^nested ones
20170228 05:26:42< vultraz_iOS> Sweet
20170228 05:26:42< irker348> wesnoth: Charles Dang wesnoth:master d0837b5d9ecf / src/scripting/game_lua_kernel.cpp: Fixup c58e2d00 (backwards logic) https://github.com/wesnoth/wesnoth/commit/d0837b5d9ecf4936acc97644bfbc9b773d649601
20170228 05:26:50< vultraz_iOS> Now you just need to fix the animate unit crash
20170228 05:27:34< celticminstrel> Which should be easy, just waiting on feedback from someone who knows whether I should make it an error or use a default value.
20170228 05:27:49< vultraz_iOS> The hits bit is easy
20170228 05:27:55< vultraz_iOS> It still crashes after that
20170228 05:27:58< celticminstrel> Oh.
20170228 05:28:07< celticminstrel> I wasn't aware of that.
20170228 05:28:35< vultraz_iOS> Local hits = cig.hits or false is what I used and then it crashes without a stack trace
20170228 05:28:36< celticminstrel> I guess that's the bug you assigned? Which means it's probably that email I just heard come in.
20170228 05:28:41< vultraz_iOS> Yes
20170228 05:29:28< vultraz_iOS> It shouldn't spout an error on missing hits key
20170228 05:29:33< vultraz_iOS> It should use a default value
20170228 05:29:54< vultraz_iOS> Since not all animations are ones where hitting makes sense
20170228 05:30:03< SigurdFD> celticminstrel: I'm getting a wml-tags ln875 bad argument #1 to place_shroud (number expected, got vconfig) ...
20170228 05:30:18< celticminstrel> Well, I would've only given an error if hits was missing with flag=attack|defend.
20170228 05:30:28< SigurdFD> ... triggered by a place_shroud tag in SotA S2
20170228 05:31:05< celticminstrel> SigurdFD: Sounds like something that can be fixed in the Lua, though I could make the API more forgiving too.
20170228 05:31:31< celticminstrel> Though I'm not quite sure, could you show the code?
20170228 05:32:00< celticminstrel> Actually, if it got a vconfig, maybe it was supposed to be a SSF...
20170228 05:32:05< SigurdFD> you mean from SotA that's triggering it?
20170228 05:32:18< celticminstrel> Is it triggered by WML code or Lua code?
20170228 05:32:24< SigurdFD> wml
20170228 05:32:27< celticminstrel> Okay.
20170228 05:32:45< SigurdFD> it's a place shroud that just has side=1 in it
20170228 05:46:09< irker348> wesnoth: Celtic Minstrel wesnoth:master 39d31219e560 / data/lua/wml-tags.lua: Accept [place_shroud]/[remove_shroud] with just a side key https://github.com/wesnoth/wesnoth/commit/39d31219e5607d0c02d6eef8b0cc0d8e89f3341c
20170228 05:46:20< celticminstrel> SigurdFD: That should fix it.
20170228 05:46:47< celticminstrel> Oh, I suppose I should've changed the commit message since it turned out to be more than just that. Oh well.
20170228 05:49:29< SigurdFD> thanks
20170228 05:52:26-!- travis-ci [~travis-ci@ec2-54-196-19-74.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 05:52:27< travis-ci> wesnoth/wesnoth#12792 (master - de090c1 : Hironori Fujimoto): The build has errored.
20170228 05:52:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206029129
20170228 05:52:27-!- travis-ci [~travis-ci@ec2-54-196-19-74.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 05:57:18< vultraz_iOS> ^ if anyone's wondering why there's a commit from that person it's because I used the rebase and merge feature in GH
20170228 06:02:08< celticminstrel> I assumed that.
20170228 06:02:20< celticminstrel> Actually I assumed squash and merge.
20170228 06:02:24< celticminstrel> But close enough.
20170228 06:04:25-!- JyrkiVesterinen [~JyrkiVest@87-100-150-152.bb.dnainternet.fi] has joined #wesnoth-dev
20170228 06:12:59< SigurdFD> celticminstrel: hmmm... now it's line878 number expected, got side
20170228 06:15:26< irker348> wesnoth: Celtic Minstrel wesnoth:master 5cd756f1b003 / data/lua/wml-tags.lua: fixup! Accept [place_shroud]/[remove_shroud] with just a side key https://github.com/wesnoth/wesnoth/commit/5cd756f1b0033118ba3760fda635c47a75e39793
20170228 06:15:38< celticminstrel> Forgot the side filter returns a side userdata rather than numbers.3
20170228 06:19:37< SigurdFD> basic::string_M_contruct null not valid    ....
20170228 06:19:44< celticminstrel> ...
20170228 06:19:48< celticminstrel> What.
20170228 06:19:56< SigurdFD> I also just tried i,s and i.side that didn't work either
20170228 06:21:11< SigurdFD> hmm.... let me try something...
20170228 06:22:55< celticminstrel> Pretty sure the Lua implementation of the tag is correct now.
20170228 06:23:11< celticminstrel> So if there's still a problem, it'd be in the C++ implementation of the API call, I think.
20170228 06:23:39< SigurdFD> tried side.number & side.side_number... didn't work
20170228 06:24:51< celticminstrel> .side is definitely correct according to lua_team.cpp.
20170228 06:24:58< SigurdFD> hmmm.. might be i, side_number that's needed
20170228 06:25:32< celticminstrel> sides is the output of wesnoth.get_sides.
20170228 06:26:20< SigurdFD> ok, I have no more ideas
20170228 06:27:37-!- Kwandulin [~Miranda@p200300760F7B96D9BCAE0DE5A209683B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170228 06:30:38-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170228 06:31:29-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20170228 06:31:30-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20170228 06:58:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170228 06:58:56-!- Kwandulin [~Miranda@p200300760F7B96D9BCAE0DE5A209683B.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20170228 07:01:06-!- Kwandulin [~Miranda@p200300760F7B967ABCAE0DE5A209683B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170228 07:02:15-!- Appleman1234 [~Appleman1@pl325.nas82a.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170228 07:03:22-!- JyrkiVesterinen [~JyrkiVest@87-100-150-152.bb.dnainternet.fi] has quit [Quit: .]
20170228 07:13:58-!- madmax28 [~madmax28@xdsl-89-0-86-77.netcologne.de] has quit [Ping timeout: 268 seconds]
20170228 07:14:53-!- madmax28 [~madmax28@xdsl-213-196-227-208.netcologne.de] has joined #wesnoth-dev
20170228 07:22:11-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 07:22:12< travis-ci> wesnoth/wesnoth#12794 (master - 42b53e6 : Charles Dang): The build failed.
20170228 07:22:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206064208
20170228 07:22:12-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 07:30:00-!- Appleman1234 [~Appleman1@pl4821.nas828.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 07:36:29-!- JyrkiVesterinen [~JyrkiVest@85.76.81.247] has joined #wesnoth-dev
20170228 07:51:52< irker348> wesnoth: Charles Dang wesnoth:master b3830b9b098d / data/campaigns/Secrets_of_the_Ancients/_main.cfg: SotA: use the mainline editor terrain group icon https://github.com/wesnoth/wesnoth/commit/b3830b9b098d22c7d51dac44423d5608eae525f2
20170228 07:59:56-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 08:00:03-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 08:00:04< travis-ci> wesnoth/wesnoth#12795 (master - d0837b5 : Charles Dang): The build failed.
20170228 08:00:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206066086
20170228 08:00:04-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 08:01:53-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170228 08:08:11-!- Rh0nda is now known as Rhonda
20170228 08:08:14-!- Rhonda [~rhonda@anguilla.debian.or.at] has quit [Changing host]
20170228 08:08:14-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20170228 08:11:38< vultraz_iOS> zookeeper: I have something I think you'll like
20170228 08:12:19< zookeeper> oh?
20170228 08:12:36< irker348> wesnoth: Charles Dang wesnoth:master 48d35a319910 / src/mouse_handler_base.cpp: Don't handle mousewheel scrolling if mouse is not in game map area (bug #24501) https://github.com/wesnoth/wesnoth/commit/48d35a319910df45330b42904b88832ffab08a55
20170228 08:12:38< vultraz_iOS> ^
20170228 08:13:02< vultraz_iOS> Fixes that pesky bug where using the wheel to scroll the editor palette also scrolls the map
20170228 08:13:49< zookeeper> ohhhhh, very good
20170228 08:14:14-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170228 08:14:20 * zookeeper pats vultraz_iOS on the head with a chocolate cookie
20170228 08:14:29< zookeeper> well done
20170228 08:14:40< vultraz_iOS> Nom nom
20170228 08:14:52< The_Unforgiven> o_O Interesting join time.
20170228 08:15:18< vultraz_iOS> :p
20170228 08:17:44< vultraz_iOS> That bug's been around since 1.12 I think
20170228 08:17:55< vultraz_iOS> Or really, 1.11
20170228 08:18:28< vultraz_iOS> All for want of a single if block
20170228 08:19:04< zookeeper> it's not in 1.12
20170228 08:19:19< vultraz_iOS> Oh?
20170228 08:19:31< vultraz_iOS> Well, whatever. It's not there now
20170228 08:20:42-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170228 08:20:45< vultraz_iOS> I was very annoying
20170228 08:20:48< vultraz_iOS> It *
20170228 08:21:05< vultraz_iOS> Basically added 10% extra time to mapmaking
20170228 08:21:07< zookeeper> yes, yes it was
20170228 08:24:55-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Remote host closed the connection]
20170228 08:26:21-!- The_Unforgiven [~quassel@c-73-18-73-236.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170228 08:26:21-!- The_Unforgiven [~quassel@c-73-18-73-236.hsd1.mi.comcast.net] has quit [Changing host]
20170228 08:26:21-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170228 08:40:48-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has joined #wesnoth-dev
20170228 08:41:33-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 08:41:34< travis-ci> wesnoth/wesnoth#12796 (master - 39d3121 : Celtic Minstrel): The build failed.
20170228 08:41:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206069075
20170228 08:41:34-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 08:58:35-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 09:01:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170228 09:16:10< vultraz_iOS> celticminstrel: looks like the anime crash has something to do with lua_rgeti
20170228 09:16:16< vultraz_iOS> Er
20170228 09:16:24< vultraz_iOS> lua_rawgeti
20170228 09:17:26-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170228 09:20:56-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 09:20:57< travis-ci> wesnoth/wesnoth#12797 (master - 5cd756f : Celtic Minstrel): The build failed.
20170228 09:20:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206073455
20170228 09:20:57-!- travis-ci [~travis-ci@ec2-107-20-33-32.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 09:29:47-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has joined #wesnoth-dev
20170228 09:37:02-!- Appleman1234 [~Appleman1@pl4821.nas828.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170228 09:38:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20170228 09:38:50-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170228 09:42:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170228 09:53:52-!- gk-1wm-su [~111111111@185.45.12.212] has joined #wesnoth-dev
20170228 09:53:53-!- gk-1wm-su [~111111111@185.45.12.212] has left #wesnoth-dev []
20170228 09:55:49-!- Kwandulin [~Miranda@p200300760F7B967ABCAE0DE5A209683B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170228 09:57:42-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170228 10:02:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170228 10:04:03-!- JyrkiVesterinen [~JyrkiVest@85.76.81.247] has quit [Quit: .]
20170228 10:11:31-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 10:11:32< travis-ci> wesnoth/wesnoth#12798 (master - b3830b9 : Charles Dang): The build is still failing.
20170228 10:11:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206088714
20170228 10:11:32-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 10:34:17-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170228 10:38:38-!- Appleman1234 [~Appleman1@pl1544.nas82a.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 10:41:47-!- The_Unforgiven [~quassel@2601:40a:c102:84cd:6430:e28:4d13:7a6f] has joined #wesnoth-dev
20170228 10:41:47-!- The_Unforgiven [~quassel@2601:40a:c102:84cd:6430:e28:4d13:7a6f] has quit [Changing host]
20170228 10:41:47-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170228 10:43:11-!- Appleman1234_ [~Appleman1@pl3575.nas828.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 10:45:32-!- Appleman1234 [~Appleman1@pl1544.nas82a.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 252 seconds]
20170228 10:48:57-!- Appleman1234_ is now known as Appleman1234
20170228 10:55:15-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170228 11:08:48-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20170228 11:08:49< travis-ci> wesnoth/wesnoth#12799 (master - 48d35a3 : Charles Dang): The build is still failing.
20170228 11:08:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206093330
20170228 11:08:49-!- travis-ci [~travis-ci@ec2-54-198-202-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20170228 11:12:47-!- irker348 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170228 11:13:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170228 11:27:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170228 11:53:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170228 11:54:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170228 12:00:54< matthiaskrgr> 04:38 < celticminstrel> matthiaskrgr: Where'd you get the error in http://pastebin.com/36YFBGYD ? While the error message isn't useful, I think it actually 
20170228 12:00:57< matthiaskrgr>                         suggests a problem in the WML.
20170228 12:01:21< matthiaskrgr> it simply happens when moving next to delfador and clicking through the dialog  
20170228 12:03:28< matthiaskrgr> there are a couple of other lua errors in other parts of the game, too 
20170228 12:04:51-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170228 12:09:58-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 264 seconds]
20170228 12:14:59-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170228 12:17:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170228 12:18:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170228 12:27:22-!- aidanhs [~aidanhs@2a00:d880:6:1ad::8e27] has quit [Ping timeout: 264 seconds]
20170228 12:37:41-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20170228 12:37:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170228 12:38:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170228 12:43:52-!- Bonobo [~Bonobo@2001:44b8:254:3200:4809:cea3:8765:1fdd] has quit [Ping timeout: 255 seconds]
20170228 13:03:08-!- Appleman1234 [~Appleman1@pl3575.nas828.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170228 13:19:20-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 13:33:28-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has joined #wesnoth-dev
20170228 13:44:29-!- Appleman1234 [~Appleman1@pl3648.nas828.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170228 13:45:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170228 13:54:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170228 14:11:41-!- gfgtdf [~chatzilla@x50abb1f0.dyn.telefonica.de] has joined #wesnoth-dev
20170228 14:11:47< gfgtdf> 20170228 01:44:37< SigurdFD> 1. the 'use_map_settings' settings now have to be directly in [campaign] (including a dummy [side]) instead of the first [scenario]
20170228 14:12:06< gfgtdf> SigurdFD: you mena you now have to put some [side] om [campaign] for some reason ?
20170228 14:21:41-!- RatArmy_ [~ratarmy@om126229092027.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 14:23:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170228 14:24:46< zookeeper> uh. use_map_settings in [campaign]? what's this?
20170228 14:25:05< zookeeper> for multiplayer campaigns? if so then nevermind.
20170228 14:25:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170228 14:28:42< gfgtdf> 20170228 01:45:00< SigurdFD> one can see the settings in scenario not working by looking at LoW
20170228 14:29:16< gfgtdf> it shouldn't be possible to change any of those settings in LoW so i don't know what you mean here
20170228 14:31:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 268 seconds]
20170228 15:31:43-!- gfgtdf_ [~chatzilla@x50abb1f0.dyn.telefonica.de] has joined #wesnoth-dev
20170228 15:34:50-!- gfgtdf [~chatzilla@x50abb1f0.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170228 15:34:53-!- gfgtdf_ is now known as gfgtdf
20170228 15:40:30-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: .]
20170228 15:49:39-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170228 15:50:25< zookeeper> funny. TerrainGraphicsWML doesn't seem to allow distinguishing between border and non-border hexes in any way.
20170228 15:55:17< zookeeper> or if it does, then only in a very complicated manner.
20170228 15:57:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170228 16:09:58< zookeeper> there's also a very subtle inconsistency with how rules are matched when a part of the rule is completely off-map. bottom and right edges are seemingly treated differently than top and left edges.
20170228 16:10:17< zookeeper> kinda hard to describe
20170228 16:11:07< DeFender> zookeeper, yeah, i've noticed that there isn't really proper handling of border hexes.
20170228 16:20:52-!- Appleman1234 [~Appleman1@pl3648.nas828.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170228 16:32:27< gfgtdf> i'm here getting a wrong color for poisoned units, note sure whterh its casued by bad wml or a n engine bug tohugh
20170228 16:34:06-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170228 16:43:14< zookeeper> holy crap what's wrong with the attack dialog
20170228 16:43:26< zookeeper> gfgtdf, yeah me too
20170228 16:43:34< zookeeper> white instead of green
20170228 16:45:39< zookeeper> vultraz, maybe a tiny little bit too tall i'd say: https://dl.dropboxusercontent.com/u/63964618/wesnoth/attack_dialog_size_bug.jpg
20170228 16:46:15-!- Kwandulin [~Miranda@p4FC3DB2C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170228 16:48:12< gfgtdf> zookeeper: looks unintended, mostliklely related to the fix for 'scrollbar appreads in advance dialog'
20170228 16:49:40-!- Tad_Carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170228 16:49:42-!- Gregory_Lundberg [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170228 16:51:31< gfgtdf> vultraz: ^ likeley casued by  https://github.com/wesnoth/wesnoth/commit/e2065867a66459e32a511d2f5f37cce59490d0bb
20170228 16:51:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170228 16:51:56< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 48d35a3: Don't handle mousewheel scrolling if mouse is not in game map area (bug #24501) Failed
20170228 16:51:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-262
20170228 16:52:01-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170228 16:55:20-!- Gregory_Lundberg [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20170228 16:55:32-!- Tad_Carlucci [~lundberg@74.193.219.119] has quit [Quit: Leaving]
20170228 17:03:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170228 17:10:48-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170228 17:11:32< SigurdFD> < gfgtdf> SigurdFD: you mena you now have to put some [side] om [campaign] for some reason ?
20170228 17:11:34< SigurdFD> Yes
20170228 17:12:31< SigurdFD> 14:29:16< gfgtdf> it shouldn't be possible to change any of those settings in LoW so i don't know what you mean here
20170228 17:13:18< SigurdFD> it's not possible to change them. The issue is that mp campaign is keyed for 100% xp modifier throughout, yet 70 is what shows on the Create Game screen
20170228 17:15:40< gfgtdf> SigurdFD: hmm maybe we shoudl just show it as default value 100 for mp campaigns there
20170228 17:15:50< gfgtdf> why exactly do you have to put [side] there?
20170228 17:16:43< SigurdFD> [side] is needed so that the desired values for village_gold,village_support,fog, & shroud show as intended in a mp_campaign
20170228 17:17:12< SigurdFD> previously, (in 1.12) it would fetch these values from the first scenario of an mp_campaign
20170228 17:17:55< gfgtdf> hmm maybe we shodul just hide those scrollbars for mp campaign then. afaik they always just effected the first scneario of a campaoign anways.
20170228 17:18:57< SigurdFD> in 1.12 some of them affected every scenario (though it was undocumented)
20170228 17:20:03< SigurdFD> which is related to #2 I mentioned
20170228 17:21:20< SigurdFD> there's at least 2 campaigns that made use of allowing the player to change the items in the use_map_setting section
20170228 17:22:43< gfgtdf> SigurdFD: all of those settings? which campaigns are that?
20170228 17:23:11< gfgtdf> there is also a realted issue in the tracker https://gna.org/bugs/?23037
20170228 17:23:38< SigurdFD> The Great Quest & Random Campaign
20170228 17:24:28-!- atarocch [~atarocch@93.56.160.29] has quit [Ping timeout: 268 seconds]
20170228 17:26:46< gfgtdf> SigurdFD: hmm at ltest "the grreat quest" used [multiplaeyr] instead of  [campaign] so it doesnt apply
20170228 17:26:51< gfgtdf> will think about it
20170228 17:27:03< SigurdFD> I'm not opposed to a behavior change here...
20170228 17:28:12< SigurdFD> Though I think there should be somethnig done about the fact that experience modifier only takes affect for the first scenario
20170228 17:28:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170228 17:45:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170228 17:45:24-!- JyrkiVesterinen [~JyrkiVest@78-27-94-36.bb.dnainternet.fi] has joined #wesnoth-dev
20170228 17:48:10-!- Kwandulin [~Miranda@p4FC3DB2C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170228 17:58:39-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170228 17:58:39< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 48d35a3: Don't handle mousewheel scrolling if mouse is not in game map area (bug #24501) Failed
20170228 17:58:39< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-259
20170228 17:58:44-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170228 18:10:07< celmin> Heh, "anime crash". Silly vultraz.
20170228 18:10:22< celmin> Huh. Apparently I disconnected while asleep.
20170228 18:10:31< celmin> matthiaskrgr: Sorry, uh... which campaign/scenario?
20170228 18:10:39-!- celmin is now known as celticminstrel
20170228 18:11:42< matthiaskrgr> celticminstrel: the tutorial
20170228 18:11:50< celticminstrel> Ah, okay.
20170228 18:11:55< matthiaskrgr> move konrad next to delfador, click through dialog
20170228 18:12:07< matthiaskrgr> right as the training dummy is supposed to appear
20170228 18:12:23< celticminstrel> Yeah, I understand now.
20170228 18:32:50-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170228 18:50:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170228 18:56:44-!- Kwandulin [~Miranda@p200300760F7B967AD1B3830867CEA443.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170228 18:58:44< JyrkiVesterinen> celticminstrel: I have been investigating the failing WML unit test. The failure is caused by your WML tag porting.
20170228 18:58:50< JyrkiVesterinen> Here is the call stack: https://gist.github.com/jyrkive/f39df28bcf53baf4c0f27bdb5f1d6e05
20170228 18:59:05< JyrkiVesterinen> And the problematic part of test: https://github.com/wesnoth/wesnoth/blob/master/data/test/scenarios/ai/modify/aspects.cfg#L116-L122
20170228 19:00:07< JyrkiVesterinen> Apparently you disallowed wildcards in [modify_ai] paths while porting, but the unit test in question uses such a wildcard.
20170228 19:00:47-!- atarocch [~atarocch@93.56.160.30] has joined #wesnoth-dev
20170228 19:03:20< celticminstrel> JyrkiVesterinen: I was aware that it was caused by the porting, but not of the details, so thanks for looking into it.
20170228 19:06:28< celticminstrel> Hmmm...
20170228 19:07:15< celticminstrel> It actually looks like it's the test that's in error here.
20170228 19:07:54< celticminstrel> I think it's a relic of an earlier revision of the AI reworking and should actually be facet[default] or similar.
20170228 19:08:48< celticminstrel> facet[default_facet] apparently (just checked in aspect.hpp)
20170228 19:11:44-!- JyrkiVesterinen [~JyrkiVest@78-27-94-36.bb.dnainternet.fi] has quit [Quit: Rebooting]
20170228 19:13:44< celticminstrel> Irker didn't announce for some reason, so here: https://github.com/wesnoth/wesnoth/commit/4e7a2072f09f4f87f53f9d86461403fee07547e8
20170228 19:15:52-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170228 19:15:58-!- irker675 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170228 19:15:58< irker675> wesnoth: Celtic Minstrel wesnoth:master 4e7a2072f09f / data/test/scenarios/ai/modify/aspects.cfg: Fix a unit test still using experimental syntax https://github.com/wesnoth/wesnoth/commit/4e7a2072f09f4f87f53f9d86461403fee07547e8
20170228 19:16:22< celticminstrel> Ahh, it was just bizarrely slow, huh.
20170228 19:16:58-!- JyrkiVesterinen [~jyrki@78-27-94-36.bb.dnainternet.fi] has joined #wesnoth-dev
20170228 19:17:09< Kwandulin> zookeeper: your comment on the fighter's taunt + Sapient's suggestion?
20170228 19:22:16< Kwandulin> -comment +thoughts
20170228 19:25:34-!- JyrkiVesterinen [~jyrki@78-27-94-36.bb.dnainternet.fi] has quit [Ping timeout: 264 seconds]
20170228 19:30:32-!- JyrkiVesterinen [~jyrki@78-27-94-36.bb.dnainternet.fi] has joined #wesnoth-dev
20170228 19:31:41< zookeeper> Kwandulin, i think his suggestion makes sense as an improvement, although i didn't think it was bad as-is
20170228 19:33:09< zookeeper> raising the shield a few pixels should be easy, and adding a few little shock/soundwave type effects to signify the beating of the axe against the shield would make it a lot clearer too
20170228 19:34:41< Kwandulin> I don't think changing the height is a good idea, the whole face would then end up behind the shield
20170228 19:35:34< zookeeper> if it would, then yeah i guess not a good idea then
20170228 19:36:22< Kwandulin> it's already one pixel below the eyes
20170228 19:36:33< Kwandulin> Anyway, I'll first see how it looks ingame
20170228 19:36:48< Kwandulin> (Is something like that even wanted?)
20170228 19:37:19< zookeeper> i'm personally not interested in animations at all anymore
20170228 19:37:31< zookeeper> i think they should all be removed :p
20170228 19:37:34< celticminstrel> I personally think it's a great idea for a victory animation.
20170228 19:38:00< celticminstrel> Or something similar. I don't remember off the top of my head if there are any other animations for which that could be appropriate.
20170228 19:39:02< zookeeper> master-at-arms has a victory animation, IIRC
20170228 19:39:09< zookeeper> dunno if any others
20170228 19:39:14< celticminstrel> Ulfserker?
20170228 19:39:18< celticminstrel> I think?
20170228 19:40:15< Kwandulin> Nah, he laughs before attacking a 0-attack unit
20170228 19:41:27< celticminstrel> Ah, what's that animation called?
20170228 19:41:44< zookeeper> it has no name
20170228 19:41:44< Kwandulin> I'm pretty sure that's a custom one
20170228 19:42:14< celticminstrel> I thought you could only trigger custom animations from WML.
20170228 19:42:28< zookeeper> it's an attack animation
20170228 19:42:48< celticminstrel> Ah, a special attack animation with extra frames at the start?
20170228 19:42:52< zookeeper> yeah
20170228 19:43:16< celticminstrel> Hmm. Well, the shield-beating could be something like that too, I suppose.
20170228 19:43:51< zookeeper> idle or victory anim, i'd say
20170228 19:44:34-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170228 20:00:24< Kwandulin> Updated: https://forums.wesnoth.org/viewtopic.php?p=608968#p608968
20170228 20:01:35< Kwandulin> The extent of the shock/soundwave is certainly up for discussion, but as there are several fighters on the map in most cases, I went for a minor effect
20170228 20:02:47< The_Unforgiven> Kwandulin: I feel like something is off with the head animation, but I can't pinpoint what...
20170228 20:03:47< Kwandulin> Mhh, right, it's a bit bouncy between the two bashes
20170228 20:05:09< The_Unforgiven> And a black outline on the right/top of his head that seems slightly weird. (But I only saw that by putting my face 2 inces from my 11.6 inch screen)
20170228 20:06:01< DeFender> hey The_Unforgiven, how goes it?
20170228 20:07:53-!- gfgtdf [~chatzilla@x50abb1f0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]]
20170228 20:12:06< The_Unforgiven> Kwandulin: Although, I feel like those are very minor details. That is great work overall, and deffinately deserves praise. 
20170228 20:17:48< Kwandulin> Okay, I fixed those two things and updated the post, thanks for the note
20170228 20:21:41< irker675> wesnoth: Hironori Fujimoto wesnoth:master 9762d021a951 / src/font/sdl_ttf.cpp: make multi chunk sentences visible in help pages https://github.com/wesnoth/wesnoth/commit/9762d021a951907966ad80c4f3647051f8e75ae9
20170228 20:21:43< irker675> wesnoth: Hironori Fujimoto wesnoth:master 7544b139b664 / src/font/sdl_ttf.cpp: change sdl_blit to blit_surface, in order to prevent alpha blending https://github.com/wesnoth/wesnoth/commit/7544b139b664c5a6883aced4ddb99881309dab4f
20170228 20:21:45< irker675> wesnoth: Hironori Fujimoto wesnoth:master b8456fead58b / src/font/sdl_ttf.cpp: remove useless adjust_surface_alpha() https://github.com/wesnoth/wesnoth/commit/b8456fead58b9144b24fc5631b19a056e5c5ebf5
20170228 20:21:47< irker675> wesnoth: Jyrki Vesterinen wesnoth:master c74fcca29b85 / src/font/sdl_ttf.cpp: Merge pull request #937 from fujimo-t/fix_25332 https://github.com/wesnoth/wesnoth/commit/c74fcca29b859c7c1ad91c56a88f8e6d1264b793
20170228 20:30:01< The_Unforgiven> Kwandulin: It still ever so slightly bulges on the top right, but I can barely see it anymore. Just one tiny pixel, right when the top of the axe meets the top right of his head... My only complaint now, good work.
20170228 20:31:18-!- RatArmy_ [~ratarmy@om126204192010.6.openmobile.ne.jp] has joined #wesnoth-dev
20170228 20:40:51< Kwandulin> Right, I'll note it down
20170228 21:05:35-!- gfgtdf [~chatzilla@x50abb1f0.dyn.telefonica.de] has joined #wesnoth-dev
20170228 21:09:43< irker675> wesnoth: Charles Dang wesnoth:master f52d6499dcb2 / data/gui/widget/unit_preview_pane.cfg: Unit Preview Pane: fixup e2065867a. We only want the default dimensions for the  https://github.com/wesnoth/wesnoth/commit/f52d6499dcb2e3d067d1f26ff794a3d276ce19e4
20170228 21:12:58< celticminstrel> Oh right, zookeeper - in [animate_unit] with flag=attack or flag=defend, what do you think should be the behaviour if hits is missing?
20170228 21:18:53< zookeeper> celticminstrel, doesn't seem to matter. if you have to pick one, then i'd say hits=yes should be the default.
20170228 21:19:07< celticminstrel> So pick a default rather than giving an error. Got it.
20170228 21:19:29< celticminstrel> In that case, maybe the wiki should be updated to not claim the hits key is required.
20170228 21:21:29< irker675> wesnoth: Celtic Minstrel wesnoth:master b37d7233d5fd / data/lua/wml/animate_unit.lua: [animate_unit] now defaults to hits=yes if missing https://github.com/wesnoth/wesnoth/commit/b37d7233d5fd317fe5a817c33344b0ce04be5c0f
20170228 21:21:51< celticminstrel> From what vultraz said there still seems to be a problem with [animate_unit] though.
20170228 21:21:58< celticminstrel> Or was that matthiaskrgr. I forget.
20170228 21:26:17< irker675> wesnoth: Celtic Minstrel wesnoth:master ee79eb426e65 / src/scripting/game_lua_kernel.cpp: Fix some invalid Lua stack accesses in [animate_unit] https://github.com/wesnoth/wesnoth/commit/ee79eb426e658dc7b71a29273b838a00a21780cc
20170228 21:26:32< celticminstrel> I think that should fix the crash. Somehow I forgot a minus sign.
20170228 21:29:45-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170228 21:30:19< irker675> wesnoth: Jyrki Vesterinen wesnoth:master 09d9054e4ad2 / src/ (11 files in 5 dirs): Stop calling adjust_surface_alpha() with SDL_ALPHA_OPAQUE https://github.com/wesnoth/wesnoth/commit/09d9054e4ad241739061426f8e98efc5ede8b128
20170228 21:33:21-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Remote host closed the connection]
20170228 21:33:32< celticminstrel> This is because originally adjust_surface_alpha actually changed the alpha value of every pixel, but vultraz decided to change it.
20170228 21:33:39-!- The_Unforgiven [~quassel@2601:40a:c102:84cd:6430:e28:4d13:7a6f] has joined #wesnoth-dev
20170228 21:33:39-!- The_Unforgiven [~quassel@2601:40a:c102:84cd:6430:e28:4d13:7a6f] has quit [Changing host]
20170228 21:33:39-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170228 21:33:53< celticminstrel> Admittedly, changing the alpha value of every pixel might not have been a good idea in the first place, though...
20170228 21:34:20< vultraz_iOS> celticminstrel: animate unit still broken
20170228 21:35:41< vultraz_iOS> Just go to the tutorial and try to get delf to summon the quintain
20170228 21:35:59< vultraz_iOS> Says attempt to index nil value
20170228 21:37:46< celticminstrel> Fun! But it sounds like it did get past the previous issue?
20170228 21:37:54< celticminstrel> Or is that the same as the previous issue?
20170228 21:46:20< gfgtdf> zookeeper: do you know why leadership doenst effect allies?
20170228 21:47:06< zookeeper> gfgtdf, must be balance
20170228 21:47:53< zookeeper> (specifically 2vs2 MP balance, i'd imagine)
20170228 21:48:24-!- atarocch [~atarocch@93.56.160.30] has quit [Ping timeout: 268 seconds]
20170228 21:52:49-!- Kwandulin [~Miranda@p200300760F7B967AD1B3830867CEA443.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170228 21:53:48< gfgtdf> hmm bu't id image in it's quite hard to move yout units in a ways that yourt allies can much benefit from it, considering that you cannot control the leader and the lowlevel units at the same time.
20170228 21:54:25< gfgtdf> i mnea in sp you usuualy try to move the leader to the units that attacks and then move the leader to the next untis that attacks in suhc a mp scewnario you cannot do that.
20170228 21:58:29< zookeeper> gfgtdf, well sure you can, depending on turn order of course
20170228 21:58:30-!- Bonobo [~Bonobo@2001:44b8:254:3200:70ee:41b6:d79b:7a18] has joined #wesnoth-dev
20170228 21:58:38< zookeeper> ask bonobo here :P
20170228 21:58:56< gfgtdf> hi bonobo
20170228 21:59:00< Bonobo> hi
20170228 21:59:25< gfgtdf> Bonobo: you have an opinion on making leadership effecting allies in mp ?
20170228 21:59:34-!- atarocch [~atarocch@93.56.160.30] has joined #wesnoth-dev
20170228 22:00:14< Bonobo> I think it would be intuitive. I've always thought it didn't make sense that allies weren't boosted too
20170228 22:00:30< zookeeper> i was just saying that i think the reason why it doesn't affect allies is MP balance
20170228 22:00:44< zookeeper> i don't know for sure but it's pretty much the only reason there is
20170228 22:05:01-!- Bonobo [~Bonobo@2001:44b8:254:3200:70ee:41b6:d79b:7a18] has quit [Ping timeout: 246 seconds]
20170228 22:05:42-!- Bonobo [~Bonobo@2001:44b8:254:3200:dcaa:97a8:a4bf:3e5a] has joined #wesnoth-dev
20170228 22:06:22< Bonobo> as long as the leadership doesn't stack to 50% it ought to be okay
20170228 22:06:43-!- JyrkiVesterinen [~jyrki@78-27-94-36.bb.dnainternet.fi] has quit [Quit: .]
20170228 22:10:30< gfgtdf> well 50% leadership is possible for exampel with lvl 0 units and a lvl 2 leader
20170228 22:10:54< Bonobo> 50% boost for a unit 1 level below I mean
20170228 22:12:02< gfgtdf> Bonobo: you mean as in "25 for own leader + 25% for allied leader=50%" ?
20170228 22:12:11< Bonobo> yeah
20170228 22:13:52< zookeeper> it is the intuitive behavior so that also does suggest it's intentional. it's certainly came up in the past
20170228 22:14:09< irker675> wesnoth: Charles Dang wesnoth:master 097867429bae / / (6 files in 4 dirs): Addons Manager: allow installing addons on list row double click (bug #25547) https://github.com/wesnoth/wesnoth/commit/097867429baedf406d30bd6559dcdac3b28a32b1
20170228 22:15:16< zookeeper> i suppose one could argue that trying to juggle leaders to provide leadership for allies could be tricky enough that it'd end up being annoying to be compelled to do it all the time, so it's easier for everyone to just not have it. but i'm pretty sure that's _not_ the reason :p
20170228 22:16:52< Bonobo> I also feel like I've heard the explanation from someone, many years ago
20170228 22:20:20< gfgtdf> zookeeper: well in mp coop campaign, in particular LoW its quite annyoing that leadership doesnt work on allied units, in particular mp LoW has some scenario where each side onyl controla a very few units so that leadership is there basically useless (as opposed in th esp version) with the current bahviour
20170228 22:21:32< gfgtdf> zookeeper: the curent baviour also encourages both players even more not to mix their units and fight on their own front of the battle.
20170228 22:23:13< zookeeper> i'm sure the arguments for why it's the way it is now are findable, then one can see if they still apply
20170228 22:24:57-!- louis94 [~~louis94@17.49-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170228 22:36:47< matthiaskrgr> celticminstrel: it's still not working ;_;
20170228 22:37:01< celticminstrel> :(
20170228 22:37:13< matthiaskrgr> http://pastebin.com/aWbFsAfi  
20170228 22:37:16< matthiaskrgr> same as before I think?
20170228 22:37:47-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170228 22:37:52< celticminstrel> Hmm...
20170228 22:40:23< matthiaskrgr> can you not reproduce locally? 
20170228 22:44:51< gfgtdf> celticminstrel: you opo 2 values here: https://github.com/wesnoth/wesnoth/blob/ee79eb426e658dc7b71a29273b838a00a21780cc/src/scripting/game_lua_kernel.cpp#L382 maybe thats related
20170228 22:46:42< celticminstrel> That does seem like it could be related. Thanks for spotting that, gfgtdf.
20170228 22:47:44< irker675> wesnoth: Celtic Minstrel wesnoth:master d6b5f8428ae3 / src/scripting/game_lua_kernel.cpp: Fix popping one value too many in [animate_unit] https://github.com/wesnoth/wesnoth/commit/d6b5f8428ae3494f4455afe4f0ac34eb17f68811
20170228 22:48:01< celticminstrel> I actually didn't try to reproduce locally yet... but if that doesn't fix it I'll have to do so.
20170228 22:48:11-!- louis94 [~~louis94@17.49-65-87.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20170228 22:48:48< celticminstrel> I've been mostly doing other things, only popping into Wesnoth as people ping me about stuff.
20170228 22:55:50< matthiaskrgr> still bugged http://pastebin.com/y8AqqPxv :\
20170228 22:57:38< celticminstrel> Right, building now.
20170228 23:11:01-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170228 23:26:11-!- RatArmy_ [~ratarmy@om126204192010.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 23:29:35-!- RatArmy_ [~ratarmy@om126204192010.6.openmobile.ne.jp] has joined #wesnoth-dev
20170228 23:30:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170228 23:33:47< vultraz_iOS> celticminstrel: "bad argument #2 to add (string expected got nil)
20170228 23:33:59< celticminstrel> I thought it was -2
20170228 23:35:33< vultraz_iOS>  Oh, right
20170228 23:35:37< vultraz_iOS> #-2
20170228 23:37:17< celticminstrel> So I'm getting a startup crash (null-pointer access) while reading animation definitions, so I can't even get in to reproduce it. I don't see anything in add that expects a string from -2, either.
20170228 23:38:24< matthiaskrgr> heh
20170228 23:39:04< celticminstrel> It only calls checkstring for indices 3 and 4 and tostring for index -1.
20170228 23:39:52< celticminstrel> I'm assuming a C++ stack trace isn't readily available for your issue?
20170228 23:40:51< matthiaskrgr> there was a weird crash previously
20170228 23:40:56< matthiaskrgr> but it turned into a lua error later
20170228 23:41:16< matthiaskrgr> see the log attached to Brave move to walk directly behind the bull..
20170228 23:41:18< matthiaskrgr> egh
20170228 23:41:22< matthiaskrgr> wtf
20170228 23:41:26< matthiaskrgr> https://gna.org/bugs/index.php?25541 
20170228 23:43:01-!- Bonobo [~Bonobo@2001:44b8:254:3200:dcaa:97a8:a4bf:3e5a] has quit [Ping timeout: 246 seconds]
20170228 23:43:55< vultraz_iOS> It's a lua error not a crash
20170228 23:43:59< vultraz_iOS> The crash was fixed
20170228 23:44:08< vultraz_iOS> Every time you fix an issue a new one pops up
20170228 23:44:13< matthiaskrgr> :/ 
20170228 23:44:38< matthiaskrgr> vultraz_iOS: so the crash and the lua error are differnt thigns?
20170228 23:44:53< matthiaskrgr> I assumed they were related since they kind of appeared at the same spot
20170228 23:44:55< matthiaskrgr> at least to my eyes
20170228 23:45:09< vultraz_iOS> There have been like 5 errors or crashes related to animate unit
20170228 23:45:13< celticminstrel> Well, though this is an error related to Lua, the fact that it's referring to argument -2 means it's a problem in the C++.
20170228 23:46:47< celticminstrel> ...though I guess I should double-check the Lua anyway, just in case.
20170228 23:47:15< vultraz_iOS> Hm
20170228 23:47:26< vultraz_iOS> There's an access of -2 when setting up color..
20170228 23:48:32< celticminstrel> Right, but it's expecting a number, not a string.
20170228 23:51:22< irker675> wesnoth: Celtic Minstrel wesnoth:master 9d6b0b2213ee / src/scripting/game_lua_kernel.cpp: Fix another index typo in [animate_unit] https://github.com/wesnoth/wesnoth/commit/9d6b0b2213ee1b3eb741fd24b72ecb5cff291bc0
20170228 23:51:32< celticminstrel> No idea if that's related, just happened to notice it.
20170228 23:53:28< vultraz_iOS> celticminstrel: bad argument #1 to ipairs (table expected, got strong)
20170228 23:54:03< vultraz_iOS> animate_unit.lua:105
20170228 23:54:33< vultraz_iOS> Ah, simple fix
20170228 23:55:09< vultraz_iOS> (cfg, "animate")
20170228 23:55:55< irker675> wesnoth: Celtic Minstrel wesnoth:master e107c52df487 / data/lua/wml/animate_unit.lua: Fix improper child_range call in [animate_unit] https://github.com/wesnoth/wesnoth/commit/e107c52df487bd5c0fcc44f8679975ba1f6db364
20170228 23:56:18< matthiaskrgr> woot
20170228 23:56:25< matthiaskrgr> I got a bit farther now!!
20170228 23:57:05< vultraz_iOS> celticminstrel: the quintain is now successfully created in the tutorial :D
20170228 23:57:24< matthiaskrgr> grnf
20170228 23:57:32< matthiaskrgr> sometimes when I click units they are not selected
20170228 23:58:29< vultraz_iOS> celticminstrel: if I quit the tutorial after the quintain is summoned, though, wesnoth crashes
20170228 23:58:52< matthiaskrgr> yes
20170228 23:59:30-!- RatArmy_ [~ratarmy@om126204192010.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170228 23:59:47< vultraz_iOS> I haz stacktrace
--- Log closed Wed Mar 01 00:00:00 2017