--- Log opened Thu Mar 02 00:00:53 2017 20170302 00:18:20-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev 20170302 00:18:20-!- Topic for #wesnoth-dev: 1.13.7 scheduled for Sunday, March 12th 00:00 UTC | Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org 20170302 00:18:20-!- Topic set by vultraz_iOS [uid24821@wesnoth/developer/vultraz] [Sun Feb 26 23:22:07 2017] 20170302 00:18:20[Users #wesnoth-dev] 20170302 00:18:20[ abruanese ] [ crimson_penguin] [ higgins ] [ madmax28 ] [ RatArmy_] [ tomreyn ] 20170302 00:18:20[ aeth ] [ DDR ] [ Ivanovic ] [ matthiaskrgr] [ Ravana_ ] [ vincent_c] 20170302 00:18:20[ AI0867 ] [ DeFender ] [ iwaim ] [ midzer ] [ Rhonda ] [ wedge009 ] 20170302 00:18:20[ aidanhs ] [ elias ] [ janebot ] [ minzbonbon ] [ SigurdFD] [ yaiyan ] 20170302 00:18:20[ APic ] [ EliDupree2 ] [ Jetrel_ ] [ new_one ] [ Sirp ] [ zookeeper] 20170302 00:18:20[ atarocch ] [ Elsi ] [ Jetrel_bot ] [ nore ] [ Soliton ] 20170302 00:18:20[ Bonobo ] [ Elvish_Hunter ] [ kidneb ] [ nurupo ] [ TC01 ] 20170302 00:18:20[ bumbadadabum ] [ esr ] [ knotwork_ ] [ oldlaptop ] [ TC02 ] 20170302 00:18:20[ celticminstrel] [ Gambit ] [ lobby ] [ Polsaker ] [ TheJJ ] 20170302 00:18:20[ clavi ] [ heirecka ] [ loonycyborg] [ pydsigner ] [ timotei ] 20170302 00:18:20-!- Irssi: #wesnoth-dev: Total of 55 nicks [0 ops, 0 halfops, 0 voices, 55 normal] 20170302 00:18:24-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009 20170302 00:19:18-!- Irssi: Join to #wesnoth-dev was synced in 68 secs 20170302 00:24:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 00:36:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170302 00:37:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 00:37:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit] 20170302 00:45:59-!- irker867 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170302 00:45:59< irker867> wesnoth: Charles Dang wesnoth:master 42f087abb3f3 / src/units/ (animation.cpp drawer.cpp frame.cpp frame.hpp): Extensive cleanup of unit animation frame code https://github.com/wesnoth/wesnoth/commit/42f087abb3f36903c1ac1d3ac1ed6431bd6c1307 20170302 00:47:19-!- Appleman1234 [~Appleman1@pl109.nas82m.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev 20170302 00:56:29-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20170302 00:56:31-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 00:59:15< vultraz_iOS> celticminstrel: do note i also assigned https://gna.org/bugs/index.php?25550 to you 20170302 00:59:20< vultraz_iOS> (more animate unit problems) 20170302 00:59:26< vultraz_iOS> also, there's yet another problem 20170302 00:59:50< vultraz_iOS> i noticed in the tutorial that after summoning the quintain, delf's ellipse/crown/bars aren't restored 20170302 00:59:56< vultraz_iOS> set_standing probably isn't getting called 20170302 01:09:54-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 01:15:22-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds] 20170302 01:35:45< celticminstrel> It's getting called. 20170302 01:35:59< vultraz_iOS> maybe the argument is wrong? 20170302 01:36:01< celticminstrel> Given that I never made it not get called. 20170302 01:36:04< celticminstrel> I dunno. 20170302 01:36:11< celticminstrel> There's no way the display would be null, right? 20170302 01:38:46< vultraz_iOS> no 20170302 01:39:03< vultraz_iOS> if it were the game would have crashed at that point before the null check was added 20170302 01:43:52< vultraz_iOS> adding with_bars (value doesn't matter) doesn't help 20170302 01:44:03< vultraz_iOS> and the bars are restored later after delf moves 20170302 02:10:37-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 02:25:07-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 02:44:26< celticminstrel> I dunno why it'd be doing that then... 20170302 02:44:38< celticminstrel> And I won't be able to fix it well unless I can get past the crash at startup. 20170302 02:49:24-!- Bonobo [~Bonobo@2001:44b8:254:3200:916a:b971:fd79:4d40] has quit [Ping timeout: 256 seconds] 20170302 02:51:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds] 20170302 02:56:22-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 02:56:57-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 03:10:23-!- travis-ci [~travis-ci@ec2-107-21-159-230.compute-1.amazonaws.com] has joined #wesnoth-dev 20170302 03:10:24< travis-ci> wesnoth/wesnoth#12814 (master - 42f087a : Charles Dang): The build is still failing. 20170302 03:10:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206827014 20170302 03:10:24-!- travis-ci [~travis-ci@ec2-107-21-159-230.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170302 03:13:36-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 03:24:10-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 03:33:46-!- Bonobo [~Bonobo@129.127.113.157] has joined #wesnoth-dev 20170302 03:46:21-!- irker867 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170302 03:51:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170302 03:54:04-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev 20170302 03:55:42-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Quit: Reconnecting] 20170302 04:06:06-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20170302 04:19:05-!- Bonobo [~Bonobo@129.127.113.157] has quit [Ping timeout: 240 seconds] 20170302 04:39:39< vultraz_iOS> hm 20170302 04:39:44< vultraz_iOS> what was your crash again? 20170302 04:41:53< celticminstrel> Something in progressive string parsing. 20170302 04:41:53-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 04:42:07< celticminstrel> I don't remember exactly. 20170302 04:42:07-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 04:44:11-!- RatArmy_ [~ratarmy@om126212080040.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 04:44:58-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds] 20170302 04:50:03< pydsigner> vultraz_iOS: have we considered putting 1.13.x releases on steam as an early access practice? 20170302 04:50:16< vultraz_iOS> yes 20170302 04:50:31< vultraz_iOS> it has been discussed 20170302 04:51:12-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20170302 04:53:29-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev 20170302 04:54:08< vultraz_iOS> dave thinks it's not really appropriate for wesnoth 20170302 04:54:10< vultraz_iOS> ill have to see 20170302 04:56:13< vultraz_iOS> depends on how long we'll be working on 1.13 for 20170302 04:56:22< vultraz_iOS> i also need to work on all the steam metadata 20170302 04:56:26< vultraz_iOS> for the store page 20170302 05:01:44< vultraz_iOS> so much stuff to do :( 20170302 05:02:03< vultraz_iOS> I'm looking for someone to work on the bug tracker transition 20170302 05:09:36-!- Bonobo [~Bonobo@129.127.113.157] has joined #wesnoth-dev 20170302 05:14:50< wedge009> vultraz_iOS: Where is it moving to? 20170302 05:17:18-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170302 05:18:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20170302 05:18:57-!- wedge010 is now known as wedge009 20170302 05:21:36-!- Bonobo [~Bonobo@129.127.113.157] has quit [Ping timeout: 258 seconds] 20170302 05:25:37< vultraz_iOS> github 20170302 05:32:16< celticminstrel> So you're basically ignoring the whole issue and just taking the easiest option?+ 20170302 05:33:11< celticminstrel> Not that I personally have any issues with the github issue tracker, but I've heard some reasonable objections. 20170302 05:33:22-!- celticminstrel is now known as celmin|sleep 20170302 05:34:26-!- JyrkiVesterinen [~JyrkiVest@87-100-231-252.bb.dnainternet.fi] has joined #wesnoth-dev 20170302 05:34:39< vultraz_iOS> it needs to be moved 20170302 05:39:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection] 20170302 05:40:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170302 05:56:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20170302 06:14:34-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds] 20170302 06:43:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20170302 07:03:45-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [] 20170302 07:20:38-!- Elsi [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 256 seconds] 20170302 07:25:54-!- Appleman1234 [~Appleman1@pl109.nas82m.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds] 20170302 07:48:39-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 260 seconds] 20170302 07:51:56-!- Appleman1234 [~Appleman1@pl2414.nas82m.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev 20170302 07:52:45-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev 20170302 07:55:39-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev 20170302 07:56:04-!- Appleman1234 [~Appleman1@pl2414.nas82m.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 246 seconds] 20170302 08:10:34-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 264 seconds] 20170302 08:15:02-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev 20170302 08:19:34-!- madmax28 [~madmax28@xdsl-78-35-253-234.netcologne.de] has quit [Ping timeout: 264 seconds] 20170302 08:20:27-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds] 20170302 08:21:04-!- madmax28 [~madmax28@xdsl-87-78-205-6.netcologne.de] has joined #wesnoth-dev 20170302 08:31:13-!- Bonobo [~Bonobo@2001:44b8:254:3200:a4e4:15d:3b69:58a7] has joined #wesnoth-dev 20170302 08:33:53-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev 20170302 08:33:53-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host] 20170302 08:33:53-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev 20170302 08:51:33-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has joined #wesnoth-dev 20170302 09:16:36-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 09:19:14-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me] 20170302 09:19:54-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20170302 09:47:09-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has joined #wesnoth-dev 20170302 10:02:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 10:07:08-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20170302 10:14:38-!- Kwandulin [~Miranda@p200300760F7B96506D44E17B48CD10AD.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170302 10:17:05-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev 20170302 10:59:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170302 10:59:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170302 11:16:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 11:16:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20170302 11:24:27-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has quit [Ping timeout: 240 seconds] 20170302 11:28:22-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has joined #wesnoth-dev 20170302 11:31:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 11:31:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20170302 11:32:48< Soliton> http://www.mirbsd.org/permalinks/wlog-10_e20170301-tg.htm#e20170301-tg_wlog-10 20170302 11:45:44< vultraz_iOS> reading 20170302 11:45:54< vultraz_iOS> this doesn't seem to line up with what the actual new ToS say 20170302 11:58:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170302 12:10:23-!- Bonobo [~Bonobo@2001:44b8:254:3200:a4e4:15d:3b69:58a7] has quit [Quit: Leaving] 20170302 12:30:33-!- irker664 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170302 12:30:33< irker664> wesnoth: Charles Dang wesnoth:master 7d5acc92ce74 / / (4 files in 2 dirs): Refactor handling of unit animation progressive_* helper classes https://github.com/wesnoth/wesnoth/commit/7d5acc92ce743392f94bd90b85168bff08c84c7d 20170302 12:35:32-!- Kwandulin [~Miranda@p200300760F7B96506D44E17B48CD10AD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170302 12:38:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 13:03:33< Soliton> which part can you not find in the ToS? 20170302 13:08:19-!- Appleman1234 [~Appleman1@pl2434.nas824.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev 20170302 13:09:17< vultraz_iOS> eh, on second thought perhaps it is there 20170302 13:09:43< vultraz_iOS> i just don't fully understand how this causes conflicts with CC licenses, etc 20170302 13:10:46< vultraz_iOS> if it's really incompatible with CC, then that slams the brakes on our relicensing efforts 20170302 13:11:13< Soliton> you grant everyone full rights which is not compatible with the GPL since that adds restrictions. 20170302 13:11:30< Soliton> the cc part is not even the big issue. 20170302 13:11:52< vultraz_iOS> how does "full rights" = "restrictions" 20170302 13:12:08< Soliton> it does not. that's the point. 20170302 13:12:46< vultraz_iOS> ok, there's something that confuses me here 20170302 13:12:59< Soliton> the fun part is also that it is effective already. 20170302 13:13:22< vultraz_iOS> why would github, a home for software, add licensing that makes it impossible for many software projects to exist on itself :| 20170302 13:13:26< Soliton> so you can get wesnoth from github now and don't need to care for the GPL. 20170302 13:13:47< Soliton> well, we can hope they'll fix it soon... 20170302 13:14:03< Soliton> but people already started deleting stuff from github. 20170302 13:14:19< vultraz_iOS> well it's not like we can just pull the plug here 20170302 13:14:48< vultraz_iOS> so what in hell do you propose :s 20170302 13:14:49-!- RatArmy_ [~ratarmy@om126237112064.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 13:15:00< vultraz_iOS> because this sounds like it could be a mess 20170302 13:15:14< Soliton> what to do is a good question, yes... 20170302 13:16:02< Soliton> hosting git somewhere else is probably not a big deal but github has some nice features. 20170302 13:16:21< vultraz_iOS> well, first things first... pydsigner: don't do anything else with the CC effort for now :| 20170302 13:16:47< Soliton> i'd try to figure out what github's plan is maybe they've posted about it somewhere. 20170302 13:19:25-!- Kwandulin [~Miranda@p200300760F7B9650AD5FF48E3F5AB4FC.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170302 13:20:44< vultraz_iOS> i guess for now we continue as usual 20170302 13:24:06< Soliton> looks like it is perhaps not as bad as the article suggests: https://news.ycombinator.com/item?id=13766933 20170302 13:36:58-!- travis-ci [~travis-ci@ec2-54-234-239-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20170302 13:36:59< travis-ci> wesnoth/wesnoth#12815 (master - 7d5acc9 : Charles Dang): The build is still failing. 20170302 13:36:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/206978511 20170302 13:36:59-!- travis-ci [~travis-ci@ec2-54-234-239-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170302 14:12:07< vultraz_iOS> "It does not. The Github license requires a waiver of the requirement of attribution insofar as such waiver is needed for Github to do what it already does e.g. as the license indicates, provide search results without attribution. 20170302 14:12:07< vultraz_iOS> Further, only Github has been given this waiver. Anyone else is still held to any requirement of attribution." 20170302 14:12:14< vultraz_iOS> that's actually something close to what i was thinking 20170302 14:12:27< vultraz_iOS> the interpretation seemed off given the wording of the TOS 20170302 14:13:34< celmin|sleep> If you're worried you could probably temporarily use wesnoth.org as the central repo until github sorts things out. 20170302 14:25:30< celmin|sleep> I mean, it'd take a little setup, but it could be done. 20170302 14:26:47-!- celmin|sleep is now known as celticminstrel 20170302 14:41:35-!- Appleman1234 [~Appleman1@pl2434.nas824.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds] 20170302 15:17:29< vultraz_iOS> huh 20170302 15:17:42< vultraz_iOS> so the VS Code C++ extension has a ClangFormat button 20170302 15:17:49< vultraz_iOS> to apply formatting 20170302 15:18:09< vultraz_iOS> sadly most of the formatting sucks 20170302 15:20:16< celticminstrel> Well, clang format is highly configurable though. 20170302 15:23:17-!- Appleman1234 [~Appleman1@pl123.nas82f.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev 20170302 15:27:54< vultraz_iOS> another huh! 20170302 15:28:28< celticminstrel> I mean, I'm not recommending using it, but... 20170302 15:28:40< celticminstrel> (Mind you, I'm also not recommending not using it.) 20170302 15:28:59< vultraz_iOS> it seems my change to allow labels to shrink has allowed MP Create to exist without scrollbars at screenshot resolution (1280x768) 20170302 15:29:07< celticminstrel> It probably has enough options to get exactly the format you want. 20170302 15:29:13< celticminstrel> Yay. 20170302 15:29:15< vultraz_iOS> since the "players" label by its filter slider shrinks 20170302 15:29:27< vultraz_iOS> so it says "Pla..." 20170302 15:30:03< vultraz_iOS> "name" and "password" also shrink 20170302 15:30:43-!- irker664 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170302 15:30:53< vultraz_iOS> "name of game", that is 20170302 15:31:04< celticminstrel> From the sounds of it, I think the new GitHub ToS would mean you can't put up any new existing open-source works (unless you're the sole author) and be problematic for manual merging of other people's work, but won't cause problems if you're just committing to the repo. 20170302 15:31:09< celticminstrel> ^might be problematic 20170302 15:31:18< celticminstrel> That's without me actually reading them, just based on the two articles. 20170302 15:31:52< celticminstrel> ^to an existing repo 20170302 15:32:10< celticminstrel> I mean, I'm not a lawyer, so I could be very wrong. 20170302 15:32:42< vultraz_iOS> I've notified the rest of the board 20170302 15:32:46< vultraz_iOS> waiting to see what they say 20170302 15:33:13< celticminstrel> The actual problem with the waiver thing seems to be that you don't have the right to grant that for someone else's code. 20170302 15:47:45-!- JyrkiVesterinen [~JyrkiVest@87-100-231-252.bb.dnainternet.fi] has quit [Quit: .] 20170302 15:50:22-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 15:51:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds] 20170302 15:54:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20170302 15:55:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20170302 16:06:12-!- Appleman1234 [~Appleman1@pl123.nas82f.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds] 20170302 16:08:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 16:09:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20170302 16:31:00-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170302 16:32:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds] 20170302 16:32:49-!- wedge010 is now known as wedge009 20170302 16:39:25 * pydsigner scrolls up 20170302 16:43:21< pydsigner> Yeah see I, like the HN lawyers, would strongly disagree with mirbsd's interpretations 20170302 16:43:54< pydsigner> I read the new TOS when it was opened to feedback 20170302 16:44:48< pydsigner> And IIRC all they were doing was requiring sufficient rights to be granted for the site to operate. 20170302 16:45:23-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev 20170302 16:46:33< pydsigner> Those rights were really already granted by FOSS licenses; I think it was more to cover their bases with non-foss licensed stuff, particularly things in private or unlicensed repos 20170302 16:48:38< pydsigner> He seems to recognize that anyways 20170302 16:49:26< pydsigner> But IDK what he's on about "separate explicit grants" 20170302 16:51:04< pydsigner> In conclusion, carry on, he's just calling wolf without cause (is he even a lawyer?) 20170302 16:53:06-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170302 16:53:06< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release Charles Dang 7d5acc9: Refactor handling of unit animation progressive_* helper classes Failed 20170302 16:53:06< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-264 20170302 16:53:10-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170302 17:01:36< DeFender> I would also point out that something as ubiquitous as well-known as github would not update their TOS in a manner that would make large swaths of what people use it for (and what they WANT people to be using it for) illegal. As such, there is NO WAY IN HELL that this interpretation is the intent of the TOS. 20170302 17:02:02< DeFender> Their intent clearly is not something that would undermine their mission. 20170302 17:02:13< DeFender> This is fearmongering. Nothing more. 20170302 17:02:34< celticminstrel> Ugh, fearmongering. There's been mountains of that lately. 20170302 17:08:17< DeFender> Indeed. 20170302 17:08:22< vultraz_iOS> Blame Trump 20170302 17:08:48-!- Kwandulin [~Miranda@p200300760F7B9650AD5FF48E3F5AB4FC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170302 17:10:55< DeFender> vultraz_iOS, ¯\_(ツ)_/¯ Healthcare, amiright? 20170302 17:12:32< vultraz_iOS> indeed 20170302 17:13:17-!- JyrkiVesterinen [~JyrkiVest@87-100-231-252.bb.dnainternet.fi] has joined #wesnoth-dev 20170302 17:14:07< pydsigner> Sigh 20170302 17:16:24< pydsigner> Other people pointed out that GitHub was already doing those things, so if it isn't legal now it wasn't legal before 20170302 17:19:14-!- irker181 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170302 17:19:14< irker181> wesnoth: Jyrki Vesterinen wesnoth:master 8f39aa92dc7d / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/8f39aa92dc7d23344c8631e80efde411b901c216 20170302 17:20:45< Soliton> so they changed their ToS just for the fun of it? that's some weird logic. 20170302 17:21:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170302 17:22:10< vultraz_iOS> why is test_modify_ai_change_default_facet failing... 20170302 17:24:39< JyrkiVesterinen> I'm debugging it. 20170302 17:25:04< vultraz_iOS> interestingly enough, that's the test celticminstrel modified in 4e7a2072f09f4f87f53f9d86461403fee07547e8 20170302 17:25:33< vultraz_iOS> related, maybe? 20170302 17:25:38< JyrkiVesterinen> It was failing before that commit as well. 20170302 17:25:48< vultraz_iOS> ah 20170302 17:25:59< JyrkiVesterinen> Before 4e7a2072, the [modify_ai] caused a Lua error. 20170302 17:26:37< JyrkiVesterinen> What happens now is that the aspect value doesn't match the expected value. 20170302 17:27:03< JyrkiVesterinen> It's supposed to be 8 after the [modify_ai], but for some reason it remains 7 instead. 20170302 17:27:47< vultraz_iOS> fun! 20170302 17:28:32< celticminstrel> That commit was supposed to fix it. 20170302 17:28:43< celticminstrel> But I guess it didn't. 20170302 17:29:03< vultraz_iOS> well it sounds like it changed at least 20170302 17:29:04< celticminstrel> vultraz_iOS: Not just Trump, but he's a huge factor in it, yes. 20170302 17:29:08< celticminstrel> Along with Brexit. 20170302 17:29:14< celticminstrel> And Marine le Pen. 20170302 17:29:29< celticminstrel> And a few others. 20170302 17:29:33< vultraz_iOS> Trump and the GOP* 20170302 17:29:52< celticminstrel> It's not just the US, is my point. It's all through Europe too, and Canada. 20170302 17:30:05< vultraz_iOS> true, true 20170302 17:30:12< vultraz_iOS> global nationalism is on the rise 20170302 17:31:39< celticminstrel> Okay, so.. 20170302 17:32:05< celticminstrel> The default attack_depth is initially 5, and there's an aspect that sets it to 7 on turns 5-8. 20170302 17:32:17< celticminstrel> Hmm... 20170302 17:32:36< celticminstrel> So it should indeed be 5 on turns 1-4... 20170302 17:33:36< JyrkiVesterinen> The failures happen in turns 7 and 8. Expected attack_depth is 8, actual depth is 7. 20170302 17:33:50< celticminstrel> Right, and I'm now wondering why it's expecting 8... 20170302 17:34:24< JyrkiVesterinen> Because of the [modify_ai] at the end of turn 6. 20170302 17:34:29< celticminstrel> Right.3 20170302 17:34:43< celticminstrel> But that changes the default aspect, which should only take effect if no other aspect takes priority. 20170302 17:34:59< celticminstrel> But the other aspect, with a value of 7, is still in effect until the end of turn 8. 20170302 17:35:32< JyrkiVesterinen> Hmm. The test previously used a wildcard, and assume that it means "all aspects". 20170302 17:36:04< celticminstrel> Yeah, at one point I think I made the wildcard mean "default aspect" in some contexts, but IIRC I changed that because it was confusing. 20170302 17:36:23< JyrkiVesterinen> So, would the fix be that the test should expect attack_depth of 7 in turns 7 and 8? 20170302 17:36:46< celticminstrel> Then recently, when the wildcard stopped working, I changed it to default_facet because the test name implied that that was what it was supposed to be testing. 20170302 17:37:05< celticminstrel> Yeah, I think changing the expectation is the correct fix here. 20170302 17:38:05< celticminstrel> Given that wildcard seems like it worked before I merged wml_tag_porting, I could also consider removing the error in [modify_ai] when you try to use one... I dunno... 20170302 17:38:16< celticminstrel> But that's a separate issue. 20170302 17:38:33< celticminstrel> The test's name implies it's supposed to test changing the default facet, not changing all facets at once. 20170302 17:38:52< celticminstrel> (And frankly, changing all facets at once doesn't seem terribly useful, though I suppose that's not necessarily a reason to disallow it.) 20170302 17:39:08< celticminstrel> (Maybe mattsc can comment on this at some point.) 20170302 17:40:10< celticminstrel> Should I make the change or you? 20170302 17:40:31< JyrkiVesterinen> I have already made it locally. I'll commit it. 20170302 17:40:35< celticminstrel> 'kay 20170302 17:40:40< celticminstrel> Thanks. 20170302 17:45:20< irker181> wesnoth: Jyrki Vesterinen wesnoth:master 0fe2fd4c00d9 / data/test/scenarios/ai/modify/aspects.cfg: Fix the modify_ai_change_default_facet unit test https://github.com/wesnoth/wesnoth/commit/0fe2fd4c00d97ba84547dae40466b3a6deb0b8b8 20170302 17:50:40< vultraz_iOS> heh 20170302 17:50:47< vultraz_iOS> that's basically a reversion of 106f1510d3993 from last march 20170302 17:51:14< celticminstrel> Oh huh. 20170302 17:51:21< celticminstrel> I guess my fix back then was actually wrong then. 20170302 17:51:32< celticminstrel> I should've changed it to default_facet then, instead of altering the numbers. 20170302 17:51:37< celticminstrel> Oh well! 20170302 17:56:42-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev 20170302 17:59:36< pydsigner> Soliton: no they changed it to make it explicit so they couldn't be sued for hosting people's code 20170302 18:04:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev 20170302 18:04:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 7d5acc9: Refactor handling of unit animation progressive_* helper classes Failed 20170302 18:04:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-261 20170302 18:04:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev [] 20170302 19:24:20-!- travis-ci [~travis-ci@ec2-54-163-44-161.compute-1.amazonaws.com] has joined #wesnoth-dev 20170302 19:24:21< travis-ci> wesnoth/wesnoth#12816 (master - 8f39aa9 : Jyrki Vesterinen): The build is still failing. 20170302 19:24:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/207075224 20170302 19:24:21-!- travis-ci [~travis-ci@ec2-54-163-44-161.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170302 19:26:30-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 19:31:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170302 19:33:05< celticminstrel> :( 20170302 19:33:34< celticminstrel> Oh. 20170302 19:33:38< celticminstrel> That's not the fix commit. 20170302 19:44:33-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 19:47:08-!- mjs-de [~mjs-de@x4e30c12d.dyn.telefonica.de] has joined #wesnoth-dev 20170302 19:52:13-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 20:01:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20170302 20:05:44-!- JyrkiVesterinen [~JyrkiVest@87-100-231-252.bb.dnainternet.fi] has quit [Quit: .] 20170302 20:17:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20170302 20:46:03-!- travis-ci [~travis-ci@ec2-54-234-239-135.compute-1.amazonaws.com] has joined #wesnoth-dev 20170302 20:46:04< travis-ci> wesnoth/wesnoth#12817 (master - 0fe2fd4 : Jyrki Vesterinen): The build was fixed. 20170302 20:46:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/207083174 20170302 20:46:04-!- travis-ci [~travis-ci@ec2-54-234-239-135.compute-1.amazonaws.com] has left #wesnoth-dev [] 20170302 20:48:01< celticminstrel> \o/ 20170302 20:51:35-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 20:54:05-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 21:23:05-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 21:26:04-!- mjs-de [~mjs-de@x4e30c12d.dyn.telefonica.de] has quit [Ping timeout: 258 seconds] 20170302 21:30:05-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 21:45:09-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 21:48:52-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 22:00:58-!- atarocch [~atarocch@93.56.160.30] has quit [Ping timeout: 264 seconds] 20170302 22:16:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV] 20170302 22:16:04-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 22:16:22-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 22:34:25-!- gfgtdf [~chatzilla@x4e369052.dyn.telefonica.de] has joined #wesnoth-dev 20170302 22:37:12< gfgtdf> when i try to upload an addon it tell me something about invalid icon, is this a bug? i had to use wesnot 1.12 to update my addon 20170302 22:37:51< DeFender> is your icon valid? 20170302 22:38:18< gfgtdf> i did not use any icon. 20170302 22:43:36-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev 20170302 22:48:19< celticminstrel> Maybe an icon is required? 20170302 22:50:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20170302 22:50:40< gfgtdf> hmm it wasn't in 1.12 and the wiki isn't really clear on this. 20170302 22:57:34-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer] 20170302 22:58:14-!- irker181 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170302 23:34:48< zookeeper> an icon shouldn't of course be mandatory. 20170302 23:36:30-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev 20170302 23:41:07-!- irker327 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170302 23:41:07< irker327> wesnoth: sigurdfdragon wesnoth:master 9a6663f3ec5d / data/multiplayer/scenarios/2p_Aethermaw.cfg: MP Aethermaw: Move message info into objectives notes https://github.com/wesnoth/wesnoth/commit/9a6663f3ec5d0caa0a7ad031ba03c4591bfe5c86 20170302 23:45:17< DeFender> "shouldn't of course" is an interesting construct grammatically. 20170302 23:47:20< zookeeper> one of the perks of being a non-native speaker 20170302 23:48:00< zookeeper> you get to use "interesting" grammatical constructs without anyone being allowed to think (much) less of you for it 20170302 23:52:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170302 23:52:56< irker327> wesnoth: Charles Dang wesnoth:master b1ea099da4d6 / src/units/frame.cpp: Small fixup to 42f087abb https://github.com/wesnoth/wesnoth/commit/b1ea099da4d6731f61a70578605b69bed896a04e 20170302 23:52:58-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20170302 23:53:41< vultraz_iOS> yay for celticminstrel making me realizing i made a mistake 20170302 23:56:43< zookeeper> oh good timing. we were just discussing something... :> 20170302 23:58:19< vultraz_iOS> oh? 20170302 23:58:23< vultraz_iOS> tell me more --- Log closed Fri Mar 03 00:00:08 2017