--- Log opened Fri Mar 03 00:00:08 2017
20170303 00:00:48-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170303 00:01:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170303 00:02:24< gfgtdf> vultraz_iOS: about the addon manager (unrelated to gui2 transition) 1.13 seems to make an icon= mandatory, unlike 1.12
20170303 00:02:42< vultraz_iOS> yes
20170303 00:03:45< vultraz_iOS> is that a problem?
20170303 00:05:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170303 00:09:13< gfgtdf> half (2 of 5) of my addons didn't have an icon in so i i gave me an erro when i tried tpo update them.
20170303 00:11:38< vultraz_iOS> saying the image could not be found?
20170303 00:12:14< DeFender> vultraz_iOS, why should an icon be mandatory?
20170303 00:13:04< vultraz_iOS> well, it sounds like it was an unintended side effect of adding a validation check so people get their icon paths correct when uploading addons
20170303 00:13:21< vultraz_iOS> I'm tried of there always being that one Water Era or something with a broken path
20170303 00:13:49< vultraz_iOS> but as to why they should or should not be mandatory, I think it provides a more consistent user experience
20170303 00:14:28< DeFender> meh.
20170303 00:14:57< gfgtdf> vultraz_iOS: i actuall wonder whetehr that checks even works correctly? Afaik image::exists only accepts images in addons which iirc is a common mistake to do in addons.
20170303 00:15:03< DeFender> not every add-on makes sense to include an icon
20170303 00:16:43< vultraz_iOS> @gfgtdf oh?
20170303 00:17:03< gfgtdf> s/only/also
20170303 00:26:54< celticminstrel> vultraz_iOS: If all you want is a consistent experience, make the game use a default icon if one isn't specifically set?
20170303 00:27:28< vultraz_iOS> perhaps, perhaps
20170303 00:27:47< celticminstrel> If you want to get fancy you could even base it on the addon's category.
20170303 00:27:58< celticminstrel> Though that might be a bit of a waste if most addons have an icon anyway..
20170303 00:33:47< DeFender> i'd be in favor of a category-based default
20170303 00:34:45< vultraz_iOS> too much work 
20170303 00:34:46< vultraz_iOS> :(
20170303 00:35:14< vultraz_iOS> especially right now that i don't have a functional image editor since the GIMP is garbage
20170303 00:35:21< vultraz_iOS> on a high-dpi screen
20170303 00:36:02< celticminstrel> The GIMP is a little better than garbage, in that it does actually work... usually.
20170303 00:40:01< DeFender> I use krita.
20170303 00:40:17< DeFender> Also, you can use existing icons as the defaults, no?
20170303 00:40:31< celticminstrel> Possibly.
20170303 00:41:23< celticminstrel> Those icons used for your own addons in the old addon manager seem like a good choice (without the +/-), maybe with something superimposed based on the category (which could be done with IPFs).
20170303 00:41:27< vultraz_iOS> gimp is unusable at 4k
20170303 00:41:50< celticminstrel> GIMP devs don't seem to have anyone who understands UI/UX.
20170303 00:41:51-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 00:43:40-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev
20170303 00:46:36-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 00:48:01-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 00:51:04-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170303 00:51:11-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev
20170303 00:53:41-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 00:53:57-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has joined #wesnoth-dev
20170303 00:58:40-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170303 00:58:46-!- RatArmy_ [~ratarmy@om126212084121.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 00:59:28-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 01:01:01-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170303 01:07:32-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20170303 01:21:04-!- Appleman1234 [~Appleman1@pl2006.nas82q.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 01:41:35-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Ping timeout: 252 seconds]
20170303 01:51:23-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170303 02:07:21-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 02:10:09-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 02:10:29-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 02:16:39-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 02:16:56-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 02:18:54-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170303 02:26:56< vultraz_iOS> celticminstrel: still getting that startup crash?
20170303 02:27:34< celticminstrel> I haven't checked since then.
20170303 02:31:35-!- gfgtdf_ [~chatzilla@x4e369d5b.dyn.telefonica.de] has joined #wesnoth-dev
20170303 02:33:37-!- gfgtdf [~chatzilla@x4e369052.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170303 02:33:45-!- gfgtdf_ is now known as gfgtdf
20170303 02:35:16-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20170303 02:35:36-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170303 02:37:18< vultraz_iOS> could you
20170303 02:37:31< celticminstrel> I started building pretty much right after saying that.
20170303 02:37:53< celticminstrel> Still getting it. It's lexical_cast called by progressive_int.
20170303 02:38:01-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 02:38:11< celticminstrel> Oh sorry, progressive_pair<int>
20170303 02:38:48< celticminstrel> It's a null pointer access, which is weird because I don't see how there's a null pointer there anywhere.
20170303 02:38:49-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 02:39:10-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 02:39:26< vultraz_iOS> whut
20170303 02:39:59< celticminstrel> Well, there is a boost::none... I don't think that's quite a null pointer though...
20170303 02:40:19< vultraz_iOS> where?
20170303 02:41:29< vultraz_iOS> this doesn't make sense :/
20170303 02:42:21< vultraz_iOS> where in this code is it accessing a null pointer
20170303 02:42:26< celticminstrel> http://pastebin.com/raw/2nd7vkUs
20170303 02:42:30< celticminstrel> No idea!
20170303 02:42:55< celticminstrel> I briefly considered it might be inlining the implementation, but give it's a debug build, that's probably unlikely.
20170303 02:43:09< vultraz_iOS> inlining the implementations?
20170303 02:43:14< celticminstrel> I suppose I could try a completely clean build, though I feel like I might've done that already.
20170303 02:43:16-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170303 02:43:37< vultraz_iOS> you are looking at frame_private.hpp right?
20170303 02:43:42< celticminstrel> Basically if it's inlining the implementation it just means the error might be in the function called at that point, rather than at that point directly.
20170303 02:43:42-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 02:43:44< celticminstrel> Uh. No?
20170303 02:43:53< celticminstrel> I was looking at lexical_cast.hpp.
20170303 02:44:03< celticminstrel> See the pastebin.
20170303 02:44:28< celticminstrel> value contains the string "40".
20170303 02:45:22< celticminstrel> My stack trace doesn't include any frame_private.hpp...
20170303 02:45:37< celticminstrel> Oh. Never mind, it does.
20170303 02:45:40< vultraz_iOS> that's where progressive_pair is
20170303 02:45:49-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170303 02:45:57-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 02:45:59< celticminstrel> Right, and the crash occurs in lexical_cast called from there.
20170303 02:47:43< vultraz_iOS> but there're no pointers there
20170303 02:47:44-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 02:47:52< celticminstrel> Yeah.
20170303 02:48:38< celticminstrel> I mean, maybe if lexical_caster::operator() is returning boost::none, that could cause it? Not sure.
20170303 02:48:54< celticminstrel> I'd expect that to be something other than a null pointer access.
20170303 02:49:16< celticminstrel> But it would seem reasonable for it to be one anyway.
20170303 02:51:07< vultraz_iOS> how would i handle that, then?
20170303 02:51:12-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 02:51:43< celticminstrel> Did you write that version of the function?
20170303 02:52:06< celticminstrel> I guess if you want to use boost::none that way you'd assign the result initially to a variable, then do something like:
20170303 02:52:19< celticminstrel> if(result) return result; else throw bad_lexical_cast(...);
20170303 02:53:00< celticminstrel> However, note that if that's really the cause, there's something else wrong.
20170303 02:53:14< vultraz_iOS> which function?
20170303 02:53:16-!- irker327 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170303 02:53:29< celticminstrel> (Line 94 or whatever in lexical_cast.hpp)
20170303 02:53:39< celticminstrel> Because it's trying to lexical_cast a string to an int, right? And it should fail only if the string isn't an integer.
20170303 02:53:47< celticminstrel> But here, the string is "40", so it should succeed and return 40.
20170303 02:54:06< vultraz_iOS> i added the boost::none part, yes
20170303 02:54:52< celticminstrel> Well, that should be fixed, but it's not the actual cause of my issue.
20170303 02:55:05< celticminstrel> Fixing it would effectively silence the problem.
20170303 02:55:20< celticminstrel> Because progressive_pair catches bad_lexical_cast and does nothing whatsoever.
20170303 02:56:23< celticminstrel> Which would mean that it doesn't get set to 40 as it should be, and who knows what that will do later on.
20170303 02:56:49< celticminstrel> So if there are two issues I'd recommend fixing the issue that causes lexical_caster::operator() to erroneously return the default, first.
20170303 02:57:02< celticminstrel> That'll also fix the crash in this case, of course.
20170303 02:59:33-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 02:59:55< vultraz_iOS> fallback is only returned if it's provided
20170303 03:02:36< celticminstrel> What line is this at?
20170303 03:09:22-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 03:11:49-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 03:12:52< vultraz_iOS> 152
20170303 03:14:24< celticminstrel> Hmm, I see.
20170303 03:14:54< celticminstrel> IIRC, bool(stream) is equivalent to stream.good()?
20170303 03:16:40< celticminstrel> Does the standard require streams to have separate get and put pointers?
20170303 03:16:54-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 03:17:13< celticminstrel> Oh, but even if they didn't and it failed because of that, you should get an exception, not a null pointer access...
20170303 03:17:28< celticminstrel> Unless bool(boost::none) doesn't return false, which seems incredibly unlikely.
20170303 03:18:32< celticminstrel> I have no idea what's going on here...
20170303 03:34:18-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170303 03:34:36-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 03:40:06< vultraz_iOS> esp since i don't get this problem :/
20170303 03:42:23< vultraz_iOS> i swear, you always get all the weird bugs
20170303 03:44:46< celticminstrel> More surprising (to me) is that Jyrki and wedge seemingly don't get it.
20170303 03:45:22< celticminstrel> Because at least one of them is presumably using the same compiler as me.
20170303 03:58:34-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 264 seconds]
20170303 04:04:08-!- JyrkiVesterinen [~JyrkiVest@87-100-187-114.bb.dnainternet.fi] has joined #wesnoth-dev
20170303 04:05:30< vultraz_iOS> and why did this come up only now
20170303 04:06:52< celticminstrel> What?
20170303 04:08:07-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170303 04:10:32< vultraz_iOS> why did you never get this crash before
20170303 04:11:27< celticminstrel> I dunno, but there was a long period in which I didn't build at all, I think.
20170303 04:11:32< celticminstrel> Like a month or two.
20170303 04:12:29< celticminstrel> And I'm not quite sure if it's actually the case that I never got it before. I feel like it might've been discussed in here before at some point...? Maybe I'm imagining things though.
20170303 04:13:40< JyrkiVesterinen> I recall discussing the crash with celticminstrel (I'm the author of the current lexical_cast implementation, after all).
20170303 04:14:14< JyrkiVesterinen> I simply don't see any pointers being accessed in the line in question, or the template code it calls.
20170303 04:14:35< celticminstrel> Likewise.
20170303 04:14:56-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 04:15:07< JyrkiVesterinen> I figure that investigating the problem would require seeing the disassembly, and the exact crashing instruction.
20170303 04:17:10-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 04:17:26-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 04:18:39< celticminstrel> http://pastebin.com/VNaed3Gi
20170303 04:19:04< celticminstrel> Seems like it crashes while setting up the call.
20170303 04:19:27< celticminstrel> Not sure how helpful that is.
20170303 04:19:53< celticminstrel> I can give register values too, actually.
20170303 04:20:14< celticminstrel> eax and edx are both 0...
20170303 04:20:27< celticminstrel> I guess that's the problem, but why are they...
20170303 04:21:32< celticminstrel> Maybe I should've pasted the whole function disassembly?
20170303 04:21:59< JyrkiVesterinen> I think the excerpt is enough.
20170303 04:22:00-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 04:22:26-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 04:23:06< JyrkiVesterinen> The code crashes when attempting to *create* empty boost::optional<int>.
20170303 04:23:19 * celticminstrel blink
20170303 04:25:46< JyrkiVesterinen> Here is the definition of boost::none as of Boost 1.60: https://github.com/boostorg/optional/blob/boost-1.60.0/include/boost/none.hpp
20170303 04:26:02< celticminstrel> I might not be using 1.60...
20170303 04:28:14< JyrkiVesterinen> Hmm, it turns out that with the "old definition of none" none_t is an integer pointer.
20170303 04:28:16< JyrkiVesterinen> #ifdef BOOST_OPTIONAL_USE_OLD_DEFINITION_OF_NONE
20170303 04:28:16< JyrkiVesterinen> namespace detail { struct none_helper{}; }
20170303 04:28:16< JyrkiVesterinen> typedef int detail::none_helper::*none_t ;
20170303 04:28:36< JyrkiVesterinen> And, in that case, boost::none is a null pointer.
20170303 04:29:16-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 258 seconds]
20170303 04:29:21< JyrkiVesterinen> Now, of course, boost::optional<int>(boost::none) should not attempt to access a null pointer, but return an empty optional.
20170303 04:32:28< celticminstrel> Hmm, I've found that in my local Boost too (which appears to be 1.58 BTW). MSVC greys it out, indicating that it's inactive.
20170303 04:33:04< vultraz_iOS> ftr im running boost 1.61
20170303 04:35:41< celticminstrel> Oh right, I just remembered that Wesnoth uses a different copy of Boost.
20170303 04:36:19< celticminstrel> Same version though.
20170303 04:42:09< celticminstrel> Gonna try taking the fallback as const-ref.
20170303 04:50:20-!- gfgtdf [~chatzilla@x4e369d5b.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 51.0.1/20170125094131]]
20170303 04:52:05-!- Appleman1234 [~Appleman1@pl2006.nas82q.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170303 04:53:59-!- Appleman1234 [~Appleman1@pl317.nas82q.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 05:00:41< JyrkiVesterinen> Whatever the compiler attempts to do, it definitely tries to call a wrong constructor.
20170303 05:00:42< JyrkiVesterinen> 00F5B83C  call        boost::optional<int>::optional<int> (0C8159Eh)  
20170303 05:00:59< JyrkiVesterinen> It should be boost::optional<int>::optional<boost::none_t>.
20170303 05:01:20-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170303 05:01:21< JyrkiVesterinen> Which is the constructor for empty optional.
20170303 05:02:56< vultraz_iOS> boost bug?
20170303 05:03:14< JyrkiVesterinen> Entirely possible.
20170303 05:03:20< JyrkiVesterinen> Maybe even a compiler bug.
20170303 05:03:46< vultraz_iOS> o_O
20170303 05:13:13< celticminstrel> I thought you also used MSVC 2013?
20170303 05:13:25< celticminstrel> I think I even updated it fairly recently.
20170303 05:13:35< vultraz_iOS> me?
20170303 05:13:53< vultraz_iOS> when did i use 2013
20170303 05:16:42< celticminstrel> Jyrki
20170303 05:16:56< JyrkiVesterinen> Yes, I use MSVC2013.
20170303 05:29:56< JyrkiVesterinen> This may not be a satisfactory solution, but boost::none was changed in Boost 1.60: https://github.com/boostorg/optional/commit/9f8dd573866a48938d53eab8eade1de41e62a6b1
20170303 05:30:21< JyrkiVesterinen> MSVC chooses the new implementation by default. It's unlikely that the problem would occur with it.
20170303 05:30:54< JyrkiVesterinen> Updating to Boost 1.60 or above should get rid of the crash, even if it doesn't explain why it happened in the first place.
20170303 05:30:57< celticminstrel> I'll try that at some point.
20170303 05:31:19-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170303 05:31:35< celticminstrel> I can't remember if I had some particular reason for being on 1.58 or if it was just because it was the version I already had on my computer.
20170303 05:31:43< vultraz_iOS> should we add another entry to boost_patched?
20170303 05:31:56< celticminstrel> vultraz_iOS: What does the README say about Boost version?
20170303 05:32:12< vultraz_iOS> what?
20170303 05:32:18< JyrkiVesterinen> I think it would be best to just set the required Boost version to 1.60 on Windows.
20170303 05:32:28< celticminstrel> Oh, I guess that'd work.
20170303 05:32:46< vultraz_iOS>  * Boost libraries             >= 1.48.0
20170303 05:33:27< vultraz_iOS> this seems quite old
20170303 05:33:33< vultraz_iOS> 1.60 min on windows it is!
20170303 05:38:19-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 05:40:38-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 05:41:48-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 05:42:42< celticminstrel> What was that workaround in Travis for an old Boost version or something?
20170303 05:42:51< celticminstrel> Maybe the base minimum also needs updating.
20170303 05:43:37< celticminstrel> Oh, that was SDL, not Boost.
20170303 05:43:40< celticminstrel> Never mind then.
20170303 05:57:48-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170303 06:23:05-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 06:25:49-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 06:29:01-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 06:36:07-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 06:37:38-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 06:51:22-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170303 06:55:13-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 268 seconds]
20170303 06:58:02-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 07:00:28-!- JyrkiVesterinen [~JyrkiVest@87-100-187-114.bb.dnainternet.fi] has quit [Quit: .]
20170303 07:07:28-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20170303 07:16:35-!- celticminstrel is now known as celmin|sleep
20170303 07:35:32-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170303 07:47:10-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 07:49:38-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 07:49:49-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 07:59:38-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 256 seconds]
20170303 08:01:52-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 08:04:55-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 08:07:27-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 08:14:46-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 264 seconds]
20170303 08:23:27-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170303 08:26:12-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 08:28:34-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 08:29:37-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170303 08:32:19-!- atarocch [~atarocch@93.56.160.30] has joined #wesnoth-dev
20170303 08:36:22-!- Appleman1234 [~Appleman1@pl317.nas82q.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 264 seconds]
20170303 08:39:01-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170303 08:43:08-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Read error: Connection reset by peer]
20170303 08:47:37-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 08:53:42-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 09:09:54-!- Appleman1234 [~Appleman1@pl301.nas82q.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 09:12:25-!- madmax28 [~madmax28@xdsl-87-78-205-6.netcologne.de] has quit [Ping timeout: 260 seconds]
20170303 09:13:25-!- madmax28 [~madmax28@xdsl-81-173-158-228.netcologne.de] has joined #wesnoth-dev
20170303 09:49:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170303 09:51:50-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: .]
20170303 09:51:59-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170303 10:08:30-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 10:08:35-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Ping timeout: 240 seconds]
20170303 10:16:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170303 10:21:14-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170303 10:25:43-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170303 10:29:51-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: Rebooting]
20170303 10:31:47-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170303 10:44:16-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170303 10:44:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20170303 10:45:22-!- Appleman1234 [~Appleman1@pl301.nas82q.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 246 seconds]
20170303 10:45:38-!- Appleman1234 [~Appleman1@pl791.nas82l.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 11:27:27-!- irker844 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170303 11:27:27< irker844> wesnoth: loonycyborg wesnoth:master 567dba1ae4ed / src/server/ (forum_user_handler.cpp forum_user_handler.hpp mysql_prepared_statement.ipp): Refit forum_user_handler to use sql prepared statements https://github.com/wesnoth/wesnoth/commit/567dba1ae4edc1641ce5bb3730f3d6b4aa8461ab
20170303 11:27:27< irker844> wesnoth: loonycyborg wesnoth:master 4917857eb999 / src/server/mysql_prepared_statement.ipp: Properly implement fetching strings from mysql https://github.com/wesnoth/wesnoth/commit/4917857eb99904d420b636982248733ec033e3e8
20170303 11:27:28< irker844> wesnoth: loonycyborg wesnoth:master df6f8891e45d / src/server/mysql_prepared_statement.ipp: Made sql error message include the SQL query https://github.com/wesnoth/wesnoth/commit/df6f8891e45df370dbf312070d4dff4ca910ab87
20170303 11:27:29< irker844> wesnoth: loonycyborg wesnoth:master 7b4f571afb3c / src/server/mysql_prepared_statement.ipp: Add some documentation to prepared_statement() https://github.com/wesnoth/wesnoth/commit/7b4f571afb3c4688a5d8eb85308bc8791ac6cf21
20170303 11:27:30< irker844> wesnoth: loonycyborg wesnoth:master e549a7c42a89 / src/server/ (forum_user_handler.cpp mysql_prepared_statement.ipp): Do probe queries without logging an error for each user not found https://github.com/wesnoth/wesnoth/commit/e549a7c42a89d226bbe5ee8a718eb472149efca0
20170303 11:27:31< irker844> wesnoth: loonycyborg wesnoth:master 41c0fc242e14 / src/server/forum_user_handler.cpp: Screen column and table names in sql with backticks for safety https://github.com/wesnoth/wesnoth/commit/41c0fc242e148ddc98127209446111fe06835227
20170303 11:27:33< irker844> wesnoth: loonycyborg wesnoth:master 409eda21a428 / src/server/ (forum_user_handler.cpp forum_user_handler.hpp): Reimplement autoreconnect if sql server lost functionality https://github.com/wesnoth/wesnoth/commit/409eda21a4287078d209e05ac37ed0c8fa57573a
20170303 11:27:35< irker844> wesnoth: loonycyborg wesnoth:master 96244e1167dd / src/server/mysql_prepared_statement.ipp: Remove cout debugging output https://github.com/wesnoth/wesnoth/commit/96244e1167dd212e6dfa79a677f0e4c8ba209e86
20170303 11:27:37< irker844> wesnoth: loonycyborg wesnoth:master 0e4586975e2f / src/server/mysql_prepared_statement.ipp: Bind mysql statement to unique_ptr to ensure that it won't be leaked https://github.com/wesnoth/wesnoth/commit/0e4586975e2f0fcbad08e8392b8be04e34a36c35
20170303 11:27:39< irker844> wesnoth: loonycyborg wesnoth:master 8c3c0abe838c / src/server/mysql_prepared_statement.ipp: Ensure that mysql_stmt_free_result is called even if exception is thrown https://github.com/wesnoth/wesnoth/commit/8c3c0abe838cdf825cdae94fd3424d0da22747ba
20170303 11:27:41< irker844> wesnoth: Sergey Popov wesnoth:master eca27ae16fea / src/server/ (forum_user_handler.cpp forum_user_handler.hpp mysql_prepared_statement.ipp): Merge pull request #930 from wesnoth/sql_prepared_statements https://github.com/wesnoth/wesnoth/commit/eca27ae16fea712b3a566e04ded810abe6baab84
20170303 11:29:35-!- Appleman1234 [~Appleman1@pl791.nas82l.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170303 11:35:45-!- Appleman1234 [~Appleman1@pl038.nas82f.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 11:51:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170303 11:57:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170303 12:08:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds]
20170303 12:42:28-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 12:46:02-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has joined #wesnoth-dev
20170303 13:06:22-!- atarocch [~atarocch@93.56.160.30] has quit [Ping timeout: 264 seconds]
20170303 13:25:33-!- Appleman1234 [~Appleman1@pl038.nas82f.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 258 seconds]
20170303 13:27:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170303 14:01:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170303 14:15:38-!- Appleman1234 [~Appleman1@pl1210.nas82d.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 14:26:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170303 14:28:08-!- irker844 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170303 14:29:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170303 14:35:48-!- Appleman1234 [~Appleman1@pl1210.nas82d.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170303 14:39:36-!- RatArmy_ [~ratarmy@om126204164042.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 15:07:28-!- Kwandulin [~Miranda@p200300760F7B960B6DBB6D898FF89949.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170303 15:13:59-!- DeFender [~DeFender1@46-116-117-53.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20170303 15:14:19-!- Appleman1234 [~Appleman1@pl2398.nas82b.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170303 15:17:44-!- JyrkiVesterinen [~JyrkiVest@85-76-81-247-nat.elisa-mobile.fi] has quit [Quit: .]
20170303 15:52:40-!- The_Unforgiven [~quassel@2601:40a:c300:b721:dce2:1e9e:93bb:da4b] has joined #wesnoth-dev
20170303 15:52:40-!- The_Unforgiven [~quassel@2601:40a:c300:b721:dce2:1e9e:93bb:da4b] has quit [Changing host]
20170303 15:52:40-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170303 16:00:12-!- Kwandulin [~Miranda@p200300760F7B960B6DBB6D898FF89949.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170303 16:12:37-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170303 16:25:33-!- The_Unforgiven [~quassel@2601:40a:c300:b721:dce2:1e9e:93bb:da4b] has joined #wesnoth-dev
20170303 16:25:48-!- The_Unforgiven [~quassel@2601:40a:c300:b721:dce2:1e9e:93bb:da4b] has quit [Changing host]
20170303 16:25:48-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170303 16:52:45-!- Kwandulin [~Miranda@p200300760F7B960BA5816D0D23702B1C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170303 17:03:29-!- JyrkiVesterinen [~JyrkiVest@89-166-103-131.bb.dnainternet.fi] has joined #wesnoth-dev
20170303 17:06:17-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170303 17:08:29-!- yaiyan is now known as Yaiyan
20170303 17:16:48-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds]
20170303 17:25:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170303 17:29:18-!- atarocch [~atarocch@93.56.160.30] has joined #wesnoth-dev
20170303 17:35:43-!- celmin|sleep is now known as celticminstrel
20170303 17:42:39-!- abruanese_ [U2FsdGVkX1@ma.sdf.org] has joined #wesnoth-dev
20170303 17:42:43-!- heirecka_ [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170303 17:43:20-!- Netsplit *.net <-> *.split quits: heirecka, abruanese, loonycyborg, tomreyn
20170303 17:43:44-!- Netsplit over, joins: tomreyn
20170303 17:44:01-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20170303 17:44:02-!- abruanese_ is now known as abruanese
20170303 17:44:11-!- heirecka_ is now known as heirecka
20170303 18:22:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170303 18:24:14-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170303 18:28:46-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 246 seconds]
20170303 19:40:02-!- Kwandulin [~Miranda@p200300760F7B960BA5816D0D23702B1C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170303 20:01:28-!- gfgtdf [~chatzilla@x4e369d5b.dyn.telefonica.de] has joined #wesnoth-dev
20170303 20:02:19< gfgtdf> celticminstrel: did you see https://gna.org/bugs/?25555?
20170303 20:24:34-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170303 20:48:41-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has joined #wesnoth-dev
20170303 20:54:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170303 21:06:14-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 21:10:22-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170303 21:30:46< celticminstrel> Sounds like an error in the C++ implementation...
20170303 21:31:10< celticminstrel> I also recall fixing something related to those tags though. Is this before or after that fix?
20170303 21:56:30-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has joined #wesnoth-dev
20170303 21:58:22< gfgtdf> don't know mote than the erroreport says
20170303 21:59:05< gfgtdf> more*
20170303 22:15:18-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 22:20:17-!- JyrkiVesterinen [~JyrkiVest@89-166-103-131.bb.dnainternet.fi] has quit [Quit: .]
20170303 22:27:50-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has joined #wesnoth-dev
20170303 22:40:46< gfgtdf> zookeeper: i just observed some mp game in 1.12 and noticed some bad transitions: http://i.imgur.com/n8DGtt7.png
20170303 22:52:07< zookeeper> sure, people use bad combinations. there's no way to make those look good.
20170303 22:52:21< zookeeper> maybe a bit better, but... i dunno
20170303 23:00:14< zookeeper> it's a given that transitions have lots of limitations, so it's not a bug if people ignore those and their maps look bad because of it. especially those kinds of 3-way corners are borderline impossible to make to look good.
20170303 23:11:19< zookeeper> btw, what i said a few days ago about there being some inconsistency about some terrain graphics rule matching... it's not true
20170303 23:18:28-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170303 23:32:30-!- RatArmy_ [~ratarmy@om126161112129.8.openmobile.ne.jp] has joined #wesnoth-dev
20170303 23:36:17-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170303 23:38:07-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Ping timeout: 258 seconds]
20170303 23:39:38-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170303 23:40:34< vultraz_iOS> celticminstrel: what is the format for ADJUST_ALPHA's formulas again?
20170303 23:40:51< celticminstrel> WFL
20170303 23:41:35< celticminstrel> And it should output a 0..255 value.
20170303 23:41:40< vultraz_iOS> hmmm
20170303 23:42:15< vultraz_iOS> pondering how to do a gradient fadeout
20170303 23:43:00< celticminstrel> Which direction?
20170303 23:43:08< vultraz_iOS> say, left to right
20170303 23:44:39< celticminstrel> That should be a simple subtraction and possibly scaling.
20170303 23:45:00< celticminstrel> ie, if the image was 256 pixels wide and you want a lineary fade, I think (255 - x) would do it.
20170303 23:45:07< celticminstrel> ^linear
20170303 23:45:10< vultraz_iOS> indeed
20170303 23:45:34< celticminstrel> But then that would also need to be scaled into the actual width of the image, or possibly even into a lesser width.
20170303 23:46:52< vultraz_iOS> indeed
20170303 23:47:39< vultraz_iOS> (we don't have any way to do something similar on drawn shapes yet,do we?)
20170303 23:47:56< vultraz_iOS> I'd guess we'd need a color() WFL object for that
20170303 23:48:38< celticminstrel> We don't have any formula support on the GUI2 canvas yet, if that's what you're asking.
20170303 23:48:59< vultraz_iOS> uh...
20170303 23:49:05< vultraz_iOS> I
20170303 23:49:09< vultraz_iOS> m pretty sure we do
20170303 23:49:42< celticminstrel> Uh. Maybe. Looking again, I'm not actually clear on what you meant.
20170303 23:50:33< vultraz_iOS> say I want to draw a rectangle with 255, 255, 255, but (255-x) alpha 
--- Log closed Sat Mar 04 00:00:45 2017