--- Log opened Thu Mar 16 00:00:18 2017
20170316 00:11:43-!- stikonas_ is now known as stikonas
20170316 00:19:19-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:ec64:66c:3160:a638] has quit [Ping timeout: 246 seconds]
20170316 00:29:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170316 00:30:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 00:30:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 00:53:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170316 00:53:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 01:14:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170316 01:15:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170316 01:21:17-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170316 01:49:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170316 01:50:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 02:14:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170316 02:14:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170316 02:15:16-!- gfgtdf_ [~chatzilla@x4e369a7a.dyn.telefonica.de] has joined #wesnoth-dev
20170316 02:15:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170316 02:15:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 02:17:24-!- gfgtdf [~chatzilla@x4e36a6be.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170316 02:17:26-!- gfgtdf_ is now known as gfgtdf
20170316 03:04:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170316 03:10:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170316 03:11:02-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170316 03:13:22-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 268 seconds]
20170316 03:27:16-!- gfgtdf [~chatzilla@x4e369a7a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0/20170302120751]]
20170316 03:32:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 03:32:55-!- irker846 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170316 03:32:55< irker846> wesnoth: Charles Dang wesnoth:master 61bac99491cd / src/units/frame.cpp: Fixed poisoned units having incorrect tint (bug #25549) https://github.com/wesnoth/wesnoth/commit/61bac99491cd22969851bbd0fe49f0ed02727a83
20170316 03:36:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 03:45:04< celticminstrel> Bad vultraz. Be on IRC when you commit. :/
20170316 03:45:17< celticminstrel> Well, I managed to comment on the commit though, so whatever.
20170316 03:58:06< irker846> wesnoth: Wedge009 wesnoth:master 2813195985e8 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project files for 581aba7e. https://github.com/wesnoth/wesnoth/commit/2813195985e891024c32b30f013ef734bf99ceed
20170316 04:26:51< irker846> wesnoth: Charles Dang wesnoth:master 45a606556af6 / src/ (game_initialization/connect_engine.cpp team.cpp): Connect Engine: add flag for host side https://github.com/wesnoth/wesnoth/commit/45a606556af6d84913dfecfededb3485ef967802
20170316 04:52:49-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 04:52:50< travis-ci> wesnoth/wesnoth#12933 (master - 61bac99 : Charles Dang): The build failed.
20170316 04:52:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211606990
20170316 04:52:50-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 05:03:04-!- Appleman1234 [~Appleman1@pl9884.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170316 05:24:46-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170316 05:25:05-!- JyrkiVesterinen [~JyrkiVest@87-100-137-127.bb.dnainternet.fi] has joined #wesnoth-dev
20170316 05:28:06-!- celticminstrel is now known as celmin|sleep
20170316 05:48:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170316 05:48:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170316 05:51:59-!- travis-ci [~travis-ci@ec2-54-198-186-122.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 05:52:00< travis-ci> wesnoth/wesnoth#12934 (master - 45a6065 : Charles Dang): The build failed.
20170316 05:52:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211614952
20170316 05:52:00-!- travis-ci [~travis-ci@ec2-54-198-186-122.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 05:56:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 06:01:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 06:04:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170316 06:27:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170316 06:43:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170316 06:54:22-!- JyrkiVesterinen [~JyrkiVest@87-100-137-127.bb.dnainternet.fi] has quit [Quit: .]
20170316 07:17:24-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20170316 07:31:32-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170316 07:35:57-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170316 07:36:15< irker846> wesnoth: Charles Dang wesnoth:master 8675bbbe8950 / src/gui/dialogs/lobby/ (lobby.cpp lobby.hpp): MP Lobby: use exit hook for quit confirmation https://github.com/wesnoth/wesnoth/commit/8675bbbe89509810ddf4579f869ec9161d022f07
20170316 07:45:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 07:48:14< irker846> wesnoth: Charles Dang wesnoth:master 70f827415be0 / / (5 files in 4 dirs): MP Lobby: rename class for better consistency with other dialogs https://github.com/wesnoth/wesnoth/commit/70f827415be05f68acb199a967a71e6feb37e6d1
20170316 07:49:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 08:05:40-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me]
20170316 08:06:36-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20170316 08:12:01-!- Appleman1234 [~Appleman1@pl1955.nas82m.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170316 08:41:05-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 08:41:06< travis-ci> wesnoth/wesnoth#12935 (master - 8675bbb : Charles Dang): The build is still failing.
20170316 08:41:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211643868
20170316 08:41:06-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 08:52:17< irker846> wesnoth: ln-zookeeper wesnoth:master a463ad72726e / data/multiplayer/maps/ (2p_Swamp_of_Dread.map 2p_The_Walls_of_Pyrennis.map): Improved borders of Swamp of Dread and The Walls of Pyrennis https://github.com/wesnoth/wesnoth/commit/a463ad72726eff1115617eea215acbba4acfdd0a
20170316 08:52:53< irker846> wesnoth: ln-zookeeper wesnoth:master bc893060908f / src/ (5 files in 4 dirs): Made the fake map border behave the same as off-map in the interface https://github.com/wesnoth/wesnoth/commit/bc893060908ffdac79e456edbbbff1f70cbe1157
20170316 09:00:16< irker846> wesnoth: Charles Dang wesnoth:master 301137091db8 / src/tests/gui/test_gui2.cpp: Fixup tests https://github.com/wesnoth/wesnoth/commit/301137091db84e10a67ec6e6fed9cb5b77bd108a
20170316 09:04:02-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 09:17:37-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20170316 09:23:14-!- travis-ci [~travis-ci@ec2-54-146-148-253.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 09:23:15< travis-ci> wesnoth/wesnoth#12936 (master - 70f8274 : Charles Dang): The build is still failing.
20170316 09:23:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211646014
20170316 09:23:15-!- travis-ci [~travis-ci@ec2-54-146-148-253.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 09:23:28< zookeeper> ...woah. my zopflipng routine can produce output that wesnoth doesn't handle right.
20170316 09:24:40< DeFender1031> "zopflipping" sounds like one of those obscure extreme sports that people post videos to facebook about.
20170316 09:24:54< JyrkiVesterinen> How is that even possible? AFAIK, we use libpng to decode PNG files.
20170316 09:25:11< JyrkiVesterinen> No PNG optimizer on the planet should create PNGs that libpng can't handle.
20170316 09:26:08< zookeeper> hmh, i don't know. now i re-saved the file and ran zopflipng on it again, and now it works. previously it showed up as fully yellow.
20170316 09:26:32< zookeeper> maybe it was some other mysterious bug? :P
20170316 09:27:16< zookeeper> i guess now i'll never know
20170316 09:28:07< zookeeper> all i know is that i ended up getting pure yellow in the middle of stone walls, that is wall-stone-base.png
20170316 09:28:33< zookeeper> but now it's gone, as is said version of said file.
20170316 09:31:53< matthiaskrgr> I can do a woptipng run if you want :) 
20170316 09:31:57-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has joined #wesnoth-dev
20170316 09:32:25< zookeeper> no no no
20170316 09:32:35< matthiaskrgr> D:
20170316 09:33:05< zookeeper> i was just moving some files, and compressing them at the the same time because why not
20170316 09:33:19< matthiaskrgr> ok
20170316 09:34:54< zookeeper> however, now on a different file i get an alpha glitch that i can actually reproduce, again resulting from zopflipng. i am using --iterations=30 but presumably that shouldn't cause breakage.
20170316 09:35:59< zookeeper> same with 20 though
20170316 09:36:30< JyrkiVesterinen> Complain to Google, then. :P https://github.com/google/zopfli/issues
20170316 09:39:04< zookeeper> yeah, if i manage to figure out what actually happens...
20170316 09:39:24< zookeeper> no pixel information seems to have changed, or at least paint.net opens it up the same as the uncompressed version
20170316 09:39:44< zookeeper> but in wesnoth it behaves as if it didn't have any alpha
20170316 09:40:55< zookeeper> ah, it has made it paletted... for some reason
20170316 09:41:15< JyrkiVesterinen> Okay, Wesnoth-specific issue, that's bad. :(
20170316 09:41:28< JyrkiVesterinen> Maybe you should just leave the image unoptimized.
20170316 09:41:31< matthiaskrgr> sdl bug?
20170316 09:42:07< matthiaskrgr> iirc sdl_image has problems with palette images
20170316 09:42:09< zookeeper> no i mean zopflipng turned it into a paletted image. with one entry being alpha, apparently. dunno if wesnoth "should" be able to handle those or not.
20170316 09:42:31< matthiaskrgr> I also had to be careful when coding woptipng
20170316 09:44:14< zookeeper> it seems zopflipng doesn't give me any options for forbidding it from doing that
20170316 09:44:26< zookeeper> hurrdurr...
20170316 09:44:53< matthiaskrgr> use flif  \o/  :> 
20170316 09:46:01< zookeeper> i don't like it when these things happen right in the middle of making a commit
20170316 09:51:32< zookeeper> wait, but... wesnoth handles _other_ paletted images (with alpha) apparently just fine?
20170316 09:51:35< zookeeper> why is it just this one that breaks
20170316 09:52:38< zookeeper> if i just commit this stuff, will someone want to figure it out ASAP? :p
20170316 09:52:46< JyrkiVesterinen> No. :P
20170316 09:53:21< zookeeper> bah
20170316 09:53:40< zookeeper> maybe the difference is that this file gets 4 bits/pixel, others seemingly get 8
20170316 09:54:07-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 09:56:13< zookeeper> well, there's no shame in brute-forcing it by altering the image just enough to make zopflipng keep it as 8bpp, which seems to fix the issue :p
20170316 09:57:02< JyrkiVesterinen> It would probably be easier to compress it to 4bpp with zopflipng and then convert it to 8bpp with ImageMagick...
20170316 09:58:28< zookeeper> well wouldn't that re-encode the file and thus lose any compression benefits?
20170316 09:59:08< JyrkiVesterinen> Dunno.
20170316 10:01:16< irker846> wesnoth: ln-zookeeper wesnoth:master b827908cd56f / data/core/ (182 files in 5 dirs): Moved (and optimized) images from cave/stone_walls/ to walls/stone/ https://github.com/wesnoth/wesnoth/commit/b827908cd56fed70b5df875c680abeb7ac069d47
20170316 10:01:27-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 10:01:28< travis-ci> wesnoth/wesnoth#12937 (master - a463ad7 : ln-zookeeper): The build is still failing.
20170316 10:01:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211662093
20170316 10:01:28-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 10:01:47< zookeeper> (no UMC used cave/stone_walls, so it's a safe move)
20170316 10:03:16-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has quit [Quit: Lunch]
20170316 10:03:53< zookeeper> matthiaskrgr, if you want to verify that woptipng doesn't do the same thing, then i can give you an image to test with.
20170316 10:05:24< matthiaskrgr> I use
20170316 10:05:25< matthiaskrgr> -np			no palette reduction
20170316 10:05:28< matthiaskrgr> when calling optipng
20170316 10:05:35< matthiaskrgr> for that reason :) 
20170316 10:05:49< zookeeper> right, okay
20170316 10:06:25< matthiaskrgr> and I check all images via PIL to make sure the still look the same
20170316 10:07:11< matthiaskrgr> altough PIL is not that reliable, if you have an empty alpha channel and you remove it, PIL will say the images are not identical iirc :(
20170316 10:09:10< zookeeper> well the images _are_ the same
20170316 10:09:18< zookeeper> it's just that wesnoth can't handle one of them, for some reason
20170316 10:09:41< matthiaskrgr> well
20170316 10:09:52< matthiaskrgr> imaging you are a sky and encode information in the amout of channels an image has 
20170316 10:09:55< matthiaskrgr> *spy
20170316 10:09:58< matthiaskrgr> xD
20170316 10:10:39< zookeeper> https://www.dropbox.com/s/nitpf0yiownlu6w/pngtest_unoptimized.png?dl=0 https://www.dropbox.com/s/nitpf0yiownlu6w/pngtest_optimized.png?dl=0
20170316 10:11:13< zookeeper> ^ i was referring to those images
20170316 10:11:50< matthiaskrgr> the link is the same
20170316 10:11:57< zookeeper> the former works as core/images/terrain/walls/stone/wall-stone-mine-concave-r.png, but if you use the latter then it behaves as if it had no alpha channel
20170316 10:12:00< zookeeper> no it isn't :p
20170316 10:12:11< matthiaskrgr> oh right
20170316 10:12:56-!- Appleman1234_ [~Appleman1@pl9282.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 10:13:03< matthiaskrgr> optimized  pngtest_unoptimized.png  from 788 to 314, -474b, -60.15%
20170316 10:13:28< zookeeper> easy to test, if you're interested: just place some straight mine walls (Xom)
20170316 10:13:37-!- Appleman1234 [~Appleman1@pl1955.nas82m.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 246 seconds]
20170316 10:13:48< matthiaskrgr> it's compiling ™
20170316 10:15:27-!- Appleman1234_ is now known as Appleman1234
20170316 10:15:44< zookeeper> (and as you probably figured, the file location i mentioned is after my latest commit)
20170316 10:19:48< matthiaskrgr> mh, new compile warnings
20170316 10:21:06< vultraz_iOS> D:
20170316 10:22:00< matthiaskrgr> oh look who showed up :P
20170316 10:22:24< matthiaskrgr> http://pastebin.com/L2etaqBs  
20170316 10:26:17< vultraz_iOS> how come you always get these nice warnings the rest of us don;t
20170316 10:26:19< vultraz_iOS> gcc 7?
20170316 10:26:26< matthiaskrgr> :>
20170316 10:26:37< matthiaskrgr> I build clang-dev on a daily basis
20170316 10:26:45< matthiaskrgr>  but clang 4.0 should also get you these
20170316 10:26:53< vultraz_iOS> im still on gcc 5.1.0
20170316 10:27:28< matthiaskrgr> I don't think gcc has Wunused-lambda-capture
20170316 10:27:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 10:32:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 10:33:30< matthiaskrgr> well if you want even more static analysis I can get you a cppcheck report as well 
20170316 10:34:09< vultraz_iOS> i can fix these easily 
20170316 10:34:15< vultraz_iOS> do you have more for me to fix?
20170316 10:34:24< matthiaskrgr> no, that was all by clang 
20170316 10:37:30-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170316 10:37:45< irker846> wesnoth: Charles Dang wesnoth:master ae13143f3d5b / src/gui/dialogs/title_screen.cpp: Fixed some unused lambda capture warnings reported by clang https://github.com/wesnoth/wesnoth/commit/ae13143f3d5b9a9f67315c1125c2e7398807f111
20170316 10:37:55< vultraz_iOS> matthiaskrgr: ^
20170316 10:39:09< matthiaskrgr> cppcheck: http://pastebin.com/raw/amJC2NNK   
20170316 10:39:22< matthiaskrgr> there might be false positives
20170316 10:39:40< matthiaskrgr> a lot of these    Assert statement calls a function which may have desired side effects     are probably garbage as well
20170316 10:40:34< matthiaskrgr> vultraz_iOS: can confirm wunusedlambda warnings are gone :) 
20170316 10:40:41< JyrkiVesterinen> Web server, forums and wiki are down. Some kind of daily maintenance?
20170316 10:41:23< zookeeper> they seem to be down momentarily very often (if not daily) at this time
20170316 10:41:44< vultraz_iOS> i have no idea what to do with .tpp files
20170316 10:42:20< zookeeper> some backup/etc jobs running i believe, probably not intended to make everything seem down though
20170316 10:43:16< Soliton> backup of website and db vm.
20170316 10:50:58< vultraz_iOS> [src/scripting/game_lua_kernel.cpp:3570]: (error) Memory leak: lua_engine
20170316 10:51:02< vultraz_iOS> dunno what to do about that
20170316 10:51:50-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 10:51:51< travis-ci> wesnoth/wesnoth#12938 (master - bc89306 : ln-zookeeper): The build is still failing.
20170316 10:51:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211662225
20170316 10:51:51-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 10:57:07< vultraz_iOS> matthiaskrgr: there's a couple good things in here
20170316 10:57:28< matthiaskrgr> :)
20170316 11:00:41< matthiaskrgr> if you want I can get you a full report which also contains style,performance and portability messages
20170316 11:00:55< matthiaskrgr> but some of them are quite noisy e.g. "scope of this variable can be reduced"
20170316 11:02:05< JyrkiVesterinen> By the way, in the evening I plan to try to compile the game with MSVC2017 and the /permissive- switch.
20170316 11:02:06< JyrkiVesterinen> https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/
20170316 11:02:48< JyrkiVesterinen> I don't expect to find much though. As we already compile the game with MSVC, GCC and Clang, it's unlikely that MSVC-specific constructs would be used outside of Windows-specific code.
20170316 11:06:12< loonycyborg> You could hit some ICEs
20170316 11:08:39< irker846> wesnoth: ln-zookeeper wesnoth:master 57cee6b09b7f / data/multiplayer/maps/2p_Hornshark_Island.map: Used the fake map border for the impassable corners of Hornshark Island https://github.com/wesnoth/wesnoth/commit/57cee6b09b7f89d53ace323d0e7823a456c33533
20170316 11:12:42< irker846> wesnoth: Charles Dang wesnoth:master 9754d3e08b4c / src/ (7 files in 5 dirs): Fixed a few of the simpler warnings reported by cppcheck https://github.com/wesnoth/wesnoth/commit/9754d3e08b4cec44124ef8fed8dfdaaab6b81d60
20170316 11:12:58< vultraz_iOS> matthiaskrgr: ^ not all but some
20170316 11:14:55< matthiaskrgr> nice
20170316 11:20:36-!- Appleman1234 [~Appleman1@pl9282.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170316 11:20:43-!- Appleman1234_ [~Appleman1@pl7506.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 11:21:39< vultraz_iOS> going to do some cleanup on the mp piepline since there was a warning about
20170316 11:21:41< vultraz_iOS> that
20170316 11:24:03< matthiaskrgr> full check at 61 % 
20170316 11:24:38< matthiaskrgr> already 600 findings xD
20170316 11:24:49< matthiaskrgr> but there's a lot of style noise 
20170316 11:25:03< vultraz_iOS> i should give you commit access
20170316 11:25:08< vultraz_iOS> let you fix stuff yourself :P
20170316 11:25:11< matthiaskrgr> ;_; 
20170316 11:25:58< vultraz_iOS> what's your github?
20170316 11:26:04< matthiaskrgr> no
20170316 11:26:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 11:26:04< matthiaskrgr> :P
20170316 11:26:28< matthiaskrgr> I'm not even a c++ coder 
20170316 11:26:33< matthiaskrgr> I just like to break stuff 
20170316 11:26:49< matthiaskrgr> which is why I'm good at testing things manually
20170316 11:27:05< matthiaskrgr> and sometimes I use static analysis to give me hints on things to test manually :) 
20170316 11:27:38< vultraz_iOS> I see
20170316 11:28:06< matthiaskrgr> do you know what this is?  https://github.com/wesnoth/wesnoth/blob/master/src/floating_label.cpp#L261  
20170316 11:28:25< matthiaskrgr> screen = nullptr;  if (screen != nullptr){}
20170316 11:28:43< vultraz_iOS> bullshit, I say :P
20170316 11:28:43< matthiaskrgr> [src/floating_label.cpp:261]: (style) Condition 'screen!=nullptr' is always false
20170316 11:29:16< vultraz_iOS> i think there was a similar thing in video.cpp I removed once
20170316 11:31:15-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 11:31:16< travis-ci> wesnoth/wesnoth#12939 (master - 3011370 : Charles Dang): The build was fixed.
20170316 11:31:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211664315
20170316 11:31:16-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 11:31:20< matthiaskrgr> woot 
20170316 11:32:43< zookeeper> i wonder what kind of crapstorm would ensue if i used the fake map border on... isar's.
20170316 11:32:46-!- Appleman1234_ [~Appleman1@pl7506.ag1212.nttpc.ne.jp] has quit [Ping timeout: 264 seconds]
20170316 11:33:20< vultraz_iOS> why would a crapstorm ensue?
20170316 11:33:32< Kwandulin> Never touch a running system
20170316 11:33:46< Kwandulin> and "muh changes"
20170316 11:34:23< zookeeper> vultraz_iOS, because people like their terrible-looking void
20170316 11:34:53< vultraz_iOS> why is the fill tool not working :/
20170316 11:35:05< vultraz_iOS> on the void
20170316 11:35:20< zookeeper> because of its code
20170316 11:35:24< zookeeper> just fill it with something else first
20170316 11:35:32< zookeeper> and by code i mean terrain code
20170316 11:36:18< vultraz_iOS> that's not void
20170316 11:36:19< vultraz_iOS> it's Off Map
20170316 11:36:38< zookeeper> yes
20170316 11:37:13< vultraz_iOS> to be fair, the Off Map does have a slightly nicer look
20170316 11:37:31< zookeeper> than void? sure, it's dark gray instead of black
20170316 11:37:35< vultraz_iOS> at least replace all uses of Void 
20170316 11:39:58< vultraz_iOS> the fake map edge encroaches a little too much
20170316 11:40:09< matthiaskrgr> vultraz_iOS: https://gist.github.com/anonymous/d637fe086d5c34e031dde244a662f877  
20170316 11:40:12 * matthiaskrgr runs
20170316 11:41:20 * vultraz_iOS screams
20170316 11:41:36< zookeeper> vultraz_iOS, on what? it doesn't encroach beyond its own hexes at all.
20170316 11:41:50< vultraz_iOS> the corners do
20170316 11:42:03< zookeeper> no they don't
20170316 11:43:02-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC 1.6.4 - http://znc.in]
20170316 11:45:00< JyrkiVesterinen> [src/attack_prediction.cpp:1259] -> [src/attack_prediction.cpp:1438]: (style, inconclusive) Function 'scale_probabilities' argument 3 names different: declaration 'multiplier' definition 'divisor'.
20170316 11:45:16< JyrkiVesterinen> Oops. I forgot to adjust the declaration. :/
20170316 11:46:05< irker846> wesnoth: ln-zookeeper wesnoth:master 6be1b807ffa7 / data/multiplayer/maps/3p_Morituri.map: Added one extra hex column to the right edge to make the map symmetric https://github.com/wesnoth/wesnoth/commit/6be1b807ffa7b63b8dfeef4d79934a72679c15a1
20170316 11:47:20< vultraz_iOS> jesus christ, 4000 lines of output
20170316 11:49:38-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170316 11:54:47< irker846> wesnoth: ln-zookeeper wesnoth:master 6ee43d496c3d / data/multiplayer/maps/6p_Crusaders_Field.map: Used fake map edge for the borders and thinned the cavewalls a bit https://github.com/wesnoth/wesnoth/commit/6ee43d496c3daf6fea2ebc03460baa6529e8eb1d
20170316 11:54:54-!- Appleman1234_ [~Appleman1@pl1259.nas82m.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170316 11:55:42< zookeeper> vultraz_iOS, i'm sure it's your fault that i subconsciously ended up using the word "edge" in that commit message even though i've been trying to call it "border"
20170316 11:56:16< vultraz_iOS> Is there a problem? :p
20170316 11:56:21< matthiaskrgr> your commit messages are quite ... edgy 
20170316 11:56:29< zookeeper> D:
20170316 11:57:36-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170316 11:58:09-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has quit [Ping timeout: 268 seconds]
20170316 12:00:15< irker846> wesnoth: ln-zookeeper wesnoth:master 3f308b2f4bea / data/multiplayer/maps/2p_Ruphus_Isle.map: Used fake map border instead of void for the edges https://github.com/wesnoth/wesnoth/commit/3f308b2f4bea9c06ac5cb5d2e0ef3c20be4e34a0
20170316 12:03:05-!- Appleman1234_ [~Appleman1@pl1259.nas82m.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170316 12:06:44-!- Appleman1234_ [~Appleman1@pl16933.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 12:07:08-!- Appleman1234_ is now known as Appleman1234
20170316 12:15:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 12:17:20-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 12:17:21< travis-ci> wesnoth/wesnoth#12940 (master - b827908 : ln-zookeeper): The build was fixed.
20170316 12:17:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211681728
20170316 12:17:21-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 12:20:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 12:22:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170316 12:22:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 12:24:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170316 13:03:47-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 13:03:48< travis-ci> wesnoth/wesnoth#12941 (master - ae13143 : Charles Dang): The build was fixed.
20170316 13:03:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211692683
20170316 13:03:48-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 13:23:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 13:29:24-!- Appleman1234 [~Appleman1@pl16933.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170316 13:42:14-!- Appleman1234 [~Appleman1@pl13456.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 13:49:40-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 13:49:41< travis-ci> wesnoth/wesnoth#12942 (master - 57cee6b : ln-zookeeper): The build was fixed.
20170316 13:49:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211702670
20170316 13:49:41-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 13:50:54-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 14:04:10-!- Appleman1234 [~Appleman1@pl13456.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170316 14:08:54-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has quit [Quit: JyrkiVesterinen]
20170316 14:14:14-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170316 14:27:42-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170316 14:32:50-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 14:32:51< travis-ci> wesnoth/wesnoth#12943 (master - 9754d3e : Charles Dang): The build was fixed.
20170316 14:32:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211703804
20170316 14:32:52-!- travis-ci [~travis-ci@ec2-54-159-193-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 14:47:25-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170316 14:47:29-!- Appleman1234 [~Appleman1@pl24997.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 14:56:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170316 14:57:50-!- Appleman1234 [~Appleman1@pl24997.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170316 15:00:17-!- irker846 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170316 15:03:09-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170316 15:23:55-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 15:32:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 15:36:48-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 15:36:49< travis-ci> wesnoth/wesnoth#12944 (master - 6be1b80 : ln-zookeeper): The build has errored.
20170316 15:36:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211713024
20170316 15:36:49-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 15:37:09-!- JyrkiVesterinen [~JyrkiVest@85-76-100-76-nat.elisa-mobile.fi] has quit [Quit: .]
20170316 15:39:21-!- Appleman1234 [~Appleman1@pl23367.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170316 16:02:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 16:08:03< celmin|sleep> zookeeper, matthiaskrgr: I thought png didn't support alpha channel in paletted images?
20170316 16:08:04< celmin|sleep> [Mar 16@06:41:44am] vultraz_iOS: i have no idea what to do with .tpp files
20170316 16:08:05< celmin|sleep> They're basically the same as .hpp files?
20170316 16:08:06< celmin|sleep> matthiaskrgr: Is that cppcheck gist based on after vultraz fixed some?
20170316 16:08:26< matthiaskrgr> after
20170316 16:09:08< matthiaskrgr> re alpha cannel: mmh maybe optipng is broken then and generates invalid pngs, I don't know
20170316 16:09:27-!- celmin|sleep is now known as celticminstrel
20170316 16:09:29< matthiaskrgr> re cppcheck: I did rerun after he pushed
20170316 16:11:34< zookeeper> http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.tRNS
20170316 16:11:54< zookeeper> "The tRNS chunk specifies that the image uses simple transparency: either alpha values associated with palette entries (for indexed-color images) or a single transparent color (for grayscale and truecolor images)."
20170316 16:11:59< celticminstrel> Huh, okay.
20170316 16:12:10< celticminstrel> Maybe it's just stb_image that doesn't support it then.
20170316 16:12:28< celticminstrel> Though I also seem to recall GIMP refusing to create such images.
20170316 16:12:40< celticminstrel> Not really important, I guess.
20170316 16:13:00< zookeeper> sure, i bet most apps won't create them
20170316 16:13:47< celticminstrel> matthiaskrgr: Was cppcheck a clang thing? The #if condition it's complaining about appears to be the one checking __has_include.
20170316 16:14:08< matthiaskrgr> no, cppcheck is independant from clang or gcc
20170316 16:14:15< matthiaskrgr> it has its own preprocessor/tokenizer 
20170316 16:14:20< celticminstrel> So it's not related to LLVM.
20170316 16:14:45< matthiaskrgr> I would not be too worried about it 
20170316 16:16:27< matthiaskrgr> it's probably the __has_included()  
20170316 16:17:19< celticminstrel> Why did Vultraz skip the uninitialized members in the tpp file.
20170316 16:18:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170316 16:18:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 16:19:38< matthiaskrgr> also, in case you try cppcheck-dev on wesnoth, we are aware that cppcheck crashes on some files :p 
20170316 16:19:47< matthiaskrgr> but latest release should be fine 
20170316 16:19:49< celticminstrel> Hmm... either he did, or the warnings are spurious.
20170316 16:19:55< celticminstrel> Moving on!
20170316 16:20:05< celticminstrel> I'm ignoring all the style ones right now.
20170316 16:23:18-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 16:23:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170316 16:24:50< celticminstrel> JyrkiVesterinen: What about "[src/attack_prediction.cpp:922] -> [src/attack_prediction.cpp:287]: (performance, inconclusive) Technically the member function '::prob_matrix::dump' can be static."?
20170316 16:25:22< celticminstrel> Also "[src/attack_prediction.cpp:1273]: (performance) Function parameter 'a_split, b_split' should be passed by reference."
20170316 16:26:06< celticminstrel> My impression is that some of these "can be static" notes don't make much sense...
20170316 16:26:38< matthiaskrgr> "inconclusive" checks might have a higher rate of false positives
20170316 16:26:52< celticminstrel> Yeah, the ones about units are definitely false positives.
20170316 16:34:42< celticminstrel> These information lines about unknown GETTEXT_DOMAIN seem to be a problem (apart from the ones in gettext.hpp).
20170316 16:34:57< celticminstrel> Unless those files don't actually contain any strings.
20170316 16:40:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 16:40:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 16:45:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170316 16:45:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 16:45:55< celticminstrel> So, there are translatable strings in src/chat_command_handler.cpp that do not appear to have been captured by xgettext.
20170316 16:46:31< celticminstrel> At least, I can't find them in wesnoth.pot or wesnoth-lib.pot.
20170316 16:50:40< celticminstrel> According to gettext.hpp, the domain should default to "wesnoth" if not explicitly set...
20170316 16:52:33< celticminstrel> Hmm, I've found some strings from chat_command_handler.cpp...
20170316 16:53:45< celticminstrel> I bet xgettext doesn't support strings spread across multiple lines, taking advantage of the fact that C/C++ concatenates adjacent strings.
20170316 16:54:33< celticminstrel> Hmm, but is that the only issue here...
20170316 16:55:11< celticminstrel> Oh, wait, when were these strings actually added... if it was after the last pot-update, it wouldn't be strange for them to be missing...
20170316 16:56:24< celticminstrel> ...
20170316 16:56:38< celticminstrel> Oh, hpp, not cpp. That could be the problem then.
20170316 16:59:45< celticminstrel> Guessing xgettext only parses the cpp files, not the hpp files. Which is probably how it should be anyway.
20170316 17:12:30< Soliton> xgettext parses what it's given. whether it's given the headers is questionable indeed though.
20170316 17:13:29< celticminstrel> I've moved the strings to a source file. Some were in a template class though; I'm trying to use extern templates to make it work.
20170316 17:16:47-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170316 17:26:29-!- irker809 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170316 17:26:29< irker809> wesnoth: Charles Dang wesnoth:master 7ef80b301bdf / src/ (5 files in 2 dirs): Whole bunch of cleanup and some refactoring of MP workflow code https://github.com/wesnoth/wesnoth/commit/7ef80b301bdf537332ad26eddd554d6e49c31b9f
20170316 17:27:46< celticminstrel> Oh good, looks like that doesn't touch any of the source files I was working with.
20170316 17:27:57< Soliton> it might not be such a bad idea to parse the headers as well if it's difficult to put the strings elsewhere.
20170316 17:28:15< celticminstrel> It's generally easy to move them.
20170316 17:28:49< Soliton> sure, but you mentioned templates.
20170316 17:29:29< celticminstrel> Yes, there was the one case where they were in a template. It looks like moving them to a source file still works if I use an extern template declaration though.
20170316 17:30:02< celticminstrel> That's on MSVC mind you, I should make sure it also works on clang/GCC.
20170316 17:31:09-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Ping timeout: 268 seconds]
20170316 17:31:28< Soliton> the other thing is that it might happen again that someone will put translatable strings in a header.
20170316 17:31:44< celticminstrel> I'm sure it will happen.
20170316 17:36:51-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170316 17:41:17< celticminstrel> Pushing to a branch so that Travis can verify whether it still works on clang/GCC.
20170316 17:45:10-!- atarocch [~atarocch@88.131.217.34] has joined #wesnoth-dev
20170316 17:52:41< irker809> wesnoth: Celtic Minstrel wesnoth:gettext_fixups b7d0a22bc364 / / (16 files in 5 dirs): Move most translatable strings in headers to a source file https://github.com/wesnoth/wesnoth/commit/b7d0a22bc36400eebfd418e771c8bc9829fc70e6
20170316 17:55:26< irker809> wesnoth: Charles Dang wesnoth:master e16588812a4f / src/ (4 files in 2 dirs): MP Lobby: refactor use of exception out of lobby config reload request https://github.com/wesnoth/wesnoth/commit/e16588812a4f27fb6b20d44d4bbab8d48229229b
20170316 18:01:12-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170316 18:05:53-!- JyrkiVesterinen [~JyrkiVest@87-92-8-82.bb.dnainternet.fi] has joined #wesnoth-dev
20170316 18:13:59< JyrkiVesterinen> 20170316 16:24:50< celticminstrel> JyrkiVesterinen: What about "[src/attack_prediction.cpp:922] -> [src/attack_prediction.cpp:287]: (performance, inconclusive) Technically the member function '::prob_matrix::dump' can be static."?
20170316 18:14:15< JyrkiVesterinen> Only if ATTACK_PREDICTION_DEBUG isn't #defined.
20170316 18:14:38< JyrkiVesterinen> Otherwise the function has a different (non-empty) implementation that can't be static.
20170316 18:14:47< JyrkiVesterinen> 20170316 16:25:22< celticminstrel> Also "[src/attack_prediction.cpp:1273]: (performance) Function parameter 'a_split, b_split' should be passed by reference."
20170316 18:14:51< celticminstrel> Ah.
20170316 18:15:08< JyrkiVesterinen> The parameters are copied anyway. Passing them by reference wouldn't speed the code up any.
20170316 18:15:16< JyrkiVesterinen> In fact, it might even make it a bit slower.
20170316 18:17:50-!- mjs-de [~mjs-de@x4e30a013.dyn.telefonica.de] has joined #wesnoth-dev
20170316 18:19:02< celticminstrel> Tons of these warnings are "maybe you should declare that constructor explicit".
20170316 18:20:07< JyrkiVesterinen> Our guidelines require explicit constructors, though.
20170316 18:20:08< JyrkiVesterinen> https://wiki.wesnoth.org/CodingStandards#Avoid_implicit_conversions
20170316 18:25:47-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 18:25:52< celticminstrel> I'm just focusing on non-style complaints right now.
20170316 18:36:30< celticminstrel> Hmm, one clamg build has passed. Seems like a good sign.
20170316 18:36:33< celticminstrel> ^clang
20170316 18:37:26< celticminstrel> Looks like the use of extern templates does work for clang, at least.
20170316 18:37:49< celticminstrel> ...wait, looking at wrong build. XD
20170316 18:38:06< celticminstrel> Okay, it hasn't started yet. :/
20170316 18:38:58< matthiaskrgr> I can check for you <3 
20170316 18:39:08< celticminstrel> I suppose you could.
20170316 18:39:13< celticminstrel> gettext_fixups branch
20170316 18:39:16< matthiaskrgr> yeah
20170316 18:39:22 * celticminstrel wanted to make sure it works on GCC too.
20170316 18:39:29< matthiaskrgr> uh :/
20170316 18:39:43< celticminstrel> Uh?
20170316 18:39:45< matthiaskrgr> well that would take some time since I'd have to rebuild wesnoth from scratch then :P
20170316 18:39:58< celticminstrel> Oh.
20170316 18:40:17< celticminstrel> Well, testing even one of the two is a good start though.
20170316 18:40:19< matthiaskrgr> I'm rebuilding with my llvm setup right now  
20170316 18:41:02< celticminstrel> Hm, on second look it might not be working on MSVC. :|
20170316 18:41:18< matthiaskrgr> http://pastebin.com/bYadp0gn  
20170316 18:41:23< celticminstrel> There are other workarounds without using an extern template declaration, if necessary...
20170316 18:41:35< celticminstrel> XD What
20170316 18:41:53< matthiaskrgr> shrug.emoij
20170316 18:41:59< celticminstrel> IOW, no errors?
20170316 18:42:04< matthiaskrgr> still building 
20170316 18:42:13< celticminstrel> Ah, so just no errors for that specific file.
20170316 18:42:21< matthiaskrgr> ah yes, linker errors
20170316 18:42:27< matthiaskrgr> shit
20170316 18:42:48< celticminstrel> So either I can't use extern templates or I used them wrong... probably...
20170316 18:42:48< matthiaskrgr> http://pastebin.com/NMwqd6L8  
20170316 18:44:15< matthiaskrgr> it started now https://travis-ci.org/wesnoth/wesnoth/jobs/211847457  
20170316 18:44:33-!- markus__ [~mjs-de@x4db64a8f.dyn.telefonica.de] has joined #wesnoth-dev
20170316 18:44:35< matthiaskrgr> so I can leave now, bbl :P
20170316 18:44:37< celticminstrel> I suppose I need to rethink it, then...
20170316 18:44:41< celticminstrel> Okay, bye. :P
20170316 18:45:05< matthiaskrgr> ok it alreay failed, lulz :> 
20170316 18:45:09< matthiaskrgr> https://travis-ci.org/wesnoth/wesnoth/jobs/211847457#L761  
20170316 18:46:14< Soliton> i'd just make it so xgettext is run on the headers.
20170316 18:46:39< Soliton> just needs two small edits for cmake and scons.
20170316 18:46:58< celticminstrel> Hmm. Well, that's certainly more future-proof, I guess...
20170316 18:48:07-!- mjs-de [~mjs-de@x4e30a013.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170316 18:48:14< JyrkiVesterinen> Okay, to compile Wesnoth with MSVC2017 it seems to be best to use the Boost develop branch.
20170316 18:48:26< JyrkiVesterinen> The latest change there was made literally three days ago: https://github.com/boostorg/config/commit/d5c2dbae3858e0cc0c1093993c5a0b54e9988a9f
20170316 18:48:33< JyrkiVesterinen> Time to clone the Git repo...
20170316 18:52:52< JyrkiVesterinen> Here we go...
20170316 18:52:53< JyrkiVesterinen> $ git clone --recursive --shallow-submodules --branch https://github.com/boostorg/boost/tree/develop
20170316 18:57:21< irker809> wesnoth: Celtic Minstrel wesnoth:master e0b85e5ddad7 / / (4 files in 3 dirs): Some unit test fixups https://github.com/wesnoth/wesnoth/commit/e0b85e5ddad793dee0b1e9e8cf0770e351c7eba4
20170316 18:57:59< celticminstrel> Feels like there's something missing in that vcxproj diff...
20170316 19:21:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 19:25:16< irker809> wesnoth: Charles Dang wesnoth:master adb5ef90ad6f / / (8 files in 4 dirs): Demote can_shrink key from global widget scope to label-only https://github.com/wesnoth/wesnoth/commit/adb5ef90ad6f2db09125af3ebf9fcccdd1caf974
20170316 19:25:19< irker809> wesnoth: Charles Dang wesnoth:master 9e258472c1b8 / data/gui/window/ (file_dialog.cfg game_load.cfg): Allowed some immediately obvious labels to shrink https://github.com/wesnoth/wesnoth/commit/9e258472c1b8668560e8846ae20acf2b76d858d3
20170316 19:25:56< celticminstrel> ...
20170316 19:28:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 19:28:26< celticminstrel> This one doesn't even make sense: [src/gui/dialogs/gamestate_inspector.cpp:475]: (warning) Redundant code: Found a statement that begins with numeric constant.
20170316 19:30:35-!- markus__ [~mjs-de@x4db64a8f.dyn.telefonica.de] has quit [Remote host closed the connection]
20170316 19:48:27-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170316 19:48:40< vultraz_iOS> Ok, so we're essentially ready for release
20170316 19:48:46< vultraz_iOS> now that I've fixed that label issue
20170316 19:51:41< celticminstrel> You're finally here.
20170316 19:51:48< celticminstrel> You should've been here like, hours ago.
20170316 19:51:54< vultraz_iOS> why?
20170316 19:52:06< celticminstrel> Because you're making all sorts of commits?
20170316 19:52:14< vultraz_iOS> indeed
20170316 19:52:30< vultraz_iOS> did you have a query?
20170316 19:52:59< celticminstrel> I don't think I did, this time.
20170316 19:53:13< celticminstrel> Though I was doing stuff at the same time and you got in my way at least twice.
20170316 19:53:41< celticminstrel> ...
20170316 19:57:49< vultraz_iOS> ah, sorry
20170316 20:00:08-!- midzer_ [~quassel@p5B051444.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170316 20:02:14-!- midzer [~quassel@p5B051A19.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20170316 20:02:18< celticminstrel> And now my Windows can't connect to the network for some reason, so I'm gonna see if restarting the router works.
20170316 20:06:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 246 seconds]
20170316 20:07:04< matthiaskrgr> mmh what about https://gna.org/bugs/index.php?25504 ? 
20170316 20:07:37< JyrkiVesterinen> It's not a blocker if you're asking about that.
20170316 20:07:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170316 20:07:46< matthiaskrgr> ok
20170316 20:09:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170316 20:09:20< celticminstrel> ?
20170316 20:10:04< matthiaskrgr> 21:07 < matthiaskrgr> mmh what about https://gna.org/bugs/index.php?25504 ? 
20170316 20:10:06< matthiaskrgr> 21:07 < JyrkiVesterinen> It's not a blocker if you're asking about that.
20170316 20:15:01< vultraz_iOS> celticminstrel: im going to merge the sota pr
20170316 20:15:08< vultraz_iOS> i assume you aren't doing anything?
20170316 20:15:23< celticminstrel> vultraz_iOS: As long as it only touches data and not src, go ahead.
20170316 20:15:26< zookeeper> wait a sec
20170316 20:15:37< celticminstrel> (Pretty sure it does, but make sure first.)
20170316 20:15:45< irker809> wesnoth: sigurdfdragon wesnoth:master b12c7791ceb2 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (15 files): SotA: Ellipsis grammer fix https://github.com/wesnoth/wesnoth/commit/b12c7791ceb21d981742e9e775b3aad4e51256f5
20170316 20:15:47< irker809> wesnoth: sigurdfdragon wesnoth:master 49a202047c7a / data/campaigns/Secrets_of_the_Ancients/maps/01_Slipping_Away.map: SotA S1: Replace void with impassable shroud https://github.com/wesnoth/wesnoth/commit/49a202047c7af229ab41b4116da61147fe11283f
20170316 20:15:48< celticminstrel> (ie, click the list of files modified.)
20170316 20:15:49< irker809> wesnoth: sigurdfdragon wesnoth:master 11ed70929d5c / data/campaigns/Secrets_of_the_Ancients/_main.cfg: SotA: Change a difficulty image so all entries in menu are same size https://github.com/wesnoth/wesnoth/commit/11ed70929d5c56102e8ed132f00393a22b204ae3
20170316 20:15:51< irker809> wesnoth: sigurdfdragon wesnoth:master 303dd6aa31a9 / data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg: SotA S18: Fix empty type unit bug reported in forums https://github.com/wesnoth/wesnoth/commit/303dd6aa31a9fca1c1808b177968f7dee812b041
20170316 20:15:53< irker809> wesnoth: beetlenaut wesnoth:master 46369c5ac227 / data/campaigns/Secrets_of_the_Ancients/_main.cfg: SotA: Use a custom icon for the campaign menu https://github.com/wesnoth/wesnoth/commit/46369c5ac2277c0fd07f827d01975227fa6be335
20170316 20:15:55< irker809> wesnoth: beetlenaut wesnoth:master ce338d2049b4 / data/campaigns/Secrets_of_the_Ancients/maps/ (10_Merfolk_Revenge.map 21_Against_the_World.map): SotA: Use merfolk castles instead of sunken ruins in some maps https://github.com/wesnoth/wesnoth/commit/ce338d2049b473b1d08250d8feb5333f939d6517
20170316 20:15:57< irker809> wesnoth: beetlenaut wesnoth:master ed31f72fae99 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (16_The_Mage.cfg 18_Abandoned_Outpost.cfg): SotA: Add notes to objectives https://github.com/wesnoth/wesnoth/commit/ed31f72fae999d8d3654a39fac8ce4ef858a56a4
20170316 20:15:59< irker809> wesnoth: beetlenaut wesnoth:master 9dfd065e1410 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (02_Dark_Business.cfg 03_Bandits.cfg 04_Becalmed.cfg 08_Carcyn.cfg): SotA: Make some small changes to messages and other strings https://github.com/wesnoth/wesnoth/commit/9dfd065e14104175e5039662ca76e8d8d17c2e94
20170316 20:16:01< irker809> wesnoth: beetlenaut wesnoth:master de0159e12084 / data/campaigns/Secrets_of_the_Ancients/scenarios/02_Dark_Business.cfg: SotA S2: Fix exploit allowing WCs to be created on invalid hexes https://github.com/wesnoth/wesnoth/commit/de0159e12084c7e3e32aabafde2aa012bf529c03
20170316 20:16:02< celticminstrel> Somehow I think vultraz_iOS didn't check for responses before clicking the button. >_>
20170316 20:16:03< irker809> wesnoth: sigurdfdragon wesnoth:master 490f8e7e9efa / changelog players_changelog: SotA: Add changelog entries https://github.com/wesnoth/wesnoth/commit/490f8e7e9efa1808856e71c4d93a30d651f3aef7
20170316 20:16:05< irker809> wesnoth: sigurdfdragon wesnoth:master 1982b31e6744 / RELEASE_NOTES: SotA: Add a little bit more to RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/1982b31e674492ae5898072e0d420c379b4123ca
20170316 20:16:07< irker809> wesnoth: beetlenaut wesnoth:master 69b12ff6ec2b / data/campaigns/Secrets_of_the_Ancients/maps/05_Blackwater.map: SotA S05: Make water under a bridge shallow so skeletons on it do not submerge https://github.com/wesnoth/wesnoth/commit/69b12ff6ec2b543feebeb91aa79a39395230aa8e
20170316 20:16:08< zookeeper> yeah
20170316 20:16:09< irker809> wesnoth: sigurdfdragon wesnoth:master 7998f84a2c5c / data/campaigns/Secrets_of_the_Ancients/scenarios/01_Slipping_Away.cfg: SotA S1: Adjust schedule & turn limit to match dialog https://github.com/wesnoth/wesnoth/commit/7998f84a2c5c4d0f845f4747d40b29ee9f20de1b
20170316 20:16:11< irker809> wesnoth: sigurdfdragon wesnoth:master 3feba6b0a1f1 / data/campaigns/Secrets_of_the_Ancients/scenarios/06_Following_the_Shadow.cfg: SotA S6: Make it clear that Ardonna must be moved to the tunnel https://github.com/wesnoth/wesnoth/commit/3feba6b0a1f177edf46578b80bdc40c409ae4966
20170316 20:16:13< irker809> wesnoth: sigurdfdragon wesnoth:master aa44755228bb / data/campaigns/Secrets_of_the_Ancients/ (scenarios/09_Training_Session.cfg units/Dummy.cfg): SotA S9: Fix removal of overlay & improve dummy invisibility https://github.com/wesnoth/wesnoth/commit/aa44755228bbee2c6decb501af0d16a28d591b2b
20170316 20:16:15< irker809> wesnoth: sigurdfdragon wesnoth:master 7552dc955729 / data/campaigns/Secrets_of_the_Ancients/scenarios/10_Merfolk_Revenge.cfg: SotA S10: Remove unworking, unneeded lines. https://github.com/wesnoth/wesnoth/commit/7552dc955729f807cb9e72daacf4a24104c61c28
20170316 20:16:17< irker809> wesnoth: sigurdfdragon wesnoth:master 9961d6d7e878 / data/campaigns/Secrets_of_the_Ancients/ (5 files in 2 dirs): SotA: Auto-recall Corpse Shynal if player has her https://github.com/wesnoth/wesnoth/commit/9961d6d7e878769478441575963bc427d001de6f
20170316 20:16:17< vultraz_iOS> i saw celticminstrel's in a popup
20170316 20:16:19< irker809> wesnoth: sigurdfdragon wesnoth:master 9fbf83f1f743 / data/campaigns/Secrets_of_the_Ancients/images/units/zombie-wolf.png: SotA: Remove unused zombie-wolf.png https://github.com/wesnoth/wesnoth/commit/9fbf83f1f7434c90116706aa9abe6afaca6fe3c5
20170316 20:16:21< irker809> wesnoth: sigurdfdragon wesnoth:master 7399cba00d37 / data/campaigns/Secrets_of_the_Ancients/scenarios/08_Carcyn.cfg: SotA S8: Make objective clearer https://github.com/wesnoth/wesnoth/commit/7399cba00d379b1076ddd07d56790d774bdd35cb
20170316 20:16:23< irker809> wesnoth: sigurdfdragon wesnoth:master c65b50e8f19a / data/campaigns/Secrets_of_the_Ancients/ (scenarios/18_Abandoned_Outpost.cfg utils/sota-utils.cfg): SotA: Make code robust against debug usage https://github.com/wesnoth/wesnoth/commit/c65b50e8f19a2a071bc101554a89faae6ce4b169
20170316 20:16:25< irker809> wesnoth: sigurdfdragon wesnoth:master 283c38e93471 / data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg: SotA S17: Improvements to how the sacrifice scene looks https://github.com/wesnoth/wesnoth/commit/283c38e934714b6ef26e451a73049d2eacae4973
20170316 20:16:27< irker809> wesnoth: sigurdfdragon wesnoth:master 535ce53ca908 / data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg: SotA S18: Simplify advancement check https://github.com/wesnoth/wesnoth/commit/535ce53ca90892d84efc3461833bce44c02e242b
20170316 20:16:29< irker809> wesnoth: sigurdfdragon wesnoth:master 6e272a6c8233 / data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg: SotA S18: Fix bug where Ardonna starts with less than full move https://github.com/wesnoth/wesnoth/commit/6e272a6c8233a414db546038489f15f9a5005893
20170316 20:16:31< irker809> wesnoth: sigurdfdragon wesnoth:master ca0a5a55d486 / data/campaigns/Secrets_of_the_Ancients/scenarios/18_Abandoned_Outpost.cfg: SotA S17: Use title case for menu option https://github.com/wesnoth/wesnoth/commit/ca0a5a55d4861c29d13825e5ac341c7b7d237ade
20170316 20:16:33< irker809> wesnoth: sigurdfdragon wesnoth:master b62e389a74b3 / data/campaigns/Secrets_of_the_Ancients/utils/sota-utils.cfg: SotA: Give Ras-Tabahn intelligent trait https://github.com/wesnoth/wesnoth/commit/b62e389a74b364b7dc803cdcd90e784b2a657bde
20170316 20:16:35< irker809> wesnoth: sigurdfdragon wesnoth:master 3699690c8566 / data/campaigns/Secrets_of_the_Ancients/scenarios/16_The_Mage.cfg: SotA 16: Fix Archmage having move at start of turn 5 https://github.com/wesnoth/wesnoth/commit/3699690c8566c2e0f6f663b0d7186967b9dab1bf
20170316 20:16:37< irker809> wesnoth: sigurdfdragon wesnoth:master ae2532deeea2 / data/campaigns/Secrets_of_the_Ancients/scenarios/17_Mortality.cfg: SotA S17: Have Ras-Tabahn walk in front of altar to get on it https://github.com/wesnoth/wesnoth/commit/ae2532deeea283fcc49b69949d3f821d00d54188
20170316 20:16:39< irker809> wesnoth: sigurdfdragon wesnoth:master 252b64245d7a / data/campaigns/Secrets_of_the_Ancients/scenarios/22_Epilogue.cfg: SotA S22: Remove unneeded code https://github.com/wesnoth/wesnoth/commit/252b64245d7af4f8789d94af069704cad616b1c3
20170316 20:16:46< zookeeper> well, i just wanted to look at the commit list first, i wasn't going to check the contents anyway
20170316 20:26:49< celticminstrel> A lot of these "assert calls a function with side-effects" seem to boil down to the use of a unique_ptr.
20170316 20:27:10< vultraz_iOS> oh?
20170316 20:28:01< JyrkiVesterinen> Remember that we have asserts enabled even in release builds. Thus, we *can* actually rely on side effects of functions called in assert statements.
20170316 20:28:12< celticminstrel> True.
20170316 20:28:27< celticminstrel> But I don't think we actually are relying on any side-effects that might exist in these cases.
20170316 20:29:08< celticminstrel> Though I don't really know what the side-effects of dereferencing a unique_ptr might be.
20170316 20:29:34-!- gfgtdf [~chatzilla@x4e369a7a.dyn.telefonica.de] has joined #wesnoth-dev
20170316 20:30:22-!- Kwandulin [~Kwandulin@p200300760F7B96F5AD2CDEEEB541604E.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20170316 20:31:13< DeFender1031> woah... wall of commits.
20170316 20:35:44< zookeeper> oh how i hate having to constantly revert the vxproj file (due to toggling off WML unit tests) just so i can pull. git is so bad.
20170316 20:37:26< celticminstrel> You shouldn't have to normally. Only if someone modified the vcxproj file. Which I did recently.
20170316 20:38:26< zookeeper> it's been getting modified quite a few times recently.
20170316 20:38:28< JyrkiVesterinen> Except if one wants to pull with rebase. (Alternatively one can stash the changes and pop them after pulling; however, at the time of rebasing, the working tree must be clean.)
20170316 20:38:48< celticminstrel> Yeah, pull with rebase is a little harder.
20170316 20:39:47< zookeeper> so, fake map border or stone wall for SotA:01...
20170316 20:40:45< celticminstrel> cppcheck apparently doesn't understand the __FUNCTION__ magic macro.
20170316 20:41:10< celticminstrel> At least, I assume it's a magic macro. It sure sounds like one.
20170316 20:44:53< celticminstrel> Scroll to bottom for a list of supposedly unused functions: https://gist.github.com/anonymous/d637fe086d5c34e031dde244a662f877
20170316 20:45:00< celticminstrel> Though I suspect it's wrong.
20170316 20:45:22< celticminstrel> And unused operators should be left in just for completeness in any case.
20170316 20:45:38< celticminstrel> At most it's a list of functions to check more closely.
20170316 20:46:22< vultraz_iOS> indeed
20170316 20:49:32< irker809> wesnoth: sigurdfdragon wesnoth:master c04e4a4a39e6 / data/campaigns/Secrets_of_the_Ancients/scenarios/ (8 files): SotA: Comment fixes https://github.com/wesnoth/wesnoth/commit/c04e4a4a39e673c400c303080cbf8bb83f2ddb84
20170316 21:11:16< irker809> wesnoth: Celtic Minstrel wesnoth:master f815c2272ad5 / src/ (25 files in 7 dirs): Pass strings by constref when possible https://github.com/wesnoth/wesnoth/commit/f815c2272ad54831a014ea421139b5b18b85a2a3
20170316 21:11:18< irker809> wesnoth: Celtic Minstrel wesnoth:master 12cf0fb45e68 / src/ (4 files in 3 dirs): Replace some uses of string::find with string::compare https://github.com/wesnoth/wesnoth/commit/12cf0fb45e68028e5524f44ac7f08d9dc9fe0dc6
20170316 21:11:20< irker809> wesnoth: Celtic Minstrel wesnoth:master 6b251d445c4d / src/ (config.cpp game_board.cpp units/filter.hpp utils/functional.hpp xBRZ/xbrz.cpp): Address a few other issues found by cppcheck https://github.com/wesnoth/wesnoth/commit/6b251d445c4d3d4e8a889b32d3a1bc5d5bd80b6d
20170316 21:11:24< celticminstrel> matthiaskrgr: ^
20170316 21:12:21< matthiaskrgr> :3
20170316 21:12:56< celticminstrel> Last thing I was going to do was make xgettext also count the header files, as Soliton suggested...
20170316 21:14:14< Soliton> need to edit cmake/update_pot_source_dependencies.cmake and po/SConscript.
20170316 21:16:11< Soliton> the cmake part would best be rewritten...
20170316 21:16:38< celticminstrel> If it's to be rewritten it probably shouldn't be by me.
20170316 21:22:15< irker809> wesnoth: Celtic Minstrel wesnoth:master 6bf76d940ba3 / cmake/update_pot_source_dependencies.cmake po/SConscript: Include header files in pot-updates https://github.com/wesnoth/wesnoth/commit/6bf76d940ba3cffc228ac50f22762e6c5ad6bf97
20170316 21:30:57< vultraz_iOS> so many bugs fixed for this release
20170316 21:30:59< vultraz_iOS> *feelsgood*
20170316 21:31:22< celticminstrel> How many of them were introduced later than the previous release, though? :P
20170316 21:31:38< vultraz_iOS> some
20170316 21:31:42< matthiaskrgr> celticminstrel: http://pastebin.com/uWpFvtpN   (build still in progress)
20170316 21:32:05< vultraz_iOS> but there have been some really bad bugs with, say, game creation that we've fixed
20170316 21:32:07< celticminstrel> Okay, not a huge deal but easily fixed.
20170316 21:32:45< celticminstrel> I mean, the warning won't cause any problems in the code or anything.
20170316 21:32:59< celticminstrel> I'll wait in case there are more warnings, though it's probably not likely.
20170316 21:33:04< matthiaskrgr> ok
20170316 21:33:14< JyrkiVesterinen> It will make Travis builds to fail, since they are compiled with -Wall -Werror...
20170316 21:33:15< matthiaskrgr> 66% 
20170316 21:33:34< vultraz_iOS> still, our work isn;t finished
20170316 21:33:44< vultraz_iOS> still a lot to do
20170316 21:35:48< celticminstrel> When's the next Appveyor build?
20170316 21:36:05< vultraz_iOS> probably one of the big things is figure out how to make map labels show while dialogs are up
20170316 21:36:54< JyrkiVesterinen> The next AppVeyor build will start tomorrow at 16:09 UTC, about 18,5 hours from now.
20170316 21:37:44< vultraz_iOS> JyrkiVesterinen: what heads your todo list currently? I keep forgetting...
20170316 21:37:51< vultraz_iOS> (same for celticminstrel)
20170316 21:38:44< celticminstrel> I dunno, maybe more WML tag porting? IIRC I had something for [music] in progress.
20170316 21:38:45< JyrkiVesterinen> Some small tasks. Currently trying to get the game to compile with MSVC2017 and Boost develop so that I can investigate possible MSVC2017 specific warnings.
20170316 21:38:47< matthiaskrgr> celticminstrel: no further warnings besides that -Wreorder one 
20170316 21:39:03< JyrkiVesterinen> Then would be removal of GUI1 addon manager subdialogs.
20170316 21:39:19< vultraz_iOS> I was about to do that later today
20170316 21:39:43< vultraz_iOS> (assuming you mean Addon Description and Filter Options)
20170316 21:39:54< JyrkiVesterinen> After that, looking into bugs 25523 and 25540.
20170316 21:40:02< JyrkiVesterinen> Yes, I mean them.
20170316 21:40:12< irker809> wesnoth: Celtic Minstrel wesnoth:master 2454059f76f5 / src/game_board.cpp: Fix -Wreorder warning https://github.com/wesnoth/wesnoth/commit/2454059f76f5bf5e5d566aceb5ba3fd7344d00e0
20170316 21:40:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20170316 21:41:02< celticminstrel> The other big thing I'd really like to see in 1.14 is the addon manifest idea.
20170316 21:42:44< vultraz_iOS> JyrkiVesterinen: ok, can you also put https://gna.org/bugs/index.php?25569 (or rather, the cause of) with those two
20170316 21:42:53< vultraz_iOS> there's something really weird with tree nodes
20170316 21:43:06< vultraz_iOS> and event/state propagation 
20170316 21:43:25< celticminstrel> BTW vultraz_iOS, the XCode project needs to be updated before a release.
20170316 21:43:40< vultraz_iOS> for example, besides that weird scrolling issue, zookeeper has also reported the toggle panels in the campaign dialog aren't set to the focused state when you hover over the icons
20170316 21:43:48< vultraz_iOS> which is *not* the case in Preferences, which uses a listbox
20170316 21:43:55< vultraz_iOS> celticminstrel: I cannot do that...
20170316 21:45:03< celticminstrel> I know.
20170316 21:46:21< celticminstrel> From my list: "wesnoth.simulate_combat uses a 0-based index for attack_num in the returned weapon tables. Add a deprecated message to this and add "number" with the 1-based index."
20170316 21:46:29< celticminstrel> Seems like something simple to change.
20170316 21:47:02< celticminstrel> Pretty sure some of the things on this list have already been done, too.
20170316 21:52:14< irker809> wesnoth: Charles Dang wesnoth:master 18a7e8024375 / / (10 files in 6 dirs): Removed GUI2 Addon Description and Filter Options dialog https://github.com/wesnoth/wesnoth/commit/18a7e8024375c764bffa8ed87c1d5b2e6b9c8adf
20170316 21:53:14< vultraz_iOS> JyrkiVesterinen: ^ done
20170316 21:53:17< celticminstrel> If mattsc or ancestral doesn't show up to update the XCode project, I suppose I can do it. Please remind me when you're almost ready for the release.
20170316 21:53:24< JyrkiVesterinen> Thanks. :)
20170316 21:53:40< celticminstrel> Maybe that should be "don't" instead of "doesn't".
20170316 22:01:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170316 22:01:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170316 22:05:16< vultraz_iOS> celticminstrel: I believe you fixed this? https://gna.org/bugs/index.php?24930
20170316 22:05:58< celticminstrel> I don't think so? It's possible that Pentarctagon fixed it himself though.
20170316 22:06:14< celticminstrel> Check 'git log --author=pentarctagon'
20170316 22:07:20< celticminstrel> I don't know IOW
20170316 22:08:36< matthiaskrgr> ok I should come up with a -dev version of gcc 7 to see if there are any build failures/compile warnings
20170316 22:10:27< matthiaskrgr> it's only a matter of hours :| 
20170316 22:11:20< JyrkiVesterinen> It would be nice if the GCC 7 warnings were also fixed by someone who can compile with GCC 7 locally...
20170316 22:11:44< JyrkiVesterinen> Debian Sid is currently in a freeze, so I will be stuck with GCC 6.3.0 for some time.
20170316 22:13:57< matthiaskrgr> I have 6.3.1 here
20170316 22:14:08< matthiaskrgr> so yeah, gcc-dev does build with gcc 6.3, at least to some extent :P 
20170316 22:14:35< matthiaskrgr> it's just that the binary that falls out at the end is weirdly slow, havn't figured out why yet 
20170316 22:15:58< JyrkiVesterinen> Yes, one can *build* newer GCC locally, but building an entire compiler just takes a lot of time. I plan to wait until the precompiled GCC 7 package arrives in the Sid repositories.
20170316 22:16:50-!- gfgtdf_ [~chatzilla@x4e369a7a.dyn.telefonica.de] has joined #wesnoth-dev
20170316 22:19:04-!- gfgtdf [~chatzilla@x4e369a7a.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170316 22:19:15-!- gfgtdf_ is now known as gfgtdf
20170316 22:23:59< matthiaskrgr> usually finishes with a night here on my 2011 cpu
20170316 22:27:29< JyrkiVesterinen> LGA2011 socket, or year 2011?
20170316 22:28:14< matthiaskrgr> year :) 
20170316 22:28:27< matthiaskrgr> i5-2540M 
20170316 22:30:13-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170316 22:31:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 22:43:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 22:45:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170316 22:51:32-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has joined #wesnoth-dev
20170316 22:58:49< vultraz_iOS> 2011 O_O
20170316 22:59:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 23:00:24-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170316 23:03:12< JyrkiVesterinen> 1>LINK : fatal error LNK1104: cannot open file 'libboost_date_time-vc141-mt-gd-1_64.lib'
20170316 23:03:41< JyrkiVesterinen> Almost there. The actual libraries have vc1410 in their filenames, not vc141. Apparently Boost needs some more fixes still.
20170316 23:03:51< JyrkiVesterinen> I'll just rename the files for now.
20170316 23:05:12< irker809> wesnoth: Charles Dang wesnoth:master cfc4c5c42581 / src/gui/dialogs/game_stats.cpp: Game Stats: apply red formatting to negative gold https://github.com/wesnoth/wesnoth/commit/cfc4c5c425819fd9650864195e71f13613ff88fe
20170316 23:19:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 23:19:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 23:21:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170316 23:21:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170316 23:29:05-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has quit [Read error: Connection reset by peer]
20170316 23:30:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 23:31:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 23:33:34-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has joined #wesnoth-dev
20170316 23:37:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 23:38:19-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has joined #wesnoth-dev
20170316 23:38:20< travis-ci> wesnoth/wesnoth#12952 (master - e0b85e5 : Celtic Minstrel): The build failed.
20170316 23:38:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/211868091
20170316 23:38:20-!- travis-ci [~travis-ci@ec2-54-204-203-173.compute-1.amazonaws.com] has left #wesnoth-dev []
20170316 23:38:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 23:39:50< irker809> wesnoth: Charles Dang wesnoth:master 2d7ac7c8872f / data/gui/window/file_dialog.cfg: File Dialog: disable horizontal scrollbar for Bookmarks list https://github.com/wesnoth/wesnoth/commit/2d7ac7c8872fc86333a0ff08acc98b0f064254c5
20170316 23:47:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 23:47:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170316 23:56:23< JyrkiVesterinen> Got it compiled.
20170316 23:56:25< JyrkiVesterinen> https://gist.github.com/jyrkive/cf601af0a26765f66039b4508d990e0d
20170316 23:56:40< JyrkiVesterinen> I'll investigate the warnings later on. I'll go to bed now.
20170316 23:56:44-!- JyrkiVesterinen [~JyrkiVest@87-92-8-82.bb.dnainternet.fi] has quit [Quit: Sleep]
20170316 23:59:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170316 23:59:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
--- Log closed Fri Mar 17 00:00:42 2017