--- Log opened Sat Mar 18 00:00:45 2017
20170318 00:00:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170318 00:12:57< SigurdFD> thanks
20170318 00:16:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170318 00:19:07-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has quit [Ping timeout: 246 seconds]
20170318 00:48:29-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170318 00:52:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20170318 00:54:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170318 00:55:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 00:57:34-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170318 01:01:49-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 246 seconds]
20170318 01:21:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has joined #wesnoth-dev
20170318 01:24:02-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20170318 01:27:49-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has joined #wesnoth-dev
20170318 01:31:47-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170318 01:33:19-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:64bf:694a:ae18:dbcf] has quit [Ping timeout: 246 seconds]
20170318 01:46:46-!- Appleman1234 [~Appleman1@pl24588.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170318 01:47:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170318 01:47:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 01:49:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has quit [Remote host closed the connection]
20170318 01:49:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has joined #wesnoth-dev
20170318 01:51:48-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170318 01:57:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170318 02:13:26-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170318 02:14:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has quit [Remote host closed the connection]
20170318 02:15:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has joined #wesnoth-dev
20170318 02:18:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:dc79:f784:f139:b9f2] has quit [Remote host closed the connection]
20170318 02:19:32-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170318 02:29:47-!- RatArmy_ [~ratarmy@om126204192169.6.openmobile.ne.jp] has joined #wesnoth-dev
20170318 02:32:38-!- gfgtdf [~chatzilla@x4e36afa0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0/20170302120751]]
20170318 02:47:08-!- irker306 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170318 02:48:42-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170318 03:00:05-!- RatArmy_ [~ratarmy@om126204192169.6.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170318 03:10:50-!- irker676 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170318 03:10:50< irker676> wesnoth: Celtic Minstrel wesnoth:deselect_unit 13cd8d2d4dfa / src/scripting/game_lua_kernel.cpp: Allow wesnoth.select_unit() to deselect the unit https://github.com/wesnoth/wesnoth/commit/13cd8d2d4dfadd29b43dfeb9a6a65822fb6888b9
20170318 03:11:30< celticminstrel> vultraz_iOS: Feel free to merge upon successful build. ^ (PR954)
20170318 03:11:37-!- celticminstrel is now known as celmin|sleep
20170318 03:14:03-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170318 03:23:41-!- Appleman1234 [~Appleman1@pl24588.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170318 04:05:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170318 04:05:57-!- Appleman1234 [~Appleman1@pl458.nas82g.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170318 04:13:50-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170318 04:14:28-!- travis-ci [~travis-ci@ec2-54-242-121-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20170318 04:14:29< travis-ci> wesnoth/wesnoth#12987 (deselect_unit - 13cd8d2 : Celtic Minstrel): The build was fixed.
20170318 04:14:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/212360237
20170318 04:14:29-!- travis-ci [~travis-ci@ec2-54-242-121-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20170318 04:18:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170318 04:31:11-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Ping timeout: 252 seconds]
20170318 05:11:11-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 05:11:56-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 05:15:51-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 05:15:54-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 05:19:18-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 05:22:32-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 05:27:55-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 05:29:56-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 05:31:53-!- Alkenrinnstet is now known as hi
20170318 05:32:10-!- hi is now known as Alkenrinnstet
20170318 05:37:43-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170318 06:02:51-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has joined #wesnoth-dev
20170318 06:25:39-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170318 06:35:55< irker676> wesnoth: Celtic Minstrel wesnoth:master f0c127915b9a / src/scripting/game_lua_kernel.cpp: Allow wesnoth.select_unit() to deselect the unit https://github.com/wesnoth/wesnoth/commit/f0c127915b9aa17fe33af93bb0b55f07a346a772
20170318 07:07:30-!- Kwandulin [~Kwandulin@p200300760F217129FDCFE173FCB705B6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170318 08:52:29-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has joined #wesnoth-dev
20170318 08:53:30-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170318 09:16:12< irker676> wesnoth: Charles Dang wesnoth:master 5a62b43dc851 / data/tools/wmllint: wmllint: added SotA to mainline campaigns list https://github.com/wesnoth/wesnoth/commit/5a62b43dc8517fef0e51ab271887a6e3f7dbcb88
20170318 09:16:15< irker676> wesnoth: Charles Dang wesnoth:master 49ec75829e8d / data/campaigns/ (11 files in 8 dirs): Campaigns: wmlindent run https://github.com/wesnoth/wesnoth/commit/49ec75829e8de54d0715ffefaa2c8b042fcd49be
20170318 09:17:11-!- Kwandulin [~Kwandulin@p200300760F217129FDCFE173FCB705B6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170318 09:26:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170318 09:46:42-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170318 10:00:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20170318 10:00:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170318 10:29:07< irker676> wesnoth: Jyrki Vesterinen wesnoth:master 2c00677d4b15 / projectfiles/VC12/ (wesnothlib.vcxproj wesnothlib.vcxproj.filters): Add lexical_cast.hpp to wesnothlib.vcxproj https://github.com/wesnoth/wesnoth/commit/2c00677d4b156b7f6159b13def42ceb09fe26dc4
20170318 10:29:09< irker676> wesnoth: Jyrki Vesterinen wesnoth:master 3dfd4211915c / src/ (14 files in 4 dirs): Address some cppcheck suggestions https://github.com/wesnoth/wesnoth/commit/3dfd4211915c7798403cd56f3196af09f720bbd6
20170318 10:36:48-!- Alkenrinnstet__ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 10:37:30-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 10:37:37-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 10:37:52-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 11:26:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170318 11:30:14-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 258 seconds]
20170318 11:30:19-!- Alkenrinnstet__ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 11:33:47-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 11:33:53-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 11:38:20< irker676> wesnoth: ln-zookeeper wesnoth:master 578171bb9243 / changelog players_changelog: Updated changelogs https://github.com/wesnoth/wesnoth/commit/578171bb9243e96a7df136f075f9561ae5eec442
20170318 11:40:02-!- mjs-de [~mjs-de@x5ce33cd4.dyn.telefonica.de] has joined #wesnoth-dev
20170318 11:50:28< vultraz_iOS> 12 hours
20170318 11:51:23< matthiaskrgr> I'll see if I can run this testsuit with ubsan/asan 
20170318 11:51:30< matthiaskrgr> haven't done this since some time actually
20170318 11:59:30-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer]
20170318 12:00:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170318 12:00:18-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has quit [Quit: .]
20170318 12:07:34-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20170318 12:24:35-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170318 12:35:22-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170318 12:37:23-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has joined #wesnoth-dev
20170318 12:40:16< matthiaskrgr> the ./build/test throws some errors but nothing is related to ubsan/asan 
20170318 12:55:52-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170318 13:02:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 13:14:00< celticminstrel> vultraz_iOS: What about getting beetlenaut to send over the po files?
20170318 13:14:12< celticminstrel> Dunno if that can be done in time though.
20170318 13:14:58< celticminstrel> Oh yeah, I should check if I have changelogs to update.
20170318 13:28:16< celticminstrel> Should this have a changelog? What category header would it fall under? https://github.com/wesnoth/wesnoth/commit/d1e853bc68dd3ce049347e2fef9706b0e1e64123
20170318 13:31:17-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170318 13:36:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170318 13:37:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 13:37:16< celticminstrel> vultraz_iOS, zookeeper, gfgtdf: RELEASE_NOTES currently has very little; if you can think of anything else to add, please do.
20170318 13:37:29< celticminstrel> Was this the release that removes the old MP UI? That's certainly important enough to add.
20170318 13:37:41< celticminstrel> Or was that last release? I forget...
20170318 13:42:15< celticminstrel> Well, I'm sending beetlenaut a PM.
20170318 13:48:20< celticminstrel> I'm guessing the pot-update script uses a directory listing to determine which domains to generate, which would suggest that simply creating an empty wesnoth-sota directory and running pot-update would be sufficient to generate it...
20170318 14:03:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170318 14:20:01-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170318 14:33:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170318 14:33:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 14:37:43-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170318 14:38:36-!- irker676 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170318 14:43:52-!- Appleman1234 [~Appleman1@pl458.nas82g.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 256 seconds]
20170318 15:15:45-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170318 15:18:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has joined #wesnoth-dev
20170318 15:31:29-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170318 15:42:58< vultraz_iOS> celticminstrel: yes, this release dropped the old mp ui
20170318 15:43:36< celticminstrel> I'm about to push my changelog updates and the SotA po-files.
20170318 15:44:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has quit [Remote host closed the connection]
20170318 15:44:47< vultraz_iOS> it's historic, really
20170318 15:45:00< vultraz_iOS> when you realize the new lobby was fist in 1.8
20170318 15:45:02< vultraz_iOS> first*
20170318 15:45:19< celticminstrel> Heh...
20170318 15:53:00-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has quit [Quit: .]
20170318 15:54:30< vultraz_iOS> btw, i have a report that the date of savefiles is no longer getting translated in the load game menu
20170318 15:54:41< vultraz_iOS> I wonder if i broke that by changing to std::put_time
20170318 15:55:07-!- Appleman1234 [~Appleman1@pl9299.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170318 15:55:38-!- Kwandulin [~Kwandulin@p200300760F217129212AE2F180320099.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170318 15:55:56< celticminstrel> Probably. You need to make sure the locale is imbued into the stream, I think?
20170318 15:56:47< celticminstrel> So everywhere you use put_time, you also need an .imbue(get_locale()) call, where get_locale() is something declared in gettext_boost.hpp (not sure if it exists currently but should be trivial to add if not).
20170318 15:58:28< vultraz_iOS> ah, it's there :D
20170318 15:59:37< vultraz_iOS> I wonder if I could tun util::put_time into an actual function in that case
20170318 15:59:46< vultraz_iOS> and just do this there
20170318 16:02:33< vultraz_iOS> eh, nah
20170318 16:05:46< vultraz_iOS> oh, 5 usecases...guess i better
20170318 16:06:08< celticminstrel> Just don't touch the changelog until I push, please.
20170318 16:06:23< celticminstrel> Anything else is fine.
20170318 16:06:47< vultraz_iOS> I never touch the changelog :P
20170318 16:06:51< celticminstrel> Lies.
20170318 16:24:04-!- Kwandulin [~Kwandulin@p200300760F2171293D8CACA493391D8E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170318 16:24:37< celticminstrel> I must be missing something, because 'scons pot-update' utterly refuses to generate wesnoth-sota.pot.
20170318 16:27:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has joined #wesnoth-dev
20170318 16:29:56< celticminstrel> Oh!
20170318 16:33:00< celticminstrel> Though I kinda wonder if it might've been better to forward the po-files to Ivanovic and let him handle it... >_>
20170318 16:34:30< celticminstrel> Anyway, I got it to work now.
20170318 16:35:10< celticminstrel> Just not sure what to do for languages that have no translations at all; excluding the po-files for those languages altogether seems to cause problems.
20170318 16:36:54-!- gfgtdf [~chatzilla@x50ab6fad.dyn.telefonica.de] has joined #wesnoth-dev
20170318 16:37:03< celticminstrel> zookeeper, vultraz_iOS, okay to merge PR 940?
20170318 16:39:37-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170318 16:39:37< Appveyor> The Battle for Wesnoth (Visual Studio 2013) - Release ln-zookeeper 578171b: Updated changelogs Failed
20170318 16:39:37< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth/build/Wesnoth-VS2013-master-280
20170318 16:39:42-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170318 16:39:59< celticminstrel> Oh yeah, we should probably fix that too before release.3
20170318 16:40:20< celticminstrel> I guess there won't be another Appveyor build before release, but the problem causing it to fail should be fixable.
20170318 16:43:38-!- irker064 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170318 16:43:39< irker064> wesnoth: gfgtdf wesnoth:master 31ac470a9304 / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/31ac470a93046b39181dc8faed0430f6e752e2df
20170318 16:51:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has quit [Remote host closed the connection]
20170318 16:54:48-!- Appleman1234 [~Appleman1@pl9299.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170318 17:05:21-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has joined #wesnoth-dev
20170318 17:09:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has joined #wesnoth-dev
20170318 17:10:03-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170318 17:11:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:18fb:359:5f42:77ea] has quit [Remote host closed the connection]
20170318 17:17:09< JyrkiVesterinen> celticminstrel: I can trigger a manual AppVeyor build after MSVC release builds have been fixed.
20170318 17:17:51< JyrkiVesterinen> I have a potential fix, but to verify it I need to make a release build. Because I haven't built one for a long time, this is a full rebuild and will take some time.
20170318 17:28:53< celticminstrel> So it was a release build problem.
20170318 17:29:05< celticminstrel> I'd assumed it was a unit tests problem.
20170318 17:29:31< JyrkiVesterinen> Unit tests aren't supposed to be compiled with MSVC.
20170318 17:29:44< celticminstrel> I thought Appveyor did though.
20170318 17:29:54< celticminstrel> And there is a "Test" target.
20170318 17:30:01< JyrkiVesterinen> The problem is that test_formula_core.cpp isn't excluded from release builds.
20170318 17:30:04< celticminstrel> Or configuration, whatever.
20170318 17:30:05< celticminstrel> Ahhh.
20170318 17:30:27< celticminstrel> I thought I'd excluded it from everything, though looking at the diff it did seem like something was missing...
20170318 17:30:52< JyrkiVesterinen> What AppVeyor runs is the WML unit tests (which are part of the Wesnoth binary itself, ran with the -u switch).
20170318 17:31:09< celticminstrel> Oh.
20170318 17:31:20< JyrkiVesterinen> The unit tests are compiled (with other toolchains) into a separate binary called "test".
20170318 17:31:32< JyrkiVesterinen> (The non-WML ones, to be clear)
20170318 17:31:42< celticminstrel> So what's the "test" configuration target for in MSVC?
20170318 17:31:49< celticminstrel> And "test_debug"
20170318 17:33:02< vultraz_iOS> blah
20170318 17:33:10< vultraz_iOS> get_locale() seems local to gettext_boost.cpp
20170318 17:33:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170318 17:33:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 31ac470: Update RELEASE_NOTES Failed
20170318 17:33:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-277
20170318 17:33:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170318 17:33:29< JyrkiVesterinen> I don't know what the "test" and "test_debug" configurations are for.
20170318 17:33:32< vultraz_iOS> I suppose I could re-purpose translation::strftime...
20170318 17:33:47< JyrkiVesterinen> (Also, I can't access Solution Explorer when I'm compiling.)
20170318 17:34:08< vultraz_iOS> celticminstrel: advise me
20170318 17:35:16< vultraz_iOS> eh.. hm
20170318 17:35:31< vultraz_iOS> it looks like the save index uses that? so why are the dates not translated..
20170318 17:36:26< vultraz_iOS> and format_time_summary...
20170318 17:36:28< vultraz_iOS> the hell :|
20170318 17:36:55< vultraz_iOS> gonna leave this for post-release
20170318 17:36:58< celticminstrel> By "that" you mean "imbue"?
20170318 17:37:18< irker064> wesnoth: Celtic Minstrel wesnoth:master 733ce215fd89 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/733ce215fd8997ec3b0f8f47c4a4c7ccd0b9c47b
20170318 17:37:19< zookeeper> celticminstrel, PR 940 still seems to have some changes to movement/defense on deep water
20170318 17:37:20< irker064> wesnoth: Celtic Minstrel wesnoth:master 6b0cca611f4b / po/wesnoth-sota/ (62 files): SotA: Set up for translations https://github.com/wesnoth/wesnoth/commit/6b0cca611f4ba7a9752bd983d9c7ba8c25e63b8c
20170318 17:37:37< celticminstrel> vultraz_iOS: You could always just make get_locale() not be local to the file. :P
20170318 17:37:44< celticminstrel> Or use translation_strftime, sure.
20170318 17:37:47< celticminstrel> ^::
20170318 17:38:01< vultraz_iOS> get_locale is implemented in a local class, it seems
20170318 17:38:50< JyrkiVesterinen> Maybe we could just use std::locale() to obtain the global C++ locale, and change it with std::locale::global() whenever the player changes the language.
20170318 17:38:56< JyrkiVesterinen> http://en.cppreference.com/w/cpp/locale/locale/locale
20170318 17:38:57< vultraz_iOS> celticminstrel: "that" as in translation::strftime, which uses imbue, so which should produce correctly translated strings
20170318 17:39:00< JyrkiVesterinen> http://en.cppreference.com/w/cpp/locale/locale/global
20170318 17:40:55< irker064> wesnoth: Charles Dang wesnoth:master d465879c8938 / data/gui/window/mp_join_game.cfg src/gui/dialogs/multiplayer/mp_join_game.cpp: MP Create Game: allow Leave button to fill all available space https://github.com/wesnoth/wesnoth/commit/d465879c893890ad9756f6d2e36afb79594b29a8
20170318 17:43:05< zookeeper> celticminstrel, so, AFAICT 940 isn't good to merge yet
20170318 17:44:01< gfgtdf> JyrkiVesterinen: std::locale is likely to be incompatible with utf8 on windows
20170318 17:45:00< vultraz_iOS> why microsoft why :|
20170318 17:45:47< gfgtdf> did you build boost with and icu backen when your error appeared ?
20170318 17:45:54< gfgtdf> backend*
20170318 17:46:14< irker064> wesnoth: Jyrki Vesterinen wesnoth:master 4d069bc8c2ec / projectfiles/VC12/wesnoth.vcxproj: Fix MSVC release builds https://github.com/wesnoth/wesnoth/commit/4d069bc8c2ecae280b62e4d08b95094163ed8dcf
20170318 17:47:51< JyrkiVesterinen> I triggered a manual VS2013 build in AppVeyor.
20170318 17:48:18< JyrkiVesterinen> I'm letting it finish the VS2015 debug build before I start a new VS2015 build.
20170318 17:48:58< gfgtdf> what exactly is the problem with strftime right now  actually?
20170318 17:50:27< vultraz_iOS> gfgtdf: i got rid of our custom strftime function awhile back in favor of std::put_time but according to Shiki, the dates in the game load menu aren't translated anymore
20170318 17:51:35< gfgtdf> vultraz_iOS: what was teh addantage of that switch ?
20170318 17:51:40< gfgtdf> advantage*
20170318 17:52:03< vultraz_iOS> less hand-rolling of standard code?
20170318 17:52:53< irker064> wesnoth: Charles Dang wesnoth:master 64a369ef6f3d / data/gui/window/addon_manager.cfg: Addon Manager: made Exit button normal size https://github.com/wesnoth/wesnoth/commit/64a369ef6f3d0aadf2260b75b7cba9eaad085f40
20170318 17:54:10< vultraz_iOS> gfgtdf: what's weird is the codepath for those dates actually calls translation::strftime (which then calls std::put_time), but includes a steam::imbue call that should set the locale correctly
20170318 17:54:53< vultraz_iOS> other cases of util::put_time (which just forwards to std::put_time on gcc >= 5) don't have imbue calls.
20170318 17:57:40< gfgtdf> vultraz_iOS: i think thats becasue those other cases sont realyl need translated things word, they all use format strings that use onyl numbers
20170318 17:59:02< gfgtdf> s/sont/don't
20170318 18:01:46-!- DeFender1031 [~DeFender1@217.132.17.168] has joined #wesnoth-dev
20170318 18:09:51< celticminstrel> zookeeper: Okay, I guess we'll wait until after release to merge 940.
20170318 18:09:51< celticminstrel> vultraz_iOS: You could easily expose it in a global wrapper function though, if you think it's necessary... but maybe using translation::strftime is actually better.
20170318 18:10:23< celticminstrel> Also vultraz_iOS, please update changelog and RELEASE_NOTES with anything you can think of.
20170318 18:11:38< celticminstrel> vultraz_iOS: Looks to me like the addon manager clearly omits the imbue.
20170318 18:11:49< vultraz_iOS> yes
20170318 18:11:51< celticminstrel> get_base_filename doesn't need an imbue really.
20170318 18:12:15< celticminstrel> Same for get_timestamp and unique_log_filename.
20170318 18:12:48< celticminstrel> REPORT_GENERATOR(report_clock) should though. Or switch to translation::strftime.
20170318 18:14:01< celticminstrel> What's that used for, anyway? Is the time shown on the main game screen? I don't remember that.
20170318 18:14:39< vultraz_iOS> in the top bar
20170318 18:14:55< celticminstrel> So I guess that's also not being localized right now?
20170318 18:15:29< Shiki> celticminstrel, zookeeper, PR940 changes only movement/defense on deep water for flying and swimming units like it is in 1.12. Currently they need 4 MP there too. Potential other movement/defense changes about which I talked in the PR notes are not included.
20170318 18:15:46< irker064> wesnoth: Charles Dang wesnoth:master daefe8e63b0a / src/ (display.cpp display.hpp): Don't reset zoom level every time a game is loaded (FR #25592) https://github.com/wesnoth/wesnoth/commit/daefe8e63b0acbfd4b76afc116c204cf4b5dab6d
20170318 18:15:48< celticminstrel> Oh, Shilki was around.
20170318 18:15:51< celticminstrel> ^ Shiki
20170318 18:15:53< vultraz_iOS> Shiki: ^
20170318 18:15:57 * celticminstrel smacks my backspace.
20170318 18:16:12< zookeeper> oh right, i seem to regularly forget that sevu == shiki
20170318 18:16:34< Shiki> Hi all :)
20170318 18:16:49< celticminstrel> vultraz_iOS: If you want it to apply across app sessions, that's also quite easy to do, you know? 
20170318 18:17:11< vultraz_iOS> serialize to prefs, I know
20170318 18:17:30< zookeeper> Shiki, err, so you're saying that currently there's a discrepancy between 1.12 and 1.13, and the PR actually fixes that?
20170318 18:18:39< Shiki> zookeeper, yes. There was an refactoring at some point, and the deep water values are inherited for all units
20170318 18:18:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170318 18:19:21< Shiki> s/for/to/
20170318 18:19:34< celticminstrel> [Mar 18@2:18:50pm] celticminstrel: Oh, and what about PR 947? Is that mergeable?
20170318 18:19:35< celticminstrel> [Mar 18@2:19:26pm] celticminstrel: Also consider PR939 and PR922...
20170318 18:19:40 * celticminstrel posted to wrong channel.
20170318 18:21:10 * celticminstrel also wonders if those fr.po updates have been submitted through the proper channels yet...
20170318 18:21:41< celticminstrel> PR907 also might be mergeable.
20170318 18:22:39< vultraz_iOS> fuck it, merge the fr.po prs
20170318 18:22:54< celticminstrel> Okay, on PR907 I guess we'd better do the fix manually ourselves.
20170318 18:24:12< zookeeper> Shiki, right... so for example for gryphon corpses, in 1.12 the fly movetype gives them 1 deep water movement, but in 1.13 you need to specify that with [movement_costs]?
20170318 18:24:55< Shiki> zookeeper, yes. you need to overwrite the inherited value from the normal corpse
20170318 18:26:14< zookeeper> Shiki, okay... and this only happens for deep water (and arcane resistance) because it's the only one the base corpse explicitly sets via [movement_costs] and [defense] (and [resistance])?
20170318 18:28:11< Shiki> zookeeper, yes
20170318 18:28:27< zookeeper> great. in that case, i think i get it :p
20170318 18:28:47< Shiki> great :)
20170318 18:28:48< zookeeper> so, yes, good to merge after all, i guess?
20170318 18:30:52-!- gfgtdf_ [~chatzilla@x50ab6c92.dyn.telefonica.de] has joined #wesnoth-dev
20170318 18:30:55< Shiki> I guess. There's one more thing which is different, it's the defense cap for the mounted unit, it seems every unit who has the "mounted" movetype has a defense cap. But I think that's intended.
20170318 18:31:52< irker064> wesnoth: Celtic Minstrel wesnoth:master 3d63f66dbb9e / data/tools/wesnoth/ (wmlparser2.py wmlparser3.py): wmlparser.py: stricter determination of whether strings are translatable (fixes  https://github.com/wesnoth/wesnoth/commit/3d63f66dbb9e7cffec5376e044fc14b635d661c2
20170318 18:32:04-!- gfgtdf [~chatzilla@x50ab6fad.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170318 18:32:17-!- gfgtdf_ is now known as gfgtdf
20170318 18:34:02-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170318 18:35:17< celticminstrel> I kinda think the procedure for submitting translations could use some revision, but obviously that'd require talking to actual translators... who generally don't come here AFAIK, or at least don't talk.
20170318 18:35:30< JyrkiVesterinen> AppVeyor VS2013 release build succeeded. The fix seems to work. :)
20170318 18:35:34< celticminstrel> (Or I just don't know who they are when they do talk; tha's also possible.)
20170318 18:35:36< celticminstrel> Yay!
20170318 18:35:43< celticminstrel> ^that's
20170318 18:37:12< irker064> wesnoth: Charles Dang wesnoth:master d215946cacc3 / RELEASE_NOTES: Updated RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/d215946cacc3edc450271a69912e9a2657f8bf04
20170318 18:38:27< celticminstrel> Oh, good, you fixed the typos. I was considering it, but didn't have anything in particular to add, so decided not to.
20170318 18:39:08< celticminstrel> So zookeeper, is PR947 also okay to merge then?
20170318 18:39:41< zookeeper> uh, sure
20170318 18:39:42< celticminstrel> Actually I kinda understand why we shouldn't accept translation changes via PR. As a general rule, we can't verify that they're correct. PR911, for example.
20170318 18:40:14< irker064> wesnoth: Shiki wesnoth:master 45d7cc14596e / data/core/macros/abilities.cfg: Changed description of the UMC plague ability. (#947) https://github.com/wesnoth/wesnoth/commit/45d7cc14596e7cce8cee62a6c97891d796c5b191
20170318 18:40:54< zookeeper> celticminstrel, how's that different from however they're currently sent?
20170318 18:41:02< irker064> wesnoth: Severin Glöckner wesnoth:master 49b4ca9ee075 / data/core/units/undead/ (Corpse_Soulless.cfg Corpse_Walking.cfg): fix regression of a701a2e (movement/defense on deep water for some variations) https://github.com/wesnoth/wesnoth/commit/49b4ca9ee075f6a247dea87b6a19fcbfc8aca31c
20170318 18:41:04< irker064> wesnoth: Severin Glöckner wesnoth:master a6643c60c11e / data/core/units/undead/ (Corpse_Soulless.cfg Corpse_Walking.cfg): added special notes telling about the defense cap of the mounted variant https://github.com/wesnoth/wesnoth/commit/a6643c60c11e33b0fad24185872582ea8096e54f
20170318 18:41:06< irker064> wesnoth: Celtic Minstrel wesnoth:master 4c26e470f67e / data/core/units/undead/ (Corpse_Soulless.cfg Corpse_Walking.cfg): Merge pull request #940 from sevu/deep_waters_are_deep https://github.com/wesnoth/wesnoth/commit/4c26e470f67e455ba21bb0c84596b68490d28094
20170318 18:41:40< celticminstrel> zookeeper: Currently translation changes are supposed to be sent to a "head translator" for the specific language, who would then check them and submit them to Ivanovic.
20170318 18:43:36< zookeeper> celticminstrel, sure? and if translations were submitted by PR, then it'd still be either the head translator making the PR's, or the head translator having to accept it if someone else makes one
20170318 18:43:49< celticminstrel> Sure.
20170318 18:44:26< celticminstrel> ATM it's all supposed to be done over email. but if head translators want to get a github account and look over language PRs, that'd be great IMO.
20170318 18:44:29< zookeeper> of course each language would still need to have a person responsible for reviewing PR's for that language
20170318 18:45:12< vultraz_iOS> down with email collaboration!
20170318 18:45:20< vultraz_iOS> *joking*
20170318 18:45:31< celticminstrel> I mean, it's fine if some translators prefer working via email.
20170318 18:45:59< zookeeper> i'm just saying that if the translators of a given language would _prefer_ PR's rather than the current procedure, then i don't see a reason why we shouldn't allow it.
20170318 18:46:10< celticminstrel> Right.
20170318 18:46:12< vultraz_iOS> there's no reason
20170318 18:46:16< vultraz_iOS> it was simply Declared So
20170318 18:46:27< vultraz_iOS> now I Declare Otherwise 
20170318 18:46:32< vultraz_iOS> :D
20170318 18:48:01< celticminstrel> The translator's guide claims HTTT is a sequel to the tutorial. XD
20170318 18:48:08-!- mjs-de [~mjs-de@x5ce33cd4.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170318 18:48:10< celticminstrel> vultraz_iOS: Declaring doesn't get anything done. :P
20170318 18:48:20-!- mjs-de [~mjs-de@x4db61b17.dyn.telefonica.de] has joined #wesnoth-dev
20170318 18:50:25< vultraz_iOS> *southern drawl* I DOOOO DECCCLLAARRE
20170318 19:11:55< celticminstrel> BTW, does GNA offer download of mailing list archives? Someone should grab that if it's available, or scrape it if there's no download button.
20170318 19:13:02< vultraz_iOS> dunno
20170318 19:20:14< celticminstrel> Seems the French translation was last updated on Aug 22, 2015.
20170318 19:21:01< celticminstrel> Russian was updated much more recently. You could probably PM aldarisvet and ask him if that typo PR is accurate.
20170318 19:21:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170318 19:21:33< celticminstrel> That's PR 911.
20170318 19:21:43< celticminstrel> Mind you, that person might've already emailed it to aldarisvet.
20170318 19:22:28< celticminstrel> The French translator is apparently "Haldric".
20170318 19:23:48< celticminstrel> Last seen on the forums in 2013, though I guess he must've been around still in 2015, just not on the forums.
20170318 19:24:27< celticminstrel> He only has three posts; probably just not much of a forum person.
20170318 19:24:45 * celticminstrel doubts we can get his attention in time for this release in any case.
20170318 19:33:48< vultraz_iOS> 4 hours
20170318 19:34:19< celticminstrel> The problem with "just merging" the three French PRs is, can you be sure they're 100% correct?
20170318 19:34:44< celticminstrel> I do know a little French, but even so QA is better left to a native speaker if possible.
20170318 19:35:46< celticminstrel> BTW, ISTR that there were plans to drop (possibly temporarily) some of the more niche languages?
20170318 19:36:03< vultraz_iOS> yes
20170318 19:36:10< vultraz_iOS> for the steam release
20170318 19:36:32< celticminstrel> Does that mean they'll still be included for the non-Steam release?
20170318 19:37:44< JyrkiVesterinen> Who cares if the PRs are "100% correct"? As long as a PR is an improvement, it should be merged.
20170318 19:37:59< celticminstrel> Fair enough.
20170318 19:38:12< celticminstrel> Can you be sure of that for the French PRs, though?
20170318 19:38:28< JyrkiVesterinen> No, not really. :/
20170318 19:39:08< celticminstrel> I wonder if the people who opened the PR have already tried contacting Haldric.
20170318 19:39:15< celticminstrel> ^Prs
20170318 19:39:18< celticminstrel> ^PRs
20170318 19:40:22-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Quit: Alkenrinnstet_]
20170318 19:40:27-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Quit: Alkenrinnstet]
20170318 19:40:47-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 19:41:09-!- Alkenrinnstet is now known as Guest90710
20170318 19:42:58< irker064> wesnoth: ln-zookeeper wesnoth:master 74a7e431826b / data/campaigns/Two_Brothers/maps/03_Guarded_Castle.map: TB S3: Used old wooden floor for parts of the castle interior https://github.com/wesnoth/wesnoth/commit/74a7e431826be919db2fd9f23de6278af53b1328
20170318 19:44:37-!- Guest90710 [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 19:45:24-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 19:46:47< celticminstrel> Ideally all the major languages should have SotA (and, potentially, any other new campaigns) translated in time for the release on Steam...
20170318 19:48:20-!- Alkenrinnstet_ is now known as Alkenrinnstet
20170318 19:50:10< zookeeper> Shiki, would you like to make a changeloggable list of all the flail/morningstar/shield/etc weapon name= changes?
20170318 19:50:36< zookeeper> that is, only the ones which can be relevant for filtering
20170318 19:51:19< zookeeper> celticminstrel, you've not changelogged the unit price changes?
20170318 19:54:07-!- Alkenrinnstet is now known as Alkenrinnstet_
20170318 19:54:31-!- Alkenrinnstet_ is now known as Alkenrinnstet
20170318 19:55:35< JyrkiVesterinen> AppVeyor VS2015 release build succeeded as well.
20170318 19:57:17< JyrkiVesterinen> celticminstrel: regarding your comments on commit 16fefa26, the constants are a problem. Adding the "u" suffix doesn't help.
20170318 19:58:03< JyrkiVesterinen> It would be possible to change the types of i and j to uint8_t and only cast the constants, but IMO the code looks better this way when it's aligned.
20170318 19:58:23< JyrkiVesterinen> The same also applies in xbrz.cpp.
20170318 19:58:43< JyrkiVesterinen> Also, it turned out that the warnings are new in VS2017. VS2013 or VS2015 don't emit them.
20170318 20:00:00< celticminstrel> zookeeper: I guess I forgot about them. Feel free to add yourself; if not I'll probably do it within the next hour or two.
20170318 20:02:21 * zookeeper opts for "not" :>
20170318 20:02:46< zookeeper> but really no need to list the exact changes, just a list of affected units should be good enough.
20170318 20:02:53< Shiki> zookeeper, ok, will do
20170318 20:03:15< Shiki> I could also ask somebody to have a look at the french PRs
20170318 20:03:17-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Quit: Alkenrinnstet]
20170318 20:03:37-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:04:56-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:05:17-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:05:35-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170318 20:05:52-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:07:33-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:07:52-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:09:52-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:10:13-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:10:49-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:11:08-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:11:17< celticminstrel> How often does gettext.wesnoth.org update?
20170318 20:11:34< celticminstrel> Also, it does use the git repository from github, right?
20170318 20:11:51< celticminstrel> As opposed to the (presumably) now-outdated svn repository on sf.net.
20170318 20:12:24< celticminstrel> It claims to have been last updated in 1970, which is obviously not right.
20170318 20:12:38< JyrkiVesterinen> Heh, gettext.wesnoth.org says that British English translation of trunk is 101,16 % complete. :D
20170318 20:12:50< celticminstrel> Eh? How does that work?
20170318 20:12:56-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:13:01< JyrkiVesterinen> https://www.wesnoth.org/gettext/index.php?version=trunk&package=alloff
20170318 20:13:39-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:14:28-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Client Quit]
20170318 20:14:48-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:14:55-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170318 20:15:33-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:15:36< celticminstrel> I get the impression that this page is kinda broken... clicking a package or language gives no info...
20170318 20:16:06-!- mjs-de [~mjs-de@x4db61b17.dyn.telefonica.de] has quit [Remote host closed the connection]
20170318 20:21:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170318 20:23:42-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Quit: Alkenrinnstet]
20170318 20:24:00-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:27:51-!- JyrkiVesterinen [~JyrkiVest@87-100-251-43.bb.dnainternet.fi] has quit [Quit: .]
20170318 20:28:34< zookeeper> eh, i'll do RELEASE_NOTES tomorrow...
20170318 20:28:50< celticminstrel> Oh right, RELEASE_NOTES doesn't need to be dealt with before tagging.
20170318 20:29:36 * celticminstrel hopes loonycyborg is around to do the tagging in the next two or so hours.
20170318 20:31:55< loonycyborg> do the tagging? me? pretty sure vultraz is supposed to do that
20170318 20:32:05< loonycyborg> hmm I can do pot-update tho
20170318 20:32:29-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Quit: Alkenrinnstet]
20170318 20:32:55-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:34:23< celticminstrel> Was he?
20170318 20:34:59< irker064> wesnoth: Celtic Minstrel wesnoth:master 2acd25e1d3fc / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/2acd25e1d3fc835883f8ebc7eb326546cde5f0b3
20170318 20:35:12< loonycyborg> at least he did before
20170318 20:35:23< celticminstrel> I seem to recall he tagged once and it was a disaster. >_>
20170318 20:35:26< Shiki> zookeeper, do you only mean the name= keys or the description= keys too?
20170318 20:35:39< loonycyborg> he did twice
20170318 20:35:43< celticminstrel> I see.
20170318 20:35:45 * celticminstrel shrugs.
20170318 20:35:51< loonycyborg> and first time it was disaster due to me retagging
20170318 20:35:54< celticminstrel> Well, it's not like I care who does the tagging.
20170318 20:36:14< zookeeper> Shiki, name= only, since that's what people would (in 99% of cases) be filtering on
20170318 20:36:21< loonycyborg> I, with my OCD, can't suffer wasted version numbers :P
20170318 20:36:24< Shiki> ok
20170318 20:36:31< celticminstrel> Shiki: What are you talking about here?
20170318 20:36:43 * celticminstrel thinks it sounds like something that should come in before a pot-update.
20170318 20:36:50< Shiki> an changelog entry for the changed weapon names
20170318 20:36:50< celticminstrel> Or, wait.
20170318 20:36:53< celticminstrel> Changelog, okay.
20170318 20:36:56< celticminstrel> Never mind then.3
20170318 20:42:00-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 20:44:05-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 260 seconds]
20170318 20:44:10< celticminstrel> Okay, so does anyone object to me merging PRs 922 and 939?
20170318 20:45:12< celticminstrel> (If Aginor's revamp comes through we can always change the ; back to : at that point.)
20170318 20:48:27< Shiki> zookeeper, https://bpaste.net/show/a681d8fc2f31 & PR #959
20170318 20:49:05< Shiki> zookeeper, not sure how to add it best in the changelog
20170318 20:51:07< irker064> wesnoth: ln-zookeeper wesnoth:master 07de0a02db92 / data/core/terrain-graphics.cfg: Use small forests also when adjacent to the off-map terrain https://github.com/wesnoth/wesnoth/commit/07de0a02db92afd826b51f6c1e78629607e78475
20170318 20:52:23< zookeeper> Shiki, great, thanks
20170318 20:54:41< vultraz_iOS> celticminstrel: I usually tag, yes
20170318 21:03:36< irker064> wesnoth: ln-zookeeper wesnoth:master b033316ed812 / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/b033316ed812865f1183a69a40ca7b9e68340638
20170318 21:04:57< zookeeper> 3 hours to go? ah, plenty of time to slack off and play a game before panicking at the last moment when i realize i've forgotten something...
20170318 21:08:35-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 21:16:22< loonycyborg> sota is new campaign it seems
20170318 21:16:34< loonycyborg> we got any other new textdomains this release?
20170318 21:16:55< loonycyborg> asking just in case
20170318 21:17:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 21:17:29< zookeeper> not that i'm aware of
20170318 21:17:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20170318 21:18:42-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 21:18:50-!- Appleman1234 [~Appleman1@pl1287.nas82h.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170318 21:31:34-!- Kwandulin [~Kwandulin@p200300760F2171293D8CACA493391D8E.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
20170318 21:32:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170318 21:32:50-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds]
20170318 21:35:38< Shiki> PR #959 should be merged too, it belongs together to the last changelog update
20170318 21:38:46< irker064> wesnoth: Shiki wesnoth:master 1c0d5eb943ca / data/core/units/humans/Loyalist_Iron_Mauler.cfg: changed weapon name= key to flail, like it is for the shock trooper (#959) https://github.com/wesnoth/wesnoth/commit/1c0d5eb943cad907998094832f3b6959549c32d8
20170318 21:40:18< irker064> wesnoth: Hironori Fujimoto wesnoth:master 1a2deea6bb0c / doc/manual/manual.txt: updates to manual https://github.com/wesnoth/wesnoth/commit/1a2deea6bb0c666516ce2c3c16f28dbb55cf7f6d
20170318 21:42:13< celticminstrel> Not obvious, but those were both me. >_>
20170318 21:42:25< celticminstrel> (Well, obvious if you click, I guess.)
20170318 21:42:27-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 21:42:47< loonycyborg> they both warrant rerunning pot-update
20170318 21:43:08< celticminstrel> Really? The second I can understand, but the first too?
20170318 21:43:32< loonycyborg> first I'm not 100% sure about
20170318 21:43:58< celticminstrel> I did mention I was merging them like... an hour ago.
20170318 21:44:07< celticminstrel> The second commit I mean.
20170318 21:44:19-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 246 seconds]
20170318 21:44:30< celticminstrel> Anyway, sorry if I stepped on your toes... >_>
20170318 21:44:32< loonycyborg> whoops didn't see
20170318 21:44:35< loonycyborg> np
20170318 21:45:14< loonycyborg> anyway I tried running sota and some strings are untranslated
20170318 21:45:32< loonycyborg> despite that it seems to have full russian translation
20170318 21:45:38< loonycyborg> and I have ru locale
20170318 21:45:48< loonycyborg> looking at the diff
20170318 21:46:00< loonycyborg> it seems translation tools reformatted the texts
20170318 21:46:10< loonycyborg> splitting them in lines differently
20170318 21:46:28< celticminstrel> It's likely that some strings changed? The translations were from the addon server, essentially, so if anything changed since then, those strings would be untranslated.
20170318 21:46:42< loonycyborg> I hope so
20170318 21:46:57-!- Appleman1234 [~Appleman1@pl1287.nas82h.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170318 21:47:17< loonycyborg> I hope it's not because my translation tools did something wrong
20170318 21:47:47< celticminstrel> Or because I messed up adding them. >_>
20170318 21:51:33< loonycyborg> seems strings that I saw in english are marked fuzzy in the .po file
20170318 21:53:09< loonycyborg> while before pot-update they weren
20170318 21:53:11< loonycyborg> t
20170318 21:56:13< celticminstrel> Maybe because the stringds were missing from the pot-file?
20170318 21:56:15< celticminstrel> ^strings
20170318 21:56:36< celticminstrel> I mean, it would make sense to me to mark changed strings fuzzy like that.
20170318 21:57:33-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 21:58:48-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 260 seconds]
20170318 22:00:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 258 seconds]
20170318 22:01:09< loonycyborg> that string wasn't missing from it
20170318 22:01:34< loonycyborg> addon original text could have changed
20170318 22:01:45< loonycyborg> but I don't see exact change
20170318 22:02:06< celticminstrel> I meant the string might be missing from the pot-file, not from the po-file... >_>
20170318 22:02:11< loonycyborg> might be even a small typo fix
20170318 22:02:18< loonycyborg> it appears in both
20170318 22:02:34< celticminstrel> Might be. If so you could update all three of the ja, ru, and hu translations for SotA.
20170318 22:02:46< celticminstrel> So that it remains translated.
20170318 22:03:25< loonycyborg> Today, headmaster Aimucasur himself taught a class on moving objects with .. 
20170318 22:03:30< loonycyborg> that's the first string affected
20170318 22:03:52< loonycyborg> you could try running that campaign yourself
20170318 22:04:00< loonycyborg> while setting language to russian
20170318 22:04:19< celticminstrel> I could if I had a runnable build.
20170318 22:04:37< loonycyborg> aww, I guess I'll have to do a git stash
20170318 22:04:47< vultraz_iOS> 2 hours, people
20170318 22:04:53< celticminstrel> I don't really understand how that follows, but okay.
20170318 22:05:44-!- Appleman1234 [~Appleman1@pl126.nas82a.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170318 22:07:15< celticminstrel> Hm, here's another pending French translation... https://forums.wesnoth.org/viewtopic.php?f=7&t=45041
20170318 22:07:31< loonycyborg> ok without pot-update those strings are still untranslated
20170318 22:07:37< loonycyborg> so not pot-update's fault
20170318 22:07:42< celticminstrel> 'kay
20170318 22:09:32-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 22:12:01-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 22:13:48< irker064> wesnoth: loonycyborg wesnoth:master 471c2864b2f9 / / (1323 files in 25 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/471c2864b2f970a9c13e041038ce793a33fcba78
20170318 22:17:16< loonycyborg> hmm
20170318 22:17:25-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has quit [Ping timeout: 260 seconds]
20170318 22:17:42< loonycyborg> html generation results in random ids that are different each time
20170318 22:17:56< loonycyborg> resulting in annoying changes for each regen of doc files
20170318 22:18:20< loonycyborg> I wonder if there is some way to reign in those random ids..
20170318 22:21:01-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 22:23:27-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 240 seconds]
20170318 22:24:02-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 22:26:35-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 240 seconds]
20170318 22:55:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170318 22:57:40< vultraz_iOS> 1 hour
20170318 22:58:11< zookeeper> wait, why is this unit sliding during a ranged animation...
20170318 23:01:47-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 23:02:38< celticminstrel> Gooooood question! :O
20170318 23:03:25< zookeeper> ohh, right. because MISSILE_FRAME_CHILL_TEMPEST doesn't create the kind of missile frame that the engine recognizes.
20170318 23:03:43< celticminstrel> Probably no reason why that can't be changed, right?
20170318 23:04:05-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 23:04:18< celticminstrel> Unless chill tempest is used alongside regular missile frames somewhere...
20170318 23:04:48-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170318 23:04:58-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 23:04:59< zookeeper> yeah, it probably could be. just change missile_1 to missile, i think
20170318 23:05:17< zookeeper> it was added in 19c78e87b45 if you're interested
20170318 23:06:11< zookeeper> i'll just write the spider lich animations in with offset=0 for now (as vyncyn had already done, i just removed it because it looked redundant, which led me to notice the problem with the macro)
20170318 23:06:36< celticminstrel> Ah, I see, it actually has two separate missile frames...
20170318 23:07:09< celticminstrel> I guess the engine looks specifically for "missile_frame", rather than for any frame prefixed with "missile_".
20170318 23:07:15< zookeeper> must be
20170318 23:07:23< zookeeper> anyway, if you do want to change that now then be my guest
20170318 23:07:27< zookeeper> but it's not really important
20170318 23:08:13< celticminstrel> I think it should probably be changed, but not sure if it should be changed right now. I guess it's not in 1.12 though...
20170318 23:08:21< celticminstrel> I thought it was, actually...
20170318 23:08:25< zookeeper> it's not in 1.12
20170318 23:08:33< irker064> wesnoth: Charles Dang wesnoth:master e60a10aa48be / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/e60a10aa48bebdfbeb060376c83a6bbf5131b0ab
20170318 23:08:50< vultraz_iOS> ^ just did it off the top of my head, might have missed some stuff
20170318 23:09:48< celticminstrel> Aww, you added the gh's to hilite. :P
20170318 23:10:24< vultraz_iOS> ...when does highlight not have gh O_O
20170318 23:10:40< celticminstrel> It's a common (if possibly not widely accepted) spelling.
20170318 23:10:49< celticminstrel> https://en.wiktionary.org/wiki/hilite
20170318 23:11:45< zookeeper> "[message]s no longer trigger a scroll if the unit is onscreen." <- if that's literally true then that's not good, because it sucks if the unit is behind the message and/or portrait.
20170318 23:11:46-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 23:11:47< matthiaskrgr> is it the informal spelling of hellolight? 
20170318 23:11:56< celticminstrel> Haha
20170318 23:12:25< celticminstrel> 1,084 commits since 1.13.6, huh...
20170318 23:12:28< vultraz_iOS> zookeeper: I actually did notice that earlier
20170318 23:12:34< vultraz_iOS> it will have to be dealt with
20170318 23:12:38< celticminstrel> Sounds like a pain to go through all of them.
20170318 23:12:39< vultraz_iOS> not sure *how*, though
20170318 23:13:40< zookeeper> don't you have access to the screen dimensions and the unit's position on it so you can check if it's somewhere near the middle?
20170318 23:14:01< celticminstrel> Oh yeah, there was the problem of making sure it's not covered by the dialog.
20170318 23:14:15< celticminstrel> The old [message] implementation had some sort of hack for that.
20170318 23:14:53< zookeeper> that's a fancy way of saying the new implementation has a regression :p
20170318 23:14:53-!- Alkenrinnstet__ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 23:14:57< vultraz_iOS> a + 1
20170318 23:15:06< celticminstrel> Yup.
20170318 23:15:10-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 260 seconds]
20170318 23:15:34< celticminstrel> But what vultraz mentioned in the changelog is a partial fix for the regression, so it's still an improvement.
20170318 23:18:16< celticminstrel> I'm now going to list some commits that might need a changelog entry. Some might already have one though.
20170318 23:18:21< irker064> wesnoth: Charles Dang wesnoth:master 0b3521824043 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): Preferences Dialog: fixed the hotkey list being unsorted when resetting hotkeys https://github.com/wesnoth/wesnoth/commit/0b3521824043db7719243f5abfd9753850bffaf9
20170318 23:18:22< celticminstrel> daefe8e
20170318 23:18:23-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 23:19:04< irker064> wesnoth: gfgtdf wesnoth:master b6694353b472 / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/b6694353b4723792baf95d512e4f22af919cfcfd
20170318 23:19:34< celticminstrel> (BTW, there have been no new or deleted files since the Xcode project update, right?)
20170318 23:19:53< vultraz_iOS> no
20170318 23:19:57< celticminstrel> cfc4c5c
20170318 23:20:10 * celticminstrel skipps everything SotA.
20170318 23:20:22< celticminstrel> ^-p
20170318 23:20:40< celticminstrel> adb5ef9 (not sure what it means)
20170318 23:20:57< vultraz_iOS> nope
20170318 23:20:59< celticminstrel> Pretty sure zk already added the new fake map edge...
20170318 23:21:42< celticminstrel> 61bac99
20170318 23:22:23< vultraz_iOS> nope
20170318 23:22:32< vultraz_iOS> introduced and fixed this cycle
20170318 23:22:58< celticminstrel> Did you look at all the ones I mentioned? You didn't respond to the first and possibly the second.
20170318 23:23:10< vultraz_iOS> first will add
20170318 23:23:11< vultraz_iOS> second invalid
20170318 23:23:43< celticminstrel> GUI2 hotkey bind dialog?
20170318 23:23:58< vultraz_iOS> not worth mentioning 
20170318 23:24:02< vultraz_iOS> primarily internal change
20170318 23:24:22< irker064> wesnoth: ln-zookeeper wesnoth:master 210c288216fe / data/campaigns/Under_the_Burning_Suns/ (15 files in 2 dirs): UtBS: New sprites and animations for Spider Lich by Vyncyn https://github.com/wesnoth/wesnoth/commit/210c288216fe5e2bde658e129718e4084e4cf90b
20170318 23:24:28< vultraz_iOS> or, i suppose i should add an entry
20170318 23:24:35< vultraz_iOS> since this is the c not the pc
20170318 23:24:38< celticminstrel> Does "fancy toggle panels" mean the ones with the line to the left when selected?
20170318 23:24:43< vultraz_iOS> yes
20170318 23:24:59< celticminstrel> I think zk mentioned the Witness sprites already...
20170318 23:25:44< celticminstrel> The bug about misordered side colors?
20170318 23:25:52< vultraz_iOS> alight
20170318 23:25:55< celticminstrel> Not sure if that's what 41647ce is, but that one made me remember it.
20170318 23:26:53< celticminstrel> Deprecation of {SOUND:POISON} and {SOUND_SLOW}
20170318 23:27:18< celticminstrel> b5113f4?
20170318 23:27:32-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170318 23:27:33< vultraz_iOS> ehh not worth
20170318 23:27:36< celticminstrel> 9f43913
20170318 23:27:41< vultraz_iOS> or.. 
20170318 23:27:48< vultraz_iOS> actually, it's a visible change
20170318 23:27:51< vultraz_iOS> so I'll mention it
20170318 23:27:58< celticminstrel> Heh, nice commit message 12a18e9 :P
20170318 23:29:37< celticminstrel> Don't remember adding c778a00 (which was me), but maybe I just forgot I added it.
20170318 23:29:57< celticminstrel> The changelog entry I mean. I do remember making the change.
20170318 23:31:13-!- Alkenrinnstet__ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170318 23:31:17< celticminstrel> e24336a
20170318 23:34:15< celticminstrel> Maybe f70a5f6?
20170318 23:34:45< celticminstrel> 8a69cf2?
20170318 23:35:04< celticminstrel> Pretty sure zk already mentioned f5f7821
20170318 23:35:36 * celticminstrel is also assuming that any campaign changes are covered.
20170318 23:36:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170318 23:36:46< zookeeper> 1c7ac5a3e
20170318 23:36:56-!- Alkenrinnstet_ is now known as Alkenrinnstet
20170318 23:38:36 * vultraz_iOS cries
20170318 23:38:39< vultraz_iOS> so many changelogs
20170318 23:38:50< celticminstrel> 0383e71? Might already be there...
20170318 23:39:15< celticminstrel> Maybe not worth it though...
20170318 23:39:27< zookeeper> anyway, i think i'm done, unless someone spots something i should have remembered to do.
20170318 23:40:14< celticminstrel> c823677?
20170318 23:40:47< celticminstrel> Is something like 309b04e even worth mentioning?
20170318 23:41:04< celticminstrel> (There should be two like that IIRC. ie two new item/scenery images)
20170318 23:41:12< vultraz_iOS> nope
20170318 23:43:24< celticminstrel> cbf1c50?
20170318 23:43:29< celticminstrel> Again, might not be worth it...
20170318 23:44:08< vultraz_iOS> stop stop stop
20170318 23:44:14< vultraz_iOS> that's it
20170318 23:44:16< celticminstrel> Almost done I think.
20170318 23:44:24< celticminstrel> Just passed the GUI2 rename.
20170318 23:44:37< celticminstrel> Yup, that appears to be everything.
20170318 23:44:51< irker064> wesnoth: Charles Dang wesnoth:master 9bd776517029 / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/9bd77651702927df8fa36e9b9f50efcfb8be9336
20170318 23:47:08< Shiki> the new spider lich images
20170318 23:48:05< celticminstrel> Those were committed?
20170318 23:48:49< celticminstrel> Ah, they were, huh.
20170318 23:50:06< celticminstrel> Well, presumably zookeeper can take care of that then. :P
20170318 23:50:15< celticminstrel> Unless vultraz_iOS is already in the middle of tagging.
20170318 23:50:26< celticminstrel> I guess technically this is an hour later than you intended... >_>
20170318 23:50:39< celticminstrel> Unless I got my timezones confused, which is totally possible since DST recently...
20170318 23:54:10< vultraz_iOS> nope, right on time
20170318 23:54:21< celticminstrel> Ah okay.
20170318 23:54:34< celticminstrel> DST clearly did confuse me then.
20170318 23:57:25< zookeeper> yeah i'll do one last quick changelog addition for the spider lich...
20170318 23:57:50< vultraz_iOS> already done
20170318 23:57:54< irker064> wesnoth: Charles Dang wesnoth:master 170ac1dac489 / changelog: Added changelog entry for Spider Lich sprites. https://github.com/wesnoth/wesnoth/commit/170ac1dac4898d1cf22e5528358784a63484df9f
20170318 23:57:57< irker064> wesnoth: Charles Dang wesnoth:master e315aa39e77c / Doxyfile changelog players_changelog projectfiles/Xcode/Info.plist src/wesconfig.h: Pre-release version bump https://github.com/wesnoth/wesnoth/commit/e315aa39e77c2d7fe88c28128307618d72c3904c
20170318 23:58:15< zookeeper> oh? okay then
20170318 23:58:50< vultraz_iOS> ANYTHING ELSE?
20170318 23:59:37< vultraz_iOS> we didn't really fill in P_C but meh
20170318 23:59:43< zookeeper> test that everything works? :p
--- Log closed Sun Mar 19 00:00:03 2017