--- Log opened Wed Mar 22 00:00:07 2017
20170322 00:12:47< vultraz_iOS> is your TC still broken?
20170322 00:15:51< celticminstrel> Oh uh... I haven't even built on the Mac in forever.
20170322 00:16:05< celticminstrel> Presumably I still can, once the XCode project is updated, though.
20170322 00:16:54< vultraz_iOS> oh right
20170322 00:16:57< vultraz_iOS> you're windows now
20170322 00:16:58< vultraz_iOS> derp
20170322 00:17:03< vultraz_iOS> it's funny
20170322 00:17:08< celticminstrel> Well, I'm still chatting from the Mac though.
20170322 00:17:22< vultraz_iOS> the entire main dev team is now on windows :P
20170322 00:17:23< celticminstrel> It's just that building Wesnoth pretty much takes over my computer and prevents me from doing much else.
20170322 00:17:32< celticminstrel> So I usually try to avoid it.
20170322 00:17:44< celticminstrel> Who do you consider to be the main dev team?
20170322 00:17:50< vultraz_iOS> I'm on windows
20170322 00:17:52< vultraz_iOS> you're on windows
20170322 00:17:56< vultraz_iOS> jyrki is on windows
20170322 00:17:58< vultraz_iOS> zookeeper is on windows
20170322 00:18:01< vultraz_iOS> gfgtdf is on windows
20170322 00:18:16< celticminstrel> You could've bundled that all up in a single line.
20170322 00:19:23< vultraz_iOS> Aginor is linux but he's not really involved anymore
20170322 00:19:47< vultraz_iOS> oh, and wedge009 is Windows and Linux
20170322 00:20:10< wedge009> What happened to Aginor? Busy?
20170322 00:20:25< vultraz_iOS> as I understand it
20170322 00:20:26< wedge009> Yes, I use Windows 7 and Linux, but primarily Windows.
20170322 00:20:34< wedge009> Hope he's okay.
20170322 00:20:38< vultraz_iOS> yeah
20170322 00:20:41< vultraz_iOS> hopefully
20170322 00:21:03< wedge009> What's the OS issue?
20170322 00:21:10< vultraz_iOS> at least he's around somewhat
20170322 00:21:16< vultraz_iOS> unlike iceiceice
20170322 00:21:22< vultraz_iOS> who has quit completely 
20170322 00:21:44< wedge009> It happens, that's why you called for help August 2015, right?
20170322 00:21:55< vultraz_iOS> yes. 
20170322 00:22:02< vultraz_iOS> we got some good devs from that
20170322 00:22:04< celticminstrel> Besides me, the only mac users are mattsc and ancestral, neither of whom are regularly around.
20170322 00:22:20< celticminstrel> If there was an "emergency" I could probably test something for you on the Mac.
20170322 00:22:22< wedge009> 11:17:28 am - vultraz_iOS: the entire main dev team is now on windows […]
20170322 00:22:25< wedge009> Wow, really?
20170322 00:22:27< vultraz_iOS> yes
20170322 00:23:01< wedge009> That's funny. I still build on Linux but mainly for checking and testing potential cross-platform issues.
20170322 00:23:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170322 00:23:29< celticminstrel> I've considered adding a second Mac build to Travis that runs an XCode build, but there are two problems with that.
20170322 00:23:34< vultraz_iOS> Windows is superior anyway :)
20170322 00:23:44< celticminstrel> 1. No-one ever updates the XCode project, so it would be regularly in a failing state.
20170322 00:23:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 00:23:49 * wedge009 isn't getting involved in that discussion
20170322 00:23:58< vultraz_iOS> I jest :P
20170322 00:24:09< celticminstrel> 2. Mac builds on Travis seem to take a lot longer than Windows builds.
20170322 00:24:14< celticminstrel> ^Linux
20170322 00:24:30< vultraz_iOS> I did hear recently from someone who sounded interested in contributing who's a mac user, he joined DIscord, and then I heard nothing
20170322 00:24:43< celticminstrel> Fun. Maybe he'll pop up again.
20170322 00:25:51< vultraz_iOS> I'm considering asking Jyrki if he'll take over Mac operations
20170322 00:27:03< vultraz_iOS> well, I might as well ask him
20170322 00:32:59< vultraz_iOS> fact is we *need* a mac dev.
20170322 00:37:22< celticminstrel> BTW, where's the 1.13.7 announcement draft?
20170322 00:37:26< celticminstrel> Is it up yet?
20170322 00:39:03< celticminstrel> Sudden thought about reported animation issues.
20170322 00:39:23< celticminstrel> Try moving line 340 of game_lua_kernel.cpp down to line 441.
20170322 00:44:02< celticminstrel> (IIRC someone reported animations simply continuing instead of reverting to the standing animation.)
20170322 00:46:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 00:46:45< vultraz_iOS> yes
20170322 00:46:47< vultraz_iOS> it's up
20170322 00:46:56< celticminstrel> ?
20170322 00:47:01< celticminstrel> Oh the draft.
20170322 00:47:28< zookeeper> oh wait i've forgotten to update release notes
20170322 00:47:43< vultraz_iOS> zookeeper: if you have something add it to the post
20170322 00:47:50< zookeeper> yeah
20170322 00:47:56< zookeeper> when are you posting it?
20170322 00:48:09< vultraz_iOS> ...same place as always?
20170322 00:48:11< vultraz_iOS> mods forum?
20170322 00:48:18< zookeeper> when
20170322 00:48:29< vultraz_iOS> oh
20170322 00:48:34< vultraz_iOS> you mean when am i announcing?
20170322 00:48:41< zookeeper> yeeeeeesss
20170322 00:48:49< vultraz_iOS> soon
20170322 00:48:56< zookeeper> when
20170322 00:48:57< vultraz_iOS> ancestral will have the mac package up today
20170322 00:49:00< vultraz_iOS> and i need screenshots
20170322 00:49:02< vultraz_iOS> so..
20170322 00:49:04< vultraz_iOS> today maybe?
20170322 00:49:13< zookeeper> what time is it?
20170322 00:49:19< vultraz_iOS> noon
20170322 00:49:28< zookeeper> okay
20170322 00:51:14< vultraz_iOS> we really need to get off sourceforge
20170322 00:51:55-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has quit [Quit: leaving]
20170322 00:52:03< celticminstrel> BTW vultraz_iOS, is Discord a web app or a downloaded client?
20170322 00:52:11< vultraz_iOS> both
20170322 00:54:28< wedge009> There are a few outstanding bug reports that I haven't touched because they seem to be OSX specific.
20170322 00:54:54< vultraz_iOS> wedge009: you wouldn't be interested in taking over Mac development would you
20170322 00:55:14< wedge009> Don't own any Apple products, don't want to waste money on them either.
20170322 00:55:18< celticminstrel> XD
20170322 00:55:31< vultraz_iOS> wedge009: the company could provide you with a macbook.
20170322 00:55:37< celticminstrel> Why do you need to get off sourceforge?
20170322 00:55:53< celticminstrel> Where would you go instead for file uploads?
20170322 00:55:57< celticminstrel> downloads, whatever
20170322 00:56:07< vultraz_iOS> dave wants us to use cloudflare hosting.
20170322 00:56:24< celticminstrel> Please no.
20170322 00:56:29< zookeeper> what
20170322 00:56:58< celticminstrel> AFAICT, CloudFlare is one of those things that requires cookies to even work.
20170322 00:57:29 * zookeeper is still waiting for the answer of why you need to get off sourceforge
20170322 00:57:30< wedge009> vultraz_iOS: Would probably be better off in the hands of someone more experienced in OSX stuff than I am.
20170322 00:57:33< zookeeper> s/of/for
20170322 00:57:54< vultraz_iOS> zookeeper: slow and clunky and they have a history of fucking with people's downloads.
20170322 00:58:09 * celticminstrel wants to get a new Mac regardless of Wesnoth work and probably will eventually; don't count on it in time for 1.14, mind you.
20170322 00:58:10< vultraz_iOS> but mostly slow
20170322 00:58:17< zookeeper> slow? i haven't noticed
20170322 00:58:19< celticminstrel> vultraz_iOS: AFAIK they stopped that with new management?
20170322 00:58:26< vultraz_iOS> yes
20170322 00:58:28< vultraz_iOS> but stil 
20170322 00:58:29< vultraz_iOS> slow
20170322 00:58:41< celticminstrel> Well, if you want to use cloudflare as a mirror, I won't object.
20170322 00:58:49< celticminstrel> ie, put everything on both cloudflare and sourceforge.
20170322 00:58:49< wedge009> I noticed FileZilla stopped bundling crap. Didn't know they changed management.
20170322 00:58:55< vultraz_iOS> celticminstrel:  y u no want to accept work laptop, then :(
20170322 00:59:37< zookeeper> certainly one can have more download locations. no need to rely on just one, naturally.
20170322 00:59:56< celticminstrel> But I will object to a switch to cloudflare exclusively.
20170322 01:00:15< celticminstrel> Probably the only place I wouldn't object to in that respect would be hosting them directly on Wesnoth's servers. :P
20170322 01:00:25< vultraz_iOS> why?
20170322 01:00:25< celticminstrel> I assume there's reasons why that can't happen though?
20170322 01:00:30< celticminstrel> Why what>
20170322 01:00:42< vultraz_iOS> why would that be the only thing you don;t object to
20170322 01:01:20< wedge009> Or object to, rather?
20170322 01:01:32< wedge009> Oh wait.
20170322 01:01:38< celticminstrel> Because it's always nicer when a website provides its downloads itself rather than outsourcing to some external download provider.
20170322 01:01:43< wedge009> Yes.
20170322 01:01:54< celticminstrel> But I wouldn't necessarily object to all other alternatives to the same extent as I would object to cloudflare.
20170322 01:04:42< vultraz_iOS> celticminstrel: btw, what the new AP dialog looks like: https://1drv.ms/i/s!As9hRC_GxjKKpFbiV2nQjcrVxjB3
20170322 01:05:46< celticminstrel> I did like the gradient effect of the old bars, but nevertheless this looks wuite nice.
20170322 01:06:28< celticminstrel> ^quite
20170322 01:06:53< celticminstrel> Something doesn't seem quite right though somehow...
20170322 01:07:19< vultraz_iOS> hm?
20170322 01:08:24< wedge009> Heh, flat-shaded, like all 'modern' stuff. XD
20170322 01:08:47< wedge009> I also liked the gradient effect, but this is okay as well.
20170322 01:08:52< celticminstrel> wedge009: Not necessarily intentional; GUI2 canvas just doesn't support gradients.
20170322 01:09:10< wedge009> Yeah, I vaguely recall something along those lines.
20170322 01:09:16< wedge009> Whatever works.
20170322 01:09:19< wedge009> It's still functional.
20170322 01:09:25< vultraz_iOS> celticminstrel, wedge009: the gradient effect was actually achieved by drawing 4 rectangles on top of each other at gradually decreasing sizes
20170322 01:09:32< celticminstrel> Oh fun!
20170322 01:09:32< wedge009> Oh? Ew.
20170322 01:09:41< wedge009> Okay, this is better then!
20170322 01:09:43< vultraz_iOS> I could do the same, but when I tried to replicate the functionality of blend_rgba I got puple bars :|
20170322 01:09:49< wedge009> Whee!
20170322 01:09:52< celticminstrel> So you could reproduce it with canvas, but... 
20170322 01:10:36< vultraz_iOS> yes
20170322 01:10:37< pydsigner> Math is hard, let's go shopping
20170322 01:11:05< celticminstrel> Why is the 70% not labelled?
20170322 01:11:16< celticminstrel> I realize this isn't new, but still.
20170322 01:11:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170322 01:11:23< vultraz_iOS> eh?
20170322 01:11:26< celticminstrel> What's with the Modifiers field?
20170322 01:11:45< vultraz_iOS> oh, i'm still working on that
20170322 01:11:55< vultraz_iOS> I did that when I was trying to get unified field labels
20170322 01:12:00< celticminstrel> What's the base damage and why is it different from anything in total damage?
20170322 01:12:12< vultraz_iOS> base damage is the base attack damage
20170322 01:12:20< celticminstrel> Meaning...?
20170322 01:12:20< vultraz_iOS> total is that modified by the modifiers
20170322 01:12:26< celticminstrel> Ah, okay.
20170322 01:12:48< vultraz_iOS> I still have improvements to do
20170322 01:12:57< vultraz_iOS> some of the modifier fields didnt get ported
20170322 01:13:01< celticminstrel> And 70% is chance to hit?
20170322 01:13:07< vultraz_iOS> yes
20170322 01:14:34< celticminstrel> "Total damage: 13×5 (70% CTH)"
20170322 01:14:43< celticminstrel> Or...
20170322 01:15:06< celticminstrel> "Total damage: 13×5"
20170322 01:15:07< celticminstrel> "Chance to hit: 70%"
20170322 01:15:26< vultraz_iOS> yes
20170322 01:15:29< vultraz_iOS> considering that
20170322 01:15:33< vultraz_iOS> again, not done yet
20170322 01:15:41< celticminstrel> So what does it look like with multiple modifiers?
20170322 01:15:57< vultraz_iOS> I haven't implemented the other ones yet
20170322 01:16:06< celticminstrel> IOW, you don't know yet, okay.
20170322 01:16:37< celticminstrel> What about "Base damage     9 (shadow wave)"
20170322 01:16:49-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:181c:f757:9532:832e] has quit [Ping timeout: 246 seconds]
20170322 01:16:57< celticminstrel> Similarly "×1.5 (arcane)"
20170322 01:17:04< vultraz_iOS> again, working on it
20170322 01:17:05< celticminstrel> Just an idea.
20170322 01:17:25< celticminstrel> I like how it's colourful though, unlike the old one.
20170322 01:17:40< celticminstrel> Or at least, unlike the screenshot I found of the old one. >_>
20170322 01:17:47< celticminstrel> Maybe it was colourful.
20170322 01:17:53< celticminstrel> Either way, I like how it's colourful.
20170322 01:18:02< vultraz_iOS> the old one was not colorful
20170322 01:18:33< celticminstrel> Random unrelated idea: show how many moves the attack will consume.
20170322 01:18:45< celticminstrel> (Presumably in the attack dialog, not the prediction dialog.)
20170322 01:18:55< irker434> wesnoth: Charles Dang wesnoth:master a3cd8224f61d / src/sdl/ (utils.cpp utils.hpp): Removed now-unused blend_rgba function https://github.com/wesnoth/wesnoth/commit/a3cd8224f61d58b83b3c618b5a516e848280f787
20170322 01:22:39< zookeeper> mmkay, added my release notes to the thread
20170322 01:22:53< gfgtdf> considering that most attacks consume all moves and the most players not know about that beeing variable, i reccomend onyl display that if it differs from  the default value (all)
20170322 01:23:22< gfgtdf> even better, instead of showing how muhc muves it consumbes, show how many moves will be left after attacking+moving
20170322 01:23:33< gfgtdf> much moves*
20170322 01:25:13< zookeeper> who's said anything about displaying moves?
20170322 01:25:22< zookeeper> oh right
20170322 01:25:31< zookeeper> it was on the only line i failed to read, apparently
20170322 01:26:36< zookeeper> yes, that seems like a very random idea if no one can actually think of why someone would want it
20170322 01:26:37< celticminstrel> gfgtdf: I had considered that, yeah.
20170322 01:26:57< celticminstrel> zookeeper: It really is just a random idea that suddenly popped into my head, so... *shrug*
20170322 01:27:19< celticminstrel> gfgtdf: Oh wait, showing moves left after attacking does seem even better.
20170322 01:27:42< celticminstrel> In which case "only if there are moves left" would be best.
20170322 01:27:54< gfgtdf> ye
20170322 01:29:10< celticminstrel> vultraz_iOS: You should consider whether to mention some of the other new Lua/WML features in the release notes.
20170322 01:29:25< vultraz_iOS> hm?
20170322 01:29:26< vultraz_iOS> which?
20170322 01:29:40< celticminstrel> Not sure off the top of my head. That's why I said "consider".
20170322 01:31:15< gfgtdf> you shodul also metion possible deprecatiosn and barking changes liek the deprecatoin of those attack soudn macors or the renaming of adv_type_tree
20170322 01:31:42< celticminstrel> Maybe the new things for Lua side proxy objects, or the new argument for scroll_to_tile?
20170322 01:32:04< celticminstrel> Maybe some of the WML changes, though none of them seem huge.
20170322 01:32:30< zookeeper> you don't need to mention silent deprecations in release notes
20170322 01:33:06< zookeeper> add-on authors/maintainers are supposed to actually read the changelogs, after all, not just the main release notes
20170322 01:33:52< celticminstrel> Well, the type_tree change isn't silent, though I doubt many people would have used it since it has only been in one release. Still, I could add it anyway if you think it's worthwhile?
20170322 01:34:55< gfgtdf> ye it was ina  relaeses version and it breaks code for people that migth ahve used it, i don't really know how maybe poeple develop for 1.13 these days but i think its bette to notice it.
20170322 01:35:58< zookeeper> for what it's worth, type_tree isn't used in any 1.13 add-on
20170322 01:36:41< zookeeper> but yes, certainly do mention all deprecations that people actually need to know about sooner or later
20170322 01:36:54< celticminstrel> Well, someone could've used it in an as-yet-unreleased addon though.
20170322 01:37:57< gfgtdf> zookeeper: i don't think we cna require wml authors to read the changelog for updating their addons to a newer version, even just the changelog form 1.12 to 1.13.7 it 1800 lines of text.
20170322 01:38:24< celticminstrel> Well, they can generally just scan for the Lua and WML headers though.
20170322 01:38:54< zookeeper> gfgtdf, apples and oranges
20170322 01:39:59< zookeeper> they're not going to update their add-on while reading through a pile of old release announcements either
20170322 01:41:00< celticminstrel> It'd actually be easier for them to look through the changelog, since it's all on one page.
20170322 01:41:10< gfgtdf> zookeeper: well yes they coudl, or we could coudl do that and have a summary of comabiltiy changes from 1.13 RN in the 1.14 RN.
20170322 01:41:41< zookeeper> may i remind everyone that https://forums.wesnoth.org/viewtopic.php?f=16&t=44957 is a thing
20170322 01:42:22< celticminstrel> Speaking of which, I was thinking the weapon name changes should maybe go there?
20170322 01:43:11< celticminstrel> I assume things that were added in 1.13.x and later removed don't need to be included.
20170322 01:43:18< zookeeper> that's all that authors are supposed to eventually need in order to port from 1.12 to 1.13/1.14, and i'd hope people would update it at a bit faster pace. i'm sure it doesn't list anywhere near everything it should.
20170322 01:43:33< zookeeper> and yes, the weapon name changes would fit there
20170322 01:43:42< zookeeper> and yes
20170322 01:44:19< wedge009> zookeeper: 'You are not authorised to read this forum.'
20170322 01:44:22< wedge009> What is it?
20170322 01:44:24< celticminstrel> Oh, but only if there were weapon name changes in core units, right? The changes that affected campaign units don't matter.
20170322 01:44:46< celticminstrel> wedge009: "Compatibility-breaking changes between 1.12 and 1.13"
20170322 01:44:54< wedge009> Oh right.
20170322 01:44:59 * celticminstrel wonders if we should give wedge009 a red name...
20170322 01:45:07< gfgtdf> unrelated issue: i want to add a lua getter/setter for [scenario] diallow_recall= but i wonder whether i shoudl make it side spcific or a scneario_global setting, any opinios?
20170322 01:45:08< wedge009> Nah. I
20170322 01:45:13< wedge009> 'm hardly on the forums.
20170322 01:45:15< zookeeper> wedge009, eh, you're not flagged as a developer on the forums? easy to change
20170322 01:45:57< zookeeper> gfgtdf, sounds like a pretty side-specific thing
20170322 01:46:15< wedge009> I'm a 'code contributer'
20170322 01:46:43< celticminstrel> zookeeper: But it seems to be set in the scenario ATM, rather than the side.
20170322 01:47:08< zookeeper> wedge009, but you do have push access, don't you?
20170322 01:47:13< wedge009> Yes.
20170322 01:53:03< zookeeper> okay, you should be in the group now
20170322 01:53:23< wedge009> Okay, thanks.
20170322 01:54:15< zookeeper> although i don't know how to change the title
20170322 01:56:11< zookeeper> oh right, should have probably set the group as the default
20170322 01:57:30< zookeeper> there we go
20170322 01:57:43 * zookeeper goes to fall asleep
20170322 01:58:47-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has joined #wesnoth-dev
20170322 02:03:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20170322 02:04:02-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has quit [Quit: ancestral]
20170322 02:19:00-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has joined #wesnoth-dev
20170322 02:26:24-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has quit [Quit: ancestral]
20170322 02:27:28-!- prkc [~prkc@da.85.7a9f.ip4.static.sl-reverse.com] has quit [Ping timeout: 240 seconds]
20170322 02:29:40-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has joined #wesnoth-dev
20170322 02:31:17-!- travis-ci [~travis-ci@ec2-54-82-95-13.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 02:31:18< travis-ci> gfgtdf/wesnoth#745 (game_data - 28e1ba0 : gfgtdf): The build has errored.
20170322 02:31:18< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/213662005
20170322 02:31:18-!- travis-ci [~travis-ci@ec2-54-82-95-13.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 02:33:22< vultraz_iOS> ...why is #arg not working here
20170322 02:34:37< celticminstrel> ?
20170322 02:34:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 02:34:45< celticminstrel> As in, the length operator?
20170322 02:35:59< vultraz_iOS> zookeepe's preprocessor thingy
20170322 02:36:45< vultraz_iOS> does not work in GUI2WML
20170322 02:39:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 02:39:22< celticminstrel> Um... maybe you're using it wrong?
20170322 02:39:28< vultraz_iOS> don't think so..
20170322 02:39:58< celticminstrel> BTW, did you try that line move I proposed regarding animations?
20170322 02:40:02< vultraz_iOS> https://www.irccloud.com/pastebin/lg28dxQA/
20170322 02:40:17< vultraz_iOS> error about arg numbers
20170322 02:43:47< celticminstrel> Who was it who reported something about animations not ending? Was that wedge009?
20170322 02:43:59< wedge009> Not me, I don't think.
20170322 02:44:07< celticminstrel> vultraz_iOS: So what's the error?
20170322 02:44:27< celticminstrel> BTW, I'd say endarg should be on the same line.
20170322 02:44:31< vultraz_iOS> wrong number of args when called with 3
20170322 02:45:27< vultraz_iOS> er
20170322 02:45:27< vultraz_iOS> 4
20170322 02:47:13< irker434> wesnoth: Charles Dang wesnoth:master 1387a647c3d0 / data/gui/window/attack_predictions.cfg src/gui/dialogs/attack_predictions.cpp: Attack Predictions: added rest of the modifier fields and improved data readabil https://github.com/wesnoth/wesnoth/commit/1387a647c3d002a2a342dedfc32ccde41f559feb
20170322 02:48:56< celticminstrel> "resis"
20170322 02:49:21< celticminstrel> Too lazy to even include the T!?
20170322 02:49:26< vultraz_iOS> :P
20170322 02:49:32< celticminstrel> 9_9
20170322 02:49:59< vultraz_iOS> :3
20170322 02:50:34< matthiaskrgr> nobody got time for the T 
20170322 02:50:42< celticminstrel> Definition: https://github.com/wesnoth/wesnoth/blob/master/data/core/terrain-graphics/new-macros.cfg#L46 Use: https://github.com/wesnoth/wesnoth/blob/master/data/core/terrain-graphics.cfg#L352
20170322 02:51:26< celticminstrel> As far as I can see, your definition is correct...
20170322 02:51:51< vultraz_iOS> OH
20170322 02:52:04< celticminstrel> Was it the call that was the problem?
20170322 02:52:20< vultraz_iOS> yes
20170322 02:52:59< vultraz_iOS> oh, blah, some layout trouble with the hidden fields..
20170322 02:53:25-!- gfgtdf_ [~chatzilla@x4e32b1de.dyn.telefonica.de] has joined #wesnoth-dev
20170322 02:55:08-!- gfgtdf [~chatzilla@x4e36aca7.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170322 02:55:19-!- gfgtdf_ is now known as gfgtdf
20170322 02:57:32< irker434> wesnoth: Charles Dang wesnoth:master 6520c7c81e14 / data/gui/window/attack_predictions.cfg: Attack Predictions: fixup use of default arg syntax https://github.com/wesnoth/wesnoth/commit/6520c7c81e1418664fba03d31801dea1711c77b5
20170322 03:02:43< celticminstrel> You forgot to remove the fixme comment. :P
20170322 03:04:32< irker434> wesnoth: Charles Dang wesnoth:master 26d4e55500e3 / data/gui/window/attack_predictions.cfg: Attack Predictions: temp fix to keep data values aligned with labels https://github.com/wesnoth/wesnoth/commit/26d4e55500e34bb45d99651a151c58613f2989ef
20170322 03:05:37< irker434> wesnoth: Charles Dang wesnoth:master faaf3119818a / data/gui/window/attack_predictions.cfg: Removed a FIXME https://github.com/wesnoth/wesnoth/commit/faaf3119818a160c9964ba55e93680be58a25d6e
20170322 03:07:09< vultraz_iOS> celticminstrel: https://1drv.ms/i/s!As9hRC_GxjKKpFbiV2nQjcrVxjB3
20170322 03:07:14< vultraz_iOS> still need to fix the alignment
20170322 03:07:29< vultraz_iOS> and need to color-format the modifiers
20170322 03:07:32< vultraz_iOS> but mostly done now
20170322 03:07:43< celticminstrel> Looks good.
20170322 03:08:16< celticminstrel> I'm guessing the graph frame size is based on the max bars?
20170322 03:08:30< vultraz_iOS> graph size is fixed
20170322 03:08:37< vultraz_iOS> to accommodate max bars
20170322 03:09:02< vultraz_iOS> which is 10 
20170322 03:13:55< wedge009> Have you tested with drain attacks? They give many more HP results (bars) than normal attacks.
20170322 03:14:44< vultraz_iOS> the list is forcibly truncated 
20170322 03:15:05< wedge009> Okay.
20170322 03:15:20 * wedge009 wonders if that could be a problem for some players.
20170322 03:16:09< matthiaskrgr> Condition '!must_exist || result' failed at ../src/gui/auxiliary/find_widget.hpp:75 in function 'find_widget'.
20170322 03:16:12< vultraz_iOS> what the code does is fetch the probability for every single hp value
20170322 03:16:24< vultraz_iOS> from 0 to max
20170322 03:16:33< vultraz_iOS> then sort by percentage change
20170322 03:16:40< vultraz_iOS> take the top 10 most likely
20170322 03:16:46< vultraz_iOS> then sort by hp value)
20170322 03:16:49< vultraz_iOS> s/)//
20170322 03:17:06< vultraz_iOS> s/sort/sorts
20170322 03:17:31< vultraz_iOS> matthiaskrgr: latest latest master?
20170322 03:18:35< celticminstrel> Ah, that's why the previous version had some super-low probabilities mixed in...?
20170322 03:18:41< matthiaskrgr> vultraz_iOS: yes
20170322 03:18:48< vultraz_iOS> what condition?
20170322 03:18:51< vultraz_iOS> celticminstrel: yes
20170322 03:18:56< matthiaskrgr> it happens in wesnoth -t when attacking the orcish archer with the footpad
20170322 03:19:13< matthiaskrgr> lightningstrike (footpad) vs archer (none) prediction
20170322 03:20:23< matthiaskrgr> its that "very long" attack type probably
20170322 03:20:39< vultraz_iOS> huh
20170322 03:20:48< vultraz_iOS> this Error message doesn't show in nondebug mode
20170322 03:20:49< vultraz_iOS> how nice
20170322 03:20:49< wedge009> vultraz_iOS: Ten most likely sounds good. Just wonder if anyone will complain that percentages don't add to 100%.
20170322 03:20:58< vultraz_iOS> heh
20170322 03:20:59< wedge009> Unless you have top 9 and tenth one is 'other'
20170322 03:21:14< matthiaskrgr> ah no, it just happens when the attacker cannot counter it seems
20170322 03:21:19< matthiaskrgr> anyway gotta run o/ 
20170322 03:21:20< vultraz_iOS> it also discards any option less than 0.1%
20170322 03:22:04< wedge009> Sounds reasonable.
20170322 03:23:32-!- travis-ci [~travis-ci@ec2-54-147-54-125.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 03:23:33< travis-ci> wesnoth/wesnoth#13041 (master - 1387a64 : Charles Dang): The build was broken.
20170322 03:23:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213679228
20170322 03:23:33-!- travis-ci [~travis-ci@ec2-54-147-54-125.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 03:23:47< celticminstrel> :O
20170322 03:25:09< irker434> wesnoth: Charles Dang wesnoth:master 80d8b99c0444 / src/gui/dialogs/attack_predictions.cpp: Attack Predictions: fixed display of dialog for no-attacks-available combatants https://github.com/wesnoth/wesnoth/commit/80d8b99c044431175c53d27354324f407cb7c43e
20170322 03:26:13< vultraz_iOS> matthiaskrgr: ^
20170322 03:27:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170322 03:28:22< irker434> wesnoth: Charles Dang wesnoth:master 8654079ba539 / src/gui/dialogs/attack_predictions.cpp: Attempt to satisfy travis https://github.com/wesnoth/wesnoth/commit/8654079ba53977388da3ba69a34be59f4c935725
20170322 03:31:23-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 03:44:08-!- Yaiyan is now known as Ieuan
20170322 03:44:41-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 03:44:42< travis-ci> wesnoth/wesnoth#13042 (master - 6520c7c : Charles Dang): The build was broken.
20170322 03:44:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213681310
20170322 03:44:42-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 03:48:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 03:51:18-!- gfgtdf [~chatzilla@x4e32b1de.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.1/20170316213829]]
20170322 03:52:47< vultraz_iOS> Can anyone take some screenshots for the release?
20170322 03:52:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 03:52:58< celticminstrel> Oh screenshots.
20170322 03:52:59< vultraz_iOS> wedge009 perhaps?
20170322 03:53:02< vultraz_iOS> r you?
20170322 03:53:03< vultraz_iOS> or*
20170322 03:53:12< vultraz_iOS> need 2 - 4.
20170322 03:53:26< vultraz_iOS> at 1280x768
20170322 03:53:30< celticminstrel> I suppose I probably could if I downloaded the release, huh...
20170322 03:53:45< celticminstrel> At the moment though I'm just about ready for bed.
20170322 03:53:55< celticminstrel> Though still 8h behind on Twitter... >_>
20170322 03:54:04< vultraz_iOS> I can't do it since as you've probably noticed, even though wesnoth displays as scaled down, screenshots display are native res
20170322 03:54:17< celticminstrel> Huh?
20170322 03:54:18< vultraz_iOS> Just4KScreenThings
20170322 03:54:59< vultraz_iOS> celticminstrel: if I take a screenshot of wesnoth running at 1280x768, the resulting picture will be twice that or something
20170322 03:55:19< vultraz_iOS> celticminstrel: if you're heading out I'll find someone else
20170322 03:58:59< wedge009> vultraz_iOS: What kind of screenshots?
20170322 03:59:08< wedge009> At 1280x768?
20170322 03:59:16< vultraz_iOS> uhh... need one of the new addon manager...
20170322 03:59:20< vultraz_iOS> and uh..
20170322 03:59:22< vultraz_iOS> one of sota
20170322 03:59:27< vultraz_iOS> one of... the new wall terrains
20170322 03:59:41< vultraz_iOS> that's enough
20170322 03:59:53< wedge009> Which one is the new wall terrain? :S I'll start on the first two.
20170322 04:00:05< vultraz_iOS> the wooden walls I think
20170322 04:00:15< celticminstrel> vultraz_iOS: Where are they used?
20170322 04:00:43< vultraz_iOS> celticminstrel: the walls?
20170322 04:00:48< vultraz_iOS> or the sceenshots
20170322 04:00:53< celticminstrel> ...though I suppose there's always the option of showing them as an editor screenshot.
20170322 04:00:56< celticminstrel> The walls.
20170322 04:01:34< vultraz_iOS> nowhere yet
20170322 04:02:10< celticminstrel> If you're doing an editor screenshot with the walls, you might as well throw in some lava and volcano. :P
20170322 04:02:42< vultraz_iOS> ah right
20170322 04:02:44< vultraz_iOS> wedge009: ^
20170322 04:02:55< vultraz_iOS> sexy new lava
20170322 04:03:39< celticminstrel> The new walls aren't mentioned in the release notes BTW.
20170322 04:04:00-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 04:04:01< travis-ci> wesnoth/wesnoth#13043 (master - 26d4e55 : Charles Dang): The build was broken.
20170322 04:04:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213682708
20170322 04:04:01-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 04:05:49-!- JyrkiVesterinen [~JyrkiVest@87-100-153-119.bb.dnainternet.fi] has joined #wesnoth-dev
20170322 04:12:26< JyrkiVesterinen> 20170321 23:24:42< vultraz_iOS> Jyrki: performance increase confirmed, but it looks like the description scroll label can get progressively smaller (both h and w)
20170322 04:12:31< JyrkiVesterinen> Can't reproduce.
20170322 04:13:00< vultraz_iOS> JyrkiVesterinen: try paging down the addons list and watch the description field
20170322 04:13:03< vultraz_iOS> that's what I did
20170322 04:13:12< vultraz_iOS> it starts once a scrollbar appears
20170322 04:13:29< vultraz_iOS> and then compounds ever time a scollbar resize happens
20170322 04:15:29< JyrkiVesterinen> Okay, I see. It indeed starts when a scrollbar appears. Previously I only tested with descriptions which are too small to trigger the scrollbar.
20170322 04:15:38< JyrkiVesterinen> I'll investigate later this week.
20170322 04:22:46< celticminstrel> Huh, apparently there now exist more unicode emoji than my computer supports.
20170322 04:23:02-!- celticminstrel is now known as celmin|sleep
20170322 04:26:01-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 04:26:02< travis-ci> wesnoth/wesnoth#13044 (master - faaf311 : Charles Dang): The build was broken.
20170322 04:26:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213682883
20170322 04:26:02-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 04:28:01< vultraz_iOS> why is travis ignoring [ci_skip]
20170322 04:28:47< wedge009> Is it [ci skip] or [ci_skip]?
20170322 04:29:10< vultraz_iOS> i used the latter
20170322 04:29:12< vultraz_iOS> is it the former?
20170322 04:30:12< wedge009> I was told it's the former. :/
20170322 04:30:22< wedge009> Also, just read your earlier remarks of native resolution.
20170322 04:30:32< wedge009> Mine is 2560x1440. Is that going to be a problem for screenshots?
20170322 04:30:44< vultraz_iOS> ah...
20170322 04:30:46< vultraz_iOS> probably :|
20170322 04:30:55< wedge009> Probably going to be a problem?
20170322 04:31:09< vultraz_iOS> yes
20170322 04:32:24< wedge009> Is there a specific screenshot function in Wesnoth? I was just using Windows' screen capture.
20170322 04:32:26< ancestral> Can’t build translations, so I’ll copy from the Windows package :-\
20170322 04:32:42< wedge009> Pfft, emojis.
20170322 04:33:04 * vultraz_iOS closes out a few zoom-related FRs
20170322 04:33:24-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has quit [Quit: ancestral]
20170322 04:35:08-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has joined #wesnoth-dev
20170322 04:35:45 * wedge009 is having a major storm move in. May have to leave in a hurry.
20170322 04:40:01 * wedge009 compares 1280x800 windowed on Windows and 1280x800 full screen on Linux
20170322 04:40:04< wedge009> Looks quite similar.
20170322 04:44:08-!- travis-ci [~travis-ci@ec2-54-147-54-125.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 04:44:09< travis-ci> wesnoth/wesnoth#13045 (master - 80d8b99 : Charles Dang): The build is still failing.
20170322 04:44:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213686149
20170322 04:44:09-!- travis-ci [~travis-ci@ec2-54-147-54-125.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 04:46:00< wedge009> Add-ons manager needs scroll bars at 1280 :/
20170322 04:48:07< irker434> wesnoth: Charles Dang wesnoth:master ae76bb0efbc5 / src/gui/widgets/scroll_label.cpp: Scroll Label: removed hack to try to keep width consistent on setting value https://github.com/wesnoth/wesnoth/commit/ae76bb0efbc53f102cc772ace3941c5867e2c91c
20170322 04:50:52< vultraz_iOS> wedge009: D:
20170322 04:50:55< vultraz_iOS> crap
20170322 04:50:59< vultraz_iOS> well that won't do..
20170322 05:01:08< wedge009> vultraz_iOS: Can you use this? https://wedge009.net/miscellaneous/sota.zip
20170322 05:12:51< vultraz_iOS> wedge009: indeed, that is good
20170322 05:13:05< wedge009> Do you still want the Add-ons one?
20170322 05:13:10< wedge009> With the scroll bar?
20170322 05:13:28< vultraz_iOS> we can't have one with a scroll bar, sadly ;_;
20170322 05:13:56< JyrkiVesterinen> So we aren't going to have a screenshot about the add-on manager at all?
20170322 05:15:05< wedge009> Which walls got redesigned?
20170322 05:15:23< vultraz_iOS> uhh... just use lava, the white walls, and the straight wooden walls mixed with the mine walls
20170322 05:16:34-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170322 05:16:39< vultraz_iOS> JyrkiVesterinen: looks like not
20170322 05:16:57-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 05:19:10< vultraz_iOS> oh, the Statistics Dialog was 1.13.7...
20170322 05:19:19< vultraz_iOS> and we forgot to mention it
20170322 05:19:20< vultraz_iOS> :(
20170322 05:20:16-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 05:22:14-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 240 seconds]
20170322 05:28:25< wedge009> vultraz_iOS: Might not be what you're after, but this is the best I could manage from your descriptions https://wedge009.net/miscellaneous/editor.zip
20170322 05:29:29< vultraz_iOS> that works
20170322 05:30:31-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 05:30:32< travis-ci> wesnoth/wesnoth#13046 (master - 8654079 : Charles Dang): The build was fixed.
20170322 05:30:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213686913
20170322 05:30:32-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 05:31:08< JyrkiVesterinen> ^ Great. :)
20170322 05:31:50-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 05:32:18< vultraz_iOS> wedge009: let's just get a shot of the statistics dialog and that's enough
20170322 05:33:27-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Ping timeout: 240 seconds]
20170322 05:34:06-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:ecf5:a85a:d633:1f15] has joined #wesnoth-dev
20170322 05:38:58-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:ecf5:a85a:d633:1f15] has quit [Ping timeout: 246 seconds]
20170322 06:09:24-!- travis-ci [~travis-ci@ec2-54-82-95-13.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 06:09:25< travis-ci> wesnoth/wesnoth#13047 (master - ae76bb0 : Charles Dang): The build was fixed.
20170322 06:09:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/213701808
20170322 06:09:25-!- travis-ci [~travis-ci@ec2-54-82-95-13.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 06:10:03-!- Kwandulin [~Kwandulin@p200300760F3E7D44DCC37EE099405F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 06:12:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 06:15:34< vultraz_iOS> wedge009: if a third is too much trouble, 2 is enough
20170322 06:17:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 06:17:57< wedge009> vultraz_iOS: Sorry, just had a shower. Working on it now.
20170322 06:18:53< wedge009> Do you want the whole window, or just the dialogue?
20170322 06:19:21< vultraz_iOS> a whole window with the dialog open
20170322 06:19:45< vultraz_iOS> wedge009: see if you can get some stats from a sota save
20170322 06:19:50< wedge009> Yep.
20170322 06:24:40< wedge009> vultraz_iOS: https://wedge009.net/miscellaneous/statistics.zip
20170322 06:29:29< vultraz_iOS> wedge009: thanks :)
20170322 06:40:59< vultraz_iOS> agh
20170322 06:41:00< vultraz_iOS> fuck
20170322 06:41:11< vultraz_iOS> shadowm has pointed out at some point we screwed up text rendering
20170322 06:41:17< vultraz_iOS> wedge009: your font is green :|
20170322 06:41:31< wedge009> Where?
20170322 06:41:38< vultraz_iOS> in your shots
20170322 06:41:41< vultraz_iOS> it has green tint
20170322 06:42:08< wedge009> Oh, the text?
20170322 06:42:15< wedge009> It's supposed to be white...
20170322 06:42:24< wedge009> Honestly, I didn't notice it till you said so.
20170322 06:42:34< wedge009> What do you want to do?
20170322 06:43:11< vultraz_iOS> leave it for now
20170322 06:43:17< vultraz_iOS> we need to figure out what the hell went wrong
20170322 06:43:21< vultraz_iOS> and fix it soon
20170322 06:43:32< wedge009> Is this from when you changed the Cairo rendering for Windows?
20170322 06:43:49< vultraz_iOS> no..d
20170322 06:43:51< vultraz_iOS> ont' think so
20170322 06:44:25< JyrkiVesterinen> Maybe https://github.com/wesnoth/wesnoth/pull/937 ?
20170322 06:44:48< vultraz_iOS> that's gui1
20170322 06:45:06< vultraz_iOS> shadowm says "don't use TGB subpixel hinting on arbitrary surfaces"
20170322 06:45:09< vultraz_iOS> RGB*
20170322 06:46:57< vultraz_iOS> but I odn't know where we'e doing that
20170322 06:52:16-!- JyrkiVesterinen [~JyrkiVest@87-100-153-119.bb.dnainternet.fi] has quit [Quit: .]
20170322 06:52:23< wedge009> Looks okay in Linux. Letters seem 'thicker', the letter strokes on Windows seem to be only a pixel wide, presumably activating the hinting that's causing the green tint.
20170322 06:57:39-!- vultraz_iOS changed the topic of #wesnoth-dev to: Discord Server: https://discord.gg/tSmJS2E | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170322 06:58:19< vultraz_iOS> done!
20170322 06:58:24< vultraz_iOS> loonycyborg: could you update the front page?
20170322 06:58:51< vultraz_iOS> loonycyborg: text https://forums.wesnoth.org/viewtopic.php?f=62&t=45176
20170322 07:11:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170322 07:12:22-!- ancestral [~anonymous@174-30-240-190.mpls.qwest.net] has quit [Quit: ancestral]
20170322 07:13:57< Kwandulin> Wheee, the add-on manager looks great
20170322 07:15:10-!- atarocch [~atarocch@93.68.142.209] has joined #wesnoth-dev
20170322 07:24:34-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170322 07:25:43< vultraz_iOS> :D
20170322 07:31:18< JyrkiVesterinen> Regarding the IRC channel topic, I think it would be best if the "Wesnoth Developers Channel" part was first.
20170322 07:43:16-!- Appleman1234 [~Appleman1@pl14773.ag1212.nttpc.ne.jp] has quit [Ping timeout: 258 seconds]
20170322 07:57:04-!- Appleman1234 [~Appleman1@pl2224.nas82f.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170322 08:00:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 08:05:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 08:07:33-!- vultraz_iOS changed the topic of #wesnoth-dev to: Wesnoth Developers Channel | Discord Server: https://discord.gg/tSmJS2E |  >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170322 08:08:15< JyrkiVesterinen> Thanks! :)
20170322 08:10:15-!- prkc [~prkc@46.166.138.153] has joined #wesnoth-dev
20170322 08:12:27-!- Appleman1234 [~Appleman1@pl2224.nas82f.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170322 08:25:35-!- vultraz_iOS changed the topic of #wesnoth-dev to: Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170322 08:40:02-!- Kwandulin [~Kwandulin@p200300760F3E7D44DCC37EE099405F6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170322 08:47:21< loonycyborg> vultraz_iOS: You're confusing me with someone. I don't even know how to update front page and don't even have access to relevant vm
20170322 08:47:36< vultraz_iOS> oh
20170322 08:47:39< vultraz_iOS> sorry 
20170322 08:50:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170322 08:52:33< vultraz_iOS> could Soliton?
20170322 08:52:59< Soliton> i suppose.
20170322 09:00:51< loonycyborg> who was usually doing that? shadowm?
20170322 09:02:09< vultraz_iOS> yes
20170322 09:02:31< vultraz_iOS> except this time he was on his way out and said "Your actual release technician did it last time and also has access to the MP server VM, I'm sure you can figure something out."
20170322 09:02:42< vultraz_iOS> I figured "release technician" would be loony :/
20170322 09:03:19< vultraz_iOS> Unless I'm totally forgetting, Soliton has never been actively involved in the release process, has he?
20170322 09:03:58< Soliton> depends on what you mean by that.
20170322 09:04:00-!- Appleman1234 [~Appleman1@pl13441.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170322 09:04:18< Soliton> front page updated. should the previous entry be removed?
20170322 09:04:38< loonycyborg> he's already involved in managing mp servers
20170322 09:04:51< vultraz_iOS> Soliton: I think the ios maintainer call goes now
20170322 09:04:57< vultraz_iOS> since AFAIK we only keep 2 entries
20170322 09:05:22< Soliton> well, do we have one now?
20170322 09:05:34< Soliton> maybe we should rather remove the last release announcement.
20170322 09:06:13< vultraz_iOS> we do
20170322 09:06:24< Soliton> alright.
20170322 09:08:08< Soliton> looks like https://wiki.wesnoth.org/Older_News should also be updated. maybe someone else can do that.
20170322 09:40:16-!- Kwandulin [~Kwandulin@p200300760F3E7D44DCC37EE099405F6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 09:47:17-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170322 09:49:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 09:53:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170322 09:55:32-!- irker434 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170322 10:05:30-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has joined #wesnoth-dev
20170322 10:15:16-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170322 10:34:37< Soliton> mp server is updated to 1.13.7.
20170322 10:38:21-!- irker323 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170322 10:38:21< irker323> wesnoth: Charles Dang wesnoth:master de0f119baae8 / src/ (4 files in 3 dirs): Made under_leadership return an int/loc pair instead of using an int ptr argumen https://github.com/wesnoth/wesnoth/commit/de0f119baae828bfa1367c73e04077cc52b7c7b4
20170322 11:01:35-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has quit [Ping timeout: 240 seconds]
20170322 11:23:32< wedge009> Announcement looks good.
20170322 11:24:42-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170322 11:27:51< Shiki> vultraz_iOS, https://gna.org/bugs/?21965 seems you can remove the know issue in the announcement
20170322 11:28:21< vultraz_iOS> It's indeed fixed?
20170322 11:29:17< Shiki> I don't know
20170322 11:31:29< Shiki> vultraz_iOS, if you want to make a networked test game, I'm free
20170322 11:31:53< vultraz_iOS> Not now, sorry.
20170322 11:33:34-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:71b6:19b1:8a04:4ab9] has joined #wesnoth-dev
20170322 11:34:26< Shiki> no problem
20170322 11:37:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 11:40:53-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: No route to host]
20170322 11:41:07-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 11:41:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 11:48:06-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170322 11:48:38-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 12:02:47-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 258 seconds]
20170322 12:20:01-!- silentcontrib [~quassel@lewis.freescotcoll.ac.uk] has joined #wesnoth-dev
20170322 12:20:30-!- atomicbomber [~atomicbom@36.84.1.187] has joined #wesnoth-dev
20170322 12:20:37-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20170322 12:20:42-!- atomicbomber is now known as atomicbomb
20170322 12:21:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170322 12:24:20-!- Kwandulin [~Kwandulin@p200300760F3E7D44DCC37EE099405F6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170322 12:41:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 12:44:05-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 12:46:20-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 260 seconds]
20170322 12:47:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 12:50:09-!- atomicbomb [~atomicbom@36.84.1.187] has quit [Quit: Leaving]
20170322 12:52:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170322 13:08:10< irker323> wesnoth: gfgtdf wesnoth:master 395a040fafa0 / RELEASE_NOTES: clean RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/395a040fafa03d99c635ca95bd82e791cfb03227
20170322 13:09:00-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has joined #wesnoth-dev
20170322 13:19:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170322 13:47:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 13:50:05-!- prkc_ [~prkc@46.166.138.153] has joined #wesnoth-dev
20170322 13:52:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170322 13:52:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 13:57:36-!- prkc_ [~prkc@46.166.138.153] has quit [Quit: Leaving]
20170322 13:57:43-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170322 13:57:54-!- prkc [~prkc@46.166.138.153] has quit [Remote host closed the connection]
20170322 13:58:05-!- prkc [~prkc@46.166.138.153] has joined #wesnoth-dev
20170322 14:04:19-!- silentcontrib [~quassel@lewis.freescotcoll.ac.uk] has quit [Remote host closed the connection]
20170322 14:17:43-!- Shiki [~Shiki@p5B27EF10.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 14:19:51-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 14:19:52< travis-ci> gfgtdf/wesnoth#746 (game_data - 68f1dfa : gfgtdf): The build failed.
20170322 14:19:52< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/213825018
20170322 14:19:52-!- travis-ci [~travis-ci@ec2-54-81-191-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 14:37:58-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:71b6:19b1:8a04:4ab9] has quit [Ping timeout: 246 seconds]
20170322 14:55:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170322 14:55:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170322 15:01:47-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170322 15:02:21-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170322 15:04:06-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170322 15:10:11-!- Shiki [~Shiki@p5B27EF10.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20170322 15:22:54-!- Shiki [~Shiki@141.57.62.233] has joined #wesnoth-dev
20170322 15:24:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170322 15:29:27-!- Shiki [~Shiki@141.57.62.233] has quit [Ping timeout: 240 seconds]
20170322 15:30:13-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170322 15:42:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 15:45:17-!- Shiki [~Shiki@p4FDD6B1F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 15:54:03< celmin|sleep> ...wait, since when is there an ios maintainer?
20170322 15:59:13-!- Appleman1234 [~Appleman1@pl13441.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170322 16:08:05-!- Duthlet [~Duthlet@dslc-082-083-178-089.pools.arcor-ip.net] has quit [Ping timeout: 240 seconds]
20170322 16:13:01-!- irker323 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170322 16:13:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 16:13:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 16:16:26< zookeeper> vultraz, btw, maybe using the 2x sprites for messages too would be a good idea: https://forums.wesnoth.org/viewtopic.php?f=21&t=45178
20170322 16:16:35< zookeeper> emphasis on maybe
20170322 16:20:35-!- atarocch [~atarocch@93.68.142.209] has quit [Ping timeout: 240 seconds]
20170322 16:21:05-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170322 16:26:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170322 16:27:49< DeFender1031> zookeeper, eh, images that get scaled up tend not to look so good.
20170322 16:28:39< zookeeper> i guess you don't like the new attack dialog then
20170322 16:28:49< zookeeper> (or help)
20170322 16:31:32< celmin|sleep> We could add an image_mod key to [message] maybe?
20170322 16:31:44< celmin|sleep> Or support unit_image~XBRZ()
20170322 16:32:12< celmin|sleep> ie, match unit_image as a prefix rather than an exact string.
20170322 16:33:54< zookeeper> if we wanted to do it then of course we could just give a ~SCALEd profile for every portraitless unit type.
20170322 16:34:16< zookeeper> either that, or making it automatic.
20170322 16:38:06< celmin|sleep> We could just set the profile for all core units, sure.
20170322 16:38:28 * vultraz_iOS kicks self
20170322 16:38:53< vultraz_iOS> I'm supposed to be the GUIWML expert and I just realized I probably made the AP dialog's WML too complex
20170322 16:39:17< celmin|sleep> Meh.
20170322 16:40:01< celmin|sleep> So, vultraz_iOS, can you make a WIP help dialog that simply dumps the help into a scroll label withut parsing it?
20170322 16:40:13< celmin|sleep> That should be pretty simple, right?
20170322 16:40:21< vultraz_iOS> yes
20170322 16:43:20-!- Shiki_ [~Shiki@p4FDD6683.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 16:43:47-!- Shiki [~Shiki@p4FDD6B1F.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20170322 16:45:05-!- celmin|sleep is now known as celticminstrel
20170322 16:45:44-!- Appleman1234 [~Appleman1@pl16271.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170322 16:51:57-!- irker744 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170322 16:51:57< irker744> wesnoth: Charles Dang wesnoth:master 9a288ab78c43 / data/gui/window/attack_predictions.cfg: Attack Predictions: greatly simplified WML and fixed misalignment when rows are  https://github.com/wesnoth/wesnoth/commit/9a288ab78c43f853205aebfd4707bec34111b078
20170322 16:52:09< vultraz_iOS> all praise zookeeper and his optional macro arg syntax \ o /
20170322 16:54:04 * zookeeper praises
20170322 17:01:57< Ravana_> that sounds like something to have under New lua/wml features
20170322 17:04:20< vultraz_iOS> right - was that this release?
20170322 17:04:25< vultraz_iOS> if so why did we forget to document it 
20170322 17:06:47< zookeeper> previous release
20170322 17:07:47< vultraz_iOS> ah
20170322 17:07:49< vultraz_iOS> ok good
20170322 17:09:46-!- JyrkiVesterinen [~JyrkiVest@89-166-109-135.bb.dnainternet.fi] has joined #wesnoth-dev
20170322 17:10:25< zookeeper> so what's this about some uses of FOREACH being broken?
20170322 17:10:28-!- mjs-de [~mjs-de@x4db67981.dyn.telefonica.de] has joined #wesnoth-dev
20170322 17:10:36< zookeeper> is that true, and if so who did it and why?
20170322 17:11:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 17:12:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 17:12:29< zookeeper> and of course i'm not asking for one of the pointlessly obvious answers, so don't use your time typing those, please
20170322 17:13:21< Ravana_> I meant case where only one of FOREACH / NEXT is used
20170322 17:15:34< zookeeper> right
20170322 17:16:44< zookeeper> celticminstrel, beyond the above, is there anything that's been broken? does [for] support manipulation of the iterator variable from inside the loop, for example?
20170322 17:16:57< celticminstrel> I assume by above you mean my post.
20170322 17:17:04< celticminstrel> [for] does support that IIRC.
20170322 17:17:13< zookeeper> no, i mean the thing above
20170322 17:17:19< celticminstrel> Oh.
20170322 17:17:55< celticminstrel> Well, [for] does support it. It basically functions exactly like a C for-loop.
20170322 17:18:23< celticminstrel> Except the condition is always "$i <= $max".
20170322 17:18:47< celticminstrel> Where $i is the loop variable and $max represents the endpoint of the range.
20170322 17:19:00< celticminstrel> (Or "$min <= $i" for reverse loops.)
20170322 17:19:35< zookeeper> what do you mean, "except"? you've always been able to do {VARIABLE i 9999} to make the loop exit prematurely
20170322 17:20:05< celticminstrel> So what happens is that after each iteration, it adds the step to the loop variable. If the loop variable was changed by the body of the loop, then it'll be adding to that new value.
20170322 17:24:17< zookeeper> well, i'm guessing that means "yes, manipulating the iterator variable works exactly the same as before", and that's good
20170322 17:24:26< celticminstrel> Right.
20170322 17:24:46 * celticminstrel is pretty sure we've had this discussion before.
20170322 17:24:56< zookeeper> hopefully :p
20170322 17:25:06< zookeeper> but how common is the unbalanced use of FOREACH/NEXT which _does_ break?
20170322 17:25:24< celticminstrel> Good question... IIRC it was used by shadowm...
20170322 17:25:44< zookeeper> i'm pretty sure i've seen it (a custom substitute for NEXT or something), but i don't know how common it is.
20170322 17:26:18< celticminstrel> I thought using a custom substitute for {FOREACH} with the built-in {NEXT} was more common, but I dunno.
20170322 17:26:26< zookeeper> same thing
20170322 17:27:13-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170322 17:34:13< zookeeper> celticminstrel, btw, it looks like REPEAT_i is referenced tons of times in UMC, meaning that the change to REPEAT might also break a lot of things for no reason whatsoever.
20170322 17:34:45< celticminstrel> REPEAT_i?
20170322 17:34:50< zookeeper> REPEAT_i
20170322 17:34:55< zookeeper> did you have a question?
20170322 17:34:57< celticminstrel> I don't know what this is.
20170322 17:35:19< zookeeper> read 12 words forward
20170322 17:35:44< celticminstrel> ...
20170322 17:35:47< zookeeper> it's the thing called context
20170322 17:35:51< celticminstrel> I guess it's not important then.
20170322 17:36:38< zookeeper> which part do you not understand? i can't understand how you could fail to understand what i said.
20170322 17:36:40-!- Kwandulin [~Kwandulin@p200300760F3E7D4494AF2281038A5FA2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170322 17:37:22< vultraz_iOS> I thought we depecated all those macros
20170322 17:37:27< vultraz_iOS> deprecated 
20170322 17:39:15< celticminstrel> I said I don't know what REPEAT_i is.
20170322 17:40:04< vultraz_iOS> I've never heard of that macro either
20170322 17:46:34< zookeeper> well now you don't need to
20170322 17:46:36< irker744> wesnoth: ln-zookeeper wesnoth:master 8bbe4189edd0 / data/core/macros/ (deprecated-utils.cfg utils.cfg): Reverted FOREACH, NEXT and REPEAT to their original forms https://github.com/wesnoth/wesnoth/commit/8bbe4189edd0c11f57c77e30a2c012af0ca30319
20170322 17:46:36< zookeeper> move along
20170322 17:46:53 * vultraz_iOS cries
20170322 17:47:05< vultraz_iOS> Y U DO DIS
20170322 17:47:28< zookeeper> because it's the non-stupid thing to do
20170322 17:48:09< vultraz_iOS> why?
20170322 17:48:29< vultraz_iOS> oh you're saying people used implementation macros to break looks
20170322 17:48:30< vultraz_iOS> loops
20170322 17:48:31< vultraz_iOS> ok
20170322 17:48:40 * celticminstrel doesn't really care that much TBH; after all they're deprecated and will eventually be removed.
20170322 17:48:56< vultraz_iOS> well, REPEAT is not
20170322 17:49:05< celticminstrel> "eventually" meaning they'll probably be gone in 1.16.
20170322 17:49:09< vultraz_iOS> sadly
20170322 17:49:17< vultraz_iOS> but at least he left FOREACH and NEXT deprecated 
20170322 17:49:22< celticminstrel> Obviously they need to remain in 1.14. That's what deprecation means.
20170322 17:50:02< zookeeper> obviously they're not going to be removed as long as it'd inconvenience lots of people, whether that's 1.16 or 1.99
20170322 17:50:28< zookeeper> (my guess would be somewhere in between those)
20170322 17:50:54< vultraz_iOS> I love inconveniencing people
20170322 17:51:18< vultraz_iOS> people will never stop using them if we never add actual deprecation notices for them, ya know
20170322 17:51:22< vultraz_iOS> we need to get on that
20170322 17:51:36< celticminstrel> That's how deprecation works. You have one major release (sometimes more than one) where it's deprecated, and then in the next major release it's gone.
20170322 17:52:24< celticminstrel> BTW, did the flooding of draw events ever get fixed?
20170322 17:52:40< vultraz_iOS> yes
20170322 17:52:53< celticminstrel> Is that what GNA25356 was about?
20170322 17:53:14< JyrkiVesterinen> Yes.
20170322 17:53:16< vultraz_iOS> yes
20170322 17:58:23< vultraz_iOS> celticminstrel: you wanted to add a #deprecated preprocessor action?
20170322 17:58:45< vultraz_iOS> directive*
20170322 17:59:02< vultraz_iOS> though I guess maybe [deprecated_message] works just put in the file?
20170322 17:59:08< vultraz_iOS> could work*
20170322 18:03:57-!- Shiki_ [~Shiki@p4FDD6683.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170322 18:04:14< vultraz_iOS> ill test later
20170322 18:07:09< celticminstrel> vultraz_iOS: For macros that are intended as ActionWML, I'd say use [deprecated_message].
20170322 18:07:30< celticminstrel> But adding a #deprecated preprocessor action for non-ActionWML macros would be good too.
20170322 18:08:59< celticminstrel> Also, to appease zookeeper we should probably add an advanced preference "show deprecation messages".
20170322 18:09:38< celticminstrel> Leave it off by default but recommend addon devs turn it on.
20170322 18:11:23< zookeeper> yes, we should very much have a preference like that. although i'd suggest it'd be more of a general "add-on developer mode" with possibly quite a lot of other warning/error messages visible only when it's on.
20170322 18:11:42< celticminstrel> That seems reasonable.
20170322 18:12:30< vultraz_iOS> yes
20170322 18:12:36< vultraz_iOS> it's true players don't need to see that
20170322 18:12:41< vultraz_iOS> but addon devs should see it
20170322 18:12:46< vultraz_iOS> frequently
20170322 18:12:53< vultraz_iOS> and plainly
20170322 18:12:55< celticminstrel> In that case. lg::wml_error could be entirely suppressed if it's off... not entirely sure if that's a good idea, mind you, since it might mean Lua errors go completely unnoticed by players... on the other hand, do players need to see Lua errors?
20170322 18:13:19< celticminstrel> Obviously it doesn't make much sense to be suppressing errors that the game can't recover from, though.
20170322 18:13:26< celticminstrel> Like WML syntax errors.
20170322 18:14:35< zookeeper> the problem with any warnings/errors that end up displayed in the chat stream is that it's essentially a fail state, it instantly gives the impression that there's actually something wrong with whatever content you're playing. and that's actually true only for a subset of them.
20170322 18:15:44-!- Shiki_ [~Shiki@141.57.62.233] has joined #wesnoth-dev
20170322 18:15:59-!- Shiki_ [~Shiki@141.57.62.233] has quit [Remote host closed the connection]
20170322 18:17:15< vultraz_iOS> then again
20170322 18:17:20< vultraz_iOS> perhaps the errors SHOULD always show
20170322 18:17:29< vultraz_iOS> it would encourage addon devs to higher standards of code
20170322 18:18:08< celticminstrel> I'd say that actual errors should probably show. Warnings and deprecations aren't so important.
20170322 18:18:26< vultraz_iOS> true
20170322 18:18:50< celticminstrel> I don't think lg::wml_error distinguishes them though?
20170322 18:19:39< vultraz_iOS> oh fun, it's dugi who brought up the issue of FOREACH
20170322 18:30:18< celticminstrel> So?
20170322 18:31:44< vultraz_iOS> Nothing
20170322 18:31:49-!- gfgtdf [~chatzilla@x4e32b1de.dyn.telefonica.de] has joined #wesnoth-dev
20170322 18:32:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170322 18:34:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 18:39:06-!- mjs-de [~mjs-de@x4db67981.dyn.telefonica.de] has quit [Remote host closed the connection]
20170322 18:53:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170322 18:56:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170322 18:59:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 18:59:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 19:03:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170322 19:26:21< gfgtdf> celticminstrel: a compoiler comains about unused local variable 'data' here https://github.com/wesnoth/wesnoth/blob/master/src/scripting/game_lua_kernel.cpp#L1465 i think you wrote that code
20170322 19:38:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 19:44:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 19:51:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 19:51:56< celticminstrel> gfgtdf: Looks to me like data should be passed to the constructor on the line below.
20170322 19:52:35< celticminstrel> As it is, it seems like get_end_level_data() isn't doing its job and instead returning a default end level data struct.
20170322 20:00:32< Kwandulin> vultraz_iOS: good job on the faction select screen. The issue I mentioned some days ago is already fixed in 1.13.7. There's one different issue: apparently, the "choose your faction" screen uses the image as determined in [multiplayer_side] of the faction, while the lobby uses the image of the leader unit type. The lobby should use the image_icon of the leader unit type instead due to cropping reasons https:/
20170322 20:00:32< Kwandulin> 43wwt8rivq6u3h/mp-factionselect.jpg?dl=0
20170322 20:00:37< Kwandulin> https://www.dropbox.com/s/p43wwt8rivq6u3h/mp-factionselect.jpg?dl=0
20170322 20:02:13< Kwandulin> This obviously only happens to units with image sizes > 72x72, so I am not sure if that's relevant to you
20170322 20:05:54< vultraz_iOS> Kwandulin: ill look into it
20170322 20:09:16< celticminstrel> gfgtdf: Were you working on something related to end level data?
20170322 20:11:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 20:12:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 20:17:36< gfgtdf> celticminstrel: ye i removed the std::string music memeber
20170322 20:17:51< celticminstrel> Why?
20170322 20:18:43< gfgtdf> i replace it with direct getter/setter for [scenario] defeat/victory music
20170322 20:19:25< celticminstrel> Ah.
20170322 20:19:58< celticminstrel> I think the end level data should as much as possible be moved over to wesnoth.game_config.
20170322 20:20:42< gfgtdf> celticminstrel: y that makes sense
20170322 20:21:05< celticminstrel> The only problem is that the end level data struct doesn't exist until the end of level is actually triggered.
20170322 20:21:27< celticminstrel> But simply setting some piece of the end level data shouldn't trigger the end of level.
20170322 20:27:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170322 20:33:10-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170322 20:33:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170322 21:02:18-!- Kwandulin [~Kwandulin@p200300760F3E7D4494AF2281038A5FA2.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170322 21:07:08-!- silentcontrib [~quassel@host-92-27-108-225.static.as13285.net] has joined #wesnoth-dev
20170322 21:19:56< vultraz_iOS> celticminstrel: that shou;d be easy enough to fix
20170322 21:30:30-!- travis-ci [~travis-ci@ec2-54-198-124-107.compute-1.amazonaws.com] has joined #wesnoth-dev
20170322 21:30:31< travis-ci> gfgtdf/wesnoth#747 (game_data - 9e72ab6 : gfgtdf): The build was fixed.
20170322 21:30:31< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth/builds/213992981
20170322 21:30:31-!- travis-ci [~travis-ci@ec2-54-198-124-107.compute-1.amazonaws.com] has left #wesnoth-dev []
20170322 21:54:32-!- atarocch [~atarocch@athe-bt-souel-peer.customers.otenet.gr] has joined #wesnoth-dev
20170322 21:55:24-!- JyrkiVesterinen [~JyrkiVest@89-166-109-135.bb.dnainternet.fi] has quit [Quit: .]
20170322 21:57:17-!- irker744 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170322 22:06:20-!- silentcontrib [~quassel@host-92-27-108-225.static.as13285.net] has quit [Remote host closed the connection]
20170322 22:19:08-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170322 22:26:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 22:37:53-!- irker242 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170322 22:37:53< irker242> wesnoth: Charles Dang wesnoth:master 004fa5071015 / src/gui/dialogs/attack_predictions.cpp: Attack Predictions: consistent formatting for ability modifiers https://github.com/wesnoth/wesnoth/commit/004fa50710151f002f28376fd2ed112aaa359d6c
20170322 22:58:15-!- RatArmy_ [~ratarmy@240f:b3:88e3:1:998d:37ab:5ebc:8186] has joined #wesnoth-dev
20170322 23:04:32< stikonas> loonycyborg: hi. I wrote to mailing list but I guess I can ask here? Any reason for no headers in sota po files?
20170322 23:05:50< loonycyborg> which headers?
20170322 23:07:56< celticminstrel> The msgstr "" header?
20170322 23:08:37< stikonas> yeah, this one, e.g. "Content-Type: text/plain; charset=UTF-8\n"
20170322 23:09:08< celticminstrel> It's there for the po files that actually exist - ja.po, ru.po, hu.po.
20170322 23:09:08< stikonas> I'm nore sure if they are mandatory, but I just started seeing some warnings
20170322 23:09:14< loonycyborg> seems they're still present in the pot file
20170322 23:09:20< loonycyborg> and ru .po file
20170322 23:09:49< celticminstrel> The other po-files for SotA are just placeholders because it seems our toolchain fails if any language is missing.
20170322 23:10:15< celticminstrel> So if a translation for SotA were to be submitted for another language, naturally it would include the header.
20170322 23:10:16< stikonas> hmm, ok, so I'll add header in my local git repo...
20170322 23:10:39< stikonas> (for translations, not fork of wesnoth)
20170322 23:12:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170322 23:12:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170322 23:37:45-!- atomicbomb [~atomicbom@202.67.35.23] has joined #wesnoth-dev
20170322 23:43:07-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170322 23:44:53< celticminstrel> vultraz_iOS: Pressing return apparently quits the addons manager. 
20170322 23:45:42< celticminstrel> https://forums.wesnoth.org/viewtopic.php?p=609840#p609840
20170322 23:53:40< vultraz_iOS>  on it
20170322 23:55:28< irker242> wesnoth: Charles Dang wesnoth:master d015f4763288 / src/gui/dialogs/addon/manager.cpp: Addon Manager: fix Enter closing the dialog https://github.com/wesnoth/wesnoth/commit/d015f4763288e6327125bc7a60ee463e706ec4cb
--- Log closed Thu Mar 23 00:00:36 2017