--- Log opened Mon Mar 27 00:00:01 2017
20170327 00:01:29< celticminstrel> So, anyone feel like working on APFs?
20170327 00:01:54< celticminstrel> There should probably be an issue about them, at least...
20170327 00:05:43< vultraz_iOS> APF?
20170327 00:06:22-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170327 00:06:32< celticminstrel> Audio Path Functions?
20170327 00:06:47< vultraz_iOS> wha?
20170327 00:06:52< vultraz_iOS> when did this come up
20170327 00:06:58< celticminstrel> It was DeFender1031's idea IIRC.
20170327 00:07:02< vultraz_iOS> I see
20170327 00:07:08< celticminstrel> It was awhile ago.
20170327 00:07:21< vultraz_iOS> well, why don't you
20170327 00:07:40< celticminstrel> Well... I might, but it's not near the top of my list.
20170327 00:09:06< vultraz_iOS> isn't our audio API pretty substandard anyway
20170327 00:09:22< vultraz_iOS> we can't even access track metadata
20170327 00:09:24< celticminstrel> What do you mean by "our audio API"?
20170327 00:09:31< vultraz_iOS> whatever we use for sound
20170327 00:09:37< celticminstrel> So, SDL_Mixer?
20170327 00:09:44< vultraz_iOS> I guess
20170327 00:09:49< celticminstrel> SDL_Mixer is pretty basic, but IIRC it does support filters.
20170327 00:10:08< celticminstrel> Unless I'm getting it confused with something else.
20170327 00:10:17< vultraz_iOS> is there an alternative?
20170327 00:10:48< celticminstrel> I dunno.
20170327 00:12:00< vultraz_iOS> Anura has a very nice audio API :P
20170327 00:15:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3cd5:572f:82c2:9188] has joined #wesnoth-dev
20170327 00:18:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3cd5:572f:82c2:9188] has quit [Remote host closed the connection]
20170327 00:19:07-!- Greg-Bog_ [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has joined #wesnoth-dev
20170327 00:22:33-!- Greg-Bog_ [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has quit [Remote host closed the connection]
20170327 00:38:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has joined #wesnoth-dev
20170327 01:11:38-!- gfgtdf_ [~chatzilla@78.54.63.164] has joined #wesnoth-dev
20170327 01:13:33-!- gfgtdf [~chatzilla@78.54.55.226] has quit [Ping timeout: 260 seconds]
20170327 01:13:47-!- gfgtdf_ is now known as gfgtdf
20170327 01:54:22-!- gfgtdf [~chatzilla@78.54.63.164] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.1/20170316213829]]
20170327 01:58:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has quit [Remote host closed the connection]
20170327 02:01:53< vultraz_iOS> looks like #arg NAME val #endarg on one line isn't supported either
20170327 02:03:27< vultraz_iOS> though that makes sense
20170327 02:16:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170327 02:17:26< celticminstrel> Basically the parser just needs to ignore the newline following an endarg.
20170327 02:17:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170327 02:17:43< celticminstrel> Obviously a one-line version isn't supported. :P
20170327 02:27:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has joined #wesnoth-dev
20170327 02:55:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has quit [Remote host closed the connection]
20170327 03:51:19-!- Kwandulin [~Kwandulin@p200300760F3E7D7259627D07BDD8FC75.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170327 04:21:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170327 04:25:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has joined #wesnoth-dev
20170327 04:31:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has quit [Ping timeout: 246 seconds]
20170327 04:47:00-!- irker268 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170327 04:47:00< irker268> wesnoth: Charles Dang wesnoth:master 2417cf31c301 / src/display.cpp: Added 125% zoom level https://github.com/wesnoth/wesnoth/commit/2417cf31c3010d91edc327f35cb53d65a7a8769f
20170327 04:50:02< vultraz_iOS> celticminstrel: https://forums.wesnoth.org/viewtopic.php?p=610021#p610021
20170327 05:00:50< celticminstrel> So basically you're telling me to fix animate_unit again.
20170327 05:01:15< celticminstrel> Sorry... heal_unit.
20170327 05:05:01< vultraz_iOS> yes
20170327 05:07:37< irker268> wesnoth: Celtic Minstrel wesnoth:master 0c4b05ee2a61 / data/lua/wml-tags.lua: Some fixes to [heal_unit]animate=yes https://github.com/wesnoth/wesnoth/commit/0c4b05ee2a61650c8ab0a6553ba7f06963f7996c
20170327 05:07:38< celticminstrel> Lazy.
20170327 05:07:48< celticminstrel> That should work, though.
20170327 05:08:40< vultraz_iOS> Please post
20170327 05:11:23< celticminstrel> ???
20170327 05:11:43< vultraz_iOS> oh wait, they don't have master
20170327 05:11:55< vultraz_iOS> was thinking you should post it was fixed in master
20170327 05:13:23< celticminstrel> I think they were copying the master code back to their copy.
20170327 05:13:56< vultraz_iOS> I see
20170327 05:14:00< vultraz_iOS> then you should post
20170327 05:41:59-!- Kwandulin [~Kwandulin@p200300760F3E7D7259627D07BDD8FC75.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170327 05:56:51< irker268> wesnoth: Charles Dang wesnoth:master 807a3eb793dd / src/gui/widgets/ (scroll_label.cpp scroll_label.hpp styled_widget.hpp): Scroll Label: enable setting alignment of internal label https://github.com/wesnoth/wesnoth/commit/807a3eb793ddbd517c57ec1db4d0fcd7d25fe7ad
20170327 05:56:54< irker268> wesnoth: Charles Dang wesnoth:master 73362d381e29 / src/gui/widgets/ (scroll_label.cpp scroll_label.hpp): Scroll Label: some minor refactoring https://github.com/wesnoth/wesnoth/commit/73362d381e29babeb1c454042784541c9495c692
20170327 05:58:38< celticminstrel> "minor refactoring"
20170327 05:58:42< vultraz_iOS> :3
20170327 05:58:50< celticminstrel> Also, what's "internal label" and why do you want to change it.
20170327 05:59:04< vultraz_iOS> a scroll label is a label inside a scrollbar container
20170327 05:59:11< vultraz_iOS> the internal label is that label
20170327 05:59:13-!- atarocch [~atarocch@93.56.160.33] has quit [Remote host closed the connection]
20170327 05:59:35< celticminstrel> So why do you want to change it?
20170327 05:59:43< vultraz_iOS> because you need to?
20170327 05:59:51< vultraz_iOS> or else you'll never see any change to anything
20170327 05:59:57< celticminstrel> ???
20170327 06:00:25< vultraz_iOS> scroll_label indirectly inherits from styled_widget, just like label
20170327 06:00:55< celticminstrel> Oh, wait, I missed a word in the commit message.
20170327 06:00:57< vultraz_iOS> but if you, say, call set_text_alignment prior to 807a3eb793dd, you'd see no actual change to the text inside the scroll label
20170327 06:01:05< vultraz_iOS> so you need to forward the change
20170327 06:01:39< celticminstrel> I think get_internal_label() should probably be private though?
20170327 06:02:50< vultraz_iOS> it i
20170327 06:02:50< vultraz_iOS> s
20170327 06:03:28< celticminstrel> Ah. So it is.
20170327 06:32:07-!- Appleman1234 [~Appleman1@pl13995.ag1212.nttpc.ne.jp] has quit [Ping timeout: 258 seconds]
20170327 06:33:00-!- celticminstrel is now known as celmin|Zzzzzz
20170327 06:35:23 * vultraz_iOS ponders how to draw the label background
20170327 06:35:30< vultraz_iOS> er, title
20170327 06:40:38-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170327 06:55:17-!- Appleman1234 [~Appleman1@pl1779.nas82j.p-tokyo.nttpc.ne.jp] has joined #wesnoth-dev
20170327 07:12:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170327 07:17:51-!- atarocch [atarocch@nat/redhat/x-eudtzlgvqoafsovm] has joined #wesnoth-dev
20170327 07:21:38< zookeeper> vultraz_iOS, most odd
20170327 07:21:50< vultraz_iOS> indeed
20170327 07:24:33< zookeeper> woah
20170327 07:25:25< vultraz_iOS> hm?
20170327 07:25:34< zookeeper> there's an extra # being swallowed up into the macro content-when-substituted
20170327 07:26:04< vultraz_iOS> p_p
20170327 07:26:23< zookeeper> oh well, i guess i'll investigate and fix
20170327 07:26:38-!- Appleman1234 [~Appleman1@pl1779.nas82j.p-tokyo.nttpc.ne.jp] has quit [Ping timeout: 256 seconds]
20170327 07:26:44< vultraz_iOS> \o/
20170327 07:27:04< zookeeper> although i can't see how it's supposed to be possible that it would be my fault and that i also didn't catch it when testing, because i tested... everything imaginable
20170327 07:27:38< vultraz_iOS> but it happens
20170327 07:32:59< zookeeper> ah, probably the # in #arg because i have a -3 instead of -4...
20170327 07:58:23-!- Appleman1234 [~Appleman1@pl16185.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170327 08:11:34< irker268> wesnoth: ln-zookeeper wesnoth:master c5dc69c024fe / src/serialization/preprocessor.cpp: Fixed an extra # ending up in the macro contents when using #arg https://github.com/wesnoth/wesnoth/commit/c5dc69c024fe6127740122e1629b723a130646bc
20170327 08:11:51< zookeeper> that should do it. but note that your code still results in extra linebreaks before the quoted string starts
20170327 08:12:30< zookeeper> so you either need to remove the quotes and use foobar="{GUI__BORDER_COLOR}" or remove the extra linebreaks if you want to use foobar={GUI__BORDER_COLOR}
20170327 08:14:11< vultraz_iOS> which extra linebreaks?
20170327 08:16:21< zookeeper> oh wait you didn't have them (maybe), i just added some myself for clarity
20170327 08:17:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170327 08:17:21< zookeeper> well, actually
20170327 08:17:30< zookeeper> the linebreak following #endarg is part of the macro contents
20170327 08:17:40< zookeeper> i guess it shouldn't be :p
20170327 08:17:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20170327 08:17:48-!- wedge010 is now known as wedge009
20170327 08:18:09< zookeeper> before i fix that, you'd have to write it like this i guess:
20170327 08:18:12< zookeeper> #define GUI__BORDER_COLOR
20170327 08:18:12< zookeeper> #arg ALPHA
20170327 08:18:12< zookeeper> 255 #endarg "162, 127, 68, {ALPHA}"
20170327 08:18:12< zookeeper> #enddef
20170327 08:18:19< zookeeper> which is a bit... ahem, messy :p
20170327 08:20:50< vultraz_iOS> p_p
20170327 08:20:57< vultraz_iOS> NEIN
20170327 08:21:09-!- Kwandulin [~Kwandulin@p200300760F3E7D72D9D6A77D8E5EB3B5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170327 08:23:29< zookeeper> yeah me too
20170327 08:23:30< irker268> wesnoth: ln-zookeeper wesnoth:master 0ffe009eef4b / src/serialization/preprocessor.cpp: Skip linebreak following #endarg https://github.com/wesnoth/wesnoth/commit/0ffe009eef4bc475d90e455ead1c1b5905375c07
20170327 08:34:24< zookeeper> good now?
20170327 08:34:31< vultraz_iOS> haven't tested yet
20170327 08:34:35< vultraz_iOS> working on something else
20170327 08:35:29< zookeeper> no hurry
20170327 08:53:59-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170327 09:19:33-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170327 09:22:13-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170327 09:25:56< vultraz_iOS> OK
20170327 09:25:58< vultraz_iOS> storyscreen
20170327 09:26:02< vultraz_iOS> approaching completion
20170327 09:26:15< vultraz_iOS> only major component is the floating images
20170327 09:26:19< vultraz_iOS> component left*
20170327 09:27:33< vultraz_iOS> zookeeper: your fix seems to work :D
20170327 09:27:33< vultraz_iOS> ty
20170327 09:27:38< zookeeper> great
20170327 09:27:55< zookeeper> new storyscreen visually the same as before, or more modern or something? :>
20170327 09:32:00< vultraz_iOS> essentially the same so far
20170327 09:32:03< vultraz_iOS> with a few small differences
20170327 09:33:53< zookeeper> mmkay
20170327 09:38:46-!- Kwandulin [~Kwandulin@p200300760F3E7D72D9D6A77D8E5EB3B5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170327 10:13:01-!- Appleman1234 [~Appleman1@pl16185.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170327 10:56:50-!- Appleman1234 [~Appleman1@pl21918.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170327 11:23:32-!- irker268 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170327 12:15:10-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170327 12:18:38-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170327 14:08:24-!- irker374 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170327 14:08:24< irker374> wesnoth: Charles Dang wesnoth:master 15b3317b3645 / data/gui/macros/_initial.cfg: Add optional ALPHA macro args to all color macros https://github.com/wesnoth/wesnoth/commit/15b3317b364514ebaca48bbebad61d2a33826181
20170327 14:08:25< irker374> wesnoth: Charles Dang wesnoth:master 18e29731e626 / data/gui/macros/filler.cfg: Add optional WIDTH and HEIGHT arguments to GUI_FILLER https://github.com/wesnoth/wesnoth/commit/18e29731e626f093417783221f3ab2dfbcbe23db
20170327 14:08:26< irker374> wesnoth: Charles Dang wesnoth:master 6bb7bd1017ec / data/gui/widget/button_default.cfg: Use standard color macros for button code https://github.com/wesnoth/wesnoth/commit/6bb7bd1017ec25a466b64e6f0b6569dcf59d4c6c
20170327 14:08:28< irker374> wesnoth: Charles Dang wesnoth:master 396b33c8a9ef / / (3 files in 3 dirs): Story Viewer: much progress https://github.com/wesnoth/wesnoth/commit/396b33c8a9ef8c666476e95f4b135b96c1efc713
20170327 14:14:45< vultraz_iOS> so, funny thing
20170327 14:15:08< vultraz_iOS> i had spent time adding support to stacked_widget to show more than one layer but fewer than all layers
20170327 14:15:12< vultraz_iOS> since I thought I'd need that
20170327 14:15:22< vultraz_iOS> then I realized I didn't need that at all
20170327 14:15:58< vultraz_iOS> since I don't need to separate the text and controls into two layers if the background is already separate 
20170327 14:36:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has joined #wesnoth-dev
20170327 14:42:09-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170327 14:49:49-!- Kwandulin [~Kwandulin@p200300760F3E7D72D19D28F80EA2FD47.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170327 15:09:55< celmin|Zzzzzz> vultraz_iOS: So you didn't commit it?
20170327 15:10:02< vultraz_iOS> I did not
20170327 15:10:14< celmin|Zzzzzz> Hmm.
20170327 15:10:47< celmin|Zzzzzz> Just wondering if that might be useful for something else too.
20170327 15:11:21-!- celmin|Zzzzzz is now known as celticminstrel
20170327 15:11:36< vultraz_iOS> it involved a dynamic_bitset mask
20170327 15:11:41< vultraz_iOS> I can commit it if you need it
20170327 15:12:09< celticminstrel> Was it tested?
20170327 15:12:17< vultraz_iOS> yes
20170327 15:12:30< vultraz_iOS> but only in one instance
20170327 15:12:37< celticminstrel> Meaning what?
20170327 15:13:20< vultraz_iOS> I tested it with the usecase I thought i needed
20170327 15:13:31< celticminstrel> So it does work?
20170327 15:13:52< vultraz_iOS> yes
20170327 15:15:38< celticminstrel> I at least want to see it, and it seems like it wouldn't hurt to commit it...
20170327 15:21:14< vultraz_iOS> celticminstrel: https://github.com/Vultraz/wesnoth/commit/1c1caffe52670d2e4daffe4b34ebd20a842a0937
20170327 15:22:17< vultraz_iOS> I suppose i could add better interaction with selected_layer_  and the multi-select code
20170327 15:23:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b092:9a08:f79c:2858] has quit [Remote host closed the connection]
20170327 15:26:53< celticminstrel> I see.
20170327 15:27:24< celticminstrel> Bit weird that you're using a std::function internally, but the implementation looks reasonable to me.
20170327 15:27:36< celticminstrel> Would need Lua support too, I guess.
20170327 15:29:24-!- atarocch [atarocch@nat/redhat/x-eudtzlgvqoafsovm] has quit [Ping timeout: 260 seconds]
20170327 15:29:31< vultraz_iOS> I don't touch that area
20170327 15:29:39< celticminstrel> Pity. :P
20170327 15:31:40< vultraz_iOS> anyway, storyscreen is mostly functional
20170327 15:32:21< vultraz_iOS> the images thing will require some thought
20170327 15:32:43< vultraz_iOS> and i need to fix the box when it's not on the bottom
20170327 15:32:53< vultraz_iOS> (needs different look)
20170327 15:33:17< vultraz_iOS> and figure out why sometimes the box not being on the bottom and going back makes the text not show up
20170327 15:33:30< vultraz_iOS> and add the proper button definitions for back/next
20170327 15:33:55< vultraz_iOS> and see if the title *really* needs to always be aligned with the base bg layer
20170327 15:34:23< vultraz_iOS> and figure out how to even deal with said base layer
20170327 15:34:56< vultraz_iOS> (it's tied to the images)
20170327 15:35:16< vultraz_iOS> really the images would be a lot easier if we had standard drawing procedures :|
20170327 15:37:18< vultraz_iOS> the old gui1 stuff handled drawing directly
20170327 15:37:25< vultraz_iOS> the new dialog does not
20170327 15:37:35< vultraz_iOS> it simply queues up shapes on the canvas to draw 
20170327 15:41:17-!- atarocch [~atarocch@109.112.71.203] has joined #wesnoth-dev
20170327 15:55:05-!- atarocch [~atarocch@109.112.71.203] has quit [Ping timeout: 260 seconds]
20170327 16:03:50-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds]
20170327 16:14:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 16:36:22-!- prkc [~prkc@ee.85.7a9f.ip4.static.sl-reverse.com] has quit [Ping timeout: 264 seconds]
20170327 16:38:59-!- Kwandulin [~Kwandulin@p200300760F3E7D72D19D28F80EA2FD47.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170327 16:43:42-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170327 16:51:20-!- prkc [~prkc@d5.85.7a9f.ip4.static.sl-reverse.com] has joined #wesnoth-dev
20170327 16:58:36-!- JyrkiVesterinen [~jyrki@87-92-18-15.bb.dnainternet.fi] has joined #wesnoth-dev
20170327 17:00:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170327 17:09:29-!- irker374 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170327 17:10:35-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170327 17:15:21-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170327 17:26:18-!- Kwandulin [~Kwandulin@p200300760F3E7D728073C5CBEC1DAB11.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170327 17:29:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 18:18:02-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20170327 18:27:45-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170327 19:04:27-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 240 seconds]
20170327 19:19:20-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20170327 19:24:47-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170327 19:52:13-!- JyrkiVesterinen [~jyrki@87-92-18-15.bb.dnainternet.fi] has quit [Quit: .]
20170327 20:02:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170327 20:03:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 20:05:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170327 20:06:08-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170327 20:07:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170327 20:08:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20170327 20:22:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 20:35:45-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170327 20:37:59-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170327 20:42:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170327 20:44:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170327 20:54:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170327 21:03:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170327 21:03:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 21:08:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170327 21:09:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170327 21:12:34-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170327 21:21:11< vultraz_iOS> I'm not sure the flashing floating images are possible in gui2 with the current engine :/
20170327 21:24:53< vultraz_iOS> i'll have to talk to jyrki
20170327 21:25:29-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170327 21:26:35-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170327 21:32:34-!- Kwandulin [~Kwandulin@p200300760F3E7D728073C5CBEC1DAB11.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170327 21:33:36< zookeeper> what flashing floating images? the battle/flag markers?
20170327 21:44:26-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20170327 21:49:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170327 21:49:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170327 21:59:35-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170327 22:05:49< zookeeper> well, i guess you didn't mean those since there's nothing special about their flashing, they're simply delayed images just like the journey dots.
20170327 22:10:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170327 22:25:37-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170327 22:38:27< vultraz_iOS> i did mean those
20170327 22:38:44< vultraz_iOS> the journey dots and the flags are the same thing
20170327 22:44:26< vultraz_iOS> jesus fuck
20170327 22:44:29< vultraz_iOS> thunder
20170327 22:44:30< vultraz_iOS> o_O
20170327 22:44:39 * vultraz_iOS prepares to vanish
20170327 22:44:50< vultraz_iOS> (that is, if this turns into a huge storm)
20170327 22:45:34< vultraz_iOS> hmmm
20170327 22:45:37< vultraz_iOS> I have an idea
20170327 22:45:46< vultraz_iOS> it's hacky, but I could blit the images directly to the canvas manually...
20170327 22:46:20< vultraz_iOS> but I still need the primary layer rect
20170327 22:50:01< vultraz_iOS> I don't HAVE the rect
20170327 22:50:09< vultraz_iOS> at least, not before render time..
20170327 22:50:54< celticminstrel> Isn't there a way to pass a timer value to the canvas so that it's different each time the canvas is re-rendered?
20170327 22:51:18< vultraz_iOS> that's not how the canvas works
20170327 22:51:22< celticminstrel> That seems like one obvious way to do animations of any kind, and blinking images are pretty simple.
20170327 22:51:49< vultraz_iOS> though, do explain
20170327 22:51:56< celticminstrel> image="(if(timer % something = something_else, 'empty_image', actual_image))"
20170327 22:52:12< celticminstrel> A little over-simplified, perhaps.
20170327 22:52:37< vultraz_iOS> that would be great
20170327 22:52:43< vultraz_iOS> except for one problem
20170327 22:52:58< vultraz_iOS> the canvas isn't redrawn unless dirty
20170327 22:53:03< vultraz_iOS> like a normal game would
20170327 22:53:10< vultraz_iOS> er
20170327 22:53:16< vultraz_iOS> let me rephrase that
20170327 22:53:28< vultraz_iOS> it's not drawn unless dirty, unlike what a normal game would do
20170327 22:53:42< vultraz_iOS> if we always redrew it, I could very easily do that perfectly.
20170327 22:54:10< celticminstrel> So just mark it dirty every X seconds?
20170327 22:54:25< celticminstrel> BTW, setting any canvas variable should mark it dirty anyway.
20170327 22:55:11< vultraz_iOS> yes, but the dialog wouldn't be the one setting it...
20170327 22:55:19< celticminstrel> Why not?
20170327 22:56:02< vultraz_iOS> well, I assume any timer would be set by the canvas code
20170327 22:57:17< vultraz_iOS> and again, that would require it running every frame
20170327 22:58:36< vultraz_iOS> and none of this solves the problem of getting the damn base rect
20170327 22:58:36< celticminstrel> Um, why would the timer be set by the canvas code when 99% of canvases don't use it?
20170327 22:59:48< vultraz_iOS> and I don't know if you can set formulas to string values of other formulas to evaluate at runtime
20170327 23:00:29< celticminstrel> There's no way that would work unless the runtime compiled the output of one formula to produce another one.
20170327 23:00:32< vultraz_iOS> but even if I do that, how do I specify the exact image I want to evaluate for size...
20170327 23:00:48 * vultraz_iOS fumes
20170327 23:00:52< celticminstrel> Which I doubt is done anywhere at the moment.
20170327 23:01:01< celticminstrel> I don't understand what the issue is with getting a rect.
20170327 23:02:19< vultraz_iOS> celticminstrel: ok, look: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/story_viewer.cpp#L108-L145
20170327 23:02:26< vultraz_iOS> this is how the new dialog handles background images
20170327 23:02:32< vultraz_iOS> it does *no* calculations itself
20170327 23:02:36< vultraz_iOS> we don't know image size
20170327 23:02:39< vultraz_iOS> or scaling factor 
20170327 23:02:49< vultraz_iOS> all it does it pass the appropriate formulas to the canvas config
20170327 23:03:04< vultraz_iOS> now, the story screen has a "base rect"
20170327 23:03:13< vultraz_iOS> ie, the *scaled* rect of the base background layer
20170327 23:03:21< vultraz_iOS> it's used to position floating images
20170327 23:03:50< vultraz_iOS> so without that, I can't even work on making said images appear because I don't have the right location
20170327 23:04:43< vultraz_iOS> now, you may think, ok, just pass a formula to the floating images' canvas configs that will be evaluated at runtime, and set a variable, like base_rect_ or something
20170327 23:04:44< vultraz_iOS> I
20170327 23:04:54< vultraz_iOS> m sure variant() has an overload for rect
20170327 23:04:58< vultraz_iOS> angles 
20170327 23:05:35< vultraz_iOS> but how do I get a value for that?
20170327 23:05:44< vultraz_iOS> I know, in this loop, which layer is the base
20170327 23:05:58< vultraz_iOS> in the old dialog, it manually handles image fetching, scaling, and blitting all by itself
20170327 23:06:08< vultraz_iOS> so it knows exactly the image dimensions
20170327 23:06:54 * vultraz_iOS ponders
20170327 23:06:57< vultraz_iOS> well
20170327 23:07:16< vultraz_iOS> hmm
20170327 23:07:31< vultraz_iOS> actually, since image_shape::draw is called for every image..
20170327 23:07:38< vultraz_iOS> I could add a base_rect attribute?
20170327 23:07:39< vultraz_iOS> maybe
20170327 23:08:20< vultraz_iOS> then set a variable by the canvas at runtime if it's found..
20170327 23:08:25< vultraz_iOS> using the rect from runtime
20170327 23:08:38< vultraz_iOS> it would mean exposing the canvas formula context to the child shapes, though..
20170327 23:09:18< vultraz_iOS> and it would also mean inserting dialog-specific code (base rects) into the canvas code..
20170327 23:09:30< vultraz_iOS> *unless*, we consider base rects something useful in the future
20170327 23:09:32< vultraz_iOS> perhaps, perhaps..
20170327 23:10:06< vultraz_iOS> celticminstrel: thoughts?
20170327 23:11:26< vultraz_iOS> it'd be nice if i could pass formulas around like lambdas..
20170327 23:11:32< celticminstrel> Um...
20170327 23:12:29< celticminstrel> Why can't you calculate the base_rect at dialog construction or in pre_show or something, and just pass it to the canvas here?
20170327 23:12:54< vultraz_iOS> because that would mean loading the image and applying all scaling factors manually
20170327 23:13:02< celticminstrel> ???
20170327 23:14:10< vultraz_iOS> the whole crux of this problem is the dialog doesn't know the size, scaled or not, of any images it handles
20170327 23:14:16< vultraz_iOS> all it does it pass a formula on to the canvas
20170327 23:14:24< celticminstrel> Oh my, you're constructing WFL code in the C++.
20170327 23:14:36< vultraz_iOS> yes
20170327 23:15:31< celticminstrel> I still don't really understand what the issue is.
20170327 23:15:50< celticminstrel> Or your hypothesized potential solutions.
20170327 23:16:15< vultraz_iOS> I can perhaps set a global canvas variable from the rendering scope of a single shape
20170327 23:16:21< vultraz_iOS> is that acceptable 
20170327 23:16:27< celticminstrel> Huh>
20170327 23:16:29< celticminstrel> ^?
20170327 23:16:33< vultraz_iOS> *sigh*
20170327 23:16:39< vultraz_iOS> the canvas has variables
20170327 23:16:53< vultraz_iOS> each shape sometimes has its own local variables.
20170327 23:17:27< vultraz_iOS> for example, image_width is a variable set in the local drawing scope of a single image shape
20170327 23:17:48< vultraz_iOS> i can perhaps conditionally set a variable in the *parent canvas* if I expose it so.
20170327 23:18:01< vultraz_iOS> that can be used for later calculations
20170327 23:18:29< vultraz_iOS> (hopefully)
20170327 23:18:34< vultraz_iOS> *is this acceptable*
20170327 23:19:12< celticminstrel> So what you're saying is that the entire canvas needs to know the size of one of the images?
20170327 23:20:43< DeFender1031> woah... wall of vultmin.
20170327 23:21:04< celticminstrel> Yup.
20170327 23:21:35< vultraz_iOS> celticminstrel: essentially
20170327 23:22:59< celticminstrel> And that's the image defined in the background= key?
20170327 23:25:02< vultraz_iOS> base_layer = true
20170327 23:25:56< celticminstrel> Okay...
20170327 23:26:26< celticminstrel> So it could be different for each [part]...
20170327 23:26:55< vultraz_iOS> yes
20170327 23:27:45< celticminstrel> Is there any reason you can't load that image to get its size, then set it in the canvas?
20170327 23:55:15< vultraz_iOS> celticminstrel: because the base_rect includes scaling factors
20170327 23:55:34< vultraz_iOS> and if i load the image and get scaling factors i might as well pass that value directly to the canvas instead of using the nice formula
20170327 23:56:29< celticminstrel> Then is there any reason you can't do that?
20170327 23:56:47< vultraz_iOS> I *can*
20170327 23:57:00< vultraz_iOS> but it'd rather leave image loading and handling in a a central place
20170327 23:57:19< vultraz_iOS> that's part of the point of GUI2, after all
--- Log closed Tue Mar 28 00:00:30 2017