--- Log opened Tue Mar 28 00:00:30 2017
20170328 00:38:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 01:22:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 01:27:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20170328 02:25:01-!- irker873 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170328 02:25:01< irker873> wesnoth: Charles Dang wesnoth:master 1c1caffe5267 / src/gui/widgets/ (stacked_widget.cpp stacked_widget.hpp): Stacked Widget: added support for selecting more than one layer, but fewer than  https://github.com/wesnoth/wesnoth/commit/1c1caffe52670d2e4daffe4b34ebd20a842a0937
20170328 02:25:02< irker873> wesnoth: Charles Dang wesnoth:master bf8398692f26 / src/storyscreen/part.hpp: Storyscreen: added getter for floating image filename https://github.com/wesnoth/wesnoth/commit/bf8398692f267090d88b4997e871ce5423f2ad1c
20170328 02:25:03< irker873> wesnoth: Charles Dang wesnoth:master b8ce26a0f968 / src/gui/core/ (canvas.cpp canvas.hpp): GUI2/Canvas: pass canvas variables to shape members as ref instead of const ref https://github.com/wesnoth/wesnoth/commit/b8ce26a0f9687534736d34b66ead0ab3abf0c95a
20170328 02:30:05< celticminstrel> I don't like that.
20170328 02:30:35< celticminstrel> To me, injecting a variable into the global canvas context seems messier than just pre-loading the key image.
20170328 02:31:32< celticminstrel> I apparently forgot to respond to your response to the last thing I said, huh...
20170328 02:35:24< vultraz_iOS> that's why i asked if you thought that effective base areas was something that might be useful in other contexts
20170328 02:36:51< celticminstrel> If you mean the behaviour of placing image A relative to image B even when image B was scaled but image A wasn't, I suppose that might be a generally usefil thing,
20170328 02:39:49< celticminstrel> So how do you propose to inject something into the global scope, anyway?
20170328 02:42:06< vultraz_iOS> just variables.set_variable
20170328 02:43:05-!- JyrkiVesterinen [~JyrkiVest@87-100-168-41.bb.dnainternet.fi] has joined #wesnoth-dev
20170328 02:45:27< vultraz_iOS> er
20170328 02:45:29< vultraz_iOS> .add
20170328 02:47:04< celticminstrel> I'm not asking how you plan to implement it.
20170328 02:48:48< vultraz_iOS> then what are you asking?
20170328 02:49:58< celticminstrel> Didn't you imply that this would affect the canvas WML?
20170328 02:50:22< vultraz_iOS> uh...
20170328 02:50:50< vultraz_iOS> only to the extent of having maybe an extra flag in the config
20170328 02:51:20< celticminstrel> So what would that look like?
20170328 02:52:13< vultraz_iOS> use_as_base_rect = true or something
20170328 02:52:19< vultraz_iOS> but obviously, right now for images only
20170328 02:52:27< vultraz_iOS> or just base_rect
20170328 02:52:29< vultraz_iOS> or even base
20170328 02:52:34< celticminstrel> That seems rather overly-specific.
20170328 02:53:15< vultraz_iOS> then what would you suggest
20170328 03:08:42-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170328 03:08:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170328 03:10:32< celticminstrel> Not entirely sure.
20170328 03:11:00< celticminstrel> But something that doesn't sound like it's tailored specifically for the one use-case you have right now.
20170328 03:18:43< celticminstrel> Like, maybe action="set_var('base_rect', whatever)"
20170328 03:19:08< celticminstrel> (Which would require somehow generalizing the concept of "actions" currently hard-coded into the FormulaAI.)
20170328 03:37:19< vultraz_iOS> celticminstrel: I thought we couldn't do that
20170328 03:37:27< vultraz_iOS> use WFL expressions like functions
20170328 03:37:42< vultraz_iOS> "it'd be nice if i could pass formulas around like lambdas.."
20170328 03:37:42< celticminstrel> Um.
20170328 03:37:51< celticminstrel> Um.
20170328 03:37:58< vultraz_iOS> also you refused to add set_var to WFL
20170328 03:38:12< celticminstrel> set_var already exists in FormulaAI though.
20170328 03:38:21< vultraz_iOS> :|
20170328 03:38:34< vultraz_iOS> this stuff should not be localized to FAI
20170328 03:39:17< celticminstrel> Its implementation in FAI is also poorly generalized. It's all in the execute_variant function rather than having some action_callable with an execute() method.
20170328 03:39:46< celticminstrel> So like, it tries to convert to every possible action type, and if one is successful, it executes it.
20170328 03:39:57< vultraz_iOS> can we add a variant for std::function?
20170328 03:40:28< celticminstrel> That would probably be more work than implementing action objects.
20170328 03:40:39< vultraz_iOS> then could you implement action objects?
20170328 03:40:42< celticminstrel> Formula variants don't have the option to be callable.
20170328 03:40:49< celticminstrel> Formula functions are not first-class values.
20170328 03:41:02< celticminstrel> I do kinda want to implement action objects.
20170328 03:41:09< celticminstrel> I was poking around at it a little while ago.
20170328 03:41:22< vultraz_iOS> can you work on it?
20170328 03:41:26< vultraz_iOS> soon?
20170328 03:42:05< celticminstrel> I'm just not sure how to generalize it from the AI. I'll try to poke around at it a bit more though.
20170328 03:42:30< vultraz_iOS> where is the code
20170328 03:42:44< celticminstrel> src/ai/formula/
20170328 03:42:54< vultraz_iOS> not formula/function*?
20170328 03:43:05< celticminstrel> Mainly ai.cpp (which contains the execute_variant function) and callable_objects.?pp.
20170328 03:43:31< celticminstrel> I get this distinct impression that you're seeing "action objects" and "lambdas" as being the same thing when they're totally different.
20170328 03:43:59< celticminstrel> Action objects have nothing to do with functions, they're just yet another type of formula_callable.
20170328 03:44:18< celticminstrel> A type of formula_callable which represent an action that the engine can execute.
20170328 03:44:45< celticminstrel> A formula in an action-enabled context can return such an object (or a list of such objects), and the engine will execute it/them.
20170328 03:46:31< vultraz_iOS> what type of objects?
20170328 03:46:35< vultraz_iOS> c++ objects?
20170328 03:47:09< celticminstrel> Formula objects. (Though of course each formula object is also a C++ object.)
20170328 03:47:20< celticminstrel> The set_var() function doesn't set any variables.
20170328 03:48:03< celticminstrel> It returns an object that tells the engine "this formula asked you to set this variable to that value", and then if that object was the final result of the formula, then the engine sets this variable to that value.
20170328 03:48:11< celticminstrel> IIUC, this is also exactly how FFL works.
20170328 03:50:02< vultraz_iOS> considering FFL started in Wesnoth as FAI/WFL, likely
20170328 04:09:14< vultraz_iOS> celticminstrel: so if i understand you correctly, you're saying what set_var does is give an object back with the command that would essentially be calling map_formula_callable::add to the current variable context?
20170328 04:09:30< vultraz_iOS> and the end result in the same
20170328 04:09:34< vultraz_iOS> the variable is set?
20170328 04:10:01< vultraz_iOS> so all the WFL engine done is evaluate objects that have commands attached to them?
20170328 04:10:09< celticminstrel> Well, it's an object. The C++ code that evaluated the formula can then choose whether to attempt to execute the result. In most cases, it wouldn't, because it's being evaluated to get a value.
20170328 04:10:39< celticminstrel> So in the case of FormulaAI, the WFL formula outputs a list of instructions which the engine then executes.
20170328 04:10:48< vultraz_iOS> I ee
20170328 04:10:50< vultraz_iOS> see
20170328 04:10:51< vultraz_iOS> wel
20170328 04:11:00< celticminstrel> The commands are not attached to the objects in the current implementation.
20170328 04:11:10< vultraz_iOS> that indeed sounds like something useful to have
20170328 04:11:31< celticminstrel> Rather, the FAI engine has a limited subset of callable types that it knows to be actions, and it checks for each one and tries to execute it if found.
20170328 04:11:55< vultraz_iOS> that seems limited
20170328 04:12:16< celticminstrel> Which is why I wanted a new action_callable that all those could inherit from, to simplify things.
20170328 04:12:24< celticminstrel> That's harder than it sounds though.
20170328 04:12:28< vultraz_iOS> how so?
20170328 04:13:17< celticminstrel> Because the FAI engine has some C++ objects that need to be known in order to execute the WFL action objects.
20170328 04:13:32< celticminstrel> And there's no obvious way to generalize that.
20170328 04:13:44< celticminstrel> With the possible exception of set_var().
20170328 04:13:46< vultraz_iOS> well it must be possible
20170328 04:32:20< celticminstrel> Huh, curious. If a formula returns [action1, action2, action3], they're executed in the order 3, 2, 1.
20170328 04:32:28< celticminstrel> If I'm reading this correctly.
20170328 04:32:35< vultraz_iOS> is that incorrect?
20170328 04:32:49< celticminstrel> I dunno, but at this point it's probably too late to change it.
20170328 04:41:48< irker873> wesnoth: Celtic Minstrel wesnoth:wfl_action_callable f3c4ee01f6e6 / src/ (6 files in 3 dirs): WIP Generalizing the FAI concept of action objects https://github.com/wesnoth/wesnoth/commit/f3c4ee01f6e6c574ba0330b86c7561ee390a5c41
20170328 04:42:00< celticminstrel> Very WIP, but should give an idea of what I'm doing. ^
20170328 04:42:19< celticminstrel> Doesn't compile because there are a plethora of undeclared variables due to copy-pasting code around.
20170328 04:42:44< celticminstrel> (That's why I made it [ci skip], so as to not waste Travis's time on broken code.)
20170328 04:44:51< celticminstrel> (It's also why it's on a branch, of course.)
20170328 04:58:09-!- celticminstrel is now known as celmin|Zzzzzz
20170328 05:01:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 05:06:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170328 05:16:40-!- Kwandulin [~Kwandulin@p200300760F3E7DB3CDAB305A2098C738.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170328 05:33:07-!- Appleman1234 [~Appleman1@pl21918.ag1212.nttpc.ne.jp] has quit [Ping timeout: 246 seconds]
20170328 05:38:23< vultraz_iOS> good, good
20170328 06:00:10-!- JyrkiVesterinen [~JyrkiVest@87-100-168-41.bb.dnainternet.fi] has quit [Quit: .]
20170328 06:29:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170328 06:29:03-!- Appleman1234 [~Appleman1@pl52248.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170328 06:40:21-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170328 06:50:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 06:54:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20170328 07:22:25-!- Kwandulin [~Kwandulin@p200300760F3E7DB3CDAB305A2098C738.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170328 07:22:37-!- Appleman1234 [~Appleman1@pl52248.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170328 07:25:43< irker873> wesnoth: Charles Dang wesnoth:master 19b4916c545b / src/sdl/ (utils.cpp utils.hpp): Add centered flag argument (def true) to tile_surface https://github.com/wesnoth/wesnoth/commit/19b4916c545b58a3d872c272cf3f4b18996e5714
20170328 07:25:46< irker873> wesnoth: Charles Dang wesnoth:master 1878095cbbe7 / src/gui/core/canvas.cpp: GUI2/Canvas: use tile_surface for tile scaling instead of custom implementation https://github.com/wesnoth/wesnoth/commit/1878095cbbe7322908ac1392165f7249dac370f2
20170328 07:27:15-!- Kwandulin [~Kwandulin@p200300760F3E7DB3DD82D7225910D393.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170328 07:51:29-!- atarocch [atarocch@nat/redhat/x-sayjzmefuuhyrudn] has joined #wesnoth-dev
20170328 07:57:59< vultraz_iOS> ugh
20170328 07:58:16< vultraz_iOS> the tiling option in the titlescreen is proving pesky
20170328 08:03:30< zookeeper> what's that?
20170328 08:04:44< vultraz_iOS> apparently we support tiling background images vertically or horizontally in the storyscreen
20170328 08:05:10< zookeeper> oh, hmh. could be.
20170328 08:05:21< zookeeper> which is of course good
20170328 08:06:02< vultraz_iOS> it's actually a "scale, then tile" method
20170328 08:06:11< vultraz_iOS> so I can't just pass resize_mode = "tile"
20170328 08:06:15< vultraz_iOS> to the canvas config
20170328 08:10:38< zookeeper> there's also unscaled tile options
20170328 08:10:59< vultraz_iOS> what do you mean
20170328 08:11:19< zookeeper> i mean what is written in the documentation
20170328 08:11:37< vultraz_iOS> oh, you mean all the interaction with these options
20170328 08:11:50< vultraz_iOS> I've done my best to preserve the behavior
20170328 08:16:46< zookeeper> the scale/tile options aren't really anything exotic, they're things that could come in handy in a lot of different places so having support for them in GUI2 would be good. but since i don't know anything about GUI2, i don't know if such a statement makes sense in this context.
20170328 08:19:05< vultraz_iOS> we already have support for them
20170328 08:19:13< vultraz_iOS> it's the interaction between them that's the problem :P
20170328 08:19:29< vultraz_iOS> for example, gui2 tiling started from top-left
20170328 08:19:39< vultraz_iOS> I preserved that behavior in my last commit but it can be changed
20170328 08:19:54< vultraz_iOS> and the fact that it only works with the designated rect area
20170328 08:20:12< vultraz_iOS> whereas stuff like storyscreen tiling works differently
20170328 08:20:33< vultraz_iOS> it uses base rects 
20170328 08:23:42< vultraz_iOS> ie, centered on the screen but fill up buffer area
20170328 08:38:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 08:43:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20170328 08:54:42-!- Appleman1234 [~Appleman1@pl49270.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170328 09:01:30-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170328 09:05:52-!- Kwandulin [~Kwandulin@p200300760F3E7DB3DD82D7225910D393.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170328 09:23:35-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 240 seconds]
20170328 09:30:12-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20170328 09:35:34-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Read error: Connection reset by peer]
20170328 09:35:40-!- iwaim__ [~iwaim@124.146.179.10] has joined #wesnoth-dev
20170328 09:36:41-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170328 10:26:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 10:30:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170328 10:55:05-!- Appleman1234 [~Appleman1@pl49270.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170328 11:07:50-!- irker873 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170328 11:08:38-!- Appleman1234 [~Appleman1@pl51270.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170328 12:15:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 12:19:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170328 12:29:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 12:32:53-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170328 12:57:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170328 13:46:58-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170328 13:54:50-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170328 14:15:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 14:19:46-!- JyrkiVesterinen [~JyrkiVest@85-76-135-236-nat.elisa-mobile.fi] has quit [Quit: .]
20170328 14:23:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170328 14:23:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 14:24:04-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170328 14:30:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170328 14:39:34-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20170328 14:52:41-!- celmin|Zzzzzz is now known as celticminstrel
20170328 14:56:15-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170328 15:13:52-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170328 15:48:52-!- irker499 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170328 15:48:52< irker499> wesnoth: Celtic Minstrel wesnoth:wfl_action_callable b5af3e6967ec / src/ (6 files in 3 dirs): WIP Generalizing the FAI concept of action objects https://github.com/wesnoth/wesnoth/commit/b5af3e6967ecb87aa3fb783e29431e25ff6da69c
20170328 15:49:07< celticminstrel> Now I just need to decide how to pass ai_, vars_, etc to execute().
20170328 15:49:17< celticminstrel> (See callable_objects.cpp.)
20170328 15:49:47< celticminstrel> Given that the general execute() doesn't need that information... though it does probably need to be passed something.
20170328 15:53:33-!- JyrkiVesterinen [~JyrkiVest@87-100-158-115.bb.dnainternet.fi] has joined #wesnoth-dev
20170328 16:01:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20170328 16:07:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 16:30:20-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170328 16:32:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 16:37:44-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170328 16:47:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170328 17:00:35-!- atarocch [atarocch@nat/redhat/x-sayjzmefuuhyrudn] has quit [Ping timeout: 258 seconds]
20170328 17:15:38-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20170328 17:26:29-!- atarocch [~atarocch@78.5.238.118] has joined #wesnoth-dev
20170328 17:28:43-!- mjs-de [~mjs-de@x4db5fbfa.dyn.telefonica.de] has joined #wesnoth-dev
20170328 18:02:13-!- Appleman1234 [~Appleman1@pl51270.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170328 18:17:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 18:17:52-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170328 18:18:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 18:19:41-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20170328 18:23:06-!- gfgtdf [~chatzilla@78.54.54.104] has joined #wesnoth-dev
20170328 18:25:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 18:32:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 18:32:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 18:33:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170328 18:33:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 18:41:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170328 18:42:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 18:43:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 18:43:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 18:47:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 18:47:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 18:48:34-!- mjs-de [~mjs-de@x4db5fbfa.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170328 18:49:21-!- mjs-de [~mjs-de@x4e31f467.dyn.telefonica.de] has joined #wesnoth-dev
20170328 18:51:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 18:54:41-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 18:56:57-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 18:59:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170328 19:05:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 19:07:15-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 19:09:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 19:12:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 19:13:25-!- Appleman1234 [~Appleman1@pl46660.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170328 19:14:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 19:15:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 19:19:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 19:22:39-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 19:23:09-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170328 19:32:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 19:34:18-!- irker499 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170328 19:55:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 20:00:54-!- JyrkiVesterinen [~JyrkiVest@87-100-158-115.bb.dnainternet.fi] has quit [Quit: .]
20170328 20:13:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 256 seconds]
20170328 20:13:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 20:15:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170328 20:27:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170328 20:29:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170328 21:02:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 21:05:53-!- Kwandulin [~Kwandulin@p200300760F3E7DB3C89ABAA6418BA19B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170328 21:06:45-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170328 21:09:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 21:14:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 21:15:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 21:18:28-!- mjs-de [~mjs-de@x4e31f467.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170328 21:18:35-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170328 21:19:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170328 21:25:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170328 21:45:35-!- gfgtdf_ [~chatzilla@78.54.54.104] has joined #wesnoth-dev
20170328 21:46:47-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20170328 21:48:00-!- gfgtdf [~chatzilla@78.54.54.104] has quit [Ping timeout: 260 seconds]
20170328 21:48:14-!- gfgtdf_ is now known as gfgtdf
20170328 21:53:16-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170328 22:07:57-!- gfgtdf [~chatzilla@78.54.54.104] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.1/20170316213829]]
20170328 22:12:56-!- Duthlet [~Duthlet@dslb-188-106-146-119.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20170328 22:22:27< vultraz_iOS> celticminstrel: wouldn't that be part of a formula context?
20170328 22:28:42< celticminstrel> vultraz_iOS: ???
20170328 22:28:55< vultraz_iOS> Now I just need to decide how to pass ai_, vars_, etc to execute().
20170328 22:28:58< vultraz_iOS> "" ^
20170328 22:29:51< celticminstrel> What do you mean by "formula context"?
20170328 22:32:18< vultraz_iOS> didn't you tell me before there are different contexts/sandboxes? AI context, game context, gui2 context
20170328 22:32:23< vultraz_iOS> and they don't interact?
20170328 22:33:33< celticminstrel> Well, something like that.
20170328 22:33:43< celticminstrel> But it's not like there's an object representing the "context".
20170328 22:35:33< celticminstrel> Hmm, apparently formula_ai and ai_context inherit from a common subclass...
20170328 22:52:10< celticminstrel> BTW, what I said earlier about [1,2,3] executing in reverse order is wrong.
20170328 22:52:13< celticminstrel> I misread the code.
20170328 22:56:46< celticminstrel> vultraz_iOS: If you want something small and easy to do, you could get rid of all those macros in formula/callable_object.hpp
20170328 22:57:02< celticminstrel> Only two of the classes actually use them, and it makes it rather hard to read IMO.
20170328 22:58:16< vultraz_iOS> I'll take a look
20170328 22:58:31< vultraz_iOS> Since I'm stumped on this storyscreen thing
20170328 23:00:32< vultraz_iOS> CALLABLE_WRAPPER_START(klass)
20170328 23:00:34< vultraz_iOS> oh good god
20170328 23:00:35< vultraz_iOS> xD
20170328 23:04:18< celticminstrel> Yeah exactly.
20170328 23:06:00< vultraz_iOS> evil macros are evil
20170328 23:06:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170328 23:12:59< vultraz_iOS> s o m a n y m a c r o s
20170328 23:13:25< vultraz_iOS> might use static functions/lambdas
20170328 23:13:28< vultraz_iOS> for some
20170328 23:13:33< vultraz_iOS> but first, expand everything..
20170328 23:13:45< celticminstrel> Um what?
20170328 23:14:03< celticminstrel> Pretty sure neither static functions nor lambdas can apply here.
20170328 23:16:12-!- atarocch [~atarocch@78.5.238.118] has quit [Ping timeout: 260 seconds]
20170328 23:19:12< celticminstrel> Because the macros are implementing overloaded functions.
20170328 23:19:19< celticminstrel> ^overridden
20170328 23:19:34< vultraz_iOS> ?
20170328 23:20:14< celticminstrel> The macros in callable_objects.hpp implement subclasses of formula_callable complete with the overrides for its pure virtual functions.
20170328 23:20:43< vultraz_iOS> I meant for stuff like the push_back wrapper
20170328 23:20:56< celticminstrel> Huh?
20170328 23:21:19< vultraz_iOS> one of the macros wraps a push_back call
20170328 23:22:06< celticminstrel> If you look in callable_objects.cpp, you'll see that the get_inputs() function does the same thing, just populating the passed list with a bunch of elements.
20170328 23:22:20< celticminstrel> (You might actually want to put the implementations of these functions in the cpp instead of in the hpp.)
20170328 23:22:34< celticminstrel> ((BUt first, as you said, expand everything.)
20170328 23:22:36< vultraz_iOS> I'm going to clean up this whole file
20170328 23:22:41< celticminstrel> Uh-oh.
20170328 23:22:51< celticminstrel> That sound ominous. :P
20170328 23:23:07< celticminstrel> Is there something else that needs changing besides the macros?
20170328 23:23:19< vultraz_iOS> mostly formatting
20170328 23:23:26< celticminstrel> Oh, eh.
20170328 23:23:34< celticminstrel> I guess that's fine then.
20170328 23:35:33-!- atarocch [~atarocch@5.92.1.76] has joined #wesnoth-dev
--- Log closed Wed Mar 29 00:00:41 2017