--- Log opened Thu Apr 06 00:00:54 2017
20170406 00:01:22-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds]
20170406 00:01:46-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20170406 00:12:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170406 00:31:54-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170406 01:22:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170406 01:37:33-!- irker216 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170406 01:51:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20170406 01:53:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20170406 01:57:46-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170406 01:58:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20170406 02:02:46-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170406 02:25:50-!- irker641 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170406 02:25:50< irker641> wesnoth: Celtic Minstrel wesnoth:lua_ai_fallback 30447aa7f7e3 / src/ (playsingle_controller.cpp playsingle_controller.hpp): Make the fallback() FormulaAI action transfer control only until end of turn https://github.com/wesnoth/wesnoth/commit/30447aa7f7e37d8f4b7bf4a7464ce3d6f0304014
20170406 02:25:50< irker641> wesnoth: Celtic Minstrel wesnoth:lua_ai_fallback 62207df0eae6 / src/ (ai/lua/core.cpp menu_events.hpp): Add fallback_human() action to the Lua AI https://github.com/wesnoth/wesnoth/commit/62207df0eae66fee49ee4f1164a8add438f3b838
20170406 02:25:57< celticminstrel> Okay, that makes both my PRs ready for review. \o/
20170406 02:27:16< celticminstrel> Oh right, there was that error on line 1002 though...
20170406 02:28:06< celticminstrel> I think that's a trivial fix actually...
20170406 02:28:50< irker641> wesnoth: Charles Dang wesnoth:master 0fe6c3295120 / src/gui/core/canvas.cpp: Small fixup to 5efc6a807f06 https://github.com/wesnoth/wesnoth/commit/0fe6c32951203f527c7c112fbc1ac696c10ef779
20170406 02:30:02< celticminstrel> "location expected, got table"
20170406 02:35:32< celticminstrel> The only thing I can think of that would cause it in this context is if unit.loc returned nil.
20170406 02:37:32< vultraz_iOS> ok what needs to be done
20170406 02:37:41< vultraz_iOS> I need to fix the panel not drawing when i change definition
20170406 02:37:48< celticminstrel> Which I suppose could happen if cfg.fire_event was set and the death event erased it?
20170406 02:37:51< vultraz_iOS> fix the text sometimes not showing up when going back
20170406 02:38:00< vultraz_iOS> add the new button definitions
20170406 02:38:20< celticminstrel> I dunno why unit.loc would be null unless the unit was removed.
20170406 02:38:24< vultraz_iOS> add the tiling functionality
20170406 02:40:35< vultraz_iOS> other than that it's mostly functional 
20170406 02:41:07< celticminstrel> Does it support the repositioning of the panel?
20170406 02:41:36< vultraz_iOS> yes
20170406 02:41:41< celticminstrel> Excellent.
20170406 02:41:46< vultraz_iOS> that was laughably easy
20170406 02:41:52< celticminstrel> I'd say tiling is probably top priority then.
20170406 02:41:54< celticminstrel> Oh?
20170406 02:41:58< celticminstrel> How laughably easy?
20170406 02:42:13< vultraz_iOS> the hard part is swapping the definition so decor appears when necessary if it's not on the bottom
20170406 02:42:46< vultraz_iOS> celticminstrel: https://pastebin.com/quLFe4vB
20170406 02:42:48< celticminstrel> Oh, does it show the title correctly?
20170406 02:43:04< celticminstrel> I suppose I could stop asking and just try it for myself. >_>
20170406 02:43:17< vultraz_iOS> you need to manually enabled it, remember
20170406 02:43:20< vultraz_iOS> enable
20170406 02:44:20< celticminstrel> Regarding the FIXME, maybe it just needs to relayout?
20170406 02:44:35< celticminstrel> There's probably a way to relayout just a subgrid, right?
20170406 02:45:08< celticminstrel> Why are the definitions "wml_message_*"?
20170406 02:45:16< vultraz_iOS> new panel definitions
20170406 02:45:26< celticminstrel> I'm questioning the names.
20170406 02:45:37< vultraz_iOS> the text doesn't show up at all without the appropriate set_dirty calls
20170406 02:45:38< celticminstrel> "wml_message" makes me think of [message]
20170406 02:45:56< vultraz_iOS> but for some reason, specifically, when going back if the panel was in the middle makes the text not show
20170406 02:46:06< vultraz_iOS> yes, the names are confusing
20170406 02:46:08< vultraz_iOS> I should rename
20170406 02:46:30< celticminstrel> So it's not a case of the panel being moved but the text stays where it was?
20170406 02:46:56< vultraz_iOS> no
20170406 02:51:54< vultraz_iOS> btw, do you think we could implement config inheritance for GUI2 definitions at least?
20170406 02:56:56< celticminstrel> Hmm?
20170406 02:57:10< celticminstrel> Do you mean in the WML, like units have?
20170406 02:57:16< vultraz_iOS> yes
20170406 02:57:23< celticminstrel> It's certainly possible.
20170406 02:57:33< vultraz_iOS> I still think we should have it everywhere but this could be a nice proof-of-concept
20170406 02:57:42< celticminstrel> Provided you have a unique way of referencing the thing you want to inherit from.
20170406 02:57:57< celticminstrel> So I guess, depending on the details.
20170406 02:58:29< celticminstrel> Like if you wanted one widget definition to inherit from another? Not too difficult.
20170406 02:58:52< celticminstrel> Particularly between definitions of the same widget. Would be a little harder across widget types.
20170406 02:58:58< celticminstrel> And wouldn't make as much sense, anyway.
20170406 02:59:19< celticminstrel> Or if you want one dialog to inherit from another, that would be possible too.
20170406 02:59:28< vultraz_iOS> just between definitions of the same widget
20170406 02:59:30< vultraz_iOS> and a base
20170406 02:59:50< celticminstrel> Well, the base could be implemented as a definition of the widget that you just don't directly use, right?
20170406 03:00:03< celticminstrel> If you want to enforce it, you could add an abstract=yes key, I guess.
20170406 03:00:19< celticminstrel> Then the game gives an error if you try to set a definition that's defined as abstract.
20170406 03:01:27< celticminstrel> Anyway, do you have any comments on PRs 962 or 972?
20170406 03:02:04< vultraz_iOS> yeah, i was trying to remember if lua has 'break' or not
20170406 03:02:20< celticminstrel> It doesn't IIRC. You can get the effect using goto, though.
20170406 03:02:37< vultraz_iOS> ok then nvm
20170406 03:02:49< celticminstrel> Why never mind?
20170406 03:03:03< vultraz_iOS> i had noticed a loop without a break
20170406 03:03:11< celticminstrel> Oh?
20170406 03:03:26< celticminstrel> Well, if it's already implemented, probably no point changing it to use goto.
20170406 03:03:38-!- JyrkiVesterinen [~JyrkiVest@87-100-157-211.bb.dnainternet.fi] has joined #wesnoth-dev
20170406 03:03:49< celticminstrel> BTW, the way to break with goto is for ... do ... goto break ... end ::break::
20170406 03:04:28< celticminstrel> Put the label before the end, and it becomes continue.
20170406 03:04:37< celticminstrel> Put it at the top of the loop, and you get Perl-style redo.
20170406 03:04:41< celticminstrel> (ie, after do)
20170406 03:07:01< vultraz_iOS> i see
20170406 03:08:20< vultraz_iOS> hmm
20170406 03:08:39< vultraz_iOS> I just noticed a behavioral change in my storyscreen 
20170406 03:08:45< celticminstrel> Oh?
20170406 03:09:38< vultraz_iOS> actually, a weird discrepancy in the old behavior too
20170406 03:13:26< vultraz_iOS> so, in the old code, if you came to a story part with images, the images draw before the text shows up
20170406 03:13:32< vultraz_iOS> then it shows up
20170406 03:13:42< vultraz_iOS> but i noticed if you go back, then forward again, the text doesn't autoshow
20170406 03:13:54< vultraz_iOS> in my new code, the text shows immediately
20170406 03:14:58< vultraz_iOS> well
20170406 03:15:02< vultraz_iOS> not sure how to handle this :/
20170406 03:16:20< vultraz_iOS> the old code basically defers any action until the images draw
20170406 03:16:21< vultraz_iOS> but..
20170406 03:16:34< vultraz_iOS> my new code is meant to handle stuff concurrently :/
20170406 03:19:05< vultraz_iOS> celticminstrel: thoughts?
20170406 03:19:34< celticminstrel> Well, I wouldn't expect waiting for the images to draw to be a concern... surely it doesn't take that long?
20170406 03:19:45< vultraz_iOS> no it doesn't
20170406 03:19:54< celticminstrel> I do recall the text appeared one line at a time, not sure how/if you could replicate that in the new implementation.
20170406 03:20:14< vultraz_iOS> the problem I guess is to ensure the textbox doesn't cover up any locations unnecessarily 
20170406 03:21:27< vultraz_iOS> let me see if the old code undraws the images..
20170406 03:21:33< JyrkiVesterinen> 20170406 02:44:35< celticminstrel> There's probably a way to relayout just a subgrid, right?
20170406 03:21:41< JyrkiVesterinen> Yes, there is. I recently added one.
20170406 03:22:01< JyrkiVesterinen> Fire the REQUEST_PLACEMENT event on the subgrid or any of its child widgets.
20170406 03:22:08< JyrkiVesterinen> Example: https://github.com/wesnoth/wesnoth/blob/0fe6c32951203f527c7c112fbc1ac696c10ef779/src/gui/widgets/scrollbar_container.cpp#L597-L598
20170406 03:22:40< vultraz_iOS> ahh ty ty
20170406 03:23:18< vultraz_iOS> ok, it doesn't undraw
20170406 03:23:19< vultraz_iOS> good
20170406 03:23:48< vultraz_iOS> hmm
20170406 03:23:51< vultraz_iOS> I have an idea
20170406 03:27:14< JyrkiVesterinen> 20170406 03:02:04< vultraz_iOS> yeah, i was trying to remember if lua has 'break' or not
20170406 03:27:20< JyrkiVesterinen> Lua does have a break keyword.
20170406 03:27:40< celticminstrel> Oh, it did have it? I know it doesn't have continue, at least...
20170406 03:29:08< irker641> wesnoth: Celtic Minstrel wesnoth:lua_ai_fallback 3e5a5626f37a / src/ (ai/lua/core.cpp menu_events.hpp): Add fallback_human() action to the Lua AI https://github.com/wesnoth/wesnoth/commit/3e5a5626f37a1e76c6839440c11844bce981ed7c
20170406 03:29:19< vultraz_iOS> work, this does not 
20170406 03:30:47< vultraz_iOS> ah, this actually halfway works with a set_dirty
20170406 03:31:14< vultraz_iOS> only problem being, I have text and buttons on the same layer...
20170406 03:32:35< vultraz_iOS> now, i could, of course..
20170406 03:32:40< vultraz_iOS> split them again
20170406 03:35:35< vultraz_iOS> AH
20170406 03:35:37< vultraz_iOS> i have an idea
20170406 03:36:23< vultraz_iOS> two actually
20170406 03:36:44-!- Appleman1234 [~Appleman1@pl2771.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170406 03:36:53< vultraz_iOS> A: set up a loop that polls a variable and waits n ms before polling again until the drawing finishes
20170406 03:37:15< vultraz_iOS> B: split the main handling into a new function and simply fire it if the last image is drawn
20170406 03:37:23< vultraz_iOS> celticminstrel: which would you prefer
20170406 03:38:35< celticminstrel> What is this trying to solve?
20170406 03:39:35< vultraz_iOS> replicate the old behavior of not showing the text and background until the images have drawn to ensure they don't cover anything
20170406 03:40:34< celticminstrel> Without really understanding the situation fully... option B sounds a little better, I guess.
20170406 03:49:56< vultraz_iOS> or
20170406 03:49:56< vultraz_iOS> hmmm
20170406 03:50:55< vultraz_iOS> actually, doesn't solve my problem completely
20170406 03:51:02< vultraz_iOS> since the previous text will still be shown
20170406 03:51:21-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170406 04:00:51< irker641> wesnoth: Charles Dang wesnoth:master 7fac80f58664 / src/gui/dialogs/story_viewer.cpp: Story Viewer: added sound and music handling https://github.com/wesnoth/wesnoth/commit/7fac80f586646e5aba5dd7856b57bcf12dd19729
20170406 04:03:32< celticminstrel> Well yes, that's pretty important. :P
20170406 04:08:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170406 04:08:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170406 04:10:51-!- Netsplit *.net <-> *.split quits: aidanhs, vultraz_iOS
20170406 04:13:03-!- Appleman1234 [~Appleman1@pl7188.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170406 04:16:59-!- Netsplit over, joins: aidanhs
20170406 04:21:17-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170406 04:23:44 * vultraz_iOS ponders how to do the tiling
20170406 04:25:11< vultraz_iOS> not as easy as you might think, given that the old storyscreen uses post-scaling tiling over the whole screen and GUI2 uses preprocessing over the specified rectangle
20170406 04:44:37< celticminstrel> I wonder how floating image coordinates would work if the base layer is tiled.
20170406 04:44:52< celticminstrel> Especially if the base layer is rather small.
20170406 05:33:34< vultraz_iOS> celticminstrel: since tiling happens after scaling nothing really different
20170406 05:33:43< vultraz_iOS> though if you don't scale...
20170406 06:15:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170406 06:32:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170406 06:32:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170406 06:34:20-!- Guest48929 [~beatdown@177-1-169-7.paebv701.dsl.brasiltelecom.net.br] has joined #wesnoth-dev
20170406 06:34:36< vultraz_iOS> wait what
20170406 06:34:49< vultraz_iOS> why is GUI2 accessing the parser here
20170406 06:36:00< vultraz_iOS> oh
20170406 06:36:03< vultraz_iOS> different parser
20170406 06:37:30 * vultraz_iOS ponders
20170406 06:37:46< vultraz_iOS> celticminstrel: would config inheritance use config::merge?
20170406 06:44:27-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170406 06:44:55-!- Guest48929 [~beatdown@177-1-169-7.paebv701.dsl.brasiltelecom.net.br] has quit [K-Lined]
20170406 06:59:56-!- JyrkiVesterinen [~JyrkiVest@87-100-157-211.bb.dnainternet.fi] has quit [Quit: .]
20170406 07:01:06< vultraz_iOS> celticminstrel: what I'm imagining is actually [&widget_definition_base] tags, and then [&widget_definition] can use base = "base_id"
20170406 07:01:32< vultraz_iOS> celticminstrel: but how would one combine the data once its found?
20170406 07:01:48< vultraz_iOS> append_children certainly...
20170406 07:01:50-!- irker641 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170406 07:01:58< vultraz_iOS> or does merge call that
20170406 07:02:29< vultraz_iOS> or maybe, not merge anything at all
20170406 07:02:40< vultraz_iOS> just create the necessary data structures from both...
20170406 07:31:30-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170406 07:37:54< vultraz_iOS> hmmmmmmmmmmmmmmmmmmmmm
20170406 07:38:09< vultraz_iOS> actually, I think what I should do is a create a base tag for resolutions
20170406 07:38:23< vultraz_iOS> that's the biggest duplicated part of the WML
20170406 07:39:40< vultraz_iOS> so, let's see
20170406 07:39:45< vultraz_iOS> the styled_widget_definition holds a config
20170406 07:39:49< vultraz_iOS> resolutions are loaded from that
20170406 07:40:26< vultraz_iOS> range of [resolution]
20170406 07:42:40< vultraz_iOS> confusing, this code is
20170406 08:03:21< vultraz_iOS> yes, I think I got it
20170406 08:32:40-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170406 08:37:08-!- irker590 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170406 08:37:08< irker590> wesnoth: Charles Dang wesnoth:master f07261325ea4 / src/gui/widgets/settings.cpp: GUI2/Settings: minor code cleanup https://github.com/wesnoth/wesnoth/commit/f07261325ea454eba61d123487e413d539e0dd7c
20170406 08:57:20-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170406 09:05:12-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 09:18:23-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 09:20:12-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170406 09:20:13-!- horrowind1 is now known as horrowind
20170406 09:32:02-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 09:33:58-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
20170406 09:33:58-!- horrowind1 is now known as horrowind
20170406 09:48:38-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 09:51:00-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170406 09:51:01-!- horrowind1 is now known as horrowind
20170406 09:53:20< matthiaskrgr> hm, does anyone see where this variable x is declared?  https://github.com/wesnoth/wesnoth/blob/master/src/map/location.cpp#L352  
20170406 09:55:18< vultraz_iOS> probably private class member
20170406 09:55:26< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/f07261325ea454eba61d123487e413d539e0dd7c/src/map/location.hpp#L126
20170406 09:56:01< vultraz_iOS> indeed
20170406 09:56:27< matthiaskrgr> ah, thanks!
20170406 09:56:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 09:59:28< Soliton> vultraz_iOS: private members should have a trailing underscore.
20170406 09:59:38< vultraz_iOS> sure
20170406 09:59:43< vultraz_iOS> i didn't write that
20170406 10:00:44< Soliton> (so that member is public.)
20170406 10:02:05< vultraz_iOS> oh right, struct
20170406 10:02:09< vultraz_iOS> alright
20170406 10:05:44-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 10:07:20-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170406 10:07:20-!- horrowind1 is now known as horrowind
20170406 10:17:40-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 10:19:34-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170406 10:19:34-!- horrowind1 is now known as horrowind
20170406 10:30:20-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 10:32:38-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 256 seconds]
20170406 10:32:38-!- horrowind1 is now known as horrowind
20170406 10:48:05-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 10:48:56-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170406 10:48:57-!- horrowind1 is now known as horrowind
20170406 11:00:03-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 11:01:34-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170406 11:01:34-!- horrowind1 is now known as horrowind
20170406 11:13:57-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Quit: horrowind]
20170406 11:37:56-!- irker590 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170406 12:34:53-!- Shiki [~Shiki@p548556CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 12:45:18< celticminstrel> vultraz_iOS: config::inherit_from
20170406 12:45:40< vultraz_iOS> actually, I might not need config inheritance for this, actually
20170406 12:47:58< vultraz_iOS> I decided to add [widget_resolution_definition] tags and then allow [resolution] base_id = in [widget_definition].
20170406 12:49:06< vultraz_iOS> since resolutions are handled on their own, I should be able to construct resolution pointers 
20170406 12:49:21-!- irker346 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170406 12:49:21< irker346> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 20fa8c561299 / data/lua/wml-tags.lua: fixup! Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/20fa8c561299736d342d390ce17da1929efe796a
20170406 12:49:47< celticminstrel> Then you should probably use inherit_from.
20170406 12:49:54< celticminstrel> I guess.
20170406 12:50:08< celticminstrel> Unless I'm missing something.
20170406 12:52:09< vultraz_iOS> that's if i want to copy the config *data* into [resolution]
20170406 12:52:34< vultraz_iOS> I don't think that's necessary
20170406 12:53:51< vultraz_iOS> say you have 10 button definitions 
20170406 12:54:05< vultraz_iOS> each includes the same [resolution] via a macro
20170406 12:54:36< vultraz_iOS> for each of the 10, a new resolution shared_ptr is constructed
20170406 12:55:22< vultraz_iOS> if I use config inheritance here, I only get rid of the 10 [resolution] blocks in the parsed WML
20170406 12:55:40< vultraz_iOS> but the block is still copied, and 10 resolution ptrs are still constructed.
20170406 12:56:03< vultraz_iOS> what I propose is to create only 1 resolution ptr and make 10 new *shared pointers* to this object.
20170406 12:56:17< vultraz_iOS> to do that, I need to *not* use config inheritance
20170406 12:56:18< vultraz_iOS> you see?
20170406 12:57:21< celticminstrel> Each of the buttos has the exact same [resolution]?
20170406 12:57:28< celticminstrel> ^buttons
20170406 12:57:31< vultraz_iOS> most do, yes
20170406 12:57:38< celticminstrel> Huh, okay.
20170406 12:57:39< vultraz_iOS> with some small changes.
20170406 12:57:51< celticminstrel> Wait, now you've just contradicted yourself.
20170406 12:58:18< vultraz_iOS> well, actually that's a good point
20170406 12:58:31< vultraz_iOS> maybe I *do* need config inheritance..
20170406 12:59:08< vultraz_iOS> the thing is, it's not optimal to copy entire [resolution] blocks just to, say, change 1 image path
20170406 12:59:33< celticminstrel> I realize.
20170406 12:59:44< celticminstrel> But that's how the config inheritance currently works.
20170406 13:00:02< vultraz_iOS> hmmm hmm hmmmmmm
20170406 13:00:05< vultraz_iOS> hmmmmmmmmmmmmmmmmmmmmmmm
20170406 13:00:12< vultraz_iOS> weeeeellll
20170406 13:00:29< vultraz_iOS> well, ok, copying at runtime is faster than the preprocessor, likely
20170406 13:01:04< vultraz_iOS> but you make a good point, actually... what would the syntax look like for overriding
20170406 13:01:15< celticminstrel> ???
20170406 13:01:47< vultraz_iOS> say I have [resolution] [background] [draw] [image] foo =  in the base
20170406 13:01:58< vultraz_iOS> and i want to override this in the derivative 
20170406 13:02:01< vultraz_iOS> what does this look like
20170406 13:02:08< celticminstrel> Exactly the same.
20170406 13:02:33< vultraz_iOS> I see
20170406 13:02:50< vultraz_iOS> well that's not optimal at all
20170406 13:03:31< celticminstrel> By "exactly the same" I just mean you need all three subtags in the same order.
20170406 13:03:39< celticminstrel> How else would you do it anyway?
20170406 13:03:45< vultraz_iOS> I don't know
20170406 13:04:57< vultraz_iOS> and this gets more complicated for macro inclusions...
20170406 13:04:58< vultraz_iOS> hmm
20170406 13:05:30< vultraz_iOS> yeeesss, this could prove troublesome...
20170406 13:09:02< vultraz_iOS> yeah actually i didn't really consider the WML side 
20170406 13:15:52< vultraz_iOS> too complex here to specify full override paths
20170406 13:18:29-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 13:19:07 * vultraz_iOS abandons
20170406 13:20:14-!- Shiki [~Shiki@p548556CE.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170406 13:25:14-!- horrowind1 [~Icedove@x55b56a05.dyn.telefonica.de] has joined #wesnoth-dev
20170406 13:27:27-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170406 13:27:27-!- horrowind1 is now known as horrowind
20170406 13:29:56-!- horrowind [~Icedove@x55b56a05.dyn.telefonica.de] has quit [Client Quit]
20170406 13:50:57-!- Appleman1234 [~Appleman1@pl7188.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170406 13:52:15< celticminstrel> Hmm. Looks like [music]shuffle=yes doesn't mean the playlist is shuffled. It means the game will jump to a random track after completing this one.
20170406 13:52:31< celticminstrel> IOW, you need shuffle on all tracks to get a truly shuffled playlist.
20170406 13:54:03< celticminstrel> That's not what the wiki says, though, and shuffle is new in 1.13.0, so I guess it's okay to change it?
20170406 13:54:17< celticminstrel> Unless someone thinks the existing behaviour is more useful.
20170406 13:55:34< zookeeper> "specifies whether the music playlist as a whole should be shuffled or not" so certainly sounds like all tracks were intended to be shuffled...
20170406 13:56:58< zookeeper> hmh, wait...
20170406 13:57:01 * zookeeper ponders
20170406 13:57:36< zookeeper> actually it might make sense the way it is now
20170406 13:58:06< zookeeper> i mean, shuffle=yes is the default so you do get whole playlist shuffle unless you specifically want to have several tracks always play in succession
20170406 13:58:33< zookeeper> ...although even if you wanted tracks E and F to play in succession and thus E had shuffle=no, you could still end up directly in F after some other track
20170406 13:59:48< zookeeper> https://github.com/wesnoth/wesnoth/pull/265 and http://www.wesnoth.org/irclogs/2014/08/%23wesnoth-dev.2014-08-03.log would presumably be good reading
20170406 14:00:30< zookeeper> i'd expect the reasoning for the behavior to be found somewhere in there
20170406 14:11:52< zookeeper> looks like it was one of those features for which was hard to find one good simple solution
20170406 14:11:57< zookeeper> +it
20170406 14:12:31-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Ping timeout: 255 seconds]
20170406 14:12:31-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 255 seconds]
20170406 14:13:20-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20170406 14:13:45< celticminstrel> Sounds like the current behaviour actually was intentional. Okay then.
20170406 14:14:42-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170406 14:16:59-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Read error: Connection reset by peer]
20170406 14:17:34-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20170406 14:27:58-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170406 14:39:53-!- Appleman1234 [~Appleman1@pl7188.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170406 14:52:32-!- gfgtdf [~chatzilla@x4e3689a2.dyn.telefonica.de] has joined #wesnoth-dev
20170406 15:30:44-!- Kwandulin [~Kwandulin@p200300760F3E7DA901DE72EF5F524102.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 15:36:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170406 15:36:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170406 15:41:17-!- JyrkiVesterinen [~JyrkiVest@78-27-116-40.bb.dnainternet.fi] has joined #wesnoth-dev
20170406 15:50:00-!- ToBeFree [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170406 15:50:07-!- irker346 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170406 16:03:44-!- gfgtdf [~chatzilla@x4e3689a2.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170406 16:19:03-!- Kwandulin [~Kwandulin@p200300760F3E7DA901DE72EF5F524102.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170406 16:23:17-!- Kwandulin [~Kwandulin@p200300760F3E7DA901DE72EF5F524102.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 16:32:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170406 16:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 16:35:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170406 16:36:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 16:46:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170406 16:46:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 16:50:43-!- Shiki [~Shiki@p548556CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 16:56:05-!- horrowind [~Icedove@x4e37e0ec.dyn.telefonica.de] has joined #wesnoth-dev
20170406 17:08:06-!- horrowind [~Icedove@x4e37e0ec.dyn.telefonica.de] has quit [Quit: horrowind]
20170406 17:17:02-!- irker700 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170406 17:17:02< irker700> wesnoth: Jyrki Vesterinen wesnoth:wfl_memleak_fix_attempt 32b45d07727f / src/formula/ (variant.cpp variant.hpp): Make variant constructor from std::shared_ptr a template https://github.com/wesnoth/wesnoth/commit/32b45d07727fc751cd551a2720da0038e68b4443
20170406 17:17:06< JyrkiVesterinen> celticminstrel: ^ this is what I came up with.
20170406 17:20:04< celticminstrel> Oh, thanks! So that works on both versions?
20170406 17:21:24< JyrkiVesterinen> I only tested VS2013. Wait a moment, I'll try a VS2015 build.
20170406 17:21:43< JyrkiVesterinen> I can't see any reason why it wouldn't build, though.
20170406 17:22:04< celticminstrel> I wouldn't expect it to fail on 2015 when it works on 2013, yeah.
20170406 17:23:05< JyrkiVesterinen> And the only thing I did was making the constructor accept *more* variable types.
20170406 17:23:33< celticminstrel> I see it's also non-explicit now.
20170406 17:23:57< JyrkiVesterinen> The onld constructor wasn't explicit either...
20170406 17:24:06< celticminstrel> ...it wasn't?
20170406 17:26:55-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170406 17:29:51< celticminstrel> Oh huh, I guess it wasn't.
20170406 17:30:08< celticminstrel> I might've removed it in an attempt to get something to build, then.
20170406 17:37:07< JyrkiVesterinen> Okay. I kept it non-explicit simply to keep my changes to a minimum.
20170406 17:45:08< JyrkiVesterinen> VS2015 build passed.
20170406 18:21:21-!- ToBeFree [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170406 18:27:30-!- Appleman1234 [~Appleman1@pl7188.ag1212.nttpc.ne.jp] has quit [Ping timeout: 256 seconds]
20170406 18:44:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170406 18:44:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 18:45:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170406 18:45:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 18:52:25< irker700> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 18100cb2dc7d / data/lua/wml-tags.lua: fixup! Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/18100cb2dc7d274f4f10b7af8d8242fb125eb59b
20170406 18:54:17-!- JyrkiVesterinen [~JyrkiVest@78-27-116-40.bb.dnainternet.fi] has quit [Quit: .]
20170406 18:54:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170406 18:57:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 19:21:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170406 19:38:40-!- gfgtdf [~chatzilla@x4e3689a2.dyn.telefonica.de] has joined #wesnoth-dev
20170406 19:38:54-!- Appleman1234 [~Appleman1@pl17210.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170406 19:39:46-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20170406 19:40:15-!- Ivanovic [~ivanovic@p579FBCCD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 19:40:15-!- Ivanovic [~ivanovic@p579FBCCD.dip0.t-ipconnect.de] has quit [Changing host]
20170406 19:40:15-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170406 19:44:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 19:49:31-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20170406 19:49:48-!- Ivanovic [~ivanovic@p579FBCCD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170406 19:49:48-!- Ivanovic [~ivanovic@p579FBCCD.dip0.t-ipconnect.de] has quit [Changing host]
20170406 19:49:48-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170406 19:53:48-!- mjs-de [~mjs-de@x4e31c635.dyn.telefonica.de] has joined #wesnoth-dev
20170406 20:00:45-!- mjs-de [~mjs-de@x4e31c635.dyn.telefonica.de] has quit [Remote host closed the connection]
20170406 20:17:46-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170406 20:21:14-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170406 20:24:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20170406 20:28:34-!- Kwandulin [~Kwandulin@p200300760F3E7DA901DE72EF5F524102.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170406 20:31:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170406 20:33:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170406 21:29:58< irker700> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 2881ba0343ee / / (11 files in 5 dirs): Properly port [music] to Lua (somewhat WIP) https://github.com/wesnoth/wesnoth/commit/2881ba0343eedebfd89ecabfe9d574097f600eb1
20170406 21:30:01-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170406 21:45:23-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170406 21:46:29< celticminstrel> So vultraz_iOS has nothing to say on my pull requests?
20170406 22:04:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170406 22:09:42-!- Shiki [~Shiki@p548556CE.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170406 22:11:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170406 22:12:36< matthiaskrgr> wow, didn't think the PR would cause so much discussion o.O
20170406 22:18:15< gfgtdf> afaik mattc did sometimes use the ai commanline feautes so he might know.
20170406 22:18:28< gfgtdf> he's the onyl one who i can currnetly think might know
20170406 22:19:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170406 22:30:20-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170406 22:30:26< irker700> wesnoth: gfgtdf wesnoth:gfgtdf-patch-optionsfix f37fb578d86d / src/saved_game.cpp: support container variables in [options] https://github.com/wesnoth/wesnoth/commit/f37fb578d86d7f37626e5c9088d855efea46d54a
20170406 22:30:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170406 22:35:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20170406 22:42:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170406 23:31:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170406 23:46:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170406 23:46:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170406 23:48:17< vultraz_iOS> celticminstrel: im not sure what i should say
20170406 23:48:23< vultraz_iOS> im no expert on the code
20170406 23:49:21< vultraz_iOS> celticminstrel: the wml tags branch looked fine
20170406 23:49:34< vultraz_iOS> celticminstrel: as for the WFL thing i don't know
20170406 23:49:42< vultraz_iOS> oh wait
20170406 23:49:44< vultraz_iOS> there's no PR for that
20170406 23:49:46< vultraz_iOS> nevermind
20170406 23:50:59< celticminstrel> vultraz_iOS: Well for the WML tags you could comment on "tags to evaluate".
20170406 23:51:21< celticminstrel> The other PR I was talking about is fallback()
20170406 23:52:32< vultraz_iOS> it's AI so I have no idea
20170406 23:53:18< celticminstrel> You could still offer opinions potentially. If you have any.
20170406 23:54:03< vultraz_iOS> i don't
20170406 23:54:10< vultraz_iOS> it seems like a good idea in general
20170406 23:54:16< vultraz_iOS> if i understand it right
20170406 23:54:31< celticminstrel> Whoa. All the WML tests failed. o.o
20170406 23:55:34< celticminstrel> And the Travis log is useless. If all tests failed though it's probably something in one of the core Lua files, so I should be able to reproduce by just starting a scenario...
20170406 23:56:36< vultraz_iOS> I'm not sure how best to solve any of the remaining storyscreen issues besotting me :|
--- Log closed Fri Apr 07 00:00:04 2017