--- Log opened Mon Apr 10 00:00:54 2017 20170410 00:17:51-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection] 20170410 00:36:05-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.4] 20170410 00:41:35-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev 20170410 00:41:35-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host] 20170410 00:41:35-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev 20170410 01:03:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20170410 01:20:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 02:15:10-!- irker387 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170410 02:15:10< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 00b2e59912a7 / / (3 files in 2 dirs): Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/00b2e59912a786ab1c8beb32cf8bad7f29bb8ca9 20170410 02:15:12< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting b7bc51d2bbeb / data/lua/wml-tags.lua src/scripting/game_lua_kernel.cpp src/scripting/lua_team.cpp: Properly port [scroll] to Lua https://github.com/wesnoth/wesnoth/commit/b7bc51d2bbeb6b94fceaf4f12fc722dce87b5e2a 20170410 02:15:14< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 7b6c13bc28af / / (12 files in 5 dirs): Properly port [music] to Lua https://github.com/wesnoth/wesnoth/commit/7b6c13bc28af10d3eb4b454b72f878907925f69f 20170410 02:15:16< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting a5b6c69939b2 / src/scripting/ (game_lua_kernel.cpp lua_common.hpp lua_unit.cpp): Lua: Add float mutator macros and some fixups/cleanup to other mutator/accessor https://github.com/wesnoth/wesnoth/commit/a5b6c69939b2de98063044f5aba13153db73c9cf 20170410 02:15:18< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting fabfee711295 / / (6 files in 4 dirs): Port [volume] to Lua https://github.com/wesnoth/wesnoth/commit/fabfee711295d3b75a844cb389880901dd4c0f84 20170410 02:15:20< irker387> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 9ddbb1b9cd0b / src/ (playsingle_controller.cpp scripting/lua_audio.cpp sound.cpp): fixup! Properly port [music] to Lua https://github.com/wesnoth/wesnoth/commit/9ddbb1b9cd0b3cee9f3ff812ae055623a9b4a512 20170410 02:25:41-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev 20170410 02:25:44< celticminstrel> Hmmm. The default GUI2 textbox history handling is really weird. 20170410 02:25:53< celticminstrel> It uses Ctrl+Tab and Ctrl+Shift+Tab. 20170410 03:11:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20170410 04:25:03-!- Appleman1234 [~Appleman1@pl26740.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer] 20170410 04:29:03-!- Appleman1234 [~Appleman1@pl45713.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170410 04:29:51-!- Appleman1234 [~Appleman1@pl45713.ag1212.nttpc.ne.jp] has quit [Client Quit] 20170410 04:30:22-!- Appleman1234 [~Appleman1@pl45713.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170410 04:34:40-!- Appleman1234 [~Appleman1@pl45713.ag1212.nttpc.ne.jp] has quit [Client Quit] 20170410 04:35:40-!- Appleman1234 [~Appleman1@pl7996.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170410 04:45:47-!- atarocch [~atarocch@31.159.80.149] has joined #wesnoth-dev 20170410 05:13:12< irker387> wesnoth: Charles Dang wesnoth:master bbd9463b1751 / src/gui/dialogs/story_viewer.cpp: Story Viewer: fixed all floating images drawing in the same spot https://github.com/wesnoth/wesnoth/commit/bbd9463b175130da4c7653a9745a7b3da6163e3c 20170410 05:13:15< vultraz_iOS> celticminstrel: ^ 20170410 05:42:53-!- Kwandulin [~Kwandulin@p200300760F3E7DA90C35A4EC73882F13.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 05:55:31< celticminstrel> \o/ 20170410 05:56:40< vultraz_iOS> ok, now I need to solve the off-center thing... 20170410 05:58:01< vultraz_iOS> I think I need to change the src_clip 20170410 06:04:19< vultraz_iOS> oh, i just noticed something in my outro screen code... 20170410 06:04:45< vultraz_iOS> I use fade_step * 5... 20170410 06:04:50< vultraz_iOS> capped at 255... 20170410 06:05:05< vultraz_iOS> but fade_step increases by 5... 20170410 06:07:02< vultraz_iOS> so we're really setting alpa to 0, 25, 50, 75, 100... 20170410 06:07:21< vultraz_iOS> so it's really fade_step * 5^2 20170410 06:07:29< vultraz_iOS> I should make that clearer 20170410 06:08:24< vultraz_iOS> but the internal code uses fade_step as a bounds check... 20170410 06:08:26< vultraz_iOS> so... 20170410 06:09:04< vultraz_iOS> actually, it means the text "fades in" for longer than it should 20170410 06:09:17< vultraz_iOS> what would fade_step equal once 255 is reached... 20170410 06:09:32< vultraz_iOS> about 10 iterations 20170410 06:10:02< vultraz_iOS> so fade_step would only be 50 :| 20170410 06:10:11< vultraz_iOS> whereas the code does a bounds check for 255 20170410 06:11:02< vultraz_iOS> so that's 205 overflow... divided by step (5) is 41....* 50 ms each...divided by 1000... 20170410 06:11:06< vultraz_iOS> ok so it's not THAT bad 20170410 06:11:21< vultraz_iOS> but the code still runs for an extra 2.05 seconds 20170410 06:11:37< vultraz_iOS> no wonder the text seemed to stick around a long time :P 20170410 06:13:03< vultraz_iOS> celticminstrel: any thoughts? 20170410 06:13:31< vultraz_iOS> let 20170410 06:14:10< vultraz_iOS> s see... the old code started at 0,0,0,0 for all colors and gradually incremented by 5 each with a 10 ms delay between each one 20170410 06:14:16< vultraz_iOS> so, what do we have 20170410 06:14:50< vultraz_iOS> 255/5 = 51... 510.....0.5 second fadein? 20170410 06:14:56< vultraz_iOS> that seems.. fast :/ 20170410 06:15:12< vultraz_iOS> then again, what is my code *actually* doing... 20170410 06:15:28< vultraz_iOS> yeah about the same time actually 20170410 06:15:37< celticminstrel> "fade_step * 5^2" is just "fade_step * 25", so no need to use ^ 20170410 06:15:41< vultraz_iOS> 10 iterations to make the math equal 255 thereabouts, every 50 ms... 20170410 06:15:52< vultraz_iOS> so yeah, about 0.5 seconds fadein 20170410 06:16:05< vultraz_iOS> celticminstrel: obviously 20170410 06:16:19< celticminstrel> Again, I don't quite understand the issue you're having. 20170410 06:16:47< vultraz_iOS> it's not really an issue, just that I noticed my code makes the outro stick around for 2 seconds longer than the specified duration 20170410 06:17:35< celticminstrel> How are you doing the fade again? Timers spawning timers still? 20170410 06:17:44< vultraz_iOS> no, continuous timer 20170410 06:18:03< vultraz_iOS> I think I got it 20170410 06:18:16< vultraz_iOS> just increment by 25 in the timer instead of by 5 and multiplying the result in the formula 20170410 06:19:00< vultraz_iOS> oh, but 255 is not completely divisible by 25... 20170410 06:19:02< vultraz_iOS> hmm 20170410 06:19:24< vultraz_iOS> not that that extra 5 points of alpha matters, but I'd like to solve it... 20170410 06:21:54 * vultraz_iOS ponders 20170410 06:26:11< vultraz_iOS> well, I could go the other way 20170410 06:27:14< vultraz_iOS> or, no, i can't multiply anything by 25 20170410 06:28:12< celticminstrel> "not completely divisible" 20170410 06:28:25< celticminstrel> It's not divisible. There's no such thing as partial divisibility. 20170410 06:28:41< vultraz_iOS> i meant it doesn't equal a whole number 20170410 06:31:56< vultraz_iOS> and I can't keep the system but check against 51... because it never gets to 51... 20170410 06:33:37< vultraz_iOS> I could inc by 25, use a check against 275, then let the WFL bring it down to 255 20170410 06:33:40< vultraz_iOS> but i don't really like that 20170410 06:39:16< vultraz_iOS> and I can't reduce the timer any further 20170410 06:39:59-!- atarocch [~atarocch@31.159.80.149] has quit [Remote host closed the connection] 20170410 06:41:29< celticminstrel> Yeah, not equalling a whole number means not divisible. :P 20170410 06:42:06< vultraz_iOS> SO how do you recommend i handle this 20170410 06:42:14< vultraz_iOS> both in terms of step, value, and time 20170410 06:42:26< celticminstrel> I'm sorry, I don't have any suggestions right now. 20170410 06:51:06< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 16c022b3f06b / / (4 files in 2 dirs): Help Browser: Actually show the correct topics with the correct icons https://github.com/wesnoth/wesnoth/commit/16c022b3f06bf8a9444429b8a30884625690dc29 20170410 06:51:08< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 111ccec8d438 / src/ (4 files in 2 dirs): Help Viewer: Show topics with generated text https://github.com/wesnoth/wesnoth/commit/111ccec8d438845a6871a9e0e171430caf041b90 20170410 06:51:10< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 69d53e39c9dc / src/help/ (help_impl.cpp help_impl.hpp): Help: That parameter isn't really needed https://github.com/wesnoth/wesnoth/commit/69d53e39c9dc683975c287537d3a6ffd21ce6332 20170410 06:51:47< vultraz_iOS> ooo 20170410 06:51:54< vultraz_iOS> what is this 20170410 06:52:05< celticminstrel> WIP 20170410 06:52:14< celticminstrel> Currently doesn't expand section topics. 20170410 06:52:20< celticminstrel> Or parse the help markup. 20170410 06:52:26< vultraz_iOS> down with help markup! 20170410 06:52:45< celticminstrel> The topic text actually looks really bad. 20170410 06:53:21< vultraz_iOS> let me take a look 20170410 06:54:48< celticminstrel> Oh, also needs history. 20170410 06:55:13< celticminstrel> You forgot the back/forward buttons in your initial implementation. 20170410 06:58:45< vultraz_iOS> i should rebase this branch 20170410 07:00:24-!- Kwandulin2 [~Kwandulin@p200300760F3E7DA90C35A4EC73882F13.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 07:03:08-!- Kwandulin [~Kwandulin@p200300760F3E7DA90C35A4EC73882F13.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20170410 07:20:30< vultraz_iOS> celticminstrel: iiiinteresting 20170410 07:20:52< vultraz_iOS> obviously i should implement tree expansion next 20170410 07:22:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20170410 07:22:39< vultraz_iOS> zookeeper: the floating image drawing is fixed 20170410 07:23:06< zookeeper> camper 20170410 07:32:58< vultraz_iOS> celticminstrel: hm.. I think this loop needs to be recursive? 20170410 07:34:38< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 14de5e379c82 / / (4 files in 2 dirs): Help Browser: Actually show the correct topics with the correct icons https://github.com/wesnoth/wesnoth/commit/14de5e379c82a781648da007c89d4ff937e42e1a 20170410 07:34:40< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 467baaf45e7a / src/ (4 files in 2 dirs): Help Viewer: Show topics with generated text https://github.com/wesnoth/wesnoth/commit/467baaf45e7a2315c17b9c30567757e6661e12d6 20170410 07:34:42< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help 8614d8f049d1 / src/help/ (help_impl.cpp help_impl.hpp): Help: That parameter isn't really needed https://github.com/wesnoth/wesnoth/commit/8614d8f049d1ef1cb238b98cd028559f89b0a74b 20170410 07:34:44< irker387> wesnoth: Charles Dang wesnoth:gui2_help e57fd9c58a02 / data/gui/window/help_browser.cfg: Help Browser: improved layout stability and added next/back buttons (non-functio https://github.com/wesnoth/wesnoth/commit/e57fd9c58a026c145d8b60c6b74628edd8656750 20170410 07:35:22< celticminstrel> Oh, thanks. 20170410 07:36:29< celticminstrel> What loop needs to be recursive, vultraz_iOS? 20170410 07:36:40< celticminstrel> I don't think there are any loops in the help browser that need to be recursive. 20170410 07:37:01< vultraz_iOS> the loops calling add_topic 20170410 07:37:35< celticminstrel> Oh. 20170410 07:37:49< celticminstrel> Well, they could be recursive, but they don't necessarily need to be. 20170410 07:38:03< vultraz_iOS> but how will we add sub-topics then 20170410 07:38:08< vultraz_iOS> default_toplevel is a section 20170410 07:38:18< vultraz_iOS> it has a list of topics and other sections 20170410 07:38:36< vultraz_iOS> so wouldn't the sub-sections need to be parsed? 20170410 07:40:38< celticminstrel> Well, you could add the sub-topics when the section is selected or when it's expanded. 20170410 07:40:49< vultraz_iOS> no, no 20170410 07:40:50< celticminstrel> I think init_help() actually preparses everything. 20170410 07:40:51< vultraz_iOS> too expensive 20170410 07:41:03< celticminstrel> It's not that expensive. It's just adding a few more nodes to the tree view. 20170410 07:41:26< celticminstrel> Well, and whatever parsed_text() does. 20170410 07:42:51< vultraz_iOS> better to prepare nodes in preshow 20170410 07:45:53< celticminstrel> Funny. You added use_markup in that commit, which was the exact thing I was missing for my next commit. 20170410 07:47:47< celticminstrel> So when I rebased to prevent conflicts when adding it, I then discovered it was already there. 20170410 07:49:13< celticminstrel> Hmmm, the dynamic canvas idea might be the easiest way to implement the help viewer... 20170410 07:50:20< vultraz_iOS> :o 20170410 07:50:43< celticminstrel> Though figuring out where to put each element is probably nontrivial... 20170410 07:50:50< celticminstrel> And then there's links... 20170410 07:50:59< vultraz_iOS> I'm implementing the recursive topic generation 20170410 07:51:03< celticminstrel> Okay. 20170410 07:51:40< vultraz_iOS> if we want to use the dynamic canvas more, we need to make the interface a little better 20170410 07:51:52< vultraz_iOS> for one, let's add mid_x and mid_y to [image] 20170410 07:51:55< celticminstrel> If you say so? 20170410 07:52:04< celticminstrel> mid_x and mid_y aren't needed? 20170410 07:52:10< celticminstrel> I mean, it's a trivial calculation. 20170410 07:52:31< vultraz_iOS> yes 20170410 07:52:35< vultraz_iOS> but it's nicer to work with 20170410 07:52:36< celticminstrel> mid_x = (x1 + x2) / 2 20170410 07:53:01< celticminstrel> And since x1 is x and x2 is x + w, you get (2 * x + w) / 2 20170410 07:53:23< celticminstrel> Or x + w / 2 20170410 07:56:27< celticminstrel> vultraz_iOS: Do you remember what/where the function to excape pango markup is? 20170410 08:00:27< vultraz_iOS> uhhh 20170410 08:00:32< vultraz_iOS> font...escape_markup? 20170410 08:00:34< vultraz_iOS> not sure 20170410 08:00:38< vultraz_iOS> look in font/pango/? 20170410 08:04:47< celticminstrel> Thanks, found it. 20170410 08:08:10< celticminstrel> Well, I broke the GUI1 help. Since this is a branch, I'm gonna push anyway. 20170410 08:08:45< celticminstrel> BTW, before you pull my commit, can you compare the GUI1 to GUI2 help quickly? I'm wondering if there should be a title line above each topic, separate from the title text. 20170410 08:09:03-!- atarocch [~atarocch@2.43.185.171] has joined #wesnoth-dev 20170410 08:09:05< irker387> wesnoth: Celtic Minstrel wesnoth:gui2_help a134f1db8413 / src/ (5 files in 2 dirs): Help Viewer: Parse help markup to Pango markup... mostly. https://github.com/wesnoth/wesnoth/commit/a134f1db8413ee97da9e3bb8f0b0598d13492a5e 20170410 08:09:06-!- celticminstrel is now known as celmin|sleep 20170410 08:12:24< vultraz_iOS> hm 20170410 08:12:36< vultraz_iOS> I know we added the ability to open nodes with toggle panels... 20170410 08:12:38< vultraz_iOS> what happened to that 20170410 08:18:33< vultraz_iOS> had to pull in the similar code from the gamestate inspector... 20170410 08:21:51< vultraz_iOS> oh huh 20170410 08:21:52< vultraz_iOS> there is... 20170410 09:02:31-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds] 20170410 09:13:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 09:17:15-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 09:21:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 252 seconds] 20170410 09:47:31-!- Appleman1234 [~Appleman1@pl7996.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds] 20170410 09:52:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 09:56:20-!- Appleman1234 [~Appleman1@pl7626.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170410 10:06:10-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 10:12:08-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 255 seconds] 20170410 10:17:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 11:09:13-!- irker387 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170410 11:20:47-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 11:26:09-!- JyrkiVesterinen [~jyrki@87-100-242-69.bb.dnainternet.fi] has joined #wesnoth-dev 20170410 11:38:44-!- Kwandulin2 [~Kwandulin@p200300760F3E7DA90C35A4EC73882F13.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170410 11:45:12-!- Shiki [~Shiki@141.57.60.165] has joined #wesnoth-dev 20170410 11:52:42-!- Ivanovic [~ivanovic@p4FC5330E.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 11:55:38-!- Shiki [~Shiki@141.57.60.165] has quit [Remote host closed the connection] 20170410 12:10:31-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds] 20170410 12:10:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170410 12:17:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 12:52:03-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 13:20:17-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 13:29:00-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds] 20170410 13:30:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 256 seconds] 20170410 14:02:52-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 14:07:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20170410 14:07:10-!- Appleman1234 [~Appleman1@pl7626.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds] 20170410 14:08:06-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 245 seconds] 20170410 14:24:28-!- Appleman1234 [~Appleman1@pl28824.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170410 14:34:32-!- Shiki [~Shiki@pD954C14C.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 14:48:54-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 14:51:21-!- irker332 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170410 14:51:21< irker332> wesnoth: Charles Dang wesnoth:gui2_help 83f1542dc123 / / (3 files in 2 dirs): Help Browser: implemented viewing of sub-sections/topics https://github.com/wesnoth/wesnoth/commit/83f1542dc1239cad661d89022b4472ef181920df 20170410 14:59:46-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20170410 15:02:37-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 15:06:35-!- JyrkiVesterinen [~jyrki@87-100-242-69.bb.dnainternet.fi] has quit [Quit: .] 20170410 15:46:51-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds] 20170410 15:54:18< irker332> wesnoth: Charles Dang wesnoth:gui2_help d89abd2776d4 / src/ (gui/dialogs/title_screen.cpp help/help.cpp): Moved new help entry point to a common location https://github.com/wesnoth/wesnoth/commit/d89abd2776d4179cb1b2b9fa19b90252ca8d5223 20170410 16:02:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 16:03:36-!- Shiki [~Shiki@pD954C14C.dip0.t-ipconnect.de] has quit [Quit: Verlassend] 20170410 16:16:19-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 16:20:40< irker332> wesnoth: Charles Dang wesnoth:master 142ced01e147 / src/gui/widgets/ (multi_page.cpp multi_page.hpp): Multipage: made add_page return the grid of the newly added page https://github.com/wesnoth/wesnoth/commit/142ced01e147ab06959c330664fea5668b43ec84 20170410 16:20:43< irker332> wesnoth: Charles Dang wesnoth:master 15daebd149d3 / data/gui/window/outro.cfg src/gui/dialogs/outro.cpp: Outro: fixed text being shown for approx 2.5 seconds longer than specified https://github.com/wesnoth/wesnoth/commit/15daebd149d376d5c8a2a25ad3fde3745f174889 20170410 16:22:27< vultraz_iOS> celmin|sleep: I settled on 10 steps with a ceil rounded value of 25.5 * step 20170410 16:23:02< vultraz_iOS> celmin|sleep: the multipage thing isn't really needed for help (I thought i was going to need it for something, didn't, but it could be useful 20170410 16:23:28-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 255 seconds] 20170410 16:26:19< irker332> wesnoth: Charles Dang wesnoth:master c452a4cc259e / src/gui/dialogs/story_viewer.cpp: Revert "Story Viewer: only show upper gradient if no title is present" https://github.com/wesnoth/wesnoth/commit/c452a4cc259eddf3c51b81c7835be08ddff1d59e 20170410 16:26:31< vultraz_iOS> zookeeper: ^ another thing done 20170410 16:29:32< vultraz_iOS> I stil think with that shading the box isn't needed at all 20170410 16:30:12< vultraz_iOS> zookeeper: do you think the box is needed at all? 20170410 16:37:28< vultraz_iOS> zookeeper: see what you think 20170410 16:37:32< irker332> wesnoth: Charles Dang wesnoth:master e369e10eee09 / data/gui/widget/label_story_screen_title.cfg: Story Viewer: disabled title background for now https://github.com/wesnoth/wesnoth/commit/e369e10eee094068bcb64434633fdc49044a85ed 20170410 16:47:55< celmin|sleep> How is he supposed to see what he thinks if you just go ahead and disable the title background? 20170410 16:48:13< celmin|sleep> Personally I'd rather have the background than the gradient, in any case. 20170410 16:50:38< vultraz_iOS> he can see if he thinks the gradient is dark enough 20170410 16:51:44< celmin|sleep> And why are you making commits on master just to see if someone likes them? 20170410 16:53:14< vultraz_iOS> I disabled it because it was causing placement issues with labels in certain circumstances 20170410 16:53:28< celmin|sleep> ...? 20170410 16:53:30< vultraz_iOS> for example AtS's multiline labels 20170410 16:53:44< vultraz_iOS> s/labels/titles 20170410 16:53:59< celmin|sleep> What kind of placement issues? 20170410 16:54:34< vultraz_iOS> was getting places near center screen 20170410 16:55:08< celmin|sleep> ??? 20170410 16:55:15< vultraz_iOS> placed* 20170410 16:55:33< celmin|sleep> I don't get it. 20170410 16:56:16< vultraz_iOS> it wasn't left aligned 20170410 16:56:19< vultraz_iOS> for some reason 20170410 17:01:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20170410 17:02:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170410 17:02:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 17:02:48-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 17:05:08-!- celmin|sleep is now known as celticminstrel 20170410 17:07:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds] 20170410 17:14:51-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds] 20170410 17:19:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 17:19:36< celticminstrel> Apparently I forgot how to set a click callback. >_> 20170410 17:20:10-!- atarocch [~atarocch@2.43.185.171] has quit [Ping timeout: 240 seconds] 20170410 17:30:54-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170410 17:33:50-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev 20170410 17:34:10-!- JyrkiVesterinen [~jyrki@87-100-242-69.bb.dnainternet.fi] has joined #wesnoth-dev 20170410 17:35:15< vultraz_iOS> celticminstrel: connect_signal_mouse_left_click 20170410 17:40:59< zookeeper> vultraz_iOS, wouldn't it make sense to use a black-and-blurred version of the text as the text background? 20170410 17:41:35< vultraz_iOS> Could also be done yes 20170410 17:44:59< zookeeper> that's usually what i'd attempt first, for making a text be readable on any kind of background 20170410 17:49:32-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds] 20170410 17:49:39< zookeeper> copy the text, turn it black, blur with radius 4, blit that under the text 3 times... seems to make the text look clear on any background 20170410 17:50:37-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 17:52:43< celticminstrel> That is indeed the general way of making text visible on any background - give it a shadow or outline. 20170410 18:08:17< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 8c0ea49169b4 / src/gui/dialogs/ (help_browser.cpp help_browser.hpp): Help Browser: Implement history https://github.com/wesnoth/wesnoth/commit/8c0ea49169b47321b40749a978073c7a5b6b8572 20170410 18:08:38< celticminstrel> So vultraz_iOS, about the folding/unfolding, the way it should work is that you click on the book to fold/unfold, just like a disclosure triangle. 20170410 18:09:07< celticminstrel> So you can fold/unfold the entry that is currently selected, if you want, or select an entry without unfolding it. 20170410 18:09:16< vultraz_iOS> Alright 20170410 18:09:18< vultraz_iOS> It can be done 20170410 18:09:31< celticminstrel> It should display the open book symbol when unfolded, of course. 20170410 18:11:19-!- Ivanovic [~ivanovic@p4FC5330E.dip0.t-ipconnect.de] has quit [Changing host] 20170410 18:11:19-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20170410 18:12:11< vultraz_iOS> there is significant lag when generating some pages 20170410 18:12:13< vultraz_iOS> just ftr 20170410 18:12:25< celticminstrel> Yeah, I know. 20170410 18:13:02< celticminstrel> Looks like the multi_page is indeed supposed to contain the topic title as a separate label. 20170410 18:13:18< vultraz_iOS> what? 20170410 18:13:26< vultraz_iOS> oh 20170410 18:17:39< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 6b25b78ef825 / src/help/help_text_area.cpp: Fix GUI1 help topics not showing https://github.com/wesnoth/wesnoth/commit/6b25b78ef825bcbb74ac02d10862828a602bde9f 20170410 18:18:46-!- atarocch [~atarocch@31.159.144.183] has joined #wesnoth-dev 20170410 18:23:22-!- atarocch [~atarocch@31.159.144.183] has quit [Remote host closed the connection] 20170410 18:33:33-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev 20170410 18:35:39< celticminstrel> vultraz_iOS: Are you working on help right now? 20170410 18:35:49< vultraz_iOS> yes, i have the book toggles implemented 20170410 18:35:54< celticminstrel> Yay 20170410 18:43:34< irker332> wesnoth: Charles Dang wesnoth:gui2_help 47ee5fbe8e3b / / (3 files in 3 dirs): Help Browser: properly implement toggling by clicking the book icons https://github.com/wesnoth/wesnoth/commit/47ee5fbe8e3b252196119ad8c5f5cf4f565ec583 20170410 18:43:36< vultraz_iOS> celticminstrel: ^ it is done 20170410 18:46:24< celticminstrel> Oh yeah, I keep forgetting to put the opening brace on a new line. 20170410 18:46:24< vultraz_iOS> celticminstrel: crash when opening the dialog and then immediately clicking back 20170410 18:46:50< celticminstrel> Didn't I hide back in pre_show? 20170410 18:47:10< vultraz_iOS> and then you call on_topic_select 20170410 18:47:13< celticminstrel> Of course it would crash if you clicked it before there's any history. 20170410 18:47:26< celticminstrel> Actually, come to think of it... 20170410 18:47:44< celticminstrel> There should always be at least one history element... hmmm... 20170410 18:47:54< celticminstrel> I'll do something. 20170410 18:50:49< celticminstrel> There already is always at least one history element. 20170410 18:53:51-!- Shiki [~Shiki@pD954C14C.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 18:56:42< vultraz_iOS> I believe this is all the low-hanging fruit 20170410 18:57:11< vultraz_iOS> you did really well getting it this far, but... how do we go from here 20170410 18:58:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 19:06:49-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds] 20170410 19:10:00-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170410 19:25:52-!- Shiki [~Shiki@pD954C14C.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20170410 19:27:28-!- gfgtdf [~chatzilla@x4e3680ae.dyn.telefonica.de] has joined #wesnoth-dev 20170410 19:32:28-!- JyrkiVesterinen [~jyrki@87-100-242-69.bb.dnainternet.fi] has quit [Quit: .] 20170410 19:42:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 19:55:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170410 19:55:46-!- janebot [~Gambot@grickit.us] has joined #wesnoth-dev 20170410 19:55:57-!- janebot [~Gambot@grickit.us] has quit [Changing host] 20170410 19:55:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170410 20:09:22-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection] 20170410 20:15:54< celticminstrel> Okay, now I need to see if it works when showing hidden topics... 20170410 20:16:06< celticminstrel> Any suggestions for where I can test a hidden topic? 20170410 20:17:21< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 3e0d0a9a2953 / src/gui/dialogs/help_browser.cpp: Help Browser: Fix back button being visible when dialog opens https://github.com/wesnoth/wesnoth/commit/3e0d0a9a2953a84daaf22600a4d775f34c7d1533 20170410 20:17:23< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 9ed971becbdf / data/gui/window/help_browser.cfg src/gui/dialogs/help_browser.cpp: Help Browser: Show topic title https://github.com/wesnoth/wesnoth/commit/9ed971becbdfe3207f0937e94e1cc42378ca5926 20170410 20:17:25< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 537ac9e8dfee / src/gui/dialogs/help_browser.cpp: Help Browser: Don't double-list a section's root topic https://github.com/wesnoth/wesnoth/commit/537ac9e8dfee84576a29504a0b4af33fe317fc7f 20170410 20:17:27< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 731f47b7c877 / src/gui/widgets/tree_view_node.cpp: Tree View: Allow find_widget to recurse into the nodes https://github.com/wesnoth/wesnoth/commit/731f47b7c87771e3988a56841ba36a0e96e52088 20170410 20:17:29< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help ded4b2b5b7e9 / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): Tree View Node: Add functionality to auto-expand parents when selecting a node https://github.com/wesnoth/wesnoth/commit/ded4b2b5b7e9c224738e7a672dbd67c58fdf1779 20170410 20:17:31< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help d1f4a8980e5b / src/gui/dialogs/ (help_browser.cpp help_browser.hpp): Help Browser: Support arbitrary initial topic https://github.com/wesnoth/wesnoth/commit/d1f4a8980e5be75fda712cbfbe8b27db8882cfd0 20170410 20:18:17< celticminstrel> ...now that I think of it, the expand_parents option could fail in theory if there's an unfolded node which is a child of a folded node... oh well. 20170410 20:21:38< celticminstrel> Could be fixed by just removing the second half of the && condition, I guess. 20170410 20:27:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20170410 20:28:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 20:34:41< celticminstrel> vultraz_iOS: There's also still a small problem with the expanding books - it seems that if the node is selected (outlined), the book needs to be double-clicked (instead of single-clicked) to expand it. 20170410 20:43:40-!- Kwandulin [~Kwandulin@p200300760F3E7DA925659C94B749C6D2.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org] 20170410 20:51:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170410 20:51:18-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170410 21:01:28< gfgtdf> celticminstrel: maybe it sbetter to have the tree_view_node_icon toggle_button not inside the tree_view_node_label togglepanel 20170410 21:02:08< celticminstrel> IIRC the lobby has the correct behviour with its player list. 20170410 21:02:15< celticminstrel> So it should be possible. 20170410 21:03:25< gfgtdf> celticminstrel: how is that related? i dont think the lobby player list has nested toggle penls 20170410 21:03:27< gfgtdf> panels 20170410 21:03:44< celticminstrel> Well, it's a tree view, at least. 20170410 21:04:09< celticminstrel> And IIRC it uses disclosure triangles. 20170410 21:07:21< gfgtdf> celticminstrel: well sure, thats what treeeviews are supposwed to do. 20170410 21:11:46-!- atarocch [~atarocch@37.176.56.55] has joined #wesnoth-dev 20170410 21:22:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 21:26:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 21:27:09< gfgtdf> is thre nowdays anythign that [multi_page] can do that [stackred_widget] doesn't ? 20170410 21:27:21< celticminstrel> Uh. They're totally different? 20170410 21:27:38< celticminstrel> [multi_page] is homogenous, [stacked_widget] is heterogenous. 20170410 21:28:05< celticminstrel> stacked_widget also allows showing multiple layers simultaneously. 20170410 21:28:49< celticminstrel> I think stacked_widget is also fixed-size? I could be wrong on that one though. 20170410 21:28:55< gfgtdf> celticminstrel: yes but i can till ad the same type of page multiple tiems in a [stackred_widget] by just puttin in the same wml multiple times 20170410 21:29:24< celticminstrel> You can, sure... 20170410 21:31:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20170410 21:58:31< gfgtdf> hm indention_step_size= seems to be borken in 1.13.7 20170410 21:58:44< celticminstrel> Huh? 20170410 21:58:55< celticminstrel> Oh. 20170410 21:58:57< celticminstrel> Spelling. 20170410 21:59:02< celticminstrel> Maybe? 20170410 21:59:07< celticminstrel> indentation_step_size? 20170410 21:59:39< celticminstrel> gfgtdf: Was this in a Lua-built dialog? 20170410 21:59:54< gfgtdf> celticminstrel: yes 20170410 22:00:27< celticminstrel> Hmm, but tree views weren't even really accessible to Lua in 1.12, right? 20170410 22:00:42< celticminstrel> So maybe breaking compatibility isn't an issue? As long as it's noted. 20170410 22:01:05< celticminstrel> Speaking of which, someone will need to update the GUI2 documentation before the 1.14 release. 20170410 22:01:18< celticminstrel> Which means both updating any doc comments and regenerating the wiki pages. 20170410 22:01:23< gfgtdf> celticminstrel: hmm ye i doubt anyone other then me used treevies in umc addons. 20170410 22:02:35< gfgtdf> celticminstrel: ok works again renaming. 20170410 22:03:00< celticminstrel> "works again renaming" 20170410 22:03:14< celticminstrel> You mean changing it to indentation instead of indention made it work? 20170410 22:04:59< gfgtdf> yes 20170410 22:05:20< gfgtdf> there was a mising 'after' after 'again' 20170410 22:06:41< celticminstrel> That's what I suspected. 20170410 22:14:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 22:15:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 22:17:23< vultraz_iOS> celticminstrel: i think you forgot to update something in help.cpp... 20170410 22:17:34< celticminstrel> ??? 20170410 22:17:51< celticminstrel> Oh, I did comment out the non-GUI2 content of show_help. 20170410 22:17:59< celticminstrel> So perhaps there's an error in there. 20170410 22:18:05< celticminstrel> It's possible, I suppose. 20170410 22:18:11< vultraz_iOS> no i meant the arguments to display() 20170410 22:18:16< vultraz_iOS> but i got it 20170410 22:18:27< celticminstrel> ...oh you're right. 20170410 22:18:41< celticminstrel> I staged those twice, but then unstaged them to make a separate commit first. 20170410 22:18:52< celticminstrel> And I guess I forgot to stage them the third time. 20170410 22:18:59< celticminstrel> I'm going to push them. 20170410 22:19:52< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 43426e69899a / src/gui/widgets/tree_view_node.cpp: Tree View Node: Minor fixup to expand parents option https://github.com/wesnoth/wesnoth/commit/43426e69899a9a25b6301adbe679e378cd88837c 20170410 22:19:54< irker332> wesnoth: Celtic Minstrel wesnoth:gui2_help 4f574507120a / src/help/help.cpp: fixup d1f4a898 https://github.com/wesnoth/wesnoth/commit/4f574507120ae0524ce6d496c6fd06ea50f740b5 20170410 22:21:52< irker332> wesnoth: Charles Dang wesnoth:gui2_help f72b725f10aa / data/gui/window/help_browser.cfg: Help Browser: fixup topic title layout https://github.com/wesnoth/wesnoth/commit/f72b725f10aa456312da1c1a7536794561b8cbb5 20170410 22:22:15< celticminstrel> There's also a layout problem when viewing help from in-game - the ToC is too wide. 20170410 22:22:33< celticminstrel> Possibly only if you enter via D or Ctrl+T? 20170410 22:22:45< celticminstrel> Also, I think the invalidate_layout is no longer needed... 20170410 22:22:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20170410 22:27:22< celticminstrel> And hidden topics don't appear to work, and there's an Unknown Unit at the end of the unit topic list... 20170410 22:27:54< celticminstrel> (Tested hidden topics with Konrad+scepter.) 20170410 22:29:51< irker332> wesnoth: gfgtdf wesnoth:gfgtdf-patch-unfoldnode 32b2630c0b6a / src/scripting/lua_gui2.cpp: wesnoth.set_dialog_value can now unfold treeview nodes https://github.com/wesnoth/wesnoth/commit/32b2630c0b6aeb79e2801a0c077469756ed6f171 20170410 22:31:31< vultraz_iOS> celticminstrel: must be some unnecessary whitespace somewhere 20170410 22:31:40< celticminstrel> ??? 20170410 22:32:39< irker332> wesnoth: Charles Dang wesnoth:gui2_help fbfe22233834 / data/gui/window/help_browser.cfg: Help Browser: removed help topic padding https://github.com/wesnoth/wesnoth/commit/fbfe222338344902f317aebe4ec215c9ab51c305 20170410 22:32:51< vultraz_iOS> to create the extra space when launched from the game 20170410 22:34:00< celticminstrel> I don't really get it? 20170410 22:34:54< vultraz_iOS> ... 20170410 22:35:12< vultraz_iOS> I'm suspecting unnecessary whitespace in a in-game only topic title 20170410 22:37:31< vultraz_iOS> celticminstrel: and the invalidate_layout is still needed because otherwise the new pages will never be drawn 20170410 22:37:57< vultraz_iOS> celticminstrel: possibly a multipage bug if it doesn't support adding new pages dynamically without needed to call invalidate_layout 20170410 22:39:14< celticminstrel> Oh, wait, the invalidate layout was on topic select, right. 20170410 22:40:40< vultraz_iOS> listboxes do some additional calculations when adding rows.... possibly multipages should also 20170410 22:41:06< celticminstrel> Oh, looks like maybe Konrad+sceptre wasn't a good test? It looks like that wouldn't've shown a hidden topic in the old dialog either. 20170410 22:41:53< celticminstrel> vultraz_iOS: Well, theoretically, adding a page to a multipage shouldn't require a relayout since it uses the same layout just with different content... 20170410 22:42:06< vultraz_iOS> then why does it need it? 20170410 22:42:19< vultraz_iOS> it's all label contents 20170410 22:43:27< celticminstrel> IIRC, topics didn't show up at all without it. 20170410 22:43:39< vultraz_iOS> yes 20170410 22:43:44< vultraz_iOS> but why is that so 20170410 22:49:00< celticminstrel> Not sure. 20170410 22:50:35< vultraz_iOS> I'd do away with the multipage 20170410 22:50:46< vultraz_iOS> except I suspect we wont just have a label 20170410 22:51:46< celticminstrel> Not 100% sure what we'll have. 20170410 22:52:15< vultraz_iOS> neither do I 20170410 22:53:36< celticminstrel> The only problematic formattings are and , I think. 20170410 22:53:47< vultraz_iOS> what does jump do again? 20170410 22:54:00< celticminstrel> It seems to be used for the tables in unit descriptions. 20170410 22:54:06< celticminstrel> I think it's something like a tab stop. 20170410 22:54:11< vultraz_iOS> I see 20170410 22:54:48< celticminstrel> Haven't investigated too closely, but currently I'm just parsing it to a single tab. 20170410 22:55:26< vultraz_iOS> probably was similar to the GUI1 COLUMN_SEPARATOR which somehow managed to get everything lined up in a column, 20170410 22:55:53< celticminstrel> Gasp! Pango seems to support tab stops!? 20170410 22:56:05< celticminstrel> Might've been! 20170410 22:56:45< celticminstrel> https://developer.gnome.org/pango/stable/pango-Tab-Stops.html 20170410 22:58:33< vultraz_iOS> let's fix Image first. 20170410 22:58:39< vultraz_iOS> then we can do tables 20170410 22:59:30< vultraz_iOS> the problem here is we need some way to dynamically generate page contents/layouts... 20170410 22:59:47< vultraz_iOS> in FFL that would be easy.... here.. not so much 20170410 23:01:04< celticminstrel> As for images, Pango does appear to support inline ones with some difficulty. http://stackoverflow.com/a/30416800 20170410 23:01:11< celticminstrel> But that's not sufficient for our needs. 20170410 23:01:24< celticminstrel> Ack, mistyped. :( 20170410 23:01:30< vultraz_iOS> say, for images. we'd need to be able to insert a grid row with an image... 20170410 23:01:38< vultraz_iOS> well, one *can* insert grid rows.. 20170410 23:01:44< celticminstrel> http://stackoverflow.com/a/30415800 20170410 23:01:45< vultraz_iOS> I've just never tried 20170410 23:03:50< celticminstrel> For floating images, I think the only way is to manually split the text into two chunks if it ends up significantly taller than the image. 20170410 23:04:32 * vultraz_iOS misses FFL's spawn() command right now 20170410 23:04:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170410 23:06:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170410 23:07:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170410 23:07:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 23:10:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170410 23:10:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 23:26:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170410 23:27:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170410 23:51:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170410 23:51:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 23:53:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170410 23:53:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170410 23:56:08-!- atarocch [~atarocch@37.176.56.55] has quit [Remote host closed the connection] --- Log closed Tue Apr 11 00:00:20 2017