--- Log opened Wed Apr 12 00:00:05 2017 20170412 00:02:38< celticminstrel> s/.108/.cpp:108/ 20170412 00:02:49< vultraz_iOS> ^ 20170412 00:03:02< matthiaskrgr> yeah I figured :P 20170412 00:04:06< matthiaskrgr> it's building™ 20170412 00:07:11< matthiaskrgr> assert doesn't fire :/ 20170412 00:10:12< vultraz_iOS> :/ 20170412 00:10:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has joined #wesnoth-dev 20170412 00:11:06< matthiaskrgr> <- zzz 20170412 00:15:49-!- irker337 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170412 00:31:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has quit [Remote host closed the connection] 20170412 00:38:47-!- Shiki [~Shiki@p548546C8.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20170412 00:52:17-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170412 01:04:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20170412 01:23:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 01:42:31-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev 20170412 01:50:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection] 20170412 02:52:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20170412 03:07:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170412 03:07:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170412 03:21:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has joined #wesnoth-dev 20170412 03:27:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has quit [Remote host closed the connection] 20170412 03:35:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has joined #wesnoth-dev 20170412 03:41:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170412 03:42:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170412 03:45:50< celticminstrel> vultraz_iOS: Possible [message] issue: https://forums.wesnoth.org/viewtopic.php?f=8&t=45215#p610597 20170412 03:46:21< vultraz_iOS> what's the problem? 20170412 03:46:29< celticminstrel> The message at the top is cut off. 20170412 03:46:36< celticminstrel> I think. 20170412 03:46:46< vultraz_iOS> ok 20170412 03:49:01< celticminstrel> Just FTR, I found that from here. https://forums.wesnoth.org/viewtopic.php?p=610600#p610600 20170412 03:55:02 * vultraz_iOS is having a hard time implementing gfgtdf's suggestions for spacers 20170412 03:55:08-!- irker990 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170412 03:55:08< irker990> wesnoth: Celtic Minstrel wesnoth:master e3b5213f21cb / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/e3b5213f21cb4858a21863d33b1491c069205434 20170412 03:58:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:7451:6594:db7c:3a5a] has quit [Remote host closed the connection] 20170412 04:03:34-!- JyrkiVesterinen [~JyrkiVest@87-100-214-179.bb.dnainternet.fi] has joined #wesnoth-dev 20170412 04:05:22< celticminstrel> BTW vultraz_iOS, please update changelog about the storyscreen (and anything else you might have done, but mainly the storyscreen). 20170412 04:34:06-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev 20170412 05:03:35-!- Kwandulin [~Kwandulin@p200300760F3E7DD8AC43FCB851E6E1C3.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170412 05:16:44< irker990> wesnoth: Charles Dang wesnoth:master da5f00c2b671 / src/gui/widgets/ (spacer.cpp spacer.hpp): GUI2/Spacer: delegate size caluclations to the widget instead of the builder https://github.com/wesnoth/wesnoth/commit/da5f00c2b671b79fcec8c36aa5316e1c7663a355 20170412 05:20:16< vultraz_iOS> Need to do that for drawing and size_lock too 20170412 05:26:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170412 05:30:52-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20170412 05:31:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170412 05:35:59< Kwandulin> Mhhh, refreshed lua/wml-tags.lua and lua/wml/animate_unit.lua from master and animations still don't work. Is there more to update? https://www.dropbox.com/s/hg1kavafy3pmo6v/meh.jpg?dl=0 20170412 05:37:36< Kwandulin> Apparently, all the other stuff that happens within an [event] after the [animate_unit] doesn't fire, which totally breaks my stuff 20170412 05:40:52< vultraz_iOS> celticminstrel: ^ 20170412 05:40:54< Kwandulin> Okay, it doesn*t work, when there's a "text= _ "Blub" " inside [animate_unit] 20170412 05:41:12< Kwandulin> It does work, when I remove the text thing 20170412 05:41:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20170412 05:41:25< Kwandulin> (It did work in 1.13.6 even with the text thing) 20170412 05:42:23< celticminstrel> Just using the master version of those files in 1.13.7 isn't necessarily going to work. 20170412 05:44:26< Kwandulin> Guess I*ll have to wait then 20170412 05:45:09< celticminstrel> I can't see anything in the source that would produce that error message, either... 20170412 06:00:27< irker990> wesnoth: Charles Dang wesnoth:master f0dffab55a84 / / (3 files in 3 dirs): Tree View Node: rename tree_view_node_icon to tree_view_node_toggle https://github.com/wesnoth/wesnoth/commit/f0dffab55a84e2355bba147aaac822ae2ccc0888 20170412 06:00:28< vultraz_iOS> celticminstrel: ^ you'll need to apply that change to the help browser code when you rebase 20170412 06:08:57-!- TC02 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 240 seconds] 20170412 06:11:57-!- TC02 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev 20170412 06:33:35-!- JyrkiVesterinen [~JyrkiVest@87-100-214-179.bb.dnainternet.fi] has quit [Quit: .] 20170412 06:44:10-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me] 20170412 06:45:29< irker990> wesnoth: Charles Dang wesnoth:master 7d8380cd8781 / src/gui/dialogs/ (85 files in 5 dirs): GUI2: marked inherited dialog functions (pre_show, etc) as virtual override https://github.com/wesnoth/wesnoth/commit/7d8380cd8781693871e5c45649e9fcb94dddccb7 20170412 06:47:40< vultraz_iOS> oh, few erroneous specifiers snuck in... 20170412 06:49:49< vultraz_iOS> mp_change_control.cpp and chat_log.cpp.. 20170412 06:49:55< vultraz_iOS> I think those are erroneous .. 20170412 06:53:40< celticminstrel> If they're erroneous, there will be Travis errors. 20170412 06:55:24-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 260 seconds] 20170412 06:55:36-!- AI0867_ [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 268 seconds] 20170412 06:55:56-!- AI0867 [~ai@uruz.ai0867.net] has joined #wesnoth-dev 20170412 06:56:01-!- AI0867 [~ai@uruz.ai0867.net] has quit [Changing host] 20170412 06:56:01-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev 20170412 06:56:03-!- TC01 [~quassel@venus.arosser.com] has quit [Read error: Connection reset by peer] 20170412 06:56:13-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev 20170412 06:57:43< irker990> wesnoth: Charles Dang wesnoth:master 4f76c90d5c2f / src/gui/dialogs/ (chat_log.cpp multiplayer/mp_change_control.cpp): Revert erroneous change in 7d8380cd8781 https://github.com/wesnoth/wesnoth/commit/4f76c90d5c2f0b2809ffc48a75837c1518ee166b 20170412 06:57:55-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev 20170412 07:05:10-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer] 20170412 07:07:32-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20170412 07:08:51-!- vincent_c [~bip@vcheng.org] has quit [Client Quit] 20170412 07:09:18-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20170412 07:09:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20170412 07:10:37-!- vincent_c [~bip@vcheng.org] has quit [Client Quit] 20170412 07:13:05-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev 20170412 07:14:27-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20170412 07:15:05-!- vincent_c [~bip@vcheng.org] has quit [Client Quit] 20170412 07:17:41-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev 20170412 07:25:13-!- atarocch [~atarocch@31.157.182.26] has joined #wesnoth-dev 20170412 07:46:20-!- celticminstrel is now known as celmin|sleep 20170412 08:29:03-!- silentcontrib [~quassel@lewis.freescotcoll.ac.uk] has joined #wesnoth-dev 20170412 08:38:47-!- Kwandulin [~Kwandulin@p200300760F3E7DD8AC43FCB851E6E1C3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20170412 09:02:54-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .] 20170412 09:11:31-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-qleptctfwugwubxj] has quit [Write error: Connection reset by peer] 20170412 09:15:00-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-carmuixceyagqjux] has joined #wesnoth-dev 20170412 09:32:53-!- Shiki [~Shiki@141.57.57.138] has joined #wesnoth-dev 20170412 09:37:07-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev 20170412 09:58:12-!- irker990 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170412 10:17:42-!- Appleman1234 [~Appleman1@pl28824.ag1212.nttpc.ne.jp] has quit [Ping timeout: 245 seconds] 20170412 10:20:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 10:42:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 10:44:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 10:46:47-!- Shiki [~Shiki@141.57.57.138] has quit [Remote host closed the connection] 20170412 10:58:15-!- Appleman1234 [~Appleman1@pl25717.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170412 11:02:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170412 11:04:27-!- irker931 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20170412 11:04:27< irker931> wesnoth: Charles Dang wesnoth:master c834d9955682 / / (3 files in 2 dirs): Preferences: convert hotkey category list to a dropdown w/ checkboxes https://github.com/wesnoth/wesnoth/commit/c834d9955682477340583278ae9bde2b6c7d37f6 20170412 11:16:28< vultraz_iOS> celmin|sleep: i have a great idea for a use of the grid listbox in presenting unit lists in the help browser, once we get there 20170412 11:25:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 11:31:52-!- silentcontrib [~quassel@lewis.freescotcoll.ac.uk] has quit [Ping timeout: 255 seconds] 20170412 12:22:34-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has joined #wesnoth-dev 20170412 12:30:30< vultraz_iOS> gfgtdf: i implemented your suggestion and moved spacer size calc to the widget 20170412 12:43:34< irker931> wesnoth: Charles Dang wesnoth:master de8419deb725 / src/gui/dialogs/preferences_dialog.cpp: Preferences Dialog: removed a hack related to the grid listbox usage https://github.com/wesnoth/wesnoth/commit/de8419deb7252cc76b7d44f0f2572f2845a7ebcd 20170412 12:52:42< celmin|sleep> It's not needed now? 20170412 12:53:10< vultraz_iOS> it's not there anymore 20170412 12:53:38< celmin|sleep> Ah. 20170412 12:54:01< vultraz_iOS> it just didn't fit here 20170412 12:54:11< vultraz_iOS> it will fit in the help pages though 20170412 13:07:08< gfgtdf> vultraz_iOS: did it work ? 20170412 13:07:16< vultraz_iOS> i don't know 20170412 13:07:30< vultraz_iOS> resizing during the loading screen didn't crash, but i don't know if it did before 20170412 13:07:53< gfgtdf> it did in >50% of cases, t lest when the size reduction was large enough 20170412 13:08:15< vultraz_iOS> oh, i was maximizing 20170412 13:08:30< gfgtdf> vultraz_iOS: no you need to reduce the size, so for exampel un-maximizing 20170412 13:08:45< vultraz_iOS> ok 20170412 13:08:49< vultraz_iOS> no it does not crash 20170412 13:08:53< gfgtdf> vultraz_iOS: you can try that in 1.13.7 relese , it will cose wensoth immidiateley 20170412 13:09:00< gfgtdf> close 20170412 13:09:05< vultraz_iOS> now it takes you back to the titlescreen :P 20170412 13:09:12< vultraz_iOS> but it doesn't crash 20170412 13:09:18< gfgtdf> actuall onyl the verticl size decrease matters. 20170412 13:09:24< gfgtdf> hmm 20170412 13:09:35< vultraz_iOS> I think that's related to uhh 20170412 13:09:46< vultraz_iOS> there's an open bug to do with the titlescreen loop 20170412 13:10:47< vultraz_iOS> gfgtdf: https://gna.org/bugs/index.php?25584 20170412 13:11:06< gfgtdf> ah yes that looks liek it 20170412 13:11:34< vultraz_iOS> see my comment #4 20170412 13:11:43< vultraz_iOS> i couldn;t figure out how to fix it 20170412 13:13:39< gfgtdf> i just tested and i coudnt reprprduce https://gna.org/bugs/index.php?25584 on 1.13.7 release 20170412 13:16:21< irker931> wesnoth: gfgtdf wesnoth:master c44de30a0921 / src/actions/move.cpp: remove unused bool return value https://github.com/wesnoth/wesnoth/commit/c44de30a0921b383dc42e01ae5c8b09d61e0a37e 20170412 13:16:23< irker931> wesnoth: gfgtdf wesnoth:master 4908124f6fe0 / src/actions/move.cpp: some clenaups https://github.com/wesnoth/wesnoth/commit/4908124f6fe04aeda1c99f871a0748e9bb987076 20170412 13:16:25< irker931> wesnoth: gfgtdf wesnoth:master 75c21815f686 / / (4 files in 3 dirs): allow multi_page to contain differnt types of pages https://github.com/wesnoth/wesnoth/commit/75c21815f686f77b09103bb8757fea1318d4ac5e 20170412 13:17:09< vultraz_iOS> gfgtdf: set the resolution to something non maximized first, open, say, the Multiplayer dialog, then maximize, and try to connect to server 20170412 13:17:59< gfgtdf> ok now i could reproduce 20170412 13:20:58-!- celmin|sleep is now known as celticminstrel 20170412 13:26:04< celticminstrel> gfgtdf: Please fix the missing doc comment. 20170412 13:26:11< celticminstrel> ^comments 20170412 13:26:24< celticminstrel> The functions on lines 78 and 58 need doc comments. 20170412 13:27:14< celticminstrel> Should suffice to copy-paste the comments from the preceding functions and just add @param lines for the extra parameters. 20170412 13:27:47-!- Appleman1234 [~Appleman1@pl25717.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds] 20170412 13:31:51< irker931> wesnoth: gfgtdf wesnoth:master 289cf35aa25e / src/gui/widgets/multi_page.hpp: add a comment https://github.com/wesnoth/wesnoth/commit/289cf35aa25e61977c3487af7ec971732f00cfd0 20170412 13:31:55< gfgtdf> celticminstrel: ^ 20170412 13:32:07-!- Appleman1234 [~Appleman1@pl25717.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170412 13:32:50< celticminstrel> Eh, close enough. 20170412 13:33:00< gfgtdf> wedge009: coudl you please ret3est https://gna.org/bugs/?21564 ? 20170412 13:54:01< vultraz_iOS> gfgtdf: btw in light of all these errors with sliders i think we should refactor sliders to not use scrollbars 20170412 13:54:09< vultraz_iOS> scrollbar as its base* 20170412 13:56:02< gfgtdf> vultraz_iOS: hm ye or at alterantiveley we coudl add a new baseclass for the things that are really used by both scrollbars and sliders. 20170412 13:56:30< gfgtdf> vultraz_iOS: currently scorllbar has multipel things, (visible_items, grip size calculations) that arent uses in sliders at all 20170412 13:56:44< vultraz_iOS> yeah 20170412 13:56:48< vultraz_iOS> it's kind a mess 20170412 13:56:51< vultraz_iOS> kinda a* 20170412 13:57:00< celticminstrel> Visible items? 20170412 14:11:40-!- Shiki [~Shiki@p54855372.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170412 14:21:45< gfgtdf> vultraz_iOS: do you want to do that ? 20170412 14:21:49< vultraz_iOS> uhh 20170412 14:21:51< vultraz_iOS> possibly 20170412 14:21:58< vultraz_iOS> but i wouldn't say no to someone else doing it 20170412 14:22:11< gfgtdf> ok 20170412 14:29:02< vultraz_iOS> ermeghard 20170412 14:29:17-!- Shiki [~Shiki@p54855372.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20170412 14:29:24< vultraz_iOS> celticminstrel: i have... STORYTEXT FADE IN AN OUT :O 20170412 14:29:44< celticminstrel> :D 20170412 14:29:58< vultraz_iOS> the impl is rather hacky but it *works* 20170412 14:30:43< vultraz_iOS> I really need to make this code generic 20170412 14:33:31< gfgtdf> vultraz_iOS: ok will try to ework on it 20170412 14:33:36< gfgtdf> (sliders) 20170412 14:34:09< celticminstrel> What do you mean by visible items? 20170412 14:34:23< celticminstrel> I'd say grip size calculations aren't necessarily meaningless for a slider... 20170412 14:34:42< celticminstrel> Though in practice I guess they're not usually used on a slider. 20170412 14:34:58< celticminstrel> gfgtdf: Did you have an idea for the base class name? 20170412 14:35:06< vultraz_iOS> celticminstrel: https://github.com/Vultraz/wesnoth/commit/084963d4af1c409661d33468f5997c1d4368d425 20170412 14:35:09< vultraz_iOS> comments plox 20170412 14:35:31< gfgtdf> celticminstrel: im hgoing for slider_base for now, im also unsure yet whether it'll be a base calss for scrollbar+slider or just slider 20170412 14:36:06< celticminstrel> slider_base sounds good to me, and I think I'd prefer if it's the base of the scrollbar class (I mean, what's the point of having a base class if it only has one subclass?). 20170412 14:36:40< celticminstrel> vultraz_iOS: Should I comment here or on github? 20170412 14:37:13< vultraz_iOS> here 20170412 14:37:27< celticminstrel> I don't think you should change all the standard font macros to be formulas. 20170412 14:37:37< celticminstrel> ^font color 20170412 14:37:52< celticminstrel> I think you could instead define something like... 20170412 14:38:16< celticminstrel> #define FADE_COLOR KIND FORMULA 20170412 14:38:36< vultraz_iOS> having them be formulas is the easiest way 20170412 14:39:01< celticminstrel> "(" + {GUI__FONT_COLOR_{KIND} ALPHA=()} + "{FORMULA}" 20170412 14:39:03< celticminstrel> #enddef 20170412 14:39:12< celticminstrel> Ah, missed a close paren. 20170412 14:39:26< celticminstrel> Things that are constants 90% of the time probably shouldn't be formulas. 20170412 14:39:30< vultraz_iOS> little messy... 20170412 14:39:44< celticminstrel> It's a little messy once in order to hide away the mess in one place. 20170412 14:39:47< vultraz_iOS> i suppose i could do that though 20170412 14:40:19< celticminstrel> The idea being to pass an empty string as the ALPHA parameter to the original font macro. 20170412 14:40:28< celticminstrel> Then insert that macro at the beginning of a formula. 20170412 14:40:37< celticminstrel> Oh yeah, I mssed the brackets too, so it would be like... 20170412 14:40:44< celticminstrel> "([" + {GUI__FONT_COLOR_{KIND} ALPHA=()} + "{FORMULA}])" 20170412 14:41:04< celticminstrel> Something like that. 20170412 14:42:30< celticminstrel> Not entirely sure if ALPHA=() sets it to an empty string. Maybe it needs to be just ALPHA= 20170412 14:43:42< celticminstrel> I'm also a little dubious about enabling text alpha on all labels like that. 20170412 14:43:58< vultraz_iOS> give me an easier way to do it 20170412 14:44:25< celticminstrel> Well, the only other way would be to have a separate label definition for labels that accept text_alpha. 20170412 14:44:43< celticminstrel> And there's one more thing... 20170412 14:44:48< vultraz_iOS> not a good idea 20170412 14:44:51< celticminstrel> What happens when you click next before the fade-in finishes? 20170412 14:44:55< celticminstrel> Why is it not a good idea? 20170412 14:45:11< vultraz_iOS> that we'd have to duplicate a definition every time we want one w/ alpha control 20170412 14:45:30< celticminstrel> I don't think the cost of more definitions is that strong, but okay. 20170412 14:45:53< celticminstrel> Are the font colour macros are used in many places besides the label definition? 20170412 14:46:06< vultraz_iOS> celticminstrel: it starts fading again. I need to fix that 20170412 14:46:11< vultraz_iOS> uh a few? 20170412 14:46:32< celticminstrel> vultraz_iOS: Clicking next while the text is fading in should force it to show fully, rather than going to the next slide. 20170412 14:46:40< celticminstrel> That's how the old storyscreen worked too. 20170412 14:47:01< vultraz_iOS> oh i thought you said fade-out 20170412 14:49:40 * vultraz_iOS deploys LE TRIBOOL 20170412 14:50:14< celticminstrel> Why tribool? Is tribool really what you want here? 20170412 14:51:03< vultraz_iOS> yes 20170412 14:51:13< celticminstrel> Relevant: http://www.boost.org/doc/libs/1_63_0/libs/optional/doc/html/boost_optional/a_note_about_optional_bool_.html 20170412 14:52:28< celticminstrel> Anyway, what do you need a tribool for? 20170412 14:52:46< celticminstrel> (I'm mentioning this mainly because the last time you used a tribool was questionably appropriate.) 20170412 14:53:10< vultraz_iOS> what? 20170412 14:53:18< vultraz_iOS> what was wrong with it the last time 20170412 14:54:08< vultraz_iOS> i deployed it to replace a local tribool impl 20170412 14:54:54< vultraz_iOS> anyway, im using it for fade_in_ here 20170412 14:56:03< vultraz_iOS> fading_in_* 20170412 14:56:30< celticminstrel> "local tribool impl" 20170412 14:59:11< celticminstrel> tristate was not really a tribool implementation. 20170412 15:00:10< celticminstrel> It did not follow any three-value logic system. 20170412 15:02:24< celticminstrel> Rather than a tribool, semantically it was more like an optional 20170412 15:03:32< celticminstrel> Which is why your fixup was required. 20170412 15:03:47< celticminstrel> BTW, a better fixup would've been to use && or || 20170412 15:04:12< celticminstrel> tristate_to_bool(a, true) would be a && true, and tristate_to_bool(a, false) would be a || false, I think. 20170412 15:04:21< celticminstrel> Or, wait. 20170412 15:04:25< celticminstrel> Would the latter work... 20170412 15:04:32< celticminstrel> Actually hmm. 20170412 15:04:39< celticminstrel> Neither would work, would they...? 20170412 15:05:16< celticminstrel> Yeah, maybe that wouldn't work... 20170412 15:05:35-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .] 20170412 15:06:41 * celticminstrel ponders. 20170412 15:07:37< vultraz_iOS> ok, i clicking next while fading out will immediately pass to the next part 20170412 15:07:58< celticminstrel> Okay I'm going to draw up a truth-table to see if anything I said can make sense in any way. 20170412 15:11:36< celticminstrel> I was wrong, indeed. 20170412 15:12:14< celticminstrel> That said, you probably could've simplified it to !indeterminate(result.primary_frame) 20170412 15:12:35< celticminstrel> Wait, is that right? The default was true. 20170412 15:12:56< celticminstrel> Maybe != false? 20170412 15:13:41< celticminstrel> I guess that won't work either. 20170412 15:13:53< celticminstrel> Meh. 20170412 15:17:16< celticminstrel> You know, I wonder if perhaps tristate_to_bool being used in only one place was actually an error... 20170412 15:19:16< celticminstrel> The old tristate implicitly converted to bool, after all, with the unset state becoming true (which actually rendered that one use of it pointless). 20170412 15:19:38< celticminstrel> Wait... doesn't tribool coerce the indeterminate state to false? 20170412 15:19:54< celticminstrel> So that commit changed the default for auto_v_flip and auto_h_flip from true to false? 20170412 15:21:39< celticminstrel> ...AnimationWML doesn'y specify what the default is. >< 20170412 15:21:41< celticminstrel> ^doesn't 20170412 15:21:51< celticminstrel> The wiki page, I mean. 20170412 15:22:15< celticminstrel> Have there been reports about something like this, zookeeper, vultraz_iOS> 20170412 15:22:17< celticminstrel> ? 20170412 15:33:28< vultraz_iOS> I thought I read that indeterminate was false or something but now looking at the docs it seems to be not 20170412 15:33:49< celticminstrel> Well no, indeterminate is maybe. 20170412 15:34:17< celticminstrel> But "bool b = indeterminate" sets b to false. 20170412 15:34:35< celticminstrel> According to the Boost 1.63 docs I just read. 20170412 15:35:33< vultraz_iOS> I see 20170412 15:37:27< zookeeper> celticminstrel, someone said something about flips recently, but maybe it was whoever prompted you to work on whatever it is you're doing 20170412 15:37:54< celticminstrel> Can you remember where they said this? 20170412 15:38:19< celticminstrel> The thing that prompted me was just vultraz saying he's using tribool again which prompted me to look back at that commit. 20170412 15:38:24< zookeeper> well, since it wasn't in IRC it must have been on the forums 20170412 15:39:05< zookeeper> oh, i think it was just this: https://forums.wesnoth.org/viewtopic.php?f=12&t=45211 20170412 15:39:51< zookeeper> which commit are you talking about? 20170412 15:40:48< celticminstrel> https://github.com/wesnoth/wesnoth/commit/42f087abb 20170412 15:41:01< celticminstrel> Specifically the tristate part of it. 20170412 15:41:21< vultraz_iOS> :| 20170412 15:41:23< vultraz_iOS> y u do dis 20170412 15:41:31< celticminstrel> ??? 20170412 15:41:51< zookeeper> oh, that recent. i don't recall anyone complaining about flips being wrong in 1.13.7 or master. 20170412 15:42:01< gfgtdf> we have an util:: and an utils:: namespace ... 20170412 15:42:10< vultraz_iOS> indeed 20170412 15:42:19< celticminstrel> Rename util to utils? 20170412 15:42:49< gfgtdf> ye i think that'd make sense 20170412 15:43:17< celticminstrel> I have sed, should I do the rename? 20170412 15:44:58< gfgtdf> yes 20170412 15:48:27< celticminstrel> Heh, I'm pulling from mac to windows and from windows to mac at the same time. 20170412 15:51:03< celticminstrel> (Was grabbing my stale branches from Mac so I could work on some of them.) 20170412 16:04:37< zookeeper> hrhm, purple xp bars. i guess i'm still unsure whether those should signal "no advancement to a new unit type" or "only standard +3hp AMLA (or other almost-meaningless bonus)". 20170412 16:05:52< Soliton> the latter is what most people will expect since the former being a notable distinction is rare, i'd say. 20170412 16:07:00< irker931> wesnoth: ln-zookeeper wesnoth:master 2f7f9a3f7189 / data/campaigns/Under_the_Burning_Suns/ (_main.cfg units/quenoth/Youth.cfg): UtBS: Prevents Kaleh and Nym having purple XP bars while choices remain https://github.com/wesnoth/wesnoth/commit/2f7f9a3f718994904d7fa6a79a30622f2fc0524e 20170412 16:07:00< zookeeper> yeah 20170412 16:07:44< matthiaskrgr> can't read XP without thinking of some smiley :/ 20170412 16:07:47< celticminstrel> Might consider adding something in [advancement] for this, but would need to decide on a key name. 20170412 16:07:55< celticminstrel> XP is indeed a smiley. :P 20170412 16:08:06< matthiaskrgr> windows XP 20170412 16:08:07< celticminstrel> Though apparenttly my client doesn't convert it. 20170412 16:08:25< zookeeper> a new [advancement] key does make sense, sure 20170412 16:08:56 * celticminstrel is still disappointed by the removal of the moon shyde line BTW. 20170412 16:09:08< zookeeper> yeah i've heard you say that quite a few times :p 20170412 16:09:13< celticminstrel> :P 20170412 16:09:20< celticminstrel> This is true. 20170412 16:10:39< celticminstrel> I have the util -> utils rename done, just building to make sure it's all good. 20170412 16:18:39-!- JyrkiVesterinen [~JyrkiVest@87-100-140-150.bb.dnainternet.fi] has joined #wesnoth-dev 20170412 16:20:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 16:31:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds] 20170412 16:36:35< vultraz_iOS> celticminstrel: color = "([{FONT_COLOR_ENABLED} text_alpha])" is how it eventually came out 20170412 16:37:20< celticminstrel> It works like that? I thought it wouldn't because the font color macros include quotes. 20170412 16:37:33< vultraz_iOS> it needs to work like that because it includes quotes 20170412 16:37:41< celticminstrel> ??? 20170412 16:37:46< vultraz_iOS> that is, it doesn't work like the way you proposed because it has quotes 20170412 16:37:57< celticminstrel> That doesn't make any sense? 20170412 16:38:31< vultraz_iOS> color = "([" + {FONT_COLOR_ENABLED} + " text_alpha])" 20170412 16:38:37< vultraz_iOS> gives unexpected characters at line start 20170412 16:38:54< celticminstrel> If {FONT_COLOR_ENABLED} expands to "12, 12, 12", then what you write would expand to "(["12, 12, 12" text_alpha]}" 20170412 16:39:10< celticminstrel> ...which I guess is still valid WML though. 20170412 16:39:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20170412 16:39:41< vultraz_iOS> dunno why it, just happens to work like this 20170412 16:39:50< celticminstrel> Oh, I think I know why the way I proposed gives that error. 20170412 16:40:06< celticminstrel> IIRC the #enddef was on a line of its own. 20170412 16:40:20< vultraz_iOS> yes 20170412 16:40:24< celticminstrel> That's the problem. 20170412 16:40:35< celticminstrel> If you wrote "12, 12, 12" #enddef 20170412 16:40:36-!- atarocch [~atarocch@31.157.182.26] has quit [Ping timeout: 260 seconds] 20170412 16:40:41< celticminstrel> Then the version with +'s should work. 20170412 16:41:22< vultraz_iOS> nope 20170412 16:41:31< vultraz_iOS> now wesnoth doesn't even spit an error to console 20170412 16:41:51< celticminstrel> Or wait, did zookeeper fix #arg yet? 20170412 16:41:56< vultraz_iOS> he did 20170412 16:41:59< celticminstrel> Okay. 20170412 16:42:15< celticminstrel> So what happens with what I just described, then? 20170412 16:42:48< celticminstrel> Mind you, if the version you had does work, I suppose you're free to use it, but in fact both should work, so there may still be a bug here. 20170412 16:42:56< vultraz_iOS> immediate crash on startup 20170412 16:43:01< vultraz_iOS> no console 20170412 16:43:20< celticminstrel> That's pretty serious. 20170412 16:43:35< celticminstrel> Could you maybe make a simple WML file as a test? 20170412 16:44:00< vultraz_iOS> later 20170412 16:44:08< celticminstrel> Well, that's assuming it's a WML problem and not a GUI2 problem, mind you. 20170412 16:44:18< celticminstrel> A stack trace would also help here. 20170412 16:48:40< vultraz_iOS> why didn't we define ALPHA_TRANSPARENT? 20170412 16:48:48< celticminstrel> No idea. 20170412 16:52:04< gfgtdf> any opinion how slider with invalid data (min=1, max=3, step=4) should behave (which value should be ignored)? 20170412 16:52:33< vultraz_iOS> step 20170412 16:52:38< vultraz_iOS> default to 1 20170412 16:53:29< celticminstrel> I dunno. 20170412 16:53:45< celticminstrel> In that example it seems to me that the slider should only offer the two endpoint values, making the step 2. 20170412 16:54:06< celticminstrel> BTW, what do you do if min > max? Swap them? 20170412 16:56:14< vultraz_iOS> celticminstrel: what should be the behavior of pressing BACK when fading in? 20170412 16:56:35< celticminstrel> Uh. Good question. Check what the old storyscreen does? 20170412 16:56:49< vultraz_iOS> ok 20170412 16:56:54< celticminstrel> My guess would be just go back without any fade-in. 20170412 16:57:07< celticminstrel> (Back should never have a fade actually.) 20170412 16:57:42< vultraz_iOS> fade is bi-directional 20170412 16:58:14< celticminstrel> Is it bi-directional in the old storyscreen? 20170412 16:58:21< celticminstrel> At the very least, fade when going back should be faster. 20170412 16:58:43< vultraz_iOS> I can implement something better later 20170412 17:01:37< irker931> wesnoth: Charles Dang wesnoth:master e0751c1f54b6 / / (6 files in 3 dirs): GUI2: implement ability to set label alpha https://github.com/wesnoth/wesnoth/commit/e0751c1f54b679562a8376c3997a28f55169ad55 20170412 17:01:40< irker931> wesnoth: Charles Dang wesnoth:master c57b58628c7a / src/gui/dialogs/ (story_viewer.cpp story_viewer.hpp): Story Viewer: implement text alpha fade-in/fade-out between screens https://github.com/wesnoth/wesnoth/commit/c57b58628c7a520a37c0c38ef9144f7786b2df61 20170412 17:01:44< vultraz_iOS> zookeeper: ^ do give thoughts 20170412 17:05:39-!- atarocch [~atarocch@37.176.245.134] has joined #wesnoth-dev 20170412 17:05:45-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev 20170412 17:08:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20170412 17:11:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170412 17:12:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 17:20:07-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!] 20170412 17:26:37< zookeeper> vultraz_iOS, it's... not bad, i guess? how hard would it be to make the fadein and fadeout concurrent, though? 20170412 17:26:51< vultraz_iOS> impossible 20170412 17:26:55< zookeeper> as in, the other [part] changes would happen at the halfway poi... okay 20170412 17:29:06< vultraz_iOS> is this better or no different, quality-wise, than the old animation, do you think? 20170412 17:30:29< vultraz_iOS> though I'm thinking perhaps I should use an easing 20170412 17:30:49< vultraz_iOS> the linear fade is bound to get rather boring after awhile 20170412 17:31:24< celticminstrel> "impossible" 20170412 17:31:32< celticminstrel> You have the source code, nothing is impossible. :P 20170412 17:31:36< zookeeper> well, i'm inclined to think it's a bit better. the best would probably be to have the text appear one character at a time. 20170412 17:31:45< celticminstrel> Actually I had thought of that too. 20170412 17:31:50< celticminstrel> I believe that would be doable. 20170412 17:32:12< celticminstrel> Though I'm not sure if it would be doable and reasonably fast. 20170412 17:32:50< zookeeper> although, actually one character at a time might look too "technical" somehow (as in, seem like typing on a computer or something). not necessarily, but might be. 20170412 17:33:11< vultraz_iOS> too slow too 20170412 17:33:18< celticminstrel> True, true, but I would've made it an option so that the designer can choose. 20170412 17:33:38< celticminstrel> Maybe I'll look at Vultraz's code and see if I can make it work. 20170412 17:33:54< vultraz_iOS> I'm pondering if i can tweak my API a little 20170412 17:34:06< zookeeper> there's all sorts of other effects that one could apply to make the fades look even nicer, dunno about performance though 20170412 17:34:10< vultraz_iOS> to avoid all the management calls.. 20170412 17:34:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20170412 17:34:32< irker931> wesnoth: Jyrki Vesterinen wesnoth:master 48142dd8212a / src/gui/widgets/ (widget.cpp widget.hpp): Fix advanced preferences not shrinking when the player deselects them https://github.com/wesnoth/wesnoth/commit/48142dd8212a33891b26a0dfe06dba8393e9e049 20170412 17:35:21< zookeeper> for example usually blur works nicely with a fade, but that's presumably too expensive on a big animated surface like that 20170412 17:35:44< vultraz_iOS> yeah we really need HW accl if we want stuff like that 20170412 17:35:52< vultraz_iOS> and shaders 20170412 17:35:55< celticminstrel> Technically not true, but whatever. 20170412 17:36:00< vultraz_iOS> to make the text fly around the room 20170412 17:36:01< vultraz_iOS> :P 20170412 17:39:15< zookeeper> no no no, of course the text needs to elegantly morph into the next text 20170412 17:39:24< vultraz_iOS> yeah 20170412 17:39:35< zookeeper> good luck writing a shader for that... :J 20170412 17:42:45< matthiaskrgr> https://pastebin.com/y0KwU4Uw 20170412 17:43:35< celticminstrel> \o/ 20170412 17:45:23< irker931> wesnoth: Jyrki Vesterinen wesnoth:master f93353bebb9f / src/gui/dialogs/multiplayer/synced_choice_wait.hpp: Add an override specifier https://github.com/wesnoth/wesnoth/commit/f93353bebb9f254d4c82bd75d8638a69888915e7 20170412 17:45:29< JyrkiVesterinen> matthiaskrgr: ^ 20170412 17:45:57< matthiaskrgr> building ... 20170412 17:47:54 * matthiaskrgr needs a faster sys :( 20170412 17:48:58< pydsigner> I wonder how good a Ryzen 5 would be for running gcc 20170412 17:49:41< JyrkiVesterinen> It should be excellent. GCC scales very well for many threads. 20170412 17:49:45 * JyrkiVesterinen is drooling 20170412 17:49:54< irker931> wesnoth: Celtic Minstrel wesnoth:master a8361986e909 / src/ (32 files in 11 dirs): Rename namespace util -> utils https://github.com/wesnoth/wesnoth/commit/a8361986e90919813f50ebfb9527a8ec3e7956e8 20170412 17:50:08< matthiaskrgr> wat 20170412 17:50:29< matthiaskrgr> its not gcc that scales, it is make or ninja 20170412 17:50:44< matthiaskrgr> I mean, gcc is not responsible for the threading 20170412 17:51:00< celticminstrel> If threading is involved, GCC would be responsible for it. 20170412 17:51:19< celticminstrel> If you mean spawning multiple processes, then yes, that's not GCC's responsibility. 20170412 17:51:32< celticminstrel> I don't know if GCC is threaded. 20170412 17:51:58< matthiaskrgr> I have not seen a multithreaded compiler yet I think o.O 20170412 17:52:25< matthiaskrgr> usually you just spawn several invocations of the same compiler in parallel to compile several files at once 20170412 17:52:32< celticminstrel> I guess it makes sense. Multithreading is inherently unsafe. 20170412 17:52:42< celticminstrel> Unless you're careful. 20170412 17:52:54< matthiaskrgr> coughwesnothcough :D 20170412 17:52:56< JyrkiVesterinen> Yeah, that was what I meant. I should have written "GCC workload" or something. 20170412 17:53:49< JyrkiVesterinen> Similar to how, for example, YouTube compresses videos uploaded to the website. They run multiple encoders in parallel in single-threaded mode. It's perfect scaling. 20170412 17:55:10< matthiaskrgr> ok actully, if you run gcc -flto=4 or llvms thinlto, that IS multithreaded 20170412 17:56:27< matthiaskrgr> but in most cases it doesn not optimize as well 20170412 17:57:02< matthiaskrgr> (not as well as monolithic single-threaded lto) 20170412 17:57:11< matthiaskrgr> ok wesnoth compiled 20170412 17:57:18< matthiaskrgr> there was some ticket I wanted to check 20170412 17:58:16< matthiaskrgr> 25075 20170412 17:59:49< matthiaskrgr> it's fixed! amazin! :D 20170412 18:00:36< celticminstrel> What fixed that again? 20170412 18:01:25< matthiaskrgr> >Please test after https://github.com/wesnoth/wesnoth/commit/da5f00c2b671b79fcec8c36aa5316e1c7663a355 20170412 18:02:13< celticminstrel> Huh. 20170412 18:03:39< celticminstrel> FTR I do still get a crash when clicking X during startup. 20170412 18:03:50< celticminstrel> Every time. 20170412 18:03:55< matthiaskrgr> looks like the crash in the gui2 story screen is gone too, great 20170412 18:05:35< matthiaskrgr> \o/ 20170412 18:05:48< celticminstrel> The titlescreen issue is still there, right? 20170412 18:05:49< matthiaskrgr> is there any ticket by me left now that is unfixed? 20170412 18:05:53< matthiaskrgr> I am actually not sure :D 20170412 18:06:01< celticminstrel> I don't think that was you. 20170412 18:06:08< matthiaskrgr> titlescreen issue? 20170412 18:06:31< celticminstrel> Click Multiplayer. Resize the window. Select an option other than cancel. 20170412 18:06:43< matthiaskrgr> uhm 20170412 18:06:47< celticminstrel> (Also happens in other situations.) 20170412 18:06:57< celticminstrel> The bug is that you just go back to the titlescreen. 20170412 18:07:03< celticminstrel> Instead of the option you selected. 20170412 18:07:17< celticminstrel> Trying to start a campaign and then resizing might also do it. 20170412 18:07:20< celticminstrel> Not sure. 20170412 18:07:24< matthiaskrgr> ah 20170412 18:07:30< matthiaskrgr> yes 20170412 18:07:40< matthiaskrgr> but I didn't report that one indeed 20170412 18:07:47< matthiaskrgr> but I also noticed that it was a bit strange 20170412 18:09:15< matthiaskrgr> 25504 is still an issue 20170412 18:10:11< matthiaskrgr> hah I found a remaining memleak :P 20170412 18:11:00-!- mjs-de [~mjs-de@x4e36cfa6.dyn.telefonica.de] has joined #wesnoth-dev 20170412 18:13:10-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20170412 18:15:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 18:21:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20170412 18:28:52-!- prkc [~prkc@d0.85.7a9f.ip4.static.sl-reverse.com] has quit [Remote host closed the connection] 20170412 18:34:42-!- prkc [~prkc@e9.85.7a9f.ip4.static.sl-reverse.com] has joined #wesnoth-dev 20170412 18:37:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 18:47:51-!- Shiki [~Shiki@p54855372.dip0.t-ipconnect.de] has joined #wesnoth-dev 20170412 18:48:14-!- markus_ [~mjs-de@x4db57a16.dyn.telefonica.de] has joined #wesnoth-dev 20170412 18:51:27-!- mjs-de [~mjs-de@x4e36cfa6.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20170412 19:17:02-!- Appleman1234_ [~Appleman1@pl7632.ag1212.nttpc.ne.jp] has joined #wesnoth-dev 20170412 19:18:14-!- Appleman1234 [~Appleman1@pl25717.ag1212.nttpc.ne.jp] has quit [Ping timeout: 252 seconds] 20170412 19:29:32-!- markus_ [~mjs-de@x4db57a16.dyn.telefonica.de] has quit [Ping timeout: 260 seconds] 20170412 19:30:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20170412 19:30:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 19:54:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 20:20:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 20:24:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 20:24:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 20:26:11-!- JyrkiVesterinen [~JyrkiVest@87-100-140-150.bb.dnainternet.fi] has quit [Quit: .] 20170412 20:37:47-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity] 20170412 20:45:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20170412 20:45:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20170412 20:48:17-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]] 20170412 20:50:11-!- irker931 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20170412 21:06:22-!- iwaim__ [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 264 seconds] 20170412 21:08:58-!- Appleman1234_ is now known as Appleman1234 20170412 21:16:03-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev 20170412 21:16:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 21:16:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 21:21:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20170412 21:37:57-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has joined #wesnoth-dev 20170412 21:39:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20170412 22:00:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 22:05:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 22:09:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 22:09:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20170412 22:14:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 22:15:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 22:15:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 22:16:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 22:18:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 22:18:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 22:32:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 22:44:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 22:53:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20170412 23:03:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20170412 23:03:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20170412 23:14:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20170412 23:23:18-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20170412 23:51:22-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has joined #wesnoth-dev 20170412 23:51:42< gfgtdf> vultraz (or anyone else): do you know what this comment means https://github.com/wesnoth/wesnoth/blob/1.13.7/src/gui/widgets/list.cpp#L156 ? 20170412 23:52:47< gfgtdf> vulright now this listbox::clear implementation is not onyl ineffective, improving this here soudl alos fix https://gna.org/bugs/?25504 i think. so i sonww why n usign generator-> clear there 20170412 23:58:57< gfgtdf> hmm i'll just tr 20170412 23:58:59< gfgtdf> y --- Log closed Thu Apr 13 00:00:40 2017