--- Log opened Thu Apr 13 00:00:40 2017
20170413 00:07:33-!- irker449 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170413 00:07:33< irker449> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 bb2d79e5f033 / src/gui/widgets/listbox.cpp: improve listbox::clear() performance. https://github.com/wesnoth/wesnoth/commit/bb2d79e5f033d4852680f27ab132b3d5241e0d78
20170413 00:10:24-!- gfgtdf [~chatzilla@x4e368c7f.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170413 00:13:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170413 00:16:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170413 00:17:39-!- atarocch [~atarocch@37.176.245.134] has quit [Remote host closed the connection]
20170413 00:18:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170413 00:24:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170413 00:24:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170413 00:25:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170413 00:30:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170413 00:37:40-!- Shiki [~Shiki@p54855372.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170413 00:37:50-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20170413 01:05:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170413 01:13:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170413 01:14:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170413 01:34:20-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 01:34:41-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 01:35:00-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 01:40:05-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 01:41:35-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 01:43:51-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 01:44:15-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 01:47:07-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 01:47:26-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 01:49:36-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170413 01:54:25-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 02:00:35-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has joined #wesnoth-dev
20170413 02:00:40-!- Greg-Boggs [~greg_bogg@50-252-20-85-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
20170413 02:07:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170413 02:18:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170413 02:29:33< vultraz_iOS> celticminstrel: I think the new memleak (https://gna.org/bugs/?25650) is here https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L596
20170413 02:30:21< vultraz_iOS> celticminstrel: supposed to be deleted here i think https://github.com/wesnoth/wesnoth/blob/master/src/serialization/preprocessor.cpp#L333
20170413 02:30:37< vultraz_iOS> celticminstrel: tbh dunno why the preprocessor code uses so many pointers
20170413 02:33:12< celticminstrel> I remember there was one part of the code that deliberately didn't free stuff and then "garbage-collected" them at the end... but maybe that wasn't the preprocessor...
20170413 02:34:14< vultraz_iOS> that seems not optimal
20170413 02:34:17< celticminstrel> The preprocessor code does look quite weird. I'd be wary of fiddling with it.
20170413 02:34:24< vultraz_iOS> what if you miss the garbage collection
20170413 02:34:27< celticminstrel> Um.
20170413 02:34:36< celticminstrel> That's actually an optimization strategy in some situations.
20170413 02:34:40< vultraz_iOS> oh?
20170413 02:34:59< celticminstrel> Because allocating/deallocating memory is typically expensive.
20170413 02:35:54< celticminstrel> But you're right, if you missed the garbage collection, then that would be bad.
20170413 02:36:15< celticminstrel> But I think maybe that was in the parser rather than the preprocessor? At least, glancing over that file didn't show any evidence of it.
20170413 02:36:27< celticminstrel> Although there are new calls that aren't assigned anywhere.
20170413 02:36:54< celticminstrel> That's because the constructor stores "this" somewhere.
20170413 02:37:32< celticminstrel> Hmm.
20170413 02:39:50< celticminstrel> I can't figure out the entry point for the preprocessor.
20170413 02:40:11< celticminstrel> Oh right!
20170413 02:40:46< celticminstrel> vultraz_iOS: I managed to fix the titlescreen by replacing the redraw_background_ member with an extra retval.
20170413 02:41:04< vultraz_iOS> ah, good, good
20170413 02:41:13< celticminstrel> I didn't push because I wasn't sure whether to a) make that retval just be 0, or b) put it in the enum and call it ... something.
20170413 02:41:29< vultraz_iOS> it can be a static numeric member
20170413 02:41:45< celticminstrel> You don't want it in the enum, huh.
20170413 02:41:54< vultraz_iOS> oh
20170413 02:42:05< vultraz_iOS> no it should be in the enum
20170413 02:42:17< celticminstrel> That does mean the switch needs an extra empty case, is that okay?
20170413 02:42:18< vultraz_iOS> i forgot there was an enum
20170413 02:42:37< vultraz_iOS> sur
20170413 02:42:37< vultraz_iOS> e
20170413 02:58:35-!- Appleman1234 [~Appleman1@pl7632.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170413 03:00:45< vultraz_iOS> so many 'new' in the preprocessor
20170413 03:06:17< celticminstrel> It's using a bizarre mode of memory management. I really don't recommend fiddling with it without having a good understanding of what it's doing.
20170413 03:07:24< vultraz_iOS> like, why is it doing stuff like this...
20170413 03:07:26< vultraz_iOS> std::map<std::string, std::string> *defines = new std::map<std::string, std::string>;
20170413 03:07:47< celticminstrel> I dunno. It's entirely possible there's a good reason.
20170413 03:08:20< vultraz_iOS> i don't think it's any faster to create that pointer than to create an object locally
20170413 03:09:47-!- Appleman1234 [~Appleman1@pl24967.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170413 03:09:58< vultraz_iOS> yeah, i don't think I can touch this
20170413 03:10:02< vultraz_iOS> we need someone expert
20170413 03:10:24< celticminstrel> Correction: We need someone willing to put in the time to actually figure out how on earth that works.
20170413 03:10:40< celticminstrel> Like tad was doing with the smart_list before he disappeared.
20170413 03:11:08< vultraz_iOS> oh yeah
20170413 03:11:11< vultraz_iOS> what happened to tad
20170413 03:11:23< celticminstrel> I've been wondering that myself.
20170413 03:14:10-!- irker449 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170413 03:24:17< celticminstrel> So yeah, line 586-ish or frame.cpp is one example of where your tribool replacement gives different results than the hand-rolled tristate did.
20170413 03:24:31< vultraz_iOS> but how
20170413 03:24:35< vultraz_iOS> i worked through the logic :/
20170413 03:24:54< celticminstrel> Okay, first, let's examine how it worked with the tristate.
20170413 03:25:11< vultraz_iOS> oh, that line..
20170413 03:25:13< celticminstrel> These are lines where it says "if(!hflip)", basically.
20170413 03:25:21< vultraz_iOS> hmm
20170413 03:25:25< vultraz_iOS> i might not have checked that bit
20170413 03:25:28< celticminstrel> The tristate was an enum - false was 0, true was 1, unset was 2.
20170413 03:25:37< celticminstrel> So apply ! to it...
20170413 03:25:42< celticminstrel> And unset becomes false.
20170413 03:26:11< celticminstrel> On the other hand, tribool only converts to true if it's definitely true.
20170413 03:26:25< celticminstrel> So !true is false, !false is true and !indeterminate is true.
20170413 03:27:14< celticminstrel> Mind you, you probably would've missed that if you'd chosen to convert to optional<bool> too.
20170413 03:27:21< celticminstrel> Except in that case it would've been even worse.
20170413 03:27:45< celticminstrel> You'd get !true = false, !false = false, and !none = true.
20170413 03:28:03< vultraz_iOS> so how do you recommend i change it
20170413 03:28:31< celticminstrel> I'm trying to decide whether it's worth changing to optional<bool>
20170413 03:28:42< celticminstrel> Maybe it's easier just to fix it to work with tribool.
20170413 03:28:48< celticminstrel> Let me think, what would that come to...
20170413 03:29:28< celticminstrel> I guess it would've been the equivalent of tristate_to_bool(b, false)?
20170413 03:29:35< celticminstrel> Or wait, not quite...
20170413 03:30:40< celticminstrel> Okay, so with the tristate you get !false = true, !true = false, !unset = false. With the tribool you get !false = true, !true = false, and !indeterminate = true.
20170413 03:30:46< celticminstrel> Or wait.
20170413 03:30:59< celticminstrel> Logically speaking, !indeterminate = indeterminate.
20170413 03:31:16< celticminstrel> So actually, by a fluke, it might work out the same after all.
20170413 03:31:51< celticminstrel> So with tristate, bool(unset) was true, and thus !unset is false.
20170413 03:32:15< celticminstrel> With tribool, !indeterminate is again indeterminate, and then bool(!indeterminate) is false.
20170413 03:32:20< celticminstrel> Wow.
20170413 03:34:19< celticminstrel> ...not 100% sure if I'm right here, though...
20170413 03:37:58-!- irker300 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170413 03:37:58< irker300> wesnoth: Celtic Minstrel wesnoth:master f3a574da46f8 / src/ (gui/dialogs/title_screen.cpp gui/dialogs/title_screen.hpp wesnoth.cpp): Fix for GNA584 https://github.com/wesnoth/wesnoth/commit/f3a574da46f85571c4db20092bc46b9f51344c4b
20170413 03:38:28< celticminstrel> According to the boost documentation, !tb is true only if tb is false.
20170413 03:38:45< celticminstrel> Meaning that !indeterminate is... false...
20170413 03:39:25< celticminstrel> Okay, so, there's no problem after all! I still think tribool is a little unsuitable, but whatever. If it works I don't see a point in changing it again.
20170413 03:39:42< vultraz_iOS> Aren't you supposed to use !indeterminate(value) not !value where value is indeterminate?
20170413 03:40:09< celticminstrel> You're supposed to do that if you want to get back "true" when value is indeterminate, sure.
20170413 03:40:19< celticminstrel> And false what it's not indeterminate.
20170413 03:40:25< vultraz_iOS> Ah
20170413 03:41:29< celticminstrel> bool(tb) is true iff tb === true.
20170413 03:41:37< celticminstrel> !tb is true iff tb === false.
20170413 03:41:49< celticminstrel> This lets you do if(tb) {} else if (!tb) {} else {}
20170413 03:42:30< celticminstrel> (The contents of an if statement are implicitly explicitly converted to bool in C++11.)
20170413 04:05:39< irker300> wesnoth: Celtic Minstrel wesnoth:frame_cleanup f6b491702761 / src/units/frame.cpp: Some cleanup to the unit frame code https://github.com/wesnoth/wesnoth/commit/f6b4917027616cf193012c5a878198dc61582007
20170413 04:05:43< celticminstrel> vultraz_iOS: Please review ^
20170413 04:07:30< vultraz_iOS> celticminstrel: "Don't initialize the color members." no, this is wrong
20170413 04:07:38< vultraz_iOS> the correct fix is don't make them optional anymore
20170413 04:07:45< celticminstrel> Why?
20170413 04:08:07< vultraz_iOS> initialization fixed the "poisoned units are white not green" bug
20170413 04:18:23< vultraz_iOS> celticminstrel: and how are those redundant initializers?
20170413 04:18:51< celticminstrel> They're redundant because they're default-initializing a member that is not a primitive type or POD type.
20170413 04:19:04< vultraz_iOS> I see
20170413 04:19:35< celticminstrel> (POD type basically meaning "something with no constructors and no virtual functions" IIRC.)
20170413 04:20:24< vultraz_iOS> ok
20170413 04:20:33< vultraz_iOS> other than the color stuff it looks alright
20170413 04:21:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170413 04:34:14< vultraz_iOS> would be nice if i could add doc comments for everything in the unit class
20170413 04:42:16< celticminstrel> You could add doc comments for just the things you understand.
20170413 04:45:49< celticminstrel> So logically, it doesn't make sense to change the optional<color_t> to just color_t...
20170413 04:46:11< celticminstrel> And the code is already set up for the assumption that the colors may not be present (ie, testing that they're present before dereferencing).
20170413 04:46:26< vultraz_iOS> in the original code, it was uint32_ts
20170413 04:46:28< vultraz_iOS> initialized to 0
20170413 04:46:31< vultraz_iOS> and using !
20170413 04:46:35< vultraz_iOS> to make sure they weren't 0
20170413 04:46:40< vultraz_iOS> just for reference
20170413 04:46:58< celticminstrel> Okay, so it does break poison...
20170413 04:48:46< vultraz_iOS> an option is to initialize to null_color
20170413 04:48:53< vultraz_iOS> and check if it equals null_color
20170413 04:51:37< vultraz_iOS> i did add a getter for null_color
20170413 04:52:14< celticminstrel> if(primary && engine_val.blend_with && result.blend_with)
20170413 04:52:16< celticminstrel> Seems wrong.
20170413 04:52:34< celticminstrel> Hmm, but it does require that...
20170413 04:52:47< celticminstrel> Because the if block uses both of those.
20170413 04:52:49< celticminstrel> Hmm...
20170413 04:53:50 * vultraz_iOS is probably going to add over 1000 lines to unit.hpp with spacing and doc comments
20170413 04:54:01< vultraz_iOS> there are at least 50 functions here
20170413 04:54:07< celticminstrel> Fine with me.
20170413 04:59:19< irker300> wesnoth: Celtic Minstrel wesnoth:master f6b491702761 / src/units/frame.cpp: Some cleanup to the unit frame code https://github.com/wesnoth/wesnoth/commit/f6b4917027616cf193012c5a878198dc61582007
20170413 04:59:21< irker300> wesnoth: Celtic Minstrel wesnoth:master c97adacfa79e / src/units/frame.cpp: Re-fix poison not being shown https://github.com/wesnoth/wesnoth/commit/c97adacfa79e3562d759e9e9f43741ab00fd42b1
20170413 04:59:29< celticminstrel> ...oh, whoops.
20170413 04:59:51< celticminstrel> If you don't like the second commit, I guess you can push a new commit reverting it and putting back the color initializations.
20170413 05:00:17< celticminstrel> (Forgot I was working on master even though I pushed to a branch before. >_> )
20170413 05:00:35< vultraz_iOS> still thinking perhaps not making them optional is best
20170413 05:01:04< celticminstrel> I'm not convinced.
20170413 05:02:10< vultraz_iOS> *you* suggested it in the first place
20170413 05:02:42< celticminstrel> Just because I suggested something once doesn't mean I still think it's a good idea. :P
20170413 05:08:14-!- JyrkiVesterinen [~JyrkiVest@87-100-218-150.bb.dnainternet.fi] has joined #wesnoth-dev
20170413 05:29:50< vultraz_iOS> soooo many docs to write
20170413 06:05:10-!- Appleman1234 [~Appleman1@pl24967.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170413 06:08:49-!- JyrkiVesterinen [~JyrkiVest@87-100-218-150.bb.dnainternet.fi] has quit [Quit: .]
20170413 06:12:06-!- Appleman1234 [~Appleman1@pl50073.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170413 06:12:21< vultraz_iOS> didn't I remove small_profile...?
20170413 06:12:23< vultraz_iOS> oh wait, no
20170413 06:12:50-!- atarocch [~atarocch@37.177.87.106] has joined #wesnoth-dev
20170413 06:22:57-!- atarocch [~atarocch@37.177.87.106] has quit [Remote host closed the connection]
20170413 06:27:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:59d9:2340:a679:fcc5] has joined #wesnoth-dev
20170413 06:31:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:59d9:2340:a679:fcc5] has quit [Ping timeout: 240 seconds]
20170413 06:36:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170413 06:43:08-!- zookeeper_ [~lmsnie@95.175.104.70] has joined #wesnoth-dev
20170413 06:45:20-!- atarocch [~atarocch@31.157.210.10] has joined #wesnoth-dev
20170413 06:46:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170413 06:47:59-!- zookeeper_ is now known as zookeeper
20170413 06:48:01-!- zookeeper [~lmsnie@95.175.104.70] has quit [Changing host]
20170413 06:48:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170413 06:53:45-!- atarocch [~atarocch@31.157.210.10] has quit [Remote host closed the connection]
20170413 07:04:03< vultraz_iOS> good god so much writing
20170413 07:04:14< vultraz_iOS> probably going to commit what i have soon and finish later
20170413 07:07:17 * celticminstrel started trying to template the frame parameters for some reason. >_>
20170413 07:10:27< vultraz_iOS> \o/
20170413 07:10:29< vultraz_iOS> templates!
20170413 07:10:32< vultraz_iOS> templates are good
20170413 07:12:51< celticminstrel> XD
20170413 07:13:24-!- celticminstrel is now known as celmin|sleep
20170413 07:16:32-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170413 07:17:26< celmin|sleep> (Only problem is, it means removing some trailing underscores on variable names, and I'm not certain that'll work out.)
20170413 07:21:29< vultraz_iOS> celmin|sleep: what do templates have to do with trailing underscorres
20170413 07:21:31< vultraz_iOS> scores 
20170413 07:22:26< celmin|sleep> Because one instance has none and the other two do have them.
20170413 07:22:39< celmin|sleep> (I mean I could add them to the one that doesn't instead, but those are public members.)
20170413 07:23:00< celmin|sleep> (Which makes it a far less localized change.)
20170413 07:23:17< celmin|sleep> I'll just show you once it's done tomorrow, then you can see what you think.
20170413 07:23:20< celmin|sleep> Good night.
20170413 07:34:38-!- Appleman1234 [~Appleman1@pl50073.ag1212.nttpc.ne.jp] has left #wesnoth-dev ["Leaving"]
20170413 07:39:00-!- atarocch [~atarocch@93.68.246.95] has joined #wesnoth-dev
20170413 08:46:35-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170413 09:09:09-!- irker300 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170413 09:20:48-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170413 09:56:23-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170413 10:28:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170413 10:53:54-!- irker001 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170413 10:53:54< irker001> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 f860bcd4d8bd / src/gui/widgets/listbox.cpp: fixup https://github.com/wesnoth/wesnoth/commit/f860bcd4d8bd187431e75edc17a72cb3c17cfc46
20170413 10:56:17< stikonas> by the way, are translations still handed by Ivanovic? I sent first translations after about 2 years but they still weren't committed..
20170413 10:57:30< JyrkiVesterinen> The process is still the same: translators send the translations to the lead translator of the language in question, who then sends them to Ivanovic who finally commits them.
20170413 10:58:52< loonycyborg> stikonas: remind me are you a translator or tranlation maintainer?
20170413 10:59:04< loonycyborg> *translation
20170413 10:59:40< loonycyborg> if you're a translator and your maintainer went inactive you'd probably need to take over his role :P
20170413 10:59:43< stikonas> loonycyborg: maintainer...
20170413 11:00:01< stikonas> well, it's more of the case all translators went inactive...
20170413 11:00:11< stikonas> guess everybody is busy including me...
20170413 11:01:06< loonycyborg> Ivanovic himself is busy too nowadays, but I still see him commiting updates
20170413 11:01:37< stikonas> hmm, let's wait a bit then
20170413 11:01:45< stikonas> wouldn't want to commit same files twice...
20170413 11:23:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170413 11:24:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170413 12:27:20-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170413 12:29:30< irker001> wesnoth: Charles Dang wesnoth:master d0dda79a6868 / src/units/ (abilities.cpp unit.cpp unit.hpp): WIP effort to document the unit class https://github.com/wesnoth/wesnoth/commit/d0dda79a686881bdf537b3ebbe23762384de437b
20170413 12:29:33< irker001> wesnoth: Charles Dang wesnoth:master ada84d6aaf48 / src/ (6 files in 3 dirs): Unit: removed an unimplemented function and renamed two others for clarity https://github.com/wesnoth/wesnoth/commit/ada84d6aaf4894f489ed6cd31082e930247fbb84
20170413 12:50:15-!- Kwandulin [~Kwandulin@p200300760F6D80479D1E6D80CA3C1CA3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170413 13:12:18< irker001> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 4d2cd2b197ee / src/gui/widgets/generator_private.hpp: fixup https://github.com/wesnoth/wesnoth/commit/4d2cd2b197eeacb758d0045fd1f6838fc9f36670
20170413 13:12:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170413 13:15:47-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170413 13:16:14-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20170413 14:09:43-!- gfgtdf [~chatzilla@x4e363184.dyn.telefonica.de] has joined #wesnoth-dev
20170413 14:12:58< gfgtdf> loonycyborg: any opinion on https://gna.org/bugs/?25653#comment6 ?
20170413 14:15:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170413 14:17:17< JyrkiVesterinen> gfgtdf: We have had issues with CMAKE_CXX_STANDARD=11 in the past.
20170413 14:17:48< JyrkiVesterinen> The IEEE 754 test uses it ( https://github.com/wesnoth/wesnoth/blob/master/CMakeLists.txt#L60 ), but multiple people have complained that the test fails, apparently because it's being compiled in C++98 mode.
20170413 14:22:31< loonycyborg> gfgtdf: The guy's suggested fix would require cmake version needed. 
20170413 14:22:56< loonycyborg> We generally don't require anything that isn't provided by current debian stable
20170413 14:24:12< loonycyborg> fix he used requires cmake 3.1, debian stable has 3.0.2
20170413 14:24:37< gfgtdf> loonycyborg: maybe put it in some if (cmake_version >= 3.1) then ?
20170413 14:25:26< loonycyborg> maybe
20170413 14:25:43< loonycyborg> but I have no idea why it doesn't pass -std=c++11 for him
20170413 14:25:50< loonycyborg> I though both buildsystems do this
20170413 14:27:06< loonycyborg> in fact cmake worked without errors for me last time I tried it here
20170413 14:27:11< loonycyborg> and I'm using gentoo too
20170413 14:27:34< loonycyborg> and it would fail if it wasn't passing -std=c++11
20170413 14:28:39-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170413 14:30:41< loonycyborg> mind you I'm using scons mostly, and there already were new versions of cmake since I used it last..
20170413 14:30:57-!- atarocch [~atarocch@93.68.246.95] has quit [Ping timeout: 240 seconds]
20170413 14:38:58< vultraz_iOS> all our recipes are supposed to mandate c++11, aren't they?
20170413 14:43:25< loonycyborg> yes
20170413 14:47:32< loonycyborg> either it broke in newer versions of cmake or that guy's gentoo has some issues..
20170413 14:48:42-!- atarocch [~atarocch@93.68.246.95] has joined #wesnoth-dev
20170413 14:53:43< irker001> wesnoth: gfgtdf wesnoth:master 59ceddf91783 / src/gui/widgets/ (generator_private.hpp listbox.cpp): improve listbox::clear() performance. (#982) https://github.com/wesnoth/wesnoth/commit/59ceddf917837fdf959ec4a9a4ea724e4ca32980
20170413 14:58:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170413 15:04:29-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20170413 15:06:20-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: I'll Be Back!]
20170413 15:07:17-!- atarocch [~atarocch@93.68.246.95] has quit [Ping timeout: 245 seconds]
20170413 15:09:26-!- loonycyborg_ [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20170413 15:09:43-!- atarocch [~atarocch@93.68.246.95] has joined #wesnoth-dev
20170413 15:10:08-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170413 15:10:53-!- Netsplit *.net <-> *.split quits: clavi, Elsi, Jetrel, loonycyborg
20170413 15:10:53-!- loonycyborg_ is now known as loonycyborg
20170413 15:11:43-!- Netsplit over, joins: clavi, Elsi
20170413 15:16:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 15:21:44-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Read error: Connection reset by peer]
20170413 15:22:24< vultraz_iOS> gfgtdf: so https://gna.org/bugs/index.php?25650 is fixed now?
20170413 15:23:12< gfgtdf> hm i don' think so
20170413 15:23:16< gfgtdf> why shoudl it ?
20170413 15:24:49-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170413 15:25:51< gfgtdf> vultraz_iOS: ^
20170413 15:26:28< vultraz_iOS> oh wait
20170413 15:26:30< vultraz_iOS> it was https://gna.org/bugs/?25504
20170413 15:26:31< vultraz_iOS> you said
20170413 15:27:02< gfgtdf> vultraz_iOS: well i dodn't test it, so i'll makr it as 'ready for test'
20170413 15:29:14< gfgtdf> matthiaskrgr: ^
20170413 15:35:27-!- mjs-de [~mjs-de@x4db57a16.dyn.telefonica.de] has joined #wesnoth-dev
20170413 15:39:27-!- atarocch [~atarocch@93.68.246.95] has quit [Ping timeout: 240 seconds]
20170413 15:48:43-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Read error: Connection reset by peer]
20170413 15:52:49-!- atarocch [~atarocch@37.176.233.165] has joined #wesnoth-dev
20170413 16:03:26-!- JyrkiVesterinen [~JyrkiVest@89-166-97-141.bb.dnainternet.fi] has joined #wesnoth-dev
20170413 16:07:17< stikonas> strange, I had no problems compiling wesnoth on gentoo with 5.4.0
20170413 16:08:02< stikonas> maybe that guy did something incorrectly in cmake stage...
20170413 16:08:40< JyrkiVesterinen> It's quite hard to imagine, as there isn't much to *do* to begin with.
20170413 16:10:41-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170413 16:13:47-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170413 16:14:38-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20170413 16:27:53-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: I'll Be Back!]
20170413 16:28:55-!- zookeeper_ [~lmsnie@95.175.104.70] has joined #wesnoth-dev
20170413 16:30:27-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170413 16:32:05-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 252 seconds]
20170413 16:32:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20170413 16:32:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20170413 16:32:07-!- wedge010 is now known as wedge009
20170413 16:34:28-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20170413 16:44:06-!- mjs-de [~mjs-de@x4db57a16.dyn.telefonica.de] has quit [Remote host closed the connection]
20170413 16:46:59< stikonas> loonycyborg: hmm, so I just got bounce email from Ivanovic...
20170413 16:47:22< loonycyborg> he's still on this irc
20170413 16:47:50< loonycyborg> probably as bouncer though
20170413 16:47:55< stikonas> yeah, but always away...
20170413 16:48:06< stikonas> maybe...
20170413 16:48:24< stikonas> well, I'll try to resolve the problem...
20170413 16:48:26< stikonas> and resend email
20170413 16:59:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has quit [Remote host closed the connection]
20170413 17:02:09-!- gfgtdf [~chatzilla@x4e363184.dyn.telefonica.de] has quit [Remote host closed the connection]
20170413 17:07:49-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170413 17:24:30< celmin|sleep> ...
20170413 17:24:39< celmin|sleep> Doc comments are supposed to be in the headers! :(
20170413 17:25:57< vultraz_iOS> ?
20170413 17:26:17< vultraz_iOS> I did put them in the headers what are you talking about
20170413 17:26:22< vultraz_iOS> header
20170413 17:27:42-!- atarocch [~atarocch@37.176.233.165] has quit [Ping timeout: 258 seconds]
20170413 17:32:50< celmin|sleep> ...sorry, I seem to be mixing up red and green. :/
20170413 17:34:03< celmin|sleep> ...why the heck does unit have a virtual destructor? o.o
20170413 17:34:11< celmin|sleep> Are there subclasses?
20170413 17:34:46< celmin|sleep> The separaters probably shouldn't be made to look like doc comments...
20170413 17:34:57< vultraz_iOS> Don't read the diff
20170413 17:35:01< vultraz_iOS> Read the full file
20170413 17:38:32< celmin|sleep> Ooh deprecated attributes.
20170413 17:39:01< celmin|sleep> Why does that need to be under HAVE_CXX14 though?
20170413 17:39:51< celmin|sleep> You know, these doc comments are nice, but they don't have all the @return and @param...
20170413 17:40:04< JyrkiVesterinen> Because [[deprecared]] was introduced in C++14.
20170413 17:40:08< celmin|sleep> (Also, deprecated ones should have a @deprecated)
20170413 17:40:21< celmin|sleep> Is it an error to use an unknown attribute in C++11?
20170413 17:40:40< celmin|sleep> Anyway, deprecated attributes are certainly available as an extension in GCC before C++14.
20170413 17:40:54< celmin|sleep> So that could be added to global.hpp.
20170413 17:41:54< vultraz_iOS> I'm considering whether that function *should* be deprecated, though, since id() has the side effect of using type name if id is empty
20170413 17:41:59< vultraz_iOS> and yeah, should be added to global.hpp
20170413 17:42:05< celmin|sleep> Wasn't it supposed to be @return and not @returns?
20170413 17:42:39< vultraz_iOS> it appears both are used extensively in the source tree
20170413 17:42:42< vultraz_iOS> dunno which is right
20170413 17:42:50< celmin|sleep> Check doxygen documentation.
20170413 17:44:02< celmin|sleep> Ah, looks like they both work. Convenient.
20170413 17:45:25< vultraz_iOS> oh hey doxygen supports markdown
20170413 17:47:18< celmin|sleep> Yup.
20170413 17:47:22< vultraz_iOS> anyway im not fully done with the unit docs
20170413 17:47:25< celmin|sleep> The documentation of take_hit is quite weird..
20170413 17:47:28< vultraz_iOS> and i need someone to check the existing ones
20170413 17:47:40< vultraz_iOS> oh yeah that was there before i think
20170413 17:49:58< celmin|sleep> vultraz_iOS: So, I think I'd suggest using doxygen groups.
20170413 17:50:05< vultraz_iOS> hm?
20170413 17:50:11< celmin|sleep> Instead of these separators.
20170413 17:50:23< vultraz_iOS> how does one do that
20170413 17:50:24< celmin|sleep> For example, "/*** *** *** *** *** *** Attack and reisstance functions. *** *** *** *** *** ***/"
20170413 17:51:10< celmin|sleep> That would become something like:
20170413 17:51:25< celmin|sleep>  * @{
20170413 17:51:28< celmin|sleep>  */
20170413 17:51:32< celmin|sleep> (functions here)
20170413 17:51:44< celmin|sleep>  /** @} */
20170413 17:52:06< celmin|sleep> And the first line got missed because this is IRC:
20170413 17:52:10< celmin|sleep>  /** @defgroup Attack and resistance functions
20170413 17:52:35< celmin|sleep> Of course, the @} from the previous group could be in the same comment as the @{ of the next group.
20170413 17:54:11< celmin|sleep> Documentation here: http://www.stack.nl/~dimitri/doxygen/manual/grouping.html
20170413 17:54:23-!- irker001 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170413 17:56:54< celmin|sleep> vultraz_iOS: Found a big error in your documentation.
20170413 17:57:05< vultraz_iOS> tell me more
20170413 17:57:13< celmin|sleep> Though it's not your fault, seemingly.
20170413 17:57:29< celmin|sleep> The documentation of the private members type_, type_name_, race_ is wrong/
20170413 17:57:40< celmin|sleep> More specifically, doxygen would apply the comments to the wrong member.
20170413 17:57:57< celmin|sleep> They need to either be changed to start with ///< or moved before the member they document.
20170413 17:58:02< vultraz_iOS> ah
20170413 17:58:07< vultraz_iOS> well im not done yet
20170413 18:01:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170413 18:03:04-!- celmin|sleep is now known as celticminstrel
20170413 18:06:07-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20170413 18:06:25-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170413 18:14:32-!- atarocch [~atarocch@93.68.159.151] has joined #wesnoth-dev
20170413 18:23:46-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170413 18:25:34-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170413 18:26:15-!- zookeeper_ is now known as zookeeper
20170413 18:26:17-!- zookeeper [~lmsnie@95.175.104.70] has quit [Changing host]
20170413 18:26:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170413 18:40:14-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170413 18:40:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 18:45:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has quit [Ping timeout: 258 seconds]
20170413 18:51:24-!- atarocch [~atarocch@93.68.159.151] has quit [Ping timeout: 260 seconds]
20170413 18:56:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 19:13:31-!- JyrkiVesterinen [~JyrkiVest@89-166-97-141.bb.dnainternet.fi] has quit [Quit: .]
20170413 19:19:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170413 19:19:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170413 19:33:08-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170413 19:36:39-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20170413 19:37:57< celticminstrel> Well, my frame parameters templatization now builds. \o/
20170413 19:38:04< celticminstrel> Next to see if animations still work.
20170413 19:39:49-!- gfgtdf [~chatzilla@x4e363184.dyn.telefonica.de] has joined #wesnoth-dev
20170413 19:40:45< gfgtdf> vultraz_iOS: when trying to eliminate direct delete p uses i cam across https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/lobby_info.cpp 
20170413 19:41:28< gfgtdf> vultraz_iOS: shouldn't erase calls like https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/lobby_info.cpp#L193 first delete current_i->second or is oit stored somehere eelse ?
20170413 19:41:34< gfgtdf> is it*
20170413 19:42:02 * celticminstrel checks.
20170413 19:43:03< celticminstrel> I wouldn't be surprised if the same pointers are also stored in games_ and potentially games_filtered_
20170413 19:43:17< celticminstrel> But, well, just use shared_ptr and then you won't need to worry about it, right?
20170413 19:43:43< celticminstrel> users_sorted_ though shouldn't use shared_ptr since it's presumably the same elements as users_/
20170413 19:44:13< celticminstrel> Unless of course you make users_ use shared_ptr too.
20170413 19:45:47< gfgtdf> well i see not prbplems in user, as long as the owner ship is clear there is reall no reason to use shared_ptr
20170413 19:47:37< celticminstrel> Yeah.
20170413 19:48:15< celticminstrel> But in that case, I'd say get_user should return a reference (and throw if the user doesn't exist).
20170413 19:48:56< celticminstrel> Though I guess that wouldn't actually change the potential issue there...
20170413 19:49:18< celticminstrel> Basically the caller could store the pointer/reference somewhere and access it after it's deleted.
20170413 19:51:13< gfgtdf> celticminstrel: hmm yes but thats the always that cane, actuall even with refrences one youd eaisly store &obj somehere.
20170413 19:51:46< celticminstrel> Or you could store it in a reference variable somewhere.
20170413 19:52:33< gfgtdf> ye
20170413 20:12:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has quit [Remote host closed the connection]
20170413 20:27:54< Ivanovic> stikonas: my email should be functional...
20170413 20:31:48< celticminstrel> Maybe misspelled?
20170413 20:31:50< celticminstrel> I dunno.
20170413 20:39:52-!- irker489 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170413 20:39:53< irker489> wesnoth: Celtic Minstrel wesnoth:frame_cleanup 79c10e08e59a / src/units/ (frame.cpp frame.hpp): Templatize the unit animation frame parameters https://github.com/wesnoth/wesnoth/commit/79c10e08e59a263439ccb71db635c5ccbc25734a
20170413 20:39:57< celticminstrel> vultraz_iOS, maybe others: please review ^
20170413 20:42:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 20:44:53< stikonas> Ivanovic: yeah, it was bad on my end...
20170413 20:45:01< stikonas> did you receive the second try today?
20170413 20:45:03< stikonas> or nothing?
20170413 20:45:53< stikonas> if not, then I'll retry with another mail server
20170413 20:47:17< Ivanovic> let me check the spamfilter
20170413 20:48:09< Ivanovic> no, there is nothing
20170413 20:48:17< stikonas> ok, I'll try my university email then
20170413 20:48:37< Ivanovic> did you use the address i pasted in a query?
20170413 20:49:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has quit [Remote host closed the connection]
20170413 20:49:54< stikonas> Ivanovic: yeah, same as before
20170413 20:49:59< stikonas> well, two years ago...
20170413 20:50:14< stikonas> now I tried from another mailbox
20170413 20:50:14< Ivanovic> i don't know if i received anything from you two years ago
20170413 20:50:20< stikonas> well, you did...
20170413 20:50:26< stikonas> it's in repos...
20170413 20:50:27< Ivanovic> usually i should react within "small number of weeks"
20170413 20:50:30< Ivanovic> :)
20170413 20:51:14< Ivanovic> (usually even within the week, though this depends on work, e.g. if I am on business travel I won't be able to transmit anything until i am back since i don't have the stuff on my business laptop)
20170413 20:51:33< stikonas> well, things were busier for both of us anyway...
20170413 20:51:50< stikonas> I didn't translate much over last 2 years...
20170413 20:52:20< Ivanovic> i did not do anything "real" for wesnoth over the last years
20170413 20:52:32< Ivanovic> only applying the tools on translation files and uploading them
20170413 20:52:53< Ivanovic> ah, and fixing the building of the new campaign in cmake / adding headers to the files
20170413 20:53:21< stikonas> well, I still did some FOSS stuff, just not wesnoth... With some help we got luks/lvm support in kde partition manager...
20170413 20:53:33< Ivanovic> nice
20170413 20:53:54< stikonas> Ivanovic: still no email?
20170413 20:53:58< Ivanovic> i received it
20170413 20:54:01< stikonas> oh, good
20170413 20:54:04< Ivanovic> this one worked like a charm
20170413 20:54:25< stikonas> I guess the first one got rejected since it doesn't have reverse dns...
20170413 20:54:29< Ivanovic> currently running a git pull, my checkout on this machine is a little outdated...
20170413 20:54:42< Ivanovic> ah, so it was not from your gmail account
20170413 20:55:00< stikonas> Ivanovic: no, it was from my postfix server...
20170413 20:55:09< stikonas> well, usually I have no problems...
20170413 20:55:12< stikonas> was using it for like 3 years
20170413 20:56:06< stikonas> and it used to work even to your email
20170413 20:57:10< irker489> wesnoth: Nils Kneuper wesnoth:master 084c4c5f4408 / / (31 files in 30 dirs): updated Lithuanian translation https://github.com/wesnoth/wesnoth/commit/084c4c5f440814d5986597faab119ef1f8213b76
20170413 20:57:12< irker489> wesnoth: Nils Kneuper wesnoth:master ed1aa0d4a176 / changelog: fixed changelog sorting order https://github.com/wesnoth/wesnoth/commit/ed1aa0d4a176990a68923c6cd2d404affc29f6bf
20170413 20:57:35< stikonas> thanks!
20170413 20:57:44< Ivanovic> hmm, right
20170413 20:57:53< Ivanovic> still got those old, 3 year old mails...
20170413 20:58:03< Ivanovic> maybe my provider changed something?
20170413 20:58:29< Ivanovic> (though their spam filters are not that great, about 5% false positives and 15% false negatives)
20170413 20:58:31< stikonas> probably... http://postmaster.gmx.com/en/error-messages?ip=176.25.98.26&c=rdns
20170413 20:58:37< stikonas> well, doesn't matter...
20170413 20:58:53< stikonas> maybe at some point I'll switch to some other isp that is nicer
20170413 20:59:02< stikonas> not one of teh big ones...
20170413 21:02:12< Ivanovic> spam filters can be nice but evil as well...
20170413 21:02:19-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170413 21:02:20< stikonas> yeah
20170413 21:02:24< stikonas> well, I get about 5% false negatives with my own dspam filter
20170413 21:02:25< Ivanovic> the one at work is great, it really filters out 99.99% of all spam
20170413 21:03:02< Ivanovic> downside: you never know about the false positives unless someone tells you that someone sent you a mail and you ask the admins to check the spamfilter logs (no, users can't access them themselves)
20170413 21:03:54< stikonas> well, hopefully doesn't happen often...
20170413 21:04:31< Ivanovic> it happens sometimes, but you usually don't know about it
20170413 21:04:32< Ivanovic> ;)
20170413 21:05:02< Ivanovic> plus it helps to focus on the important stuff, not making you read emails you should maybe answer to
20170413 21:05:04< Ivanovic> :D
20170413 21:12:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 21:17:47-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170413 21:31:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170413 21:46:49-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 260 seconds]
20170413 21:58:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170413 22:07:41-!- Kwandulin [~Kwandulin@p200300760F6D80479D1E6D80CA3C1CA3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170413 22:10:02< gfgtdf> celticminstrel: your commit doesn't build
20170413 22:10:25< celticminstrel> Aww.
20170413 22:10:45< celticminstrel> I'm guessing you mean Travis failed?
20170413 22:11:50< gfgtdf> celticminstrel: yes
20170413 22:49:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170413 23:01:45-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20170413 23:23:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has quit [Remote host closed the connection]
20170413 23:41:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d4a2:2690:5771:4d16] has joined #wesnoth-dev
20170413 23:45:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20170413 23:50:02-!- gfgtdf [~chatzilla@x4e363184.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170413 23:57:20-!- irker489 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
--- Log closed Fri Apr 14 00:00:49 2017