--- Log opened Sat Apr 15 00:00:53 2017
20170415 00:16:09-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20170415 00:16:09-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20170415 00:16:09-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20170415 00:46:12-!- irker825 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170415 02:21:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170415 02:22:05-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170415 02:25:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170415 02:54:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 03:14:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 03:39:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170415 04:03:40< vultraz_iOS> gfgtdf: yeah i know about that, need to fix
20170415 04:19:23< vultraz_iOS> hmm
20170415 04:19:41< vultraz_iOS> celticminstrel: I'm assuming boost::swap doesn't work with shared_ptr?
20170415 04:19:47< vultraz_iOS> or does it
20170415 04:20:14< celticminstrel> boost::swap?
20170415 04:20:22< vultraz_iOS> yes
20170415 04:20:36< vultraz_iOS> as opposed to std::swap
20170415 04:20:54< vultraz_iOS> I just noticed the face_unit_ptr uses it in operator=
20170415 04:21:07< vultraz_iOS> 	boost::swap(unit_, o.unit_);
20170415 04:21:07< vultraz_iOS> 	std::swap(my_manager_, o.my_manager_);
20170415 04:21:19< vultraz_iOS> unit_ is the boost::intrusive_ptr
20170415 04:21:37< vultraz_iOS> I'm pondering if this might be related to my problems earlier, since if might not work with std::shared_ptr correctly
20170415 04:21:49< vultraz_iOS> does this seem plausible?
20170415 04:21:53< celticminstrel> Not really.
20170415 04:22:18< celticminstrel> Standard practice with swap appears to be not specializing but simply declaring your own overload.
20170415 04:22:33< celticminstrel> Boost thus probably declared one in their own namespace for intrusive_ptr.
20170415 04:22:38< celticminstrel> Maybe they also had using std::swap
20170415 04:23:07< celticminstrel> I mean, you can try changing it and see if it fixes your problems, but it doesn't seem too likely to me.
20170415 04:25:54< vultraz_iOS> hmmmmmmm
20170415 04:30:54< vultraz_iOS> ok, this is interesting...
20170415 04:31:12< vultraz_iOS> sometimes the code uses raw unit* ptrs, sometimes it uses unit_ptr
20170415 04:32:04< celticminstrel> Not good!
20170415 04:32:29< celticminstrel> It's fine if it uses local unit variables BTW, as long as they never get into the unit map.
20170415 04:32:39< celticminstrel> (Or if they do they're first copied into a unit_ptr.)
20170415 04:33:05< celticminstrel> (By copied I mean the unit is copied, so if you intend to do that you might as well use a unit_ptr from the start.)
20170415 04:34:58-!- irker490 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170415 04:34:58< irker490> wesnoth: Charles Dang wesnoth:master 6addb2e12fb7 / src/ (4 files in 4 dirs): Cleaned up some comments and an include related to intrusive_ptr https://github.com/wesnoth/wesnoth/commit/6addb2e12fb724cab1a88ff294d5a94038d78e8a
20170415 04:35:34< vultraz_iOS> well this is fun.. 117 cases of `unit *` and 124 of `unit*`
20170415 04:35:45< celticminstrel> Fuuuuun!
20170415 04:35:58< celticminstrel> BTW, IRC doesn't support Markdown. :P
20170415 04:36:10< celticminstrel> (Not sure that even is Markdown though.)
20170415 04:36:48< vultraz_iOS> not sure how i should handle this..
20170415 04:36:59< vultraz_iOS> should i make every case a unit_ptr?
20170415 04:38:46< celticminstrel> That's probably the easiest option.
20170415 04:39:49-!- JyrkiVesterinen [~JyrkiVest@87-100-224-41.bb.dnainternet.fi] has joined #wesnoth-dev
20170415 04:43:06< vultraz_iOS> I think most of these are just local variables... though they do get passed around an awful lot...
20170415 04:43:10< vultraz_iOS> oh, I see some unit& too..
20170415 04:43:26< celticminstrel> If they get passed around anywhere, it's probably not safe to just declare them as a local unit.
20170415 04:43:43< celticminstrel> Because whatever they're passed to might call shared_from_this().
20170415 04:45:14< celticminstrel> Unless of course you can prove that that's impossible, but in that case put a comment both at the call site and in the function called.
20170415 04:45:29< celticminstrel> So that other people know that they can't call shared_from_this() there.
20170415 04:59:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 05:00:12-!- Kwandulin [~Kwandulin@p200300760F6D8067C106474B65342408.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170415 05:06:14< vultraz_iOS> celticminstrel: btw, unrelated to this ptr stuff, i had an idea to move all the attributes common to unit and unit_type into their own struct 
20170415 05:12:51< celticminstrel> Hmm.
20170415 05:13:15< celticminstrel> Just off the top of my head, I can see a few minor problems with that idea.
20170415 05:13:37< celticminstrel> For example, unit_type::hitpoints is presumably max hitpoints while unit::hitpoints is current hitpoints.
20170415 05:14:11< vultraz_iOS> easy to make type use map_hitpoints, though
20170415 05:14:34< celticminstrel> If you did do that you could make both inherit from the struct (probably privately).
20170415 05:16:08< vultraz_iOS> similar to your frame branch?
20170415 05:16:14< celticminstrel> Yeah.
20170415 05:26:20-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170415 05:34:56< vultraz_iOS> celticminstrel: any idea how this could be fixed? https://gna.org/bugs/index.php?25641 since you've been working with animations
20170415 05:35:10< vultraz_iOS> I think set_standing needs to be called somewhere.. not sure where, though
20170415 05:35:18< celticminstrel> Didn't I fix that already?
20170415 05:35:28< celticminstrel> Or is this something different?
20170415 05:35:59< vultraz_iOS> different
20170415 05:46:05< celticminstrel> Maybe related to something missed when making the GUI2 preferences?
20170415 05:47:55< vultraz_iOS> i dunno
20170415 05:48:14< vultraz_iOS> something needs to "refresh" the unit anims so they stop playing
20170415 06:14:18< irker490> wesnoth: Charles Dang wesnoth:master 3f8d3cca781d / src/units/ (unit.cpp unit.hpp): Added more documentation to the unit class https://github.com/wesnoth/wesnoth/commit/3f8d3cca781dc9ba0b4d67a59a800f25e45ad5d7
20170415 06:14:21< irker490> wesnoth: Charles Dang wesnoth:master 41e0e21d5d1e / src/units/unit.hpp: Unit: implemented a todo for a bool state count variable https://github.com/wesnoth/wesnoth/commit/41e0e21d5d1e57013ab3e1fab835320860895548
20170415 06:15:32< celticminstrel> Does CONSTEXPR expand to const where constexpr isn't supported? Because if not, I think that'll break MSVC 2013.
20170415 06:15:57< celticminstrel> Also, did you check if 7 was referenced anywhere in unit.cpp?
20170415 06:23:14< vultraz_iOS> it is not
20170415 06:23:44< vultraz_iOS> CONSTEXPR expands to nothing if it's not supported
20170415 06:24:54< celticminstrel> Then that commit probably breaks MSC 2013.
20170415 06:24:57< celticminstrel> ^MSVC
20170415 06:25:17< celticminstrel> Because IIRC it's illegal to initialize a non-const static inline.
20170415 06:26:09< celticminstrel> Why not just make it const though? There's no reason to even use constexpr there.
20170415 06:26:32< celticminstrel> For constants, there's literally no difference between const and constexpr AFAIK.
20170415 06:26:34< vultraz_iOS> oh?
20170415 06:26:44< vultraz_iOS> then when should one use constexpr
20170415 06:26:50< celticminstrel> constexpr is most useful when applied to functions re-entrant functions.
20170415 06:27:02< celticminstrel> That is, functions that always return the same value for a given input.
20170415 06:27:33< vultraz_iOS> oh, i thought static const still meant the value wasn't known until runtime
20170415 06:27:39< celticminstrel> Uh what.
20170415 06:27:56< celticminstrel> Well, it's true that static const doesn't necessarily mean the value is calculated at compile-time.
20170415 06:28:07< celticminstrel> However, when you're literally just assigning a constant, it will me.
20170415 06:28:27< celticminstrel> It's only if you were assigning an expression that calls non-constexpr functions that a static const would be calculated at runtime.
20170415 06:28:34< celticminstrel> (If I recall correctly, anyway)
20170415 06:28:41< celticminstrel> ^will be
20170415 06:28:57< celticminstrel> Don't use constexpr for trivial constants. Just make them const.
20170415 06:29:17< celticminstrel> Use constexpr if it's calculated by some expression.
20170415 06:29:33< vultraz_iOS> ahhhh
20170415 06:29:37< vultraz_iOS> I see
20170415 06:29:46< vultraz_iOS> is this also the same for strings?
20170415 06:29:51< celticminstrel> Even then it may not really be necessary, but that's the situation where it might be needed, at least.
20170415 06:29:54< celticminstrel> Strings?
20170415 06:30:05< celticminstrel> This applies to primitive types, at least.
20170415 06:30:06< vultraz_iOS> is constexpr not needed for string constants
20170415 06:30:12< celticminstrel> And that should include const char*
20170415 06:30:22< celticminstrel> But whether it includes std::string, I'm not sure.
20170415 06:30:36< celticminstrel> I would be unsurprised if it didn't.
20170415 06:30:54< vultraz_iOS> ok, so I should use constexpr for string constants
20170415 06:31:05< celticminstrel> Probably, yeah.
20170415 06:31:16< celticminstrel> But not for integer or floating-point or pointer constants.
20170415 06:31:20< vultraz_iOS> alright
20170415 06:31:25< celticminstrel> (Generally the latter would only be string literals, really.)
20170415 06:31:37< celticminstrel> Unless it's assigned a complicated expression, then you can use constexpr.
20170415 06:31:58< celticminstrel> Like, I dunno, "int w = cos(y) * sin(x) - 42"
20170415 06:32:17< celticminstrel> That could use constexpr.
20170415 06:33:05< celticminstrel> Though sin and cos are probably specified to be constexpr in C++11, I'd guess, so it might not be necessary in that specific case, but it would make sense to use it anyway,
20170415 07:03:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 07:06:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170415 07:07:14-!- atarocch [~atarocch@31.157.104.99] has joined #wesnoth-dev
20170415 07:12:20< JyrkiVesterinen> celmin is correct, current master doesn't build with MSVC2013.
20170415 07:12:21< JyrkiVesterinen> 2>i:\battle for wesnoth\wesnoth\src\units\unit.hpp(1355): error C2864: 'unit::num_bool_states' : a static data member with an in-class initializer must have non-volatile const integral type (..\..\src\carryover.cpp)
20170415 07:12:48-!- celticminstrel is now known as celmin|sleep
20170415 07:19:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170415 07:32:26< Kwandulin> Will we see items being affected by ToD (visually)? Looking a bit strange, when those are popping out, especially when the ToD colour changes became a bit stronger recently
20170415 07:34:47< zookeeper> right... they should be
20170415 07:34:54< zookeeper> or at least i can't think of any reason why they shouldn't
20170415 07:38:12< Kwandulin> Dunno what would happen to the items' halos, though. Probably unaffected?
20170415 07:39:53< zookeeper> maybe. at least unit halos aren't affected by ToD, IIRC
20170415 07:40:19< irker490> wesnoth: Jyrki Vesterinen wesnoth:master efb857a3191d / src/units/unit.hpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/efb857a3191d7a1ccb6c1eaffadce6218860df8b
20170415 07:40:53< zookeeper> hmh... i wonder if we could have a dummy IPF for marking a oh wait i did that already in one place
20170415 07:41:38< zookeeper> namely, i made it so that if you put ~NO_TOD_SHIFT() on a terrain image, it won't be ToD-shifted. should be easy enough to make that work elsewhere too.
20170415 07:42:05< zookeeper> or at least presumably not terribly difficult, perhaps
20170415 07:43:10< Kwandulin> a ~TOD_SHIFT() would be great then
20170415 07:47:19< zookeeper> that, or alternatively just using ToD-shifting everywhere but letting one disable it with ~NO_TOD_SHIFT().
20170415 07:47:41< zookeeper> dunno, haven't really looked at the code which draws items and halos
20170415 08:02:20< zookeeper> now i have (briefly) and it sure looks like it's supposed to ToD-shift them.
20170415 08:09:48< zookeeper> for those interested, i'm referring to https://github.com/wesnoth/wesnoth/blob/master/src/display.cpp#L2607-L2638
20170415 08:11:14< zookeeper> it's too complicated to figure out how that overlays thingy is supposed to work though
20170415 08:12:24< zookeeper> it's a pair of Itors which are overlay_map::const_iterators and overlay_map is a std::multimap<map_location, overlay>... yeah, whatever, i give up
20170415 08:24:51< vultraz_iOS> celmin|sleep: apparently constexpr cannot be used with strings
20170415 08:32:22< JyrkiVesterinen> celmin|sleep: I reviewed https://github.com/wesnoth/wesnoth/commit/06c9e59065de3dc43bdcc48efa42abd910d4a7c9 .
20170415 08:42:11< zookeeper> humm... actually, surely that get_light_string(-1 should be 0 instead... i'll give it a try later today.
20170415 08:43:18-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170415 09:16:27-!- Kwandulin [~Kwandulin@p200300760F6D8067C106474B65342408.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170415 09:19:47< irker490> wesnoth: Jyrki Vesterinen wesnoth:master d1df341371f8 / src/gui/widgets/widget.cpp: Fix: with --new-widgets advanced preferences may not shrink on deselect https://github.com/wesnoth/wesnoth/commit/d1df341371f8356586cdd3ca2696ad1d0aaf56f0
20170415 09:21:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170415 09:23:00-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 09:25:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20170415 09:25:27-!- wedge010 is now known as wedge009
20170415 09:47:06-!- Kwandulin [~Kwandulin@p200300760F6D8067C106474B65342408.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170415 09:55:42-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170415 10:05:12< zookeeper> Kwandulin, looks like it'll be an easy fix to make items be ToD-shifted (again?)
20170415 10:05:32< Kwandulin> zookeeper: sounds great!
20170415 10:05:37< zookeeper> it looks like they currently only get shifted if the location has a local ToD, but items in the global ToD area don't
20170415 10:05:46< Kwandulin> Yeah, i am pretty sure they were tod'ed befor
20170415 10:06:13< Kwandulin> Ah, now that's a special case
20170415 10:06:48< zookeeper> anyway, i'll clean up and verify my fix maybe tonight
20170415 10:07:04-!- JyrkiVesterinen [~JyrkiVest@87-100-224-41.bb.dnainternet.fi] has quit [Quit: .]
20170415 10:10:59< irker490> wesnoth: Charles Dang wesnoth:master 3c4e6f0f71cb / src/units/unit.cpp: Unit: code cleanup https://github.com/wesnoth/wesnoth/commit/3c4e6f0f71cbc22a372206ae5fdb1a90653833ca
20170415 10:11:02< irker490> wesnoth: Charles Dang wesnoth:master 61992429d003 / src/ (10 files in 5 dirs): Avoid copy initialization of colors when possible https://github.com/wesnoth/wesnoth/commit/61992429d0030302fe3f5a9f32e579954c6ef298
20170415 10:17:45-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 10:18:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20170415 10:18:59-!- wedge010 is now known as wedge009
20170415 10:34:24-!- mjs-de [~mjs-de@b9168e77.cgn.dg-w.de] has joined #wesnoth-dev
20170415 11:02:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 11:21:59-!- atarocch [~atarocch@31.157.104.99] has quit [Ping timeout: 260 seconds]
20170415 11:30:18-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170415 11:33:18< irker490> wesnoth: Charles Dang wesnoth:master 63403c90a5c6 / src/gui/dialogs/story_viewer.cpp: Story Viewer: made text fade smoother https://github.com/wesnoth/wesnoth/commit/63403c90a5c6013d3b630d206c6df4e6f0cc7a95
20170415 11:34:44-!- atarocch [~atarocch@37.176.201.13] has joined #wesnoth-dev
20170415 11:37:02-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 11:37:39 * vultraz_iOS ponders
20170415 11:37:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20170415 11:37:41-!- wedge010 is now known as wedge009
20170415 11:37:44< vultraz_iOS> what do do about the scaling...
20170415 11:43:11< vultraz_iOS> zookeeper: i assume we want all the backgrounds to appear the same in the new viewer
20170415 11:45:24 * vultraz_iOS asks, slightly rhetorically
20170415 11:45:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 11:46:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 11:48:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20170415 11:50:08-!- mjs-de [~mjs-de@b9168e77.cgn.dg-w.de] has quit [Remote host closed the connection]
20170415 11:50:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 11:53:35-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 11:54:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20170415 11:54:57-!- wedge010 is now known as wedge009
20170415 11:55:24< vultraz_iOS> hmmmm
20170415 11:55:27< vultraz_iOS> ok i see more problems..
20170415 11:57:55< vultraz_iOS> ok I think I have something here..
20170415 12:01:03-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170415 12:01:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20170415 12:01:51-!- wedge010 is now known as wedge009
20170415 12:02:24-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20170415 12:04:46-!- JyrkiVesterinen [~JyrkiVest@87-100-224-41.bb.dnainternet.fi] has joined #wesnoth-dev
20170415 12:21:12-!- Kwandulin2 [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170415 12:21:38< vultraz_iOS> ok, so i've restored the behavior
20170415 12:21:39< vultraz_iOS> I think
20170415 12:21:48< vultraz_iOS> by using similar code to what the old screen used..
20170415 12:21:57< vultraz_iOS> now, to see if I can simply this..
20170415 12:22:41-!- Kwandulin [~Kwandulin@p200300760F6D8067C106474B65342408.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20170415 12:30:02-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170415 12:36:30< irker490> wesnoth: Charles Dang wesnoth:master e150c7c0701a / src/gui/dialogs/story_viewer.cpp: Story Viewer: fix situational incorrect scaling of background images https://github.com/wesnoth/wesnoth/commit/e150c7c0701aed54720f23c118a02a7be6e003d8
20170415 12:36:42< vultraz_iOS> zookeeper: ^ 
20170415 12:40:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 12:41:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 13:10:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170415 13:13:47< irker490> wesnoth: Charles Dang wesnoth:master 5b08c1f37bbd / src/gui/dialogs/story_viewer.cpp: Story Viewer: fix background images with no scaling specified being scaled https://github.com/wesnoth/wesnoth/commit/5b08c1f37bbdc59039675ad8ce9c939919a05d66
20170415 13:15:22< irker490> wesnoth: Charles Dang wesnoth:master e3e0320ff0b0 / src/gui/dialogs/story_viewer.cpp: Story Viewer: use consistent variables for scaling calculations (fixup e150c7c) https://github.com/wesnoth/wesnoth/commit/e3e0320ff0b0265e202b013cf6b4614fd34a9f4b
20170415 13:27:57-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170415 13:31:57< irker490> wesnoth: Charles Dang wesnoth:master 120aa0e6caf6 / data/gui/widget/label_story_screen_title.cfg: Story Viewer Label: ensure sufficient top padding for text https://github.com/wesnoth/wesnoth/commit/120aa0e6caf6876afa9f44dea8c1b6cd9efb28c4
20170415 13:33:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 13:34:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 13:39:30< irker490> wesnoth: Charles Dang wesnoth:master 1ff3f7e25164 / src/gui/dialogs/story_viewer.cpp: Story Viewer: allow returning to the previous part during text fade-in https://github.com/wesnoth/wesnoth/commit/1ff3f7e2516437a8818e71aa0e228d630d70b0ae
20170415 14:02:36-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170415 14:12:24-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170415 14:15:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20170415 14:22:10-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170415 14:25:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 14:38:57-!- Kwandulin2 [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170415 14:41:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 14:46:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 14:47:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 15:02:22< vultraz_iOS> zookeeper: https://forums.wesnoth.org/viewtopic.php?p=610708#p610708
20170415 15:11:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170415 15:20:39< zookeeper> vultraz_iOS, perhaps you'd enjoy making sure there's nothing gone particularly wrong due to the gif conversion, cleaning up whatever other artifacts it might have, fixing the shadows, optimizing them, wiring them in, testing them and committing? :p
20170415 15:21:49< vultraz_iOS> I can give you the images
20170415 15:22:15< vultraz_iOS> if you wire them in
20170415 15:22:48< zookeeper> what does that even mean "give you the images"? the images are right there.
20170415 15:23:06< zookeeper> fixing the shadows? uh, well, sure
20170415 15:23:46< zookeeper> i just really couldn't care less about some death animation so i'm not promising to do anything about it anytime soon, though
20170415 15:24:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 15:26:48< vultraz_iOS> nice, there's weird image palette issues here 
20170415 15:27:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 15:27:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 15:29:06< vultraz_iOS> really weird o-O
20170415 15:30:37-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170415 15:32:37< vultraz_iOS> and they're not even square ;_;
20170415 15:34:11< vultraz_iOS> though I guess they don't *need* to be
20170415 15:34:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Read error: Connection reset by peer]
20170415 15:35:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 15:35:59< zookeeper> if there's no reason for them to not be square, then they should be
20170415 15:36:17< zookeeper> (also of course you need to make sure they're aligned right WRT the base frame)
20170415 15:36:26< vultraz_iOS> I guess they're not since the mage flies way to the left
20170415 15:37:16-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170415 15:39:56< zookeeper> sure, that means the frames should increase in dimensions when necessary
20170415 15:40:08< zookeeper> they don't have to really stay square in that case
20170415 15:40:11< vultraz_iOS> only when necessary?
20170415 15:41:27< zookeeper> the frames which fit into 72x72 should be 72x72, and the frames which need more than that should be whatever size is needed. although it's convenient if you make all of those the same size, like 90x72 or whatever the widest frame needs.
20170415 15:42:05< zookeeper> but it's certainly not a disaster if you just make them all 90x72 (or whatever) instead of having two different frame sizes
20170415 15:42:12< zookeeper> maybe that even makes more sense
20170415 15:42:27< vultraz_iOS> alright
20170415 15:42:32< vultraz_iOS> right now they're 86x72
20170415 15:42:59< vultraz_iOS> oh, look, that guy finished the Elvish Fighter run :o
20170415 15:44:15< celmin|sleep> [Apr 15@04:24:51am] vultraz_iOS: celmin|sleep: apparently constexpr cannot be used with strings
20170415 15:44:17< celmin|sleep> What?
20170415 15:44:43< vultraz_iOS> https://stackoverflow.com/questions/27123306/is-it-possible-to-use-stdstring-in-a-constexpr
20170415 15:47:42< vultraz_iOS> Looks like c++ extended constexpr gives you more options  but I'm not sure if you can declare strings constexpr there either
20170415 15:49:16< celmin|sleep> Ah.
20170415 15:50:14< vultraz_iOS> C++14 that is
20170415 15:51:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 16:13:16-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170415 16:26:04-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170415 16:34:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170415 16:36:07-!- celmin|sleep is now known as celticminstrel
20170415 16:39:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170415 16:40:29-!- irker490 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170415 17:12:25-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170415 17:14:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170415 17:14:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 17:15:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 17:16:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 17:18:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 17:20:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 17:21:40-!- gfgtdf [~chatzilla@x4e32b12f.dyn.telefonica.de] has joined #wesnoth-dev
20170415 17:21:51< gfgtdf> vultraz_iOS: why do you want conxstexpr strings ?
20170415 17:22:11< vultraz_iOS> just figured it could be used for various string constants we have
20170415 17:22:44< celticminstrel> I personally feel that named string contants should not be std::string.
20170415 17:22:52< celticminstrel> They should be char[n] instead.
20170415 17:23:04< celticminstrel> const char the_string[] = "the string";
20170415 17:23:25< JyrkiVesterinen> Constexpr isn't very useful in the Wesnoth codebase in practice, because MSVC2013 doesn't support it.
20170415 17:23:28< celticminstrel> char* would work too but not sure if it would work as well.
20170415 17:23:32< gfgtdf> celticminstrel: that's reqzure  constructing a temporary strign each time it's used.
20170415 17:23:52< celticminstrel> gfgtdf: And how expensive is calculating a temporary string?
20170415 17:24:17< gfgtdf> depends on whether the strings is bigger than the short string potinsation buffer
20170415 17:24:18< JyrkiVesterinen> Even if a function is marked as CONSTEXPR, we can't use its return value as e.g. an array length.
20170415 17:24:20< celticminstrel> ^constructing
20170415 17:24:39< gfgtdf> if its lower then its just copying the string once.
20170415 17:25:14< celticminstrel> Why would it matter what the length of the string is?
20170415 17:25:42< celticminstrel> You'd expect the char* string constructor to do the equivalent of "this->reserve(strlen(s))" first.
20170415 17:26:01< gfgtdf> celticminstrel: if it too long the sting data doesnt fit into the std::string itself and needs to be placed on the heap.
20170415 17:26:11< celticminstrel> Anyway, string constants generally are short.
20170415 17:26:38< gfgtdf> actuall c++17 seems to have a  std::string_view class that will replace all those 'const std::string&' types used.
20170415 17:26:56< celticminstrel> I saw that in the answer vultraz linked and was wondering "what the heck is this".
20170415 17:27:09< vultraz_iOS> what the heck is string_view?
20170415 17:27:33< vultraz_iOS> hm
20170415 17:27:37< vultraz_iOS> what is this good for
20170415 17:27:42< gfgtdf> vultraz_iOS: a lot of functions take 'const std::string& str' parameters which is kinda unflexible.
20170415 17:28:11< celticminstrel> ^inflexible
20170415 17:28:17< gfgtdf> vultraz_iOS: becasue in particular if the caller only has some strign data that is not stored in a std::string it needs to temporariyl copy them into a temporarly std::string
20170415 17:28:54< gfgtdf> vultraz_iOS: string_view is more or less  boost::boost::iterator_range<const char*>
20170415 17:29:01< gfgtdf> boost::iterator_range<const char*> i meant
20170415 17:29:03< vultraz_iOS> hmm
20170415 17:29:12< vultraz_iOS> reading here it seems a more efficient method of working with strings
20170415 17:29:23< vultraz_iOS> this could be great for the preprocessor
20170415 17:29:32< celticminstrel> Well, it doesn't matter how much more efficient it is, because we absolutely cannot use it ever.
20170415 17:29:38< vultraz_iOS> why not?
20170415 17:29:42< celticminstrel> For the 1.14 version, at least.
20170415 17:29:49< vultraz_iOS> that's not ever :P
20170415 17:29:58< celticminstrel> It's not ever for the 1.14 version.
20170415 17:30:20< vultraz_iOS> of course
20170415 17:30:27< vultraz_iOS> is the 17 standard even ratified yet?
20170415 17:30:32< celticminstrel> No ideas.
20170415 17:30:35< celticminstrel> ^-s
20170415 17:30:56< celticminstrel> I don't suppose it includes global overloading of operator->
20170415 17:31:40< vultraz_iOS> "The committee has completed work on C++17, which is now in its final ISO balloting process, and aims to begin work on C++20 in July."
20170415 17:32:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 17:32:32< vultraz_iOS> I guess we won't be able to use it until 2022, though :P
20170415 17:32:44< celticminstrel> Oh nice, fallthrough became standard.
20170415 17:32:49< celticminstrel> As an attribute
20170415 17:34:20< vultraz_iOS> looks like most of the c++17 features are already in GCC as of 7
20170415 17:34:30< gfgtdf> vultraz_iOS: about constxpr: you can only use types in a constexpr functions whose constructor is a constexpr function.
20170415 17:34:42< gfgtdf> any opinion on dropping msvc2013 ?
20170415 17:34:55< celticminstrel> gfgtdf: Not before 1.14 is released.
20170415 17:35:08< vultraz_iOS> i don't know why you keep saying that
20170415 17:35:17< vultraz_iOS> there's no benefit either way, though
20170415 17:36:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 17:36:52< vultraz_iOS> but I'm curious what 1.14 enables 
20170415 17:36:54< vultraz_iOS> er
20170415 17:36:58< vultraz_iOS> what 2013 enables for 1.14
20170415 17:37:30-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170415 17:38:09< celticminstrel> It's more that we shouldn't be dropping support for some compiler just a month or three before the release.
20170415 17:39:47< vultraz_iOS> point taken
20170415 17:41:27< vultraz_iOS> still, i maintain it would be nice to have 100% c++11 in the 1.14 codebase.
20170415 17:41:45< celticminstrel> FTR, C++98 code is still C++11 code.
20170415 17:42:02< celticminstrel> So you could say it's already 100% C++11.
20170415 17:42:51< celticminstrel> So any and optional got adopted, huh...
20170415 17:42:59< celticminstrel> Oh and variant.
20170415 17:43:03< vultraz_iOS> yes
20170415 17:43:52< JyrkiVesterinen> Still, there is too much stuff that didn't make it. Reflection for example. :/
20170415 17:44:20< celticminstrel> Reflection is hard.
20170415 17:44:22< vultraz_iOS> c++20 maybe?
20170415 17:45:03< celticminstrel> And half the users would compile it out anyway, by turning exceptions off.
20170415 17:45:15< vultraz_iOS> why?
20170415 17:45:40< celticminstrel> I don't have any examples off the top of my head, but there are applications where exceptions are an unacceptable performance hit.
20170415 17:45:47< celticminstrel> Generally in embedded systems, I think.
20170415 17:48:17< celticminstrel> Hmm, wonder if template<auto value> void f() is equivalent to template<typename T, T value> void f().
20170415 17:48:57< celticminstrel> Apart from the extra template parameter not actually being a template parameter in the first case (you'd need to use decltype(value) I guess).
20170415 17:50:34< celticminstrel> ...wait, did the standard actually guarantee the order of function parameter evaluations?
20170415 17:54:22-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170415 17:56:23< celticminstrel> Ah, looks like I misread. It's still undetermined.
20170415 17:58:50< celticminstrel> So is it my imagination or do the new rules mean that there's now a difference between "operator+(a,b)" and "a + b"?
20170415 18:03:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 18:07:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 18:15:32-!- irker968 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170415 18:15:32< irker968> wesnoth: ln-zookeeper wesnoth:master 478c75bdb5bc / src/display.cpp: Fixed [item]s not receiving ToD lighting https://github.com/wesnoth/wesnoth/commit/478c75bdb5bc914fcd71469a2ae6967cadc99e11
20170415 18:15:49< zookeeper> Kwandulin, ^ at least according to my testing that should fix the issue(s).
20170415 18:22:23< gfgtdf> hmm didn't we fix exactly the same issue not too long ago?
20170415 18:23:23-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170415 18:23:33< zookeeper> gfgtdf, maybe, i couldn't exactly find out when it had broken
20170415 18:27:11< gfgtdf> it was some discussion about this commit https://github.com/wesnoth/wesnoth/commit/d131f1d58c5b343e4119e201204fcc3ecbb53c7d breaking tod_coloring of items by removign use_local_light variable.
20170415 18:27:29< gfgtdf> hmm maybe we just forgot to fix it back then.
20170415 18:32:56< gfgtdf> ah now i remember now, i told that guy who told me to file bugreport, and i forgot it then.
20170415 18:34:29< vultraz_iOS> is there a bug for it?
20170415 18:35:09< gfgtdf> afaik not
20170415 18:36:25< vultraz_iOS> btw how's the slider work coming?
20170415 18:38:19< gfgtdf> hmm ye i did some work on it, my plan was to move the 'step' handling out of the base class to the actual slider class.might work out might not
20170415 18:40:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 18:41:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170415 18:43:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 18:49:47-!- trewe [~trewe@2001:8a0:d12d:2801:973c:2991:9775:12d5] has joined #wesnoth-dev
20170415 18:51:36 * vultraz_iOS browses old bug reports
20170415 18:56:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 19:06:32-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170415 19:10:29-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170415 19:12:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 19:13:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 19:14:44-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 19:16:15-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 19:33:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 19:35:44< irker968> wesnoth: Charles Dang wesnoth:master 96ef6b1f5a48 / data/gui/window/ (4 files in 2 dirs): MP Create Game: ensure campaign icons always line up (bug #22956) https://github.com/wesnoth/wesnoth/commit/96ef6b1f5a48157bd30926ce7ea4370209031ab7
20170415 19:54:08-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170415 20:09:19< irker968> wesnoth: Charles Dang wesnoth:master 1ea440fed3dd / data/gui/widget/menu_button_default.cfg: Menu Button: fix overlap of long text and down arrow (bug #25320) https://github.com/wesnoth/wesnoth/commit/1ea440fed3ddeca968663cb67bcabb7546474c0d
20170415 20:17:33< vultraz_iOS> gfgtdf: do you have any idea where i would look to fix this https://gna.org/bugs/index.php?24383
20170415 20:18:10< gfgtdf> vultraz_iOS: afaik we just had a pr that should fixed this but was too messy to be merged
20170415 20:18:25< vultraz_iOS> whar pr?
20170415 20:19:07< gfgtdf> https://github.com/wesnoth/wesnoth/pull/973
20170415 20:19:29< gfgtdf> is basically rmoved game_initialization/multiplayer.cpp#L407
20170415 20:19:38< vultraz_iOS> hm
20170415 20:19:40< gfgtdf> i didn't test it tough
20170415 20:19:40< vultraz_iOS> let me confirm
20170415 20:20:15-!- gfgtdf [~chatzilla@x4e32b12f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170415 20:20:49-!- gfgtdf [~chatzilla@x4e32b12f.dyn.telefonica.de] has joined #wesnoth-dev
20170415 20:22:17< vultraz_iOS> it does
20170415 20:22:19< vultraz_iOS> will commit
20170415 20:22:26< vultraz_iOS> thanks for pointing it out
20170415 20:23:37< irker968> wesnoth: Charles Dang wesnoth:master 3efcc2a31db3 / src/game_initialization/multiplayer.cpp: Fixed statistics being reset on reloading an MP game (bug #24383) https://github.com/wesnoth/wesnoth/commit/3efcc2a31db313b23664861bbe7e77de26b175d0
20170415 20:32:57< vultraz_iOS> we really do owe sigurd and shiki many thanks for testing the releases so thoroughly 
20170415 20:33:12< celticminstrel> What about Pentarctagon?
20170415 20:34:42< vultraz_iOS> certainly
20170415 20:35:14-!- JyrkiVesterinen [~JyrkiVest@87-100-224-41.bb.dnainternet.fi] has quit [Quit: .]
20170415 20:38:02< vultraz_iOS> celticminstrel: what's the syntax for filling a dynamic_bitset of size with 'false' again?
20170415 20:38:12< vultraz_iOS> or, really, just resetting a bitset to all false?
20170415 20:38:22< celticminstrel> b.unset() IIRC
20170415 20:38:31< celticminstrel> Or b.clear() I suppose.
20170415 20:38:35< celticminstrel> Why?
20170415 20:39:16< vultraz_iOS> need to fill a bitset with false
20170415 20:39:30< celticminstrel> A dynamic one?
20170415 20:39:43< vultraz_iOS> yes
20170415 20:39:49< celticminstrel> What for?
20170415 20:40:02< vultraz_iOS> https://gna.org/bugs/index.php?25620
20170415 20:42:49< celticminstrel> Speaking of which, the hotkeys dropdown doesn't work right at all.
20170415 20:43:01< celticminstrel> For starters, when you first open it, all the checkboxes should be checked.
20170415 20:43:21< celticminstrel> And another thing - it shouldn't show "General" or anything like that in the menu button.
20170415 20:43:23< vultraz_iOS> actually, this mirrors behavior in the addon manager that jyrki introduced
20170415 20:43:31< vultraz_iOS> none = all
20170415 20:44:17< vultraz_iOS> and yes, I know it shouldn't show 'general
20170415 20:44:23< vultraz_iOS> haven't gotten to fixing that yet
20170415 20:44:55< celticminstrel> Hmm. Not sure I like the none=all behaviour, honestly.
20170415 20:45:05< celticminstrel> But it should definitely not be showing just the first item.
20170415 20:45:25< celticminstrel> Either show a string indicating which are checked, or show a placeholder string.
20170415 20:45:35< celticminstrel> And speaking of the addons manager, it's totally broken at 800x600.
20170415 20:45:44< vultraz_iOS> likely
20170415 20:45:52< celticminstrel> No. It is.
20170415 20:46:55< gfgtdf> i do think the  none = all beaviour is what one  woudl expect. In particular becasue having all checboxed woudl be checked at start one woudl mean you need to unceck all others manualyl if one would want to see onyl one type.
20170415 20:47:31< celticminstrel> It's clearly going to be impossible to make an 800x600 addons manager that shows everything at once...
20170415 20:48:14< celticminstrel> I'm going to push a commit to the frame_cleanup branch based on Jyrki's feedback and then leave it for awhile, because I don't know why it's broken.
20170415 20:48:27< celticminstrel> (My best guess is something about the difference in layer default.)
20170415 20:48:27-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 268 seconds]
20170415 20:49:05< irker968> wesnoth: Celtic Minstrel wesnoth:frame_cleanup 47c6cbebb3c8 / src/units/ (frame.cpp frame.hpp): Address feedback https://github.com/wesnoth/wesnoth/commit/47c6cbebb3c8944095febf0729280835deac9b53
20170415 20:51:11< irker968> wesnoth: Charles Dang wesnoth:master fb0f2eef106c / src/gui/widgets/ (menu_button.cpp menu_button.hpp): Menu Button: add ability to reset stored toggle states https://github.com/wesnoth/wesnoth/commit/fb0f2eef106c40354d55c787139de696ff7050ad
20170415 20:51:14< irker968> wesnoth: Charles Dang wesnoth:master 13d2f010e90f / src/gui/dialogs/preferences_dialog.cpp: Preferences Dialog: reset hotkey filter toggle states when resetting to default  https://github.com/wesnoth/wesnoth/commit/13d2f010e90f5db588b8b1f5100c4c41634962a2
20170415 20:51:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 20:51:17< irker968> wesnoth: Charles Dang wesnoth:master 88430d3b8845 / src/gui/dialogs/preferences_dialog.cpp: Preferences Dialog: removed an invalidate_layout call https://github.com/wesnoth/wesnoth/commit/88430d3b88455fc982a76367154720729630f42d
20170415 20:52:35< vultraz_iOS> celticminstrel: turns out reset() is what I needed
20170415 20:52:39< vultraz_iOS> clear(), well, clears
20170415 20:54:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170415 20:56:48< celticminstrel> Works much better with a stacked_widget, but still has a scrollbar...
20170415 20:57:02< vultraz_iOS> What?
20170415 20:57:07< vultraz_iOS> Oh the addons manager?
20170415 20:57:12< celticminstrel> Stacked widget WML doesn't allow specifying the initially visible layer, right?
20170415 20:57:21< vultraz_iOS> Not the wml no
20170415 20:57:29< vultraz_iOS> You could add such a thing easily
20170415 21:00:56< celticminstrel> Basically all I did is replace your panel with a stacked_widget so that it has two layers instead of two columns.
20170415 21:02:57< vultraz_iOS> What?
20170415 21:03:07< vultraz_iOS> I don't follow
20170415 21:06:03< vultraz_iOS> Oh
20170415 21:06:08< vultraz_iOS> I think I get what you're saying
20170415 21:19:22< celticminstrel> Now using the four-argument version of find_widget for its intended use, wheeee.
20170415 21:20:09< celticminstrel> Oh right, also need a low-res addon_list definition...
20170415 21:25:55-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20170415 21:26:11-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170415 21:27:24-!- trewe [~trewe@2001:8a0:d12d:2801:973c:2991:9775:12d5] has quit [Quit: quit]
20170415 21:29:06-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170415 21:29:39-!- mjs-de [~mjs-de@185.22.140.69] has joined #wesnoth-dev
20170415 21:30:54< gfgtdf> celticminstrel: wait you are working on the addons manager layout ?
20170415 21:31:03< celticminstrel> Yes
20170415 21:31:47< gfgtdf> celticminstrel: but that panel replacement is onyl on lower resultions right? it woudl really suck at higher (normal) resif you couldn't see description withotu an extra click
20170415 21:31:56< celticminstrel> Of course.
20170415 21:40:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 21:48:26-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Quit: Verlassend]
20170415 21:50:58-!- mjs-de [~mjs-de@185.22.140.69] has quit [Remote host closed the connection]
20170415 21:54:52-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 258 seconds]
20170415 21:56:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 21:58:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 21:58:40-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170415 21:59:19-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170415 22:15:32-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170415 22:22:22< celticminstrel> vultraz_iOS: It works really well, but we need to reduce the width of the addon list itself, too.
20170415 22:22:32< celticminstrel> I notice the version column in particular is absurdly wide.
20170415 22:24:39< irker968> wesnoth: Celtic Minstrel wesnoth:master 4fbc94361267 / / (3 files in 2 dirs): Addons Manager: New layout for resolutions < ~1280x800 https://github.com/wesnoth/wesnoth/commit/4fbc943612672377c5c5a77e55e29ad81b11782e
20170415 22:24:52< celticminstrel> There's probably also some redundancy that could be reduced with macros.
20170415 22:25:17< celticminstrel> I also wondered if it would be okay to remove some of the columns of the addons list on 800x600?
20170415 22:25:37< celticminstrel> Not sure if it'll be necessary if you make general adjustments to its overall width, though.
20170415 22:26:06< celticminstrel> IIRC the Staging screen also needs a low-res definition...
20170415 22:34:30< irker968> wesnoth: IWAI, Masaharu website:master 59d16419bfff / start/1.12/template.html: The 1.12.6 release https://github.com/wesnoth/website/commit/59d16419bffff31c803bfe1998e2f92a6af698b8
20170415 22:34:32< irker968> wesnoth: Ignacio R. Morelle website:master 77963c8a9063 / start/1.12/ (62 files in 2 dirs): pofix pass for the 1.12.6 release https://github.com/wesnoth/website/commit/77963c8a90639a89fdb3dce14d0fb81079b4e5fd
20170415 22:35:05< irker968> wesnoth: Ignacio R. Morelle wesnoth:1.12 a1cead45a7f0 / utils/pofix.py: pofix: Add download path string fixes for the 1.12.6 release https://github.com/wesnoth/wesnoth/commit/a1cead45a7f093caf50b540fe0efdb67045d00af
20170415 22:35:31< irker968> wesnoth: Ignacio R. Morelle wesnoth:master 9ba02c0900f4 / utils/pofix.py: pofix: Add download path string fixes for the 1.12.6 release https://github.com/wesnoth/wesnoth/commit/9ba02c0900f4758bb55d8fd15113e1838ea1eaa3
20170415 22:46:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 22:47:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 22:58:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 22:58:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170415 22:58:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170415 23:15:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20170415 23:39:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170415 23:40:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 23:46:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170415 23:47:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170415 23:47:47-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
--- Log closed Sun Apr 16 00:00:53 2017