--- Log opened Sun Apr 16 00:00:53 2017
20170416 00:05:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 00:07:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170416 00:31:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 00:32:39-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 00:44:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20170416 00:46:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 01:08:07-!- gfgtdf_ [~chatzilla@x4e363696.dyn.telefonica.de] has joined #wesnoth-dev
20170416 01:10:19-!- gfgtdf [~chatzilla@x4e32b12f.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170416 01:10:32-!- gfgtdf_ is now known as gfgtdf
20170416 01:11:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 01:15:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 01:23:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 01:24:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 01:25:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 01:34:58< irker968> wesnoth: Celtic Minstrel wesnoth:master cb333dbfdf3d / data/gui/widget/addon_list.cfg src/gui/widgets/addon_list.cpp: Addons List: Hide some columns on lower resolutions https://github.com/wesnoth/wesnoth/commit/cb333dbfdf3da70f8f657052ef2e8f8650b0ac29
20170416 01:35:35< celticminstrel> ^ That might break the "install dependencies" dialog on 800x600 resolution (or even on 1024x768).
20170416 01:36:09< celticminstrel> Especially if the control buttons are needed in that dialog box, because that commit removes them altogether at 800x600.
20170416 01:36:23< celticminstrel> I did that because they're duplicated in the details area anyway.
20170416 01:39:56< celticminstrel> Uh-oh. Create Game seems fine at 800x600, but gets a slight scrollbar at 1024x768.
20170416 02:12:33-!- gfgtdf [~chatzilla@x4e363696.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170416 02:13:14< celticminstrel> Ugh, menu_button.
20170416 02:17:35-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170416 02:18:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 02:38:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 02:46:34-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 02:50:36-!- JyrkiVesterinen [~JyrkiVest@87-100-173-27.bb.dnainternet.fi] has joined #wesnoth-dev
20170416 02:57:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 02:59:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 03:06:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 03:11:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 03:20:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 03:25:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 03:27:48-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 04:09:27< irker968> wesnoth: Celtic Minstrel wesnoth:master b7aea011f92f / / (9 files in 7 dirs): Add VNGETTEXT macro to complement the VGETTEXT macro https://github.com/wesnoth/wesnoth/commit/b7aea011f92f6ecbd0ca7ea4924aa3b248625e49
20170416 04:09:29< irker968> wesnoth: Celtic Minstrel wesnoth:master 1793133a59ed / / (14 files in 8 dirs): Fix menu_button widget trying to be two things at the same time. https://github.com/wesnoth/wesnoth/commit/1793133a59edf448a990dade2ec022732e856b8c
20170416 04:09:31< irker968> wesnoth: Celtic Minstrel wesnoth:master b0039be726f7 / src/formula/string_utils.cpp: Fix VGETTEXT not stripping hint^ prefixes https://github.com/wesnoth/wesnoth/commit/b0039be726f791e9ec4532ca9200b4ee0ffef8a5
20170416 05:00:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 05:18:53-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170416 05:20:52< vultraz_iOS> I  have a feeling a lot of our low-resolution problems would go away
20170416 05:21:08< vultraz_iOS> if we used relative scaling instead of exact pixel measurements
20170416 05:23:50< vultraz_iOS> as is necessary for DPI
20170416 05:24:52< celticminstrel> vultraz_iOS: Any thoughts on my recent commits?
20170416 05:25:05< vultraz_iOS> building
20170416 05:25:25< vultraz_iOS> ftr, the version column is especially long since someone uploaded an addon with an abnormally long version string
20170416 05:25:40< celticminstrel> Then maybe there should be some length limit on version strings.
20170416 05:26:00< celticminstrel> Isn't there even a key in [label] for that?
20170416 05:26:16< vultraz_iOS> characters_per_line
20170416 05:26:21< vultraz_iOS> but it breaks on space
20170416 05:26:31< celticminstrel> ?
20170416 05:27:14< vultraz_iOS> characters_per_line breaks a line on a space
20170416 05:27:35< celticminstrel> Oh, so it fails if there are no spaces?
20170416 05:27:38< celticminstrel> That's easily fixed.
20170416 05:28:13< vultraz_iOS> excellent with with the multimenu
20170416 05:28:24< vultraz_iOS> :)
20170416 05:28:28< vultraz_iOS> work with*
20170416 05:28:35< vultraz_iOS> and good job with the addon's manager
20170416 05:28:39< vultraz_iOS> this is a nice solution
20170416 05:28:44< celticminstrel> In prefs it'd be better if it expanded to fill the available width.
20170416 05:29:07< vultraz_iOS> unlike the small-res Create which is forced to look rather cluttered (though no fault of your own)
20170416 05:29:08< vultraz_iOS> celticminstrel: ?
20170416 05:29:11< vultraz_iOS> "it"?
20170416 05:29:26< celticminstrel> The hotkey category button.
20170416 05:29:37< vultraz_iOS> easily done
20170416 05:29:42< vultraz_iOS> why do you say that?
20170416 05:29:55< celticminstrel> Because if you have more than one selected it's cut off.
20170416 05:30:10< celticminstrel> I guess it doesn't need to fill available width, just resize for the new label...
20170416 05:30:22< celticminstrel> I wonder if firing a replacement request on it would do that...
20170416 05:30:57< vultraz_iOS> hmmm
20170416 05:31:16< vultraz_iOS> celticminstrel: as for characters_per_line, feel free to implement a fix. 
20170416 05:31:22< vultraz_iOS> just noticed something else weird about it..
20170416 05:32:00< vultraz_iOS> in the low-res version, when addon names have enough space for two lines, it appears to insert a newline at the end of the string?
20170416 05:47:04-!- celticminstrel is now known as celmin|sleep
20170416 05:50:06< celmin|sleep> ...ah! I just realized I forgot to update source_lists!
20170416 05:56:54< vultraz_iOS> oh no!
20170416 06:07:25-!- mjs-de [~mjs-de@185.22.140.202] has joined #wesnoth-dev
20170416 06:09:06< irker968> wesnoth: Charles Dang wesnoth:master 70e607d04ae9 / data/gui/window/preferences/02_hotkeys.cfg: Preferences Dialog: make hotkey category multimenu fill all available space as r https://github.com/wesnoth/wesnoth/commit/70e607d04ae9f4c78cd1c7c25e45a5971cd548f4
20170416 06:09:09< irker968> wesnoth: Charles Dang wesnoth:master 82f0c0e291d9 / src/gui/widgets/multimenu_button.cpp: Multimenu Button: update label when toggle states are reset https://github.com/wesnoth/wesnoth/commit/82f0c0e291d9adf6d045087385c2ad9e7d8ee4dd
20170416 06:09:12< irker968> wesnoth: Charles Dang wesnoth:master 55e295a80112 / source_lists/wesnoth: Updated source listings for 1793133 https://github.com/wesnoth/wesnoth/commit/55e295a80112a336f2fd6c5de1f96a3b27ad27e8
20170416 06:09:15< vultraz_iOS> celmin|sleep: ^
20170416 06:13:15< irker968> wesnoth: Charles Dang wesnoth:master c11a669332e1 / src/gui/widgets/multimenu_button.cpp: Multimenu Button: avoid copy initialization of string maps https://github.com/wesnoth/wesnoth/commit/c11a669332e15da3b92e0fa5d24d89981b359713
20170416 06:15:46< irker968> wesnoth: Charles Dang wesnoth:master 511184e8f3da / projectfiles/CodeBlocks/wesnoth.cbp: Update CB projectfile https://github.com/wesnoth/wesnoth/commit/511184e8f3da1c89bef41af8e4136ac99b8888bc
20170416 06:19:35< irker968> wesnoth: Charles Dang wesnoth:master 4f50559af9ad / data/gui/ (112 files in 6 dirs): GUI2 WML: consistent styling, don't use strings for bools https://github.com/wesnoth/wesnoth/commit/4f50559af9ad89d47166aae92fe7abbdd18ef061
20170416 07:12:10-!- mjs-de [~mjs-de@185.22.140.202] has quit [Remote host closed the connection]
20170416 07:19:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170416 08:01:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 08:16:25-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 09:07:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170416 09:07:34-!- TC02 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 264 seconds]
20170416 09:20:14-!- irker968 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170416 09:22:44-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170416 09:42:49< Kwandulin> zookeeper: good job on fixing the item/tod thing. seems like there was a bit more code to change than expected
20170416 09:43:46< Kwandulin> anyway, how to proceed with the utbs sprites? I heard vultraz saying that jetrel _might_ do them sometime in the future?
20170416 09:47:54< vultraz_iOS> might
20170416 09:53:19-!- JyrkiVesterinen [~JyrkiVest@87-100-173-27.bb.dnainternet.fi] has quit [Quit: .]
20170416 09:57:05< zookeeper> Kwandulin, i'll put in kaleh, nym and the shaman (well, mystic) sometime soon before the next release. so feel free to proceed for example further into the mystic line.
20170416 09:57:48< Kwandulin> alright
20170416 09:59:39< zookeeper> and yeah jet _might_ do them in the future but that's been the case for like a year and a half, so...
20170416 10:00:30 * vultraz_iOS nods knowingly
20170416 10:14:23-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170416 10:15:32-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 10:16:47-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170416 10:20:07-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 10:44:29-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170416 10:46:06-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 10:58:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170416 10:58:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170416 11:02:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 11:06:57-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20170416 11:12:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170416 12:00:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 12:00:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 12:06:11< vultraz_iOS> celticminstrel: could you take a look at the quit confirmation weirdness when exiting an mp game?
20170416 12:09:35-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170416 12:22:21-!- Kwandulin [~Kwandulin@p200300760F6D80D0A025BE4D9EE7174A.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20170416 12:37:36-!- JyrkiVesterinen [~JyrkiVest@87-100-173-27.bb.dnainternet.fi] has joined #wesnoth-dev
20170416 12:52:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 12:53:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 13:11:55< vultraz_iOS> matthiaskrgr: how do you keep getting these issues when I don't o.o
20170416 13:12:25< matthiaskrgr> do you use ubsan? :P 
20170416 13:12:36< vultraz_iOS> I do not use ubsan
20170416 13:12:42< matthiaskrgr> see :P
20170416 13:12:48< matthiaskrgr> https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html  
20170416 13:13:09< matthiaskrgr> maybe I should write some kind of tutorial how to use it at some point
20170416 13:13:18< matthiaskrgr> but then again there are official docs also 
20170416 13:13:41< vultraz_iOS> I don't use clang either
20170416 13:13:58< matthiaskrgr> well, thats why you don't keep getting these issues :) 
20170416 13:14:25< matthiaskrgr> its build-time instrumentalization of the code
20170416 13:14:47< JyrkiVesterinen> Microsoft's debug C runtime library, used in MSVC debug builds, is also better than nothing. It can detect, for example, incorrect use of iterators.
20170416 13:14:59< matthiaskrgr> like compiler warnings at runtime instead of buildtime
20170416 13:16:10-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170416 13:18:39< matthiaskrgr> oh :( the storyscreen buffer overvlow is still there :( 
20170416 13:21:16-!- irker159 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170416 13:21:16< irker159> wesnoth: Charles Dang wesnoth:master 9d2eaf5f99c9 / src/gui/dialogs/ (story_viewer.cpp story_viewer.hpp): Story Viewer: attempt to fix UB https://github.com/wesnoth/wesnoth/commit/9d2eaf5f99c96fb889ed9fcbf6e797a62d590e2c
20170416 13:21:18< vultraz_iOS> matthiaskrgr: ^
20170416 13:24:38< vultraz_iOS> as for the other thing i still have no idea how to fix it
20170416 13:25:59< matthiaskrgr> the UB is fixed yeah :)
20170416 13:26:08< matthiaskrgr> I'll make a ticket for the crash
20170416 13:27:03< celticminstrel> <3 4f50559af9ad
20170416 13:27:52-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170416 13:29:26< celticminstrel> MSVC's incorrect iterator use detection and incorrect comparator detection has actually been quite helpful.
20170416 13:29:48< celticminstrel> The former for example helped detect using a destroyed vector in the formula engine.
20170416 13:29:58< matthiaskrgr> https://gna.org/bugs/index.php?25661  
20170416 13:30:30< celticminstrel> Oh huh, apparently there was a connection hiccup so my nick changed itself.
20170416 13:30:48< matthiaskrgr> 15:25 < matthiaskrgr> the UB is fixed yeah :)
20170416 13:30:49< matthiaskrgr> hmm wait
20170416 13:30:51< matthiaskrgr> strange
20170416 13:32:24< matthiaskrgr> it's still there
20170416 13:32:40< matthiaskrgr> maybe there was something strange in the campeign I looked at that didn't trigger it always :( 
20170416 13:33:27< vultraz_iOS> hm
20170416 13:33:41< vultraz_iOS> i wonder if with an unsigned value you can never use max<val, 0>...
20170416 13:33:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170416 13:33:46< matthiaskrgr> what happens if you change the "-1" to 0 ? 
20170416 13:33:57< vultraz_iOS> bad behavior
20170416 13:34:01< matthiaskrgr> :(
20170416 13:34:08-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170416 13:34:13< vultraz_iOS> needed for this condition 
20170416 13:34:14< vultraz_iOS> if(!fading_in_ && fade_step_ < 0) {
20170416 13:34:49< matthiaskrgr> mmh
20170416 13:36:01< vultraz_iOS> this is weird
20170416 13:36:09< vultraz_iOS> and as is your crash
20170416 13:36:14< vultraz_iOS> there's literally NO WAY it should happen
20170416 13:36:29< matthiaskrgr> well it could be a bug in clang 
20170416 13:36:35< matthiaskrgr> since I'm using the dev version
20170416 13:37:16< matthiaskrgr> but then again I don't have any crazy optimizations enabled
20170416 13:37:23< matthiaskrgr> only -Og 
20170416 13:39:29< vultraz_iOS> i mean, get part is called here..
20170416 13:39:31< vultraz_iOS> current_part_ = controller_.get_part(part_index_);
20170416 13:39:41< vultraz_iOS> but part_index is always valid
20170416 13:39:45< vultraz_iOS> and you said it never asserts
20170416 13:40:37< vultraz_iOS> unless there's something bad about using operator= with shared_ptrs here?
20170416 13:41:04-!- mjs-de [~mjs-de@b9168ec5.cgn.dg-w.de] has joined #wesnoth-dev
20170416 13:42:41< celticminstrel> Why is the addon image all lonely in a column by itself?
20170416 13:44:00< matthiaskrgr> hmmm
20170416 13:44:22< matthiaskrgr> vultraz_iOS: did you tell me to add the assert before or after the    controller_.get_part(part_index_);   line?
20170416 13:44:30< matthiaskrgr> I added it on both places now and now it asserts
20170416 13:44:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 13:45:00< matthiaskrgr> {
20170416 13:45:01< matthiaskrgr> 	assert(part_index_);
20170416 13:45:01< matthiaskrgr> 	current_part_ = controller_.get_part(part_index_);
20170416 13:45:07< matthiaskrgr> that assert  fails 
20170416 13:45:19< vultraz_iOS> the fuck
20170416 13:45:47< celticminstrel> What's the type of part_index_?
20170416 13:46:14< vultraz_iOS> int initialized to 0
20170416 13:46:23< celticminstrel> So that's why it asserts.
20170416 13:46:31< vultraz_iOS> update_current_part_ptr is called from the ctor so it will definitely assert
20170416 13:46:34< matthiaskrgr> hm
20170416 13:46:37< celticminstrel> assert(0) is an assertion failure.
20170416 13:46:39< vultraz_iOS> but why would it not assert *after*...
20170416 13:46:57< vultraz_iOS> oh
20170416 13:47:05< vultraz_iOS> matthiaskrgr: i asked you to assert current_part_ not part_index
20170416 13:47:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20170416 13:47:25< matthiaskrgr> ah
20170416 13:47:26< matthiaskrgr> er
20170416 13:47:37-!- stikonas_ is now known as stikonas
20170416 13:47:38< matthiaskrgr> well I don't remember what I asserted back then 
20170416 13:47:50< matthiaskrgr> so want me to re-assert anything?
20170416 13:48:13< vultraz_iOS> try current_part after setting again
20170416 13:48:56-!- mjs-de [~mjs-de@b9168ec5.cgn.dg-w.de] has quit [Remote host closed the connection]
20170416 13:49:01< matthiaskrgr> 	current_part_ = controller_.get_part(part_index_);
20170416 13:49:01< matthiaskrgr> 	assert(current_part);
20170416 13:49:04< matthiaskrgr> like this, right?
20170416 13:49:19< vultraz_iOS> current_part_
20170416 13:49:26< matthiaskrgr> ah yes
20170416 13:49:34< vultraz_iOS> but yes
20170416 13:52:57< matthiaskrgr> can't get the crash triggered right now, xD  
20170416 13:53:13< vultraz_iOS> oh come on :|
20170416 13:53:17< vultraz_iOS> ;_;
20170416 13:54:04< matthiaskrgr> I'll drop caches
20170416 13:57:51< matthiaskrgr> there we go !
20170416 13:58:08< matthiaskrgr> so
20170416 13:58:08< matthiaskrgr> 	current_part_ = controller_.get_part(part_index_);
20170416 13:58:09< matthiaskrgr> 	assert(current_part_);
20170416 13:58:12< matthiaskrgr> did not assert but just cras 
20170416 13:58:14< matthiaskrgr> h
20170416 13:58:21< vultraz_iOS> sigh
20170416 14:06:46< lipkab> matthiaskrgr, vultraz_iOS: stupid question. did you check whether part_index_ is actually a valid index? :)
20170416 14:07:31< vultraz_iOS> well, I do check that once it equals controller_.max_parts() it exits
20170416 14:07:40< celticminstrel> Why isn't the menu button using markup in its own label...
20170416 14:08:11< vultraz_iOS> so one would think that anything from 0 to n - 1 where n is max parts, would be valid
20170416 14:08:23< vultraz_iOS> celticminstrel: probably text_markup is not set in [text]
20170416 14:09:54< lipkab> vultraz_iOS: i'd say it's worth a try to print the index right before the crash
20170416 14:10:37< vultraz_iOS> matthiaskrgr: could you try that
20170416 14:11:00< lipkab> ...and the vector's size, too, of course
20170416 14:11:39< vultraz_iOS> which is controller_.max_parts() 
20170416 14:13:08< vultraz_iOS> matthiaskrgr: so, you'll want, in place of assert, std::cerr << "Current part: " << part_index_ << ", " max is " << controller_.max_parts()  << std::endl;
20170416 14:13:59-!- Kwandulin [~Kwandulin@p200300760F6D807D45D3EBFD0B470A65.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 14:14:34< matthiaskrgr> alright
20170416 14:16:43< matthiaskrgr> yeah :)
20170416 14:16:58< matthiaskrgr> out of bounds access
20170416 14:17:02< celticminstrel> Okay, now I have an uncaught GUI2 layout failure exception. :(
20170416 14:17:11< vultraz_iOS> output please
20170416 14:17:13< matthiaskrgr> https://pastebin.com/7eM8Jpyb  
20170416 14:17:23< vultraz_iOS> what the fuck o_O
20170416 14:17:23< matthiaskrgr> 1 2 3 4 5 7  lol  
20170416 14:17:41< vultraz_iOS> oh...
20170416 14:17:42< vultraz_iOS> hmm
20170416 14:19:16< lipkab> it seems obvious now
20170416 14:19:26< lipkab> matthiaskrgr's computer can't count to 6
20170416 14:19:30< irker159> wesnoth: Charles Dang wesnoth:master 409404cf6069 / src/gui/dialogs/story_viewer.cpp: Story Viewer: attempt to fix bug #25661 https://github.com/wesnoth/wesnoth/commit/409404cf6069dfc0eecc72e8b852aa6a892920da
20170416 14:19:41< vultraz_iOS> matthiaskrgr: try now
20170416 14:25:04< vultraz_iOS> good call on lipkab's part to check the indices 
20170416 14:25:23< matthiaskrgr> yeah :)
20170416 14:25:28< matthiaskrgr> vultraz_iOS: i think it's gone :)
20170416 14:25:35< matthiaskrgr> checked ~6 times now :P
20170416 14:25:54< matthiaskrgr> \O/
20170416 14:25:56< vultraz_iOS> it should good, good
20170416 14:26:08< vultraz_iOS> btw, what do you think of the fading?
20170416 14:26:45< matthiaskrgr> looks great ^^
20170416 14:26:52< vultraz_iOS> is the UB still there?
20170416 14:27:01< matthiaskrgr> yes
20170416 14:27:51< vultraz_iOS> fuck
20170416 14:28:02< matthiaskrgr> well
20170416 14:28:08< matthiaskrgr> let me re-double check again, just to be sure xD
20170416 14:29:16< vultraz_iOS> celticminstrel: what is the behavior with max and negative values in an unsigned variable?
20170416 14:29:34< matthiaskrgr> it's strange that it says    409404c-Modified   altough my HEAD == upstream/master
20170416 14:30:18< irker159> wesnoth: Celtic Minstrel wesnoth:master 65deb19bcc94 / data/gui/widget/addon_list.cfg: Addon List: Limit width of version column https://github.com/wesnoth/wesnoth/commit/65deb19bcc94d78ac8a606f64dc0229e7b5a776e
20170416 14:30:20< irker159> wesnoth: Celtic Minstrel wesnoth:master c294484cda83 / data/gui/window/mp_staging.cfg: MP Staging: New layout for resolutions < 1024x768 https://github.com/wesnoth/wesnoth/commit/c294484cda83d307423fe52b1cd755ab26ec0fe4
20170416 14:30:22< celticminstrel> vultraz_iOS: ^ Two problems I can see still. Chat should be wider than player list, and buttons should be at the right.
20170416 14:30:39< celticminstrel> And I'm not sure what you're asking.
20170416 14:31:03< vultraz_iOS> yeah, ill take a look at the low res thing... sometime
20170416 14:31:05< matthiaskrgr> vultraz_iOS: yeah, UB is still there
20170416 14:31:10< matthiaskrgr> ../src/gui/dialogs/story_viewer.cpp:445:58: runtime error: value -25.5 is outside the range of representable values of type 'const unsigned short'
20170416 14:32:17< irker159> wesnoth: Charles Dang wesnoth:master 5c0a043f7975 / src/gui/dialogs/story_viewer.cpp: Story Viewer: another attempt to fix UB https://github.com/wesnoth/wesnoth/commit/5c0a043f79752ac2ec4835e45f759fa1373730c6
20170416 14:32:21< vultraz_iOS> matthiaskrgr: ^
20170416 14:32:51< matthiaskrgr> building
20170416 14:33:08< vultraz_iOS> celticminstrel: you broke something
20170416 14:33:11< vultraz_iOS> can't even start wesnoth
20170416 14:33:23< celticminstrel> Eh?
20170416 14:33:38< matthiaskrgr> o_O
20170416 14:33:40< vultraz_iOS> oh wait
20170416 14:33:45< celticminstrel> It starts fine for me.
20170416 14:33:45< vultraz_iOS> git fucked up
20170416 14:33:48< vultraz_iOS> nevermind
20170416 14:34:02< matthiaskrgr> git gud 
20170416 14:34:03< matthiaskrgr> :>
20170416 14:34:19-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 14:34:53< zookeeper> someone had to be the first to make that joke here
20170416 14:35:24< matthiaskrgr> vultraz_iOS: it's fixed yay!
20170416 14:35:24< zookeeper> i admit i think i've had it in mind occasionally but never had the opportunity
20170416 14:35:30< matthiaskrgr> zookeeper: :D 
20170416 14:36:25< celticminstrel> vultraz_iOS: Which would you prefer for menu buttons - permit markup, or strip markup?
20170416 14:36:33< vultraz_iOS> permit
20170416 14:36:35< vultraz_iOS> ill fix it
20170416 14:36:38< vultraz_iOS> i broke it yesterday
20170416 14:36:44< vultraz_iOS> in dota right now
20170416 14:36:45< celticminstrel> Oh did you?
20170416 14:36:48< vultraz_iOS> yes
20170416 14:37:04< celticminstrel> Well, if it's just setting text_markup to true, I can commit it.
20170416 14:37:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 14:37:58< lipkab> vultraz_iOS: int would have been a better choice there
20170416 14:38:37< vultraz_iOS> why?
20170416 14:38:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 14:39:03< lipkab> now technically you could go out-of-range at the other end
20170416 14:39:22< irker159> wesnoth: Charles Dang wesnoth:master 9b326e21db9b / data/gui/widget/ (menu_button_default.cfg multimenu_button_default.cfg): Menu Button/Multimenu Button: re-enable text markup (fixup 1ea440fed) https://github.com/wesnoth/wesnoth/commit/9b326e21db9bcadebb3130f406a1e2830b3e484e
20170416 14:39:47< lipkab> although on a second thought it doesn't matter much
20170416 14:40:33< lipkab> that big values don't make any sense
20170416 14:40:40< lipkab> nevermind
20170416 14:42:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 14:44:48< celticminstrel> JyrkiVesterinen: I wonder if you'd be able to implement drag-and-drop support in GUI2 for the MP Staging dialog?
20170416 14:45:05< vultraz_iOS> he's busy
20170416 14:45:18< celticminstrel> I might be able to do it by referencing the GUI1 implementation, I suppose.
20170416 14:45:21< vultraz_iOS> i've already assigned him the impossible task of fixing End Credits
20170416 14:45:50< celticminstrel> Oh, the need for a "dynamic grid" type thing.
20170416 14:46:10-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 240 seconds]
20170416 14:46:15< vultraz_iOS> no
20170416 14:46:17< vultraz_iOS> no need for that
20170416 14:46:32< celticminstrel> Well, it's a way of solving it.
20170416 14:46:39< celticminstrel> Probably not the only way.
20170416 14:47:02< celticminstrel> I'm trying to decide what to do with MP Staging at 800x600.
20170416 14:47:10< vultraz_iOS> ignore it
20170416 14:47:14< celticminstrel> No.
20170416 14:47:20< vultraz_iOS> let's implement dynamic size scaling
20170416 14:47:27< celticminstrel> Eh?
20170416 14:47:29< vultraz_iOS> become DPI aware and fix all our problems at once
20170416 14:47:31-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170416 14:47:38< celticminstrel> I don't think that would fix all problems at once.
20170416 14:47:58< vultraz_iOS> RE resolution at least
20170416 14:48:15< celticminstrel> I don't see how it would.
20170416 14:48:28< vultraz_iOS> by not using the antiquated method of absolute pixel measurements
20170416 14:50:18< vultraz_iOS> you do realize there's no reason to support 800x600 anymore right?
20170416 14:50:23< vultraz_iOS> "oh but phones!"
20170416 14:50:30< vultraz_iOS> most phones have a higher resolution than that
20170416 14:50:33< vultraz_iOS> bc they're high-DPI
20170416 14:50:35< celticminstrel> I disagree.
20170416 14:50:37< vultraz_iOS> admittedly some might not
20170416 14:50:41< vultraz_iOS> like my cheap one
20170416 14:50:48< celticminstrel> I think there's no reason to ever drop support for 800x600.
20170416 14:50:50< vultraz_iOS> is probably 800x480 itself
20170416 14:51:12< celticminstrel> People play in windowed mode.
20170416 14:51:13< vultraz_iOS> let me finish my game and ill talk more
20170416 14:51:36< celticminstrel> Some people might want the game in a small window so they can have other stuff visible onscreen too.
20170416 14:52:00< vultraz_iOS> i personally would discourage that
20170416 14:52:09< celticminstrel> Don't discourage that.
20170416 14:52:55< JyrkiVesterinen> Also, while high-DPI phones do have higher pixel dimensions, they still need an UI designed for a small screen.
20170416 14:53:29< JyrkiVesterinen> 1920x1080 desktop UI would be unusable on a 1920x1080 mobile phone screen.
20170416 14:53:48< vultraz_iOS> of course
20170416 14:54:00< celticminstrel> So in fact it's probably better to treat it as if it's a smaller resolution.
20170416 14:54:01< vultraz_iOS> but we'll never be able to accommodate that with absolute pixel measurements 
20170416 14:54:07< vultraz_iOS> we need DPI awareness
20170416 14:54:47< vultraz_iOS> though tbh we can probably do some dynamic sizing right now
20170416 14:54:49< vultraz_iOS> with formulas
20170416 14:56:10< celticminstrel> Could probably just add a "dpi" variable to the formulas and let them do all the work.
20170416 14:57:06< vultraz_iOS> sure
20170416 14:57:10< vultraz_iOS> but A we need to fetch that data
20170416 14:57:13< vultraz_iOS> OS dependeltly
20170416 14:57:38< vultraz_iOS> and it needs to be applied to *any surface operation*
20170416 14:57:51< vultraz_iOS> most importantly, text drawing
20170416 14:59:03< matthiaskrgr>    Caught unspecified general exception. Terminating.
20170416 14:59:08< vultraz_iOS> oh ffs :(
20170416 14:59:10< matthiaskrgr> this sometimes happens when connecting to a server
20170416 14:59:13< vultraz_iOS> oh
20170416 14:59:13< celticminstrel> Well, maybe with OpenGL.
20170416 14:59:17< vultraz_iOS> ok not my code xD
20170416 14:59:28< vultraz_iOS> celticminstrel: then we need it ASAP
20170416 14:59:31< celticminstrel> I got that error too a little while ago.
20170416 15:01:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 15:02:24< vultraz_iOS> we should begin OGL work before the year is out
20170416 15:02:38< zookeeper> so what does this DPI awareness thing mean? that we'd for example have text drawn at a physical size, like 1/2cm tall instead of 12px tall? and all UI would basically be like that, physical sizes instead of pixels?
20170416 15:02:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 15:03:21< JyrkiVesterinen> Yes, more or less.
20170416 15:03:59< vultraz_iOS> yes
20170416 15:05:57< zookeeper> okay. so, sure that makes sense, but why is the lack of that supposedly such a problem currently? if, for example, the game renders to 1920x1080 as normal and the OS scales that up to fill a 4k screen then what's the problem with that?
20170416 15:06:21< zookeeper> because it's too small if you have a 4k mobile device or something?
20170416 15:07:06< JyrkiVesterinen> The problem is that OS upscaling is blurry.
20170416 15:07:58< zookeeper> can't the app control what sort of upscaling gets used?
20170416 15:08:44< vultraz_iOS> no
20170416 15:08:49< vultraz_iOS> only whether it happens or not
20170416 15:08:52< vultraz_iOS> (I think)
20170416 15:09:07< vultraz_iOS> if it's DPI aware then it can handle being DPI aware any way it likes
20170416 15:09:13< vultraz_iOS> we are not DPI aware
20170416 15:09:17< vultraz_iOS> we should be
20170416 15:09:52< zookeeper> D: what how is that even possible, it doesn't make any sense that it can't tell the OS whether to use smooth or linear upscaling
20170416 15:10:35< vultraz_iOS> shrug
20170416 15:10:41< vultraz_iOS> maybe there is a setting
20170416 15:11:01< vultraz_iOS> os-dependent, ofc
20170416 15:11:24< zookeeper> sounds like a rather important question to me
20170416 15:11:41< vultraz_iOS> window's upscaling is pretty nice actually
20170416 15:11:51< vultraz_iOS> not really noticeable after you see it awhile 
20170416 15:12:48-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 15:13:15< celticminstrel> Hmm... does use_tooltip_on_label_overflow=true not actually work?
20170416 15:13:18< zookeeper> linear upscaling would look okay with pixely art, bilinear scaling would look blurry... so i'd think how badly DPI awareness is needed greatly depends on that
20170416 15:13:19< vultraz_iOS> no idea
20170416 15:13:22< vultraz_iOS> never tested it
20170416 15:13:29< celticminstrel> It seems pango_text::is_truncated() returns false when it should be returning true.
20170416 15:13:32< zookeeper> anyway, would being DPI aware mean that on a 4k display the game would actually software-render at 4k and thus perform absolutely terribly bad?
20170416 15:13:43< vultraz_iOS> yes
20170416 15:14:00< celticminstrel> We should fix use_tooltip_on_label_overflow and use it in places.
20170416 15:14:43< zookeeper> vultraz_iOS, wonderful :> although i suppose the gamemap should render at 1/2 size or so and just be stretched to double size
20170416 15:14:53< irker159> wesnoth: Celtic Minstrel wesnoth:master d54c8ad40e5b / data/gui/window/mp_staging.cfg: MP Staging: Add tooltip to bizarre arrow buttons https://github.com/wesnoth/wesnoth/commit/d54c8ad40e5bf26c97a53db3570f5acd208f7e85
20170416 15:14:55< irker159> wesnoth: Celtic Minstrel wesnoth:master e5ff9f958480 / data/gui/widget/ (menu_button_default.cfg multimenu_button_default.cfg): (Multi)menu Buttons: Reduce default size at low resolutions https://github.com/wesnoth/wesnoth/commit/e5ff9f9584806f1eee9cfa3fc349fff7bda414f0
20170416 15:14:57< irker159> wesnoth: Celtic Minstrel wesnoth:master 3af50b919cff / data/gui/window/mp_staging.cfg: MP Staging: Request tooltip on label overflow for leader/faction name https://github.com/wesnoth/wesnoth/commit/3af50b919cffa3a6b167c8aee8e47af0c1f480bb
20170416 15:15:06< vultraz_iOS> zookeeper: most games make it so that a specific amount of gamemap is visible at once
20170416 15:15:09< vultraz_iOS> regardless of resolution
20170416 15:15:22< vultraz_iOS> once again we use A B S O L U T E P I X E L M E A S U R E M E N T S
20170416 15:15:23< zookeeper> so at least the gamemap rendering maybe wouldn't be any more costly than at normal resolutions
20170416 15:16:20< vultraz_iOS> we should change it
20170416 15:16:22< vultraz_iOS> to fixed view
20170416 15:16:41< vultraz_iOS> though that might involve scaling
20170416 15:16:46< vultraz_iOS> so maybe not
20170416 15:18:08< irker159> wesnoth: Celtic Minstrel wesnoth:master bb535fe452fd / data/gui/window/mp_staging.cfg: MP Staging: A few more tooltips https://github.com/wesnoth/wesnoth/commit/bb535fe452fd20b06661ebc511511b972a7fb3b2
20170416 15:18:46< celticminstrel> vultraz_iOS: Feel free to reformat everything now.
20170416 15:19:15< celticminstrel> And maybe force a minimum width on some menu buttons, such as the resolution one.
20170416 15:20:50< vultraz_iOS> i think you should have used a formulas
20170416 15:20:52< vultraz_iOS> formula
20170416 15:20:56< vultraz_iOS> instead of additional resolutions
20170416 15:21:09< celticminstrel> I dunno.
20170416 15:21:16< celticminstrel> It's only default width.
20170416 15:21:34< vultraz_iOS> i see
20170416 15:21:38< celticminstrel> Logically, the prefs one should notice that the default is too small and automatically expand it.
20170416 15:21:47< celticminstrel> But for some reason it doesn't.
20170416 15:22:24< vultraz_iOS> ...what?
20170416 15:22:31< vultraz_iOS> you mean for resolution?
20170416 15:22:35< vultraz_iOS> too small for what?
20170416 15:23:53< celticminstrel> Too small for its content.
20170416 15:24:10< celticminstrel> On 800x600, the resolution selector is now too small to show 800x600.
20170416 15:24:16< celticminstrel> Even though there's plenty of space.
20170416 15:24:29< celticminstrel> Hmm...
20170416 15:25:35< vultraz_iOS> the button doesn't grow
20170416 15:25:44< vultraz_iOS> ie, it's not set horizontal_grow = true
20170416 15:26:03< celticminstrel> I think maybe the problem is that menu_button doesn't override calculate_best_size().
20170416 15:26:08< vultraz_iOS> (speaking of which, why were you so happy with the commit to change "true"/"false" to true/false)
20170416 15:26:34< celticminstrel> I didn't like the quoted booleans.
20170416 15:28:03< zookeeper> vultraz_iOS, it'll involve scaling anyway, pixel coordinates are used everywhere so you still have to internally render the gamemap based on pixels, and just upscale the result.
20170416 15:28:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 15:29:28< celticminstrel> Not sure how to implement menu_button::calculate_best_size, though...
20170416 15:29:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 15:29:55< celticminstrel> I mean, obviously it should be something along the lines of "the longest option + 25", but how to get that...
20170416 15:37:42-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 15:40:01-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 15:45:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 16:08:05-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 252 seconds]
20170416 16:10:13-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 16:22:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170416 16:23:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170416 16:30:00-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170416 16:30:21-!- Kwandulin [~Kwandulin@p200300760F6D807D45D3EBFD0B470A65.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170416 16:46:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170416 16:53:27-!- Kwandulin [~Kwandulin@p200300760F6D807D74FA14ED681557C8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170416 16:53:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 17:14:47-!- gfgtdf [~chatzilla@x4e363696.dyn.telefonica.de] has joined #wesnoth-dev
20170416 17:15:06< gfgtdf> matthiaskrgr: did you see my message eariler ?
20170416 17:16:19-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170416 17:34:59-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 252 seconds]
20170416 17:38:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 18:01:20< celticminstrel> Urgh. Whyyyy is Travis not announcing!?
20170416 18:12:54< vultraz_iOS> must be off for easter
20170416 18:13:14< celticminstrel> It's been like that for awhile now.
20170416 18:17:54< vultraz_iOS> indeed
20170416 18:17:56< vultraz_iOS> i did notice
20170416 18:18:21-!- irker159 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170416 18:35:54-!- trewe [~trewe@2001:8a0:d133:8d01:fdb2:fc98:1280:857b] has joined #wesnoth-dev
20170416 18:50:22-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20170416 18:51:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170416 18:56:59< vultraz_iOS> looks like one of my fixes earlier broke fading..
20170416 18:57:54< vultraz_iOS> weird..
20170416 18:58:00< vultraz_iOS> looks like unsigned short new_alpha = utils::clamp<short>(fade_step_ * 25.5, 0, ALPHA_OPAQUE); breaks
20170416 18:58:02< celticminstrel> Uh-oh?
20170416 18:58:04< vultraz_iOS> unsigned short new_alpha = utils::clamp<unsigned short>(fade_step_ * 25.5, 0, ALPHA_OPAQUE);
20170416 18:58:06< vultraz_iOS> does not break
20170416 18:58:07< vultraz_iOS> the hell?
20170416 18:58:20< celticminstrel> Um.
20170416 18:58:28< celticminstrel> ALPHA_OPAQUE is 255, right?
20170416 18:58:41< vultraz_iOS> yes
20170416 18:58:50< celticminstrel> Okay so...
20170416 18:58:50< vultraz_iOS> only difference is the 'unsigned' 
20170416 18:59:05< celticminstrel> If it's <unsigned short>, the clamp is superfluous.
20170416 18:59:19< celticminstrel> Because the value has already been converted from double to unsigned short.
20170416 18:59:27< celticminstrel> And thus cannot be less than zero.
20170416 18:59:38< celticminstrel> But I'm guessing that conversion was the undefined behaviour?
20170416 18:59:39< vultraz_iOS> if it's NOT unsigned short then matthiaskrgr gets UB
20170416 19:00:01< celticminstrel> Alright, so why is the fade_step set to -1?
20170416 19:00:18< vultraz_iOS> if(!fading_in_ && fade_step_ < 0) {
20170416 19:00:23< vultraz_iOS> to enable complete fade out
20170416 19:00:36< celticminstrel> Uh. What?
20170416 19:01:08< vultraz_iOS> sigh
20170416 19:01:10< vultraz_iOS> look at the code
20170416 19:02:03< celticminstrel> Not sure why you assume that would help..
20170416 19:02:09< celticminstrel> Anyway, I just did, and still don't get it.
20170416 19:02:39< vultraz_iOS> the check for exiting the draw cycle comes before the draw
20170416 19:02:54< celticminstrel> Hmm...
20170416 19:03:02< celticminstrel> So you pass false to fade out, I guess...
20170416 19:03:04< vultraz_iOS> so, if i want to be able to fade fully out, i need 0 to pass
20170416 19:04:00< celticminstrel> What was the log message for the UB again?
20170416 19:04:29< vultraz_iOS> -25.5 not allowed with unsigned
20170416 19:04:53< celticminstrel> That's not the exact wording, is it?
20170416 19:05:09< vultraz_iOS> no
20170416 19:06:52< celticminstrel> Is it possible for fade_step_ to be -1 when fading in?
20170416 19:07:27< celticminstrel> ...I guess it must be somehow, because otherwise where would -25.5 come from...
20170416 19:08:36< vultraz_iOS> what i want to know is why the hell the absence of <unsigned in the clamp call breaks shit
20170416 19:09:18< celticminstrel> Well, maybe it depends on the output of static_cast<unsigned short>(-25.5) vs static_cast<short>(-25.5)
20170416 19:09:56 * vultraz_iOS curses
20170416 19:11:45< vultraz_iOS> why the hell does assigning a signed value to an unsigned variable round to 0
20170416 19:11:48< vultraz_iOS> er
20170416 19:11:51< vultraz_iOS> NOT round to0
20170416 19:12:17< celticminstrel> So casting to unsigned gives 0. Casting to unsigned gives -25.
20170416 19:12:21 * celticminstrel just tested.
20170416 19:12:31< vultraz_iOS> what?
20170416 19:12:35< vultraz_iOS> which one is it
20170416 19:12:51< celticminstrel> It should be obvious which un- is erroneous.
20170416 19:12:54< celticminstrel> Sorry.
20170416 19:12:57< celticminstrel> So...
20170416 19:13:14< vultraz_iOS> BUT THE MIN VALUE IS 0!
20170416 19:13:25< celticminstrel> If it's signed short, you get -25, and that clamps it it to 0. If it's unsigned short, you get 0, and that also clamps it to 0. Hmm...
20170416 19:13:42< celticminstrel> Oh but in the latter case it's UB, so maybe getting 0 is just the way my implementation handle it.
20170416 19:13:55< celticminstrel> So maybe on matthiaskrgr's machine you instead get MAX_SHORT.
20170416 19:14:01< celticminstrel> For example.
20170416 19:14:08< celticminstrel> Or on your machine? I dunno.
20170416 19:14:10 * vultraz_iOS throws up hands
20170416 19:14:22< celticminstrel> Anyway.
20170416 19:14:24< vultraz_iOS> on my machine it's fading in and then suddenly vanishing and the loop keeps firing
20170416 19:14:41< celticminstrel> If it's signed short, then it's next cast to unsigned short, and then you get, uh...
20170416 19:15:01< celticminstrel> MAX_SHORT-25 which would be... 32743.
20170416 19:15:14< celticminstrel> So the clamp will pick the upper bound instead of 0.
20170416 19:15:29< celticminstrel> Oh sorry, it would be 32762.
20170416 19:15:33< celticminstrel> Not that it makes a difference.
20170416 19:15:58< celticminstrel> Anyway, it should be unsigned in both places. The real question is. why is the step -1 at that point?
20170416 19:16:32< vultraz_iOS> it can't be unsigned in both places
20170416 19:16:35< celticminstrel> ^is,
20170416 19:16:41< vultraz_iOS> and it shouldn't be -1 at that point
20170416 19:16:48< vultraz_iOS> this happens on start
20170416 19:16:54< vultraz_iOS> value is initialized to 0
20170416 19:17:10< vultraz_iOS> value is set to 0
20170416 19:17:11< vultraz_iOS> fade_step_ = fade_in ? 0 : 10;
20170416 19:17:25< celticminstrel> Oh, wait, maybe I'm wrong.
20170416 19:17:32< celticminstrel> ...
20170416 19:17:52< vultraz_iOS> it should never be -1 so i dunno how he even got the UB in the first place or why in a million hells it loops back to transparent 
20170416 19:17:53< celticminstrel> So first it's cast to short to give -25... then clamped to 0... so that should be fine, right?
20170416 19:18:22< vultraz_iOS> a thousand curses upon signedness
20170416 19:23:09< celticminstrel> fading_in_ seems to never become false ATM.
20170416 19:23:10< vultraz_iOS> fade step is: 0, alpha is: 0
20170416 19:23:10< vultraz_iOS> fade step is: 1, alpha is: 25
20170416 19:23:10< vultraz_iOS> fade step is: 2, alpha is: 51
20170416 19:23:10< vultraz_iOS> fade step is: 3, alpha is: 76
20170416 19:23:10< vultraz_iOS> fade step is: 4, alpha is: 102
20170416 19:23:10< vultraz_iOS> fade step is: 5, alpha is: 127
20170416 19:23:10< vultraz_iOS> fade step is: 6, alpha is: 153
20170416 19:23:11< vultraz_iOS> fade step is: 7, alpha is: 178
20170416 19:23:11< vultraz_iOS> fade step is: 8, alpha is: 204
20170416 19:23:12< vultraz_iOS> fade step is: 9, alpha is: 229
20170416 19:23:12< vultraz_iOS> fade step is: 10, alpha is: 255
20170416 19:23:13< vultraz_iOS> fade step is: -1, alpha is: 0
20170416 19:23:20< vultraz_iOS> but why is this firing!
20170416 19:23:34< celticminstrel> Because fading_in_ is not false.
20170416 19:23:50< celticminstrel> if(!fading_in_ && fade_step_ < 0)
20170416 19:24:02< celticminstrel> "if fading_in is false and fade_step is less than zero"
20170416 19:24:16< vultraz_iOS> irrelevant since halt_fade_draw sets next_draw to 0 
20170416 19:24:33< celticminstrel> Sorry, what?
20170416 19:24:46< celticminstrel> fading_in = false means fading out, right?
20170416 19:24:47< vultraz_iOS> wait
20170416 19:24:53< vultraz_iOS> wait a second..
20170416 19:25:34< vultraz_iOS> ok actually..
20170416 19:25:38< celticminstrel> I have fading_in = maybe and the fade_step counting down from 10 here.
20170416 19:25:39< vultraz_iOS> restoring that unsigned causes a crash?
20170416 19:26:18< celticminstrel> (BTW, that's an even worse abuse of tribool than the animations one; it does at least somewhat make sense in the animations, but here...)
20170416 19:26:39< vultraz_iOS> abuse?
20170416 19:26:43< vultraz_iOS> i needed an intermediate state
20170416 19:26:51< celticminstrel> Yes, abuse.
20170416 19:26:58< celticminstrel> A tribool is "yes, no, maybe"
20170416 19:27:07< celticminstrel> This is "fading in, fading out, not fading".
20170416 19:27:25< celticminstrel> Not "fading in, not fading in, maybe fading in"
20170416 19:27:27< vultraz_iOS> I don't understand how this works..
20170416 19:28:08< vultraz_iOS> it doesn't make sense that it doesn't
20170416 19:28:13< vultraz_iOS> we know fading_in is true
20170416 19:28:17< vultraz_iOS> since it's happening
20170416 19:28:20< vultraz_iOS> we reach 10
20170416 19:28:22< vultraz_iOS> full alpha
20170416 19:28:26< vultraz_iOS> it bumps alpha to 11
20170416 19:28:31< celticminstrel> But fading_in is never false.
20170416 19:28:32< vultraz_iOS> so if(fading_in_ && fade_step_ > 10) { should catch!
20170416 19:28:41< celticminstrel> No, fade_step is set to -1.
20170416 19:28:54< celticminstrel> By halt_fade_draw().
20170416 19:29:03< celticminstrel> Maybe if you make halt_fade_draw() not touch the fade step?
20170416 19:29:06 * celticminstrel tries that.
20170416 19:29:21< vultraz_iOS> it touches it because otherwise shit breaks
20170416 19:29:28< vultraz_iOS> and you get a fade in, then fade out, then vanish
20170416 19:29:52< vultraz_iOS> but the thing is, halt_fade_draw also sets next_draw to 0
20170416 19:29:57< vultraz_iOS> so this should *never run*
20170416 19:30:02< vultraz_iOS> after fading happens
20170416 19:30:05< vultraz_iOS> because of if(SDL_GetTicks() < next_draw_) {
20170416 19:30:28< vultraz_iOS> perhaps the granularity is too small...
20170416 19:30:44< vultraz_iOS> oh, right
20170416 19:30:50< vultraz_iOS> er
20170416 19:30:51< vultraz_iOS> no
20170416 19:30:58< vultraz_iOS> ticks should never be less than 0
20170416 19:30:59< vultraz_iOS> the hell
20170416 19:31:17< celticminstrel> Uh, I don't know what you're talking about, because it works if fade_step is left at 1..
20170416 19:31:20< celticminstrel> ^11
20170416 19:31:43< vultraz_iOS> ok, yes
20170416 19:31:44< vultraz_iOS> but..
20170416 19:31:57< vultraz_iOS> the function keeps setting alpha
20170416 19:32:07< vultraz_iOS> put a cerr call after getting new_alpha and watch console
20170416 19:32:09< vultraz_iOS> it spams
20170416 19:32:10< vultraz_iOS> *why*
20170416 19:33:13< vultraz_iOS> ah wait
20170416 19:33:20< vultraz_iOS> i need to add a not_fadng check
20170416 19:33:24< vultraz_iOS> fading*
20170416 19:34:31< vultraz_iOS> even if fade_step is set to -1
20170416 19:34:44< vultraz_iOS> but how does SDL_GetTicks < 0 pass :\
20170416 19:34:46< celticminstrel> It appears that it gets past the <0 check even when next_draw_ is 0, somehow.
20170416 19:35:11< vultraz_iOS> yes
20170416 19:35:11< vultraz_iOS> why
20170416 19:35:59< vultraz_iOS> maybe set_next_draw is somehow getting called..
20170416 19:36:09< vultraz_iOS> I think i need to refactor this
20170416 19:36:21< vultraz_iOS> celticminstrel: how would you suggest doing away with the tribool if its so offensive
20170416 19:37:45< vultraz_iOS> (i was considering using RAII)
20170416 19:38:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 19:39:07< celticminstrel> There is an SDL_TICKS_PASSED macro, but I'm pretty sure your test is exactly equivalent to the negation of it.
20170416 19:39:16< celticminstrel> What were you considering RAII for?
20170416 19:39:23< celticminstrel> For the fade state, I'd use an enum.
20170416 19:39:58< celticminstrel> SDL_TICKS_PASSED is "next_draw - ticks <= 0"
20170416 19:40:10< celticminstrel> The negation of that is "next_draw - ticks > 0
20170416 19:40:31< celticminstrel> Multiply by -1: "ticks - next_draw < 0"
20170416 19:40:44< celticminstrel> Add next_draw: "ticks < next_draw"
20170416 19:40:49< celticminstrel> So yeah. Exactly equivalent.
20170416 19:41:21< celticminstrel> Hmm...
20170416 19:41:32< celticminstrel> That is of course assuming everything is a signed value, though.
20170416 19:41:49< vultraz_iOS> RAII for reset
20170416 19:41:57< celticminstrel> Huh?
20170416 19:42:11< vultraz_iOS> was considering a struct and a unique ptr
20170416 19:42:34< celticminstrel> Since ticks is unsigned, "ticks < 0" should be always false...
20170416 19:42:37< celticminstrel> Ah...
20170416 19:42:45< celticminstrel> That's it.
20170416 19:42:48< vultraz_iOS> what?
20170416 19:42:58< celticminstrel> "SDL_GetTicks() < 0" is always false.
20170416 19:43:04< vultraz_iOS> what?
20170416 19:43:22< celticminstrel> So when next_draw_ is 0, "SDL_GetTicks() < next_draw_" is always false, so the return is never reached.
20170416 19:43:35< vultraz_iOS> but why is it 0
20170416 19:43:36< vultraz_iOS> er
20170416 19:43:37< vultraz_iOS> false
20170416 19:43:45< celticminstrel> Because SDL_GetTicks() is unsigned.
20170416 19:43:52< celticminstrel> It can never be less than 0.
20170416 19:44:08< celticminstrel> Change to (next_draw_ && SDL_GetTicks() < next_draw_)?
20170416 19:44:28< vultraz_iOS> I see
20170416 19:44:38< vultraz_iOS> I'll do some refactoring
20170416 19:45:23< vultraz_iOS> Thanks tho
20170416 20:11:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170416 20:13:38-!- Kwandulin [~Kwandulin@p200300760F6D807D74FA14ED681557C8.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170416 20:17:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170416 20:36:38-!- irker647 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170416 20:36:38< irker647> wesnoth: gfgtdf wesnoth:master ddba0f84a211 / src/gui/dialogs/multiplayer/mp_join_game.cpp: add a errormessage https://github.com/wesnoth/wesnoth/commit/ddba0f84a2110a2625c0b271eb44eb2353e5a83b
20170416 20:47:26< gfgtdf> is the somehere a page the tellms em the ports of the mp servers ?
20170416 20:48:44< vultraz_iOS> i think so but i can't remember where
20170416 20:48:47< vultraz_iOS> ask loonycyborg 
20170416 20:49:28-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170416 20:49:29-!- trewe [~trewe@2001:8a0:d133:8d01:fdb2:fc98:1280:857b] has quit [Quit: quit]
20170416 20:50:34< gfgtdf> loonycyborg: ^
20170416 20:51:21< gfgtdf> nvm i somehow forung out the correct port by trying
20170416 20:52:28< gfgtdf> found*
20170416 20:54:46< gfgtdf> when i try to end an mp game i have to check 2 checkboxes "are you sure you want to quit" and "are you sure you want to log out"
20170416 20:54:53< gfgtdf> is this a known bug ?
20170416 20:55:11< celticminstrel> Yeah
20170416 21:00:57< gfgtdf> i wonder why we'd need the 'do you really want to log out' mesage in the firs tplace? I mean it's not like any data would be lost when leaving the lobby.
20170416 21:02:25< celticminstrel> Search filter. Chat log.
20170416 21:03:28< gfgtdf> serach filter is preserved in perferences (at least it was in 1.12)
20170416 21:03:58< gfgtdf> also i have actually never seens an intersting chat on the mp server 
20170416 21:04:15< gfgtdf> (also you can see the mp chat in wesnoth irclogs server)
20170416 21:05:23< celticminstrel> Just because you haven't seen it doesn't mean it doesn't exist.
20170416 21:05:35< celticminstrel> And viewing it on a website is much less convenient.
20170416 21:08:23-!- TC02 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20170416 21:11:54-!- JyrkiVesterinen [~JyrkiVest@87-100-173-27.bb.dnainternet.fi] has quit [Quit: .]
20170416 21:13:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170416 21:16:07-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 21:31:13< loonycyborg> gfgtdf: iirc it follows centain scheme, master one is first number and release branches are the following numbers
20170416 21:31:37< loonycyborg> and it's set up by the server admin, namely Soliton
20170416 21:31:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20170416 21:40:29-!- gfgtdf [~chatzilla@x4e363696.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170416 21:41:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 22:08:04-!- atarocch [~atarocch@37.176.201.13] has quit [Remote host closed the connection]
20170416 22:10:40< vultraz_iOS> celticminstrel: next_draw_ && SDL_GetTicks() < next_draw_ doesn't work
20170416 22:11:32< celticminstrel> Meaning...?
20170416 22:11:53< vultraz_iOS> still fired
20170416 22:12:40< celticminstrel> Hmm.
20170416 22:12:42< vultraz_iOS> (why the hell does Pageant keep quitting...)
20170416 22:13:07< irker647> wesnoth: Charles Dang wesnoth:master 93f5b0c8b221 / src/gui/dialogs/ (story_viewer.cpp story_viewer.hpp): Story Viewer: fixed draw callback firing wayyy more than it should https://github.com/wesnoth/wesnoth/commit/93f5b0c8b22190a95065b1d920acf9366ea95b78
20170416 22:14:56-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 240 seconds]
20170416 22:15:19< vultraz_iOS> ^ no longer "abusing" tribool
20170416 22:15:28< celticminstrel> But you say that doesn't work?
20170416 22:15:50< vultraz_iOS> added a return if NOT_FADING
20170416 22:16:46< vultraz_iOS> I should probably move all this fade handling to a helper class so it can be utilized elsewhere
20170416 22:17:26< vultraz_iOS> i already now have two implementations...
20170416 22:17:28< vultraz_iOS> here and Outro
20170416 22:41:37-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170416 23:15:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20170416 23:21:46-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170416 23:31:15< irker647> wesnoth: Charles Dang wesnoth:master 89c4d10f5950 / src/gui/dialogs/ (statistics_dialog.cpp unit_create.cpp): Set restore flag on some windows (bugs # 25662 abd #25664) https://github.com/wesnoth/wesnoth/commit/89c4d10f5950f414b72cacdf2d4b2d1f60950fc5
20170416 23:32:11< vultraz_iOS> celticminstrel: https://gna.org/bugs/index.php?25663
20170416 23:32:21< vultraz_iOS> more animate_unit breakage
20170416 23:43:03< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help fab79d86de23 / / (4 files in 2 dirs): Help Browser: Actually show the correct topics with the correct icons https://github.com/wesnoth/wesnoth/commit/fab79d86de23d8afa88bfd9589bc4c9ca8593950
20170416 23:43:05< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 0702e004e8d2 / src/ (4 files in 2 dirs): Help Viewer: Show topics with generated text https://github.com/wesnoth/wesnoth/commit/0702e004e8d2a9b86fdfb990200b0f183faacdfd
20170416 23:43:07< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 5a52816873f0 / src/help/ (help_impl.cpp help_impl.hpp): Help: That parameter isn't really needed https://github.com/wesnoth/wesnoth/commit/5a52816873f03bdf05f5536a5a70b7581441995c
20170416 23:43:09< irker647> wesnoth: Charles Dang wesnoth:gui2_help 918f1e909356 / data/gui/window/help_browser.cfg: Help Browser: improved layout stability and added next/back buttons (non-functio https://github.com/wesnoth/wesnoth/commit/918f1e909356c7b4555ec04d70039a4f6455e7df
20170416 23:43:12< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help cf8762cbca2d / src/ (5 files in 2 dirs): Help Viewer: Parse help markup to Pango markup... mostly. https://github.com/wesnoth/wesnoth/commit/cf8762cbca2d336ad8aead4e76ee0f1f236a2c13
20170416 23:43:14< irker647> wesnoth: Charles Dang wesnoth:gui2_help 3719367346d2 / / (3 files in 2 dirs): Help Browser: implemented viewing of sub-sections/topics https://github.com/wesnoth/wesnoth/commit/3719367346d2ec2b88e0813f20e94a35d0952e8f
20170416 23:43:17< irker647> wesnoth: Charles Dang wesnoth:gui2_help d5b74a380ad9 / src/ (gui/dialogs/title_screen.cpp help/help.cpp): Moved new help entry point to a common location https://github.com/wesnoth/wesnoth/commit/d5b74a380ad90731ff8583dd98b9dc061278e16a
20170416 23:43:20< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help a8edca2d54d3 / src/gui/dialogs/ (help_browser.cpp help_browser.hpp): Help Browser: Implement history https://github.com/wesnoth/wesnoth/commit/a8edca2d54d319ddbcefea116f1c785850a680c8
20170416 23:43:22< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 25f45f1671e0 / src/help/help_text_area.cpp: Fix GUI1 help topics not showing https://github.com/wesnoth/wesnoth/commit/25f45f1671e0b3f6be9d52d3806d7ab8d22d1552
20170416 23:43:24< irker647> wesnoth: Charles Dang wesnoth:gui2_help f28794f06a7b / / (3 files in 3 dirs): Help Browser: properly implement toggling by clicking the book icons https://github.com/wesnoth/wesnoth/commit/f28794f06a7b921cb0bbc5081c9f85a1b3e5e6c1
20170416 23:43:27< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 696a8b6e7303 / src/gui/dialogs/help_browser.cpp: Help Browser: Fix back button being visible when dialog opens https://github.com/wesnoth/wesnoth/commit/696a8b6e730379242ea004d59b31a38367b95e6e
20170416 23:43:29< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 7a78f4b517b3 / data/gui/window/help_browser.cfg src/gui/dialogs/help_browser.cpp: Help Browser: Show topic title https://github.com/wesnoth/wesnoth/commit/7a78f4b517b334e91dfff7921afec15633d3f6a5
20170416 23:43:31< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 61c2d9743d66 / src/gui/dialogs/help_browser.cpp: Help Browser: Don't double-list a section's root topic https://github.com/wesnoth/wesnoth/commit/61c2d9743d669390041c908eba7e06336541f423
20170416 23:43:33< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help ece130102c03 / src/gui/widgets/tree_view_node.cpp: Tree View: Allow find_widget to recurse into the nodes https://github.com/wesnoth/wesnoth/commit/ece130102c036a749af408df41c2bb06826a0932
20170416 23:43:35< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help bfb501569bbe / src/gui/widgets/ (tree_view_node.cpp tree_view_node.hpp): Tree View Node: Add functionality to auto-expand parents when selecting a node https://github.com/wesnoth/wesnoth/commit/bfb501569bbe0dac48c2d226fa80dc57e6e21786
20170416 23:43:37< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help 31f32dc7059d / src/ (gui/dialogs/help_browser.cpp gui/dialogs/help_browser.hpp help/help.cpp): Help Browser: Support arbitrary initial topic https://github.com/wesnoth/wesnoth/commit/31f32dc7059d73b4fb4da79e6894c9ef82d4cc8b
20170416 23:43:39< irker647> wesnoth: Celtic Minstrel wesnoth:gui2_help d08364879955 / src/gui/widgets/tree_view_node.cpp: Tree View Node: Minor fixup to expand parents option https://github.com/wesnoth/wesnoth/commit/d0836487995579e17433e414e8ed5ea2cc3d4fbe
20170416 23:43:41< irker647> wesnoth: Charles Dang wesnoth:gui2_help 99d79b758140 / data/gui/window/help_browser.cfg: Help Browser: fixup topic title layout https://github.com/wesnoth/wesnoth/commit/99d79b758140583e7430a06d6c563a91133d467e
20170416 23:43:44< irker647> wesnoth: Charles Dang wesnoth:gui2_help e01697d94ee5 / data/gui/window/help_browser.cfg: Help Browser: removed help topic padding https://github.com/wesnoth/wesnoth/commit/e01697d94ee509d59fd12bf88105930a7d646d18
20170416 23:43:48< vultraz_iOS> nothing new, just a rebase
20170416 23:44:34< vultraz_iOS> celticminstrel: actually, we should probably just merge it to master..
20170416 23:44:41< vultraz_iOS> obv not enable the new dialog
20170416 23:44:44< vultraz_iOS> but have the code in
20170416 23:46:28< celticminstrel> I don't see any point merging just for that.
20170416 23:54:07< vultraz_iOS> well, it's about as complete as we'll get it for now
20170416 23:54:29< celticminstrel> So?
20170416 23:54:49< celticminstrel> There's no reason to merge something incomplete.
--- Log closed Mon Apr 17 00:00:16 2017