--- Log opened Mon Apr 17 00:00:16 2017
20170417 00:00:51< irker647> wesnoth: Charles Dang wesnoth:master 0f585a58075e / data/gui/window/wml_message.cfg: GUI2/WML Message: gave grow priority to text over options https://github.com/wesnoth/wesnoth/commit/0f585a58075e7c96158c2b6ce643dbde74430cb1
20170417 00:02:35< vultraz_iOS> ya know i think we can make the floating textbox GUI2
20170417 00:02:39< vultraz_iOS> using a modeless dialog
20170417 00:03:02< celticminstrel> Nope, tried it.
20170417 00:03:20< vultraz_iOS> IIRC you tried a no-dialog option?
20170417 00:03:28< celticminstrel> That too.
20170417 00:03:39< vultraz_iOS> hm
20170417 00:03:48< vultraz_iOS> im tempted to try myself anyway
20170417 00:12:43-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170417 00:14:52< celticminstrel> The gist of it is: modeless dialog is probably the way to go, but a modeless dialog cannot function over the in-game GUI because it doesn't receive events.
20170417 00:15:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170417 00:15:23< vultraz_iOS> what doesn't?
20170417 00:15:25< vultraz_iOS> the dialog?
20170417 00:15:27< vultraz_iOS> or the game?
20170417 00:15:44< celticminstrel> There's also the potential issue with your window stack when there's a possibility to have two modeless windows open at once.
20170417 00:15:52< celticminstrel> Uh, I don't remember. Might've been either, or even both.
20170417 00:16:11< celticminstrel> IIRC the only thing I could do while the textbox was open was scroll.
20170417 00:16:30< celticminstrel> That includes the inability to close the textbox.
20170417 00:16:53< vultraz_iOS> ah, hmm
20170417 00:20:23< vultraz_iOS> yes, i see why that would happen
20170417 00:24:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170417 00:29:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has joined #wesnoth-dev
20170417 00:32:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:39d0:ec45:5052:5388] has quit [Remote host closed the connection]
20170417 01:34:39< celticminstrel> I thought you fixed the "image doesn't fit on canvas" in the storyscreen, vultraz_iOS?
20170417 01:36:27< celticminstrel> Also, why does {../maps/thing.map} not work? :(
20170417 01:36:40< celticminstrel> I thought gfgtdf did something about allowing ../ in paths.
20170417 02:03:35< celticminstrel> (Updating my campaign to 1.13. Got that error on the very first storyscreen.)
20170417 02:08:02< celticminstrel> wmllint changed viewing_side to side in [store_reachable_locations], but it looks like that's not right?
20170417 02:22:06< celticminstrel> Okay, so I started the campaign and now clicks don't work at all.
20170417 02:25:33< celticminstrel> In other words, the game is completely broken right now.
20170417 02:25:36< celticminstrel> Fun!
20170417 02:25:49< celticminstrel> Unless of course the last commit or two fixed it, but that's unlikely...
20170417 02:25:54 * celticminstrel will try anyway, though.
20170417 02:34:01< celticminstrel> It's triggered by the storyscreen bug.
20170417 02:34:23< celticminstrel> After you see that error once, the game totally breaks and you can't do anything once you've started a scenario.
20170417 02:53:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170417 02:57:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170417 02:59:26-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170417 03:00:56-!- irker647 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170417 03:07:26< celticminstrel> Huh. Is vision supposed to be cleared through tunnels?
20170417 03:07:39< celticminstrel> Uh, I mean shroud.
20170417 03:07:49< celticminstrel> Is shroud supposed to be cleared through tunnels?
20170417 03:08:03< celticminstrel> Shroud and also fog.
20170417 03:12:18< celticminstrel> Getting two AI errors too... one about invalid [recruitment] aspect and one about invalid "action=remove" in [modify_ai]...
20170417 03:20:12< celticminstrel> Looks like the latter was an error in my WML all along. Fixing the former.
20170417 03:20:57< celticminstrel> I was sure there was code to handle [recruitment] as a special-case synonym for [recruitment_instructions], but somehow it disappeared?
20170417 03:41:22-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170417 03:42:20-!- irker913 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170417 03:42:20< irker913> wesnoth: Celtic Minstrel wesnoth:master 2b58109133f3 / src/scripting/lua_map_location_ops.cpp: Fix wesnoth.map_location.get_relative_dir (GNA25657) https://github.com/wesnoth/wesnoth/commit/2b58109133f35701ce8f3a0dd4f9a31ec8cac0a9
20170417 03:42:20< irker913> wesnoth: Celtic Minstrel wesnoth:master 77184d4af0ce / src/ai/configuration.cpp: AI: Fix old recruitment aspect not working https://github.com/wesnoth/wesnoth/commit/77184d4af0cef776af93cc91d8e73626c76c36e2
20170417 03:49:35-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170417 03:53:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 258 seconds]
20170417 04:52:47-!- JyrkiVesterinen [~jyrki@87-100-206-117.bb.dnainternet.fi] has joined #wesnoth-dev
20170417 05:00:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20170417 05:08:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170417 05:08:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170417 05:11:05-!- JyrkiVesterinen [~jyrki@87-100-206-117.bb.dnainternet.fi] has quit [Quit: .]
20170417 05:19:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170417 05:39:58-!- Guest9573 [~tinkyholl@78.38.114.213] has joined #wesnoth-dev
20170417 05:43:47-!- Guest9573 [~tinkyholl@78.38.114.213] has quit [Read error: Connection reset by peer]
20170417 05:51:34< irker913> wesnoth: Rikard Falkeborn wesnoth:master 343eb9ab1b07 / src/ (10 files in 5 dirs): Add const to some functions https://github.com/wesnoth/wesnoth/commit/343eb9ab1b070e7c30174d9e9b66ae214e68df12
20170417 05:51:36< irker913> wesnoth: Rikard Falkeborn wesnoth:master 94e73a7cccf7 / src/ (22 files in 6 dirs): Add const to some more functions https://github.com/wesnoth/wesnoth/commit/94e73a7cccf7faf40852a20a1d8308cc249ea376
20170417 05:52:04< celticminstrel> That must mean Vultraz is up...
20170417 05:52:14-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170417 05:52:19< celticminstrel> There you are.
20170417 05:53:02< celticminstrel> Was the storyscreen issue with "Image too big for canvas" still a thing?
20170417 05:53:13< celticminstrel> Or rather, did know it was still a thing?
20170417 05:53:23-!- Kwandulin [~Kwandulin@p200300760F6D807DF02A457EC0C94A14.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170417 05:53:29< celticminstrel> I don't remember if you committed something that was supposed to fix it.
20170417 05:54:01< vultraz_iOS> i dunno
20170417 05:54:04< vultraz_iOS> it could be fixed
20170417 05:54:12< celticminstrel> It's not fixed.
20170417 05:54:15< vultraz_iOS> ok
20170417 05:54:35< celticminstrel> And worse, once it triggers, something is permanently messed up so that you can't start a game.
20170417 05:54:48< celticminstrel> Or rather, you can't do anything once you start one.
20170417 05:55:59< celticminstrel> In other words, the program makes you think it has recovered from the error when in fact it hasn't.
20170417 05:58:22< vultraz_iOS> i dunno what even the issue is
20170417 05:58:36< celticminstrel> I think it should be a blocker.
20170417 05:58:48< vultraz_iOS> I use max(pos, 0)
20170417 05:59:16< celticminstrel> Hmm, I suppose we could check the implementation of max...
20170417 06:00:58< celticminstrel> Hmm, it's probably not actually relevant here, but there is a problem with max.
20170417 06:01:24< celticminstrel> And with min, too.
20170417 06:02:54< vultraz_iOS> \ o /
20170417 06:11:25< vultraz_iOS> (what is this problem? signedness?)
20170417 06:13:36< celticminstrel> ...wait, should min work on strings too?
20170417 06:13:53< celticminstrel> The problem BTW is that 0 is implicitly in the list.
20170417 06:14:08< celticminstrel> So when you write max(a,b,c) it actually calculates max(a,b,c,0)
20170417 06:14:19< celticminstrel> And when you write min(a,b,c) it actually calculates min(a,b,c,0)
20170417 06:14:44< celticminstrel> So max can never return a negative value and min can never return a positive value... wait, seriously?
20170417 06:15:57< celticminstrel> Oh wait, that's probably what the boolean flag is for.
20170417 06:17:23< vultraz_iOS> boolflag?
20170417 06:19:22< celticminstrel> Yeah, there was a bool flag to exclude the implicit 0.
20170417 06:19:28< vultraz_iOS> i see
20170417 06:19:29< celticminstrel> So it's correct after all.
20170417 06:19:35< celticminstrel> Just a little weird.
20170417 06:19:37< vultraz_iOS> what is the default
20170417 06:21:07< celticminstrel> It's still a bit inconsistent though... if you do max('ab', 'abc') it fails, but if you do max(['ab','abc']) it works.
20170417 06:37:23-!- JyrkiVesterinen [~JyrkiVest@87-100-206-117.bb.dnainternet.fi] has joined #wesnoth-dev
20170417 06:40:17< irker913> wesnoth: Celtic Minstrel wesnoth:master eccd3d8e7eeb / src/formula/function.cpp: WFL: Cleanup of min() and max() function, and allow them to work on strings etc https://github.com/wesnoth/wesnoth/commit/eccd3d8e7eeb79a86ae538c9b469fd8c291763ec
20170417 06:40:19< irker913> wesnoth: Celtic Minstrel wesnoth:master d6dddd68d20d / src/formula/function.cpp: WFL Functions: Use isnan() instead of x != x https://github.com/wesnoth/wesnoth/commit/d6dddd68d20d5938899533d292a4736e37e2c970
20170417 06:41:28< vultraz_iOS> \o/ 
20170417 06:41:30< vultraz_iOS> isnan!
20170417 06:41:47< celticminstrel> :p
20170417 06:48:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170417 07:07:07< vultraz_iOS> celticminstrel: is there any reason the function_symbol_table and action_function_symbol_tables shouldn't be static?
20170417 07:08:43< celticminstrel> The main function_symbol_table, maybe.
20170417 07:08:59< celticminstrel> Actually, it is already, right?
20170417 07:09:14< vultraz_iOS> ah yes
20170417 07:09:14< vultraz_iOS> it is
20170417 07:18:04-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170417 07:18:27-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170417 07:18:32-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Client Quit]
20170417 07:19:51-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170417 07:35:55< vultraz_iOS> bleh
20170417 07:35:56< vultraz_iOS> "int i_side = i - teams.begin() + 1;"
20170417 07:36:03 * vultraz_iOS makes note to remove code like this sometime
20170417 08:01:29-!- Kwandulin [~Kwandulin@p200300760F6D807DF02A457EC0C94A14.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170417 08:08:01-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170417 08:21:25-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170417 08:33:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170417 09:02:22-!- Kwandulin [~Kwandulin@p200300760F6D807DF02A457EC0C94A14.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170417 09:28:12-!- Nobun [~nobun@5.170.108.110] has joined #wesnoth-dev
20170417 09:42:08-!- irker913 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170417 09:56:16-!- JyrkiVesterinen [~JyrkiVest@87-100-206-117.bb.dnainternet.fi] has quit [Quit: .]
20170417 10:10:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 10:24:10-!- Nobun [~nobun@5.170.108.110] has quit [Ping timeout: 240 seconds]
20170417 10:32:10-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170417 10:38:49-!- mjs-de [~mjs-de@185.22.140.72] has joined #wesnoth-dev
20170417 10:44:51-!- Nobun [~nobun@5.170.106.49] has joined #wesnoth-dev
20170417 10:50:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 10:50:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 10:57:15-!- mjs-de [~mjs-de@185.22.140.72] has quit [Remote host closed the connection]
20170417 11:38:31-!- JyrkiVesterinen [~JyrkiVest@87-100-206-117.bb.dnainternet.fi] has joined #wesnoth-dev
20170417 11:39:40-!- Nobun [~nobun@5.170.106.49] has quit [Ping timeout: 240 seconds]
20170417 11:45:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 11:47:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 12:22:55-!- Kwandulin [~Kwandulin@p200300760F6D807DF02A457EC0C94A14.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20170417 12:23:31-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170417 12:27:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170417 12:33:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:29e1:6f1d:821c:fc57] has joined #wesnoth-dev
20170417 12:35:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170417 12:36:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 12:37:43-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:29e1:6f1d:821c:fc57] has quit [Ping timeout: 245 seconds]
20170417 12:51:42-!- irker989 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170417 12:51:42< irker989> wesnoth: gfgtdf wesnoth:master 7db2b7c31e56 / src/gui/dialogs/multiplayer/mp_join_game.cpp: fix OOS when joining an mp game https://github.com/wesnoth/wesnoth/commit/7db2b7c31e56dfb52f7e6139336b0d5088ed2b50
20170417 12:52:04-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170417 13:01:43-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170417 13:14:46< zookeeper> besides terrain and [item]s, is there anything else that gets ToD-shifted?
20170417 13:18:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170417 13:30:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 13:30:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 13:31:20< vultraz_iOS> dunno
20170417 13:31:52< irker989> wesnoth: mattsc wesnoth:master 6f221f9bb981 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/6f221f9bb98143b26247de6ca1a4912cb4cac3dd
20170417 13:32:00< zookeeper> i can't think of any, so i was just wondering whether i'm missing something obvious
20170417 13:49:12< vultraz_iOS> can't think of any either
20170417 13:49:19< mattsc> zookeeper: hi; what’s your take on being able to play an expert campaign on nightmare on the first attempt?
20170417 13:49:22< mattsc> I mean, in an ideal world this should be set up for that to be possible for the best players, of couse, but in practice …
20170417 13:49:38< mattsc> s/this/things
20170417 13:49:48< mattsc> I am asking because of this:  https://forums.wesnoth.org/viewtopic.php?f=38&t=16994&p=610490#p610490
20170417 13:50:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170417 13:52:49-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170417 13:53:00< zookeeper> mattsc, no time to read the whole thing now, but generally i'd say it shouldn't require a very lopsided recall list (like a disproportionate amount of trolls for example, just because they're needed for one scenario)
20170417 13:53:45< zookeeper> that is, if one plays very well and gets a balanced recall list, it should be possible... but of course really really hard
20170417 13:54:14< mattsc> zookeeper: yeah, I agree with that; and I did not think that was necessary; at least on the medium level (on which I tested), you don’t need that
20170417 13:54:59< mattsc> maybe we should just make that scenario a little easier …  It’d still be quite the challenge.
20170417 13:56:01< mattsc> In any case, if anything other than very minor adjustments are needed/desired, I am in no position to do that anytime soon (or not so soon).
20170417 13:56:29< mattsc> Maybe somebody else wants to?  :)   (not talking about zookeeper here)
20170417 14:00:41< zookeeper> yeah usually if people complain about a scenario being too difficult, i'll rather err on the side of caution and make it a bit easier (as i'm sure i've mentioned a lot of times)
20170417 14:05:09-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170417 14:24:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 14:24:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 14:25:30-!- gfgtdf [~chatzilla@x4e369bb0.dyn.telefonica.de] has joined #wesnoth-dev
20170417 14:25:36< gfgtdf> 20170417 01:36:40< celticminstrel> I thought gfgtdf did something about allowing ../ in paths.
20170417 14:26:52< gfgtdf> celticminstrel: iirc ,my wokr was onyl about the lua api (require/dofile/readfile etc)
20170417 14:31:48< gfgtdf> celticminstrel: which doesn't mean it couldn't be impelemnted for wmlproceccins aswell, but i just didn't want to touche the preproceccor code back then
20170417 14:36:07< gfgtdf> touch*
20170417 14:47:46-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170417 15:08:39-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170417 15:16:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 15:17:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 15:56:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 16:00:23-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 16:00:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 16:01:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170417 16:06:20< gfgtdf> vultraz_iOS: about slider: my current work somehow resulted in slider beeing unabl to have values that is not valid in terman of steps.
20170417 16:06:42< vultraz_iOS> well, i think that's to be expected?
20170417 16:06:43< gfgtdf> vultraz_iOS: like when you have a slider min=0, max=10 you cannot assign it value 5 by code
20170417 16:06:54< gfgtdf> not sure whather thats a problem.
20170417 16:06:56< vultraz_iOS> even if step = 1?
20170417 16:07:04< gfgtdf> no if step=2 i meant
20170417 16:07:19< gfgtdf> ofc it can be done in case step =1.
20170417 16:07:24< vultraz_iOS> don't think it would be too much of a problem
20170417 16:08:29-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170417 16:09:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 16:09:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 16:16:05-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170417 16:17:38< gfgtdf> vultraz_iOS: about https://github.com/wesnoth/wesnoth/commit/3efcc2a31db313b23664861bbe7e77de26b175d0
20170417 16:17:56< gfgtdf> vultraz_iOS: i wonder whether the other statistics::fresh_stats(); in that file shouldn't be cleared aswell
20170417 16:18:20< vultraz_iOS> doesn't one want fresh stats when entering a game tho
20170417 16:19:52< gfgtdf> vultraz_iOS: hmm tdepends on whetehr the actual game is already loaded at that point, ou're problable right
20170417 16:24:01< gfgtdf> hmm it seems like the multiplayer.cpp  enter_..._mode mode don't destroy the gui2 doesgs before the game is ended, i think it'd be better if they would
20170417 16:24:12< gfgtdf> at least it'd save some ram.
20170417 16:24:38-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170417 16:27:59< vultraz_iOS> yes
20170417 16:28:02< vultraz_iOS> they don't
20170417 16:28:05< vultraz_iOS> i did notice that
20170417 16:28:23< gfgtdf> any reaspon against changin that ?
20170417 16:28:33< vultraz_iOS> no
20170417 16:28:46< vultraz_iOS> that would probably fix the double quit confirmation bug
20170417 16:29:06< vultraz_iOS> i think it's just a matter of making each function exit with its output rather than chain calling each other
20170417 16:32:22-!- irker989 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170417 16:32:28-!- irker955 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170417 16:32:28< irker955> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 254ae3fa57ce / src/game_initialization/multiplayer.cpp: destro mp dialog objects before starting the game. https://github.com/wesnoth/wesnoth/commit/254ae3fa57cef7f2bffa576f9cd34b4a900b354a
20170417 16:32:52-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170417 16:33:06< vultraz_iOS> ....huh
20170417 16:33:12< vultraz_iOS> i didn't realize you could control scope like that
20170417 16:34:05< gfgtdf> just add brackets {} and everythgin declared inside them will have their  scope ended at the }
20170417 16:34:27< gfgtdf> actually connect_engine_ptr did that already in this file
20170417 16:58:58< irker955> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 fbb8925d7d50 / src/game_initialization/multiplayer.cpp: fixup https://github.com/wesnoth/wesnoth/commit/fbb8925d7d50bdcbd11c47ac4ede0096b7999533
20170417 17:02:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 17:02:28-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 17:03:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 17:03:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 17:07:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170417 17:08:56-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20170417 17:19:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 17:30:51-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170417 17:35:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 17:36:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 17:39:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 17:42:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 17:51:44< irker955> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 f19013433e03 / src/game_initialization/multiplayer.cpp: fixup https://github.com/wesnoth/wesnoth/commit/f19013433e032d09abfc08c72db299ff84267357
20170417 17:59:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 17:59:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 18:06:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 18:06:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 18:07:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 18:08:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 18:13:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 18:14:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 18:17:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 18:18:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 18:19:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 18:19:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 18:35:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170417 18:44:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170417 18:45:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170417 19:10:31< Shiki> from the wiki https://wiki.wesnoth.org/ReportingBugs "In Mac OS X, you can enable Crash Reporter -- the output is a backtrace. Run Applications -> Utilities -> Console to see log output. ..." Afterwards is a link to a dead page. Maybe someone using osx can check that?
20170417 19:16:49< celticminstrel> ...you need to enable Crash Reporter? o.o
20170417 19:20:00< Shiki> no idea. i just came along the wikipage
20170417 19:32:47-!- Shiki [~Shiki@dslb-188-105-048-166.188.105.pools.vodafone-ip.de] has quit [Remote host closed the connection]
20170417 19:40:07< irker955> wesnoth: gfgtdf wesnoth:master 175e64cfaa0a / src/game_initialization/multiplayer.cpp: destroy mp dialog objects before starting the game. https://github.com/wesnoth/wesnoth/commit/175e64cfaa0a18c85b5387d4464256b6c8cdf1cf
20170417 19:46:48-!- mjs-de [~mjs-de@x4db65b8a.dyn.telefonica.de] has joined #wesnoth-dev
20170417 19:48:24< vultraz_iOS> gfgtdf: confirmed it fixes the double quit message 
20170417 19:48:50< gfgtdf> that's nice actually that wasn't even my intention.
20170417 19:54:29-!- Kwandulin [~Kwandulin@p200300760F6D800395F68B7638287E0A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170417 20:02:36-!- mjs-de [~mjs-de@x4db65b8a.dyn.telefonica.de] has quit [Remote host closed the connection]
20170417 20:16:26< irker955> wesnoth: ln-zookeeper wesnoth:master 8e4251349bd2 / src/display.cpp: Allow the ~NO_TOD_SHIFT() IPF to work also on [item]s https://github.com/wesnoth/wesnoth/commit/8e4251349bd22696f5ab44eb7caa4431315b6d2e
20170417 20:17:42< vultraz_iOS> well that's one way to do it...
20170417 20:17:48< vultraz_iOS> I don't think it's the best way, though
20170417 20:18:29-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170417 20:22:22< vultraz_iOS> though, that is how the other code does it
20170417 20:22:29 * vultraz_iOS makes note
20170417 20:23:08< celticminstrel> A fake IPF isn't as good as a special key in the WML tag, but ... it's not that bad, I guess.
20170417 20:24:07< vultraz_iOS> right, but i don't like that the code does string search for the IPF
20170417 20:24:36< celticminstrel> How else would it find it?
20170417 20:24:50< vultraz_iOS> or at least, not directly like this
20170417 20:25:17< celticminstrel> Hmmm...
20170417 20:25:28< vultraz_iOS> processing should be internally..
20170417 20:25:40< vultraz_iOS> either in the IPF or get_lighted_image
20170417 20:25:59< vultraz_iOS> though the other usecase doesn't use the latter
20170417 20:26:01< celticminstrel> I too was thinking the latter.
20170417 20:26:07< celticminstrel> Ah, then that's a problem.
20170417 20:26:07< vultraz_iOS> oh, wait, it does
20170417 20:26:38< celticminstrel> This isn't a real IPF, so it can't use the regular IPF processing pipeline.
20170417 20:31:10< celticminstrel> The only other place get_lighted_image is called is in apply_light on line 614 of image.cpp... which is also called by get_lighted_image...
20170417 20:33:57< celticminstrel> vultraz_iOS: It does look like you should be able to handle it in get_lighted_image if you want to.
20170417 20:36:05< vultraz_iOS> alright
20170417 20:38:51< celticminstrel> (But be sure to test it.)
20170417 20:39:32< vultraz_iOS> heh, i just realized this entire file (image.*cpp) would have to be rewritten when we switch to textures
20170417 20:39:45< vultraz_iOS> JustEarlyMorningPreCoffeeThoughts
20170417 20:42:51< vultraz_iOS> i wonder how HW rendering affects text rendering
20170417 20:44:09< vultraz_iOS> probably a lot to rewrite there too
20170417 20:47:13-!- mjs-de [~mjs-de@x4db65b8a.dyn.telefonica.de] has joined #wesnoth-dev
20170417 21:03:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 21:03:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 21:07:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170417 21:14:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 21:14:53-!- mjs-de [~mjs-de@x4db65b8a.dyn.telefonica.de] has quit [Remote host closed the connection]
20170417 21:23:24-!- JyrkiVesterinen [~JyrkiVest@87-100-206-117.bb.dnainternet.fi] has quit [Quit: .]
20170417 21:30:48-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170417 21:34:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 245 seconds]
20170417 21:38:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170417 22:08:20-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170417 22:20:18-!- gfgtdf_ [~chatzilla@x4e369bb0.dyn.telefonica.de] has joined #wesnoth-dev
20170417 22:20:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 22:21:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 22:22:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 22:22:52-!- gfgtdf [~chatzilla@x4e369bb0.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170417 22:22:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 22:22:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170417 22:22:59-!- gfgtdf_ is now known as gfgtdf
20170417 22:23:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170417 22:47:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20170417 23:16:58-!- irker955 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170417 23:31:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170417 23:32:10-!- gfgtdf [~chatzilla@x4e369bb0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170417 23:39:18< vultraz_iOS> celticminstrel: i wonder if location_callable could be implemented with a point
20170417 23:41:18< celticminstrel> Uh.
20170417 23:41:22< celticminstrel> Why?
20170417 23:42:29< vultraz_iOS> well you said a week or so ago that using it as a coordinate is weird if it's implemented with a map loc
20170417 23:42:43< celticminstrel> True, but the reverse is also true.
20170417 23:44:58< celticminstrel> Although it's not reflected in anything in WFL, there actually is a fundamental difference between a pixel location and a map location.
20170417 23:45:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170417 23:46:08< vultraz_iOS> what is it?
20170417 23:46:36< celticminstrel> I think the "coordinate system" would be the best way to describe it.
20170417 23:47:04< vultraz_iOS> certainly, but the values come out the same
20170417 23:47:22< celticminstrel> The fact of being an entity with x and y coordinates is the same, yes.
20170417 23:51:25 * vultraz_iOS is looking for something to clean up
20170417 23:57:52-!- irker628 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170417 23:57:52< irker628> wesnoth: Charles Dang wesnoth:master 5bc40c0f21d5 / src/units/drawer.hpp: Made unit_drawer's fixed_t type match the rest of the fixed_t's https://github.com/wesnoth/wesnoth/commit/5bc40c0f21d599d5c227838c5333a353022f5f33
--- Log closed Tue Apr 18 00:00:16 2017