--- Log opened Thu Apr 20 00:00:24 2017
--- Day changed Thu Apr 20 2017
20170420 00:00:24-!- turupawn [~turupawn@179.49.119.217] has joined #wesnoth-dev
20170420 00:06:45< gfgtdf> the old namespece (which was deleted after the random_new  was added) was rand_rng which isn't ideal eigher.
20170420 00:15:03-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 00:17:48-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170420 00:29:11< vultraz_iOS> a wild tad appears!
20170420 00:30:21< celticminstrel> I don't see one?
20170420 00:30:25< celticminstrel> What are you talking about?
20170420 00:30:38< celticminstrel> Oh.
20170420 00:33:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170420 00:34:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 00:39:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170420 00:50:31-!- gfgtdf [~chatzilla@x4e363f9a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170420 00:50:32-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 01:02:53-!- turupawn [~turupawn@179.49.119.217] has quit [Ping timeout: 260 seconds]
20170420 01:03:55< vultraz_iOS> ok, time to finish my tod_manager_manager class..
20170420 01:05:08< celticminstrel> That sounds awful.
20170420 01:05:16< celticminstrel> Why would you want a tod manager manager. :(
20170420 01:05:38< vultraz_iOS> or perhaps it should just be in tod_manager
20170420 01:07:01< vultraz_iOS> celticminstrel: trying to replace all the tod_manager entry points with a single global shared_ptr that game_display/map_context can reset on demand
20170420 01:09:09< vultraz_iOS> or perhaps it should just be a unique_ptr here and raw pointers dispensed...
20170420 01:16:14-!- irker649 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170420 01:19:59< vultraz_iOS> oh jfc who owns the game_display
20170420 01:20:12-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 01:20:42< vultraz_iOS> everyone
20170420 01:21:24< vultraz_iOS> ok, the game_display doesn't own the ToD manager..
20170420 01:21:51< vultraz_iOS> game_state owns the ToD manager
20170420 01:28:46< vultraz_iOS> sigh
20170420 01:28:58< vultraz_iOS> filter_context has pure_virtual get_tod_man
20170420 01:29:20< vultraz_iOS> oh, display inherits from filter_context...
20170420 01:29:22< vultraz_iOS> who'd have thought
20170420 01:29:54< celticminstrel> I think I already knew that.
20170420 01:31:11< vultraz_iOS> ok, ill make this non-virtual and return the managed ptr
20170420 01:32:25< celticminstrel> Don't make it non-virtual.
20170420 01:32:36< vultraz_iOS> why?
20170420 01:32:57< celticminstrel> At least, consider the fact that filter_context has more than just one subclass.
20170420 01:33:28< vultraz_iOS> i'm making it so no subclass owns a tod manager
20170420 01:37:14< celticminstrel> I think filter_context was intended to be just an interface, which would suggest it shouldn't own anything... though on the other hand I think it's kinda silly for an interface to be just an interface when logically there's common data anyway...
20170420 01:37:44< vultraz_iOS> seems game... state owns the tod manager
20170420 01:37:48< vultraz_iOS> I think..
20170420 01:39:03< vultraz_iOS> (im curious how singletons are thread-safe)
20170420 01:42:32< vultraz_iOS> hmmm
20170420 01:42:41< vultraz_iOS> this might be a little more complicated than i thought..
20170420 01:50:14-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 01:58:25< vultraz_iOS> Oh geez another PR with a million commits
20170420 01:59:03< vultraz_iOS> And a ton of unrelated stuff
20170420 02:05:07< pydsigner> Those are the bestest!
20170420 02:05:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170420 02:05:57< celticminstrel> Looks like they closed it already though.
20170420 02:06:41< pydsigner> Yeah. Presumably  they'll clean it up and resub.
20170420 02:06:47< pydsigner> Hopefully, anyways
20170420 02:06:51< pydsigner> It'd be a good feature
20170420 02:21:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170420 02:47:48< vultraz_iOS> celticminstrel: https://github.com/Vultraz/wesnoth/commit/2135389f603ba35a5a2b9f09b55b0f0c9e60a736
20170420 02:48:44< vultraz_iOS> need feedback
20170420 02:49:07< vultraz_iOS> also, not 100% sure it's safe to dereference the singleton in filter_context 100% of the time
20170420 02:49:17< vultraz_iOS> maybe I should add an assert
20170420 02:49:35-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 02:50:07< vultraz_iOS> anyway, the tl'dr is instead of two classes owning an manager and a whole fucktown of pointers being passed around as well as the global resources ptr, we now have a singleton and getters in filter_context and map_context
20170420 02:51:18< celticminstrel> Not sure I like the approach...
20170420 02:52:14< vultraz_iOS> Elaborate
20170420 02:52:29< celticminstrel> The singleton approach.
20170420 03:04:42-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170420 03:04:43-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 03:04:43-!- JyrkiVesterinen [~JyrkiVest@87-100-163-0.bb.dnainternet.fi] has joined #wesnoth-dev
20170420 03:04:51< vultraz_iOS> no other feedback?
20170420 03:10:00< celticminstrel> I don't really have much to say... the only two specific comments I thought of were "don't allow overriding filter_context::get_tod_manager" (either by making it non-virtual or by making it final) and "maybe consider returning the so-called singleton by reference"
20170420 03:10:22< celticminstrel> But I'm not really sure a singleton approach is best here anyway.
20170420 03:10:37< celticminstrel> The tod_manager doesn't seem like a singleton to me.
20170420 03:10:57-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 03:15:40< un214> a singleton is something that should be static but can't be
20170420 03:35:39-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 03:35:53< vultraz_iOS> celticminstrel: how else should i do it, then
20170420 03:37:15< celticminstrel> I'm not sure...
20170420 03:47:06< vultraz_iOS> plus, is the singleton any worse than the resources global pointer?
20170420 03:47:47< celticminstrel> I don't think it's any worse, but I'm not convinced it's any better, either.
20170420 03:48:51< vultraz_iOS> it unifies the interface
20170420 03:53:19< vultraz_iOS> maybe ill see what gfgtaf tas to say
20170420 03:53:22< vultraz_iOS> has
20170420 04:08:58-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170420 04:19:31-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 04:48:37-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 04:52:20-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 05:15:15-!- RatArmy [~ratarmy@om126161112060.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 05:22:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 05:27:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20170420 05:52:21-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170420 06:05:43-!- JyrkiVesterinen [~JyrkiVest@87-100-163-0.bb.dnainternet.fi] has quit [Quit: .]
20170420 06:26:14-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 06:32:40-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 260 seconds]
20170420 06:34:57-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170420 06:45:21-!- celticminstrel is now known as celmin|sleep
20170420 06:46:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170420 06:48:57-!- RatArmy [~ratarmy@om126161117059.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 06:52:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170420 06:53:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20170420 06:53:47-!- wedge010 is now known as wedge009
20170420 07:04:01-!- RatArmy [~ratarmy@om126161117059.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 07:04:26-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170420 07:09:05-!- RatArmy [~ratarmy@om126161117059.8.openmobile.ne.jp] has joined #wesnoth-dev
20170420 07:10:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170420 07:11:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 07:15:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170420 07:32:54-!- RatArmy [~ratarmy@om126161117059.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 07:56:34-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 08:39:53-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 255 seconds]
20170420 08:43:52-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170420 08:50:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170420 08:56:42-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 08:58:00-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 258 seconds]
20170420 08:59:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 09:03:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170420 09:08:53-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170420 09:19:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170420 09:59:18< vultraz_iOS> gfgtdf: what do you think of https://github.com/Vultraz/wesnoth/commit/29d9cf212499f1a9975882fc98b53b0141bddb3e ?
20170420 10:02:44-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 260 seconds]
20170420 10:05:30-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 10:39:45< wedge009> What's the minimum VC++ version supported nowadays?
20170420 10:40:19< wedge009> I'm not sure if the fallthrough annotations celticminstrel added to tokenizer.cpp will work with the older versions.
20170420 10:40:21-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 10:41:57< JyrkiVesterinen> Visual Studio 2013 is still the minimum.
20170420 10:42:19< wedge009> Okay.
20170420 10:42:22< JyrkiVesterinen> Celticminstrel tested with it, so the annotations should work.
20170420 10:42:37< wedge009> Hmm, I can't get it to compile with VS2017...
20170420 10:43:43< JyrkiVesterinen> I'm too busy to test it myself in the evening, unfortunately. :/
20170420 10:43:56-!- irker824 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170420 10:43:56< irker824> wesnoth: Wedge009 wesnoth:master 46acff818b02 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update VC project files for d8ed11c2 (dropping _new suffix). https://github.com/wesnoth/wesnoth/commit/46acff818b0224c0e6abba194a68e7ff9b8a9113
20170420 10:46:51-!- Shiki [~Shiki@141.57.57.138] has joined #wesnoth-dev
20170420 10:47:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 10:52:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170420 10:59:43-!- Shiki [~Shiki@141.57.57.138] has quit [Remote host closed the connection]
20170420 11:12:01-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 11:41:39-!- DeFender1031 [~DeFender1@46-116-90-83.bb.netvision.net.il] has joined #wesnoth-dev
20170420 11:42:47-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20170420 11:43:31-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170420 11:48:22-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 12:00:29< wedge009> celticminstrel: JyrkiVesterinen: It might be a VS2017-specific issue. Looks like some extra handling for c++2017 was done to fallthrough, but using /std:c++latest to let it get compiled seems to break things in boost (haven't looked into the recent 1.64 release yet).
20170420 12:03:34< DeFender1031> Sup guys? Anyone miss me?
20170420 12:08:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 12:12:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 12:12:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds]
20170420 12:15:14-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 12:35:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 12:36:30< wedge009> Hmm, Linux compilation also not working...
20170420 12:39:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170420 12:47:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170420 12:54:16-!- stikonas_ is now known as stikonas
20170420 12:58:32-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 13:14:15-!- turupawn [~turupawn@179.49.119.217] has joined #wesnoth-dev
20170420 13:29:05-!- Kwandulin [~Kwandulin@p200300760F6D80B36877D6CE172B1F72.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170420 14:01:57-!- zookeeper_ [zookeeper@37.35.31.211] has joined #wesnoth-dev
20170420 14:04:40-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170420 14:06:26-!- zookeeper_ is now known as zookeeper
20170420 14:06:28-!- zookeeper [zookeeper@37.35.31.211] has quit [Changing host]
20170420 14:06:28-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170420 14:31:50-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170420 14:33:10-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 240 seconds]
20170420 14:53:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170420 14:53:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170420 15:02:17-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 15:02:20-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170420 15:11:21-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170420 15:11:45< DeFender1031> sup, vult?
20170420 15:12:02< vultraz_iOS> String utils? :3
20170420 15:12:53< DeFender1031> No no, that's MY job... :P
20170420 15:20:23< vultraz_iOS> heh
20170420 15:20:42< vultraz_iOS> welcome back
20170420 15:23:10-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has left #wesnoth-dev ["Verlassend"]
20170420 15:28:51-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170420 15:28:54-!- Shiki [~Shiki@p57803acb.dip0.t-ipconnect.de] has left #wesnoth-dev []
20170420 15:41:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170420 15:41:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170420 15:43:10-!- JyrkiVesterinen [~JyrkiVest@89-166-121-0.bb.dnainternet.fi] has joined #wesnoth-dev
20170420 15:45:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 15:46:22-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170420 15:46:46< celmin|sleep> Uh, vultraz_iOS, why haven't you fixed the random issue yet...
20170420 15:47:23< vultraz_iOS> ah, I should do that..
20170420 15:48:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170420 15:49:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 15:50:46< vultraz_iOS> guess i should just put my ToD commit on a branch
20170420 15:54:04< irker824> wesnoth: Charles Dang wesnoth:tod_manager_handling_refactor 29d9cf212499 / src/ (34 files in 13 dirs): Refactor handling of the ToD manager https://github.com/wesnoth/wesnoth/commit/29d9cf212499f1a9975882fc98b53b0141bddb3e
20170420 15:56:17< vultraz_iOS> celmin|sleep: still no ideas for a new name?
20170420 15:56:41< vultraz_iOS> what about 'randomness'
20170420 15:56:48< celmin|sleep> Kinda long, but would work.
20170420 16:04:48< vultraz_iOS> the Windows 10 creators update really handles full CPU loads a lot better.
20170420 16:05:29< vultraz_iOS> can actually do stuff while compiling with -j4 instead of lag and freezing
20170420 16:05:34< vultraz_iOS> esp in chrome
20170420 16:05:42< vultraz_iOS> kudos, microsoft 
20170420 16:09:31< celmin|sleep> Are you sure CPU is the issue here?
20170420 16:10:31< irker824> wesnoth: Charles Dang wesnoth:master e90d11d02a14 / src/ (23 files in 10 dirs): Renamed namespace 'random' to 'randomness' https://github.com/wesnoth/wesnoth/commit/e90d11d02a14129334c8570004276ae0928ece6a
20170420 16:10:34< irker824> wesnoth: Charles Dang wesnoth:master 323516d3d86d / src/ (19 files in 8 dirs): Avoid copy initialization of arrays (use direct instead) https://github.com/wesnoth/wesnoth/commit/323516d3d86d64e75483a541cb4ce7396d5029e5
20170420 16:10:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 16:10:45< vultraz_iOS> celmin|sleep: dunno. but it's improved
20170420 16:11:16< celmin|sleep> Pretty sure there's no such thing as copy-initialization of arrays...
20170420 16:11:25< vultraz_iOS> *shrug*
20170420 16:11:32< vultraz_iOS> let's be safe :P
20170420 16:11:41< celmin|sleep> 9_9
20170420 16:13:37< vultraz_iOS> wonder if we should deploy std::array in place of T foo[]
20170420 16:14:05< celmin|sleep> Depends.
20170420 16:15:11< vultraz_iOS> only downside is having to specify the size manually
20170420 16:15:16< celmin|sleep> Uh.
20170420 16:15:33< celmin|sleep> You do need to do that for C-style arrays too.
20170420 16:15:48< vultraz_iOS> I'm not seeing any numbers here
20170420 16:15:51< celmin|sleep> Though I guess you can let the compiler figure it out if you're initializing it.
20170420 16:16:45< celmin|sleep> Well, it sounds like you've decided it's not worth it then. :P
20170420 16:17:16< celmin|sleep> I'd say the advantages of std::array over bare arrays are:
20170420 16:17:22< celmin|sleep> 1. You can easily get the size.
20170420 16:17:29< celmin|sleep> 2. You can pass it to a function.
20170420 16:17:30< vultraz_iOS> i dunno if it's worth it, just would be slightly bothersome to count elements
20170420 16:17:34< vultraz_iOS> esp in the lua stuff
20170420 16:17:49< celmin|sleep> Mind you, IIRC you can get the size of a bare array with sizeof() though.
20170420 16:17:54< vultraz_iOS> since with std::array, the size is a template parameter
20170420 16:18:12< celmin|sleep> It wouldn't be worth it to use std::array in the Lua stuff.
20170420 16:18:16< vultraz_iOS> sizeof is very C, isn't it
20170420 16:18:27< celmin|sleep> Uh, well, it's both?
20170420 16:19:57< vultraz_iOS> I'll change cases that use sizeof for array size to std::array
20170420 16:20:30< celmin|sleep> I think the cases you changed in the previous commit probably would not be worth changing to std::array.
20170420 16:32:26< vultraz_iOS> surprisingly few places array size is used 
20170420 16:33:20< celmin|sleep> Apparently array size is sizeof(arr) / sizeof(arr[0])?
20170420 16:35:30< vultraz_iOS> also saw sizeof(arr) / sizeof(*arr)
20170420 16:35:57< celmin|sleep> I think that comes to the same thing.
20170420 16:36:05-!- celmin|sleep is now known as celticminstrel
20170420 16:36:05< vultraz_iOS> probably
20170420 16:36:11 * vultraz_iOS just counted a 193 member array
20170420 16:36:31< celticminstrel> An array decays to a pointer to its first member... why are you counting 193 members?
20170420 16:36:50< vultraz_iOS> return known_hotkeys[sizeof(hotkey_list_) / sizeof(hotkey_list_[0])  - 1];
20170420 16:37:01< celticminstrel> Eh, don't make that std::array...
20170420 16:37:09< celticminstrel> It'd make it harder to add new hotkeys.
20170420 16:37:59< celticminstrel> "return *(std::end(known_hotkeys) - 1)" ?
20170420 16:38:17< celticminstrel> The point of that seems to be to fetch the last element, right?
20170420 16:38:32< vultraz_iOS> /it is the last entry in that array, and the indexes in hotkey_list_ and known_hotkeys are the same.
20170420 16:38:46< celticminstrel> ???
20170420 16:38:55< vultraz_iOS> seems known_hotkeys's size might not equal hotkey_list_'s size
20170420 16:39:02< vultraz_iOS> if i'm reading correctly
20170420 16:39:44< celticminstrel> Oh.
20170420 16:41:19< celticminstrel> Hmm.
20170420 16:41:54< irker824> wesnoth: Charles Dang wesnoth:master ac9ad01be8f2 / src/ (display.cpp display.hpp units/unit.cpp): Use std::array where array size is needed, when appropriate https://github.com/wesnoth/wesnoth/commit/ac9ad01be8f2b1c441b7405abca6233e74139251
20170420 16:42:31< vultraz_iOS> turns out it's like, 3 cases
20170420 16:42:41< vultraz_iOS> (one of which was in my previous commit)
20170420 16:42:43< celticminstrel> Um.
20170420 16:43:12< celticminstrel> sizeof(display::drawing_buffer_key::layer_groups) is probably not the same as layer_groups.size()
20170420 16:43:29< vultraz_iOS> hm?
20170420 16:44:25< celticminstrel> Line 1216 of display.cpp. You basically replaced "sizeof(x) / sizeof(x[0])" with "x.size() / sizeof(x[0])"
20170420 16:45:13< celticminstrel> Though TBH I kind question whether std::array was a good idea there... but at least it's not as bad as it would be for the hotkeys list.
20170420 16:45:28< celticminstrel> Oh wait, it's a member value though...
20170420 16:45:52< celticminstrel> Still, I guess adding new drawing layers would be an uncommon occurrence.
20170420 16:46:27< celticminstrel> I think the case in unit.cpp would've been better handled by leaving it a bare array and using rnage-for.
20170420 16:46:38< celticminstrel> Unless i is used in the loop?
20170420 16:47:02< celticminstrel> Mind you, you can use range-for for std::array as easily as for bare arrays.
20170420 16:47:43< vultraz_iOS> yeah, i isn't used
20170420 16:50:19< irker824> wesnoth: Charles Dang wesnoth:master bdb2b05db817 / src/units/unit.cpp: Further cleanup to ac9ad01be8f2 with range-for https://github.com/wesnoth/wesnoth/commit/bdb2b05db8179ebe7ae29cdfd0f74ea94207d2f2
20170420 16:51:40< irker824> wesnoth: Celtic Minstrel wesnoth:master fb71507d0dd8 / src/display.cpp: Fixup ac9ad01be8f2 https://github.com/wesnoth/wesnoth/commit/fb71507d0dd8b709720eac0e28129e5f95bf7dee
20170420 16:52:55< vultraz_iOS> size - 2?
20170420 16:53:06< celticminstrel> That's what it was before?
20170420 16:53:09< vultraz_iOS> shouldn't it be - 1?
20170420 16:53:40< celticminstrel> I assume the last element is intentionally excluded.
20170420 16:54:00< vultraz_iOS> tbh im not even sure what the code is supposed to do
20170420 16:54:02< vultraz_iOS> drawing_layer is an enum
20170420 16:54:59< vultraz_iOS> LAYER_LAST_LAYER is a dummy, eh
20170420 16:55:29< vultraz_iOS> 	// max_layer_group + 1 is the last valid entry in layer_groups, but it is always > layer
20170420 16:55:29< vultraz_iOS> 	// thus the first --g is a given => start with max_layer_groups right away
20170420 16:55:32< vultraz_iOS> hmm
20170420 17:03:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170420 17:05:12< mattsc> vultraz_iOS: the Xcode build still fails with the same warning/error I mentioned yesterday
20170420 17:05:22< vultraz_iOS> what error?
20170420 17:07:07< mattsc> 20170419 16:27:22< mattsc> vultraz: trying to update the Xcode project, the build fails on this:
20170420 17:07:07< mattsc> 20170419 16:27:25< mattsc> src/storyscreen/controller.hpp:56:6: error: private field 'segment_index_' is not used [-Werror,-Wunused-private-field]
20170420 17:07:08< mattsc> 20170419 16:27:41< mattsc> Do you want me to make that warning non-fatal, or do you want to remove the cause of it?
20170420 17:07:09< mattsc> 20170419 16:30:36< JyrkiVesterinen> Please fix it. That field is indeed no longer used.
20170420 17:07:51< vultraz_iOS> will fix
20170420 17:09:31< irker824> wesnoth: Charles Dang wesnoth:master 2e4e84d27031 / src/storyscreen/ (controller.cpp controller.hpp interface.cpp): Removed unused class member from storyscreen controller https://github.com/wesnoth/wesnoth/commit/2e4e84d27031cc574c243b82e43b5588b645b71e
20170420 17:09:50< vultraz_iOS> mattsc: ^
20170420 17:10:02< vultraz_iOS> celticminstrel: actually, can LAYER_LAST_LAYER be removed?
20170420 17:10:15< vultraz_iOS> and size() - 1 be used?
20170420 17:10:28-!- gfgtdf [~chatzilla@x4e32b5b9.dyn.telefonica.de] has joined #wesnoth-dev
20170420 17:11:00< mattsc> vultraz_iOS: okay, thanks; will try to update the Xcode project
20170420 17:12:20< mattsc> ugh
20170420 17:12:21< celticminstrel> I don't know.
20170420 17:12:25< mattsc> src/display.cpp:944:49: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
20170420 17:12:39< celticminstrel> Pretty sure that's wrong.
20170420 17:12:53< celticminstrel> std::array should have an initializer_list constructor, I thought?
20170420 17:13:25< JyrkiVesterinen> I think the problem is initialization of strings.
20170420 17:14:03< JyrkiVesterinen> static const std::array<std::string, 6> dirs { {"-n"}, {"-ne"}, {"-se"}, {"-s"}, {"-sw"}, {"-nw"} };
20170420 17:14:11< JyrkiVesterinen> That should fix it.
20170420 17:14:13< celticminstrel> You think so?
20170420 17:14:54< celticminstrel> I think it's also fine to just turn off the warning though.
20170420 17:16:20< vultraz_iOS> celticminstrel: what does sizeof(an_enum) do?
20170420 17:16:26< vultraz_iOS> just trying to figure out what the old code did
20170420 17:16:40< vultraz_iOS> because to me it *looks* like 5 / 26 - 2
20170420 17:17:50< mattsc> no, that does not fix it; it then produces a different error: excess elements in struct initializer
20170420 17:18:18< mattsc> I can disable the warning, don’t really care; but right now I need to be off, sorry
20170420 17:18:18< vultraz_iOS> mattsc: try dir = {
20170420 17:19:27< mattsc> vultraz_iOS: nope
20170420 17:19:31< vultraz_iOS> huh
20170420 17:19:32< mattsc> anyway, bye for now
20170420 17:19:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170420 17:19:35< vultraz_iOS> weird
20170420 17:21:43-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 260 seconds]
20170420 17:23:23< celticminstrel> I think the fix would actually be to use double braces around the whole thing.
20170420 17:23:46< celticminstrel> Because it's initializing the bare array which exists within the std::array.
20170420 17:24:03< celticminstrel> Which is silly, but...
20170420 17:25:22< vultraz_iOS> I can't figure out what the drawing_buffer_key ctor is doing
20170420 17:26:02< vultraz_iOS> so you have the index of the last valid group
20170420 17:26:09< vultraz_iOS> but why do you *decrease* the index :|
20170420 17:28:01< vultraz_iOS> 	// max_layer_group + 1 is the last valid entry in layer_groups, but it is always > layer
20170420 17:28:01< vultraz_iOS> 	// thus the first --g is a given => start with max_layer_groups right away
20170420 17:28:16< JyrkiVesterinen> Hmm. Maybe it would even need both double braces around everything, *and* braces around the character arrays (inside the strings), bringing it to no less than three levels of braces. :/
20170420 17:28:16 * vultraz_iOS parses
20170420 17:29:02< vultraz_iOS> ok so it makes sense when the dummy last entry was present
20170420 17:29:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170420 17:29:18< vultraz_iOS> so max_group + 1 was the dummy 
20170420 17:29:43< vultraz_iOS> ah, but it checks the array *value*
20170420 17:30:10< vultraz_iOS> but it doesn;'t check +1..
20170420 17:30:16< vultraz_iOS> the hell is the code going on about
20170420 17:30:22< mattsc> vultraz_iOS, JyrkiVesterinen, celticminstrel: just here for a few seconds to say that one extra set of braces around everything works.
20170420 17:30:29< vultraz_iOS> \o/
20170420 17:30:33< mattsc> Also needed in l.1206, smae file.
20170420 17:30:39< vultraz_iOS> curses!
20170420 17:31:06< mattsc> Either doing that or turning off the warning is fine with me, I’ll get back to it tonight or tomorrow; right now RL is calling ...
20170420 17:31:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit]
20170420 17:33:26< vultraz_iOS> yeah, i think this weird code is unnecessary without the buffer..
20170420 17:33:29< vultraz_iOS> I *think*
20170420 17:34:27< celticminstrel> Don't change something on a wild theory.
20170420 17:35:48< vultraz_iOS> ah, wait, i think I understand
20170420 17:38:21-!- atarocch [~atarocch@31.157.9.167] has joined #wesnoth-dev
20170420 17:40:43< vultraz_iOS> so, if the layer was *above* the group, decrease the index of the layer *group* until the specified layer is ... greater than or equal the group 
20170420 17:41:55< irker824> wesnoth: ln-zookeeper wesnoth:master 2db50851b4b8 / data/campaigns/Under_the_Burning_Suns/ (3 files in 2 dirs): UtBS: Color-shift the blue steel of loyalist units, for a unique look https://github.com/wesnoth/wesnoth/commit/2db50851b4b8af05d760a52a0a79ab7ba000d5b8
20170420 17:47:25-!- mjs-de [~mjs-de@x4db5cab9.dyn.telefonica.de] has joined #wesnoth-dev
20170420 17:52:13< gfgtdf> vultraz_iOS: uhm what the point of the tod_manager refactor? the to managert is clearly a partof the normal gamestate so it shodul also be a  memeber of gamestate class
20170420 17:53:46< vultraz_iOS> Ehh...
20170420 17:54:37< vultraz_iOS> my goal was to reduce the amount of management going on
20170420 17:55:07< vultraz_iOS> Esp having resources::tod_manager and all those getters in play_controller and such
20170420 17:55:48< gfgtdf> vultraz_iOS: how? managing a globla is usualy more work toi maintina & understand than well tree structore
20170420 17:56:18< gfgtdf> vultraz_iOS: i man your commit does make game_state class more conplicated
20170420 17:56:49< vultraz_iOS> Well tbh I'd like to refactor stuff so there's a common base class that both the editor and the game can initialize
20170420 17:57:01< vultraz_iOS> And the tod manager and units and other stuff can go in there
20170420 17:57:18< vultraz_iOS> I suppose that might be better
20170420 17:58:08< vultraz_iOS> Bc it just makes it confusing when you have the editor duplicating stuff from the game_state
20170420 17:58:17< vultraz_iOS> Idk how would you do it
20170420 17:59:42< irker824> wesnoth: ln-zookeeper wesnoth:master 8b926cc3eba4 / data/campaigns/Under_the_Burning_Suns/ (_main.cfg images/units/quenoth/kaleh.png images/units/quenoth/nym.png): UtBS: New sprites for Kaleh and Nym by Kwandulin https://github.com/wesnoth/wesnoth/commit/8b926cc3eba40bd6fa2e123e4834a9d92b1023d0
20170420 18:00:06< gfgtdf> hmm what exactly are you trying to fix?
20170420 18:00:35-!- atarocch [~atarocch@31.157.9.167] has quit [Ping timeout: 255 seconds]
20170420 18:01:31< vultraz_iOS> Trying to reduce duplication between the editor snd the main game.
20170420 18:02:19< Kwandulin> zookeeper: What's happening to the Dwarvish Fighter's shieldbash?
20170420 18:02:27< vultraz_iOS> I think bc I noticed that I think I made the tod coloring work incorrectly in the editor
20170420 18:02:35< zookeeper> Kwandulin, to the what?
20170420 18:02:47< vultraz_iOS> I.e. I utilized the code path that's supposed to be for temporarily recoloring
20170420 18:02:54< Kwandulin> I still think that would be cool for a victory anim or somewhat
20170420 18:03:05< vultraz_iOS> Bc for some reason just setting the image tints didn't work anymore
20170420 18:03:10< zookeeper> oh, that. i thought you meant an attack or something.
20170420 18:03:19< vultraz_iOS> And update_tod in display:: requires a tod manager
20170420 18:03:36< celticminstrel> "shield bash" does imply an attack after all
20170420 18:03:47< vultraz_iOS> Or something
20170420 18:04:03< vultraz_iOS> At least, it's implemented static in the class
20170420 18:04:20< vultraz_iOS> So I figured I might as well unify the code paths Bc right now it's a mess
20170420 18:05:10< zookeeper> Kwandulin, where was it again?
20170420 18:05:11< Kwandulin> If there's a chance to get that one in, I'll PM Crow_T to post those. He improved it quite a bit
20170420 18:05:20< Kwandulin> http://forum.wesnoth.org/viewtopic.php?p=608968#p608968
20170420 18:05:28< gfgtdf> vultraz_iOS: no its noit a mess, display::get_time_of_day is staic beaus eit always returns dummy incalce, 
20170420 18:05:37< gfgtdf> vultraz_iOS: i also wonder whterh its every called actually
20170420 18:05:49< gfgtdf> vultraz_iOS: afaik both editor_display anf game_display override it
20170420 18:06:16< vultraz_iOS> No I meant the entire editor/game state divide is a mess
20170420 18:06:45< zookeeper> Kwandulin, i guess it's okay?
20170420 18:07:30< Kwandulin> Yeah, overall it is
20170420 18:07:37< celticminstrel> Does your refactor really make it less messy though?
20170420 18:07:52< gfgtdf> well i don't know the editor code, but iceiceice did youte some wokr on it bfore he left and it made it quite easier to understand then before
20170420 18:08:05< gfgtdf> onj the gamestate code i mean
20170420 18:10:19< vultraz_iOS> I still find the game state code very hard to understand
20170420 18:10:47< vultraz_iOS> Bc there's game state, game display, display, play controller, display context,
20170420 18:10:58< vultraz_iOS> Filter context too
20170420 18:11:22< gfgtdf> i have to say that i dont really know the (game_)display.cpp code and ididn't includ it when i meant gamestate
20170420 18:17:21< gfgtdf> wait did tod coloring inthe estiro actuall ever work ?
20170420 18:17:48< gfgtdf> in the editor*
20170420 18:21:05< vultraz_iOS> gfgtdf: yes
20170420 18:21:24< vultraz_iOS> broke sometime in 1.13
20170420 18:25:05< vultraz_iOS> gfgtdf: i don't think the original codepath was the right way tog o, though...
20170420 18:25:08< vultraz_iOS> or maybe it was
20170420 18:25:15< vultraz_iOS> it just used the image tint cache
20170420 18:25:25< gfgtdf> the coling codepath in 11.2 you mean ?
20170420 18:25:51< vultraz_iOS> 1.12 yes
20170420 18:30:54< gfgtdf> hmm ok how 1.12 worked was asically tcustom_tod::update_tod_display calling image::set_color_adjustment ...
20170420 18:31:36< vultraz_iOS> yes
20170420 18:31:45< vultraz_iOS> that remained unchanged until a few days ago
20170420 18:32:11< gfgtdf> hm ye this wasn't isn't how it shodul be think, spceialyl sindiering that we also support local tods
20170420 18:32:32< gfgtdf> so this woudl man that local tod are handes in the display.cpp and the global tod in image.cpp ....
20170420 18:32:38< gfgtdf> mean*
20170420 18:33:16< Kwandulin> zookeeper: managed to extract the frames+settings from Crow_T's gif: https://www.dropbox.com/s/uxw8usqsslrqq5l/fighter-taunt-crowt.zip?dl=0
20170420 18:33:37< irker824> wesnoth: Charles Dang wesnoth:master 30340aaedbaa / src/ (display.cpp display.hpp): Display: removed dummy drawing layer https://github.com/wesnoth/wesnoth/commit/30340aaedbaaa14de0f3bac2ac88345f575e0485
20170420 18:33:40< irker824> wesnoth: Charles Dang wesnoth:master 3252348dd698 / src/display.cpp: Attempt to fix build on XCode https://github.com/wesnoth/wesnoth/commit/3252348dd698e213ccf5f04b8173c097774c58c7
20170420 18:37:06< vultraz_iOS> no idea why the double braces are needed
20170420 18:38:19< gfgtdf> vultraz_iOS: "sizing the vector" here mens probably somethign like using it as a counter for the numenr of enum values
20170420 18:38:25< vultraz_iOS> gfgtdf: maybe editor_display needs to implement get_time_of_day
20170420 18:38:48< vultraz_iOS> and then call update_tod() on the editor display....
20170420 18:38:57< vultraz_iOS> but that doesn't solve the problem for the sliders
20170420 18:39:10< vultraz_iOS> in custom ToD
20170420 18:39:24< gfgtdf> vultraz_iOS: with LAYER_LAST_LAYER cou coud've wrote const std::array<display::drawing_layer, LAYER_LAST_LAYER > instead of std::array<display::drawing_layer, 4> to have less 'magic numbers'
20170420 18:39:53< vultraz_iOS> gfgtdf: no, since that would make it LAYER_LAST_LAYER's long, not just 4
20170420 18:39:58< JyrkiVesterinen> vultraz_iOS: As celmin already mentioned, double braces are needed for the array inside the std::array.
20170420 18:40:27< JyrkiVesterinen> The code constructs std::array<std::string, 6> from a const char*[].
20170420 18:40:36< gfgtdf> vultraz_iOS: hmm right the diff colapes lines to that it lookes liek that anum had onyl 6 values
20170420 18:40:58< gfgtdf> vultraz_iOS: but usually "sizing the vector" means soemthign like that
20170420 18:41:00< JyrkiVesterinen> You need the inner braces to construct the C array that is passed to the std::array constructor.
20170420 18:41:05< celticminstrel> vultraz_iOS: It's basically because std::array is "template<typename T, size_t n> struct array { T arr_[n]; };"
20170420 18:41:17< celticminstrel> Plus some functions.
20170420 18:41:38< gfgtdf> vultraz_iOS: what exactly is the problms with sliders there ?
20170420 18:41:39< zookeeper> Kwandulin, mmkay, i'll take a look in an hour or so
20170420 18:42:26< vultraz_iOS> gfgtdf: well, the sliders just tint the display a specific color..they don't use the manager... though i guess that's desired?
20170420 18:43:12< gfgtdf> vultraz_iOS: hmm i'd guess thats desires, aikain thats a just normal color selector dialog ?
20170420 18:43:12< vultraz_iOS> celticminstrel: looks like that might have changed in c++14?
20170420 18:43:47< celticminstrel> Might've.
20170420 18:44:31< vultraz_iOS> http://www.open-std.org/JTC1/SC22/WG21/docs/papers/2013/n3526.html
20170420 18:47:17< vultraz_iOS> gfgtdf: so, something i don't particularly like... for example, game_display inherits from display and specializes get_time_of_day, but it doesn't own the tod manager.. it only owns a pointer and the real ToD manager is passed to its ctor from game_data
20170420 18:47:34< vultraz_iOS> gfgtdf: if i want to do the same thing for the editor I'd have to do the same thing
20170420 18:48:25< vultraz_iOS> though I'd need to find a way to pass the tod_manager from the map_context to editor_display
20170420 18:48:25-!- mjs-de [~mjs-de@x4db5cab9.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170420 18:48:32-!- mjs-de [~mjs-de@x4db6e2df.dyn.telefonica.de] has joined #wesnoth-dev
20170420 18:48:33< gfgtdf> vultraz_iOS: well yes if both editor and game_controller have te same beahvuour cou can just put in the display.cpp class
20170420 18:48:58< gfgtdf> i mena all the display.cpp class is a common subclass for game/editor_disply classes
20170420 18:49:09< gfgtdf> s/game_controller/game_display
20170420 18:49:10< vultraz_iOS> yes
20170420 18:49:22< vultraz_iOS> but then it would mean the tod manager ptr is owned by display...
20170420 18:49:40< gfgtdf> yes
20170420 18:50:53< gfgtdf> wait i think you'D catually put it inthe display_context  class
20170420 18:51:05< gfgtdf> actually*
20170420 18:51:15< vultraz_iOS> hmmm
20170420 18:51:17< gfgtdf> and thne use dc->get_tod_manage or similar
20170420 18:51:17< vultraz_iOS> yes that might be better
20170420 18:51:41< gfgtdf> at lest that how it work for the uni_mpa pointer
20170420 18:51:47< gfgtdf> unitmap*
20170420 18:51:56< vultraz_iOS> i guess the display_context would jist have a ptr not own the mansger right?
20170420 18:52:26< gfgtdf> that depends, the display_context is just an interface
20170420 18:53:33< gfgtdf> hmm wait it seems like in the gamesate case the display_context IS the game_board
20170420 18:57:59< gfgtdf> hm i wonder what the filter_context interface does, doe we ever have a nother filter_contextthat the gamestate 
20170420 19:01:15< celticminstrel> Was it filter_context that map_context extends?
20170420 19:01:22< celticminstrel> Or was that display_context?
20170420 19:01:45< vultraz_iOS> Now you see why I say this is a mess
20170420 19:03:16< vultraz_iOS> celticminstrel: latter
20170420 19:06:02< gfgtdf> i'm tempoted to remove filter_contet in favour of reuing resources::: ..
20170420 19:07:34< vultraz_iOS> I thought we wanted to remove resources::
20170420 19:10:49< celticminstrel> Yes.
20170420 19:28:03-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 19:28:23-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170420 19:28:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170420 19:30:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170420 19:40:16-!- JyrkiVesterinen [~JyrkiVest@89-166-121-0.bb.dnainternet.fi] has quit [Quit: .]
20170420 19:53:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 19:57:36-!- mjs-de [~mjs-de@x4db6e2df.dyn.telefonica.de] has quit [Remote host closed the connection]
20170420 20:00:17-!- Shiki [~Shiki@p5485620E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170420 20:08:16< vultraz_iOS> celticminstrel: can probably do that by providing a single base class that encapsulates the stuff resources accesses and use it for both the editor and game
20170420 20:08:42< celticminstrel> Uh...
20170420 20:08:46< vultraz_iOS> Right now one of their functions is providing a unified access point for data that could be different in either the editor or game
20170420 20:09:07< celticminstrel> Well certainly some of the stuff could be pushed into a single base class.
20170420 20:09:24< celticminstrel> I don't know if all of resources makes sense like that.
20170420 20:09:41< vultraz_iOS> Some no
20170420 20:10:44< vultraz_iOS> I guess I'll abandon my tod manager commit and work in such a base class instead
20170420 20:11:37< vultraz_iOS> Problem is I'm not sure where to begin
20170420 20:11:49< vultraz_iOS> gfgtdf: do you have any suggestions
20170420 20:13:02< gfgtdf> hmm ye i think having a common subclass does make sense, ideall if woudl replace one of filter_context or display_context 
20170420 20:13:35< vultraz_iOS> Probably replace filter context
20170420 20:23:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170420 20:37:29-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 20:41:40< gfgtdf> the travis rng test seems to fail
20170420 20:42:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170420 20:42:34-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 20:42:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 20:50:18< gfgtdf> vultraz_iOS: https://github.com/wesnoth/wesnoth/commit/42b309165a3c8d9980d1b698256e04db2838a5d9 broke mt_rng::get_random_calls() 
20170420 20:50:31< vultraz_iOS> but why :/
20170420 20:51:00< gfgtdf> vultraz_iOS: becase get_next_random did more thna just calling mt_()
20170420 20:51:05< gfgtdf> than*
20170420 20:51:29< vultraz_iOS> mt_?
20170420 20:51:52< gfgtdf> yes
20170420 20:52:01< vultraz_iOS> im confused
20170420 20:52:56< vultraz_iOS> the private impl of discard was supposed to be equivalent to mt_.discard by the boost docs
20170420 20:52:57< gfgtdf> our code changes ehaviour, look at what mt_rng::discard did, and what mt_.discard does
20170420 20:53:10< gfgtdf> your*
20170420 20:54:09< vultraz_iOS> oh 
20170420 20:54:21< vultraz_iOS> it also bumps random_calls_
20170420 20:54:22< vultraz_iOS> ok
20170420 20:54:37< vultraz_iOS> ill revert
20170420 20:56:07< gfgtdf> vultraz_iOS: you codul also just add random_calls_ += call_count: after mt_.disacrd()
20170420 20:56:30< vultraz_iOS> hmm
20170420 20:56:30< vultraz_iOS> ok
20170420 21:05:41< irker824> wesnoth: Charles Dang wesnoth:master 43edb92537e5 / src/mt_rng.cpp: Fixup 42b309165a3c https://github.com/wesnoth/wesnoth/commit/43edb92537e5708cf348e196aaf6ad20b87b39ee
20170420 21:05:44< irker824> wesnoth: Charles Dang wesnoth:master a1702d52e7f8 / src/ (15 files in 5 dirs): Merge rand_rng namespace with randomness https://github.com/wesnoth/wesnoth/commit/a1702d52e7f879a224522cdcc2231ee669b3645c
20170420 21:11:02-!- Shiki [~Shiki@p5485620E.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170420 21:21:46-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 21:23:07-!- Kwandulin [~Kwandulin@p200300760F6D80B36877D6CE172B1F72.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170420 21:35:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170420 21:36:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170420 21:39:21-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20170420 21:44:44-!- turupawn [~turupawn@179.49.119.217] has quit [Remote host closed the connection]
20170420 22:02:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170420 22:05:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 22:13:09< vultraz_iOS> looks like the mac build failed for taking too long?
20170420 22:13:20< vultraz_iOS> "The job exceeded the maximum time limit for jobs, and has been terminated."
20170420 22:13:21< vultraz_iOS> wonder why
20170420 22:14:01-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 22:14:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170420 22:31:49-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20170420 22:45:05< vultraz_iOS> gfgtdf: do you think it would make sense for display_context to own anything?
20170420 22:46:53< vultraz_iOS> such as the tod_manager or should it just bevirtual getters
20170420 22:46:55< gfgtdf> vultraz_iOS: hmm well currently you get things by vritual functions, replacing them with just pointers to those struct migth speedup things, not 100% sure though
20170420 22:47:55< vultraz_iOS> hmm
20170420 22:47:55-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Remote host closed the connection]
20170420 22:47:57< vultraz_iOS> well...
20170420 22:47:58< vultraz_iOS> maybe
20170420 22:48:09-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 22:48:27< vultraz_iOS> gfgtdf: i think first I'm going to move the virtual getters for the lua kernel, tod manager, and game data to display context
20170420 22:50:10< vultraz_iOS> though tbh none of those exactly make sense in the context of "display"
20170420 22:50:15< vultraz_iOS> except the ToD manager
20170420 22:50:17< vultraz_iOS> hmmm
20170420 22:51:36< vultraz_iOS> what, exactly, is the purpose of fc...
20170420 22:53:09< gfgtdf> to proive filters (unit /terrain filters) with data they need afaik
20170420 22:53:55< vultraz_iOS> yes, seems so..
20170420 22:54:03< vultraz_iOS> but everything is spread out so much
20170420 22:54:12< vultraz_iOS> having a hard time figuring out where even to start
20170420 22:54:18< gfgtdf> vultraz_iOS: one of the problems is that iirc , now that the edito can place units filters are also aplied for those units  in the editor
20170420 22:54:31< gfgtdf> so filters can no longer assume there is a running game
20170420 22:54:47< vultraz_iOS> right
20170420 22:55:43< vultraz_iOS> but what is "needed" for a running game?
20170420 22:55:51< vultraz_iOS> i'd think it should only be play_controller
20170420 23:01:33< vultraz_iOS> gfgtdf: ok... would it be reasonable for the editor to have a game_board?
20170420 23:02:32< vultraz_iOS> none of these godforsaken classes seem to have any distinct scope
20170420 23:03:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170420 23:03:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 23:04:33-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170420 23:06:49< vultraz_iOS> my head hurts just looking at this
20170420 23:08:00< vultraz_iOS> what the hell why is the editor creating new map contexts in a unique_ptr and then using release() to pull out the raw ptr to push it to a vector
20170420 23:08:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20170420 23:08:32< gfgtdf> vultraz_iOS: soudns liek the normal thing to do actually
20170420 23:08:46< vultraz_iOS> why not just use the ptr in the vector
20170420 23:09:55< gfgtdf> vultraz_iOS:  the unique_ptr is a pointer that own the pointed structore, release() transfers ownership to a somethign else, altenateveley you codul use std::move
20170420 23:10:52< vultraz_iOS> i mean there's no reason to use vector<map_context*> here instead of vector<unique_ptr<map_context>>
20170420 23:11:21< gfgtdf> vultraz_iOS: hmm ye probably
20170420 23:11:58< gfgtdf> vultraz_iOS: you want to fix that ?
20170420 23:12:11< vultraz_iOS> yes
20170420 23:14:12< gfgtdf> vultraz_iOS: you probably want to change add_map_context take a unique_ptr<map_context> or a unique_ptr<map_context>&&
20170420 23:15:15< gfgtdf> vultraz_iOS: did you make progress on the bugtracker issue?
20170420 23:17:40-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170420 23:19:18-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170420 23:20:10< gfgtdf> vultraz_iOS: you see i really don't see how this bugtracke issue cna be solved
20170420 23:20:43< gfgtdf> vultraz_iOS: faik we have ~1 month left, and noone in your current dev team is really able to manage hosing a server
20170420 23:20:46< gfgtdf> afaik*
20170420 23:20:50< gfgtdf> in our*
20170420 23:22:09< gfgtdf> that means the active dev team.
20170420 23:31:25< vultraz_iOS> gfgtdf: i say we just use github
20170420 23:31:29< vultraz_iOS> and discard attachments
20170420 23:31:36< vultraz_iOS> we're only moving open bugs, I assume?
20170420 23:31:58-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170420 23:32:24< gfgtdf> vultraz_iOS: no we are moving all bugs, a lot of commits have onyl messages like "fig bug #12345" and they would not amke any ssense anym more of those bogs woudl accessible anymore.
20170420 23:32:33< gfgtdf> fix*
20170420 23:32:52< gfgtdf> s/not amke any ssense anym/not make any sense anymore 
20170420 23:32:52< vultraz_iOS> well then we'd need to add a description 
20170420 23:33:02< vultraz_iOS> to the new bugs as to what GNA bug those are 
20170420 23:33:19< vultraz_iOS> bc the GNA numbers are not contiguous 
20170420 23:34:00< gfgtdf> vultraz_iOS: ye i suppose so, i'd ay we just have an issue number 0 that is liek map old_id ->new_id.
20170420 23:34:19< vultraz_iOS> we'll need a script
20170420 23:34:21< vultraz_iOS> to do tha
20170420 23:34:25< vultraz_iOS> and i don't have the skills
20170420 23:35:52< gfgtdf> vultraz_iOS: but i think we really have some bug that won't make sense without their attachements, i mean ofc we dont need to keep savefiles that wont load anymore in newest wesnoth version, but specially for all ui issues those images do mkae sense,
20170420 23:37:07< gfgtdf> vultraz_iOS: also we have matthiaskrgrs memleak/crash bugs that also have all their informationj inthe stacktraces in the attachement
20170420 23:37:08< gfgtdf> s
20170420 23:37:20< vultraz_iOS> but those are fixed
20170420 23:37:47-!- RatArmy [~ratarmy@om126229088058.12.openmobile.ne.jp] has joined #wesnoth-dev
20170420 23:41:06< vultraz_iOS> and the logs rapidly become useless as the codebase changes
20170420 23:47:56< gfgtdf> hmm
--- Log closed Fri Apr 21 00:00:53 2017