--- Log opened Sat Apr 22 00:00:06 2017
20170422 00:00:12< celticminstrel> Or rather, if it's still updated.
20170422 00:00:26< celticminstrel> I never used it myself.
20170422 00:00:41< vultraz_iOS> did we drop 10.7 support?
20170422 00:00:53< celticminstrel> AFAIK we didn't..
20170422 00:01:04< celticminstrel> But 1.13.7 doesn't fully run on 10.7 already.
20170422 00:01:10< vultraz_iOS> oh?
20170422 00:01:18< celticminstrel> Specifically, the file dialog crashes.
20170422 00:01:30< celticminstrel> I suspect this is a library incompatibility issue or something, though...
20170422 00:01:41< vultraz_iOS> ok, let's drop it
20170422 00:02:20< celticminstrel> Which may mean I can't do Mac development on this computer ever again. :P
20170422 00:02:32 * vultraz_iOS sighs and repeats the company offer
20170422 00:03:17 * celticminstrel rejects it as usual. :P
20170422 00:03:34< vultraz_iOS> ;_;
20170422 00:03:42< Aginor> macs in the cloud is a thing
20170422 00:03:50< Aginor> for development and testing
20170422 00:03:51< celticminstrel> Sudden Aginor! :O
20170422 00:04:07< celticminstrel> We do have a Mac Travis build, though that's not exactly sufficient for this sort of thing.
20170422 00:04:11< vultraz_iOS> he must stalk us 
20170422 00:05:36< Aginor> no, I booted the computer at home for the first time in a week :D
20170422 00:05:46< Aginor> and checked up on all of my IRC channels
20170422 00:06:03< Aginor> I'll be disappearing soon for a brunch though
20170422 00:06:15< celticminstrel> Fun!
20170422 00:06:33< Aginor> http://www.macincloud.com/
20170422 00:06:38< Aginor> I think that's pretty much it
20170422 00:07:25< Aginor> there seems to be a few others as well
20170422 00:07:47< Aginor> https://xcloud.me/ too
20170422 00:11:25< Aginor> and now I disappear
20170422 00:11:30< Aginor> I'll probably be back later
20170422 00:16:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170422 00:26:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170422 00:26:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170422 00:38:47-!- RatArmy_ [~ratarmy@om126211112080.13.openmobile.ne.jp] has joined #wesnoth-dev
20170422 00:56:09-!- RatArmy_ [~ratarmy@om126211112080.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 01:16:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5014:1d16:c496:c905] has joined #wesnoth-dev
20170422 01:19:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170422 01:20:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170422 01:21:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5014:1d16:c496:c905] has quit [Ping timeout: 258 seconds]
20170422 01:23:47< celticminstrel> vultraz_iOS: Looks like the function that was causing those unused variable warnings is never actually called. Should I just delete it?
20170422 01:30:10-!- gfgtdf [~chatzilla@x4e32b333.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170422 01:41:28< celticminstrel> I guess he probably won't be around until tomorrow then, so I guess I'll delete it.
20170422 01:41:43< irker216> wesnoth: Celtic Minstrel wesnoth:master 2b7b1b36d847 / src/editor/palette/ (5 files): Editor palettes: Remove an unused function https://github.com/wesnoth/wesnoth/commit/2b7b1b36d847e56eadb681287ec5483a51170fd2
20170422 02:01:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170422 02:12:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170422 02:12:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170422 02:13:09< celticminstrel> Uhhh... is it just my campaign or is backstab broken?
20170422 02:17:21< celticminstrel> Hmmm... could it be that backstab loses its effect when you load a saved game...?
20170422 02:17:56< celticminstrel> Looking at my unit, its backstab definition contains adjacent="" instead of adjacent="$other_unit.facing"
20170422 02:18:10< celticminstrel> So I'm guessing the config gets parsed at some point that it shouldn't be.
20170422 02:18:33< celticminstrel> This should probably be a blocker for 1.13.8...
20170422 02:18:45< celticminstrel> Especially if it affects core units.
20170422 02:24:01< celticminstrel> Does changing the resolution reset your prefs or something? :S
20170422 02:24:22< celticminstrel> Did vultraz_iOS maybe make the prefs dialog re-open when you change resolution?
20170422 02:27:32-!- RatArmy_ [~ratarmy@om126212252033.14.openmobile.ne.jp] has joined #wesnoth-dev
20170422 02:30:39< celticminstrel> Looks like there isn't any problem with a thief. Now that I think of it, the problem could be a lack of delayed_variable_substitution=yes in my [object].
20170422 02:35:00< vultraz_iOS> celticminstrel: what?
20170422 02:35:09< celticminstrel> Prefs.
20170422 02:35:13< vultraz_iOS> what about it
20170422 02:35:59< celticminstrel> I turned music off, changed the resolution to 800x600, and then exited the dialog. Then I exited the game. When I reopened it, the music played.
20170422 02:36:01< vultraz_iOS> celticminstrel: btw, thinking about it, i think i made an unnecessary change in the menu refactor..
20170422 02:36:06< celticminstrel> Oh?
20170422 02:36:28< vultraz_iOS> the output should be a config, yes, but as gfgtdf said the data you get from the menu is always an id.
20170422 02:36:30< celticminstrel> As for the backstab, I'm now pretty sure that that was a problem in my campaign. Just FTR.
20170422 02:36:40< celticminstrel> What are you saying?
20170422 02:36:43< vultraz_iOS> so I could use a vector of string for the id
20170422 02:36:48< vultraz_iOS> then generate an output config
20170422 02:36:49< celticminstrel> Hmm, sure.
20170422 02:36:55< vultraz_iOS> I think I'll do that
20170422 02:38:34< vultraz_iOS> esp since you got rid of the loops..
20170422 02:38:37< vultraz_iOS> though..
20170422 02:39:22< celticminstrel> I think perhaps there should be a loop in editor_controller instead of checking the first ID, though.
20170422 02:39:39< vultraz_iOS> hm
20170422 02:40:08< celticminstrel> Of course it can't be a range-for loop though.
20170422 02:40:31< celticminstrel> Would need to be an index-based loop unless you changed the expansions to take an iterator instead of an index.
20170422 02:40:49< celticminstrel> IIRC there was a loop just before that, right?
20170422 02:41:00< vultraz_iOS> yes
20170422 02:41:03< celticminstrel> That would be the place to transform from vector<string> to vector<config>
20170422 02:41:21< celticminstrel> In fact maybe you could even replace the loop with a std::transform call.
20170422 02:41:41< celticminstrel> Not sure what would be the equivalent place for in-game though,
20170422 02:42:38< celticminstrel> Oh right, I almost forgot, the editor can't actually support multiple generated groups in the same menu or a generated group not at the top of the menu, without further changes.
20170422 02:47:33< celticminstrel> Well, it's not like someone's going to customize the editor theme. I mean, is that even supported?
20170422 02:48:34< vultraz_iOS> no idea
20170422 02:48:38< vultraz_iOS> no point, really
20170422 02:51:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5014:1d16:c496:c905] has joined #wesnoth-dev
20170422 02:57:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170422 03:13:36< irker216> wesnoth: Charles Dang wesnoth:master 42cb55fa24ca / src/ (9 files in 4 dirs): Revert an unnecessary part of 7d2d100 https://github.com/wesnoth/wesnoth/commit/42cb55fa24ca79b43d3a5fc7f29841fce77eea34
20170422 03:13:38< vultraz_iOS> celticminstrel: ^
20170422 03:13:43< vultraz_iOS> gfgtdf too ^
20170422 03:14:45< celticminstrel> Ah right, it was a filtering loop, so obviously it can't be replaced with std::transform.
20170422 03:14:53< celticminstrel> Though I'm pretty sure there's something like std::filter too.
20170422 03:14:57< celticminstrel> Buuuut not important.
20170422 03:16:42-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:5014:1d16:c496:c905] has quit [Remote host closed the connection]
20170422 03:16:55< celticminstrel> Huh? You're still passing a vector<config> to show_menu in command_executor.cpp?
20170422 03:17:34< irker216> wesnoth: Charles Dang wesnoth:master 5aa7ba098cb8 / src/hotkey/command_executor.cpp: Fixup 42cb55f (take string by reference) https://github.com/wesnoth/wesnoth/commit/5aa7ba098cb8d761262d3799f7cd2bce04fd4fbe
20170422 03:17:44< vultraz_iOS> celticminstrel: that's takes the parsed data
20170422 03:17:58< vultraz_iOS> in fact, I'm thinking of renaming that function since it's confusing
20170422 03:17:58< celticminstrel> In theme.cpp, either merge those lines or indent the ones beginning with +
20170422 03:18:18< celticminstrel> ...there's also a random extra space on line 563.
20170422 03:18:20-!- RatArmy_ [~ratarmy@om126212252033.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 03:19:15< celticminstrel> You think it's confusing for two functions that do essentially the same thing to have the same name?
20170422 03:19:28< celticminstrel> One calls the other generally, right?
20170422 03:20:17< vultraz_iOS> when they're in two different classes, yes
20170422 03:20:47< celticminstrel> That's exactly why I think it shouldn't be confusing...
20170422 03:22:38< vultraz_iOS> show_menu is virtual in controller_base
20170422 03:22:58< vultraz_iOS> editor_controller inherits from that
20170422 03:23:07< vultraz_iOS> both call command_executor::show_menu
20170422 03:23:49< vultraz_iOS> the former two take raw id data
20170422 03:23:56< vultraz_iOS> the latter takes parsed data
20170422 03:25:01< vultraz_iOS> actually, perhaps the controller_base show_menu should be called something else
20170422 03:28:26< celticminstrel> I don't see why you'd rename either.
20170422 03:29:57< vultraz_iOS> well, then just keep in mind that command_executor::show_menu takes parsed - aka, config - output
20170422 03:30:06-!- RatArmy_ [~ratarmy@om126212252033.14.openmobile.ne.jp] has joined #wesnoth-dev
20170422 03:53:55< vultraz_iOS> celticminstrel: as for the prefs thing I'm not sure I understand  the issue
20170422 03:54:02< vultraz_iOS> Are you saying the dialogs fields are not saved?
20170422 03:54:15< vultraz_iOS> On reize?
20170422 03:54:17< vultraz_iOS> Resize
20170422 03:56:05< Aginor> celticminstrel: xor crypto is actually really strong if you have a good amount of true randomness and use as the key
20170422 03:56:32< celticminstrel> Huh.
20170422 03:56:35< Aginor> celticminstrel: it's the basis of one-time-pads, which if done correctly, are unbreakable
20170422 03:56:53< celticminstrel> Still, that means you need to store/transmit the key somewhere in order to decrypt it.
20170422 03:57:07< celticminstrel> I knew about one-time pads but didn't know they were based on XOR.
20170422 03:57:58< celticminstrel> vultraz_iOS: Something like that seems to be the issue, yes.
20170422 03:58:12< Aginor> celticminstrel: yes
20170422 03:58:23< Aginor> celticminstrel: for all crypto you need a key sooner or later
20170422 03:58:34< vultraz_iOS> odd..
20170422 03:59:34< Aginor> ideally you can use a TPM module to store the secret in an irritrievable fashion and have that deal with the sensitive operations
20170422 03:59:43< Aginor> but for wesnoth, I don't think that's very practical
20170422 04:04:00-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has joined #wesnoth-dev
20170422 04:04:59< celticminstrel> Probably not, yeah...
20170422 04:08:40-!- RatArmy_ [~ratarmy@om126212252033.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 04:24:53< Aginor> ok, I've written a somewhat considered response to your PR :)
20170422 04:26:42< celticminstrel> Thanks. :)
20170422 04:27:10< Aginor> https://github.com/weidai11/cryptopp by the way :)
20170422 04:27:46< celticminstrel> Ooh nice.
20170422 04:27:57< celticminstrel> That might be better than depending on something like OpenSSL, huh?
20170422 04:28:00< Aginor> I don't know about the quality of it
20170422 04:28:05< celticminstrel> Ah.
20170422 04:28:07< Aginor> different use cases
20170422 04:28:26< Aginor> openssl provides TLS primarily
20170422 04:28:50< Aginor> that you get crypto and stuff is a happy side effect :)
20170422 04:29:03< Aginor> that library just does crypto
20170422 04:29:12< celticminstrel> OpenSSL is also a C library.
20170422 04:29:41< Aginor> I'd still use openssl for my TLS support over a less vetted library
20170422 04:32:12< celticminstrel> Sure.
20170422 04:33:32< Aginor> now, the problem with starting to pull in this kind of libraries as dependencies is that we also need to be aware of any security problems in the libraries themselves as we ship them as dependencies
20170422 04:33:56< Aginor> I suspect that's not something anyone has cared about to date for any of our dependant libraries
20170422 04:34:57< Aginor> but if we want to make a proper comittment to security, we need to ensure that we provide new releases with updated dependencies when there's a security issue in the libraries wesnoth depends upon
20170422 04:35:12< celticminstrel> That makes sense.
20170422 04:35:31< celticminstrel> If cryptopp is included as a dll it could even be as simple as just substituting the dll.
20170422 04:36:09< Aginor> ideally we'd rely on dynamic linking (done right, or that's yet another security problem) to make that easier, but if it's the wesnoth project shipping those libraries, it's also up to the wesnoth project to ensure that the latest releases are secure
20170422 04:37:49< Aginor> I think I'm done monologuing now :)
20170422 04:39:25 * celticminstrel had been considering whether it'd be possible to include only the algorithm we actually want to use.
20170422 04:39:50< Aginor> give me a moment, there's better things for that
20170422 04:40:13< Aginor> if I can find it again
20170422 04:41:22< Aginor> https://github.com/libtom/libtomcrypt
20170422 04:41:34< Aginor> those are pretty self contained if I remember correctly
20170422 04:44:56< celticminstrel> I see. Well, it's a C library which is a bit annoying, but on the other hand it's nice if it's modular...
20170422 04:54:18< Aginor> yeah
20170422 04:54:33< Aginor> and as gregorylundberg wrote, we do not want to implement crypto ourselves
20170422 04:54:47< Aginor> or pick up someone elses home-implemented library
20170422 04:54:48< celticminstrel> Obviously.
20170422 04:55:09< Aginor> we're better off picking up a well known, vetted, library
20170422 05:17:43-!- Kwandulin [~Kwandulin@p200300760F6D8096B181ECDE39D95415.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170422 05:21:50-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has quit [Quit: Rebooting]
20170422 05:23:54-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has joined #wesnoth-dev
20170422 05:41:10-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170422 05:49:35-!- atarocch [~atarocch@2.43.123.94] has joined #wesnoth-dev
20170422 05:53:23-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170422 06:05:47< irker216> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 6b6bf0ff8c38 / / (3 files in 2 dirs): Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/6b6bf0ff8c38602c510286e4ae55000ae7e62f3b
20170422 06:05:49< irker216> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 8e48af1ca1b6 / / (4 files in 3 dirs): Properly port [scroll] to Lua https://github.com/wesnoth/wesnoth/commit/8e48af1ca1b6a1902dbc673cfb63ef68401c3a8e
20170422 06:05:51< irker216> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 1cdf0ed65e7a / / (14 files in 6 dirs): Properly port [music] to Lua https://github.com/wesnoth/wesnoth/commit/1cdf0ed65e7a210a96923fd752d6f5e7b3ba300d
20170422 06:05:53< irker216> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f1e4ad24a003 / src/scripting/ (game_lua_kernel.cpp lua_common.hpp lua_unit.cpp): Lua: Add float mutator macros and some fixups/cleanup to other mutator/accessor  https://github.com/wesnoth/wesnoth/commit/f1e4ad24a003238d67bebfa7c9d9d568a8eb5c73
20170422 06:05:55< irker216> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5e3d4b0dc629 / / (7 files in 5 dirs): Port [volume] to Lua https://github.com/wesnoth/wesnoth/commit/5e3d4b0dc629fdf2ca14b8509f127df85eac500d
20170422 06:12:12< celticminstrel> zookeeper, whenever you're around, I have two questions for you regarding [kill].
20170422 06:12:13< celticminstrel> 1) Should it support [primary_attack] and [secondary_attack] just like [animate_unit] does?
20170422 06:12:14< celticminstrel> 2) What should it do if there's a secondary unit specified which has a victory animation? Should it a) always play it (if animate=yes), b) never play it, c) only play it if an additional flag is specfied (eg animate_victory=yes)?
20170422 06:12:18-!- celticminstrel is now known as celmin|sleep
20170422 06:12:35< celmin|sleep> (Of course, if anyone else has opinions on it, they're welcome to give their own answers too.)
20170422 06:47:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170422 07:09:28-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170422 07:12:40-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170422 07:21:03< zookeeper> celmin|sleep, sure, it could have [primary_attack] and [secondary_attack], so one could affect which death/victory animation gets played if there's multiple for different damage types, etc.
20170422 07:21:50< zookeeper> and as for victory anims, i'd go with a)
20170422 07:22:52-!- atarocch [~atarocch@2.43.123.94] has quit [Remote host closed the connection]
20170422 07:24:24< zookeeper> and i hope that if you're planning on not porting some recursion prevention code you'll track down the commit which introduced it and find out what the rationale was
20170422 07:26:02< zookeeper> what happens if a unit is [kill]ed in its own die event? do you get an infinite loop? maybe it's for preventing that, or some other similar situation. i don't know, but you'll need to :p
20170422 07:50:37-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 08:13:23-!- Kwandulin [~Kwandulin@p200300760F6D8096B181ECDE39D95415.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170422 08:13:24-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 08:13:32-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 08:18:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Ping timeout: 258 seconds]
20170422 08:18:32-!- Kwandulin [~Kwandulin@p200300760F6D8096B181ECDE39D95415.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170422 08:26:57-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 08:41:14-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 08:45:40-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 08:50:50-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has quit [Quit: .]
20170422 08:50:51-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 08:52:56-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 08:52:56-!- horrowind1 is now known as horrowind
20170422 08:55:49-!- Kwandulin [~Kwandulin@p200300760F6D8096B181ECDE39D95415.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170422 09:06:55-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 09:09:10-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170422 09:09:10-!- horrowind1 is now known as horrowind
20170422 09:14:20-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 09:15:10-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 09:19:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Ping timeout: 255 seconds]
20170422 09:20:35-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 09:22:59-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 09:22:59-!- horrowind1 is now known as horrowind
20170422 09:32:32-!- Kwandulin [~Kwandulin@p200300760F6D809678C543E7E81D5F4B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170422 09:35:49-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 09:38:01-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170422 09:38:02-!- horrowind1 is now known as horrowind
20170422 09:38:02-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 09:41:46-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 09:47:47-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 09:50:30-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170422 09:50:30-!- horrowind1 is now known as horrowind
20170422 09:58:52-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 09:59:56-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 10:01:57-!- irker216 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170422 10:02:04-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 10:02:04-!- horrowind1 is now known as horrowind
20170422 10:05:49-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 10:11:06-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170422 10:11:47-!- horrowind1 [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 10:14:33-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170422 10:14:33-!- horrowind1 is now known as horrowind
20170422 10:35:09-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 10:48:57-!- horrowind [~Thunderbi@x4e33f6b6.dyn.telefonica.de] has quit [Quit: horrowind]
20170422 10:57:24-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 11:34:01-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has joined #wesnoth-dev
20170422 11:38:57-!- Kwandulin [~Kwandulin@p200300760F6D809678C543E7E81D5F4B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170422 12:00:18-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170422 12:02:11-!- gfgtdf [~chatzilla@x4e32b7e5.dyn.telefonica.de] has joined #wesnoth-dev
20170422 12:04:37< gfgtdf> i'm thinking about optimising lua unit getter/setter methods to do less string comparisions, so whta i want to do is to replace all those return_xxx strcmp with a big switch satement,  and then use a map string -> int/enum where the later is the index to the switch satement.
20170422 12:05:26-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 260 seconds]
20170422 12:05:32< gfgtdf> bug what i'm unsure about is what is teh bast type of map i could: 1) use unordered map 2) use a lua table and then use lua_gettable
20170422 12:06:02-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170422 12:13:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170422 12:21:05-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170422 12:24:02-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has joined #wesnoth-dev
20170422 12:24:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170422 13:04:39-!- Kwandulin [~Kwandulin@p200300760F6D80926C4D7EE320B6CB98.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170422 13:09:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170422 13:09:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170422 13:17:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 13:22:09-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Ping timeout: 260 seconds]
20170422 13:30:19-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has quit [Remote host closed the connection]
20170422 13:57:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170422 14:11:18-!- Appleman1234 [~Appleman1@pl33323.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170422 14:21:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170422 14:56:30-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170422 15:20:15-!- Kwandulin [~Kwandulin@p200300760F6D80926C4D7EE320B6CB98.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170422 15:27:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170422 15:49:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170422 15:50:00-!- Kwandulin [~Kwandulin@p200300760F6D80926C4D7EE320B6CB98.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170422 16:00:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 16:00:58< vultraz_iOS> gfgtdf: did you see i reduced the scope of the vector-of-config stuff?
20170422 16:01:27< gfgtdf> vultraz_iOS: i saw the commit in the log but didnt look at it yet
20170422 16:01:59-!- irker102 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170422 16:01:59< irker102> wesnoth: Charles Dang wesnoth:master ad871581ef1f / src/hotkey/hotkey_handler.cpp: Move instead of copy when trimming menu lists https://github.com/wesnoth/wesnoth/commit/ad871581ef1fa989a613e2e5f8d39df71a3ac10d
20170422 16:02:00< irker102> wesnoth: Charles Dang wesnoth:master 7790442b0c61 / src/hotkey/hotkey_handler.cpp: Cleaned up menu-related code in play_controller::hotkey_handler https://github.com/wesnoth/wesnoth/commit/7790442b0c6116401b313e6cd35b658edc59bb97
20170422 16:02:01< gfgtdf> vultraz_iOS: somehow i cannot connect ot trvis ci webpage,
20170422 16:02:51< gfgtdf> vultraz_iOS: what exactyl does trim_items do?
20170422 16:03:22< gfgtdf> vultraz_iOS: ok i see
20170422 16:03:28< vultraz_iOS> gfgtdf: like when you have the list of autosaves to go back to it keeps only a few entries
20170422 16:03:37< gfgtdf> vultraz_iOS: at foirst it looked liek we are doingmanual text ellisation there
20170422 16:06:23< vultraz_iOS> gfgtdf: so earlier i reverted the vector back to a vector of strings inside the theme menu objects since those will only have id keys
20170422 16:06:51< vultraz_iOS> gfgtdf: so the functions that take the raw id list takes a vector of strings and will construct a vector of config with the output
20170422 16:07:57< vultraz_iOS> gfgtdf: so it removes the configs that only have IDs
20170422 16:11:45< gfgtdf> ok
20170422 16:18:42< irker102> wesnoth: Charles Dang wesnoth:master b6639bf27084 / src/ (6 files in 6 dirs): Use emplace_back() instead of push_back("") https://github.com/wesnoth/wesnoth/commit/b6639bf27084d8fdaec4268feb456e10f2461c7e
20170422 16:19:13< JyrkiVesterinen> IMO, push_back("") is more clear...
20170422 16:23:48< celmin|sleep> I don't get what 7790442b0c61 is doing...
20170422 16:29:45< irker102> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting dae05d10a7fd / data/lua/wml-tags.lua: [kill] fixups https://github.com/wesnoth/wesnoth/commit/dae05d10a7fdc67aa67a980ab522e8128ae63b26
20170422 16:32:42< gfgtdf> vultraz_iOS: please try not to mix formatting commits with real commit that does real changes, sicne the formatting stuff wuill mak eit harder to see the actual bahviour change
20170422 16:33:11< vultraz_iOS> ok
20170422 16:33:31< celmin|sleep> Yes, please do that.
20170422 16:38:38< gfgtdf> +
20170422 16:38:40< gfgtdf> +
20170422 16:38:42< gfgtdf> +
20170422 16:38:47< celmin|sleep> ???
20170422 16:39:37< gfgtdf> accidently pressen on keyboard
20170422 16:39:51< gfgtdf> im cleaningup my desk
20170422 16:40:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 16:41:13< celmin|sleep> Ah.
20170422 16:41:18-!- celmin|sleep is now known as celticminstrel
20170422 16:49:42-!- RatArmy_ [~ratarmy@om126237120057.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 16:53:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170422 16:58:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170422 16:58:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 17:09:54< celticminstrel> I suppose map labels showing through GUI2 dialogs is a known issue?
20170422 17:10:04< celticminstrel> Only when  tooltip is showing though.
20170422 17:10:08< celticminstrel> ^when a
20170422 17:10:41< vultraz_iOS> i thought i fixed that :/
20170422 17:11:01< celticminstrel> Well, it's happening with Sigurd's unit debug dialog.
20170422 17:11:13< celticminstrel> Which BTW uses tooltip_large.
20170422 17:11:26< celticminstrel> In case that's relevant (I doubt it though).
20170422 17:12:05< irker102> wesnoth: Celtic Minstrel wesnoth:master fb0dcc3740ed / src/hotkey/ (hotkey_handler.cpp hotkey_handler.hpp): Loop once instead of twice when expanding in-game generated menuitems https://github.com/wesnoth/wesnoth/commit/fb0dcc3740ed3f3f2e8632c86fd0a7ec21b402e6
20170422 17:13:29< vultraz_iOS> doesn't happen with core dialogs
20170422 17:13:47< celticminstrel> Then it was something fixed in modal_dialog::show?
20170422 17:13:55< celticminstrel> Because Lua dialogs don't use the modal_dialog class at all.
20170422 17:14:02< celticminstrel> They directly construct a window and show that.
20170422 17:14:21< vultraz_iOS> sigh
20170422 17:14:22< celticminstrel> What was the fix?
20170422 17:14:33< vultraz_iOS> it's in modal and modeless dialog
20170422 17:14:37< celticminstrel> Maybe it can be integrated into the scoped_dialog class too.
20170422 17:14:44 * vultraz_iOS curses
20170422 17:14:48 * vultraz_iOS curses soundly
20170422 17:14:55< vultraz_iOS> why can't it construct a dialog
20170422 17:15:01< celticminstrel> Stop cursing, it doesn't help anything. :P
20170422 17:15:14< celticminstrel> I dunno, that's just how someone designed it.
20170422 17:15:24< celticminstrel> The GUI2 Lua API is pretty terrible anyway, we should make a brand-new one.
20170422 17:15:33< vultraz_iOS> yeees :D
20170422 17:15:41< celticminstrel> The only problem with that is that I want to reuse the show_dialog function for the new one...
20170422 17:15:51-!- Appleman1234 [~Appleman1@pl5982.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170422 17:26:45< gfgtdf> wait, the ma labels showing through recuit dialog in tooltips is fixed in master?
20170422 17:26:56< gfgtdf> map*
20170422 17:28:14< gfgtdf> hm yes indeed
20170422 17:28:50< gfgtdf> althogh it not perece, it just hides all map labes, i think it'd be bettter if the map labels outside the dialog are still drawn
20170422 17:29:09< gfgtdf> i wonder why the map label draing is not just part of the normal map  draing
20170422 17:29:22< gfgtdf> drawing*
20170422 17:31:04-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 17:31:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 17:33:58< irker102> wesnoth: Celtic Minstrel wesnoth:master f8c8d443dcf4 / src/game_end_exceptions.hpp: Minor doc comment fixup https://github.com/wesnoth/wesnoth/commit/f8c8d443dcf4959f9aaa897106fc1cc22be7dd57
20170422 17:43:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 17:48:19-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170422 17:50:21< celticminstrel> The default road path cost calculator uses some weird math tricks for the random windiness...
20170422 17:50:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 18:12:38-!- gfgtdf_ [~chatzilla@x50abe498.dyn.telefonica.de] has joined #wesnoth-dev
20170422 18:13:30-!- gfgtdf [~chatzilla@x4e32b7e5.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 18:13:31-!- gfgtdf_ is now known as gfgtdf
20170422 18:13:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 18:14:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 18:15:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 18:15:50-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 18:22:58< vultraz_iOS> gfgtdf: yeah the map labels thing should be fixed for 1.14
20170422 18:25:12-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170422 18:27:30-!- gfgtdf [~chatzilla@x50abe498.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 18:28:04-!- gfgtdf [~chatzilla@x50abdfa9.dyn.telefonica.de] has joined #wesnoth-dev
20170422 18:30:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 18:31:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 18:31:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 18:32:28-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 18:33:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 18:50:16-!- gfgtdf_ [~chatzilla@x4e36a1a6.dyn.telefonica.de] has joined #wesnoth-dev
20170422 18:51:08-!- gfgtdf [~chatzilla@x50abdfa9.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170422 18:51:11-!- gfgtdf_ is now known as gfgtdf
20170422 18:56:00-!- gfgtdf_ [~chatzilla@x50abe3a8.dyn.telefonica.de] has joined #wesnoth-dev
20170422 18:57:50-!- gfgtdf [~chatzilla@x4e36a1a6.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 18:57:55-!- gfgtdf_ is now known as gfgtdf
20170422 19:06:07-!- JyrkiVesterinen [~JyrkiVest@87-100-151-153.bb.dnainternet.fi] has quit [Quit: .]
20170422 19:09:46< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff fbd2c8ef14d7 / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Support comma-separated chamber locations https://github.com/wesnoth/wesnoth/commit/fbd2c8ef14d71c9aa2337159eea730a8c1c113e9
20170422 19:09:48< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff b456e1050a24 / data/ (4 files in 3 dirs): Lua mapgen: Use helper.rand for chamber locations https://github.com/wesnoth/wesnoth/commit/b456e1050a24c50c61dd8bb78a4b619a8eef4a97
20170422 19:09:50< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff bd2455e19424 / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Allow alternate clear and village terrains https://github.com/wesnoth/wesnoth/commit/bd2455e19424e669663cb157f2d22ea3ac6443ed
20170422 19:09:52< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff fd9405337c7f / data/lua/cave_map_generator.lua: Lua Cave Mapgen: Allow a chamber's existence to depend on number of players https://github.com/wesnoth/wesnoth/commit/fd9405337c7fd63c69ae6f526a2a96a6ce61ae98
20170422 19:09:54< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff c6c28539ffc0 / data/multiplayer/scenarios/Random_Scenario_Cave.cfg: Add a multiplayer cave random map https://github.com/wesnoth/wesnoth/commit/c6c28539ffc0318e75a24ee43615d70997f3480d
20170422 19:09:56< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff f37cf5641d22 / data/lua/mapgen_helper.lua: Lua cave mapgen: Maintain compatibility support for - in chamber locations https://github.com/wesnoth/wesnoth/commit/f37cf5641d22f4500a1e64920310b169f5b8f52c
20170422 19:09:58< irker102> wesnoth: Celtic Minstrel wesnoth:lua_mapgen_stuff 829e700f332a / data/ (lua/cave_map_generator.lua multiplayer/scenarios/Random_Scenario_Cave.cfg): WIP - Support [road_cost] in [passage] https://github.com/wesnoth/wesnoth/commit/829e700f332a53969ee26bfb8f1b7a63465c3a8d
20170422 19:11:56< celticminstrel> Need some help on that latest commit... see the PR for details...
20170422 19:12:13< celticminstrel> Also people, please comment on PR 992 already?
20170422 19:14:19-!- gfgtdf_ [~chatzilla@x4e36a970.dyn.telefonica.de] has joined #wesnoth-dev
20170422 19:15:55-!- gfgtdf [~chatzilla@x50abe3a8.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170422 19:15:58-!- gfgtdf_ is now known as gfgtdf
20170422 19:18:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170422 19:18:07< gfgtdf> celticminstrel: considering that people need to (slightly) update their mapgen code abnyways when moving to the new lua cavegen code, im usure whether it mkaes sense to maintain compability for - ranges.
20170422 19:18:19< celticminstrel> Hmm, maybe not.
20170422 19:29:18-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170422 19:44:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170422 19:46:17-!- gfgtdf_ [~chatzilla@x50abe21c.dyn.telefonica.de] has joined #wesnoth-dev
20170422 19:47:07-!- gfgtdf [~chatzilla@x4e36a970.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170422 19:47:12-!- gfgtdf_ is now known as gfgtdf
20170422 20:05:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170422 20:06:23< Ravana_> I see that [options] id has to be unique across all scenarios that have ever been used, enforced by preferences file
20170422 20:07:01< Ravana_> this means that scenario may never be assigned new id
20170422 20:07:34< gfgtdf> ?
20170422 20:08:09< gfgtdf> ah wait, i tink you coudl be talkingh about a known 1.12 bug.
20170422 20:08:32< gfgtdf> Ravana_: please chek whethe rit's still aproblem inj 1.13
20170422 20:08:51< Ravana_> I have 1.13.4, would that work?
20170422 20:09:39< gfgtdf> Ravana_: hmm no you probably need the new gui2 mp create screen.
20170422 20:09:48< gfgtdf> that is 1.13.6 or later
20170422 20:09:57< Ravana_> going to download then
20170422 20:10:33< gfgtdf> if you need to download it's prbably better to download latest versoin
20170422 20:11:12< gfgtdf> 1.13.7 i think
20170422 20:21:16-!- gfgtdf_ [~chatzilla@x50abdffc.dyn.telefonica.de] has joined #wesnoth-dev
20170422 20:21:32< celticminstrel> What's this all about?
20170422 20:22:15< Ravana_> about https://forums.wesnoth.org/viewtopic.php?f=21&t=45240
20170422 20:22:20-!- gfgtdf [~chatzilla@x50abe21c.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170422 20:22:26-!- gfgtdf_ is now known as gfgtdf
20170422 20:26:31-!- DeFender1031 [~DeFender1@46-116-90-83.bb.netvision.net.il] has joined #wesnoth-dev
20170422 20:29:14< gfgtdf> this seems ot be the bnugreport: https://gna.org/bugs/?22335
20170422 20:32:24-!- gfgtdf_ [~chatzilla@x4e36969f.dyn.telefonica.de] has joined #wesnoth-dev
20170422 20:32:45< Ravana_> 1.13.7 has some strange wesnoth.message() font
20170422 20:33:40-!- gfgtdf [~chatzilla@x50abdffc.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170422 20:33:49-!- gfgtdf_ is now known as gfgtdf
20170422 20:34:18< celticminstrel> 1.13 uses Lato instead of DejaSans. I'm not entirely happy with this.
20170422 20:34:31< vultraz_iOS> I am entirely happy with this.
20170422 20:34:33< celticminstrel> ^DejaVu Sans3
20170422 20:35:03< celticminstrel> vultraz_iOS: I think a lot of people who don't speak English may be very unhappy with it.
20170422 20:35:14< vultraz_iOS> every time I look back at DVS I wonder how we tolerated it for so long
20170422 20:35:15< Ravana_> gfgtdf: fixed in 1.13.7
20170422 20:35:22< celticminstrel> Lato's unicode support is far worse.
20170422 20:35:36< celticminstrel> Though some languages substituted the fonts anyway...
20170422 20:35:44 * celticminstrel isn't sure if those languages still do so.
20170422 20:36:46< vultraz_iOS> but it looks better
20170422 20:37:21< celticminstrel> I don't recall it ever looking better.
20170422 20:37:34< celticminstrel> Mind you, I don't recall it looking worse, either, but...
20170422 20:39:06< Ravana_> top values are good enough, but message area is uncomfortable https://vgy.me/gMPffg.png
20170422 20:39:06< vultraz_iOS> celticminstrel: https://www.wesnoth.org/images/sshots/wesnoth-1.11.8-3.jpg
20170422 20:39:40< celticminstrel> vultraz_iOS: Uh, what about it?
20170422 20:39:53< vultraz_iOS> look at how bad the old font looks
20170422 20:41:12< celticminstrel> It looks fine to me.
20170422 20:42:44< celticminstrel> Ravana_: What's wrong with the message area... font size?
20170422 20:42:53< Ravana_> yes
20170422 20:43:20< vultraz_iOS> guess you think it's too big
20170422 20:43:33< celticminstrel> Uh. I assumed he thought it's too small.
20170422 20:43:34< Ravana_> no, its too small
20170422 20:43:41< vultraz_iOS> oh that
20170422 20:43:46< celticminstrel> Why would you think he thought it's too big?
20170422 20:44:18< Ravana_> those top values might be too big, but that should be easy to become used to
20170422 20:44:42< vultraz_iOS> though she was talking about [message] like zookeeper
20170422 20:45:05< Ravana_> > strange wesnoth.message() font
20170422 20:45:38< Ravana_> I quite dislike [message]
20170422 20:45:48< celticminstrel> Oh?
20170422 20:46:16< Ravana_> [message] needs clicking action from each player
20170422 20:46:27< Ravana_> and each observer
20170422 20:46:33< celticminstrel> True...
20170422 20:46:51< celticminstrel> Though ISTR there was a timeout option.
20170422 20:48:46< Ravana_> it has duration=, that specifies minimal required viewing time
20170422 20:48:59< irker102> wesnoth: Charles Dang wesnoth:master 9e854e2a462f / src/display_chat_manager.cpp: Increased floating chat text size https://github.com/wesnoth/wesnoth/commit/9e854e2a462f55c3d46a2035624f3e061a9c1e83
20170422 20:51:25< irker102> wesnoth: Nils Kneuper wesnoth:master 1d13dcfbec62 / / (31 files in 30 dirs): updated Chinese (Simplified) translation https://github.com/wesnoth/wesnoth/commit/1d13dcfbec622fa1e68fb39de7769cdfec900123
20170422 20:52:31< celticminstrel> Seems like SotA has gained three new translations so far...
20170422 20:52:57< celticminstrel> Oh, wait.
20170422 20:53:11< celticminstrel> I guess the updates touch every po-file.
20170422 20:53:57-!- nickanc [5d33ac22@wikimedia/nickanc] has joined #wesnoth-dev
20170422 20:54:40< Ivanovic> celticminstrel: in fact en@shaw being shown as "complete" might be a bug in gettext tool thinking that since the original language was english, this should be complete as well...
20170422 20:55:01< Ivanovic> https://www.wesnoth.org/gettext/?package=wesnoth-sota&order=trans&version=master
20170422 20:55:08< Ivanovic> this is what you should be looking at for language stats
20170422 20:55:10< Ivanovic> ;)
20170422 20:55:38< celticminstrel> Well, I guess it has gained one new translation then.
20170422 20:55:43< celticminstrel> Not counting British English.
20170422 20:56:36< vultraz_iOS> such a hard translation :P
20170422 20:56:44< vultraz_iOS> throw u's into everything xD
20170422 20:56:50< celticminstrel> I dunno how hard it was, ask wedge009 
20170422 20:57:03< celticminstrel> No vultraz_iOS, I'm sure it's not just that. :P
20170422 20:57:30< celticminstrel> Though most of the other spelling differences I can think of are modern words...
20170422 20:57:30< Ivanovic> vultraz_iOS: don't underestimate s vs z questions
20170422 20:57:32< Ivanovic> ;)
20170422 20:57:41< celticminstrel> Oh yeah, there's a lot of that too.
20170422 20:58:06< celticminstrel> And potentially more oe / ae than in US English, and maybe some re instead of er
20170422 20:58:32< vultraz_iOS> still, it's comparatively simple
20170422 20:58:59< vultraz_iOS> think of the effort the GB->US translator had to put into their work for, say, Harry Potter, compared to say, GB->Chinese
20170422 20:59:01< celticminstrel> Well, simpler than most, certainly.
20170422 21:01:03< irker102> wesnoth: Nils Kneuper wesnoth:master 9c05058986ff / po/wesnoth-sota/en@shaw.po: reset wesnoth-sota translation for en@shaw since it should start https://github.com/wesnoth/wesnoth/commit/9c05058986fffb7fd3372af5db7e62f2e05ccfd0
20170422 21:01:26< celticminstrel> What does the fuzzy flag mean, anyway? Is it "this is an approximate translation" or "this string no longer exists in the source pot"?
20170422 21:03:57< Ivanovic> fuzzy means: "the check shows that this string is similar to a string already existing in the po file but not a perfect match"
20170422 21:04:04< Ivanovic> not sure how many % need to be matching
20170422 21:04:19< Ivanovic> usually a fuzzy string is a string where "something" was changed in an existing string
20170422 21:04:27< celticminstrel> So it's applied to strings that no longer exist in the pot.
20170422 21:04:35< Ivanovic> but it can also be pretty far of, as in the translation for "orc" being used for the new term "orb"
20170422 21:04:41< Ivanovic> wrong
20170422 21:04:56< Ivanovic> it is a way to try to identify strings that *might* be changed strings but at least need a review
20170422 21:05:26< Ivanovic> the idea by the creators was that this way most of the spelling fixes are faster to fix then by forcing a complete retranslation of the string since you don't have a 100% match
20170422 21:05:37< Ivanovic> as in the example it can still be pretty far off as well...
20170422 21:06:09< Ivanovic> fuzzy is a string shown in the original lanauge in the application until the marker is removed by a translator (meaning: it was verified that the translation matches the original string)
20170422 21:06:59< Ivanovic> and now, the original strings might still exist as well
20170422 21:07:06< Ivanovic> (c.f. the orc vs orb example)
20170422 21:14:37-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 21:20:58-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 21:33:36-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 21:34:17-!- gfgtdf [~chatzilla@x4e36969f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170422 21:38:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 21:39:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 21:42:23-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 21:44:25< Kwandulin> What might be the cause of a campaign becoming slow after a certain scenario?
20170422 21:44:34< Kwandulin> (slow=performance wise)
20170422 21:47:21< Ravana_> slow when doing what?
20170422 21:48:53< Kwandulin> slow when it's the turn of the AI
20170422 21:50:27< Ravana_> then standard cause is too many units with too high stats/slow/drain
20170422 21:51:17< nickanc> ^
20170422 21:51:30-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 21:52:03< Kwandulin> Is there a way to activate a "simple AI", that ignores slow/berserk/drain stuff?
20170422 21:52:10< nickanc> at most, there are some gimmicks to make the ai less cautious, but that would hardly make a campaign more enjoyable, quite the contrary
20170422 21:52:31< celticminstrel> There's a MicroAI which disables some things that are slow.
20170422 21:52:35< celticminstrel> "fast AI" IIRc
20170422 21:52:50< Kwandulin> I'll have a look
20170422 21:53:02< nickanc> Ravana_ : I am macroing the thing, downloaded 1.13, testing.
20170422 21:53:29< celticminstrel> It causes the AI to make overall poorer combat decisions, AIUI, but it also takes a lot less time to move.
20170422 21:53:58< celticminstrel> (I wonder if it should be offered as a toplevel AI instead of a MicroAI...)
20170422 22:09:12-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has joined #wesnoth-dev
20170422 22:09:55< Kwandulin> Mhh, doesn
20170422 22:10:05< Kwandulin> 't make it faster
20170422 22:10:39< nickanc> Kwandulin what are you testing exactly? how many units? levels? era?
20170422 22:10:50< Kwandulin> I'll check if disabling [ai] grouping="offensive" [/ai] will make it faster. That's one of the few things that changes
20170422 22:11:04< Kwandulin> I checked the fast micro ai
20170422 22:11:32< celticminstrel> https://wiki.wesnoth.org/Micro_AIs#Fast_Micro_AI_.28ai_type.3Dfast_ai.29
20170422 22:11:51< Kwandulin> Slow/drain/berserk stuff is probably to the cause, because the player has many of those units even before the specific scenario
20170422 22:11:53< celticminstrel> So I guess the slow-down is probably not a result of the things it removes...
20170422 22:12:29< Kwandulin> -to +not
20170422 22:12:58< celticminstrel> For example, it's not simply a problem of having so many units that it takes quite some time for the AI to consider all possibilities and determine the best one.
20170422 22:13:45< nickanc> berserk and drain, the more together, cause the AI to think a lot more for each unit having them.
20170422 22:14:22< celticminstrel> So, is it faster if you use the monte carlo simulation thing?
20170422 22:14:22< nickanc> for the simple math fact that the results of attacking them varies a lot
20170422 22:14:38< nickanc> it should not change much
20170422 22:14:46< nickanc> if that were the cause
20170422 22:14:56< Kwandulin> Yeah, sure. The thing is that the player already got several of those units before that scenario. But things were going fast then. But in that specific scenario, things get out of control. The AI needs 30++ seconds per turn. Even for the first turn
20170422 22:15:14< celticminstrel> IIRC the monte carlo simulation mainly fixed slowness with ridiculously large hp.
20170422 22:15:29< Kwandulin> Turning Monte Carlo off doesn*t really change a much
20170422 22:16:01< Kwandulin> (I just jumped right into that scenario with debug-> choose_level and the AI is already very slow, although I got no units on my side)
20170422 22:16:11< nickanc> but, more to the heart, what is the point of a plethora of units with drain or berserk?
20170422 22:16:21< Kwandulin> Hitpoint pools are mostly below 80
20170422 22:17:19< celticminstrel> So it's nothing to do with your units...
20170422 22:19:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170422 22:19:58< Kwandulin> The amount of enemy units is also below 30, so that should be fine, too
20170422 22:20:52< Kwandulin> Anyway, it's late. I*ll check tomorrow
20170422 22:21:26< Kwandulin> Funny, the AI isn*t moving all of its units
20170422 22:21:33< Kwandulin> Ugghh, late
20170422 22:21:44-!- Kwandulin [~Kwandulin@p200300760F6D80926C4D7EE320B6CB98.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170422 22:29:57< vultraz_iOS> funny enough, it's extremely easy to get checkboxes to appear in the music menu...
20170422 22:41:22< celticminstrel> I think there's little point in doing so, but sure, it's probably easy.
20170422 22:41:36< celticminstrel> There's no point in doing anything about checkboxes or radiobuttons in other menus, though.
20170422 22:41:51< celticminstrel> The way they're currently handled is good enough. There's no need for an actual toggle button.
20170422 22:42:29< vultraz_iOS> true
20170422 22:42:41< celticminstrel> Because the menu closes when you select something anyway.
20170422 22:42:43< vultraz_iOS> but I'll probably do it eventually anyway, for consistency
20170422 22:42:49< celticminstrel> No, please don't.
20170422 22:42:56< vultraz_iOS> why?
20170422 22:42:59< celticminstrel> Don't waste your time on something that has no value whatsoever.
20170422 22:43:04< vultraz_iOS> it's my time :P
20170422 22:43:16< celticminstrel> These may look like checkboxes and radiobuttons, but that's not what they are.
20170422 22:43:29< celticminstrel> They're those little checkmarks or bullet points that you sometimes see next to a menuitem.
20170422 22:43:30< vultraz_iOS> and I really hate when stuff looks like something but internally it is not so
20170422 22:43:42< vultraz_iOS> in which case, the image should be changed
20170422 22:43:49< vultraz_iOS> if what you say is true
20170422 22:43:53< celticminstrel> Well, feel free to change the images they use to not resemble checkboxes or radiobuttons, then. I'd have little objection to that.
20170422 22:44:17< celticminstrel> (Just be careful to ensure that the change doesn't accidentally also change the appearance of real checkboxes or radiobuttons. :P )
20170422 22:44:30< vultraz_iOS> basically I'd either change the image or change them to a widget
20170422 22:44:49< celticminstrel> I don't really see any point in changing the image either, but if you're going to insist on doing one of those two things, I'd say change the image.
20170422 22:45:03< celticminstrel> The image gets the meaning across just fine in my opinion.
20170422 22:45:28< celticminstrel> It does behave like a checkbox/radiobutton in a certain sense, after all.
20170422 22:45:56< celticminstrel> But since the menu closes the moment you select it, it doesn't behave exactly like a checkbox/radiobutton, because as soon as you toggle it, it's gone.
20170422 22:46:12< celticminstrel> So you don't see the toggle change until the next time the menu is opened.
20170422 22:46:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6ced:8714:41bb:c429] has quit [Remote host closed the connection]
20170422 22:46:20< celticminstrel> So there's no "real" checkbox/radiobutton.
20170422 22:46:21< vultraz_iOS> definitely want checkboxes in the music menu tho
20170422 22:46:31< vultraz_iOS> and removing the show loop
20170422 22:46:34< celticminstrel> Yeah, that would be fine, because the music menu stays open.
20170422 22:46:50< vultraz_iOS> because that loop has the annoying effect of scrolling to the top every single time :|
20170422 22:47:00< celticminstrel> Ah. I hadn't thought of that.
20170422 22:47:04< nickanc> Ravana_ why is there no ageless for 1.13?
20170422 22:47:12< celticminstrel> Yeah, okay, I guess doing it for the music menu is in fact an overall improvement.
20170422 22:47:21< celticminstrel> So go right ahead.
20170422 22:48:00< Ravana_> last time when I had time to look, it failed to load
20170422 22:48:16< Ravana_> but I think Shiki fixed that recently
20170422 22:49:33< Ravana_> or not so recently, Aug 30, 2016
20170422 22:51:33< nickanc> Ravana_ I copypasted 1.12 Ageless to make Orocia work there. Ageless has a lot of errors, but a macroed Orocia seems to work. Now I made four scenarios, whose text looks like:
20170422 22:52:21< nickanc> #textdomain wesnoth-OrociaRandomMod  {OROCIARM_MULTIPLAYER (swamp) (Swamp) ("{~add-ons/OrociaRandomMod/maps/OrociaRandomModSwamp.map}") (The shrine lies in a swampy wasteland where settlements are still temporary. Play with castle destruction for a challenge, all villages will be susceptible of being destroyed.) ( 	{DEFAULT_SCHEDULE} )}
20170422 22:53:04< nickanc> and that is all scenarios/OrociaRandomModSwamp.cfg
20170422 22:53:31< nickanc> though on 1.12 because options id apparently have to be unique
20170422 22:53:42< nickanc> *though on 1.12 doesnt worl
20170422 22:53:44< nickanc> *work
20170422 22:54:11< Ravana_> I understand 1.14 will be released during summer
20170422 22:55:18< nickanc> do you want me to pull you a 1.13 compatible Orocia (that likely wont work properly because Ageless half broken, Switch leader missing, etc) or lets wait?
20170422 22:55:55< wedge009> Ivanovic: celticminstrel: vultraz_iOS: More than just adding 'u' and other spelling differences. (And actually, previous translators prefer 'z' to 's' because the latter is a more recent difference following French spelling.) I observe American habits in the default dialogue like, for example 'go get the mage' instead of 'go and get the mage'. What's the language question for anyway?
20170422 22:56:21< celticminstrel> I think just curiosity.
20170422 22:56:59< wedge009> Oh okay. Well, sure, certainly less 'difficult' than translating to non-English languages, but still takes time and effort to read through everything. That's how I catch a lot of spelling/grammar issues too.
20170422 22:57:40< vultraz_iOS> why would you need an 'and' there i wonder
20170422 22:57:46< Ravana_> I think it is too early to drop support of 1.12, so better bit later
20170422 22:58:10< celticminstrel> Why wouldn't you need an "and" in there?
20170422 22:58:29< Ravana_> since currently released ageless seems to start up with 1.13, uploading it there now
20170422 23:00:02< wedge009> See what I mean? It sounds 'normal' for you as an American speaker, but to a non-American English speaker not so much.
20170422 23:00:35< celticminstrel> Well, both sound fine to me though.
20170422 23:00:45< wedge009> It's not to say one is right or wrong, just what is conventional for a given dialect.
20170422 23:01:08< wedge009> I would argue that it's also a modern style of writing/speaking, which seems to be discouraged in Wesnoth.
20170422 23:01:09< nickanc> Ravana: I cant guarantee I will be here in summer, I'll put it somewhere online, so that when it is the time it may be of use to you.
20170422 23:01:25< Ravana_> that would work
20170422 23:02:47< vultraz_iOS> celticminstrel: would you hate me if i did a mass formatting commit for if ( and for ( -> if( and for( to save time when we do formatting cleanups 
20170422 23:03:12< celticminstrel> I would not hate you as long as it was only formatting changes in that commit.
20170422 23:10:31< celticminstrel> (Ideally you'd stash any real work before getting started on something like that.)
20170422 23:10:40< celticminstrel> (Well, stash or commit.)
20170422 23:11:55< vultraz_iOS> i have no local changes
20170422 23:12:07< celticminstrel> Good, good
20170422 23:16:45< vultraz_iOS> celticminstrel: ok, i have a commit for > > to >> and if ( and for ( to if( and for(. Is there anything else you can think of I can do along with these?
20170422 23:17:10< celticminstrel> Maybe switch ( or catch ( ?
20170422 23:17:18< celticminstrel> Or while (
20170422 23:17:30< celticminstrel> Also, maybe ) )
20170422 23:17:53< celticminstrel> And a ( immediately followed by a space
20170422 23:18:06< vultraz_iOS> hm, yes, first two can go in the commit with for and if
20170422 23:19:07< vultraz_iOS> actually those can probably all go together
20170422 23:21:15-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170422 23:23:54< celticminstrel> The last two tend to be on the same lines as the others, after all.
20170422 23:24:15< celticminstrel> Stuff like "if ( (some_expression) )"
20170422 23:25:56< vultraz_iOS> 418 files changed, 9344 insertions(+), 9344 deletions(-)
20170422 23:25:58< vultraz_iOS> \o/
20170422 23:26:05< nickanc> Ravana_ : https://www.dropbox.com/s/hzildt9xne16zol/OrociaRandomMod_1.13_compatible_nickanc.7z?dl=0
20170422 23:26:13< vultraz_iOS> so this strips over 10,000 unnecessary space characters 
20170422 23:26:20< vultraz_iOS> wonder how much file size shrinks :P
20170422 23:26:21< nickanc> probably I should put it on wesnoth forum, perhaps
20170422 23:26:47< vultraz_iOS> I assume a space character is 1 byte
20170422 23:27:54< zookeeper> what is that about? formulas?
20170422 23:27:54< vultraz_iOS> or maybe not?
20170422 23:28:25< zookeeper> speak
20170422 23:28:53< vultraz_iOS> zookeeper: ?
20170422 23:28:59< zookeeper> sigh
20170422 23:29:01< zookeeper> yes, vultraz, what?
20170422 23:29:05< zookeeper> can't you read my question?
20170422 23:29:19< vultraz_iOS> stripping unnecessary whitespace from control functions in the code
20170422 23:29:40< zookeeper> ok, that's a "no, c++"
20170422 23:29:54< vultraz_iOS> I've stripped over 10,000 whitespace characters and I'm idly curious how much it would reduce file sze by
20170422 23:30:41< nickanc> to those who like shadowmcanon stuff: if the link above somehow in the future join the 1.14 multiplayer, it would contain one of the few two suns scenarios that ever the multiplayer had. Now it is just an option of the Orocia map, and a quite played one, when I am around.
20170422 23:31:45< zookeeper> vultraz_iOS, 10kb?
20170422 23:31:57< vultraz_iOS> probably
20170422 23:33:00< zookeeper> so yeah maybe don't make such a mess of everyone's non-master code with something like that?
20170422 23:33:35< zookeeper> no one wants to resolve some pointless merge conflicts in every file they happen to be working on.
20170422 23:34:25< vultraz_iOS> pretty sure it wouldn't cause that much problems
20170422 23:34:32< vultraz_iOS> the changes are all onsingle lines
20170422 23:35:09< nickanc> vultraz_iOS what did you do that seems so controversial?
20170422 23:35:47< vultraz_iOS> nickanc: i'm preparing to push a commit to do a pass formatting change of removing unnecessary whitespace
20170422 23:36:36< vultraz_iOS> zookeeper is expressing concern it will cause merge conflicts. I'm saying it's unlikely since no new lines are added and all the changes are on single lines. So unless you already modified that line, you're fine.
20170422 23:36:51< nickanc> does it break indent style? if not, why was not it already done?
20170422 23:37:12< vultraz_iOS> it doesn't break indent
20170422 23:37:12< zookeeper> because doing so has no benefit whatsoever?
20170422 23:37:49< vultraz_iOS> saves people time if they're reformatting files
20170422 23:38:48< zookeeper> reformatting files saves people time if they're reformatting files because then they've already been reformatted and thus they don't need to do it?
20170422 23:38:53< zookeeper> yeah hard to argue with logic like that :>
20170422 23:39:11< vultraz_iOS> no, it saves time when doing further reformatting :P
20170422 23:39:23< Ravana_> nickanc: I downloaded it, but I guess wouldn't hurt to include it in some post either
20170422 23:39:37< vultraz_iOS> it's tiresome when you go to a file and are like, "ok, going to clean this up" and then have to do the same bunch of steps over and over
20170422 23:39:37< nickanc> Probably vultraz and I shall admit we have a disorder about tidying stuff.
20170422 23:39:43< nickanc> Ravana_ ok, doing
20170422 23:39:57< zookeeper> vultraz_iOS, i have no idea what sort of reformatting you're referring to
20170422 23:42:43< nickanc> Ravana_ total orocia is missing because many things check the number of sides and I was more concerned with the macroing of the general scenario. I did not included Deep Shrine either because the original wave mechanics and the upgrade mechanics are a bit different and that would have required more than the 2 hours I gave to that thing.
20170422 23:43:34< nickanc> Deep Shrine in principle is a very interesting version of Orocia, you can check it in the Dov's MP mappack
20170422 23:44:20< vultraz_iOS> zookeeper: I mean if one wants to clean up a file it's rather tedious to have to start with the same bunch of find/replace steps each time you do
20170422 23:44:34< nickanc> ^
20170422 23:44:53< zookeeper> yes, that's what you already said
20170422 23:45:11< Ravana_> deep shrine is the first scenario I remember playing
20170422 23:45:51< zookeeper> vultraz_iOS, do i need to repeat that i don't know what sort of reformatting you're referring to?
20170422 23:45:56< Ravana_> in 1.8 it had ageless waves too
20170422 23:46:23< vultraz_iOS> zookeeper: if ( -> if(, for ( -> for(, ) ) -> )), ( ( -> ((, etc
20170422 23:46:37< zookeeper> vultraz_iOS, are you f... whatever
20170422 23:46:49< zookeeper> if your comprehension is that bad, don't push anything
20170422 23:47:12< vultraz_iOS> my comprehension is not bad, your question are not clear
20170422 23:47:31< vultraz_iOS> are you asking what reformatting needs repeating? what's in the commit? reformatting in general?
20170422 23:47:40< vultraz_iOS> I'm answering the first question
20170422 23:47:43-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170422 23:47:56< zookeeper> no it's not, you just have a chronic problem with understanding context which you've yourself established 5 minutes ago
20170422 23:48:34< zookeeper> look up every instance of the word "reformatting" above
20170422 23:48:54-!- gfgtdf [~chatzilla@x4e36969f.dyn.telefonica.de] has joined #wesnoth-dev
20170422 23:49:00< gfgtdf> is https://forums.wesnoth.org/viewtopic.php?f=5&p=610997#p610997 (crash in addon manager) a known issue ?
20170422 23:49:55< nickanc> Ravana_ Dovolente is definetely one of the best scenario makers.
20170422 23:54:12< zookeeper> vultraz_iOS, how can you take a short and simple exchange like https://pastebin.com/bAt9pf16 and claim that it's unclear on the last line when i say "reformatting" whether i'm referring to your if ( -> if( or the further reformatting that's going to be made faster by it?
20170422 23:54:39< vultraz_iOS> zookeeper: reformatting as in cleaning up the code to make it look nicer and conform to a common standard. Which *includes* the basic find/replace patterns I just mentioned as well as other stuff like shifting braces, reducing indent by inverting conditionals, using 'auto'
20170422 23:54:55< vultraz_iOS> etc etc etc
20170422 23:56:04< zookeeper> then this _is_ exactly what you're saying:
20170422 23:56:06< zookeeper> <zookeeper> reformatting files saves people time if they're reformatting files because then they've already been reformatted and thus they don't need to do it?
20170422 23:56:06< zookeeper> <vultraz_iOS> yes
20170422 23:56:18< vultraz_iOS> ...no :|
20170422 23:56:34< vultraz_iOS> because most of those changes *cannot be done by, say, a simple find/replace*
20170422 23:57:08< vultraz_iOS> all I'm doing is removing the need to do the *simple find/replace reformatting*
20170422 23:58:05< vultraz_iOS> so it saves people time by not having to repeatedly do the simple reformatting by allowing them to immediately move to the more in-depth reformatting or cleanup 
20170422 23:59:47< zookeeper> yes. you're doing reformatting which will save time in the future, because when someone would do the thing you're doing now, they won't need to because it's already been done.
--- Log closed Sun Apr 23 00:00:01 2017