--- Log opened Mon Apr 24 00:00:14 2017
--- Day changed Mon Apr 24 2017
20170424 00:00:14< mattsc> So, digging down function by function, this is the offending line:
20170424 00:00:15< mattsc> https://github.com/wesnoth/wesnoth/blob/master/src/pathfind/teleport.cpp#L130
20170424 00:00:23< mattsc> That’s what takes all the time ...
20170424 00:03:55< celticminstrel> So it is the filtering... o.o
20170424 00:03:55-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 00:05:42< vultraz_iOS> so apparently boost::mpl is rendered less useful by variadic templates? hmmmm
20170424 00:05:54 * vultraz_iOS needs to learn more about le metaprogramming
20170424 00:06:01< mattsc> yeah, but I don’t get it; that should be an individual hex there, shouldn’t it …
20170424 00:06:10< celticminstrel> What?
20170424 00:09:05< celticminstrel> loc_pair.first and loc_pair.second are both sets of locations.
20170424 00:10:08< mattsc> Well, on this specific map the tunnels are single hex to single hex, and there are two tunnels
20170424 00:10:19< celticminstrel> Oh.
20170424 00:10:31< irker929> wesnoth: Charles Dang wesnoth:master 8354469ca4a6 / src/gui/core/event/handler.hpp: GUI2: update and reformat ui_event documentation https://github.com/wesnoth/wesnoth/commit/8354469ca4a626a16f08c15b234ecda2df0c0129
20170424 00:11:16< mattsc> What’s the syntax for outputting the content of loc_pair.first to stderr in human readable format?
20170424 00:11:18< celticminstrel> Well, if the filter isn't defined in terms of x and y, or a couple of other options that refer to exact locations, it still needs to check every location on the map to see if it matches.
20170424 00:12:35< mattsc> [source] and [target] are both in x,y=… format
20170424 00:12:55< mattsc> And [source] also checks that a certain unit is not at the location.
20170424 00:13:24< celticminstrel> Using x,y does ensure no other location are checked...
20170424 00:14:41< celticminstrel> ^locations
20170424 00:14:53< mattsc> that’s what I thought
20170424 00:16:04< mattsc> celticminstrel: what’s the syntax for putting the content of loc_pair.first to stdout/err?
20170424 00:16:15< celticminstrel> To output the contents of a set, something like... "for(const auto& elem : loc_pair.first) std::cerr << elem << '\t';"
20170424 00:16:29< celticminstrel> Of course, that'll work for a vector too.
20170424 00:16:49< celticminstrel> This is also assuming that elem itself is streamable... might need to write "elem.x << ',' << elem.y" instead.
20170424 00:20:09< mattsc> Hmm, doesn’t seem to loop.
20170424 00:32:19< gfgtdf> celticminstrel: at lest for units filters it usually does
20170424 00:32:34< gfgtdf> (that was an answer to 'Using x,y does ensure no other location are checked...')
20170424 00:32:59< gfgtdf> afaik map_location object are streamable
20170424 00:33:20< celticminstrel> gfgtdf: Looks like it does for location filters too.
20170424 00:33:24< mattsc> that’s what I thought, but this one isn’t (or I am doing it wrong)
20170424 00:33:35< mattsc> anyway, I’m going to be away again ...
20170424 00:34:25< gfgtdf> wait maybe what i said was wrong, and does it onyl for loactions.. not sure
20170424 00:40:40< gfgtdf> i should go to bed too can't even read correctly...
20170424 00:40:41-!- gfgtdf [~chatzilla@x4e36a6b6.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170424 00:54:26-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170424 00:54:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170424 00:57:55< mattsc> Wow, this is amazing …
20170424 00:57:57< mattsc> bbl
20170424 00:58:02-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170424 01:03:30< mattsc> the problem appears to be due to the fact that one of the SLFs is of form x,y,[filter] = …   (not written exactly like that, of course)
20170424 01:04:26< mattsc> [ cfg_ inside src/terrain/filter.cpp has a .get_config() member ]
20170424 01:07:07< mattsc> x and y are individual coordinates and [filter] has an individual id in it, but it’s still taking forever.
20170424 01:16:36< irker929> wesnoth: Charles Dang wesnoth:master 7106c1215a5e / src/ (recall_list_manager.cpp units/unit.hpp): Removed fallback from unit::id https://github.com/wesnoth/wesnoth/commit/7106c1215a5e40e04cecc7c037ae8096005ddeeb
20170424 01:20:35-!- RatArmy_ [~ratarmy@126.237.124.26] has joined #wesnoth-dev
20170424 01:22:10< irker929> wesnoth: Charles Dang wesnoth:master cb71c3dc2e5b / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/cb71c3dc2e5bfb8058e5d19f5744829b685249f4
20170424 01:25:47< mattsc> Okay, so SLFs with a negated [filter] in them take _really_ long.
20170424 01:26:33< mattsc> I tested this just by executing some Lua code with wesnoth.get_locations() in it 100 times.
20170424 01:27:14< mattsc> For filter { x = 33, y = 11 } that takes a couple milliseconds (total for all 100 iterations)
20170424 01:27:36< mattsc> With { x = 33, y = 11, { "filter", { id = 'xxx' } } } it’s pretty much the same
20170424 01:27:59< mattsc> But { x = 33, y = 11, { "not", { { "filter", { id = 'xxx' } } } } } takes over 1000 ms !!
20170424 01:28:43< mattsc> Sounds rather … inefficient to me.
20170424 01:28:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3819:376c:bdf7:5fea] has joined #wesnoth-dev
20170424 01:29:28< mattsc> celticminstrel, gfgtdf, zookeeper, Kwandulin, whoever else is interested: ^
20170424 01:30:01< vultraz_iOS> weird
20170424 01:31:04< mattsc> This is on Kwandulin’s large map, so I bet the code iterates over all hexes even though x,y= is set to a single hex; but only when the SUF is negated.
20170424 01:36:26< mattsc> So, in summary, as expected the slow-down in Kwandulin’s scenarios has nothing to do with the AI (other than that the AI does a lot of pathfinding).  However (and that’s contrary to what I expected), it also has nothing to do with tunnels per se, but rather with an inefficiency in SLF evaluation.
20170424 01:36:45-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170424 01:38:11-!- RatArmy_ [~ratarmy@126.237.124.26] has quit [Read error: Connection reset by peer]
20170424 01:38:44< mattsc> I just also tested this in 1.12, it’s already like that there, so it’s not a recent regression.
20170424 01:39:08< mattsc> … and with that, I am done with this for today.
20170424 01:41:53< vultraz_iOS> I guess we need to optimie the loc filter
20170424 01:42:25< vultraz_iOS> optimize
20170424 01:43:41< irker929> wesnoth: Charles Dang wesnoth:master 35600270f36c / src/ (addon/manager_ui.cpp gui/dialogs/addon/manager.hpp): Addon Manager: fixed a typo in a function name https://github.com/wesnoth/wesnoth/commit/35600270f36c9cfaf9c261af762de253192f52c1
20170424 01:43:44< irker929> wesnoth: Charles Dang wesnoth:master 6cde201d09cb / src/gui/dialogs/ (message.cpp message.hpp): Renamed a struct that escaped the t-prefix purge https://github.com/wesnoth/wesnoth/commit/6cde201d09cb233c44c9615f46dfcbaa86caaa7d
20170424 01:50:24< vultraz_iOS> looks like [not] considers all locations instead of simply the ones already matched?
20170424 01:52:15< vultraz_iOS> ie, it gets every location that doesn't match, then removes each one from the result
20170424 01:52:25< vultraz_iOS> as opposed to checking the result against the condition
20170424 01:52:38< vultraz_iOS> very inefficient...
20170424 01:52:43-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170424 01:54:52< vultraz_iOS> but I'll let someone else handle changing it
20170424 02:17:27-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 02:24:52< celticminstrel> I wouldn't call that a typo, vultraz_iOS 
20170424 02:25:22< celticminstrel> As for the cause of the inefficiency...
20170424 02:25:46< celticminstrel> It's probably something like, the [not] is an entirely separate location filter?
20170424 02:26:20< celticminstrel> Hmm...
20170424 02:26:23< vultraz_iOS> I just said what it looked like it was doing
20170424 02:26:33< vultraz_iOS> so... yeah basically that
20170424 02:26:54< celticminstrel> No, it looks like and/or/not also work with the result set generated from x,y or similar...
20170424 02:27:23< vultraz_iOS> yes
20170424 02:27:33< vultraz_iOS> but only once the filter has been separately calculated 
20170424 02:27:40< celticminstrel> Oh, you're right!
20170424 02:28:13< vultraz_iOS> what it *should* be doing is operating on the data already provided
20170424 02:28:31< celticminstrel> Hmmm...
20170424 02:30:43< vultraz_iOS> the function is recursive, though, so you'll need to do some refactoring, maybe?
20170424 02:30:48-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 02:31:07-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 02:31:35< celticminstrel> Well, I need to switch from the wml_tag_porting branch before doing anything...
20170424 02:32:06< celticminstrel> I guess [or] really does need to calculate the full subfilter, but [and] and [not] really don't...
20170424 02:32:29< celticminstrel> Okay, so vultraz_iOS, are you okay with using a shared_ptr for music tracks? (Currently they're stored by value.)
20170424 02:32:44< vultraz_iOS> why would that be a problem
20170424 02:33:04< celticminstrel> Well, it does mean more heap allocations.
20170424 02:33:14< celticminstrel> And more indirection.
20170424 02:33:34< celticminstrel> And it's not like the current method is insecure - it's not using pointers at all right now.
20170424 02:34:36< celticminstrel> Though, right now, it does store two distinct copies of the currently-playing track - the one in the track list, and the one actually playing right now.
20170424 02:34:43< celticminstrel> It's not a huge problem since tracks are small, though.
20170424 02:35:21< celticminstrel> This is the track info I'm talking about, not the actual audio data.
20170424 02:37:04< vultraz_iOS> why do you need to do this anyway
20170424 02:37:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170424 02:37:22< celticminstrel> I want the Lua API to be able to shuffle around the order of the tracks.
20170424 02:37:41< vultraz_iOS> and....?
20170424 02:38:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3819:376c:bdf7:5fea] has quit [Remote host closed the connection]
20170424 02:38:42< celticminstrel> And that means it needs a way for a track to survive removal from the list.
20170424 02:39:11< vultraz_iOS> seems to me worth having a second vector that controls order
20170424 02:39:18< vultraz_iOS> with pointers or something, that can be shuffled
20170424 02:39:43< celticminstrel> In order to do something like "wesnoth.music_list[3], wesnoth.music_list[5] = wesnoth.music_list[5], wesnoth.music_list[3]", for example.
20170424 02:40:03< celticminstrel> Uhh. What's the point of having a separate vector when a vector already indicates an ordering?
20170424 02:41:13< vultraz_iOS> oh, I thought this was a master list of track metadata
20170424 02:41:28< celticminstrel> It's a list of metadata for the current playlist.
20170424 02:41:32< celticminstrel> And only the current playlist.
20170424 02:41:33< vultraz_iOS> ah
20170424 02:41:40< celticminstrel> It's not a list of metadata for every track known.
20170424 02:41:45< vultraz_iOS> well, i really don't have any opinion on this
20170424 02:42:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3819:376c:bdf7:5fea] has joined #wesnoth-dev
20170424 02:47:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:3819:376c:bdf7:5fea] has quit [Ping timeout: 258 seconds]
20170424 02:47:18-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 02:53:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170424 03:03:40-!- RatArmy_ [~ratarmy@126.237.124.26] has joined #wesnoth-dev
20170424 03:16:32< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 548ecb68cb9b / data/lua/wml-tags.lua: [kill] fixups https://github.com/wesnoth/wesnoth/commit/548ecb68cb9bc60007c02a7fd2d4008172d8179f
20170424 03:16:34< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c83809e7ae6c / src/scripting/lua_audio.cpp: Return nil instead of #wesnoth.playlist+1 when the current track is not on the p https://github.com/wesnoth/wesnoth/commit/c83809e7ae6cb5bfeae438792f5135c783bdd8ac
20170424 03:16:36< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting a6f67df9111f / src/ (scripting/lua_audio.cpp sound.cpp sound.hpp): Allow removing a track by index https://github.com/wesnoth/wesnoth/commit/a6f67df9111f35f76851631004c449b0597d2969
20170424 03:16:38< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting dd81221df297 / data/lua/wml-utils.lua src/scripting/lua_audio.cpp: commit -> force_refresh https://github.com/wesnoth/wesnoth/commit/dd81221df297524827b7dae1656d403ab16a9683
20170424 03:16:40< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 6e2c06598dd2 / data/lua/wml-tags.lua data/lua/wml-utils.lua src/scripting/lua_audio.cpp: playlist -> music_list https://github.com/wesnoth/wesnoth/commit/6e2c06598dd271cea0f35a89161b48983b18b46a
20170424 03:16:42< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5b79669e6908 / data/lua/wml-utils.lua src/actions/undo_action.cpp src/game_events/handlers.cpp: Commit music changes only after event completes, not after any control=flow tag  https://github.com/wesnoth/wesnoth/commit/5b79669e690839861382726ac12f6adda03a641e
20170424 03:16:44< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 7ea83d4bc70d / data/lua/backwards-compatibility.lua: Add wenoth.set_music compatibility function https://github.com/wesnoth/wesnoth/commit/7ea83d4bc70ddfbaa255a255a5e2f2dc11d417cb
20170424 03:16:46< irker929> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 6542ec75e747 / src/ (scripting/lua_audio.cpp sound.cpp sound.hpp): Allow inserting a track into the middle of the playlist https://github.com/wesnoth/wesnoth/commit/6542ec75e747489315aac37562fb044864b955b6
20170424 03:27:16-!- RatArmy_ [~ratarmy@126.237.124.26] has quit [Read error: Connection reset by peer]
20170424 03:31:40-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 03:33:03< irker929> wesnoth: Charles Dang wesnoth:master 288472b476c9 / src/gui/core/canvas.cpp: Don't use 0 in place of nullptr https://github.com/wesnoth/wesnoth/commit/288472b476c9c244deb5382b4bf377b5de9ba838
20170424 03:35:00-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170424 03:54:12-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170424 03:59:02-!- Kwandulin [~Kwandulin@p200300760F6D80CF615EC032E3CE3257.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 03:59:04-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 04:11:35-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 04:12:43-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170424 04:17:12< irker929> wesnoth: Celtic Minstrel wesnoth:master 067301ea9501 / changelog src/mouse_handler_base.cpp: Fix ability to scroll via minimap while view locked https://github.com/wesnoth/wesnoth/commit/067301ea9501b4aa4e26bc90babfd34fb203a90a
20170424 04:17:13< celticminstrel> Zooming is kinda broken.
20170424 04:17:14< irker929> wesnoth: Celtic Minstrel wesnoth:master ce9ec5912a33 / src/hotkey/command_executor.cpp: Disable zooming while view is locked https://github.com/wesnoth/wesnoth/commit/ce9ec5912a33afe301f20ffdbb7957e8174de7c9
20170424 04:17:22< celticminstrel> It doesn't preserve your location.
20170424 04:17:34< vultraz_iOS> I know
20170424 04:17:37< vultraz_iOS> I don't kno wwhy
20170424 04:17:41< celticminstrel> The viewport jumps around, with a preference for the right edge.
20170424 04:17:58< celticminstrel> Is there a way to figure out what tile is in the centre of the viewport?
20170424 04:18:10-!- un214 [~un214@76.14.112.211] has joined #wesnoth-dev
20170424 04:18:37< vultraz_iOS> I think so
20170424 04:19:01< vultraz_iOS> get_visible_hexes
20170424 04:19:36< celticminstrel> That doesn't sound like "centre" to me.
20170424 04:19:55< vultraz_iOS> it returns a rect of hexes
20170424 04:20:02< vultraz_iOS> you could get the center from there
20170424 04:20:34< celticminstrel> Eh? It returns a rectangle? From the name I assumed it returned a set<map_location>
20170424 04:21:00< vultraz_iOS> no there's literally a struct called rect_of_hexes
20170424 04:22:45< celticminstrel> I can see the hex borders on high zoom levels, and the selected hex leaves artifacts.
20170424 04:22:57< vultraz_iOS> yes
20170424 04:23:01< vultraz_iOS> dunno how to fix that
20170424 04:23:11-!- un214 [~un214@76.14.112.211] has quit [Remote host closed the connection]
20170424 04:26:57< celticminstrel> The math on lines 2030-1 of command_executor.cpp must be wrong, causing the view to jump weirdly.
20170424 04:27:15< celticminstrel> I could fix the math, or I could try using get_visible_hexes and the scroll to the centre...
20170424 04:27:16-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 04:27:22< celticminstrel> Fixing the math is probably more efficient...
20170424 04:27:25< vultraz_iOS> indeed
20170424 04:27:42< celticminstrel> I don't really understand what the math is doing though.
20170424 04:28:36< celticminstrel> ... whoa, a lot of Nam on this map.
20170424 04:29:29< vultraz_iOS> there's no 2030 in that file
20170424 04:30:06< celticminstrel> Sorry, display.cpp
20170424 04:30:18< celticminstrel> MSVC has this thing where it can display one file inline within the window of another.
20170424 04:30:49< vultraz_iOS> vs code too
20170424 04:30:52< celticminstrel> FTR, I tried commenting them out and changing += to just =; neither fixed it, though both did have some effect.
20170424 04:31:05< celticminstrel> Commenting them basically reversed the direction of the jumps.
20170424 04:31:17< celticminstrel> So instead of drifting right and down, it drifts up and left.
20170424 04:31:36< celticminstrel> Using = instead of += ... I think it just reduced the amount of the jump?
20170424 04:32:55< celticminstrel> The formula should probably use new_zoom instead of amount... though that shouldn't make a difference in most cases because new_zoom was set equal to amount at the top.
20170424 04:34:16< celticminstrel> Tooltips in MP Select still appear in the top left corner on 800x600 BTW.
20170424 04:34:25< celticminstrel> Must be something wrong with the tooltip formulas.
20170424 04:38:14< celticminstrel> Tried a few other things, still not getting it right. Probably need to figure out exactly what each variable means.
20170424 04:38:34< celticminstrel> Then work out what the formula should be.
20170424 04:50:57< vultraz_iOS> stop using 800x600 :|
20170424 04:51:05< celticminstrel> Never!
20170424 04:51:49< celticminstrel> Note though that some of your fancy dialogs didn't work even at 1024x768. (Of course I've mostly fixed that now, though.)
20170424 04:52:19< celticminstrel> There is actually one thing that bugs me about MP Create / Staging on low resolutions - the button positions are vastly different.
20170424 04:52:30< celticminstrel> I mean the okay/cancel buttons.
20170424 04:56:49< vultraz_iOS> you did that
20170424 04:56:58< celticminstrel> I know.
20170424 05:04:21-!- RatArmy_ [~ratarmy@126.237.124.26] has joined #wesnoth-dev
20170424 05:06:36< celticminstrel> Heh, all the image paths for the unitbox theme are broken... the images weren't removed, were they?
20170424 05:06:46< Aginor> you can't get rid of 800x600 or 1027x768 if you care about android versions
20170424 05:06:56< Aginor> otherwise, sure
20170424 05:07:00< celticminstrel> I'm not sure how to make the theme update in-game.
20170424 05:07:11< celticminstrel> Calling invalidate_theme() doesn't seem to help.
20170424 05:07:26< Aginor> it's unlikely that someone who has a grunty enough computer to run wesnoth will have a display old enough to not support a larger resolution 
20170424 05:07:30-!- Greg-Boggs [~greg_bogg@76.115.139.154] has joined #wesnoth-dev
20170424 05:07:38< vultraz_iOS> why android specifically
20170424 05:08:25< celticminstrel> I don't think 800x600 should be dropped unless there's a very good reason. Some people prefer gaming in a window, and why should we force them to use a huge window?
20170424 05:09:08< Aginor> celticminstrel: a very valid point
20170424 05:09:48< Aginor> vultraz_iOS: because iPhones tend to have higher resolutions, but android devices are still actively sold that has absolutely crap resolutions
20170424 05:10:14< vultraz_iOS> ah, so android sucks :P
20170424 05:10:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170424 05:11:05< Aginor> that's contempt culture
20170424 05:12:09< vultraz_iOS> (nah, android is actually pretty alright itself)
20170424 05:15:17< vultraz_iOS> return controller_.get_context_manager().get_map_context().get_time_manager()->get_time_of_day();
20170424 05:15:18< vultraz_iOS> \o/
20170424 05:15:31< celticminstrel> o.o
20170424 05:16:44< vultraz_iOS> get ALL THE THINGS
20170424 05:19:32< Aginor> so many things that could be null :D
20170424 05:22:19< vultraz_iOS> what happens when you have to pull something from the depths of an ownership stack
20170424 05:27:53-!- Greg-Boggs [~greg_bogg@76.115.139.154] has quit [Remote host closed the connection]
20170424 05:31:44-!- Kwandulin [~Kwandulin@p200300760F6D80CF615EC032E3CE3257.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170424 05:31:57-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has joined #wesnoth-dev
20170424 05:34:39< vultraz_iOS> nuuuuuuuuuuuuuuuuuuu
20170424 05:34:48< vultraz_iOS> the Assign Time Schedule menu is broken ;_;
20170424 05:35:45-!- celticminstrel is now known as celmin|sleep
20170424 05:38:12-!- RatArmy_ [~ratarmy@126.237.124.26] has quit [Read error: Connection reset by peer]
20170424 05:38:35-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 05:39:31< vultraz_iOS> celmin|sleep: ping ping ping
20170424 05:42:46< vultraz_iOS> celmin|sleep: we broke sub-menus that require generation..
20170424 05:42:59< vultraz_iOS> possibly when i reverted part of the handling to std::string..
20170424 05:48:45-!- sevu [~Unknown@p5485597C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 05:49:07< sevu> We're having a spambot on the forum
20170424 05:49:58< vultraz_iOS> *ban hammer*
20170424 05:50:14< vultraz_iOS> sevu: fixed
20170424 05:50:15< sevu> =)
20170424 05:54:29-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170424 05:54:30-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 06:03:58-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 06:04:50-!- sevu [~Unknown@p5485597C.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170424 06:06:21< zookeeper> mattsc, interesting find
20170424 06:20:04< DeFender1031> it sounds like intersect and negation filters are generating the entire sub-filter set and then performing the intersect/negation rather than running directly on the outer result set to further limit it. In essence: "1. generate outer set 2. generate inner set 3. calculate intersect" instead of "1. generate outer set 2. run through outer set removing anything not matched by inner filter"
20170424 06:20:05-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 06:20:58< DeFender1031> (where the latter code would be more efficient)
20170424 06:29:27-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170424 06:33:11< vultraz_iOS> DeFender1031: exactly
20170424 06:36:02< irker929> wesnoth: Charles Dang wesnoth:master 4656cbfd511f / src/editor/controller/ (editor_controller.cpp editor_controller.hpp): Editor Controller: add getter for current map context https://github.com/wesnoth/wesnoth/commit/4656cbfd511fcb4333d568932bfe8e0e1947c689
20170424 06:36:12< irker929> wesnoth: Charles Dang wesnoth:master 21add65dca85 / src/editor/ (controller/editor_controller.cpp editor_display.cpp editor_display.hpp): Editor Display: override display::get_tod_man and display::get_time_of_day https://github.com/wesnoth/wesnoth/commit/21add65dca858dfbf629f1ac42f5a5d412ab7874
20170424 06:36:12< irker929> wesnoth: Charles Dang wesnoth:master fa5e7fe73c67 / src/editor/controller/editor_controller.cpp: Editor: use proper method to update ToD coloring https://github.com/wesnoth/wesnoth/commit/fa5e7fe73c676d0db56c41abd96a10e9d1e87834
20170424 06:36:41< vultraz_iOS> irker y u do dis
20170424 06:36:53< vultraz_iOS> report all the commits! :(
20170424 06:37:11< irker929> wesnoth: Charles Dang wesnoth:master 9e812f9122f0 / src/ (image.cpp image.hpp): Removed the color_adjustment_resetter https://github.com/wesnoth/wesnoth/commit/9e812f9122f078b99272b4d24cbfe49dda32ffc8
20170424 06:37:15< irker929> wesnoth: Charles Dang wesnoth:master 4c0422d49116 / src/ (display.cpp display.hpp): Allow manual override of ToD color used in display::update_tod https://github.com/wesnoth/wesnoth/commit/4c0422d491166db4b777fa38001bcab3028ab510
20170424 06:37:27< vultraz_iOS> \o/
20170424 06:46:59< irker929> wesnoth: Charles Dang wesnoth:master e44723222231 / src/ (3 files in 2 dirs): GUI2/Custom ToD: stop using the adjust_color_overlay mechanism (not fully workin https://github.com/wesnoth/wesnoth/commit/e44723222231f8a156ecdb2e19f016317e3764e8
20170424 06:49:03< vultraz_iOS> for the life of me I can't figure out why that doesn't work
20170424 06:54:49-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170424 06:58:07< DeFender1031> what's not working?
20170424 06:58:18< vultraz_iOS> above commit
20170424 06:58:21< DeFender1031> ah
20170424 06:58:24< DeFender1031> hey deathisundead
20170424 06:58:31< deathisundead> Hey
20170424 06:58:34< vultraz_iOS> the change in codepath means only one thing isn't called..
20170424 07:01:55-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has joined #wesnoth-dev
20170424 07:07:52< vultraz_iOS> DeFender1031: your addon generates a whole bunch of Invalid Anchor warnings in your terrain WML
20170424 07:09:00< DeFender1031> what's an invalid anchor?
20170424 07:09:59< vultraz_iOS> ask zookeeper 
20170424 07:10:04< vultraz_iOS> something to do with pos=?
20170424 07:10:20< DeFender1031> whatever it is, though, i'm not surprised. A lot of my code is terrible because I didn't really know what I was doing. Still don't, in certain areas (like terrain graphics)
20170424 07:10:45< deathisundead> Noone knows that.
20170424 07:11:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170424 07:13:26< vultraz_iOS> zookeeper: is the only one who knows
20170424 07:13:44< zookeeper> \o/
20170424 07:14:37< DeFender1031> yeah, I've learned that there are certain people to go to for certain areas. GUI2? Ask vult. AI? Ask matt. Terrain graphics? That's zookeeper's department. LUA API? Celmin.
20170424 07:14:50< DeFender1031> zookeeper, so what IS an invalid anchor?
20170424 07:15:12< vultraz_iOS> *eh em* is it an anchor that is invalid :> 
20170424 07:15:26< zookeeper> probably some kind of mismatch with your map= and [tile]s
20170424 07:16:24< zookeeper> such as that map= that is missing entirely at the top of your terrain-graphics-cliff.cfg
20170424 07:16:37< zookeeper> oh wait it's just macroified, nevermind
20170424 07:17:10< zookeeper> well, it's still those macros i suppose, seeing how not all the maps that get used have positions 1-6
20170424 07:17:21< DeFender1031> right. there's a bunch of crap and testing code in there that i'm not actually using
20170424 07:18:36< DeFender1031> that stuff in particular is from when I was playing with the idea of having a cliff terrain, when I was saying that there should be a way to have boundaries on certain hex edges but not others. (Still think it's a good idea, but there's no way it'll happen any time soon.)
20170424 07:18:43< DeFender1031> none of it is actually in use.
20170424 07:19:19< DeFender1031> Honestly, if you actually look through the add-on, you'll find all sorts of stuff i'm somewhat embarassed to have seen yet/at all
20170424 07:19:21-!- RatArmy_ [~ratarmy@om126237124026.9.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 07:19:23< DeFender1031> :P
20170424 07:20:40< deathisundead> DeFender1031: You didn't add that, it was the WML Gnomes. They come in and add random things, and also misspell words.
20170424 07:20:49< DeFender1031> hehehehe
20170424 07:21:24< deathisundead> Probably same thing happened with the ToD code vultraz_iOS was working on.
20170424 07:22:10< DeFender1031> yeah, a couple of weeks ago I found a typo in one of my lines of dialogue that's been there for a year and a half and that I must have read hundreds of times, sometimes while showing to friends of mine who also never caught it. Only explanation is that it was never like that until the gnomes.
20170424 07:29:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170424 07:29:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170424 07:39:44< deathisundead> 1.14 seems to be coming along O_o
20170424 07:43:49< vultraz_iOS> indeed
20170424 08:01:04-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170424 08:54:40-!- JyrkiVesterinen [~JyrkiVest@85-76-70-126-nat.elisa-mobile.fi] has quit [Quit: .]
20170424 09:25:36-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170424 09:47:24-!- irker929 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170424 10:01:12-!- RatArmy_ [~ratarmy@om126161114122.8.openmobile.ne.jp] has joined #wesnoth-dev
20170424 10:32:20-!- RatArmy_ [~ratarmy@om126161114122.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 10:48:03-!- RatArmy_ [~ratarmy@om126161114122.8.openmobile.ne.jp] has joined #wesnoth-dev
20170424 11:30:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 11:54:04-!- Kwandulin [~Kwandulin@p200300760F6D80CF615EC032E3CE3257.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 11:54:12< celmin|sleep> 
20170424 11:54:13< celmin|sleep> [Apr 24@01:42:46am] vultraz_iOS: celmin|sleep: we broke sub-menus that require generation..
20170424 11:54:14< celmin|sleep> [Apr 24@01:43:00am] vultraz_iOS: possibly when i reverted part of the handling to std::string..
20170424 11:54:14< celmin|sleep> Almost certainly when you did that, given that that was what led to the warnings matthiaskrgr posted about,
20170424 12:01:47-!- celmin|sleep is now known as celticminstrel
20170424 12:08:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170424 12:10:17< Kwandulin> Any release schedule? I am super excited for the new stuff that is being worked on
20170424 12:13:30< celticminstrel> As in a timeline towards 1.14? Not that I know of.
20170424 12:13:46< celticminstrel> Other than that 1.13.8 is scheduled for May 30th.
20170424 12:14:10< celticminstrel> Do we feature freeze at that point?
20170424 12:14:21< celticminstrel> Or does feature freeze come at the RC stage?
20170424 12:18:51< Kwandulin> Ah, didnt see the topic
20170424 12:23:44-!- Kwandulin [~Kwandulin@p200300760F6D80CF615EC032E3CE3257.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20170424 12:26:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 12:32:25-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 12:47:07-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has joined #wesnoth-dev
20170424 12:47:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170424 13:05:35-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170424 13:10:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170424 13:18:42-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has quit [Remote host closed the connection]
20170424 13:20:27< mattsc> zookeeper: Thanks, I thought so too.  And it is not at all what I expected to find.
20170424 13:21:43< celticminstrel> Hmm, is there a way to get the game_data from the game_display...
20170424 13:22:03< celticminstrel> I guess maybe it's not needed, I can just set the value in two places...
20170424 13:36:01-!- RatArmy_ [~ratarmy@om126161114122.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 14:01:40-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170424 14:01:54< vultraz_iOS> celticminstrel: how should I fix
20170424 14:02:07< celticminstrel> Simplest fix would be to revert d18b94d
20170424 14:02:12< vultraz_iOS> nein!
20170424 14:02:35< celticminstrel> I think that's the right commit.
20170424 14:02:47< celticminstrel> Or maybe not?
20170424 14:03:03-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 14:03:15< celticminstrel> Uh, the commit where you partially switched back to vector<string>.
20170424 14:03:18< celticminstrel> Which commit is that?
20170424 14:03:37< celticminstrel> Oh, 42cb55fa?
20170424 14:04:09< celticminstrel> Okay, so what's the class hierarchy for those classes touched in 7d2d100?
20170424 14:04:44< vultraz_iOS> very weird
20170424 14:06:13< celticminstrel> controller_base is touched... display::enable_menu... editor_controller... context_manager... the palette classes... wmi_container... command_executor... play_controller::hotkey_handler... that seems to be it?
20170424 14:06:44< celticminstrel> I know editor_controller inherits from controller_base, what about command_executor or play_controller::hotkey_handler?
20170424 14:06:47< vultraz_iOS> sounds about right
20170424 14:07:15< vultraz_iOS> they all defer to command_executor's base method in the end, either via an object or base inheritance 
20170424 14:07:16< celticminstrel> I think I wouldn't expect the latter one to, because play_controller presumably inherits from controller_base,
20170424 14:08:10< vultraz_iOS> I basically need that function to defer back to the caller, not loop back to itself
20170424 14:08:32< celticminstrel> So 42cb55f changes controller_base and editor_controller...
20170424 14:09:02< celticminstrel> But leaves command_executor...
20170424 14:09:38< vultraz_iOS> matthiaskrgr gets the warning because now not all the functions override each other
20170424 14:09:42< celticminstrel> Okay, command_executor doesn't inherit from controller_base, so that should be fine...
20170424 14:11:45< celticminstrel> play_controller doesn't override show_menu anyway...
20170424 14:11:54 * celticminstrel doesn't remember exactly where matthiaskrgr got the warnings.
20170424 14:12:22< vultraz_iOS> because a function that takes a vector<string> is overriding one that takes vector<config>
20170424 14:12:28< celticminstrel> Wrong.
20170424 14:12:35< vultraz_iOS> oh?
20170424 14:12:38< vultraz_iOS> i thought that was it
20170424 14:12:40< celticminstrel> It's not overriding, that's the problem.
20170424 14:12:51< celticminstrel> To override, the signatures have to be identical.
20170424 14:12:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20170424 14:12:59< vultraz_iOS> right
20170424 14:13:01< celticminstrel> Maybe you meant overload though?
20170424 14:13:12< celticminstrel> Do you have matthiaskrgr's pastebin still?
20170424 14:14:32< vultraz_iOS> no
20170424 14:24:00< matthiaskrgr> I can get a new one
20170424 14:24:34 * matthiaskrgr rebuilds
20170424 14:28:54-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: .]
20170424 14:33:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170424 14:37:59-!- irker887 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170424 14:37:59< irker887> wesnoth: Charles Dang wesnoth:master 0708b866a3b5 / src/editor/ (controller/editor_controller.cpp editor_display.cpp editor_display.hpp): Drop some useless arguments from editor_display https://github.com/wesnoth/wesnoth/commit/0708b866a3b5c07b0cb0cf3ce0f7021f172c7e7b
20170424 14:38:00< irker887> wesnoth: Charles Dang wesnoth:master 62fd603ad29d / src/display.cpp: Display: deploy some range-for and auto https://github.com/wesnoth/wesnoth/commit/62fd603ad29dc1f39d0a9f091e01dad698f9a980
20170424 14:39:52< matthiaskrgr> vultraz_iOS: 
20170424 14:39:52< matthiaskrgr> celticminstrel: 
20170424 14:39:55< matthiaskrgr> https://pastebin.com/ds07prbV  
20170424 14:40:13< matthiaskrgr> bbl 
20170424 14:40:13< vultraz_iOS> it's back!
20170424 14:40:41< matthiaskrgr> log is based on   e44723222231f8a156ecdb2e19f016317e3764e8  fyi 
20170424 14:46:24< irker887> wesnoth: Charles Dang wesnoth:master 872dc7646dfc / src/editor/editor_display.hpp: Editor Display: add more override specifiers https://github.com/wesnoth/wesnoth/commit/872dc7646dfcdad4315908dd3646264523d90953
20170424 14:46:26< vultraz_iOS> matthiaskrgr: ^
20170424 14:47:47-!- TC01 [~quassel@venus.arosser.com] has quit [Read error: Connection reset by peer]
20170424 14:48:31-!- TC01 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170424 14:50:21< celticminstrel> editor_controller::show_menu hides command_executor::show_menu? o.o
20170424 14:50:43< celticminstrel> editor_controller inherited from command_executor?
20170424 14:50:59< vultraz_iOS> command_executor_default
20170424 14:51:04< vultraz_iOS> so simple, you said
20170424 14:51:09< vultraz_iOS> not confusing, you said
20170424 14:51:14< vultraz_iOS> :P
20170424 14:51:18< celticminstrel> Okay, so, it seems like the situation is pretty simple.
20170424 14:51:34< celticminstrel> Previously, editor_controller had a single function that override two superclass functions.
20170424 14:51:45 * celticminstrel is assuming editor_controller also inherits from controller_base.
20170424 14:51:54< celticminstrel> You changed the signature of one of those superclass functions.
20170424 14:51:56< vultraz_iOS> yes
20170424 14:52:03< celticminstrel> Now the overridden function isn't being called when it should be.
20170424 14:52:15< celticminstrel> I think reverting the commit is still easiest.
20170424 14:52:43< vultraz_iOS> but it will have conflicts ;_;
20170424 14:52:58< celticminstrel> So you don't mind if I revert it, then?
20170424 14:53:11< vultraz_iOS> well, I dunno..
20170424 14:53:19< vultraz_iOS> it *is* how it should have been done
20170424 14:54:48< vultraz_iOS> if a base class method calls itself when invoked from a derived class does it call the override in the derived class?
20170424 14:55:01< celticminstrel> Yes.
20170424 14:55:05< vultraz_iOS> ...huh
20170424 14:55:05< celticminstrel> Wait.
20170424 14:55:27< celticminstrel> Hold on, you're talking about controller_base::show_menu calling controller_base::show_menu?
20170424 14:56:02< celticminstrel> Um. I think that would indeed invoke the derived show_menu?
20170424 14:56:12< celticminstrel> But, it might not.
20170424 14:56:18< vultraz_iOS> no command_executor::show_menu calling editor_controller::show_meu
20170424 14:56:25< celticminstrel> Because to even get to that point, you would've had to bypass virtual dispatch.
20170424 14:56:39< vultraz_iOS> see
20170424 14:57:05< vultraz_iOS> actually no..
20170424 14:57:20< vultraz_iOS> honestly I don't know how this worked
20170424 14:58:46< vultraz_iOS> or what the best solution is
20170424 15:03:24< celticminstrel> Still think the easiest solution is reverting the offending commit. If your only argument against that is that it could cause conflicts, then it shouldn't be a problem if someone else does it for you, right?
20170424 15:05:05< vultraz_iOS> well, the original reason for it still stands - it's more optimal
20170424 15:05:23< celticminstrel> True.
20170424 15:05:36< celticminstrel> But it's better to have working code than optimal code, if you have to choose.
20170424 15:06:19< celticminstrel> The numbers in zoom_levels are actual pixel size, right?
20170424 15:06:58< vultraz_iOS> yes
20170424 15:07:37< celticminstrel> Hmm, why does validate_value_and_set_index just bail out instead of selecting the nearest match?
20170424 15:08:10< vultraz_iOS> in order to prevent arbitrary values
20170424 15:08:22< celticminstrel> ...you didn't read what I said, did you.
20170424 15:09:20< vultraz_iOS> I did.
20170424 15:09:28< vultraz_iOS> I meant it to do nothing with invalid values at all
20170424 15:09:36< vultraz_iOS> though I suppose nearest match could work
20170424 15:10:05< celticminstrel> It's fine that you meant it, but saying "in order to prevent arbitrary values" in response to "why not just select the nearest match" is pretty nonsensical.
20170424 15:10:21< celticminstrel> Since the nearest match would in fact not be an arbitrary value.
20170424 15:10:31< celticminstrel> BTW, why do we prevent arbitrary values?
20170424 15:10:55< vultraz_iOS> because we only allow specific values now
20170424 15:11:43< celticminstrel> So should Lua be allowed to override that or not?
20170424 15:12:09< vultraz_iOS> no
20170424 15:12:30< celticminstrel> Okay, need to decide whether to use lower_bound or upper_bound...
20170424 15:19:15< celticminstrel> Do you think default zoom should be 100 or 1.0?
20170424 15:20:57< vultraz_iOS> What!
20170424 15:21:05< vultraz_iOS> ?
20170424 15:21:07< vultraz_iOS> Sorry
20170424 15:21:10< vultraz_iOS> Not !
20170424 15:21:15< vultraz_iOS> It's 72
20170424 15:21:28< vultraz_iOS> Whatever index that is
20170424 15:21:30< celticminstrel> That's not very user-friendly.
20170424 15:21:45< celticminstrel> I'm asking whether you'd prefer a fraction or a percentage, basically.
20170424 15:23:04< vultraz_iOS> 1.0 seems more reasonable
20170424 15:27:38< vultraz_iOS> I didn't meant for there to be a user-facing interface
20170424 15:27:40< vultraz_iOS> Mean
20170424 15:28:08< celticminstrel> ?
20170424 15:28:52< vultraz_iOS> You said the index-based system isn't user friendly
20170424 15:29:06< vultraz_iOS> I said I never intended for users to use it
20170424 15:32:21< vultraz_iOS> ah, so VS Code uses clang-format 3.8
20170424 15:39:49< vultraz_iOS> the useful things you learn when opening a bug report
20170424 15:42:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170424 15:49:11< Kwandulin> Uh, how comes a unit-specific ability in the help menu doesn*t link to the unit that has that ability? (1.13.7)
20170424 15:50:30< Kwandulin> https://www.dropbox.com/s/px5h8dwj76cxdat/ability.png?dl=0
20170424 15:50:43< Kwandulin> second one gets linked, first one not
20170424 15:52:55< celticminstrel> Weird...
20170424 15:53:14< zookeeper> both are discovered units, right? although if the first one wasn't, i'd expect it to not be listed at all.
20170424 15:53:43< Kwandulin> Uh, I'll check
20170424 15:54:57< Kwandulin> Yeah, both are discovered
20170424 15:55:43< Kwandulin> If I enter the help menu within debug mode, the name of the not-available unit is red and if I click on it, it says "Reference to unknown topic: 'unit_Genie_Altawir
20170424 15:56:53< zookeeper> any funny characters in its name/id?
20170424 15:57:09< zookeeper> if not then i'm out of guesses
20170424 15:57:11< Kwandulin> A space
20170424 15:57:53< Kwandulin> A space in its name and a _ in its id
20170424 15:59:36< Kwandulin> Changing the _ in the id to a blank space doesn't change a thing
20170424 15:59:37< matthiaskrgr> vultraz_iOS:  https://pastebin.com/ZHmewPp5  
20170424 16:00:58-!- gfgtdf [~chatzilla@x4e363058.dyn.telefonica.de] has joined #wesnoth-dev
20170424 16:15:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 16:20:09< irker887> wesnoth: Celtic Minstrel wesnoth:master 58ee985c5b7f / src/scripting/ (game_lua_kernel.cpp lua_common.hpp lua_unit.cpp): Lua: Add float mutator macros and some fixups/cleanup to other mutator/accessor  https://github.com/wesnoth/wesnoth/commit/58ee985c5b7f0d9d663f56f051fa78b15e20a14b
20170424 16:20:11< irker887> wesnoth: Celtic Minstrel wesnoth:master b6212132a25d / src/scripting/lua_common.hpp: Lua: Wrap accessor/mutator macros in do...while https://github.com/wesnoth/wesnoth/commit/b6212132a25d8afeb45b5fc66602a71d33951ff6
20170424 16:20:13< irker887> wesnoth: Celtic Minstrel wesnoth:master b9a35fa8707c / / (5 files in 3 dirs): Allow changing theme while in a game https://github.com/wesnoth/wesnoth/commit/b9a35fa8707ca1d9aa93f6d65a0e66244f8ccbea
20170424 16:20:15< irker887> wesnoth: Celtic Minstrel wesnoth:master 1fb4d36ef850 / changelog data/lua/wml-tags.lua src/scripting/game_lua_kernel.cpp: Enable scenarios to change theme in an event https://github.com/wesnoth/wesnoth/commit/1fb4d36ef850f7ae7b9b81317f912bc3b0a60d9a
20170424 16:20:17< irker887> wesnoth: Celtic Minstrel wesnoth:master 7f0ab4bcf5d7 / src/preferences_display.cpp: Fix scenario theme being overridden when changing theme in prefs https://github.com/wesnoth/wesnoth/commit/7f0ab4bcf5d7fe114cb0482d5fcd05b093b3ceee
20170424 16:20:19< irker887> wesnoth: Celtic Minstrel wesnoth:master 062046760d36 / data/ (core/images/themes/unit_box/status-bg.png themes/unit_box.cfg): Fix most of the missing image errors in the UnitBox theme https://github.com/wesnoth/wesnoth/commit/062046760d3604b377fb6dd77527fa9951ac987d
20170424 16:20:21< irker887> wesnoth: Celtic Minstrel wesnoth:master 66f4c2ba3d56 / / (5 files in 4 dirs): Add WML tag to change the map zoom level https://github.com/wesnoth/wesnoth/commit/66f4c2ba3d56fcc01444fea4e3d75efc7ea1b82c
20170424 16:20:23< irker887> wesnoth: Celtic Minstrel wesnoth:master 86505e58a416 / src/ (9 files in 4 dirs): Revert "Revert an unnecessary part of 7d2d100" https://github.com/wesnoth/wesnoth/commit/86505e58a416c216be2ea2936cdbaaed03366e91
20170424 16:20:25< irker887> wesnoth: Celtic Minstrel wesnoth:master 00a461626bbb / src/map/label.cpp: Fix an uninitialized variable warning https://github.com/wesnoth/wesnoth/commit/00a461626bbbd15ddd72186f6159072cb1e9ec17
20170424 16:20:46-!- sevu [~Unknown@141.57.59.163] has joined #wesnoth-dev
20170424 16:24:05< gfgtdf> why do we need all those return_..._attrib macors in the first place? shouldn't with lua_push beeing a template one macro be enough ?
20170424 16:24:24< celticminstrel> Maybe.
20170424 16:24:41< celticminstrel> Though you might still need a separate macro for configs?
20170424 16:26:31< gfgtdf> celticminstrel: hmm i'd think that lua_push  also supports configs
20170424 16:26:48< celticminstrel> Not sure if it does or not.
20170424 16:27:25< celticminstrel> I do know that the luaW functions for getting configs from the stack do not conform to the interface of the luaL functions for getting things from the stack.
20170424 16:27:40< celticminstrel> For example, taking a config reference and returning bool, rather than returning a config pointer.
20170424 16:27:41< gfgtdf> celticminstrel: also did you see my mesage eariler:
20170424 16:27:41< vultraz_iOS> you should have removed the uses of status-bg
20170424 16:27:42< gfgtdf> 20170422 12:04:37< gfgtdf> i'm thinking about optimising lua unit getter/setter methods to do less string comparisions, so whta i want to do is to replace all those return_xxx strcmp with a big switch satement,  and then use a map string -> int/enum where the later is the index to the switch satement.
20170424 16:27:46< gfgtdf> 20170422 12:05:32< gfgtdf> bug what i'm unsure about is what is teh bast type of map i could: 1) use unordered map 2) use a lua table and then use lua_gettable
20170424 16:28:00< celticminstrel> vultraz_iOS: Feel free to do that if you know how.
20170424 16:29:12< gfgtdf> 'replace all those return_xxx ' here doesnt men dlete the macros but dont use then unit unit getter/setter
20170424 16:29:18< gfgtdf> them*
20170424 16:32:22< gfgtdf> have to go
20170424 16:32:24-!- gfgtdf [~chatzilla@x4e363058.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 52.0.2/20170323105023]]
20170424 16:36:05< vultraz_iOS> matthiaskrgr: stuff should be fixed now btw
20170424 16:39:48-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has joined #wesnoth-dev
20170424 16:43:55< vultraz_iOS> I hate regxp....
20170424 16:46:44< celticminstrel> I think I remember gfgtdf saying that, but wasn't it a couple days ago?
20170424 16:47:31< vultraz_iOS> are they designed to return only the first result or something
20170424 16:47:38< celticminstrel> ?
20170424 16:47:52< vultraz_iOS> SDL_Rect (.*?) = {
20170424 16:47:58< vultraz_iOS> gives me exactly 1 result
20170424 16:48:02< vultraz_iOS> despite me knowing there are more
20170424 16:48:21< celticminstrel> What, in grep?
20170424 16:48:38< vultraz_iOS> vscode search w/ regxp
20170424 16:49:06< irker887> wesnoth: Charles Dang wesnoth:master ae906d69a521 / src/controller_base.cpp: Restore cleanup lost in 86505e58a https://github.com/wesnoth/wesnoth/commit/ae906d69a521aae902d6330ae458cfb53e4dd583
20170424 16:49:23< vultraz_iOS> (how many times is that poor config_assign.hpp include going to be added or removed :P )
20170424 16:49:39< celticminstrel> One million times!
20170424 16:50:31< vultraz_iOS> but really, is regxp designed to just return 1 match or something
20170424 16:51:03< celticminstrel> git grep -P returns 19 results for that regex
20170424 16:51:20< vultraz_iOS> god dammit :|
20170424 16:51:35< vultraz_iOS> oh wait
20170424 16:51:39< celticminstrel> I don't know how VSCode works, but generally a text editor just finds the next result.
20170424 16:51:41< vultraz_iOS> SDL_Rect.*= [{] works
20170424 16:51:45< vultraz_iOS> weird..
20170424 16:51:50< celticminstrel> Ah.
20170424 16:51:54< vultraz_iOS> why
20170424 16:52:00< celticminstrel> { is indeed a special character in some regex flavours.
20170424 16:52:20< celticminstrel> Though usually it's more contextual and will work if it doesn't form a valid quantifier?
20170424 16:52:48< celticminstrel> What regex flavour does VSCode use, anyway?
20170424 16:53:43< vultraz_iOS> javascript, apparently
20170424 16:56:19< matthiaskrgr> vultraz_iOS: well, build still failing https://pastebin.com/YSWtQWKT  
20170424 16:56:39< vultraz_iOS> celticminstrel: 
20170424 16:57:07< matthiaskrgr> but until the failure, the warnings are gone, yes  :)
20170424 16:59:47< celticminstrel> matthiaskrgr: I'm assuming removing the FALLTHROUGH fixes it?
20170424 16:59:53< celticminstrel> Possibly more than one of them.
20170424 16:59:59< matthiaskrgr> yeah
20170424 17:00:10< celticminstrel> I just need to remove the last one then?
20170424 17:00:19< matthiaskrgr> let me see
20170424 17:00:55< celticminstrel> I guess there's not much point in keeping the second, either. I'd like to keep the first though.
20170424 17:02:41< matthiaskrgr> looks like build continues when I make line 49
20170424 17:02:46< matthiaskrgr> case child:;  
20170424 17:03:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 17:04:48< irker887> wesnoth: Celtic Minstrel wesnoth:master d4f91674391a / src/gui/auxiliary/iterator/walker_widget.cpp: Fix a clang compiler error https://github.com/wesnoth/wesnoth/commit/d4f91674391a92943056e5717266825172dd5342
20170424 17:06:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 17:06:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170424 17:12:36-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170424 17:24:30< matthiaskrgr> ok I can build again \o/
20170424 17:33:15-!- travis-ci [~travis-ci@54.92.139.174] has joined #wesnoth-dev
20170424 17:33:16< travis-ci> wesnoth/wesnoth#13522 (master - 00a4616 : Celtic Minstrel): The build has errored.
20170424 17:33:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/225276302
20170424 17:33:16-!- travis-ci [~travis-ci@54.92.139.174] has left #wesnoth-dev []
20170424 17:33:41< vultraz_iOS> :o
20170424 17:33:48< vultraz_iOS> a wild travis appears!
20170424 17:34:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 17:35:14-!- stikonas_ is now known as stikonas
20170424 17:35:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 17:40:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170424 17:41:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 17:44:32< celticminstrel> So it errored only because the Mac build timed out.
20170424 17:45:46< irker887> wesnoth: Charles Dang wesnoth:master 0031f9a45af5 / src/ (23 files in 13 dirs): Don't copy-initialize containers https://github.com/wesnoth/wesnoth/commit/0031f9a45af5ca7fa0cfe0a569ea73666f6835bf
20170424 17:46:01< vultraz_iOS> ...where is the other commit
20170424 17:46:26< celticminstrel> Maybe you forgot to commit it?
20170424 17:46:38< vultraz_iOS> no, it's there..
20170424 17:46:39< vultraz_iOS> weird
20170424 17:46:45< vultraz_iOS> not reported but it was pushed
20170424 17:46:57< vultraz_iOS> oh hey, 68,500th commit
20170424 17:47:02< celticminstrel> Heh.
20170424 17:47:14< matthiaskrgr> wooot travis is back !? finally !! 
20170424 17:48:26< celticminstrel> Hmm, was there something else I was going to do? Other than stuff that's on branches.
20170424 17:50:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170424 17:54:51-!- sevu [~Unknown@141.57.59.163] has quit [Remote host closed the connection]
20170424 18:00:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 18:03:45-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170424 18:22:23-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170424 18:23:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 18:24:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 18:24:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 18:24:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 18:48:40-!- markus_ [~mjs-de@x4e345d51.dyn.telefonica.de] has joined #wesnoth-dev
20170424 18:50:54< celticminstrel> Right, wml_tag_porting rebased, now I just have to figure out how to do the thing I want to do on it...
20170424 18:52:23-!- mjs-de [~mjs-de@x4db53ed9.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170424 19:03:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 19:43:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170424 19:44:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 20:05:44-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170424 20:06:30< celticminstrel> If only there was some way to execute a different codepath on "wesnoth.music_list[1].once = true" than on "local thing = wesnoth.music_list[1]; thing.once = true"...
20170424 20:14:54< DeFender1031> why... would you want that?
20170424 20:16:29< celticminstrel> TBH I'm not even quite sure what I want, which is part of the problem, but... the first version would update the track in-place while the second would only update a copy of it... but I think that can't really work in Lua. It's basically value semantics, which is kinda foreign to Lua.
20170424 20:16:38< celticminstrel> (If I understand correctly.)
20170424 20:17:31< DeFender1031> yeah... all objects are references to the same object unless copied
20170424 20:17:59 * celticminstrel meant the IIUC to apply to "it's basically value semantics".
20170424 20:18:41< DeFender1031> i still don't know in what situation you'd want to change it in one place but not the other, except when soing something further with the local one, in which case you can perform a copy when grabbing it for the local variable
20170424 20:19:49< celticminstrel> I'm trying to somehow have a persistent reference to it without actually using a pointer, I guess.
20170424 20:20:14< celticminstrel> Maybe I should just use a pointer.
20170424 20:20:16< DeFender1031> meh.
20170424 20:20:35< DeFender1031> seems like a place that doesn't need that kind of optimization
20170424 20:20:55< DeFender1031> (and i'm usually the last to ignore potential performance issues)
20170424 20:21:23< DeFender1031> but how many tracks are there likely to be? even if every mainline song is on the list, that's what? 30?
20170424 20:21:26< celticminstrel> Well, I this to be valid though: "local thing = wesnoth.music_list[1]; wesnoth.music_list.remove(1); print(thing.name)"
20170424 20:21:44< celticminstrel> The default playlist is 25 tracks. I think that's not quite all the mainline songs.
20170424 20:21:52< DeFender1031> fine
20170424 20:22:10< DeFender1031> point is, a pointer shouldn't be too much extra overhead for that kind of situation.
20170424 20:23:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170424 20:26:05-!- flowerhack [uid6775@gateway/web/irccloud.com/x-lnpxhpjjkowhnskj] has joined #wesnoth-dev
20170424 20:38:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170424 20:38:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 21:01:57-!- markus_ [~mjs-de@x4e345d51.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170424 21:19:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 21:26:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 21:31:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170424 21:32:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 21:37:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170424 21:40:29< celticminstrel> Oh wow, sound.cpp has a test for SDL 1.2.
20170424 21:41:03< celticminstrel> Also, Travis reported once but still is mostly failing to report...
20170424 21:50:27-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170424 21:56:56< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5596e6682f97 / / (4 files in 3 dirs): Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/5596e6682f974abb0488daab5f31089a59c0dc1b
20170424 21:56:58< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 7cd638ffcccb / / (4 files in 3 dirs): Properly port [scroll] to Lua https://github.com/wesnoth/wesnoth/commit/7cd638ffcccba1e4cbf22c4dee48028b9b667314
20170424 21:57:00< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 3793951208e6 / / (15 files in 6 dirs): Properly port [music] to Lua https://github.com/wesnoth/wesnoth/commit/3793951208e6de9b4a83599e7a4414c1bc89c2be
20170424 21:57:02< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting e0141d7fff85 / src/scripting/lua_audio.cpp: Return nil instead of #wesnoth.playlist+1 when the current track is not on the p https://github.com/wesnoth/wesnoth/commit/e0141d7fff85794517b0ee0732ba261ce26eee30
20170424 21:57:04< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 81524103c184 / / (7 files in 5 dirs): Port [volume] to Lua https://github.com/wesnoth/wesnoth/commit/81524103c18446a8a3c5fbd0d7337fc3c31c36de
20170424 21:57:06< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 1cd4b366d9e6 / src/ (scripting/lua_audio.cpp sound.cpp sound.hpp): Allow removing a track by index https://github.com/wesnoth/wesnoth/commit/1cd4b366d9e6db2cea168e931c1e96802f947005
20170424 21:57:08< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 78eee8c8438b / data/lua/wml-utils.lua src/actions/undo_action.cpp src/game_events/handlers.cpp: Commit music changes only after event completes, not after any control=flow tag  https://github.com/wesnoth/wesnoth/commit/78eee8c8438bd23f21d713cdd8aaaa84d434a15d
20170424 21:57:10< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting b9e23fb293a4 / src/ (scripting/lua_audio.cpp sound.cpp sound.hpp): Allow inserting a track into the middle of the playlist https://github.com/wesnoth/wesnoth/commit/b9e23fb293a4678e0af79b55dae5929da4af0790
20170424 21:57:12< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting a0c860c30ff6 / src/scripting/lua_audio.cpp: Allow assigning a config to an existing track to overwrite it https://github.com/wesnoth/wesnoth/commit/a0c860c30ff6e98a6330900d39ce35c174e6ee6e
20170424 21:57:14< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 6db0d10628c4 / src/sound.cpp: Use std::find when checking for duplicate tracks https://github.com/wesnoth/wesnoth/commit/6db0d10628c44e6ee8b686be5b45ec2e8699b7bf
20170424 21:57:16< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 591cb3bad354 / src/sound.cpp: fixup! Allow inserting a track into the middle of the playlist https://github.com/wesnoth/wesnoth/commit/591cb3bad354058fb0423d548a97186577556bc1
20170424 21:57:18< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 017f0cd41e23 / src/scripting/lua_audio.cpp: fixup! Port [volume] to Lua https://github.com/wesnoth/wesnoth/commit/017f0cd41e23c3808bcfe4a2126c08362a96fda8
20170424 21:57:20< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 100f73ca2e40 / src/ (scripting/lua_audio.cpp sound.cpp sound_music_track.hpp): Store music tracks as shared_ptrs https://github.com/wesnoth/wesnoth/commit/100f73ca2e40eeb09f3ddef0d4e386e8e06312f4
20170424 21:57:22< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 3d69b7729b00 / src/scripting/lua_audio.cpp: Handle all plausible cases of assigning into the playlist https://github.com/wesnoth/wesnoth/commit/3d69b7729b0007fa565b94bffe9aac8989a5ac5a
20170424 21:57:24< irker887> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 1cb3eb476528 / src/ (scripting/lua_audio.cpp sound.cpp sound.hpp): Allow changing the current track to an existing one on the playlist https://github.com/wesnoth/wesnoth/commit/1cb3eb4765284a5e043ab384c35c0a650a6677a1
20170424 21:57:38< celticminstrel> Whoa, a lot of commits on there now...
20170424 22:17:05-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170424 22:22:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170424 22:22:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 22:26:39-!- Estradavi [~quassel@92.56.2.210] has joined #wesnoth-dev
20170424 22:35:36-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 22:38:59-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170424 22:54:31-!- Estradavi [~quassel@92.56.2.210] has quit [Remote host closed the connection]
20170424 23:03:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170424 23:03:57-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170424 23:04:34-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has joined #wesnoth-dev
20170424 23:11:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170424 23:15:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170424 23:15:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170424 23:21:33-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has quit [Remote host closed the connection]
20170424 23:32:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170424 23:45:08-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170424 23:52:40< vultraz_iOS> gaaah
20170424 23:52:45< vultraz_iOS> why doesn't update_tod update the tod
20170424 23:53:01< vultraz_iOS> that is, when used from the custom tod dialog
20170424 23:53:12< vultraz_iOS> but it does update when i use adjust_color_overlay
20170424 23:53:20< vultraz_iOS> which sets color_adjust_
20170424 23:53:26< vultraz_iOS> and then calls update_tod
20170424 23:53:36< vultraz_iOS> and update_tod adds color_adjust_ to the current tod
20170424 23:55:01< vultraz_iOS> the function isn't broken since it updates fine outside the dialog
20170424 23:55:05< vultraz_iOS> it = the tod coloring
20170424 23:55:41< vultraz_iOS> and because using adjust_color_overlay i know it's possible to tint the map
20170424 23:55:47< vultraz_iOS> with a dialog open
20170424 23:55:53< vultraz_iOS> so what the hell gives here
--- Log closed Tue Apr 25 00:00:19 2017