--- Log opened Tue Apr 25 00:00:19 2017
20170425 00:04:42< celticminstrel> It's similar to how game_data::set_theme doesn't actually do anything.
20170425 00:04:52< celticminstrel> I wonder if it could be removed.
20170425 00:05:47< celticminstrel> (Basically, "updating the ToD colouring" is several steps, and for some reason or other they're not all bundled into a single convenient function? I'd recommend searching for the other places it's called from, maybe you'll unearth some clues.)
20170425 00:07:10< vultraz_iOS> but I am indeed calling invalidate_all 
20170425 00:07:12< vultraz_iOS> and draw
20170425 00:12:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170425 00:12:35< vultraz_iOS> celticminstrel: wait, i thought you added the ability to change theme in the game?
20170425 00:12:42< celticminstrel> Yes?
20170425 00:12:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 00:13:46< vultraz_iOS> well the unit box theme is broken as fuck
20170425 00:14:03< vultraz_iOS> widescreen is totally broken
20170425 00:14:20< celticminstrel> The unit box screen seems to work on 1024x768 and up, but...
20170425 00:14:39< celticminstrel> The ToD images don't show up for some reason. They're being sought in the wrong subdirectory.
20170425 00:15:09< vultraz_iOS> good god the classic theme is so classic
20170425 00:15:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170425 00:15:29< celticminstrel> XD
20170425 00:15:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 00:18:12-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 00:20:25< vultraz_iOS> celticminstrel: before 1.14 we should definitely try to fix the disappearing labels/UI buttons when gui2 is open issue
20170425 00:20:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170425 00:20:55< celticminstrel> You mean like how typing "wesnoth.zoom(2)" into the Lua console destroys everything?
20170425 00:21:25< celticminstrel> Oh wait, you're talking about how the menu buttons disappear when the menu is open?
20170425 00:21:35< vultraz_iOS> yes
20170425 00:25:53 * celticminstrel notes that "destroys everything" is an exaggeration. It just fails to redraw the dialog.
20170425 00:39:09-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 00:41:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170425 01:09:57-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170425 01:11:24-!- RatArmy_ [~ratarmy@126.211.127.58] has joined #wesnoth-dev
20170425 01:17:02< irker887> wesnoth: Charles Dang wesnoth:master 3de10e5e61df / src/gui/dialogs/editor/custom_tod.cpp: Custom ToD: fixed bug where color sliders would continuously slide to the left w https://github.com/wesnoth/wesnoth/commit/3de10e5e61dfe07bb69b6a93743c7b71f1e28a6d
20170425 01:17:05< irker887> wesnoth: Charles Dang wesnoth:master 347fdd42bfd2 / src/gui/dialogs/lua_interpreter.cpp: Lua Console: prevent bad window redraw when commands such as wesnoth.zoom are us https://github.com/wesnoth/wesnoth/commit/347fdd42bfd2399d6862c81be81108ec80512a2c
20170425 01:17:06< vultraz_iOS> celticminstrel: ^
20170425 01:20:47< celticminstrel> Oh huh, it was that easy?
20170425 01:21:06< vultraz_iOS> si si
20170425 01:22:13< vultraz_iOS> how do i invoke the mp change control dialog..
20170425 01:22:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170425 01:23:02< vultraz_iOS> oh jesus fuck this dialog
20170425 01:23:04-!- flowerhack [uid6775@gateway/web/irccloud.com/x-lnpxhpjjkowhnskj] has quit [Quit: Connection closed for inactivity]
20170425 01:23:06< vultraz_iOS> REFACTOR TIME
20170425 01:23:44-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170425 01:23:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170425 01:24:10< vultraz_iOS> grow_factor = 7
20170425 01:24:19 * vultraz_iOS runs down the street screaming
20170425 01:24:23-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170425 01:24:52< celticminstrel> You're gonna need to get off your refactor tractor soon, you know.
20170425 01:25:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 01:25:22< celticminstrel> After the next release, we should probably make a "no more refactoring" rule until 1.14.
20170425 01:25:47< vultraz_iOS> "refactor tractor" xD
20170425 01:25:51< celticminstrel> (Another way of putting that is "finish refactoring everything you want to refactor by the end of May".)
20170425 01:28:11-!- RatArmy_ [~ratarmy@126.211.127.58] has quit [Read error: Connection reset by peer]
20170425 01:28:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170425 01:29:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 01:31:19< vultraz_iOS> ahhh curses upon MVC!
20170425 01:33:35< vultraz_iOS> I don't fully understand what this dialog is supposed to do..
20170425 01:35:46-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170425 01:35:58-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170425 01:36:47< vultraz_iOS> huh
20170425 01:36:50< vultraz_iOS> looks like I fixed a bug?
20170425 01:38:47-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has quit [Remote host closed the connection]
20170425 01:38:59-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has joined #wesnoth-dev
20170425 01:39:59-!- un214 [~un214@76-14-112-211.rk.wavecable.com] has left #wesnoth-dev []
20170425 01:41:47< irker887> wesnoth: Charles Dang wesnoth:master 07d418f543d2 / data/gui/window/mp_change_control.cfg: MP Change Control: cleaned up internal layout https://github.com/wesnoth/wesnoth/commit/07d418f543d2f284773fa7ceed2592c76da712c7
20170425 01:42:00-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170425 01:46:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170425 01:47:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170425 01:47:48-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 01:54:10< celticminstrel> Fixing bugs by accident, huh. Suspicious.
20170425 01:58:52< vultraz_iOS> it happens
20170425 01:58:56< vultraz_iOS> no idea why though
20170425 01:59:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d82a:7574:a170:377f] has joined #wesnoth-dev
20170425 02:00:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170425 02:03:18-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:d82a:7574:a170:377f] has quit [Ping timeout: 240 seconds]
20170425 02:03:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 02:04:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170425 02:04:53-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 02:07:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 02:08:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 02:17:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170425 02:19:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 02:21:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170425 02:22:39-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 02:39:27-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 02:40:55-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 02:52:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Remote host closed the connection]
20170425 03:10:13-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has joined #wesnoth-dev
20170425 03:13:11< irker887> wesnoth: Charles Dang wesnoth:master bf2dfc8f20ed / src/gui/dialogs/multiplayer/mp_change_control.cpp: MP Change Control: removed a bunch of invalidate_layout calls https://github.com/wesnoth/wesnoth/commit/bf2dfc8f20edee73a7bcca697e4ee804d9176ffc
20170425 03:13:14< irker887> wesnoth: Charles Dang wesnoth:master 5effd5338a49 / src/gui/dialogs/multiplayer/ (mp_change_control.cpp mp_change_control.hpp): MP Change Control: refactor dialog implementation https://github.com/wesnoth/wesnoth/commit/5effd5338a49402f650bbc675cad3489a8173d90
20170425 03:13:16< vultraz_iOS> almost 200 lines lighter due to lack of MVC :D
20170425 03:14:16< celticminstrel> But what if there was a good reason for MVC!? :O
20170425 03:14:27< celticminstrel> (What was this dialog for, again?)
20170425 03:14:47< vultraz_iOS> giving control of a side 
20170425 03:14:54 * celticminstrel notes that MVC in the inspector kinda makes a lot of sense; I think I left that in when I refactored it, didn't I?
20170425 03:15:08< celticminstrel> The MVC in the main game also makes sense.
20170425 03:15:16< celticminstrel> The MVC in the Lua inspector is a little questionable.
20170425 03:15:44< celticminstrel> One of the nice things about MVC is that, if done right, you can swap out views or models.
20170425 03:15:51< celticminstrel> So it can be good for code reuse.
20170425 03:16:17< vultraz_iOS> sure
20170425 03:16:23< vultraz_iOS> this was not the place for it though
20170425 03:16:36< celticminstrel> Perhaps not.
20170425 03:16:43< vultraz_iOS> the dialog is actually very simple
20170425 03:18:35< celticminstrel> ...
20170425 03:19:20< vultraz_iOS> hm?
20170425 03:21:20< celticminstrel> Just spotted PR996 which seems to a) fix a bug that was fixed, b) change all the lines (possibly newlines to CRLF?), c) add several irrelevant people to the credits, and d) list some random people in the readme.
20170425 03:22:12< vultraz_iOS> (the main problem I have with MVC is it makes the functionality of the code often very obscure)
20170425 03:22:42< vultraz_iOS> (take this case - 200 lines of misdirection with excessive listbox clearing/refilling)
20170425 03:23:39< vultraz_iOS> (whereas if you used the simple, direct method, you can follow the code's flow very easily)
20170425 03:26:11-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 03:53:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 03:57:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Ping timeout: 258 seconds]
20170425 04:32:42-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 04:34:28-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has quit [Remote host closed the connection]
20170425 04:47:57-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 04:53:22-!- celticminstrel is now known as celmin|sleep
20170425 04:57:49-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 05:29:32-!- RatArmy_ [~ratarmy@om126211127058.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 05:33:36-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 05:45:15-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170425 06:13:24-!- irker887 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170425 06:36:42-!- JyrkiVesterinen [~JyrkiVest@85.76.67.43] has joined #wesnoth-dev
20170425 06:37:00-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 06:51:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Remote host closed the connection]
20170425 07:28:52-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 07:36:12-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170425 07:36:46-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170425 07:39:09-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20170425 07:39:39-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170425 07:41:09-!- oldlaptop_ [~quassel@45.63.78.126] has joined #wesnoth-dev
20170425 07:41:36-!- oldlaptop [~quassel@45.63.78.126] has quit [Quit: No Ping reply in 180 seconds.]
20170425 07:41:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20170425 07:41:37-!- wedge010 is now known as wedge009
20170425 07:52:05-!- Greg-Boggs [~greg_bogg@76.115.139.154] has joined #wesnoth-dev
20170425 07:56:10-!- Greg-Boggs [~greg_bogg@76.115.139.154] has quit [Ping timeout: 240 seconds]
20170425 07:57:25-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 08:14:20-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 08:33:54-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has quit [Quit: Miranda IM! Smaller, Faster, Easier. http://miranda-im.org]
20170425 08:40:07< vultraz_iOS> zookeeper: alright if i remove the useless border keys from the theme c++?
20170425 08:40:09< vultraz_iOS> (and wml)
20170425 08:40:57< zookeeper> sure. but just the useless ones, not the background or whatever else might be there.
20170425 08:41:11< vultraz_iOS> right
20170425 08:42:20-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 08:49:20-!- irker969 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170425 08:49:20< irker969> wesnoth: Charles Dang wesnoth:master d4529dfc1ee4 / data/themes/_initial.cfg src/display.cpp src/display.hpp src/theme.cpp src/theme.hpp: Removed ThemeWML border image keys https://github.com/wesnoth/wesnoth/commit/d4529dfc1ee4d4ab1b48df5506f6c557c837c131
20170425 08:50:36-!- JyrkiVesterinen [~JyrkiVest@85.76.67.43] has quit [Quit: .]
20170425 08:51:03< vultraz_iOS> only downside of the border change is i think it now forces borders on our cutscene minimal theme
20170425 08:52:05< zookeeper> yeah
20170425 08:52:28< zookeeper> although it's _possible_ to workaround that on a scenario level
20170425 08:52:44< vultraz_iOS> or justadd a show_border key somewhere
20170425 08:52:50< zookeeper> yes
20170425 08:54:37< zookeeper> well, actually i'm not at all sure if the workaround would even work... it very well might not.
20170425 08:54:43-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170425 09:00:25-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 09:04:44-!- Kwandulin [~Kwandulin@p200300760F6D80C0FC41FBC964383EB0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170425 09:06:40-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 09:23:58-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 09:29:47-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170425 09:32:07< JyrkiVesterinen> Vultraz just said in Discord that "we're going to try to release 1.13.8 this weekend".
20170425 09:32:18< JyrkiVesterinen> He may have mixed up April and May in the channel topic...
20170425 09:52:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 09:58:40-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Ping timeout: 260 seconds]
20170425 10:02:36-!- RatArmy_ [~ratarmy@126.212.252.59] has joined #wesnoth-dev
20170425 10:15:38< vultraz_iOS> i did?
20170425 10:15:52< vultraz_iOS> good god
20170425 10:16:04< vultraz_iOS> JyrkiVesterinen: I thought it was may :|
20170425 10:16:09< vultraz_iOS> *now* :|
20170425 10:16:19-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.8 (1.14. Beta 1) scheduled for Sunday, April 30th 00:00 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170425 10:16:22< vultraz_iOS> what the hell
20170425 10:16:50< vultraz_iOS> JyrkiVesterinen: thanks for pointing that out >_>
20170425 10:21:59-!- RatArmy_ [~ratarmy@126.212.252.59] has quit [Read error: Connection reset by peer]
20170425 10:26:18-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 10:42:50-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 10:44:11-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 11:13:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 11:13:07-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 11:32:16-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has joined #wesnoth-dev
20170425 11:50:12-!- irker969 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170425 12:01:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170425 12:01:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 12:45:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170425 12:45:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170425 12:55:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170425 12:56:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 13:02:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170425 13:17:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170425 13:17:50-!- RatArmy_ [~ratarmy@om126212252059.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 13:32:07-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has joined #wesnoth-dev
20170425 13:46:55-!- atarocch [~atarocch@2604:2000:de9b:9c00:4122:5fe7:5bb9:3477] has quit [Remote host closed the connection]
20170425 13:47:30< celmin|sleep> And here I thought there was a lot more time until the release...
20170425 13:47:35-!- celmin|sleep is now known as celticminstrel
20170425 13:55:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 14:00:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Ping timeout: 255 seconds]
20170425 14:06:56< celticminstrel> If it's this weekend, I guess wml_tag_porting isn't going in?
20170425 14:07:15< celticminstrel> Although maybe it could, since it's better-tested than last time. Provided I finish up the last bits of work on it.
20170425 14:07:43< celticminstrel> ...vultraz isn't here. :/
20170425 14:19:07< DeFender1031> can't we just stop releasing until EVERYTHING is perfect? :P
20170425 14:41:32< celticminstrel> Only if you don't want any releases until, I dunno, 2030 or so. :P
20170425 14:44:24< DeFender1031> Great! It'd give me time to finish my campaign and possibly a sequel too! :P
20170425 14:48:11-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: .]
20170425 14:59:19-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-rcdzlxjtflpaofdd] has quit [K-Lined]
20170425 15:00:42-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170425 15:05:33< vultraz_iOS> why is regxp so hard :(
20170425 15:06:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has joined #wesnoth-dev
20170425 15:06:22< Soliton> i wouldn't say it is.
20170425 15:06:52< vultraz_iOS> how do you match a full word?
20170425 15:06:54< Soliton> well, unless you try to parse xml with it or something non-sensical.
20170425 15:07:24< Soliton> [[:alpha:]]+
20170425 15:07:39< Soliton> depends on what regex variant you're talking about.
20170425 15:07:45< vultraz_iOS> JS, apparently
20170425 15:09:00< Soliton> perhaps \w+ then
20170425 15:09:57< Soliton> that also allows digits though.
20170425 15:10:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:6064:93bf:7470:9e70] has quit [Ping timeout: 258 seconds]
20170425 15:11:46-!- ChipmunkV[m] [chipmunkvm@gateway/shell/matrix.org/x-pieqnhxwktpyiott] has joined #wesnoth-dev
20170425 15:13:34 * celticminstrel points vultraz_iOS at the logs from just before he returned.
20170425 15:13:57< celticminstrel> "how do you match a full word" -- depends on what you mean by "word"?
20170425 15:14:54< vultraz_iOS> I'm trying to find any case of "teams()[" followed by anything followed by "- 1]"
20170425 15:15:20< Soliton> ah, parsing c++ with regex.
20170425 15:15:38< Soliton> that cannot work, of course.
20170425 15:15:43< celticminstrel> Uh.
20170425 15:15:49< celticminstrel> This isn't parsing C++. :P
20170425 15:16:16< Soliton> it's certainly just a guess but it sure looks like it to me.
20170425 15:16:22< celticminstrel> Parsing means producing a tree.
20170425 15:16:48< celticminstrel> You can't parse C++ or XML with regex, but you can use regex to locate patterns in them.
20170425 15:16:50< Soliton> well, trying to parse or whatever you want to call the attempt.
20170425 15:17:03< celticminstrel> vultraz_iOS: You could try marking teams() deprecated.
20170425 15:17:19< celticminstrel> And work through the fallout from that.
20170425 15:20:12< DeFender1031> vultraz_iOS, is "teams\(\)\[.*- 1\]" not what you want?
20170425 15:20:59< celticminstrel> That does seem like it would work, yes.
20170425 15:21:06< celticminstrel> Perhaps through a \b in front.
20170425 15:21:50< DeFender1031> probably a good idea. I was just matching what vult said exactly.
20170425 15:22:27< celticminstrel> Well, since he was asking about "full word" I figured he was getting things that end with "teams".
20170425 15:22:39< celticminstrel> So the \b should fix that.
20170425 15:22:55< vultraz_iOS> \ o /
20170425 15:22:59< vultraz_iOS> that works
20170425 15:23:25< vultraz_iOS> ty ty
20170425 15:23:48< celticminstrel> \b means "make sure this is a word boundary"; it's an anchor, like $ or ^, so it matches an empty string.
20170425 15:23:52< DeFender1031> ah, that's what you meant
20170425 15:24:43< DeFender1031> \b is basically equivalent to ([^\w]|^|$)
20170425 15:25:09< DeFender1031> actually, that should be a look-ahead/behind
20170425 15:25:14< celticminstrel> Not quite, yeah.
20170425 15:25:21< DeFender1031> since it doesn't actually include the character in the match
20170425 15:25:29< celticminstrel> It's equivalent if you make it a lookbehind / lookahead.
20170425 15:25:39< DeFender1031> [4/25/2017 6:30:55 pm] <DeFender1031> actually, that should be a look-ahead/behind
20170425 15:25:42< DeFender1031> yeah.
20170425 15:25:46< DeFender1031> as i said.
20170425 15:39:21< vultraz_iOS> christ why does Pageant keep crashing...
20170425 15:41:45-!- irker158 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170425 15:41:45< irker158> wesnoth: Charles Dang wesnoth:master f9a021eaab1d / src/ (18 files in 6 dirs): Deploy display_context::get_team when possible https://github.com/wesnoth/wesnoth/commit/f9a021eaab1dbd7b3dbd228dacfc2c637ca33be7
20170425 15:42:36< celticminstrel> Oh my.
20170425 15:42:58< celticminstrel> BTW vultraz_iOS, did you consider the possibility of no spaces?
20170425 15:43:10< celticminstrel> "teams\(\)\[.*- ?1\]" instead of "teams\(\)\[.*- 1\]"
20170425 15:43:18< vultraz_iOS> no
20170425 15:43:28< celticminstrel> (Or "teams\(\)\[.*-1\]" now that you've addressed with spaces.)
20170425 15:43:50< vultraz_iOS> not all of which are dealt with yet :P
20170425 15:44:32< celticminstrel> Had someone already added get_team()?
20170425 15:44:40< celticminstrel> Also, are you going to mark teams() deprecated?
20170425 15:44:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 15:44:57< celticminstrel> (Note that if you do it should probably be in filter_context at minimum.)
20170425 15:45:09< celticminstrel> (Or wait, was it display_context? One of those.)
20170425 15:45:44< celticminstrel> (Oh yeah, the commit message says it – display_context it is.)
20170425 15:46:04< vultraz_iOS> I thought you added it
20170425 15:46:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170425 15:46:35< celticminstrel> Did I? I don't remember.
20170425 15:46:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 15:47:15< vultraz_iOS> indeed, t'was you
20170425 15:47:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20170425 15:47:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 15:49:31< DeFender1031> hahahahahahaha
20170425 15:50:33< celticminstrel> ...why are you laughing? >_>
20170425 15:51:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170425 15:53:08< Soliton> is there even a reason to keep teams()?
20170425 15:56:06< vultraz_iOS> teams() is a function implemented independently in multiple classes, it seems
20170425 15:57:49< celticminstrel> Removing teams() is the end goal, but what vultraz said.
20170425 15:58:21< celticminstrel> Are you not going to mark it deprecated though? Might make it easier to find where it's used, right?
20170425 15:58:43< vultraz_iOS> and we can't deprecate it since in some places it's used with the proper index lookup
20170425 15:59:06< celticminstrel> You can still deprecate it but leave those uses in place for the time being.
20170425 15:59:22< celticminstrel> I think there are also cases where it's iterated over BTW.
20170425 16:01:06< irker158> wesnoth: Charles Dang wesnoth:master 921bbc2d7d6a / src/ (menu_events.cpp reports.cpp scripting/game_lua_kernel.cpp): Forward get_team call to a display_context derivative when necessary https://github.com/wesnoth/wesnoth/commit/921bbc2d7d6ae6a8902fb45bd789c0f5d96f6afd
20170425 16:02:31< DeFender1031> celticminstrel, it was funny to me. "Did someone add that?" "You did!" "Oh."
20170425 16:02:48< celticminstrel> If specific instances of teams() are no longer used, you should remove it?
20170425 16:02:56< celticminstrel> For example in game_lua_kernel
20170425 16:03:18< vultraz_iOS> working on it, working on it..
20170425 16:03:24< celticminstrel> Oh okay.
20170425 16:16:36-!- JyrkiVesterinen [~JyrkiVest@78-27-71-152.bb.dnainternet.fi] has joined #wesnoth-dev
20170425 16:22:29-!- gfgtdf [~chatzilla@x4e363232.dyn.telefonica.de] has joined #wesnoth-dev
20170425 16:23:00< gfgtdf> vultraz_iOS: there are still maybusecases as resources::gameboard->teams[num -1] which coud probably be replaced by resources::gameboard->get_team(num)
20170425 16:23:18< vultraz_iOS> not done yet
20170425 16:25:22< gfgtdf> vultraz_iOS: are you workin  on that currently? i codul try to replace some for( size_t i = 0; i<resources::gameboard->teams().size(); ++i) with reabe loops otherwise
20170425 16:25:32< gfgtdf> range*
20170425 16:25:50< vultraz_iOS> gfgtdf: working on it but don't have local changes atmf
20170425 16:25:55< vultraz_iOS> feel free to do that *
20170425 16:27:15< vultraz_iOS> gfgtdf: but just the loops 
20170425 17:06:07< JyrkiVesterinen> vultraz_iOS: I started investigating bug 25065.
20170425 17:06:26< vultraz_iOS> is that the end credits bug?
20170425 17:06:33< JyrkiVesterinen> Increasing the size of the surface indeed causes malfunctioning, but I'm unable to reproduce the text disappearing completely.
20170425 17:06:39< JyrkiVesterinen> Yes, it is.
20170425 17:06:47< vultraz_iOS> ah
20170425 17:07:19< JyrkiVesterinen> First, I installed a few small add-on campaigns and changed the label definition to default_large.
20170425 17:07:22< JyrkiVesterinen> Result: https://s19.postimg.org/75q614xk3/credits-cut-off.png
20170425 17:07:43< JyrkiVesterinen> Most of the credits are shown fine, but then they are cut off.
20170425 17:08:33< JyrkiVesterinen> Next, I thought that maybe I can reproduce the problem if I make the surface even larger. I doubled the length of about.cfg (Ctrl+A, Ctrl+X, Ctrl+V, Ctrl+V).
20170425 17:08:44< JyrkiVesterinen> That resulted in this: https://s19.postimg.org/ub0kn52oz/stacked-text.png
20170425 17:09:19< vultraz_iOS> hm
20170425 17:09:21< JyrkiVesterinen> So, the breakage I can cause by making the surface larger doesn't quite match with yours...
20170425 17:09:23< vultraz_iOS> i did not observe this
20170425 17:09:47< JyrkiVesterinen> (I'm testing with a build from February, by the way, just in case the behavior has changed recently.)
20170425 17:11:04< celticminstrel> Nothing has changed in credits since then, and I don't think any of the changes to the canvas would be relevant to text...
20170425 17:11:34< vultraz_iOS> windows, right?
20170425 17:11:39< JyrkiVesterinen> Windows 10.
20170425 17:12:13< celticminstrel> Different C++ runtime, though, but would that matter here?
20170425 17:14:08< celticminstrel> (I mean msvcprt.dll vs libstdc++)
20170425 17:14:14< celticminstrel> (aka MSVC vs GCC)
20170425 17:14:56< vultraz_iOS> either way, we know it's a surface size problem
20170425 17:15:35< celticminstrel> So what's the actual goal here? Fixing problems resulting from large surfaces, or reducing the size of the surface to work around it?
20170425 17:16:04< JyrkiVesterinen> Fixing, of course.
20170425 17:16:05< vultraz_iOS> either
20170425 17:16:10< celticminstrel> 'kay
20170425 17:21:21< DeFender1031> clavi, https://img.memesuper.com/200de1d4ef6baaccc1cb515779c2faf6_-meme-why-not-both-meme-why-not-both_419-261.jpeg
20170425 17:21:24< DeFender1031> er
20170425 17:21:33< DeFender1031> meant to ping celticminstrel
20170425 17:22:35< vultraz_iOS> JyrkiVesterinen: side note - what the hell is wrong with your text rendering O_O
20170425 17:22:39< vultraz_iOS> it looks so jagged
20170425 17:22:55< JyrkiVesterinen> I have font smoothing disabled system-wide.
20170425 17:23:02< JyrkiVesterinen> I prefer aliased rendering. :P
20170425 17:23:14< vultraz_iOS> but that's not aliased 
20170425 17:23:40< vultraz_iOS> (or am I confusing the meaning of aliased)
20170425 17:25:16< JyrkiVesterinen> The screenshots are downscaled, so they don't exactly match what I see.
20170425 17:26:26-!- Kwandulin [~Kwandulin@p200300760F6D807054F6AD4FE9F66C2A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170425 17:28:06< celticminstrel> vultraz_iOS: https://en.wikipedia.org/wiki/Aliasing#/media/File:Aliasing_a.png
20170425 17:28:16< celticminstrel> Font smoothing is anti-aliasing.
20170425 17:29:14< vultraz_iOS> ahhh
20170425 17:30:01-!- celticminstrel is now known as celmin|away
20170425 17:35:47< irker158> wesnoth: ln-zookeeper wesnoth:master cbd7d44f627d / data/core/ (8 files in 2 dirs): Added idle animation for Dwarvish Fighter, by Kwandulin and Crow_T https://github.com/wesnoth/wesnoth/commit/cbd7d44f627dc275856dee63facf3c214d97c26c
20170425 17:37:38< DeFender1031> I remember seeing a proposal for that animation on the forum somewhere ages ago.
20170425 17:37:43-!- gfgtdf [~chatzilla@x4e363232.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170425 17:38:58< zookeeper> it's only been <2 months, that's nothing :p
20170425 17:39:31< zookeeper> when you commit stuff from 2+ years ago, then that kinda sorta starts to qualify for "ages ago"
20170425 17:40:00< DeFender1031> Eh, whatever. I have a warped sense of time.
20170425 17:41:05< zookeeper> oh wait, i guess i forgot to rename the frames. well, not a problem i guess.
20170425 17:41:34< zookeeper> just a moment ago i was checking the commit log for when the old idle anim frames were removed, and i thought the anim was commented out "not that long ago", but then it was in 2008...
20170425 17:42:30< DeFender1031> So I'm not the only one with a warped sense of time... :P
20170425 17:42:32< zookeeper> i've fallen into a wesnothian time vortex where everything feels like "not that long ago"
20170425 17:43:32< DeFender1031> That's... not a thing AFAIK.
20170425 17:43:46< DeFender1031> Unless there's some wesnoth campaign I don't know of that does time travel
20170425 17:44:12< DeFender1031> (And please no. Time travel stories are nearly impossible to keep internally consistent.
20170425 17:44:14< DeFender1031> )
20170425 17:45:38< vultraz_iOS> AtS has a small bit of "time travel"
20170425 17:47:27< zookeeper> DeFender1031, yeah, time travel is terrible unless you really have some new kind of twist on it... which occasionally happens, but usually not.
20170425 17:51:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 17:52:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20170425 17:55:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170425 17:55:45-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170425 17:56:41-!- gfgtdf [~chatzilla@x4e3630db.dyn.telefonica.de] has joined #wesnoth-dev
20170425 18:13:25< irker158> wesnoth: Charles Dang wesnoth:master 06199650e6fa / src/ (19 files in 8 dirs): Deployed more display_context::get_team (cont. f9a021e and 921bbc2) https://github.com/wesnoth/wesnoth/commit/06199650e6faa9682d15b7ff1fa2147ca5a89767
20170425 18:14:59< irker158> wesnoth: Charles Dang wesnoth:master 8320dd349e87 / src/scripting/game_lua_kernel.cpp: This was supposed to be with 06199650e https://github.com/wesnoth/wesnoth/commit/8320dd349e875112c5cc103b60d11da544accd87
20170425 18:46:23< Kwandulin> Whee, dwarf anim
20170425 18:47:30< Kwandulin> Still wanted to do that quenoth shaman sprites. Can't do that until sunday, though
20170425 18:58:39-!- Kwandulin [~Kwandulin@p200300760F6D807054F6AD4FE9F66C2A.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170425 19:02:35< DeFender1031> Kwandulin seems to have an error in his quit wml, unless that's an undocumented value :P
20170425 19:09:39-!- clavi [~clavi@v22017034422546657.goodsrv.de] has quit [Quit: ZNC - http://znc.in]
20170425 19:16:01< irker158> wesnoth: gfgtdf wesnoth:master f202d5bef567 / src/scripting/lua_unit_type.cpp: add image and icon to lua unit type getter https://github.com/wesnoth/wesnoth/commit/f202d5bef567d39417b5c464cdf341c3371cc699
20170425 19:16:11-!- clavi [~clavi@v22017034422546657.goodsrv.de] has joined #wesnoth-dev
20170425 19:33:49< matthiaskrgr> https://pastebin.com/CgsJXxmh  
20170425 19:38:22< celmin|away> [Apr 25@1:44:12pm] DeFender1031: (And please no. Time travel stories are nearly impossible to keep internally consistent.
20170425 19:38:23< celmin|away> Aw, but time travel is fuuun! :(
20170425 19:39:40< matthiaskrgr> celmin|away: you already said that 
20170425 19:39:42 * matthiaskrgr hides 
20170425 19:42:01< celmin|away> Hmm, I just thought of an idea of what to do with teams()...
20170425 19:42:09-!- celmin|away is now known as celticminstrel
20170425 19:43:38< celticminstrel> Basically making it private virtual in display_context (and private in the derived classes too), and then implementing get_team() and possibly others as non-virtual functions in display_context that forward to it.
20170425 19:45:13< celticminstrel> gfgtdf: TBH, I think 773aef099 might be a step in the wrong direction.
20170425 19:45:21< celticminstrel> It makes it harder to get rid of teams.
20170425 19:45:25< celticminstrel> ^teams()
20170425 19:47:48< celticminstrel> So before it was "for(size_t i = 0; i < teams().size(); i++) do_something_with(teams()[i])" and you changed to "for(const team& t L teams()) do_something_with(t)", but I think it might be better to do "for(size_t i = 1; i <= num_teams(); i++) do_something_with(get_team(i))"
20170425 19:48:03< gfgtdf> celticminstrel: well we dont intend to get rid of team compltely, we just want to 'fix' the issues of some functions refereing to ream by their 'index (0-based)' and some ba their number (1-based)
20170425 19:48:11< celticminstrel> Hmm, maybe.
20170425 19:48:35< celticminstrel> Note that that technically also means that functions like init_flags_for_side_internal should refer to them with 1-based indexing. :P
20170425 19:49:07< celticminstrel> Actually I had considered changing teams() to return an iterator range, but...
20170425 19:49:16< celticminstrel> I'd prefer it not to be a random-access-iterator range...
20170425 19:49:51< celticminstrel> Which might be impossible? Unless of course you changed the underlying implementation from std::vector to std::list, but that'd be silly, wouldn't it?
20170425 19:50:12< celticminstrel> Especially since there's random-access in get_team() already.
20170425 19:50:23< gfgtdf> celticminstrel: you coudl ma a wrapper for the std::vector::itwrator, burt i doubt its worth it
20170425 19:54:21< celticminstrel> gfgtdf: If you're removing the USE_HETEROGENOUS_LOOKUPS code, shouldn't you also remove the part where it's defined?
20170425 19:56:07< gfgtdf> celticminstrel: i don't completelex remove it, i still use USE_HETEROGENOUS_LOOKUPS  for the config_key_type define
20170425 19:56:16< celticminstrel> Ah.
20170425 20:00:26< celticminstrel> I think I like the string_view approach better since IIUC it doesn't rely on C++14.
20170425 20:00:33< celticminstrel> It also looks simpler.
20170425 20:01:10< gfgtdf> celticminstrel: it does need c++14 simpley becasue lookino up in  amp with something else than std::strign require exactly herogeous lookups, that also why it onyl enabled then
20170425 20:01:39< gfgtdf> celticminstrel: i coudl probably implemeti it for c++11 too by using a boost map type (boost::multi_index) but im not really motivated sicne it just a temporariyl thing (unutl we use c++14)
20170425 20:01:48< celticminstrel> For some reason you've optimized attribute lookup...
20170425 20:02:00< celticminstrel> What the heck does std::piecewise_construct mean...
20170425 20:02:03-!- JyrkiVesterinen [~JyrkiVest@78-27-71-152.bb.dnainternet.fi] has quit [Quit: .]
20170425 20:02:36< gfgtdf> celticminstrel: it's a tag type to use the correct std::pair ctor
20170425 20:02:55< celticminstrel> Why'd you inline config_has_value?
20170425 20:03:06< celticminstrel> I guess it doesn't matter that much.
20170425 20:03:41< gfgtdf> celticminstrel: i need to change the type of std::string name_; and it was just easier that way
20170425 20:04:05< celticminstrel> The inlined version has two additional members, but I guess they're references so that shouldn't make a difference.
20170425 20:04:27< gfgtdf> celticminstrel: why shodul it has 2 additional memebers ?
20170425 20:04:41< celticminstrel> [&] captures everything. Actually I think there's 3 additional members.
20170425 20:04:56< gfgtdf> celticminstrel: i think [&] captutes only the things that it actuall uses
20170425 20:05:00< celticminstrel> Original config_has_value captured only name and value. The inlined one also captures key, i, and probably this.
20170425 20:05:12< celticminstrel> Ah, it would make sense for the compiler to optimize that, sure.
20170425 20:05:39< celticminstrel> Anyway, since they're references, it probably doesn't matter whether they're captured, I guess.
20170425 20:05:40< gfgtdf> celticminstrel: "[&] captures all automatic variables used in the body of the lambda by reference and current object by reference if exists " accorign to http://en.cppreference.com/w/cpp/language/lambda
20170425 20:05:50< gfgtdf> notive the 'used in the body of the lambda '
20170425 20:06:00< celticminstrel> Does [=] also only capture used variables?
20170425 20:06:41< gfgtdf> celticminstrel: i think yes
20170425 20:08:24< celticminstrel> So the string_view version still relies on std::less<>, huh...
20170425 20:09:33< celticminstrel> gfgtdf: But, you know, couldn't that be done in C++11 too?
20170425 20:09:49< celticminstrel> Basically by using a custom class that does the same thing as std::less<>
20170425 20:10:19< gfgtdf> celticminstrel: not with std::map, sicne in c++11 std::map::find isn't a template function
20170425 20:10:55< celticminstrel> Ah, I see.
20170425 20:11:25< celticminstrel> You could use std::find instead but that would be a real pain, huh...
20170425 20:11:41< celticminstrel> Oh well.
20170425 20:11:51< celticminstrel> It's still simpler than the previous version, which is good.
20170425 20:14:10< celticminstrel> vultraz_iOS: So when does feature freeze happen? During beta or during RCs?
20170425 20:14:58< DeFender1031> Feature freeze?
20170425 20:15:08< DeFender1031> How broad a feature freeze?
20170425 20:16:05< celticminstrel> Uh...
20170425 20:16:16< gfgtdf> DeFender1031: well the main porpose is to make sure no nw issues get added when we want to release
20170425 20:17:51< gfgtdf> DeFender1031: do 'feature freeze' applied to new feature aswell as refactors sicne the later oftne have an change to add new bugs as high as the first.
20170425 20:18:08< DeFender1031> okay... and the feature freeze lasts for how long?
20170425 20:18:20< gfgtdf> DeFender1031: you has sometihng in particular in mind?
20170425 20:18:29< gfgtdf> DeFender1031: the feature freezenlasts until 11.4 is released
20170425 20:18:33< gfgtdf> 1.14 i meant
20170425 20:18:40< DeFender1031> understanding wesnoth procedures
20170425 20:18:41< gfgtdf> but
20170425 20:18:50< DeFender1031> is what i have in mind
20170425 20:19:08< celticminstrel> What I'm asking is when it starts.
20170425 20:19:46< DeFender1031> so it ends when 1.14 is released, and then I assume that development continues until some feature freeze that lasts until 1.14.1, later rinse, repeat?
20170425 20:19:52< DeFender1031> lather,*
20170425 20:20:55< gfgtdf> DeFender1031: well actuall what i sant want that correct
20170425 20:21:05< gfgtdf> DeFender1031: the feature freeze on the 1.14 branch will thne be forever
20170425 20:21:33< gfgtdf> DeFender1031: and at soem point 1.14 will be branchof off form master and master becomed 1.15.0-dev
20170425 20:21:39< DeFender1031> but all sorts of features were added between minor releases of 12.
20170425 20:23:16< gfgtdf> DeFender1031: ye but there are a lot of things that can sureely not be added, sepcailyl thign that break wml compability
20170425 20:23:35< DeFender1031> oh, obviously
20170425 20:24:08< DeFender1031> so basically the rule is that minor versions are backwards-compatible within themselves, but not necessarily across major versions?
20170425 20:24:18< gfgtdf> DeFender1031: also usually the 'featues' addedn in 1.12 are just backported form 1.13, so realyl any fearture develpement shodul happen on master (1.13 back then)
20170425 20:24:34< DeFender1031> right, I figured that'd be the case also
20170425 20:24:57< gfgtdf> DeFender1031: no the 'odd' numbers (1.15, 1.13, 1.11) are defv versions, while thne even numbe are stable version
20170425 20:25:06< DeFender1031> i know
20170425 20:25:13< gfgtdf> so the stable version have to be 100% compatible to subversion
20170425 20:25:18< DeFender1031> i meant within stable versions
20170425 20:25:35< DeFender1031> obviously dev versions aren't going to be self-compatible, because they're dev.
20170425 20:25:36< gfgtdf> the 100% compabilty also cinluded the previousl Rc version leik 1.1118
20170425 20:25:38< gfgtdf> 1.11.18
20170425 20:25:46< DeFender1031> huh?
20170425 20:26:32< gfgtdf> DeFender1031: so ideally anyrthign from the first 1.13 Rc version to the last of the 1.14 stable version shoudl be 100% wml cmpatible
20170425 20:26:48< DeFender1031> this is all sensible.
20170425 20:26:49-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 20:29:50< gfgtdf> celticminstrel: you can check tthe mailinglist https://www.mail-archive.com/wesnoth-dev@gna.org/mail2.html so see how it went last year
20170425 20:29:56< gfgtdf> last release*
20170425 20:31:45-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 20:33:01< gfgtdf> DeFender1031: you have sometihng in particuolar you want to work on ?
20170425 20:34:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170425 20:35:05< DeFender1031> had still been planning on string lib refactoring, there was something else I wanted to check my logs for, and then possibly the lua API reorg (which is not a feature freeze issue, as the idea would be to leave the existing API in place for an undetermined number of releases and just add the new one)
20170425 20:35:28< zookeeper> if we're supposed to not do API changes/breakages after the next release, then everyone should have their compatibility-breaking API changes listed in the sticky thread so that there's time to evaluate whether any of them should be changed in whatever way. because we can't do that _after_ the release.
20170425 20:37:41< DeFender1031> right
20170425 20:38:20< DeFender1031> the idea behind the reorg that i mentioned is that there's a bunch of NEW APIs in a more organized fashion, but nothing existing would be changed or removed.
20170425 20:38:36< celticminstrel> But I'm not sure if the feature freeze is after the next release.
20170425 20:38:38< zookeeper> (i wasn't talking to anyone in particular)
20170425 20:38:44< celticminstrel> Since vultraz_iOS called it beta, not release candidate.
20170425 20:38:47< zookeeper> celticminstrel, well, regardless
20170425 20:39:12< zookeeper> the sooner the better
20170425 20:39:27< DeFender1031> (well then neither was I. :P)
20170425 20:44:24< celticminstrel> Did we have unit tests for the string lib? If not, we probably should.
20170425 20:44:30< gfgtdf> vultraz_iOS: any opinuion on mkaing the mp faction/leader select dilaog use unit_preview_pane ?
20170425 20:47:10< gfgtdf> just made a my addon 'pick you recruits no preperation turn' use the unit_preview_pane widget (not puloaded yet), looks much better now.
20170425 20:49:53< DeFender1031> celticminstrel, I was going to create those too...
20170425 20:52:03< celticminstrel> Ah.
20170425 20:54:49-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 20:57:39-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 21:31:45-!- gfgtdf_ [~chatzilla@x4e36388b.dyn.telefonica.de] has joined #wesnoth-dev
20170425 21:33:58-!- gfgtdf [~chatzilla@x4e3630db.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170425 21:34:10-!- gfgtdf_ is now known as gfgtdf
20170425 21:47:05< zookeeper> gfgtdf, hmm, in addition to the "[endlevel] no longer silently kills 0-hp units" thing, it seems that the primary unit doesn't exist during die events anymore in 1.13?
20170425 21:47:46< zookeeper> at least i got one die event with code that works in 1.12 but fails in 1.13 because it has filters which assume the dying unit can still be matched.
20170425 21:47:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170425 21:49:46< zookeeper> in case that's not intentional and you know something about it and want to take a look: https://paste.ee/p/PfoKI
20170425 21:50:04< zookeeper> (i don't have time to make it more sensible; just kill a side 2 unit with a side 1 unit and a side 1 TC portal should appear)
20170425 21:50:30< zookeeper> (if doesn't, because the [store_side] won't store side 1 because the filter won't match, which causes the ~TC to fail)
20170425 21:55:49 * zookeeper leaves for now
20170425 21:59:07-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170425 22:00:05-!- zookeeper [zookeeper@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170425 22:05:27-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170425 22:06:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170425 22:06:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170425 22:10:47-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170425 22:11:03< vultraz_iOS> gfgtdf: looks like string view isn't present in whatever boost travis is using
20170425 22:16:37-!- irker158 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170425 22:24:17< gfgtdf> vultraz_iOS: hmm ye seems to be new in boost 1.61.0
20170425 22:24:33< gfgtdf> probably not important enough to upgrade boost for it
20170425 22:24:33< vultraz_iOS> can we bump min version to that?
20170425 22:26:12-!- irker179 [~irker@109.237.213.40] has joined #wesnoth-dev
20170425 22:26:12< irker179> wesnoth: Charles Dang wesnoth:master af3a7a77347f / src/ (display.cpp scripting/game_lua_kernel.cpp scripting/game_lua_kernel.hpp): Cleaned up remaining usecases of teams() https://github.com/wesnoth/wesnoth/commit/af3a7a77347fedec7e0d5f7ba1d9b27df7bd93e5
20170425 22:27:32< gfgtdf> hmm boost has an older verson called boost::string_ref need to fund out what teh differences are
20170425 22:27:33-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 22:28:09< vultraz_iOS> string_ref was deprecated in favor of view AFAIU
20170425 22:28:21< vultraz_iOS> gfgtdf: https://stackoverflow.com/questions/36704794/differences-between-booststring-ref-and-booststring-view
20170425 22:29:55< gfgtdf> hmm ye that'S te page i foudn aswell, unfortunteley it just says 'closer to the c++17 standard' not the exact differences
20170425 22:30:32-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 22:33:18-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 22:36:51-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 22:39:27-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170425 22:39:28-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170425 22:39:42< gfgtdf> one of the differnce is that string_view.hpp and string_ref.hpp have different intention rules which makes it hard to get a file diff.
20170425 22:41:41-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170425 22:41:44-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170425 22:45:21-!- atarocch [~atarocch@31.157.131.77] has joined #wesnoth-dev
20170425 22:49:06-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 268 seconds]
20170425 22:51:21-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170425 22:56:37< gfgtdf> vultraz_iOS: was looking at teams() cases and foudn this one: https://github.com/wesnoth/wesnoth/blob/1.13.7/src/units/unit.cpp#L2082 it looks lieka bug, shouldn't it be side_  - 1 
20170425 22:57:04< vultraz_iOS> hmm
20170425 22:57:07< vultraz_iOS> possibly, yes
20170425 22:57:33-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170425 23:00:27< celticminstrel> Is side_ the 0-indexed team?
20170425 23:02:31< gfgtdf> well i think not, othersise there would  be no bug there.
20170425 23:09:09-!- atarocch [~atarocch@31.157.131.77] has quit [Ping timeout: 260 seconds]
20170425 23:15:59< celticminstrel> Ooh wait, .at().
20170425 23:16:06< celticminstrel> Okay yeah, that should be changed to get_team().
20170425 23:16:29< celticminstrel> vultraz_iOS: Do a search for "\bteams\(\)\.at"
20170425 23:20:31< celticminstrel> vultraz_iOS, gfgtdf: Some things seem suspect in 1f3a7a77
20170425 23:20:48< celticminstrel> For starters, this: https://github.com/wesnoth/wesnoth/commit/af3a7a77347fedec7e0d5f7ba1d9b27df7bd93e5#diff-85d89e7c81ef538af4d65cee40074b67R86
20170425 23:21:12< celticminstrel> Why is it playing_team() on line 86, but playing_team() - 1 on line 87?
20170425 23:21:20< celticminstrel> Oh, prev_team.
20170425 23:21:31< celticminstrel> Okay, then in that case, it should still be playing_team() - 1 on line 88.
20170425 23:22:06< celticminstrel> And the check shouldn't rely on signed integer overflow.
20170425 23:22:36< celticminstrel> "playing_team() - 1 < dc_->teams().size()" only works because -1 converts to MAX_INT.
20170425 23:23:28< celticminstrel> A better check would be "playing_team() == 0" and then swap the values on lines 88 and 89.
20170425 23:24:11< vultraz_iOS> will do
20170425 23:24:57< celticminstrel> playing_team() is also the 0-based index.
20170425 23:25:11< celticminstrel> I think I'd prefer using the 1-based index - playing_side() IIRC.
20170425 23:25:47< vultraz_iOS> if playing_team is 0-based then that's broken
20170425 23:26:43< celticminstrel> Pretty sure the display has functions that return the 0-based index and also functions that return the 1-based index.
20170425 23:26:55< vultraz_iOS> curses!
20170425 23:27:06< vultraz_iOS> but the old code did a -1
20170425 23:27:07< celticminstrel> I didn't touch display in my team index refactor because 0-based indexing was rampant there.
20170425 23:27:09< vultraz_iOS> so i'm leaving that
20170425 23:27:20< celticminstrel> Well yes, prev_team should have a -1, obviously.
20170425 23:27:35< celticminstrel> Because it's getting the team before the current team.
20170425 23:28:12< celticminstrel> I guess get_team(playing_team()) is actually technically correct, since playing_team() is the 0-based index and get_team() takes the 1-based index.
20170425 23:28:13< irker179> wesnoth: Charles Dang wesnoth:master 5d6a37f990b9 / src/ (8 files in 6 dirs): Even more deployment of display_context::get_team https://github.com/wesnoth/wesnoth/commit/5d6a37f990b93d36ae9ea284d15078b3b32ed281
20170425 23:28:16< irker179> wesnoth: Charles Dang wesnoth:master e5cb8c44a8d1 / src/display.cpp: Improved a ternary check (fixup af3a7a7) https://github.com/wesnoth/wesnoth/commit/e5cb8c44a8d1c5679528dd323e15be41097f8f54
20170425 23:28:18< vultraz_iOS> sounds like you want to get rid of any 0-based team index access?
20170425 23:28:38< celticminstrel> But it's confusing that way. Better to use get_team(playing_side() - 1), surely?
20170425 23:28:51< celticminstrel> I think it would be a good idea to get rid of all 0-based team index access.
20170425 23:29:15< vultraz_iOS> why
20170425 23:29:22< celticminstrel> Because teams are 1-indexed?
20170425 23:30:03< vultraz_iOS>  get_team(playing_side() - 1), would be a -2
20170425 23:30:05< vultraz_iOS> keep in mind
20170425 23:30:17< celticminstrel> Uh.
20170425 23:30:24< celticminstrel> Isn't playing_side() == playing_team() + 1?
20170425 23:30:34 * celticminstrel checks that...
20170425 23:30:49< vultraz_iOS> oh
20170425 23:30:51< vultraz_iOS> misread
20170425 23:30:53-!- RatArmy_ [~ratarmy@om126211120087.13.openmobile.ne.jp] has joined #wesnoth-dev
20170425 23:30:59< vultraz_iOS> ya know what, if there's a problem commit the fix
20170425 23:31:14< celticminstrel> :/
20170425 23:31:17< celticminstrel> Well sure...
20170425 23:31:36< celticminstrel> I also think it's highly dubious to make board() public in game_lua_kernel though.
20170425 23:31:55< celticminstrel> If you need to access it from one helper function, it's better to declare that function a friemd IMO.
20170425 23:32:10< vultraz_iOS> *then do so*
20170425 23:32:37< celticminstrel> :/
20170425 23:32:48< vultraz_iOS> I assume int(foo) should be converted to static_cast<int>(foo)?
20170425 23:33:07< celticminstrel> It's equivalent, as long as foo is not a pointer.
20170425 23:34:39-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170425 23:34:55< vultraz_iOS> alright, i'll work on that later..
20170425 23:35:09< vultraz_iOS> right now need to figure how to handle all this function duplication..
20170425 23:35:17< vultraz_iOS> teams(), units(), etc
20170425 23:35:17 * celticminstrel personally prefers the brevity of int(foo), but I'm not going to stop you from changing it.
20170425 23:35:54< celticminstrel> I don't think there's a major problem with all the function duplication TBH, but if you want to just use board().units() I guess that's fine too.
20170425 23:36:22< vultraz_iOS> there's always a problem with duplication
20170425 23:37:44< celticminstrel> Well, you could argue that removing those functions from eg game_lua_kernal actually increases duplication.
20170425 23:37:59< celticminstrel> Because everywhere you used teams() before, you now have to use board().teams().
20170425 23:38:15< vultraz_iOS> that's why I'm trying to think of a good solution! 
20170425 23:38:30< celticminstrel> I don't see what's wrong with the current solution.
20170425 23:38:49< celticminstrel> It's a nice way to shorten the code for commonly-referenced objects.
20170425 23:40:34< vultraz_iOS> yes
20170425 23:45:28-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170425 23:56:01< vultraz_iOS> i have an idea...
20170425 23:56:05< vultraz_iOS> let me see if it works
--- Log closed Wed Apr 26 00:00:55 2017