--- Log opened Thu Apr 27 00:00:11 2017
20170427 00:07:10-!- atarocch [~atarocch@69.193.57.18] has quit [Ping timeout: 240 seconds]
20170427 00:10:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 00:22:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 00:37:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170427 00:42:13-!- RatArmy_ [~ratarmy@om126200120038.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 00:46:58-!- RatArmy_ [~ratarmy@om126200120038.15.openmobile.ne.jp] has joined #wesnoth-dev
20170427 01:03:11-!- RatArmy_ [~ratarmy@om126200120038.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 01:08:11-!- RatArmy_ [~ratarmy@126.200.120.38] has joined #wesnoth-dev
20170427 01:15:26-!- gfgtdf_ [~chatzilla@x4e3633a2.dyn.telefonica.de] has joined #wesnoth-dev
20170427 01:17:24-!- gfgtdf__ [~chatzilla@x4e3633a2.dyn.telefonica.de] has joined #wesnoth-dev
20170427 01:17:38-!- gfgtdf [~chatzilla@x4e3631e9.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170427 01:17:48-!- gfgtdf__ is now known as gfgtdf
20170427 01:21:20-!- gfgtdf_ [~chatzilla@x4e3633a2.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170427 01:22:18-!- RatArmy_ [~ratarmy@126.200.120.38] has quit [Read error: Connection reset by peer]
20170427 01:24:34-!- gfgtdf [~chatzilla@x4e3633a2.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170427 01:27:30-!- irker921 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170427 02:17:42< vultraz_iOS> celticminstrel: status of wmltagporting2?
20170427 02:20:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170427 02:21:01< celticminstrel> IIRC it was ready to be merged after I confirm that the API refactor didn't break it.
20170427 02:21:21< celticminstrel> If you want to confirm for me, that would be acceptable too.
20170427 02:22:53< celticminstrel> I think PR 992 should also be released (assuming it works), but first people need to talk about it...
20170427 02:24:32< vultraz_iOS> API refactor?
20170427 02:25:06< celticminstrel> Of the new music API.
20170427 02:26:24-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.8 (1.14. Beta 1) scheduled for Sunday, May 7th 00:00 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170427 02:26:32< vultraz_iOS> we're not ready for a release this weekend
20170427 02:29:19< celticminstrel> Oh.
20170427 02:29:38< celticminstrel> Well, assuming no-one talks about 992, I'll probably work on 990 next.
20170427 02:30:53< celticminstrel> Do we need Elvish_Hunter to review 995?
20170427 02:31:19< vultraz_iOS> probably not
20170427 02:31:31< celticminstrel> Okay.
20170427 02:31:50< celticminstrel> As long as you're adding PRs to milestones, what abuot 984 / 987?
20170427 02:31:59< celticminstrel> ^about
20170427 02:32:02< celticminstrel> Maybe 988?
20170427 02:32:13< celticminstrel> And 983?
20170427 02:33:04< vultraz_iOS> both yes
20170427 02:33:14< celticminstrel> You said "both" when I named four.
20170427 02:33:49< vultraz_iOS> all
20170427 02:34:15-!- vultraz_iOS changed the topic of #wesnoth-dev to: 1.13.8 (1.14. Beta 1) scheduled for Sunday, May 14th 00:00 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170427 02:34:18< vultraz_iOS> we'll need more time
20170427 02:34:33< vultraz_iOS> everything marked needs to go in for this release
20170427 02:34:37< vultraz_iOS> 990 is not marked
20170427 02:34:44< celticminstrel> I know.
20170427 02:35:08-!- atarocch [~atarocch@rrcs-69-193-57-18.nys.biz.rr.com] has joined #wesnoth-dev
20170427 02:35:29< celticminstrel> 990 is just a draft.
20170427 02:35:32< vultraz_iOS> the CC change needs to happen too
20170427 02:35:38< vultraz_iOS> pydsigner: please get on that
20170427 02:35:38< celticminstrel> Oh yeah.
20170427 02:35:44< celticminstrel> Why are you asking him?
20170427 02:36:28< celticminstrel> I mean, it's like you're asking him to do something but didn't bother to tell him what the something is.
20170427 02:36:41< vultraz_iOS> he knows
20170427 02:36:46< celticminstrel> Oh?
20170427 02:36:51< celticminstrel> Do tell?
20170427 02:37:00< pydsigner> I thought we were going to merge and revise
20170427 02:37:11< celticminstrel> "he knows"
20170427 02:37:15< celticminstrel> Uhuh. Sure.
20170427 02:37:17< vultraz_iOS> I'm leaving it up to you when to merge
20170427 02:37:21< pydsigner> But I can take a revision tonight maybe
20170427 02:37:27< vultraz_iOS> and make any edits you deem necessary
20170427 02:37:34< vultraz_iOS> and write an announement
20170427 02:37:37< vultraz_iOS> (optinally)
20170427 02:37:40< vultraz_iOS> optionally*
20170427 02:37:44< pydsigner> Now see
20170427 02:37:47< celticminstrel> So basically you're foisting the whole thing on him?
20170427 02:37:50< pydsigner> that I didn't know
20170427 02:37:53< celticminstrel> But what about that huge debate?
20170427 02:38:06< vultraz_iOS> ehhh
20170427 02:38:11< vultraz_iOS> we decided something i think
20170427 02:38:25< celticminstrel> "I think" isn't good enough, is it?
20170427 02:38:34< pydsigner> vultraz_iOS: I'm not going to do the politics here
20170427 02:38:42< vultraz_iOS> no
20170427 02:40:17< pydsigner> I mean, I already wrote an announcement once, and it got posted as a discussion
20170427 02:41:19< vultraz_iOS> ok, look... just make any amendments you care to and I'll announce it when the release happens
20170427 02:42:30 * celticminstrel sighs.
20170427 02:45:02< Aginor> hmm
20170427 02:45:04< pydsigner> Heh.
20170427 02:45:13< Aginor> so we're going to relicense other people's content?
20170427 02:45:21< pydsigner> No
20170427 02:45:40< celticminstrel> Relicensing core content is part of the goal. but not content currently on the addon server.
20170427 02:45:41< Aginor> so they've assigned ownersip/copyright to wesnoth?
20170427 02:45:55< Aginor> even of the core content?
20170427 02:45:59< celticminstrel> I don't think so.
20170427 02:46:01< pydsigner> Aginor: Adding the CC as the primary license
20170427 02:46:13< celticminstrel> I think relicensing it means tracking everyone down and asking. :(
20170427 02:46:14< Aginor> so we're relicensing other people's contents
20170427 02:46:16< pydsigner> Does not require changing existing stuff's licensing
20170427 02:46:26< Aginor> IANAL, but this sounds dubious
20170427 02:46:41< vultraz_iOS> we are not relicensing anything yet
20170427 02:46:51< pydsigner> Aginor: only content that will have licenses changed is stuff for which we can get permission to do so
20170427 02:47:02< pydsigner> Or things that are already dual-licensed
20170427 02:47:21< pydsigner> (For example, all of Westlund's music we use has been CC for a long time)
20170427 02:47:32< celticminstrel> ...really?
20170427 02:47:53< pydsigner> Yes. Even back in the day when he was still active.
20170427 02:48:20-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170427 02:48:20-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170427 02:48:20-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170427 02:48:37< celticminstrel> Does anyone know how hard it would be to add a license key in _server.pbl?
20170427 02:48:53< pydsigner>     play
20170427 02:48:56< pydsigner> Er
20170427 02:49:01< pydsigner> https://mattiaswestlund.bandcamp.com/album/the-wesnoth-years
20170427 02:49:26< pydsigner> "All tracks are released under a Creative Commons Attribution license (CC BY 3.0)."
20170427 02:50:35< celticminstrel> We also need to have something somewhere that says exactly which parts are CC and which parts are GPL...
20170427 02:51:13< pydsigner> Yes.
20170427 02:51:43< pydsigner> We're way overdue on having a good attribution system anyways
20170427 02:51:48< celticminstrel> And relicensing the images is a herculean task made even harder by the fact that some are derived from others.
20170427 02:53:13< pydsigner> My expectation is that relicensing will never actually be completed.
20170427 02:53:22< celticminstrel> This applies mainly to the sprites, I guess. Derivatives of portraits are less common.
20170427 02:53:31< celticminstrel> Yeah, it's quite likely that it will never be completed.
20170427 02:54:14< celticminstrel> ...though, could the art eventually enter the public domain and then be relicensed? That wouldn't be anytime soon though.
20170427 02:54:33< celticminstrel> Then again, if it's public domain there's no real need to relicense it.
20170427 02:54:44< pydsigner> Sure, we can play the long game :)
20170427 02:55:12< Aginor> it'll never happen in all countries
20170427 02:55:36< Aginor> every time mickey mouse is about to enter public domain, disney lobbies to have US copyright lifespan extended
20170427 02:56:02< celticminstrel> Every time? How many times has this happened?
20170427 02:56:12< pydsigner> There are few film companies I dislike as strongly as Disney
20170427 02:56:20< vultraz_iOS> :|
20170427 02:56:31< Aginor> celticminstrel: 2 or 3 times I think
20170427 02:56:31< vultraz_iOS> disney owns star wars and that means you hate star wars
20170427 02:56:34< celticminstrel> Oh hi vultraz_iOS, welcome back.
20170427 02:56:51< pydsigner> vultraz_iOS: that does not follow.
20170427 02:56:57< celticminstrel> I think that's a huge stretch.
20170427 02:57:26< celticminstrel> Because Disney didn't create Star Wars. Plus, hating a company need not translate to hating what they create?
20170427 02:57:45< Aginor> http://artlawjournal.com/mickey-mouse-keeps-changing-copyright-law/
20170427 02:57:47< vultraz_iOS> perhaps, perhaps
20170427 02:58:34< vultraz_iOS> you have a point
20170427 02:58:48< pydsigner> I wouldn't call myself a big SW fan but I don't hate it.
20170427 03:02:13< pydsigner> Anyways.
20170427 03:02:30< pydsigner> Yeah, changing licenses is hard. Which is why we're not doing it the hard way.
20170427 03:03:13< pydsigner> We aren't even changing the default license for UMC to start with, just adding the option
20170427 03:04:03< celticminstrel> It'd be nice if the server could detect the license you chose and ask you to accept that specific license (together with a brief explanation of how to choose a different one).
20170427 03:04:54< pydsigner> Yeah that could be nice.
20170427 03:35:28-!- atarocch [~atarocch@rrcs-69-193-57-18.nys.biz.rr.com] has quit [Remote host closed the connection]
20170427 03:35:59-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 260 seconds]
20170427 03:37:04-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170427 04:12:10< vultraz_iOS> celticminstrel: is it safe to implement the non-const getters as non-virtual in display_context that use const_cast on the pure-virtual const ones?
20170427 04:12:35< celticminstrel> I think so.
20170427 04:13:23< vultraz_iOS> oh heh
20170427 04:13:31< vultraz_iOS> there's already a function that *does exactly that* p_p
20170427 04:13:50< vultraz_iOS> hidden_label_categories_ref
20170427 04:14:30< vultraz_iOS> so there's precedent :D
20170427 04:15:05< celticminstrel> XD
20170427 04:15:56< celticminstrel> Well, it's kinda silly to make derived classes override two functions when they could just override one.
20170427 04:16:32< celticminstrel> Hmm, come to think of it, actually...
20170427 04:17:04< celticminstrel> It's technically possible for that to be unsafe too... if one of the derived classes declared the underlying data as a const member... it's not the case here, of course, but...
20170427 04:17:55< vultraz_iOS> I wonder if it's possible to add a compile-time check for that..
20170427 04:18:21< celticminstrel> I'd think it's pretty difficult.
20170427 04:18:29< celticminstrel> I dunno if it's possible.
20170427 04:19:22-!- RatArmy_ [~ratarmy@om126211121204.13.openmobile.ne.jp] has joined #wesnoth-dev
20170427 04:21:27-!- Kwandulin [~Kwandulin@p200300760F6D8001ECD6B37F16A8B19F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 04:21:33-!- RatArmy_ [~ratarmy@om126211121204.13.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 04:42:03< vultraz_iOS> hmmm
20170427 04:42:15< vultraz_iOS> now how do I make the proxy class.. call only the appropriate qualified getter
20170427 04:44:11-!- Kwandulin [~Kwandulin@p200300760F6D8001ECD6B37F16A8B19F.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170427 04:44:23< celticminstrel> Uh, what?
20170427 04:44:47< celticminstrel> Obviously the proxy class needs duplicate getters too, right?
20170427 04:45:04< vultraz_iOS> celticminstrel: if the proxy class is passed a const d_c, I want it to call the const getters, and vice versa
20170427 04:46:10< celticminstrel> And just how is that even supposed to work?
20170427 04:46:29< vultraz_iOS> metamagic
20170427 04:48:34< celticminstrel> I can't think of any way to do that.
20170427 04:48:58< celticminstrel> You probably have to settle for just making the proxy only call non-const members.
20170427 04:50:28< celticminstrel> You'd actually need a separate proxy class to be able to wrap a const display_context.
20170427 05:01:25< vultraz_iOS> celticminstrel: does the proxy class need a virtual dtor?
20170427 05:01:37< vultraz_iOS> (I'm unsure when a class needs one or not)
20170427 05:02:23< celticminstrel> A class needs a virtual destructor if it has any virtual functions... so the proxy class probably wouldn't need one.
20170427 05:02:32< vultraz_iOS> ahh
20170427 05:03:18-!- JyrkiVesterinen [~JyrkiVest@87-100-209-246.bb.dnainternet.fi] has joined #wesnoth-dev
20170427 05:09:56< vultraz_iOS> celticminstrel: why is that so, though?
20170427 05:10:06< vultraz_iOS> celticminstrel: ie, what exactly does a virtual dtor enable
20170427 05:10:15< vultraz_iOS> is it needed when a class is fully abstract?
20170427 05:10:24< celticminstrel> Suppose you have class A, and clas B that extends class A.
20170427 05:10:35< vultraz_iOS> is it needed if a class has virtual functions but no data members?
20170427 05:10:41< celticminstrel> Class B holds some resource, maybe a file or something.
20170427 05:11:08< celticminstrel> If you write "A* ptr = new B; delete A", B's destructor is not called.
20170427 05:11:18< celticminstrel> So the file won't be closed.
20170427 05:11:30< celticminstrel> That's why A needs to have a virtual destructor.
20170427 05:11:35< vultraz_iOS> delete A? dont you mean delete ptr?
20170427 05:11:40< celticminstrel> Yes.
20170427 05:12:30< vultraz_iOS> ok, so basically it allows derived classes to override the dtor with their own like any other virtual function?
20170427 05:12:50< celticminstrel> Sort of.
20170427 05:13:21< celticminstrel> A virtual destructor works a little differently from other virtual functions though, in that the base class destructor is called even if a subclass overrides it.
20170427 05:13:34< celticminstrel> More precisely, the subclass destructor is called, followed by the base class destructor.
20170427 05:14:52< vultraz_iOS> i see
20170427 05:16:04< vultraz_iOS> ok, I have suceeded 
20170427 05:16:16< vultraz_iOS> succeeded  
20170427 05:16:34< celticminstrel> Basically, if there might ever be a situation where you have a A" that actually points to a B, you should probably have a virtual destructor.
20170427 05:16:45< celticminstrel> Any class that's intended to be polymorphic needs one.
20170427 05:16:49< vultraz_iOS> celticminstrel: https://github.com/Vultraz/wesnoth/commit/5ca0dd8142a534458987d8f430c16167265cfc8d
20170427 05:16:58< vultraz_iOS> (JyrkiVesterinen might also be interested)
20170427 05:17:02< vultraz_iOS> though it crashes :/
20170427 05:17:07< vultraz_iOS> so not 100% succeeded.. 
20170427 05:17:09< vultraz_iOS> need to investigate
20170427 05:21:59< celticminstrel> vultraz_iOS: What's with the "todo: rename" on hidden_label_categories_ref?
20170427 05:22:13< vultraz_iOS> was going to make it an overload like the others
20170427 05:22:28< celticminstrel> Oh, was it already there and named that?
20170427 05:22:34< vultraz_iOS> yes
20170427 05:22:36 * celticminstrel probably added that actually.
20170427 05:23:01< celticminstrel> IIRC, that should only be used in a few places like the label settings dialog?
20170427 05:23:24< celticminstrel> I forget how you open the label settings dialog...
20170427 05:23:46< celticminstrel> Ah, you made it a template, huh.
20170427 05:24:57< celticminstrel> If you could define functions using a typedef that would pretty much work for what you wanted to do there, but it's unfortunately impossible.
20170427 05:25:25< vultraz_iOS> actually I think I know what's causing the crash
20170427 05:25:43< vultraz_iOS> in reports::context, the proxy is specialized for display_context directly
20170427 05:25:55< celticminstrel> You could however declare the functions with a typedef and then define them as specializations, I suppose.
20170427 05:26:12< celticminstrel> I'm not sure if that would actually work.
20170427 05:26:25< vultraz_iOS> so it's trying to const_cast a pure virtual function..
20170427 05:26:30< vultraz_iOS> 's output
20170427 05:26:31< vultraz_iOS> hm
20170427 05:26:35< vultraz_iOS> celticminstrel: what?
20170427 05:26:43< celticminstrel> Why would that be a problem?
20170427 05:26:54< vultraz_iOS> is it not?
20170427 05:26:55< vultraz_iOS> ok
20170427 05:27:04< vultraz_iOS> now what is this you're saying
20170427 05:28:01< vultraz_iOS> ugh
20170427 05:28:09< vultraz_iOS> the crash doesn't even throw a segfault
20170427 05:28:11< celticminstrel> Hmm...
20170427 05:28:18< celticminstrel> Oh? What kind of crash is it?
20170427 05:28:18< vultraz_iOS> or an exception or anything :|
20170427 05:28:26< vultraz_iOS> it just freezes
20170427 05:28:39< celticminstrel> Infinite loop somewhere? >_>
20170427 05:28:41< vultraz_iOS> no stack
20170427 05:28:51< celticminstrel> ???
20170427 05:28:55< celticminstrel> Oh, no stack trace?
20170427 05:29:05< vultraz_iOS> yes
20170427 05:29:20< vultraz_iOS> does anything look obviously wrong?
20170427 05:30:58< vultraz_iOS> celticminstrel: I think you mean game_lua_kernel?
20170427 05:31:26< vultraz_iOS> they were public in menu_handler
20170427 05:31:36< vultraz_iOS> and two were public in glk
20170427 05:31:42< celticminstrel> When I looked closer it seems that's not the case?
20170427 05:31:49< vultraz_iOS> well, i made board public recently
20170427 05:31:53< vultraz_iOS> could revert that..
20170427 05:32:24< celticminstrel> I think ideally those functions should not be public in g_l_k.
20170427 05:32:39< vultraz_iOS> probably
20170427 05:32:40< celticminstrel> As for the menu_handler...
20170427 05:32:57< celticminstrel> https://github.com/Vultraz/wesnoth/commit/5ca0dd8142a534458987d8f430c16167265cfc8d#diff-b435c67bdb50a8ed1b99b9d2d40101d8R113
20170427 05:33:01< celticminstrel> See? They were private.
20170427 05:33:14< vultraz_iOS> oh
20170427 05:33:17< vultraz_iOS> collapsed gh view
20170427 05:33:31< celticminstrel> This commit is actually nice and small, huh.
20170427 05:33:40< celticminstrel> Somehow I expected it to be much more expansive.
20170427 05:34:05< vultraz_iOS> has a few formatting things you probably don't like :P
20170427 05:34:05< celticminstrel> I think board() probably shouldn't be public either in g_l_k.
20170427 05:34:14< celticminstrel> Oh, yeah, there's a couple of those.
20170427 05:34:38< celticminstrel> I don't know if making those private is possible. Maybe they're referenced from Lua API stuff that's not member functions of g_l_k.
20170427 05:35:33< vultraz_iOS> i can deal with that later
20170427 05:35:43< vultraz_iOS> right now, do you see anything that would obviously cause a crash?
20170427 05:37:28< vultraz_iOS> oh huh, static_assert can be in the class scope..
20170427 05:37:34< vultraz_iOS> i wonder if i should do that here?
20170427 05:37:42< celticminstrel> static_assert can go anywhere IIRC
20170427 05:38:00< celticminstrel> I've used it at global scope sometimes.
20170427 05:38:00< vultraz_iOS> is it useful at all where it is?
20170427 05:38:05< celticminstrel> Where?
20170427 05:38:14< vultraz_iOS> in the ctor body\
20170427 05:38:36< celticminstrel> Should be?
20170427 05:38:40< vultraz_iOS> ok
20170427 05:39:00< celticminstrel> Why do you have an extra pair of parentheses there?
20170427 05:39:08< vultraz_iOS> no real reason
20170427 05:39:17< vultraz_iOS> just kinda been doing that
20170427 05:39:18< vultraz_iOS> can remove
20170427 05:40:10< vultraz_iOS> i wonder if marking the functions const in the proxy is causing problems...
20170427 05:40:16< vultraz_iOS> though you would think the compiler would catch it..
20170427 05:40:34< vultraz_iOS> so i guess not
20170427 05:40:42< vultraz_iOS> can't figure out what might be the problem
20170427 05:40:47< vultraz_iOS> :/
20170427 05:41:14< celticminstrel> Oh.
20170427 05:41:25< celticminstrel> You didn't fix the unsafe function call in game_lua_kernel.
20170427 05:41:36< celticminstrel> I'm pretty sure I pointed that out before?
20170427 05:41:36< vultraz_iOS> have locally, didn't do anything
20170427 05:41:41< celticminstrel> Oh okay.
20170427 05:41:53< celticminstrel> I'm talking about line 4068 of the cpp, just FTR.
20170427 05:42:04< vultraz_iOS> yes
20170427 05:42:40< celticminstrel> The other two cases don't have anything unsafe like that...
20170427 05:43:07< vultraz_iOS> hnmmm
20170427 05:43:16< vultraz_iOS> game_board has unit_map & units()
20170427 05:43:23< vultraz_iOS> perhaps this is causing problems
20170427 05:43:26< celticminstrel> ???
20170427 05:43:53< vultraz_iOS> game_board declares its own non-const units getter
20170427 05:44:07< celticminstrel> If that caused problems I think it would be a compile error?
20170427 05:44:14< vultraz_iOS> well, worth a shot 
20170427 05:44:48< celticminstrel> No, wait, that shouldn't cause any problems, right?
20170427 05:44:54< vultraz_iOS> *i don't lmpw*
20170427 05:44:57< vultraz_iOS> know
20170427 05:45:24< celticminstrel> It's just redundant. If called via a game_board reference, it'll call the game_board version, and if called via a display_context reference, it'll call the display_context version, but ultimately both return the same thing, right?
20170427 05:45:44< celticminstrel> Should be safe to remove it.
20170427 05:46:03< vultraz_iOS> ah fuck 
20170427 05:46:43< vultraz_iOS> C:\Users\exodi\Documents\wesnoth\src\actions\heal.cpp|86|error: binding 'const unit_map' to reference of type 'unit_map&' discards qualifiers|
20170427 05:46:47< vultraz_iOS> *sigh*
20170427 05:47:10< vultraz_iOS> looks like the units() in game_board was hiding the one in d_c
20170427 05:47:11< celticminstrel> Uhh... what?
20170427 05:47:16< celticminstrel> Yes, obviously.
20170427 05:48:06< vultraz_iOS> but why
20170427 05:48:08< celticminstrel> But the d_c version is "unit_map& units()" right?
20170427 05:48:13< vultraz_iOS> is it
20170427 05:48:14< vultraz_iOS> yes
20170427 05:48:23< celticminstrel> Ah.
20170427 05:48:51< vultraz_iOS> ah?
20170427 05:49:28< celticminstrel> Hmm, that theory didn't work.
20170427 05:49:49< celticminstrel> The line you cited uses resources::gameboard which is declated as "game_board* gameboard", so not const.
20170427 05:50:03< celticminstrel> So it should call the non-const function.
20170427 05:50:07< celticminstrel> ^declared
20170427 05:50:23< vultraz_iOS> but it is not
20170427 05:50:31< celticminstrel> Not what?
20170427 05:50:39< celticminstrel> Oh.
20170427 05:51:34< celticminstrel> Oh...
20170427 05:51:40< vultraz_iOS> hm?
20170427 05:51:51< celticminstrel> Ugh, that's a pain.
20170427 05:52:03< celticminstrel> Does it work if you add "using display_context::units"?
20170427 05:52:41< vultraz_iOS> yes
20170427 05:52:48< celticminstrel> Hmm.
20170427 05:53:26< vultraz_iOS> why, though
20170427 05:53:43< vultraz_iOS> why would an overload in a derived class hide one in the base class
20170427 05:53:55< celticminstrel> Because you've declared a function called units() in game_board, it hides any other overloaded functions with the same name in display_context.
20170427 05:54:12< vultraz_iOS> even if it's a virtual override :|
20170427 05:54:14< celticminstrel> The using declaration brings the otherwise hidden function into scope.
20170427 05:54:26< celticminstrel> Yeah, exactly, even if it's a virtual override. :/
20170427 05:54:38< vultraz_iOS> seems like an oversight on the c++ guys' part
20170427 05:55:16< vultraz_iOS> what the actual fuck
20170427 05:55:18< vultraz_iOS> ..\..\src\map\map.hpp|111|error: 't_translation::terrain_code& gamemap::operator[](const map_location&)' is private|
20170427 05:55:20< vultraz_iOS> ?????????????
20170427 05:55:22< celticminstrel> I wonder how many uses of resources::gameboard actually need a game_board.
20170427 05:56:17< vultraz_iOS> most, none, I'd say
20170427 05:56:36< celticminstrel> That private function is probably intended to make [] lookup-only.
20170427 05:56:42< vultraz_iOS> now where the fuck is this coming from though
20170427 05:56:52< celticminstrel> There are definitely some uses of resources::gameboard that actually need a game_board.
20170427 05:57:19< vultraz_iOS> so it's within the context of resources::gameboard->map()...
20170427 05:57:31< celticminstrel> So it's again due to hiding.
20170427 05:57:46< vultraz_iOS> i added the using
20170427 05:57:56< celticminstrel> Oh, you added a using for map()?
20170427 05:58:09< vultraz_iOS> yes
20170427 05:58:23< vultraz_iOS> it seems like what one should do :|
20170427 05:58:44< celticminstrel> Well, that's why then.
20170427 05:58:47< vultraz_iOS> apparently the using caused the error
20170427 05:58:49< vultraz_iOS> why :|
20170427 05:59:12< celticminstrel> Did game_board have a non-const map() before?
20170427 05:59:13< vultraz_iOS> also, this bloody hiding maybe part of the problem...
20170427 05:59:43< vultraz_iOS> when the proxy is (not it did not) specialized for game_map, is it possible the const_cast is tryig to cast the result of the const function?
20170427 05:59:47< celticminstrel> Hmm, but I wonder if the private [] could just be deleted from gamemap... unless it's actually used internally?
20170427 05:59:51< vultraz_iOS> oh wait
20170427 05:59:53< vultraz_iOS> that's what we want
20170427 05:59:57< celticminstrel> But if it's only used internally you could rename it to something like rawset().
20170427 05:59:59< vultraz_iOS> nevermind
20170427 06:00:43< celticminstrel> I think for the display_context_proxy I'd actually suggest requiring that it take only a display_context ref, not any descendant of it.
20170427 06:00:53< celticminstrel> That way it won't need to worry about hiding issues.
20170427 06:01:04< vultraz_iOS> but how do I do that
20170427 06:01:24< celticminstrel> Replace is_base with is_same, I guess?
20170427 06:01:37< vultraz_iOS> specialize all cases with display_context?
20170427 06:01:42< celticminstrel> ?
20170427 06:01:53< celticminstrel> Why are we talking about specializing all of a sudden?
20170427 06:02:06< vultraz_iOS> when the classes inherit from the proxy
20170427 06:02:08< celticminstrel> The thing is, the display_context_proxy doesn't need to know it's actually wrapping a game_board, right?
20170427 06:02:12< celticminstrel> Oh, yeah.
20170427 06:02:15< vultraz_iOS> should they all inherit from proxy<dc> or const dc
20170427 06:02:36< celticminstrel> ATM there's not really any difference between the two...
20170427 06:02:42< celticminstrel> Which might be a bit of a problem...
20170427 06:02:52< vultraz_iOS> what?
20170427 06:03:12< celticminstrel> Oh, actually, I think display_context_proxy<const display_context> would be a compile error?
20170427 06:03:20< vultraz_iOS> no?
20170427 06:03:24< vultraz_iOS> i already do that once
20170427 06:03:28< celticminstrel> Hmm.
20170427 06:03:41< celticminstrel> I thought because you have const functions returning non-const members...
20170427 06:03:52< vultraz_iOS> no
20170427 06:03:54< vultraz_iOS> ?
20170427 06:04:17< vultraz_iOS> if you use proxy<dc>, the getters return non-const references
20170427 06:04:32< vultraz_iOS> if you use proxy<const dc>, they return const ones
20170427 06:04:37< celticminstrel> But the getters are still declared const in either case.
20170427 06:04:55< vultraz_iOS> no?
20170427 06:05:05< celticminstrel> "getter_t<std::vector<team>>& teams() const"
20170427 06:05:15< vultraz_iOS> yes, but they don't return const..
20170427 06:05:20< vultraz_iOS> and i asked you if this could be a problem
20170427 06:05:22< celticminstrel> But they are const functions.
20170427 06:05:30< celticminstrel> Hmm.
20170427 06:05:36< vultraz_iOS> and jesus fucking christ now i have an infinite loop in the loading screen WHAT THE HELL
20170427 06:05:45< celticminstrel> Ah, but dc_'s constness depends on the constness of the template argument.
20170427 06:05:49< vultraz_iOS> at least before it entered the game before crashing
20170427 06:05:49< celticminstrel> So maybe that's why it works out.
20170427 06:06:04< vultraz_iOS> now it sticks on "initializing teams"
20170427 06:06:07< vultraz_iOS> jesus christ WHY
20170427 06:06:50< vultraz_iOS> do you think I should try using only dc?
20170427 06:08:06-!- JyrkiVesterinen [~JyrkiVest@87-100-209-246.bb.dnainternet.fi] has quit [Quit: .]
20170427 06:08:24< celticminstrel> ?
20170427 06:08:51< vultraz_iOS> specialize the inheritance using dc only
20170427 06:09:21< vultraz_iOS> worth a shot, i guess
20170427 06:09:33< vultraz_iOS> since i have NFI why any of this is happening
20170427 06:09:48< celticminstrel> I think it's safer that way.
20170427 06:09:58< celticminstrel> And use is_same instead of is_base in the ctor to enforce it.
20170427 06:10:26< celticminstrel> I don't expect it to fix your issues though...
20170427 06:10:33< vultraz_iOS> looks like is_same respects constness
20170427 06:10:38< vultraz_iOS> oh wait
20170427 06:10:43< vultraz_iOS> there's a remove const thingy..
20170427 06:10:58< celticminstrel> Well, if is_same does respect constness you can add the remove_const.
20170427 06:10:58< vultraz_iOS> i think
20170427 06:11:06< vultraz_iOS> yes
20170427 06:11:17< celticminstrel> std::is_same<std::remove_const<T>::type, display_context>::value
20170427 06:13:03< vultraz_iOS> huh, errors with the ::type
20170427 06:13:26< celticminstrel> Probably needs typename.
20170427 06:13:36< vultraz_iOS> works without it
20170427 06:13:44< celticminstrel> What's the error then?
20170427 06:13:56< vultraz_iOS> no i mean it works without the ::type
20170427 06:13:59< vultraz_iOS> it says it expected a type
20170427 06:14:12< celticminstrel> Uh, it won't work without the ::type...
20170427 06:14:21< celticminstrel> std::is_same<typename std::remove_const<T>::type, display_context>::value
20170427 06:14:40< celticminstrel> ^
20170427 06:15:11< celticminstrel> It might seem to compile without the ::type, but then the static_assert will trigger because std::remove_const is not the same as display_context.
20170427 06:15:19< celticminstrel> ^ std::remove_const<T>
20170427 06:15:34< celticminstrel> ie std::remove_const<display_context> is not the same as display_context.
20170427 06:15:53< vultraz_iOS> i see
20170427 06:16:10< vultraz_iOS> weird that the assert is only triggering for reports::context...
20170427 06:16:13< vultraz_iOS> not the others..
20170427 06:16:15< vultraz_iOS> yet
20170427 06:16:46< vultraz_iOS> i thought it was wotking w/o the ::type since i read metafunctions can be template arguments in c++11
20170427 06:17:05< celticminstrel> I don't think there's any way for that to work.
20170427 06:17:15< celticminstrel> In order to work without the ::type it would have to be a template alias.
20170427 06:17:20< celticminstrel> ie, using-declaration.
20170427 06:17:23< vultraz_iOS> ahhhhhhhhhhhhhhhh
20170427 06:17:44< celticminstrel> But all the C++ standard library type traits are structs, because template aliases didn't exist yet.
20170427 06:18:13< vultraz_iOS> why the hell didn't they change that
20170427 06:18:18< celticminstrel> Mind you, making it a struct is also more flexible in some ways.
20170427 06:18:42< celticminstrel> Uhh. Why would they change it?
20170427 06:18:51< celticminstrel> Changing it would break all the code using type traits.
20170427 06:18:58< celticminstrel> Obviously they're not going to change it.
20170427 06:21:06< vultraz_iOS> i like breaking things
20170427 06:29:45< vultraz_iOS> ugh
20170427 06:29:47< vultraz_iOS> i give up
20170427 06:29:54< vultraz_iOS> infite loop in game creation
20170427 06:29:56< vultraz_iOS> *why*
20170427 06:30:26< DeFender> Probably because for some reason the loop is never beaing broken out of?
20170427 06:30:43 * DeFender is not helping
20170427 06:30:52< vultraz_iOS> :|
20170427 06:31:08< DeFender> Actually, I should say...
20170427 06:31:15-!- DeFender is now known as CaptainObvious
20170427 06:31:19< vultraz_iOS> :|
20170427 06:31:20 * CaptainObvious is not helping.
20170427 06:31:26-!- CaptainObvious is now known as DeFender1031
20170427 06:34:08< vultraz_iOS> but *why*
20170427 06:34:11< vultraz_iOS> there's no reason
20170427 06:35:06< vultraz_iOS> why should deferring the getters in game_board to the base class cause a loop
20170427 06:35:07< vultraz_iOS> why!
20170427 06:35:58< celticminstrel> Hmm.
20170427 06:35:59< DeFender1031> umm.... code gnomes?
20170427 06:36:34< celticminstrel> Yeah, I have no idea. I suggest using a debugger.
20170427 06:37:09< matthiaskrgr> 00:27 < gfgtdf> matthiaskrgr: #25677 is fixed coud you please also test the other one ?
20170427 06:37:33< matthiaskrgr> gfgtdf 25677 is fixed, 25676 persists
20170427 06:40:19< vultraz_iOS> wait
20170427 06:40:41< vultraz_iOS> celticminstrel: is it possible that we end up in an infinite call loop
20170427 06:40:45< vultraz_iOS> we have the proxy
20170427 06:40:55< vultraz_iOS> it calls dc_.func()
20170427 06:41:03< vultraz_iOS> func() calls const_cast on the same func
20170427 06:41:07< vultraz_iOS> but for, say, game_board
20170427 06:41:12< vultraz_iOS> that defers back to the base class
20170427 06:41:19< vultraz_iOS> oh wait
20170427 06:41:21< vultraz_iOS> hm
20170427 06:41:26< vultraz_iOS> no, that... shouldn't be a problem..
20170427 06:41:34< vultraz_iOS> because gb doesn't inherit from the proxy
20170427 06:41:47< celticminstrel> Right, right. The proxy is actually an unrelated class.
20170427 06:45:36-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170427 06:47:10< vultraz_iOS> https://github.com/Vultraz/wesnoth/commit/ddf0b5db4492a1f93787e51a8998ee68076bbb49
20170427 06:50:42< JyrkiVesterinen> Functions calling each other infinitely should cause a stack overflow and crash.
20170427 06:51:00< vultraz_iOS> i see
20170427 06:51:03< vultraz_iOS> but there is no crash
20170427 06:51:28< vultraz_iOS> well, not after tha commit
20170427 06:51:36< vultraz_iOS> the first commit produced a crash
20170427 07:04:09-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170427 07:08:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170427 07:10:33< vultraz_iOS> celticminstrel: ok, something is caught in an infinite loop calling teams()...
20170427 07:11:10< vultraz_iOS> printed to cerr and the loop in the titlescreen shows the non-const getter is being called over and over..
20170427 07:11:19< vultraz_iOS> wait...
20170427 07:11:40< vultraz_iOS> cel
20170427 07:11:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has left #wesnoth-dev []
20170427 07:11:58< vultraz_iOS> celticminstrel, JyrkiVesterinen: when this `const_cast<std::vector<team>&>(this->teams());` is called, how does it know whether to call the const or non-const version?
20170427 07:12:24< vultraz_iOS> of course...
20170427 07:12:36< vultraz_iOS> the SO page had a  static_cast<const X&>( bit
20170427 07:16:56< JyrkiVesterinen> The compiler calls the non-const version if "this" is non-const.
20170427 07:16:58< JyrkiVesterinen> See http://stackoverflow.com/q/164102
20170427 07:17:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170427 07:17:21< vultraz_iOS> then this function is calling const_cast on itself
20170427 07:17:25 * vultraz_iOS attempts
20170427 07:17:26< vultraz_iOS> return const_cast<std::vector<team>&>(static_cast<const display_context&>(*this).teams());
20170427 07:18:03< celticminstrel> Personally I think the two-line form looks nicer (no ugly static_cast), but yeah, that's basically right.
20170427 07:18:10< vultraz_iOS> OK
20170427 07:18:18< vultraz_iOS> something is still looping :|
20170427 07:18:26< celticminstrel> (I'd also use (this)->teams rather than (*this).teams but that makes no actual difference.)
20170427 07:18:27< vultraz_iOS> but at least it breaks out of the initializing teams bit
20170427 07:18:32< vultraz_iOS> we now get to starting game
20170427 07:18:35< JyrkiVesterinen> (IMO, static_cast is not ugly at all, but const_cast is extremely ugly...)
20170427 07:18:36< vultraz_iOS> and the game freezes
20170427 07:18:59< vultraz_iOS> JyrkiVesterinen: see https://github.com/wesnoth/wesnoth/compare/master...Vultraz:master and you'll get why im doing it so https://github.com/wesnoth/wesnoth/compare/master...Vultraz:master
20170427 07:19:01< vultraz_iOS> oops;
20170427 07:19:03< vultraz_iOS> linked twice
20170427 07:19:32< celticminstrel> JyrkiVesterinen: IMO all the C++ style casts are ugly.
20170427 07:20:03< celticminstrel> Although it is kind of cool how they look like a template function, so you can effectively define new casts as template functions.
20170427 07:20:09< vultraz_iOS> i guess it didn't crash before because the loop was in a different thread
20170427 07:20:23< DeFender1031> celticminstrel, IIRC, they actually ARE template functions.
20170427 07:21:02< celticminstrel> DeFender1031: No, they're apparently considered to be operators.
20170427 07:21:03< DeFender1031> celticminstrel, the C++ libs used at my day job have a couple of new casts they've created.
20170427 07:21:08< JyrkiVesterinen> vultraz_iOS: It may have been so-called tail call optimization, which resulted in the function calls not taking any stack space.
20170427 07:21:17< JyrkiVesterinen> Unoptimized builds would likely have crashed.
20170427 07:21:23< celticminstrel> Oh, that was a thing that exists, huh.
20170427 07:21:35< vultraz_iOS> well, now it crashes
20170427 07:21:39< vultraz_iOS> once the threads converge
20170427 07:21:47< vultraz_iOS> and it's still looping ;_;
20170427 07:21:49< vultraz_iOS> i sad.
20170427 07:22:02< celticminstrel> If it might be tail-call optimization, try a debug buld?
20170427 07:27:04-!- celticminstrel is now known as celmin|sleep
20170427 07:27:33< vultraz_iOS> celmin|sleep: interesting
20170427 07:27:44< vultraz_iOS> when i make the getters in the proxy class non-const i get compiler errors
20170427 07:28:09< vultraz_iOS> menu_events.cpp|222|error: passing 'const events::menu_handler' as 'this' argument discards qualifiers [-fpermissive]|
20170427 07:30:44< vultraz_iOS> looks like i need to ensure the proxy classes are also conditionally const?
20170427 07:31:11< vultraz_iOS> though the menu_handler getters had widly different constness..
20170427 07:31:14< vultraz_iOS> wildly*
20170427 07:43:11< vultraz_iOS> Hmm
20170427 07:43:26< vultraz_iOS> Actually, obviously the teams getter is calling the non-const function...
20170427 08:09:11< vultraz_iOS> hmm
20170427 08:09:19< vultraz_iOS> the loop isn't coming from...
20170427 08:09:25< vultraz_iOS> a proxy call
20170427 08:10:47< vultraz_iOS> weird
20170427 08:11:26< vultraz_iOS>  if i run the game via a debugger i can bypass the loop...
20170427 08:22:41-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has joined #wesnoth-dev
20170427 08:23:45< zookeeper> ...really weird. if i open the editor, scale the map down (so that the borders show on all sides), the background image gets drawn slightly lighter than it should. then when i F5, it returns to normal.
20170427 08:23:46-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 08:24:18< vultraz_iOS> JyrkiVesterinen: do you have any suggestions
20170427 08:24:20< zookeeper> i spent quite a bit of time trying to track down what i assumed was a small difference in the colour values of related images because of that
20170427 08:24:48< vultraz_iOS> :/
20170427 08:25:22< JyrkiVesterinen> vultraz_iOS: If you can reproduce the loop in a debugger, you should already know the cause?
20170427 08:26:20< zookeeper> should be easy to test: create a small map like that, start the editor, open the map, take screenshot. then press F5, and take another screenshot. the colour of the background should have a subtle difference.
20170427 08:26:21< vultraz_iOS> guess i need a debug build
20170427 08:26:56< vultraz_iOS> but i meant perhaps if you say anything directly wrong with the method used
20170427 08:27:25< vultraz_iOS> ie, having a base class loop back to a derived class;s result in such a way.
20170427 08:37:25< JyrkiVesterinen> Hmm... when I think about it, one strange thing sticks out.
20170427 08:37:42< JyrkiVesterinen> The display_context class contains pure virtual functions.
20170427 08:37:58< JyrkiVesterinen> In other words, display_context is an abstract class.
20170427 08:38:29< JyrkiVesterinen> Display_context objects can't exist: there are only instances of _subclasses_ of display_context.
20170427 08:38:54< JyrkiVesterinen> So... how can the static_assert in display_context_proxy constructor ever pass?
20170427 08:39:17< vultraz_iOS> because I explicitly specialize it as so
20170427 08:40:59< vultraz_iOS> wait
20170427 08:41:25< vultraz_iOS> hm
20170427 08:41:35< vultraz_iOS> JyrkiVesterinen: actually, you have a point for the case in reports.hpp...
20170427 08:41:39< vultraz_iOS> reports::context
20170427 08:41:46< vultraz_iOS> i don't understand how the code would originally have worked
20170427 08:41:58< vultraz_iOS> it's passed a display_context...
20170427 08:42:13< vultraz_iOS> unless the object *actually* passed were *not* a dc but a derived class..
20170427 08:42:17< vultraz_iOS> let us see..
20170427 08:42:24< JyrkiVesterinen> It has to be a derived class.
20170427 08:43:51< vultraz_iOS> indeed..
20170427 08:44:06< vultraz_iOS> in which case my code would appear to be wrong 
20170427 08:45:22< vultraz_iOS> can't figure out what's actually passed, though..
20170427 08:45:27< vultraz_iOS> the code is very obscure
20170427 08:45:50< JyrkiVesterinen> Runtime analysis in a debugger would give you the answer immediately.
20170427 08:46:10< vultraz_iOS> i honestly have no idea how to do that :|
20170427 08:47:17< JyrkiVesterinen> Consider learning to debug. It's an extremely useful skill.
20170427 08:47:18< JyrkiVesterinen> https://www.youtube.com/watch?v=C0vDKXIq_9A
20170427 08:49:56< vultraz_iOS> looks like VS gives you absolutely nothing if it's something built with VS :|
20170427 08:50:34< JyrkiVesterinen> Yes, I think GCC and VS use different ways to store debug information.
20170427 08:52:39< vultraz_iOS> i should probably switch to using VS..
20170427 08:52:55< vultraz_iOS> only reason i haven't is its always taken 4x as long to build for me
20170427 08:52:58< vultraz_iOS> compared to cb/gcc
20170427 08:53:10< JyrkiVesterinen> The debugger is the reason why I use VS myself.
20170427 08:55:33< vultraz_iOS> ok, i now have a stacktrace on the crash
20170427 08:55:53< vultraz_iOS> (for some reason using a debugger skips the crash *Before* entering a game)
20170427 09:00:30-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170427 09:01:42-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: Lunch]
20170427 09:02:21< vultraz_iOS> i should definitely update to vs17 proper tho
20170427 09:04:29< vultraz_iOS> hmmmmmmmmmmmmmmmmmmm
20170427 09:04:44< vultraz_iOS> ok so i've traced creation of a new reports context to display.hpp
20170427 09:04:46< vultraz_iOS> cpp*
20170427 09:05:09< vultraz_iOS> where it's generated by dereferencing dc_
20170427 09:05:19< vultraz_iOS> which is a display_context ptr
20170427 09:06:56< vultraz_iOS> display is the base class of game_display
20170427 09:08:06< vultraz_iOS> where it's initialized...
20170427 09:08:08< vultraz_iOS> with...
20170427 09:08:10< vultraz_iOS> a game_board
20170427 09:08:12< vultraz_iOS> oh come on :|
20170427 09:08:23< vultraz_iOS> all this misdirection
20170427 09:10:21< vultraz_iOS> and the editor initializes it with a dummy
20170427 09:11:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170427 09:15:25-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has joined #wesnoth-dev
20170427 09:22:40-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 09:23:00-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170427 09:26:03< vultraz_iOS> heh
20170427 09:26:12< vultraz_iOS> apparently c++17 has as_const
20170427 09:28:41-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170427 09:32:37-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170427 09:34:07-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170427 09:34:40< JyrkiVesterinen> Well, if it's any help, std::add_const is C++11.
20170427 09:44:04< vultraz_iOS> btw, your remarks made me realize something possibly very wrong with my code - the proxy was *always* storing its member as a display_context
20170427 09:44:07< vultraz_iOS> reference
20170427 09:44:30< vultraz_iOS> regardless of specialization 
20170427 09:45:24< vultraz_iOS> so, I'm changing it to take T directly
20170427 09:45:33< vultraz_iOS> er, s/use/take
20170427 09:45:35< vultraz_iOS> er
20170427 09:45:37< vultraz_iOS> s/take/use
20170427 09:45:39< vultraz_iOS> >_<
20170427 09:45:48< JyrkiVesterinen> That shouldn't be a problem. Because the const functions are virtual, the compiler will call the right function.
20170427 09:46:14< JyrkiVesterinen> Either directly, or from the non-const function (that calls the corresponding const function).
20170427 09:47:08< vultraz_iOS> well... either way it's unnecessary 
20170427 09:47:37< vultraz_iOS> and using T directly has revealed a compiler error..
20170427 09:48:38< vultraz_iOS> display_context.hpp|168|error: binding 'const gamemap' to reference of type 'display_context_proxy<game_board>::getter_t<gamemap>& {aka gamemap&}' discards qualifiers|
20170427 09:48:40< vultraz_iOS> hmmmmmmmmmmmmmmmmmmmmmmm
20170427 09:49:04< vultraz_iOS> this is *probably* since I didn't expose the base class non-const getter in game_board...
20170427 09:49:22< vultraz_iOS> since doing so causes weird-ass compiler errors about something totally unrelated being private
20170427 09:49:23< JyrkiVesterinen> Maybe it would work with display_context_proxy<const game_board>
20170427 09:50:24< vultraz_iOS> I think a small problem here is that the different getters all had different qualifiers in the old code..
20170427 09:50:55< vultraz_iOS> so menu_events::map returned a const reference and was const
20170427 09:50:59< vultraz_iOS> teams was neither
20170427 09:51:07< vultraz_iOS> and units was const but returned a non-const ref
20170427 09:51:15< vultraz_iOS> the proxy makes them all either const or not const
20170427 09:51:29< vultraz_iOS> the retvals, that is
20170427 09:52:19< vultraz_iOS> and there's really no way to solve that :/
20170427 09:52:29< JyrkiVesterinen> It would be best to have both const and non-const versions of each getter.
20170427 09:52:53< JyrkiVesterinen> And how can menu_events::units() even be const and return a non-const reference?
20170427 09:53:34< vultraz_iOS> ah, wait, i switched the qualifiers of units and teams
20170427 09:53:37< vultraz_iOS> still, point stands
20170427 09:53:57< vultraz_iOS> JyrkiVesterinen: friend declaration to bypass any getters and access game_board directly
20170427 09:56:33< JyrkiVesterinen> Hmm... I don't know how this line can compile.
20170427 09:56:34< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/menu_events.cpp#L108
20170427 09:57:03< JyrkiVesterinen> In a const member function, all member variables (in this case, pc_) are also const.
20170427 09:57:36< JyrkiVesterinen> And the const version of play_controller::gamestate() returns a non-const reference.
20170427 09:57:44< JyrkiVesterinen> *const reference
20170427 09:58:14< vultraz_iOS> who knows :P
20170427 09:58:15< JyrkiVesterinen> And yet, that function binds it to a non-const reference without const_cast.
20170427 09:58:23< vultraz_iOS> magic!
20170427 09:58:25< JyrkiVesterinen> As far as I know, it shouldn't compile.
20170427 09:58:40< vultraz_iOS> i;m going to try adding both const and non const proxy getters
20170427 10:00:05-!- Kwandulin [~Kwandulin@p200300760F6D8001ECD6B37F16A8B19F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 10:02:40-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170427 10:03:13-!- RatArmy_ [~ratarmy@126.161.120.73] has joined #wesnoth-dev
20170427 10:05:57< vultraz_iOS> blah
20170427 10:06:01< vultraz_iOS> still the same problem ;_;
20170427 10:06:58< vultraz_iOS> yeah, this must be because the non-const is hidden in game_board
20170427 10:06:59-!- RatArmy_ [~ratarmy@126.161.120.73] has quit [Read error: Connection reset by peer]
20170427 10:16:33< vultraz_iOS> random idea
20170427 10:16:57< vultraz_iOS> i wonder if it would be worth making the proxy inherit privately from display_context
20170427 10:17:08 * vultraz_iOS ponders
20170427 10:34:30-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has joined #wesnoth-dev
20170427 10:37:57-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:38:57-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:39:16-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:40:11-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:40:31-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:42:20-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:42:39-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:43:30-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:43:52-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:45:41-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:45:56-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:47:10-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:47:31-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 10:48:10-!- sevu [~Unknown@141.57.57.138] has quit [Client Quit]
20170427 10:48:29-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 11:08:01-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 11:19:46-!- sevu [~Unknown@141.57.57.138] has quit [Remote host closed the connection]
20170427 11:23:19-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has joined #wesnoth-dev
20170427 11:32:43-!- Kwandulin [~Kwandulin@p200300760F6D8001ECD6B37F16A8B19F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170427 11:40:40-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 11:46:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 11:49:31-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has joined #wesnoth-dev
20170427 11:57:42-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Remote host closed the connection]
20170427 12:04:17-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170427 12:13:04-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 12:46:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170427 12:46:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 12:49:36-!- RatArmy_ [~ratarmy@om126161120073.8.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 12:56:08-!- RatArmy_ [~ratarmy@126.161.120.73] has joined #wesnoth-dev
20170427 13:08:44-!- sevu is now known as shiki
20170427 13:10:42-!- RatArmy_ [~ratarmy@126.161.120.73] has quit [Read error: Connection reset by peer]
20170427 13:19:50-!- shiki [~Unknown@141.57.57.138] has quit [Quit: Verlassend]
20170427 13:20:06-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 13:20:26-!- shiki [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 13:20:26-!- sevu [~Unknown@141.57.57.138] has quit [Disconnected by services]
20170427 13:20:51-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170427 13:38:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170427 13:44:20-!- sevu [~Unknown@141.57.57.138] has quit [Quit: Verlassend]
20170427 13:47:25-!- irker567 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170427 13:47:25< irker567> wesnoth: Charles Dang wesnoth:master 0dfe846090ef / src/utils/const_clone.hpp: Refactored const_clone https://github.com/wesnoth/wesnoth/commit/0dfe846090ef42bd28924073a01bec0002fa6bcc
20170427 13:52:55< vultraz_iOS> Only real thing I've got to work today :p
20170427 13:54:04< zookeeper> arr. i dislike it when i use blame to find someone to ask why they've committed a broken thing, and it's me. but at least it was still someone else's patch...
20170427 13:55:22< vultraz_iOS> :p
20170427 14:00:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 14:07:44< zookeeper> vultraz_iOS, Aginor, anyone: any faintest idea what could possibly cause the background drawing bug i mentioned earlier; the outside-the-map area getting drawn slightly lighter than the actual bitmap is? i can't see anything immediately suspicious in the code.
20170427 14:08:07< vultraz_iOS> Outside the map?
20170427 14:08:15< zookeeper> outside the map
20170427 14:08:23< zookeeper> you know. a small map. fills only part of the screen.
20170427 14:08:24< vultraz_iOS> You mean the background?
20170427 14:08:32< vultraz_iOS> The gray stuff?
20170427 14:08:35< zookeeper> yes, yes
20170427 14:08:55< vultraz_iOS> Possibly in uh...
20170427 14:09:04< vultraz_iOS> Editor controller::get image type
20170427 14:09:09< vultraz_iOS> Er
20170427 14:09:12< vultraz_iOS> Editor display
20170427 14:09:13< vultraz_iOS> Sorry
20170427 14:09:43< zookeeper> hmh, right
20170427 14:10:04< zookeeper> i'll check that
20170427 14:11:22< zookeeper> but... that's only used from the hex drawing code
20170427 14:15:13< zookeeper> the difference is very subtle anyway, not the usual kind of brightening. i'll first check that it's not related to redraw_background_ somehow...
20170427 14:15:14< vultraz_iOS> honestly i can't see any change
20170427 14:15:35< zookeeper> did you check whether there is a change?
20170427 14:15:43< vultraz_iOS> yes
20170427 14:16:19< zookeeper> really? like, actually checked? well, that is surprising
20170427 14:29:43-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: .]
20170427 14:29:46< zookeeper> oh, these compile times...
20170427 14:49:27< zookeeper> "close map" crashes in the editor (not completely latest master)
20170427 15:12:41< zookeeper> it
20170427 15:13:27< zookeeper> it's weird because when the background is lighter, it also has more variation in the red channel... according to screenshots anyway
20170427 15:14:33< zookeeper> a little bit in the blue channel too
20170427 15:15:01< zookeeper> but after F5 when it renders as intended, the RGB values match the bitmap
20170427 15:21:13< zookeeper> 35,32,31 vs (37|35),33,(32|31)
20170427 15:21:21< zookeeper> go figure.
20170427 15:22:00< zookeeper> some pixels just seemingly randomly receive a slightly different value on the red and/or blue channels.
20170427 15:23:30< zookeeper> doesn't seem to be according to any kind of recurring pattern either. mystery!
20170427 15:29:30< shiki> I can't install with scons. "sudo scons install" starts compiling again, "scons install" complains ofc about missing permissions
20170427 15:32:13-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 16:09:41-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit []
20170427 16:10:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 16:27:31-!- JyrkiVesterinen [~JyrkiVest@89-166-100-1.bb.dnainternet.fi] has joined #wesnoth-dev
20170427 16:41:49< zookeeper> 1.12 seems to be unaffected
20170427 16:42:37-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170427 16:47:44-!- irker567 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170427 16:51:02-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170427 16:57:49-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170427 17:08:05-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 17:34:11< celmin|sleep> [Apr 27@05:51:07am] vultraz_iOS: and units was const but returned a non-const ref
20170427 17:34:12< celmin|sleep> This shouldn't happen... is it actually even possible?
20170427 17:35:31< zookeeper> Aginor, my guess would be that _maybe_ the background bug is caused by some SDL2-related subtlety.
20170427 17:47:28-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 260 seconds]
20170427 17:48:48< JyrkiVesterinen> celmin|sleep: I sent some more messages about it.
20170427 17:48:58< JyrkiVesterinen> Indeed, I think it shouldn't be possible either.
20170427 17:49:30-!- celmin|sleep is now known as celticminstrel
20170427 17:50:27< celticminstrel> BTW JyrkiVesterinen, didn't you do something with widgets injecting linked groups into a window?
20170427 17:50:44< JyrkiVesterinen> Yes, I implemented that possibility.
20170427 17:51:15< celticminstrel> Does that mean it's no longer necessary (in most cases) to explicitly declare all the linked groups in a window?
20170427 17:52:41< JyrkiVesterinen> Yes, if widgets inject the necessary linked groups.
20170427 17:53:17< JyrkiVesterinen> The purpose, of course, is that a widget injects the groups that it needs so that every window that contains that widget doesn't need to.
20170427 17:58:15< celticminstrel> So injecting linked groups isn't just "automatically create any requested linked group that doesn't already exist"?
20170427 17:58:47< JyrkiVesterinen> Indeed, it's not.
20170427 17:59:13-!- Kwandulin2 [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 17:59:31< JyrkiVesterinen> See the addon list for an example. https://github.com/wesnoth/wesnoth/blob/master/data/gui/widget/addon_list.cfg#L429-L457
20170427 18:00:02< celticminstrel> Ah.
20170427 18:00:10-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170427 18:06:30-!- DeFender1031 [~DeFender1@46-116-4-88.bb.netvision.net.il] has quit [Ping timeout: 260 seconds]
20170427 18:19:25-!- Kwandulin2 [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has quit [Ping timeout: 246 seconds]
20170427 18:28:27-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 18:32:21-!- shiki [~Unknown@141.57.57.138] has quit [Remote host closed the connection]
20170427 18:36:41-!- Ivanovic_ [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170427 18:38:57-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Write error: Broken pipe]
20170427 18:38:57-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has quit [Excess Flood]
20170427 18:40:17-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20170427 18:40:35-!- Ivanovic_ is now known as Ivanovic
20170427 19:01:30-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 19:01:35-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 19:01:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 19:03:01-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Changing host]
20170427 19:03:01-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170427 19:04:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170427 19:06:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170427 19:08:12-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 19:08:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 19:09:29-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170427 19:14:11-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170427 19:15:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 19:15:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 19:21:27-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit []
20170427 19:22:39< celticminstrel> I wish these guys would figure out how to properly submit a pull request.
20170427 19:22:46< celticminstrel> One or two of the fixes actually look useful.
20170427 19:33:37-!- JyrkiVesterinen [~JyrkiVest@89-166-100-1.bb.dnainternet.fi] has quit [Quit: .]
20170427 19:34:34-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170427 19:42:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 19:43:24< vultraz_iOS> zookeeper: confirmed the crash happens
20170427 19:58:14< vultraz_iOS> zookeeper: i forgot... is opening a new map supposed to be at default size?
20170427 19:58:48< zookeeper> size? zoom?
20170427 19:59:55< vultraz_iOS> size
20170427 19:59:59< vultraz_iOS> map dimensions
20170427 20:00:12< vultraz_iOS> or is it supposed to be the same size as the current one
20170427 20:00:27< zookeeper> that doesn't make any sense to me. if you create a new map you decide the dimensions.
20170427 20:00:38< zookeeper> you know, sliders and stuff.
20170427 20:00:50< vultraz_iOS> .......
20170427 20:00:51< vultraz_iOS> right
20170427 20:00:57 * vultraz_iOS rubs eyes
20170427 20:01:02< vultraz_iOS> coffee, where art thou...
20170427 20:02:35< zookeeper> how do you end up asking that question without first having actually done that action yourself? :x
20170427 20:02:47< vultraz_iOS> but I did do so
20170427 20:02:48< vultraz_iOS> :|
20170427 20:02:57< zookeeper> and you didn't see the dialog that pops up? :p
20170427 20:03:13< vultraz_iOS> i dunno
20170427 20:04:03< zookeeper> peculiar
20170427 20:08:36-!- irker327 [~irker@109.237.213.40] has joined #wesnoth-dev
20170427 20:08:36< irker327> wesnoth: Charles Dang wesnoth:master cddc2d2f6919 / src/editor/map/context_manager.cpp: Editor: fix crash when closing map (fixup bf79dbd8) https://github.com/wesnoth/wesnoth/commit/cddc2d2f69194f6802635e66c016c1a0bafdfefc
20170427 20:08:37< irker327> wesnoth: Charles Dang wesnoth:master 509937305bf1 / src/editor/map/context_manager.cpp: Removed unused member from map_context_refresher https://github.com/wesnoth/wesnoth/commit/509937305bf1796ba37ad06e51140c08331be24e
20170427 20:08:42< vultraz_iOS> zookeeper: ^
20170427 20:08:55< zookeeper> very good
20170427 20:30:18< zookeeper> still crashes?
20170427 20:30:48< zookeeper> for me it does, anyway
20170427 20:30:51< vultraz_iOS> what
20170427 20:31:44< vultraz_iOS> no?
20170427 20:33:26< vultraz_iOS> are you sure you built
20170427 20:40:01< irker327> wesnoth: Nils Kneuper wesnoth:master df2e16c05320 / / (7 files in 6 dirs): updated Slovak translation https://github.com/wesnoth/wesnoth/commit/df2e16c05320b4244fec9a33cbdcff8a15c57726
20170427 20:40:03< irker327> wesnoth: Nils Kneuper wesnoth:master f9b4b5681fd6 / changelog players_changelog: fixed changelog formatting to 80chars for the current version https://github.com/wesnoth/wesnoth/commit/f9b4b5681fd6c84daa23f11391f2fff9c7048e12
20170427 20:41:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170427 20:41:24< celticminstrel> 80 columns is so short, huh... but I suppose there are also good reasons not to increase it...
20170427 20:41:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 20:41:58< celticminstrel> Also, when will the French translation be updated...
20170427 20:42:05< Ivanovic> celticminstrel: it is a classic, old school terminal style
20170427 20:42:09< Ivanovic> celticminstrel: no idea, ask the maintainer
20170427 20:42:16< Ivanovic> at least i did not receive files that need uploading
20170427 20:42:35< celticminstrel> Yeah, I figured.
20170427 20:42:46< Ivanovic> and yeah, there is some reason behind this: somewhere in this area is the best length for "relaxed reading and understanding"
20170427 20:43:26< celticminstrel> I was thinking of more technical reasons, like how it's the default width of a terminal window.
20170427 20:43:39< zookeeper> vultraz_iOS, yes
20170427 20:43:40< Ivanovic> that was in the past, the 80x20 terminal thingie
20170427 20:43:47< celticminstrel> I see.
20170427 20:47:41< vultraz_iOS> Recommend 120
20170427 20:47:55< vultraz_iOS> 80 is antiquated
20170427 20:48:19-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 20:48:36< celticminstrel> Well, I too think 80 is a bit narrow, but I don't really care that much; it's trivial to re-wrap it, after all.
20170427 20:48:55< celticminstrel> Or, almost trivial?
20170427 20:49:22< celticminstrel> Oh right, now that it's been rewrapped, I guess I need to resolve conflicts in wml_tag_porting, huh.
20170427 20:51:00< vultraz_iOS> Does Ivanovic use a terminal to read the changelog?
20170427 20:51:39< celticminstrel> There are other advantages to keeping the changelog narrow.
20170427 20:51:55< celticminstrel> Like the fact that you can have it in a smaller window, for example.
20170427 20:52:12< celticminstrel> And diffs look better if the lines are not super-long.
20170427 20:52:41< vultraz_iOS> True
20170427 20:52:53< vultraz_iOS> Speaking of the changelog
20170427 20:53:11< vultraz_iOS> Where did this practice of having an extension-less file
20170427 20:53:13< vultraz_iOS> Come from
20170427 20:53:58< zookeeper> from the time before someone came up with extensions, probably? :p
20170427 20:53:58< celticminstrel> I think file extensions are a Windows/DOS invention.
20170427 20:54:15< celticminstrel> Macs originally didn't have them.
20170427 20:54:29< celticminstrel> IIUC, Unix also didn't originally have them.
20170427 20:54:53< vultraz_iOS> But why do we still use such a thing
20170427 20:55:34< celticminstrel> No particular reason, I guess. I don't think there's any reason to change it either.
20170427 20:56:02< vultraz_iOS> I mean, would anyone object to making some of the files markdown
20170427 20:56:32< celticminstrel> I'm not really in favour of making the changelog markdown.
20170427 20:57:09< zookeeper> what's a markdown?
20170427 20:57:28< vultraz_iOS> What about INSTALL
20170427 21:00:57< celticminstrel> I suppose INSTALL could be markdown...
20170427 21:01:35< zookeeper> oh, a markup language
20170427 21:01:50< zookeeper> created by hans mcclane
20170427 21:04:17< celticminstrel> It's the markup used on github.
20170427 21:06:40< celticminstrel> Huh, lucky. I had no changelog conflicts during rebase.
20170427 21:07:16< celticminstrel> The only actual conflict was with vultraz_iOS changing everything to use get_team, because I removed one of the touched chunks of code.
20170427 21:11:33-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 21:13:11-!- travis-ci [~travis-ci@54.145.87.102] has joined #wesnoth-dev
20170427 21:13:12< travis-ci> wesnoth/wesnoth#13546 (master - 5099373 : Charles Dang): The build is still failing.
20170427 21:13:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/226550461
20170427 21:13:12-!- travis-ci [~travis-ci@54.145.87.102] has left #wesnoth-dev []
20170427 21:13:21< celticminstrel> Uh-oh! :O
20170427 21:13:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 21:15:40< vultraz_iOS> unknown location(0): fatal error in "test_gui2": memory access violation at address: 0x00000000: no mapping at fault address
20170427 21:16:03< vultraz_iOS> ah, mp change control
20170427 21:16:26< vultraz_iOS> 0x00000000007b9ff6 in gui2::dialogs::mp_change_control::pre_show(gui2::window&) ()
20170427 21:17:54< vultraz_iOS> been broken for 3 days i see
20170427 21:18:20< vultraz_iOS> const std::set<std::string>& observers = resources::screen->observers();
20170427 21:18:21< vultraz_iOS> hmm
20170427 21:18:24< vultraz_iOS> perhaps this line?
20170427 21:19:07< vultraz_iOS> celticminstrel: i can't really do anything since im still working on the accursed proxy, can you take a look?
20170427 21:20:30< celticminstrel> I'm on wml_tag_porting ATM, but perhaps a little later.
20170427 21:24:21-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 21:24:35< matthiaskrgr> vultraz_iOS: is that the testrunner crash ? 
20170427 21:24:45< vultraz_iOS> there's a crash in the tests yes
20170427 21:24:48< matthiaskrgr> ah
20170427 21:24:49< matthiaskrgr> ok
20170427 21:24:57< matthiaskrgr> I made a ticket about this a couple of hours ago :P
20170427 21:25:11< matthiaskrgr> https://gna.org/bugs/index.php?25676 
20170427 21:25:48< matthiaskrgr> also 25677 can be closed, it was fixed
20170427 21:25:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 21:32:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170427 21:33:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 21:33:22< celticminstrel> Thought so... the API falsely claimed knolls.ogg was playing for some reason...
20170427 21:33:30< celticminstrel> When in fact it was... I think wanderer or something?
20170427 21:34:00< celticminstrel> Might not be a bug with the Lua interface though...
20170427 21:34:01< vultraz_iOS> perhaps we should disable the test for this dialog
20170427 21:34:11< vultraz_iOS> since it doesn't do anything without resources::gameboard
20170427 21:34:19-!- gfgtdf [~chatzilla@x4e36a0c7.dyn.telefonica.de] has joined #wesnoth-dev
20170427 21:34:24< celticminstrel> ...the test uses resources::gameboard?
20170427 21:34:38< vultraz_iOS> the dialog does
20170427 21:34:47< vultraz_iOS> and screen
20170427 21:35:23< gfgtdf> matthiaskrgr: by 'the other one' i actuallm meant upadoign an adon that uses a custom .ign  file
20170427 21:35:56< gfgtdf> addon*
20170427 21:36:23< matthiaskrgr> upadoign ? 
20170427 21:36:41< matthiaskrgr> updating?
20170427 21:37:18< gfgtdf> uploading*
20170427 21:37:30< matthiaskrgr> o_O
20170427 21:37:38< gfgtdf> matthiaskrgr: what's so rtrange abotu that ?
20170427 21:37:41< gfgtdf> strange*
20170427 21:37:59< matthiaskrgr> does it upload to the addon server?
20170427 21:38:26< gfgtdf> yes that's what i asekd you to do, i think there is a memeleak there but i'm not sure
20170427 21:38:36< gfgtdf> when readon the .ign fiel i mean
20170427 21:38:48< celticminstrel> Ah, choose_track actually does something weird here...
20170427 21:38:49< gfgtdf> ofcourse you dont have a write a real addons for that
20170427 21:39:06< gfgtdf> you can jsut use a dummy addon and remove it form the server after testing
20170427 21:39:29< matthiaskrgr> I have never seen any kind of upload button
20170427 21:39:30< gfgtdf> actuall i didnt test wheterh removign an addon form the server works with the new addon manager hmm
20170427 21:39:39< gfgtdf> matthiaskrgr: you have ato creat a dummy addon first
20170427 21:39:59< gfgtdf> matthiaskrgr: make a new folder  in your userdata/add-ons folder where teh other addosn are
20170427 21:40:05< celticminstrel> matthiaskrgr: I think you only see the upload button for addons that contain a _server.pbl file.
20170427 21:40:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170427 21:40:14< gfgtdf> matthiaskrgr: and aass a _server.pbl file in it
20170427 21:40:20< gfgtdf> add*
20170427 21:41:15< gfgtdf> matthiaskrgr: you coudol for examepl use the example pbl file from https://wiki.wesnoth.org/PBLWML
20170427 21:41:55< matthiaskrgr> https://pastebin.com/y6SPGEW4 <- backtrace for current testrunner crash
20170427 21:43:42< gfgtdf> seem sliek vultraz roke it in https://github.com/wesnoth/wesnoth/commit/5effd5338a49402f650bbc675cad3489a8173d90
20170427 21:44:00< gfgtdf> previously it had a explicit check for resources::gameboard == nullptr
20170427 21:44:14< vultraz_iOS> where?
20170427 21:45:06< gfgtdf> hmm mayb ei was confusted by the red and blue will check agan
20170427 21:45:18< vultraz_iOS> gfgtdf: would it just be acceptable to exit the dialog if gameboard and screen are null
20170427 21:45:30< celticminstrel> Uh. What?
20170427 21:45:34< vultraz_iOS> or perhaps exclude the test
20170427 21:45:47< celticminstrel> Excluding the test is not a good option.
20170427 21:45:51< gfgtdf> vultraz_iOS: well the test isn't that inportant but still nice to have
20170427 21:46:06< vultraz_iOS> well the dialog has nothing without a gameboard
20170427 21:46:11< celticminstrel> Exiting the dialog may result in an incomplete test.
20170427 21:46:46< gfgtdf> vultraz_iOS:  it porbably this loop :https://github.com/wesnoth/wesnoth/blob/5effd5338a49402f650bbc675cad3489a8173d90/src/gui/dialogs/multiplayer/mp_change_control.cpp#L135
20170427 21:46:57< vultraz_iOS> yes
20170427 21:47:04< vultraz_iOS> but there are other unguarded cases
20170427 21:47:05< vultraz_iOS> and
20170427 21:47:07< gfgtdf> vultraz_iOS: you see the lopop before https://github.com/wesnoth/wesnoth/blob/5effd5338a49402f650bbc675cad3489a8173d90/src/gui/dialogs/multiplayer/mp_change_control.cpp#L110 is ok becasue it uses num_sides 
20170427 21:47:07< vultraz_iOS> as i said
20170427 21:47:13< vultraz_iOS> without it the dialog has nothing
20170427 21:47:26< gfgtdf> vultraz_iOS: whre are other unguaded cases ?
20170427 21:47:27-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 21:47:27< matthiaskrgr> >at the same level as the _main.cfg file.  
20170427 21:47:34< matthiaskrgr> gfgtdf: I don't have a _main.cfg
20170427 21:47:46< vultraz_iOS> line 185
20170427 21:47:50< gfgtdf> matthiaskrgr: it complains about not havign a _main.cfg ?
20170427 21:47:58< matthiaskrgr> no
20170427 21:48:05< matthiaskrgr> I do :P
20170427 21:48:13< matthiaskrgr> >To upload an add-on you have made, you need a _server.pbl file in your add-on's directory, at the same level as the _main.cfg file.  
20170427 21:48:39< matthiaskrgr> from the wiki page
20170427 21:49:25< gfgtdf> vultraz_iOS: hmm just adda  if(!resources::gameboard) {return;} at highlight_side_nick for that one i'D say
20170427 21:49:37< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 339587ee2b64 / / (4 files in 3 dirs): Properly port [kill] to Lua https://github.com/wesnoth/wesnoth/commit/339587ee2b644ad700851379835700de480e18b6
20170427 21:49:39< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 0a591cd4242e / / (4 files in 3 dirs): Properly port [scroll] to Lua https://github.com/wesnoth/wesnoth/commit/0a591cd4242e148f68bf6e734ad834b84e0f3ad9
20170427 21:49:41< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 6906ced4e732 / / (15 files in 6 dirs): Properly port [music] to Lua https://github.com/wesnoth/wesnoth/commit/6906ced4e7321758c219cca50faaa2fd6bc38b13
20170427 21:49:43< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 5b4dbe1c6108 / / (7 files in 5 dirs): Port [volume] to Lua https://github.com/wesnoth/wesnoth/commit/5b4dbe1c61086af398eb1e20f66a082c7b702614
20170427 21:49:45< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting eb0947c863b0 / / (6 files in 5 dirs): Some improvements to the new Lua music API https://github.com/wesnoth/wesnoth/commit/eb0947c863b08a33667f204f0885b4818101988f
20170427 21:49:47< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c04456dec151 / src/ (scripting/lua_audio.cpp sound.cpp sound_music_track.hpp): Store music tracks as shared_ptrs https://github.com/wesnoth/wesnoth/commit/c04456dec151d907de58493b9abb0494c8fc91be
20170427 21:49:47< gfgtdf> matthiaskrgr: ye just add it directly in your new folder.
20170427 21:49:49< irker327> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting c892b6025735 / changelog src/scripting/lua_audio.cpp src/sound.cpp src/sound.hpp: A few more improvements to the music API https://github.com/wesnoth/wesnoth/commit/c892b602573564c397d6618f3c2f69b509e47d77
20170427 21:50:09< gfgtdf> matthiaskrgr: you could also add _main.cfg ot suew whewthe rits needed
20170427 21:50:12< gfgtdf> sure*
20170427 21:50:14< matthiaskrgr> so I am in ~/.local/share/wesnoth/1.13/data/add-ons  
20170427 21:50:18< matthiaskrgr> mkdir test
20170427 21:50:22< matthiaskrgr> cd test
20170427 21:50:49< matthiaskrgr> then I dump this  https://wiki.wesnoth.org/PBLWML#Example_.pbl_File  example text into "_server.pbl" 
20170427 21:50:56< gfgtdf> matthiaskrgr: yes
20170427 21:51:23< gfgtdf> add-ons/test/_server.pbl
20170427 21:51:43< matthiaskrgr> yeah 
20170427 21:51:59< celticminstrel> The test was for when there's a _server.ign file, right?
20170427 21:52:11< matthiaskrgr> where is this upload button located, maybe I'm just stupid :|
20170427 21:52:14< celticminstrel> There's an example ign file somewhere oto.
20170427 21:52:16< celticminstrel> ^too
20170427 21:52:25< celticminstrel> matthiaskrgr: What's your resolution?
20170427 21:52:36< celticminstrel> Window resolution, not monitor (unless those are the same).
20170427 21:52:38< matthiaskrgr> 1286x861  
20170427 21:52:48< gfgtdf> matthiaskrgr: ye to test the particaul isuse you aslo need to add the add-ons/test/_server.ign file
20170427 21:52:55< celticminstrel> Okay, so there should be a pair of buttons next to each addon in the addons list.
20170427 21:53:46< celticminstrel> It'll be easier to find it if you change the title in the example pbl file to something that would collate it at the top.
20170427 21:55:22< gfgtdf> matthiaskrgr: you probabyl bneed to add-ons/test/_main.cfg too
20170427 21:55:26< gfgtdf> matthiaskrgr: it can be empty
20170427 21:56:14< gfgtdf> matthiaskrgr: then 'My campaign - redy to publich' will likely appear near the bottom of the list
20170427 21:56:28< matthiaskrgr> ahaaa!
20170427 21:56:31< matthiaskrgr> ok I got it now
20170427 21:56:47< celticminstrel> gfgtdf: I didn't think publishable addons are pushed to the bottom anymore?
20170427 21:57:00< matthiaskrgr> so now I hit publish?
20170427 21:57:21< celticminstrel> Did you add the ign file yet?
20170427 21:57:29< matthiaskrgr> yes
20170427 21:57:46< matthiaskrgr> it just contians a few file extension patterns
20170427 21:57:59< matthiaskrgr> or something like that 
20170427 21:58:26< gfgtdf> celticminstrel: i just tested exactly what ui suggested matthiaskrgr do to and i foudn the campaign at th ebottom
20170427 21:58:37< gfgtdf> matthiaskrgr: yes please click publish
20170427 21:58:50< celticminstrel> Eh, really?
20170427 21:59:03< matthiaskrgr> invalid icon path ._.
20170427 21:59:03< celticminstrel> I think it's weird though that they get pushed to the bottom.
20170427 21:59:52< gfgtdf> matthiaskrgr: try in the pbl file replace icon=..  with icon="units/unknown-unit.png"
20170427 22:00:54< matthiaskrgr> yeah there's a leak 
20170427 22:01:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170427 22:01:24< matthiaskrgr> https://pastebin.com/raw/ADpp9H7e  
20170427 22:02:07< matthiaskrgr> theres no leak when removing addon from server though
20170427 22:02:39< gfgtdf> matthiaskrgr: ok thx
20170427 22:02:51< irker327> wesnoth: gfgtdf wesnoth:master b8a76bed9d4e / src/addon/manager.cpp: fix memleak when uploading addons. https://github.com/wesnoth/wesnoth/commit/b8a76bed9d4ed3fc12d2163ed1e1da03583b5c67
20170427 22:03:04< celticminstrel> Fast!
20170427 22:03:17< celticminstrel> Ah, I see why that was a leak though.
20170427 22:03:38< matthiaskrgr> there were also leaks in the testrunner 
20170427 22:03:49< matthiaskrgr> before it started crashing :P
20170427 22:03:54< gfgtdf> matthiaskrgr: you you please aso test a leak in the mpserver ?
20170427 22:04:40< matthiaskrgr> mmh what was that?
20170427 22:04:45< gfgtdf> matthiaskrgr: please connect to server.wesnoth.org:14997 mp server (offical 1.13.7 release server)
20170427 22:04:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 22:04:54< gfgtdf> matthiaskrgr: and thne wait a little
20170427 22:05:18< gfgtdf> matthiaskrgr: in the mp lobby i meant
20170427 22:06:08< gfgtdf> matthiaskrgr: please tem le when you are connected to the server
20170427 22:06:33-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:06:52< matthiaskrgr> gfgtdf: I'm there now
20170427 22:06:53-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 22:07:07-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:07:39< matthiaskrgr> 20170428 00:07:01 warning engine: User gfg has unknown game_id: 401
20170427 22:07:41-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 22:07:50< gfgtdf> were there leaks yet ?
20170427 22:08:18< matthiaskrgr> yes
20170427 22:08:44< matthiaskrgr> one
20170427 22:08:45< gfgtdf> matthiaskrgr: could you give leak stacktrace ?
20170427 22:08:52< matthiaskrgr> https://pastebin.com/raw/2k8x21TC  
20170427 22:08:57-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:11:08-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 22:11:40-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:13:03< gfgtdf> matthiaskrgr: thx again
20170427 22:13:03-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 22:13:04< irker327> wesnoth: gfgtdf wesnoth:master eeb0165cd669 / src/game_initialization/lobby_info.cpp: fix memleak in mp lobby. https://github.com/wesnoth/wesnoth/commit/eeb0165cd669ddcb1ac1b233d75d081a003208fb
20170427 22:14:53< irker327> wesnoth: Celtic Minstrel wesnoth:master 1c3d48a06972 / .gitignore: Add some MSVC build folders to gitignore https://github.com/wesnoth/wesnoth/commit/1c3d48a069723bb690dd58673fd93b13cfbb4c84
20170427 22:14:58-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.]
20170427 22:15:56-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20170427 22:16:01< celticminstrel> So you can run the unit tests from MSVC by going into the configuration manager and setting the configuration for the wesnoth project to Test_Debug or Test_Release.
20170427 22:16:12< celticminstrel> However, the tests won't compile on MSVC 2013.
20170427 22:16:23< matthiaskrgr> gn 
20170427 22:17:09< gfgtdf> gn
20170427 22:18:18< irker327> wesnoth: Celtic Minstrel wesnoth:master 77cce6edbe71 / projectfiles/VC12/wesnoth.vcxproj: MSVC: Exclude wesnoth.cpp from unit tests configuration https://github.com/wesnoth/wesnoth/commit/77cce6edbe713b107aec1755f50fe894ebaa8122
20170427 22:18:28< celticminstrel> Maybe gfgtdf could try it and see if the tests will build?
20170427 22:18:43-!- gfgtdf_ [~chatzilla@x4e36a0c7.dyn.telefonica.de] has joined #wesnoth-dev
20170427 22:21:08-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:21:32-!- gfgtdf [~chatzilla@x4e36a0c7.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170427 22:21:37-!- gfgtdf_ is now known as gfgtdf
20170427 22:25:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170427 22:25:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170427 22:25:59< celticminstrel> Hmmm. vultraz_iOS, I think perhaps that dialog is easier to just disable in the tests. I don't know of a way to make a dummy menu_handler.
20170427 22:30:06< celticminstrel> Hmm, a dummy menu_handler would require a dummy play_controller too...
20170427 22:38:08-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 22:38:16< irker327> wesnoth: Celtic Minstrel wesnoth:master f5918996df64 / src/gui/dialogs/addon/ (manager.cpp manager.hpp): Addon Manager: Make type lists static since they never change https://github.com/wesnoth/wesnoth/commit/f5918996df6485a4a28adcebc96bbab5ed28ca6b
20170427 22:50:43-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 22:54:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170427 22:54:48-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170427 22:54:56-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 22:57:43-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170427 23:10:38-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170427 23:17:24-!- Appleman1234 [~Appleman1@pl51532.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170427 23:18:56-!- Appleman1234 [~Appleman1@pl5101.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170427 23:22:33-!- atarocch [~atarocch@107.19.190.6] has joined #wesnoth-dev
20170427 23:44:47-!- atarocch [~atarocch@107.19.190.6] has quit [Ping timeout: 258 seconds]
20170427 23:45:18-!- atarocch [~atarocch@107.19.190.6] has joined #wesnoth-dev
20170427 23:47:03-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170427 23:53:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170427 23:56:33-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170427 23:57:48-!- atarocch [~atarocch@107.19.190.6] has quit [Ping timeout: 240 seconds]
20170427 23:58:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
--- Log closed Fri Apr 28 00:00:26 2017