--- Log opened Fri Apr 28 00:00:26 2017
20170428 00:00:45< irker327> wesnoth: Charles Dang wesnoth:master 2ddb305844b1 / src/tests/gui/test_gui2.cpp: Disabled MP Change Control test https://github.com/wesnoth/wesnoth/commit/2ddb305844b1c0bebcf66028464dc879f0b72338
20170428 00:06:12< celticminstrel> vultraz_iOS: In fact, gameboard should be always valid in mp_change_control.
20170428 00:06:19< celticminstrel> Because the menu_handler links back to it.
20170428 00:06:41< celticminstrel> IOW, with a few changes, you could get the game_board from the menu_handler rather than from resources.
20170428 00:06:41< vultraz_iOS> guess i can remove the checks then
20170428 00:07:07< celticminstrel> ("few changes" basically means making stuff public or similar)
20170428 00:07:44< vultraz_iOS> not while im in the middle of the accursed proxy class
20170428 00:07:56< vultraz_iOS> though im considering dropping it because it's rage-inducing
20170428 00:08:47< celticminstrel> I started doing it but then stopped because I realized it conflicts with your proxy thing.
20170428 00:09:26< vultraz_iOS> there's too much crap and i can't figure out how to deal with it all
20170428 00:09:33< vultraz_iOS> I can't make the proxy inherit from d_c
20170428 00:09:45< vultraz_iOS> i can't make the proxy always have const and non-const functions
20170428 00:09:47< celticminstrel> Sounds similar to my unit_frame stuff.
20170428 00:09:49< vultraz_iOS> *something* needs to change
20170428 00:09:55< vultraz_iOS> but what
20170428 00:10:31-!- atarocch [~atarocch@31.159.11.87] has joined #wesnoth-dev
20170428 00:12:48-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 00:23:52-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 00:43:04-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 00:53:51< vultraz_iOS> tests segfaulted :/
20170428 00:53:59< celticminstrel> Fun.
20170428 00:54:07< celticminstrel> What's the culprit this time?
20170428 00:54:25< vultraz_iOS> dunno
20170428 00:54:37< vultraz_iOS> and it was only 2 builds
20170428 00:55:42< celticminstrel> I guess the tests could be build in MSVC 2013 if I added constructors to the dialog_testers that produced errors...
20170428 00:55:49< celticminstrel> ^built
20170428 00:56:13< celticminstrel> My version of cl doesn't support initializer-lists inside a class.
20170428 00:56:57< celticminstrel> BTw vultraz_iOS, you should really get a way of building the tests yourself.
20170428 00:57:24< celticminstrel> Hmmm, was there anything small I was supposed to be doing...
20170428 00:59:26-!- gfgtdf [~chatzilla@x4e36a0c7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170428 01:20:38-!- Greg_Boggs[m] [gregboggsm@gateway/shell/matrix.org/x-zibhwanupqcasdhx] has joined #wesnoth-dev
20170428 01:21:57< vultraz_iOS> i should probably switch to msvc
20170428 01:22:24< celticminstrel> Well, if you do, you should be able to build the tests.
20170428 01:24:02< vultraz_iOS> thing is every time I've tried to build wesnoth there
20170428 01:24:03-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 01:24:06< vultraz_iOS> it's taken 4 times longer than gcc
20170428 01:24:36< celticminstrel> It does take awhile to build in MSVC.
20170428 01:24:42< celticminstrel> Like a few minutes I think.
20170428 01:25:01< vultraz_iOS> shouldn't take much longer though
20170428 01:25:02< celticminstrel> I usually go off and do something else and it's done by the time I get back, so I don't know exactly how long it takes.
20170428 01:26:54< celticminstrel> ISTR that parallel build was disabled in the MSVC project.
20170428 01:27:30< celticminstrel> I might be getting it confused with something else though, because I can't find that option in the settings.
20170428 01:28:22< celticminstrel> Minimal build is disabled. I don't think that's the option I was thinking of though.
20170428 01:28:47< vultraz_iOS> why would parallel be disabled
20170428 01:28:56< celticminstrel> I don't remember.
20170428 01:30:03< vultraz_iOS> if there's no good reason it should be renabled
20170428 01:30:34< celticminstrel> Ask Jyrki about it. Whatever it is I'm thinking of (whether it was parallel build or minimal build or whatever), I think it was him who did it.
20170428 01:30:50< celticminstrel> Or I suppose it might've been tad.
20170428 01:31:03< celticminstrel> Oh right, I suppose I could check the commit history and find it.
20170428 01:32:19< vultraz_iOS> random weird thing: my wesnoth executable output size seemed to decrease by ~300 KB or so after i removed the unnecessary copy assignment ops o-O
20170428 01:32:45< celticminstrel> That is kinda weird, since you're using an optimizied build right?
20170428 01:33:03< celticminstrel> If you were using an unoptimized build it'd kinda make sense that the size is a bit reduced.
20170428 01:33:11< vultraz_iOS> perhaps it was something else
20170428 01:33:44< vultraz_iOS> i just remember a week or so ago seeing 26.30 or something MB and now it's down to 25.97
20170428 01:34:17< celticminstrel> Ah.
20170428 01:34:45< vultraz_iOS> tad would approve :P
20170428 01:35:11< celticminstrel> I would say it's pointless attempting to reduce the size of the executable (though if you manage to do it by accident, it's not bad).
20170428 01:35:21< celticminstrel> Because the executable is a tiny portion of the download size.
20170428 01:36:30< celticminstrel> Hmm. Here's a commit that seems to do the exact opposite...
20170428 01:36:41< celticminstrel> Oh right.
20170428 01:36:50< celticminstrel> It disables minimal build and enables multiprocessor build.
20170428 01:36:52< vultraz_iOS> no objections to my const_clone changes earlier?
20170428 01:36:54< celticminstrel> Okay.
20170428 01:37:20< celticminstrel> So that's what I was remembering.
20170428 01:37:41< celticminstrel> Minimal build was turned off in favour of multiprocessor build, which I'd think would improve the build times.
20170428 01:37:47< celticminstrel> When did you last try it on MSVC?
20170428 01:37:57< celticminstrel> (That said, for me at least, build times are still rather long.)
20170428 01:38:02< vultraz_iOS> long time ago
20170428 01:38:07< celticminstrel> https://github.com/wesnoth/wesnoth/commit/f56cb7f9bb0f9609b874c34211b7ef61dcb83d95
20170428 01:38:29< vultraz_iOS> back when MSVc 2015 was still the latest
20170428 01:38:40< celticminstrel> Later than July?
20170428 01:38:48< vultraz_iOS> no
20170428 01:38:57< vultraz_iOS> or maybe?
20170428 01:39:00< vultraz_iOS> probably not
20170428 01:39:00< vultraz_iOS> no
20170428 01:39:09< celticminstrel> Well, could be worth trying again then?
20170428 01:39:35< vultraz_iOS> perhaps
20170428 01:39:39< vultraz_iOS> need build libs tho
20170428 01:39:59< celticminstrel> You could just clone aquileia/external
20170428 01:40:06< celticminstrel> Unless you want to try on MSVC 2017.
20170428 01:40:12< vultraz_iOS> of course
20170428 01:40:19< vultraz_iOS> that's what i have installed
20170428 01:40:29< vultraz_iOS> why would I use anything older :P
20170428 01:40:31< celticminstrel> Don't you have 2015 installed too?
20170428 01:40:34< vultraz_iOS> no
20170428 01:40:39< celticminstrel> You did before, right?
20170428 01:40:41< vultraz_iOS> that was my old laptop
20170428 01:40:44< celticminstrel> Oh.
20170428 01:40:46< celticminstrel> I see.
20170428 01:40:51 * celticminstrel shrug.
20170428 01:40:57< vultraz_iOS> you forget I got a new GLORIOUS 4K LAPTOP
20170428 01:41:05< celticminstrel> Yeah yeah, who cares.
20170428 01:41:14< celticminstrel> Why would you need 4k, that's silly.
20170428 01:41:29< vultraz_iOS> it's so much better than 1080p
20170428 01:41:32< vultraz_iOS> 1080p is grainy
20170428 01:41:52< celticminstrel> Who cares?
20170428 01:42:01< vultraz_iOS> I
20170428 01:42:01-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 01:43:52< vultraz_iOS> celticminstrel: any objections to https://github.com/Vultraz/wesnoth/commit/647f3e12bef7a31b5a706fb6f7ccbbadc94a25cb
20170428 01:43:54< celticminstrel> I'm also doubtful of your assertion, mind you.
20170428 01:44:15< celticminstrel> No idea, Firefox suddenly decided to hang.
20170428 01:44:33< celticminstrel> Oh it's back already.
20170428 01:45:32< celticminstrel> bool_string should probably be constexpr, but we can't use really constexpr... ah, actually, it probably can't be constexpr anyway with that implementation...
20170428 01:45:51< celticminstrel> Well, I have no objections, anyway.
20170428 01:46:04< celticminstrel> ^really use
20170428 01:46:44< celticminstrel> Ah, so the current failure in wml_tag_porting is the same as the current failure in master. That's good then, it means wml_tag_porting could probably be merged.
20170428 01:48:08< irker327> wesnoth: Charles Dang wesnoth:master 647f3e12bef7 / src/ (7 files in 5 dirs): Added small wrapper function for converting a bool to string https://github.com/wesnoth/wesnoth/commit/647f3e12bef7a31b5a706fb6f7ccbbadc94a25cb
20170428 01:49:59< vultraz_iOS> i wonder why the value of a metafunc like is_const can't be converted to a bool variable
20170428 01:50:07< vultraz_iOS> there is operator() but that's c++14...
20170428 01:50:13< celticminstrel> Uhh.
20170428 01:50:19< celticminstrel> Isn't that what ::value is?
20170428 01:50:19< vultraz_iOS> and there's also operator bool but I have no idea how that works
20170428 01:50:27< vultraz_iOS> celticminstrel: you can't assign it to a bool
20170428 01:50:32< celticminstrel> ???
20170428 01:50:53< celticminstrel> What are you talking about?
20170428 01:51:11< vultraz_iOS> you can't say template<typename T>class foo { const bool value = std::is_const<T>::value; };
20170428 01:51:39< celticminstrel> Why not?
20170428 01:51:49< vultraz_iOS> complains it's not static
20170428 01:52:03< celticminstrel> Then make it static? You probably want it to be static anyway, right?
20170428 01:52:44< vultraz_iOS> you do?
20170428 01:52:56< celticminstrel> If you're writing a metafunction, yeah.
20170428 01:53:09< celticminstrel> I think metafunctions generally have everything static.
20170428 01:53:11< vultraz_iOS> wait, how are static variables handled in class templates...
20170428 01:53:22< celticminstrel> Same as in normal classes?
20170428 01:53:58< vultraz_iOS> hm
20170428 01:54:03< vultraz_iOS> yes, actually i see what you mean
20170428 01:55:10< celticminstrel> Just FTR, if you have "template<typename A> class C;", then C<int> and C<float> are two different classes.
20170428 01:56:58< vultraz_iOS> eh, still doesn't like assigning with ::value
20170428 01:57:34< vultraz_iOS> () works though... surprised my compiler isn't warning it's c++14
20170428 01:58:24-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 01:58:51< vultraz_iOS> oh wait
20170428 01:58:54< celticminstrel> Okay, PR 999 has a merge commit, which is annoying, but it's certainly far cleaner than anything else that group has done so far, so yay.
20170428 01:58:55< vultraz_iOS> i forgot to remove the typename
20170428 01:59:09< celticminstrel> I guess you'd probably end up squashing it, but well...
20170428 02:00:06< celticminstrel> What typename?
20170428 02:00:32< celticminstrel> Obviously if you write "typename std::is_const<T>::value" that's not going to work, because it'll look for a type named value in is_const, which doesn't exist.
20170428 02:00:38< vultraz_iOS> yes
20170428 02:00:50< celticminstrel> And then since it thinks it's a type, you need to construct it with ()
20170428 02:01:20< vultraz_iOS> which is c++14
20170428 02:01:24< celticminstrel> No.
20170428 02:01:49< vultraz_iOS> oh?
20170428 02:01:57< celticminstrel> "typename std::is_const<T>::value()" means "call the default constructor of the type called value nexted in std::is_const<T>".
20170428 02:02:02< celticminstrel> ^nested
20170428 02:02:22< celticminstrel> Of course, that type does not exist, so it'll be a compiler error.
20170428 02:02:29< celticminstrel> But it's not referencing anything C++14.
20170428 02:02:37< celticminstrel> It's not a reference to std::is_const<Y>::operator()
20170428 02:03:00< celticminstrel> A reference to that would look more like "std::is_const<T>()()"
20170428 02:03:22< celticminstrel> "construct an instance of std::is_const<T>, then call operator() on that instance"
20170428 02:03:24< vultraz_iOS> I see
20170428 02:03:46< celticminstrel> TBH I wonder why the operator() even exists. In what circumstance would you have an instance of is_const?
20170428 02:04:02< vultraz_iOS> so i just need bool foo = is_const::value
20170428 02:04:10< celticminstrel> Plus <T> yes
20170428 02:04:51< celticminstrel> Do you know if there was something I was supposed to be doing BTW?
20170428 02:06:01< vultraz_iOS> nope
20170428 02:08:31< vultraz_iOS> celticminstrel: do you think const_clone::is_source_const should be public?
20170428 02:09:19< celticminstrel> Ah well, I guess I won't do anything then. >_>
20170428 02:09:26< celticminstrel> Until I think of something. Or you think of something.
20170428 02:10:07< celticminstrel> I don't really see any reason for is_source_const to be public.
20170428 02:10:21< celticminstrel> But if you did want to publicize it, I'd make it a value rather than a type.
20170428 02:15:29< celticminstrel> Do you have any specific reason why you want to?
20170428 02:15:32-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 02:15:36< celticminstrel> Or was it just a random thought?
20170428 02:15:39< vultraz_iOS> random thought
20170428 02:15:46< vultraz_iOS> might as well do it while im editing the file
20170428 02:15:52< vultraz_iOS> could be useful for something
20170428 02:15:55< celticminstrel> What? You're editing the file again? o.o
20170428 02:16:48< celticminstrel> I'm not sure if it's a good idea to publicize it just as a random thought.
20170428 02:17:01< celticminstrel> Though I guess it won't hurt anything.
20170428 02:21:55-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 02:26:40< irker327> wesnoth: Charles Dang wesnoth:master 3713930249db / src/utils/const_clone.hpp: Simplify 0dfe846 a little further https://github.com/wesnoth/wesnoth/commit/3713930249dbd2f74cd6b8231a2e4ac0b2a36ecf
20170428 02:26:43< irker327> wesnoth: Charles Dang wesnoth:master e8776e3c7975 / src/utils/const_clone.hpp: Made const_clone::is_source_const public https://github.com/wesnoth/wesnoth/commit/e8776e3c79759f910714bd21c8cb5464531eabe2
20170428 02:27:23< celticminstrel> I don't get why that had to be a separate commit though...
20170428 02:36:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170428 02:38:19< vultraz_iOS> hey PR 1000
20170428 02:38:32< vultraz_iOS> sadly it's nothing :(
20170428 02:40:24< celticminstrel> ...
20170428 02:40:31< celticminstrel> What the heck was that?
20170428 02:40:38< celticminstrel> Did he accidentally open it to the wrong repo?
20170428 02:40:40< vultraz_iOS> i have no idea
20170428 02:40:44< vultraz_iOS> he opened another one
20170428 02:41:52< celticminstrel> Was he the one who removed the fresh_stats call?
20170428 02:49:29< vultraz_iOS> no idea
20170428 02:49:31< vultraz_iOS> perhaps
20170428 02:50:27< celticminstrel> I just thought that if he was, it's theoretically possible that he cherry-picked it and didn't notice it failed.
20170428 02:50:45< celticminstrel> Since you added that change yourself IIRC
20170428 02:50:46-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 02:51:06< celticminstrel> And then theoretically he might have pushed and opened the PR, thinking that that change was in it.
20170428 02:51:23< celticminstrel> But I could easily be totally wrong.
20170428 03:00:07< vultraz_iOS> celticminstrel: is the luamap branch good
20170428 03:00:54< celticminstrel> Oh yeah, I could check if there's any open GNA issues assigned to me...
20170428 03:01:06< celticminstrel> The Lua map generator? Um... let me think...
20170428 03:01:34< celticminstrel> Oh, it passed, that's nice.
20170428 03:01:39< celticminstrel> Ah right, there was a WIP commit.
20170428 03:02:10< celticminstrel> And I wasn't sure why it didn't work and asked for comments but apparently no-one commented.
20170428 03:02:45< celticminstrel> Besides that, I also wanted to add a default settings dialog for the cave generator.
20170428 03:07:33< irker327> wesnoth: sigurdfdragon wesnoth:master 5ebe71be0337 / data/campaigns/Secrets_of_the_Ancients/ (5 files in 2 dirs): SotA: Fix altar lighting for sacrifice scene https://github.com/wesnoth/wesnoth/commit/5ebe71be0337b6bee61efde959e8a55f328704f6
20170428 03:28:13-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 03:30:17-!- atarocch [~atarocch@31.159.11.87] has quit [Read error: Connection reset by peer]
20170428 03:33:30< vultraz_iOS> celticminstrel: you could start looking at making the theme UI button overlays not get destroyed when a dialog is open
20170428 03:48:35-!- RatArmy_ [~ratarmy@om126234121087.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 03:53:50< irker327> wesnoth: Charles Dang wesnoth:master ed8562a8158c / INSTALL INSTALL.md: Made INSTALL a Markdown file https://github.com/wesnoth/wesnoth/commit/ed8562a8158c3bb5c73663875ddc2c87df55fb0f
20170428 03:54:28-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170428 03:54:33< celticminstrel> Just FTR, I already fixed the crash I accidentally introduced in my last commit.
20170428 03:54:59< vultraz_iOS> what?
20170428 03:55:11< celticminstrel> I'll push it once I'm finished with what I'm doing.
20170428 03:59:24< vultraz_iOS> celticminstrel: how would you find all README files in a directory and its subs?
20170428 03:59:57< vultraz_iOS> oh wait. i forgot Windows Explorer find is a thing xDD
20170428 04:07:33< irker327> wesnoth: Charles Dang wesnoth:master bba5454443a0 / / (32 files in 16 dirs): Made README files Markdown https://github.com/wesnoth/wesnoth/commit/bba5454443a0fbc17e540e1c3a90465d9cf4d719
20170428 04:08:13< celticminstrel> Uhh. You should have actually checked it still looks good as Markdown...
20170428 04:08:46< celticminstrel> INSTALL doesn't, because it gets confused between "numbered list" and "header".
20170428 04:09:30< vultraz_iOS> Will fix
20170428 04:09:36< celticminstrel> Some of the readme files too.
20170428 04:09:40< celticminstrel> Like the cmake one.
20170428 04:10:08< vultraz_iOS> what's the numbered list syntax again?
20170428 04:10:17< celticminstrel> 1. thing
20170428 04:10:28< vultraz_iOS> but that's what's there
20170428 04:10:37< vultraz_iOS> oh
20170428 04:10:39< vultraz_iOS> it's the header
20170428 04:10:43< celticminstrel> Yes, the problem is that the header is also a numbered list.
20170428 04:10:48< celticminstrel> Or looks like one, rather.
20170428 04:10:56< celticminstrel> I'm not quite sure how to fix that.
20170428 04:11:04< celticminstrel> You could use the alternate title syntax, I suppose.
20170428 04:11:10< celticminstrel> # 1. Prerequisites
20170428 04:11:21< celticminstrel> (Instead of the line of ='s on the next line.)
20170428 04:11:46< vultraz_iOS> I assume we want ##
20170428 04:11:47< celticminstrel> data/tools/README appears to have been in some other markup format.
20170428 04:11:57< celticminstrel> Oh, probably.
20170428 04:12:06< celticminstrel> Kinda looks like MediaWiki actually.
20170428 04:12:34< celticminstrel> So I guess == Scripts == can become ## Scripts and === journeylifter === can become ### journeylifter etc
20170428 04:13:12< celticminstrel> tools/emacs_mode/README could use a little ```
20170428 04:13:53< celticminstrel> data/tools/wesnoth/README appears to be Doxygen markdown...
20170428 04:14:16< celticminstrel> Or no, it appears to be Doxygen plaintext?
20170428 04:14:25< celticminstrel> Doxygen didn't always support Markdown IIRC.
20170428 04:17:53< irker327> wesnoth: Charles Dang wesnoth:master bf93c346dc43 / INSTALL.md: Reformat INSTALL file to work correctly with Markdown https://github.com/wesnoth/wesnoth/commit/bf93c346dc436393eeb04800a0cf22bb855047a9
20170428 04:18:52< vultraz_iOS> looks *so* much better now
20170428 04:19:32< celticminstrel> Gonna do stuff about any of the other readmes?
20170428 04:20:33< celticminstrel> Oh right, I forgot that indenting with spaces also made a code block.
20170428 04:20:47< celticminstrel> In fact, IIRC, that's the actual Markdown way of doing it rather than the GitHub extension.
20170428 04:21:07< vultraz_iOS> probably not
20170428 04:22:36< celticminstrel> Looks like that guy got his PR working properly on his third try.
20170428 04:25:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 04:29:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170428 04:29:48-!- Kwandulin [~Kwandulin@p200300760F6D803FAC613231AD8944BF.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170428 04:36:54-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170428 04:54:57< irker327> wesnoth: Celtic Minstrel wesnoth:master ac23b4579e78 / src/gui/dialogs/addon/manager.cpp: fixup! Addon Manager: Make type lists static since they never change https://github.com/wesnoth/wesnoth/commit/ac23b4579e784e82fb3b6673b6f4852c0cf10659
20170428 04:55:18< irker327> wesnoth: Celtic Minstrel wesnoth:lua_multi_require 383dba93378b / src/scripting/lua_fileops.cpp: Allow wesnoth.require to load a whole directory in one call https://github.com/wesnoth/wesnoth/commit/383dba93378bbb49bff1011beaeed04722d35954
20170428 04:55:42< celticminstrel> gfgtdf, Jyrki: Any idea why that doesn't work? ^
20170428 04:55:57< celticminstrel> When I call wesnoth.require "lua/wml" I get a table containing only items.
20170428 04:56:05< celticminstrel> ie, {items = {...}}
20170428 05:09:04-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has joined #wesnoth-dev
20170428 05:11:59-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 05:13:35-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has joined #wesnoth-dev
20170428 05:16:04-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 05:24:35-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has joined #wesnoth-dev
20170428 05:37:36-!- RatArmy_ [~ratarmy@om126212252199.14.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 05:42:55< irker327> wesnoth: Charles Dang wesnoth:display_context_proxy a2d6b9c2d857 / src/ (9 files in 3 dirs): [WIP] add proxy class to implement display_context getters in non-derived classe https://github.com/wesnoth/wesnoth/commit/a2d6b9c2d857fdc13fce5948a59cf32519bec2e8
20170428 05:43:15< vultraz_iOS> i just can't think of anything else to try
20170428 05:46:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170428 05:52:42< vultraz_iOS> celticminstrel: now, what was this thing you wanted me to do?
20170428 05:52:49< vultraz_iOS> make mp change control not use resourced/"
20170428 05:52:57< celticminstrel> Oh yeah.
20170428 05:53:01< celticminstrel> Sure.
20170428 05:53:15< celticminstrel> The menu_handler that's already passed to mp_change_control already holds a reference to the game_board.
20170428 05:53:54< vultraz_iOS> should i make it a reference
20170428 05:54:00< vultraz_iOS> or do i need to validate the ptr
20170428 05:54:24< vultraz_iOS> I'm thinking a reference since a ptr desn't make much sense if the dialog is meant to rely on it
20170428 05:56:20< celticminstrel> ?
20170428 05:57:14< vultraz_iOS> should i make the menu_handler a reference
20170428 05:57:32< celticminstrel> Oh. Yeah, probably.
20170428 05:59:53< zookeeper> urgh, that forum spam... my learning something new every day quota filled already for today.
20170428 06:13:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 06:16:30< irker327> wesnoth: Charles Dang wesnoth:master 2a6ca6cd9e86 / src/ (19 files in 11 dirs): Deployed more emplace_back (how do I keep missing these...) https://github.com/wesnoth/wesnoth/commit/2a6ca6cd9e8620b433e9b7ecd8892ca52c926814
20170428 06:16:33< irker327> wesnoth: Charles Dang wesnoth:master a4b3f72a575e / src/tests/gui/test_gui2.cpp: GUI2 Tests: directly initialize a vector https://github.com/wesnoth/wesnoth/commit/a4b3f72a575e4d04f75b50930ab544da376cdfe7
20170428 06:16:42< celticminstrel> Heh.
20170428 06:16:54< vultraz_iOS> *how* do I keep missing them, though :|
20170428 06:17:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170428 06:17:57< celticminstrel> ...
20170428 06:18:26< celticminstrel> Isn't it weird that it's working with std::pair<size_t,size_t> but then inserting them into a vector<pair<int,int>>?
20170428 06:19:03< celticminstrel> On an unrelated note, should I make the GUI2 tests compilable on MSVC 2013?
20170428 06:19:34< vultraz_iOS> i suppose
20170428 06:19:36< vultraz_iOS> since we support 2013
20170428 06:19:39< vultraz_iOS> for now
20170428 06:19:56< celticminstrel> Ah! tresolution_list! :(
20170428 06:20:40< celticminstrel> Making them compilable on MSVC 2013 means adding some dialog_tester constructors.
20170428 06:30:50< celticminstrel> Hmm. So the menu buttons now redraw, but the action buttons still don't. :S
20170428 06:31:01< celticminstrel> Even though I explicitly added the same code to both cases...
20170428 06:31:24< vultraz_iOS> hm
20170428 06:31:39< vultraz_iOS> i just remembered i never added explicit handling for that Give option in MP Create
20170428 06:31:52< celticminstrel> ???
20170428 06:32:47< vultraz_iOS> celticminstrel: in the controllers menu
20170428 06:32:52< vultraz_iOS> there's a --give-- option
20170428 06:32:55< vultraz_iOS> should I remove that
20170428 06:32:58< vultraz_iOS> it's just visual
20170428 06:32:59< celticminstrel> What does it do?
20170428 06:33:06< vultraz_iOS> nothing
20170428 06:33:09< celticminstrel> Or what is it supposed to do?
20170428 06:33:11< vultraz_iOS> it's purely visual
20170428 06:33:19< vultraz_iOS> names under it are players
20170428 06:33:38< vultraz_iOS> the connect engine basically discards it if you select that
20170428 06:33:51< vultraz_iOS> the gui1 dialog re-set the label to something else
20170428 06:33:59< vultraz_iOS> just wondering if i should remove that altogether
20170428 06:35:16< vultraz_iOS> it's only purpose is a visual delim between the players and controller options
20170428 06:36:40< celticminstrel> Hmm.
20170428 06:39:06< vultraz_iOS> since this is gui2 and more powerful we could obviously
20170428 06:39:09< vultraz_iOS> make player names bold
20170428 06:39:10< vultraz_iOS> or something
20170428 06:47:42< celticminstrel> Ugh.
20170428 06:48:02< celticminstrel> The panel has a fixed-height linked_group.
20170428 06:48:13< vultraz_iOS> what?
20170428 06:48:17< celticminstrel> Oh, hmm, maybe I could use the swap_grid thing or something...
20170428 06:48:39< celticminstrel> Where's the GUI_HORIZONTAL_SPACER defined again?
20170428 06:48:42< vultraz_iOS> should i make the board, etc getter
20170428 06:48:48< vultraz_iOS> public
20170428 06:48:56-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170428 06:48:57< vultraz_iOS> in menu_handker
20170428 06:49:06< celticminstrel> I dunno. It's probably either that or declaring a friend class.
20170428 06:49:09< vultraz_iOS> celticminstrel: there is no such macro
20170428 06:49:26< vultraz_iOS> if you mean GUI_HORIZONTAL_SPACER_LINE it's in initial.cfg
20170428 06:49:48< celticminstrel> That's the one, but ugh, seriously? A [drawing]?
20170428 06:50:05< vultraz_iOS> what's wrong with it
20170428 06:50:06< vultraz_iOS> :|
20170428 06:50:17< vultraz_iOS> that's literally the only way to do it
20170428 06:50:28< celticminstrel> Hmm.
20170428 06:50:49< celticminstrel> Could it be done with a [spacer]?
20170428 06:51:07< vultraz_iOS> not likely
20170428 06:51:10< vultraz_iOS> spacers don
20170428 06:51:14< vultraz_iOS> t do canvas drawing
20170428 06:51:27< celticminstrel> ...eh?
20170428 06:51:39< vultraz_iOS> just leave it
20170428 06:51:51< celticminstrel> Why?
20170428 06:53:40< vultraz_iOS> why do you need to change it?
20170428 06:53:43< vultraz_iOS> what are you trying to do?
20170428 06:54:02< vultraz_iOS> and i say leave it because that's *the only way to do it right now*
20170428 06:54:54< celticminstrel> I'm trying to implement separators in drop_down_menu.
20170428 06:55:08< celticminstrel> Should I make it use a tree_view then?
20170428 06:55:17< vultraz_iOS> that thought had occurred to me
20170428 06:55:41< vultraz_iOS> at this point i think we should really look to refactoring the generator class so we don't have to rely on the tree view class so much...
20170428 06:55:58< vultraz_iOS> anyway, using a tree view might come with other caveats 
20170428 06:57:10< celticminstrel> Oh?
20170428 06:57:25< celticminstrel> But wait, does the tree_view not use the generator?
20170428 06:58:27< vultraz_iOS> don't think so
20170428 07:03:25< celticminstrel> The generator can support different types of items.
20170428 07:03:49< vultraz_iOS> yes
20170428 07:03:53< vultraz_iOS> h
20170428 07:03:54< vultraz_iOS> m
20170428 07:04:02< vultraz_iOS> well then the listbox needs to be able to utilizr that
20170428 07:04:04< vultraz_iOS> utilize that
20170428 07:04:22< celticminstrel> I'm not sure the listbox should utilize it, but... it certainly could.
20170428 07:11:10< irker327> wesnoth: Charles Dang wesnoth:master dd5a8a6e38a3 / src/menu_events.hpp: Menu Handler: made state gamestate/gameboard data getters public https://github.com/wesnoth/wesnoth/commit/dd5a8a6e38a30d1d638c33ffcd90841a67511000
20170428 07:11:12-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 07:11:13< irker327> wesnoth: Charles Dang wesnoth:master 8970340f3902 / src/ (3 files in 2 dirs): MP Change Control: utilize menu_handler member for game_board access https://github.com/wesnoth/wesnoth/commit/8970340f3902da4c6ffee4e6869a247530791b0e
20170428 07:13:41-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 07:14:17-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 07:14:34-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170428 07:16:27-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 07:16:39-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 07:20:29< vultraz_iOS> menu_handler is really bloated 
20170428 07:26:57-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 07:33:28< vultraz_iOS> "You are about to open a security breach in Wesnoth. Are you sure you want to continue? If you have downloaded add-ons, do not click 'ok'! They would instantly take over your computer."
20170428 07:33:30< vultraz_iOS> jesus christ
20170428 07:33:34< vultraz_iOS> scare-factor much?
20170428 07:33:49< celticminstrel> Haha
20170428 07:33:56< celticminstrel> What was that for again?
20170428 07:33:59< vultraz_iOS> unsafe lua
20170428 07:34:03< celticminstrel> Ah, right.
20170428 07:34:07< celticminstrel> Well, it's probably true though.
20170428 07:34:16< celticminstrel> At least if you replace "would" with "could".
20170428 07:34:23-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 07:38:07< vultraz_iOS> celticminstrel: what exactly does unsafe lua do anyway
20170428 07:38:27< celticminstrel> IIRC it allows you access to the file library, which means scripts can open any file on your computer.
20170428 07:38:44< celticminstrel> (Within filesystem permissions obviously.)
20170428 07:39:52< celticminstrel> Kinda surprised you wrote .board().teams() instead of just .teams(). Not that it matters though.
20170428 07:40:20< vultraz_iOS> oh
20170428 07:40:22< vultraz_iOS> dur
20170428 07:40:24< vultraz_iOS> >_>
20170428 07:40:31< vultraz_iOS> too much refactoring made me forget that was a thing
20170428 07:40:35< celticminstrel> I kinda want to know what side_nick_map_ was even for...
20170428 07:41:18< vultraz_iOS> temp thing i added during my refactor
20170428 07:41:40< vultraz_iOS> before realizing the code could not be made to use a map
20170428 07:41:47< vultraz_iOS> so i commented it out and forgot to remove it
20170428 07:42:51< vultraz_iOS> celticminstrel: suggest this edit for the unsafe lua prompt
20170428 07:42:54< vultraz_iOS> WARNING! Unsafe Lua Mode
20170428 07:42:54< vultraz_iOS> Executing Lua code in in this manner opens your computer to potential security breaches from any malicious add-ons or other programs you may have installed.
20170428 07:42:54< vultraz_iOS> Do not continue unless you really know what you are doing.
20170428 07:43:12< celticminstrel> Shrug!
20170428 07:43:22< celticminstrel> I have no objections to that text, anyway.
20170428 07:59:25< irker327> wesnoth: Charles Dang wesnoth:master a4e3f54661f3 / src/ (menu_events.cpp menu_events.hpp): Menu Handler/Chat Handler: reformat https://github.com/wesnoth/wesnoth/commit/a4e3f54661f3013e6bc4a829d60848481826276e
20170428 07:59:28< irker327> wesnoth: Charles Dang wesnoth:master 7e5e83d0715b / src/menu_events.cpp: Rewrote the unsafe lua mode warning to be less panic-y https://github.com/wesnoth/wesnoth/commit/7e5e83d0715ba39102d07c1496642035eff5e358
20170428 07:59:31< irker327> wesnoth: Charles Dang wesnoth:master 10925b8f92c0 / src/menu_events.cpp: Menu Handler: deploy range-for https://github.com/wesnoth/wesnoth/commit/10925b8f92c0b1798e85ac5b5fbded0ec8ca8437
20170428 08:00:34< celticminstrel> vultraz_iOS: Minor typo in 7e5e83d0
20170428 08:00:49< celticminstrel> Missing a space between "anymalicious"
20170428 08:00:56< vultraz_iOS> oops
20170428 08:01:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 08:04:53< irker327> wesnoth: Charles Dang wesnoth:master 17405bcdfb22 / src/menu_events.cpp: Fixed a bit of unintended formatting in a4e3f5466 and a typo in 7e5e83d07 https://github.com/wesnoth/wesnoth/commit/17405bcdfb22813948b6714d0f7286a26ea5a437
20170428 08:05:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170428 08:19:05< irker327> wesnoth: Charles Dang wesnoth:master d0b9f431e78c / src/menu_events.cpp: Remove some unnecessary draw calls when recruiting or recalling https://github.com/wesnoth/wesnoth/commit/d0b9f431e78cc9353a2d87276d64c2cdbab54e1a
20170428 08:19:48< Aginor> we should get onto https://scan.coverity.com/github
20170428 08:20:53< vultraz_iOS> what does it do?
20170428 08:21:22< vultraz_iOS> hmmm
20170428 08:21:32-!- Appleman1234 [~Appleman1@pl5101.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170428 08:21:53< celticminstrel> Static code analysis can be helpful, I guess.
20170428 08:22:01< vultraz_iOS> sure, why not
20170428 08:22:12< Aginor> it rocks
20170428 08:22:31< Aginor> it's pretty good at finding bugs
20170428 08:22:34< celticminstrel> I think I've occasionally found bugs using XCode's static analysis (I assume that's part of clang/LLVM), and we already found some bugs using cppcheck, right?
20170428 08:22:43< celticminstrel> cppcheck is also a static analyzer, right?
20170428 08:23:05< Aginor> yes
20170428 08:23:26< Soliton> https://scan.coverity.com/projects/wesnoth
20170428 08:23:28< Aginor> I've used coverity for various work projects, it's awesome
20170428 08:23:49< vultraz_iOS> :o
20170428 08:24:09< Aginor> a bit of pain to get set up though
20170428 08:24:18< vultraz_iOS> seems we're already there?
20170428 08:24:20< Aginor> and very expensive for closed source
20170428 08:24:22< celticminstrel> I'm kinda surprised it's already there...
20170428 08:24:32< Aginor> someone used to run it for wesnoth
20170428 08:24:34< celticminstrel> It looks like it's not set up currently, though.
20170428 08:24:44< celticminstrel> Last build was almost a year ago.
20170428 08:24:45< Aginor> maybe iceiceice
20170428 08:24:49< vultraz_iOS> well then let's get it running again
20170428 08:24:53< Soliton> i think AI0867 set it up originally.
20170428 08:25:28< vultraz_iOS> who is the owner tho
20170428 08:26:24< vultraz_iOS> doesn't say
20170428 08:26:37< Aginor> just link the github account?
20170428 08:26:44< Soliton> Aginor: you seem to have asked AI0867 to become a coverity admin last. i guess you did not get a response?
20170428 08:26:48< vultraz_iOS> one needs to request access
20170428 08:27:19< Aginor> Soliton: no, I don't think I did. 
20170428 08:27:23< Soliton> https://wiki.wesnoth.org/Coverity
20170428 08:28:31< Soliton> i guess we need AI0867 for that coverity token.
20170428 08:28:41< Aginor> or contact support
20170428 08:29:42< JyrkiVesterinen> I think AI is still semi-active, so we only need to wait for his response.
20170428 08:33:17< celticminstrel> He pops up on github periodically, so yeah.
20170428 08:33:19-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 08:35:04< celticminstrel> JyrkiVesterinen: Any idea why this doesn't work? https://github.com/wesnoth/wesnoth/commit/383dba93378bbb49bff1011beaeed04722d35954
20170428 08:35:32< JyrkiVesterinen> Sorry, going through that commit would take more time than I'm willing to spend.
20170428 08:35:40< celticminstrel> Oh.
20170428 08:36:00< JyrkiVesterinen> Lua C API is such a low-level API. Reading code that uses that API is just so slow...
20170428 08:36:16< celticminstrel> Hard to debug too because I can't see the stack.
20170428 08:57:53-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 08:59:43-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: .]
20170428 09:01:54< Aginor> I so want a faster computer :/
20170428 09:02:11< Aginor> but no, I have to go and spend my money on more responsible things
20170428 09:13:00-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 09:17:40< Soliton> seems someone renamed INSTALL to INSTALL.md so it now looks funny if you want to read it, at least in vim.
20170428 09:18:49< irker327> wesnoth: Andreas Löf wesnoth:composed_hotkeys 53858984c8b0 / / (6 files in 3 dirs): Fix #24681: Use composed hotkeys where appropriate and revert help to be ':' https://github.com/wesnoth/wesnoth/commit/53858984c8b069074c7091c4fcf6d9cec9152b07
20170428 09:18:51< irker327> wesnoth: Andreas Löf wesnoth:composed_hotkeys 32153752258a / src/ (hotkey/hotkey_item.cpp hotkey/hotkey_item.hpp key.cpp key.hpp): Fix 24681: Proper filtering of modifiers when handling hotkeys https://github.com/wesnoth/wesnoth/commit/32153752258abbc84df2d6f351bd4a6b1f2e25ce
20170428 09:18:53< irker327> wesnoth: Andreas Löf wesnoth:composed_hotkeys 43b85f7d5d79 / src/ (gui/dialogs/hotkey_bind.cpp gui/dialogs/hotkey_bind.hpp hotkey/hotkey_item.hpp): WIP: start to clean up the hotkey dialog https://github.com/wesnoth/wesnoth/commit/43b85f7d5d794471cd9d81bd7991939686d4fc78
20170428 09:31:09< irker327> wesnoth: Andreas Löf wesnoth:composed_hotkeys dd200859faa1 / src/hotkey/ (hotkey_item.cpp hotkey_item.hpp): WIP: fix linker issue https://github.com/wesnoth/wesnoth/commit/dd200859faa11795cb9718be4876f454380b9ea8
20170428 09:34:22-!- Appleman1234 [~Appleman1@pl44893.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170428 09:43:10-!- JyrkiVesterinen [~JyrkiVest@85.76.67.43] has joined #wesnoth-dev
20170428 09:49:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 09:54:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20170428 10:03:24-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 10:19:49-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 10:25:13-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170428 10:30:33-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 10:33:33< celticminstrel> ...oh right, there should be another way to make menu separators.
20170428 10:33:50< celticminstrel> Rather than having the separator be a separate item, it could be a flag on an item - like "line_before" or something.
20170428 10:34:03< celticminstrel> vultraz_iOS: Would that be easier to implement?
20170428 10:37:44< vultraz_iOS> celticminstrel: elaborate 
20170428 10:38:08< celticminstrel> Basically, it would be a flag that tells the row to draw a line along its upper border.
20170428 10:39:04< celticminstrel> Or lower border, I suppose.
20170428 10:39:43< vultraz_iOS> that would be harder to implement
20170428 10:39:53< celticminstrel> Really?
20170428 10:39:56< vultraz_iOS> yes
20170428 10:39:59< celticminstrel> Why?
20170428 10:40:23< vultraz_iOS> well, how would you draw the border?
20170428 10:40:31< vultraz_iOS> A: you could implement conditional canvas shapes
20170428 10:40:35< vultraz_iOS> B: a custom definition 
20170428 10:40:42< vultraz_iOS> but how do you choose said definition?
20170428 10:40:43< celticminstrel> I was thinking a custom definition.
20170428 10:40:46< vultraz_iOS> definitions are not dynamic
20170428 10:40:49< vultraz_iOS> at all
20170428 10:41:04< celticminstrel> I feel like it should be possible...
20170428 10:41:19< vultraz_iOS> set_definition can only be called at widget creation time
20170428 10:41:23< vultraz_iOS> perhaps that should change
20170428 10:41:29< vultraz_iOS> but for now that's the case
20170428 10:41:32< celticminstrel> Well, no, that's not necessarily what's needed.
20170428 10:41:44< vultraz_iOS> so, you think, what if I provide a way to select different "variants" of the list definition
20170428 10:41:50< vultraz_iOS> in which case, you might as well use a tree view
20170428 10:41:54< celticminstrel> What's needed, I think, would be for the generator to support setting the definition of generated items.
20170428 10:41:59< vultraz_iOS> you follow?
20170428 10:42:53< celticminstrel> Hmm, looking at styled_widget::set_members, it seems like that's not the case currently.
20170428 10:43:01< celticminstrel> Not sure if it would be trivial to add (or even a good idea).
20170428 10:43:18< celticminstrel> Conditional canvas shapes should already be possible too though.
20170428 10:44:15< celticminstrel> The only question then would be how you set the variable... 
20170428 10:44:55< vultraz_iOS> conditional canvas shapes could also mean allowing metatags in the canvas wml
20170428 10:44:58< vultraz_iOS> like [if]
20170428 10:45:08< celticminstrel> Uhh.
20170428 10:45:15< celticminstrel> Well I suppose that could be a possibility too.
20170428 10:45:41< celticminstrel> But I was thinking more something like color="(if(condition, [r,g,b,a], [0,0,0,0]))"
20170428 10:46:07< celticminstrel> Speaking of which, I wonder if it skips drawing shapes that are fully-transparent.
20170428 10:46:14< vultraz_iOS> nooo nonononono
20170428 10:48:31< vultraz_iOS> honestly a tree view is simples
20170428 10:48:37< vultraz_iOS> t
20170428 10:48:44< vultraz_iOS> might also allow something else i was considering
20170428 10:49:00< vultraz_iOS> showing the currently playing track at the top of the ediot rmusic menu
20170428 10:50:25< irker327> wesnoth: Celtic Minstrel wesnoth:master ad9bf209a758 / src/ (display.cpp widgets/widget.hpp): Fix buttons disappearing while menus are open https://github.com/wesnoth/wesnoth/commit/ad9bf209a758fa0172cdadd4931a884265bd47df
20170428 10:50:37< celticminstrel> Uh.
20170428 10:50:57< vultraz_iOS> along with a slider for progress
20170428 10:50:59< vultraz_iOS> possibly
20170428 10:51:27< vultraz_iOS> celticminstrel: that simple, eh o_O
20170428 10:51:30< celticminstrel> I don't think I like this idea.
20170428 10:51:39< vultraz_iOS> y u no like this idea
20170428 10:51:50< vultraz_iOS> my idea is flawless :P
20170428 10:52:01< celticminstrel> Because it implies stuffing yet more features into the menu implementation.
20170428 10:52:37< vultraz_iOS> no?
20170428 10:52:42< celticminstrel> No?
20170428 10:53:35< vultraz_iOS> i dont tink so
20170428 10:53:38< vultraz_iOS> think
20170428 10:53:43< celticminstrel> So how would you do it?
20170428 10:53:58< vultraz_iOS> not sure
20170428 10:54:13< vultraz_iOS> if this was anura id spawn an object so...
20170428 10:54:14< vultraz_iOS> a widget
20170428 10:54:16< vultraz_iOS> i guess
20170428 10:54:23< celticminstrel> ???
20170428 10:54:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170428 10:56:02< vultraz_iOS> what?
20170428 10:57:42< celticminstrel> BTW, if you did do that, I'd suggest using a progress_bar widget.
20170428 10:58:26< celticminstrel> But anyway... if you're not going to stuff more features into the drop_down_list, would you make a custom dialog instead/
20170428 10:58:27< celticminstrel> ^?
20170428 10:59:27< celticminstrel> Oh hey, I just thought of something to add to the Lua music API.
20170428 10:59:54< celticminstrel> But it's a slightly(?) bigger undertaking, so I think I'll put it on hold for now and not include it in wml_tag_porting.
20170428 11:01:13< celticminstrel> I wonder how large something would need to be to produce underflow(?) in the progress_bar...
20170428 11:03:25< celticminstrel> I guess it's not really something to be worried about.
20170428 11:05:19< celticminstrel> Anyway, about the --give--, I think ideally it could be replaced by a separator.
20170428 11:24:23-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 11:30:27-!- celticminstrel is now known as celmin|nap
20170428 11:32:02-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 11:36:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170428 11:37:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170428 11:38:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 11:42:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170428 11:57:09-!- Kwandulin [~Kwandulin@p200300760F6D803F744FC73157D0220F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170428 12:03:50-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 12:22:04-!- Kwandulin2 [~Kwandulin@p200300760F6D809E4CDAB9D1BD267C2F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170428 12:23:08-!- Kwandulin [~Kwandulin@p200300760F6D803F744FC73157D0220F.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170428 12:32:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170428 12:32:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170428 12:53:02-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 13:09:54-!- RatArmy_ [~ratarmy@om126234117178.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 13:41:36-!- Kwandulin2 [~Kwandulin@p200300760F6D809E4CDAB9D1BD267C2F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170428 13:46:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170428 13:46:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170428 13:51:04-!- irker327 [~irker@109.237.213.40] has quit [Quit: transmission timeout]
20170428 14:07:57-!- atarocch [~atarocch@107.19.190.6] has joined #wesnoth-dev
20170428 14:27:50-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170428 14:31:33-!- Kwandulin [~Kwandulin@p200300760F6D809E39CE5825879CB931.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170428 14:31:49-!- atarocch [~atarocch@107.19.190.6] has quit [Remote host closed the connection]
20170428 14:32:53-!- JyrkiVesterinen [~JyrkiVest@85.76.67.43] has quit [Quit: .]
20170428 15:03:35-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170428 15:10:57< mkdroid> re #25680: no idea about release version
20170428 16:09:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 16:09:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 16:09:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 17:10:23-!- JyrkiVesterinen [~JyrkiVest@87-100-141-176.bb.dnainternet.fi] has joined #wesnoth-dev
20170428 17:52:11-!- Kwandulin [~Kwandulin@p200300760F6D809E39CE5825879CB931.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170428 17:59:12-!- Kwandulin [~Kwandulin@p200300760F6D809EFC70C9B757DC4C53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170428 18:10:13< celmin|nap> ...
20170428 18:10:19-!- celmin|nap is now known as celticminstrel
20170428 18:51:28-!- irker166 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170428 18:51:28< irker166> wesnoth: Celtic Minstrel wesnoth:master d4c75b6ad6dd / src/gui/dialogs/game_stats.cpp: Game Stats: Show controller https://github.com/wesnoth/wesnoth/commit/d4c75b6ad6dda5427163db18881e3f5008fb5de6
20170428 19:04:36< celticminstrel> Hmm, it looks like tooltip placement method V deliberately puts the tooltip in the top left...
20170428 19:05:00-!- JyrkiVesterinen [~JyrkiVest@87-100-141-176.bb.dnainternet.fi] has quit [Quit: .]
20170428 19:06:50< celticminstrel> So... placement method V is triggered if the tooltip is higher than the screen or wider than half the screen... why half?
20170428 19:10:23< celticminstrel> It also seems like it never attempts to put the tooltip below the mouse...
20170428 19:12:05-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170428 19:12:29< celticminstrel> Any suggestions, vultraz_iOS?
20170428 19:12:57< vultraz_iOS> Yes. Please remember to use the proper { on newline formatting ;_;
20170428 19:13:05< celticminstrel> <_<
20170428 19:13:08< celticminstrel> I'll try?
20170428 19:13:21< irker166> wesnoth: Celtic Minstrel wesnoth:master 06450e8bb627 / data/gui/window/ (tooltip_floating.cfg tooltip_large.cfg): Split tooltip definitions into separate files https://github.com/wesnoth/wesnoth/commit/06450e8bb62767546cb5e9da24c20845eb73e12b
20170428 19:13:21< vultraz_iOS> now, what's this really about
20170428 19:13:26< celticminstrel> Tooltips.
20170428 19:13:35< vultraz_iOS> what about them
20170428 19:13:51< celticminstrel> Their placement formulas still leave much to be desired.
20170428 19:15:22< vultraz_iOS> yes
20170428 19:15:28< vultraz_iOS> feel free to do whatever with them
20170428 19:21:09< vultraz_iOS> well here's a nice bug
20170428 19:21:27< vultraz_iOS> open Back to Turn..., but dismiss it by clicking outside
20170428 19:21:34< vultraz_iOS> next menu item you click will trigger that
20170428 19:26:43< vultraz_iOS> celticminstrel: i think the controller would look better w/o the indent
20170428 19:26:59< celticminstrel> Eh.
20170428 19:27:21< celticminstrel> I prefer it with the indent, but it's probably not a big deal.
20170428 19:28:11< vultraz_iOS> somethig is seriously fucked up with menus
20170428 19:28:48< vultraz_iOS> the first two commands are always brining up the inspector/lua console
20170428 19:28:49< vultraz_iOS> brining
20170428 19:30:29< vultraz_iOS> good job on the button bug tho :)
20170428 19:31:22< celticminstrel> Huh? Were there commands to bring up the inspector or lua console?
20170428 19:32:48< irker166> wesnoth: Celtic Minstrel wesnoth:master 819fa7533051 / data/gui/window/tooltip_floating.cfg: Some improvements to tooltip placement https://github.com/wesnoth/wesnoth/commit/819fa75330512d6027f580778344f388fa6a0528
20170428 19:32:50< irker166> wesnoth: Celtic Minstrel wesnoth:master 19fa4244af94 / src/formula/function.cpp: Fix crash when using debug_print in a GUI2 formula https://github.com/wesnoth/wesnoth/commit/19fa4244af9440ece8ef9bca366e4358b1bc1614
20170428 19:32:51< vultraz_iOS> the custom menu items in shiki's addon
20170428 19:33:03< vultraz_iOS> or was it sigfurg's
20170428 19:33:08< vultraz_iOS> the gui debug tools anyway
20170428 19:33:13< celticminstrel> Oh.
20170428 19:33:49< celticminstrel> (That crash probably only occurred with --debug mind you)
20170428 19:35:37< celticminstrel> I'm not sure what you're talking about. The recruit menuitem definitely opens the recruit dialog.
20170428 19:35:49< vultraz_iOS> yes
20170428 19:35:52< vultraz_iOS> it does
20170428 19:36:05< vultraz_iOS> install the gui debug tools and see
20170428 19:36:12< vultraz_iOS> with the menus up at the top
20170428 19:36:14< celticminstrel> I have them installed already.
20170428 19:36:34< celticminstrel> Scenario Objectives opens the scenario objectives. Planning Mode toggles planning more.
20170428 19:37:01< vultraz_iOS> ah, ok
20170428 19:37:03< celticminstrel> Ah, there is something wrong in the actions menu though...
20170428 19:37:07< vultraz_iOS> celticminstrel: open the right click menu first
20170428 19:37:10< vultraz_iOS> then cancel it
20170428 19:37:17< vultraz_iOS> then attempt to use the actions menu
20170428 19:37:21< vultraz_iOS> first etry
20170428 19:38:04< celticminstrel> So basically the WML actions somehow override the proper actions in the action menu... if you right-click a castle hex, it's instead the third and fourth options that are replaced.
20170428 19:38:41< vultraz_iOS> seems to do something with canceling..
20170428 19:39:17< celticminstrel> I think it's nothing to do with cancelling. It looks like it happens the same if you don't cancel the menu.
20170428 19:39:51< celticminstrel> To test: Right-click a non-castle non-keep hex. Check the actions menu. Right-click a castle hex, click recruit. Cancel and check the actions menu.
20170428 19:40:12< celticminstrel> If it only happened when the menu is cancelled, you'd see the first two items have SFD's icon. Instead, the second two have it.
20170428 19:40:26< vultraz_iOS> weird
20170428 19:40:28< vultraz_iOS> what the hell
20170428 19:43:39< irker166> wesnoth: Celtic Minstrel wesnoth:master c77800333ca3 / src/hotkey/hotkey_handler.cpp: Fix WML commands replacing regular menuitems https://github.com/wesnoth/wesnoth/commit/c77800333ca39ca6c58f6ce36b2650968c851a23
20170428 19:44:32< celticminstrel> Was caused by only calling expand_wml_commands if "wml" is actually in the list of commands.
20170428 19:45:28< vultraz_iOS> ok, that's fixed
20170428 19:45:36< vultraz_iOS> what's *not* fixed is the Back to Turn bug
20170428 19:45:51< celticminstrel> It's probably a very similar fix.
20170428 19:45:51< vultraz_iOS> open the BTT menu, dismiss, and then try to execute any other menu item
20170428 19:46:01< celticminstrel> Check the other expand_* function in that file.
20170428 19:47:26< vultraz_iOS> you're right
20170428 19:47:26< vultraz_iOS> O_O
20170428 19:47:32< celticminstrel> ?
20170428 19:48:20< vultraz_iOS> fix is exactly the same
20170428 19:48:24< irker166> wesnoth: Charles Dang wesnoth:master e50d9ed417ad / src/hotkey/hotkey_handler.cpp: Fixed Back To Turn menu items overriding regular ones https://github.com/wesnoth/wesnoth/commit/e50d9ed417ad8b3a4ceac78530729f26dcd15134
20170428 19:50:06< celticminstrel> Huh, interesting, that expand function clears the WML commands.
20170428 19:50:43< celticminstrel> Wait, no...
20170428 19:50:51< celticminstrel> Never mind, misread.
20170428 20:07:16-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170428 20:07:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170428 20:16:30-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170428 20:36:50-!- Kwandulin [~Kwandulin@p200300760F6D809EFC70C9B757DC4C53.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170428 20:45:32< celticminstrel> So vultraz_iOS, should I switch the drop_down_list to tree_view or not?:
20170428 20:45:59< vultraz_iOS> if you want to implement separators it's the best way
20170428 20:46:01< celticminstrel> I mean, extending listbox to multiple item types is an option too.
20170428 20:46:19< vultraz_iOS> or that too
20170428 20:46:21< vultraz_iOS> if you want
20170428 20:46:27< celticminstrel> Which would you prefer?
20170428 20:46:39< vultraz_iOS> hmmmmmmmmmmmmmm
20170428 20:47:00< vultraz_iOS> wll, currently a lisbox requires a toggle button or panel..
20170428 20:47:05< vultraz_iOS> so that might make changing things harder
20170428 20:47:12< celticminstrel> Hm? How so?
20170428 20:47:41< vultraz_iOS> you'd have to totally change the schematics of the listbox
20170428 20:47:42< celticminstrel> Anyway, when saying which you'd prefer, I don't think "difficulty of implementation" should be a concern.
20170428 20:47:46< vultraz_iOS> to more match the tree view
20170428 20:47:52< celticminstrel> Huh?
20170428 20:47:54< celticminstrel> Schematics?
20170428 20:48:29< vultraz_iOS> a tree view honestly doesn't make much sense here, though...
20170428 20:48:36< celticminstrel> Indeed - there's no tree.
20170428 20:48:46< celticminstrel> We're using tree-views in other places where it doesn't make much sense, too.
20170428 20:48:50< vultraz_iOS> indeed
20170428 20:48:57< vultraz_iOS> we're using them as dynamic item generators
20170428 20:50:25< vultraz_iOS> i had wanted to implement lists of not just toggle stuff at some point
20170428 20:50:31< vultraz_iOS> i think that was the point of the list class
20170428 20:50:53< vultraz_iOS> so perhaps you should finish the experimental listbox
20170428 20:51:01< vultraz_iOS> if we're going to allow lists with non-toggle members
20170428 20:51:12< vultraz_iOS> a keep a listbox strictly toggle
20170428 20:51:58< celticminstrel> The experimental listbox replaces the current one, though.
20170428 20:52:28< vultraz_iOS> or we could do that
20170428 20:52:38< vultraz_iOS> make list a generic list class a just use it with toggles when we want
20170428 20:52:42< vultraz_iOS> that would also be acceptable
20170428 20:53:10< vultraz_iOS> split the current listbox handling into a policy module to handle pure-toggle lists, maybe
20170428 20:53:24< celticminstrel> Does the experimental listbox actually compile ATM?
20170428 20:53:44< vultraz_iOS> no idea
20170428 20:53:50< vultraz_iOS> I made it do so 2 years ago
20170428 20:53:54< vultraz_iOS> or so
20170428 20:54:27< celticminstrel> Then let's find out!
20170428 20:54:42< vultraz_iOS> *drumroll*
20170428 20:54:53< vultraz_iOS> i guarantee it won't run, though
20170428 20:55:16< vultraz_iOS> we don't want to throw out a lot of the current listbox API, though..
20170428 20:55:19< vultraz_iOS> more like generalize it
20170428 21:02:20-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170428 21:02:56< celticminstrel> Hmm, I want to add a new type of AI component...
20170428 21:03:18< celticminstrel> Wonder how much work that would be...
20170428 21:03:23-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 21:04:04< mkdroid> vultraz_iOS did you see my comment on the commi?
20170428 21:04:37< celticminstrel> vultraz_iOS: It doesn't compile for two reasons. a) tplacement in list.?pp; b) some places use listbox without the conditional compilation.
20170428 21:05:00< vultraz_iOS> mkdroid: what commit?
20170428 21:05:06< celticminstrel> https://github.com/wesnoth/wesnoth/commit/a4b3f72a575e4d04f75b50930ab544da376cdfe7
20170428 21:05:33< celticminstrel> I'll look at it.
20170428 21:05:40< celticminstrel> I was going to edit that file anyway.
20170428 21:06:41< mkdroid> i am not 100 perc positive that this is the cause but it seemed suspicious
20170428 21:06:49< mkdroid> thanks celticminstrel
20170428 21:09:39-!- horrowind [~Thunderbi@x4db32db6.dyn.telefonica.de] has joined #wesnoth-dev
20170428 21:14:03< vultraz_iOS> why the hell would clang not like that
20170428 21:14:13< vultraz_iOS> OH
20170428 21:14:24< vultraz_iOS> celticminstrel: i forgot the commas, I think
20170428 21:16:26< celticminstrel> ...yes, yes you did.
20170428 21:16:46< celticminstrel> I'm guessing Travis is giving the same error on all builds?
20170428 21:17:06< celticminstrel> Oh wait, mac build doesn't do tests though.
20170428 21:21:43-!- horrowind1 [~Thunderbi@77.179.45.182] has joined #wesnoth-dev
20170428 21:23:44-!- horrowind [~Thunderbi@x4db32db6.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170428 21:23:44-!- horrowind1 is now known as horrowind
20170428 21:38:27-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20170428 21:40:31-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 21:40:44-!- horrowind1 [~Thunderbi@x4db32db6.dyn.telefonica.de] has joined #wesnoth-dev
20170428 21:42:00-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 21:42:40-!- horrowind [~Thunderbi@77.179.45.182] has quit [Ping timeout: 240 seconds]
20170428 21:42:40-!- horrowind1 is now known as horrowind
20170428 21:42:51-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 21:44:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20170428 21:46:34-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 21:47:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 21:49:33-!- atarocch [~atarocch@107.19.188.59] has joined #wesnoth-dev
20170428 21:51:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 21:53:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 22:01:06-!- horrowind1 [~Thunderbi@x4db32db6.dyn.telefonica.de] has joined #wesnoth-dev
20170428 22:01:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 22:02:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 22:03:10-!- horrowind [~Thunderbi@x4db32db6.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170428 22:03:10-!- horrowind1 is now known as horrowind
20170428 22:12:30-!- atarocch [~atarocch@107.19.188.59] has quit [Ping timeout: 240 seconds]
20170428 22:14:49-!- horrowind1 [~Thunderbi@x4db32db6.dyn.telefonica.de] has joined #wesnoth-dev
20170428 22:17:01-!- horrowind [~Thunderbi@x4db32db6.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170428 22:17:01-!- horrowind1 is now known as horrowind
20170428 22:17:02-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 22:19:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 22:19:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 22:21:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 22:21:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 22:22:46< irker166> wesnoth: Celtic Minstrel wesnoth:master 1916815e384c / src/tests/gui/test_gui2.cpp: fixup! GUI2 Tests: directly initialize a vector https://github.com/wesnoth/wesnoth/commit/1916815e384cc1e864734130d97f87ef51d32a36
20170428 22:22:48< irker166> wesnoth: Celtic Minstrel wesnoth:master 8cb3334ca35f / src/tests/gui/test_gui2.cpp: Fix GUI2 test compilation on MSVC 2013 https://github.com/wesnoth/wesnoth/commit/8cb3334ca35f1bb850abb82ec6bc58bb72a90364
20170428 22:22:50< irker166> wesnoth: Celtic Minstrel wesnoth:master f142ed617069 / projectfiles/VC12/wesnoth.vcxproj: Fix MSVC misconfiguration for unit tests https://github.com/wesnoth/wesnoth/commit/f142ed617069f90b948601b8e89f9cf8faab9cfd
20170428 22:22:52< irker166> wesnoth: Celtic Minstrel wesnoth:master 74df91877fec / src/tests/ (gui/test_gui2.cpp test_serialization.cpp): Unit tests: Fix a few MSVC warnings https://github.com/wesnoth/wesnoth/commit/74df91877fec7d2c3d13cf470f23f58282bfb8b2
20170428 22:22:54< irker166> wesnoth: Celtic Minstrel wesnoth:master 0828c2bdf881 / projectfiles/VC12/wesnoth.sln: MSVC: Add Test_Debug and Test_Release to solution configurations https://github.com/wesnoth/wesnoth/commit/0828c2bdf881ba61e884ac89e4765985c77b168f
20170428 22:23:32< matthiaskrgr> ayay
20170428 22:23:35< matthiaskrgr> -^a
20170428 22:27:26-!- horrowind [~Thunderbi@x4db32db6.dyn.telefonica.de] has quit [Quit: horrowind]
20170428 22:30:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20170428 22:36:41< celticminstrel> Since aquileia is MIA right now, maybe wedge009 or gfgtdf could update aquileia/external?
20170428 22:38:20< celticminstrel> I could too, but lazy. >_>
20170428 23:03:36< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys b63a063f7b48 / src/ (9 files in 3 dirs): WIP: Pipe through raw sdl events for hotkeys https://github.com/wesnoth/wesnoth/commit/b63a063f7b4806698b65f043042f6da29ccd3576
20170428 23:03:51-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 23:05:16< vultraz_iOS> celticminstrel: im curious how exactly boost::mpl::set works
20170428 23:05:24< wedge009> celticminstrel: What needs updating? I haven't really checked much since the difficulty with FALLTHROUGH;
20170428 23:05:35< vultraz_iOS> I know it's basically a static compile-time set, but how does it do that
20170428 23:05:55< celticminstrel> wedge009: https://github.com/aquileia/external/issues
20170428 23:05:55< vultraz_iOS> AFAIK one cannot declare a static const std::set and use it in metafunctions 
20170428 23:06:17< celticminstrel> vultraz_iOS: It's a set of types, not values.
20170428 23:06:20< celticminstrel> I think.
20170428 23:06:44< vultraz_iOS> well in this case it's enum values
20170428 23:06:47< celticminstrel> Oh.
20170428 23:06:49< wedge009> Just the test framework?
20170428 23:07:08< celticminstrel> wedge009: I guess, maybe also removing VC9 and VC10 stuff.
20170428 23:07:13< vultraz_iOS> but you can use a template value as a type
20170428 23:07:16< vultraz_iOS> so that works
20170428 23:07:43< celticminstrel> vultraz_iOS: Maybe I'm wrong? I haven't really used MPL.
20170428 23:08:06< vultraz_iOS> I'm just wondering if there's a standard way to do that with c++11 
20170428 23:09:49< celticminstrel> Well, I don't know of anything.
20170428 23:11:13< celticminstrel> I kinda doubt there would be anything. I suppose maybe a constexpr set might work, provided set supports constexpr, but of course we can't actually use constexpr for anything yet.
20170428 23:12:36< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys b0399719b2dd / src/gui/core/event/dispatcher.cpp: WIP: Missing bit to make events be passed through properly https://github.com/wesnoth/wesnoth/commit/b0399719b2ddc2e70efca6abbf35e6bc40875ce1
20170428 23:15:21< Aginor> that's working
20170428 23:15:37< Aginor> of course, the general handling the the preferences dialog is broken
20170428 23:15:45< Aginor> but that's a separate issue methinks
20170428 23:16:06< celticminstrel> Hmm?
20170428 23:16:25< Aginor> I've fixed the hotkey bindings, again
20170428 23:16:42< Aginor> in the composed_hotkeys branch
20170428 23:16:45< celticminstrel> Okay.
20170428 23:16:55< Aginor> but the hotkey preferences dialog seems to be rather broken
20170428 23:17:04< celticminstrel> Oh, the dialog to rebind them.
20170428 23:17:16< Aginor> but I also think that's a different case from the hotkey creation itself being wrong/broken
20170428 23:17:40< Aginor> the handling of rebound hotkeys and unbinding of hotkeys seems rather wrong
20170428 23:17:49< Aginor> but I am pretty sure that was broken since long
20170428 23:20:51-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 23:20:57-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has joined #wesnoth-dev
20170428 23:30:19< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys 8092b38691ca / src/ (9 files in 3 dirs): Pipe raw SDL events throught the GUI2 event system for hotkeys https://github.com/wesnoth/wesnoth/commit/8092b38691ca7afe94d450010fb155ce0440637d
20170428 23:30:45< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys 92ca7fdb5eb1 / / (6 files in 3 dirs): Fix #24681: Use composed hotkeys where appropriate and revert help to be ':' https://github.com/wesnoth/wesnoth/commit/92ca7fdb5eb11c04b191359892517ea22d9f4491
20170428 23:30:47< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys daef8cd22ca9 / src/ (hotkey/hotkey_item.cpp hotkey/hotkey_item.hpp key.cpp key.hpp): Fix 24681: Proper filtering of modifiers when handling hotkeys https://github.com/wesnoth/wesnoth/commit/daef8cd22ca9ba689a0d5b6db1cbbbdb84285570
20170428 23:30:49< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys c127e6f9d3ab / src/ (9 files in 3 dirs): Pipe raw SDL events throught the GUI2 event system for hotkeys https://github.com/wesnoth/wesnoth/commit/c127e6f9d3abfdbae4bea903608aea715a657c37
20170428 23:31:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170428 23:34:15< Aginor> https://github.com/wesnoth/wesnoth/pull/1003
20170428 23:34:30-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170428 23:37:03< vultraz_iOS> looks good to me :)
20170428 23:37:12< vultraz_iOS> though im curious why you made the 'window' argument 'win
20170428 23:37:24< vultraz_iOS> anyway, as long as it works I have no objections
20170428 23:37:25< Aginor> to make my IDE happy
20170428 23:37:48< Aginor> I thought it was getting confused about having a class and variable overloading the same name
20170428 23:38:15< Aginor> it's like calling your int variable "int" :D
20170428 23:38:19< vultraz_iOS> heh
20170428 23:38:38< celticminstrel> Except that calling your int variable int is a compile error.
20170428 23:38:41< vultraz_iOS> you appear to have reverted the copyright year in hotkey_item.cpp
20170428 23:39:01< Aginor> I must have done that when I reverted your other changes, I'll fix that
20170428 23:39:47< celticminstrel> Why is the indentation changed in dispatcher.hpp...
20170428 23:39:51< vultraz_iOS> ah, good, ckey::is_uncomposable is static.
20170428 23:40:05< irker166> wesnoth: Andreas Löf wesnoth:composed_hotkeys 46f16e1a8af2 / src/ (9 files in 3 dirs): Pipe raw SDL events throught the GUI2 event system for hotkeys https://github.com/wesnoth/wesnoth/commit/46f16e1a8af25f352624edbb6d8f199337d2fc62
20170428 23:40:38< Aginor> celticminstrel: because it was inconsistent within the different functions, so I tried to make it consistent
20170428 23:40:59< vultraz_iOS> yeah, that's good
20170428 23:41:06< celticminstrel> I really don't like the practice of aligning with the opening brace/parenthesis/bracket though... :/
20170428 23:41:13< vultraz_iOS> celticminstrel: we can reformat later
20170428 23:41:42< Aginor> lovely though, GH applies a different tab-width
20170428 23:41:55< vultraz_iOS> Aginor: thanks for going back and working on this
20170428 23:42:10< celticminstrel> I think it's actually useful that GH uses a different tab-width, because it makes indentation errors more obvious.
20170428 23:42:25< Aginor> celticminstrel: spaces would fix it all :D
20170428 23:42:32< celticminstrel> Ugh no.
20170428 23:42:50< vultraz_iOS> no no no no :P
20170428 23:42:52< vultraz_iOS> no space indent
20170428 23:42:58< Aginor> I have religiously followed the formatting of the files though
20170428 23:42:59< celticminstrel> I don't get what is_uncomposable means.
20170428 23:43:15< Aginor> including having to fight the IDE
20170428 23:43:23< Aginor> celticminstrel: it's not composable
20170428 23:43:39< Aginor> a composable event can consist of multiple keypresses
20170428 23:43:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170428 23:44:01< celticminstrel> So what if you want Ctrl+F1?
20170428 23:44:04< Aginor> to write 你好 you would have to press multiple keys
20170428 23:44:08< celticminstrel> Or Alt+Return?
20170428 23:44:13< celticminstrel> Or am I just confused...
20170428 23:44:29< Aginor> you're confused, they are excluded
20170428 23:44:41< celticminstrel> So you can set those as hotkeys if you want?
20170428 23:44:53< Aginor> it's two caracters, but yes
20170428 23:44:56< Aginor> or ö
20170428 23:45:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170428 23:45:27< Aginor> whether it actually would work with the chinese alphabet, I have no idea
20170428 23:45:37< Aginor> and I don't even know how to go about to test it
20170428 23:46:04< Aginor> but it starts to lay down the beginning of proper multi-character composition and proper UTF-8 support
20170428 23:46:18< Aginor> s/UTF-8/unicode input/
20170428 23:46:55< celticminstrel> I don't suppose that includes input methods?
20170428 23:47:20< celticminstrel> I kinda imagine that would be significantly more work.
20170428 23:47:33< celticminstrel> (Thinking of the text input boxes here.)
20170428 23:47:41< Aginor> it taps into some of the stuff that SDL provides
20170428 23:48:02< Aginor> handle TEXT_INPUT events properly for the textboxes and you get most of that for free
20170428 23:48:34-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170428 23:52:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170428 23:54:11< Aginor> and as I said, the actual hotkey preferences screen looks broken, but I think that's outside the scope of my PR
20170428 23:55:10< vultraz_iOS> how is it broken
20170428 23:57:16< Aginor> it doesn't seem to be holding the correct references to the newly created hotkeys
20170428 23:57:26< Aginor> I'd guess there's an off by 1 error somewhere in it
20170428 23:58:07< Aginor> my guess would be that you introduced a bug when you changed it to gui2
20170428 23:59:28< vultraz_iOS> weird...
20170428 23:59:29-!- RatArmy_ [~ratarmy@om126234118053.16.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170428 23:59:40< vultraz_iOS> it appeared to be working with the broken impl
--- Log closed Sat Apr 29 00:00:10 2017