--- Log opened Sun Apr 30 00:00:47 2017
20170430 00:06:28-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 00:09:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 00:09:31-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has joined #wesnoth-dev
20170430 00:25:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 00:37:50-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170430 00:59:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 00:59:26-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170430 00:59:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 01:00:40-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has joined #wesnoth-dev
20170430 01:10:15< gfgtdf> forum is getting spammed
20170430 01:15:31-!- gfgtdf_ [~chatzilla@x4e36a230.dyn.telefonica.de] has joined #wesnoth-dev
20170430 01:18:02-!- gfgtdf [~chatzilla@x4e36a612.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 01:18:12-!- gfgtdf_ is now known as gfgtdf
20170430 01:19:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170430 01:22:43-!- nickanc [5d33ac22@wikimedia/nickanc] has quit []
20170430 01:30:24-!- gfgtdf [~chatzilla@x4e36a230.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170430 01:35:09< celticminstrel> Apparently I can't ban the spambot.
20170430 01:35:52< celticminstrel> And it looks like Pentarctagon can't either (otherwise I assume he'd do that before deleting posts).
20170430 01:36:02< celticminstrel> Isn't it kinda silly if moderators can't ban users?
20170430 01:37:28-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 240 seconds]
20170430 01:38:31-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170430 01:40:11 * celticminstrel tries Soliton?
20170430 01:57:02-!- irker568 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170430 02:06:44-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:10:52-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170430 02:10:57-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170430 02:10:57-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:12:50-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:13:24< celticminstrel> They're still at it...
20170430 02:14:14-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:15:16< celticminstrel> ...what the heck is this about? https://forums.wesnoth.org/viewtopic.php?f=6&t=45207
20170430 02:15:44-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:16:49-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:18:58-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:19:49-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:22:03-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:22:51-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:22:52-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170430 02:24:37-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20170430 02:25:51-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170430 02:25:57-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170430 02:25:58-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170430 02:31:14-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has joined #wesnoth-dev
20170430 02:31:31-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170430 02:31:52-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170430 02:41:55-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170430 02:46:33-!- atarocch [~atarocch@c-24-61-135-102.hsd1.ma.comcast.net] has joined #wesnoth-dev
20170430 02:50:08< vultraz_iOS> celticminstrel: https://github.com/Vultraz/wesnoth/commit/8a88d3c1c9d59a7b7ae2e915cb9b5d590dc4be64 can you see any reason here why the 'message' version of fire basically doesn't work anymore?
20170430 02:50:57< celticminstrel> vultraz_iOS: Can you ban the forum spambots?
20170430 02:51:05< vultraz_iOS> yes
20170430 02:52:48< celticminstrel> For the template parameter pack in dispatcher_private.hpp...
20170430 02:53:05< celticminstrel> Could those types be anything, or just one of a limited set?
20170430 02:53:20< celticminstrel> If the former, you should probably use std::forward.
20170430 02:53:29< vultraz_iOS> I did use forward
20170430 02:53:42< vultraz_iOS> or are you referring to the second case
20170430 02:53:50< celticminstrel> In dispatcher_private.hpp.
20170430 02:54:10< vultraz_iOS> look further down
20170430 02:54:12< celticminstrel> The first case, not the second. I see you did use forward on the second.
20170430 02:54:25< vultraz_iOS> i can't use it on the first tho
20170430 02:54:35< celticminstrel> BTW, IIRC for perfect forwarding you also need to declare it as "F&... params" in the function header.
20170430 02:54:45< celticminstrel> Why not?
20170430 02:55:12< celticminstrel> I see, the third case also ise forward...
20170430 02:55:41< celticminstrel> ^uses
20170430 02:55:55< vultraz_iOS> if i leave the pack as copies, I get: ..\..\src\gui\core\event\dispatcher_private.hpp|429|error: invalid initialization of non-const reference of type 'gui2::event::message&' from an rvalue of type 'gui2::event::message'|
20170430 02:56:24< celticminstrel> What do you mean by "leave the pack as copies"?
20170430 02:56:33< vultraz_iOS> F...
20170430 02:56:39< vultraz_iOS> instead of F&...
20170430 02:56:59< celticminstrel> So you're saying that commit doesn't compile?
20170430 02:57:23< vultraz_iOS> it doesn't compile if I use forward in the first function
20170430 02:57:41< vultraz_iOS> which is the second function the arguments are forwarded to
20170430 02:58:36< vultraz_iOS> that is, if i use forward where forward is not used in that commit yet, I get the above error
20170430 03:01:15< celticminstrel> Well, you also seem to be using forward wrong.
20170430 03:01:24< celticminstrel> I was wrong too though.
20170430 03:01:34< celticminstrel> It should be "F&&... params", not "F&... params".
20170430 03:01:49-!- atarocch [~atarocch@c-24-61-135-102.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20170430 03:02:06< celticminstrel> As to your actual question on the commit, I'm afraid I have no idea from just looking at the code.
20170430 03:02:06< vultraz_iOS> in which function
20170430 03:02:13< Aginor> Always pass by reference unless you have a good reason not to :)
20170430 03:02:17< Aginor> it's way more efficient
20170430 03:02:17< celticminstrel> The ones that use forward.
20170430 03:02:45< celticminstrel> const int& is no more efficient than int though.
20170430 03:02:50< Aginor> no
20170430 03:03:05< Aginor> but const struct <foo> & is much more efficient
20170430 03:03:08< celticminstrel> Yes.
20170430 03:03:14< Aginor> as it'll copy the entire struct otherwise
20170430 03:03:28< Aginor> or class, I think
20170430 03:03:40< vultraz_iOS> true, we don't want to copy an SDL_Event..
20170430 03:03:47< Aginor> or a surface
20170430 03:03:51< Aginor> or a settings object
20170430 03:03:53< Aginor> or a window
20170430 03:03:56< Aginor> or a button
20170430 03:03:59< Aginor> or a sprite
20170430 03:04:14< Aginor> or a rect
20170430 03:04:40< celticminstrel> SDL_Event is a union though, not a struct. Just FTR.
20170430 03:04:56< Aginor> celticminstrel: it still follows the same semantics
20170430 03:04:57< vultraz_iOS> wait!
20170430 03:05:04< vultraz_iOS> oh celticminstrel is a genius 
20170430 03:05:16< celticminstrel> What'd I do now?
20170430 03:05:19< vultraz_iOS> using F&& in both places magically fixes All The Problems O_O
20170430 03:05:30< celticminstrel> What about the third place?
20170430 03:05:37< celticminstrel> http://eli.thegreenplace.net/2014/perfect-forwarding-and-universal-references-in-c/
20170430 03:05:38< vultraz_iOS> both places as in both functions
20170430 03:05:51< celticminstrel> But there are three functions.
20170430 03:06:14< celticminstrel> Line 410,  line 520, and line 540.
20170430 03:06:14< vultraz_iOS> oh yes
20170430 03:06:18< vultraz_iOS> ill use && in all
20170430 03:06:26< celticminstrel> And forward in all too, right?
20170430 03:06:44< vultraz_iOS> forward still doesn't work in the first case
20170430 03:07:04< celticminstrel> I think it might be nicer to write "auto functor = *itor" though.
20170430 03:07:24< celticminstrel> Oh, but I guess you'd have to do that several times, so maybe not that big a gain?
20170430 03:07:36< vultraz_iOS> I'm going to do some cleanup to the file
20170430 03:07:39< vultraz_iOS> after this commit
20170430 03:07:58< celticminstrel> So even if you put F&&... at line 410 you still can't use forward at line 429?
20170430 03:08:30< vultraz_iOS> correct
20170430 03:08:35< celticminstrel> :|
20170430 03:08:39< celticminstrel> What's the error?
20170430 03:08:44< vultraz_iOS> same as above
20170430 03:08:49< vultraz_iOS> non-const ref from rvalue
20170430 03:09:07< celticminstrel> Invalid init of non-const reference from rvalue?
20170430 03:09:14< vultraz_iOS> yes
20170430 03:09:17< celticminstrel> What?
20170430 03:09:51< vultraz_iOS> what what
20170430 03:09:52< celticminstrel> Where does gui::event::message come from?
20170430 03:10:02< celticminstrel> Can you maybe paste the full error message including all the template backtrace?
20170430 03:11:15< vultraz_iOS> the message comes from...
20170430 03:11:20< vultraz_iOS> styled_widget.cpp
20170430 03:11:23< vultraz_iOS> look for...
20170430 03:11:32< vultraz_iOS> fire(event::MESSAGE_SHOW_TOOLTIP
20170430 03:11:39< celticminstrel> IIUC there shouldn't be any rvalues there, even a value declared as an rvalue reference counts as an lvalue...
20170430 03:12:08-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20170430 03:12:32< vultraz_iOS> ya know
20170430 03:12:41< vultraz_iOS> i am wondering why that isn't const message&
20170430 03:12:51< vultraz_iOS> there's no reason to change it once it's created..
20170430 03:12:55< vultraz_iOS> in fact, you wouldn't want to
20170430 03:12:59< celticminstrel> Is that so? Are you sure?
20170430 03:13:16< vultraz_iOS> only change that occurs is a dynamic_cast
20170430 03:14:07< celticminstrel> Well, the line you pointed at does not have an rvalue, so surely it can't be the cause of this error.
20170430 03:14:23< celticminstrel> Oh, unless that string appears more than once.
20170430 03:14:38< celticminstrel> It does, but no rvalue in either place.
20170430 03:14:57< celticminstrel> Ah wait, the second is MESSAGE_SHOW_HELPTIP. Whatever, close enough.
20170430 03:15:08< vultraz_iOS> I still don;t fully understand this rvalue, lvalue, xvalue stuff :/
20170430 03:15:35< vultraz_iOS> I'm assuming r/lvalue refers to position on the right or left of an assignment op, but that's it
20170430 03:15:58< celticminstrel> So, the method is defined on line 174 of dispatcher.cpp...
20170430 03:16:11< celticminstrel> It calls fire_event<signal_message_function>
20170430 03:16:19< celticminstrel> And just passes on the arguments verbatim.
20170430 03:16:57< celticminstrel> Is signal_message_function a type or enum value?
20170430 03:17:05< celticminstrel> I guess it's a type?
20170430 03:17:10< celticminstrel> Maybe it's the MPL set?
20170430 03:17:27< vultraz_iOS> an std::function alias
20170430 03:17:39< celticminstrel> Oh okay.
20170430 03:18:53< celticminstrel> So it should end up calling fire_event<signal_message_function, message&>
20170430 03:19:26< celticminstrel> Because the rules for type deduction when you have "F&&" is that an rvalue is deduced as a non-reference and an lvalue is deduced as a reference.
20170430 03:20:13< celticminstrel> Then that calls implementation::fire_event<signal_message_function, message&>
20170430 03:20:33< celticminstrel> So where the heck is it getting an rvalue from?
20170430 03:20:52< vultraz_iOS> I have no idea
20170430 03:21:15< celticminstrel> Does the definition of signal_message_function specify message&?
20170430 03:21:25< vultraz_iOS> yes
20170430 03:21:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170430 03:21:48< celticminstrel> Okay, try changing line 177 of dispatcher.cpp to explicitly specify the template parameter pack.
20170430 03:21:56< celticminstrel> fire_event<signal_message_function, message&>
20170430 03:23:08< celticminstrel> Oh, hmm, possible alternate workaround might be fire_event<signal_message_function>(event, this, &target, std::ref(msg))
20170430 03:23:22< celticminstrel> Because of reference decay, perhaps msg is being deduced as an rvalue there?
20170430 03:23:26< celticminstrel> I dunno.
20170430 03:23:53< celticminstrel> Just see if either of those works for using forward in implementation::fire_event.
20170430 03:24:23< celticminstrel> And maybe add an explanatory comment about it and wondering if it could be made const.
20170430 03:26:15-!- RatArmy_ [~ratarmy@133.15.175.65] has joined #wesnoth-dev
20170430 03:26:21< vultraz_iOS> do you think I should explicitly specify the pack types for each fire overload?
20170430 03:26:34< vultraz_iOS> since for each they can only be certain ones
20170430 03:27:48< celticminstrel> I'd prefer not explicitly specifying them.
20170430 03:28:32< vultraz_iOS> celticminstrel: std::ref works
20170430 03:28:38< vultraz_iOS> with forwarding in the implementation
20170430 03:29:04< celticminstrel> So I guess it was reference decay...
20170430 03:29:18< vultraz_iOS> should I use that?
20170430 03:29:29< celticminstrel> Sure.
20170430 03:29:39< celticminstrel> I think I prefer it to explicitly specifying the template parameter pack.
20170430 03:31:20< vultraz_iOS> +13 -153 *feels good*
20170430 03:32:10< celticminstrel> Double-clicked titlebar and Wesnoth crashed.
20170430 03:32:18< vultraz_iOS> whut
20170430 03:32:31< celticminstrel> IIRC that means maximize?
20170430 03:32:54< celticminstrel> I was in the map editor, in case that's relevant.
20170430 03:32:54< vultraz_iOS> uhhh...
20170430 03:33:02< celticminstrel> With the location palette active.
20170430 03:33:06< vultraz_iOS> depends if you're maximized or not
20170430 03:41:54-!- irker484 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170430 03:41:54< irker484> wesnoth: Charles Dang wesnoth:master f095ada2f541 / src/gui/core/event/ (dispatcher.cpp dispatcher_private.hpp): GUI2: refactor dispatcher to remove need for helper structs in fire() https://github.com/wesnoth/wesnoth/commit/f095ada2f54117e42996e2eab0e0516a3cff85a6
20170430 03:41:55< irker484> wesnoth: Charles Dang wesnoth:master c25b0097f87b / src/gui/core/event/dispatcher_private.hpp: GUI2/dispatcher: simplified fire_event implementation with range-for https://github.com/wesnoth/wesnoth/commit/c25b0097f87b9c0f788689c457c7b53a52a69bd5
20170430 03:41:56< irker484> wesnoth: Charles Dang wesnoth:master 6eab63a71d37 / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/6eab63a71d370e7967b71b0ec739b8b4bd9efbde
20170430 03:53:30< celticminstrel> vultraz_iOS: Decided yet whether to add the cutscene theme to mainline?
20170430 03:53:38< vultraz_iOS> we probably should
20170430 03:54:37-!- RatArmy_ [~ratarmy@133.15.175.65] has quit [Ping timeout: 246 seconds]
20170430 03:55:19-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has joined #wesnoth-dev
20170430 03:55:19-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170430 03:59:02< celticminstrel> Then, do it? :P
20170430 04:06:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170430 04:07:37< irker484> wesnoth: Charles Dang wesnoth:master 627d4f825f9e / src/gui/core/event/dispatcher_private.hpp: Fixup c25b009 (use reference in pre-child loop) https://github.com/wesnoth/wesnoth/commit/627d4f825f9ef5d8010773dfbb775ea63765f362
20170430 04:07:40< irker484> wesnoth: Charles Dang wesnoth:master 7e84348ace63 / src/gui/core/event/ (dispatcher.cpp dispatcher_private.hpp): GUI2: bunch of formatting cleanup to the dispatcher https://github.com/wesnoth/wesnoth/commit/7e84348ace6323721c5ca1029f0bb64a3f3e5a64
20170430 04:08:40-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has joined #wesnoth-dev
20170430 05:06:43< vultraz_iOS> hmmm
20170430 05:06:48< vultraz_iOS> why is the editor still crashing..
20170430 05:07:17< celticminstrel> It's crashing?
20170430 05:07:40< vultraz_iOS> the close map thing
20170430 05:07:43< vultraz_iOS> hmm
20170430 05:07:49< celticminstrel> What?
20170430 05:08:00< celticminstrel> It crashes when you close a map?
20170430 05:08:04< vultraz_iOS> actually, I guess a pointer doesn't get reset to nullptr if it's pointing to something in an object that gets destroyed
20170430 05:08:11< celticminstrel> That's correct.
20170430 05:08:16< celticminstrel> Only smart pointers do that.
20170430 05:08:33< celticminstrel> Is the object owned by a smart pointer?
20170430 05:08:52< vultraz_iOS> the object is but the ptr is external and points to the object owned by the smart ptr
20170430 05:09:02< celticminstrel> Sorry, what?
20170430 05:09:33< celticminstrel> Is it something like you have a struct A {int b;} and a smart_ptr<A> and then you return a pointer to b?
20170430 05:09:40< vultraz_iOS> the editor has this: static map_labels* current_labels;
20170430 05:09:53< celticminstrel> What kind of static?
20170430 05:09:55< vultraz_iOS> current_labels points to the labels of the current map context, which is a unique_ptr
20170430 05:09:59< vultraz_iOS> file static
20170430 05:10:09< celticminstrel> Okay, so there's a unique_ptr<map_context>
20170430 05:10:20< celticminstrel> And map_context contains map_labels.
20170430 05:10:31< vultraz_iOS> I'm guessing current_labels is not actually reset to nullptr when the map context is destroyed
20170430 05:10:37< vultraz_iOS> since it
20170430 05:10:41< vultraz_iOS> 's raw
20170430 05:10:48< celticminstrel> Yes, that would be accurate.
20170430 05:11:09< celticminstrel> But you shouldn't store a raw pointer to something (or part of something) owned by a smart pointer...
20170430 05:11:52< celticminstrel> So basically, you have a unique_ptr<map_context> and the map_context contains a map_labels element?
20170430 05:12:16< vultraz_iOS> yes
20170430 05:12:20< vultraz_iOS> the refresher uses 
20170430 05:12:22< vultraz_iOS> current_labels = &context_manager_.get_map_context().get_labels();
20170430 05:12:24< celticminstrel> Do you know why it's unique_ptr and not shared_ptr?
20170430 05:12:27< vultraz_iOS> to 'reset' the pointer
20170430 05:12:44< vultraz_iOS> because there's no reason for it to be a shared_ptr
20170430 05:12:53< celticminstrel> Well, you've just given one though.
20170430 05:13:17< vultraz_iOS> but that's not a ptr to the map_context
20170430 05:13:17< celticminstrel> If you're storing a pointer to a portion of it, that's a reason for it to be a shared_ptr.
20170430 05:13:23< vultraz_iOS> oh
20170430 05:13:52< celticminstrel> Apparently reset doesn't have an aliasing form...?
20170430 05:14:28< vultraz_iOS> i wonder if this variable is needed at all
20170430 05:14:30< vultraz_iOS> let us see
20170430 05:14:57< vultraz_iOS> not...really :/
20170430 05:15:02< celticminstrel> Oh?
20170430 05:15:28< celticminstrel> So does that mean that context_manager_ is accessible everywhere it's used?
20170430 05:15:59< vultraz_iOS> seems so
20170430 05:16:19< celticminstrel> Anyway, if removing the variable were not an option, what I'd recommend is changing the map_context to a shared_ptr, and using the aliasing constructor to assign to the variable.
20170430 05:16:19< vultraz_iOS> celticminstrel: OT for a sec - you implemented changing theme mid scenario via Prefs - did you add an action for it?
20170430 05:16:26< celticminstrel> I did.
20170430 05:16:32< celticminstrel> IIRC it was [change_theme]
20170430 05:16:50< celticminstrel> The aliasing constructor is for when you have an object managed by a shared_ptr and you want to store a pointer to a portion of it.
20170430 05:17:03< celticminstrel> #8 on this list http://en.cppreference.com/w/cpp/memory/shared_ptr/shared_ptr
20170430 05:17:44< celticminstrel> (It can also link an unrelated pointer to the lifetime of the object, if for some reason you wanted to do that.)
20170430 05:17:47< vultraz_iOS> hmmmm
20170430 05:18:02< celticminstrel> But if you think removing the variable is better, go ahead.
20170430 05:18:38< vultraz_iOS> celticminstrel: OT again - can you add the ability to invoke the storyscreen mid scenario (obv one would need the ability to set the story data)
20170430 05:18:49< vultraz_iOS> should be relatively simple since right now the story is just auto-invoked at the start
20170430 05:18:52< celticminstrel> I don't get your "obv" line here.
20170430 05:19:22< celticminstrel> I'd assume what you want would be as easy as it was for me to add the ability to invoke the popup menu or the transient message.
20170430 05:19:39< vultraz_iOS> probably
20170430 05:19:48< vultraz_iOS> but again, we don't want to just re-show the story
20170430 05:19:55< vultraz_iOS> one needs to be able to set new story to show
20170430 05:19:59< celticminstrel> Um.
20170430 05:20:08< celticminstrel> So just pass a different config to the storyscreen?
20170430 05:20:13< celticminstrel> That should be obvious, right?
20170430 05:20:29< celticminstrel> Or a different config-range, possibly, so that you can use child_range.
20170430 05:20:41< vultraz_iOS> oh, so you would allow [story] within [show_story] or something?
20170430 05:20:52< celticminstrel> ...how else would you do it?
20170430 05:20:55< vultraz_iOS> or whatabout allowing [story] id= at toplevel
20170430 05:21:14< celticminstrel> I think the way I was assuming was just using [story] as an action.
20170430 05:21:40< vultraz_iOS> oh, that's good, actuslly
20170430 05:22:07< vultraz_iOS> any toplevel [story] wil be shown at start and anything in an event will show when invoked
20170430 05:22:28< celticminstrel> Where does the storyscreen controller come from?
20170430 05:22:50< celticminstrel> Shouldn't it be owned by story_viewer rather than being passed in?
20170430 05:23:03< celticminstrel> Is it just a local variable?
20170430 05:25:30< celticminstrel> Okay, yeah, the storyscreen controller should probably be a member of the story_viewer dialog, rather than being passed as a parameter.
20170430 05:26:10< celticminstrel> In fact, you might as well delete storyscreen/interface.?pp
20170430 05:26:30< celticminstrel> Since they have pretty much nothing useful left in them. If the enum is still needed it could be moved elsewhere.
20170430 05:27:37< celticminstrel> So the arguments to the story_viewer constructor would become (CVideo& video, const std::string& scenario_name, const config::const_child_itors& story)
20170430 05:28:02< celticminstrel> And show_story would be replaced with gui2::story_viewer::show or whatever.
20170430 05:29:02< vultraz_iOS> feel free to do all of that
20170430 05:29:28< celticminstrel> I'm on a branch right now, but I might do it later.
20170430 05:29:35< vultraz_iOS> i left it passed in for compatibility with the gui1 dialog
20170430 05:29:50< celticminstrel> Well, that makes sense when the GUI1 dialog still exists.
20170430 05:29:53< celticminstrel> But now, it doesn't.
20170430 05:30:55< celticminstrel> I mentioned all that because I thought you wanted to add [story] as ActionWML.
20170430 05:31:33< vultraz_iOS> actually, ill do it right now
20170430 05:31:43< celticminstrel> Sure.
20170430 05:33:35< vultraz_iOS> heh, the dialog already owns the controller
20170430 05:33:44< celticminstrel> No?
20170430 05:34:22< vultraz_iOS> it doesn't have a reference
20170430 05:34:26< vultraz_iOS> it copies it
20170430 05:34:31< celticminstrel> As for how to add storyscreen to Lua, probably something like this: https://github.com/wesnoth/wesnoth/commit/376020097fbce1409d59838437c7510736038b88#diff-29c54921f2ea3d551910d2fc3ab7df20R298
20170430 05:34:34< celticminstrel> Oh. Heh.
20170430 05:35:10< celticminstrel> Though I'm not sure if that one should be in lua_kernel_base like the others.
20170430 05:35:32< celticminstrel> Then again, it's not like it would hurt for it to be there?
20170430 05:35:36< celticminstrel> I think?
20170430 05:48:13< vultraz_iOS> ok, done
20170430 05:48:24< vultraz_iOS> now to deal with the editor thing...
20170430 05:48:26< irker484> wesnoth: Charles Dang wesnoth:master 47d77c79d4fc / / (7 files in 5 dirs): Story Viewer: delegate storyscreen controller creation to dialog https://github.com/wesnoth/wesnoth/commit/47d77c79d4fc2427ee4cd161d357142fe785b08e
20170430 05:48:58< vultraz_iOS> looks like the label ptr IS accessible outside the file
20170430 05:48:59< vultraz_iOS> gah
20170430 05:50:08< vultraz_iOS> ah, but..
20170430 05:58:31< celticminstrel> What?
20170430 05:58:34< vultraz_iOS> got it
20170430 05:58:44< vultraz_iOS> or, well...
20170430 05:58:45< vultraz_iOS> hmm
20170430 05:58:58< vultraz_iOS> ah wait
20170430 05:59:05< vultraz_iOS> yes
20170430 06:04:39< vultraz_iOS> this is rather bad design..
20170430 06:05:00< vultraz_iOS> the ptr is allows static access to the current context's labels without a controller object..
20170430 06:05:06-!- Kwandulin [~Kwandulin@p200300760F6D80DFC912DB11B98971C7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170430 06:06:39< vultraz_iOS> how to fix this...
20170430 06:06:56< vultraz_iOS> or perhaps I should use the shared_ptr method
20170430 06:07:49< vultraz_iOS> or a hacky simple fix would be to manually set the ptr to nullptr when closing the context
20170430 06:08:51< vultraz_iOS> yeah actually the shared_ptr method won't work...
20170430 06:10:27< vultraz_iOS> i'd need to make sure it was reset first
20170430 06:11:19< vultraz_iOS> but the refresher isn't always meant to refresh first
20170430 06:11:27< vultraz_iOS> in fact, it's... not meant to do that at all, I think...
20170430 06:26:47< celticminstrel> Which file is this in?
20170430 06:27:53< vultraz_iOS> celticminstrel: editor/map/context_manager
20170430 06:28:33< vultraz_iOS> the point of its presence in the resetter is to hide the previous context's labels since map labels are dumb a'f
20170430 06:29:04< celticminstrel> Ahh, I see why you said it's visible outside the file.
20170430 06:29:07< celticminstrel> Didn't expect that.
20170430 06:29:24< celticminstrel> Can get_current_labels() be moved into the context_manager_class, maybe?
20170430 06:30:51< celticminstrel> It seems to me that the direct uses of current_labels in that file are easily replaced with the call get_map_context().get_labels()
20170430 06:30:52< vultraz_iOS> but then a context manager would be needed
20170430 06:30:59< vultraz_iOS> oh?
20170430 06:32:04< celticminstrel> The function is called only from mouse_action_map_label.cpp
20170430 06:32:27< celticminstrel> When I say "easy", I don't necessarily mean it's as simple as just replacing references to current_labels with that expression, though.
20170430 06:33:59< celticminstrel> The enable(false) call would have to come before current_context_index is changed, while enable(true) comes after.
20170430 06:34:45< irker484> wesnoth: Charles Dang wesnoth:master 47177dfd62a6 / src/ (gui/dialogs/story_viewer.hpp storyscreen/controller.hpp): Fixup 47d77c7 https://github.com/wesnoth/wesnoth/commit/47177dfd62a6b529a318e5ab867e52cc7996fa13
20170430 06:35:03< celticminstrel> Which might be difficult.
20170430 06:36:02< celticminstrel> You know, I really don't understand why this is static/global instead of part of the context manager.
20170430 06:36:18< vultraz_iOS> because there was no way at that point to get the controller
20170430 06:36:23< vultraz_iOS> but now there is
20170430 06:36:24< vultraz_iOS> sec..
20170430 06:36:57< celticminstrel> Well, the if(current_labels) check is useless.
20170430 06:37:19< vultraz_iOS> yes
20170430 06:38:11< celticminstrel> Ooookay, what about moving the enable(false) to the map_context_refresher constructor?
20170430 06:38:59< vultraz_iOS> hang on hang on
20170430 06:39:08< celticminstrel> Also, TBH, there's no reason to have the refresh function, that could easily just all be in the destructor, since refresh is never called directly?
20170430 06:39:26< vultraz_iOS> haaaannngggg onnnn
20170430 06:46:29< irker484> wesnoth: Charles Dang wesnoth:master de5dcb2771c9 / src/editor/editor_display.hpp: Editor Display: added getter for parent controller https://github.com/wesnoth/wesnoth/commit/de5dcb2771c9916dfb402af4e16d5f4129f78623
20170430 06:46:32< irker484> wesnoth: Charles Dang wesnoth:master 309f708c7bb8 / src/editor/ (3 files in 2 dirs): Editor: remove global get_current_labels function https://github.com/wesnoth/wesnoth/commit/309f708c7bb84f2c298be28f5b03f9e0f085ff69
20170430 06:46:33< vultraz_iOS> celticminstrel: ^
20170430 06:49:04< celticminstrel> Well, it's long, but whatever.
20170430 06:49:17< celticminstrel> Who the heck named that variable? "last_draged"
20170430 06:49:30< vultraz_iOS> fabi probabbly 
20170430 06:49:37< vultraz_iOS> probably 
20170430 06:57:32< irker484> wesnoth: Charles Dang wesnoth:master a42d418bee57 / src/editor/map/context_manager.cpp: Editor: refactored global labels handling to avoid static pointer to context int https://github.com/wesnoth/wesnoth/commit/a42d418bee574a76154c49881e52d4247b906d56
20170430 06:57:35< irker484> wesnoth: Charles Dang wesnoth:master 9c222772c042 / src/editor/action/mouse/mouse_action_map_label.cpp: Editor: fixed label color settings not being respected https://github.com/wesnoth/wesnoth/commit/9c222772c042b826eecf3a0a139d5b5532e68ddc
20170430 06:57:41< vultraz_iOS> celticminstrel: ^
20170430 06:57:57< celticminstrel> "should"
20170430 06:58:00< celticminstrel> Didn't you test it?
20170430 06:58:05< vultraz_iOS> of course
20170430 06:59:03< celticminstrel> Should probably investigate whether enable(false) is also needed in replace_map_context_with.
20170430 07:00:09< vultraz_iOS> hmmm
20170430 07:00:42< vultraz_iOS> celticminstrel: I said "should" since I don't get the crash myself
20170430 07:01:02< vultraz_iOS> so I tested it works, but I can't say if it fixes the crash
20170430 07:03:23< vultraz_iOS> im not sure if it's needed there
20170430 07:03:41< vultraz_iOS> probably not
20170430 07:03:48< vultraz_iOS> since it destroys a context
20170430 07:03:55< vultraz_iOS> and doing so gets rid of its labels
20170430 07:06:55< celticminstrel> It does? Okay then.
20170430 07:09:35< celticminstrel> Do you know how to invoke it? Maybe you can test it?
20170430 07:09:49< celticminstrel> Of course, making sure both contexts have labels.
20170430 07:10:23< celticminstrel> IIUC, you'll see the labels of both if it's wrong.
20170430 07:10:34< celticminstrel> So it should be pretty obvious. P
20170430 07:10:36< celticminstrel> ^ :P
20170430 07:10:47< vultraz_iOS> how to invoke what?
20170430 07:10:53< vultraz_iOS> the replace context thing?
20170430 07:10:59< celticminstrel> replace_map_context_with
20170430 07:11:51< vultraz_iOS> no idea
20170430 07:11:55< vultraz_iOS> without editing the code
20170430 07:12:03< vultraz_iOS> invert if(new_context)
20170430 07:12:05< vultraz_iOS> in a few places
20170430 07:12:17< celticminstrel> What's new_context?
20170430 07:12:22< vultraz_iOS> flag
20170430 07:12:28< vultraz_iOS> to create a new context 
20170430 07:12:29< vultraz_iOS> :P
20170430 07:12:30< irker484> wesnoth: Charles Dang wesnoth:master 6051c48852a0 / src/hotkey/hotkey_item.cpp: Removed a useless variable in hortkey::bindings_equal https://github.com/wesnoth/wesnoth/commit/6051c48852a077c3bac53c45d7702abf79c1b102
20170430 07:12:32< celticminstrel> ...?
20170430 07:12:33< vultraz_iOS> it's used in a few functions
20170430 07:12:36< vultraz_iOS> just
20170430 07:12:38< vultraz_iOS> look in the file
20170430 07:20:43< vultraz_iOS> I think https://gna.org/bugs/index.php?25683 is a bug with the hotkey code..
20170430 07:23:27< vultraz_iOS> or...
20170430 07:23:28< vultraz_iOS> hmm
20170430 07:27:16< irker484> wesnoth: Charles Dang wesnoth:master 7e1caca082dc / src/gui/dialogs/preferences_dialog.cpp: Attempt to fix spurious error when assigning the same hptkey multiple times (bug https://github.com/wesnoth/wesnoth/commit/7e1caca082dca2930a55deebe4e2a89349ff06af
20170430 07:27:17-!- RatArmy_ [~ratarmy@om126200120136.15.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20170430 07:27:23< vultraz_iOS> probably the wrong fix
20170430 07:34:45< celticminstrel> NIce typo.
20170430 07:35:16< celticminstrel> vultraz_iOS: With that fix, can you still assign hotkeys to WML commands?
20170430 07:35:56< vultraz_iOS> eh?
20170430 07:36:09< celticminstrel> I thought it was a pretty clear question.
20170430 07:37:05< vultraz_iOS> i didn't know you could assign hotkeys to wml commands
20170430 07:37:33< celticminstrel> ...
20170430 07:38:04< vultraz_iOS> but yes
20170430 07:38:20< celticminstrel> Ah, looking at hotkey_item.hpp, it looks like my worries were probably baseless.
20170430 07:38:34< vultraz_iOS> though that does remind me of a bug
20170430 07:38:40< vultraz_iOS> and im not sure if it was ever fixed
20170430 07:38:44< celticminstrel> Seems like hotkey_item represents the key, not the action?
20170430 07:38:47< vultraz_iOS> if you specify a hotkey for an item from wml
20170430 07:38:52< vultraz_iOS> an reload
20170430 07:38:54< vultraz_iOS> it disappears
20170430 07:39:01< vultraz_iOS> it was in 1.12, did we fix that in 1.13?
20170430 07:39:04< celticminstrel> Or hotykey_base rather.
20170430 07:39:20< celticminstrel> I thought you said you didn't know you could assign hotkeys to WML commands.
20170430 07:39:29< celticminstrel> Now you're saying you did know?
20170430 07:39:38< vultraz_iOS> via the interface
20170430 07:39:38< celticminstrel> I have no idea if it was fixed.
20170430 07:39:41< vultraz_iOS> i knew you could in WML
20170430 07:39:43< celticminstrel> Seems like it would be eassy to fix.
20170430 07:39:51< celticminstrel> Eh?
20170430 07:40:10< celticminstrel> Wait, you're saying that if you specify a default hotkey for the WML command, it disappears when you reload?
20170430 07:40:39< vultraz_iOS> that was the bug, yes
20170430 07:40:56< celticminstrel> Oh.
20170430 07:41:16< celticminstrel> Well, if I were to hazard a guess, I'd say it's probably an issue in persistence of menu-items.
20170430 07:42:31< vultraz_iOS> ah, ut's fixed
20170430 07:42:50< celticminstrel> Oh, good.
20170430 07:43:03< celticminstrel> BTW, if you set a hotkey for a WML command in prefs, does that persist?
20170430 07:43:30< vultraz_iOS> didnt test
20170430 07:43:50< celticminstrel> Seems like it'd be hard to make that work just right.
20170430 07:44:28< celticminstrel> If two WML menu irems in different scenarios have the same ID, should they share a hotkey too?
20170430 07:46:13< celticminstrel> I'm kinda thinking most of the UNIT macros should be deprecated.
20170430 07:47:29< celticminstrel> But regardless, there's room for more that use location IDs instead of x,y.
20170430 07:47:44< celticminstrel> Speaking of which, "placement" is way too overloaded now.
20170430 07:49:55< celticminstrel> If you ask me, placement should be only a comma-separated list of one or more of: map, leader, recall.
20170430 07:50:10< celticminstrel> overwrite and passable should be separate flags.
20170430 07:50:48< celticminstrel> Placement at a location ID should be a separate key that has the same effect as specofying x,y (so that it works with placement=map).
20170430 07:51:12< celticminstrel> At least the last one can just be removed.
20170430 07:54:14< celticminstrel> ...hey. Does placement=leader_passable actually work? It looks to me like it doesn't.
20170430 07:54:29< celticminstrel> Or maybe it works in [side][unit] but not in [event][unit].
20170430 07:54:49< celticminstrel> Oh, wait. I see.
20170430 07:55:07< celticminstrel> I got confused, never mind then.
20170430 08:02:07< matthiaskrgr> vultraz_iOS: #25680 looks fixed now   \o/
20170430 08:07:06< celticminstrel> Aaaand I just went and wrote the code for what I described in [unit]. >_>
20170430 08:07:15< celticminstrel> Maybe I'll commit it when I switch back to master.
20170430 08:07:51< celticminstrel> Considering at= and location_id= for specifying a named location.
20170430 08:08:08< celticminstrel> But slightly leaning to the latter since that makes it the same as in SLF (or SUF too maybe?)
20170430 08:09:13< celticminstrel> But I wonder if there are other sensible placement options besides leader, map, and recall...
20170430 08:10:42< celticminstrel> Well, I suppose you generally wouldn't want to place something on the leader with overwrite=yes... but on the other hand, there's not really a reason to disallow it either.
20170430 08:15:41< celticminstrel> XD The FormulaAI wiki page still makes it sound like Python AI is available.
20170430 08:16:30< celticminstrel> Speaking of FormulaAI, is there some way to enforce that a script doesn't change Lua variables?
20170430 08:16:46< celticminstrel> Except for local variables in the current function.
20170430 08:30:03-!- RatArmy_ [~ratarmy@om126161120078.8.openmobile.ne.jp] has joined #wesnoth-dev
20170430 08:43:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170430 08:53:08-!- JyrkiVesterinen [~JyrkiVest@87-100-223-30.bb.dnainternet.fi] has joined #wesnoth-dev
20170430 08:58:14-!- celticminstrel is now known as celmin|sleep
20170430 09:03:52< JyrkiVesterinen> gfgtdf: I added "wesnoth/Developers" GitHub team to the AppVeyor team.
20170430 09:04:23< JyrkiVesterinen> You should now be able to trigger new builds and configure AppVeyor when you log in to AppVeyor with your GitHub account.
20170430 09:42:51< irker484> wesnoth: Charles Dang wesnoth:master b5168508dece / src/gui/dialogs/campaign_selection.cpp: Campaign Dialog: fixed mods menu not reflecting already toggled mods https://github.com/wesnoth/wesnoth/commit/b5168508dece823cf81cb70540e94d62292d8a7d
20170430 09:53:14< irker484> wesnoth: Charles Dang wesnoth:master 43b80235069d / src/storyscreen/controller.hpp: Attempt to fix Mac build https://github.com/wesnoth/wesnoth/commit/43b80235069d781e023997ef7c3d15c0684785c4
20170430 09:53:49< irker484> wesnoth: gfgtdf wesnoth:master 28585785040e / .travis.yml: remove 'allow_failures' from c++14 build https://github.com/wesnoth/wesnoth/commit/28585785040ed2cc94cb74d1e63931908d2e3030
20170430 09:57:39< irker484> wesnoth: Jyrki Vesterinen wesnoth:master 076c47cd3e1e / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/076c47cd3e1eb96c7297c5e676d083bf9fdc95fe
20170430 10:07:57< irker484> wesnoth: Jyrki Vesterinen wesnoth:master 804c7d604511 / src/gui/core/event/ (dispatcher.cpp message.hpp): Make gui2::event::message noncopyable https://github.com/wesnoth/wesnoth/commit/804c7d604511907c76b4651049b7d7902ad653a4
20170430 10:16:20< irker484> wesnoth: Charles Dang wesnoth:master b0f91e7d2e5d / / (8 files in 5 dirs): GUI2: removed unused Campaign Settings dialog https://github.com/wesnoth/wesnoth/commit/b0f91e7d2e5dfca72fc22828cbb63f8b00e2043d
20170430 10:20:00< irker484> wesnoth: Jyrki Vesterinen wesnoth:master eeeb54c2ffe9 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/eeeb54c2ffe9fbf599e618b4382d85a0a1aedeec
20170430 10:26:02-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20170430 10:27:27-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170430 10:28:37< irker484> wesnoth: Charles Dang wesnoth:master 4d23e8359eda / data/gui/ (macros/custom_options_tree.cfg window/sp_options_configure.cfg): SP Options Configure: hide option tree toggle for this dialog https://github.com/wesnoth/wesnoth/commit/4d23e8359eda6f0c23cc2fc764cc28249fc030dc
20170430 10:40:09-!- JyrkiVesterinen [~JyrkiVest@87-100-223-30.bb.dnainternet.fi] has quit [Quit: .]
20170430 11:05:33-!- Kwandulin [~Kwandulin@p200300760F6D80DFC912DB11B98971C7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170430 11:09:51< irker484> wesnoth: Wedge009 wesnoth:master 5b6860ec65e9 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Add missing Release build option for VC project files. https://github.com/wesnoth/wesnoth/commit/5b6860ec65e9dbb7232539310a3189afb640ea21
20170430 11:17:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 11:45:13-!- Kwandulin [~Kwandulin@p200300760F6D80DFC912DB11B98971C7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170430 11:53:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170430 11:57:10-!- JyrkiVesterinen [~jyrki@87-100-223-30.bb.dnainternet.fi] has joined #wesnoth-dev
20170430 12:00:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 12:01:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 12:21:42-!- atarocch [~atarocch@c-24-61-135-102.hsd1.ma.comcast.net] has joined #wesnoth-dev
20170430 12:23:23-!- Kwandulin [~Kwandulin@p200300760F6D80DFC912DB11B98971C7.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
20170430 12:26:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 12:26:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 12:49:28< irker484> wesnoth: Charles Dang wesnoth:master 7d9b3f44ad87 / src/ (4 files in 3 dirs): Editor Generate Map: hold reference to generator vector instead of copying https://github.com/wesnoth/wesnoth/commit/7d9b3f44ad8763dc1dd9de578ebdbef8a93e4564
20170430 12:49:31< irker484> wesnoth: Charles Dang wesnoth:master e0f3ce428d70 / src/ (7 files in 7 dirs): Cleaned up unnecessary uses of get()-> https://github.com/wesnoth/wesnoth/commit/e0f3ce428d7008c0be0e48585745e77e2fae4865
20170430 13:05:05-!- RatArmy_ [~ratarmy@om126161120078.8.openmobile.ne.jp] has quit [Ping timeout: 240 seconds]
20170430 13:07:45-!- atarocch [~atarocch@c-24-61-135-102.hsd1.ma.comcast.net] has quit [Remote host closed the connection]
20170430 13:09:41-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170430 13:21:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 13:22:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 13:43:57-!- gfgtdf [~chatzilla@x4e36a230.dyn.telefonica.de] has joined #wesnoth-dev
20170430 13:44:00< gfgtdf> JyrkiVesterinen: ok thx i'll try
20170430 13:51:04-!- JyrkiVesterinen [~jyrki@87-100-223-30.bb.dnainternet.fi] has quit [Quit: Rebooting]
20170430 13:53:30-!- JyrkiVesterinen [~JyrkiVest@87-100-223-30.bb.dnainternet.fi] has joined #wesnoth-dev
20170430 14:10:59-!- Kwandulin [~Kwandulin@p200300760F6D800D1C06FDF04D39EC80.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170430 14:15:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 14:15:32< irker484> wesnoth: mattsc wesnoth:master ad4a65c8efb5 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/ad4a65c8efb55aeb7eac297a4a1610eb3666c5ff
20170430 14:15:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 15:07:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 15:08:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 15:27:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170430 15:27:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 15:42:56-!- celmin|sleep is now known as celticminstrel
20170430 16:01:33-!- gfgtdf_ [~chatzilla@x4e36a230.dyn.telefonica.de] has joined #wesnoth-dev
20170430 16:03:31-!- gfgtdf [~chatzilla@x4e36a230.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 16:03:43-!- gfgtdf_ is now known as gfgtdf
20170430 16:15:51-!- gfgtdf [~chatzilla@x4e36a230.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170430 16:26:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 16:27:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 16:44:41-!- Kwandulin [~Kwandulin@p200300760F6D800D1C06FDF04D39EC80.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170430 17:06:39-!- Kwandulin [~Kwandulin@p200300760F6D800DD16E43E4BC2ADC9F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170430 17:07:12< zookeeper> humm. weird. these two produce slightly different results in the way the tentacle and the ripple are overlayed:
20170430 17:07:17< zookeeper> image="misc/blank-hex.png~SCALE(110,100)~BLIT(halo/ripples/ripple10.png,19,19)~BLIT(units/monsters/deep-tentacle.png,19,0)~CROP(19,0,72,72)"
20170430 17:07:17< zookeeper> image="units/monsters/deep-tentacle.png~O(0)~BLIT(halo/ripples/ripple10.png~CROP(0,0,72,53),0,19)~BLIT(units/monsters/deep-tentacle.png,0,0)"
20170430 17:07:50-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170430 17:08:28< zookeeper> both result in a 72x72 image where the ripple is blitted first onto a transparent background, then the tentacle is blitted on top of that. but there's a difference in how the blending ends up happening.
20170430 17:10:01< celticminstrel> Weird. Maybe the colour channels in the second example aren't properly ignored?
20170430 17:10:28< zookeeper> possibly. i'll check...
20170430 17:10:49< celticminstrel> I wonder if Vultraz deciding to use surface alpha is related to this.
20170430 17:13:11< zookeeper> no, that wasn't it... i tried the first example but with blank-hex.png being the tentacle sprite (but with 0 alpha obviously), and the result was the same as with an unmodified blank-hex.png.
20170430 17:14:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170430 17:14:43< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release mattsc ad4a65c: Update Xcode project Failed
20170430 17:14:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-322
20170430 17:14:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170430 17:15:13< zookeeper> also, the ripple is drawn much fainter than it should
20170430 17:16:01-!- irker484 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170430 17:16:51< celticminstrel> Suddenly failure.
20170430 17:17:39-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170430 17:17:39< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug mattsc ad4a65c: Update Xcode project Failed
20170430 17:17:39< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-322
20170430 17:17:43-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170430 17:18:06< celticminstrel> I guess one of Vultraz's most recent commits.
20170430 17:28:11-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 255 seconds]
20170430 17:31:16-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170430 18:09:17-!- gfgtdf [~chatzilla@x50abdd20.dyn.telefonica.de] has joined #wesnoth-dev
20170430 18:10:14< gfgtdf> wedge009: maybe you could add the string_view to the aquileia/external repo? i thought about doing it manually but it seems like they are somehow automatically gnerated.
20170430 18:17:51-!- gfgtdf_ [~chatzilla@x4e363f02.dyn.telefonica.de] has joined #wesnoth-dev
20170430 18:18:41-!- gfgtdf [~chatzilla@x50abdd20.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170430 18:18:46-!- gfgtdf_ is now known as gfgtdf
20170430 18:21:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170430 18:36:06-!- irker143 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170430 18:36:06< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt e23e965933e9 / src/credentials.cpp: Address further feedback from Jyrki https://github.com/wesnoth/wesnoth/commit/e23e965933e9e5cc2981043c0958fa127d64556a
20170430 18:36:08< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt c218ad377a18 / src/credentials.cpp: Fix loading https://github.com/wesnoth/wesnoth/commit/c218ad377a1875b01da40f705415dcd3da8b28bb
20170430 18:36:10< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 522eacd18ac1 / src/credentials.cpp: Reduce indentation level https://github.com/wesnoth/wesnoth/commit/522eacd18ac13b18d3dceef0f3f216a17f18bcee
20170430 18:36:12< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 6bf36c984f5a / utils/travis/install_deps.sh: Add cryptopp to Travis, to test if it's available there https://github.com/wesnoth/wesnoth/commit/6bf36c984f5a3cd6711df7cdc153274c40fa61fb
20170430 18:58:31-!- gfgtdf [~chatzilla@x4e363f02.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170430 19:02:54-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Quit: Leaving]
20170430 19:05:49-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170430 19:16:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 19:25:56-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 19:35:09-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 19:36:12-!- gfgtdf [~chatzilla@x4e32b420.dyn.telefonica.de] has joined #wesnoth-dev
20170430 19:37:32-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 19:37:32-!- horrowind1 is now known as horrowind
20170430 19:46:49-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 19:49:16-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 19:49:17-!- horrowind1 is now known as horrowind
20170430 19:56:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 19:56:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 20:01:00-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 20:02:44-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 20:02:44-!- horrowind1 is now known as horrowind
20170430 20:18:12-!- horrowind1 [~Thunderbi@85.180.171.188] has joined #wesnoth-dev
20170430 20:19:27-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170430 20:19:27-!- horrowind1 is now known as horrowind
20170430 20:32:05-!- gfgtdf [~chatzilla@x4e32b420.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170430 20:38:02-!- atarocch [~atarocch@ip-64-134-98-13.public.wayport.net] has joined #wesnoth-dev
20170430 20:48:24-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 20:50:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170430 20:50:40-!- horrowind [~Thunderbi@85.180.171.188] has quit [Ping timeout: 240 seconds]
20170430 20:50:41-!- horrowind1 is now known as horrowind
20170430 20:51:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170430 20:54:39-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170430 20:59:30< vultraz_iOS> why are the tests broken :/
20170430 20:59:45< vultraz_iOS> seems they don't like my change to the editor_generate_map tests
20170430 20:59:55-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 21:01:14< vultraz_iOS> or perhaps saving the list as a reference?
20170430 21:02:37-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170430 21:02:37-!- horrowind1 is now known as horrowind
20170430 21:03:54< vultraz_iOS> no idea..
20170430 21:05:23< vultraz_iOS> only thing i can think of is that map_generators is full of nullptrs in the tests
20170430 21:05:50-!- Kwandulin [~Kwandulin@p200300760F6D800DD16E43E4BC2ADC9F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170430 21:08:05-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 21:09:26< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt d1bdf6917317 / src/credentials.cpp: Support @ or = in usernames https://github.com/wesnoth/wesnoth/commit/d1bdf6917317ba9c3d878b175fe476e83de5317d
20170430 21:09:28-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 21:09:28< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 0ce4fca06b2f / utils/travis/install_deps.sh: Update Travis (apparently got the package name wrong) https://github.com/wesnoth/wesnoth/commit/0ce4fca06b2fb5bb8372ea7cbc917a6a08b4f923
20170430 21:09:28-!- horrowind1 is now known as horrowind
20170430 21:09:30< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 15e1088071a2 / src/tests/gui/test_gui2.cpp: Fix unit test https://github.com/wesnoth/wesnoth/commit/15e1088071a27f67715d61faf0caa984b84c5e24
20170430 21:10:06< celticminstrel> Just FTR, that has nothing to do with the broken tests you were complaining about. It's probably obvious if you look closely, but...
20170430 21:12:36< vultraz_iOS> meh
20170430 21:20:47-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 21:22:56-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170430 21:22:56-!- horrowind1 is now known as horrowind
20170430 21:30:50-!- JyrkiVesterinen [~JyrkiVest@87-100-223-30.bb.dnainternet.fi] has quit [Quit: .]
20170430 21:33:04-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 21:34:16-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 21:34:16-!- horrowind1 is now known as horrowind
20170430 21:45:38-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 21:48:15-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170430 21:48:15-!- horrowind1 is now known as horrowind
20170430 22:01:48-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 22:04:02-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170430 22:04:02-!- horrowind1 is now known as horrowind
20170430 22:15:23-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 22:17:35-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170430 22:17:35-!- horrowind1 is now known as horrowind
20170430 22:29:24-!- horrowind1 [~Thunderbi@x55b4abbc.dyn.telefonica.de] has joined #wesnoth-dev
20170430 22:31:26-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170430 22:31:26-!- horrowind1 is now known as horrowind
20170430 22:36:39< celticminstrel> login_save_crypt build passed! \/o
20170430 22:36:41< celticminstrel> ^ \o/
20170430 22:37:27< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 8e9c9ad00c73 / SConstruct: Check for cryptopp in scons (is this the right way to do it?) https://github.com/wesnoth/wesnoth/commit/8e9c9ad00c73e69c28ec7fd986025b88ebb30d2b
20170430 22:45:10< vultraz_iOS> celticminstrel: another simple action you could add is [save]
20170430 22:45:28< vultraz_iOS> and perhaps [reload]
20170430 22:46:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170430 22:46:28< celticminstrel> Why on earth would you ever want [reload]?
20170430 22:46:33< celticminstrel> [save] I can maybe see.
20170430 22:46:41< vultraz_iOS> automatic return to a checkpoint
20170430 22:46:52< celticminstrel> But [reload] sounds like a pain for the player.
20170430 22:46:58< vultraz_iOS> why?
20170430 22:47:14< celticminstrel> Would you like it if you moved to point X and suddenly the game reloaded an earlier save?
20170430 22:47:46< vultraz_iOS> I would leave it to the WML authors to handle that responsibly 
20170430 22:49:26-!- horrowind [~Thunderbi@x55b4abbc.dyn.telefonica.de] has quit [Quit: horrowind]
20170430 22:49:37< celticminstrel> I don't think I like this idea.
20170430 22:49:49< vultraz_iOS> I imagine it would be useful in defeat events
20170430 22:49:59< vultraz_iOS> but if you don't want it, [save] is enough
20170430 22:50:04< vultraz_iOS> (working through a FR list by shadowm)
20170430 22:50:23< celticminstrel> If you want auto reload on defeat, that would be acceptable; but I don't think that should be a WML action.
20170430 22:50:53< celticminstrel> BTW, when you said "another", the first one you were thinking of was story-screen?
20170430 22:51:00< vultraz_iOS> yes
20170430 22:51:34< celticminstrel> I just suddenly thought, config could use something like std::back_inserter...
20170430 22:51:54< vultraz_iOS> btw we should document that __remove=yes feature
20170430 22:52:06< celticminstrel> Assuming it works, yes we should.
20170430 22:53:04< vultraz_iOS> [save] should take a name= key to specify the save file name
20170430 22:53:18< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 6f6f533139a1 / INSTALL.md: Add cryptopp to INSTALL https://github.com/wesnoth/wesnoth/commit/6f6f533139a1f0cc3177064855e38347e71b420e
20170430 22:53:20< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 6d772702b631 / SConstruct: Second attempt at checking for cryptopp in scons https://github.com/wesnoth/wesnoth/commit/6d772702b63189403bc828daa480720bf442af14
20170430 22:53:34< celticminstrel> I need to build it now...
20170430 22:53:52< vultraz_iOS> or filename
20170430 22:53:55< vultraz_iOS> to be clea
20170430 22:53:56< vultraz_iOS> rer
20170430 23:15:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170430 23:35:00< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt eac00e9358bf / utils/travis/install_deps.sh: Travis fixup (need the dev version of cryptopp) https://github.com/wesnoth/wesnoth/commit/eac00e9358bfd54bc7e36d48e2ea62c28ca92b8d
20170430 23:35:02< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt e9210bd154a8 / SConstruct: Scons fixup (lib prefix is automatically added?) https://github.com/wesnoth/wesnoth/commit/e9210bd154a81c4504d7cfe5a83b3bb3ac63cc21
20170430 23:59:52-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
--- Log closed Mon May 01 00:00:08 2017