--- Log opened Mon May 01 00:00:08 2017
--- Day changed Mon May 01 2017
20170501 00:00:08-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170501 00:22:37< vultraz_iOS> celticminstrel: i have a fix for the editor buttons
20170501 00:25:04< celticminstrel> Disappearing with dialog onscreen?
20170501 00:25:24< vultraz_iOS> yes
20170501 00:31:02< irker143> wesnoth: Charles Dang wesnoth:master 5d74d3bc1952 / src/display.cpp: Editor: fix button overlay disappearing when a GUI2 dialog was open https://github.com/wesnoth/wesnoth/commit/5d74d3bc195226412b71460ee433dff92879320b
20170501 00:31:03< vultraz_iOS> celticminstrel: ^
20170501 00:31:25< celticminstrel> It's just odd that they didn't disappear when any GUI2 dialog was open.
20170501 00:31:33< celticminstrel> eg, the menu, which is also a GUI2 dialog.
20170501 00:34:45< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 44bb17377d93 / SConstruct: Attempt to fix Mac build https://github.com/wesnoth/wesnoth/commit/44bb17377d93756a225032a5c2943e1a49e9a40c
20170501 00:40:45-!- travis-ci [~travis-ci@54.211.76.231] has joined #wesnoth-dev
20170501 00:40:46< travis-ci> wesnoth/wesnoth#13644 (login_save_crypt - e9210bd : Celtic Minstrel): The build was broken.
20170501 00:40:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/227464560
20170501 00:40:46-!- travis-ci [~travis-ci@54.211.76.231] has left #wesnoth-dev []
20170501 00:41:17< celticminstrel> ...suddenly Travis is announcing again? o.o
20170501 00:51:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170501 00:56:47< vultraz_iOS> celticminstrel: since you build the tests could you look at the failure in editor generate map
20170501 00:59:02< celticminstrel> Maybe when I'm done with this branch?
20170501 01:00:07< vultraz_iOS> of course
20170501 01:12:11< vultraz_iOS> blah
20170501 01:12:13< vultraz_iOS> more editor bugs!
20170501 01:17:10< vultraz_iOS> WESNOTH Y U CRASHING NOW ;_;
20170501 01:17:28< matthiaskrgr> D: 
20170501 01:18:16-!- Appleman1234 [~Appleman1@pl8682.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170501 01:22:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170501 01:23:59< vultraz_iOS> celticminstrel: I thought team.side() was 1-indexed... o_O
20170501 01:26:24< celticminstrel> Eh?
20170501 01:26:47< vultraz_iOS> unit::side starts at 1
20170501 01:26:51< vultraz_iOS> does team::side start at 1
20170501 01:26:56< matthiaskrgr> ah the tests crash
20170501 01:26:59< vultraz_iOS> because that doesn't seem to be so...
20170501 01:27:50< matthiaskrgr> https://pastebin.com/Ju8B4nbe 
20170501 01:28:00< celticminstrel> side = cfg["side].to_int(1)
20170501 01:28:06< celticminstrel> So yes, it starts at 1.
20170501 01:28:19< celticminstrel> (Line 145 of team.cpp)
20170501 01:28:35< vultraz_iOS> celticminstrel: it's 0 at 108
20170501 01:28:52< vultraz_iOS> should that be 1?
20170501 01:29:03< celticminstrel> I did notice that. It's the default constructor.
20170501 01:29:20< vultraz_iOS> the editor relies on the default ctor when adding a team
20170501 01:29:31< celticminstrel> It's actually kind of weird...
20170501 01:29:43< celticminstrel> Why does the team even have a default constructor?
20170501 01:29:53< vultraz_iOS> though im not.. exactly sure how that works..
20170501 01:29:57< matthiaskrgr> lol
20170501 01:30:05< celticminstrel> What line is this in the editor?
20170501 01:30:16< celticminstrel> (And file)
20170501 01:30:23< matthiaskrgr> you can play with an invalid map apparently (not enough space to place castles) and it kinda breaks the game :P
20170501 01:30:27< vultraz_iOS> map_context.hpp:105
20170501 01:30:31< matthiaskrgr> 20170501 03:29:47 error engine: Playing game with 0 teams.
20170501 01:30:37< celticminstrel> ...hpp?
20170501 01:31:03< vultraz_iOS> yes
20170501 01:31:25< celticminstrel> ...the indentation in that function is totally messed up.
20170501 01:31:35-!- Appleman1234 [~Appleman1@pl3757.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170501 01:31:37< vultraz_iOS> I'm trying to figure out what actually sets the team..
20170501 01:32:04< celticminstrel> So...
20170501 01:32:04< vultraz_iOS> see, having it 0 there causes an assert in display::Init_flags_for_side_internal after 12f9215da24...
20170501 01:32:14< vultraz_iOS> because it does 0 - 1
20170501 01:32:18< celticminstrel> Does the crash occur just by adding a side?
20170501 01:32:23< vultraz_iOS> yes
20170501 01:32:27< celticminstrel> Okay.
20170501 01:32:34< vultraz_iOS> display::init_flags() is called immediately
20170501 01:32:42< vultraz_iOS> i i change the default ctor to start at 1..
20170501 01:32:47< vultraz_iOS> and then open the edit side dialog
20170501 01:32:52< vultraz_iOS> somehow the side numbers are correct
20170501 01:32:56< vultraz_iOS> so what actually sets the...
20170501 01:32:56< vultraz_iOS> hang on
20170501 01:33:00< celticminstrel> When is the side number set?
20170501 01:33:10< celticminstrel> Because it should never be 0, and initializing it to 1 is wrong too.
20170501 01:33:27< vultraz_iOS> I don't know
20170501 01:33:32< celticminstrel> Oh, BTW, can you crash Wesnoth now with [side]side=0?
20170501 01:33:42< vultraz_iOS> I DON'T KNOW
20170501 01:33:47< celticminstrel> Try it?
20170501 01:33:52< vultraz_iOS> editor_team_info sets the side to... team.side()...
20170501 01:33:56< vultraz_iOS> so something modified it..
20170501 01:34:06< vultraz_iOS> I seem to recall there was some bs with the - 1 here..
20170501 01:34:29< celticminstrel> Oh, I know.
20170501 01:34:59< celticminstrel> teams_.back().set_side(teams_.size()) essentially (if set_side even exists?)
20170501 01:35:23< celticminstrel> But I still think it doesn't make sense for team to have a default constructor at all.
20170501 01:35:47 * vultraz_iOS grumbles
20170501 01:35:55< vultraz_iOS> I'm looking for where side is set NOW
20170501 01:36:11< vultraz_iOS> *there is no set_side*
20170501 01:36:12< vultraz_iOS> function
20170501 01:36:14< celticminstrel> (team_info having a default constructor is fine, because it's internal to team.)
20170501 01:36:25-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 268 seconds]
20170501 01:36:44-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170501 01:36:51< vultraz_iOS> yes, that's where the 0 is!
20170501 01:37:07< celticminstrel> Right, so...
20170501 01:37:14< celticminstrel> Properly set the side in new_side?
20170501 01:37:28< vultraz_iOS> THERE IS NO SET_SIDE FUNCTION
20170501 01:37:35< vultraz_iOS> so what is setting it *now*
20170501 01:37:56< celticminstrel> There is a way to set the side number.
20170501 01:38:39-!- oldlaptop_ [~quassel@45.63.78.126] has quit [Remote host closed the connection]
20170501 01:38:51< celticminstrel> You'd want to move new_side() to the cpp probably, and instead of set_hidden(false), read(config_of("hidden", false)("side", teams_size() + 1))?
20170501 01:39:01< celticminstrel> Something like that?
20170501 01:39:14< celticminstrel> Still think it makes more sense for the config to be passed to the constructor though.
20170501 01:39:21< vultraz_iOS> *what is setting it now*
20170501 01:39:26< vultraz_iOS> this shouldn't work as it is
20170501 01:39:35< celticminstrel> But well, the point here is to fix a bug, not refactoring.
20170501 01:39:38< celticminstrel> I don't know.
20170501 01:39:42< celticminstrel> Is it being set now?
20170501 01:39:56< vultraz_iOS> wait
20170501 01:39:57< vultraz_iOS> ...
20170501 01:40:00< vultraz_iOS> 	// The side number perhaps should have been set in map_context::new_side() but the design of team::team_info appears to be read-only.
20170501 01:40:01< vultraz_iOS> 	team_info.side = side_index + 1;	// note team_info::side is supposed to be 1 to n, while side/team indexes are 0 to n-1
20170501 01:40:08< vultraz_iOS> this is the *editor_team_info*
20170501 01:40:12< vultraz_iOS> it's not the team info..
20170501 01:40:19< vultraz_iOS> so of course, the visible number is correct..
20170501 01:40:42< vultraz_iOS> looks like the internal side number is wrong
20170501 01:40:50< celticminstrel> Uh, no, team::team_info is not read-only.
20170501 01:40:53< celticminstrel> Okay.
20170501 01:41:18< vultraz_iOS> let me confirm..
20170501 01:42:14< vultraz_iOS> yeeees
20170501 01:42:22< vultraz_iOS> the internal side number is *never* set properly
20170501 01:43:20< celticminstrel> So was it impossible to add units not to side 1 or something...
20170501 01:43:49 * celticminstrel kinda thinks editor_team_info shouldn't be needed.
20170501 01:43:49-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev
20170501 01:44:06< vultraz_iOS> i added it as a wrapper to get rid of a huge arg list in the edit side dialog
20170501 01:44:22< vultraz_iOS> anyway, this side stuff is something i recall wedge009 beating his head over
20170501 01:44:28< celticminstrel> Why not just pass the team?
20170501 01:45:05< vultraz_iOS> no reason
20170501 01:45:17< vultraz_iOS> ok first thing is to properly set the damn side number
20170501 01:45:59< celticminstrel> Using the read() function.
20170501 01:46:39< vultraz_iOS> the default side value in team::team_info
20170501 01:46:43< vultraz_iOS> should it remain 0?
20170501 01:47:03< celticminstrel> Probably not, since 0 is an invalid value for it.
20170501 01:47:21< vultraz_iOS> ok
20170501 01:47:23< vultraz_iOS> 1 it is
20170501 01:47:30< celticminstrel> side=0 means "no side" and AFAIK only applies to villages.
20170501 01:47:32-!- oldlaptop [~quassel@45.63.78.126] has quit [Remote host closed the connection]
20170501 01:47:37< vultraz_iOS> now, how do i call read here..
20170501 01:48:23< vultraz_iOS> celticminstrel: i think team::build should be a static factor
20170501 01:48:24< vultraz_iOS> y
20170501 01:48:51< vultraz_iOS> thoughts?
20170501 01:49:17-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev
20170501 01:52:22< vultraz_iOS> No reason to create a team and the call build
20170501 01:52:33< vultraz_iOS> So I think it make it a static factory
20170501 01:53:12< celticminstrel> By static factory you mean the "Named Constructor" idiom or...?
20170501 01:53:37< celticminstrel> Oh, wait, it's a function that already exists?
20170501 01:53:42< celticminstrel> Maybe it should be static...
20170501 01:53:44< vultraz_iOS> What we did with color_t
20170501 01:54:02< vultraz_iOS> Static function that returns an object of the type
20170501 01:54:12< vultraz_iOS> Constructs and returns, that is
20170501 01:57:11< celticminstrel> Sounds like "Named Constructor".
20170501 01:57:30< celticminstrel> IIRC, the "Static Factory" pattern is when it creates an object of a derived type.
20170501 01:57:39< vultraz_iOS> I see
20170501 01:57:48< vultraz_iOS> Named constructor then
20170501 01:58:15< celticminstrel> I think the generator uses that pattern actually...
20170501 02:09:49< celticminstrel> It might be non-static for a reason, but... that doesn't mean it shouldn't be changed.
20170501 02:10:11< celticminstrel> Actually though, rather than making it static, you could also just make it the constructor.
20170501 02:10:17< celticminstrel> (Or, merge it with the constructor?)
20170501 02:11:07< celticminstrel> Named Constructor idiom is most useful when you have constructors that would otherwise be ambiguous - for example, in wfl::variant.
20170501 02:16:26< celticminstrel> (Which doesn't use it currently, though.)
20170501 02:38:41-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has joined #wesnoth-dev
20170501 02:41:00< vultraz_iOS> hmm
20170501 02:41:06< vultraz_iOS> can't use resize then
20170501 02:45:18< celticminstrel> resize requires a default constructor.
20170501 02:46:35-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170501 03:01:55< vultraz_iOS> hmmm
20170501 03:02:04< vultraz_iOS> ok, this is going to touch slightly more than i expected..
20170501 03:03:22< vultraz_iOS> i was going to make build a ctor of its own but i think maybe i should just leave it as it is for now...
20170501 03:03:28< vultraz_iOS> prevents unnecessary copying
20170501 03:06:25< vultraz_iOS> celticminstrel: i wonder if the whole build call is needed when adding a new side or i should just add a set_side sette
20170501 03:06:25< vultraz_iOS> r
20170501 03:08:11< celticminstrel> Well, I suppose you could add a special constructor for the editor that takes only a side number?
20170501 03:08:15 * celticminstrel shrug.
20170501 03:08:33< celticminstrel> I think adding a set_side function isn't a good idea. A side's number isn't supposed to change once it's created.
20170501 03:08:57< celticminstrel> If you need to change the side's number in the editor, create a new side with the new number and transfer all the other data over.
20170501 03:09:26< celticminstrel> You could even do that as a special "copy" constructor (taking a team and the new number).
20170501 03:10:17< vultraz_iOS> (just realized since side is 1-indexed i could just always set the side num to teams.size())
20170501 03:11:42< celticminstrel> That's assuming you set the side num after inserting it into the vector though, right?
20170501 03:11:49< celticminstrel> Which I'd guess is probably not the case.
20170501 03:12:08< vultraz_iOS> emplace
20170501 03:12:26< vultraz_iOS> oh fuck it I'll use build
20170501 03:12:39< celticminstrel> I have no idea why you said "emplace" there.
20170501 03:14:26< vultraz_iOS> https://www.irccloud.com/pastebin/FBoajnxK/
20170501 03:18:07< vultraz_iOS> the gist
20170501 03:24:01< celticminstrel> You don't want static_cast<unsigned int>(teams_.size)
20170501 03:24:10< celticminstrel> If that even works, it's some random arbitrary value.
20170501 03:24:15< celticminstrel> Though more likely it doesn't work.
20170501 03:24:27< vultraz_iOS> yes, type
20170501 03:24:29< vultraz_iOS> typo
20170501 03:24:31< vultraz_iOS> i wanted size()
20170501 03:24:38< celticminstrel> Yeah.
20170501 03:24:43< celticminstrel> Is the cast needed though?
20170501 03:25:29< vultraz_iOS> dunno
20170501 03:25:39< celticminstrel> Other than not seeing a point in declaring a team variable that's used only once (but that's just a matter of taste), that's more or less precisely what I was thinking for the bugfix.
20170501 03:26:49< celticminstrel> I now have a weird problem with the cryptopp lib in MSVC. For some reason when I link to it the program hangs before it's even launched.
20170501 03:27:00< celticminstrel> Might consider just using OpenSSL's crypto instead...
20170501 03:27:36< celticminstrel> Apparently OpenSSL is actually a dependency of pango, at least on Linux.
20170501 03:27:40< celticminstrel> Or was it Mac.
20170501 03:27:44< celticminstrel> One of those.
20170501 03:28:49< celticminstrel> Well maybe both  too.
20170501 03:35:50-!- Appleman1234 [~Appleman1@pl3757.ag1212.nttpc.ne.jp] has quit [Ping timeout: 252 seconds]
20170501 03:35:52< irker143> wesnoth: Charles Dang wesnoth:master 4345c54e61af / src/team.cpp: Team Info: default-initialize side value as 1 instead of 0 https://github.com/wesnoth/wesnoth/commit/4345c54e61af382e2473f003dcfd0b798b1e9944
20170501 03:35:55< irker143> wesnoth: Charles Dang wesnoth:master 208e1640e6c2 / src/editor/map/ (map_context.cpp map_context.hpp): Editor: fixed added sides never having the proper side number https://github.com/wesnoth/wesnoth/commit/208e1640e6c254001f1b43421610d1fa5ff74e1a
20170501 03:35:58< irker143> wesnoth: Charles Dang wesnoth:master 2877a20439cc / src/editor/map/context_manager.cpp: Editor Edit Side: remove hack to properly set side variable in editor_team_info https://github.com/wesnoth/wesnoth/commit/2877a20439cc328131684536c248c839bb0d7abe
20170501 03:50:05< celticminstrel> I wouldn't call that "default-initialize", but whatever.
20170501 03:50:38< celticminstrel> You decided not to use config_of, huh?
20170501 03:55:14< vultraz_iOS> yes
20170501 03:55:35< vultraz_iOS> clearer when dealing with a comma seperated list
20170501 03:55:47< vultraz_iOS> (config_of()(), get_map()) just looks weird
20170501 04:02:58-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170501 04:51:41-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has quit [Quit: ancestral]
20170501 05:08:22-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has joined #wesnoth-dev
20170501 05:22:07-!- ancestral [~anonymous@63-231-152-92.mpls.qwest.net] has quit [Quit: ancestral]
20170501 05:25:39-!- atarocch [~atarocch@ip-64-134-98-13.public.wayport.net] has quit [Remote host closed the connection]
20170501 05:37:07-!- Kwandulin [~Kwandulin@p200300760F6D800DD16E43E4BC2ADC9F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170501 05:55:15< wedge009> Side, team ID, etc, seems like there's a lot of that type of thing and I'm not even sure they're all consistently 0-based or 1-based. I remember running into compiler issues or something like that as a result (out of bounds, etc).
20170501 05:58:17< wedge009> Back in a few minutes, just updating client.
20170501 05:58:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170501 05:58:58< celticminstrel> You'll probably find any off-by-one issues you've introduced by just playing a few games (particularly campaigns or the more complicated MP scenarios).
20170501 05:59:36< celticminstrel> Ideally, I think the teams vector should never be indexed directly (except in the get_team() getter).
20170501 05:59:55< celticminstrel> Even in its own class, get_team() should be used instead of directly indexing the vector.
20170501 06:00:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20170501 06:00:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170501 06:01:53< vultraz_iOS> why
20170501 06:01:58< vultraz_iOS> that makes no sense
20170501 06:03:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170501 06:05:26< celticminstrel> Because then you know that any index is 1-based.
20170501 06:05:37< vultraz_iOS> right
20170501 06:05:48< celticminstrel> And there's no -1's or +1's littering the code when indexing it.
20170501 06:05:54< vultraz_iOS> but it also seems weird to deliberately manage with 1-based indices when not necessary
20170501 06:06:19< celticminstrel> I think it's better to think of the teams array as inherently 1-indexed.
20170501 06:06:32< celticminstrel> Just like a Lua array, there's no 0 index.
20170501 06:07:42< vultraz_iOS> perhaps
20170501 06:07:57< vultraz_iOS> what about overloading operator[]
20170501 06:08:17< vultraz_iOS> ah, but there's no wrapper
20170501 06:08:34< celticminstrel> You could write a wrapper fairly trivially.
20170501 06:08:47< celticminstrel> It would override operator[] and then import anything else important with using.
20170501 06:09:09< celticminstrel> (Assuming it inherits privately from vector; if the vector is instead a member, you'd have to define the wrapper functions.)
20170501 06:09:45< celticminstrel> Do you prefer a wrapper to having the separate get_team() function?
20170501 06:10:22< vultraz_iOS> hmm
20170501 06:10:25< vultraz_iOS> not sure
20170501 06:11:09< celticminstrel> I probably slightly favour the get_team() simply because it doesn't create a new class just for this purpose, but I don't mind that either. And in theory the class might be usable elsewhere anyway.
20170501 06:12:19< celticminstrel> There are other things in the game that are inherently 1-indexed, where access to them is currently sprinkled with +1's and -1's. The game map, for example.
20170501 06:13:40< celticminstrel> Oh right, gfgtdf even added getters to hide that - wml_x() and wml_y().
20170501 06:15:53< celticminstrel> This is really weird. Just by linking the cryptopp dll, the game hangs during dll loading... but of a different dll.
20170501 06:16:20< celticminstrel> It loads the cryptopp dll just fine but hangs later when loading something called cryptosp.
20170501 06:16:49< celticminstrel> Assuming the dlls are always loaded in the same order (I'm only guessing it's that because it's the first one I see in the log when cryptopp isn't loaded that is not in the log when cryptopp is loaded).
20170501 06:18:13< celticminstrel> ^cryptsp (no o)
20170501 06:25:30< celticminstrel> Maybe I should just go for OpenSSL after all? That'll probably also allow removing md5.h (provided we can assume that later versions of OpenSSL don't remove MD5; IIRC, it's marked deprecated).
20170501 06:26:05< celticminstrel> And upon closer inspection of cryptopp, it's pretty much just the C interface encapsulated into a class anyway.
20170501 06:26:22< celticminstrel> So there's not really any big advantage of it being "more C++" or anything...
20170501 06:26:27< celticminstrel> I guess I'll try it?
20170501 06:31:41< irker143> wesnoth: Charles Dang wesnoth:master 2591bed31f19 / src/editor/map/map_context.cpp: Editor: construct team in-place when loading sides from file https://github.com/wesnoth/wesnoth/commit/2591bed31f1986e5d1665d73b6860c4a43db6ab6
20170501 06:31:44< irker143> wesnoth: Charles Dang wesnoth:master b49a90d0371a / src/ (17 files in 13 dirs): All hail the great emplace_back \o/ https://github.com/wesnoth/wesnoth/commit/b49a90d0371afaaa271160d708ad78a9fec12bc8
20170501 06:34:10< celticminstrel> I refuse!
20170501 06:34:28< celticminstrel> Thanks wedge009, I'll go ahead and merge it then.
20170501 06:34:39< vultraz_iOS> do squash tho
20170501 06:34:58< wedge009> ~squish!~
20170501 06:35:10< celticminstrel> Squashing was the intention...
20170501 06:35:18< celticminstrel> Should I try the Resolve Conflicts button?
20170501 06:35:25< vultraz_iOS> sure
20170501 06:35:41< celticminstrel> I'm hoping that what that actually does is "merge master into the branch".
20170501 06:35:56< celticminstrel> Implying I can then choose how to merge the branch back to master.
20170501 06:36:55< celticminstrel> \o/
20170501 06:37:19< vultraz_iOS> now try Squash?
20170501 06:37:21< irker143> wesnoth: Charles Dang wesnoth:master ba6bf07a0f4b / src/ (game_config.cpp game_initialization/lobby_info.cpp): Deployed some more map::emplace https://github.com/wesnoth/wesnoth/commit/ba6bf07a0f4b3d448b196a9e6830c043bd102eb7
20170501 06:37:30< irker143> wesnoth: qmo2015 wesnoth:master c551cfd04884 / changelog data/core/about.cfg src/mouse_events.cpp src/mouse_handler_base.cpp: Fixed bug #24644: Units moving after in game help exit  (#1002) https://github.com/wesnoth/wesnoth/commit/c551cfd048845cf4dd0017efb46c1f6a5d6c3777
20170501 06:37:35< vultraz_iOS> :O
20170501 06:37:37< vultraz_iOS> \o/
20170501 06:37:50< vultraz_iOS> github is great
20170501 06:38:26< celticminstrel> Out of curiosity, have you used vector::emplace anywhere?
20170501 06:38:42< vultraz_iOS> yes
20170501 06:38:54< celticminstrel> Oh huh.
20170501 06:40:21< vultraz_iOS> I wonder how much marginal performance we've gained though use of emplace
20170501 06:43:45< celticminstrel> Probably none worth speaking of.
20170501 06:43:45< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 56e3ed61591c / / (6 files in 4 dirs): Link with cryptopp and replace sha1.hpp with the cryptopp version https://github.com/wesnoth/wesnoth/commit/56e3ed61591cbaeb083db912089285dca0cd95b2
20170501 06:43:47< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 3968e51d7a9f / SConstruct utils/travis/install_deps.sh: Can't get cryptopp to work in MSVC; switch to OpenSSL https://github.com/wesnoth/wesnoth/commit/3968e51d7a9fc37587a4b747cd2dc110e6250b2f
20170501 06:44:03< celticminstrel> Eh? There were two commits? Whoops.
20170501 06:44:14< celticminstrel> Better cancel that build then.
20170501 06:44:55< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 6477f9683e9d / / (4 files in 4 dirs): Can't get cryptopp to work in MSVC; switch to OpenSSL https://github.com/wesnoth/wesnoth/commit/6477f9683e9dfe14313b431133862507fdb768f9
20170501 06:45:38< vultraz_iOS> I guess one of the main benefits of emplace, then, is less typing
20170501 06:45:43< celticminstrel> Heh.
20170501 06:46:07< vultraz_iOS> and slightly cleaner code
20170501 06:46:12< celticminstrel> There might be marginal performance benefits in some places, but even if there are it probably only affects the debug build.
20170501 06:47:35< vultraz_iOS> well, that's good for people running debug builds then
20170501 06:50:18< vultraz_iOS> yeah, most of the time the performance is minimal 
20170501 06:50:18< vultraz_iOS> http://www.acodersjourney.com/2016/11/6-tips-supercharge-cpp-11-vector-performance/
20170501 06:50:35< vultraz_iOS> "We can clearly see that the emplacement function is outperforming the insertion function – but only by 177 micro seconds. For all intents and purposes, they are roughly equivalent."
20170501 06:50:46< vultraz_iOS> though
20170501 06:50:49< vultraz_iOS> "Emplacement functions are likely to be significantly faster only in the following cases:
20170501 06:50:49< vultraz_iOS> The value being added is constructed into the vector, not assigned."
20170501 06:50:59< vultraz_iOS> and I have replaced quite a few cases of that
20170501 06:52:16< vultraz_iOS> not sure what the use of the shrink_to_fit suggestion is though
20170501 06:53:45< vultraz_iOS> resizing the size of the vector ahead of time is interesting, though
20170501 06:53:49< vultraz_iOS> AFAIK we don't do that much
20170501 06:53:56< vultraz_iOS> but it seems it could be significant gain
20170501 06:56:04< celticminstrel> I've done that several times.
20170501 06:56:08< celticminstrel> I think.
20170501 06:57:37-!- JyrkiVesterinen [~jyrki@87.92.8.244] has joined #wesnoth-dev
20170501 07:02:42< celticminstrel> Does encode_hash()... 1) Just convert an array of bytes to a hex-encoded string? 2) Depend closely on the length of 16?
20170501 07:02:48< celticminstrel> (In hash.cpp.)
20170501 07:03:55< JyrkiVesterinen> Yes and yes.
20170501 07:04:12< celticminstrel> So, it wouldn't work if you changed all the 16's to something else?
20170501 07:04:17< JyrkiVesterinen> It would be possible to convert it to accept a different length, mind you.
20170501 07:06:45-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Changing host]
20170501 07:06:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170501 07:07:04< JyrkiVesterinen> From what I can tell, as much as changing the 16s should be sufficient.
20170501 07:14:53< celticminstrel> Maybe not the bitshift one?
20170501 07:15:46< JyrkiVesterinen> Bitshift one? The only constants used for bitshifting are 6, 12 and 18.
20170501 07:16:06< celticminstrel> I see 8, 6, 12, 16, 18...
20170501 07:16:30< JyrkiVesterinen> Oh, those.
20170501 07:16:43< JyrkiVesterinen> Yes, you should leave the shift in line 64 alone.
20170501 07:22:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170501 07:23:55< irker143> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 29db5bb01030 / / (11 files in 4 dirs): Use OpenSSL for MD5 too! https://github.com/wesnoth/wesnoth/commit/29db5bb01030515b4875568d668e3065b77d35c8
20170501 07:31:13< JyrkiVesterinen> vultraz_iOS: Regarding the article you linked, std::vector::at() should be avoided only where performance is important.
20170501 07:31:24< JyrkiVesterinen> At() is slower because it checks that the index is valid.
20170501 07:31:45< JyrkiVesterinen> And that check is a good thing if it's not performance-critical code.
20170501 07:55:13-!- JyrkiVesterinen [~jyrki@87.92.8.244] has quit [Quit: .]
20170501 07:56:27< celticminstrel> So I got it kinda working with AES, but only until you quit; saved credentials aren't working. Also there seems to be a lot of debug asserts being triggered.
20170501 07:56:39< celticminstrel> Of the ignorable type.
20170501 07:57:12< celticminstrel> By ignorable I mean not "it's safe to ignore them" but rather "there's an ignore button"
20170501 07:57:37< celticminstrel> IOW, just like a breakpoint.
20170501 07:58:51-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has joined #wesnoth-dev
20170501 08:03:33< celticminstrel> I'm probably doing something wrong.
20170501 08:03:50-!- celticminstrel is now known as celmin|sleep
20170501 08:05:32< irker143> wesnoth: Charles Dang wesnoth:master 6babeec7867e / src/gui/auxiliary/ (tips.cpp tips.hpp): GUI2: reformat tip-of-the-day code https://github.com/wesnoth/wesnoth/commit/6babeec7867e7a39e16a2748509d49b9f0de664f
20170501 08:05:35< irker143> wesnoth: Charles Dang wesnoth:master dcb996566e07 / src/gui/auxiliary/ (tips.cpp tips.hpp): GUI2: refactored tip-of-the-day code https://github.com/wesnoth/wesnoth/commit/dcb996566e07822d4e709db723aa02c58654ea97
20170501 08:17:25< irker143> wesnoth: Charles Dang wesnoth:master 3929cbc51882 / src/gui/auxiliary/tips.cpp: Fixup dcb9965 (feedback by @jyrkive) https://github.com/wesnoth/wesnoth/commit/3929cbc518825923f8dd8aa812abd5893d74a164
20170501 08:24:57< celmin|sleep> No longer relevant there, but... filters.empty() ? true : std::all_of(...) is exactly equivalent to just std::all_of(...)
20170501 08:25:06< celmin|sleep> all_of / none_of return true on an empty range.
20170501 08:25:13< celmin|sleep> (any_of returns false on an empty range)
20170501 08:25:58< celmin|sleep> I think maybe filters.empty() || std::any_of(...) might be slightly cleaner though...?
20170501 08:26:08< celmin|sleep> Assuming it really is the same.
20170501 08:29:05-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 255 seconds]
20170501 08:31:11-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170501 08:45:05-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170501 09:51:12-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 09:59:42-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 10:01:57-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 10:01:57-!- horrowind1 is now known as horrowind
20170501 10:06:15-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has quit [Quit: .]
20170501 10:06:28-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170501 10:09:03-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170501 10:11:42-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170501 10:14:07-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 10:15:05-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 10:15:05-!- horrowind1 is now known as horrowind
20170501 10:26:16-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 10:28:20-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170501 10:28:20-!- horrowind1 is now known as horrowind
20170501 10:40:01-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 10:41:28-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 10:41:28-!- horrowind1 is now known as horrowind
20170501 10:51:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 10:56:11-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 10:58:27-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 10:58:27-!- horrowind1 is now known as horrowind
20170501 11:10:03< irker143> wesnoth: Charles Dang wesnoth:master 726db2dee34a / src/gui/core/event/dispatcher.hpp: GUI2: use an std::list for the dispatcher signal queues https://github.com/wesnoth/wesnoth/commit/726db2dee34ad97f15f223c2a25e75e5ce5eeec1
20170501 11:11:30-!- Kwandulin [~Kwandulin@p200300760F6D800DD16E43E4BC2ADC9F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170501 11:12:19-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 11:13:59-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20170501 11:13:59-!- horrowind1 is now known as horrowind
20170501 11:26:53-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 11:29:05-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170501 11:29:06-!- horrowind1 is now known as horrowind
20170501 11:38:18-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 11:40:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170501 11:40:16-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 11:40:16-!- horrowind1 is now known as horrowind
20170501 12:00:34-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 12:01:16-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 12:01:16-!- horrowind1 is now known as horrowind
20170501 12:17:11-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 12:19:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 12:19:28-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 12:19:28-!- horrowind1 is now known as horrowind
20170501 12:26:50-!- gfgtdf [~chatzilla@x4e3698f7.dyn.telefonica.de] has joined #wesnoth-dev
20170501 12:28:00< gfgtdf> 20170501 06:40:21< vultraz_iOS> I wonder how much marginal performance we've gained though use of emplace
20170501 12:28:30< gfgtdf> vultraz_iOS: this sure depends on the conrete case, some obevty coping or ven moving is expensive while of others it's not
20170501 12:29:08< gfgtdf> vultraz_iOS: also it depends on whether previously push_back(const value_type&) or push_back(value_type&&) wsa called, 
20170501 12:29:47< gfgtdf> vultraz_iOS: somhow http://www.cplusplus.com/reference/vector/vector/push_back/ doenst meanting the push_back(value_type&&) overload so i'm unusre wheterh the standard actualyl guarantees its existence msvc has it(
20170501 12:30:12< gfgtdf> wedge009: did you see my reuqest eariler ?
20170501 12:30:14< vultraz_iOS> gfgtdf: cppreference mentions it
20170501 12:32:10< vultraz_iOS> gfgtdf: http://en.cppreference.com/w/cpp/container/vector/push_back
20170501 12:32:15< gfgtdf> ok
20170501 12:37:47-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 12:40:10-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 12:40:10-!- horrowind1 is now known as horrowind
20170501 12:42:58-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has joined #wesnoth-dev
20170501 12:48:18-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 12:49:35-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 12:49:35-!- horrowind1 is now known as horrowind
20170501 12:53:39-!- Kwandulin [~Kwandulin@p200300760F6D8048A8CD4DC399F5AC99.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170501 13:08:51-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 13:09:49-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 13:09:49-!- horrowind1 is now known as horrowind
20170501 13:11:38< DeFender1031> service providers suck.
20170501 13:11:47< DeFender1031> just thought I'd throw that out there.
20170501 13:21:16< zookeeper> in my experience they mostly suck at the times they _don't_ provide the service. does that still count?
20170501 13:23:33< DeFender1031> hmm... I shall have to ponder this thought. That's probably true in general.
20170501 13:26:39< DeFender1031> Also when they misrepresent a service agreement, charge you for what they told you is the full amount but is not, and then cut off your service at the WORST possible time logistically for anyone to try to fix it because you "haven't paid them for the service"
20170501 13:27:21< DeFender1031> (Which also, incidentally, explains why I haven't been here for the past few days.)
20170501 13:29:34-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 13:29:41< Kwandulin> Mhh, wouldn't adding the 'new' sylph be a good option? While the old elvish sorceress looks good, the old sylph totally falls off
20170501 13:30:11< irker143> wesnoth: Charles Dang wesnoth:master 890177d170d1 / src/gui/core/event/dispatcher.hpp: GUI2: fixed disconnect_signal searching the wrong queue 2/3 of the time https://github.com/wesnoth/wesnoth/commit/890177d170d1e18ff2b7f59ae39cfade518c6be2
20170501 13:30:14< irker143> wesnoth: Charles Dang wesnoth:master 81eb23c74e8a / src/gui/core/event/dispatcher.hpp: GUI2: remove every matching signal from an event queue when disconnecting https://github.com/wesnoth/wesnoth/commit/81eb23c74e8ad86d0354a195e668c0c79546f4fd
20170501 13:30:58-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20170501 13:30:58-!- horrowind1 is now known as horrowind
20170501 13:43:36-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 13:44:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20170501 13:44:55-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 13:45:53-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170501 13:45:53-!- horrowind1 is now known as horrowind
20170501 14:03:20-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 14:04:45-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 14:04:45-!- horrowind1 is now known as horrowind
20170501 14:11:31-!- nickanc [5d33ac22@wikimedia/nickanc] has joined #wesnoth-dev
20170501 14:20:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 14:20:20-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170501 14:24:53-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 14:26:35-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 14:26:35-!- horrowind1 is now known as horrowind
20170501 14:37:09-!- nickanc [5d33ac22@wikimedia/nickanc] has quit [Ping timeout: 260 seconds]
20170501 14:37:27-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Quit: horrowind]
20170501 14:39:16< celmin|sleep> vultraz_iOS: std::deque is also good when using front/back insertion.
20170501 14:42:37< celmin|sleep> IIRC it's also the default underlying container for std::queue
20170501 14:45:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 14:46:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170501 14:47:43-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has quit [Quit: .]
20170501 14:48:06-!- Octalot [~noct@77.119.131.172.wireless.dyn.drei.com] has joined #wesnoth-dev
20170501 14:48:44-!- Kwandulin [~Kwandulin@p200300760F6D8048A8CD4DC399F5AC99.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170501 14:56:55-!- celmin|sleep is now known as celticminstrel
20170501 15:05:13< gfgtdf> is here someone using linux/mac wo coudl help me testing a bug ?
20170501 15:08:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 15:08:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20170501 15:25:22-!- Kwandulin [~Kwandulin@p200300760F6D8048A8CD4DC399F5AC99.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170501 15:34:05-!- nickanc [5d33ac22@wikimedia/nickanc] has joined #wesnoth-dev
20170501 15:34:24< nickanc> Ravana_ sorry for not mentioning you the error on ageless!
20170501 15:35:53< Ravana_> it was good learning experience to modify those core lua files
20170501 15:37:29< celticminstrel> ?
20170501 15:39:02< nickanc> Ravana_ good, then :D
20170501 15:49:16-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has joined #wesnoth-dev
20170501 15:55:48-!- gfgtdf [~chatzilla@x4e3698f7.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170501 15:59:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170501 15:59:50< nickanc> celticminstrel: if ? refers to us, we were working on porting Orocia to 1.13 and possibly 1.14, but the version I proposed encountered an error, which though is a bug of ageless era, not orocia.
20170501 16:13:47< celticminstrel> Was more at Ravana than you.
20170501 16:15:15< Ravana_> I followed Lua error traceback and added logging to those places
20170501 16:15:52< celticminstrel> Oh.
20170501 16:16:05< celticminstrel> I see.
20170501 16:18:42< nickanc> btw, Ravana has a point: sometimes lua errors are not that clear about where they happen
20170501 16:19:14< celticminstrel> Really? I think I've usually found them to be pretty clear about where they happen...
20170501 16:29:10< nickanc> I have yet to understand what caused the error we were talking about above (and indeed I kind of were uninterested in fixing it, since I was concerned with the stuff I was patching and not the rest), but would be nicer if core lua made checks and raised errors on the data types it gets. However I dont know the whole code enough to understand the whole picture, I think
20170501 16:30:51-!- irker143 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170501 16:35:44-!- TC04 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20170501 16:37:50-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170501 16:41:14-!- Netsplit *.net <-> *.split quits: TC01, Kwandulin
20170501 16:45:05-!- Netsplit over, joins: Kwandulin
20170501 17:20:49-!- celticminstrel is now known as celmin|away
20170501 17:21:58-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170501 17:21:58< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 81eb23c: GUI2: remove every matching signal from an event queue when disconnecting Failed
20170501 17:21:59< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-323
20170501 17:22:03-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170501 17:22:12-!- Computer10 [5fea9e3f@gateway/web/freenode/ip.95.234.158.63] has joined #wesnoth-dev
20170501 17:26:19-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170501 17:26:19< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 81eb23c: GUI2: remove every matching signal from an event queue when disconnecting Failed
20170501 17:26:19< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-323
20170501 17:26:23-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170501 17:34:39-!- gfgtdf [~chatzilla@x4e3698f7.dyn.telefonica.de] has joined #wesnoth-dev
20170501 17:39:11-!- nickanc [5d33ac22@wikimedia/nickanc] has quit []
20170501 17:49:14-!- Computer10 [5fea9e3f@gateway/web/freenode/ip.95.234.158.63] has quit [Quit: Page closed]
20170501 18:32:22-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170501 18:35:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170501 19:05:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170501 19:06:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170501 19:10:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170501 19:12:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170501 19:13:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170501 19:15:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170501 19:19:09-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170501 19:31:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170501 19:37:51-!- Kwandulin [~Kwandulin@p200300760F6D8048A8CD4DC399F5AC99.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170501 19:46:12< JyrkiVesterinen> celmin|away, gfgtdf, wedge009: I opened some pull requests in the aquileia/external repository.
20170501 19:46:19< JyrkiVesterinen> https://github.com/aquileia/external/pull/7
20170501 19:46:21< JyrkiVesterinen> https://github.com/aquileia/external/pull/8
20170501 19:46:24< JyrkiVesterinen> https://github.com/aquileia/external/pull/9
20170501 19:48:16< gfgtdf> JyrkiVesterinen: wait strign_vire is missing on VC14 but not on vc12 ?
20170501 19:48:35-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170501 19:49:15< vultraz_iOS> good god you built pango :O
20170501 19:49:19< JyrkiVesterinen> It's not present in either. However, VS2013 builds don't use USE_HETEROGENOUS_LOOKUPS and therefore don't need string_view.
20170501 19:49:50< gfgtdf> vultraz_iOS: i also did that when i build wesnoth here... 
20170501 19:49:55< vultraz_iOS> oh
20170501 19:51:16< gfgtdf> but ye it's not that enjoyable, back thne i was lucky to find a msvc pango projectfiles form an third party source.
20170501 19:52:08< gfgtdf> (or was it cairo? not sure whic was the hard part)
20170501 19:52:22< JyrkiVesterinen> The gvsbuild script that I linked worked fine for me. :) (Except for VS2017; it required some manual tweaks and failed to build some libraries.)
20170501 19:52:28-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Client Quit]
20170501 19:52:35< gfgtdf> JyrkiVesterinen: which pango/aciro version does it use nopw ?
20170501 19:52:41< gfgtdf> now*
20170501 19:53:02< JyrkiVesterinen> (Failure to build some libraries isn't a problem because 2015 and 2017 are ABI-compatible. For the libraries which the script failed to build, I just used VS2015 versions.)
20170501 19:53:59< gfgtdf> JyrkiVesterinen: ye specialyl sicne these are c loibary (not c++) it shoudl also be enough to build thne with a non-msvc compiler.
20170501 19:54:41< celmin|away> ABI-compatible!? That's surprising.
20170501 19:55:22-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170501 19:56:45< JyrkiVesterinen> gfgtdf: They look like development versions. Cairo 1.15.2 and Pango 1.42.
20170501 19:59:16< gfgtdf> JyrkiVesterinen: you sure its safe enough to use deloement release? I mean cairo 1.14.8  coudl also be an option.
20170501 19:59:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 20:00:08< JyrkiVesterinen> Well, the script didn't allow me to choose the version.
20170501 20:01:05< JyrkiVesterinen> I'd say that it's not a big problem if there are bugs in this snapshot. After all, this repository is only intended for developers.
20170501 20:02:12< gfgtdf> JyrkiVesterinen: why that? i mean what library woudl we use for the release then?
20170501 20:02:46< JyrkiVesterinen> I thought that official Windows releases don't use this repo?
20170501 20:03:31< gfgtdf> JyrkiVesterinen: i actually don't know bu ieven it it doesnt, better als loonycabord whether/how we woudl update th pangocuaro vversion that is used for releases
20170501 20:03:38< gfgtdf> better ask*
20170501 20:03:43< gfgtdf> loonycyborg*
20170501 20:03:58< gfgtdf> pangocairo*
20170501 20:05:48< gfgtdf> i mean even if you woudl fix 25065 with that it'll onyl wokr when the rease pangocairo versions are also updated  wesnoth 1.13.7 relese uses cairo 1.10 and pango 1.30
20170501 20:06:04< gfgtdf> 	i mean even if you woudl fix 25065 with that it'll onyl wokr when the rease pangocairo versions are also updated ( wesnoth 1.13.7 relese uses cairo 1.10 and pango 1.30 )
20170501 20:06:08< JyrkiVesterinen> 1.10 is what I need.
20170501 20:06:23< celmin|away> I thoughg loonycyborg cross-compiled.
20170501 20:06:31< gfgtdf> hmm so the one packed with aquiera/external was even older ?
20170501 20:06:37< JyrkiVesterinen> Yes.
20170501 20:06:46< celmin|away> ^thought
20170501 20:07:20< gfgtdf> celmin|away: i dont he doesn't although he can, he once said that he once had problems with it.
20170501 20:07:34< loonycyborg> I'm building windows releases in virtualbox vm that has windows xp installed
20170501 20:07:44< celmin|away> MSVC or GCC?
20170501 20:07:49< loonycyborg> gcc
20170501 20:08:19< loonycyborg> mingw64
20170501 20:09:21< vultraz_iOS> XP O_O
20170501 20:09:28< gfgtdf> JyrkiVesterinen: well i guess we can merge it and check whethe someone observed problems.
20170501 20:09:43< celmin|away> Well, Wesnoth does support XP, so building on it is probably best after all.
20170501 20:09:54< vultraz_iOS> right, we do
20170501 20:10:00< vultraz_iOS> >_>
20170501 20:10:17< celmin|away> No, we can't drop XP support without a good reason.
20170501 20:10:44< vultraz_iOS> The reason is it's no longer supported by Microsoft and we should not encourage its usage.
20170501 20:11:06< celmin|away> That's not a good reason.
20170501 20:11:16< celmin|away> Anyway, it's not like we're encouraging its use by supporting it.
20170501 20:11:37< gfgtdf> JyrkiVesterinen: as i said eariler i don't use thoes files anymore (although i think i maybe will start doing so now that they aren't so outdated anymore), so i'm probably not the best one to test it 
20170501 20:12:26-!- celmin|away is now known as celticminstrel
20170501 20:14:58-!- sevu [~Unknown@141.57.57.138] has joined #wesnoth-dev
20170501 20:14:58-!- sevu is now known as shiki
20170501 20:29:48-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 20:30:15-!- irker865 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170501 20:30:15< irker865> wesnoth: sigurdfdragon wesnoth:master 58131236f7a6 / data/core/units/undead/ (Corpse_Soulless.cfg Corpse_Walking.cfg): Fix base animation showing in zombie bats https://github.com/wesnoth/wesnoth/commit/58131236f7a697684d6118f7c427f6845f7ff3a7
20170501 20:30:15< irker865> wesnoth: sigurdfdragon wesnoth:master 40138d4c1648 / changelog players_changelog: Add changelog entries https://github.com/wesnoth/wesnoth/commit/40138d4c164864bf9a1b6afcfd8345d2165602f3
20170501 20:33:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170501 20:33:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 20:49:16-!- horrowind1 [~Thunderbi@78.49.253.137] has joined #wesnoth-dev
20170501 20:51:20-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170501 20:51:20-!- horrowind1 is now known as horrowind
20170501 20:55:14< irker865> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 0b2113093223 / SConstruct source_lists/libwesnoth_core: Fixup (wrong lib name, forgot to remove file from source_lists) https://github.com/wesnoth/wesnoth/commit/0b2113093223b771ee50b81bccf897f4f08496e8
20170501 20:59:29-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170501 20:59:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170501 21:00:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 21:02:49-!- horrowind1 [~Thunderbi@x4e31fd89.dyn.telefonica.de] has joined #wesnoth-dev
20170501 21:04:40-!- horrowind [~Thunderbi@78.49.253.137] has quit [Ping timeout: 240 seconds]
20170501 21:04:41-!- horrowind1 is now known as horrowind
20170501 21:11:47-!- horrowind [~Thunderbi@x4e31fd89.dyn.telefonica.de] has quit [Quit: horrowind]
20170501 21:14:51-!- JyrkiVesterinen [~JyrkiVest@87-92-8-244.bb.dnainternet.fi] has quit [Quit: .]
20170501 21:26:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170501 21:26:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 21:38:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170501 22:05:10-!- atarocch [~atarocch@ip-64-134-98-13.public.wayport.net] has joined #wesnoth-dev
20170501 22:21:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170501 22:22:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170501 22:42:56-!- gfgtdf [~chatzilla@x4e3698f7.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170501 22:49:48-!- shiki [~Unknown@141.57.57.138] has quit [Quit: Verlassend]
20170501 22:56:07< vultraz_iOS> celticminstrel: you can remove an event from within itself, right?
20170501 22:56:10< vultraz_iOS> just checking
20170501 22:56:16< vultraz_iOS> before i mere https://github.com/wesnoth/wesnoth/pull/1011/files
20170501 23:01:01-!- Octalot [~noct@77.119.131.172.wireless.dyn.drei.com] has quit []
20170501 23:02:46-!- TC04 is now known as TC01
20170501 23:55:25-!- irker865 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
--- Log closed Tue May 02 00:00:06 2017