--- Log opened Tue May 02 00:00:06 2017
20170502 00:12:28< celticminstrel> If you mean [event] then yes, I think so. Otherwise, not idea.
20170502 00:12:58< vultraz_iOS> yes
20170502 00:13:14< celticminstrel> ^no
20170502 00:13:30< vultraz_iOS> what?
20170502 00:13:33< vultraz_iOS> oh
20170502 00:14:44-!- irker324 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170502 00:14:44< irker324> wesnoth: Charles Dang wesnoth:master 568c13f82678 / src/editor/palette/editor_palettes.cpp: Editor Palettes: simplify template specializations https://github.com/wesnoth/wesnoth/commit/568c13f82678b3cc7ce90e2a22b5ddca1fab0f57
20170502 00:19:28< vultraz_iOS> "This server could not prove that it is gna.org; its security certificate expired yesterday." welp
20170502 00:21:59< vultraz_iOS> when is GNA supposed to go down?
20170502 00:22:53< matthiaskrgr> :s 
20170502 00:23:00-!- sevu [~Unknown@p5485791F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 00:23:38< vultraz_iOS> may
20170502 00:25:12< pydsigner> So, this month
20170502 00:25:19< matthiaskrgr> so now is the time to yell "may day, may day" ?
20170502 00:25:22< vultraz_iOS> well, they said "6 months notice"
20170502 00:25:29< vultraz_iOS> in November
20170502 00:25:37< vultraz_iOS> and now the security cert has expired 
20170502 00:25:43< pydsigner> My opinion is that we should go to Github
20170502 00:25:52< pydsigner> And have an email for bugs
20170502 00:25:52< vultraz_iOS> sure
20170502 00:25:58< vultraz_iOS> But i can't do it
20170502 00:26:04< vultraz_iOS> I don't have the know-how
20170502 00:28:20< vultraz_iOS> Ok, as an preemptive measure I'm enabling the tracker on GH.
20170502 00:29:05< matthiaskrgr> 1458 hosted projects on gna 
20170502 00:29:23< vultraz_iOS> I think we should start posting new bugs there
20170502 00:31:16< matthiaskrgr> first? :> 
20170502 00:32:04< matthiaskrgr> well ok, I cheated, I just posted a bug I already had posted on gna :P
20170502 00:32:35< sevu> you .P I was thinking about posting one two, but I had none in mind
20170502 00:33:01< matthiaskrgr> ;)
20170502 00:33:26< matthiaskrgr> mmhr but normal users cant set categories etc for bugs, right? 
20170502 00:33:28< matthiaskrgr> :/ 
20170502 00:35:34< matthiaskrgr> uh wow why am I a gna member since 2012 
20170502 00:35:47< matthiaskrgr> o.o
20170502 00:36:58< matthiaskrgr> anyway, you can poke me if you want me to repost all my reports go github, if I find a bit more time I can also check if they are still present while I'm at it 
20170502 00:37:24< vultraz_iOS> I don't think that should be necessary right now
20170502 00:37:29< vultraz_iOS> just post all new ones on GH
20170502 00:37:38< vultraz_iOS> likewise for sigurd and shiki
20170502 00:38:04< matthiaskrgr> oki 
20170502 00:40:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170502 00:44:35< irker324> wesnoth: Charles Dang wesnoth:master f4a34cc58d2d / src/editor/controller/editor_controller.cpp: Editor: fixed palette button overlay disappearing when a dialog is open https://github.com/wesnoth/wesnoth/commit/f4a34cc58d2d29cc1d07a7fcd44ea98d7c8f8b6b
20170502 00:53:20< celticminstrel> vultraz_iOS: Your 568c13f may seem like it changes nothing, but it actually does.
20170502 00:53:28< celticminstrel> (Probably nothing important, but...)
20170502 00:53:37< vultraz_iOS> hm?
20170502 00:53:42< pydsigner> https://github.com/mypaint/mypaint/issues/3
20170502 00:54:08< celticminstrel> With a template, only the members that are actually used are instantiated.
20170502 00:54:12< celticminstrel> (Virtual members are always used.)
20170502 00:54:42< celticminstrel> ^template class
20170502 00:54:54< celticminstrel> But if you explicitly instantiate it, all members are instantiated.
20170502 00:55:05< vultraz_iOS> I see
20170502 00:55:29< celticminstrel> I doubt it matters here, though.
20170502 00:56:00< celticminstrel> Looking at it... most of the members are virtual, and the ones that might not be seem like they'd be called by the virtual ones.
20170502 00:56:47< celticminstrel> You know, it might be nice to hide the palette button altogether when the selected palette has no groups.
20170502 00:57:45< celticminstrel> ...eh? How is 1013 possible? o.o
20170502 00:58:09< celticminstrel> Oh, there it is.
20170502 00:58:15< celticminstrel> When did someone enable issues?
20170502 00:58:33< vultraz_iOS> just now
20170502 00:58:49< vultraz_iOS> gna's security cert has expired
20170502 00:59:24< celticminstrel> Well, if we're switching, all GNA bugs need to be transferred, too.
20170502 00:59:29< celticminstrel> Especially open ones.
20170502 00:59:44< celticminstrel> Closed ones maybe could just be archived somewhere and not transferred.
20170502 01:00:04< pydsigner> Unfortunately I don't think there's an easy way to move the bugs
20170502 01:00:22< pydsigner> Probably the best thing we can get it is to scrape the website
20170502 01:00:36< vultraz_iOS> you can export them i think
20170502 01:01:03< celticminstrel> They can be exported, yes. zookeeper did it a few weeks ago.
20170502 01:01:48< pydsigner> Oh ok
20170502 01:02:05< pydsigner> What format are they in?
20170502 01:02:18< celticminstrel> I don't remember, some XML thing maybe?
20170502 01:02:24< pydsigner> Ew
20170502 01:04:14< celticminstrel> I can't see anywhere where I can download them, maybe I don't have enough permissions.
20170502 01:21:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 01:25:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170502 01:32:40< celticminstrel> https://forums.wesnoth.org/viewtopic.php?f=16&t=45320
20170502 01:33:35< celticminstrel> vultraz_iOS: ISTR there was a service that allows anonymously posting bugs on github.
20170502 01:33:41< celticminstrel> (Nothing to do with above link)
20170502 01:35:37-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 255 seconds]
20170502 01:37:38-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170502 01:39:27< celticminstrel> I wonder if there's a possibility of updating the forum to phpbb3.
20170502 01:40:01< celticminstrel> Though doing so might break the 1.12 MP server authentication...
20170502 01:40:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170502 01:43:50< celticminstrel> Oh wait, I'm dumb. It was upgraded, I think.
20170502 01:44:37< celticminstrel> <_<
20170502 01:44:44-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has joined #wesnoth-dev
20170502 01:44:46< celticminstrel> Still, when was it last updated, I wonder.
20170502 01:45:01< gfgtdf> celticminstrel: yute sure you can  download go to bugs->export
20170502 01:45:39< celticminstrel> Oh there it is.
20170502 01:49:50< celticminstrel> Wait, what was that about a board member quitting.
20170502 01:50:04 * celticminstrel just reading old forum topics.
20170502 01:50:40< gfgtdf> i thought vultraz_iOS is the only actuive 'board' member?
20170502 01:51:12< vultraz_iOS> iceiceice quit
20170502 01:51:17< vultraz_iOS> doofus replaced him
20170502 01:51:26< vultraz_iOS> the board is now me, dave, jetrel, and doofus01
20170502 02:02:33-!- sevu [~Unknown@p5485791F.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170502 02:11:08< irker324> wesnoth: Charles Dang wesnoth:master 27912cd71649 / src/editor/map/context_manager.cpp: Editor: add an initial side when creating a new scenario https://github.com/wesnoth/wesnoth/commit/27912cd71649b4af02c8b39bc992f09addb9e619
20170502 02:11:11< irker324> wesnoth: Charles Dang wesnoth:master a31f62b8bc2e / / (4 files in 3 dirs): Editor New Map: set the title based on whether a new map or scenario is being cr https://github.com/wesnoth/wesnoth/commit/a31f62b8bc2e6c705c27c487fd86f867fba460d9
20170502 02:16:37< celticminstrel> Ooh, good idea.
20170502 02:25:36< vultraz_iOS> seems to sometimes be a crash when exiting the editor...
20170502 02:25:42< vultraz_iOS> or switching a map
20170502 02:25:43< vultraz_iOS> not sure
20170502 02:25:46< vultraz_iOS> can't reliably repro
20170502 02:29:29-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170502 02:38:01< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 55593b493fd5 / / (6 files in 4 dirs): Refactor hash.?pp to have an interface more like the removed md5.?pp and sha1.?p https://github.com/wesnoth/wesnoth/commit/55593b493fd5a55ca948be8fed869df5a94c6bfe
20170502 02:38:49< celticminstrel> I think I'll probably squash the branch down to around three commits once it all works.
20170502 02:39:09< celticminstrel> 1: Everything I did before starting to bring in a new dependency.
20170502 02:39:29< celticminstrel> 2: Bring in the new dependency and use it for the hashes.
20170502 02:39:50< celticminstrel> 3: Use AES and key-expansion (not yet pushed).
20170502 02:41:00< celticminstrel> vultraz_iOS: Does the recall dialog show the current moves of the unit? It should probably show only the max moves.
20170502 02:41:13< vultraz_iOS> dunno, why?
20170502 02:41:22< celticminstrel> Because current moves is meaningless?
20170502 02:41:30< celticminstrel> Same with current health actually.
20170502 02:45:26-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170502 02:46:55< SigurdFD> recall shows current mp & health. Units can end up on recall via wml and have less than max for each
20170502 02:47:24< celticminstrel> But once you recall them, those numbers are clobbered, so there's no point in showing them.
20170502 02:47:31< celticminstrel> MP goes to 0 and health to max.
20170502 02:48:42< SigurdFD> I'm not sure about that being the case
20170502 02:49:02< celticminstrel> ???
20170502 02:50:13 * celticminstrel exported 648 open GNA bugs.
20170502 02:51:52< SigurdFD> should I repost my hotkey bug to github? I put it on gna right before cert expired
20170502 02:52:48< vultraz_iOS> if you want
20170502 02:52:50< celticminstrel> ^
20170502 02:53:03< celticminstrel> I see 6 bugs submitted by Sigurd in this dump.
20170502 02:53:10< celticminstrel> Oh wait, only two bugs.
20170502 02:53:19< celticminstrel> The other four were only modified by Sigurd.
20170502 02:53:34< celticminstrel> Which most likely means he commented on them, I guess?
20170502 02:55:00< celticminstrel> The second one is 18873 which I guess is a pretty old bug.
20170502 02:55:27-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170502 02:55:29< SigurdFD> celticminstrel: tested, it does make mp go to 0 and health to max
20170502 03:08:42< celticminstrel> vultraz_iOS: I made a few more issue labels, but feel free to recolour/rename them.
20170502 03:09:34 * celticminstrel added 6 in total.
20170502 03:09:54< celticminstrel> (Based on the GNA statuses.)
20170502 03:10:03< vultraz_iOS> Alright
20170502 03:10:30< celticminstrel> Should probably also add labels based on the GNA item groups... but there's so many of those...
20170502 03:10:52< celticminstrel> Oh right, we might want to add "bug" and "feature" too?
20170502 03:11:01< celticminstrel> And OS labels?
20170502 03:11:27< celticminstrel> And maybe Priority/Severity?
20170502 03:11:44< celticminstrel> Generally I'd say labels in the same category should be the same colour (possibly excepting the status category).
20170502 03:12:41< celticminstrel> Ah, the "enhancement" label already exists and basically means the same as "feature".
20170502 03:15:05< celticminstrel> SigurdFD: What was the GNA bug number for the one you just submitted?
20170502 03:15:25< celticminstrel> Also, do random people have the power to assign labels?
20170502 03:15:39< celticminstrel> I mean, can the submitter assign labels.
20170502 03:15:51< celticminstrel> If they don't have push access.
20170502 03:15:58< SigurdFD> nope
20170502 03:16:03< celticminstrel> Aw.
20170502 03:16:06< SigurdFD> not that I can see
20170502 03:17:01< celticminstrel> Oh, I found said issue number.
20170502 03:17:37< SigurdFD> ok
20170502 03:18:27-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20170502 03:18:34< celticminstrel> Ah. So there are 13 open bugs from Sigurd, not 2.
20170502 03:19:58< SigurdFD> wow
20170502 03:20:33< celticminstrel> This XML format is actually super-simple.
20170502 03:22:50< celticminstrel> The inability to attach files on github isn't great...
20170502 03:23:38< vultraz_iOS> celticminstrel: does our audio API set specific mods like volume/pitch etc
20170502 03:23:44< celticminstrel> ???
20170502 03:23:57< celticminstrel> It doesn't have track-specific volume if that's what you're asking.
20170502 03:24:06< celticminstrel> Implementing track-specific volume would mean, uh...
20170502 03:24:08< vultraz_iOS> celticminstrel: i've noticed if you listen to the raw sfx file in sounds/ they're alot softer than in-game
20170502 03:24:22< celticminstrel> Setting the volume when the tracks starts playing, basically.
20170502 03:24:44< celticminstrel> I dunno why that would be.
20170502 03:25:41< vultraz_iOS> and rather harsh
20170502 03:29:36< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 7518049a1752 / SConstruct src/hash.hpp: Fixup - we need libcrypto, not libssl https://github.com/wesnoth/wesnoth/commit/7518049a1752eed07106a6b2ed26cce379ec0431
20170502 03:29:46< celticminstrel> (Both are part of OpenSSL)
20170502 03:30:50< celticminstrel> Okay, back to GNA, we need a way to export the attachments.
20170502 03:31:18< celticminstrel> I mean, I suppose you could go through every bug in the database and manually download any attachments.
20170502 03:31:23< celticminstrel> But that's so much effort.
20170502 03:32:23< celticminstrel> Hmm, looks like scraping the files should be possible though...
20170502 03:32:34< celticminstrel> Still a lot of effort...
20170502 03:33:54< celticminstrel> vultraz_iOS: I wonder if we should encourage people to use gist for large logs such as the one in matthiaskrgr's issue.
20170502 03:34:03< vultraz_iOS> yes
20170502 03:34:20< celticminstrel> In that case, it should be mentioned when creating a new issue?
20170502 03:34:24< vultraz_iOS> not absolutely necessary though
20170502 03:35:10< SigurdFD> would having users post files to a site like https://filebin.ca/ and include the link in the github bug report work?
20170502 03:35:11< celticminstrel> Oh wait, maybe I can actually do that.
20170502 03:35:20< celticminstrel> SigurdFD: Probably.
20170502 03:35:45< celticminstrel> For screenshots I think I'd recommend an actual image host though, like imgur or tinypic.
20170502 03:36:23< SigurdFD> makes sense
20170502 03:37:46< celticminstrel> Hmm, github doesn't support adding a small blurb at the top of the issue form, so the only way to encourage it is to add something to CONTRIBUTING.md or to add an issue template.
20170502 03:37:57< celticminstrel> (The only way within github itself, I mean.)
20170502 03:38:41< celticminstrel> Which means...
20170502 03:38:53< celticminstrel> vultraz_iOS: Which one should I do?
20170502 03:39:25< vultraz_iOS> what does CONTRIBUTING.md do?
20170502 03:39:57< celticminstrel> Adds this blurb above the issue field: "Before you submit an issue, please review the guidelines for this repository."
20170502 03:40:04< celticminstrel> With a link to the it.
20170502 03:40:08< celticminstrel> ^to the file
20170502 03:40:57< vultraz_iOS> hmmm
20170502 03:41:09< vultraz_iOS> that would be optimal i think
20170502 03:41:12< vultraz_iOS> if we want to require gists
20170502 03:41:23< celticminstrel> Well, we're not requiring anything, just recommending it.
20170502 03:41:28< vultraz_iOS> perhaps say we recommend gists for long logs
20170502 03:41:34< vultraz_iOS> and say we encourage inline attachments
20170502 03:41:46< celticminstrel> "inline attachments"?
20170502 03:41:46< vultraz_iOS> not external links to dropbox etc
20170502 03:41:58< vultraz_iOS> yes you can attach directly to the issue
20170502 03:42:11< celticminstrel> ???
20170502 03:42:35< vultraz_iOS> you can attach by dragging into the text box
20170502 03:42:52< celticminstrel> Huh.
20170502 03:44:35< vultraz_iOS> celticminstrel: wonder if we should basically put the contents of https://wiki.wesnoth.org/ReportingBugs
20170502 03:44:37< vultraz_iOS> into a file
20170502 03:44:39< vultraz_iOS> s/a/the
20170502 03:44:44< celticminstrel> If a text file is attached, can you view it without downloading the file?
20170502 03:44:50< vultraz_iOS> not sure
20170502 03:47:37< SigurdFD> chrome wants to make me download an attached .txt instead of viewing it
20170502 03:47:57< Aginor> the server probably doesn't supply a nice mime-type
20170502 03:49:08< celticminstrel> SigurdFD: That's from github?
20170502 03:49:20< SigurdFD> yes
20170502 03:49:34< irker324> wesnoth: Celtic Minstrel wesnoth:master 0f0a245c5c55 / CONTRIBUTING.md: Add initial CONTRIBUTING file for the issue tracker https://github.com/wesnoth/wesnoth/commit/0f0a245c5c55c10c907f6290a283c36ae1e568d5
20170502 03:51:25-!- Kwandulin [~Kwandulin@p200300760F6D804824B637A877718B9E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 03:55:45< celticminstrel> vultraz_iOS: Were you going to recolour the new issue labels?
20170502 03:56:02< celticminstrel> I just let it randomly choose a colour for each label.
20170502 03:56:18< vultraz_iOS> they look alright
20170502 03:56:58< celticminstrel> If you say so?
20170502 03:57:26< celticminstrel> Well, I might do it later too.
20170502 03:57:58< vultraz_iOS> backport and confirmed look a little too close 
20170502 03:58:00< vultraz_iOS> er
20170502 03:58:01< vultraz_iOS> similar
20170502 03:58:02< celticminstrel> The one thing I definitely think should be changed is that "ready for testing" and "needs information" are practically the same colour.
20170502 03:58:35< celticminstrel> I don't think it's necessary for all labels to have a unique colour, mind you; it'd make sense to me for wontfix, invalid, duplicate to all be the same colour, for example.
20170502 03:58:37< vultraz_iOS> I dunno if we need all of those, though
20170502 03:58:46< celticminstrel> We need them if we want to import the GNA issues.
20170502 03:58:49< vultraz_iOS> :/
20170502 03:58:55< vultraz_iOS> curses
20170502 03:59:01< celticminstrel> Why curses?
20170502 03:59:54-!- atarocch [~atarocch@ip-64-134-98-13.public.wayport.net] has quit [Remote host closed the connection]
20170502 03:59:57< vultraz_iOS> I'd like it if we started over with an organizational method rather than importing the old one
20170502 04:00:57< celticminstrel> If you want to propose something, feel free, I guess.
20170502 04:01:18< vultraz_iOS> for example, this is the issue tracker
20170502 04:01:24< vultraz_iOS> why should we mark things as bug :\
20170502 04:01:40< celticminstrel> Because issue trackers also get feature requests.
20170502 04:01:52< vultraz_iOS> right
20170502 04:02:01< vultraz_iOS> but those should get a FR tag
20170502 04:02:10< celticminstrel> There might also be something that's neither a feature nor a bug.
20170502 04:02:16< SigurdFD> aren't 'bug' and 'confirmed' the same thing?
20170502 04:02:21< celticminstrel> No.
20170502 04:02:25< vultraz_iOS> those should get an Other tag
20170502 04:02:37< celticminstrel> "confirmed" means someone on the project has confirmed that the bug exists.
20170502 04:02:52< celticminstrel> It's roughly opposte to "works for me".
20170502 04:03:00< SigurdFD> one could add the bug label as the act of confirming
20170502 04:03:13< celticminstrel> It's a possibility, sure.
20170502 04:03:14< SigurdFD> was where I was coming from
20170502 04:03:40< celticminstrel> It's true that "confirmed" and "works for me" make no sense for feature requests.
20170502 04:03:48< celticminstrel> vultraz_iOS: Any objections to adding namespace prefixes to the labels?
20170502 04:04:07< vultraz_iOS> ?
20170502 04:04:08< SigurdFD> also, 'needs more info' and 'works for me' are kind of similar
20170502 04:04:27< celticminstrel> "s:postponed" or "status:postponed" instead of just "postponed".
20170502 04:04:30< celticminstrel> SigurdFD: You think so?
20170502 04:05:06< celticminstrel> I think "works for me" is "I tried this and didn't get the issue".
20170502 04:05:20< celticminstrel> Whereas with "needs more info" you probably can't even get to that point.
20170502 04:05:27< SigurdFD> hmmm.. ok
20170502 04:06:15 * celticminstrel pokes vultraz_iOS 
20170502 04:06:21< SigurdFD> I just look at the list of labels, and import issues aside, question if it should really have that many different lables
20170502 04:06:23< vultraz_iOS> uhhhh
20170502 04:06:27< vultraz_iOS> i don't think we need it
20170502 04:06:37< celticminstrel> I think it might become confusing if we don't have it though.
20170502 04:07:08< celticminstrel> Given that there's at least 3 supported platforms (which all need a label), around 14 "components" (which all need a label), and perhaps a few other things.
20170502 04:07:40< celticminstrel> Not sure if priority/severity is important enough to be a label... maybe not.
20170502 04:07:41< SigurdFD> maybe there should be an issue template in addition to the Contributing.md?
20170502 04:07:47< celticminstrel> SigurdFD: Maybe.
20170502 04:08:06< celticminstrel> Although "blocker" at least should probably be a label. I'll add that.
20170502 04:09:08< pydsigner> Remember, you can always add labels as they're needed ;)
20170502 04:10:53< irker324> wesnoth: Celtic Minstrel wesnoth:objectives_with_variables 030317b907ab / src/play_controller.cpp: fixup https://github.com/wesnoth/wesnoth/commit/030317b907ab5b4fdc3eaa96fe0477e006449662
20170502 04:26:11< vultraz_iOS> jesus christ
20170502 04:26:15< celticminstrel> ?
20170502 04:26:26< vultraz_iOS> TFW you spend two hours investigating a bug and then realize you were reading a variable wrong :|
20170502 04:26:36< celticminstrel> XD What?
20170502 04:27:01< vultraz_iOS> menu-editor-terrain vs editor-palette-groups
20170502 04:29:24< vultraz_iOS> or at least, I hope I've read it wrong or else I really have absolutely no idea how any of this works :P
20170502 04:35:57-!- JyrkiVesterinen [~JyrkiVest@87-100-195-197.bb.dnainternet.fi] has joined #wesnoth-dev
20170502 04:37:37-!- Kwandulin [~Kwandulin@p200300760F6D804824B637A877718B9E.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170502 04:38:54< vultraz_iOS> for the life of me...
20170502 04:39:08< vultraz_iOS> i can't figure out why the palette button doesn't get disabled :|
20170502 04:41:47< vultraz_iOS> ok... progress...
20170502 04:42:42< celticminstrel> Are you implementing my susggestion about palettes that don't have groups?
20170502 04:43:38< vultraz_iOS> what was that?
20170502 04:43:54< celticminstrel> Disable/hide the groups button?
20170502 04:44:52< vultraz_iOS> trying to
20170502 04:57:04< wedge009> Hmm, so gna's certificate has expired.
20170502 04:57:35< wedge009> gfgtdf: Sorry, which request was that?
20170502 04:57:44< wedge009> JyrkiVesterinen: I'll have a look momentarily.
20170502 05:00:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 05:01:30< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 4fc036ab7378 / SConstruct: Scons: Move libcrypto to base prerequisites https://github.com/wesnoth/wesnoth/commit/4fc036ab737863b78ce5aefcc329d494abfb15c5
20170502 05:02:56< celticminstrel> wedge009: Vultraz turned on GitHub Issues because of that.
20170502 05:03:15< wedge009> Are we moving there then? I saw something above about exporting issue?
20170502 05:03:17< wedge009> issues
20170502 05:04:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170502 05:04:39< celticminstrel> Well, since no-one has done any work on moving to something else, I guess we are?
20170502 05:06:49< vultraz_iOS> gaaah
20170502 05:07:02< vultraz_iOS> why the hell does empty_palette::draw get called constantly
20170502 05:11:25< wedge009> I could help move things across... but is going to be a manual process? I'm so buggered with work these days that I don't have much time for Wesnoth work at home - kinda want to avoid staring at a screen too much. Maybe we say GitHub is the new place to report bugs and stop accepting new ones on gna?
20170502 05:11:43< wedge009> Also, I thought there were objections to using GitHub, otherwise I might have put my hand up (so to speak) earlier.
20170502 05:13:11< vultraz_iOS> "Maybe we say GitHub is the new place to report bugs and stop accepting new ones on gna?" already said as much on the forums
20170502 05:14:13-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170502 05:15:40< celticminstrel> wedge009: I think the process could be scripted using GitHub's API.
20170502 05:15:59< wedge009> vultraz_iOS: Is it official then?
20170502 05:16:02< celticminstrel> And the GNA output is a very simple XML format.
20170502 05:16:22< wedge009> Should http://bugs.wesnoth.org/ redirect to GitHub instead?
20170502 05:16:33< vultraz_iOS> yes
20170502 05:16:36< wedge009> celticminstrel: That sounds encouraging.
20170502 05:16:42< celticminstrel> So you just need to map the GNA XML to GitHub API JSON and send a POST request.
20170502 05:16:59< celticminstrel> The hardest issue is deciding exactly how that mapping works.
20170502 05:19:22< celticminstrel> GNA didn't support anything resembling milestones, huh?
20170502 05:20:11< celticminstrel> One of the things needed is a mapping from GNA username to GitHub username.
20170502 05:21:05< celticminstrel> For everyone who's in the "Assigned to" dropdown on GNA.
20170502 05:22:22< celticminstrel> Hmm, there are four private issues on GNA...
20170502 05:22:45< celticminstrel> (Private open issues, I mean.)
20170502 05:23:58< celticminstrel> https://gna.org/bugs/index.php?19074 https://gna.org/bugs/index.php?20815 https://gna.org/bugs/index.php?21175 https://gna.org/bugs/index.php?25274
20170502 05:24:27< celticminstrel> One of those is even very recent.
20170502 05:24:59< celticminstrel> What's the reason for these being private? Should they be transferred to GitHub, or not?
20170502 05:25:32< vultraz_iOS> private bugs are usually security bugs
20170502 05:25:40< celticminstrel> Also, are they still a problem?
20170502 05:26:08< celticminstrel> Sounds like 20815 might be fixed at least.
20170502 05:26:21< celticminstrel> And 19074 doesn't sound like a security bug to me.
20170502 05:26:44< vultraz_iOS> i can't guarantee the former is fixed
20170502 05:28:55-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit [Ping timeout: 252 seconds]
20170502 05:29:21< celticminstrel> vultraz_iOS: Sounds like something that could be tested, possibly with asan?
20170502 05:30:12< vultraz_iOS> the only possible case is the in-game chat
20170502 05:30:15< vultraz_iOS> matthiaskrgr could test
20170502 05:32:24< celticminstrel> vultraz_iOS: Did you try the reproduction method from the first comment?
20170502 05:32:31< vultraz_iOS> yes
20170502 05:32:50< celticminstrel> In that case I think it's probably fixed?
20170502 05:33:03< celticminstrel> We did update SDL_TTF since it was reported, after all.
20170502 05:33:23< celticminstrel> You can't reproduce it, and wedge009 can't reproduce it...
20170502 05:34:15< celticminstrel> Wait, is SDL_ttf 2.0.11 SDL2?
20170502 05:35:21< vultraz_iOS> who knows
20170502 05:35:27< JyrkiVesterinen> No, it's not.
20170502 05:35:34< JyrkiVesterinen> 2.0.12 is the first SDL2 version.
20170502 05:35:39< JyrkiVesterinen> https://www.libsdl.org/projects/SDL_ttf/
20170502 05:36:01< celticminstrel> Ah.
20170502 05:36:22< wedge009> I was using that version as well - I presume you're talking about https://gna.org/bugs/index.php?20815?
20170502 05:36:25< vultraz_iOS> then we should update
20170502 05:36:45< wedge009> 2.0.14, that is.
20170502 05:42:08< celticminstrel> The code shadowm pointed out on the issue still seems to be in SDL_ttf: https://hg.libsdl.org/SDL_ttf/annotate/3b93536d291a/SDL_ttf.c#l1792 (also on line 2060)
20170502 05:47:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170502 05:56:08< vultraz_iOS> zookeeper: is it just me or are units in the editor drawn slightly transparent
20170502 05:57:05< zookeeper> i wouldn't know since i can't test since i get a crash when adding a new side.
20170502 05:57:39< vultraz_iOS> fixed that yesterday
20170502 05:58:14< vultraz_iOS> even made it so a new scenario has an initial side
20170502 06:01:09-!- JyrkiVesterinen [~JyrkiVest@87-100-195-197.bb.dnainternet.fi] has quit [Quit: .]
20170502 06:05:29-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170502 06:05:39< zookeeper> so should we disable posting new bugs on gna then?
20170502 06:06:29< zookeeper> then someone has to do forum/frontpage announcement, etc etc
20170502 06:06:52< zookeeper> oh. you have.
20170502 06:06:58< celticminstrel> And if bugs.wesnoth.org is to be redirected, I think Rhonda needs to be contacted.
20170502 06:07:12< celticminstrel> Or was it Soliton?
20170502 06:11:09< vultraz_iOS> holy hell FINALLY
20170502 06:11:11< celticminstrel> zookeeper: Disabling posting sounds like a good idea, I guess.
20170502 06:11:14< celticminstrel> vultraz_iOS: What?
20170502 06:11:17< vultraz_iOS> turns out the problem was....
20170502 06:11:23< vultraz_iOS> gui1 buttons reject "" as an image path :|
20170502 06:11:47< celticminstrel> What?
20170502 06:11:55-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170502 06:12:03< vultraz_iOS> in order to clear the overlay it was being st to ""
20170502 06:12:06< vultraz_iOS> but gui1 rejected that
20170502 06:15:13< zookeeper> ok, i set it so that only project members can submit/comment on gna bug reports now. so please don't :p
20170502 06:15:47< celticminstrel> Is there any way to tell if anyone did in the past... six hours or so?
20170502 06:16:00< celticminstrel> Since around the time vultraz_iOS enabled GitHub issues.
20170502 06:16:10< zookeeper> dunno
20170502 06:16:26< celticminstrel> Huh, 6 hours is apparently about right.
20170502 06:18:29< zookeeper> vultraz_iOS, yes, units seem a bit transparent. surely intentionally.
20170502 06:18:48< celticminstrel> I could see that being intentional, yeah.
20170502 06:22:36-!- Elsi [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 260 seconds]
20170502 06:29:12< irker324> wesnoth: Charles Dang wesnoth:master 03841cb1a0c4 / src/editor/palette/ (item_palette.cpp terrain_palettes.cpp unit_palette.cpp): Editor: use emplace_back for palette item_group setup https://github.com/wesnoth/wesnoth/commit/03841cb1a0c47f4b13a9c4163a69e1427b426036
20170502 06:29:15< irker324> wesnoth: Charles Dang wesnoth:master 1000d9684ab7 / src/widgets/button.cpp: GUI1: allow buttons to accept "" as a valid image path https://github.com/wesnoth/wesnoth/commit/1000d9684ab77f47976a6ab1cc6dc452a29472c4
20170502 06:29:18< irker324> wesnoth: Charles Dang wesnoth:master e64727271b09 / src/editor/palette/palette_manager.cpp: Editor: 'unhide' palette when drawing contents https://github.com/wesnoth/wesnoth/commit/e64727271b09444fc3f658659b95b9d8c94c1db0
20170502 06:29:21< irker324> wesnoth: Charles Dang wesnoth:master a29f3bb24432 / src/editor/palette/ (empty_palette.hpp location_palette.hpp): Editor: remove 'Change Palette Group' entry from empty and location palettes https://github.com/wesnoth/wesnoth/commit/a29f3bb244327087ef3b08543365fb1008a29d1e
20170502 06:29:24< irker324> wesnoth: Charles Dang wesnoth:master b04a9728a0a4 / src/editor/palette/empty_palette.hpp: Editor: keep empty palette group list as static https://github.com/wesnoth/wesnoth/commit/b04a9728a0a4387f715259297fdc97fef6640d3c
20170502 06:32:08< vultraz_iOS> Location palette still a little buggy
20170502 06:33:53< celticminstrel> You mean how the label randomly shifts?
20170502 06:34:00< celticminstrel> Also it doesn't have a scrollbar.
20170502 06:34:36< celticminstrel> BTW, did you want me to fix/finish the grid listbox?
20170502 06:34:46< vultraz_iOS> yes
20170502 06:34:55< vultraz_iOS> the label shift is gone
20170502 06:35:03< vultraz_iOS> since you can't trigger it now
20170502 06:35:06< celticminstrel> Was there anything in particular you wanted to use it for?
20170502 06:35:15< vultraz_iOS> gri dlayout of units in faction select
20170502 06:35:19< celticminstrel> Uh, the label shift happened when I clicked one of those buttons...
20170502 06:35:19< vultraz_iOS> and help
20170502 06:35:24< celticminstrel> Okay...
20170502 06:35:47< vultraz_iOS> hm
20170502 06:35:48< celticminstrel> Maybe you could do that in a branch?
20170502 06:36:04< vultraz_iOS> oh, for you totest?
20170502 06:36:33< celticminstrel> Well, if I'm fixing it I need something to test on anyway.
20170502 06:36:56< celticminstrel> I think it's nicer if it's something we actually want, rather than just a random test debug dialog.
20170502 06:37:14-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170502 06:37:49< vultraz_iOS> i could do that
20170502 06:39:43< celticminstrel> vultraz_iOS: Pretty sure that last commit means that there are now many copies of empty_group_vector.
20170502 06:39:54< vultraz_iOS> what?
20170502 06:40:00< vultraz_iOS> no?
20170502 06:40:07< vultraz_iOS> that's the opposite of what i wanted
20170502 06:40:19< celticminstrel> When you put a file-static variable in a header, you get a separate copy for every file that includes that header.
20170502 06:41:05< vultraz_iOS> D:
20170502 06:41:07< vultraz_iOS> nuuuu
20170502 06:41:13< celticminstrel> That's why there used to be a recommendation against including <iostream> except when you absolutely had to.
20170502 06:42:50< celticminstrel> Sometimes this isn't a problem; I think the Boost placeholders are file-statics, for example, but they're trivial types with no storage so it doesn't really matter.
20170502 06:44:01< celticminstrel> (I'm pretty sure this is how file-statics work.)
20170502 06:44:22-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit []
20170502 06:47:19< irker324> wesnoth: Charles Dang wesnoth:master fd2487fadfb9 / src/editor/map/map_context.hpp: Editor/Map Context: added a getter for a default context name https://github.com/wesnoth/wesnoth/commit/fd2487fadfb911afdf5d316a031b50825e36fd63
20170502 06:47:22< irker324> wesnoth: Charles Dang wesnoth:master 19836a03542d / src/editor/map/context_manager.cpp: Editor: fixed new scenarios being listed as new maps in the quit confirmation di https://github.com/wesnoth/wesnoth/commit/19836a03542dd2e56c4d9f496b17875585644df5
20170502 06:47:25< irker324> wesnoth: Charles Dang wesnoth:master 8177e13d1d90 / src/editor/map/context_manager.cpp: Editor: deployed default context name getter https://github.com/wesnoth/wesnoth/commit/8177e13d1d905177c25946adc5f561f39a7e6fbc
20170502 06:48:35< celticminstrel> Please don't remove the surrounding parentheses.
20170502 06:48:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 06:48:50< celticminstrel> At least not in the menu.
20170502 06:49:00< vultraz_iOS> Why?
20170502 06:49:33< celticminstrel> It's sort of like, the parentheses serve as an indication that it has never been saved?
20170502 06:50:01< vultraz_iOS> going to use better formatting
20170502 06:50:10< celticminstrel> Also, fd2487 is bad.
20170502 06:50:25< vultraz_iOS> whyyy
20170502 06:51:02< celticminstrel> Because it means you've moved the string from the wesnoth-editor textdomain to the wesnoth textdomain.
20170502 06:51:13< celticminstrel> Best fix is to move it to the source file.
20170502 06:51:24< vultraz_iOS> curses
20170502 06:51:46< celticminstrel> As a general rule, it's best to avoid translatable strings in headers.
20170502 06:52:03< celticminstrel> Sometimes it might be unavoidable though.
20170502 06:52:15< celticminstrel> Like in that one case of a template.
20170502 06:52:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170502 06:53:04< vultraz_iOS> what would be a good indicator of 'unsaved'
20170502 06:53:23< celticminstrel> And defining GETTEXT_DOMAIN in a header (which would also seem to fix it) is not a good idea, because it might accidentally change the textdomain of strings in other files that include the header.
20170502 06:53:52< celticminstrel> vultraz_iOS: Italicize the name and add an asterisk to the end?
20170502 06:54:20< vultraz_iOS> k
20170502 06:56:24< celticminstrel> Isn't the name usually the full filepath?
20170502 06:57:33< vultraz_iOS> yes
20170502 06:57:35< vultraz_iOS> we should fix that
20170502 06:57:54< celticminstrel> If it's a scenario, use the scenario name.
20170502 06:57:57< celticminstrel> If it's a map:
20170502 06:58:15< celticminstrel> 1) Check if it's relative to the game config dir. If so, truncate it from there.
20170502 06:58:32< celticminstrel> 2) Check if it's relative to the userdata dir. If so, truncate it from there and put a tilde in front.
20170502 06:59:16< celticminstrel> 3) Possibly, if it's in the editor/map dir, just show the filename.
20170502 06:59:29< vultraz_iOS> blah
20170502 06:59:30< vultraz_iOS> so much work
20170502 06:59:33< celticminstrel> Does that sound good?
20170502 06:59:59< celticminstrel> Basically, for maps, show the path you'd include it by from WML.
20170502 07:00:13< celticminstrel> But show the full path if it's not in either of those two locations.
20170502 07:00:20< vultraz_iOS> and scenarios?
20170502 07:00:22< celticminstrel> Possibly ellipsized.
20170502 07:00:30< celticminstrel> I mentioned scenarios before maps. :P
20170502 07:01:02< vultraz_iOS> why not use map name
20170502 07:01:05< celticminstrel> Ellipsizing a path should of course cut out the middle, not the beginning or end.
20170502 07:01:06< celticminstrel> Map name?
20170502 07:01:16< vultraz_iOS> if the map is saved and has a name
20170502 07:01:22< celticminstrel> ???
20170502 07:02:35< vultraz_iOS> noidjiowqjdijwqidjwiejfjeivweiojvo
20170502 07:03:33< celticminstrel> Maps don't have names?
20170502 07:03:41< vultraz_iOS> filenames
20170502 07:03:52< celticminstrel> ...
20170502 07:03:59< celticminstrel> Isn't that basically what I've been saying?
20170502 07:04:04< celticminstrel> Use the filename?
20170502 07:04:23< celticminstrel> BTW, is the filename used when listing the map in MP Create, too?
20170502 07:04:55< celticminstrel> If you wanted, we could add the ability for maps to have names. IIRC, the map header is still supported even though it's no longer used.
20170502 07:05:11< vultraz_iOS> yes
20170502 07:05:37< celticminstrel> What I was proposing for maps boils down to "use the WML-visible file path".
20170502 07:06:43< celticminstrel> So, ~addons/Your_Campaign/maps/test.map, or ~editor/maps/your_map.map, or campaigns/tutorial/maps/01_Tutorial_part_1.map
20170502 07:09:09< Rhonda> celticminstrel: Only in parts.  The redirect is in the .htaccess file of the website container as far as I know, so anyone with access to there can do it.
20170502 07:09:30< celticminstrel> Ah.
20170502 07:09:54 * celticminstrel has no idea what "only in parts" means, though.
20170502 07:14:49< celticminstrel> Oh hey, login_save_crypt finally passed.
20170502 07:14:59< celticminstrel> Or at least, the scons builds passed.
20170502 07:15:05< celticminstrel> But not the Mac build.
20170502 07:15:08< celticminstrel> Which is also scons.
20170502 07:15:22< celticminstrel> I never expected the CMake builds to pass since I hadn't updated CMake yet.
20170502 07:22:25< zookeeper> umm... so what about http://librelist.com/ ?
20170502 07:22:49< zookeeper> no web interface for browsing the archives of course
20170502 07:23:01< zookeeper> oh wait, there actually is
20170502 07:23:40< celticminstrel> Oh nice.
20170502 07:24:09< celticminstrel> So this one hosts it for you too.
20170502 07:24:53< celticminstrel> Is there any list administration?
20170502 07:25:05< celticminstrel> Kinda looks like there isn't.
20170502 07:25:10< zookeeper> doesn't look like it, seems pretty minimal.
20170502 07:25:14< celticminstrel> Mmhm.
20170502 07:25:32< celticminstrel> Do you think that's a problem?
20170502 07:25:49< zookeeper> what kind of administration would we need?
20170502 07:25:54< zookeeper> i can't think of any
20170502 07:25:55< celticminstrel> No clue!
20170502 07:26:18< celticminstrel> I suppose the only thing I could maybe think of would be auto-subscribing all the old subscribers.
20170502 07:27:03< celticminstrel> But maybe that's not really necessary as long as a message about the shift is sent to each of the old mailing lists?
20170502 07:27:19< zookeeper> yep
20170502 07:27:19< matthiaskrgr> 07:30 < vultraz_iOS> matthiaskrgr could test
20170502 07:27:24< matthiaskrgr> I could not view any of these issues lol
20170502 07:27:31< matthiaskrgr> (item is private) 
20170502 07:27:34< vultraz_iOS> oh right
20170502 07:27:37< vultraz_iOS> it's alright
20170502 07:27:42< vultraz_iOS> we've concluded it's fixed
20170502 07:27:50< celticminstrel> vultraz_iOS: Uh. Since when?
20170502 07:28:01< vultraz_iOS> you did earlier
20170502 07:28:01< matthiaskrgr> is it buffer overflows around lobby code again? :P
20170502 07:28:19< celticminstrel> Did I?
20170502 07:28:24< celticminstrel> I don't remember confirming such a thing.
20170502 07:28:40< vultraz_iOS> no
20170502 07:29:05< zookeeper> at least that librelist site hasn't apparently been updated since 2009, which i guess in this case can just be a mark of it being really venerable and steadfast, i suppose? :p
20170502 07:31:03< vultraz_iOS> :|
20170502 07:32:18< celticminstrel> zookeeper: All the lists on that site haven't been posted to since 2015. No idea if that's relevant though.
20170502 07:34:02 * celticminstrel pokes matthiaskrgr 
20170502 07:35:42< zookeeper> doesn't sourceforge provide mailing lists too?
20170502 07:35:45< celticminstrel> vultraz_iOS: Random thought... perhaps the switch to Lato influenced it?
20170502 07:35:56< vultraz_iOS> perhaps
20170502 07:36:18< pydsigner> We can always go back to OpenSans :]
20170502 07:36:52< vultraz_iOS> NEIN
20170502 07:37:03< vultraz_iOS> oh wait that's not DVS so it's accaptable 
20170502 07:37:06< vultraz_iOS> acceptable 
20170502 07:37:32< celticminstrel> You shouldn't say it's acceptable if you don't even know what it is?
20170502 07:37:38 * celticminstrel doesn't know what it is, at least.
20170502 07:42:30< vultraz_iOS> ah crap
20170502 07:42:31< vultraz_iOS> BUG
20170502 07:42:38< celticminstrel> Yay!
20170502 07:42:49 * celticminstrel slips it down vultraz_iOS's shirt.
20170502 07:43:00< vultraz_iOS> oh wait
20170502 07:43:56< pydsigner> Down the back with the roaches!\
20170502 07:45:11< celticminstrel> Hmm, the Mac build is mysteriously missing sha.h? :S
20170502 07:48:46< vultraz_iOS> celticminstrel: https://1drv.ms/i/s!As9hRC_GxjKKpWR33uF7nSnX_X7X
20170502 07:48:53< vultraz_iOS> decided to truncate fully for now
20170502 07:49:00< zookeeper> celticminstrel, oh and of course you could work out if any bug report stuff was posted during those 6 hours here, right? https://mail.gna.org/public/wesnoth-bugs/2017-05/index.html
20170502 07:49:43< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 7e41c3a2dd94 / utils/travis/install_deps.sh: Travis Mac: Try installing OpenSSL with homebrew? https://github.com/wesnoth/wesnoth/commit/7e41c3a2dd94eb8c4d6b88f8b97a9275e6bd66c5
20170502 07:49:45< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 51445cc70709 / CMakeLists.txt: Attempt to update CMake https://github.com/wesnoth/wesnoth/commit/51445cc7070945e71782ac2fc8072f9f5ae953af
20170502 07:50:42< celticminstrel> vultraz_iOS: Oh, you're using the details field?
20170502 07:50:49< vultraz_iOS> yup
20170502 07:50:57< celticminstrel> Not sure I like the red/green though...
20170502 07:51:09< celticminstrel> Actually, if I think about it, it's probably bad.
20170502 07:51:18< celticminstrel> But even not considering that, I think I don't like it.
20170502 07:51:35< celticminstrel> Oh, it's also italicized, so maybe not quite as bad.
20170502 07:51:40< vultraz_iOS> white/green?
20170502 07:51:49< vultraz_iOS> er
20170502 07:51:51< vultraz_iOS> red/white
20170502 07:53:32< celticminstrel> zookeeper: Oh, thanks. Seems like almost nothing happened since my export, then.
20170502 07:53:52< celticminstrel> vultraz_iOS: Hmm, not sure. Maybe?
20170502 07:53:59< zookeeper> oh, duh, i _can_ view the mailing list subscriber lists... i just missed that part of the listinfo page
20170502 07:55:45< zookeeper> ok, i got the lists for all except -hungtrans and -releases
20170502 08:01:24< celticminstrel> Is -hungtrans inactive?
20170502 08:01:24< celticminstrel> No posts since 2014.
20170502 08:01:26< celticminstrel> I think I'd call that inactive.
20170502 08:01:26< zookeeper> more or less, yeah
20170502 08:01:26< celticminstrel> Why not releases?
20170502 08:01:26< zookeeper> because i have no access
20170502 08:01:26< celticminstrel> Ah.
20170502 08:01:32< celticminstrel> Should we grab the mailing-list archives, too? Seems like it'd be a bit of a pain though since it's one zip per list per year.
20170502 08:01:34-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ogazjasbmomxpgew] has quit [Ping timeout: 264 seconds]
20170502 08:01:34-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has quit [Ping timeout: 264 seconds]
20170502 08:01:52-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20170502 08:02:05-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-scjealgdwuidapoh] has joined #wesnoth-dev
20170502 08:02:29-!- matthiaskrgr is now known as Guest99195
20170502 08:06:16-!- Guest99195 [matthiaskr@gateway/shell/panicbnc/x-scjealgdwuidapoh] has quit [Changing host]
20170502 08:06:16-!- Guest99195 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170502 08:06:16-!- Guest99195 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20170502 08:06:16-!- Guest99195 [matthiaskr@gateway/shell/panicbnc/x-scjealgdwuidapoh] has joined #wesnoth-dev
20170502 08:06:16-!- Guest99195 is now known as matthiaskrg
20170502 08:06:16< irker324> wesnoth: Charles Dang wesnoth:master 3448e48aad0d / src/editor/map/ (map_context.cpp map_context.hpp): Fixup fd2487f (move implementation to cpp) https://github.com/wesnoth/wesnoth/commit/3448e48aad0dbb9f6101e9632160de4f7334343c
20170502 08:06:16< irker324> wesnoth: Charles Dang wesnoth:master bfb18423b987 / src/hotkey/command_executor.cpp: Allow formatting in menu items https://github.com/wesnoth/wesnoth/commit/bfb18423b98758d0be32a344eabf416d9cc8d940
20170502 08:06:16< irker324> wesnoth: Charles Dang wesnoth:master 88d103567323 / src/editor/map/context_manager.cpp: Editor: redesigned open windows menu https://github.com/wesnoth/wesnoth/commit/88d103567323bcc26c0a721863b4bd627f023867
20170502 08:06:16< irker324> wesnoth: Charles Dang wesnoth:master ff1a78c246eb / src/editor/map/context_manager.cpp: Editor: display map name in quit confirmation, if available https://github.com/wesnoth/wesnoth/commit/ff1a78c246eb57da62b5dedc910fd3754c4ae819
20170502 08:06:16< irker324> wesnoth: Charles Dang wesnoth:master 877c788d2512 / src/tests/gui/test_gui2.cpp: Fixup tests for a31f62b https://github.com/wesnoth/wesnoth/commit/877c788d25127f54150f5db6b29eb7f8d729e8f6
20170502 08:06:16-!- matthiaskrg is now known as mattiaskrgr
20170502 08:08:48< vultraz_iOS> mattiaskrgr: ^
20170502 08:08:55< celticminstrel> Eh?
20170502 08:09:03< vultraz_iOS> last commit
20170502 08:09:10< celticminstrel> Oh.
20170502 08:31:30-!- celticminstrel is now known as celmin|sleep
20170502 08:31:35< Rhonda> celticminstrel: In parts that I still could do it if it's a timing thing although that file is handled mostly by others. :)  Or that if it stays with us it might make sense to add the domain to the letsencrypt certificate (which would be mine to do).
20170502 08:36:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 08:41:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20170502 08:46:37-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170502 08:48:30-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Quit: .]
20170502 09:04:04-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 260 seconds]
20170502 09:07:33-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170502 09:18:13-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170502 09:22:44-!- sevu [~Unknown@p54856E7B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 09:26:18< irker324> wesnoth: Charles Dang wesnoth:master 22a99d4472d6 / src/editor/map/context_manager.cpp: Fixup ff1a78c https://github.com/wesnoth/wesnoth/commit/22a99d4472d65546f7b0bc41034dcc04bcb8cff5
20170502 09:26:21< irker324> wesnoth: Charles Dang wesnoth:master f983f22981fa / src/editor/map/context_manager.cpp: Fixup 88d1035 https://github.com/wesnoth/wesnoth/commit/f983f22981fa61feccf4ceb7bb32a3233c09a0b1
20170502 09:28:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170502 10:18:34< irker324> wesnoth: Charles Dang wesnoth:master e3c9d17035ff / src/editor/map/context_manager.cpp: Editor: apply formatting to Areas and Sides menus https://github.com/wesnoth/wesnoth/commit/e3c9d17035ff6a0e60f0a4f6573f5c80ca607265
20170502 10:18:37< irker324> wesnoth: Charles Dang wesnoth:master 09e4bfcaeef9 / src/editor/map/context_manager.cpp: Editor: show Window indexes starting from 1 https://github.com/wesnoth/wesnoth/commit/09e4bfcaeef9eb34973eb028295f56f559edc876
20170502 10:32:37< irker324> wesnoth: Charles Dang wesnoth:master 9cf2e7924ff8 / src/editor/map/context_manager.cpp: Editor: show scenario name in titlebar if available https://github.com/wesnoth/wesnoth/commit/9cf2e7924ff80f07e8a8e90cef2b072b3554d7fc
20170502 10:47:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170502 11:15:20-!- sevu [~Unknown@p54856E7B.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170502 11:22:23-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20170502 11:31:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170502 11:32:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170502 11:32:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170502 11:33:41-!- mjs-de [~mjs-de@x4e309205.dyn.telefonica.de] has joined #wesnoth-dev
20170502 11:36:11-!- Kwandulin [~Kwandulin@p200300760F6D8048FCDC861169D50681.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 11:55:57-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170502 12:17:19-!- mjs-de [~mjs-de@x4e309205.dyn.telefonica.de] has quit [Remote host closed the connection]
20170502 12:22:46-!- Kwandulin2 [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 12:23:59-!- Kwandulin [~Kwandulin@p200300760F6D8048FCDC861169D50681.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20170502 12:26:03-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has joined #wesnoth-dev
20170502 12:26:10< gfgtdf> wedge009:are you online ?
20170502 12:26:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170502 12:27:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170502 12:29:31< irker324> wesnoth: Severin Glöckner wesnoth:master 77719820ee4d / data/campaigns/tutorial/scenarios/01_Tutorial_part_1.cfg: use [remove_event] instead of variable logic https://github.com/wesnoth/wesnoth/commit/77719820ee4da3da9f525f0c81d0fd8b6db11ce7
20170502 13:04:37-!- Kwandulin2 [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170502 13:12:31-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170502 13:24:24< irker324> wesnoth: Charles Dang wesnoth:master cd761f0a5540 / src/editor/palette/empty_palette.hpp: Editor: removed codepath to enable group selection menu for empty palettes https://github.com/wesnoth/wesnoth/commit/cd761f0a5540f5c2ba720c326eb937f337b6953d
20170502 13:24:27< irker324> wesnoth: Charles Dang wesnoth:master 21ef86bfa82d / src/editor/palette/location_palette.cpp: Editor: hide help string and group button when using the Location palette https://github.com/wesnoth/wesnoth/commit/21ef86bfa82d39ae18cb56bb0cc839170c2995fa
20170502 13:33:50-!- sevu [~Unknown@p57803acb.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 13:34:41-!- sevu [~Unknown@p57803acb.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170502 13:57:41-!- gfgtdf_ [~chatzilla@x4e369ba4.dyn.telefonica.de] has joined #wesnoth-dev
20170502 14:00:25-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20170502 14:00:35-!- gfgtdf_ is now known as gfgtdf
20170502 14:12:28-!- JyrkiVesterinen [~JyrkiVest@85-76-67-43-nat.elisa-mobile.fi] has quit [Ping timeout: 240 seconds]
20170502 14:41:28-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170502 14:44:01-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170502 14:44:10-!- new_one [~new_one@2604:a880:1:20::22e:d001] has quit [Ping timeout: 264 seconds]
20170502 14:45:22-!- DDR [~david@ec2.happyspork.com] has quit [Ping timeout: 264 seconds]
20170502 14:46:11-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Ping timeout: 255 seconds]
20170502 14:49:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170502 14:50:06-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170502 14:50:08-!- DDR [~david@ec2.happyspork.com] has joined #wesnoth-dev
20170502 14:58:11-!- new_one [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20170502 15:56:40-!- JyrkiVesterinen [~jyrki@87-100-203-254.bb.dnainternet.fi] has joined #wesnoth-dev
20170502 16:12:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 16:16:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20170502 16:16:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 16:38:10-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170502 16:40:40-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has joined #wesnoth-dev
20170502 16:50:08< irker324> wesnoth: Jyrki Vesterinen wesnoth:master 6b8273e00397 / CMakeLists.txt SConstruct scons/cairo.py: Require Cairo 1.10 or above https://github.com/wesnoth/wesnoth/commit/6b8273e003970b7a272350de2f92d4b770648628
20170502 17:01:48-!- JyrkiVesterinen [~jyrki@87-100-203-254.bb.dnainternet.fi] has quit [Quit: .]
20170502 17:07:50-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170502 17:28:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170502 17:28:05< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Jyrki Vesterinen 6b8273e: Require Cairo 1.10 or above Failed
20170502 17:28:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-324
20170502 17:28:10-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170502 17:31:27-!- JyrkiVesterinen [~JyrkiVest@87-100-203-254.bb.dnainternet.fi] has joined #wesnoth-dev
20170502 17:34:41-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170502 17:34:41< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Jyrki Vesterinen 6b8273e: Require Cairo 1.10 or above Failed
20170502 17:34:41< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-324
20170502 17:34:46-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170502 17:34:57< irker324> wesnoth: Jyrki Vesterinen wesnoth:master c825ff7a8013 / INSTALL.md: Update INSTALL.md for 6b8273e0 https://github.com/wesnoth/wesnoth/commit/c825ff7a8013d94d1cae39dffde564afcb1791e0
20170502 17:43:30< gfgtdf> wedge009: are you online?
20170502 17:52:50< celmin|sleep> So many fixups. X_X
20170502 17:58:32-!- celmin|sleep is now known as celticminstrel
20170502 18:01:30-!- atarocch [~atarocch@64.251.121.244] has joined #wesnoth-dev
20170502 18:09:04< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt b2727852477d / CMakeLists.txt cmake/FindCrypto.cmake: Second attempt to update CMake https://github.com/wesnoth/wesnoth/commit/b2727852477d93233dcdbe504a9d7cd8f2e0a2a7
20170502 18:09:06< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt b55f7ef17ed1 / utils/travis/install_deps.sh: Attempt to fix Mac build https://github.com/wesnoth/wesnoth/commit/b55f7ef17ed10f3a03e83c7893cde07f63ec1b1f
20170502 18:36:42< celticminstrel> This is an interesting idea. https://forums.wesnoth.org/viewtopic.php?p=589593#p589593
20170502 18:39:26-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20170502 18:40:34-!- atarocch [~atarocch@64.251.121.244] has quit [Ping timeout: 264 seconds]
20170502 18:41:34-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170502 18:42:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170502 18:43:49< celticminstrel> The new desert elves aren't on units.wesnoth.org; probably something to do with the way the campaign allows you to select old or new units?
20170502 18:46:10< zookeeper> probably... although i'm not sure how the script's logic works.
20170502 18:46:33< celticminstrel> Well, if the units are hidden behind an unusual macro, that might do it?
20170502 18:48:01< elias> the idea was to show whatever shows up in the documentation
20170502 18:48:25< elias> at the time I wrote the script there even was some attributes like "hide-in-docs"... if any of that changed since then it likely needs to be adapted
20170502 18:49:16< elias> (macros don't matter as the C++ wesnoth does the actual parsing)
20170502 18:50:00< zookeeper> the units are hidden behind another set of difficulty levels
20170502 18:50:46< celticminstrel> elias: I meant the units might be hidden behind a macro that isn't defined when your script parses it.
20170502 18:50:53< elias> indeed
20170502 18:51:05< elias> I think it reads the list of difficulty levels and always uses the first one
20170502 18:51:22< elias> so units only in another difficulty will not show
20170502 18:52:08< zookeeper> sounds like that's the reason, then
20170502 18:52:37< celticminstrel> Is the old version going to be kept around indefinitely?
20170502 18:52:49< celticminstrel> Or would it be removed soon?
20170502 18:53:01< zookeeper> soon, i guess after the next release or so
20170502 18:54:26< zookeeper> so the u.w.o problem shouldn't really matter, aside from your current inconvenience :p
20170502 18:54:52< celticminstrel> Yeah.
20170502 18:58:19< zookeeper> well, i was intending on the old ones being kept around until the new ones are finished, but...
20170502 18:58:41< zookeeper> perhaps we should commission a sprite artist
20170502 19:12:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170502 19:14:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170502 19:15:40-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170502 19:35:33< DeFender1031> celticminstrel, re: units.wesnoth, I recall someone in the other channel mentioning that some weird WML quirk made some other unit not show up... spaces in the id maybe?
20170502 19:37:14< DeFender1031> Oh, nevermind, didn't read the whole conversation before running my mou- er- hands.
20170502 19:38:08< celticminstrel> Pretty sure the core units have spaces in the IDs.
20170502 19:38:55< DeFender1031> maybe, but whatever it is I'm remembering is apparently not the issue here anyway.
20170502 19:39:17< celticminstrel> I guess so.
20170502 19:39:39< DeFender1031> zookeeper, are the units functionally different in the new version, or is it just new graphics and new names, descriptions, etc?
20170502 19:39:55< zookeeper> functionally entirely different
20170502 19:40:48< DeFender1031> I'm a little surprised that it'd be under the same campaign id at that point, then
20170502 19:41:49< DeFender1031> Like, I feel like if you beat it with the old units, you don't necessarily deserve the laurel for the current version.
20170502 19:42:03< DeFender1031> But that may be a little too nitpicky.
20170502 19:42:58< zookeeper> well... yes :p
20170502 19:44:21< DeFender1031> ... "yes" to which?
20170502 19:44:34< zookeeper> to the last one
20170502 19:44:54< DeFender1031> thought so.
20170502 20:15:40< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 961407174c33 / utils/travis/install_deps.sh: Another attempt to fix Mac build https://github.com/wesnoth/wesnoth/commit/961407174c33db987a9eceb5bfaf33f3210d0ad0
20170502 20:15:42< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt 81cc9317c8da / CMakeLists.txt: Attempt to fix CMake build https://github.com/wesnoth/wesnoth/commit/81cc9317c8dae66051eb7b20d1b437ec5649ac32
20170502 20:15:44< celticminstrel> This is a pain.
20170502 20:39:52-!- Appleman1234 [~Appleman1@pl47283.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170502 20:40:48-!- JyrkiVesterinen [~JyrkiVest@87-100-203-254.bb.dnainternet.fi] has quit [Quit: .]
20170502 20:52:15< Ravana_> I started wondering whether Tag Amendment Syntax is evaluated at runtime or preprocessing.. would it make any sense to use it with ActionWML tags
20170502 20:53:39< gfgtdf> the [+tag] syntax? at preprocessing afaik
20170502 20:54:35< celticminstrel> Uh.
20170502 20:54:42< celticminstrel> I think it's evaluated at neither time.
20170502 20:54:57< celticminstrel> It should be evaluated during parsing, after preprocessing.
20170502 20:55:24< gfgtdf> ye i assumes there was no diffents forma users point of view
20170502 20:55:34< celticminstrel> You could use it with ActionWML tags. It would only really make sense if you're amending a tag inserted by a macro IMO.
20170502 20:56:03< celticminstrel> gfgtdf: If you're going to conflate the two stages, the combined stage should be called "parsing", not "preprocessing" IMO
20170502 20:56:18< celticminstrel> By saying "preprocessing" you're already implying that you've not conflated them.
20170502 20:56:20< celticminstrel> IMO
20170502 20:57:38< gfgtdf> celticminstrel: well no, i had to choose form 'runtime or preprocessing' sanying 'parsing' woudl make me need to explain the difference. sice i then explicitly hcoose to use non of the given options.
20170502 20:58:11 * celticminstrel probably would've said "not runtime" rather than choosing "preprocessing".
20170502 20:58:37< celticminstrel> BTW, do we want an Attribute Amendment Syntax too?
20170502 20:58:55< zookeeper> how would that work?
20170502 20:58:57-!- Appleman1234 [~Appleman1@pl8731.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170502 20:59:12< gfgtdf> celticminstrel: we can just write them a secodn time overwriting the first appearance
20170502 20:59:25< celticminstrel> zookeeper: attribute=thing followed by attribute+=stuff would result in attribute having the value thingstuff.
20170502 20:59:54< Ravana_> I am aware of what parsing stage is, but saying preprocessing was good enough
20170502 21:00:20< Ravana_> not +=, that would just result in people trying to use it to increase attribute value
20170502 21:00:24< zookeeper> ehh. seems a bit... random, because if you want to use the former value as part of the new one, then it's pretty unlikely to be in a simple concatenated form like that.
20170502 21:00:41< zookeeper> and that'd be the only supported form
20170502 21:00:47< celticminstrel> You think so?
20170502 21:01:01< celticminstrel> I think the simple concatenated form would be fairly likely.
20170502 21:01:07< zookeeper> well, hard to say. it's a new thought :p
20170502 21:01:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170502 21:01:42< celticminstrel> But I suppose you could also make it a find-and-replace or something.
20170502 21:02:12< celticminstrel> Or even support multiple modes.
20170502 21:03:12< zookeeper> maybe. i can't really think of any potential usecases off the top of my head. maybe in some kind of code that deals with comma-separated lists or something, but nothing specific comes to mind.
20170502 21:03:24< celticminstrel> Unit descriptions?
20170502 21:04:15< celticminstrel> Hmm, on a related note, I wonder if there's away to amend an attribute in unit inheritance...
20170502 21:05:21< celticminstrel> Apparently there is!
20170502 21:05:29< celticminstrel> add_to_description="additional info"
20170502 21:07:14 * zookeeper blinks
20170502 21:07:47< celticminstrel> Works for any key anywhere in a unit with [base_unit], or a variation.
20170502 21:08:02< celticminstrel> Just put add_to_ in front of the key name.
20170502 21:08:12< celticminstrel> Well, I haven't tested though, this is from code-reading.
20170502 21:08:38< zookeeper> that's... undocumented
20170502 21:08:49< zookeeper> but sounds nice
20170502 21:08:53< celticminstrel> Yeah. So is the __remove=yes that causes a subtag to be deleted.
20170502 21:10:12< irker324> wesnoth: Celtic Minstrel wesnoth:login_save_crypt efa30dec29fc / src/credentials.cpp: [WIP] Use AES instead of XOR to encrypt passwords https://github.com/wesnoth/wesnoth/commit/efa30dec29fcbc2b68e0f762d9de22c8871fc146
20170502 21:10:30< gfgtdf> celticminstrel: seems liek it does integer addition though not text concatination
20170502 21:11:00< gfgtdf> celticminstrel: so more liek add_to_cost=6
20170502 21:11:17< celticminstrel> Well, that's useful too though.
20170502 21:11:40< celticminstrel> I'll add the other one too. What should I call it?
20170502 21:11:44< celticminstrel> "concat_to_"
20170502 21:11:45< celticminstrel> ?
20170502 21:13:51< DeFender1031> recruit=Spearman,Bowman / recruit+=,Fire Dragon
20170502 21:16:25< celticminstrel> Maybe recruit=Spearman,Bowman / recruit,=Fire Dragon
20170502 21:16:48< celticminstrel> <_<
20170502 21:17:05< celticminstrel> Though I'm not sure how useful it would be for recruits, considering that it'd be evaluated all at parse time.
20170502 21:17:41< DeFender1031> isn't there an action that changes the recruit list?
20170502 21:18:09< celticminstrel> There is.
20170502 21:18:13< celticminstrel> [allow_recruit]?
20170502 21:18:18< DeFender1031> maybe.
20170502 21:18:48< DeFender1031> point is, that's something that isn't entirely static.
20170502 21:19:30< celticminstrel> A += might be useful if you want to tack on an extra piece of text in a [message] only on one difficulty level.
20170502 21:19:48< celticminstrel> Is there currently a way to do that without repeating the entire message? I suspect not...
20170502 21:19:56< celticminstrel> Oh, wait.
20170502 21:20:01< DeFender1031> honestly though, something I'd want to see is the ability for every tag to have an id, and then the ability to amend any given tag by its id (rather than just being able to amend the last one)
20170502 21:20:11< celticminstrel> You could do it now by ending the line with + and then adding "" in the else branch.
20170502 21:20:49< celticminstrel> Any tag in the entire config? Or just any sibling tag?
20170502 21:22:01< DeFender1031> not sure that distinction would affect the use-case I have in mind
20170502 21:22:18< DeFender1031> which is simple modifications to existing units.
20170502 21:23:30< DeFender1031> (so long as once inside the tag making the modifications, sub-tags making additional modifications are tied to the original tag's subtags)
20170502 21:25:26< DeFender1031> basically, something like [modify_tag] / tag_id=Fire Dragon / cost=1 / hp=9001 / description=_"Well, this is somewhat overpowered" / [modify_tag]
20170502 21:26:01< DeFender1031> ("somewhat"... hehehehehe.)
20170502 21:26:11< celticminstrel> Where should we document add_to_ and __remove=yes?
20170502 21:26:33< DeFender1031> does it work with all tags or just certain ones?
20170502 21:26:47< celticminstrel> It works anywhere two configs are merged by the engine.
20170502 21:27:09< celticminstrel> I'm not sure if that's done anywhere besides unit_type inheritance...
20170502 21:27:15< DeFender1031> then we should document it in the same place that the merge syntax is documented. SyntaxWML I believe is that place.
20170502 21:27:25< celticminstrel> Eh?
20170502 21:27:41< gfgtdf> DeFender1031: so you mean like changing unittpyes attributes or ain a more general way ?
20170502 21:27:44< celticminstrel> I don't think it should go in SyntaxWML?
20170502 21:27:46< DeFender1031> Are you saying that it works anywhere that [+tag] is used?
20170502 21:27:49< celticminstrel> No.
20170502 21:28:04< celticminstrel> Anywhere the engine has two configs and decides to merge them together.
20170502 21:28:07< DeFender1031> gfgtdf, that would be one useful example, yes.
20170502 21:29:07< celticminstrel> Looks like there are actually quite a few places where this is the case...
20170502 21:29:20< celticminstrel> It seems as though add_to_ would work in movetype tags even in a base unit.
20170502 21:29:20< DeFender1031> celticminstrel, oh, i see. So pretty much just the unit "inherits_from" thing?
20170502 21:29:35< celticminstrel> That might be the only case actually relevant to users.
20170502 21:29:35< DeFender1031> oh, hmm.
20170502 21:30:06< celticminstrel> Ohhhh! [set_variables]!
20170502 21:30:15< DeFender1031> movetype... probably also the abilities thing if you ever get that working in a centralized manner like you've mentioned a few times...
20170502 21:30:22< DeFender1031> set variables?
20170502 21:30:24< DeFender1031> oh
20170502 21:30:28< DeFender1031> the merge mode
20170502 21:30:32< DeFender1031> iiiiiiiiiiiiinteresting
20170502 21:30:41< celticminstrel> Also used in themes...
20170502 21:31:05< celticminstrel> Something in AI and something in MP setup.
20170502 21:31:20 * celticminstrel grepped for uses of merge_with, merge_attributes, and inherit_from.
20170502 21:31:20< DeFender1031> yeah, so there isn't really a good central place where merge behavior is documented...
20170502 21:32:24< celticminstrel> I could document it at [set_variables]?
20170502 21:32:35< celticminstrel> And link there from UnitTypeWML?
20170502 21:32:52< DeFender1031> maybe, although that'd be a somewhat obscure and unexpected place to look when it relates to all the automatic cases.
20170502 21:33:05< celticminstrel> Maybe...
20170502 21:33:57< celticminstrel> I suppose it could also be given a new page, though I'm not sure there's really enough for a whole page.
20170502 21:34:07< DeFender1031> you could document it there and then make sure that EVERY OTHER CASE that allows it has some generic "also allows [[linkything|tag merging syntax]]"
20170502 21:34:17< DeFender1031> yeah, i wouldn't do a whole page.
20170502 21:34:37< DeFender1031> set_variables makes sense, so long as there's clear signposting from the other relevant cases.
20170502 21:36:31< irker324> wesnoth: Celtic Minstrel wesnoth:master fc204ea1c5dc / changelog src/config.cpp: Add concat_to_* key for config merging (eg, unit type inheritance) https://github.com/wesnoth/wesnoth/commit/fc204ea1c5dcff7f1b7a19097f0a3a56a617dbaa
20170502 21:37:32-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170502 21:38:27-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170502 21:46:53< celticminstrel> Well, I've done the work in UnitTypeWML and in InternalActionsWML... still need to figure out other places where it would need to be linked though.
20170502 21:46:59< celticminstrel> Maybe it could still be improved, too.
20170502 21:47:09< celticminstrel> Feel free to take a look?
20170502 21:47:26 * DeFender1031 goes to check
20170502 21:49:01< DeFender1031> celticminstrel, https://wiki.wesnoth.org/InternalActionsWML#.5Bset_variables.5D looks great
20170502 21:49:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20170502 21:51:27< DeFender1031> celticminstrel, as for https://wiki.wesnoth.org/Unittypewml i'd be more explicit. Maybe something like "also supports the additional syntaxes available to [set_variables]mode=merge"?
20170502 21:51:47< celticminstrel> Hmm.
20170502 21:52:18< celticminstrel> I'm not sure if that gets across that the merging is exactly the same, for example the fact that corresponding tags of the same name are also merged.
20170502 21:53:49< mattiaskrgr> celticminstrel: for the record, in all these years I have been working with asan now I don't think I have seen a single leak false positive 
20170502 21:54:17< DeFender1031> celticminstrel, ah, good point.
20170502 21:54:25< mattiaskrgr> re #1020
20170502 21:54:38< DeFender1031> celticminstrel, maybe just add "including the special syntaxes" then?
20170502 21:56:06< celticminstrel> mattiaskrgr: So how can something leak when it's managed by a shared_ptr?
20170502 22:00:43< mattiaskrgr> I don't know how shared_ptr works so I don't know, sorry
20170502 22:01:37< mattiaskrgr> well technically it could be a clang bug, I'm using the clang-devel version, but still I fould find that quite strange
20170502 22:08:32-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 255 seconds]
20170502 22:08:55< mattiaskrgr> gotta get some sleep, see you later
20170502 22:10:45-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170502 22:25:40< celticminstrel> gfgtdf: Do you know how I can get to the scenario config from the game_lua_kernel?
20170502 22:39:06< gfgtdf> celticminstrel: the orignal scenario config or the current snapshot?
20170502 22:39:27< celticminstrel> The original scenario config.
20170502 22:39:37< celticminstrel> I want the [story] tags.
20170502 22:40:17< celticminstrel> I wonder if any scenarios actually contain multiple [story] tags, and if so, why...
20170502 22:44:19< gfgtdf> celticminstrel: hmm i dont' think this is generalyl possible, for xmaple when you are a non-host in a mp game you cannot get the [scenario] from the game_config since it was receives via network, and the story data that is received form the nework is mostlileley removed once it's used
20170502 22:44:38-!- heirecka_ [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20170502 22:45:09-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit []
20170502 22:46:00-!- heirecka_ is now known as heirecka
20170502 22:46:02< gfgtdf> celticminstrel: hmm wait actuall the story data migth still exist in the [replay_start] in most cases, it's a rater hacky way though
20170502 22:46:06< gfgtdf> rather*
20170502 22:48:27< celticminstrel> Hmm. I wanted to add access to it in wesnoth.game_config so that you can write "wesnoth.show_story(wesnoth.game_config.intro)" to repeat the intro storyscreen, though the motivation was solely for making it easier for me to test show_story.
20170502 22:48:44< celticminstrel> So maybe I should just put it on hold and test it the harder way.
20170502 22:51:52< gfgtdf> celticminstrel: i think adding a getter for game config is sure useful but i'm unure aboit possible security problems
20170502 22:52:08< celticminstrel> Unrelatedly, is it possible in a defeat event to advance you to another scenario?
20170502 22:52:21< gfgtdf> celticminstrel: yes it is
20170502 22:52:37< celticminstrel> Would you need to replace the defeat with a victory, then?
20170502 22:52:44< celticminstrel> Using [end_level]
20170502 22:53:10< gfgtdf> celticminstrel: since 1.13 the lua endlevel inteface has a 'proceed_to_next_level' flag, not sure whtehr the wml interface suports this though
20170502 22:53:27< celticminstrel> Oh, and that's independent of defeat vs victory?
20170502 22:53:46< gfgtdf> celticminstrel: yes, this was needed mostly for mp where it's possible for one side to be defeated while the other was victorious.
20170502 22:53:55< DeFender1031> last level of DiD does something similar
20170502 22:54:23< celticminstrel> IIUC, doesn't DiD just declare victory on leader death?
20170502 22:54:35< celticminstrel> I still think that's ridiculous and should be changed.
20170502 22:55:24< gfgtdf> celticminstrel: so the default is 'set proceed_to_next_level=yes if any (loca or remote) human side is victorious while the other the victly message is shown if any _local_ side is victorious 
20170502 22:58:48< gfgtdf> celticminstrel: to the first issue: i think it'Dbe nice to have some function get_gameconfig_variable() or a get metatable wit the game syntax. but maybe hidden in the unsafe lua check.
20170502 22:59:14< gfgtdf> s/game/same
20170502 22:59:27< celticminstrel> Why hidden in the unsafe Lua check? Surely it's nowhere near as unsafe as allowing access to the file library.
20170502 23:01:38< gfgtdf> celticminstrel: hmm well one could do stuff like read which other addons are installed some people might not want that.
20170502 23:02:16< vultraz_iOS> what do you mean
20170502 23:02:24< vultraz_iOS> the game already knows what addons are installed
20170502 23:02:45< gfgtdf> hmm i can query this by addon wml/lua?
20170502 23:02:51< celticminstrel> gfgtdf: So you were suggesting allowing access to the root [game_config]?
20170502 23:03:08< celticminstrel> I guess that might not be a good idea, then...
20170502 23:03:17< vultraz_iOS> well no you can't query exactly 
20170502 23:03:30< celticminstrel> Though it is possible for an addon to determine what addons are installed via preprocessor checks, but that's a little different, I guess.
20170502 23:03:35< vultraz_iOS> yes
20170502 23:03:37< celticminstrel> Maybe you could use wesnoth.have_file for the same.
20170502 23:03:46< celticminstrel> (Or was it has_file)
20170502 23:03:55< vultraz_iOS> I do that for my music pack
20170502 23:04:15< celticminstrel> I think both of those only work for detecting a specific addon though, not for getting a list of installed addons.
20170502 23:04:32< vultraz_iOS> is that so bad though
20170502 23:04:40< vultraz_iOS> knowing that's installing
20170502 23:04:51< vultraz_iOS> really just playing devil's advocate here
20170502 23:04:59< celticminstrel> I think allowing game_lua_kernel to read a list of installed addons is probably not a good idea.
20170502 23:05:15< celticminstrel> But I don't think it's as bad as allowing access to the file library, either.
20170502 23:06:51< gfgtdf> what would be the usecases for such a function other than debugging/testing etc?
20170502 23:07:54< vultraz_iOS> celticminstrel: ftr the storyscreen concatenates any [story] tags in the range passed to it
20170502 23:09:27< gfgtdf> vultraz_iOS: are the advantages of using multiple story tags instead of puttin it all in one ?
20170502 23:10:08< vultraz_iOS> gfgtdf: not really but ti think mainline does that bc some of the story stuff is split into macros
20170502 23:10:16< gfgtdf> ok
20170502 23:12:00-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170502 23:16:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170502 23:16:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170502 23:17:20-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has joined #wesnoth-dev
20170502 23:25:44< vultraz_iOS> hmm... I was going to write a menu_generator class
20170502 23:27:57< vultraz_iOS> heh
20170502 23:28:01< vultraz_iOS> "resrote_palete_bg"
20170502 23:38:08< celticminstrel> vultraz_iOS: I'm aware of that, thanks.
20170502 23:39:50< celticminstrel> vultraz_iOS: What's the scenario name used for by the story viewer? Just a default for the title?
20170502 23:40:20< vultraz_iOS> what do you mean
20170502 23:40:25< vultraz_iOS> "default for the title"
20170502 23:40:31< vultraz_iOS> the scenario name is passed in
20170502 23:40:34< celticminstrel> [part] supports title text, right?
20170502 23:40:49< celticminstrel> So I meant, the scenario name is used as a default for that if it's not specified.
20170502 23:41:02< celticminstrel> I just want to know why the scenario name is passed in, basically.
20170502 23:42:05< vultraz_iOS> honestly, that's piped into the controller
20170502 23:42:15< vultraz_iOS> you'll have to look how exactly it's used
20170502 23:45:40< vultraz_iOS> (since im not sure exactly)
20170502 23:45:45< vultraz_iOS> one can specify a title manually
20170502 23:46:05< vultraz_iOS> celticminstrel: likely it's used as a default if show_title is specified w/o a title
20170502 23:53:46< celticminstrel> There should be a mainline After The Fall era.
--- Log closed Wed May 03 00:00:52 2017