--- Log opened Wed May 03 00:00:52 2017
20170503 00:03:57-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20170503 00:14:09< vultraz_iOS> another editor crash ;_;
20170503 00:18:47< pydsigner> celticminstrel: have fun balancing it
20170503 00:19:29< celticminstrel> Heh...
20170503 00:19:56< vultraz_iOS> just import Era of Chaos
20170503 00:20:11-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170503 00:21:05< celticminstrel> As long as it's not a mega-era like Ageless, and as long as it includes the new Quenoth Elves, I suppose that could be acceptable.
20170503 00:22:47< irker324> wesnoth: Charles Dang wesnoth:master f2705ab2e275 / src/editor/palette/ (palette_manager.cpp palette_manager.hpp): Editor/Palette Manager: fix misspelled function https://github.com/wesnoth/wesnoth/commit/f2705ab2e275fb12d10699042e2a31885f6cf800
20170503 00:22:50< irker324> wesnoth: Charles Dang wesnoth:master a82b70ff182a / src/editor/map/context_manager.cpp: Fixup 27912cd https://github.com/wesnoth/wesnoth/commit/a82b70ff182a5efc0c1fc1bbab56cd1146833146
20170503 00:23:59< celticminstrel> Eh, on second thought, there are some questionable things in EoC.
20170503 00:24:45-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170503 00:25:09< celticminstrel> I still want the moon line back too. >_>
20170503 00:26:15< celticminstrel> Blargh, timing. :(
20170503 00:27:03< celticminstrel> Argh, I can't fast-forward now.
20170503 00:35:16< vultraz_iOS> alright, the editor seems to be working properly
20170503 00:35:21< vultraz_iOS> except for that help crash
20170503 00:36:54< celticminstrel> Help crash?
20170503 00:37:52< vultraz_iOS> celticminstrel: go to editor, open help, attempt to exit to titlescreen, game hangs
20170503 00:39:44< celticminstrel> Wait, how do you exit to titlescreen from help?
20170503 00:39:53< vultraz_iOS> no
20170503 00:39:56< vultraz_iOS> close help
20170503 00:52:11< irker324> wesnoth: Celtic Minstrel wesnoth:master da2f7723c79f / src/game_board.cpp: Remove a needless extra level of indentation https://github.com/wesnoth/wesnoth/commit/da2f7723c79ffc34bc59339a011a7662b2f6af45
20170503 00:52:13< irker324> wesnoth: Celtic Minstrel wesnoth:master a7cacfb77f49 / src/editor/palette/editor_palettes.hpp: Remove unused, undefined functions (fixing MSVC warnings) https://github.com/wesnoth/wesnoth/commit/a7cacfb77f49853064ca1b863b0227bd8970572f
20170503 00:52:15< irker324> wesnoth: Celtic Minstrel wesnoth:master efb0fe05e9b6 / / (7 files in 5 dirs): Accept [story] as ActionWML https://github.com/wesnoth/wesnoth/commit/efb0fe05e9b64807301cb9762fdea86cfe930332
20170503 00:59:08< Aginor> celticminstrel: how's your crpyto branch coming along?
20170503 00:59:48< celticminstrel> It's kinda coming along? I recently pushed the AES commit. I think I must be doing something wrong though, because it only half works.
20170503 01:00:16< celticminstrel> Still needs some kind of key transformation.
20170503 01:05:24< celticminstrel> I was also having trouble getting it to build with CMake on Travis.
20170503 01:05:31< celticminstrel> And on Mac on Travis.
20170503 01:06:31< vultraz_iOS> hm, why did you move the concatenation out of the display function?
20170503 01:07:04< celticminstrel> Because a) it didn't seem like it belonged there and b) requiring display to take an iterator range complicates the implementation of show_story.
20170503 01:08:40< vultraz_iOS> I see
20170503 01:08:52< vultraz_iOS> shouldn't matter, I think
20170503 01:09:00< vultraz_iOS> toplevel is the only place we'd want to join them
20170503 01:09:11< vultraz_iOS> otherwise they should be considered separate actions
20170503 01:09:18< celticminstrel> Really can't join them in the ActionWML.
20170503 01:09:25< celticminstrel> Because it's evaluated one tag at a time.
20170503 01:09:36< vultraz_iOS> yes
20170503 01:18:59 * vultraz_iOS ponders his idea for a menu generator class
20170503 01:19:19< celticminstrel> What's this idea?
20170503 01:20:34< vultraz_iOS> encapsulate the code that generates menu configs in the game and editor
20170503 01:21:05< vultraz_iOS> takes a vector of strings and gives you an vector of configs
20170503 01:22:49< vultraz_iOS> allow all the "expand" functions to be registered as callbacks in an id/function map
20170503 01:24:01< celticminstrel> Sounds a little confusing.
20170503 01:27:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170503 01:32:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20170503 01:33:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170503 01:35:56-!- gfgtdf_ [~chatzilla@x4e363b9f.dyn.telefonica.de] has joined #wesnoth-dev
20170503 01:36:47< celticminstrel> Oh, "unsafe Lua" also allows access to the package library, which means scripts can load and execute arbitrary code.
20170503 01:37:56-!- gfgtdf [~chatzilla@x4e369ba4.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170503 01:38:06-!- gfgtdf_ is now known as gfgtdf
20170503 01:38:17< Aginor> celticminstrel: that sounds like an exceptionally dangerous thing
20170503 01:38:34< celticminstrel> Which undoubtedly is why it's only enabled with a command-line flag.
20170503 01:38:56< celticminstrel> Basically it means Lua can load Lua modules that are written in C.
20170503 01:48:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170503 01:48:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170503 01:57:58-!- Appleman1234 [~Appleman1@pl8731.ag1212.nttpc.ne.jp] has quit [Ping timeout: 264 seconds]
20170503 01:58:29< celticminstrel> gfgtdf: Do you think wesnoth.require could be implemented in Lua?
20170503 01:58:56< celticminstrel> By calling out to wesnoth.dofile.
20170503 02:09:30< gfgtdf> celticminstrel: npt sure i currently don't seee why not though.
20170503 02:10:38-!- gfgtdf [~chatzilla@x4e363b9f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170503 02:22:23-!- Appleman1234 [~Appleman1@pl23312.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170503 02:31:45-!- Appleman1234 [~Appleman1@pl23312.ag1212.nttpc.ne.jp] has quit [Ping timeout: 268 seconds]
20170503 02:38:21-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20170503 02:38:50-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170503 02:43:53< celticminstrel> gfgtdf: Would you object to changing wesnoth.read_file to return an array of one string per line?
20170503 02:44:27-!- Appleman1234 [~Appleman1@pl29969.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170503 02:44:31< vultraz_iOS> uh
20170503 02:44:34< vultraz_iOS> why would you do that
20170503 02:44:41< celticminstrel> Convenience?
20170503 02:44:54< celticminstrel> It's probably very common that you'll want to split it on line breaks anyway.
20170503 02:44:58-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20170503 02:45:05< celticminstrel> Unless of course it's a binary file, but uh...
20170503 02:45:21< celticminstrel> I'm pretty sure it already doesn't work on binary files ATM.
20170503 02:45:21-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170503 02:45:21-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170503 02:45:22-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170503 02:47:38< vultraz_iOS> what is it now?
20170503 02:47:53< celticminstrel> It currently reads the file into one big string IIUC.
20170503 02:48:06< celticminstrel> It uses luaL_Buffer so I'm not entirely sure how that works.
20170503 02:51:29< vultraz_iOS> i see
20170503 02:51:37< celticminstrel> It doesn't pass the binary flag to the istream though, so it probably won't correctly read binary files.
20170503 02:52:19< vultraz_iOS> not sure why we would want to read binary files
20170503 02:53:26< celticminstrel> Well, if we don't want to read binary files, then an array of lines is probably more useful IMO.
20170503 02:53:41< celticminstrel> Either that, or invoking the WML parser. :P
20170503 02:54:02 * vultraz_iOS runs screaming
20170503 02:57:17< celticminstrel> XD
20170503 03:17:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170503 03:19:55< irker324> wesnoth: Celtic Minstrel wesnoth:lua_require 37c0ccafa3be / src/scripting/lua_kernel_base.cpp: Allow wesnoth.dofile to forward arbitrary arguments to the file's "..." https://github.com/wesnoth/wesnoth/commit/37c0ccafa3bec08592a78b6fc1b77d25e45311f8
20170503 03:19:57< irker324> wesnoth: Celtic Minstrel wesnoth:lua_require 17d5e84482ac / data/lua/package.lua src/scripting/lua_kernel_base.cpp: Reimplement wesnoth.require function in Lua https://github.com/wesnoth/wesnoth/commit/17d5e84482aca91a07850fd5c40af1287cfe707f
20170503 03:19:59< irker324> wesnoth: Celtic Minstrel wesnoth:lua_require 98c129ca8fcf / data/lua/package.lua: Allow shorter module name specification in wesnoth.require https://github.com/wesnoth/wesnoth/commit/98c129ca8fcf99b155156716ac5c5e4931bcc460
20170503 03:20:01< irker324> wesnoth: Celtic Minstrel wesnoth:lua_require 6459c2f7cd3f / data/ (98 files in 21 dirs): Shorten requires where possible https://github.com/wesnoth/wesnoth/commit/6459c2f7cd3fd3eb63f8814fcc00f757ab1e6911
20170503 03:22:45< celticminstrel> Okay, now it just needs: 1) detect if a path is a directory and b) read the directory contents.
20170503 03:23:13< celticminstrel> Was going to shove b) into the read_file implementation; or I could add a separate read_dir, I suppose.
20170503 03:25:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170503 03:31:58-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170503 04:00:38-!- JyrkiVesterinen [~JyrkiVest@87.100.249.81] has joined #wesnoth-dev
20170503 04:05:08< vultraz_iOS> hmmm
20170503 04:05:11< vultraz_iOS> how to write this class...
20170503 04:05:23< vultraz_iOS> I guess I'll let it handle the hotkey logic too
20170503 04:05:50< celticminstrel> You're working on that menu generator? :|
20170503 04:06:18< vultraz_iOS> yes
20170503 04:06:19< vultraz_iOS> why?
20170503 04:06:34< celticminstrel> It just didn't sound like a terribly useful thing to me, but whatever.
20170503 04:14:56-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 04:18:23< celticminstrel> vultraz_iOS: https://forums.wesnoth.org/viewtopic.php?f=16&t=44864
20170503 04:19:10< vultraz_iOS> reading
20170503 04:30:06< celticminstrel> I can't open the Lua console from the titlescreen...
20170503 04:38:35< SigurdFD> Did that change since the 28th? I can, but it requires launching with --debug
20170503 04:39:31< vultraz_iOS> im running with debug and its not working
20170503 04:39:31< vultraz_iOS> :/
20170503 04:39:32< celticminstrel> I don't know any reason why it would've changed, but I am indeed launching with --debug...
20170503 04:39:49< celticminstrel> And it doesn't work after starting a scenario and returning to titlescreen, either...
20170503 04:41:47< SigurdFD> I should clarify, I'm currently using a build from a commit on the 28th
20170503 04:42:10< vultraz_iOS> possibly my dispatcher refactor
20170503 04:42:11< vultraz_iOS> :(
20170503 04:54:53< celticminstrel> Other hotkeys do work in the titlescreen though, for example F5.
20170503 04:55:39< vultraz_iOS> odd
20170503 04:55:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170503 04:55:42< vultraz_iOS> maybe.. Aginor's work?
20170503 04:55:48< vultraz_iOS> we'd have to bisect
20170503 04:56:00< celticminstrel> Well, ` does work in-game thoguh.
20170503 04:56:03< celticminstrel> ^though
20170503 04:56:45< vultraz_iOS> hmmm
20170503 04:56:51< vultraz_iOS> then something else is wrong..
20170503 05:00:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20170503 05:26:17-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170503 05:42:30< wedge009> gfgtdf: Yes?
20170503 05:46:58-!- JyrkiVesterinen [~JyrkiVest@87.100.249.81] has quit [Quit: .]
20170503 06:20:35-!- irker324 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170503 06:22:16-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170503 06:28:28-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170503 06:37:20-!- JyrkiVesterinen [~JyrkiVest@85-76-67-125-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170503 06:44:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170503 06:47:11-!- irker427 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170503 06:47:11< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 072ddc4dc121 / data/lua/package.lua src/scripting/lua_kernel_base.cpp: Reimplement wesnoth.require function in Lua https://github.com/wesnoth/wesnoth/commit/072ddc4dc121f7bb0b264f1c8f4d1c506b62dd90
20170503 06:47:11< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 6b74f91b2feb / data/lua/package.lua: Allow shorter module name specification in wesnoth.require https://github.com/wesnoth/wesnoth/commit/6b74f91b2feb4bca38f8675d141f41a455525e17
20170503 06:47:11< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 8d4cf3cf62f0 / data/ (98 files in 21 dirs): Shorten requires where possible https://github.com/wesnoth/wesnoth/commit/8d4cf3cf62f0e402cb8356dcd8a8155daf3e5bd8
20170503 06:47:12< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 448dd5d0b494 / src/scripting/lua_fileops.cpp: Minor reformatting and comment fixup https://github.com/wesnoth/wesnoth/commit/448dd5d0b4944f48c92e5ac815cb7db2754e2409
20170503 06:47:13< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require e2a2790182c1 / src/scripting/lua_fileops.cpp: Add flag to wesnoth.have_file to require it to be a real file, not a directory https://github.com/wesnoth/wesnoth/commit/e2a2790182c12e539b4976713777b2d908ff5b87
20170503 06:47:15< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 3eae385f3f18 / src/scripting/lua_fileops.cpp: Allow wesnoth.read_file to list a directory contents https://github.com/wesnoth/wesnoth/commit/3eae385f3f1848ce3b07e21e35a3b0bc887c2dda
20170503 06:47:17< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 690acf9b790e / data/lua/ (package.lua wml-tags.lua): Allow wesnoth.require to load a whole directory in one call https://github.com/wesnoth/wesnoth/commit/690acf9b790e185b119f0a8ed64ead7cac496550
20170503 06:47:19< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require e1233fd0f244 / data/lua/ (9 files in 2 dirs): Split several of the larger WML tags into their own file https://github.com/wesnoth/wesnoth/commit/e1233fd0f244c12727bb9be349ee12dd6dac2edc
20170503 06:47:21< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require 5da2d71a205b / data/ (ai/micro_ais/micro_ai_wml_tag.lua core/_main.cfg lua/wml/micro_ai.lua): Move [micro_ai] implementation to data/lua/wml https://github.com/wesnoth/wesnoth/commit/5da2d71a205b6e2411972e403fe66733fb653de0
20170503 06:47:23< irker427> wesnoth: Celtic Minstrel wesnoth:lua_require badc2d56d0cd / data/lua/wml/micro_ai.lua: Load all MicroAI definitions in a single line https://github.com/wesnoth/wesnoth/commit/badc2d56d0cd61a16743a1373b72d6563cb2a7a2
20170503 06:48:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170503 07:02:10< celticminstrel> vultraz_iOS, gfgtdf: https://github.com/wesnoth/wesnoth/pull/1021
20170503 07:05:14-!- Appleman1234 [~Appleman1@pl29969.ag1212.nttpc.ne.jp] has quit [Ping timeout: 276 seconds]
20170503 07:22:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170503 07:22:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Client Quit]
20170503 07:22:29-!- zookeeper_ [~lmsnie@95.175.104.127] has joined #wesnoth-dev
20170503 07:22:59-!- zookeeper_ is now known as zookeeper
20170503 07:23:01-!- zookeeper [~lmsnie@95.175.104.127] has quit [Changing host]
20170503 07:23:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170503 08:15:02-!- Appleman1234 [~Appleman1@pl23964.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170503 08:19:24< vultraz_iOS> can
20170503 08:19:29< vultraz_iOS> t really comment on the internals
20170503 08:19:31< vultraz_iOS> but it seems good
20170503 08:21:44< zookeeper> ah, i almost forgot to export patches too...
20170503 08:24:33< vultraz_iOS> nothing really useful there
20170503 08:24:43< zookeeper> lots of historical value!
20170503 08:25:13< celticminstrel> I exported those earlier.
20170503 08:25:14< zookeeper> don't you want to browse the xml file in a rocking chair in 70 years?
20170503 08:25:24< vultraz_iOS> good god no xD
20170503 08:25:29< zookeeper> :| :| :|
20170503 08:25:30< celticminstrel> I also started writing a Python script for the conversion.
20170503 08:25:39< zookeeper> celticminstrel, oh, cool
20170503 08:25:46< celticminstrel> Of issues though, not patches. I think they're a slightly different format.
20170503 08:26:03< zookeeper> sure
20170503 08:29:33< zookeeper> there are a whole bunch of open patches though. dunno how many contain anything that could/should be merged or would at least be of help to someone looking to re-implement them.
20170503 08:29:58< vultraz_iOS> IIRC i looked at them a year ago and implemented one
20170503 08:30:09< vultraz_iOS> but most are probably useless
20170503 08:30:33< celticminstrel> I'll look through them at some point.
20170503 08:30:50< celticminstrel> But yeah, most are likely useless simply by virtue of being old.
20170503 08:33:38-!- celticminstrel is now known as celmin|sleep
20170503 08:40:55 * zookeeper grabs the mailing list archives too
20170503 08:44:00-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170503 09:10:29-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170503 09:10:56< irker427> wesnoth: Charles Dang wesnoth:master 71740c82167b / src/storyscreen/ (part.cpp part.hpp): Removed render_input code from storyscreen parts https://github.com/wesnoth/wesnoth/commit/71740c82167b8e339fc2ca967dc9eb5c66a22679
20170503 09:10:59< irker427> wesnoth: Charles Dang wesnoth:master 3ff2816fee63 / src/storyscreen/ (controller.cpp controller.hpp part.cpp part.hpp): Reformatted and cleaned up includes for the storyscreen internals https://github.com/wesnoth/wesnoth/commit/3ff2816fee63fe65085510cecf889eaad0bfe401
20170503 09:11:02< irker427> wesnoth: Charles Dang wesnoth:master e97b99239355 / / (8 files in 3 dirs): Storyscreen: split common WML parsing code into a helper class https://github.com/wesnoth/wesnoth/commit/e97b99239355789c35485d190e50f36d73b51c9f
20170503 09:11:05< irker427> wesnoth: Charles Dang wesnoth:master 478fea46b60f / src/storyscreen/parser.cpp: Storyscreen/Parser: range-for https://github.com/wesnoth/wesnoth/commit/478fea46b60f0e4ce57ea920dc5dc2cba7ed37a0
20170503 09:12:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170503 09:18:09-!- JyrkiVesterinen [~JyrkiVest@85-76-67-125-nat.elisa-mobile.fi] has quit [Quit: .]
20170503 09:23:41-!- Ivanovic_ [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 09:23:52-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Write error: Broken pipe]
20170503 09:25:35-!- Ivanovic_ is now known as Ivanovic
20170503 10:12:47-!- JyrkiVesterinen [~JyrkiVest@85-76-67-125-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170503 10:41:22-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20170503 10:41:22-!- Topic for #wesnoth-dev: 1.13.8 (1.14. Beta 1) scheduled for Sunday, May 14th 00:01 UTC | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Discord Server: https://discord.gg/tSmJS2E | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20170503 10:41:22-!- Topic set by zookeeper [~lmsnie@wesnoth/developer/zookeeper] [Sat Apr 29 08:38:27 2017]
20170503 10:41:22[Users #wesnoth-dev]
20170503 10:41:22[ abruanese    ] [ ChipmunkV[m]   ] [ Gambit       ] [ Jetrel_bot     ] [ nurupo   ] [ TheJJ      ] 
20170503 10:41:22[ aeth         ] [ clavi          ] [ Greg_Boggs[m]] [ JyrkiVesterinen] [ oldlaptop] [ timotei    ] 
20170503 10:41:22[ Aginor       ] [ crimson_penguin] [ heirecka     ] [ kidneb         ] [ Polsaker ] [ tomreyn    ] 
20170503 10:41:22[ AI0867       ] [ DDR            ] [ higgins      ] [ lobby          ] [ prkc     ] [ vincent_c  ] 
20170503 10:41:22[ aidanhs      ] [ DeFender1031   ] [ Ieuan        ] [ loonycyborg    ] [ pydsigner] [ vultraz_iOS] 
20170503 10:41:22[ Alkenrinnstet] [ elias          ] [ irker427     ] [ mattiaskrgr    ] [ Ravana_  ] [ wedge009   ] 
20170503 10:41:22[ APic         ] [ EliDupree      ] [ Ivanovic     ] [ midzer         ] [ Rhonda   ] [ zookeeper  ] 
20170503 10:41:22[ Appleman1234 ] [ Elsi           ] [ iwaim__      ] [ minzbonbon     ] [ Soliton  ] 
20170503 10:41:22[ bumbadadabum ] [ Elvish_Hunter  ] [ janebot      ] [ new_one        ] [ TC01     ] 
20170503 10:41:22[ celmin|sleep ] [ esr            ] [ Jetrel       ] [ nore           ] [ TC02     ] 
20170503 10:41:22-!- Irssi: #wesnoth-dev: Total of 57 nicks [0 ops, 0 halfops, 0 voices, 57 normal]
20170503 10:41:25-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20170503 10:42:12-!- Irssi: Join to #wesnoth-dev was synced in 58 secs
20170503 10:44:19-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170503 10:54:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170503 10:54:57< irker427> wesnoth: Charles Dang wesnoth:master 85b2aad5ba17 / src/ (gui/dialogs/story_viewer.cpp storyscreen/part.cpp storyscreen/part.hpp): Storyscreen: store the text/title alignment as strings https://github.com/wesnoth/wesnoth/commit/85b2aad5ba178115f1c85da160435076709f4160
20170503 11:15:01-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 11:31:53-!- travis-ci [~travis-ci@54.158.39.57] has joined #wesnoth-dev
20170503 11:31:54< travis-ci> wesnoth/wesnoth#13693 (master - 85b2aad : Charles Dang): The build is still failing.
20170503 11:31:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/228290223
20170503 11:31:54-!- travis-ci [~travis-ci@54.158.39.57] has left #wesnoth-dev []
20170503 11:42:21< irker427> wesnoth: loonycyborg wesnoth:master cc8c3fe35247 / src/server/server.cpp: Fix dereference of past-the-end iterator https://github.com/wesnoth/wesnoth/commit/cc8c3fe35247bb94d46f47fc976052bd77cb4da2
20170503 11:42:23< irker427> wesnoth: loonycyborg wesnoth:master c8a7dd7b3700 / src/storyscreen/parser.hpp: Add return value to operator= to fix gcc compiler error https://github.com/wesnoth/wesnoth/commit/c8a7dd7b370065a1356b0e205e1c12a7f09c8a09
20170503 11:44:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170503 11:45:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170503 12:12:35< vultraz_iOS> loonycyborg: what does that fix?
20170503 12:12:38< vultraz_iOS> the server thing
20170503 12:12:49< vultraz_iOS> that is, was there a bug for it
20170503 12:13:10< loonycyborg> you mean as a tracker item?
20170503 12:13:25< vultraz_iOS> yes, was there a reported crash or something
20170503 12:13:32< loonycyborg> soliton just pinged me about it via irc
20170503 12:13:40< loonycyborg> I'm not aware of any tracker item
20170503 12:15:46< vultraz_iOS> got it
20170503 12:23:44-!- Kwandulin [~Kwandulin@p200300760F6D80C4A05750AA3D659435.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20170503 12:27:48-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 12:36:10-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20170503 12:39:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170503 12:39:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170503 12:41:13-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170503 12:55:19-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170503 12:58:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170503 13:13:20< irker427> wesnoth: Wedge009 wesnoth:master 974315f9b785 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project files for e97b9923. https://github.com/wesnoth/wesnoth/commit/974315f9b7852825de60738fc2794555fa28b4f6
20170503 13:31:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170503 13:32:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170503 13:37:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170503 13:37:24-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170503 13:56:46-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 255 seconds]
20170503 14:18:05-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 14:24:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170503 14:24:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170503 14:25:36< irker427> wesnoth: Charles Dang wesnoth:master 4b9463a6ff57 / src/gui/widgets/ (helper.cpp helper.hpp): Minor cleanup of GUI2 helper code https://github.com/wesnoth/wesnoth/commit/4b9463a6ff575acf1689be55f64ff7208be57fb5
20170503 14:25:39< irker427> wesnoth: Charles Dang wesnoth:master c9d484e2c4ea / src/storyscreen/ (controller.cpp controller.hpp parser.cpp parser.hpp part.cpp part.hpp): Storyscreen/Parser: don't keep parsing if special action was already executed https://github.com/wesnoth/wesnoth/commit/c9d484e2c4eabd832ac113aa9c955eae685a8afd
20170503 14:41:13-!- JyrkiVesterinen [~JyrkiVest@85-76-67-125-nat.elisa-mobile.fi] has quit [Quit: .]
20170503 14:43:37-!- gfgtdf [~chatzilla@x4e363b9f.dyn.telefonica.de] has joined #wesnoth-dev
20170503 14:43:51< gfgtdf> 20170503 02:44:54< celticminstrel> It's probably very common that you'll want to split it on line breaks anyway.
20170503 14:46:16< gfgtdf> celmin|sleep: well afaik currently the oynl usecases in mainline are 1) reading  a .map file and pass it to [terrain_mask], 2) read some formula code somehwre in the ai files.
20170503 14:46:43< gfgtdf> celmin|sleep: so for those current form seems the most suited.
20170503 14:49:49< gfgtdf> wedge009: i wanted you to ask 2 things 1) join me o mp serve to test http://gna.org/bugs/?25686 2) help me adding boost string_view to the aquileia/external repo
20170503 14:50:08< gfgtdf> wedge009: but it seems like we are online at sifferent times.
20170503 15:16:50-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170503 15:18:05-!- gfgtdf [~chatzilla@x4e363b9f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170503 15:37:30-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has joined #wesnoth-dev
20170503 15:37:30-!- deathisundead [~quassel@c-73-144-114-234.hsd1.mi.comcast.net] has quit [Changing host]
20170503 15:37:30-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20170503 16:05:29-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 16:23:35< vultraz_iOS> celmin|sleep: are you going to move all the prefs files into a single folder or should I?
20170503 16:23:47< vultraz_iOS> celmin|sleep: and should lua_preferences be moved with them
20170503 16:48:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170503 16:52:13-!- Ivanovic [~ivanovic@p4FC534A6.dip0.t-ipconnect.de] has quit [Changing host]
20170503 16:52:13-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20170503 17:01:32-!- vn971 [~vasya@0896414046.static.corbina.ru] has joined #wesnoth-dev
20170503 17:13:16-!- atarocch [~atarocch@64.251.121.244] has joined #wesnoth-dev
20170503 17:26:17-!- irker427 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170503 17:27:16-!- vn971 [~vasya@0896414046.static.corbina.ru] has quit [Quit: Leaving.]
20170503 17:28:29< celmin|sleep> vultraz_iOS: If you're moving prefs files into a folder, lua_preferences would not be among them.
20170503 17:28:43< celmin|sleep> You'd want... game_preferences, preferences, and uh... I think there's one or two more?
20170503 17:28:57< celmin|sleep> display_preferences maybe? Or preferences_display?
20170503 17:29:07< celmin|sleep> The new credentials file also counts.
20170503 17:30:15-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170503 17:30:15< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang c9d484e: Storyscreen/Parser: don't keep parsing if special action was already executed Failed
20170503 17:30:15< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-325
20170503 17:30:19-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170503 17:37:31-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170503 17:37:31< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang c9d484e: Storyscreen/Parser: don't keep parsing if special action was already executed Failed
20170503 17:37:31< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-325
20170503 17:37:35-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170503 17:40:02-!- vn971 [~vasya@ppp91-79-180-146.pppoe.mtu-net.ru] has joined #wesnoth-dev
20170503 17:41:03-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20170503 17:55:08-!- celmin|sleep is now known as celticminstrel
20170503 17:56:24-!- mjs-de [~mjs-de@x4db5fcbc.dyn.telefonica.de] has joined #wesnoth-dev
20170503 18:01:26-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170503 18:03:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170503 18:06:23-!- irker409 [~irker@109.237.213.40] has joined #wesnoth-dev
20170503 18:06:23< irker409> wesnoth: mattsc wesnoth:master 2fec0500506e / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/2fec0500506e88e88e2aa273add8c82c963a2eb7
20170503 18:16:09< mattsc> zookeeper: have you seen the (minor) SotBE rebalancing suggestions here: https://forums.wesnoth.org/viewtopic.php?f=38&t=16994&p=611595#p611595
20170503 18:16:15< mattsc> Do you have an opinion on that?
20170503 18:17:41< mattsc> Also, do you understand what he means with increasing early finish bonus by one gold?  One gold per turn or village or something?
20170503 18:22:26-!- vn971 [~vasya@ppp91-79-180-146.pppoe.mtu-net.ru] has quit [Quit: Leaving.]
20170503 18:25:32-!- gfgtdf [~chatzilla@x4e363b9f.dyn.telefonica.de] has joined #wesnoth-dev
20170503 18:25:44< gfgtdf> celticminstrel: did yu just add the new issue flags ?
20170503 18:25:56< celticminstrel> Yes.
20170503 18:25:59< celticminstrel> Copied from GNA.
20170503 18:26:09< gfgtdf> oh ok
20170503 18:26:28< gfgtdf> celticminstrel: so as a preperation to move the older bugs there ?
20170503 18:26:33< celticminstrel> Yes.
20170503 18:27:55-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20170503 18:31:38-!- gfgtdf [~chatzilla@x4e363b9f.dyn.telefonica.de] has quit [Ping timeout: 276 seconds]
20170503 18:35:05-!- vn971 [~vasya@ppp91-79-180-146.pppoe.mtu-net.ru] has joined #wesnoth-dev
20170503 18:40:07-!- gfgtdf [~chatzilla@x50abe4c3.dyn.telefonica.de] has joined #wesnoth-dev
20170503 18:41:32< gfgtdf> i saw at multiple priject that they order their labes by some vategory like: in the form 'category:value' as the lavel, liek 'os:windows' still thinking about when it woudl make sense here
20170503 18:42:19< gfgtdf> also in unsure about whether some labels do really make sense for exampel we have 'mp' and 'networking' and i don't realyl see the difference.
20170503 18:44:11< celticminstrel> I suggested that to vultraz_iOS and he said he didn't see why it was needed.
20170503 18:45:22< celticminstrel> While I can see how there's an overlap between MP and Network, I don't think they're redundant.
20170503 18:45:37< celticminstrel> If you're working on Dark Forecast for example, that's MP but not Network.
20170503 18:46:00< celticminstrel> I think there's room for several more purple labels, actually.
20170503 18:46:28< celticminstrel> Like Lua API, Addon Server, etc.
20170503 18:48:37< gfgtdf> celticminstrel: hmm ye i agree tat we codul add more of those type of labels
20170503 18:49:13-!- markus_ [~mjs-de@x4db5f238.dyn.telefonica.de] has joined #wesnoth-dev
20170503 18:51:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170503 18:51:44< celticminstrel> gfgtdf: Did you look at my wesnoth.require PR?
20170503 18:51:58< gfgtdf> celticminstrel: are you going to create a new github account to create all those tocktes with ?
20170503 18:52:01< gfgtdf> celticminstrel: not yet
20170503 18:52:24< celticminstrel> I don't really want to create a new github account for making the tickets, but the thought had crossed my mind.
20170503 18:52:52-!- mjs-de [~mjs-de@x4db5fcbc.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20170503 18:53:42< celticminstrel> gfgtdf: Do you think comments should be appended to the issue body or added as actual comments?
20170503 18:54:17< gfgtdf> celticminstrel: iÄ'D probably add then as comments.
20170503 18:57:57< gfgtdf> celticminstrel: is the new wesnth requite 100% backwards compatible ?
20170503 18:58:18< celticminstrel> I know know reason why it wouldn't be?
20170503 18:58:21< celticminstrel> ^know no
20170503 18:58:30< zookeeper> mattsc, no idea about what he meant by that, no
20170503 18:59:00< celticminstrel> wesnoth.require "lua/helper.lua" and wesnoth.require "helper" are equivalent.
20170503 18:59:28-!- atarocch [~atarocch@64.251.121.244] has quit [Ping timeout: 240 seconds]
20170503 18:59:54< DeFender1031> zookeeper, mattsc, sounds like it means one per turn.
20170503 19:04:34< zookeeper> as in one more village to the map? maybe
20170503 19:06:24< gfgtdf> hmm no objectes here to it
20170503 19:12:29-!- atarocch [~atarocch@64.251.121.244] has joined #wesnoth-dev
20170503 19:17:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170503 19:21:17< mattsc> zookeeper, DeFender1031: something we should clarify.  As for the gold/turn/income changes to Silent Forest, any comments on that?
20170503 19:21:28< mattsc> Anybody other than me want to take this on?  :P
20170503 19:23:30< zookeeper> mattsc, the suggestions in your post? sounds good to me
20170503 19:24:05< mattsc> zookeeper: yes, those (sorry)
20170503 19:33:24< mattsc> The Desert of Death map is entirely devoid of villages (in part, probably, because there’s no point in going there).
20170503 19:33:51< mattsc> We could add one in the south of the little lake in that area, say at 23,10.
20170503 19:34:20< mattsc> Far enough out of the way to make you think about whether it’s worth it, but still feasible.
20170503 19:35:19< mattsc> Sorry: … devoid of villages in the NE part of the map.
20170503 19:42:50< zookeeper> or just one more to the SE corner somewhere
20170503 19:43:22< zookeeper> (it's a bit weird how many villages there already are in the middle of this supposedly really inhospitable desert :p)
20170503 19:43:37< mattsc> sure; and yes, it is
20170503 19:47:08-!- markus_ [~mjs-de@x4db5f238.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20170503 19:53:30< zookeeper> mattsc, if no one else feels like doing it, i can apply your suggested changes and that desert of death village thing. seems like a pretty mechanical task after all...
20170503 19:54:37< mattsc> zookeeper: yeah, agreed.  Same here.  Just let me know.
20170503 19:56:17< zookeeper> same here as in you'll do it if no one else feels like it? :P
20170503 19:57:29< mattsc> Something along those lines.  I don’t feel like doing it, but it’s easy enough …  ;)
20170503 19:57:43< zookeeper> i guess we no longer have any bots here which can flip dice or coins...
20170503 19:58:41< mattsc> hehe
20170503 19:59:56< zookeeper> well, okay, i'll try to psych myself into doing it first thing tomorrow
20170503 20:00:09< mattsc> I was tempted to ask CannonFodder to put in a PR, but I have no idea if he has any WML experience.  And in any case, that’s probably more work than just doing it my/yourself.
20170503 20:01:12< mattsc> zookeeper: cool, you have my full moral support.  ;)  
20170503 20:02:21< mattsc> And, in good time honored tradition, we spent way more time talking about this than the actual change itself will take!
20170503 20:06:29< zookeeper> maybe
20170503 20:07:16-!- Kwandulin [~Kwandulin@p200300760F6D80A5D1C63ED7267BA5CC.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170503 20:08:45< Ravana_> is there any design reason why [chat] is only displayed to human players who control side?
20170503 20:18:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170503 20:18:49< gfgtdf> Ravana_: i think that's what side filter in chat[ does?
20170503 20:19:03< Ravana_> yes
20170503 20:19:25< Ravana_> which is why I ask, if it is that way by design
20170503 20:20:03< gfgtdf> Ravana_: not sure, i never used in my addon.
20170503 20:20:14< gfgtdf> Ravana_: you can eeaisly use wesnoth.message directly tohugh
20170503 20:20:21< Ravana_> yes
20170503 20:23:33< gfgtdf> Ravana_: ok i looked at the history and it seems liek it's actualla a behviour change introduced in 923ae89cce9014dc36ef72ebf2d731b469dcf6ab
20170503 20:24:21< gfgtdf> Ravana_: note that before that commit wesnoth.message was called unconditionally if side= was not given
20170503 20:30:25-!- atarocch [~atarocch@64.251.121.244] has quit [Ping timeout: 240 seconds]
20170503 20:32:50< Ravana_> interesting...
20170503 20:34:08< Ravana_> so it shows to all sides that match filter... but what about showing to everyone, other than sides that do not match filter
20170503 20:35:19< Ravana_> (my goal is to have chat take optional key that controls if output is visible to observer)
20170503 20:36:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 245 seconds]
20170503 20:50:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170503 20:55:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170503 20:57:31< Ravana_> I understand that even if whatever I change is not accepted for core, I can see [chat] messages
20170503 20:58:38< celticminstrel> Uhhh... why is this even still open? https://gna.org/bugs/index.php?5400
20170503 21:00:40< celticminstrel> I'm not going to attempt to filter out bugs that should have been closed long ago, but... if I happen to notice one, I might as well omit it, right?
20170503 21:01:12< celticminstrel> Unless of course someone wants to go through all the open bugs on GNA and see if there are any that should have been closed long ago.
20170503 21:01:18< celticminstrel> There are only about 600 of them. >_>
20170503 21:02:03< celticminstrel> So anyway, I have a parser that converts the Savane XML into Github API JSON.
20170503 21:03:18< celticminstrel> I assume the GNA website will go down at some point, right? So I should probably not link back to its attachments...
20170503 21:06:47-!- irker409 [~irker@109.237.213.40] has quit [Quit: transmission timeout]
20170503 21:09:13< gfgtdf> celticminstrel: so you are only going to port the open bugs ?
20170503 21:09:19< celticminstrel> Yes.
20170503 21:09:37< gfgtdf> celticminstrel: you already know what you are going to do with the glosed bugs?
20170503 21:09:43< gfgtdf> closed*
20170503 21:09:58< celticminstrel> No.
20170503 21:10:16-!- vn971 [~vasya@ppp91-79-180-146.pppoe.mtu-net.ru] has left #wesnoth-dev ["PART #wesnoth :ISON Rogach NickServ "]
20170503 21:12:00< gfgtdf> celticminstrel: there are quite some commits show message is basically 'fix #1234' and not havign those old bugs available woudl make them really hard to understand.
20170503 21:12:19< celticminstrel> That's true...
20170503 21:12:51< gfgtdf> celticminstrel: can your script also create labels? i wonder whtehr it'd make senst to have label like oldid:1234 but that'D require creating a lot lables automatically.
20170503 21:13:16< celticminstrel> But there are nearly 7000 closed issues.
20170503 21:13:32< celticminstrel> It's possible to create new labels via the Github API, but I don't think that'd be a good use of labels.
20170503 21:14:22< celticminstrel> I've included a link to the GNA page in the output, so the old ID is available that way.
20170503 21:15:01< gfgtdf> celticminstrel: i thought gna is going down ?
20170503 21:15:07< celticminstrel> Yeah.
20170503 21:15:20< celticminstrel> But the URL contains the old ID even if the link is broken.
20170503 21:15:30< gfgtdf> celticminstrel: right
20170503 21:15:32< celticminstrel> I mean, I could just put the ID instead of the URL if you prefer though.
20170503 21:15:53< gfgtdf> celticminstrel: url is fine al longs as it shows up when ypou type the id in the search field
20170503 21:16:05< celticminstrel> I have no idea whether it would.
20170503 21:16:33< gfgtdf> celticminstrel: we coudl simply test it? i assume you are first testign your script ona  dummy repo before you upload them to github ?
20170503 21:16:49< gfgtdf> upload them to wesnoth repo*
20170503 21:16:56< celticminstrel> I dunno, maybe?
20170503 21:17:11< celticminstrel> I hadn't gotten it to the point of being able to test it yet.
20170503 21:17:26< celticminstrel> Right now it jsut dumps invalid JSON.
20170503 21:17:37< celticminstrel> (Invalid because it's of the form {...}{...}{...} etc)
20170503 21:17:40< celticminstrel> ^jsut
20170503 21:17:55< celticminstrel> (ie a bunch of valid JSON objects all concatenated.)
20170503 21:17:59< celticminstrel> ^just
20170503 21:19:29< gfgtdf> celticminstrel: so you writing it yourself and not using a json library?
20170503 21:19:53< celticminstrel> No, I'm using the Python json module.
20170503 21:20:08< celticminstrel> But I just dumped a series of objects to the same file to see if it looks like it's working.
20170503 21:20:30< gfgtdf> ok
20170503 21:28:30-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170503 21:31:15< SigurdFD> celticminstrel: I've been thinking about doing something like that (going through the 600 bugs, about which 1/2 are FR's)...
20170503 21:31:47< SigurdFD> ... as long as the processing of them doesn't get bogged down
20170503 21:31:53< celticminstrel> Hm?
20170503 21:31:58< celticminstrel> What do you mean by that last bit?
20170503 21:32:19< SigurdFD> lengthly discussions if it is vaild to close them or not.
20170503 21:32:25< celticminstrel> Ah.
20170503 21:32:37< celticminstrel> Well, I'd say, just produce a list of bug numbers that look like they can be closed?
20170503 21:36:08< SigurdFD> ok. It's something I'd chip away at.
20170503 21:37:53< SigurdFD> not sure if I should wait until export to github, or if this is something I could start on before that
20170503 21:38:46< celticminstrel> Well, if done before the import, those issues can be skipped when importing, but I guess it doesn't really matter too much either way.
20170503 21:40:05< SigurdFD> ok
20170503 22:01:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170503 22:02:34< celticminstrel> Sample result of my script: https://github.com/CelticMinstrel/wesnoth/issues/5
20170503 22:04:29< celticminstrel> Triggered rate-limiting after around 10 issues.
20170503 22:05:23-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170503 22:06:30< celticminstrel> Looks like adding a nonexistent label automatically creates it, too.
20170503 22:08:50< celticminstrel> 5000 requests per hour, huh. So if I force it to wait 1 second after every request, I think that should avoid triggering the limit?
20170503 22:09:50< vultraz_iOS> dont post open security bugs
20170503 22:10:02< celticminstrel> ?
20170503 22:10:26< vultraz_iOS> if youre posting the gna bugs exclude security ones 
20170503 22:10:30< celticminstrel> I've already set it to skip bugs that are private.
20170503 22:10:40< celticminstrel> Which happens to also include all those with severity set to security.
20170503 22:13:03< celticminstrel> Waiting one second is also described in the best practices, though maybe I should wait even longer since issues trigger notifications and thus might be even further limited.
20170503 22:16:03< gfgtdf> celticminstrel: hmm i think the 'linux' labes doesnt really fit there
20170503 22:16:59< celticminstrel> ?
20170503 22:17:14< gfgtdf> celticminstrel: you dummy isue has athe 'linux' label attached ot it
20170503 22:17:16< celticminstrel> Oh.
20170503 22:17:30< celticminstrel> That's because the original issue had Linux in the OS field.
20170503 22:17:33< gfgtdf> celticminstrel: probably better to just put the os information in the first post than making it a tag sicne teh usualy dont impyl is related to that os, just that is was rproduced there
20170503 22:17:53< gfgtdf> celticminstrel: also i think  we shodul ignore the os field for feature requests
20170503 22:18:01< celticminstrel> I think I'll do that, yes.
20170503 22:20:00< celticminstrel> gfgtdf: There are several more sample ported issues too now, if you want to look.
20170503 22:20:51< celticminstrel> The only problem with skipping OS for feature requests is that OS is processed before bug/feature.
20170503 22:22:01< gfgtdf> celticminstrel: well if it's not put as a tag it doesn't hurt that mjuch i think.
20170503 22:22:40< gfgtdf> celticminstrel: also it seems like you don't keep servity flag for low/minor issue
20170503 22:23:36< celticminstrel> I don't keep severity at all, except for blocker.
20170503 22:23:44< celticminstrel> Though changes to severity are included.
20170503 22:24:05< celticminstrel> I don't keep priority either, but I do include changes to priority.
20170503 22:24:06< gfgtdf> hm ok
20170503 22:25:00-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170503 22:33:33< celticminstrel> So I think the script is basically done.
20170503 22:33:43< celticminstrel> I'm not going to post it since it contains my password. >_>
20170503 22:34:00< celticminstrel> Though obviously it could be reworked a little to avoid that.
20170503 22:34:31< celticminstrel> I could add downloading of attachments though.
20170503 22:34:43< celticminstrel> Possibly even re-uploading them elsewhere.
20170503 22:41:55< gfgtdf> celticminstrel: maybe we coudl put the other (closed) issue d in a dummy repo with the same script if we dont want them at wesnoth main repo?
20170503 22:42:07< celticminstrel> I suppose?
20170503 22:42:27< celticminstrel> It's certainly an option, yeah.
20170503 22:47:53< SigurdFD> celticminstrel, Aginor: the 'Show Lua Console' not working on title screen was introduced in the composed hotkeys pr
20170503 22:48:06< celticminstrel> Aginor: ^
20170503 22:54:14-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has quit []
20170503 23:03:13< vultraz_iOS> assigned the bug to aginor too
20170503 23:04:47< vultraz_iOS> probably something in hotkey_keyboard::save_helper
20170503 23:16:49< celticminstrel> BTW vultraz_iOS, do you think "meta" is a good name for that label? The intention is for issues related to the repository, GitHub, Travis, Appveyor, etc.
20170503 23:17:27< vultraz_iOS> "services"
20170503 23:19:01< celticminstrel> vultraz_iOS: I don't know what labels to apply to 1018 and 1020.
20170503 23:19:28< vultraz_iOS> you don't need to apply labels to everything
20170503 23:19:59< celticminstrel> It's probably a good idea to TBH.
20170503 23:20:00< vultraz_iOS> i'd say "bug" but I really don't think we need to mark everything as bug since that will  be the majority of entries
20170503 23:20:07< celticminstrel> Labels can be used for filtering.
20170503 23:20:24< celticminstrel> I dunno if you can filter on the absence of a label.
20170503 23:20:37< celticminstrel> I'm not sure if 1018 is a bug. Did you actually read it?
20170503 23:20:59< vultraz_iOS> ah right
20170503 23:21:04< vultraz_iOS> that should be enhancement
20170503 23:21:33< vultraz_iOS> btw you never replied to
20170503 23:21:35< vultraz_iOS> <vultraz_iOS> Charles Dang celmin|sleep: are you going to move all the prefs files into a single folder or should I?
20170503 23:21:35< vultraz_iOS> 3:23 AM celmin|sleep: and should lua_preferences be moved with them
20170503 23:21:35< celticminstrel> Maybe change the title too?
20170503 23:21:46< celticminstrel> I did reply to that.
20170503 23:22:09< celticminstrel> [May 03@1:28:29pm] celmin|sleep: vultraz_iOS: If you're moving prefs files into a folder, lua_preferences would not be among them.
20170503 23:22:09< vultraz_iOS> oh i must have dced 
20170503 23:22:10< celticminstrel> [May 03@1:28:43pm] celmin|sleep: You'd want... game_preferences, preferences, and uh... I think there's one or two more?
20170503 23:22:11< celticminstrel> [May 03@1:28:57pm] celmin|sleep: display_preferences maybe? Or preferences_display?
20170503 23:22:12< celticminstrel> [May 03@1:29:07pm] celmin|sleep: The new credentials file also counts.
20170503 23:22:27< celticminstrel> Well, you were technically still connected when I replied.
20170503 23:22:40< vultraz_iOS> i didn't get it
20170503 23:22:51< celticminstrel> I see.
20170503 23:23:05< celticminstrel> I don't know what to change the title of 1018 to.
20170503 23:36:21< celticminstrel> gfgtdf: What's the status of PR 1010?
20170503 23:40:20-!- irker576 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170503 23:40:20< irker576> wesnoth: Celtic Minstrel wesnoth:lua_require 9ad5a5698437 / data/lua/wml/test_condition.lua: Fix lua error in [test_condition] https://github.com/wesnoth/wesnoth/commit/9ad5a56984374083065cbbba4d6af0cea1c845cb
20170503 23:43:54-!- sevu [~Unknown@p5485651C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170503 23:52:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170503 23:52:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
--- Log closed Thu May 04 00:00:04 2017