--- Log opened Sat May 06 00:00:00 2017
--- Day changed Sat May 06 2017
20170506 00:00:00-!- Appleman1234 [~Appleman1@pl24634.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170506 00:01:44< vultraz_iOS> unassign
20170506 00:01:48< vultraz_iOS> coffee...
20170506 00:01:59< vultraz_iOS> well I know who that is but dunno if he ever mved to gh
20170506 00:02:17< vultraz_iOS> anything assigned to mordante unassign too since he never set up his gh accint
20170506 00:02:19< vultraz_iOS> account
20170506 00:02:32< celticminstrel> Seems to be an issue or too still assigned to AI0867, should I leave those or reassign?
20170506 00:02:36< celticminstrel> ^or two
20170506 00:02:56< vultraz_iOS> leave for now
20170506 00:02:59< celticminstrel> I'm unassigning coffe, e s r, gabba, j_daniel so far.
20170506 00:03:19< vultraz_iOS> unassign anything from Aginor too
20170506 00:04:51< celticminstrel> I think things can only be assigned to project members, too.
20170506 00:06:00< vultraz_iOS> yes
20170506 00:06:04< vultraz_iOS> which is good
20170506 00:07:49< celticminstrel> I'm reassigning crab's issues to mattsc so he can evaluate if they're still relevant.
20170506 00:08:24< celticminstrel> Whoa, mordante has a lot.
20170506 00:11:00< celticminstrel> "sapient" on github is a totally different person.
20170506 00:12:15< sevu> shiki on github is as well a totally different person
20170506 00:12:29< celticminstrel> Should I unassign or reassign?
20170506 00:12:46< celticminstrel> Or does he have a github account?
20170506 00:14:38< vultraz_iOS> sapient?
20170506 00:14:40< vultraz_iOS> dunno
20170506 00:15:36< celticminstrel> Should I unassign or reassign?
20170506 00:16:02< vultraz_iOS> always reassign if appropriate else unassign
20170506 00:16:21< celticminstrel> So to who?
20170506 00:16:48< celticminstrel> It's automated, so either I reassign all his bugs to X or I leave all his bugs unassigned.
20170506 00:17:04< vultraz_iOS> i see
20170506 00:17:10< vultraz_iOS> uhhh
20170506 00:17:14< vultraz_iOS> unassign
20170506 00:17:27-!- sevu [~Unknown@141.39.226.226] has quit [Disconnected by services]
20170506 00:17:27-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170506 00:19:02< celticminstrel> And shadowm?
20170506 00:19:24< vultraz_iOS> keep assigned
20170506 00:19:37< celticminstrel> It looks like "soliton" on github might also be a different person.
20170506 00:20:36< celticminstrel> I have no clue who thunderstruck even is.
20170506 00:20:55< vultraz_iOS> uhhh
20170506 00:21:06< vultraz_iOS> yeah unassign
20170506 00:21:07< celticminstrel> (Unassigning since they're clearly inactive.)
20170506 00:22:06< celticminstrel> Wow, you have a lot assigned too.
20170506 00:24:20< celticminstrel> So I'm currently testing my script on a copy of the repo. When it's done I'll get people to look at it.
20170506 00:24:25< celticminstrel> Then I'll run it again on the real repo.
20170506 00:24:31< vultraz_iOS> good idea
20170506 00:24:39< celticminstrel> ATM it's skipping assignees.
20170506 00:24:48< vultraz_iOS> if you need extra access just ping
20170506 00:24:56< celticminstrel> Since no-one has access on the copy.
20170506 00:25:01< celticminstrel> Extra access?
20170506 00:25:08< celticminstrel> Oh, it crashed again. ><
20170506 00:25:21< vultraz_iOS> to the main repo to fiddle with stuff but I don't think so
20170506 00:27:10< celticminstrel> I only need permissions to create issues and post comments, so...
20170506 00:33:28< celticminstrel> vultraz_iOS: I started adding [color_range]default=yes so that there's no need to keep two things in sync. Sound okay?
20170506 00:33:41< vultraz_iOS> what?
20170506 00:33:49< vultraz_iOS> im confused
20170506 00:33:51< celticminstrel> default_colors
20170506 00:34:00< celticminstrel> And the order of the [color_range] tags
20170506 00:34:07< celticminstrel> Currently need to be kept in sync.
20170506 00:34:10< vultraz_iOS> yes
20170506 00:34:28< vultraz_iOS> so you'll build the list from the tag order?
20170506 00:34:34< vultraz_iOS> no objections
20170506 00:37:20< vultraz_iOS> celticminstrel: actually, unassign shadowm's bugs
20170506 00:38:36< celticminstrel> There are a total of 9 currently assigned to him.
20170506 00:38:47< celticminstrel> Oh hey, at least one of those can be closed.
20170506 00:41:51< celticminstrel> BTW, bold formatting on GNA will become italics, because it's too much work to identify all the bold without false positives.
20170506 00:41:52 * vultraz_iOS wishes he had configured clang format a long time ago instead of manually formatting files
20170506 00:42:14< vultraz_iOS> celticminstrel: that is the least of our worries
20170506 00:42:40< celticminstrel> I figured it wouldn't really affect the semantic content of the posts anyway.
20170506 00:43:26< celticminstrel> I wonder if I should check for ftp links too. Probably not worth it...?
20170506 00:44:26< vultraz_iOS> celticminstrel: ya know what, make it simple: unassign any bug not assigned to me, you, gfgtdf, zookeeper, jyrki, wedge, loonycyborg, or Elvish_Hunter
20170506 00:44:56< celticminstrel> As far as I can see, there's literally only one link in the open issues.
20170506 00:46:46-!- gfgtdf [~chatzilla@x4e363c4a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0/20170413192749]]
20170506 00:47:18< celticminstrel> Oh, it hit another 422.
20170506 00:48:19-!- Shiki_ [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170506 00:49:28-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170506 00:49:53< celticminstrel> Apparently an issue didn't have an item_group assigned.
20170506 00:50:41< celticminstrel> At the current rate it'll take almost a full day, huh.
20170506 00:50:51< celticminstrel> Maybe I should increase the rate again.
20170506 01:08:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170506 01:15:11< celticminstrel> MP Staging crashes if there are no default colours BTW. Maybe that should be fixed eventually just in case.
20170506 01:18:12-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170506 01:21:40-!- Shiki_ [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170506 01:26:16< irker216> wesnoth: Celtic Minstrel wesnoth:master 4c5bf2dae2db / / (7 files in 3 dirs): Auto-build default team colors list https://github.com/wesnoth/wesnoth/commit/4c5bf2dae2db8637ea743281bae4bd480269c78f
20170506 01:33:56< celticminstrel> Hmm. I wonder what would be the performance hit of calling set_label multiple times from calculate_best_size.
20170506 01:34:21< celticminstrel> It's probably cheaper to set label_ directly, though it's currently private in styled_widget so I'd need to change that.
20170506 01:34:42< celticminstrel> Well, I'll just push to a branch I guess and let others review it.
20170506 01:51:31-!- Shiki_ [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170506 01:52:05-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170506 01:58:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170506 02:07:32< celticminstrel> Oh, a wild JaMiT appeared.
20170506 02:11:49< vultraz_iOS> indeed
20170506 02:11:51< celticminstrel> 141/645
20170506 02:23:21-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170506 02:24:40-!- Shiki_ [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170506 02:25:25< celticminstrel> 160/645 and it triggered abuse limit.
20170506 02:27:50< celticminstrel> Sooo, the cause of the Create Game issue was the Custom Options panel.
20170506 02:28:29< vultraz_iOS> what?
20170506 02:28:49< celticminstrel> The default text is so long that it stretches the dialog. Remove the text and there's no scrollbar.
20170506 02:29:00< vultraz_iOS> add wrap = true
20170506 02:29:04< celticminstrel> But it looks like selecting Dark Forecast adds a scrollbar.
20170506 02:34:18< celticminstrel> wrap=true does work, so it's an improvement, but I guess the sliders request too much space?
20170506 02:36:05-!- aeth_ is now known as aeth
20170506 02:55:39-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 260 seconds]
20170506 02:58:32< celticminstrel> It seems that best_slider_length does nothing.
20170506 03:01:02< celticminstrel> definition = "short" also doesn't seem to make any difference
20170506 03:03:44< irker216> wesnoth: Celtic Minstrel wesnoth:master 4f3d7507e8a5 / data/gui/macros/custom_options_tree.cfg: Prevent scrollbar in MP Create 1024x768 (usually) https://github.com/wesnoth/wesnoth/commit/4f3d7507e8a5e77c9445645495c6271482c02535
20170506 03:03:45 * celticminstrel gives up.
20170506 03:05:25< celticminstrel> Okay, relative paths.
20170506 03:05:52< celticminstrel> I suppose it kinda makes sense that binary paths cannot be relative.
20170506 03:08:28< vultraz_iOS> celticminstrel: i see no scrollbar when clicking DF
20170506 03:08:37< celticminstrel> At 1024x768?
20170506 03:08:47< vultraz_iOS> yes
20170506 03:09:02< celticminstrel> Hmm, then it might be related to my local menu_button changes.
20170506 03:09:02< vultraz_iOS> oh wait
20170506 03:09:03< vultraz_iOS> no
20170506 03:09:04< vultraz_iOS> sorry
20170506 03:09:05< vultraz_iOS> 1280x768
20170506 03:09:07< celticminstrel> Oh?
20170506 03:09:10< celticminstrel> Ah.
20170506 03:09:18< celticminstrel> Yeah, it's really only at 1024x768 that you'd see it.
20170506 03:09:23< celticminstrel> It's not a big scrollbar.
20170506 03:11:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170506 03:18:20-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20170506 03:19:50-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20170506 03:21:30< vultraz_iOS> tests still broken
20170506 03:21:31< vultraz_iOS> [string "-- join.lua --..."]:19: attempt to index a function value (upvalue 'helper')
20170506 03:23:12< celticminstrel> That's weird, because requiring helper seems to work when I invoke the Lua console from the title screen.
20170506 03:23:37< celticminstrel> Oh, bug-posting just resumed.
20170506 03:24:11< vultraz_iOS> gah
20170506 03:24:13< vultraz_iOS> useless console
20170506 03:24:17< vultraz_iOS> scrolls to the top
20170506 03:32:51< celticminstrel> I think it only does that when there's wrapped lines.
20170506 03:32:59< celticminstrel> So basically if you got an error message.
20170506 03:33:38< vultraz_iOS> stupid-ass console
20170506 03:38:47< vultraz_iOS> but no, you're wrong
20170506 03:38:52< vultraz_iOS> now it constantly scrolls to end
20170506 03:50:29< irker216> wesnoth: Charles Dang wesnoth:master bf60a0a20920 / data/gui/macros/custom_options_tree.cfg: Custom Options Tree: allow 'no mods' label to grow https://github.com/wesnoth/wesnoth/commit/bf60a0a20920be8bd4b5c367dd530b3c7a4f56da
20170506 03:50:32< irker216> wesnoth: Charles Dang wesnoth:master 7d68b4ffba8c / src/gui/dialogs/lua_interpreter.cpp: GUI2/Lua Console: use static vector for constant tab match values https://github.com/wesnoth/wesnoth/commit/7d68b4ffba8c752e62994e8fc5b9ae25387b8019
20170506 04:04:38< celticminstrel> vultraz_iOS: I think you never did answer if you want to use a dummy account for posting the ported bugs?
20170506 04:05:11< celticminstrel> If we did, it could also later be useful for posting anonymous bugs.
20170506 04:05:24< celticminstrel> For example with the Git Reports service.
20170506 04:05:40< vultraz_iOS> i was thinking GR too
20170506 04:06:00< celticminstrel> So answer the question?
20170506 04:10:31< vultraz_iOS> i do not want to se a dummy account
20170506 04:34:51< celticminstrel> 239/645 and triggered abuse detection again.
20170506 04:35:13< celticminstrel> vultraz_iOS: Do you want to use Git Reports?
20170506 04:35:26< celticminstrel> vultraz_iOS: If we're not using a dummy account, whose account should post them?
20170506 04:35:34< celticminstrel> (Both Git Reports and GNA bugs.)
20170506 04:58:06< vultraz_iOS> ah
20170506 05:00:00< vultraz_iOS> didnt think of that
20170506 05:00:00< celticminstrel> ...
20170506 05:09:00< celticminstrel> vultraz_iOS: So... decision?
20170506 05:09:09< vultraz_iOS> ill think about it
20170506 05:09:17< celticminstrel> Okay, that'll do for now, I guess.
20170506 05:09:56< celticminstrel> Oh, it's continuing, yay.
20170506 05:35:58-!- Kwandulin [~Kwandulin@p200300760F6D803C90EFE9501B66FE53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170506 05:37:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170506 05:55:46< celticminstrel> 316/645 and hit the abuse limit again.
20170506 05:56:09< celticminstrel> I guess I can expect it to take at least three more batches.
20170506 05:56:19< celticminstrel> Maybe four.
20170506 06:40:38-!- JyrkiVesterinen [~JyrkiVest@87-92-10-6.bb.dnainternet.fi] has joined #wesnoth-dev
20170506 07:03:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170506 07:15:34-!- irker216 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170506 07:20:55-!- Kwandulin [~Kwandulin@p200300760F6D803C90EFE9501B66FE53.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170506 07:43:22< vultraz_iOS> celticminstrel: progress?
20170506 07:44:18< celticminstrel> On the test run of the issue porting? 293/645 and hit rate limiting again a few minutes ago.
20170506 07:44:27< celticminstrel> It sleeps for an hour each time that happens.
20170506 07:44:42< vultraz_iOS> i see
20170506 07:44:54< vultraz_iOS> progress on lua require issue?
20170506 07:45:33< celticminstrel> AFAIK there's no require issues in-game, so I suppose I'll have to actually try running the plugin.
20170506 07:45:53< celticminstrel> ^AFAICT
20170506 07:47:27< JyrkiVesterinen> Where is the code that loads the require Lua module?
20170506 07:47:39< JyrkiVesterinen> Anything in game_lua_kernel.cpp isn't accessible to plugins.
20170506 07:47:41< celticminstrel> lua_kernel_base
20170506 07:47:54< JyrkiVesterinen> OK, so that shouldn't be a problem.
20170506 08:02:22-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 240 seconds]
20170506 08:15:47-!- Kwandulin [~Kwandulin@p200300760F6D803C90EFE9501B66FE53.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170506 08:16:19-!- Tad_Carlucci [~lundberg@74.193.219.119] has joined #wesnoth-dev
20170506 08:18:15< Tad_Carlucci> Looks like the web site forums are under active spam attack.
20170506 08:18:28 * celticminstrel pokes vultraz_iOS 
20170506 08:18:38< celticminstrel> Also hi.
20170506 08:18:57< Tad_Carlucci> I'm headed to bed and don't feel like playing whack-a-mole.
20170506 08:19:04< Tad_Carlucci> hi.
20170506 08:19:32-!- Tad_Carlucci [~lundberg@74.193.219.119] has quit [Client Quit]
20170506 08:22:02< zookeeper> oh wow.
20170506 08:25:23< zookeeper> i banned two IPs from which it all (or the ones i checked) seemed to be coming from
20170506 08:30:32< zookeeper> there, all cleaned up
20170506 08:34:32-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20170506 08:34:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Disconnected by services]
20170506 08:34:32-!- celmin is now known as celticminstrel
20170506 08:40:36< celticminstrel> Wait, when did it hit 392? Or was it actually there already when I last announced? Has it already been an hour plus another sequence?
20170506 08:40:50< celticminstrel> And it just started going again, so probably not.
20170506 08:56:11-!- irker411 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170506 08:56:11< irker411> wesnoth: Celtic Minstrel wesnoth:rel_paths bfa5a4e80f3e / src/ (filesystem_boost.cpp game_config_manager.cpp scripting/lua_fileops.cpp): Accept ".." in file paths everywhere https://github.com/wesnoth/wesnoth/commit/bfa5a4e80f3e0d038c0e2efde6cd4581f050d12a
20170506 08:56:18< celticminstrel> Does that look safe? ^
20170506 08:56:37 * celticminstrel thinks there should probably be a unit test suite for it, too.
20170506 08:58:00< celticminstrel> (Apparently there is one! But it probably needs expansion now.)
20170506 09:05:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170506 10:01:06-!- mjs-de [~mjs-de@x5ce4a8b0.dyn.telefonica.de] has joined #wesnoth-dev
20170506 10:07:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170506 10:18:37-!- JyrkiVesterinen [~JyrkiVest@87-92-10-6.bb.dnainternet.fi] has quit [Quit: .]
20170506 10:22:36< irker411> wesnoth: Celtic Minstrel wesnoth:rel_paths f3c9e36cc344 / src/ (filesystem_boost.cpp game_config_manager.cpp tests/test_filesystem.cpp): More tests https://github.com/wesnoth/wesnoth/commit/f3c9e36cc344311b3b92ac7d4ee52ad61bac0d80
20170506 10:35:44-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170506 10:48:15< celticminstrel> 508/645
20170506 11:05:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170506 11:09:49-!- chiec [~chiec@2a01:c50e:3509:1f00:1f05:155b:5053:7345] has joined #wesnoth-dev
20170506 11:20:39< irker411> wesnoth: Charles Dang wesnoth:master 79ca2aaff487 / src/ai/ (7 files in 3 dirs): Deployed a few more cases of std::map::emplace https://github.com/wesnoth/wesnoth/commit/79ca2aaff4877413ffeb6496d14d8bf3f22ca2bc
20170506 11:20:42< irker411> wesnoth: Charles Dang wesnoth:master 8f610ec2074b / src/units/ (types.cpp types.hpp): Removed unnecessary unit_type_data::insert wrapper https://github.com/wesnoth/wesnoth/commit/8f610ec2074b0396400703bea0e1e9d06f4ed2a3
20170506 11:31:14-!- travis-ci [~travis-ci@50.17.54.68] has joined #wesnoth-dev
20170506 11:31:15< travis-ci> wesnoth/wesnoth#13747 (rel_paths - f3c9e36 : Celtic Minstrel): The build has errored.
20170506 11:31:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/229409481
20170506 11:31:15-!- travis-ci [~travis-ci@50.17.54.68] has left #wesnoth-dev []
20170506 11:32:47< celticminstrel> So it seems like there's an error loading the file?
20170506 11:35:05< vultraz_iOS> oh you're still here
20170506 11:35:11< vultraz_iOS> were you up all night
20170506 11:35:18< celticminstrel> <_<
20170506 11:41:42-!- gfgtdf [~chatzilla@x4e368224.dyn.telefonica.de] has joined #wesnoth-dev
20170506 11:43:11< celticminstrel> So for some reason the call to helper.lua raises a runtime error but with no message.
20170506 11:43:39< vultraz_iOS> but only from the tests?
20170506 11:43:57< celticminstrel> Only from the join plugin AFAICT.
20170506 11:44:02< gfgtdf> JyrkiVesterinen: maybe we could make the appveyor build msvc2017 instead of msv2015?  i think its rather save fo asume that if something works for msvc2017 adn msvc 2013 that it'll also work for ,svc 2015
20170506 11:44:08< celticminstrel> Though it could be that the host plugin simply hasn't reached that point yet.
20170506 11:44:16< gfgtdf> JyrkiVesterinen: whiel the other way irounds it's less clear
20170506 11:44:28< gfgtdf> around*
20170506 11:44:59< gfgtdf> JyrkiVesterinen: ofc building all 3 version would also be good.
20170506 11:45:28< gfgtdf> verions*
20170506 11:48:05< gfgtdf> wedge009: i tested with with vultraz_iOS help now
20170506 11:48:15< celticminstrel> I assume that's dependent on an existing "external" for 2017 though.
20170506 11:48:43< gfgtdf> celticminstrel: we have one, wedge009 just updated it
20170506 11:49:17< celticminstrel> Ah.
20170506 11:49:24< celticminstrel> What about the unit tests lib for all three versions?
20170506 11:49:47< celticminstrel> Hmm, 557/645.
20170506 11:51:04< irker411> wesnoth: Celtic Minstrel wesnoth:rel_paths 487652af447e / src/ (scripting/lua_fileops.cpp tests/test_filesystem.cpp): Stuff https://github.com/wesnoth/wesnoth/commit/487652af447edf0f8357b9088dae0b3978e7e2ef
20170506 11:52:52< wedge009> gfgtdf: Okay. What was the outcome? Does that mean your issue is resolved?
20170506 11:53:22< gfgtdf> wedge009: it semes to be a big on receiving side that seem rto be fixes in master
20170506 11:53:31< wedge009> Okay.
20170506 11:54:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170506 11:54:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170506 11:56:30< gfgtdf> wedge009: also thy for updating the vc 14 project
20170506 11:56:37< wedge009> 15?
20170506 11:56:46< wedge009> Was that sufficient to get it working for you?
20170506 11:56:56< celticminstrel> So somehow when it tries to call helper.lua it's not a function. :S
20170506 11:57:13< celticminstrel> And it fails because it's not a table with a __call metafunction.
20170506 11:57:42< celticminstrel> But it should be a function.
20170506 11:59:53< celticminstrel> Only thing I can think of off the top of my head is maybe the rotates are wrong? https://github.com/wesnoth/wesnoth/blob/master/src/scripting/lua_kernel_base.cpp#L688
20170506 12:00:00< celticminstrel> More likely the second than the first, I guess.
20170506 12:00:34< celticminstrel> The documentation for lua_rotate was vague.
20170506 12:00:52< celticminstrel> But the intention is thus:
20170506 12:01:06< celticminstrel> 1. You call dofile(filename, arg1, arg2, ...)
20170506 12:01:21< celticminstrel> 2. Rotate stack to get (arg1, arg2, ..., filename)
20170506 12:02:00< celticminstrel> 3. Load the file, replacing filename with the callable code.
20170506 12:02:13< celticminstrel> 4. Rotate stack back, to get (code, arg1, arg2, ...)
20170506 12:02:17< celticminstrel> 5. Call it.
20170506 12:02:45< celticminstrel> Thinking about it, maybe I just rotate only if gettop() > 1?
20170506 12:02:52< celticminstrel> I'll try that.
20170506 12:09:00< gfgtdf> wedge009: my aim was to get the appveyor working and appveytor doesnt budl vc15 yet
20170506 12:09:01< celticminstrel> Doesn't seem to help. Maybe rotate is already a no-op if stack size is 1.
20170506 12:09:56< gfgtdf> wedge009: so i'm hoping we'll updarte  appveyor to build vc15.
20170506 12:10:26< wedge009> That'd be great. I'd like to see how it handles FALLTHROUGH because it doesn't work for me.
20170506 12:13:12< celticminstrel> What doesn't it work on? 2015 or 2017?
20170506 12:13:24-!- JyrkiVesterinen [~JyrkiVest@87-92-10-6.bb.dnainternet.fi] has joined #wesnoth-dev
20170506 12:14:32< celticminstrel> I'm out of ideas.
20170506 12:15:23< celticminstrel> It would help if I could see what's on the Lua stack at any given time.
20170506 12:15:43< JyrkiVesterinen> gfgtdf: I think it would be best for AppVeyor to build the game with all three versions.
20170506 12:16:10< JyrkiVesterinen> My plate is currently full, though. I don't have time to add VS2017 build to AppVeyor.
20170506 12:16:41< wedge009> celticminstrel: 2017. It says it requires /std:c++latest but when I switch that on - even if only specifically for the given cpp file - I get a lot of compilation errors from boost code. The only place I could use that switch successfully was in serialization/tokenizer.cpp.
20170506 12:17:22< celticminstrel> Ah, so it's Boost that's the problem mainly.
20170506 12:17:32< JyrkiVesterinen> I tried building with VS2017 (Boost develop) earlier on, but it was in C++14 mode.
20170506 12:17:49< wedge009> Probably, but I don't know how to work around that. I presume it works for you in whichever VC you're using?
20170506 12:18:01< wedge009> JyrkiVesterinen: What does that mean? Is there a compatibility option somewhere?
20170506 12:18:13< JyrkiVesterinen> The /std switch is exactly it.
20170506 12:18:23< JyrkiVesterinen> VS2017 compiles in C++14 mode by default.
20170506 12:19:08< wedge009> ...I'm not sure I understand. You're using VS2017, like me, and you can compile code as-is, including FALLTHROUGH, using which /std switch?
20170506 12:19:34< JyrkiVesterinen> No, I can't use [[fallthrough]] with VS2017.
20170506 12:19:45< celticminstrel> IIRC, FALLTHROUGH still expands to an attribute in VS2017 regardless of switches.
20170506 12:19:58< celticminstrel> But maybe it'll just warn about unknown attribute?
20170506 12:20:17< wedge009> JyrkiVesterinen: How did you work around it then?
20170506 12:20:25< JyrkiVesterinen> I did my VS2017 experiment before the FALLTHROUGH macro was added.
20170506 12:20:32< wedge009> Ah, okay.
20170506 12:21:29< celticminstrel> Does MSVC provide a macro or something to test if /std:c++latest is used?
20170506 12:21:40< celticminstrel> Because if so, global.hpp should maybe check for it.
20170506 12:23:17< JyrkiVesterinen> Yes, _MSVC_LANG.
20170506 12:23:19< JyrkiVesterinen> https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
20170506 12:23:31< JyrkiVesterinen> "When compiled as C++, the macro is the integer literal value 201402 if the /std:c++14 compiler option is set, or by default, and it is set to a higher, unspecified value when the /std:c++latest compiler option is set."
20170506 12:24:04-!- Kwandulin [~Kwandulin@p200300760F6D803C90EFE9501B66FE53.dip0.t-ipconnect.de] has quit [Ping timeout: 255 seconds]
20170506 12:24:15< celticminstrel> ...sounds like the same as __cplusplus
20170506 12:24:20< celticminstrel> Or whatever that was.
20170506 12:24:27-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20170506 12:25:24< wedge009> I was just looking at that...
20170506 12:26:05< JyrkiVesterinen> AFAIK, __cplusplus is still set to 199711, even in C++latest mode.
20170506 12:26:13< JyrkiVesterinen> "We won’t update __cplusplus until the compiler fully conforms to the standard."
20170506 12:26:42-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170506 12:27:28< celticminstrel> I assume that doesn't mean it'll never be updated because they'll never implement export. >_>
20170506 12:30:22< vultraz_iOS> what?
20170506 12:33:07< vultraz_iOS> export?
20170506 12:37:23< wedge009> That reminds me, USE_HETEROGENOUS_LOOKUPS doesn't work for me either.
20170506 12:46:31< gfgtdf> wedge009: ye it has some bugs, but i have to wait to the appveytor build  to tell me them.
20170506 12:46:56< gfgtdf> wedge009: for exmaple this one https://github.com/wesnoth/wesnoth/pull/1010/commits/7c953d9d05055d1192f54f5af8c9fb186a073976 but i suspect thre migth be more 
20170506 12:48:10< wedge009> Yes, it all seems to be related to the definition of the config_key_type
20170506 12:48:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170506 12:49:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170506 12:49:10< gfgtdf> JyrkiVesterinen: in order to create an appveytor msvc15 build but it eb enough t copy all sewttigns from the vc 134 build ?
20170506 12:49:55< JyrkiVesterinen> It needs another variant of the configuration file: https://github.com/wesnoth/wesnoth/blob/master/.appveyor.vs2015.yml
20170506 12:50:26< JyrkiVesterinen> Other than that, few settings are changed from defaults. (And most of them don't even take effect because a configuration file is used.)
20170506 12:59:26< irker411> wesnoth: gfgtdf wesnoth:master f348723d1b57 / .appveyor.vs2017.yml: Create .appveyor.vs2017.yml https://github.com/wesnoth/wesnoth/commit/f348723d1b57dc9cbb56e409f41d816041487a3d
20170506 12:59:44< gfgtdf> just copied the appveyor.vs2015.yml fiel and replace al 14 with 15
20170506 13:00:08< JyrkiVesterinen> It looks okay to me.
20170506 13:00:42< JyrkiVesterinen> (Personally I tend to create projectfiles\VC14.1, because the C++ toolchain version is 14.1 instead of 15.)
20170506 13:01:51< gfgtdf> hmm th but external package is also names 15
20170506 13:03:16-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 13:03:17< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf f348723: Create .appveyor.vs2017.yml Failed
20170506 13:03:17< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1
20170506 13:03:20-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 13:04:11< wedge009> JyrkiVesterinen: Aye, it is, but VS as a whole is still 15, so it's confusing.
20170506 13:04:17< gfgtdf> JyrkiVesterinen: you know weterh i have to use Microsoft Visual Studio 14.1\\Common7 or Microsoft Visual Studio 15\\Common7 ?
20170506 13:04:56< irker411> wesnoth: gfgtdf wesnoth:master 0f0b61ae9cde / .appveyor.vs2017.yml: Update .appveyor.vs2017.yml https://github.com/wesnoth/wesnoth/commit/0f0b61ae9cde1bdc31c1ed4dd617e06ef8a2eb57
20170506 13:05:17< JyrkiVesterinen> The path to devenv.exe is:
20170506 13:05:18< JyrkiVesterinen> C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\devenv.exe
20170506 13:05:43< JyrkiVesterinen> At least with the Enterprise version. I don't know which version AppVeyor has.
20170506 13:05:57-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 13:05:57< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf f348723: Create .appveyor.vs2017.yml Failed
20170506 13:05:57< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-1
20170506 13:06:02-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 13:08:42< wedge009> C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe for Community edition. Looks like they changed the directory structure again, hope they stick with this one.
20170506 13:09:13< irker411> wesnoth: gfgtdf wesnoth:master 8cc8c5c16d8d / .appveyor.vs2017.yml: Update .appveyor.vs2017.yml https://github.com/wesnoth/wesnoth/commit/8cc8c5c16d8de0e0061d7838c475a45be4f61b33
20170506 13:11:16< JyrkiVesterinen> I found another performance problem with credits.
20170506 13:11:35< JyrkiVesterinen> The credits window is laid out. During the layout, the text is queried for optimal size.
20170506 13:11:59< JyrkiVesterinen> That query involves setting the text, i.e. parsing 30 kilobytes of pango markup.
20170506 13:12:01< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/8cc8c5c16d8de0e0061d7838c475a45be4f61b33/src/gui/widgets/styled_widget.cpp#L493
20170506 13:12:28< JyrkiVesterinen> Credits don't exactly fit into the screen vertically, so the scrollbar is shown.
20170506 13:12:45< JyrkiVesterinen> (An ugly hack is used to keep it invisible anyway, but that's not relevant here.)
20170506 13:13:12< JyrkiVesterinen> Enabling the scrollbar makes the scroll label throw layout_exception_width_modified.
20170506 13:13:26< JyrkiVesterinen> And that exception causes the layout process to be re-run.
20170506 13:13:40< JyrkiVesterinen> Including the part where 30 kilobytes of Pango markup is parsed.
20170506 13:14:51< JyrkiVesterinen> So, a "always invisible scrollbar" mode for scrollbar_container and using it in credits would be another big performance win if someone has time to implement that.
20170506 13:17:25< irker411> wesnoth: Wedge009 wesnoth:master 03d39d627905 / src/global.hpp: [[fallthrough]] is only supported by VC15/2017 when /std:c++latest is used. https://github.com/wesnoth/wesnoth/commit/03d39d6279053b72c5ae44cdf2324a71952a1016
20170506 13:18:28< irker411> wesnoth: gfgtdf wesnoth:master 315cfa5ddd42 / .appveyor.vs2017.yml: temporary commit to find out appveyors directory structure. https://github.com/wesnoth/wesnoth/commit/315cfa5ddd42ec2eb7cd4959232b5734b0454ffa
20170506 13:21:13< irker411> wesnoth: gfgtdf wesnoth:master dfa4f792793c / .appveyor.vs2017.yml: Update .appveyor.vs2017.yml https://github.com/wesnoth/wesnoth/commit/dfa4f792793c6ab4111a1d09bce28a00ba156f48
20170506 13:24:43-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 13:24:43< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf dfa4f79: Update .appveyor.vs2017.yml Failed
20170506 13:24:43< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-5
20170506 13:24:47-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 13:27:36-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 13:27:36< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf dfa4f79: Update .appveyor.vs2017.yml Failed
20170506 13:27:36< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-5
20170506 13:27:40-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 13:29:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170506 13:36:24< gfgtdf> wedge009: the vc15 buidl seens to fail becasue there ate header files missing in the vc15 eternal package
20170506 13:36:27< gfgtdf> external*
20170506 13:37:31< gfgtdf> wedge009: for example boost\smart_ptr\detail\sp_noexcept.hpp is missing 
20170506 13:38:12< gfgtdf> wedge009: when i doanload the the boost headers from boost.org its all there so it's mostlikely something going  wrogn when extracing the used headers.
20170506 13:38:31< gfgtdf> wedge009: note this files are new in bost 1.64 (or 1.63 not sure)
20170506 13:38:41< gfgtdf> these*
20170506 13:53:35-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20170506 13:54:20< irker411> wesnoth: mattsc wesnoth:master 6e1abcca1e8c / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project with preferences files moves https://github.com/wesnoth/wesnoth/commit/6e1abcca1e8c2440282add30ee96e89697a4de02
20170506 13:54:31-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170506 13:58:49< mattsc> zookeeper: thanks for doing the map change to Desert of Death
20170506 14:23:17< zookeeper> mattsc, i didn't commit the silent forest stuff yet because there was something i was wondering about...
20170506 14:23:22 * zookeeper tries to remember what it was
20170506 14:25:53< zookeeper> mattsc, does this seem okay? https://paste.ee/p/rhb8I
20170506 14:26:28-!- travis-ci [~travis-ci@54.234.173.51] has joined #wesnoth-dev
20170506 14:26:29< travis-ci> wesnoth/wesnoth#13750 (master - f348723 : gfgtdf): The build has errored.
20170506 14:26:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/229434204
20170506 14:26:29-!- travis-ci [~travis-ci@54.234.173.51] has left #wesnoth-dev []
20170506 14:30:59< mattsc> zookeeper: yes, that looks good as far as I can tell, thanks
20170506 14:32:22< zookeeper> all right, i'll throw that in then
20170506 14:33:10< zookeeper> bound to make things a lot easier on the easiest difficulty, but i guess that's not a bad thing in this case.
20170506 14:35:59< gfgtdf> wedge009: i now fixed the externl package
20170506 14:36:21-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 14:36:21< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release mattsc 6e1abcc: Update Xcode project with preferences files moves Failed
20170506 14:36:21< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-6
20170506 14:36:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 14:37:18< mattsc> zookeeper: Agreed, I don’t think that’s a problem either.
20170506 14:37:49< mattsc> One of us should also reply to the forum post once this is in.
20170506 14:40:34-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 14:40:34< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug mattsc 6e1abcc: Update Xcode project with preferences files moves Failed
20170506 14:40:34< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-6
20170506 14:40:38-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 14:41:20< irker411> wesnoth: gfgtdf wesnoth:master 034c6430904c / src/config.hpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/034c6430904cfcb0c52cda332a7fd98232e5233e
20170506 14:41:22< irker411> wesnoth: ln-zookeeper wesnoth:master 1efa889c3a1f / data/campaigns/Son_Of_The_Black_Eye/scenarios/08_Silent_Forest.cfg: SotBE S8: Balance changes to make the scenario easier overall https://github.com/wesnoth/wesnoth/commit/1efa889c3a1f6270c834b2af934f509b083768b2
20170506 14:42:50< zookeeper> huh. how was i able to push without git whining as usual, even though gfgtdf pushed between my push and latest pull?
20170506 14:43:55-!- Kwandulin [~Kwandulin@p200300760F6D801B055C4A8B6D11E63D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170506 14:46:20< zookeeper> mattsc, i'll post
20170506 14:48:05< mattsc> zookeeper: thanks
20170506 14:48:23< zookeeper> done
20170506 14:53:18< irker411> wesnoth: gfgtdf wesnoth:master 3f602f0020d2 / src/config.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/3f602f0020d27474e84aa8d91b3440aaa89daefd
20170506 14:53:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 14:54:13< wedge009> gfgtdf: Thanks for that. I see what happened now. I copied the include files as per aquileia's instructions, but only the modified files got committed - there were additional files which didn't get added, but you've done that now.
20170506 15:12:34-!- gfgtdf [~chatzilla@x4e368224.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170506 15:12:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170506 15:16:59-!- gfgtdf [~chatzilla@x4e368224.dyn.telefonica.de] has joined #wesnoth-dev
20170506 15:23:24< irker411> wesnoth: gfgtdf wesnoth:master 2adb0a651cb6 / src/config.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/2adb0a651cb6919430e7b42b4cf37a98bd56b75a
20170506 15:26:41< irker411> wesnoth: Jyrki Vesterinen wesnoth:large-gui-canvas 180ee0162920 / src/gui/ (dialogs/end_credits.cpp widgets/window.cpp widgets/window.hpp): End credits: only start scrolling when the window is actually drawn https://github.com/wesnoth/wesnoth/commit/180ee016292071f60c4bea3d649cbf9772f0cc9a
20170506 15:27:35-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 15:27:35< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 2adb0a6: fixes to c++14 build Failed
20170506 15:27:35< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-7
20170506 15:27:40-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 15:28:20< irker411> wesnoth: gfgtdf wesnoth:master 96aa94a323bb / src/config.cpp: fixup build https://github.com/wesnoth/wesnoth/commit/96aa94a323bbc57930a121ae8a82ac45ae76ea43
20170506 15:32:08-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 15:32:08< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 96aa94a: fixup build Failed
20170506 15:32:08< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-8
20170506 15:32:12-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 15:36:23-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 15:36:23< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf 96aa94a: fixup build Failed
20170506 15:36:23< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-8
20170506 15:36:27-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 15:42:06< irker411> wesnoth: gfgtdf wesnoth:master 1c516fd8314e / src/config.cpp: fixup build https://github.com/wesnoth/wesnoth/commit/1c516fd8314e54f65b5551200f870056e5f8d207
20170506 15:44:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 15:46:05-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 15:46:05< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 1c516fd: fixup build Failed
20170506 15:46:05< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-9
20170506 15:46:09-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 15:51:01-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 15:51:01< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf 1c516fd: fixup build Failed
20170506 15:51:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-9
20170506 15:51:04-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 15:51:26-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170506 15:52:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 15:52:49< irker411> wesnoth: gfgtdf wesnoth:master 7ae0bf2996a3 / src/config.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/7ae0bf2996a3fb75f662ef641d71b68df2f7ede5
20170506 15:56:25-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 246 seconds]
20170506 16:00:09< gfgtdf> celticminstrel: https://github.com/wesnoth/wesnoth/commit/b0510bfdc7315bd999d0c4d66faf939d0fe62157 gives 'data loss conversion double -> int in game_config.cpp' warnings.
20170506 16:02:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 16:02:20< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 7ae0bf2: fixes to c++14 build Failed
20170506 16:02:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-10
20170506 16:02:25-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 16:06:21< irker411> wesnoth: gfgtdf wesnoth:master 08df6849375e / src/variable.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/08df6849375e668fa4962cfee41b28e4573b06f2
20170506 16:07:17< irker411> wesnoth: Jyrki Vesterinen wesnoth:large-gui-canvas d20e98958f16 / src/font/ (text.cpp text.hpp): Fix: lengthened credits weren't centered https://github.com/wesnoth/wesnoth/commit/d20e98958f16adc76ff83c096a73c7c97b325dc2
20170506 16:09:34-!- Appleman1234_ is now known as Appleman1234
20170506 16:10:08< irker411> wesnoth: gfgtdf wesnoth:master 8599d762f889 / src/game_config_manager.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/8599d762f889ddb01f6d8b897475305a1780c1cb
20170506 16:15:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170506 16:15:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170506 16:16:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20170506 16:21:30< JyrkiVesterinen> I opened pull request #1028.
20170506 16:31:42< irker411> wesnoth: gfgtdf wesnoth:master 12f147d1d23d / src/gui/dialogs/gamestate_inspector.cpp: fixes to c++14 build https://github.com/wesnoth/wesnoth/commit/12f147d1d23dc1b58ebc734fbf3e471f53008f44
20170506 16:33:36< celticminstrel> gfgtdf: Not a problem, the data loss is intentional. I suppose you could static_cast it if you really want.
20170506 16:35:57< irker411> wesnoth: gfgtdf wesnoth:master 1362e03df8f0 / src/game_config.cpp: fix compiler wanring https://github.com/wesnoth/wesnoth/commit/1362e03df8f06ad7546fd4759183854cbb3bd1ab
20170506 16:37:33< celticminstrel> So anyway, you can browse the test run of GNA import here: https://github.com/CelticMinstrel/wesnoth/issues
20170506 16:38:11< gfgtdf> celticminstrel: y i saw i got pinged by multiple  issues that containes a @gfgtdf
20170506 16:38:31< celticminstrel> Huh, that's odd.
20170506 16:38:44< celticminstrel> I didn't expect issues to contain people's names with @.
20170506 16:38:53< celticminstrel> Sorry about that?
20170506 16:39:33< celticminstrel> I'll start the real import probably in a couple of days, or once vultraz_iOS (or, possibly, someone else) decides on which account should do it.
20170506 16:39:34< gfgtdf> celticminstrel: no problem
20170506 16:39:50< gfgtdf> celticminstrel: it seems liek those iseus have no information baotu the Os they occured on
20170506 16:40:08< gfgtdf> about the os*
20170506 16:40:23< celticminstrel> Huh, you're right.
20170506 16:40:59< gfgtdf> celticminstrel: i suggest juts add thoe infotmation in the first post
20170506 16:41:13< gfgtdf> celticminstrel: like 
20170506 16:41:34< gfgtdf> celticminstrel: 'Original submission by sigurdfdragon on 2017-04-16 on os linux' maybe
20170506 16:42:11< gfgtdf> celticminstrel: i feel liek labl woudl be misplayced becasue labels usuualy imply that the issue is known to be related to that (od)
20170506 16:43:55< celticminstrel> The question is whether it would be easier to add them as labels and then go through and remove the labels where they're superfluous, or not add them as labels and then go through and add the labels where they really are needed. I think the former is probably easier since you can easily view all issues with a given label.
20170506 16:44:55< zookeeper> celticminstrel, what will the "opened by" name be in the final run? are you planning on doing it with/from some dedicated new "gna.org import" account, perhaps?
20170506 16:45:51< celticminstrel> zookeeper: vultraz_iOS is "thinking about it"; that was one of the options in my mind, the other being a generic "wesnoth anonymous" type account which would then also be used by Git Reports if we set that up.
20170506 16:46:09< zookeeper> right, okay
20170506 16:46:21< celticminstrel> Of course it could also just be from my own account, but personally I'd prefer not to do that.
20170506 16:46:25< gfgtdf> celticminstrel: but note that on gna os os fiels was arbitary text
20170506 16:46:31< celticminstrel> I know.
20170506 16:46:43< celticminstrel> I have a function that attempts to guess it.
20170506 16:56:52-!- gfgtdf [~chatzilla@x4e368224.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170506 16:57:47-!- gfgtdf [~chatzilla@x4e36a95e.dyn.telefonica.de] has joined #wesnoth-dev
20170506 17:07:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170506 17:12:14-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 17:12:14< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Release gfgtdf 12f147d: fixes to c++14 build Failed
20170506 17:12:14< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-13
20170506 17:12:17-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 17:14:11< gfgtdf> any idea what that one ^^failed i cannot se the error in the log 
20170506 17:15:11< JyrkiVesterinen> gfgtdf: I can investigate it locally.
20170506 17:15:22< gfgtdf> JyrkiVesterinen: that'd be nice
20170506 17:15:31< JyrkiVesterinen> I have VS2017 installed, and now when I finished the large-gui-canvas branch, I'm free for other tasks.
20170506 17:16:25-!- mjs-de [~mjs-de@x5ce4a8b0.dyn.telefonica.de] has quit [Remote host closed the connection]
20170506 17:17:20< JyrkiVesterinen> Okay... I suppose this isn't useful.
20170506 17:17:26< gfgtdf> ?
20170506 17:17:32< JyrkiVesterinen> Building wesnothlib succeeds here.
20170506 17:18:04-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20170506 17:18:44< gfgtdf> hmm the appveyor debug build also din't have any issues yet
20170506 17:19:11< JyrkiVesterinen> Oh, that was Release build.
20170506 17:19:16< JyrkiVesterinen> I'm making a debug build.
20170506 17:19:42< JyrkiVesterinen> I can try a release build later, after I get the debug build to pass.
20170506 17:20:41< gfgtdf> JyrkiVesterinen: possibly it aws alsoa  appveyor server issue, wil restert the build once debug buidl has passed
20170506 17:28:57< JyrkiVesterinen> Error	C2679	binary '[': no operator found which takes a right-hand operand of type 'const config::attribute_value' (or there is no acceptable conversion)	wesnoth	i:\battle for wesnoth\wesnoth\src\gui\dialogs\multiplayer\mp_options_helper.cpp	45	
20170506 17:29:06-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 17:29:10< JyrkiVesterinen> The AppVeyor debug build isn't going to pass.
20170506 17:29:13< JyrkiVesterinen> Will fix.
20170506 17:30:29< celticminstrel> Did someone manage to get it to build on each push instead of on a schedule, or have you been manually requesting all those builds?
20170506 17:30:52< gfgtdf> JyrkiVesterinen: hmm ye the problem is that those functio now take a string_vie and attribtue value cannot be cases to string_view
20170506 17:31:05< gfgtdf> celticminstrel: ive me manualy requesting those
20170506 17:31:40< gfgtdf> JyrkiVesterinen: so you now have to adda  .str() ebfore you pass an attribute_value to a config::operator[]
20170506 17:32:04< JyrkiVesterinen> I think it would be better to just add a conversion to string_view...
20170506 17:32:14< gfgtdf> JyrkiVesterinen: that's not realyl possible
20170506 17:32:32< gfgtdf> JyrkiVesterinen: i thought about havvinga  const std::strign& overload fo thoe operators, but im unuslaue which overload woudl thne be chosen for cfg["c_string"]
20170506 17:32:44< gfgtdf> s/unuslaue /unsure
20170506 17:33:16< JyrkiVesterinen> Would it be a problem?
20170506 17:33:25< JyrkiVesterinen> Conversion to string_view should be cheap anyway.
20170506 17:34:06< gfgtdf> JyrkiVesterinen: well one one points of those optinsation is the no std::string object is created when doing, cfg["c_string"]
20170506 17:34:37< gfgtdf> s/the/that
20170506 17:34:59< gfgtdf> hm ye now appveyor also gives that error in mp_options_helper.cpp	
20170506 17:35:23-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 17:35:23< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug gfgtdf 12f147d: fixes to c++14 build Failed
20170506 17:35:23< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-13
20170506 17:35:27-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 17:35:30-!- DeFender1031 [~DeFender1@46-116-209-76.bb.netvision.net.il] has joined #wesnoth-dev
20170506 17:35:56< gfgtdf> JyrkiVesterinen: you wnatd to fix that onew or can i ?
20170506 17:36:10< JyrkiVesterinen> I'll fix it.
20170506 17:36:29< JyrkiVesterinen> Because I have VS2017 locally, I can also fix any other errors which show up.
20170506 17:37:02< gfgtdf> ok
20170506 17:37:06< celticminstrel> I assume the problem with having a string_view conversion is something like, the content isn't always a string.
20170506 17:37:16< celticminstrel> A string_view doesn't own its content, right?
20170506 17:38:06< celticminstrel> So if the attribute_value actually contains a number, then how do you return a string_view?
20170506 17:38:32< celticminstrel> But, um, what happened to the "operator string" that was already present?
20170506 17:38:40< gfgtdf> celticminstrel: you can't, you av to use .str() becaus that creates a temporary string
20170506 17:38:48-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 17:38:48< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release gfgtdf 1362e03: fix compiler wanring Failed
20170506 17:38:48< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-328
20170506 17:38:52-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 17:39:07< celticminstrel> There was config::operator string which was (AFAIK) equivalent to .str().
20170506 17:39:16< gfgtdf> celticminstrel: the compiler wont do multiple implicit conversions attribute_value -> std::strign ->string_view
20170506 17:39:47< celticminstrel> Ah.
20170506 17:40:06< celticminstrel> Well, you could also just add an overload of operator[] that takes an attribute_value.
20170506 17:41:58-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170506 17:41:58< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug gfgtdf 1362e03: fix compiler wanring Failed
20170506 17:41:58< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-328
20170506 17:42:02-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170506 17:50:33< JyrkiVesterinen> After thinking about is, here's what I plan to do.
20170506 17:50:49< JyrkiVesterinen> Add overloads of config::operator[] for both std::string and const char*.
20170506 17:51:06< JyrkiVesterinen> The const char* overload calls the string_view overload.
20170506 17:51:34< JyrkiVesterinen> That avoids creating a std::string object when you do cfg["my string literal"].
20170506 17:53:50< gfgtdf> JyrkiVesterinen: hmm why not creatign an overload for attribute_value ?
20170506 17:54:17< JyrkiVesterinen> Because attribute_value is essentially a variant. A container for arbitrary types.
20170506 17:54:29< gfgtdf> JyrkiVesterinen: so ?
20170506 17:54:45< JyrkiVesterinen> With an attribute_value overload, it would be possible to attempt to accidentally index a config by a number key or whatever.
20170506 17:55:12< JyrkiVesterinen> It would only cause a runtime error rather than a compile-time error.
20170506 17:55:23< gfgtdf> uhm th emain reason why it currently doenst cmpile is exctl ybecause we call it with attribute_value
20170506 17:55:36< gfgtdf> you can case the variant to a string if we need to
20170506 17:55:49< celticminstrel> That's true.
20170506 17:56:19< celticminstrel> I guess an attribute_value overload isn't such a good idea after all.
20170506 17:56:28< gfgtdf> celticminstrel: why that=
20170506 17:56:34< JyrkiVesterinen> Hmm... right. There wouldn't exactly be any more type safety with a std::string overload, because an attribute value would be implicitly converted to a string anyway.
20170506 17:57:51< JyrkiVesterinen> Still, gfgtdf, would that option be any worse in your opinion?
20170506 17:58:14< JyrkiVesterinen> I'd still like to have a std::string overload rather than attribute_value overload.
20170506 17:58:42< gfgtdf> one advantage of the attrbute_vlue overload would be that we can optmize for the default case that it contains a std::string, and not copy it in that case, but i guess  it doesn't matter too much though.
20170506 17:59:26< DeFender1031> gfgtdf, I want to ask this without being in any way offensive or antagonistic, and I hope I'll succeed, but is there any way you could try to type a little slower and proofread what you type before you send it? I tend very often to find it hard to read what you're saying.
20170506 17:59:50< celticminstrel> gfgtdf: I think maybe it's not a good idea to accept floating-point indices.
20170506 18:00:15< celticminstrel> Integer indices should be fine, but... generally not used anyway.
20170506 18:00:44< gfgtdf> DeFender1031: while i generally agree that i dont type that well, ui doidnt see any read mistakes in my previous post
20170506 18:00:46< celticminstrel> I think maybe the statistics use them?
20170506 18:01:22< DeFender1031> gfgtdf, Not the one right before my comment, but a few before that was very hard to read.
20170506 18:01:41< DeFender1031> [5/6/2017 9:01:41 pm] <gfgtdf> uhm th emain reason why it currently doenst cmpile is exctl ybecause we call it with attribute_value
20170506 18:03:27< gfgtdf> celticminstrel: the problem is that atribute_value is not really typed, it's more like optmized string_map, for exmaple when you wrtite cfg["a"] = "9" will will store it as a integer, while cfg["a"] = "09" will store it as a string.
20170506 18:03:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20170506 18:05:14< celticminstrel> gfgtdf: Based on this, I think that's not true. https://github.com/wesnoth/wesnoth/blob/master/src/config.cpp#L239
20170506 18:05:27< celticminstrel> Oh, wai.
20170506 18:05:30< celticminstrel> No you're right.
20170506 18:05:40< celticminstrel> Line 260-265.
20170506 18:06:12< celticminstrel> Which also means that it won't store as a floating-point if it would lose precision, right?
20170506 18:06:55< celticminstrel> I wonder why those lines don't use from_string_verify though.
20170506 18:07:41< celticminstrel> Oh, I guess because it was already converted to double, so half of the function is unnecessary.
20170506 18:08:24< gfgtdf> celticminstrel: in wonder if it woudl break too much compabilty if we _would_ make it typed so that [node]atttr=5 is stored a number but [node]atttr="5" as a string
20170506 18:08:43< celticminstrel> TBH I think there's little point.
20170506 18:10:42< gfgtdf> celticminstrel: the current ssystem is really flawede, specially when it comes to serializing wml tables to lua objects which are typed like that.
20170506 18:11:44< celticminstrel> What's the problem when serializing to Lua tables?
20170506 18:14:08< gfgtdf> celticminstrel: the most know one is the boolena problem where loa doesnt sidderence bettween 'yes' and 'true' and converts all tres to yeses
20170506 18:14:47< celticminstrel> I don't see that as a problem TBH, but, well...
20170506 18:15:06< celticminstrel> If you really dislike it you could create a proper wrapper around the config class instead of serializing it to a regular table.
20170506 18:16:03< celticminstrel> I wonder how table.insert is implemented. You'd want to avoid breaking it.
20170506 18:16:18< JyrkiVesterinen> IMO, it's better that configs are represented as tables.
20170506 18:17:05 * celticminstrel doesn't really have a strong opinion on whether they should be tables or userdata.
20170506 18:17:18< gfgtdf> celticminstrel: config  object always store things (children) as copies , which liek quite difference from lua tables
20170506 18:17:44< celticminstrel> When does that actually matter?
20170506 18:18:27< gfgtdf> so 'local a = {}, insert(cfg, { "tag", a}) a.val = v' wouldn't change the cfg object anymore which woudl breka  lot of codes
20170506 18:19:17< celticminstrel> What are you talking about?
20170506 18:24:08< celticminstrel> Back to the GNA porting, there are a total of 197 attachments. What do you recommend? It's possible to manually go through and reattach each one, but that would take some time.
20170506 18:25:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170506 18:26:12< JyrkiVesterinen> Since irker isn't working (or slow): https://github.com/wesnoth/wesnoth/commit/1eca3736f65639d8dfc725c9ceee58ee56abdd88
20170506 18:26:23< JyrkiVesterinen> Debug build passed. I started a local release build.
20170506 18:27:05< irker411> wesnoth: Jyrki Vesterinen wesnoth:master 1eca3736f656 / src/config.hpp: Add overloads of config::operator[] for std::string and const char* https://github.com/wesnoth/wesnoth/commit/1eca3736f65639d8dfc725c9ceee58ee56abdd88
20170506 18:43:21< JyrkiVesterinen> The release build passed too.
20170506 18:43:22< celticminstrel> Okay, tweaked the script to include the priority, severity, OS, and release inline.
20170506 18:43:38< JyrkiVesterinen> I think the AppVeyor release build that failed earlier was just a fluke.
20170506 18:43:40< celticminstrel> Now the only thing it omits is discussion lock and privacy, both of which are irrelevant for GitHub.
20170506 18:43:58< celticminstrel> The former because AFAIK it's impossible, and the latter because the private ones aren't being posted anyway.
20170506 18:44:57< celticminstrel> ...also no idea what group_id is.
20170506 18:45:16< celticminstrel> Oh, there's a closed_on field, huh. Well, that's probably irrelevant since the closed bugs aren't being posted either.
20170506 18:49:05< celticminstrel> We still need to replace the mailing lists, too.
20170506 18:50:50< celticminstrel> zookeeper discovered a service where you can in theory just create one and it'll handle everything for you; it hasn't been active for awhile, though, and has no administration interface.
20170506 18:51:22< celticminstrel> Alternatively, perhaps a mailing list could be hosted on Wesnoth's servers. I looked at four possible list servers that could be used for that.
20170506 18:51:48< celticminstrel> Or, I dunno, on someone else's server, such as the Jenkins one.
20170506 18:52:32< celticminstrel> (There are two or three others listed on Wikipedia that I didn't investigate, so it's not just four options.)
20170506 18:56:03-!- JyrkiVesterinen [~JyrkiVest@87-92-10-6.bb.dnainternet.fi] has quit [Quit: Going to bed]
20170506 18:57:43< irker411> wesnoth: Celtic Minstrel wesnoth:rel_paths 1973b6524f99 / src/tests/test_filesystem.cpp: Fixup tests and add a couple more https://github.com/wesnoth/wesnoth/commit/1973b6524f99fbc1c08dd7803a124e189dc05d0b
20170506 19:21:05< irker411> wesnoth: Elias Pschernig wesnoth:master 6a287f22c5f6 / data/tools/unit_tree/helpers.py: [units.wesnoth.org] catch empty picture names in add-ons https://github.com/wesnoth/wesnoth/commit/6a287f22c5f606135b9ea3c5c0deb9d3cf6656d8
20170506 19:21:59< celticminstrel> elias: While you're here, what about changing the display for weapons from 9-3 to 9×3 to match the new in-game format?
20170506 19:22:13< celticminstrel> Both on overview and on unit details.
20170506 19:22:45< celticminstrel> ...ugh, gfgtdf.
20170506 19:22:50< gfgtdf> ?
20170506 19:22:59< celticminstrel> Your series of "fix fix fix" commits.
20170506 19:23:19< gfgtdf> yes i fixed one thing, then watches the appveyor outpout then fixed the next thign
20170506 19:26:22< celticminstrel> Which is why ugh.
20170506 19:28:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 19:30:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Read error: Connection reset by peer]
20170506 19:31:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 19:36:51< celticminstrel> Argh. I forgot what I was doing. >_>
20170506 19:37:18< celticminstrel> Oh right. Wiki.
20170506 19:58:03< celticminstrel> Can we drop the practice of using the first positional parameter as the userdata directory?
20170506 19:58:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170506 20:11:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20170506 20:24:49< celticminstrel> Okay, so a) it looks like I user lua_rotate correctly and b) it seems safe to use it when there's only one element on the stack.
20170506 20:38:47< celticminstrel> ATM it seems as though the function is left on the stack after failing to call it.
20170506 20:42:51< celticminstrel> Though I can't be certain it's the same function...
20170506 20:50:53< celticminstrel> So basically the protected call returns 2 (runtime error), and then when Wesnoth attempts to display the error message, it finds a function there instead of the error message.
20170506 20:56:25< celticminstrel> The code in helper.lua is never actually run though.
20170506 20:56:54< celticminstrel> (I know this because I added a log message to the top of the file.)
20170506 21:11:46-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170506 21:11:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170506 21:17:53< celticminstrel> I'm lost. Sorry. :(
20170506 21:26:22< gfgtdf> celticminstrel: so you think that  'Allow wesnoth.dofile to forward arbitrary arguments ' is the 'bad' commit 
20170506 21:26:24< gfgtdf> ?
20170506 21:26:38< celticminstrel> Uh. I'm not convinced of that.
20170506 21:27:03< celticminstrel> But sure, I'll try reverting it and see if that helps.
20170506 21:29:51< gfgtdf> celticminstrel: did you change nythogin since you merged that pr ?
20170506 21:30:10< gfgtdf> celticminstrel: or rather:is the erro still the same?
20170506 21:30:27< celticminstrel> I think the error is still the same.
20170506 21:33:17< celticminstrel> gfgtdf: Unrelatedly, do you think this commit looks safe? https://github.com/wesnoth/wesnoth/commit/bfa5a4e80f3e0d038c0e2efde6cd4581f050d12a
20170506 21:38:24< gfgtdf> celticminstrel: you changed is_legal_file to allow .. in it
20170506 21:38:30< gfgtdf> celticminstrel: so i'd say no
20170506 21:38:44< celticminstrel> That seems like a pretty poor way of evaluating.
20170506 21:39:13< gfgtdf> celticminstrel: i mean leading .. is sureley not enough to enure its save sicne aa/../.../thing is just equivelrne to ../thing
20170506 21:39:23< gfgtdf> equivalent*
20170506 21:39:24< celticminstrel> Though, hmm, considering that resolve is always called before is_legal, it's probably fine to revert those lines.
20170506 21:39:38< celticminstrel> Because resolve removes any safe internal .. anyway.
20170506 21:39:48< celticminstrel> I think my reasoning was that anything unsafe would end up as an initial ..
20170506 21:40:15< gfgtdf> hmm
20170506 21:41:19< gfgtdf> celticminstrel: also note that the secodn argument to get_wml_location is usualyl an absolute path
20170506 21:41:36< celticminstrel> Yeah, that's why I passed it through get_short_wml_path.
20170506 21:42:35< celticminstrel> Reverting the dofile commit does not help.
20170506 21:43:18-!- Appleman1234 [~Appleman1@pl26691.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170506 21:43:20< gfgtdf> celticminstrel: hmm i'D ned to figure out what get_short_wml_path does then
20170506 21:44:15< celticminstrel> Chops off the gamedate/userdir prefix to produce a relative path.
20170506 21:44:36< celticminstrel> Though it actually doesn't change the path if it wasn't in those dirs to begin with, I think... or does it return empty in that case..
20170506 21:47:01< irker411> wesnoth: Celtic Minstrel wesnoth:master 71ae14e851ae / data/lua/helper.lua src/scripting/lua_kernel_base.cpp: Some minor improvements to Lua error messages https://github.com/wesnoth/wesnoth/commit/71ae14e851ae23485093fb17671da824aa2bf420
20170506 21:47:02< celticminstrel> ^ Not related to the tests issue, just little things I came across while attempting to figure it out.
20170506 21:49:01< celticminstrel> ...Oh, I think I also forgot to commit the one which makes it pring "function" instead of "null string".
20170506 21:49:17< celticminstrel> Actually, was that change in the situation a result of the dofile commit...
20170506 21:50:03< celticminstrel> Maybe there's something wrong with it after all?
20170506 21:51:15< celticminstrel> It's a pretty small change though, I don't see how there could be a problem.
20170506 21:54:05< gfgtdf> someone aborted all my travis builds :O
20170506 21:54:12< celticminstrel> Except one.
20170506 21:55:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170506 22:03:27< gfgtdf> loonycyborg: jeankins doesnt build, it complains about cairo not found
20170506 22:10:54-!- chiec [~chiec@2a01:c50e:3509:1f00:1f05:155b:5053:7345] has quit [Remote host closed the connection]
20170506 22:13:27-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170506 22:14:30< loonycyborg> gfgtdf: all of them or only some?
20170506 22:15:09< gfgtdf> loonycyborg: i just checked one (that i usually use to download  wensoth_master.exe)
20170506 22:15:15-!- Kwandulin [~Kwandulin@p200300760F6D801B055C4A8B6D11E63D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170506 22:15:49< gfgtdf> loonycyborg: seems like it doesn't build for 5 days now.
20170506 22:15:53< loonycyborg> hmm did we increase min version recently?
20170506 22:16:37< celticminstrel> Yes.
20170506 22:16:55< gfgtdf> loonycyborg: quite possibly, JyrkiVesterinen said he wanted to do that but i didn'T think he did already sicne the quiera eternal packages are also not merged yet
20170506 22:17:01< celticminstrel> https://github.com/wesnoth/wesnoth/commit/c825ff7a8013d94d1cae39dffde564afcb1791e0
20170506 22:17:18< celticminstrel> I think the min version is required for his branch though.
20170506 22:17:24< celticminstrel> So it shouldn't affect master?
20170506 22:17:41< celticminstrel> I could be wrong though.
20170506 22:17:55< gfgtdf> celticminstrel: the commit you just linked is on master
20170506 22:18:10< gfgtdf> celticminstrel: stil i don't see why  he pushed that to master before the rest of the branch
20170506 22:18:27< celticminstrel> Right, but that commit only updates the INSTALL file. I don't know if anything on master relies on it yet.
20170506 22:18:44< gfgtdf> celticminstrel: that commit links to the oter commit change changes the install buidl scripts
20170506 22:18:53< gfgtdf> commit that changes*
20170506 22:19:05< gfgtdf> loonycyborg: so yes 1.10 seem to be the new minimum
20170506 22:19:34< loonycyborg> I'll look into it later a bit
20170506 22:19:39< celticminstrel> Ah, right, he updated the build scripts too, okay.
20170506 22:20:31< gfgtdf> loonycyborg: i think we assumes this wouldnt be a problme since the windows releases already use 1.10.2
20170506 22:20:35< gfgtdf> assumed*
20170506 22:21:17< loonycyborg> very possible I have older deps there
20170506 22:21:25< loonycyborg> or something else broke
20170506 22:33:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170506 22:33:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170506 22:36:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170506 22:47:43-!- stikonas_ is now known as stikonas
20170506 22:48:33-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170506 22:52:59-!- gfgtdf [~chatzilla@x4e36a95e.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 53.0.2/20170504105526]]
20170506 22:56:03-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170506 22:56:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170506 22:58:30-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170506 22:59:27-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20170506 23:09:15-!- Appleman1234 [~Appleman1@pl7533.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170506 23:11:20-!- sevu [~Unknown@p548545AE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170506 23:15:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170506 23:20:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170506 23:21:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170506 23:22:05-!- sevu [~Unknown@p548545AE.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
--- Log closed Sun May 07 00:00:52 2017