--- Log opened Sun May 07 00:00:52 2017
20170507 00:03:05-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 240 seconds]
20170507 00:34:17< vultraz_iOS> celticminstrel: did your lua require fix work?
20170507 00:34:27< celticminstrel> vultraz_iOS: No.
20170507 00:35:08< celticminstrel> The weird thing is that it works everywhere, except in the plugin.
20170507 00:36:06< vultraz_iOS> is there something different about the plugin codepath?
20170507 00:36:28< celticminstrel> Hmm, there actually is one thing different... the current directory is not in the gamedata or userdata dirs...
20170507 00:37:52< vultraz_iOS> well there you go
20170507 00:38:07< celticminstrel> Checking now in the debugger to see if that could make a difference.
20170507 00:40:34< celticminstrel> Okay, so the plugin actually isn't treated as a file.
20170507 00:40:42< celticminstrel> So that can't be the problem.
20170507 00:41:36< irker411> wesnoth: loonycyborg wesnoth:master 691db62ecf3a / scons/cairo.py: scons: Add support for pkg-config files in custom path to cairo check https://github.com/wesnoth/wesnoth/commit/691db62ecf3a7e262e1238df849657e646d26585
20170507 00:42:10< loonycyborg> gfgtdf: this should fix it
20170507 00:47:34< celticminstrel> To clarify: the game doesn't inform the Lua interpreter that the plugin code was loaded from a file, so when searching the stack for a file, it's not considered to be one.
20170507 00:52:27< vultraz_iOS> is that a problem?
20170507 00:52:49< celticminstrel> Shouldn't be.
20170507 00:53:17< celticminstrel> It also means the "current dir" ends up empty, which is equivalent to the gamedata dir.
20170507 00:53:23< celticminstrel> (Specifically the "data" dir.)
20170507 00:54:02< celticminstrel> This is already the case when loading ilua.lua and core.lua, and even package.lua.
20170507 00:56:07-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170507 00:56:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 01:01:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 246 seconds]
20170507 01:04:54-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 01:09:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 01:10:31-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 01:14:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 260 seconds]
20170507 01:15:10< celticminstrel> So there's no problem loading helper.lua. The parser completes without any errors. It's when evaluating the resulting function that something mysteriously goes wrong.
20170507 01:16:04< celticminstrel> I noticed that the function seemed to have "isvararg" set to 2, but I dunno if that's unexpected...
20170507 01:24:20< celticminstrel> Okay, this is interesting. When I attempt to access an attribute of the "empty package", I get the same error that the plugin dumps to the console - instead of the error I'm supposed to get.
20170507 01:25:45< celticminstrel> However, this only happens if a plugin was actually loaded. If I launch without loading a plugin, I get the correct error.
20170507 01:25:57< celticminstrel> So it seems like there's something different that happens when a plugin is loaded.
20170507 01:31:43< celticminstrel> Each plugin has its own thread. I'm guessing the Lua console invoked from the title screen runs in thread 0.
20170507 01:32:04< celticminstrel> I'm not sure if this could be the problem. Threads do share global environment.
20170507 01:32:18< celticminstrel> But it's certainly something that differs from anything else done in the game.
20170507 01:37:04< vultraz_iOS> whatever is, it's a blocker
20170507 01:37:07< vultraz_iOS> you have 1 week to fix it
20170507 01:42:56< vultraz_iOS> also, you should get on discord.
20170507 01:43:04< celticminstrel> No.
20170507 01:43:06< vultraz_iOS> also goes for Ivanovic 
20170507 01:43:29< vultraz_iOS> celticminstrel: you do realize you're basically the #1 person anchoring us to IRC :|
20170507 01:43:40< celticminstrel> No.
20170507 01:44:11< celticminstrel> If you want to move to discord, by all means do so, and I'll stick to GitHub and the forums for communication.
20170507 01:45:35< vultraz_iOS> Impossible. You are one of the core developers right now. If you remain on IRC we must all maintain an IRC presence.
20170507 01:45:47 * celticminstrel shrugs.
20170507 01:46:07< celticminstrel> I really don't think it's impossible to communicate solely through GitHub and forums, but IRC certainly is more convenient.
20170507 01:47:08< vultraz_iOS> discord would be even more convenient 
20170507 01:47:22< celticminstrel> I don't believe that.
20170507 01:47:45< vultraz_iOS> no need to maintain 24/7 irc instance
20170507 01:47:58< vultraz_iOS> missed mentions can appear as email notif.
20170507 01:48:01< celticminstrel> There's no need for that anyway.
20170507 01:48:04< vultraz_iOS> no need for dedicated log reading
20170507 01:48:15< celticminstrel> I honestly don't care that much about missed notifications or log reading.
20170507 01:53:10-!- Appleman1234 [~Appleman1@pl7533.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170507 02:00:47-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 02:12:10-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 02:12:48-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 02:16:51-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 240 seconds]
20170507 02:20:21-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170507 02:42:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170507 03:01:19-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170507 03:24:51-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds]
20170507 03:39:25< vultraz_iOS> celticminstrel: if you have 2 ints (or enums), it allows to do static constexpr bool equals() { return a == b; } ?
20170507 03:40:25< vultraz_iOS> allowed
20170507 03:40:42< celticminstrel> Well, we can't really use constexpr because MSVC 2013, but yes, constexpr does allow that.
20170507 03:41:08< celticminstrel> Though, I guess that specific example would be totally pointless since it's always true or always false.
20170507 03:41:26< celticminstrel> (If the two ints are non-const, then no, you can't declare the function constexpr.)
20170507 03:41:41< celticminstrel> (A constexpr function cannot access any global variables IIRC.)
20170507 03:42:08-!- irker411 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170507 03:44:19< vultraz_iOS> could it be done if one of the values was a template parameter compared against a value?
20170507 03:45:16< vultraz_iOS> ie template<int n>static constexpr bool equals(const int val) { return n == 1; } equals<1>();
20170507 03:45:49< celticminstrel> Template non-type parameters are constants, so yes, but if you're passing a template non-type parameter that kinda defeats the point of making it constexpr in the first place.
20170507 03:45:53-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 03:46:16< celticminstrel> (The point being that you can call it both with constexpr arguments and dynamically with arguments that can't be resolved at compile-time.)
20170507 03:49:12< vultraz_iOS> can you expand a variadic template with each argument as a call to a single function
20170507 03:49:32< celticminstrel> What?
20170507 03:50:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 255 seconds]
20170507 03:53:55< vultraz_iOS> say ou have a variadic template
20170507 03:54:05< vultraz_iOS> and i want to run the above equals function on each one
20170507 03:56:11< celticminstrel> If your function is "static bool equals(int val) {return val == 1;}", then in your variadic template you'd write something like "bool results[] = {equals(arg)...}; if(std::any_of(std::begin(results), std::end(results), functor)) ..." (Or all_of or none_of or whatever you need.
20170507 03:56:28< celticminstrel> In C++17 it'd be even easier, you could use the fold notation.
20170507 03:56:45< vultraz_iOS> what is this fold notation I keep hearing of
20170507 03:58:14< celticminstrel> Something like "if(args || .. || args)" giving the exact same effect as what I wrote above.
20170507 03:58:19< celticminstrel> ^ ...
20170507 03:58:34< celticminstrel> Of course you can use any operator in place of ||
20170507 03:58:49< celticminstrel> But IIUC the two operators and two endpoints need to be the same.
20170507 03:59:21< vultraz_iOS> i see
20170507 03:59:23< vultraz_iOS> thanks
20170507 03:59:37< celticminstrel> But you can't use it in master obviously.
20170507 04:00:24< vultraz_iOS> no
20170507 04:00:26< celticminstrel> There's also unary folds with a slightly different syntax. I'm not sure what exactly the difference is.
20170507 04:00:29< vultraz_iOS> but the other code
20170507 04:00:41< aeth> FP is not a good fit for games atm. Games are necessarily always trailing every trend because of performance requirements.
20170507 04:00:47< celticminstrel> They're called unary folds but they still work with binary operators.
20170507 04:00:52< celticminstrel> aeth: Huh?
20170507 04:01:01< celticminstrel> FP?
20170507 04:01:08< aeth> functional programming
20170507 04:01:43< celticminstrel> Well, this isn't technically functional programming. It's evaluated during template instantiation.
20170507 04:01:50< aeth> ah
20170507 04:01:51< celticminstrel> Functional metaprogramming maybe.
20170507 04:02:12< celticminstrel> https://isocpp.org/files/papers/n4295.html
20170507 04:02:38< vultraz_iOS> aeth: Anura is functional 
20170507 04:02:59< celticminstrel> I wonder if WFL has fold... since it doesn't have first-class functions, maybe not?
20170507 04:03:04< aeth> vultraz_iOS: 2D?
20170507 04:03:20< vultraz_iOS> 2D specialized for pixel art games
20170507 04:03:29< aeth> I guess 2D can technically cheat here because it doesn't need to perform well.
20170507 04:03:32< celticminstrel> It has filter, map, reduce, and zip, but no fold, AFAICT.
20170507 04:03:57< celticminstrel> Unless fold is the same as one of those. I forget.
20170507 04:04:02< aeth> But FP tends to lead to unnecessary allocations ime.
20170507 04:04:16< aeth> At least in the game loop.
20170507 04:04:28< celticminstrel> Ah, fold is reduce. Right, that should've been obvious with a little thought.
20170507 04:07:19< celticminstrel> vultraz_iOS: https://github.com/wesnoth/wesnoth/issues/1015#issuecomment-299660128
20170507 04:08:25-!- Appleman1234 [~Appleman1@pl49630.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170507 04:09:31< vultraz_iOS> I see you are accusing me of totally missing the point
20170507 04:10:00< celticminstrel> Well yes, but that's not the link.
20170507 04:11:58< celticminstrel> I know you think discord is the best thing ever, but this is an open-source project. There will inevitably be people who hate discord just on principle, and een though you may disagree with them, it's not good PR to just shut them out.
20170507 04:12:16< celticminstrel> You're suppose to be the community manager, so you should think about these things more.
20170507 04:12:20< celticminstrel> ^supposed
20170507 04:12:56< vultraz_iOS> The people who would most vehemently oppose on principle are those like e s r and I do not intend deal with that.
20170507 04:13:14< celticminstrel> (Just FTR, I am not one of those who hate it on principle. I just see zero benefit from using it.)
20170507 04:13:48< celticminstrel> So you intend to turn down people eager to contribute because they have principles that do not align with yours?
20170507 04:14:05< vultraz_iOS> No.
20170507 04:14:20< vultraz_iOS> But I'm not going to reject Discord because of an extremist's views.
20170507 04:14:29< celticminstrel> Then, stop trying to switch entirely to discord and shut down the mailing lists.
20170507 04:14:42< celticminstrel> I'm not telling you to reject discord.
20170507 04:14:53< vultraz_iOS> Wesnoth commits is useless 
20170507 04:14:56< vultraz_iOS> no one uses -dev
20170507 04:15:14< celticminstrel> Wesnoth commits is not useless if you don't have GitHub account.
20170507 04:15:17< vultraz_iOS> I already see *active language channels* on the discord server
20170507 04:15:33< vultraz_iOS> most specifically the japanese channel is very active
20170507 04:16:00< celticminstrel> Good for the Japanese?
20170507 04:16:12< celticminstrel> I don't really care how active they are.
20170507 04:16:37< vultraz_iOS> here's another reason discord is better:
20170507 04:16:40< vultraz_iOS> "And, I think most important of all, Discord is more approachable to new players. If they discover a game and see we have a Discord, they'll be likely to join, and seeing the admins and people in charge clearly listed gives the project a sense of open management. As opposed to finding out they need to go on IRC ("what is this I R C they speak of") and being
20170507 04:16:40< vultraz_iOS> confronted with a baffling list of random people and not knowing how any of them fit into the org.
20170507 04:16:40< vultraz_iOS> And here's another extremely important reason I think we should be using Discord primarily - all the server channels are listed!
20170507 04:16:40< vultraz_iOS> That is, depending on your access rights
20170507 04:16:40< vultraz_iOS> So a new player comes and they can immediately see there are already three dedicated language channels
20170507 04:16:41< vultraz_iOS> Whereas on IRC they would have absolutely no way to know that"
20170507 04:17:42< celticminstrel> Well, IRC lists all the channels too. The only reason it's not useful is because we're on Freenode rather than a custom-hosted server.
20170507 04:18:10< celticminstrel> (Not that I'm saying we should be on a custom-hosted server. That probably wouldn't be worthwhile either.)
20170507 04:18:54< celticminstrel> That aside, it's fairly trivial to just list the channels on a website instead.
20170507 04:19:05< celticminstrel> And you get pretty much the exact same benefit from that.
20170507 04:19:10< vultraz_iOS> you're thinking like a linux user
20170507 04:19:54< celticminstrel> As for your complaint about being confronted with a "baffling list of random people", well, uh... that's just because this channel is set (like many on Freenode) to hide ops.
20170507 04:20:17< vultraz_iOS> ops != roles
20170507 04:20:26< celticminstrel> Not really true?
20170507 04:20:42< celticminstrel> It may not give exact roles, but it certainly at least gives some sense of who's important.
20170507 04:20:53< vultraz_iOS> granted
20170507 04:20:57< vultraz_iOS> but it's only general
20170507 04:21:16< celticminstrel> And it's not like it's a binary thing; you have voice, half-op, op, and super-op, so there's four different levels you could give people.
20170507 04:21:56< celticminstrel> Sure it's only general, but if ops were marked, that'd be a far cry from being "confronted with a baffling list of random people".
20170507 04:22:06< vultraz_iOS> but here's the thing - those mean nothing to a new user
20170507 04:22:12< celticminstrel> I don't know what the reasoning is for not marking ops. Maybe someone had a very good reason I don't know about.
20170507 04:22:37< vultraz_iOS> the reason is the ops didn't want to be talked to
20170507 04:23:03< celticminstrel> Of course, that's actually a point against Discord for some people. :P
20170507 04:23:53< celticminstrel> Ops could of course temporarily remove their status if they want to go "incognito" on IRC, though that might be a little inconvenient if you need to do it every time you log in.
20170507 04:29:06< aeth> Fuck Discord.
20170507 04:29:12< aeth> I'm running IRC on a Raspberry Pi.
20170507 04:29:21< aeth> Good luck doing that with a bloated Electron proprietary app written in JS.
20170507 04:29:30< vultraz_iOS> oh shut up
20170507 04:29:42< aeth> A gen 1 raspberry pi.
20170507 04:29:52< vultraz_iOS> HIPSTER INTENSIFIES 
20170507 04:30:17< aeth> Because CPU performance all of a sudden doesn't matter?
20170507 04:30:34< vultraz_iOS> uh....
20170507 04:30:44< aeth> This is a gamedev channel. Game developers of all people should care about performance.
20170507 04:31:09< vultraz_iOS> A Pi has nothing.
20170507 04:31:11< aeth> IRC clients are, for the most part, high-performance.
20170507 04:31:29< celticminstrel> Anyway, back to the point... please do respond to the linked comment.
20170507 04:31:49< vultraz_iOS> I guess we'll need a dummy account if Git Reports needs it
20170507 04:32:12< vultraz_iOS> wesnoth-bugs
20170507 04:32:25< celticminstrel> Pretty sure Git Reports doesn't need a dummy account, just an account.
20170507 04:32:37< aeth> And if you're saying that a Pi has no performance, that's exactly the point. High performance software runs on very low end computers.
20170507 04:32:42< celticminstrel> But of course, if it's not a dummy account, it needs to be a person's account.
20170507 04:32:57< celticminstrel> So you'd need someone willing to use their account for that. I don't really want to be the one to do that TBH.
20170507 04:33:07< vultraz_iOS> In which case I'd rather we had a dedicated account
20170507 04:33:18< celticminstrel> So wesnoth-bugs?
20170507 04:33:22< celticminstrel> I suppose that works.
20170507 04:33:22< vultraz_iOS> yes
20170507 04:33:40< celticminstrel> You want to create it or shall I?
20170507 04:33:40< vultraz_iOS> aeth: and why would you want that
20170507 04:33:53< vultraz_iOS> if you want to handle it sure
20170507 04:37:32< celticminstrel> Hmm, I wonder if there's some sort of official Wesnoth email I could use...
20170507 04:37:43< vultraz_iOS> uhhhhh
20170507 04:38:36< vultraz_iOS> i don't think so
20170507 04:38:43< vultraz_iOS> i had to use my own email for the steam account
20170507 04:40:34< vultraz_iOS> hmm
20170507 04:41:05< celticminstrel> Hmm?
20170507 04:41:14< vultraz_iOS> I guess std::any_of can't be used in a constexpr statement
20170507 04:41:45< celticminstrel> Why are you even using constexpr here?
20170507 04:42:36< vultraz_iOS> I'm pondering (as a learning exercise, really) the implementation of has_key and find in the GUI2 dispatcher
20170507 04:42:40< celticminstrel> As suspected, I can't use my email.
20170507 04:42:58-!- Appleman1234 [~Appleman1@pl49630.ag1212.nttpc.ne.jp] has quit [Ping timeout: 264 seconds]
20170507 04:43:38< vultraz_iOS> for has_key, I have been pondering a simple compile-time method of checking if a specified enum value is in a static set
20170507 04:43:44< vultraz_iOS> one would think it would be easy
20170507 04:43:47< vultraz_iOS> but not really
20170507 04:43:55< vultraz_iOS> especially without related constexpr
20170507 04:44:05< vultraz_iOS> relaxed
20170507 04:44:06< celticminstrel> If you're talking about std::set, it's impossible.
20170507 04:44:18< vultraz_iOS> well, it doesn't need to be a set
20170507 04:44:24< vultraz_iOS> it's just saved as a set in boost::mpl
20170507 04:44:41< celticminstrel> So anyway, what should I do for an email?
20170507 04:44:56< vultraz_iOS> talk to Soliton 
20170507 04:45:04< vultraz_iOS> maybe he can make one
20170507 04:45:10< celticminstrel> Got it.
20170507 04:45:12< vultraz_iOS> on the server
20170507 04:45:43< celticminstrel> I assume Soliton would also be the one to talk to if we wanted to move the mailing lists to our servers.
20170507 04:45:51< vultraz_iOS> probably
20170507 04:46:02< vultraz_iOS> anyway, back to pondering this..
20170507 04:46:44< vultraz_iOS> in c++17 one could easily use constexpr for
20170507 04:47:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 04:47:08< celticminstrel> I'm not sure about that.
20170507 04:47:08< vultraz_iOS> but here I can't
20170507 04:47:16< celticminstrel> Maybe you could, maybe not.
20170507 04:47:25< vultraz_iOS> so, I was thinking one could construct an array of matching results
20170507 04:49:54< vultraz_iOS> easy with a constexpr function and a variadic expansion
20170507 04:49:54< celticminstrel> I seriously doubt whether this thing you're doing is worth the effort.
20170507 04:49:54< vultraz_iOS> as I said, it's mostly a learning exercise 
20170507 04:49:54< celticminstrel> Checking if a value is in a set is O(logn) or something like that.
20170507 04:49:54< celticminstrel> (It can be worse for unordered_set, but on average is better.)
20170507 04:49:54< vultraz_iOS> as I said, doesn't need to be a set
20170507 04:49:54< vultraz_iOS> it's just implemented as a check on a set of types in mpl
20170507 04:49:55< vultraz_iOS> but ok, we can get as far as a compile-time array
20170507 04:49:57< vultraz_iOS> I think
20170507 04:50:18< vultraz_iOS> or perhaps that's not possible
20170507 04:50:26< vultraz_iOS> i dunno
20170507 04:50:56< vultraz_iOS> but unless std::any_of can be run in a constexpr context then I can't proceed any further
20170507 04:50:59< vultraz_iOS> for has_key
20170507 04:51:01< vultraz_iOS> now, for find...
20170507 04:51:24< vultraz_iOS> well, find is a runtime operation but features some compile-time optimizations 
20170507 04:51:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 260 seconds]
20170507 05:02:21< vultraz_iOS> well, technically i could make some implementation fixes to the find implementation as long as i have constexpr..
20170507 05:02:59< vultraz_iOS> I have no idea what this line does
20170507 05:03:00< vultraz_iOS> return functor.template oper<item>(event);
20170507 05:03:12< vultraz_iOS> specifically...
20170507 05:03:14< vultraz_iOS> .template
20170507 05:05:49-!- JyrkiVesterinen [~JyrkiVest@87.100.173.104] has joined #wesnoth-dev
20170507 05:11:22-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 05:13:31-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20170507 05:15:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Ping timeout: 246 seconds]
20170507 05:18:01< celticminstrel> vultraz_iOS: Disambiguation.
20170507 05:18:16< celticminstrel> Presumably "functor" is one of the template arguments.
20170507 05:18:25< vultraz_iOS> Yes
20170507 05:18:36< celticminstrel> So the compiler cannot tell whether "oper" is a template or a member variable/function.
20170507 05:18:48< celticminstrel> Thus, by default it assumes the latter.
20170507 05:19:19< celticminstrel> IOW, if you write "functor.oper<item>(event)" it would parse it as '(functor.oper) < (item) > (event)"
20170507 05:19:27< celticminstrel> (Those are less than and greater than.)
20170507 05:19:48< celticminstrel> By adding the template keyword, you tell it the next identifier is a template, allowing it to parse it correctly.
20170507 05:22:02< vultraz_iOS> I see
20170507 05:22:07< vultraz_iOS> good to know
20170507 05:22:21< celticminstrel> It's only needed when it depends on a template parameter.
20170507 05:22:30< celticminstrel> So if functor was a global typedef, you wouldn't need it.
20170507 05:22:43< celticminstrel> It can be needed after :: or -> as well.
20170507 05:23:38< celticminstrel> [May 07@01:18:16am] celticminstrel: Presumably "functor" is one of the template arguments.
20170507 05:23:39< celticminstrel> (Or its type is one of the template arguments, ie it's declared "T functor".)
20170507 05:27:07< vultraz_iOS> ok, let's see here
20170507 05:27:15< vultraz_iOS> the compile time optimization simply seems to be...
20170507 05:27:33< vultraz_iOS> whether "itor == end"
20170507 05:27:35< vultraz_iOS> ok..?
20170507 05:27:38< celticminstrel> ?
20170507 05:29:41< vultraz_iOS> ok so what boost appears to be doing is treating the event values as integral constants
20170507 05:29:45< vultraz_iOS> of... int
20170507 05:31:29< vultraz_iOS> and uses some weird compile time iterator interface
20170507 05:32:18< vultraz_iOS> ah, I see
20170507 05:32:23< vultraz_iOS> it's not an optimization
20170507 05:32:27< vultraz_iOS> it's an implementation detail
20170507 05:34:51< JyrkiVesterinen> aeth: I think it's a wrong policy to ban functional programming in game projects because of performance reasons.
20170507 05:35:04< JyrkiVesterinen> In any game project, 90 % of code isn't performance-critical.
20170507 05:35:22< JyrkiVesterinen> There isn't any reason why functional programming should be disallowed there.
20170507 05:35:41< JyrkiVesterinen> Only in performance-critical code the programmers should try to optimize.
20170507 05:36:28< JyrkiVesterinen> (Such as the case that I found a couple days ago where a ~30 kB string was copied twice and a link detection function was called over 3500 times.)
20170507 05:36:56< vultraz_iOS> o-O
20170507 05:37:02< vultraz_iOS> jesus christ 
20170507 05:37:27< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/pull/1028/commits/b301da8d43b93ec00eadec5767fa2e16492dfb7e fixes that.
20170507 05:47:16-!- irker140 [~irker@109.237.213.40] has joined #wesnoth-dev
20170507 05:47:16< irker140> wesnoth: Jyrki Vesterinen wesnoth:large-gui-canvas f2d4bcb7f005 / src/font/ (text.cpp text.hpp): Specify the types of unique_ptr deleters with std::function https://github.com/wesnoth/wesnoth/commit/f2d4bcb7f0056d6215c3530eb31a00f6da888557
20170507 05:47:34-!- Aginor [~andreas@unaffiliated/aginor] has left #wesnoth-dev ["so long"]
20170507 05:47:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170507 05:49:04< celticminstrel> JyrkiVesterinen: I don't suppose you have any idea what I could look for regarding the MP tests issue? I can't think of any reason why it doesn't work, but there are some things going on in the plugin that are different from anywhere else in the game, such as the use of coroutines.
20170507 05:49:28< JyrkiVesterinen> Indeed, I don't really have any clue there. :(
20170507 05:52:29< irker140> wesnoth: Celtic Minstrel wesnoth:master 5d3fec98c5fd / src/scripting/lua_kernel_base.cpp: Some small wesnoth.dofile fixes https://github.com/wesnoth/wesnoth/commit/5d3fec98c5fde51b30c04cc9957886eb985f2b2c
20170507 05:52:44< celticminstrel> (Again, that still doesn't fix the issue ^ )
20170507 05:55:28-!- Appleman1234 [~Appleman1@pl16179.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170507 05:58:19< celticminstrel> Section B.2 is relevant for the issues thing. https://help.github.com/articles/github-terms-of-service/#b-account-terms
20170507 05:58:41< celticminstrel> I dunno, do organizations (eg "wesnoth") count as accounts?
20170507 05:59:26 * celticminstrel has assumed they don't.
20170507 06:21:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170507 06:21:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170507 06:46:07-!- Kwandulin [~Kwandulin@p200300760F6D801B055C4A8B6D11E63D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170507 08:04:19-!- Kwandulin [~Kwandulin@p200300760F6D801B055C4A8B6D11E63D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170507 08:05:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170507 08:20:18-!- Appleman1234 [~Appleman1@pl16179.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170507 08:52:32-!- irker140 [~irker@109.237.213.40] has quit [Quit: transmission timeout]
20170507 08:59:25-!- Kwandulin [~Kwandulin@p200300760F6D801BA9E71FB5FA480E9D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170507 09:32:35-!- Appleman1234 [~Appleman1@pl34624.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170507 10:17:35-!- JyrkiVesterinen [~JyrkiVest@87.100.173.104] has quit [Quit: .]
20170507 10:24:57-!- irker102 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170507 10:24:57< irker102> wesnoth: Charles Dang wesnoth:master a3448e990890 / src/sound.cpp: Don't play music config if music is disabled https://github.com/wesnoth/wesnoth/commit/a3448e9908902f247eecb020202c2d9d9f94ed72
20170507 10:29:55< zookeeper> doesn't that mean that toggling music on/off does more than just... disable the music output?
20170507 10:31:00< vultraz_iOS> well, if you think it just mutes the audio channel, no
20170507 10:31:03< vultraz_iOS> it doesn't just do that
20170507 10:31:12< vultraz_iOS> it's used as an early return flag in some other functions too
20170507 10:31:21< zookeeper> ...that's what i said
20170507 10:32:27< zookeeper> if you have a scenario which sets up playlist stuff in the beginning, and you enter that scenario with music off, and then turn it back on, what gets played?
20170507 10:32:45< zookeeper> i don't know the music code, i'm just trying to figure out if you know what you're doing or not.
20170507 10:32:56< vultraz_iOS> hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm
20170507 10:32:59< vultraz_iOS> good point...
20170507 10:33:30< vultraz_iOS> that *could* be an issue.
20170507 10:33:49< vultraz_iOS> let me see first if it fixes the memleak..
20170507 10:34:35< zookeeper> pretty much everything regarding [music] tags and playlists etc should be unaffected by whether music is on or off
20170507 10:35:30< vultraz_iOS> indeed, what you describe is an issue
20170507 10:35:32< zookeeper> the only thing it should affect is whether the current track is actually playing at all
20170507 10:35:57< vultraz_iOS> that is, the wrong music plays.
20170507 10:37:21< zookeeper> ideally, having music toggled off should be identical to a pause button being held down
20170507 10:40:23< vultraz_iOS> well that did not fix the crash
20170507 10:40:26< vultraz_iOS> er
20170507 10:40:28< vultraz_iOS> leak
20170507 10:40:29< vultraz_iOS> not crash
20170507 10:40:30< vultraz_iOS> sorry
20170507 10:42:45< irker102> wesnoth: Charles Dang wesnoth:master 7e67b7bba030 / src/sound.cpp: Revert "Don't play music config if music is disabled" https://github.com/wesnoth/wesnoth/commit/7e67b7bba03066836ab1cac4a2adc9a68c893616
20170507 10:46:34-!- horus2 [~1@91.82.241.203.pool.invitel.hu] has joined #wesnoth-dev
20170507 11:33:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 12:00:09-!- JyrkiVesterinen [~JyrkiVest@87-100-173-104.bb.dnainternet.fi] has joined #wesnoth-dev
20170507 12:11:24-!- gfgtdf [~chatzilla@x4e36880b.dyn.telefonica.de] has joined #wesnoth-dev
20170507 12:11:50< gfgtdf> celticminstrel: does 5d3fec98c5fde51b30c04cc9957886eb985f2b2c fix teh travis isue ?
20170507 12:11:52< gfgtdf> the*
20170507 12:13:36< JyrkiVesterinen> No.
20170507 12:13:36< JyrkiVesterinen> 20170507 05:52:44< celticminstrel> (Again, that still doesn't fix the issue ^ )
20170507 12:15:09-!- Appleman1234 [~Appleman1@pl34624.ag1212.nttpc.ne.jp] has quit [Read error: Connection reset by peer]
20170507 12:15:24< gfgtdf> loonycyborg: thx for fixing that
20170507 12:24:04-!- Kwandulin [~Kwandulin@p200300760F6D801BA9E71FB5FA480E9D.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20170507 12:28:52-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170507 12:33:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170507 12:34:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 12:37:07< zookeeper> matthiaskrgr, at least in waterloo sunset and merkwuerdigliebe there are "players 145 vs. 236" -style team descriptions left, did you intentionally omit changing those?
20170507 12:38:43< zookeeper> (manzivan traps too)
20170507 12:39:12-!- chiec [~chiec@clients-xsf-98.upc.es] has joined #wesnoth-dev
20170507 12:41:42< matthiaskrgr> yes 
20170507 12:45:33< zookeeper> well, okay, but wouldn't those warrant the same 1+4+5 style as you applied to some other maps?
20170507 12:54:46< gfgtdf> celticminstrel: unrelated to the problem i noiticed that here <https://github.com/wesnoth/wesnoth/commit/787a46820ee71e5538cbcd1b431c6560e4d94b47#diff-134e6f055615e6d49064a684872c530cR1400 you alos changed a dofile call.
20170507 12:58:56-!- Kwandulin [~Kwandulin@p200300760F6D8083A9E71FB5FA480E9D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170507 13:03:24< gfgtdf> hmm we could work around this issue by changing that require call to a  << load(wesnoth.read_file("lua/helper.lua"))() >> this doenst really fix the issue though
20170507 13:10:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170507 13:10:37< gfgtdf> i actuall wonder why our dofile implementation beves differently form that in the first place. If it wasn't for the better debug informtion  when printing stacktraces i think we coudl just implement dofile similar to that.
20170507 13:10:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170507 13:10:47< gfgtdf> (in lua i meant)
20170507 13:17:01-!- Appleman1234 [~Appleman1@pl52488.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170507 13:21:33-!- horus21 [~1@91.83.36.24.pool.invitel.hu] has joined #wesnoth-dev
20170507 13:23:48-!- horus2 [~1@91.82.241.203.pool.invitel.hu] has quit [Ping timeout: 240 seconds]
20170507 13:27:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170507 13:28:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 13:35:06< gfgtdf> im trying to figure out teh reason for https://github.com/wesnoth/wesnoth/commit/1bd5cfb7568e98b79925099ce9945ab2d0ba70d2
20170507 13:35:37< gfgtdf> accoring t th eocmmit message it something i could know, but i reeally don't remember and the irlog alos won'T tell me
20170507 13:37:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20170507 13:43:07-!- irker102 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170507 13:48:24< JyrkiVesterinen> gfgtdf: The difference between lua_call() and protected_call() is that lua_call() can longjmp out of the call (if an exception occurs).
20170507 13:48:38< JyrkiVesterinen> Which is something that you definitely don't want in a C++ codebase.
20170507 13:54:29< gfgtdf> JyrkiVesterinen: we compile lua as c++ code
20170507 13:55:28< JyrkiVesterinen> Well, even in that case exceptions are sometimes easier to handle with protected_call(). Depends on which programming model you want to follow.
20170507 13:55:58< JyrkiVesterinen> (I tend to use return codes even in C++ or C# code when the failure condition is common.)
20170507 14:00:39< gfgtdf> JyrkiVesterinen: well' its not really common here, however note that the commitmessage said 'to pervent lua panic' so the question is why (under which conditions) could it cause lua panic back then.
20170507 14:01:42< gfgtdf> JyrkiVesterinen: usually lua pani is issues when the initial lua call isn't done via a protected call. but dofile is just not the initial function to invoke lua code form c++ code
20170507 14:01:51< gfgtdf> is issued*
20170507 14:03:25< JyrkiVesterinen> Okay, I see. Quoting the Lua Reference Manual:
20170507 14:03:27< JyrkiVesterinen> "If an error happens outside any protected environment, Lua calls a panic function (see lua_atpanic) and then calls abort, thus exiting the host application. Your panic function can avoid this exit by never returning (e.g., doing a long jump to your own recovery point outside Lua)."
20170507 14:04:22< JyrkiVesterinen> AFAIK, lua_call() isn't a protected environment. Thus, with raw lua_call() a Lua exception actually doesn't throw an exception, but terminates the entire game.
20170507 14:06:16-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 14:06:45< gfgtdf> JyrkiVesterinen: hmm no the point is that in this case the funciton thta does call dofile shoudl already be run ina protected environment.
20170507 14:07:13< JyrkiVesterinen> Hmm. In that case a raw lua_call() should indeed be okay.
20170507 14:12:12-!- horus21 [~1@91.83.36.24.pool.invitel.hu] has left #wesnoth-dev []
20170507 14:20:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170507 14:20:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 14:37:27-!- sevu [~Unknown@141.39.226.226] has quit [Disconnected by services]
20170507 14:37:27-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 14:42:07< celticminstrel> [May 07@09:10:37am] gfgtdf: i actuall wonder why our dofile implementation beves differently form that in the first place. If it wasn't for the better debug informtion  when printing stacktraces i think we coudl just implement dofile similar to that.
20170507 14:42:08< celticminstrel> Looks like the Lua load() function also accepts chunkname, so we really could implement dofile in Lua.
20170507 14:53:51< celticminstrel> I don't really understand why, but making that call unprotected fixes the issue.
20170507 14:57:55< celticminstrel> Wesnoth never sets "require = nil" (only "dofile = nil" and "loadfile = nil"), so how is it possible that the built-in require function does not exist?
20170507 15:02:17-!- irker464 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170507 15:02:17< irker464> wesnoth: Celtic Minstrel wesnoth:master e9674ec8a77c / data/scenario-test.cfg: Fix test scenario https://github.com/wesnoth/wesnoth/commit/e9674ec8a77c24f86d4dcd00e087dddd2ba944fb
20170507 15:02:17< irker464> wesnoth: Celtic Minstrel wesnoth:master b5a0ef7e4d5b / host.lua src/scripting/lua_kernel_base.cpp: Fix the MP tests https://github.com/wesnoth/wesnoth/commit/b5a0ef7e4d5bc8ec75b2942d689250eb3a5d40de
20170507 15:04:41-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170507 15:05:15< irker464> wesnoth: Celtic Minstrel wesnoth:rel_paths b7c32c3877df / src/ (4 files in 3 dirs): Accept ".." in file paths everywhere https://github.com/wesnoth/wesnoth/commit/b7c32c3877df5e4a0a6fdf1ff0dc22c57e42b558
20170507 15:05:17< irker464> wesnoth: Celtic Minstrel wesnoth:rel_paths ba42e2cf1403 / src/filesystem_boost.cpp: Safety net (suggested by @gfgtdf) https://github.com/wesnoth/wesnoth/commit/ba42e2cf14034438078b38e1539ebc8d3c70c779
20170507 15:08:36-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Ping timeout: 252 seconds]
20170507 15:10:36-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 260 seconds]
20170507 15:13:45-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 15:14:43-!- Alkenrinnstet_ [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170507 15:14:50-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170507 15:16:07< gfgtdf> celticminstrel: weit if lua suppoirts fgiving chunknames the new get_wml_locations implementation woudl be unsafe since lua can pass arbitaty things as secodn parameter if the the code does that dofile was loaded via load()
20170507 15:17:11< celticminstrel> ...what?
20170507 15:17:17-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has quit [Read error: Connection reset by peer]
20170507 15:17:27-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170507 15:19:13< gfgtdf> if lua suppoirts fgiving chunknames then the new get_wml_locations implementation woudl be unsafe since lua can pass arbitaty things as secodn paremater by loading the code that calls dofile via load()
20170507 15:19:24< celticminstrel> ...
20170507 15:19:36< celticminstrel> Repeating exactly what you said doesn't help.
20170507 15:19:45< gfgtdf> i didn't
20170507 15:20:14< celticminstrel> I see no significant changes.
20170507 15:21:03< celticminstrel> Are you talking about searching the stack for the most recent file?
20170507 15:22:41< celticminstrel> I don't think it would be unsafe. Though it's true that a load() call could insert an arbitrary element there and thus change the effective current directory for Lua scripts above it on the stack, that wouldn't allow escaping the filesystem sandbox because it considers that chunk name to be relative to the gamedata/userdata dirs.
20170507 15:37:48-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 260 seconds]
20170507 15:41:21-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170507 15:44:00-!- shiki [~Unknown@141.39.226.226] has quit [Read error: Connection reset by peer]
20170507 15:44:38-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 15:44:44-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Remote host closed the connection]
20170507 15:45:24-!- Shiki_ [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 15:48:25-!- Rhonda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20170507 15:49:10-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 16:01:38-!- Kwandulin [~Kwandulin@p200300760F6D8083A9E71FB5FA480E9D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170507 16:09:54-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170507 16:13:43< celticminstrel> TBH I don't expect the cave map PR to be ready for 1.13.8.
20170507 16:13:55< celticminstrel> Oh, he's not even here though.
20170507 16:14:32-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 260 seconds]
20170507 16:16:40-!- Shiki_ [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 16:19:31< Ravana_> first time I see https://vgy.me/zebUk3.png
20170507 16:22:03< Ravana_> it ended up deleting the addon version I had installed, instead of updating
20170507 16:24:00-!- Shiki_ [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 16:37:06< gfgtdf> celticminstrel: no with you changes it also allows absolute current-directory paths
20170507 16:37:42< celticminstrel> gfgtdf: Does it? Example?
20170507 16:38:10< gfgtdf> celticminstrel: well you pass the currnet direcrory directly to the second parmater of get_wml_location whihc accepts absolute paths
20170507 16:46:10< celticminstrel> No I don't.
20170507 16:49:19-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 16:54:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 16:56:05-!- Shiki_ [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 16:59:32< gfgtdf> celticminstrel: in the code you call exactly resolve_filename(p, get_calling_file(L) where resolve_filename is just an alias for get_wml_location
20170507 17:01:48< celticminstrel> Hmm.
20170507 17:02:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 17:02:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 17:03:14< celticminstrel> If you're talking about someone doing something like load("some code", "@/path/to/unsafe/file"), I think the call to get_short_wml_path would mean that it's resolved as if the current directory is empty.
20170507 17:03:39< celticminstrel> Oh, I'm wrong.
20170507 17:03:50< celticminstrel> get_short_wml_path returns its argument unchanged if it failed.
20170507 17:04:10-!- Kwandulin [~Kwandulin@p200300760F6D8083E939901127AC211B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170507 17:11:36< DeFender1031> Who is Alessandro Pira? (Or more to the point, is this Android port of the game official?)
20170507 17:13:48< gfgtdf> there are no really 'official' ports. There is one that is the most opdated though you can find a forum thread on this issue.
20170507 17:14:40-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 17:15:06< DeFender1031> I'll look, thanks.
20170507 17:21:29< celticminstrel> Where is the "turn refresh" event triggered?
20170507 17:24:33< gfgtdf> celticminstrel: dontknow but textsearch for turn refresh in the c++ code shoudl find it out
20170507 17:24:44< celticminstrel> For some reason that didn't work for me.
20170507 17:24:51< celticminstrel> git grep "turn refresh" src
20170507 17:24:53< gfgtdf> celticminstrel: did ou try with underscore ?
20170507 17:25:00< celticminstrel> Oh.
20170507 17:25:19< celticminstrel> Found it.
20170507 17:27:52-!- chiec [~chiec@clients-xsf-98.upc.es] has quit [Remote host closed the connection]
20170507 17:27:59-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20170507 17:40:30< vultraz_iOS> celticminstrel: is it possible that the current_track variable keeps a ptr from the list alive when playing a config or vice versa
20170507 17:41:52< celticminstrel> The current_track always contains the currently-playing track, whether or not that's on the list.
20170507 17:42:08< vultraz_iOS> but it could be on the list
20170507 17:42:28< vultraz_iOS> meaning a clear() call wouldnt fully clear the list
20170507 17:45:12< celticminstrel> No?
20170507 17:45:18< celticminstrel> The clear call would fully clear the list.
20170507 17:45:26< celticminstrel> But one of the tracks on the list would not be deallocated.
20170507 17:45:40< celticminstrel> Because it's still playing and thus still held by current_track.
20170507 17:45:49< celticminstrel> ie, that's not a leak.
20170507 17:47:28< celticminstrel> gfgtdf, vultraz_iOS: Do you think there'd be any use in a function on the Lua team that does standard income/upkeep work?
20170507 17:47:50< vultraz_iOS> then where the hell is this god damn leak
20170507 17:47:55< celticminstrel> I don't know.
20170507 17:48:10-!- sevu [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 17:48:27< gfgtdf> celticminstrel: you men moving the income/upkeep code calculation to lua so that lua can overwrite it ?
20170507 17:48:39< celticminstrel> gfgtdf: That's not quite what I was thinking...
20170507 17:48:54< celticminstrel> It was more about letting Lua invoke it at times other than turn start.
20170507 17:49:27< celticminstrel> I suppose allowing Lua to override it is another option...
20170507 17:50:07< gfgtdf> celticminstrel: i liek the oidea of moving it to lua so that wml developery can define their own income calculation function, the problme i see is that we cannot easily serialize functions in savefiles afaik
20170507 17:51:05< celticminstrel> Well, income calculation is a fairly simple thing, so we could allow it to be a WFL formula.
20170507 17:51:23-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 17:51:27< celticminstrel> Might be a little less flexible than defining it in Lua, but... no problem with serialization.
20170507 17:52:51< gfgtdf> hmm
20170507 17:57:07< celticminstrel> Is it just me or is the :unit command not working?
20170507 17:57:34 * celticminstrel did :unit health=5 and :unit status=poison
20170507 17:59:20< gfgtdf> iirc its hitpoints not health
20170507 18:00:08< celticminstrel> Ah right.
20170507 18:00:18< celticminstrel> So I was doing it wrong.
20170507 18:00:25< celticminstrel> Maybe it's status=poisoned?
20170507 18:00:49< celticminstrel> vultraz_iOS: Unit Create idea. Make changing the gender selection also update the unit image?
20170507 18:06:21< vultraz_iOS> fine, fine, I'll look into it
20170507 18:08:05-!- irker464 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170507 18:13:27-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20170507 18:14:40< zookeeper> vultraz_iOS, any progress on the blitting thing?
20170507 18:14:45< vultraz_iOS> none
20170507 18:18:57-!- louis94 [~~louis94@163.50-65-87.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 240 seconds]
20170507 18:22:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 18:22:12< Ravana_> at least 1.12 :unit only supports toplevel keys
20170507 18:22:23< Ravana_> but relevant variable name would be status[0].poisoned
20170507 18:22:56-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170507 18:22:56< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Celtic Minstrel b5a0ef7: Fix the MP tests Failed
20170507 18:22:56< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-329
20170507 18:23:01-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170507 18:23:40-!- sevu [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 18:26:05< Ravana_> been using https://pastebin.com/8dhasygH as mp-safe :unit
20170507 18:26:20-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170507 18:26:20< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Celtic Minstrel b5a0ef7: Fix the MP tests Failed
20170507 18:26:20< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-329
20170507 18:26:24-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170507 18:27:16< gfgtdf> Ravana_: in 1.13 :unit is mp-msafe
20170507 18:28:00< Ravana_> with 1.13.7 at least I could not use debug commands in multiplayer game
20170507 18:28:53< gfgtdf> Ravana_: did you start wesnoth in debug mode (-debug commandline switch) ?
20170507 18:29:00< Ravana_> no
20170507 18:29:13< gfgtdf> Ravana_: debug commands onyl work in debug mode
20170507 18:29:16< gfgtdf> only*
20170507 18:33:44< Ravana_> with 1.13 I need to use commandline switches anyways to be able to load userdata.. will having -debug always on break anything?
20170507 18:35:22< gfgtdf> Ravana_: well most imporatntly it might spoil you with information which makes in particular normal campaign gameplay less enjoyable.
20170507 18:35:58< gfgtdf> Ravana_: also ofc wml/lua code can query debug mode so i't possible to bahave differently in debug mode.
20170507 18:36:09< gfgtdf> Ravana_: if the wml author wants it
20170507 18:36:10< Ravana_> I haven't played any normal campaign since 2012
20170507 18:37:27< gfgtdf> Ravana_: well let me put it like this: if you onyl plaing wesnoth is to log inthe mp server to observe games than -debug won't hurt you.
20170507 18:37:57< gfgtdf> Ravana_: unless ofc there is badly coded wml running that explicitly checks for debug mode
20170507 18:39:47< gfgtdf> Ravana_: i personally used to use -debug when i was playing in 1.10.x but at some point stpped to do so, mostly becasue of reason #1 i mentioned above.
20170507 18:40:08< Ravana_> I see.. I think I can do everything I need without -debug then
20170507 18:41:05< gfgtdf> Ravana_: ye in 1.13 it is even easier since you can just inject an unsynced menu item.
20170507 18:49:24< celticminstrel> Ravana_: :unit has a few special cases, status is one of them. You can do status=list,of,status and it sets all of them to true.
20170507 18:50:04< celticminstrel> BTW it's --debug not -debug.
20170507 18:50:18< celticminstrel> And you can also enable it in-game with the :debug command.
20170507 18:50:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 18:55:44-!- irker905 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170507 18:55:44< irker905> wesnoth: Celtic Minstrel wesnoth:master 04670c313b3c / src/scripting/game_lua_kernel.cpp: Some additions to wesnoth.simulate_combat output https://github.com/wesnoth/wesnoth/commit/04670c313b3c9802b1578cd89ae2af5aadbc8ce4
20170507 18:55:44< irker905> wesnoth: Celtic Minstrel wesnoth:master 78815759547e / src/ (attack_prediction.cpp attack_prediction.hpp): Use std::array for passing summaries around in attack prediction https://github.com/wesnoth/wesnoth/commit/78815759547e4d7520693d03ad7119378d565dfc
20170507 18:55:45< irker905> wesnoth: Celtic Minstrel wesnoth:master 079b60acbd43 / src/units/filter.cpp: Add ability_type_active to SUF https://github.com/wesnoth/wesnoth/commit/079b60acbd434bb8aa88d7fc0e80daa9055a9006
20170507 19:01:03< irker905> wesnoth: Celtic Minstrel wesnoth:rel_paths c45c36c3087f / src/tests/test_filesystem.cpp: fixup tests https://github.com/wesnoth/wesnoth/commit/c45c36c3087f17eb0cf66e708fd64dc25da586a1
20170507 19:01:05< irker905> wesnoth: Celtic Minstrel wesnoth:rel_paths 09ddf0368f9c / src/filesystem_boost.cpp: Another safety check (thanks @gfgtdf for spotting this) https://github.com/wesnoth/wesnoth/commit/09ddf0368f9c56b02f2d7437f0577bf10e210650
20170507 19:01:50-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 19:06:38< celticminstrel> I wonder if there is any difference between ai.synced_command and wesnoth.synchronize_choice.
20170507 19:09:26-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 255 seconds]
20170507 19:14:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 19:19:38< irker905> wesnoth: Charles Dang wesnoth:master 23f4eab5db78 / src/sound.cpp: Reformat sound code https://github.com/wesnoth/wesnoth/commit/23f4eab5db78fa1328288c87944251b8368dfc2c
20170507 19:19:41< irker905> wesnoth: Charles Dang wesnoth:master 14e22779ab95 / src/sound.cpp: Removed need for forward declaration of play_sound_internal https://github.com/wesnoth/wesnoth/commit/14e22779ab95a92cf107186181e2ab90549fe6cd
20170507 19:19:44< irker905> wesnoth: Charles Dang wesnoth:master ac2913bd627a / src/sound.cpp: Made use of std::list_remove_if https://github.com/wesnoth/wesnoth/commit/ac2913bd627ac2d467d3ddd2e78958ae8429b4da
20170507 19:21:16< vultraz_iOS> hmm
20170507 19:21:32< vultraz_iOS> i just realized, matthiaskrgr reported the leak even when play_music_config was cordoned off, in play_music_repeatedly
20170507 19:21:48< celticminstrel> BTW, attack_I noticed attack_prediction.cpp has inconsistent indentation.
20170507 19:21:55< vultraz_iOS> that also touches the current_track_list
20170507 19:21:59< celticminstrel> Sometimes it's spaces, sometimes it's tabs, and sometimes it's even a mixture.
20170507 19:22:12< vultraz_iOS> the dialog
20170507 19:22:14< vultraz_iOS> or the file
20170507 19:22:16< celticminstrel> "cordoned off"?
20170507 19:22:19< celticminstrel> The file.
20170507 19:22:19< vultraz_iOS> implementation file
20170507 19:22:25< celticminstrel> Not the dialog.
20170507 19:22:34< celticminstrel> Nothing to do with the dialog.
20170507 19:22:40< vultraz_iOS> celticminstrel: https://github.com/wesnoth/wesnoth/commit/a3448e9908902f247eecb020202c2d9d9f94ed72
20170507 19:22:47< vultraz_iOS> i have since reverted that
20170507 19:22:55< celticminstrel> I'm talking about src/attack_prediction.cpp
20170507 19:22:58< vultraz_iOS> but he reported a leak via play_music_repeatedly
20170507 19:23:08< vultraz_iOS> even with that change
20170507 19:23:20< vultraz_iOS> so I'm saying that narrows the scope...
20170507 19:24:17< vultraz_iOS> celticminstrel: do you want me to format a_p.cpp
20170507 19:25:23< celticminstrel> Well, if nothing else, I think at least the spaces indentation should be fixed.
20170507 19:26:22< vultraz_iOS> wait, this is that standalone program
20170507 19:26:35< celticminstrel> ???
20170507 19:27:04< vultraz_iOS> attack_prediction.*pp is a standalone program
20170507 19:27:08< vultraz_iOS> it even has its own main()
20170507 19:29:05< gfgtdf> celticminstrel: with the latest check doenst that mean that it no longer accepts relertive directores as given by the lua functions ?
20170507 19:31:20< vultraz_iOS> i still think this leak must have something to do with circular references
20170507 19:32:50-!- Kwandulin [~Kwandulin@p200300760F6D8083E939901127AC211B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170507 19:33:00< celticminstrel> gfgtdf: Sorry, what?
20170507 19:33:17< celticminstrel> Oh, wait.
20170507 19:33:37< vultraz_iOS> and i definitely think it has to do with current_track
20170507 19:35:21< celticminstrel> Circular references are when A references B which references A. I don't see that happening here.
20170507 19:35:46-!- sevu [~Unknown@141.39.226.226] has quit [Ping timeout: 264 seconds]
20170507 19:38:02-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 19:41:09< irker905> wesnoth: Charles Dang wesnoth:master c8e1035a90fb / src/sound.cpp: Another attempt to fix sound memleak https://github.com/wesnoth/wesnoth/commit/c8e1035a90fbca857b746e664321d259cc691858
20170507 19:43:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170507 19:43:35< celticminstrel> That shouldn't make a difference.
20170507 19:43:51< vultraz_iOS> one would think
20170507 19:44:21< celticminstrel> One thing I'd considered was using push_back and std::make_shared, but I'm pretty sure that shouldn't make a difference either.
20170507 19:45:54-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 19:50:42< irker905> wesnoth: Celtic Minstrel wesnoth:rel_paths 5c5f6a3e923c / src/filesystem_boost.cpp: Previous fix broke something else https://github.com/wesnoth/wesnoth/commit/5c5f6a3e923c47f233a7157fee2f0f27130684b5
20170507 19:53:51-!- JyrkiVesterinen [~JyrkiVest@87-100-173-104.bb.dnainternet.fi] has quit [Quit: .]
20170507 19:59:08< celticminstrel> There are only 17 calls to get_wml_location... seems like it shouldn't be too hard to make sure they all pass only relative paths as the current directory.
20170507 19:59:16< celticminstrel> (Most of them probably just pass the default empty, anyway.)
20170507 20:00:26< celticminstrel> It'd be really nice if Lua embedded in WML could somehow give the filename and line numbers of the WML file in the event of errors... but I can't think of a way to do that...
20170507 20:01:42< celticminstrel> gfgtdf: Oh hey, there's string.dump(fcn) which appears to be a way to serialize a function.
20170507 20:02:00< gfgtdf> celticminstrel: hmm ye but it probably won't eokr if the function has upvalues
20170507 20:02:03< gfgtdf> work*
20170507 20:02:07< celticminstrel> That's correct.
20170507 20:02:16< celticminstrel> It'll only work if the function has no upvalues.
20170507 20:03:34< celticminstrel> It's probably possible to serialize the upvalues manually somehow, but I imagine that would take a lot of work.
20170507 20:03:35< gfgtdf> celticminstrel: wml has  currnet_dirctory macro, to as a workaroudn we coudl add a name= attibute to [lua] so that people coudl write [lua] name = {CURRNET_FILE}
20170507 20:03:49< celticminstrel> I was actually thinking about that too.
20170507 20:03:59< celticminstrel> But there's still the problem of line numbers.
20170507 20:05:11< gfgtdf> celticminstrel: it would. Note that 'upvalues' are often uderdata objects or other functions 
20170507 20:05:30< celticminstrel> Yeah.
20170507 20:18:58-!- sevu [~Unknown@141.39.226.226] has quit [Ping timeout: 264 seconds]
20170507 20:21:22-!- sevu [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 20:33:27-!- prkc [~prkc@212.92.119.1] has quit [Ping timeout: 240 seconds]
20170507 20:49:55-!- sevu [~Unknown@141.39.226.226] has quit [Disconnected by services]
20170507 20:49:55-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 20:54:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170507 20:55:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170507 21:17:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170507 21:17:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 21:21:55-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 21:23:46-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 264 seconds]
20170507 21:24:14-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 21:26:30-!- Shiki_ [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 21:29:35-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 21:37:08< vultraz_iOS> hmm
20170507 21:37:09< vultraz_iOS> current_track_index = current_track_list.size();
20170507 21:37:17< vultraz_iOS> is this valid? I thought size() wasn't a valid index
20170507 21:38:20< vultraz_iOS> see, elsewhere it does current_track_index = current_track_list.size() - 1;
20170507 21:38:23< vultraz_iOS> celticminstrel: which is correct?
20170507 21:40:36< celticminstrel> Both, potentially.
20170507 21:40:52< celticminstrel> size() isn't a valid index.
20170507 21:40:56< celticminstrel> That's the point.
20170507 21:42:00< vultraz_iOS> :|
20170507 21:42:15< celticminstrel> When current_track is not on the list, current_track_index == current_track_list.size()
20170507 21:42:48< vultraz_iOS> ...
20170507 21:43:27< vultraz_iOS> ya know, I'm starting to doubt the efficacy of making this code use pointers 
20170507 21:44:55< celticminstrel> It's because of the Lua music API.
20170507 21:47:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 21:48:42< celticminstrel> vultraz_iOS:  Wild guess; try clearing the track list and resetting current_track in close_sound()?
20170507 21:49:21< celticminstrel> I don't see why that would help, but if it thinks it's leaked because it's a global variable...
20170507 21:49:28-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20170507 21:49:56< celticminstrel> Probably just after it calls stop_music() I guess.
20170507 21:50:51< celticminstrel> Ah, no, that won't work.
20170507 21:51:01< celticminstrel> close_sound() is called when you disable sound and music in prefs.
20170507 21:51:04< celticminstrel> :/
20170507 21:51:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20170507 21:54:26-!- shiki [~Unknown@141.39.226.226] has joined #wesnoth-dev
20170507 21:57:35-!- Shiki_ [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 21:59:27< celticminstrel> wedge009: Are you going to add the Boost.Unit_Test lib+dll to aquileia/external?
20170507 22:10:26-!- higgins` [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev
20170507 22:10:57-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20170507 22:11:17-!- Ravana__ [~Ravana@17-83-191-90.dyn.estpak.ee] has joined #wesnoth-dev
20170507 22:11:48-!- Ravana__ is now known as Ravana_
20170507 22:11:50-!- Ravana_ [~Ravana@17-83-191-90.dyn.estpak.ee] has quit [Changing host]
20170507 22:11:50-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170507 22:14:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170507 22:22:36-!- Netsplit *.net <-> *.split quits: boucman, Jetrel, matthiaskrgr, Alkenrinnstet, Elsi, higgins
20170507 22:23:01-!- Netsplit over, joins: Elsi
20170507 22:25:54-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-iouszrnnqkiuptti] has joined #wesnoth-dev
20170507 22:26:20< celticminstrel> Why does filesystem::read_map() check first in "maps/"?
20170507 22:26:26-!- matthiaskrgr is now known as Guest73997
20170507 22:26:46< celticminstrel> That directory does not exist anyway.
20170507 22:26:55-!- Guest73997 [matthiaskr@gateway/shell/panicbnc/x-iouszrnnqkiuptti] has quit [Changing host]
20170507 22:26:55-!- Guest73997 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170507 22:26:55-!- Guest73997 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20170507 22:26:55-!- Guest73997 [matthiaskr@gateway/shell/panicbnc/x-iouszrnnqkiuptti] has joined #wesnoth-dev
20170507 22:27:31-!- Guest73997 is now known as matthiaskrgr_
20170507 22:28:08-!- shiki [~Unknown@141.39.226.226] has quit [Ping timeout: 240 seconds]
20170507 22:35:28-!- Appleman1234 [~Appleman1@pl52488.ag1212.nttpc.ne.jp] has quit [Ping timeout: 240 seconds]
20170507 22:37:29-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170507 22:38:50< vultraz_iOS> dunno
20170507 22:38:52< vultraz_iOS> legacy?
20170507 22:50:31-!- Appleman1234 [~Appleman1@pl37465.ag1212.nttpc.ne.jp] has joined #wesnoth-dev
20170507 22:51:06< vultraz_iOS> celticminstrel: any objection if i move most of the sound.cpp file into the sound namespace
20170507 22:51:14-!- irker905 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170507 22:51:16< vultraz_iOS> inc the track list
20170507 22:51:20-!- irker157 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170507 22:51:20< irker157> wesnoth: Celtic Minstrel wesnoth:rel_paths a7c494445e4d / src/ (filesystem_boost.cpp serialization/preprocessor.cpp): Instead of trying to trap absolute paths in get_wml_location, https://github.com/wesnoth/wesnoth/commit/a7c494445e4dc57bea2b1c4cd6f58b19742fbf2a
20170507 22:54:20< irker157> wesnoth: Celtic Minstrel wesnoth:master f0d023164eab / src/editor/map/map_context.cpp: Make editor understand tutorial tags and current directory https://github.com/wesnoth/wesnoth/commit/f0d023164eabbdc3f381e3ed9ee8f8a0914989ca
20170507 22:54:22< irker157> wesnoth: Celtic Minstrel wesnoth:master cbba6b3929c5 / data/lua/package.lua: wesnoth.require: Automatically check current directory for packages https://github.com/wesnoth/wesnoth/commit/cbba6b3929c5542bcc4f5dc783883ec76c316262
20170507 22:54:34< celticminstrel> vultraz_iOS: I don't think it matters at all.
20170507 22:54:51< celticminstrel> I think the way it's currently set up is that only the public stuff is in the sound namespace.
20170507 22:55:01< celticminstrel> With maybe a few exceptions.
20170507 22:55:13< celticminstrel> But at least, I think that was the intent.
20170507 22:55:20< celticminstrel> Still, I don't really care one way or the other.
20170507 22:55:45< celticminstrel> Don't remove anonymous namespaces or static specifiers though.
20170507 22:56:00< vultraz_iOS> why former?
20170507 22:56:14< celticminstrel> ?
20170507 22:56:23< vultraz_iOS> "Don't remove anonymous namespaces "
20170507 22:56:39< celticminstrel> Because removing them means exporting the symbols?
20170507 22:56:55< vultraz_iOS> I don't get it
20170507 22:57:34-!- Appleman1234 [~Appleman1@pl37465.ag1212.nttpc.ne.jp] has quit [Ping timeout: 260 seconds]
20170507 22:57:37< vultraz_iOS> it's still in the cpp 
20170507 22:59:04< celticminstrel> If it's not supposed to be directly accessed outside the file, then it shouldn't have external linkage.
20170507 22:59:26< celticminstrel> Even if it's in the cpp file, if it has external linkage (ie, is not declared static or in an anonymous namespace), it can be accessed from another file.
20170507 22:59:38< celticminstrel> That file just needs to redeclare it with the extern specifier.
20170507 23:00:05< vultraz_iOS> I see
20170507 23:00:39< celticminstrel> (Not sure if that's possible for classes actually..._
20170507 23:00:42< celticminstrel> ^)
20170507 23:01:33< vultraz_iOS> i was mostly going to mark the track list and stuff as static in sound
20170507 23:01:34< celticminstrel> Anyway, if it has internal linkage already, don't make it external unless you have to.
20170507 23:02:10< celticminstrel> Actually, making something external that previously wasn't could theoretically cause linker errors, though I don't think it's very likely.
20170507 23:02:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170507 23:02:35< vultraz_iOS> static means internal linkage, you just said
20170507 23:02:53< celticminstrel> Speaking of internal linkage, didn't you add something static in a header that wasn't supposed to be static? Was that fixed?
20170507 23:03:07< gfgtdf> vultraz_iOS: anon namespace also means internal linkage, usually anaon namespace is the perfered way
20170507 23:03:20< celticminstrel> I actually prefer static.
20170507 23:03:21< vultraz_iOS> I did not
20170507 23:03:26< vultraz_iOS> fix it
20170507 23:03:27< vultraz_iOS> wasn't sure how
20170507 23:03:36< celticminstrel> ...pretty sure I told you how.
20170507 23:03:43< celticminstrel> Where was it again?
20170507 23:04:15< vultraz_iOS> empty_palette.hpp
20170507 23:05:15< gfgtdf> celticminstrel: static was naearly deprecated in c++11 in favour of anon namespace 
20170507 23:05:27< vultraz_iOS> i know but it's not anymore
20170507 23:05:33< celticminstrel> Is there even a reason to have a static vector? Is constructing an empty vector really that expensive? I think it'd be easier to do that.
20170507 23:05:54< vultraz_iOS> no, i just didn't see much point in doing it
20170507 23:05:57< vultraz_iOS> though actually
20170507 23:06:04< vultraz_iOS> I wonder why it needs to return anything at all
20170507 23:06:13< vultraz_iOS> just don't implement the function
20170507 23:06:19< celticminstrel> Oh, wait, it's a reference.
20170507 23:06:27< celticminstrel> So it can't return a temporary.
20170507 23:07:09< celticminstrel> vultraz_iOS: If you didn't implement the function, empty_palette would be abstract.
20170507 23:07:15< vultraz_iOS> hell
20170507 23:10:39-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170507 23:14:46-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has joined #wesnoth-dev
20170507 23:20:10< irker157> wesnoth: Celtic Minstrel wesnoth:master 02414e6bd57c / src/editor/palette/empty_palette.hpp: fixup! Editor: keep empty palette group list as static https://github.com/wesnoth/wesnoth/commit/02414e6bd57cf8a464e444d90f186ba1e7b730f4
20170507 23:25:44-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 260 seconds]
20170507 23:34:05< celticminstrel> So should I start transferring bugs now or leave a day or two more for people to peruse the trial run?
20170507 23:35:11< vultraz_iOS> .......why did i not think of that
20170507 23:36:01< vultraz_iOS> celticminstrel: looks good to me
20170507 23:36:08< vultraz_iOS> the bug test
20170507 23:37:07< vultraz_iOS> honestly, I have faith you've done everything properly
20170507 23:37:23< celticminstrel> So you want me to start transferring them now?
20170507 23:37:33 * celticminstrel pings gfgtdf in case he has any objections.
20170507 23:37:51< vultraz_iOS> sure,begin
20170507 23:40:16< vultraz_iOS> hmmm
20170507 23:40:23< vultraz_iOS> i noticed you left bugs marked fixed
20170507 23:40:33< vultraz_iOS> shouldn't those be left out?
20170507 23:40:44< vultraz_iOS> ie, open but fixed.
20170507 23:40:47< vultraz_iOS> on GNA
20170507 23:40:48< vultraz_iOS> like https://github.com/CelticMinstrel/wesnoth/issues/572
20170507 23:41:14-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:b8f3:10ec:f389:b4a9] has quit [Remote host closed the connection]
20170507 23:41:18< celticminstrel> Well, that depends on our bugs protocol.
20170507 23:42:11< vultraz_iOS> I see
20170507 23:42:16< celticminstrel> https://github.com/wesnoth/wesnoth/issues/1031
20170507 23:42:36< vultraz_iOS> well, we no longer have an easy way to filter those out
20170507 23:42:39< celticminstrel> gfgtdf seemed to support a fixed label, so I added it to the script.
20170507 23:43:12< vultraz_iOS> well, first off, we want to allow auto-close from commit messages
20170507 23:44:25< vultraz_iOS> if you can't mass-close bugs on GH I support changing the protocol 
20170507 23:44:40< vultraz_iOS> it's annoying as hell to have to close dozens of bugs when a release happens
20170507 23:44:58< vultraz_iOS> i propose we leverage milestones to allow us to see what's in a certain release
20170507 23:45:03< celticminstrel> You can mass-close them on the main issues page. That's what all those checkboxes are for.
20170507 23:45:22< celticminstrel> You can also exclude labels by URL editing: https://github.com/CelticMinstrel/wesnoth/issues?q=is%3Aopen+is%3Aissue+-label%3Ablocker
20170507 23:45:50< celticminstrel> (Just add a - in front of the word "label" for the label you want to exclude.)
20170507 23:46:02< celticminstrel> (So you end up with +- instead of just +)
20170507 23:47:00< vultraz_iOS> I'm thinking we immediately close bugs when fixed
20170507 23:47:08< vultraz_iOS> but add a milestone for the release they'll be in
20170507 23:47:19< vultraz_iOS> assuming they're not interim master bugs
20170507 23:48:01< celticminstrel> I have no objections, but please post it on the issue too.
20170507 23:48:11< celticminstrel> So that people who don't pay attention to IRC can see it.
20170507 23:52:15< celticminstrel> [May 07@7:42:36pm] vultraz_iOS: well, we no longer have an easy way to filter those out
20170507 23:52:17< celticminstrel> I don't really know what you're talking about here.
20170507 23:52:29< vultraz_iOS> I don't remember
20170507 23:52:38< celticminstrel> ...
20170507 23:52:54< celticminstrel> Well if what you wanted is to view all bugs not marked "fixed", then that's possible.
20170507 23:53:00< celticminstrel> Though a little fiddly.
20170507 23:53:08< vultraz_iOS> hang on, im writing my protocol proposal
20170507 23:53:13< celticminstrel> 'kay
20170507 23:56:15< vultraz_iOS> postd
20170507 23:56:16< vultraz_iOS> ed
20170507 23:57:02< vultraz_iOS> *small tweak*
--- Log closed Mon May 08 00:00:28 2017