--- Log opened Wed May 10 00:00:28 2017
20170510 00:05:55< vultraz_iOS> celticminstrel: what are we doing about Git Reports?
20170510 00:06:11< celticminstrel> I dunno. Have you investigated it?
20170510 00:07:44< vultraz_iOS> well, you'd need to login with wesnoth-bugs
20170510 00:08:01< celticminstrel> Obviously.
20170510 00:09:44< vultraz_iOS> looks really simple
20170510 00:09:44< vultraz_iOS> https://gitreports.com/tutorial
20170510 00:11:14< celticminstrel> Somone wondered if Git Reports allows notifying the person who posted the issue when it gets updated, but it looks like it doesn't.
20170510 00:11:54< irker599> wesnoth: Matthias Krüger wesnoth:master 3ec26df495e0 / data/multiplayer/scenarios/ (12 files): multiplayer maps: descriptions: cleanup https://github.com/wesnoth/wesnoth/commit/3ec26df495e0c568fb2e1536e0c7356f29738f81
20170510 00:12:46< vultraz_iOS> any chance of finishing https://github.com/wesnoth/wesnoth/pull/993
20170510 00:12:52< vultraz_iOS> in the next 4 days
20170510 00:12:56< vultraz_iOS> or do i postpone 
20170510 00:13:07< vultraz_iOS> the PR, that is
20170510 00:13:23< vultraz_iOS> (speaking of 4 days, could you add the [save] action by then?)
20170510 00:13:36< celticminstrel> Maybe if someone points me in the right direction.
20170510 00:13:48< vultraz_iOS> which direction is that
20170510 00:14:09< celticminstrel> As for the cave map, probably postpone.
20170510 00:14:47< vultraz_iOS> is game_lua_kernel::save_game not what you want
20170510 00:15:30< celticminstrel> Uh. No idea?
20170510 00:17:53-!- Greg-Boggs [~greg_bogg@c-73-37-6-51.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20170510 00:19:51< celticminstrel> There's an open issue for notifying the submitter when the issue status changes...
20170510 00:22:27< vultraz_iOS> you're kidding me
20170510 00:22:31< vultraz_iOS> why, wml why..
20170510 00:22:32< celticminstrel> ?
20170510 00:22:56< vultraz_iOS> looks like [generator][height] doesn't allow a comma separated list of terrains!
20170510 00:23:12< celticminstrel> Pretty sure my PR adds that.
20170510 00:23:28< celticminstrel> Oh wait, that might be some other place.
20170510 00:23:31< celticminstrel> Yeah, sorry.
20170510 00:23:35< celticminstrel> Still, shouldn't be hard to add?
20170510 00:25:44< vultraz_iOS> maybe you could add it with your PR
20170510 00:25:48< vultraz_iOS> not sure how best to do it
20170510 00:25:57< celticminstrel> Well it's technically out of scope for my PR, I think.
20170510 00:26:03< celticminstrel> Since the PR is about cave maps.
20170510 00:26:04< vultraz_iOS> easy enough to split the data, but then the choices need to be randomized
20170510 00:26:11< celticminstrel> And/or Lua generation.
20170510 00:26:24< celticminstrel> Randmoizing the choices is also easy, right?
20170510 00:26:32< vultraz_iOS> is it?
20170510 00:26:42< celticminstrel> What exactly would be hard about it?
20170510 00:27:00< vultraz_iOS> how does one do it 
20170510 00:28:00< celticminstrel> You're asking me how to pick a random element from a list?
20170510 00:28:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 00:29:12< vultraz_iOS> yes
20170510 00:29:21< celticminstrel> Seriously?
20170510 00:29:26< vultraz_iOS> though i guess there are enough code references I could figure it out
20170510 00:29:38< celticminstrel> list[rand(0, list.size() - 1)]
20170510 00:29:44< celticminstrel> (Assuming rand's range is inclusive)
20170510 00:30:07< vultraz_iOS> well, of course :|
20170510 00:30:39< vultraz_iOS> but I thought we weren't supposed to use std::rand
20170510 00:30:41< celticminstrel> (And rand is an illustrative name, nothing to do with the actual rand() function.)
20170510 00:30:46-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20170510 00:30:50< celticminstrel> std::rand doesn't take any arguments.
20170510 00:31:27< celticminstrel> And yes, don't use std::rand. Use the same RNG used by the rest of the generator, obviously.
20170510 00:32:02< vultraz_iOS> (of course it's obvious that one wants to random between 0 and size - 1, that's not what I was asking >_> )
20170510 00:32:45< vultraz_iOS> even though I admit i have asked some very... stupid questions in the past
20170510 00:32:53< vultraz_iOS> like "what is true && false" :P
20170510 00:32:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170510 00:33:49< celticminstrel> Everything you said pointed to you asking that, so...
20170510 00:35:11< vultraz_iOS> perhaps I should have said "what code method do we use specifically to get random numbers in wesnoth"
20170510 00:36:20< celticminstrel> I don't recall exactly, but I'm sure there are tons of examples in the map generator.
20170510 00:36:32< vultraz_iOS> yes, that's why I said "though i guess there are enough code references I could figure it out"
20170510 00:36:33< celticminstrel> (And elsewhere of course.)
20170510 00:37:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170510 00:51:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170510 00:51:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170510 00:54:30-!- atarocch [~atarocch@37.176.3.75] has quit [Remote host closed the connection]
20170510 00:59:44-!- sevu [~Unknown@pD954C1B8.dip0.t-ipconnect.de] has quit [Quit: Verlassend]
20170510 01:05:40-!- gfgtdf [~chatzilla@x4e32b7a1.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20170510 01:19:30-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20170510 01:41:31-!- sevu [~Unknown@pD954C1B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170510 03:02:50-!- sevu [~Unknown@pD954C1B8.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20170510 03:08:47-!- JyrkiVesterinen [~JyrkiVest@87-100-181-28.bb.dnainternet.fi] has joined #wesnoth-dev
20170510 03:12:25-!- irker599 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170510 03:14:02< celticminstrel> vultraz_iOS: So how do you think the blinking text cursor should behave?
20170510 03:14:18< vultraz_iOS> i would imagine it should pause if the window isn't on top
20170510 03:14:18< celticminstrel> When there's another window in front of it.
20170510 03:14:33< celticminstrel> Should it stay at the alpha it had when the second window opened?
20170510 03:14:39< celticminstrel> Or should it be fixed at fully opaque?
20170510 03:14:39< vultraz_iOS> yes
20170510 03:14:44< vultraz_iOS> or
20170510 03:14:46< vultraz_iOS> hm
20170510 03:14:51< vultraz_iOS> yeah actually that might be better?
20170510 03:14:52< vultraz_iOS> i dunno
20170510 03:14:54< vultraz_iOS> doesn't matter
20170510 03:14:54< celticminstrel> Or should it be fixed at fully transparent?
20170510 03:15:02< celticminstrel> ...wow, you're so helpful. :P
20170510 03:15:21< celticminstrel> Geh, I lost the disable commit.
20170510 03:15:50< celticminstrel> Found it again.
20170510 03:16:49-!- irker766 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170510 03:16:49< irker766> wesnoth: Charles Dang wesnoth:master e41a4155884d / src/ (26 files in 16 dirs): Deployed yet even more further additional emplace_back https://github.com/wesnoth/wesnoth/commit/e41a4155884d29c98b5d670a55a4913566b1ee37
20170510 03:16:50< irker766> wesnoth: Charles Dang wesnoth:master ba99ffded861 / src/ (game_launcher.cpp hotkey/command_executor.cpp menu_events.cpp): Fixup 194b5ef https://github.com/wesnoth/wesnoth/commit/ba99ffded8611a4f1360d3dc70fd74bd0b8d6575
20170510 03:16:51< irker766> wesnoth: Charles Dang wesnoth:master 9ec8ea3f0f0c / src/addon/manager.cpp: Used static vectors for default addon upload ignore patterns https://github.com/wesnoth/wesnoth/commit/9ec8ea3f0f0c26213cf7657a2d0587e797bb91d6
20170510 03:18:43< celticminstrel> We should probably rebase gui2_help again soon.
20170510 03:18:53< vultraz_iOS> still think we should merge it
20170510 03:19:06< celticminstrel> It's not finished, so why would we merge it?
20170510 03:19:16< vultraz_iOS> so we don't have to keep rebasing it
20170510 03:19:20< celticminstrel> Don't merge things that aren't finished.
20170510 03:19:31< celticminstrel> Well, if you don't want to keep rebasing it, there's always the other option/
20170510 03:19:32< vultraz_iOS> i commit unfinished things to master all the time
20170510 03:19:39< celticminstrel> Which is what Aginor did with the sdl2 branch.
20170510 03:19:46< celticminstrel> Merge master into gui2_help.
20170510 03:20:06< celticminstrel> Personally, I prefer rebasing the branch.
20170510 03:20:19< celticminstrel> More precisely, I prefer merges to only go one way - into master.
20170510 03:21:05< celticminstrel> vultraz_iOS: Add .DS_Store to the list of ignore patterns.
20170510 03:21:19< celticminstrel> Oh, wait.
20170510 03:21:24< celticminstrel> Not necessary because it begins with a dot.
20170510 03:21:58< celticminstrel> It'd be great if it could also auto-ignore files which have the hidden flag set in Windows or Mac.
20170510 03:22:11< celticminstrel> But on the other hand, it's also rather unlikely that any such files would exist.
20170510 03:24:05< celticminstrel> ...heh, why is .js on that list?
20170510 03:24:34< celticminstrel> I mean, there's no reason why you'd want to include JS files, but... I also don't know any reason why they should be excluded.
20170510 03:56:08-!- Kwandulin [~Kwandulin@p200300760F6D804160106C5AD4B7D859.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170510 04:12:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170510 04:12:40-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170510 04:47:16-!- Kwandulin [~Kwandulin@p200300760F6D804160106C5AD4B7D859.dip0.t-ipconnect.de] has quit [Quit: [endlevel] result=novictorynodefeatjustquit [/endlevel]]
20170510 04:49:37-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20170510 04:59:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 05:04:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20170510 05:39:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20170510 06:10:54< zookeeper> celticminstrel, either raise an error or just do nothing, i guess. the only sensible default would seem to be to play a random animation, but that's more a recipe for confusion than anything else.
20170510 06:12:57< zookeeper> what _does_ it do currently?
20170510 06:13:11< zookeeper> the history for the test scenario suggests that it might be intended to just play a random anim
20170510 06:13:25-!- JyrkiVesterinen [~JyrkiVest@87-100-181-28.bb.dnainternet.fi] has quit [Quit: .]
20170510 06:13:56< celticminstrel> I see.
20170510 06:14:32< celticminstrel> I don't think it's possible to play a random animation out of all the animations actually possessed by the unit.
20170510 06:14:36< zookeeper> i mean... what else could "The silly dance" refer to? :p
20170510 06:14:52< celticminstrel> Yeah, it does kinda make sense, I guess.
20170510 06:15:56< zookeeper> i seem to constantly get the idle anim when i step on that on 1.12.6
20170510 06:18:44< zookeeper> well, whatever it's intended to do, it's undocumented and it'd be really fishy to rely on that kind of behavior anyway instead of just specifying what you want it to play, so i don't mind if it's made to result in a warning
20170510 06:19:08< celticminstrel> I was going to change it to a WML error if there's no flag.
20170510 06:20:46< zookeeper> sure
20170510 06:31:01< vultraz_iOS> celticminstrel: what needs to be done before release?
20170510 06:31:29< celticminstrel> https://github.com/wesnoth/wesnoth/issues?q=is%3Aissue+is%3Aopen+label%3Ablocker
20170510 06:31:49< celticminstrel> All those need to be fixed at least for 1.14.
20170510 06:32:07< celticminstrel> It's possible a few already are, not sure.
20170510 06:32:15< vultraz_iOS> 1499 doesn't have to be
20170510 06:32:17< vultraz_iOS> I'm demoting it.
20170510 06:32:46< celticminstrel> That was one of the ones I thought might already be fixed, but if it's what I think it is, I'd agree it shouldn't be a blocker.
20170510 06:38:03< vultraz_iOS> oh, attack_prediction.hpp *can* be compiled standalone
20170510 06:38:06< vultraz_iOS> but isn't necessary
20170510 06:38:21< celticminstrel> ???
20170510 06:38:57< vultraz_iOS> investigating https://github.com/wesnoth/wesnoth/issues/1679
20170510 06:39:59< vultraz_iOS> ok what
20170510 06:40:23< vultraz_iOS> ok, so I added this assertion.
20170510 06:40:24< vultraz_iOS> assert(&them_b.hp_dist[0] != nullptr);
20170510 06:40:25< vultraz_iOS> that fails
20170510 06:40:51< vultraz_iOS> celticminstrel: if i revert your commit the crash goes away: https://github.com/wesnoth/wesnoth/commit/78815759547e4d7520693d03ad7119378d565dfc
20170510 06:41:54< celticminstrel> Well, the reason for the commit is that when you declare an array as a function argument, that's not really an array, just a pointer to the first element.
20170510 06:41:58< celticminstrel> So it's misleading.
20170510 06:42:07< vultraz_iOS> oh wait
20170510 06:42:11< vultraz_iOS> do I need to double index now?
20170510 06:42:18< celticminstrel> However, if you can't fix the issue, I guess it's okay to revert it.
20170510 06:42:23< celticminstrel> What are you talking about?
20170510 06:42:43< vultraz_iOS> or..hm
20170510 06:42:45< vultraz_iOS> no..
20170510 06:43:30< vultraz_iOS> hmmm
20170510 06:45:36< vultraz_iOS> what could the issue be..
20170510 06:45:54< vultraz_iOS> that is, why would them_b.hp_dist[0] be invalid if an array is used..
20170510 06:46:30< vultraz_iOS> oh
20170510 06:46:44< vultraz_iOS> think i got it
20170510 06:47:57< vultraz_iOS> wait, no
20170510 06:48:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 06:49:33-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170510 06:52:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170510 06:52:09< vultraz_iOS> celticminstrel: what do you mean pointer to the first element?
20170510 06:52:34< celticminstrel> int x[2] as a function parameter does not exist. It's equivalent to int* x
20170510 06:53:04< celticminstrel> "int x[2]" makes it look like the compiler might be checking the length of the array, but it's not. It just passes a pointer to the first element.
20170510 06:53:07< vultraz_iOS> then how would this have worked: https://github.com/wesnoth/wesnoth/blob/master/src/attack_prediction.cpp#L1186-L1192
20170510 06:53:31< celticminstrel> How would it not have worked?
20170510 06:53:45< celticminstrel> A pointer can be indexed just like an array.
20170510 06:53:51< vultraz_iOS> wait what?
20170510 06:56:24< JyrkiVesterinen> Regarding the commit (as the current attack prediction code maintainer): I think the problem is that the code needs to write to the target array.
20170510 06:56:39< JyrkiVesterinen> If you convert a C array into a std::array, it will only write to the copy.
20170510 06:56:49< JyrkiVesterinen> And the change won't be visible to the caller.
20170510 06:56:53< celticminstrel> Ah, so pass by reference?
20170510 06:56:56< vultraz_iOS> oh right, it doesn't take by reference
20170510 06:57:21< JyrkiVesterinen> Yes, passing by reference should help.
20170510 06:57:27< vultraz_iOS> should i make all changes in that commit by reference?
20170510 06:57:34< vultraz_iOS> er
20170510 06:57:42< celticminstrel> Probably.
20170510 06:57:47< vultraz_iOS> ok you got what i meant
20170510 06:57:51< JyrkiVesterinen> Yes. Both for correctness and performance.
20170510 06:57:57< celticminstrel> All cases where it's passed to a function, at the very least.
20170510 07:03:52< vultraz_iOS> ah, that fixes it
20170510 07:04:10< irker766> wesnoth: Wedge009 wesnoth:master 8225e8d4b054 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project files for 194b5ef1. https://github.com/wesnoth/wesnoth/commit/8225e8d4b0546d48b3f47b33d863fcee4aee2f6b
20170510 07:05:12-!- celticminstrel is now known as celmin|sleep
20170510 07:05:33< irker766> wesnoth: Charles Dang wesnoth:master fa135054ba6a / src/attack_prediction.cpp: Fixup 78815759547: take all summary arrays by reference (fixes #1679) https://github.com/wesnoth/wesnoth/commit/fa135054ba6a4904027803c8e265a57e42089245
20170510 07:06:11< matthiaskrgr> \o/
20170510 07:07:16-!- Alkenrinnstet [~alkenrinn@42.61.217.253] has joined #wesnoth-dev
20170510 07:07:48-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20170510 07:11:47< vultraz_iOS> this file (attack_predication.cpp) is messy as *hell* 
20170510 07:12:29< matthiaskrgr> :/  
20170510 07:12:45< vultraz_iOS> JyrkiVesterinen: you don't have any pending changes to this file, do you? I'm going to run clang-format + manual cleanup.
20170510 07:12:51< vultraz_iOS> local changes*
20170510 07:12:59< JyrkiVesterinen> No, I don't.
20170510 07:13:02< vultraz_iOS> k
20170510 07:15:12< vultraz_iOS> sooo muuchhh ccccccc
20170510 07:19:45-!- atarocch [~atarocch@37.176.213.189] has joined #wesnoth-dev
20170510 08:12:29< irker766> wesnoth: Charles Dang wesnoth:master 7947d7d77a3c / src/attack_prediction.cpp: Attack Prediction: massive formatting cleanup https://github.com/wesnoth/wesnoth/commit/7947d7d77a3c45563a46e6bc1a473cf202cda7ca
20170510 08:12:32< irker766> wesnoth: Charles Dang wesnoth:master 82348700ac8c / src/attack_prediction.cpp: Attack Prediction: added type alias for summary array https://github.com/wesnoth/wesnoth/commit/82348700ac8cb3391be7c68996c0e8ea5f06e397
20170510 08:15:12< vultraz_iOS> JyrkiVesterinen: is there any reason to keep so much C in this file, or is it alright to change stuff like printf to a log stream, etc?
20170510 08:15:35< JyrkiVesterinen> Using C++ stuff would be fine.
20170510 08:16:36< JyrkiVesterinen> I think the main reason why there is some old code is that the file is just so old. In particular, almost nobody has bothered to refactor the test code.
20170510 08:18:01< JyrkiVesterinen> In https://github.com/wesnoth/wesnoth/commit/ddf842194446917847203c8e3afa0d04f24b50a2 I at least switched the benchmarking from ancient Unix-specific functions to std::chrono.
20170510 08:19:16< vultraz_iOS> good god what even was that code O_O
20170510 08:19:56-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170510 08:33:19-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170510 08:36:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 08:40:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170510 08:42:16-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Read error: Connection reset by peer]
20170510 08:42:22-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20170510 08:47:17-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 272 seconds]
20170510 08:52:08-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 240 seconds]
20170510 09:08:51-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has joined #wesnoth-dev
20170510 09:17:05-!- sevu [~Unknown@141.57.57.56] has joined #wesnoth-dev
20170510 09:18:31< Soliton> that code is C because it was written by a C coder.
20170510 09:19:15< vultraz_iOS> I see
20170510 10:03:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20170510 10:04:29-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has joined #wesnoth-dev
20170510 10:05:35-!- oldlaptop [~quassel@45.63.78.126] has quit [Ping timeout: 240 seconds]
20170510 10:12:25-!- oldlaptop [~quassel@45.63.78.126] has joined #wesnoth-dev
20170510 10:20:29-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170510 10:24:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 10:28:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20170510 10:38:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 10:39:33-!- sevu [~Unknown@141.57.57.56] has quit [Remote host closed the connection]
20170510 11:12:58-!- irker766 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170510 11:22:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 11:23:01-!- sevu [~Unknown@141.57.57.56] has joined #wesnoth-dev
20170510 11:23:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 11:24:21-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has quit [Ping timeout: 272 seconds]
20170510 11:24:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170510 11:36:20-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170510 11:42:17-!- sevu [~Unknown@141.57.57.56] has quit [Quit: Verlassend]
20170510 11:42:40-!- sevu [~Shiki@141.57.57.56] has joined #wesnoth-dev
20170510 11:47:03-!- Kwandulin [~Kwandulin@p200300760F6D804160106C5AD4B7D859.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170510 11:48:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 11:48:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 11:51:51< sevu> vultraz_iOS, would it be possible to join the development team ?
20170510 12:00:38-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has joined #wesnoth-dev
20170510 12:06:53-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has quit [Ping timeout: 255 seconds]
20170510 12:13:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 12:13:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 12:14:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 12:17:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20170510 12:24:06-!- Kwandulin [~Kwandulin@p200300760F6D804160106C5AD4B7D859.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20170510 12:25:31-!- Kwandulin [~Kwandulin@p200300760F6D803DA14702C3BE550BD3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170510 12:26:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20170510 12:26:32-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 12:28:45-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has joined #wesnoth-dev
20170510 13:08:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 13:08:46-!- lipkab [~the_new_l@2001:738:5404:192:8115:b1aa:e7a5:f184] has quit [Ping timeout: 264 seconds]
20170510 13:10:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 13:27:29-!- Kwandulin [~Kwandulin@p200300760F6D803DA14702C3BE550BD3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170510 13:33:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 13:33:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 13:42:44< vultraz_iOS> would probably be accaptable
20170510 13:51:15-!- minbonbon [~min@meta23.net] has joined #wesnoth-dev
20170510 13:52:21-!- minzbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20170510 14:00:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 14:01:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 14:09:17-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20170510 14:30:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170510 14:34:54-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20170510 14:48:08-!- JyrkiVesterinen [~JyrkiVest@85-76-66-132-nat.elisa-mobile.fi] has quit [Quit: .]
20170510 15:02:55-!- Kwandulin [~Kwandulin@p200300760F6D803DA14702C3BE550BD3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20170510 15:04:17-!- irker338 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170510 15:04:17< irker338> wesnoth: Charles Dang wesnoth:master c83021f8298c / src/attack_prediction.cpp: Attack Prediction: incomplete conversion of debug output to use C++ streams https://github.com/wesnoth/wesnoth/commit/c83021f8298cb968fd26bc3bf94999cf5d37e0cf
20170510 15:04:18< irker338> wesnoth: Charles Dang wesnoth:master c5da7b216347 / src/attack_prediction.cpp: Attack Prediction: use a constexpr static instead of a macro constant https://github.com/wesnoth/wesnoth/commit/c5da7b2163478d81f48a9a8a84f04f04a47b2a21
20170510 15:04:19< irker338> wesnoth: Charles Dang wesnoth:master e351af4a200f / src/attack_prediction.cpp: Attack Prediction: range-for https://github.com/wesnoth/wesnoth/commit/e351af4a200f62eb2ebbf6750c5ab8aec44b0ae8
20170510 15:04:21< irker338> wesnoth: Charles Dang wesnoth:master a75e606d8c66 / src/attack_prediction.cpp: Attack Prediction: use unique_ptr to manage prob_matrix plane_ ptrs https://github.com/wesnoth/wesnoth/commit/a75e606d8c66127bffc3fa3f3c798536a6182e90
20170510 15:04:23< irker338> wesnoth: Charles Dang wesnoth:master 8e065f4ff4c6 / src/attack_prediction.cpp: Attack Prediction: fixed game_config symbol clash when building wtih BENCHMARK o https://github.com/wesnoth/wesnoth/commit/8e065f4ff4c6cbf899128929b0a94763f069379e
20170510 15:53:42< wedge009> gfgtdf: I could update the headers, but I wouldn't be able to build the libs. Is this something you want?
20170510 15:53:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170510 16:08:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20170510 16:19:38-!- JyrkiVesterinen [~JyrkiVest@87-100-225-122.bb.dnainternet.fi] has joined #wesnoth-dev
20170510 16:21:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170510 16:29:53-!- mjs-de [~mjs-de@x4db5fa64.dyn.telefonica.de] has joined #wesnoth-dev
20170510 16:46:37-!- sevu [~Shiki@141.57.57.56] has quit [Remote host closed the connection]
20170510 16:46:54-!- gfgtdf [~chatzilla@x4e32b709.dyn.telefonica.de] has joined #wesnoth-dev
20170510 16:47:19< gfgtdf> wedge009: hmm i thought boost string_view is a header onyl library.
20170510 16:59:06< gfgtdf> hmm i just read the in the follwong case f1(  f2(f3())  , f4(f5())  ) its possibel that the functions are called in the folliwing order: f3, f5, f2, f4, f4 you know whether that's true ?
20170510 17:00:32< celmin|sleep> There's no defined order for function calls.
20170510 17:00:34< Soliton> f2 and f4 can be called in any order so presumably f3 and f5 can be as well.
20170510 17:00:41< celmin|sleep> ^
20170510 17:01:24< Soliton> of course the inner calls need to be resolved first but besides that there are no restrictions afaik.
20170510 17:01:30< celmin|sleep> Yeah.
20170510 17:01:51< celmin|sleep> f5, f3, f4, f2, f1 is probably a legal order.
20170510 17:02:26< Soliton> what gfgtdf said should be, too.
20170510 17:02:38< Soliton> except the last one should be f1, of course.
20170510 17:03:53< gfgtdf> i alwa thought  that the 'order or parameter si undefined' only aplies to the diect arguments passed to that function not recusiveley too all expressions that have to be evaulated, so that irts eigher f3,f2,f5,f4,f1 or f5,f4,f3,f2,f1
20170510 17:08:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 17:09:09< gfgtdf> so in particular lines like https://github.com/wesnoth/wesnoth/blob/master/src/ai/formula/function_table.cpp#L364 can casue memeleak becasue the compiler coudl decide to call it in the following order:
20170510 17:09:59< gfgtdf> 1) evaluate 'new map_location(x, y)' 2) evaluate 'variant(scores[0][i] + 10000)', 3) construct the variant from the map_location.
20170510 17:10:18< gfgtdf> so if (2) throws the pointer created by (1) is leaked
20170510 17:12:15< Soliton> there's no naked new there.
20170510 17:12:34< gfgtdf> Soliton: 'new map_location(x, y)'
20170510 17:12:55< gfgtdf> hmm wait
20170510 17:13:03< JyrkiVesterinen> gfgtdf: the line uses make_shared().
20170510 17:13:05< JyrkiVesterinen> std::make_shared<location_callable>(map_location(x, y))
20170510 17:13:23< JyrkiVesterinen> And indeed, thanks to make_shared it's safe from memory leaks.
20170510 17:13:25< JyrkiVesterinen> See https://herbsutter.com/gotw/_102/
20170510 17:13:56< Soliton> yeah, that's why you use the make_* functions.
20170510 17:14:35< gfgtdf> JyrkiVesterinen: hm right seem i havea ~10 days outdated copy here
20170510 17:15:15< gfgtdf> take this line: https://github.com/wesnoth/wesnoth/blob/1.13.7/src/ai/formula/function_table.cpp#L363
20170510 17:16:47< Soliton> that can leak, yes.
20170510 17:17:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20170510 17:17:40-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20170510 17:19:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 17:20:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20170510 17:23:44< irker338> wesnoth: mattsc wesnoth:master e0f8b522043d / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/e0f8b522043df9d8af353262392f93e550044ac9
20170510 17:35:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 18:13:01-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170510 18:13:01< Appveyor> The Battle for Wesnoth (Visual Studio 2017) - Debug Charles Dang 8e065f4: Attack Prediction: fixed game_config symbol clash when building wtih BENCHMARK or CHECK Failed
20170510 18:13:01< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/build/Wesnoth-VS2017-master-17
20170510 18:13:05-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170510 18:20:00-!- celmin|sleep is now known as celticminstrel
20170510 18:20:32-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170510 18:20:32< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Release Charles Dang 8e065f4: Attack Prediction: fixed game_config symbol clash when building wtih BENCHMARK or CHECK Failed
20170510 18:20:32< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-332
20170510 18:20:37-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170510 18:26:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 18:26:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 18:27:08-!- Appveyor [~Appveyor@74.205.54.20] has joined #wesnoth-dev
20170510 18:27:08< Appveyor> The Battle for Wesnoth (Visual Studio 2015) - Debug Charles Dang 8e065f4: Attack Prediction: fixed game_config symbol clash when building wtih BENCHMARK or CHECK Failed
20170510 18:27:08< Appveyor> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/build/Wesnoth-VS2015-master-332
20170510 18:27:12-!- Appveyor [~Appveyor@74.205.54.20] has left #wesnoth-dev []
20170510 18:49:45-!- markus_ [~mjs-de@x4db5cc22.dyn.telefonica.de] has joined #wesnoth-dev
20170510 18:53:04-!- mjs-de [~mjs-de@x4db5fa64.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20170510 19:19:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20170510 19:20:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20170510 19:54:14< zookeeper> DeFender1031, want to (p)review a possible mal-ravanal death animation?
20170510 19:55:37< zookeeper> (if you don't mind pasting in an animation to the ancient lich and testing with that, anyway)
20170510 20:06:47< zookeeper> or anyone else who wants a peek: https://paste.ee/p/u5ojq it's nothing exceptionally fancy, but i'm kind of wondering whether the spot it hits between "cinematic" and "short" is a sweet spot or a bad spot.
20170510 20:10:21< DeFender1031> zookeeper, sure.
20170510 20:13:20< DeFender1031> a dying lich in the middle of my opening ceremony makes for an interesting scene...
20170510 20:14:07< celticminstrel> XD
20170510 20:15:38< DeFender1031> can [animation] be put directly into a unit definition?
20170510 20:15:56< celticminstrel> Yes.
20170510 20:16:01< zookeeper> where else?
20170510 20:17:54< DeFender1031> wrapped in [modifications][object]
20170510 20:18:04< DeFender1031> hmm... it seems to be playing a normal fade out..
20170510 20:18:28< DeFender1031> there doesn't seem to be anything giving it higher priority than the normal fade out.
20170510 20:19:27< DeFender1031> and that's not the issue... for some reason it's just not playing here.
20170510 20:19:40< DeFender1031> okay, let me rephrase the question.
20170510 20:19:59< DeFender1031> when I place a unit, using [unit], can [animation] be stuck in there?
20170510 20:20:41< zookeeper> no
20170510 20:20:47< zookeeper> i'll write an easier testcase
20170510 20:21:00< celticminstrel> Uh, let me check.
20170510 20:21:47< DeFender1031> whatever, i'm wrapping it in an object.
20170510 20:22:01< celticminstrel> Okay yeah, [animation] only works in [unit_type], not [unit].
20170510 20:22:18< DeFender1031> yeah, still didn't work for some reason.
20170510 20:22:28< DeFender1031> zookeeper, i'll await your testcase.
20170510 20:23:52-!- Kwandulin [~Kwandulin@p200300760F6D803DA14702C3BE550BD3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20170510 20:24:24< celticminstrel> So, is there any way for a widget to check if its window has focus?
20170510 20:24:31< celticminstrel> ie, whether its window is the front window.
20170510 20:25:23-!- irker338 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20170510 20:26:53< zookeeper> DeFender1031, try this: https://paste.ee/p/4w5Mh
20170510 20:27:14< zookeeper> but kill it from nw,n,ne since for some reason the vertical flipping happens differently with this one
20170510 20:28:10< DeFender1031> won't that be a problem in actual usage then?
20170510 20:28:58< zookeeper> uh, of course wrong kind of flipping is a problem in actual usage
20170510 20:29:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20170510 20:29:08< DeFender1031> zookeeper, also, I was killing it using [kill]animate=yes
20170510 20:30:49< DeFender1031> okay, the new exaple worked.
20170510 20:30:54< DeFender1031> wow. I really like it.
20170510 20:31:14< DeFender1031> No hand as I would have done, but it's nice.
20170510 20:31:49< zookeeper> the blurry poof isn't too sauron'ish either? :p
20170510 20:32:02-!- JyrkiVesterinen [~JyrkiVest@87-100-225-122.bb.dnainternet.fi] has quit [Quit: .]
20170510 20:32:47< DeFender1031> and if it is?
20170510 20:33:05< DeFender1031> The description was based heavily on sauron as I understand.
20170510 20:34:25< DeFender1031> zookeeper, http://esr.ibiblio.org/?p=3173&cpage=4 "the description I wrote for the death of the lich Mal-Ravanal at the end of Eastern Invasion consciously echoes the death of Sauron in The Return of The King"
20170510 20:34:41< zookeeper> well, yeah
20170510 20:35:19< DeFender1031> anyway, one thing I'd say is that the pink flame or whatever it is right when the lich disappears and the smoke starts seems too quick.
20170510 20:38:19< DeFender1031> Otherwise, looks really good. I like how it expands and fades as it rises.
20170510 20:38:46< DeFender1031> The hand thing could still be added to this in theory.
20170510 20:38:51< DeFender1031> But it may be unnecessary.
20170510 20:38:56< DeFender1031> This is really good.
20170510 20:40:41< zookeeper> it would be really difficult to shape this smoke into a hand, so i'll skip that
20170510 20:44:31< DeFender1031> Yeah, I wouldn't use that smoke for it. I'd probably IPF the heck out of something else.
20170510 20:48:14< zookeeper> anyway, i'll see if i can make the disappearance poof a bit slower in the beginning
20170510 20:48:56< celticminstrel> Apparently I was talking to mattsc in the wrong channel, huh.
20170510 20:49:31< DeFender1031> celticminstrel, oh, I thought you were doing that on purpose so that there wouldn't be two conversations happening here at the same time.
20170510 20:49:50< celticminstrel> Oh. Well, I suppose that's a somewhat reasonable reason.
20170510 20:50:03< celticminstrel> But in fact it was just chance.
20170510 20:50:14< celticminstrel> I happened to have that channel active when he joined and wasn't really paying attention.
20170510 20:50:19< mattsc> celticminstrel: that’s why I asked you about that in the PM
20170510 20:50:37< celticminstrel> ...and I didn't see the PM because I had some old log-files open.
20170510 20:53:55< DeFender1031> Haha
20170510 20:57:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20170510 21:00:17< celticminstrel> DeFender1031: Did you say you were going to add Lua API access to the string split functions so that we don't have to have multiple implementations of the same thing?
20170510 21:01:12< DeFender1031> I need to write the darn thing first before I figure out how to make it lua-accessible.
20170510 21:01:32< DeFender1031> I think I said it was probably a good idea to do so.
20170510 21:01:43< DeFender1031> I vaguely recall it having come up
20170510 21:13:07-!- markus_ [~mjs-de@x4db5cc22.dyn.telefonica.de] has quit [Quit: On the road again]
20170510 21:14:28-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 245 seconds]
20170510 21:21:10-!- minbonbon [~min@meta23.net] has quit [Ping timeout: 240 seconds]
20170510 21:21:48-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20170510 21:22:08< DeFender1031> https://wiki.wesnoth.org/InterfaceActionsWML#.5Bchange_theme.5D this is interesting
20170510 21:22:25< DeFender1031> zookeeper, vultraz_iOS, we were talking about this at some point.
20170510 21:22:35< DeFender1031> I didn't realize it already existed.
20170510 21:23:13< DeFender1031> I still think that a fade from one to the other (or an option to do so) would be really nice.
20170510 21:23:20< celticminstrel> I added it recently.
20170510 21:23:46< celticminstrel> A fade sounds really hard.
20170510 21:23:52-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20170510 21:27:21< DeFender1031> I know.
20170510 21:27:38< DeFender1031> I said it'd be cool, I didn't say it'd be easily doable.
20170510 21:28:13< DeFender1031> hmm... https://wiki.wesnoth.org/InterfaceActionsWML#.5Bstory.5D it's now possible to jump to the story screen mid-scenario?
20170510 21:29:50< DeFender1031> that's pretty cool actually, if it does what I think it does. you can have, for example, a two-part scenario where the first part is to get to a certain place and the second part is to defend it, have the story screen in the middle, and still have your units where they were before.
20170510 21:34:50-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20170510 21:34:56-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20170510 21:49:35< DeFender1031> celticminstrel, still around?
20170510 21:51:52< DeFender1031> celticminstrel, the list we talked about: http://paste.nachsoftware.com/DeFender1031/nXrsj9c3d862a4d4d11244b9a59138b684ceffYr
20170510 21:52:42< DeFender1031> these are the times when a redraw should happen during an event, and any other times when it happens will cause issues.
20170510 21:53:39< DeFender1031> Also, once that's done, any time anything is added, the same rules should be followed: redraw right before a dialog or delay of some sort and after initializing the first frame of an animation AND NO OTHER TIME.
20170510 21:53:57< DeFender1031> s/anything/any new WML actions or Lua functions
20170510 22:05:32< DeFender1031> Also, there may be some Lua situations I missed, since those aren't documented in as organized a fashion as action WML is. The pattern I'm defining here should be clear though.
20170510 22:17:48< celticminstrel> I think most of the things on that list I would actually implement in the Lua API that the tags are implemented in terms of.
20170510 22:19:53< celticminstrel> I'm not sure I can manager "after the first frame of ...".
20170510 22:19:55< celticminstrel> ^manage
20170510 22:20:14< celticminstrel> On the other hand, that might already trigger a redraw anyway.
20170510 22:22:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20170510 22:23:24< DeFender1031> hmm...
20170510 22:23:32< DeFender1031> the "after the first frame" part is important
20170510 22:24:00< DeFender1031> and yes, it makes sense to implement the redraws at whatever the lowest-level of abstraction that causes the given behavior is.
20170510 22:24:46< celticminstrel> "before the first frame" wouldn't be sufficient?
20170510 22:25:05< DeFender1031> i'm not sure if the animate does a full redraw. I was under the impression that that was localized to areas of the screen where the animation is taking place, but I could be wrong.
20170510 22:25:12< DeFender1031> nope.
20170510 22:25:29< DeFender1031> that'd lead to the same kind of issues that sparked the conversation yesterday
20170510 22:25:37< celticminstrel> It's quite possible that it's localized as you say.
20170510 22:25:45< celticminstrel> It would?
20170510 22:26:23< DeFender1031> yep. for exmaple, if someone does, say, an [unstore_unit] followed by an [animate_unit] with the teleport_in flag, the unit would flicker there for a moment
20170510 22:26:46< DeFender1031> that's why the "first frame" thing is important.
20170510 22:27:03< DeFender1031> likewise, the LAST frame of an animation should persist until the next redraw for the same reason.
20170510 22:27:12< celticminstrel> So I guess no redraw at all would also not be sufficient?
20170510 22:27:29< DeFender1031> for example, [animate_unit] with "death" followed by a [kill] should not flicker the unit back on in between.
20170510 22:28:00< DeFender1031> no redraw at all would be sufficient if the animation code itself would correct any parts of the screen that are no longer up-to-date.
20170510 22:28:11< DeFender1031> if that's not the case, then yeah, that'd be an issue too.
20170510 22:29:29< DeFender1031> ultimately, what I'm aiming for here is that the screen only gets updated when something is actually supposed to occur on it, and otherwise stays in whatever state it was last in when the last thing that occurred on the screen occurred.
20170510 22:30:20< DeFender1031> which is logically the optimal arrangement for screen updates, and also makes sure to avoid issues from redraws occurring during actions which have nothing to do with the screen.
20170510 22:30:32< celticminstrel> ...I just got an out of memory error? o.o
20170510 22:30:33< DeFender1031> I hope I'm articulating my point well.
20170510 22:31:07< DeFender1031> that's... odd. Did you get stuck in either an allocation or a recursion loop?
20170510 22:31:25< celticminstrel> No idea!
20170510 22:32:07< celticminstrel> Seems like it might be related to a syntax error in a core file though...
20170510 22:34:29< DeFender1031> Anyway, am I making sense with my point about how screen updates should only happen when something is actually happening on the screen? I worry that I'm not articulating well. It's sometimes hard to get these concepts across via text-only communication.
20170510 22:34:39< celticminstrel> I think I get it?
20170510 22:35:05< DeFender1031> Okay.
20170510 22:36:30< DeFender1031> I really hope it turns out that the animation code does currently do a full redraw on the first frame. If it doesn't, that'll cause issues.
20170510 22:36:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20170510 22:36:49< DeFender1031> I do know that there were fewer rogue-redraw-related issues in 1.12 than there are currently.
20170510 22:37:32< DeFender1031> And it'd obviously be nice if there were no such issues.
20170510 22:38:06< celticminstrel> I can't get a stack trace for the bad_alloc...
20170510 22:38:18< celticminstrel> It seems to occur while parsing Lua though...
20170510 22:40:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170510 22:45:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20170510 22:50:22< celticminstrel> ...and now it mysteriously disappeared just by attempting to step through the code and locate it.
20170510 22:57:22-!- irker504 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20170510 22:57:22< irker504> wesnoth: Celtic Minstrel wesnoth:master 6000d644d86d / src/scripting/ (game_lua_kernel.cpp lua_common.cpp lua_common.hpp): Add a second version of luaW_type_error https://github.com/wesnoth/wesnoth/commit/6000d644d86d17d1335df302ca7e215097a989bb
20170510 22:57:22< irker504> wesnoth: Celtic Minstrel wesnoth:master 37f1c490a5ff / data/ (4 files in 2 dirs): Lua: Use the second argument to error() where appropriate https://github.com/wesnoth/wesnoth/commit/37f1c490a5ffcc4c64a020d62a6aa042ea9b416d
20170510 22:57:23< irker504> wesnoth: Celtic Minstrel wesnoth:master 9b635994e18d / data/ (3 files in 3 dirs): Add location_set.(of|to)_triples (migrated from ai_helper) https://github.com/wesnoth/wesnoth/commit/9b635994e18d3438dcc37fe5acc7c89174ec4b38
20170510 22:57:24< irker504> wesnoth: Celtic Minstrel wesnoth:master a98a9a74db89 / data/lua/helper.lua: Deprecate helper.distance_between and implement helper.adjacent_tiles in https://github.com/wesnoth/wesnoth/commit/a98a9a74db89e9063264490cde2b318a10e11785
20170510 22:57:25< irker504> wesnoth: Celtic Minstrel wesnoth:master 2f0a6d13e4e3 / data/ (lua/wml/animate_unit.lua scenario-test.cfg): Make [animate_unit] without flag an error (fixes #1678) https://github.com/wesnoth/wesnoth/commit/2f0a6d13e4e3bfe931cdb3d3d341d903507ddca4
20170510 22:57:26< irker504> wesnoth: Celtic Minstrel wesnoth:master 1623efb66c2a / src/units/ (abilities.cpp unit.hpp): Add more documentation to the unit class and use Doxygen groups. https://github.com/wesnoth/wesnoth/commit/1623efb66c2a94623aa763e7eddc9ce220675d8c
20170510 22:57:28< irker504> wesnoth: Celtic Minstrel wesnoth:master b04894fbf3a4 / src/units/unit.hpp: Use perfect forwarding for unit::add_attack https://github.com/wesnoth/wesnoth/commit/b04894fbf3a4e2958ed3ec445024a8b77d3b55d4
20170510 22:57:30< irker504> wesnoth: Celtic Minstrel wesnoth:master 6846506860b9 / src/ (5 files in 2 dirs): Lua Units: Add animations key which returns a list of animations defined https://github.com/wesnoth/wesnoth/commit/6846506860b98ae790dd1368a7c10b0adb3392a4
20170510 22:57:32< irker504> wesnoth: Celtic Minstrel wesnoth:master f6c04e7dd17e / data/ (ai/lua/ai_helper.lua lua/functional.lua): Add functional.lua which implements higher-order functions https://github.com/wesnoth/wesnoth/commit/f6c04e7dd17e66600d8eafcc36c3f9abaff9d908
20170510 22:57:34< irker504> wesnoth: Celtic Minstrel wesnoth:master 0539a68eb4f6 / data/ (3 files in 3 dirs): Migrate ai_helper.LS_random_hex to location_set:random https://github.com/wesnoth/wesnoth/commit/0539a68eb4f6e5b69fbe9a298a0a03e87d81e56a
20170510 22:57:36< irker504> wesnoth: Celtic Minstrel wesnoth:master 396de6721130 / src/scripting/lua_common.cpp: Lua: Allow using the length operator on translatable strings https://github.com/wesnoth/wesnoth/commit/396de6721130db19a10ff3a9b9aa8de04a52c752
20170510 22:57:38< irker504> wesnoth: Celtic Minstrel wesnoth:master 0ac01c762250 / data/lua/wml/set_variable.lua: Fix [set_variable][join] not working with translatable strings (fixes #1682) https://github.com/wesnoth/wesnoth/commit/0ac01c762250b8bbec3b3d40554cbfbd64e627c5
20170510 23:02:59< irker504> wesnoth: Celtic Minstrel wesnoth:master e2ebfa31f6b2 / src/scripting/game_lua_kernel.cpp: Add an extra error-checking case for targets in Lua animators https://github.com/wesnoth/wesnoth/commit/e2ebfa31f6b20eef25c7f45adc40444ceb25b31e
20170510 23:10:32< DeFender1031> Wall of commits.
20170510 23:21:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170510 23:28:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20170510 23:29:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20170510 23:45:30-!- atarocch [~atarocch@37.176.213.189] has quit [Remote host closed the connection]
20170510 23:46:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20170510 23:47:53-!- wedge009 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20170510 23:49:14-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-196.zoominternet.net] has joined #wesnoth-dev
20170510 23:54:37< celticminstrel> Yup.
--- Log closed Thu May 11 00:00:24 2017